platform/upstream/iotivity.git
9 years agoAdded Arduino Mega w/WiFi build to auto build process.
Patrick C Lankswert [Tue, 17 Feb 2015 18:35:44 +0000 (13:35 -0500)]
Added Arduino Mega w/WiFi build to auto build process.

Seung-Woo Lee found a problem with the build for Arduino Mega w/WiFi.
As a result, I am adding this to the build machine list to prevent
regression in the future.

Change-Id: Icdc9fd0ffd911c1bc9c1878f17ebb86010f2c2e1
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/359
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoRemoved Doxygen warnings caused by improper formatting of several headers
William Dieter [Fri, 27 Feb 2015 04:58:06 +0000 (23:58 -0500)]
Removed Doxygen warnings caused by improper formatting of several headers

OCResource.h and OCPlatform.h had a number of methods where improperly
documented.  They had:

* Incorrect parameter names for a several methods,

* Missing documentation for overloaded methods,

* Where only one overload was documented, often the documentation was
  attached to the wrong overloaded method,

* Improper capitalization, and

* Formatting that impairs readability of Doxygen HTML documentation.

This commit addresses those issues.

Change-Id: I4536964afe91f4278810fe2d71f0cf74cf7a78b7
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/417
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoUpdated Doxygen config.
Jon A. Cruz [Thu, 5 Mar 2015 06:15:11 +0000 (22:15 -0800)]
Updated Doxygen config.

Removed deprecated items. Enabled Javadoc style auto-brief. Fixed tab settings.

Change-Id: Ia002ccdc9ce86de6c36c8aeb5fd3b6d7c70f5864
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/440
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: William Dieter <william.r.dieter@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years ago[PPM] Modify Protocol Plugin Manager for Android platform
Younghyun Joo [Mon, 2 Mar 2015 10:10:29 +0000 (19:10 +0900)]
[PPM] Modify Protocol Plugin Manager for Android platform

1. Modify FelixAdapter for android support
2. Modify PluginManagerImpl to use FelixAdapter

Change-Id: I14481ddd75913e3eeddef00febd1e8f1c2476aef
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/423
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: yunhee.hwang <yunhee.hwang@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoUpdated tinyDTLS test apps to use identity hint
Sachin Agrawal [Thu, 26 Feb 2015 17:28:56 +0000 (09:28 -0800)]
Updated tinyDTLS test apps to use identity hint

dtls-server test is updated to pass 'psk hint' to tinyDTLS library so that
it can send ServerKeyExchange packet. Similarly, dtls-client test
is updated to retrieve PSK specific for the server whose identity was
received via 'psk hint' packet.

Change-Id: Ifba720f1505ed6afbf56dfc179d98790176ce0b0
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/348
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Seung-Woo Lee <sw0524.lee@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoCheck if C/C++ compiler is installed
Caiwen Zhang [Tue, 10 Feb 2015 09:10:27 +0000 (17:10 +0800)]
Check if C/C++ compiler is installed

If C/C++ compiler isn't installed, notify user to install it.

Change-Id: I58ad124139a2b454dcd8100b14d5ed23a8065144
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/322
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoRemoved unneeded references to oic-utilities
William Dieter [Fri, 27 Feb 2015 15:11:38 +0000 (15:11 +0000)]
Removed unneeded references to oic-utilities

The oic-utilities repo was used as a temporary solution for holding third
party libraries.  The build system now has a better way to handle them.
This commit removes obsolete instructions to copy the oic-utilities repo
from the scons build instructions.

The resource/csdk/README.txt file still has a reference to oic-utilties,
as do some of the old release notes files.  The csdk README can probably
be deleted when makefiles are eliminated.

Change-Id: Ic5824264835359a59cfd79443ce4e773205eeb07
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/420
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
9 years agoDo not explicitly add "-fPIC" to the compiler command line.
Ossama Othman [Mon, 23 Feb 2015 18:45:26 +0000 (10:45 -0800)]
Do not explicitly add "-fPIC" to the compiler command line.

There is no need to explicitly add "-fPIC" to the compiler command
line since the SCons SharedLibary builder will automatically add it.
This change also addresses a problem where position independent code
was unnecessarily and incorrectly generated for static libraries.
IoTivity resource related static libraries are now smaller and code is
more efficient as result of removing "-fPIC" from static library
generation since the indirection that accompanies position independent
code no longer exists (for those static libraries).

Change-Id: I6cf57713d97b62f873ded4f4728fbb5e77e28ca6
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/399
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoReorder library link order for mqttclient to address link error.
Ossama Othman [Mon, 23 Feb 2015 18:34:20 +0000 (10:34 -0800)]
Reorder library link order for mqttclient to address link error.

An unresolved symbol error for pthread_create() occurred during the
Linux mqttclient sample app link phase.  Move the pthread library to
end of the linker command line so that the missing symbol can be
resolved for libraries that depend on it.

Generally, libraries that depend on specific libraries should appear
earlier in the linker command line. For example, if libfoo depends on
libpthread, the library command line should look something like:

  g++ bar.c -lfoo -lpthread

This doesn't matter as much for dynamically linked libraries since the
inter-library dependency is embedded into the shared library itself,
but order does matter when statically linking.

Change-Id: I6ac40dde39930501458e16624052ab934503e27f
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/398
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years ago[SSM] Fix IOT-332, 333, 334 issues
Minji Park [Fri, 27 Feb 2015 05:58:00 +0000 (14:58 +0900)]
[SSM] Fix IOT-332, 333, 334 issues

Modify SSM java Interface and Android sample app

1. Fix IOT 332, unregister queries continuously

2. Fix IOT 333, handling exception when registering an empty query

3. Fix IOT 334, handling exception when registering invalid queries

Change-Id: Ie4bb94c19634c18f6484313de16a49c1ac5f46d1
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/418
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years ago[SSM] Fix IOT-322, 323 issues
jk13 [Fri, 27 Feb 2015 01:21:38 +0000 (10:21 +0900)]
[SSM] Fix IOT-322, 323 issues

1. Fix IOT 322, duplicated callback if query contains
   multiple 'and' operation to one resource
2. Fix IOT 323, init-term exceptional case

Change-Id: If78af1060c905c52c36aa6cdbf01af1f8a11db73
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/416
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years ago[PPM] Set the Iotivity Code Format
Younghyun Joo [Mon, 23 Feb 2015 09:38:23 +0000 (18:38 +0900)]
[PPM] Set the Iotivity Code Format

1. Excute the format script

Change-Id: I2aa09fcec6a4641dea44fbffbd6692e0deadf86a
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/397
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: yunhee.hwang <yunhee.hwang@samsung.com>
9 years agoRemoved non-existent files from Doxyfile to reduce number of warnings
William R. Dieter [Wed, 25 Feb 2015 03:38:03 +0000 (22:38 -0500)]
Removed non-existent files from Doxyfile to reduce number of warnings

The files removed from the Doxyfile do not exist in the repo.  I have
removed them to remove warnings that they do not exist.

Change-Id: I7d8eb26c69426ad1595c42f4bbd27f3f897d3095
Signed-off-by: William R. Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/408
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
9 years agoReplaced tinyDTLS ecc with micro-ecc
Randeep Singh [Fri, 13 Feb 2015 06:07:54 +0000 (15:07 +0900)]
Replaced tinyDTLS ecc with micro-ecc

Please refer https://github.com/kmackay/micro-ecc with
version 98e1f208cfde43f65b6263dde6fca1a194bb6543 for
micro-ecc source code used in this implementation.

Change-Id: Icacd21ff24a7afce524bf4b0f4b3429541161269
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/340
Reviewed-by: Seung-Woo Lee <sw0524.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoModified Rijndeal for Arduino Mega2560
Randeep Singh [Fri, 13 Feb 2015 05:34:27 +0000 (14:34 +0900)]
Modified Rijndeal for Arduino Mega2560
pre-computed values are stored in flash in case of Arduino to overcome Arduino Mega 2560's SRAM limitation

Change-Id: I05de1c47d8d8288be0f1c3cff8a870d15a5df411
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/339
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Seung-Woo Lee <sw0524.lee@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoClean up TODOs in OCUtilities
Erich Keane [Tue, 10 Feb 2015 01:29:14 +0000 (17:29 -0800)]
Clean up TODOs in OCUtilities

The Escape String mechanism is no longer used anywhere, so it is
dead code.  The QueryParam parsing was only used in 1 place and the
initial non 'temp patch' function was all dead code.  This fix removes
both sets of dead code and cleans up the temp-patch code to be a little
more efficient.

Change-Id: I0777f5d5795362195e35bdffc82a6eed55850a91
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/320
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years ago[PPM] Fix sample plugins and sample app for Linux
Younghyun Joo [Mon, 23 Feb 2015 05:27:14 +0000 (14:27 +0900)]
[PPM] Fix sample plugins and sample app for Linux

1. Modify sample plugins for Linux: mqtt-fan, mqtt-light
2. Modify sample app for Linux

Change-Id: I6bb156b9288ce13ba98ec3b3b02a084f4fcf5919
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/395
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: yunhee.hwang <yunhee.hwang@samsung.com>
9 years agoAdded resource/include/OCRepresentation.h to Doxyfile
William Dieter [Tue, 17 Feb 2015 04:52:13 +0000 (23:52 -0500)]
Added resource/include/OCRepresentation.h to Doxyfile

OCRepresentation is passed as a paramter to documented API calls, so
presumably, it should be part of the public, documented API.

Change-Id: Ia17813b8ade749d0446d1ed4068f7e49d60d6ec4
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/351
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoGuard against spurious wakeups in devicediscoveryserver.cpp
William Dieter [Tue, 17 Feb 2015 06:45:00 +0000 (01:45 -0500)]
Guard against spurious wakeups in devicediscoveryserver.cpp

Like most condition variable implementations, std::condition_variable may
wake up spuriously, even though it is not signalled (see
http://en.cppreference.com/w/cpp/thread/condition_variable/wait).  Since
the intention of blocking on the std::condition_variable in main is to
wait forever, add a loop to block again after spurious wakeups.

Change-Id: I97e89a1ec95d6ba65eeb7daff861ee0a65d03a7e
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/357
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoGuard against spurious wakeups in devicediscoveryclient.cpp
William Dieter [Tue, 17 Feb 2015 05:41:32 +0000 (00:41 -0500)]
Guard against spurious wakeups in devicediscoveryclient.cpp

Like most condition variable implementations, std::condition_variable may
wake up spuriously, even though it is not signalled (see
http://en.cppreference.com/w/cpp/thread/condition_variable/wait).  Since
the intention of blocking on the std::condition_variable in main is to
wait forever, add a loop to block again after spurious wakeups.

Change-Id: I19b7ee13650b9b80250f935e2099119611fa61b3
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/355
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoAdded documentation for OCRepresentation::getValue
William Dieter [Tue, 17 Feb 2015 05:34:52 +0000 (00:34 -0500)]
Added documentation for OCRepresentation::getValue

Change-Id: I832fa198bfc3e3fe633531c3bf67d0c1421b47da
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/353
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoAutomatically detect C++11 flags for supported compilers.
Ossama [Thu, 22 Jan 2015 05:49:16 +0000 (21:49 -0800)]
Automatically detect C++11 flags for supported compilers.

This patch set allows the required C++11 command line flags to
be automatically set earlier in the build process.  Currently
only gcc is supported, but adding support for other compilers
is straightforward.  Furthermore, changes are for the most part
isolated to the new `iotivityconfig' python package.  There should
be no need to update SConscript files found throughout the
iotivity source tree.

Change-Id: I4ba0f6712e4a56a1a97630e511e9aabfdcd9e349
Signed-off-by: Ossama <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/240
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoFormalized the Arduino builds' generation of linker maps
Patrick C Lankswert [Fri, 13 Feb 2015 20:46:40 +0000 (15:46 -0500)]
Formalized the Arduino builds' generation of linker maps

Change-Id: If832e3e94de96c0b14b2c49c302dd21d1736ccbf
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/344
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
9 years agoFix build error of SimpleClientServer for Wifi
Seung-woo Lee [Fri, 13 Feb 2015 03:45:52 +0000 (12:45 +0900)]
Fix build error of SimpleClientServer for Wifi

Due to absence of "Wifi" macro definition, a build error
appears for arduino with argument of "NET=Wifi"

Change-Id: Ie5acd09b0d54ed8af165f48302fa351182c679e3
Signed-off-by: Seung-woo Lee <sw0524.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/337
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoUpdated Doxygen @param for OCResourceResponse::setResourceRepresentation
William Dieter [Tue, 17 Feb 2015 04:53:35 +0000 (23:53 -0500)]
Updated Doxygen @param for OCResourceResponse::setResourceRepresentation

The parameter was updated in a previous commit without updating the
Doxygen comments.

Change-Id: Ia6fc35d7a7ad8c6fd8a0d076aa21915813fe2820
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/352
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
9 years ago[SSM] Modify ommited arduino sample and soft sensor sample
jk13 [Fri, 9 Jan 2015 07:14:17 +0000 (16:14 +0900)]
[SSM] Modify ommited arduino sample and soft sensor sample

1. Modify Arduino indoor trajectory reference sensor
2. Modify indoor trajectory soft sensor for tizen

Change-Id: If83113c4564d894c8d740ecc357999acabc29f46
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/109
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years ago[SSM] Fix console sample
jk13 [Mon, 16 Feb 2015 03:50:01 +0000 (12:50 +0900)]
[SSM] Fix console sample

1. Fix sample application while reading query string from console

Change-Id: I90076ad0711ce165293a4db159e5796f1b7c93ee
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/347
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years ago[SSM] Fix Tizen sample and soft sensor declaration
jk13 [Fri, 13 Feb 2015 00:25:04 +0000 (09:25 +0900)]
[SSM] Fix Tizen sample and soft sensor declaration

1. Fix Tizen sample to load description and so from specific location
2. Fix Soft Sensor declaration to support which built under Tizen IDE

Change-Id: I73bdc793c5b1b6e100e9af36aca9503be9522b3e
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/335
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoFix runtime error of ThingsManager API.
HyunJun Kim [Thu, 12 Feb 2015 07:09:59 +0000 (16:09 +0900)]
Fix runtime error of ThingsManager API.

Some API and examples show runtime errors.
So we fixed runtime errors and issues.

Fix [IOT-324], [IOT-326], [IOT-336], [IOT-337]

Change-Id: I0f71b3a2243e4856203140aae71db473f4fa32ad
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/330
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoFix missing of 'TB_LOG' in SConscript of ocserver
Seung-woo Lee [Wed, 11 Feb 2015 07:21:20 +0000 (16:21 +0900)]
Fix missing of 'TB_LOG' in SConscript of ocserver

The defining of 'TB_LOG' is missing when building ocserver
for debug. It results in no serial output because log macro
functions like OC_LOG_INIT were redefined as nothing

Change-Id: I25881d16a2a7fefb17dd79c4349353c9befede77
Signed-off-by: Seung-woo Lee <sw0524.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/324
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoImprove external library management error handling
Caiwen Zhang [Thu, 12 Feb 2015 02:31:49 +0000 (10:31 +0800)]
Improve external library management error handling

Change-Id: I2a0b7003f0bd2987fa101285977fa0621688017b
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/327
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoAdd auto download cereal library support
Caiwen Zhang [Thu, 12 Feb 2015 05:30:43 +0000 (13:30 +0800)]
Add auto download cereal library support

Change-Id: Iab0fe5ca9c64849d215dfcf1ec99a4f834cb26f8
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/328
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoImplement [] and iteration for OCRepresentation
Erich Keane [Wed, 7 Jan 2015 21:09:55 +0000 (13:09 -0800)]
Implement [] and iteration for OCRepresentation

Multiple requests have come in to be able to access the contents
of OCRepresentation in an easier to use manner.  This fix allows
OCRepresentation to be indexed using the [] operator and also
be iterated in an STL compliant fashion.

Additionally, this adds more than 40 tests for this functionality

Change-Id: Ibfc4bc61493324e118c4a6b67efc1d66e8b66b04
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/116
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
9 years agoImprove usability of Group Interface API.
HyunJun Kim [Mon, 9 Feb 2015 08:09:45 +0000 (17:09 +0900)]
Improve usability of Group Interface API.

GetActionSetFromString function has memory leak.
So we fix memory leak and improve usability of the function.

We call two function, ExtractKeyValueFromRequest and BuildActionSetFromString
to extract key and value from requset and get ActionSet object from string.

Fix [IOT-283]

Change-Id: Ie13dcd0afc168632d9a53ad27182d15a55c3aca0
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/308
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoAdded comment to the OCRepresentation fix
Erich Keane [Mon, 9 Feb 2015 17:59:48 +0000 (09:59 -0800)]
Added comment to the OCRepresentation fix

A build issue is seemingly causing a crash for the Android API
implementation, so the constructors/destructors were all placed
in the .h file.  This commit adds a comment explaining that to the
OCRepresentation code.

Change-Id: I22d0e2a374ea82165d0d7914ebfd2748b5f59c60
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/318
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoAdd external package management support
Caiwen Zhang [Tue, 3 Feb 2015 09:01:51 +0000 (17:01 +0800)]
Add external package management support

Some methods are added to manage external packages:
  'PrepareLib': checks the existence of an external library, if it
doesn't exist, calls the script user provided to download(if required)
and build the source code of the external library or notify user to
install the library.
  'Download': download package from specify URL
  'UnpackAll': unpack the package
  'Configure': execute specify script(configure, bootstrap etc)
  'InstallHeadFile': install head files
  'InstallLib': install library binaries(.so, .a etc)

Change-Id: Ibf3ef58abf8ba5a466b82a341bb6dce83d61726e
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/138
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoAdd missing LICENSE and NOTICE file to repository.
Patrick C Lankswert [Mon, 2 Feb 2015 15:50:39 +0000 (10:50 -0500)]
Add missing LICENSE and NOTICE file to repository.

Change-Id: Ib47076ee53884cb4bd87cc822dff0437ca1deb9e
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/283
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Fred Cooper <fred.cooper@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
9 years ago[SSM] Upload Tizen sample for 2.3 public sdk IDE
jk13 [Fri, 6 Feb 2015 05:34:40 +0000 (14:34 +0900)]
[SSM] Upload Tizen sample for 2.3 public sdk IDE

1. Change existing Tizen gbs sample app
   to using Tizen 2.3_rev1 IDE env

Change-Id: I12977bcd4de66d925f6e98f5382f1227d218c72c
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/313
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoAdding OCRep destructor, various move activities
Erich Keane [Wed, 4 Feb 2015 20:08:26 +0000 (12:08 -0800)]
Adding OCRep destructor, various move activities

Apparently OCRepresentation's destructor was causing issues
in the JNI version.  Seemingly adding a virtual destructor to
the OCRepresentation is enough to cause this to go away.

Also adding move construction/assignment to our more expensive
types.

Change-Id: Icb3b6f25e268384b51126e18ec55fc5099c9b2f9
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/305
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years ago[SSM] Fix SSM Sample App to handle invalid input for app menu (IOT-290)
Minji Park [Fri, 6 Feb 2015 06:07:46 +0000 (15:07 +0900)]
[SSM] Fix SSM Sample App to handle invalid input for app menu (IOT-290)

Modify SSM Linux Sample App to to prevent unexpected input values

Change-Id: Ic9de6e894a44a903f02d60f6eeaf0fa9035e0e5a
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/315
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years ago[SSM] Cleanup JNI dead code and add NDEBUG definition
jk13 [Fri, 6 Feb 2015 05:38:37 +0000 (14:38 +0900)]
[SSM] Cleanup JNI dead code and add NDEBUG definition

1. Cleanup JNI dead code
2. Add NDEBUG definition to SCONS script to prevent crash
   when assert

Change-Id: Ia4dc46548ce3bb0c9b4b28776e6c5f328444ab1a
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/314
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoAdded lock logic in findResource callback for C++ samples
Sudarshan Prasad [Tue, 13 Jan 2015 06:46:14 +0000 (22:46 -0800)]
Added lock logic in findResource callback for C++ samples

As part of Gerrit review #101,(83fed5a6c6b01d32de3e47c669652a1aa79ebb49)
there were changes required in other samples to prevent a crash in the
findResource callback.

Additionally, made minor correction in groupclient by changing
printf to cout in one of the function

Change-Id: I524f5d862c82011e5d008e686cc1d6e41ac3f170
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/126
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
9 years agoAdded Vagrant config files that will create a build VM
William Dieter [Thu, 4 Dec 2014 03:35:04 +0000 (22:35 -0500)]
Added Vagrant config files that will create a build VM

As described in the tools/vagrant/README.md, Vagrant can use the
configuration provided in this commit to provision a build VM for building
IoTivity.

Change-Id: Ic2ae5a7bfc9e4274aa76be99a0807517f89c94b8
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/88
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoFix problem for multiple api call
jjack.lee [Mon, 26 Jan 2015 04:59:03 +0000 (13:59 +0900)]
Fix  problem  for multiple api call

It is thread issue. So, add lock mechanism.
Fix [IOT-263]

Change-Id: Ic0fac30b1a4c0c305af607e5caa7c1afd21163b6
Signed-off-by: Jack Lee <jjack.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/243
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoFix an exception handling issue in con-client app.
Jihun Ha [Tue, 3 Feb 2015 08:12:37 +0000 (17:12 +0900)]
Fix an exception handling issue in con-client app.

Though con-client app do not discover configuration,
diagnostics, and factorySet collection resources in
a network, the con-client app can be proceded.
And even when a response for any GET/PUT request indicates
a bad request, it is correctly delivered to the app.

Reference issue ID : [IOT-291]

Change-Id: Ic101013daa6efea9639295553022fd67f58c925e
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/271
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoFix infinite loop in GroupAction.
HyunJun Kim [Tue, 3 Feb 2015 02:10:55 +0000 (11:10 +0900)]
Fix infinite loop in GroupAction.

Fix infinite loop in FindAndDeleteActionSet function.

So we change the code.

Fix [IOT-282]

Change-Id: I23d3663ea32c5e56a456b013d4c697fcf0f886d2
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/286
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
9 years agoAltered the .gitignore to properly ignore unittest build biproducts
Erich Keane [Fri, 30 Jan 2015 21:29:49 +0000 (13:29 -0800)]
Altered the .gitignore to properly ignore unittest build biproducts

gitignore wasn't ignoring the gtest install and hippomocks installed
components.

Cleaned whitespace for the unittests makefile, which had tons of
trailing whitespace issues.

Change-Id: I10c4505ddf56df6d34e972553f93531132d53af3
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/280
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: William Dieter <william.r.dieter@intel.com>
Reviewed-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoRelease notes for Feb 1st release
Sudarshan Prasad [Mon, 2 Feb 2015 02:18:44 +0000 (18:18 -0800)]
Release notes for Feb 1st release

Change-Id: I046922a66eaa03b18482fb139986a439a49f568f
Signed-off-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/282
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
9 years agoFix API of ThingsManger.
HyunJun Kim [Mon, 2 Feb 2015 05:49:56 +0000 (14:49 +0900)]
Fix API of ThingsManger.

subscribeCollectionPresence and findCandidateResource are occurred exception or
no response(callback) while to combine resource type
when child resource doesn't have correct type name of resource.

In this case we don't combine the type of resource and
we will ignore.

Fix [IOT-289]

Change-Id: I59c48726a9738e34d6c5561b59a2cdda243168ec
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/277
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
9 years ago[SSM] Add android sample and fix jni issues.
jk13 [Fri, 30 Jan 2015 07:53:11 +0000 (16:53 +0900)]
[SSM] Add android sample and fix jni issues.

1. Add android sample application
2. Fix jni issues that mismatch of package name
   and Android-L jni callback issue
3. Fix scons script to build for creating SSM so file.

Change-Id: Ief192a96f6d97fd2ac4ad47b3e7d9029d964f2f6
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/278
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoApply the 'CA_INT' of Connectivity Abstraction for Things Manager.
HyunJun Kim [Mon, 26 Jan 2015 08:22:50 +0000 (17:22 +0900)]
Apply the 'CA_INT' of Connectivity Abstraction for Things Manager.

The Thing Manager does not prepare for the CA.
So we provide different function of CA in the same API.

Change-Id: I8b64608e352a19fddedf42beef647003d18e61f8
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/244
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoAdd API description of Things Manager.
HyunJun Kim [Thu, 29 Jan 2015 04:38:08 +0000 (13:38 +0900)]
Add API description of Things Manager.

joinGroup and findGroup function call were ambiguous
when join to a local(or remote) resource.
We provide more detail description of function for the user.

Fix [IOT-265],[IOT-267]

Change-Id: I43de1f6671dc73d0725bdc9c0e85ffca45878d2e
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/245
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoexample: link to libraries using -L flag
Philippe Coval [Mon, 26 Jan 2015 10:08:48 +0000 (11:08 +0100)]
example: link to libraries using -L flag

executable will be able to load them
from standard paths (/usr/lib*/)

Change-Id: I0728c196b766ce55e7185dffb69d9790b5b065c5
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/246
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoResolved Klocwork warnings for C++ Stack & Samples
Shilpa Sodani [Wed, 14 Jan 2015 23:56:47 +0000 (15:56 -0800)]
Resolved Klocwork warnings for C++ Stack & Samples

Fixed comment, space issue and added default case to switch in
groupclient.cpp

Made code compliance to code guideline

Resolve Infinite loop warning and Memory leak warning.
Also replaced multiple if-else with switch to match code
standards.

Change-Id: I125ab9d20fe4c8352f261afa7a538a7487aa7880
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/141
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoAdded support in tinyDTLS to support rehandshake
Sachin Agrawal [Wed, 21 Jan 2015 16:55:45 +0000 (08:55 -0800)]
Added support in tinyDTLS to support rehandshake

As per RFC 6347 section 4.2.8, DTLS Server should support requests
from clients who have silently abandoned the existing association
and initiated a new handshake request by sending a ClientHello.
Code is updated to detect this scenario and delete the old
association when client successfully responds to HelloVerifyRequest.

Change-Id: I6e256921215c1a22e9e5013499c4dfd98659f8cc
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/120
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoFix FindGroup API of Things Manager about group sync feature.
HyunJun Kim [Fri, 23 Jan 2015 05:00:54 +0000 (14:00 +0900)]
Fix FindGroup API of Things Manager about group sync feature.

It is not notify about state of finding to caller.
So we will return 'OC_STACK_ERROR' when It was finding a group.
User should be wait findCallback.
Then user will know the result of finding.

FindCallback has the argument which OCResource.
If it is NULL we could not find a group.

Fix [IOT-286]

Change-Id: I2b95d5102e54e4242394c36d51de81f192b87e13
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/230
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoFix GroupSync API of about GroupSync of Group feature.
HyunJun Kim [Fri, 23 Jan 2015 04:15:09 +0000 (13:15 +0900)]
Fix GroupSync API of about GroupSync of Group feature.

Crash is occured when som api of ThingsManager is called multiple times.

Fix [IOT-261], [IOT-264], [IOT-268]

Change-Id: Iec1cb11c570357411351c69450ace91ea6fa3754
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/228
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years ago[SSM] Fix issue about initializing SSM with invalid parameter (IOT-260)
Minji Park [Fri, 23 Jan 2015 02:05:32 +0000 (11:05 +0900)]
[SSM] Fix issue about initializing SSM with invalid parameter (IOT-260)

Modify SoftSensorManager to return error code when initialized with invalid parameter

Change-Id: Ia0a54cd6e71321cbe2b4fd18352a2a609c20fabd
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/229
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
9 years agoFixed issue to pass PSK identity hint to application in callback
Sachin Agrawal [Tue, 20 Jan 2015 23:58:45 +0000 (15:58 -0800)]
Fixed issue to pass PSK identity hint to application in callback

In cases (with PSK ciphersuite) where Server is sending
'PSK Identity Hint’ inside ServerKeyExchange message, DTLS library
is not passing the â€˜identity hint’ inside â€˜desc’ argument in
get_psk_info(DTLS_PSK_KEY, desc) callback. Instead, â€˜desc’ contains
the identity of the client itself. The reason for this is that the
code inside dtls_send_client_key_exchange() method
overwrites the â€˜identity hint’ received earlier.

Change-Id: Ibf447e3a6b33284118908a52aed4cf636038ab23
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/119
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoResolve Bug IOT-273 (rename "OC_STACK_REPEATED_REQUEST")
ywsung [Wed, 21 Jan 2015 03:54:20 +0000 (12:54 +0900)]
Resolve Bug IOT-273 (rename "OC_STACK_REPEATED_REQUEST")

 - OCStackResult "OC_STACK_REPEATED_REQUEST" is renamed to
   "OC_STACK_DUPLICATE_REQUEST"
 - In StringConstants.h, "REPEATE_REQUEST" is rename to
   "DUPLICATE_REQUEST" (Message string also changed)

Change-Id: Ie3bca4642441a59c3c66a98513d0f15d2e923096
Signed-off-by: ywsung <yw.sung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/177
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoFixed crash on rec'd invalid data.
Erich Keane [Mon, 12 Jan 2015 17:51:31 +0000 (09:51 -0800)]
Fixed crash on rec'd invalid data.

This issue is a fix for IOT 114.

Previously, a bad series of JSON coming in would cause an exception
to be thrown. this would result in the callback/server crashing, which
is not appropriate behavior. This fix catches and logs any JSON
errors keeping the callback/server from crashing.

NOTE: This changeset is originally from 01.org(changeset 695,
author: Erich Keane).

Change-Id: I1e7d042f243bc1b86771778c308f1187bcda875f
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/103
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
9 years agoEnable Building C++ samples using Scons
omkar [Tue, 20 Jan 2015 17:34:04 +0000 (09:34 -0800)]
Enable Building C++ samples using Scons

Change-Id: I4ebcee826bcd6f1afdea88038cd0ce340b209103
Signed-off-by: omkar <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/161
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agotizen: packaging: build on x86_64 arm64 and others too
Philippe Coval [Mon, 19 Jan 2015 18:09:28 +0000 (19:09 +0100)]
tizen: packaging: build on x86_64 arm64 and others too

Without this change only 2 arch were possible to build :
arm and x86 (32bits)

Since some scon's variables are not aligned with Tizen's infra name,
mapping is needed for x86 amd arm64.

While for x86_64 it can use the generic RPM macro %{_arch} value
which is same, it prevents writing an extra "if endif block".

Other unsuported arch were not tested (ie: mips, ppc ...)
and would  probably need more sources or make/scon/files adaptations.

With a couple of other fixes (to come later),
rpmbuild was successful using Tizen:Common's repos
with those archs : x86, x86_64, armv7l, aarch64.

Feel free to me ask support upstream or on tizen trackers

Change-Id: I1034d66ac29bee1667a7e12d6ceb9e08806c3a15
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/157
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
9 years agoMerge "Add missing enum value of OCStackResult to switch in reason() function of...
Sudarshan Prasad [Tue, 20 Jan 2015 17:32:22 +0000 (17:32 +0000)]
Merge "Add missing enum value of OCStackResult to switch in reason() function of OCException class"

9 years agoMerge "Improve usability of ActionSet for Group Action Feature."
Uze Choi [Tue, 20 Jan 2015 01:53:23 +0000 (01:53 +0000)]
Merge "Improve usability of ActionSet for Group Action Feature."

9 years agoAdded release notes for Jan 17th release
Sudarshan Prasad [Mon, 19 Jan 2015 00:35:30 +0000 (16:35 -0800)]
Added release notes for Jan 17th release

Change-Id: I62b1457e8a35082f7896fb5d64630a173c59f233
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>

9 years agoMerge "Fix zeroing of OCServerResponse payload array"
Sudarshan Prasad [Sat, 17 Jan 2015 00:37:39 +0000 (00:37 +0000)]
Merge "Fix zeroing of OCServerResponse payload array"

9 years agoMerge "Remove OCICUC from build and repo"
Sudarshan Prasad [Fri, 16 Jan 2015 22:59:14 +0000 (22:59 +0000)]
Merge "Remove OCICUC from build and repo"

9 years agoMerge "Enable building C Samples using scons"
Sudarshan Prasad [Fri, 16 Jan 2015 17:02:48 +0000 (17:02 +0000)]
Merge "Enable building C Samples using scons"

9 years agoAdd missing enum value of OCStackResult to switch in reason() function of OCException...
ywsung [Thu, 15 Jan 2015 07:30:54 +0000 (16:30 +0900)]
Add missing enum value of OCStackResult to switch in reason() function of OCException class

- Adding missing case of enum value (OC_STACK_REPEATED_REQUEST, OC_STACK_INVALID_DEVICE_INFO) to switch statement
- Adding constant strings to StringContant.h
- Reorder case statements by OCStackResult definition order

Change-Id: I207a2f9122779c37df48aae260061fce442de798
Signed-off-by: ywsung <yw.sung@samsung.com>
9 years agoEnable building C Samples using scons
Caiwen Zhang [Fri, 16 Jan 2015 07:12:52 +0000 (15:12 +0800)]
Enable building C Samples using scons

Change-Id: I9de4f80a0abe0cd1da14b2abb063e3deda928cba
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Signed-off-by: Caiwen Zhang <caiwen.zhang@intel.com>
9 years agoImprove usability of ActionSet for Group Action Feature.
HyunJun Kim [Fri, 16 Jan 2015 02:22:12 +0000 (11:22 +0900)]
Improve usability of ActionSet for Group Action Feature.

ActionSet structure is not show directly to developer.
Because there is the definition of ActionSet in GroupManager.h.
So we separate the definition of ActionSet from Groupmanager to ActionSet.h
And it is exposed to developer by one type of header file.

Change-Id: I2ccb93cf70ec42b122aaead4943aed56df161641
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
9 years agoRemove OCICUC from build and repo
Erich Keane [Thu, 15 Jan 2015 19:41:05 +0000 (11:41 -0800)]
Remove OCICUC from build and repo

The OCICUC library isn't properly being maintained and isn't really being
used, so it is being removed.

Signed-off-by: Erich Keane <erich.keane@intel.com>
Change-Id: I613072d5256fd53c6d7ef179cd971356caf18d41

9 years agoMerge "Remove high frequency log to avoid the log full with useless information"
Patrick Lankswert [Thu, 15 Jan 2015 03:35:25 +0000 (03:35 +0000)]
Merge "Remove high frequency log to avoid the log full with useless information"

9 years agoMerge "Adding tinyDTLS into iotivity repo"
Patrick Lankswert [Thu, 15 Jan 2015 03:22:55 +0000 (03:22 +0000)]
Merge "Adding tinyDTLS into iotivity repo"

9 years agoMerge "Reduce footprint by using string literals."
Sudarshan Prasad [Thu, 15 Jan 2015 01:21:13 +0000 (01:21 +0000)]
Merge "Reduce footprint by using string literals."

9 years agoMerge "Changed OCStackResult to be consistent across compile flags."
Sudarshan Prasad [Thu, 15 Jan 2015 01:02:29 +0000 (01:02 +0000)]
Merge "Changed OCStackResult to be consistent across compile flags."

9 years agoFix zeroing of OCServerResponse payload array
Maks Naumov [Wed, 14 Jan 2015 22:26:52 +0000 (14:26 -0800)]
Fix zeroing of OCServerResponse payload array

Change-Id: I93ba1720a3de0c54937d5d8d48d72574b2dbb65d
Signed-off-by: Maks Naumov <maksqwe1@ukr.net>
9 years agoChanged OCStackResult to be consistent across compile flags.
Erich Keane [Tue, 13 Jan 2015 21:39:57 +0000 (13:39 -0800)]
Changed OCStackResult to be consistent across compile flags.

Issue 245 was reported that pointed out that the presence flag in
the compiler makes OCStackResult incompatible across differently
compiled versions of the CStack.  Additionally, this spaces out the
error codes from success codes, permitting additional room for more
success codes.

Change-Id: Ia93f34e23756e7663ea80f6667699d59e358058e
Signed-off-by: Erich Keane <erich.keane@intel.com>
9 years agoMerge "Update gitignore."
Sudarshan Prasad [Wed, 14 Jan 2015 17:21:55 +0000 (17:21 +0000)]
Merge "Update gitignore."

9 years agoAdd method of Things-Manager.
HyunJun Kim [Wed, 14 Jan 2015 08:52:28 +0000 (17:52 +0900)]
Add method of Things-Manager.

It was not included implementation.
So We implement about bindResourceToGroup for Group Formation feature.

Change-Id: Iade53004d8b3d974846a3b9056c6c3b6649104fa
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
9 years agoMerge "Fix Memory leak of getResourceType() in ocstack.c"
Sudarshan Prasad [Wed, 14 Jan 2015 03:52:24 +0000 (03:52 +0000)]
Merge "Fix Memory leak of getResourceType() in ocstack.c"

9 years agoRemove high frequency log to avoid the log full with useless information
Caiwen Zhang [Tue, 13 Jan 2015 06:58:06 +0000 (14:58 +0800)]
Remove high frequency log to avoid the log full with useless information

The OCProcess function is invoked in while loop. The functions that are
invoked by OCProcess will be invoked very frequently. If add log in these
functions, it may make the log full of useless information.

This patch removes frequent log from OCProcess/OCProcessPresence/
OCProcessCoAP/coap_read/OCRecvFrom function.

Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Change-Id: Iabe182aca8430438085296cd16d69f5bde0626a8

9 years agoReduce footprint by using string literals.
Ossama Othman [Tue, 13 Jan 2015 18:24:49 +0000 (10:24 -0800)]
Reduce footprint by using string literals.

This change replaces the std::string based exception description
string constants in resource/include/StringConstants.h with
string literals instead.  Switching to string literals has a number of
advantages in this case:

- reduced start-up time for binaries that link against liboc
  since the static std::string constants no longer have to
  be initialized at run-time.
- the compiler is free to place the strings in read-only
  memory.
- reduced static and run-time footprint.

Footprint reductions in text, data and bss are as follows:

filename                        text
                        std::   const
                        string  char[]  Diff    Change
InProcClientWrapper.o   81458   77684   -3774   -4.63%
InProcServerWrapper.o   43292   40122   -3170   -7.32%
OCException.o           5399    1956    -3443   -63.77%
OCPlatform_impl.o       25054   21803   -3251   -12.98%
OCPlatform.o            9574    5535    -4039   -42.19%
OCRepresentation.o      97156   93782   -3374   -3.47%
OCResource.o            28565   25048   -3517   -12.31%
OCUtilities.o           19844   15805   -4039   -20.35%
liboc.so                453688  434400  -19288  -4.25%

filename                        data
                        std::   const
                        string  char[]  Diff    Change
InProcClientWrapper.o   1916    1916    0       0.00%
InProcServerWrapper.o   1368    1368    0       0.00%
OCException.o           4       4       0       0.00%
OCPlatform_impl.o       552     552     0       0.00%
OCPlatform.o            8       8       0       0.00%
OCRepresentation.o      388     388     0       0.00%
OCResource.o            100     100     0       0.00%
OCUtilities.o           344     344     0       0.00%
liboc.so                6636    6652    16      0.24%

filename                        bss
                        std::   const
                        string  char[]  Diff    Change
InProcClientWrapper.o   577     309     -268    -46.45%
InProcServerWrapper.o   657     389     -268    -40.79%
OCException.o           320     52      -268    -83.75%
OCPlatform_impl.o       420     152     -268    -63.81%
OCPlatform.o            340     72      -268    -78.82%
OCRepresentation.o      328     60      -268    -81.71%
OCResource.o            340     72      -268    -78.82%
OCUtilities.o           340     72      -268    -78.82%
liboc.so                3340    1192    -2148   -64.31%

filename                        dec
                        std::   const
                        string  char[]  Diff    Change
InProcClientWrapper.o   83951   79909   -4042   -4.81%
InProcServerWrapper.o   45317   41879   -3438   -7.59%
OCException.o           5723    2012    -3711   -64.84%
OCPlatform_impl.o       26026   22507   -3519   -13.52%
OCPlatform.o            9922    5615    -4307   -43.41%
OCRepresentation.o      97872   94230   -3642   -3.72%
OCResource.o            29005   25220   -3785   -13.05%
OCUtilities.o           20528   16221   -4307   -20.98%
liboc.so                463664  442244  -21420  -4.62%

Overall liboc.so drops in size by 20 kilobytes, a 4.62%
reduction in size with these changes in place.

Change-Id: I3e24f56bf702a0ea134b113d542f61e45f8af613
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
9 years agoMerge "Fixed seg fault in simpleclient sample app (Bug IOT-130)"
Sudarshan Prasad [Tue, 13 Jan 2015 22:43:57 +0000 (22:43 +0000)]
Merge "Fixed seg fault in simpleclient sample app (Bug IOT-130)"

9 years agoMerge "Added style formatting config files for iotivity coding standards"
Sudarshan Prasad [Tue, 13 Jan 2015 02:48:25 +0000 (02:48 +0000)]
Merge "Added style formatting config files for iotivity coding standards"

9 years agoMerge "Fixed InProcServerWrapper to be thread safe"
Sudarshan Prasad [Tue, 13 Jan 2015 02:01:50 +0000 (02:01 +0000)]
Merge "Fixed InProcServerWrapper to be thread safe"

9 years agoMerge "Fixed simpleclient crash caused by curResource being altered"
Sudarshan Prasad [Mon, 12 Jan 2015 23:17:48 +0000 (23:17 +0000)]
Merge "Fixed simpleclient crash caused by curResource being altered"

9 years agoFixed InProcServerWrapper to be thread safe
Erich Keane [Sat, 10 Jan 2015 00:53:28 +0000 (16:53 -0800)]
Fixed InProcServerWrapper to be thread safe

A few of the variables/collections in the server wrapper were not
properly protected against multi-threading.  This fix adds a mutex
to the class to ensure that all accessed items are protected.
Additionally, they are moved out of the root namespace to prevent
polution.

Change-Id: I2eedb9bf9b1960ff7a018a2ca1e15183e42bd9cd
Signed-off-by: Erich Keane <erich.keane@intel.com>
9 years agoMerge "Fix failed unit tests for CSDK stack."
Sudarshan Prasad [Mon, 12 Jan 2015 20:03:15 +0000 (20:03 +0000)]
Merge "Fix failed unit tests for CSDK stack."

9 years agoMerge "C++ Avoid crash in case of Invalid/Empty Payload"
Sudarshan Prasad [Mon, 12 Jan 2015 18:47:13 +0000 (18:47 +0000)]
Merge "C++ Avoid crash in case of Invalid/Empty Payload"

9 years agoFix failed unit tests for CSDK stack.
Doug Hudson [Mon, 12 Jan 2015 16:28:32 +0000 (11:28 -0500)]
Fix failed unit tests for CSDK stack.

The existing unit tests in stacktests.cpp had not kept up with
ongoing modifications to the C API.  Modified failing tests to
align with latest C API functionality.

Also modified to remove limitation that required the eth0 network
interface to be available on the test machine.  If eth0 was not
available, some tests would fail.

Also added a local function to handle C stack initialization and
modified tests to call this function.  Added local functions to
intialize the number of expected resources and resource index
depending on whether presence is defined.

Re-grouped related test cases and created common group test names.

Change-Id: Ief59854d762ef9837f8b1d5b95bebc6514bd545a
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
9 years agoFix Memory leak of getResourceType() in ocstack.c
ywsung [Fri, 9 Jan 2015 06:15:06 +0000 (15:15 +0900)]
Fix Memory leak of getResourceType() in ocstack.c

When memory allocation is failed, add free memory for already allocated memory.

Change-Id: I601367e7bfe3ff6a616d870636d5b535a32047fd
Signed-off-by: YW Sung <yw.sung@samsung.com>
9 years agoChange the definition of GROUP_INTERFACE.
HyunJun Kim [Mon, 12 Jan 2015 05:30:24 +0000 (14:30 +0900)]
Change the definition of GROUP_INTERFACE.

The definition of GROUP_INTERFACE as "oc.mi.c"
does not get big meaning.
So, we change the definition to "oc.mi.grp".
Regarding opinion of Caiwen.

Issue : [IOT-253]

Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Change-Id: Ia196e8a2a0856ed0651874eec419f77468e8329e

9 years agoMerge "Fixed invalid memory read, removed dead code"
Sudarshan Prasad [Sat, 10 Jan 2015 01:43:38 +0000 (01:43 +0000)]
Merge "Fixed invalid memory read, removed dead code"

9 years agoMerge "Adding OK Response Code for POST"
Sudarshan Prasad [Sat, 10 Jan 2015 01:25:24 +0000 (01:25 +0000)]
Merge "Adding OK Response Code for POST"

9 years agoMerge "Fixing repeated EH calls when client retransmits requests"
Sudarshan Prasad [Fri, 9 Jan 2015 21:10:25 +0000 (21:10 +0000)]
Merge "Fixing repeated EH calls when client retransmits requests"

9 years agoC++ Avoid crash in case of Invalid/Empty Payload
omkar [Fri, 9 Jan 2015 19:34:18 +0000 (11:34 -0800)]
C++ Avoid crash in case of Invalid/Empty Payload

This change is based on a bug reported by SHP wherein
they want to be able to send response with empty payload.
Instead of throwing an error, we now send an empty
OCRepresentation() object to the client callback.

Change-Id: I16f298bf8a0bdbb545e1133d751582f418991352
Signed-off-by: omkar <omkar.m.hegde@intel.com>
9 years agoAdded style formatting config files for iotivity coding standards
Ossama Othman [Fri, 9 Jan 2015 19:10:59 +0000 (11:10 -0800)]
Added style formatting config files for iotivity coding standards

The style config files are used to apply IoTivity coding style, as
described on the wiki https://wiki.iotivity.org/iotivity_coding_standards.

Change-Id: Ifd3937bebde658a76aa7c9918b4c699c1384f341
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
9 years agoAdding tinyDTLS into iotivity repo
Sachin Agrawal [Fri, 9 Jan 2015 18:38:48 +0000 (10:38 -0800)]
Adding tinyDTLS into iotivity repo

Picked GIT commit id 7d039c from
http://sourceforge.net/projects/tinydtls/ .

iotivity build system can compile tinydtls using autotools
with below steps:
1)autoconf
2)./configure --without-debug --without-ecc 'CFLAGS=-fPIC'
3)make

Change-Id: I97a917955ca13a06914ecee178c0cee0701eda12
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>