Ben Adams [Sat, 18 Feb 2017 18:47:36 +0000 (18:47 +0000)]
Fast-path for ASCII & UTF8 Encoding ASCII data (#9187)
Steve MacLean [Sat, 18 Feb 2017 09:15:26 +0000 (04:15 -0500)]
[Arm64/Unix] Fix cmake race condition (#9666)
On a clean build SET(REQUIRE_LLDBPLUGIN false) was being ignored because the cmake
cache variable had not been created
Change order of cmake file to be more natural and to resolve
Sivarv [Sat, 18 Feb 2017 06:29:47 +0000 (22:29 -0800)]
Merge pull request #9667 from sivarv/backout
Back-out promotion of structs containing fields of struct of single field
sivarv [Sat, 18 Feb 2017 04:17:13 +0000 (20:17 -0800)]
Backout promotion of structs containing fields of struct of single field.
Andy Ayers [Sat, 18 Feb 2017 01:17:34 +0000 (17:17 -0800)]
Merge pull request #9657 from AndyAyersMS/FixFinallyChainMergeAssert
JIT: relax assert in fgMergeFinallyChains
Sivarv [Fri, 17 Feb 2017 22:21:33 +0000 (14:21 -0800)]
Merge pull request #9636 from sivarv/shouldPromote
Refactor some of fgPromoteStruct() checks into lvaCanPromoteStructVar() and lvaShouldPromoteStructVar()
chcosta [Fri, 17 Feb 2017 20:47:10 +0000 (12:47 -0800)]
Merge pull request #9658 from chcosta/fix_coreclr_packaging
Exclude ni files from linux arm32 builds
Jiyoung Giuliana Yun [Fri, 17 Feb 2017 20:43:52 +0000 (05:43 +0900)]
Synchronous toolchain.cmake files with CoreFX (#9409)
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
Pat Gavlin [Fri, 17 Feb 2017 20:13:25 +0000 (12:13 -0800)]
Merge pull request #8843 from mikedn/decompose-cast-mul
Improve int->long cast decomposition
Joseph Tremoulet [Fri, 17 Feb 2017 19:40:17 +0000 (14:40 -0500)]
Merge pull request #9615 from JosephTremoulet/UpdateCompareVN
Update array length compare value numbers on CSE
Dan Moseley [Fri, 17 Feb 2017 19:18:50 +0000 (11:18 -0800)]
Merge pull request #9649 from dotnet-bot/master-UpdateDependencies
Update CoreFx to beta-25017-02 (master)
Dan Moseley [Fri, 17 Feb 2017 19:13:59 +0000 (11:13 -0800)]
Merge pull request #9228 from fujiy/fixcorefx4805
Add/Expose String.EndsWith(char) and String.StartsWith(char)
Russ Keldorph [Fri, 17 Feb 2017 19:03:05 +0000 (11:03 -0800)]
Merge pull request #9656 from RussKeldorph/corefx_x86
Fix corefx x86 testing and small netci.groovy fixes
Christopher Costa [Fri, 17 Feb 2017 18:46:41 +0000 (10:46 -0800)]
Remove ubuntu 16.10 arm build from packaging
Steve MacLean [Fri, 17 Feb 2017 18:25:37 +0000 (13:25 -0500)]
[ARM64/Unix] (#9500)
* [Arm64/Unix] Update arm64 *.S files to match *.asm
* [Arm64/Unix] Fix CONTEXTToNativeContext()
* [Arm64/Unix] ThrowExceptionFromContextInternal
* [Arm64/Unix] Preserve x8 argument register
* [ARM64/Unix] Add CFI directives
Add native unwind info
* [Arm64/Unix] Fix RtlRestoreContext
* [Arm64/Unix] Restore FP from CurrentContextPointers
* [Arm64/Unix] fix pointer math
* [Arm64/Unix] Fix CallDescrWorkerInternal personality
* [Arm64/Unix] More Fp fixups
* [Arm64/Unix] CallEHFunclet machine state
Restore non-volatile machine state in CallEHFunclet
* [Arm64/Unix] CallDescrWorkerInternal
Use empty stack slot to save argument
* [Arm64/Unix] RtlVirtualUnwind update pointers
* [Arm64] LazyMachState fixes
* [Arm64/Unix] disable USE_REDIRECT_FOR_GCSTRESS
When FEATURE_PAL is enableds USE_REDIRECT_FOR_GCSTRESS
is not supported
* [Arm64] ClearRegDisplayArgumentAndScratchRegisters()
* [Arm64] Remove unnecesary copy in TransitionFrame
* [Arm64/Unix] Fix comment per review
* [Arm64/Unix] move constants per review
* [Arm64/Unix] Use ldp per review
Also fix indentation
* [Arm64/Unix] Fix indentation per review
* [Arm64/Unix] Remove m_Unwound per review comments
* [Arm64/Unix] Use PREPARE_EXTERNAL_VAR to access globals
* [Arm64/Unix] Fix more whitespace per earlier review comments
Christopher Costa [Fri, 17 Feb 2017 18:23:20 +0000 (10:23 -0800)]
Remove contraction from property name
Christopher Costa [Fri, 17 Feb 2017 18:20:58 +0000 (10:20 -0800)]
Exclude ni files from linux arm32 builds
Russ Keldorph [Fri, 17 Feb 2017 17:12:04 +0000 (09:12 -0800)]
Fix corefx x86 testing and small netci.groovy fixes
run-corefx-tests.py fixes
- Switch to using the same corefx build switches as the corefx CI.
netci.groovy fixes
- Add COMPlus_Ready2Run=0 to existing ZapDisable jobs to get the coverage
we intended to have in these jobs. Previously, R2R images were slipping
through.
- Add architecture to the trigger strings fore corefx jobs so it's
possible to request x86 corefx runs.
- Add the -u option to python command line in netci.groovy so Python
output is synchronized with subcommand output in the CI logs.
- Fix whitespace in name formatting of corefx_baseline jobs
- Remove trailing (sorry, my editor did this and now it is too hard to
undo. Add ?w=1 to Github diff URL to filter out ws diffs.)
Jarret Shook [Fri, 17 Feb 2017 16:27:18 +0000 (08:27 -0800)]
Merge pull request #9580 from sdmaclea/PR-ARM64-CROSSGENFAILS
[Arm64/Unix] Add crossgen fails
Andy Ayers [Fri, 17 Feb 2017 16:04:55 +0000 (08:04 -0800)]
JIT: relax assert in fgMergeFinallyChains
In some rare and likely IL-only cases the jit may create unreachable
callfinallys. This trips up finally chain merging since it spots a
merge opportunity but no merge actually happens.
Relax the assertion checks so that `canMerge && !didMerge` is now ok.
Closes #9651.
dotnet-bot [Fri, 17 Feb 2017 15:07:22 +0000 (15:07 +0000)]
Update CoreFx to beta-25017-02
Hanjoung Lee [Fri, 17 Feb 2017 11:39:26 +0000 (20:39 +0900)]
[x86/Linux] Remove unnecessary x86-specific part (#9627)
This inlined assembly is no longer necessary for x86.
Jonghyun Park [Fri, 17 Feb 2017 11:11:46 +0000 (20:11 +0900)]
Clean up nested WIN64EXCEPTIONS (#9644)
Jonghyun Park [Fri, 17 Feb 2017 09:27:17 +0000 (18:27 +0900)]
Clean up dummy implementation in regdisp.h (#9643)
Jonghyun Park [Fri, 17 Feb 2017 09:19:16 +0000 (18:19 +0900)]
[x86/Linux] Fix GetCallerSp (#9384)
* [x86/Linux] Fix GetCallerSp
* Do NOT pop stack argument for TransitionFrame
* Add ResumeEsp to CONTEXT
Drew Scoggins [Fri, 17 Feb 2017 08:45:22 +0000 (00:45 -0800)]
Merge pull request #9645 from DrewScoggins/EmptyVariableFix
Fix x64 perf run break
Drew Scoggins [Fri, 17 Feb 2017 07:39:53 +0000 (23:39 -0800)]
Fix x64 perf run break
After the checkin to add legacy JIT testing support for x86 we broke x64
runs. THe issue is that we do not pass anything in to the TEST_ENV
variable on x64 and when a variable is empty and you attempt to use the
if exists syntax you fail. I have added a nonsense file name that we
set this to before we go through the args loop. I was not able to find a
better solution and want to get the lab unblocked, but any batch masters
feel free to solve this the right way.
Dan Moseley [Fri, 17 Feb 2017 05:45:12 +0000 (21:45 -0800)]
Merge pull request #9642 from dotnet-bot/master-UpdateDependencies
Update CoreFx to beta-25017-01 (master)
Dan Moseley [Fri, 17 Feb 2017 05:44:36 +0000 (21:44 -0800)]
Merge pull request #9639 from parjong/fix/wrong_comment
Fix wrong comment
dotnet-bot [Fri, 17 Feb 2017 03:03:57 +0000 (03:03 +0000)]
Update CoreFx to beta-25017-01
Dan Moseley [Fri, 17 Feb 2017 02:47:45 +0000 (18:47 -0800)]
Merge pull request #8778 from dnickless/master
Performance improvement: Make ConcurrentDictionary with Enum values also profit from atomic writes.
William Godbe [Fri, 17 Feb 2017 01:58:46 +0000 (17:58 -0800)]
Merge pull request #9637 from wtgodbe/noMoreSuse
Remove all references to OpenSuse13.2
Gaurav Khanna [Fri, 17 Feb 2017 01:31:17 +0000 (17:31 -0800)]
Merge pull request #9628 from dotnet-bot/master-UpdateDependencies
Update CoreFx to beta-25016-03 (master)
Jonghyun Park [Fri, 17 Feb 2017 01:10:09 +0000 (10:10 +0900)]
Fix wrong comment
Bruce Forstall [Thu, 16 Feb 2017 23:42:34 +0000 (15:42 -0800)]
Merge pull request #9610 from sdmaclea/PR-ARM64-CALLSITE
[Arm64/Unix] Correct ControlPC when unwinding
wtgodbe [Thu, 16 Feb 2017 22:40:39 +0000 (14:40 -0800)]
Remove all references to OpenSuse13.2
sivarv [Thu, 16 Feb 2017 22:01:24 +0000 (14:01 -0800)]
Refactor fgPromoteStrut into lvaShouldPromoteStructVar
Joseph Tremoulet [Thu, 16 Feb 2017 21:53:47 +0000 (13:53 -0800)]
Rename cseArrLenMap to optCseArrLenMap
This lines up better with other names in code that optimizes common sub-
expressions.
Joseph Tremoulet [Thu, 16 Feb 2017 19:45:52 +0000 (11:45 -0800)]
Factor signedness test into helper
Gaurav Khanna [Thu, 16 Feb 2017 18:03:03 +0000 (10:03 -0800)]
Merge pull request #9629 from sdmaclea/PR-FIX-LLDB-REGRESSION
Pr fix lldb regression typo
Michelle McDaniel [Thu, 16 Feb 2017 17:14:35 +0000 (09:14 -0800)]
Merge pull request #9588 from adiaaida/perfLegacyJit
Add perf job for legacy jit
Jonghyun Park [Thu, 16 Feb 2017 16:40:03 +0000 (01:40 +0900)]
[x86/Linux] Emit proper frame for FastGetSharedStaticBase (#9618)
* [x86/Linux] Emit proper frame for FastGetSharedStaticBase
* Adjust Stack-align Padding
* Remove FEATURE_PAL ifdef
Steve MacLean [Thu, 16 Feb 2017 13:16:20 +0000 (08:16 -0500)]
Merge branch 'master' into PR-FIX-LLDB-REGRESSION
[Unix] Fix arm/lldb rootfs breakage (typo)
dotnet-bot [Thu, 16 Feb 2017 09:09:29 +0000 (09:09 +0000)]
Update CoreFx to beta-25016-03
Steve MacLean [Thu, 16 Feb 2017 08:55:20 +0000 (03:55 -0500)]
[Unix] Fix arm/lldb rootfs breakage (#9625)
SaeHie Park [Thu, 16 Feb 2017 08:50:08 +0000 (17:50 +0900)]
[x86/Linux] Fix IsIPInMarkedJitHelper to handle sigsegv (#9605)
Include JIT_WriteBarrier and JIT_CheckedWriteBarrier functions
so that we can handle NullReferenceException for sigsegv from WriteBarriers.
Dan Moseley [Thu, 16 Feb 2017 05:50:01 +0000 (21:50 -0800)]
Merge pull request #9603 from danmosemsft/defines4
Remove more dead native defines
[Unix] Fix arm/lldb rootfs breakage
Dan Moseley [Thu, 16 Feb 2017 02:09:34 +0000 (18:09 -0800)]
Update testing-with-corefx.md
Felipe Fujiy Pessoto [Thu, 16 Feb 2017 02:08:58 +0000 (00:08 -0200)]
Remove unnecessary "this"
Andy Ayers [Thu, 16 Feb 2017 01:48:59 +0000 (17:48 -0800)]
Merge pull request #9622 from AndyAyersMS/FixRetDesktopBreak
JIT: fix desktop build break
Dan Moseley [Wed, 15 Feb 2017 23:55:09 +0000 (15:55 -0800)]
Merge pull request #9599 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-25015-04, beta-25015-02, respectively (master)
danmosemsft [Wed, 15 Feb 2017 23:52:17 +0000 (15:52 -0800)]
Other props stragglers for never defined symbols
danmosemsft [Wed, 15 Feb 2017 23:44:09 +0000 (15:44 -0800)]
More FEATURE_WIN_DB_APPCOMPAT
danmosemsft [Wed, 15 Feb 2017 23:41:02 +0000 (15:41 -0800)]
More FEATURE_ISOSTORE
danmosemsft [Wed, 15 Feb 2017 23:38:26 +0000 (15:38 -0800)]
Remove never defined FEATURE_X509
danmosemsft [Wed, 15 Feb 2017 22:58:27 +0000 (14:58 -0800)]
Remove never defined FEATURE_WIN_DB_APPCOMPAT
danmosemsft [Wed, 15 Feb 2017 22:55:46 +0000 (14:55 -0800)]
Remove never defined FEATURE_UEF_CHAINMANAGER
danmosemsft [Wed, 15 Feb 2017 22:20:38 +0000 (14:20 -0800)]
Remove never defined FEATURE_TRACELOGGING except in jit/**
danmosemsft [Wed, 15 Feb 2017 21:49:49 +0000 (13:49 -0800)]
Remove never defined FEATURE_SERIALIZATION
Andy Ayers [Wed, 15 Feb 2017 23:35:12 +0000 (15:35 -0800)]
JIT: fix desktop build break
Desktop builds warn about unreachable code after returns, so modify
how finally chain merging is enabled and disabled in various configs.
Michelle McDaniel [Tue, 14 Feb 2017 18:11:56 +0000 (10:11 -0800)]
Add perf job for legacy jit
Add performance testing jobs for jit32. This change adds jit32 as an
architecture for perf.groovy. It also renames the x86 legs to be
x86ryujit. For the two x86-based architectures, we pass a testenv. This is
so if we have to switch which version is the default jit on x86, we will
not need to change the perf jobs, we can just update the testenv files.
This change updates run-xunit-perf.cmd to take a test env script as a
parameter and run it before running the tests if it exists.
This change also cleans up some of the calls in perf.groovy to use
variables that we've already set, rather than baking in the contents of
those variables (changing Release to ${configuration}).
SaeHie Park [Wed, 15 Feb 2017 21:46:36 +0000 (06:46 +0900)]
[x86/Linux] Fix GetModRMOperandValue() (#9600)
Getting idiv divisor in GetModRMOperandValue() needs to handle x86 also
This patch will correct address of divisor when it resides in memory
Related unit test case: JIT/Regression/CLR-x86-JIT/V1-M09.5-PDC/b16328/b16328
Michelle McDaniel [Wed, 15 Feb 2017 21:32:22 +0000 (13:32 -0800)]
Merge pull request #9587 from adiaaida/newDelaySign
Enable delay signing in ilasm
danmosemsft [Wed, 15 Feb 2017 21:16:04 +0000 (13:16 -0800)]
Extra line
Dan Moseley [Wed, 15 Feb 2017 21:15:00 +0000 (13:15 -0800)]
Merge pull request #9613 from danmosemsft/stragglers
Remove dead code
chcosta [Wed, 15 Feb 2017 21:14:09 +0000 (13:14 -0800)]
Merge pull request #9263 from chcosta/refactor_packaging
Refactor coreclr packaging
Joseph Tremoulet [Mon, 13 Feb 2017 22:27:12 +0000 (14:27 -0800)]
Update array length compare value numbers on CSE
Modify CSE to identify compares which are functions of CSE candidate array
length nodes; when those length nodes get CSEd and consequently have their
value numbers updated, also update the value number on the compare
consuming the array length; this way the assertions generated in assertion
prop for the different compares on the CSEd array will use the same value
numbers, and range check elimination becomes more effective.
Resolves #5371
Andy Ayers [Wed, 15 Feb 2017 19:11:13 +0000 (11:11 -0800)]
JIT: Finally chain merging (#8810)
Add an optimization that performs a specialized tail merge for chains
of callfinallys. These can arise from try-finallys where there are
multiple exit points from the try that have the same continuation.
When the jit generates a callfinally, it does so without considering
whether some previously generated callfinally might invoke the same
handler and then continue on to the same continuation.
This optimization looks for callfinallys that invoke the same handler
and have the same continuation and effectively merges them into one
canonical callfinally.
This optimization is done bottom-up (from outermost handler invocation
to innermost) to allow the merging done at an outer levels to enable
merging at inner levels.
This optimization saves code size and also results in more compact EH
reporting, since the callfinallies are reported to the runtime as
duplicate EH regions.
When run upstream of finally cloning, finally chain merging also allows
more of the paths exiting the try to exit via the clone.
Also fix an issue in block ref count maintenance during empty try
removal that caused an assert during finally chain merging.
Christopher Costa [Wed, 15 Feb 2017 18:38:46 +0000 (10:38 -0800)]
Rename dir.targets -> dir.traversal.targets
Michelle McDaniel [Mon, 13 Feb 2017 19:00:58 +0000 (11:00 -0800)]
Enable delay signing in ilasm
Corefx needs the .Net Core version of ilasm to create delay signable
assemblies. This change brings back AllocateStrongNameSignature that was
deleted in 2efbb92 and modifies it to use similar logic from Roslyn to
determine the size of the signature that we need to allocate space for.
Fixes #9292.
dotnet-bot [Wed, 15 Feb 2017 17:53:21 +0000 (17:53 +0000)]
Update CoreClr, CoreFx to beta-25015-04, beta-25015-02, respectively
danmosemsft [Wed, 15 Feb 2017 17:39:39 +0000 (09:39 -0800)]
Remove dead code
Andy Ayers [Wed, 15 Feb 2017 17:33:16 +0000 (09:33 -0800)]
Merge pull request #9479 from AndyAyersMS/TrimInlineGcRefs
JIT: null out inline gc type locals after inline body
Steve MacLean [Wed, 15 Feb 2017 17:00:56 +0000 (12:00 -0500)]
[ARM64/Unix] LLDB (#9504)
* [Arm64/Unix] Default to no lldb in build-rootfs
lldb is not readily available on arm64 Ubuntu releases prior to
16.10
Set the default lldb version to none to allow building Arm64 rootfs
* [Arm64/Unix] Warn if lldb is missing
SOS lldb plugin is an optional component
lldb is not availiable on arm64 prior to lldb3.9
lldb3.9 is not readily available on many ubuntu until 16.10
Change error to warning to simplify building arm64
[Arm64/Unix] Correct ControlPC when unwinding
Fixes #9585
Hyung-Kyu Choi [Wed, 15 Feb 2017 12:07:08 +0000 (21:07 +0900)]
Fix build-rootfs.sh to include lldb package (#9608)
lldb package is missing for architectures other than arm and armel.
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
danmosemsft [Wed, 15 Feb 2017 06:24:54 +0000 (22:24 -0800)]
Remove never defined FEATURE_RWLOCK
danmosemsft [Wed, 15 Feb 2017 06:20:22 +0000 (22:20 -0800)]
Remove never defined FEATURE_REMOTING
danmosemsft [Wed, 15 Feb 2017 05:34:56 +0000 (21:34 -0800)]
Remove never defined FEATURE_REFLECTION_ONLY_LOAD
danmosemsft [Wed, 15 Feb 2017 05:23:33 +0000 (21:23 -0800)]
Remove never defined FEATURE_PLS
danmosemsft [Wed, 15 Feb 2017 05:21:22 +0000 (21:21 -0800)]
Remove never defined FEATURE_PERFMON
danmosemsft [Wed, 15 Feb 2017 05:18:37 +0000 (21:18 -0800)]
Remove never defined FEATURE_NON_UNICODE_CODE_PAGES
danmosemsft [Wed, 15 Feb 2017 05:13:22 +0000 (21:13 -0800)]
Remove never defined FEATURE_MULTIMODULE_ASSEMBLIES
danmosemsft [Wed, 15 Feb 2017 05:07:49 +0000 (21:07 -0800)]
Remove never defined FEATURE_MIXEDMODE
danmosemsft [Wed, 15 Feb 2017 04:49:11 +0000 (20:49 -0800)]
Remove never defined FEATURE_METHOD_RENTAL
danmosemsft [Wed, 15 Feb 2017 04:44:23 +0000 (20:44 -0800)]
Remove never defined FEATURE_METADATA_STANDALONE_WINRT
danmosemsft [Wed, 15 Feb 2017 04:37:29 +0000 (20:37 -0800)]
Remove never defined FEATURE_METADATA_STANDALONE_WINRT_RO
SaeHie Park [Wed, 15 Feb 2017 05:12:06 +0000 (14:12 +0900)]
[x86/Linux] Fix CreateInstantiatingILStub (#9590)
The hidden argument should be always passed last for x86
danmosemsft [Tue, 14 Feb 2017 21:58:27 +0000 (13:58 -0800)]
Remove never defined FEATURE_LEAK_CULTURE_INFO
Rama krishnan Raghupathy [Wed, 15 Feb 2017 02:55:00 +0000 (18:55 -0800)]
Merge pull request #9472 from ramarag/RMLocalizationparity
RM localization parity with desktop
Jonghyun Park [Wed, 15 Feb 2017 01:11:32 +0000 (10:11 +0900)]
Rewrite GetRegisterAddressByIndex using getRegAddr (#9574)
* Rewrite GetRegisterAddressByIndex using getRegAddr
* Use offset-based indirection in x86 getRegAddr
William Godbe [Wed, 15 Feb 2017 00:49:20 +0000 (16:49 -0800)]
Merge pull request #9593 from wtgodbe/skipGCTests
Return exit code 0 for long-running/GCSimulator tests in Helix
Rama Krishnan Raghupathy [Wed, 15 Feb 2017 00:44:42 +0000 (16:44 -0800)]
Removing nativeGetResourceFallbackArray support from Vm
Joseph Tremoulet [Wed, 15 Feb 2017 00:41:17 +0000 (19:41 -0500)]
Merge pull request #9583 from JosephTremoulet/ByrefConst
Value number casts and zeros of TYP_BYREF
Christopher Costa [Wed, 15 Feb 2017 00:29:51 +0000 (16:29 -0800)]
change package_platform to platform
William Godbe [Wed, 15 Feb 2017 00:27:07 +0000 (16:27 -0800)]
Merge pull request #9589 from dotnet-bot/master-UpdateDependencies
Update CoreClr to beta-25014-04 (master)
Rama Krishnan Raghupathy [Thu, 9 Feb 2017 23:09:12 +0000 (15:09 -0800)]
Removing Os specified ulimatefallback for localization
Christopher Costa [Wed, 15 Feb 2017 00:14:31 +0000 (16:14 -0800)]
Exclude binaries not built on armel