bsalomon@google.com [Wed, 2 Oct 2013 13:04:56 +0000 (13:04 +0000)]
Make GPU coord transforms automatic
Adds a GrCoordTransform class and updates the framework to handle
coord transforms similar to how it handles textures with
GrTextureAccess. Renames GrGLEffectMatrix to GrGLCoordTransform and
slightly repurposes it to be used by the framework instead of effects.
R=bsalomon@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
24853002
git-svn-id: http://skia.googlecode.com/svn/trunk@11569
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 2 Oct 2013 12:16:25 +0000 (12:16 +0000)]
Whitespace change to test CQ emails.
BUG=
NOTRY=True
R=borenet@google.com
TBR=borenet@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
25712003
git-svn-id: http://skia.googlecode.com/svn/trunk@11567
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 1 Oct 2013 19:54:42 +0000 (19:54 +0000)]
Empty implementations for SkImageDecoder.
Add constructor and destructor, so SkScaledBitmapSampler's
DummyDecoder has no unresolved symbols in Chrome.
Fixes our Chrome canary.
Unreviewed.
Review URL: https://codereview.chromium.org/
25536004
git-svn-id: http://skia.googlecode.com/svn/trunk@11566
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 1 Oct 2013 18:44:18 +0000 (18:44 +0000)]
Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone.
We're writing fDone without holding the mutex. Bad form, says tsan.
In practice this is fairly innocuous, as fDone only ever goes from false to
true and only once. Though, I wouldn't be surprised if there were some way
this could leak a thread that never got the signal to die.
BUG=
R=scroggo@google.com, reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
25371003
git-svn-id: http://skia.googlecode.com/svn/trunk@11563
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 1 Oct 2013 18:44:04 +0000 (18:44 +0000)]
Writing to testName and reading its size isn't thread safe, TSAN reminds us.
Guarding it into a no-op makes it safe. Looks like this is only used for debugging, presumably singlethreaded?
BUG=
R=caryclark@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
25366002
git-svn-id: http://skia.googlecode.com/svn/trunk@11562
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 1 Oct 2013 18:43:50 +0000 (18:43 +0000)]
In skia_test.cc, atomics -> mutex.
These guys are not heavily contended nor speed critical. No need for atomics,
plus this makes tsan stop complaining (correctly) about reading fNextIndex
unsafely in onEnd.
I took a look at failCount/fFailCount, which I think is safely atomic and quite
conveniently so: It's never read until all the threads which could possibly
increment it have terminated (except for the one where it was created,
obviously). We could guard it with a mutex too, but maybe we can let this one
slide.
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
25357002
git-svn-id: http://skia.googlecode.com/svn/trunk@11561
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 1 Oct 2013 18:43:29 +0000 (18:43 +0000)]
Use explicitly-sized enums in GrGLProgramDesc::KeyHeader
Uses enums explicitly sized to 8 bits in GrGLProgramDesc::KeyHeader,
instead of storing them as uint8_t values. This avoids the need to
static_cast them.
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
23875048
git-svn-id: http://skia.googlecode.com/svn/trunk@11560
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 1 Oct 2013 17:46:35 +0000 (17:46 +0000)]
Fix build.
Predeclare a function.
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@11559
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 1 Oct 2013 17:27:15 +0000 (17:27 +0000)]
Add an option on SkImageDecoder to skip writing 0s.
Only implemented for PNG.
Add a getter and setter, and sets the default to false in the
constructor. Also copies the setting in copyFieldsToOther.
Fix an indpendent bug where fDitherImage was not being copied in
copyFieldsToOther.
In SkScaledBitmapSampler::begin, consolidate the settings passed in
by passing a const reference to the decoder. The decoder can be
referenced for its settings of dither, unpremultiplied, and now
skipping writing zeroes. Update callers to use the new API. In png
decoder, rather than passing around a pointer to an initial
read of getDitherImage, and potentially changing it, look at the
field on the decoder itself, and modify it directly. This is a
change in behavior - now if that same decoder is used to decode
a different image, the dither setting has changed. I think this is
okay because A) the typical use case is to use a new decoder for
each decode, B) we do not make any promises that a decode does not
change the decoder and C) it makes the code in SkScaledBitmapSampler
much cleaner.
In SkScaledBitmapScampler, add new row procs for skipping zeroes. Now
that choosing the row proc has five dimensions (src config, dst config,
dither, skip writing zeroes, unpremultiplied), use a new method: each
src/dst combination has a function for choosing the right proc depending
on the decoder.
SkScaledBitmapScampler::RowProc is now public for convenience.
Remove Sample_Gray_D8888_Unpremul, which is effectively no different
from Sample_Gray_D8888.
In cases where unpremultiplied was trivial, such as 565 and when
sampling from gray, decoding may now succeed.
Add a benchmark (currently disabled) for comparing the speed of skipping
writing zeroes versus not skipping. For this particular image, which is
mostly transparent pixels, normal decoding took about 3.6 milliseconds,
while skipping zeroes in the decode took only about 2.5 milliseconds
(this is on a Nexus 4). Presumably it would be slower on an image
with a small amount of transparency, but there will be no slowdown
for an image which reports that it has no transparency.
In SkImageRef_ashmem, always skip writing zeroes, since ashmem
memory is guaranteed to be initialized to 0.
Add a flag to skip writing zeroes in skimage.
Add a regression test for choosing the rowproc to ensure I did not
change any behavior accidentally.
BUG=skia:1661
R=reed@google.com
Review URL: https://codereview.chromium.org/
24269006
git-svn-id: http://skia.googlecode.com/svn/trunk@11558
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 1 Oct 2013 15:31:54 +0000 (15:31 +0000)]
Fix ninja build on Android
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
25535002
git-svn-id: http://skia.googlecode.com/svn/trunk@11555
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 1 Oct 2013 15:30:46 +0000 (15:30 +0000)]
Allow creating a picture from skp to fail.
Replace the current constructor for creating an
SkPicturePlayback to a factory. In the factory,
check for incorrect data that would result in an invalid
playback. If the playback is invalid, return NULL, and
return NULL from SkPicture's factory as well.
Update SkTimedPicture(Playback) as well.
BUG=skia:1672
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
24826002
git-svn-id: http://skia.googlecode.com/svn/trunk@11554
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 1 Oct 2013 15:03:18 +0000 (15:03 +0000)]
Minor changes to XPS device.
git-svn-id: http://skia.googlecode.com/svn/trunk@11552
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 1 Oct 2013 13:54:16 +0000 (13:54 +0000)]
Reverted r11547; filing bugs for 64-bit warnings
Review URL: https://codereview.chromium.org/
25530002
git-svn-id: http://skia.googlecode.com/svn/trunk@11551
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 1 Oct 2013 13:22:07 +0000 (13:22 +0000)]
Whitespace change to trigger builds after r11547: Always use WERR for skia_lib
Review URL: https://codereview.chromium.org/
25521002
git-svn-id: http://skia.googlecode.com/svn/trunk@11548
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 1 Oct 2013 07:01:46 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11544
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 30 Sep 2013 20:58:48 +0000 (20:58 +0000)]
fix the android build. now both android_ninja _and_ android_make work.
BUG=
Review URL: https://codereview.chromium.org/
25319003
git-svn-id: http://skia.googlecode.com/svn/trunk@11542
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 30 Sep 2013 20:53:36 +0000 (20:53 +0000)]
VERBOSE -> SKIA_ANDROID_VERBOSE_SETUP
BUG=
R=borenet@google.com
Review URL: https://codereview.chromium.org/
25269008
git-svn-id: http://skia.googlecode.com/svn/trunk@11541
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 30 Sep 2013 20:42:10 +0000 (20:42 +0000)]
make vanilla android_ninja work, and add quiet options
BUG=
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
25275006
git-svn-id: http://skia.googlecode.com/svn/trunk@11540
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 30 Sep 2013 20:33:21 +0000 (20:33 +0000)]
Remove uneeded copy of gdbserver from apk
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
25336002
git-svn-id: http://skia.googlecode.com/svn/trunk@11539
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 30 Sep 2013 19:57:15 +0000 (19:57 +0000)]
Reduce max number of textures to 4 to make room for a larger class id in effect key
git-svn-id: http://skia.googlecode.com/svn/trunk@11538
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 30 Sep 2013 19:55:49 +0000 (19:55 +0000)]
Mark when effects and programs have vertex code
Adds a 'hasVertexCode' method to GrEffect and a 'fHasVertexCode' field
to GrGLProgramDesc::KeyHeader. Also adds a GrVertexEffect class that
effects have to inherit from in order to set the 'hasVertexCode' flag
and be able to emit vertex code, and updates the existing effects to
use it as needed.
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
23653059
git-svn-id: http://skia.googlecode.com/svn/trunk@11537
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 30 Sep 2013 19:41:09 +0000 (19:41 +0000)]
Add 3 color variant to gradient bench, include scale in name, add more benchs
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
25294003
git-svn-id: http://skia.googlecode.com/svn/trunk@11536
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 30 Sep 2013 19:23:05 +0000 (19:23 +0000)]
fix Android release builds
BUG=
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
25300005
git-svn-id: http://skia.googlecode.com/svn/trunk@11535
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 30 Sep 2013 18:41:38 +0000 (18:41 +0000)]
Add a GrCustomCoordsTextureEffect class
Extracts a GrCustomCoordsTextureEffect class from
GrSimpleTextureEffect. This way there are no effects that can
conditionally require a vertex shader. They either always need one or
never do. Also removes kCustom_CoordsType from the CoordsType enum in
GrEffect (that enum is really only meant for coords provided by the
framework), and updates GrSimpleTextureEffect::TestCreate to make the
effect with position as well, instead of just local coords.
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
24018007
git-svn-id: http://skia.googlecode.com/svn/trunk@11531
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 30 Sep 2013 18:19:26 +0000 (18:19 +0000)]
quiet down more third-party warnings in poppler and jsoncpp
BUG=
R=djsollen@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
25319002
git-svn-id: http://skia.googlecode.com/svn/trunk@11530
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 30 Sep 2013 18:06:34 +0000 (18:06 +0000)]
remove unecessary warnings from third_party code
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
25030003
git-svn-id: http://skia.googlecode.com/svn/trunk@11529
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 30 Sep 2013 18:05:43 +0000 (18:05 +0000)]
Add GrSurface::savePixels().
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
25021006
git-svn-id: http://skia.googlecode.com/svn/trunk@11528
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 30 Sep 2013 17:32:09 +0000 (17:32 +0000)]
Add android_ninja, like android_make for ninja.
android_ninja {tests,bench,gm,bench_pictures,render_pictures} all build and run
fine. They build so fast I thought maybe they were broken.
Note that android_ninja with no argument is failing:
ninja: Entering directory `out/config/android-arm_v7_thumb/Debug'
ninja: error: 'lib.target/libSampleApp.so', needed by 'android/libs/armeabi-v7a/libSampleApp.so', missing and no known rule to make it
Will look into this.
BUG=
R=djsollen@google.com
Committed: https://code.google.com/p/skia/source/detail?r=11525
Review URL: https://codereview.chromium.org/
24833002
git-svn-id: http://skia.googlecode.com/svn/trunk@11527
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 30 Sep 2013 17:22:48 +0000 (17:22 +0000)]
Revert "Add android_ninja, like android_make for ninja."
Broke some builds. Will try again.
BUG=
Review URL: https://codereview.chromium.org/
25307002
git-svn-id: http://skia.googlecode.com/svn/trunk@11526
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 30 Sep 2013 17:13:58 +0000 (17:13 +0000)]
Add android_ninja, like android_make for ninja.
android_ninja {tests,bench,gm,bench_pictures,render_pictures} all build and run
fine. They build so fast I thought maybe they were broken.
Note that android_ninja with no argument is failing:
ninja: Entering directory `out/config/android-arm_v7_thumb/Debug'
ninja: error: 'lib.target/libSampleApp.so', needed by 'android/libs/armeabi-v7a/libSampleApp.so', missing and no known rule to make it
Will look into this.
BUG=
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
24833002
git-svn-id: http://skia.googlecode.com/svn/trunk@11525
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 30 Sep 2013 15:46:50 +0000 (15:46 +0000)]
Ignore flaky shadertext2_pdf-poppler tests on Mac-10.7 Release builds
BUG=skia:1692
TBR=edisonn
Review URL: https://codereview.chromium.org/
25287002
git-svn-id: http://skia.googlecode.com/svn/trunk@11524
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 30 Sep 2013 15:30:27 +0000 (15:30 +0000)]
Move the GL shader compilation step into GrGLShaderBuilder
Moves the compilation step and a few other blocks of code from
GrGLProgram to GrGLShaderBuilder. This way GrGLProgram doesn't have to
know whether or not there is a vertex shader.
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
23533066
git-svn-id: http://skia.googlecode.com/svn/trunk@11523
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 30 Sep 2013 15:13:58 +0000 (15:13 +0000)]
Revert "Add a requiresVertexShader method to GrGLEffect"
This reverts commit
1a30a3af805b7ea688d4a0f0bfe373c204085a27. We're
going to take a different direction for vertexless shaders.
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
23464082
git-svn-id: http://skia.googlecode.com/svn/trunk@11521
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 30 Sep 2013 15:06:25 +0000 (15:06 +0000)]
HTTP GM results viewer: server now returns category summaries along with testData
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/
25045003
git-svn-id: http://skia.googlecode.com/svn/trunk@11520
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 30 Sep 2013 07:01:55 +0000 (07:01 +0000)]
revert temporary r11517
Review URL: https://codereview.chromium.org/
25215002
git-svn-id: http://skia.googlecode.com/svn/trunk@11518
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 30 Sep 2013 06:29:19 +0000 (06:29 +0000)]
gm: temporarily re-enable multiple rendermodes, to make sure they haven't regressed
Review URL: https://codereview.chromium.org/
25213002
git-svn-id: http://skia.googlecode.com/svn/trunk@11517
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 29 Sep 2013 17:57:36 +0000 (17:57 +0000)]
More image rebaselines
https://codereview.chromium.org/
25184002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11516
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 29 Sep 2013 14:48:38 +0000 (14:48 +0000)]
Added SK_API to SkPathRef.h
git-svn-id: http://skia.googlecode.com/svn/trunk@11515
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 28 Sep 2013 07:01:33 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11513
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 27 Sep 2013 23:18:16 +0000 (23:18 +0000)]
Rebaselining some stragglers
https://codereview.chromium.org/
25098008/
git-svn-id: http://skia.googlecode.com/svn/trunk@11512
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 27 Sep 2013 21:53:39 +0000 (21:53 +0000)]
Limit warning message to de-clutter bench output logs
https://codereview.chromium.org/
25112002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11511
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 27 Sep 2013 21:50:21 +0000 (21:50 +0000)]
Rebaseline after quadratic-circle approximation change
https://codereview.chromium.org/
25078003/
git-svn-id: http://skia.googlecode.com/svn/trunk@11510
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 27 Sep 2013 21:22:45 +0000 (21:22 +0000)]
Rebaseline inconsequential changes to quadclosepath on N10 msaa4
R=epoger@google.com
Review URL: https://codereview.chromium.org/
25104003
git-svn-id: http://skia.googlecode.com/svn/trunk@11509
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 27 Sep 2013 19:39:38 +0000 (19:39 +0000)]
GrAtlas cleanup: Split out GrPlot and GrAtlas
This breaks up GrAtlas into the head of the list (GrAtlas) and the list elements (GrPlot). It also moves all of the GrPlot management code into GrAtlasMgr. It adds a simple pool allocator for GrPlots and removes use of GrPlotMgr.
R=bsalomon@google.com, robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
24981004
git-svn-id: http://skia.googlecode.com/svn/trunk@11508
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 27 Sep 2013 17:48:49 +0000 (17:48 +0000)]
Move unlikely-to-be-inlined code from SkPathRef.h to SkPathRef.cpp
https://codereview.chromium.org/
24998004/
git-svn-id: http://skia.googlecode.com/svn/trunk@11506
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 27 Sep 2013 17:36:22 +0000 (17:36 +0000)]
Added two more GMs to the suppressions file
git-svn-id: http://skia.googlecode.com/svn/trunk@11505
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 27 Sep 2013 17:05:59 +0000 (17:05 +0000)]
This CL effectively reverts:
r5997 Altered arcTo's canonical points to (usually) be convex (https://codereview.appspot.com/6709051/)
r9928 GM (and fix) for drawArc capping issue (https://codereview.chromium.org/
18271003/)
Instead of pushing some of the on-curve points out to attain convexity, this patch pulls all the off curve points in.
R=reed@google.com
Review URL: https://codereview.chromium.org/
24810002
git-svn-id: http://skia.googlecode.com/svn/trunk@11504
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Fri, 27 Sep 2013 15:08:53 +0000 (15:08 +0000)]
Adding gms for tileimagefilter and offsetimagefilter
BUG=skia:1684
Review URL: https://codereview.chromium.org/
25068002
git-svn-id: http://skia.googlecode.com/svn/trunk@11501
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 27 Sep 2013 15:02:44 +0000 (15:02 +0000)]
Create HTTP-based GM results viewer.
For now, it only allows VIEWING results... next, it will allow the user to
rebaseline GM results via the web interface.
R=borenet@google.com
Review URL: https://codereview.chromium.org/
24274003
git-svn-id: http://skia.googlecode.com/svn/trunk@11500
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Fri, 27 Sep 2013 15:00:22 +0000 (15:00 +0000)]
Rebaselining xfermodeimagefilter
Adding new baselines and removing the line in ignore-tests.txt
BUG=
R=bsalomon@google.com, epoger@google.com
Review URL: https://codereview.chromium.org/
25062002
git-svn-id: http://skia.googlecode.com/svn/trunk@11499
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Fri, 27 Sep 2013 14:28:45 +0000 (14:28 +0000)]
Fix android_run_skia
If STATUS_FILENAME doesn't exist, exit 1.
R=djsollen@google.com, jvanverth@google.com
Review URL: https://codereview.chromium.org/
24770002
git-svn-id: http://skia.googlecode.com/svn/trunk@11498
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Fri, 27 Sep 2013 13:39:14 +0000 (13:39 +0000)]
Fix asan build. Duh, don't return a stack address...
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
25026004
git-svn-id: http://skia.googlecode.com/svn/trunk@11497
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 27 Sep 2013 13:33:17 +0000 (13:33 +0000)]
Rebaseline hairline images & remove suppression
https://codereview.chromium.org/
25045002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11496
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 27 Sep 2013 12:27:27 +0000 (12:27 +0000)]
Compiler warning/error fix for Chromium
git-svn-id: http://skia.googlecode.com/svn/trunk@11494
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 27 Sep 2013 07:01:29 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11493
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 26 Sep 2013 22:58:20 +0000 (22:58 +0000)]
Whitespace change to trigger build.
git-svn-id: http://skia.googlecode.com/svn/trunk@11492
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 26 Sep 2013 21:49:46 +0000 (21:49 +0000)]
Fix a warning.
git-svn-id: http://skia.googlecode.com/svn/trunk@11489
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 26 Sep 2013 21:35:39 +0000 (21:35 +0000)]
Add a buffered SkStream class.
This is used by Android to buffer an input stream which may not
otherwise be able to rewind.
Add a test for the new class.
R=bungeman@google.com, mtklein@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
23717055
git-svn-id: http://skia.googlecode.com/svn/trunk@11488
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 26 Sep 2013 20:44:24 +0000 (20:44 +0000)]
gm: add a flag to force perspective usage in all gms
BUG=
R=reed@google.com, epoger@google.com, borenet@google.com
Author: edisonn@google.com
Review URL: https://chromiumcodereview.appspot.com/
23587029
git-svn-id: http://skia.googlecode.com/svn/trunk@11487
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 26 Sep 2013 19:56:51 +0000 (19:56 +0000)]
move GrMalloc, GrFree, Gr_bzero to their sk equivalents
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
23566022
git-svn-id: http://skia.googlecode.com/svn/trunk@11486
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 26 Sep 2013 19:28:27 +0000 (19:28 +0000)]
add counting to Globals, and refactor some for clarity
BUG=
Review URL: https://codereview.chromium.org/
24447003
git-svn-id: http://skia.googlecode.com/svn/trunk@11484
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 26 Sep 2013 19:23:03 +0000 (19:23 +0000)]
Remove uses of unnamed namespace in bench/ directory.
Skia prefers to use static over unnamed namespace.
BUG=None
TEST=None, no functional changes.
R=bsalomon@google.com, robertphillips@google.com
Author: tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
24660003
git-svn-id: http://skia.googlecode.com/svn/trunk@11483
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 26 Sep 2013 19:22:54 +0000 (19:22 +0000)]
Add SkDivMod with a special case for ARM.
BUG=skia:1663
R=djsollen@google.com, tomhudson@google.com, reed@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
24159009
git-svn-id: http://skia.googlecode.com/svn/trunk@11482
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Thu, 26 Sep 2013 17:24:27 +0000 (17:24 +0000)]
Correcting expectations file
git-svn-id: http://skia.googlecode.com/svn/trunk@11479
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Thu, 26 Sep 2013 17:12:47 +0000 (17:12 +0000)]
Whitespaces
Ignore failing gms
git-svn-id: http://skia.googlecode.com/svn/trunk@11478
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Thu, 26 Sep 2013 17:03:38 +0000 (17:03 +0000)]
Added SkTileImageFilter to SkFlattenable::InitializeFlattenables()
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
24764003
git-svn-id: http://skia.googlecode.com/svn/trunk@11477
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 26 Sep 2013 16:09:28 +0000 (16:09 +0000)]
Moving 4 SkImageFilter derived classes from blink to skia
There were 4 classes in blink that derived from SkImageFilter :
- TileImageFilter -> SkTileImageFilter
- OffsetImageFilter -> SkOffsetImageFilter (already existed)
- FloodImageFilter -> SkFloodImageFilter
- CompositeImageFilter -> SkCompositeImageFilter
All functions were copied as is, without modification (except for warnings fixes), except for the offset filter, which was merged into the existing SkOffsetImageFilter class, as a special case when a crop rect is provided. Since the names won't clash with the names in blink, it should be easy to integrate them in blink later and fix issues, if needed.
BUG=
R=senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com, reed@google.com, mtklein@google.com
Author: sugoi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
24157005
git-svn-id: http://skia.googlecode.com/svn/trunk@11475
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 26 Sep 2013 15:28:40 +0000 (15:28 +0000)]
GrAtlas refactor: Replace GrMaskFormat usage in GrAtlas with GrPixelConfig.
This gets the font-specific GrMaskFormat out of GrAtlas and replaces it with
more generic configs, allowing GrAtlas to be used for other things.
R=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
24751003
git-svn-id: http://skia.googlecode.com/svn/trunk@11474
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 26 Sep 2013 15:25:23 +0000 (15:25 +0000)]
ARM Skia NEON patches - 24 - S32_D565_Blend_Dither slight speedup/bugfix
BlitRow565: S32_D565_Blend_Dither, slight speedup + bugfix
This patch adds a rewrite of S32_D565_Blend_Dither in intrinsics.
The newer version is faster (10-20% depending on the value of count)
and also supports ARGB as well as ABGR. It also adds the missing
assert at the beginning of the function.
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://chromiumcodereview.appspot.com/
22566002
git-svn-id: http://skia.googlecode.com/svn/trunk@11473
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 26 Sep 2013 15:16:12 +0000 (15:16 +0000)]
We don't flatten or unflatten SkPaintOptionsAndroid. Reproduce and fix.
BUG=skia:1625
R=djsollen@google.com, reed@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
24075010
git-svn-id: http://skia.googlecode.com/svn/trunk@11472
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Thu, 26 Sep 2013 14:49:02 +0000 (14:49 +0000)]
Ignore incosistent results of pdf-mac and pdf-poppler renderers, and remove a temp file checked in by mistake.
Review URL: https://codereview.chromium.org/
24642003
git-svn-id: http://skia.googlecode.com/svn/trunk@11471
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 26 Sep 2013 12:57:19 +0000 (12:57 +0000)]
First pass at font cache refactor: Create an atlas manager per texture
This changes the AtlasMgr from a singleton class to one that is
created per-texture. This is the first step in allowing us to create
Atlases of other types (e.g., combine small icons into one big texture).
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
24608002
git-svn-id: http://skia.googlecode.com/svn/trunk@11468
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 26 Sep 2013 12:18:23 +0000 (12:18 +0000)]
Move bound and isFinite into pathref
https://codereview.chromium.org/
24350006/
git-svn-id: http://skia.googlecode.com/svn/trunk@11467
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 26 Sep 2013 12:05:32 +0000 (12:05 +0000)]
Add GM case for arc truncation error bug
https://codereview.chromium.org/
23532082/
git-svn-id: http://skia.googlecode.com/svn/trunk@11466
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 26 Sep 2013 07:01:39 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11465
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 25 Sep 2013 22:39:22 +0000 (22:39 +0000)]
Add skia_tsan_build to match skia_asan_build and fix one example race.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
24644003
git-svn-id: http://skia.googlecode.com/svn/trunk@11464
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 25 Sep 2013 22:10:04 +0000 (22:10 +0000)]
Fix iOS build.
More SkStream -> SkStreamRewindable.
git-svn-id: http://skia.googlecode.com/svn/trunk@11463
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 25 Sep 2013 22:01:17 +0000 (22:01 +0000)]
Fix a warning.
git-svn-id: http://skia.googlecode.com/svn/trunk@11462
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 25 Sep 2013 21:42:12 +0000 (21:42 +0000)]
Bench baseline for mostly 0 image.
Add a baseline for decoding a mostly 0 image. This is in advance of
https://codereview.chromium.org/
24269006/ which provides an option to
skip writing those 0s (as part of BUG=skia:1661). On my Nexus 4, the
benchmark does not slow down after that change.
As suggested in https://codereview.chromium.org/
24269006/ add a
resourcePath flag to bench. Will require a change in buildbot in order
to actually use the flag.
Add an image used by the test.
Until https://codereview.chromium.org/
24448002 is submitted,
the test will not actually be run by the bots (since it
won't know where to find the file).
BUG=skia:1661
R=djsollen@google.com, mtklein@google.com
Review URL: https://codereview.chromium.org/
24440002
git-svn-id: http://skia.googlecode.com/svn/trunk@11461
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 25 Sep 2013 21:34:24 +0000 (21:34 +0000)]
Change SkImageDecoders to take an SkStreamRewindable.
Only affects factories, static functions that will use the factories,
and subset decoding, which all require rewinding. The decoders
themselves continue to take an SkStream. This is merely documentation
stating which functions will possibly rewind the passed in SkStream.
This is part of the general change to coordinate SkStreams with
Android's streams, which don't necessarily support rewinding in all
cases.
Update callers to use SkStreamRewindable.
BUG=skia:1572
R=bungeman@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
23477009
git-svn-id: http://skia.googlecode.com/svn/trunk@11460
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 25 Sep 2013 21:27:31 +0000 (21:27 +0000)]
Print a better error message.
Use format_message to print the proper error message in JPEG decoder.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
24461002
git-svn-id: http://skia.googlecode.com/svn/trunk@11459
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 25 Sep 2013 21:17:41 +0000 (21:17 +0000)]
Use the default resync_to_restart in jpeg.
Our version requires rewinding the stream, which is not always
supported. Instead, depend on jpeg's default version.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
23464068
git-svn-id: http://skia.googlecode.com/svn/trunk@11458
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 25 Sep 2013 20:57:51 +0000 (20:57 +0000)]
Replace GR_*_BUILD by their SK_BUILD_FOR_* equivalents.
BUG=None
TEST=None, no functional changes.
R=bsalomon@google.com, robertphillips@google.com
Author: tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
24253009
git-svn-id: http://skia.googlecode.com/svn/trunk@11457
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Wed, 25 Sep 2013 20:51:16 +0000 (20:51 +0000)]
Deletes bench_expectations.txt and change comments to refer to the new per-bot expectation files.
Review URL: https://codereview.chromium.org/
23830009
git-svn-id: http://skia.googlecode.com/svn/trunk@11456
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 25 Sep 2013 18:21:39 +0000 (18:21 +0000)]
Refactor PathTest.cpp test_isNestedRects and test_isRect.
The existing implementations make it difficult to add new tests
and rely on non-local side effects.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
24502004
git-svn-id: http://skia.googlecode.com/svn/trunk@11455
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 25 Sep 2013 01:01:30 +0000 (01:01 +0000)]
Whitespace change to trigger rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@11452
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 24 Sep 2013 20:08:47 +0000 (20:08 +0000)]
Use different unique identifier for a fallback family.
BUG=chromium:266412
R=mtklein@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
24288002
git-svn-id: http://skia.googlecode.com/svn/trunk@11451
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 24 Sep 2013 19:59:44 +0000 (19:59 +0000)]
remove obsolete USE_CACHE_HASH
BUG=
Review URL: https://codereview.chromium.org/
23526082
git-svn-id: http://skia.googlecode.com/svn/trunk@11450
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 24 Sep 2013 17:51:26 +0000 (17:51 +0000)]
GalaxyNexus rebaselines for testimagefilters and imagefilterscropped. (I guess this bot was previously failing before generating GMs?)
TBR=bsalomon
Review URL: https://codereview.chromium.org/
23531087
git-svn-id: http://skia.googlecode.com/svn/trunk@11449
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 24 Sep 2013 14:17:12 +0000 (14:17 +0000)]
rebase gradients[_*_perspective] tests on GN after test change.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
23531085
git-svn-id: http://skia.googlecode.com/svn/trunk@11445
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 23 Sep 2013 20:00:30 +0000 (20:00 +0000)]
Rebaseline gradient changes on GN due to test change.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
24161005
git-svn-id: http://skia.googlecode.com/svn/trunk@11441
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 23 Sep 2013 17:23:21 +0000 (17:23 +0000)]
Rebaselines -- some stragglers for morphology.
TBR=bungeman
Review URL: https://codereview.chromium.org/
23688007
git-svn-id: http://skia.googlecode.com/svn/trunk@11440
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 23 Sep 2013 13:53:46 +0000 (13:53 +0000)]
Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@11438
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 23 Sep 2013 12:08:20 +0000 (12:08 +0000)]
Whitespace change to trigger rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@11430
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 22 Sep 2013 21:57:03 +0000 (21:57 +0000)]
Patch SkImage.h so Chrome will compile
git-svn-id: http://skia.googlecode.com/svn/trunk@11429
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 22 Sep 2013 21:01:28 +0000 (21:01 +0000)]
Remove SK_ENABLE_LEGACY_API_ALIASING from SkImage.h
git-svn-id: http://skia.googlecode.com/svn/trunk@11428
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 22 Sep 2013 20:18:07 +0000 (20:18 +0000)]
Revert r11423 (low hanging calloc fruit)
git-svn-id: http://skia.googlecode.com/svn/trunk@11427
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 21 Sep 2013 07:01:53 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11426
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 20 Sep 2013 20:24:55 +0000 (20:24 +0000)]
Moar rebaselines for testimagefilters and imagefilterscropped.
TBR=bungeman
Review URL: https://codereview.chromium.org/
23749010
git-svn-id: http://skia.googlecode.com/svn/trunk@11425
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 20 Sep 2013 20:05:01 +0000 (20:05 +0000)]
use new globally scoped SkAlphaType
git-svn-id: http://skia.googlecode.com/svn/trunk@11424
2bbb7eff-a529-9590-31e7-
b0007b416f81