Guillaume Lucas [Tue, 7 Dec 2010 10:58:47 +0000 (10:58 +0000)]
stkutil: fix crash cause by null text string
According to 3GPP TS 31.124 a zero length for the text string
should be allowed. An empty string must be returned to the
user in this case.
Johan Hedberg [Thu, 9 Dec 2010 19:52:54 +0000 (21:52 +0200)]
gdbus: fix accessing freed callback data
cb->disc_func or cb->conn_func could remove the callback so this needs
to be checked for before continuing processing.
Rajesh Kadhiravan Nagaiah [Thu, 2 Dec 2010 23:29:05 +0000 (15:29 -0800)]
doc: Add RoamingPreference property
Denis Kenzior [Thu, 9 Dec 2010 07:53:05 +0000 (01:53 -0600)]
test: Fixup build issues with test-sms
Denis Kenzior [Wed, 8 Dec 2010 17:55:07 +0000 (11:55 -0600)]
radio-settings: Minor style fixes for rule M13
Denis Kenzior [Wed, 8 Dec 2010 17:41:36 +0000 (11:41 -0600)]
AUTHORS: Mention Rafael's contributions
Rafael Ignacio Zurita [Thu, 2 Dec 2010 19:22:47 +0000 (16:22 -0300)]
TODO: Add owner to 'GPS power control atom' task
Denis Kenzior [Wed, 8 Dec 2010 17:38:25 +0000 (11:38 -0600)]
doc: Reword the description of GsmBand and UmtsBand
Lucas De Marchi [Thu, 2 Dec 2010 01:55:59 +0000 (23:55 -0200)]
doc: document frequency band selection
Denis Kenzior [Wed, 8 Dec 2010 17:35:44 +0000 (11:35 -0600)]
radio-settings: Minor style issues
Lucas De Marchi [Thu, 2 Dec 2010 01:55:58 +0000 (23:55 -0200)]
radio-settings: add frequency band selection props
Denis Kenzior [Wed, 8 Dec 2010 17:26:58 +0000 (11:26 -0600)]
include: Minor style fixes
Lucas De Marchi [Thu, 2 Dec 2010 01:55:57 +0000 (23:55 -0200)]
radio-settings: add frequency band selection methods
Denis Kenzior [Wed, 8 Dec 2010 16:39:59 +0000 (10:39 -0600)]
TODO: Mark Provide Local Information task as done
Jeevaka Badrappan [Wed, 1 Dec 2010 19:47:21 +0000 (11:47 -0800)]
TODO: Mark Language Notification task as done
Denis Kenzior [Wed, 8 Dec 2010 16:31:05 +0000 (10:31 -0600)]
unit: Minor style updates to test-sms
Denis Kenzior [Wed, 8 Dec 2010 16:27:48 +0000 (10:27 -0600)]
AUTHORS: Mention Oleg's contributions
Oleg Zhurakivskyy [Wed, 1 Dec 2010 12:27:42 +0000 (14:27 +0200)]
unit: add national dialect SMS character set tests
Denis Kenzior [Wed, 8 Dec 2010 15:43:25 +0000 (09:43 -0600)]
simutil: fixup style according to M11
Lucas De Marchi [Sat, 27 Nov 2010 19:39:01 +0000 (17:39 -0200)]
gdbus: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Yang Gu [Tue, 30 Nov 2010 10:44:50 +0000 (18:44 +0800)]
stk: Handle provide local info proactive command
Yang Gu [Tue, 30 Nov 2010 10:44:49 +0000 (18:44 +0800)]
smsutil: Make timezone an optional field
Denis Kenzior [Wed, 8 Dec 2010 13:03:01 +0000 (07:03 -0600)]
test: When priting help for enter-pin, exit
Yang Gu [Tue, 30 Nov 2010 10:44:48 +0000 (18:44 +0800)]
smsutil: Change the range of time zone
Gustavo F. Padovan [Fri, 3 Dec 2010 18:52:56 +0000 (16:52 -0200)]
phonesim: Add modem reset trigger
Gustavo F. Padovan [Fri, 3 Dec 2010 18:52:55 +0000 (16:52 -0200)]
Add ofono_modem_reset()
Some modems can screw up everything and then we will need to do a silent
reset of the modem. This patch take the modem back to the OFFLINE state.
Gustavo F. Padovan [Fri, 3 Dec 2010 18:52:54 +0000 (16:52 -0200)]
modem: add ofono_modem_reset() to modem.h
Gustavo F. Padovan [Fri, 3 Dec 2010 21:40:22 +0000 (19:40 -0200)]
modem: only unref pending if it is a powered pending
Lucas De Marchi [Thu, 2 Dec 2010 12:46:46 +0000 (10:46 -0200)]
TODO: add owner to 'SIM PIN retry counter' task
Gustavo F. Padovan [Thu, 2 Dec 2010 17:14:43 +0000 (15:14 -0200)]
TODO: Add owner for the CNAP task
Vinicius Costa Gomes [Thu, 2 Dec 2010 20:13:42 +0000 (17:13 -0300)]
gatchat: fix canceling in progress commands
As g_queue_peek_head() returns the node data field, we have to compare
it against the actual command, not against the pointer to the queue node.
Denis Kenzior [Tue, 7 Dec 2010 02:11:55 +0000 (20:11 -0600)]
smsutil: Minor style fix
Marcel Holtmann [Tue, 7 Dec 2010 09:00:36 +0000 (10:00 +0100)]
build: Silence another make message
Rémi Denis-Courmont [Mon, 6 Dec 2010 15:49:56 +0000 (17:49 +0200)]
Mark ofono/*.h symbolink links as built sources
This forces automake/make to build them first if needed (as before).
But it avoids marking every single header as a dependency of every
single object. Thus we do not need a bogus full rebuild of the tree
everytime a header is added.
Pekka Pessi [Fri, 26 Nov 2010 15:14:49 +0000 (17:14 +0200)]
voicecall: fix dial result handling
The existing call will be automatically put on hold if there is an
existing active call when dialing. On some modems the dial request
returns only after the dialed call is active and the existing call has
been put on hold.
However, on isimodem driver the dial request returns immediately before
the existing call has changed its status. With isimodem driver the
dial_handle_result() selected the existing call from the list when it
should have created a new one.
The dial result handling now guards againt returning a previously dialed
active call as result.
Denis Kenzior [Fri, 3 Dec 2010 18:14:06 +0000 (12:14 -0600)]
network: Send strength as a byte, not uint16
To be consistent with the documentation
Denis Kenzior [Thu, 2 Dec 2010 20:24:07 +0000 (14:24 -0600)]
AUTHORS: Mention Helen's contributions
Denis Kenzior [Thu, 2 Dec 2010 20:23:35 +0000 (14:23 -0600)]
ste: Minor style fixes
Helen Clemson [Thu, 2 Dec 2010 11:05:40 +0000 (12:05 +0100)]
ste: Restructure caif channel creation
This is restructuring the caif channel creation, so that at a later
date multiple AT channels can be supported. This effectively moves
the channel creation from ste_enable, into its own function,
ste_create_channel.
Pekka Pessi [Fri, 3 Dec 2010 08:30:50 +0000 (10:30 +0200)]
isi/voicecall: fix handling of waiting calls
Also, do not retrieve calls after isi_release_all_active() because
retrieving is now only an unwanted side-effect .
Pekka Pessi [Fri, 3 Dec 2010 08:30:49 +0000 (10:30 +0200)]
isi/voicecall: avoid side-effects of release
If a call was held automatically when an another call was dialed or
answered, it gets retrieved when the other call is released unless
auto change features is explicitly disabled.
Drop cause_type parameter because it is never used.
Use cause code for busy when releasing incoming or waiting calls.
Pekka Pessi [Fri, 3 Dec 2010 08:30:48 +0000 (10:30 +0200)]
isi/voicecall: add call id to queued requests
Pekka Pessi [Fri, 3 Dec 2010 08:30:47 +0000 (10:30 +0200)]
isi/voicecall: fix status reporting
Do not report incoming calls to the oFono core until they can be
answered.
Report MT_RELEASED or MO_RELEASED via ofono_voicecall_notify(),
TERMINATED calls via ofono_voicecall_disconnected().
Pekka Pessi [Fri, 3 Dec 2010 09:05:28 +0000 (11:05 +0200)]
coding-style M14: parenthesis around sizeof arg
Aki Niemi [Fri, 3 Dec 2010 12:47:40 +0000 (14:47 +0200)]
test: Unregister agents on keyboard interrupt
Control-C now calls UnregisterAgent(), so the agents exit cleanly.
Aki Niemi [Fri, 3 Dec 2010 12:46:51 +0000 (14:46 +0200)]
test: Fix script output
There is no proposing, just action.
Aki Niemi [Fri, 3 Dec 2010 12:36:17 +0000 (14:36 +0200)]
TODO: Add owner for IAP database task
Denis Kenzior [Thu, 2 Dec 2010 17:22:07 +0000 (11:22 -0600)]
doc: Don't go over 80 characters / line
Denis Kenzior [Thu, 2 Dec 2010 17:21:07 +0000 (11:21 -0600)]
doc: Move DisconnectReason to the signals section
Gustavo F. Padovan [Tue, 30 Nov 2010 22:14:39 +0000 (20:14 -0200)]
atmodem: fix DBG message
Denis Kenzior [Thu, 2 Dec 2010 14:13:41 +0000 (08:13 -0600)]
AUTHORS: Mention Rafael's contributions
Rafael Ignacio Zurita [Tue, 30 Nov 2010 21:56:23 +0000 (18:56 -0300)]
HACKING: Add ofono.conf file copy command required
Add ofono.conf copy command required for oFono core daemon to work.
Lucas De Marchi [Wed, 1 Dec 2010 15:46:44 +0000 (13:46 -0200)]
HACKING: add guidelines to patch submission
Jeevaka Badrappan [Thu, 2 Dec 2010 09:43:27 +0000 (01:43 -0800)]
smsutil: Fix issue in mwi dcs decoding
Zhigang Li [Thu, 2 Dec 2010 09:29:22 +0000 (17:29 +0800)]
test: Add support for PlayTone and LoopTone
Denis Kenzior [Thu, 2 Dec 2010 13:58:48 +0000 (07:58 -0600)]
AUTHORS: Mention Antti's contributions
Antti Paila [Thu, 2 Dec 2010 07:19:00 +0000 (09:19 +0200)]
gprs: Fix for gprs context conversion
Denis Kenzior [Thu, 2 Dec 2010 13:53:54 +0000 (07:53 -0600)]
smsutil: Fix uninitialized optional elements
sms_decode was never memsetting the returned structure, so if any
optional elements were present in the SMS (e.g. status report) then the
structure was not completely initialized.
Denis Kenzior [Thu, 2 Dec 2010 13:49:49 +0000 (07:49 -0600)]
sms: Use the right union member for DCS check
Denis Kenzior [Wed, 1 Dec 2010 22:25:17 +0000 (16:25 -0600)]
doc: Mark EmergencyNumbers property readonly
Guillaume Lucas [Tue, 30 Nov 2010 13:21:50 +0000 (13:21 +0000)]
stk: Add busy error for the display text command
According to the sequence 1.2 of the ETSI TS 102 384 a busy
screen error should be returns for the display text proactive
command when the ME is not able to display the text.
Jeevaka Badrappan [Mon, 29 Nov 2010 16:57:39 +0000 (08:57 -0800)]
sim: be more paranoid for triggering EFest read
Denis Kenzior [Mon, 29 Nov 2010 19:53:36 +0000 (13:53 -0600)]
TODO: minor typo
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
core: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
simutil: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
simfs: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
util: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
stkutil: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
smsutil: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:39:02 +0000 (17:39 -0200)]
plugins: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:39:00 +0000 (17:39 -0200)]
gatchat: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:38:59 +0000 (17:38 -0200)]
examples: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:38:58 +0000 (17:38 -0200)]
gisi: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:38:57 +0000 (17:38 -0200)]
unit: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Denis Kenzior [Mon, 29 Nov 2010 17:47:47 +0000 (11:47 -0600)]
isi: Get rid of a pointless check in cf driver
Lucas De Marchi [Sat, 27 Nov 2010 19:38:56 +0000 (17:38 -0200)]
drivers: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:38:55 +0000 (17:38 -0200)]
coding-style: add rule about checking NULL pointer
Lucas De Marchi [Sat, 27 Nov 2010 19:22:55 +0000 (17:22 -0200)]
TODO: Mark CTM task as done
Lucas De Marchi [Sat, 27 Nov 2010 19:22:54 +0000 (17:22 -0200)]
phonesim: implement ctm atom
Denis Kenzior [Mon, 29 Nov 2010 13:51:53 +0000 (07:51 -0600)]
isi: Update radio-settings to use new API
Denis Kenzior [Mon, 29 Nov 2010 13:51:41 +0000 (07:51 -0600)]
radio-settings: Update API to use ofono_bool_t
Denis Kenzior [Sat, 27 Nov 2010 17:57:50 +0000 (11:57 -0600)]
atmodem: Forgot to reset sms data on remove
Rémi Denis-Courmont [Mon, 29 Nov 2010 08:29:02 +0000 (10:29 +0200)]
configure: do not hard-code the C run-time library name
Since oFono does (obviously) not use -nostdlib, this only broke support
for alternative C run-times.
Jeevaka Badrappan [Fri, 26 Nov 2010 06:23:31 +0000 (22:23 -0800)]
simutil: Add EFcfis and EFcphs-cff file Ids
Jeevaka Badrappan [Fri, 26 Nov 2010 21:21:06 +0000 (13:21 -0800)]
call-volume: Minor coding style fix
Jeevaka Badrappan [Fri, 26 Nov 2010 12:27:42 +0000 (04:27 -0800)]
audio-settings: Remove unwanted check
Jeevaka Badrappan [Fri, 26 Nov 2010 20:59:38 +0000 (12:59 -0800)]
call-volume: Remove extra line at EOF
Arun Ravindran [Fri, 26 Nov 2010 09:54:02 +0000 (11:54 +0200)]
doc: update cdma-voicecall-manager-api.txt
Yang Gu [Thu, 25 Nov 2010 12:29:00 +0000 (20:29 +0800)]
network: Use bit as size instead of byte
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
core: Remove stray newlines in messages sent to log
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
isigen: Remove stray newlines in DBG
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
ste: Remove stray newlines in messages sent to log
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
isi: Remove stray newlines in messages sent to log
Jeevaka Badrappan [Fri, 26 Nov 2010 14:59:32 +0000 (06:59 -0800)]
call-volume: Fix dbus error message type
Denis Kenzior [Fri, 26 Nov 2010 19:22:55 +0000 (13:22 -0600)]
build: Add forgotten test/test-tty
Lucas De Marchi [Thu, 25 Nov 2010 17:42:00 +0000 (15:42 -0200)]
test: add test/set-tty script
To enable/disable text-telephony support
Denis Kenzior [Fri, 26 Nov 2010 18:56:43 +0000 (12:56 -0600)]
ctm: Tweak documentation to reflect implementation
Denis Kenzior [Fri, 26 Nov 2010 18:55:50 +0000 (12:55 -0600)]
ctm: fix minor style issues
Lucas De Marchi [Thu, 25 Nov 2010 17:41:58 +0000 (15:41 -0200)]
ctm: add documentation for TextTelephony interface
Lucas De Marchi [Thu, 25 Nov 2010 17:41:57 +0000 (15:41 -0200)]
ctm: Add initial CTM atom implementation