Daniel Stenberg [Fri, 13 Jul 2012 11:38:02 +0000 (13:38 +0200)]
getinfo: use va_end and cut off Curl_ from static funcs
va_end() needs to be used after va_start() and we don't normally use
Curl_ prefixes for purely static functions.
Philip Craig [Fri, 13 Jul 2012 11:04:10 +0000 (21:04 +1000)]
Split up Curl_getinfo
This avoids false positives from clang's scan-build.
Guenter Knauf [Thu, 12 Jul 2012 13:18:00 +0000 (15:18 +0200)]
Added error checking for curl_global_init().
Guenter Knauf [Thu, 12 Jul 2012 13:01:18 +0000 (15:01 +0200)]
Added curl_global_* functions.
Guenter Knauf [Thu, 12 Jul 2012 12:15:58 +0000 (14:15 +0200)]
Minor fixes to MinGW makefiles.
Daniel Stenberg [Thu, 12 Jul 2012 06:40:43 +0000 (08:40 +0200)]
docs: mention CURL_GLOBAL_DEFAULT
Guenter Knauf [Thu, 12 Jul 2012 00:02:22 +0000 (02:02 +0200)]
Added curl_global_* functions.
Daniel Stenberg [Wed, 11 Jul 2012 22:32:23 +0000 (00:32 +0200)]
tests: verify the stricter numeric option parser
Test 1409 and 1410 verifies the stricter numeric option parser
introduced the other day in commit
f2b6ebed7b.
Daniel Stenberg [Wed, 11 Jul 2012 22:07:16 +0000 (00:07 +0200)]
SWS: use of uninitialized memory fix
I made "connmon" not get initialized properly before use, and I use the
big hammer and make sure we always clear the entire struct to avoid any
problem like this in the future.
Daniel Stenberg [Wed, 11 Jul 2012 21:50:19 +0000 (23:50 +0200)]
test48: verify that HEAD doesn't close extra
Two commits ago, we fixed a bug where the connction would be closed
prematurely after a HEAD. Now I added connection-monitor to test 48 and
added a second HEAD and make sure that both are sent over the same
connection.
This triggered a failure before the bug fix and now works. Will help us
avoid a future regression of this kind.
Daniel Stenberg [Wed, 11 Jul 2012 21:49:01 +0000 (23:49 +0200)]
connection-monitor: always log disconnect when enabled
This makes verifying easier and makes us more sure curl closes the
connection only at the correct point in time. Adjusted test 206 and 1008
accordingly and updated the docs for it.
Daniel Stenberg [Wed, 11 Jul 2012 21:13:52 +0000 (23:13 +0200)]
HEAD: don't force-close after response-headers
A HEAD response has no body length and gets the headers like the
corresponding GET would so it should not get closed after the response
based on the same rules. This mistake caused connections that did HEAD
to get closed too often without a valid reason.
Bug: http://curl.haxx.se/bug/view.cgi?id=3542731
Reported by: Eelco Dolstra
Guenter Knauf [Wed, 11 Jul 2012 22:07:01 +0000 (00:07 +0200)]
Removed trailing empty strings from awk script.
Guenter Knauf [Wed, 11 Jul 2012 21:23:19 +0000 (23:23 +0200)]
Cleaned up version awk script.
Guenter Knauf [Wed, 11 Jul 2012 19:59:20 +0000 (21:59 +0200)]
Added project copyright header.
Guenter Knauf [Wed, 11 Jul 2012 15:40:09 +0000 (17:40 +0200)]
Removed libcurl.imp from Makefile.am.
Updated .gitignore for NetWare created files.
Guenter Knauf [Wed, 11 Jul 2012 14:52:48 +0000 (16:52 +0200)]
Added missing dependency to export list.
Guenter Knauf [Wed, 11 Jul 2012 14:01:48 +0000 (16:01 +0200)]
Fixed export list path.
Guenter Knauf [Wed, 11 Jul 2012 13:48:02 +0000 (15:48 +0200)]
Changed NetWare build to generate export list.
Guenter Knauf [Wed, 11 Jul 2012 10:58:54 +0000 (12:58 +0200)]
Added pointer to FAQ for linkage errors.
Guenter Knauf [Wed, 11 Jul 2012 09:54:49 +0000 (11:54 +0200)]
Small NetWare makefile tweak.
Guenter Knauf [Wed, 11 Jul 2012 09:33:08 +0000 (11:33 +0200)]
Changed MinGW makefiles to use WINSSL now.
Daniel Stenberg [Tue, 10 Jul 2012 21:20:05 +0000 (23:20 +0200)]
test231: fix wrong -C use!
Daniel Stenberg [Tue, 10 Jul 2012 21:11:30 +0000 (23:11 +0200)]
cmdline: parse numerical options stricter
1 - str2offset() no longer accepts negative numbers since offsets are by
nature positive.
2 - introduced str2unum() for the command line parser that accepts
numericals which are not supposed to be negative, so that it will
properly complain on apparent bad uses and mistakes.
Bug: http://curl.haxx.se/mail/archive-2012-07/0013.html
Daniel Stenberg [Mon, 9 Jul 2012 17:27:54 +0000 (19:27 +0200)]
docs: switch to proper UTF-8 for text file encoding
Yang Tse [Mon, 9 Jul 2012 13:23:49 +0000 (15:23 +0200)]
Make Curl_schannel_version() return "WinSSL"
Modification based on voting result:
http://curl.haxx.se/mail/lib-2012-07/0104.html
Daniel Stenberg [Mon, 9 Jul 2012 13:25:54 +0000 (15:25 +0200)]
test 46: use different path lengths to get reliable sort order
Since the order of the cookies is sorted by the length of the paths,
having them on the same path length will make the test depend on what
order the qsort() implementation will put them. As seen in the
windows/msys output posted by Guenter in this posting:
http://curl.haxx.se/mail/lib-2012-07/0105.html
Daniel Stenberg [Mon, 9 Jul 2012 13:25:34 +0000 (15:25 +0200)]
cookie: fixed typo in comment
Christian Hägele [Mon, 9 Jul 2012 11:54:13 +0000 (13:54 +0200)]
https_getsock: provided for schannel backend as well
The function https_getsock was only implemented properly when USE_SSLEAY
or USE_GNUTLS is defined, but it is also necessary for USE_SCHANNEL.
The problem occurs when Curl_read_plain or Curl_write_plain returns
CURLE_AGAIN. In that case CURL_OK is returned to the multi-interface an
the used socket is set to state CURL_POLL_REMOVE and the easy-state is
set to CURLM_STATE_PROTOCONNECT. This is fine, because later the socket
should be set to CURL_POLL_IN or CURL_POLL_OUT via multi_getsock. That's
where https_getsock is called and doesn't return any sockets.
Daniel Stenberg [Mon, 9 Jul 2012 11:11:44 +0000 (13:11 +0200)]
RELEASE-NOTES: added a URL reference to cookie docs
Guenter Knauf [Sun, 8 Jul 2012 16:06:15 +0000 (18:06 +0200)]
Removed obsolete include path to project root.
Daniel Stenberg [Sun, 8 Jul 2012 13:48:46 +0000 (15:48 +0200)]
TODO-RELEASE: issue 316 NTLM over proxy is fixed
Nick Zitzmann [Sat, 7 Jul 2012 22:03:16 +0000 (16:03 -0600)]
darwinssl: don't use arc4random_buf
Re-wrote Curl_darwinssl_random() to not use arc4random_buf() because the
function is not available prior to iOS 4.3 and OS X 10.7.
Daniel Stenberg [Sun, 8 Jul 2012 13:37:52 +0000 (15:37 +0200)]
KNOWN_BUGS: #80 Curl doesn't recognize certs in DER format
Daniel Stenberg [Sun, 8 Jul 2012 13:34:58 +0000 (15:34 +0200)]
KNOWN_BUGS: #79 - any RCPT TO failure makes and error
Marc Hoersken [Sun, 8 Jul 2012 08:41:53 +0000 (10:41 +0200)]
winbuild: Aligned BUILD.WINDOWS.txt and Makefile.vc usage help
Marc Hoersken [Thu, 5 Jul 2012 06:53:02 +0000 (08:53 +0200)]
winbuild: Make USE_WINSSL depend on USE_SSPI
Since WinSSL cannot be build without SSPI being enabled,
USE_WINSSL now defaults to the value of USE_SSPI.
The makefile does now raise an error if WinSSL is enabled
while SSPI is disabled.
Marc Hoersken [Thu, 5 Jul 2012 06:49:45 +0000 (08:49 +0200)]
winbuild: Aligned USE_SSPI with other USE_x defines
Renamed external parameter USE_SSPI = yes/no to ENABLE_SSPI = yes/no.
Backwards compatible change: USE_SSPI can still be passed as external
parameter with yes/no value as long as ENABLE_SSPI is not given.
USE_x defines are passed around with true/false values internally,
USE_SSPI is now aligned to this approach, but still accepts external
values yes/no being passed, just like the other defines.
Marc Hoersken [Thu, 5 Jul 2012 06:39:40 +0000 (08:39 +0200)]
winbuild: Clean up formatting and variable naming
- Changed space usage to line up with the whole file
- Renamed CFLAGS_SSPI/IPV6 to SSPI/IPV6_CFLAGS to be
consistent with the other CFLAGS_x variables
- Make use of existing CFLAGS_IPV6 (previously IPV6_CFLAGS)
instead of appending directly to CFLAGS
Nick Zitzmann [Sat, 7 Jul 2012 20:37:52 +0000 (22:37 +0200)]
darwinssl: output cipher with text, remove SNI warning
The code was printing a warning when SNI was set up successfully. Oops.
Printing the cipher number in verbose mode was something only TLS/SSL
programmers might understand, so I had it print the name of the cipher,
just like in the OpenSSL code. That'll be at least a little bit easier
to understand. The SecureTransport API doesn't have a method of getting
a string from a cipher like OpenSSL does, so I had to generate the
strings manually.
Daniel Stenberg [Sat, 7 Jul 2012 12:47:46 +0000 (14:47 +0200)]
RELEASE-NOTES: synced with
5a99bce07d
Daniel Stenberg [Sat, 7 Jul 2012 12:38:50 +0000 (14:38 +0200)]
KNOWN_BUGS: NTLM with unicode works with schannel/winssl!
Bug #75 updated with additional info, still remains for builds with
other backends.
Daniel Stenberg [Thu, 5 Jul 2012 22:19:41 +0000 (00:19 +0200)]
code police: narrow source to < 80 columns
Yang Tse [Thu, 5 Jul 2012 21:41:47 +0000 (23:41 +0200)]
unicode NTLM SSPI: cleanup follow-up
Yang Tse [Thu, 5 Jul 2012 20:16:15 +0000 (22:16 +0200)]
unicode NTLM SSPI: cleanup
Reduce the number of #ifdef UNICODE directives used in source files.
Daniel Stenberg [Thu, 5 Jul 2012 09:20:18 +0000 (11:20 +0200)]
tests: use connection-monitor and verify results
Test 1008 and 206 don't show the disconnect since it happens when SWS
awaits a new request, but 503 does and so the verify section needs that
string added.
Daniel Stenberg [Thu, 5 Jul 2012 09:10:50 +0000 (11:10 +0200)]
http-proxy: keep CONNECT connections alive (for NTLM)
When doing CONNECT requests, libcurl must make sure the connection is
alive as much as possible. NTLM requires it and it is generally good for
other cases as well.
NTLM over CONNECT requests has been broken since this regression I
introduced in my CONNECT cleanup commits that started with
41b02378342,
included since 7.25.0.
Bug: http://curl.haxx.se/bug/view.cgi?id=3538625
Reported by: Marcel Raad
Daniel Stenberg [Thu, 5 Jul 2012 07:49:58 +0000 (09:49 +0200)]
sws: support <servercmd> for CONNECT requests
I moved out the servercmd parsing into a its own function called
parse_servercmd() and made sure it gets used also when the test number
is extracted from CONNECT requests. It turned out sws didn't do that
previously!
Daniel Stenberg [Thu, 5 Jul 2012 07:46:07 +0000 (09:46 +0200)]
FILEFORMAT: provided a full description of connection-monitor
Daniel Stenberg [Thu, 5 Jul 2012 07:32:41 +0000 (09:32 +0200)]
lib503: enable verbose to ease debugging this
Daniel Stenberg [Thu, 5 Jul 2012 07:31:04 +0000 (09:31 +0200)]
sws: add 'connection-monitor' command support
Using this, the server will output in the protocol log when the
connection gets disconnected and thus we will verify correctly in the
test cases that the connection doesn't get closed prematurely. This is
important for example NTLM to work.
Documentation added to FILEFORMAT, test 503 updated to use this.
Guenter Knauf [Wed, 4 Jul 2012 20:14:18 +0000 (22:14 +0200)]
Removed non-used variable.
Guenter Knauf [Wed, 4 Jul 2012 15:03:52 +0000 (17:03 +0200)]
Added error checking for samples.
Guenter Knauf [Wed, 4 Jul 2012 10:54:21 +0000 (12:54 +0200)]
Renamed vars to avoid shadow global declaration.
Daniel Stenberg [Tue, 3 Jul 2012 15:18:36 +0000 (17:18 +0200)]
docs: clarify how to start with curl_multi_socket_action
Mention the CURL_SOCKET_TIMEOUT argument in step 6 of the typical
application.
Guenter Knauf [Tue, 3 Jul 2012 12:31:50 +0000 (14:31 +0200)]
Moved some patterns to subfolder's .gitignore.
Guenter Knauf [Tue, 3 Jul 2012 11:01:17 +0000 (13:01 +0200)]
Merge branch 'master' of ssh://github.com/bagder/curl
Guenter Knauf [Tue, 3 Jul 2012 10:56:41 +0000 (12:56 +0200)]
MinGW makefile tweaks for running from sh.
Added function macros to make path converting easier.
Added CROSSPREFIX to all compile tools.
Marc Hoersken [Tue, 3 Jul 2012 07:16:00 +0000 (09:16 +0200)]
curl_ntlm_msgs.c: Removed unused variable passwd
Guenter Knauf [Tue, 3 Jul 2012 09:36:24 +0000 (11:36 +0200)]
Added files generated by mingw32, eclipse and VC.
Posted by Marc Hoersken.
Daniel Stenberg [Tue, 3 Jul 2012 09:27:45 +0000 (11:27 +0200)]
cookies: change the URL in the cookie jar file header
Daniel Stenberg [Tue, 3 Jul 2012 09:10:41 +0000 (11:10 +0200)]
HTTP-COOKIES: clarified and modified layout
Daniel Stenberg [Tue, 3 Jul 2012 08:54:46 +0000 (10:54 +0200)]
HTTP-COOKIES: use the FAQ document layout
Daniel Stenberg [Tue, 3 Jul 2012 07:03:08 +0000 (09:03 +0200)]
HTTP-COOKIES: added cookie documentation
Yang Tse [Mon, 2 Jul 2012 22:14:14 +0000 (00:14 +0200)]
curl_ntlm_msgs.c: include <tchar.h> for prototypes
Neil Bowers [Mon, 2 Jul 2012 21:22:10 +0000 (23:22 +0200)]
testcurl.pl: fix missing semicolon
Christian Hägele [Mon, 2 Jul 2012 20:59:54 +0000 (22:59 +0200)]
unicode NTLM SSPI: heap corruption fixed
When compiling libcurl with UNICODE defined and using unicode characters
in username.
Yang Tse [Mon, 2 Jul 2012 18:21:48 +0000 (20:21 +0200)]
testcurl.pl: allow non in-tree c-ares enabled autobuild
Yang Tse [Mon, 2 Jul 2012 14:42:54 +0000 (16:42 +0200)]
configure.ac: verify that libmetalink is new enough
Enabling test2017 to test2022.
Tatsuhiro Tsujikawa [Sat, 30 Jun 2012 12:17:44 +0000 (21:17 +0900)]
curl: Added runtime version check for libmetalink
Tatsuhiro Tsujikawa [Sat, 30 Jun 2012 12:07:38 +0000 (21:07 +0900)]
Include metalink/metalink.h for libmetalink functions
Daniel Stenberg [Sun, 1 Jul 2012 22:10:59 +0000 (00:10 +0200)]
errors: CURLM_CALL_MULTI_PERFORM is not returned anymore
Daniel Stenberg [Sun, 1 Jul 2012 18:09:35 +0000 (20:09 +0200)]
release: cleaned up plans for this and coming release
Yang Tse [Fri, 29 Jun 2012 14:40:23 +0000 (16:40 +0200)]
curl-compilers.m4: remove -Wstrict-aliasing=3 from clang
Currently it is unknown if there is any version of clang that
actually supports -Wstrict-aliasing. What is known is that there
are several that don't support it.
Yang Tse [Fri, 29 Jun 2012 14:02:10 +0000 (16:02 +0200)]
test2017 to test2022: more metalink tests
With this commit, checks done in previous test2017 are now done in test2018.
Whole range test2017 to test2022 DISABLED until configure is capable of
requiring a new-enough metalink library.
Don't try these without mentioned check in place!
Yang Tse [Fri, 29 Jun 2012 13:44:50 +0000 (15:44 +0200)]
test2005 to test2016: improve failure detection
Yang Tse [Thu, 28 Jun 2012 15:14:41 +0000 (17:14 +0200)]
lib582.c: fix conversion warning
Yang Tse [Thu, 28 Jun 2012 14:58:07 +0000 (16:58 +0200)]
nss.c: #include warnless.h for curlx_uztosi and curlx_uztoui prototypes
Marc Hoersken [Thu, 28 Jun 2012 13:48:32 +0000 (15:48 +0200)]
nss.c: Fixed size_t conversion warnings
Yang Tse [Thu, 28 Jun 2012 10:49:12 +0000 (12:49 +0200)]
sslgen.c: cleanup temporary compile-time SSL-backend check
Daniel Stenberg [Wed, 27 Jun 2012 21:36:07 +0000 (23:36 +0200)]
schannel: provide two additional (dummy) API defines
Tatsuhiro Tsujikawa [Wed, 27 Jun 2012 15:20:20 +0000 (00:20 +0900)]
Metalink: message updates
Print "parsing (...) OK" only when no warnings are generated. If
no file is found in Metalink, treat it FAILED.
If no digest is provided, print WARNING in parse_metalink().
Also print validating FAILED after download.
These changes make tests 2012 to 2016 pass.
Daniel Stenberg [Wed, 27 Jun 2012 21:15:56 +0000 (23:15 +0200)]
sslgen: avoid compiler error in SSPI builds
Yang Tse [Wed, 27 Jun 2012 17:06:43 +0000 (19:06 +0200)]
ssluse.c: fix compiler warning: conversion to 'int' from 'size_t'
Reported by Tatsuhiro Tsujikawa
http://curl.haxx.se/mail/lib-2012-06/0371.html
Yang Tse [Wed, 27 Jun 2012 15:14:59 +0000 (17:14 +0200)]
sslgen.c: add compile-time check for SSL-backend completeness
Yang Tse [Wed, 27 Jun 2012 15:13:16 +0000 (17:13 +0200)]
build: add our standard includes to curl_darwinssl.c and curl_multibyte.c
Yang Tse [Wed, 27 Jun 2012 12:04:42 +0000 (14:04 +0200)]
build: add curl_schannel and curl_darwinssl files to other build systems
Yang Tse [Wed, 27 Jun 2012 11:15:05 +0000 (13:15 +0200)]
tests: add five more Metalink test cases
Yang Tse [Wed, 27 Jun 2012 11:08:46 +0000 (13:08 +0200)]
tests: update Metalink message format
Tatsuhiro Tsujikawa [Tue, 26 Jun 2012 13:55:16 +0000 (22:55 +0900)]
Metalink: updated message format
Nick Zitzmann [Wed, 27 Jun 2012 09:57:31 +0000 (11:57 +0200)]
DarwinSSL: allow using NTLM authentication
Allow NTLM authentication when building using SecureTransport (Darwin) for SSL.
This uses CommonCrypto, a cryptography library that ships with all versions of
iOS and Mac OS X. It's like OpenSSL's libcrypto, except that it's missing a few
less-common cyphers and doesn't have a big number data structure.
Yang Tse [Wed, 27 Jun 2012 08:55:54 +0000 (10:55 +0200)]
curl_darwinssl.h: add newline at end of file
Daniel Stenberg [Tue, 26 Jun 2012 18:05:26 +0000 (20:05 +0200)]
ossl_seed: remove leftover RAND_screen check
Before commit
2dded8fedba (dec 2010) there was logic that used
RAND_screen() at times and now I remove the leftover #ifdef check for
it.
The seeding code that uses Curl_FormBoundary() in ossl_seed() is dubious
to keep since it hardly increases randomness but I fear I'll break
something if I remove it now...
Nick Zitzmann [Tue, 26 Jun 2012 19:39:48 +0000 (21:39 +0200)]
DarwinSSL: several adjustments
- Renamed st_ function prefix to darwinssl_
- Renamed Curl_st_ function prefix to Curl_darwinssl_
- Moved the duplicated ssl_connect_done out of the #ifdef in lib/urldata.h
- Fixed a teensy little bug that made non-blocking connection attempts block
- Made it so that it builds cleanly against the iOS 5.1 SDK
Yang Tse [Tue, 26 Jun 2012 19:22:36 +0000 (21:22 +0200)]
curl-compilers.m4: -Wstrict-aliasing=3 for warning enabled gcc and clang builds
Marc Hoersken [Tue, 26 Jun 2012 05:27:02 +0000 (07:27 +0200)]
sockaddr.h: Fixed dereferencing pointer breakin strict-aliasing
Fixed warning: dereferencing pointer does break strict-aliasing rules
by using a union inside the struct Curl_sockaddr_storage declaration.
Daniel Stenberg [Tue, 26 Jun 2012 12:52:46 +0000 (14:52 +0200)]
SSL cleanup: use crypto functions through the sslgen layer
curl_ntlm_msgs.c would previously use an #ifdef maze and direct
SSL-library calls instead of using the SSL layer we have for this
purpose.
Nick Zitzmann [Tue, 26 Jun 2012 12:01:51 +0000 (14:01 +0200)]
darwinssl: add support for native Mac OS X/iOS SSL
Daniel Stenberg [Mon, 25 Jun 2012 21:03:52 +0000 (23:03 +0200)]
RELEASE-NOTES: link to more metalink info
Daniel Stenberg [Mon, 25 Jun 2012 21:02:32 +0000 (23:02 +0200)]
RELEASE-NOTES: synced with
d025af9bb576