Lennart Poettering [Thu, 27 Nov 2014 02:20:51 +0000 (03:20 +0100)]
sd-bus: deal with whitespace in matches
Lennart Poettering [Thu, 27 Nov 2014 01:57:22 +0000 (02:57 +0100)]
sd-bus: unify logic how we patch the message source of driver messages
Lennart Poettering [Thu, 27 Nov 2014 01:37:05 +0000 (02:37 +0100)]
sd-bus: fake valid well-known-names metadata for faked bus messages
Lennart Poettering [Thu, 27 Nov 2014 01:28:23 +0000 (02:28 +0100)]
sd-bus: optimize how we generate the well-known-names lists in messages from kdbus
Lennart Poettering [Thu, 27 Nov 2014 00:19:50 +0000 (01:19 +0100)]
sd-bus: be stricter with mismatches between dbus1 and kdbus message headers
Lennart Poettering [Wed, 26 Nov 2014 22:14:13 +0000 (23:14 +0100)]
bus-proxy: beef up policy enforcement
- actually return permission errors to clients
- use the right ucreds field
- fix error paths when we cannot keep track of locally acquired names
due to OOM
- avoid unnecessary global variables
- log when the policy denies access
- enforce correct policy rule order
- always request all the metadata its we need to make decisions
Lennart Poettering [Wed, 26 Nov 2014 22:13:52 +0000 (23:13 +0100)]
update TODO
Lennart Poettering [Wed, 26 Nov 2014 21:52:10 +0000 (22:52 +0100)]
bus-proxy: check passed parameter signature of all driver method calls
Alin Rauta [Thu, 27 Nov 2014 17:50:48 +0000 (18:50 +0100)]
networkd: fix kernel rtnl receive buffer overrun error
We got the following error when running systemd on a device with many ports:
"rtnl: kernel receive buffer overrun
Event source 'rtnl-receive-message' returned error, disabling: No buffer space
available"
I think the kernel socket receive buffer queue should be increased. The default
value is taken from:
"/proc/sys/net/core/rmem_default", but we can overwrite it using SO_RCVBUF
socket option.
This is already done in networkd for other sockets.
For example, the bus socket (sd-bus/bus-socket.c) has a receive queue of 8MB.
In our case, the default is 208KB.
Increasing the buffer receive queue for manager socket to 512KB should be enough
to get rid of the above error.
[tomegun: bump the limit even higher to 8M]
Stanisław Pitucha [Tue, 18 Nov 2014 03:52:13 +0000 (14:52 +1100)]
resolve: reject empty TXT records
TXT records should have at least one character, so enforce this.
Before 0f84a72 parser SIGSEGV'd on ->txt.strings being NULL, but
even if this is fixed we should reject invalid TXT records.
Stanisław Pitucha [Tue, 18 Nov 2014 05:40:18 +0000 (16:40 +1100)]
resolve: set error code on failure
Set the error code in case of incorrect name. This prevents continuing
and failing an assert(name) later on.
Stanisław Pitucha [Tue, 18 Nov 2014 05:25:20 +0000 (16:25 +1100)]
resolve: fix redirection loops in compressed RR
Loops in RR compression were only detected for the first entry.
Multiple redirections should be allowed, each one checking for an
infinite loop on its own starting point.
Also update the pointer on each redirection to avoid longer loops of
labels and redirections, in names like:
(start) [len=1] "A", [ptr to start]
(David: rename variable to "jump_barrier" and add reference to RFC)
Michal Schmidt [Thu, 27 Nov 2014 14:23:58 +0000 (15:23 +0100)]
core: fix transaction destructiveness check once more
The previous fix
e0312f4db "core: fix check for transaction
destructiveness" broke test-engine (noticed by Zbyszek).
Apparently I had a wrong idea of the intended semantics of --fail.
The manpage says the operation should fail if it "conflicts with a
pending job (more specifically: causes an already pending start job to
be reversed into a stop job or vice versa)".
So let's check job_type_is_conflicting, instead of !is_superset.
This makes both test-engine and TEST-03-JOBS pass again.
David Herrmann [Thu, 27 Nov 2014 15:08:46 +0000 (16:08 +0100)]
resolve: fix NULL deref on strv comparison
A strv might be NULL if it is empty. The txt.strings comparison doesn't
take that into account. Introduce strv_equal() to provide a proper helper
for this and fix resolve to use it.
Thanks to Stanisław Pitucha <viraptor@gmail.com> for reporting this!
David Herrmann [Thu, 27 Nov 2014 12:49:41 +0000 (13:49 +0100)]
bus: prefix custom endpoints with "$UID-"
The kdbus module will later get a policy that endpoint-names are
restricted to "<uid>-<name>" just like bus-names. Make sure that systemd
is already compatible to that.
Peter Hutterer [Tue, 25 Nov 2014 11:35:16 +0000 (21:35 +1000)]
hwdb: add a new db for the DPI/frequency settings of mice
Pointer acceleration for relative input devices (mice, trackballs, etc.)
applies to the deltas of the device. Alas, those deltas have no physical
reference point - a delta of 10 may be caused by a large movement of a
low-dpi mouse or by a minute movement of a high-dpi mouse.
Which makes pointer acceleration a bit useless and high-dpi devices
essentially unusable.
In an ideal world, we could read the DPI from the device directly and work
with that. In the world we actually live in, we need to compile this list
manually. This patch introduces the database, with the usual match formats
and a single property to be set on a device: MOUSE_DPI
That is either a single value for most mice, or a list of values for mice
that can change resolution at runtime. The exact format is detailed in the
hwdb file.
Note that we're explicitly overshooting the requirements we have for
libinput atm. Frequency could be detected in software and we don't
actually use the list of multiple resolutions (because we can't detect
when they change anyway). However, we might as well collect those values
from the get-go, adding/modifying what will eventually amount to hundreds
of entries is a bit cumbersome.
Note: we rely on the input_id builtin to tag us as mouse first, ordering
of the rules is important.
(David: fixed up typos and moved hwdb file into ./hwdb/)
Ivan Shapovalov [Tue, 25 Nov 2014 18:58:14 +0000 (21:58 +0300)]
unit-name: fix escaping logic in unit_name_mangle_with_suffix()
Make screened character set consistent with unit_name_mangle() by splitting off
the escaping loop into a separate function.
Before this fix, unit names such as `foo@bar.target` would get transformed
into `foo\x40bar.target` when unit_name_mangle_with_suffix() is used.
https://bugs.freedesktop.org/show_bug.cgi?id=86711
Zbigniew Jędrzejewski-Szmek [Thu, 27 Nov 2014 04:31:35 +0000 (23:31 -0500)]
coredump: use openat
Andrej Manduch [Tue, 25 Nov 2014 19:47:49 +0000 (20:47 +0100)]
journalctl: print all possible lines immediately with --follow + --since
When I tryed to run journalctl with --follow and --since arguments it
behaved very strangely.
First It prints logs from what I specified in --since argument, then
printed 10 lines (as is default in --follow) and when app put something
new in to log journalctl printed everithing from the last printed line.
How to reproduce:
1. run: journalctl -m --since 14:00 --follow
Then you'll see 10 lines of logs since 14:00. After that wait until some
app add something in the journal or just run `systemd-cat echo test`
2. After that journalctl will print every single line since 14:00 and will
follow as expected.
As long as --since and --follow will eventually print all relevant
lines, I seen no reason why not to print them right away and not after
first new message in journal.
Relevant bugzillas:
https://bugs.freedesktop.org/show_bug.cgi?id=71546
https://bugs.freedesktop.org/show_bug.cgi?id=64291
Jakub Filak [Tue, 25 Nov 2014 06:37:48 +0000 (07:37 +0100)]
coredump: collect all /proc data useful for bug reporting
/proc/[pid]:
- status
- maps
- limits
- cgroup
- cwd
- root
- environ
- fd/ & fdinfo/ joined in open_fds
Jakub Filak [Tue, 25 Nov 2014 06:37:47 +0000 (07:37 +0100)]
util: add function getting proc environ
On the contrary of env, the added function returns all characters
cescaped, because it improves reproducibility.
Gavin Li [Mon, 24 Nov 2014 23:51:31 +0000 (15:51 -0800)]
networkd: route - allow routes without a gateway
For IPv6, the kernel returns EINVAL if a route is added with the
RTA_GATEWAY attribute set to in6addr_any (::). A route without a
gateway is useful in some situations, such as layer 3 tunneling
(sit, gre, etc.).
This patch prevents the RTA_GATEWAY attribute from being added
when route.in_addr is ip6addr_any (::).
Łukasz Stelmach [Wed, 26 Nov 2014 08:17:50 +0000 (09:17 +0100)]
build-sys: do not install tmpfiles and sysusers files by default
Sean Young [Wed, 26 Nov 2014 09:33:30 +0000 (09:33 +0000)]
timesyncd: do not keep listening socket open forever
This also makes the source port less predicatable.
Josh Triplett [Wed, 29 Oct 2014 12:10:48 +0000 (05:10 -0700)]
logind: Support logind.conf.d directories in the usual search paths
This makes it possible to drop in logind configuration snippets from a
package or other configuration management mechanism.
Add documentation to the header of /etc/logind.conf pointing the user at
/etc/logind.conf.d/*.conf.
Introduce a new helper, conf_parse_many, to parse configuration files in
a search path.
Josh Triplett [Wed, 29 Oct 2014 12:02:56 +0000 (05:02 -0700)]
Introduce CONF_DIRS_NULSTR helper to define standard conf dirs
Several different systemd tools define a nulstr containing a standard
series of configuration file directories, in /etc, /run, /usr/local/lib,
/usr/lib, and (#ifdef HAVE_SPLIT_USR) /lib. Factor that logic out into
a new helper macro, CONF_DIRS_NULSTR.
Zbigniew Jędrzejewski-Szmek [Wed, 26 Nov 2014 20:05:55 +0000 (15:05 -0500)]
journald: proceed even if some sockets are unknown
systemd-journald would refuse to start if it received an unknown
socket from systemd. This is annoying, because the failure more for
systemd-journald is unpleasant: systemd will keep restarting journald,
but most likely the same error will occur every time. It is better
to continue. journald will try to open missing sockets on its own,
so things should mostly work.
One question is whether to close the sockets which cannot be parsed or
to keep them open. Either way we might lose some messages. This
failure is most likely for the audit socket (selinux issues), which
can be opened multiple times so this not a problem, so I decided to
keep them open because it makes it easier to debug the issue after the
system is fully started.
Zbigniew Jędrzejewski-Szmek [Wed, 26 Nov 2014 15:36:52 +0000 (10:36 -0500)]
swap: restore support for nofail
systemd stops adding automatic dependencies on swap.target to swap
units. If a dependency is required, it has to be added by unit
configuration. fstab-generator did that already, except that now it is
modified to create a Requires or Wants type dependency, depending on
whether nofail is specified in /etc/fstab. This makes .swap units
obey the nofail/noauto options more or less the same as .mount units.
Documentation is extended to clarify that, and to make
systemd.mount(5) and system.swap(5) more similar. The gist is not
changed, because current behaviour actually matches existing
documentation.
https://bugs.freedesktop.org/show_bug.cgi?id=86488
Zbigniew Jędrzejewski-Szmek [Thu, 6 Nov 2014 05:05:38 +0000 (00:05 -0500)]
manager: print fatal errors on the console too
When booting in quiet mode, fatal messages would not be shown at all to the user.
https://bugzilla.redhat.com/show_bug.cgi?id=1155468
Zbigniew Jędrzejewski-Szmek [Thu, 6 Nov 2014 05:04:06 +0000 (00:04 -0500)]
manager: log some fatal errors at emergency level
This adds a new log_emergency() function, which is equivalent to
log_error() for non-PID-1, and logs at the highest priority for PID 1.
Some messages which occur before freezing are converted to use it.
Lennart Poettering [Wed, 26 Nov 2014 20:15:39 +0000 (21:15 +0100)]
bus-policy: actually test messages against the newly added test.conf
Lennart Poettering [Wed, 26 Nov 2014 19:58:34 +0000 (20:58 +0100)]
bus-policy: also add in other bus policy tests from dbus1
dbus1 only checks if these files parse correctly so let's do the same for now.
Lennart Poettering [Wed, 26 Nov 2014 19:22:22 +0000 (20:22 +0100)]
bus-policy: steal a test case for prefix ownership from dbus1, and make sure it passes with the bus proxy enforcement
Lennart Poettering [Wed, 26 Nov 2014 17:59:31 +0000 (18:59 +0100)]
sd-bus: make sure that when we connect to the system bus we have enough creds to make security decisions
Lennart Poettering [Wed, 26 Nov 2014 17:57:37 +0000 (18:57 +0100)]
core: make sure we have enough information when doing selinux decisions
Let's ask for the security relevant bits in a race-free way, and augment
the rest from /proc.
Lennart Poettering [Wed, 26 Nov 2014 16:27:13 +0000 (17:27 +0100)]
update TODO
Lennart Poettering [Wed, 26 Nov 2014 14:54:53 +0000 (15:54 +0100)]
sd-bus: update peeking into receieved messages, with recent kernel change we need to FREE them after all
Michal Schmidt [Wed, 26 Nov 2014 15:33:46 +0000 (16:33 +0100)]
core: fix check for transaction destructiveness
When checking if the transaction is destructive, we need to check if the
previously installed job is a superset of the new job (and hence the new
job will fold into the installed one without changing it), not the other
way around.
Michal Schmidt [Wed, 26 Nov 2014 15:33:45 +0000 (16:33 +0100)]
core: drop now-redundant special-casing of JOB_NOP
job_type_is_conflicting(X, JOB_NOP) correctly gives: false.
job_type_allows_late_merge(JOB_NOP) && job_type_is_superset(X, JOB_NOP)
correctly gives: true.
Michal Schmidt [Wed, 26 Nov 2014 15:33:43 +0000 (16:33 +0100)]
core: fix assertion failure in checking a transaction with a JOB_NOP
Several functions called from transaction_activate() need to correctly
handle the case where a JOB_NOP job is being checked against a unit's
pending job. The assumption that JOB_NOP never merges with other job
types was correct, but since the job_type_is_*() functions are
implemented using the merge lookup, they need to special-case JOB_NOP
to avoid hitting assertion failures.
Michal Schmidt [Wed, 26 Nov 2014 15:33:40 +0000 (16:33 +0100)]
test: add test for crash when adding a JOB_NOP
Lennart Poettering [Wed, 26 Nov 2014 14:43:50 +0000 (15:43 +0100)]
sd-bus: update kdbus.h from upstream
Lennart Poettering [Wed, 26 Nov 2014 14:43:20 +0000 (15:43 +0100)]
core: reindent mount/kmod tables
Lennart Poettering [Wed, 26 Nov 2014 14:42:54 +0000 (15:42 +0100)]
update TODO
Lennart Poettering [Wed, 26 Nov 2014 14:01:50 +0000 (15:01 +0100)]
update TODO
Lennart Poettering [Wed, 26 Nov 2014 13:59:12 +0000 (14:59 +0100)]
sd-bus: given that the kernel now passes the auxgroups list as 32bit array to us, no need to convert to uid_t manually
This way, we can save one allocation and avoid copying the array
unnecesarily.
Lennart Poettering [Wed, 26 Nov 2014 13:14:17 +0000 (14:14 +0100)]
update TODO
Lennart Poettering [Wed, 26 Nov 2014 11:11:39 +0000 (12:11 +0100)]
update TODO
David Herrmann [Wed, 26 Nov 2014 10:11:54 +0000 (11:11 +0100)]
bus: update kdbus.h (ABI break)
We changed creds to u32, so fix systemd sd-bus to acknowledge that.
Lennart Poettering [Wed, 26 Nov 2014 02:18:17 +0000 (03:18 +0100)]
reorder TODO a bit
Zbigniew Jędrzejewski-Szmek [Wed, 26 Nov 2014 01:32:03 +0000 (20:32 -0500)]
udevadm trigger: allow matching by device name
This makes udevadm trigger mirror udevadm info, except that multiple
device names can be specified. Instructions in 60-keyboard.hwdb should
now actually work.
udevadm(8) is updated, but it could use a bit more polishing.
https://bugs.freedesktop.org/show_bug.cgi?id=82311
Zbigniew Jędrzejewski-Szmek [Wed, 26 Nov 2014 00:39:19 +0000 (19:39 -0500)]
udevadm: split out find_device helper
The idea is to unify the way that devices can be specified.
Lennart Poettering [Wed, 26 Nov 2014 01:55:42 +0000 (02:55 +0100)]
update TODO
Lennart Poettering [Wed, 26 Nov 2014 01:54:41 +0000 (02:54 +0100)]
bus-kernel: when installing an activator, ask for any kind of metadata to be attached to incoming messages
We don't know what the activated service might want in the end, hence
enable everything current and future, just to be sure.
Lennart Poettering [Wed, 26 Nov 2014 01:54:11 +0000 (02:54 +0100)]
sd-bus: don't clobber return values on failure in bus_kernel_open_bus_fd()
Lennart Poettering [Wed, 26 Nov 2014 01:50:49 +0000 (02:50 +0100)]
sd-bus: set per-bus attach flag requirement mask to ANY
On the system and user busses we create it's the receiver that chooses
which metadata is attched, not the sender, hence set the requirement
mask to ANY, to allow any current of future credential bit to be
attached.
Lennart Poettering [Wed, 26 Nov 2014 01:21:15 +0000 (02:21 +0100)]
update TODO
Lennart Poettering [Wed, 26 Nov 2014 01:20:28 +0000 (02:20 +0100)]
sd-bus: add suppot for renegotiating message credential attach flags
Lennart Poettering [Wed, 26 Nov 2014 00:45:14 +0000 (01:45 +0100)]
sd-bus: use free_and_strdup() where appropriate
This simplifies things a bit and makes sure we free any previously set
creds component before writing in a new one.
Tom Gundersen [Tue, 25 Nov 2014 21:30:29 +0000 (22:30 +0100)]
resolved: fix typo in sd_notify() call
Lennart Poettering [Tue, 25 Nov 2014 19:50:55 +0000 (20:50 +0100)]
update TODO
Lennart Poettering [Tue, 25 Nov 2014 18:32:48 +0000 (19:32 +0100)]
core: show log message about process triggering kdbus service activation
Lennart Poettering [Tue, 25 Nov 2014 18:54:18 +0000 (19:54 +0100)]
sd-bus: react properly to EOVERFLOW by generating a log message about dropped broadcast messages and proceeding
Lennart Poettering [Tue, 25 Nov 2014 18:25:33 +0000 (19:25 +0100)]
kdbus: update header file to current upstream version
Lennart Poettering [Tue, 25 Nov 2014 18:25:19 +0000 (19:25 +0100)]
kdbus: minor simplification
Lennart Poettering [Tue, 25 Nov 2014 18:25:03 +0000 (19:25 +0100)]
update TODO
Lennart Poettering [Tue, 25 Nov 2014 18:24:45 +0000 (19:24 +0100)]
util: mark page_size() as pure
Lennart Poettering [Tue, 25 Nov 2014 12:24:08 +0000 (13:24 +0100)]
update TODO
Lennart Poettering [Tue, 25 Nov 2014 12:23:44 +0000 (13:23 +0100)]
sd-bus: fix error handling when receiving invalid service name
Also, properly keep track of incoming additional service names.
Lennart Poettering [Tue, 25 Nov 2014 12:22:55 +0000 (13:22 +0100)]
sd-bus: properly handle non-initialized audit records attached to incoming kernel messages
Lennart Poettering [Tue, 25 Nov 2014 12:22:19 +0000 (13:22 +0100)]
sd-bus: properly copy selinux label and description field when duplicating creds object
Lennart Poettering [Tue, 25 Nov 2014 12:21:23 +0000 (13:21 +0100)]
sd-bus: add supplementary groups list to creds object
Lennart Poettering [Tue, 25 Nov 2014 01:11:57 +0000 (02:11 +0100)]
busctl: if no parameter is specified for "busctl status" show credentials of bus owner
Lennart Poettering [Tue, 25 Nov 2014 00:59:48 +0000 (01:59 +0100)]
sd-bus: properly handle uninitialized audit creds from kdbus
Lennart Poettering [Mon, 24 Nov 2014 21:11:53 +0000 (22:11 +0100)]
sd-bus: don't fail when querying creds and dbus1 refuses to tell us the selinux context
Lennart Poettering [Mon, 24 Nov 2014 20:53:29 +0000 (21:53 +0100)]
busctl: add new --augment-creds= switch for controlling whether shown credential data shall be augment with data from /proc
Lennart Poettering [Mon, 24 Nov 2014 20:41:40 +0000 (21:41 +0100)]
sd-bus: update to current kernel version, by splitting off the extended KDBUS_ITEM_PIDS structure from KDBUS_ITEM_CREDS
Also:
- adds support for euid, suid, fsuid, egid, sgid, fsgid fields.
- makes augmentation of creds with data from /proc explicitly
controllable to give apps better control over this, given that this is
racy.
- enables augmentation for kdbus connections (previously we only did it
for dbus1). This is useful since with recent kdbus versions it is
possible for clients to control the metadata they want to send.
- changes sd_bus_query_sender_privilege() to take the euid of the client
into consideration, if known
- when we don't have permissions to read augmentation data from /proc,
don't fail, just don't add the data in
Lennart Poettering [Mon, 24 Nov 2014 20:39:18 +0000 (21:39 +0100)]
busctl: improve readability a bit
Lennart Poettering [Mon, 24 Nov 2014 20:37:26 +0000 (21:37 +0100)]
bus: change creds dumping order to be more close to internal storage order
Lennart Poettering [Mon, 24 Nov 2014 20:21:24 +0000 (21:21 +0100)]
util: skip incomplete ucred information in getpeersec()
Lennart Poettering [Mon, 24 Nov 2014 20:20:53 +0000 (21:20 +0100)]
sd-bus: don't blindly take incomplete ucred bits from AF_UNIX when constructing message
Lennart Poettering [Mon, 24 Nov 2014 16:55:44 +0000 (17:55 +0100)]
update TODO
Peter Hutterer [Tue, 25 Nov 2014 10:45:50 +0000 (20:45 +1000)]
hwdb: fix a typo
Martin Pitt [Tue, 25 Nov 2014 10:39:30 +0000 (11:39 +0100)]
tmpfiles.d: Fix directory name
The .service uses "/var/lib/container", not "containers".
David Herrmann [Tue, 25 Nov 2014 09:26:08 +0000 (10:26 +0100)]
localed: verify xkb keymaps after pk-queries
Make sure not to run xkb-keymap validation twice if pk-queries are used.
Move it below pk-checks.
David Herrmann [Tue, 25 Nov 2014 09:24:39 +0000 (10:24 +0100)]
terminal/idev: forward xkb-messages
Properly forward all XKB messages. You can use XKB_LOG_VERBOSITY= to
control the amount of messages sent by XKB. We explicitly set
XKB_LOG_LEVEL to 7 you can use SYSTEMD_LOG_LEVEL to control the log-level
generically.
David Herrmann [Tue, 25 Nov 2014 09:24:08 +0000 (10:24 +0100)]
terminal/idev: avoid magic numbers
Use XKB_CONTEXT_NO_FLAGS instead of magic 0.
David Herrmann [Mon, 24 Nov 2014 17:25:30 +0000 (18:25 +0100)]
terminal/idev: use compose tables
Before forwarding keyboard events, feed them into possible compose tables.
This enables Compose-key and Dead-key features.
Few notes:
* REPEAT events are never fed into compose tables. It just doesn't make
sense and is usually not wanted. Compose-sequences are usually hard to
remember and take time to type. Thus, the REPEAT event of the
Compose-key itself would often cancel the compose sequence already.
* Stop resolving symbols for UP events. Anything but keycodes is never
associated to a physical key, but is a one-time action. There is
nothing like UP events for key-symbols!
* Cancel compose-sequences on Multi-Key UP. See the inline comment. We
should make this configurable!
David Herrmann [Mon, 24 Nov 2014 15:32:54 +0000 (16:32 +0100)]
terminal/idev: add compose-file support
Add support for compose files to idev-keyboard. This requires
libxkbcommon-0.5.0, which is pretty new, but should be fine.
We don't use the compose-files, yet. Further commits will put life into
them.
WaLyong Cho [Mon, 24 Nov 2014 11:46:20 +0000 (20:46 +0900)]
smack: introduce new SmackProcessLabel option
In service file, if the file has some of special SMACK label in
ExecStart= and systemd has no permission for the special SMACK label
then permission error will occurred. To resolve this, systemd should
be able to set its SMACK label to something accessible of ExecStart=.
So introduce new SmackProcessLabel. If label is specified with
SmackProcessLabel= then the child systemd will set its label to
that. To successfully execute the ExecStart=, accessible label should
be specified with SmackProcessLabel=.
Additionally, by SMACK policy, if the file in ExecStart= has no
SMACK64EXEC then the executed process will have given label by
SmackProcessLabel=. But if the file has SMACK64EXEC then the
SMACK64EXEC label will be overridden.
[zj: reword man page]
Zbigniew Jędrzejewski-Szmek [Mon, 24 Nov 2014 01:01:40 +0000 (20:01 -0500)]
gpt-auto-generator: properly ignore value
A negative return code was treated as a true value.
David Herrmann [Mon, 24 Nov 2014 14:39:00 +0000 (15:39 +0100)]
build-sys: support local ./configure arguments
I often want to use the awesome "./autogen.sh [cmd]" arguments, but have
to append some custom ./configure options. For now, I always had to edit
autogen.sh manually, or copy the full commands out of it and run it
myself.
As I think this is super annoying, this commit adds support for
".config.args" files in $topdir. If it exists, any content is just
appended to $args, thus to any ./configure invokation of autogen.sh.
Maybe autotools provide something similar out-of-the-box. In that case,
feel free to revert this and lemme know!
David Herrmann [Mon, 24 Nov 2014 14:12:42 +0000 (15:12 +0100)]
localed: validate xkb keymaps
Introduce a new optional dependency on libxkbcommon for systemd-localed.
Whenever the x11 keymap settings are changed, use libxkbcommon to compile
the keymap. If the compilation fails, print a warning so users will get
notified.
On compilation failure, we still update the keymap settings for now. This
patch just introduces the xkbcommon infrastructure to have keymap
validation in place. We can later decide if/how we want to enforce this.
Zbigniew Jędrzejewski-Szmek [Mon, 24 Nov 2014 14:11:12 +0000 (09:11 -0500)]
cryptsetup: default to no hash when keyfile is specified
For plain dm-crypt devices, the behavior of cryptsetup package is to
ignore the hash algorithm when a key file is provided. It seems wrong
to ignore a hash when it is explicitly specified, but we should default
to no hash if the keyfile is specified.
https://bugs.freedesktop.org/show_bug.cgi?id=52630
Zbigniew Jędrzejewski-Szmek [Thu, 6 Nov 2014 03:39:13 +0000 (22:39 -0500)]
manager: only issue overmount warning when the check succeeded
If for any reason the check failed (selinux?), we would still issue
the warning. Check the return status.
Zbigniew Jędrzejewski-Szmek [Sat, 8 Nov 2014 15:06:12 +0000 (10:06 -0500)]
manager: let manager_free() handle NULLs
This makes the calling code a bit simpler.
Lukas Nykryn [Thu, 20 Nov 2014 15:06:18 +0000 (16:06 +0100)]
dbus: return non-zero return value in the case that prefix won't match
strv_extend returns 0 in the case of success which means that
else if (bus_track_deserialize_item(&m->deserialized_subscribed, l) == 0)
log_warning("Unknown serialization item '%s'", l);
will be printed when value is added correctly.
Iago López Galeiras [Thu, 20 Nov 2014 20:18:23 +0000 (21:18 +0100)]
test: support empty environment variables in unit files
Also update TODO, empty environment variables in Environment= and
EnvironmentFile= options work.
Zbigniew Jędrzejewski-Szmek [Sun, 23 Nov 2014 16:07:15 +0000 (11:07 -0500)]
man: reword list-dependencies description
The previous version was a bit too vague. It is better
to simply list all dependency types that are followed.
Previous version also made an emphasis on dependencies introduced by
configuration. But this command (or systemd) don't care about this
distinction between configured and automatically added dependencies at
all. This distinctionis removed from the main description, and an
explanatory paragraph is added to remind the user that all
dependencies are shown, no matter where they come from.
Zbigniew Jędrzejewski-Szmek [Sun, 23 Nov 2014 01:21:56 +0000 (20:21 -0500)]
systemctl: show BindsTo/BoundBy in list-dependencies
Suggested-by: Peter Mattern <matternp@arcor.de>
http://lists.freedesktop.org/archives/systemd-devel/2014-November/025437.html