platform/upstream/connman.git
11 years agovpn: Make sure vpn connection really exists before removing it
Jukka Rissanen [Thu, 7 Mar 2013 16:13:45 +0000 (18:13 +0200)]
vpn: Make sure vpn connection really exists before removing it

11 years agovpn: Check whether we have already removed the provider
Jukka Rissanen [Thu, 7 Mar 2013 16:13:44 +0000 (18:13 +0200)]
vpn: Check whether we have already removed the provider

The dbus messages from vpnd might come in different order so make
sure we are not trying to access already removed provider.

11 years agovpn: Add debug information when vpn state changes
Jukka Rissanen [Thu, 7 Mar 2013 16:13:43 +0000 (18:13 +0200)]
vpn: Add debug information when vpn state changes

11 years agovpn: Remove VPN provider from service list when destroying it
Jukka Rissanen [Thu, 7 Mar 2013 16:13:42 +0000 (18:13 +0200)]
vpn: Remove VPN provider from service list when destroying it

When provider is destroyed in vpnd, we get a notification about
that. We must then remove the provider which will also unref it
so the provider data will get removed properly.
Old code just unreffed the provider but it was left hanging in
service list.

11 years agoprovider: New provider removal function callable from vpn plugin
Jukka Rissanen [Thu, 7 Mar 2013 16:13:41 +0000 (18:13 +0200)]
provider: New provider removal function callable from vpn plugin

11 years agoprovider: Change the name of provider remove function
Jukka Rissanen [Thu, 7 Mar 2013 16:13:40 +0000 (18:13 +0200)]
provider: Change the name of provider remove function

Following patch will introduce provider remove function that can
be used from vpn plugin so rename the current removal function to
reflect better its usage.

11 years agovpn-config: Ignore IN_CREATE as IN_MODIFY is called anyway
Jukka Rissanen [Thu, 7 Mar 2013 16:13:39 +0000 (18:13 +0200)]
vpn-config: Ignore IN_CREATE as IN_MODIFY is called anyway

Inotify will send modify event after create event when user has
copied the config file into config directory. Because of this
it is useless to act on create event. As a bonus we avoid
create/modify/create loop that was earlier done in the modify event
handling code.

11 years agovpn: Clear the data pointer from provider when destroying
Jukka Rissanen [Thu, 7 Mar 2013 16:13:38 +0000 (18:13 +0200)]
vpn: Clear the data pointer from provider when destroying

If the data pointer is left around, then vpn plugin might
accidentally use it if dbus messages are received after
we have cleared the vpn connection.

11 years agovpn-provider: Do not save or load provisioned VPN connections
Jukka Rissanen [Tue, 5 Mar 2013 14:06:23 +0000 (16:06 +0200)]
vpn-provider: Do not save or load provisioned VPN connections

The vpnd will not read or save provider data from disk. Only
way to provision VPN is by setting necessary data in VPN .config
file.

11 years agovpn-provider: SetProperty and ClearProperty do not work if immutable
Jukka Rissanen [Tue, 5 Mar 2013 14:06:22 +0000 (16:06 +0200)]
vpn-provider: SetProperty and ClearProperty do not work if immutable

Immutable VPN connection settings cannot be changed by SetProperty or
ClearProperty dbus API.

11 years agovpn-provider: Introduce immutable flag to provider data
Jukka Rissanen [Tue, 5 Mar 2013 14:06:21 +0000 (16:06 +0200)]
vpn-provider: Introduce immutable flag to provider data

11 years agovpn-provider: Do not allow changes to settings that are immutable
Jukka Rissanen [Tue, 5 Mar 2013 14:06:20 +0000 (16:06 +0200)]
vpn-provider: Do not allow changes to settings that are immutable

The immutable settings are those that are read from .config file.

11 years agoservice: Send signal only if immutable flag value changes
Jukka Rissanen [Tue, 5 Mar 2013 14:06:19 +0000 (16:06 +0200)]
service: Send signal only if immutable flag value changes

11 years agovpn: Set immutable flag of the VPN service
Jukka Rissanen [Tue, 5 Mar 2013 14:06:18 +0000 (16:06 +0200)]
vpn: Set immutable flag of the VPN service

11 years agoprovider: Function to set the immutable flag
Jukka Rissanen [Tue, 5 Mar 2013 14:06:17 +0000 (16:06 +0200)]
provider: Function to set the immutable flag

11 years agovpn: Remember the immutable flag from vpnd
Jukka Rissanen [Tue, 5 Mar 2013 14:06:16 +0000 (16:06 +0200)]
vpn: Remember the immutable flag from vpnd

11 years agotest: Pretty print the error when trying to set/unset VPN property
Jukka Rissanen [Tue, 5 Mar 2013 14:06:15 +0000 (16:06 +0200)]
test: Pretty print the error when trying to set/unset VPN property

11 years agodoc: Describe immutable flag for VPN connection
Jukka Rissanen [Tue, 5 Mar 2013 14:06:14 +0000 (16:06 +0200)]
doc: Describe immutable flag for VPN connection

The immutable flag is set if the VPN connection is provisioned
via a .config file. The VPN connection can be removed only by
removing the .config file from /var/lib/connman-vpn directory.

11 years agovpn-provider: Do not quit vpnd if there are no VPN configurations
Jukka Rissanen [Thu, 7 Mar 2013 10:34:42 +0000 (12:34 +0200)]
vpn-provider: Do not quit vpnd if there are no VPN configurations

Because we now support provisioning of VPN services via .config file,
we need to keep vpnd running so that it can monitor the connman-vpn
directory for new config files.

11 years agodoc: Typo fixes in the documentation
Jukka Rissanen [Thu, 7 Mar 2013 08:56:51 +0000 (10:56 +0200)]
doc: Typo fixes in the documentation

Fixes BMC#25978

11 years agodevice: Check positive device filter correctly
Jukka Rissanen [Thu, 7 Mar 2013 08:24:37 +0000 (10:24 +0200)]
device: Check positive device filter correctly

The -i or --device command line option contains the device names
that we should use. Unfortunately the check fails if there are
multiple interfaces in that list and we ignore the interfaces instead.

Fixes BMC#25979

11 years agoiptables: Fix rule appending
Daniel Wagner [Wed, 6 Mar 2013 15:08:55 +0000 (16:08 +0100)]
iptables: Fix rule appending

Commit ba052f1f "iptables: Add split out iptables commands"
introduced a bug. __connman_iptables_append() should
call iptables_append_rule() instead of iptables_insert_rule().

11 years agoiptables: Valid policies are only ACCEPT and DROP
Daniel Wagner [Wed, 6 Mar 2013 15:08:54 +0000 (16:08 +0100)]
iptables: Valid policies are only ACCEPT and DROP

11 years agoiptables: Fix setting policy
Daniel Wagner [Wed, 6 Mar 2013 15:08:53 +0000 (16:08 +0100)]
iptables: Fix setting policy

The policy is kept at the end of the chain not at the beginning.
Currently, the code assumes that the builtin chain is empty.

11 years agoiptables: Always update options table
Daniel Wagner [Wed, 6 Mar 2013 15:08:52 +0000 (16:08 +0100)]
iptables: Always update options table

The linked list is tracking all loading modules. Since we do not
unload once they are loaded (xtables does not support this), we
might up leaving prepare_matches() before we update the
option table. Since we carefully reset the global xtable state
after executing one rule, this check is wrong, e.g. if we add
to similar rules (same matches (mark, nfacct)). In this case
the second rule would not be parsed correctly. Nasty nasty iptables parser!

11 years agoiptables: Do not flush in the wrong order
Daniel Wagner [Wed, 6 Mar 2013 15:08:51 +0000 (16:08 +0100)]
iptables: Do not flush in the wrong order

11 years agoiptables: Fix and refactor iterate_entries()
Daniel Wagner [Wed, 6 Mar 2013 15:08:50 +0000 (16:08 +0100)]
iptables: Fix and refactor iterate_entries()

Updating the builtin and hook index is more complex then one
would expect. In order to be able to update them correctly
we need also to pass in the underflow table to the iterate
function. To improve the readability the valid_hook magic
has been moved into next_hook_entry_index() which does exactly
as the name says.

11 years agoiptables: Fix is_fallthrough() check
Daniel Wagner [Wed, 6 Mar 2013 15:08:49 +0000 (16:08 +0100)]
iptables: Fix is_fallthrough() check

A fallthrough rule is one which has the default target name,
does not have a verdict and is not a jump rule.

is_fallthrough() is called excluslive from the insert path,
thus the value of verdict will be 0 for a fallthrough rule.

11 years agobuild: vpn-property test script was missing from build
Jukka Rissanen [Wed, 6 Mar 2013 08:39:59 +0000 (10:39 +0200)]
build: vpn-property test script was missing from build

11 years agoservice: Restart wispr on nameserver change
Forest Bond [Wed, 5 Dec 2012 21:44:27 +0000 (16:44 -0500)]
service: Restart wispr on nameserver change

This is needed to make a service go online in the case where it was
already connected and then manual IPv4 & nameservers settings are
applied.  In that case, wispr is restarted with the new IP settings, but
the nameservers have not been set yet, so the wispr test fails and the
service remains in ready state.

11 years agowifi: Preliminary fix for autoscanning known hidden SSIDs
Tomasz Bursztyka [Fri, 1 Mar 2013 11:17:58 +0000 (13:17 +0200)]
wifi: Preliminary fix for autoscanning known hidden SSIDs

Currently, it relies on max_ssids to know how many SSIDs it can provide as
paremeters. However, patch 6af0579c434058536fb40480f40f5e9895cfe863, which
fixes an issue about fast scanning, affects such feature.

Therefore, as a default, it will fallback to 1 if given max_ssids is 0.

There is still the issue that it will autoscan only max_ssid (1 or more)
known hidden SSIDs. This need to be fixed.

Reported by Sameer Naik

11 years agovpn-provider: Parse user networks correctly
Jukka Rissanen [Thu, 28 Feb 2013 09:00:02 +0000 (11:00 +0200)]
vpn-provider: Parse user networks correctly

Check NULL string before passing it to g_strsplit()

11 years agoneard: Use a timeout instead of DBUS_TIMEOUT_USE_DEFAULT for compatibility
Tomasz Bursztyka [Wed, 27 Feb 2013 09:17:40 +0000 (11:17 +0200)]
neard: Use a timeout instead of DBUS_TIMEOUT_USE_DEFAULT for compatibility

DBUS_TIMEOUT_USE_DEFAULT appeared in dbus-1.4.12, but earlier dbus versions
are still in use in some distributions like Fedora 17.

11 years agoRelease 1.12 1.12 upstream/1.12
Marcel Holtmann [Tue, 26 Feb 2013 13:01:53 +0000 (05:01 -0800)]
Release 1.12

11 years agodoc: Fix the path to VPN config files
Jukka Rissanen [Mon, 25 Feb 2013 08:09:00 +0000 (10:09 +0200)]
doc: Fix the path to VPN config files

The correct default path is /var/lib/connman-vpn

11 years agodoc: Update overview-api.txt
Tomasz Bursztyka [Tue, 26 Feb 2013 10:53:38 +0000 (12:53 +0200)]
doc: Update overview-api.txt

- Introduce the user to per SSID/Security Wifi networks grouping
- Agent is no longer a future feature and user should be aware of how
  required information can be provided when connecting to a service.

11 years agodundee: Increase timeout to 60 seconds
Patrik Flykt [Tue, 26 Feb 2013 10:54:08 +0000 (12:54 +0200)]
dundee: Increase timeout to 60 seconds

D-Bus method calls to may trigger pairing and/or pop up a dialog
in the remote Bluetooth device to which the user needs to react.

11 years agobluetooth_legacy: Increase Bluez 4 plugin timeout to 60 seconds
Patrik Flykt [Tue, 26 Feb 2013 10:52:55 +0000 (12:52 +0200)]
bluetooth_legacy: Increase Bluez 4 plugin timeout to 60 seconds

D-Bus method calls to Bluez 4 may trigger pairing and/or pop up a
dialog in the remote device to which the user needs to react.

11 years agogsupplicant: Increase D-Bus timeout to 30 seconds
Patrik Flykt [Tue, 26 Feb 2013 10:18:54 +0000 (12:18 +0200)]
gsupplicant: Increase D-Bus timeout to 30 seconds

11 years agoneard: Add partial support for wifi provisionning via NFC
Tomasz Bursztyka [Mon, 25 Feb 2013 12:11:10 +0000 (14:11 +0200)]
neard: Add partial support for wifi provisionning via NFC

PushOOB() method implementation. Currently only basic open/psk based
provisioning is supported.

11 years agoconfig: Add a function to provision mutable service
Tomasz Bursztyka [Mon, 25 Feb 2013 15:49:50 +0000 (17:49 +0200)]
config: Add a function to provision mutable service

The point here is to create a virtual configuration, which does not come
from a real file. This is a handy way for plugins to be able to provision
services without creating any file on the FS.

In case of a wifi configuration type and if connect is requested, it will
trigger a scan, thus leading to a possible service being provisioned by
such virtual configuration. If so and if connect was requested: the service
will be asked to connect.

11 years agoconfig: Make load service from each keyfile group as a function
Tomasz Bursztyka [Mon, 25 Feb 2013 12:11:08 +0000 (14:11 +0200)]
config: Make load service from each keyfile group as a function

11 years agoconfig: Remove superfluous error code
Tomasz Bursztyka [Mon, 25 Feb 2013 12:11:07 +0000 (14:11 +0200)]
config: Remove superfluous error code

It simplifies the code removing uselesse variable, moreover such variable
has the same name as an existing label in the same function.

11 years agoneard: Add neard plugin with tethering info sharing support
Tomasz Bursztyka [Mon, 25 Feb 2013 12:11:06 +0000 (14:11 +0200)]
neard: Add neard plugin with tethering info sharing support

Implement also RequestOOB() neard Agent method.

11 years agotechnology: Provide a function to get WiFi tethering information
Tomasz Bursztyka [Mon, 25 Feb 2013 12:11:05 +0000 (14:11 +0200)]
technology: Provide a function to get WiFi tethering information

11 years agogsupplicant: Remove pointless timeout constant
Marcel Holtmann [Mon, 25 Feb 2013 14:18:02 +0000 (15:18 +0100)]
gsupplicant: Remove pointless timeout constant

11 years agogdbus: Always unreference the message in g_dbus_send_message()
Tomasz Bursztyka [Fri, 8 Feb 2013 13:58:10 +0000 (15:58 +0200)]
gdbus: Always unreference the message in g_dbus_send_message()

A quick fix on g_dbus_send_message(), if check_signal() fails it returns
FALSE without unreferencing the message as it should. This patch fixes
it.

11 years agoconfig: Run service autoconnect after provisioning the wifi service
Jukka Rissanen [Fri, 22 Feb 2013 11:47:57 +0000 (13:47 +0200)]
config: Run service autoconnect after provisioning the wifi service

We trigger autoconnect request in service after the wifi service
has been provisioned. This is useful in headless systems where
there is no user to trigger the connect to provisioned service,
and it might take some time before system autoconnect is run.

11 years agoconfig: Add ethernet provisioning support
Jukka Rissanen [Fri, 22 Feb 2013 11:47:56 +0000 (13:47 +0200)]
config: Add ethernet provisioning support

11 years agoconfig: Support static IP address for wifi service
Jukka Rissanen [Fri, 22 Feb 2013 11:47:55 +0000 (13:47 +0200)]
config: Support static IP address for wifi service

11 years agoservice: Refactor ipconfig setter
Jukka Rissanen [Fri, 22 Feb 2013 11:47:54 +0000 (13:47 +0200)]
service: Refactor ipconfig setter

Done so that the function can be called also from config.c
The idea is that if ethernet .config file is removed,
we are able to clear the interface properly.

11 years agoipconfig: Add function to set the IPv6 privacy option
Jukka Rissanen [Fri, 22 Feb 2013 11:47:53 +0000 (13:47 +0200)]
ipconfig: Add function to set the IPv6 privacy option

11 years agoservice: Add function to set timeservers
Jukka Rissanen [Fri, 22 Feb 2013 11:47:52 +0000 (13:47 +0200)]
service: Add function to set timeservers

11 years agoservice: Add function to manipulate DNS search domains
Jukka Rissanen [Fri, 22 Feb 2013 11:47:51 +0000 (13:47 +0200)]
service: Add function to manipulate DNS search domains

11 years agoservice: Add function to manipulate ignore flag
Jukka Rissanen [Fri, 22 Feb 2013 11:47:50 +0000 (13:47 +0200)]
service: Add function to manipulate ignore flag

11 years agodoc: Ethernet provisioning support
Jukka Rissanen [Fri, 22 Feb 2013 11:47:49 +0000 (13:47 +0200)]
doc: Ethernet provisioning support

11 years agogsupplicant: Set the scan callback in g_supplicant_interface_scan
Julien Massot [Thu, 21 Feb 2013 17:23:07 +0000 (18:23 +0100)]
gsupplicant: Set the scan callback in g_supplicant_interface_scan

The callback is required to properly handle scanning errors reported
by wpa_supplicant through the scan_done signal.

Steps to reproduce:
1. Set a country code to the WiFi card which have more frequencies
   allowed than the world roaming allow.
2. Connect to a WiFi network not available in the world roaming setup.
3. Stop connman.
4. Change the country code to 00, be sure the frequencies use in step 2.
   is no longer allowed. Take care of cfg80211 authorize frequencies when
   beacons are received, I prefer using mac80211_hwsim from here to avoid
   side effects about beacon reception.
5. Start connman again.

Now ConnMan is stuck in scanning state as the scan_fast method of
plugins/wifi.c is called with a forbidden frequency.

wpa_supplicant returns an error received in "gsupplicant/supplicant.c:
signal_scan_done", where the code enters 'if (success == FALSE)' but
unfortunately scan_callback is NULL at this point as the scan_callback is
normally set in interface_scan_result().

11 years agoiptables: Merge clear_tables_flags() and reset_xtables()
Daniel Wagner [Thu, 21 Feb 2013 16:42:33 +0000 (17:42 +0100)]
iptables: Merge clear_tables_flags() and reset_xtables()

Both function reset the xtables library. So let's do this
at the same place.

11 years agoiptables: Free table pointer
Daniel Wagner [Thu, 21 Feb 2013 16:42:32 +0000 (17:42 +0100)]
iptables: Free table pointer

And also use g_strv_length() to count the number of entries.
Thanks Tomasz!

11 years agoiptables: Free match rules
Daniel Wagner [Thu, 21 Feb 2013 16:42:31 +0000 (17:42 +0100)]
iptables: Free match rules

We forgot to free the match rules.

11 years agoiptables: Reset pointer after freeing
Daniel Wagner [Thu, 21 Feb 2013 16:42:30 +0000 (17:42 +0100)]
iptables: Reset pointer after freeing

The match or the target might be reused in the next invocation
of iptables and then xtables operates on this invalid pointer.
xt_t->t and xt_m->m are keept alive via the global variables
xtables_targets and xtables_matches.

11 years agoiptables: Reinitialize global parser table
Daniel Wagner [Thu, 21 Feb 2013 16:42:29 +0000 (17:42 +0100)]
iptables: Reinitialize global parser table

xtables modifies the global parse table and allocates additional
memory. If that happens we need to free it afterwards.

11 years agoiptables: Free xtables entry when removing one entry from the table
Daniel Wagner [Thu, 21 Feb 2013 16:42:28 +0000 (17:42 +0100)]
iptables: Free xtables entry when removing one entry from the table

11 years agotest-iptables: Fix memory leak
Daniel Wagner [Thu, 21 Feb 2013 16:42:27 +0000 (17:42 +0100)]
test-iptables: Fix memory leak

11 years agotest-iptables: Delete all rules in target0
Daniel Wagner [Thu, 21 Feb 2013 16:42:26 +0000 (17:42 +0100)]
test-iptables: Delete all rules in target0

11 years agoclient: Remove the now obsolete command parsing functions
Patrik Flykt [Wed, 20 Feb 2013 11:53:36 +0000 (13:53 +0200)]
client: Remove the now obsolete command parsing functions

11 years agoclient: Remove unused functions
Patrik Flykt [Wed, 20 Feb 2013 11:45:52 +0000 (13:45 +0200)]
client: Remove unused functions

Remove find_service() as it is no longer used and match_service_name()
which was only used by find_service().

11 years agoclient: Factor out monitor command
Patrik Flykt [Wed, 20 Feb 2013 11:43:57 +0000 (13:43 +0200)]
client: Factor out monitor command

11 years agoclient: Create monitor helper functions
Patrik Flykt [Wed, 20 Feb 2013 11:29:37 +0000 (13:29 +0200)]
client: Create monitor helper functions

11 years agoclient: Factor out technology enable and disable commands
Patrik Flykt [Tue, 19 Feb 2013 20:42:48 +0000 (22:42 +0200)]
client: Factor out technology enable and disable commands

11 years agoclient: Wait for a reply from Manager API
Patrik Flykt [Tue, 19 Feb 2013 20:41:47 +0000 (22:41 +0200)]
client: Wait for a reply from Manager API

11 years agoclient: Wait for a reply from Technology API
Patrik Flykt [Tue, 19 Feb 2013 20:39:57 +0000 (22:39 +0200)]
client: Wait for a reply from Technology API

Also reduce logging.

11 years agoclient: Factor out scan command
Patrik Flykt [Tue, 19 Feb 2013 20:20:01 +0000 (22:20 +0200)]
client: Factor out scan command

11 years agoclient: Reduce technology logging
Patrik Flykt [Tue, 19 Feb 2013 20:18:47 +0000 (22:18 +0200)]
client: Reduce technology logging

Reduce technology logging messages and modify the remaining one. Also
free the DBusError.

11 years agoclient: Factor out disconnect command
Patrik Flykt [Tue, 19 Feb 2013 20:00:08 +0000 (22:00 +0200)]
client: Factor out disconnect command

11 years agoclient: Factor out connect command
Patrik Flykt [Tue, 19 Feb 2013 19:57:24 +0000 (21:57 +0200)]
client: Factor out connect command

11 years agoclient: Don't look up service on connect or disconnect
Patrik Flykt [Tue, 19 Feb 2013 19:55:42 +0000 (21:55 +0200)]
client: Don't look up service on connect or disconnect

Attempt to connect or disconnect without looking up the service in
advace. Fix memory leak and update the error message.

11 years agoclient: Factor out technologies command
Patrik Flykt [Tue, 19 Feb 2013 19:36:24 +0000 (21:36 +0200)]
client: Factor out technologies command

11 years agoclient: Factor out state command
Patrik Flykt [Tue, 19 Feb 2013 19:34:15 +0000 (21:34 +0200)]
client: Factor out state command

11 years agoclient: Print out any errors on command execution
Patrik Flykt [Tue, 19 Feb 2013 19:33:32 +0000 (21:33 +0200)]
client: Print out any errors on command execution

11 years agoclient: Factor out config command
Patrik Flykt [Tue, 19 Feb 2013 13:29:04 +0000 (15:29 +0200)]
client: Factor out config command

Using the lengths returned from the property setting functions more than
one config option can be specified on the command line. Use the simple
argument parsing function as getopt is slightly limited in functionality.

11 years agoclient: Wait for a reply when removing service
Patrik Flykt [Wed, 20 Feb 2013 08:49:48 +0000 (10:49 +0200)]
client: Wait for a reply when removing service

11 years agoclient: Fix setting service properties
Patrik Flykt [Tue, 19 Feb 2013 13:24:14 +0000 (15:24 +0200)]
client: Fix setting service properties

Set properties for a service ignoring any cached lookups. Send the method
call only if ther is no error.  When sending, wait for the result in order
to see if the method call succeeded.

11 years agoclient: Quick fix for parsing IPv6.Configuration correctly
Patrik Flykt [Wed, 20 Feb 2013 13:55:44 +0000 (15:55 +0200)]
client: Quick fix for parsing IPv6.Configuration correctly

Fixes BMC#25925

11 years agoclient: Return number of arguments processed when setting properties
Patrik Flykt [Tue, 19 Feb 2013 13:20:05 +0000 (15:20 +0200)]
client: Return number of arguments processed when setting properties

11 years agoclient: Return number of proxies added
Patrik Flykt [Tue, 19 Feb 2013 13:16:52 +0000 (15:16 +0200)]
client: Return number of proxies added

11 years agoclient: Return the number of proxy arguments discovered
Patrik Flykt [Tue, 19 Feb 2013 13:13:03 +0000 (15:13 +0200)]
client: Return the number of proxy arguments discovered

11 years agoclient: Return the number of added dict entries
Patrik Flykt [Tue, 19 Feb 2013 12:44:23 +0000 (14:44 +0200)]
client: Return the number of added dict entries

Check that both the dict entry name and data are non-NULL, the dict data
does not start with '--' indicating a new option and that the length is
not exhausted. Return the number of dict entries.

11 years agoclient: Return the number of added array entries
Patrik Flykt [Tue, 19 Feb 2013 12:40:44 +0000 (14:40 +0200)]
client: Return the number of added array entries

Check that the array element is non-NULL, does not start with '--' indicating
a new option or that the array length is not exhausted. Return the number of
array elements added.

11 years agoclient: Factor out services command
Patrik Flykt [Tue, 19 Feb 2013 13:26:46 +0000 (15:26 +0200)]
client: Factor out services command

Update the help printout as well, '--properties' is not mandatory. Add a
simple argument parsing function.

11 years agoclient: Add boolean parsing helper function
Patrik Flykt [Wed, 20 Feb 2013 11:42:05 +0000 (13:42 +0200)]
client: Add boolean parsing helper function

11 years agoclient: Fix up interactive option parsing
Patrik Flykt [Tue, 12 Feb 2013 19:57:23 +0000 (21:57 +0200)]
client: Fix up interactive option parsing

Use g_strsplit to get a NULL terminated array of chars and compute the
number of array items.

11 years agoclient: Make DBusConnection global
Patrik Flykt [Tue, 12 Feb 2013 19:56:29 +0000 (21:56 +0200)]
client: Make DBusConnection global

11 years agoclient: Factor out help implementation
Patrik Flykt [Tue, 12 Feb 2013 12:40:15 +0000 (14:40 +0200)]
client: Factor out help implementation

Use command table to produce help text. Add description texts for various
options and use both option and description arrays to produce option help
texts. Remove old help printing function.

11 years agoclient: Create prototypes for all commands
Patrik Flykt [Tue, 12 Feb 2013 11:55:34 +0000 (13:55 +0200)]
client: Create prototypes for all commands

Provide the infrastructure to factor out the commands.

11 years agovpn-provider: SetProperty works with all properties
Jukka Rissanen [Tue, 19 Feb 2013 08:45:08 +0000 (10:45 +0200)]
vpn-provider: SetProperty works with all properties

11 years agovpn-provider: ClearProperty works with all properties
Jukka Rissanen [Tue, 19 Feb 2013 08:45:07 +0000 (10:45 +0200)]
vpn-provider: ClearProperty works with all properties

11 years agovpn-provider: Allow use of Domain property name
Jukka Rissanen [Tue, 19 Feb 2013 08:45:06 +0000 (10:45 +0200)]
vpn-provider: Allow use of Domain property name

Allow use of both VPN.Domain and Domain property strings.

11 years agovpn-provider: Add GetProperties method implementation
Jukka Rissanen [Tue, 19 Feb 2013 08:45:05 +0000 (10:45 +0200)]
vpn-provider: Add GetProperties method implementation

11 years agovpn-provider: Do not send state property if state is not changed
Jukka Rissanen [Tue, 19 Feb 2013 08:45:04 +0000 (10:45 +0200)]
vpn-provider: Do not send state property if state is not changed