platform/upstream/dotnet/runtime.git
5 years agoUpdate LicenseInterop API (dotnet/corefx#35577)
Aaron Robinson [Thu, 28 Feb 2019 05:50:57 +0000 (21:50 -0800)]
Update LicenseInterop API (dotnet/corefx#35577)

* Clean up the Interop helper API for managed COM server activation via IClassFactory2.

Commit migrated from https://github.com/dotnet/corefx/commit/bf09f74c8fe5b6094771266e6beeb36e7447b252

5 years agoAvoid re-scanning the whole input ROSequence when getting position in Utf8JsonReader...
Ahson Khan [Thu, 28 Feb 2019 03:41:48 +0000 (19:41 -0800)]
Avoid re-scanning the whole input ROSequence when getting position in Utf8JsonReader (dotnet/corefx#35310)

* Make sure SequencePosition is saved as part of JsonReaderState

* Avoid rescanning whole ROSequence when getting position.

* We don't guarantee the position for invalid JSON.

* Remove isSingleSegment check when getting position and add single
segment tests

* Address feedback: remove else block and add some comments.

Commit migrated from https://github.com/dotnet/corefx/commit/b85d017ecac090e6966822f159b48e7edfef37ce

5 years agoAuto-generate the reference assemblies and separate type forwards (dotnet/corefx...
Ahson Khan [Thu, 28 Feb 2019 03:39:21 +0000 (19:39 -0800)]
Auto-generate the reference assemblies and separate type forwards (dotnet/corefx#35557)

* Auto-generate the reference assemblies

* Add back type forwards.

* Revert "Add back type forwards."

This reverts commit dotnet/corefx@3acf74aabb2e3ba90ac7280d541723d13d72c74a.

* Add back TypeForwardedTo in .Forward.cs files

* Add new type forward files to the csproj files

* Add back if-defs and move TestUtilities comment from ref to source

* Remove duplicate definitions, delete unnecessary manual files,

* Fix build breaks

* Add back missing AsyncMethodBuilderAttr to S.Runtime ref

* Fix typo between XmlDocument and XPath.XDocument

* Add type forward fild missed from previous commit

* Fix ECDiffieHellmanCngPublicKey internal ctor for netfx 4.6.1

* Remove "this type was moved to comments" from the type forwards.

* Add back the Xml and Debugger* attributes to Xml.ReaderWriter

* Add back struct layout attributes

* Add back attributes missing (highlighted from api compat)

* Add missing toolbox item attribute in s.data.common.

* Add missing struct layout attributes and remove unnecessary additions

* Add back InterfaceTypeAttribute

Commit migrated from https://github.com/dotnet/corefx/commit/16689aa0a933517dc45465fc6edb6223222414a6

5 years agoProcess: Unix: use groups of ProcessStartInfo.UserName (dotnet/corefx#34961)
Tom Deseyn [Thu, 28 Feb 2019 02:55:26 +0000 (03:55 +0100)]
Process: Unix: use groups of ProcessStartInfo.UserName (dotnet/corefx#34961)

* Process: Unix: use groups of ProcessStartInfo.UserName

* PR feedback

* Fix OSX build

* Fix OSX build II

* Fix OSX build III

* Set ngroups to -1 on error

* Handle setgroups EPERM with fallback to process groups

* pal_process: handle zero groups length

This is for completeness, managed code calls this with at least one group: the primary group of the user.

* Remove uid_t and gid_t sizeof asserts

* Determine user ids using 'id' command

* Deal with OSX and musl specifics

* Try to fix OSX TestStartWithNormalUser by handling setgroups EINVAL

* Fix UnauthorizedAccessException for ExceptionFile when RemoteInvoke as sudo

* OSX getgrouplist is not thread safe

* Try to fix Ubuntu 18.10 test failures

* Refactor RunTestAsSudo to use RemoteInvoke child Process checking

* Try to fix OSX 13.10 fails

* Update test for truncated groups

* Extend tests

* Try fix/debug OSX test fail

* Test: special case OSX for getgrouplist truncate

* PR feedback

* Improve groups checking: O(N*M) to O(N*log(M))

Commit migrated from https://github.com/dotnet/corefx/commit/b10e8d67b260e26f2e47750cf96669e6f48e774d

5 years agopull updated Alpine3.9 image one more time (dotnet/corefx#35639)
Tomas Weinfurt [Thu, 28 Feb 2019 00:52:54 +0000 (16:52 -0800)]
pull updated Alpine3.9 image one more time (dotnet/corefx#35639)

Commit migrated from https://github.com/dotnet/corefx/commit/94322619b200b05dbb9a386db391407f97ebefa2

5 years agoFix advance for single length delimiter (dotnet/corefx#35597)
Jeremy Kuhne [Thu, 28 Feb 2019 00:33:56 +0000 (16:33 -0800)]
Fix advance for single length delimiter (dotnet/corefx#35597)

* Fix advance for single length delimiter

If the delimiter span for TryReadTo was only one character long we weren't advancing past the delimiter if requested. Add regression test.

* Address feedback

* Scan from beginning as well

Commit migrated from https://github.com/dotnet/corefx/commit/b0bc99d6f7943a8081a84bea23c5542831c9359e

5 years agoupdate SqlClient Area Owners (dotnet/corefx#35634)
Afsaneh Rafighi [Wed, 27 Feb 2019 20:55:57 +0000 (12:55 -0800)]
update SqlClient Area Owners (dotnet/corefx#35634)

Commit migrated from https://github.com/dotnet/corefx/commit/5aeccae0ab98af86e56043c1017474b7c05358e0

5 years agoupdate container name (dotnet/corefx#35631)
Tomas Weinfurt [Wed, 27 Feb 2019 19:46:57 +0000 (11:46 -0800)]
update container name (dotnet/corefx#35631)

* pul in updated Alpine39 image

* images no longer published to old place

Commit migrated from https://github.com/dotnet/corefx/commit/417c3b8a97b29f7c5c1d25d5f7357b387bc5a68b

5 years agopul in updated Alpine39 image (dotnet/corefx#35627)
Tomas Weinfurt [Wed, 27 Feb 2019 17:37:56 +0000 (09:37 -0800)]
pul in updated Alpine39 image (dotnet/corefx#35627)

Commit migrated from https://github.com/dotnet/corefx/commit/cbb3159d041c4489ced4ef7142a40a86aa54e35f

5 years agoRevert "Revert "Add another Zip IEnumerable<T> extension method (dotnet/corefx#26582...
Stephen Toub [Wed, 27 Feb 2019 15:20:41 +0000 (10:20 -0500)]
Revert "Revert "Add another Zip IEnumerable<T> extension method (dotnet/corefx#26582)"" (dotnet/corefx#35595)

* Revert "Revert "Add another Zip IEnumerable<T> extension method (dotnet/corefx#26582)" (dotnet/corefx#33709)"

This reverts commit dotnet/corefx@53ae9af48c5c133f4413e76c1469dfe6ccecd926.

* Adapt to ThrowHelper changes

Commit migrated from https://github.com/dotnet/corefx/commit/720591ab8c213c8f3563db1f06114ec7c8d012bb

5 years agoDisable BitOps tests
Jan Kotas [Wed, 27 Feb 2019 05:59:42 +0000 (21:59 -0800)]
Disable BitOps tests

Commit migrated from https://github.com/dotnet/corefx/commit/70af5f296f7bfcdd7b7fade082c15cd19d8b29ab

5 years agoenable GetAsync_AllowedSSLVersion_Succeeds for SocketHttpHandler (dotnet/corefx#35605)
Tomas Weinfurt [Wed, 27 Feb 2019 06:41:05 +0000 (22:41 -0800)]
enable GetAsync_AllowedSSLVersion_Succeeds for SocketHttpHandler (dotnet/corefx#35605)

* enable GetAsync_AllowedSSLVersion_Succeeds for SocketHttpHandler and skip Curl on RH6

Commit migrated from https://github.com/dotnet/corefx/commit/f44142b855330ca9274827a230b8ad9a3ccda357

5 years agoUpdate the IBufferWriter contract definition documentation to be clearer (dotnet...
Ahson Khan [Wed, 27 Feb 2019 03:12:35 +0000 (19:12 -0800)]
Update the IBufferWriter contract definition documentation to be clearer (dotnet/corefx#35554)

* Update the IBufferWriter contract definition docs

* Address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/1da56c2529c8d52bd8f3b1ceb07795379221dc02

5 years agoAdding some formatter tests validating the updated float/double behavior (dotnet...
Tanner Gooding [Wed, 27 Feb 2019 02:58:22 +0000 (18:58 -0800)]
Adding some formatter tests validating the updated float/double behavior (dotnet/corefx#35567)

* Adding some formatter tests validating the updated float/double behavior

* Adding a regression test for ToString("R") on integral types, asserting it isn't supported

Commit migrated from https://github.com/dotnet/corefx/commit/54e341c9ba4ea452b098f2ec9dbcf58da7b33ed6

5 years agoDarc update from build '20190226.3' (dotnet/corefx#35604)
Viktor Hofer [Wed, 27 Feb 2019 01:07:26 +0000 (02:07 +0100)]
Darc update from build '20190226.3' (dotnet/corefx#35604)

* Darc update from build '20190226.3'

* Apply TestAllTargets project filter

Commit migrated from https://github.com/dotnet/corefx/commit/23c06516a29ac94585cee09e82b5ddf57d0cae0e

5 years agoAllow tests to sign with a different StrongNameKeyId
Eric St. John [Tue, 26 Feb 2019 19:24:31 +0000 (11:24 -0800)]
Allow tests to sign with a different StrongNameKeyId

Before this change all tests are forced to use the Open key.

Now tests can specify TestStrongNameKeyId to control their key.

Commit migrated from https://github.com/dotnet/corefx/commit/a8fc4418080e66d97f337e7b663a88b047f1e2e0

5 years agoUse ILAsm/ILDasm that are restored as part of external
Eric St. John [Tue, 26 Feb 2019 17:18:18 +0000 (09:18 -0800)]
Use ILAsm/ILDasm that are restored as part of external

Also fixes a test project to build correctly and deletes a checked in binary.

Commit migrated from https://github.com/dotnet/corefx/commit/733f5bee45d7b1c684dc353a1197ddb718cc4aa9

5 years agocollect system info if IPv6 loopback fails to resolve (dotnet/corefx#35581)
Tomas Weinfurt [Tue, 26 Feb 2019 23:12:36 +0000 (15:12 -0800)]
collect system info if IPv6 loopback fails to resolve (dotnet/corefx#35581)

* collect system info if IPv6 loopback fails to resolve

* add emply line after } to comply with style

Commit migrated from https://github.com/dotnet/corefx/commit/77cde697f9ee9941bdc76e02b9481d781790e86a

5 years agoimprove detection for ReadOnly_FileSystemHelper (dotnet/corefx#35531)
Tomas Weinfurt [Tue, 26 Feb 2019 23:11:39 +0000 (15:11 -0800)]
improve detection for ReadOnly_FileSystemHelper (dotnet/corefx#35531)

* improve detection for ReadOnly_FileSystemHelper

* feedback from review

* fix bad resolve

Commit migrated from https://github.com/dotnet/corefx/commit/7d4f25f1f503f91dd680d6e2c4cb556fd4f631e4

5 years agoRemove System.IO.Ports.Native from the framework (dotnet/corefx#35598)
Krzysztof Wicher [Tue, 26 Feb 2019 22:23:27 +0000 (14:23 -0800)]
Remove System.IO.Ports.Native from the framework (dotnet/corefx#35598)

Commit migrated from https://github.com/dotnet/corefx/commit/3bf49dd2a3f136a85bed3cc40e6648ccdef4a3f9

5 years agoMerge pull request dotnet/corefx#35572 from wtgodbe/UpdateStando
William Godbe [Tue, 26 Feb 2019 21:54:54 +0000 (13:54 -0800)]
Merge pull request dotnet/corefx#35572 from wtgodbe/UpdateStando

[master] Trigger manual DARC update

Commit migrated from https://github.com/dotnet/corefx/commit/7c37cfbd03d058b966160fdc39cd902ef3b2782c

5 years agoAdd string overloads to DbDataReader.Get*()
Essam Almohammadi [Sat, 9 Feb 2019 10:55:56 +0000 (11:55 +0100)]
Add string overloads to DbDataReader.Get*()

Implement dotnet/corefx#31595

Commit migrated from https://github.com/dotnet/corefx/commit/b30fc2b4ee302e449e3580ae39cb083a76b813c9

5 years agoUpdate ApiCompat baselines
wtgodbe [Tue, 26 Feb 2019 00:26:29 +0000 (16:26 -0800)]
Update ApiCompat baselines

Commit migrated from https://github.com/dotnet/corefx/commit/01ef5e6cbb395709c02436538018d44c61cfdcc8

5 years agoChanges to support W3C style IDs and propagation (dotnet/corefx#33207)
Vance Morrison [Tue, 26 Feb 2019 15:51:19 +0000 (07:51 -0800)]
Changes to support W3C style IDs and propagation (dotnet/corefx#33207)

* First set of changes to support W3C style IDs and propagation

see https://w3c.github.io/trace-context

This is mostly for discussion purposes.

* Changed UseW3CFormat to be DefaultIdFormat

* Review feedback

* More comments.  Small Renames

* Added Sampling Support, Review feedback.

* Added placeholder for SetRecordingDesired

* Separated out the Sampling support into its own PR.

* Remove more sampling support

* Fix IsWC3Id -> IdFormat

* Added Sampling Support, Review feedback.

* Separated out the Sampling support into its own PR.

* Add ForceW3C option.

* Introduce ForceDefaultIdFormat

* Adding SpanId and TraceId support

* Change ulong->long in SpanID (probably temporary)

* Remove undesired file changes

* Fix up reference assembly.

Note complete because of questions about Span<byte>, but closer now.

* Turn on code that used Span<byte>

* Defer setting IDFormat until start.

This insures that the IDFormat property is either unknown or a given value (that never changes from there).

* More implementation, made the interface more uniform.

* Support to avoid using strings whenever possible

Basically Id, SpanId TraceId properties are set lazily and only converted lazily.

* Added some tests

* First round of testing (and bugfixes)

* More testing

* Added Equality operators

* Rename SpanId -> ActivitySpanId TraceId ->ActivityTraceId

* Add Comments

* Fix bad XML comment

* Review feedback

* Change AsBytes -> CopyTo

Lifetime issues prevent returning Span<T> (which is what AsBytes does.   Reverting to CopyTo instead.
Also added System.Memory ref in attempt to resolve build errors (that don't reproduce locally).

* Attempt to fix build break in netfx build

* Deal with Verification errors.

* Provide full namespace for SecuritySafeCriticalAttribute

* More securitySafeCritical annotations to fix test failures on desktop

* Another attempt on setting SecuritySafeCritical

* Remove the readonly ref (to avoid perf issue)

* Fix most  -buildAllConfigurations issues

* Tentative change to see if testing works if we ignore the older netstandard configs.

* Workaround package cycle involving DiagnosticSource and Memory

* Satisfy dangling System.Memory dangling reference in package tests

* Add notes to remove the workarounds when Unsafe is fixed.

* Review feedback

Uses Utf8 helpers where possible.

Commit migrated from https://github.com/dotnet/corefx/commit/fa07e4f0a8e564f33ef8e2de86dc9087a53bdf26

5 years agoimprove Ssl3 detection (dotnet/corefx#35574)
Tomas Weinfurt [Tue, 26 Feb 2019 07:02:20 +0000 (23:02 -0800)]
improve Ssl3 detection (dotnet/corefx#35574)

* improve sslv3 detection

* updates to pass all tests

* correct catch

Commit migrated from https://github.com/dotnet/corefx/commit/0fa22d4b6753c47b6139980255e932341353179e

5 years agoAdd doc comments to JsonDocument (and friends)
Jeremy Barton [Tue, 26 Feb 2019 06:02:02 +0000 (22:02 -0800)]
Add doc comments to JsonDocument (and friends)

* Add doc comments to all public members of JsonDocument, JsonElement, JsonProperty, and JsonValueType.
* Add "do not use this" doc comments on all internal members, because of source-package concerns.
* Change JsonElement.TokenType from internal to private because it could.

Commit migrated from https://github.com/dotnet/corefx/commit/81e9045dca63ccea9b4fe31f8ac3a035b1b1f86d

5 years agodisable AllSubscriberStress test on ARM64 untill we get more resources to run it...
Tomas Weinfurt [Tue, 26 Feb 2019 05:28:18 +0000 (21:28 -0800)]
disable AllSubscriberStress test on ARM64 untill we get more resources to run it (dotnet/corefx#35575)

Commit migrated from https://github.com/dotnet/corefx/commit/dedb0f8e93661d13f18c9afcae6c2883b28a2d68

5 years agoRemoved GetRootLength Helper Function from PathInternalWindows.cs (dotnet/corefx...
Erhan Atesoglu [Tue, 26 Feb 2019 03:05:07 +0000 (19:05 -0800)]
Removed GetRootLength Helper Function from PathInternalWindows.cs (dotnet/corefx#35568)

Commit migrated from https://github.com/dotnet/corefx/commit/6b262c30165fe7c39d9fb582495c76c704c0a0d6

5 years agoAdd temporary resources and copy of Thread implementation to unblock merge of shared...
Filip Navara [Tue, 26 Feb 2019 02:47:18 +0000 (03:47 +0100)]
Add temporary resources and copy of Thread implementation to unblock merge of shared CoreLib (dotnet/corefx#35553)

Commit migrated from https://github.com/dotnet/corefx/commit/facf731986511cb0cc0ceb181b6c7d846afa0743

5 years agoUse NativeLibrary.TryLoad and prefer RTLD_LAZY over RTLD_NOW (dotnet/corefx#35548)
Adeel Mujahid [Tue, 26 Feb 2019 02:44:03 +0000 (04:44 +0200)]
Use NativeLibrary.TryLoad and prefer RTLD_LAZY over RTLD_NOW (dotnet/corefx#35548)

* Use NativeLibrary.TryLoad in ODBC test

* Use RTLD_LAZY instead of RTLD_NOW

* Add missing using statement

* More RTLD_NOW -> RTLD_LAZY

* Remove unused RTLD_NOW constant

* Use NativeLibrary.TryLoad instead of P/Invoke dlopen

* Inline method body in property

* Add fallback for netcoreapp2x and below

* Reduce visibility of const

Commit migrated from https://github.com/dotnet/corefx/commit/863b9bff2d77669b426b52dcb1bf7ba9246729e0

5 years agoRemoving restriction of first 8 character being different from lognames (dotnet/coref...
Anirudh Agnihotry [Sun, 24 Feb 2019 22:31:51 +0000 (14:31 -0800)]
Removing restriction of first 8 character being different from lognames (dotnet/corefx#35532)

Commit migrated from https://github.com/dotnet/corefx/commit/26b932e3c56702382d13ece010b300d3181d2891

5 years agoRemove Task{CompletionSource} allocations from Http2Stream (dotnet/corefx#35522)
Stephen Toub [Sat, 23 Feb 2019 10:00:31 +0000 (05:00 -0500)]
Remove Task{CompletionSource} allocations from Http2Stream (dotnet/corefx#35522)

* Remove Task{CompletionSource} allocations from Http2Stream

This change makes the Http2Stream instance itself awaitable via ValueTask, such that we don't need to allocate any additional TaskCompletionSource or Task objects for such internal await'ing, regardless of how many times the Http2Connection or Http2ReadStream needs to wait for headers or response data to arrive.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/aacff5212204ee54e3b3e0172fcf364c3fe253e3

5 years agoUse product version in RuntimeInformation.FrameworkDescription (dotnet/corefx#35516)
Jan Kotas [Sat, 23 Feb 2019 05:07:03 +0000 (21:07 -0800)]
Use product version in RuntimeInformation.FrameworkDescription (dotnet/corefx#35516)

* Use product version in RuntimeInformation.FrameworkDescription

* Include FrameworkDescription in the Assert

* Strip the git hash in the fallback

Commit migrated from https://github.com/dotnet/corefx/commit/db95b37fa3218e20ff639b232a41202b24ddcb39

5 years agoRemoved "Argument_InvalidPathChars" Resource String (dotnet/corefx#35534)
Erhan Atesoglu [Sat, 23 Feb 2019 02:53:24 +0000 (18:53 -0800)]
Removed "Argument_InvalidPathChars" Resource String (dotnet/corefx#35534)

Commit migrated from https://github.com/dotnet/corefx/commit/bd52650a7ba05b16c5cabf37cb69511cbccc35b9

5 years agoAdd #define alias for local_X509_STORE_CTX_get0_store for RHEL6 build
Jeremy Barton [Sat, 23 Feb 2019 02:37:22 +0000 (18:37 -0800)]
Add #define alias for local_X509_STORE_CTX_get0_store for RHEL6 build

Commit migrated from https://github.com/dotnet/corefx/commit/eaafb6fd980f161c94c16b7036a73ed3df5871ae

5 years agoMake System.Runtime.CompilerServices.Unsafe inbox (dotnet/corefx#35526)
Eric StJohn [Sat, 23 Feb 2019 02:20:16 +0000 (18:20 -0800)]
Make System.Runtime.CompilerServices.Unsafe inbox (dotnet/corefx#35526)

* Make System.Runtime.CompilerServices.Unsafe inbox

Fix a couple places where we wanted to use it from other inbox assemblies but couldn't.

Unsafe remains as a package and newer versions of Unsafe will replace the inbox Version,
permitting us to add API over time.

* Update Rune tests to use TryEncodeToUtf8Bytes directly

* Add temporary suppression to package tests

Commit migrated from https://github.com/dotnet/corefx/commit/9074d9f5b513a95b7eac9ba1112069c29230d1d2

5 years agoDisable azure pipelines reporter for official builds (dotnet/corefx#35540)
Santiago Fernandez Madero [Sat, 23 Feb 2019 01:00:31 +0000 (17:00 -0800)]
Disable azure pipelines reporter for official builds (dotnet/corefx#35540)

Commit migrated from https://github.com/dotnet/corefx/commit/a41629b2604a9dc92305f4df067898a377f72b17

5 years agoMerge pull request dotnet/corefx#35533 from dotnet/Add-Alpine-3-9
Matt Galbraith [Fri, 22 Feb 2019 22:20:15 +0000 (14:20 -0800)]
Merge pull request dotnet/corefx#35533 from dotnet/Add-Alpine-3-9

Adding Alpine 3.9 Runs to official

Commit migrated from https://github.com/dotnet/corefx/commit/dc6dfe11752a00136df36b5c62f6b891322068e6

5 years agoAdding Alpine 3.9 Runs to official
Matt Galbraith [Fri, 22 Feb 2019 22:07:50 +0000 (14:07 -0800)]
Adding Alpine 3.9 Runs to official

There may be a little more work to be done here for displaying what actually ran, but I believe we're ready to use the new Helix Client docker work.

Commit migrated from https://github.com/dotnet/corefx/commit/eeaeb1a11f244dc13e827decd3ab0c810089f747

5 years agoAdd support for OCSP on Linux, overhaul Linux X509Chain processing
Jeremy Barton [Fri, 22 Feb 2019 20:51:22 +0000 (12:51 -0800)]
Add support for OCSP on Linux, overhaul Linux X509Chain processing

This change moves a lot of the chain building work from managed code into the native shim, largely to cut down on the number of P/Invokes required to set up the chain builder.

Once a chain has been built to a point where only one issuer will be considered, if revocation was requested and a CRL is not available, attempt an OCSP request if the certificate indicates the CA has an OCSP endpoint.

Based on CA/Browser Forum's requirements this expects CRL for all intermediates and only attempts OCSP for the end-entity certificate.

"Conforming" OCSP requests are opportunistically cached on the basis that local filesystem re-reads are more reliable (and faster) than doing a live request to the CA.

Commit migrated from https://github.com/dotnet/corefx/commit/0fbbb68a3f7be82d26e4b2dff5c25c192e3a2023

5 years agoAvoid some 1st-chance exceptions on Linux in GetAllNetworkInterfaces (dotnet/corefx...
Stephen Toub [Fri, 22 Feb 2019 18:51:14 +0000 (13:51 -0500)]
Avoid some 1st-chance exceptions on Linux in GetAllNetworkInterfaces (dotnet/corefx#35523)

Commit migrated from https://github.com/dotnet/corefx/commit/cbf462058cf0aa96c171f84604e575be9f41830a

5 years agoFix bug: Process.OutputDataReceived not firing (dotnet/corefx#33974)
Marco Rossignoli [Fri, 22 Feb 2019 13:57:42 +0000 (14:57 +0100)]
Fix bug: Process.OutputDataReceived not firing  (dotnet/corefx#33974)

* fix bug

* address PR feedback

* remove flaky assertions

* remove test for Uap

* update test

* nit: remove empty line

* add test to outerloop

* try deterministic test with fileSystem lock

* update test

* update test

* add cleanup to test

* update test

* update test comment

* refactor test

* address PR feedback

* address PR feedback

* Address PR feedback

* update tests

* try anonymous pipe

* remove FileSystemLock

* fix test

* try tu run on UAP

* try to run on UAP

* updates

* uap experiment

* uap experiment

* uap experiment

* remove uap from tests

* updates

* update tests

* fix test name

* avoid uap compile error

* apply Stephen steps

* Update ProcessStreamReadTests.cs

Add comment

* update comment

Commit migrated from https://github.com/dotnet/corefx/commit/7817a109400b5b22c02ae6667706cda8a7f3d168

5 years agoUpdate Environment.Version test to not expect hardcoded version (dotnet/corefx#35512)
Jan Kotas [Fri, 22 Feb 2019 10:55:41 +0000 (02:55 -0800)]
Update Environment.Version test to not expect hardcoded version (dotnet/corefx#35512)

* Update Environment.Version test to not expect hardcoded version

Contributes to https://github.com/dotnet/corefx/issues/31099

* Fix nit

Commit migrated from https://github.com/dotnet/corefx/commit/d8473a7bab7cb9b26344281913c488b7475644bb

5 years agoUse a pooled buffer in BrotliStream (dotnet/corefx#35492)
Stephen Toub [Fri, 22 Feb 2019 03:16:04 +0000 (22:16 -0500)]
Use a pooled buffer in BrotliStream (dotnet/corefx#35492)

* Use a pooled buffer in BrotliStream

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/bca44089343cf14cffd3cb0982b7e209692f6731

5 years agoReduce the amount of exceptions throw in Advance (dotnet/corefx#35509)
David Fowler [Fri, 22 Feb 2019 03:15:41 +0000 (19:15 -0800)]
Reduce the amount of exceptions throw in Advance (dotnet/corefx#35509)

* Reduce the amount of exceptions throw in Advance
- Advance checks for 3 error conditions today, no writing head (no body called GetMemory()), bytesWritten being a positive number and that Advance is called with a bytesWritten between 0 and _writingMemory.Length. Instead, just unify those into a single ArgumentOutOfRangeException.

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/498a7e169a452d3e53a061c1433aea637506a14a

5 years agoRestore optional tooling for windows to use optimization data (dotnet/corefx#35433)
Santiago Fernandez Madero [Fri, 22 Feb 2019 02:32:07 +0000 (18:32 -0800)]
Restore optional tooling for windows to use optimization data (dotnet/corefx#35433)

Commit migrated from https://github.com/dotnet/corefx/commit/c839a4d5b1cb8889e6251d47aed3fdfd098586ef

5 years agoReduce PLINQ outerloop test execution time (dotnet/corefx#35510)
Stephen Toub [Fri, 22 Feb 2019 02:17:11 +0000 (21:17 -0500)]
Reduce PLINQ outerloop test execution time (dotnet/corefx#35510)

Our PLINQ test suite has a ridiculously large number of test cases, in particular in outerloop (~200K), and as such it takes a long time to run.  In outerloop CI legs on some machines we're currently bumping up against time limits, causing spurious failures.  While more may be needed, these two small tweaks shrink execution time on my machine by 50%.

Commit migrated from https://github.com/dotnet/corefx/commit/bec9e1ec77306f339fd2b34d0e9b6013b5555c39

5 years agoUse the .NET Core product version for informational version description (dotnet/coref...
Jan Kotas [Fri, 22 Feb 2019 02:08:30 +0000 (18:08 -0800)]
Use the .NET Core product version for informational version description (dotnet/corefx#35436)

* Use the .NET Core product version for informational version description

The 4.X.Y.Z versions that we use for file and assembly versions are confusing. We can make the situation better by including the official .NET Core version in the informational assembly version description at least.

* Move ProductVersion to Versions.props

* Move Packaging.props to later

Commit migrated from https://github.com/dotnet/corefx/commit/0577135efa86fec33f1cc9bb10808d31e302a94f

5 years agoPublish corefx test assets (dotnet/corefx#35473)
Mike McLaughlin [Fri, 22 Feb 2019 00:43:56 +0000 (16:43 -0800)]
Publish corefx test assets (dotnet/corefx#35473)

* Publish corefx test assets

So coreclr and other repos can run the corefx tests.

New step to publish the test zip files to dotnet-core blob storage.

Publishes the build manifest from above to blob storage path:

https://dotnetfeed.blob.core.windows.net/dotnet-core/corefx-tests/$(Version)/$(TargetOS).$(ArchGroup)/$(TargetGroup)/corefx-test-assets.xml

Declare DotNet-Blob-Feed only in official builds

* Code review feedback.

The blob path should NOT be Normalized.

* WIP

Commit migrated from https://github.com/dotnet/corefx/commit/bfb495d39e2d7b5d7cc0b571ed504670b2faa68c

5 years agoMerge pull request dotnet/corefx#35485 from geoffkizer/http2streamstate
Geoff Kizer [Fri, 22 Feb 2019 00:03:00 +0000 (16:03 -0800)]
Merge pull request dotnet/corefx#35485 from geoffkizer/http2streamstate

add StreamState and rework HTTP2 stream state handling

Commit migrated from https://github.com/dotnet/corefx/commit/cab8d6bbfe49c7571f682234622f4ea3bfcf5010

5 years agoOverride WriteAsync on the DefaultPipeWriter (dotnet/corefx#35484)
David Fowler [Thu, 21 Feb 2019 23:31:23 +0000 (15:31 -0800)]
Override WriteAsync on the DefaultPipeWriter (dotnet/corefx#35484)

- Today we're using an extension method on IBufferWrite<T> to implement
copying the input buffer to the underlying PipeWriter. Luckily this
method is virtual so we can optimize using the Pipe's internal structures
directly rather than going through GetMemory and Advance

Commit migrated from https://github.com/dotnet/corefx/commit/a0bbeb7f2143a063eb5e944026787974362c8b3d

5 years agofix ping TTL option for OSX (dotnet/corefx#35506)
Tomas Weinfurt [Thu, 21 Feb 2019 23:01:02 +0000 (15:01 -0800)]
fix ping TTL option for OSX (dotnet/corefx#35506)

Commit migrated from https://github.com/dotnet/corefx/commit/ecad65740b41b1502188ac6b412ade53fb54ba3e

5 years agoaddress PR feedback
Geoff Kizer [Thu, 21 Feb 2019 21:52:02 +0000 (13:52 -0800)]
address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/333fabaffeabf3b4de5d6ba45e54b2078f57adcf

5 years agoMake restore of external 2-pass
ericstj [Thu, 21 Feb 2019 00:54:05 +0000 (16:54 -0800)]
Make restore of external 2-pass

Commit migrated from https://github.com/dotnet/corefx/commit/c8e44c3d027d0539e7f9091336cc48e59e7d03e8

5 years agoRestore IBC data and embed during Windows release builds
Eric St. John [Wed, 20 Feb 2019 00:35:49 +0000 (16:35 -0800)]
Restore IBC data and embed during Windows release builds

See the following docs.
https://github.com/dotnet/arcade/blob/dotnet/corefx@bac85242024ba867b6204b90c1522793093f5e31/Documentation/ArcadeSdk.md#ibc-optimization-data-embedding

We are using IBC data produced by our perf team and embedding into all builds of a DLL;
currently we don't distinguish cross-compiles of the same DLL, nor does arcade define any
conventions to do so.  I've disabled it for references and not-supported assemblies.

Commit migrated from https://github.com/dotnet/corefx/commit/96661fad0e63a7869539fa0981c8b8be2f3824d3

5 years agoDisable two Socket.Begin/EndSendFile tests (dotnet/corefx#35494)
Stephen Toub [Thu, 21 Feb 2019 17:16:35 +0000 (12:16 -0500)]
Disable two Socket.Begin/EndSendFile tests (dotnet/corefx#35494)

Commit migrated from https://github.com/dotnet/corefx/commit/1c802d6d8c06b727c102c00e5eb4224de9608a16

5 years agoOmit Environment.Version from CodeDom generated files (dotnet/corefx#35458)
Jan Kotas [Thu, 21 Feb 2019 17:15:56 +0000 (09:15 -0800)]
Omit Environment.Version from CodeDom generated files (dotnet/corefx#35458)

* Omit Environment.Version from CodeDom generated files

Contributes to https://github.com/dotnet/coreclr/pull/22664

* Disable tests on .NET Framework

Commit migrated from https://github.com/dotnet/corefx/commit/89f72f6edb0d4ec18afa8e8138d1f12fdde09e5d

5 years agoMerge pull request dotnet/corefx#35489 from dotnet/darc-master-f2564df9-8df7-4569...
Stephen Toub [Thu, 21 Feb 2019 16:46:00 +0000 (11:46 -0500)]
Merge pull request dotnet/corefx#35489 from dotnet/darc-master-f2564df9-8df7-4569-8e31-4500b86d8bfa

[master] Update dependencies from dotnet/coreclr

Commit migrated from https://github.com/dotnet/corefx/commit/3ec07dba620c98da2a53856ab756d9322972d953

5 years agoUpdate publish.yml
Viktor Hofer [Thu, 21 Feb 2019 14:42:16 +0000 (15:42 +0100)]
Update publish.yml

Commit migrated from https://github.com/dotnet/corefx/commit/4762671d7034adced7320f8e8f9b4f1d53c88450

5 years agoFix ArgumentOutOfRangeException validation in GregorianCalendarTests.cs
Stephen Toub [Thu, 21 Feb 2019 14:30:40 +0000 (09:30 -0500)]
Fix ArgumentOutOfRangeException validation in GregorianCalendarTests.cs

Commit migrated from https://github.com/dotnet/corefx/commit/07116a67cacaa2965479429a1bfd19fb60fcd53f

5 years agoMerge branch 'master' into darc-master-f2564df9-8df7-4569-8e31-4500b86d8bfa
Stephen Toub [Thu, 21 Feb 2019 14:27:43 +0000 (09:27 -0500)]
Merge branch 'master' into darc-master-f2564df9-8df7-4569-8e31-4500b86d8bfa

Commit migrated from https://github.com/dotnet/corefx/commit/fb4bcafc113a208da4ba60b8f56bc58689d624b3

5 years agoAdd test targets to build script (dotnet/corefx#34385)
Viktor Hofer [Thu, 21 Feb 2019 14:18:47 +0000 (15:18 +0100)]
Add test targets to build script (dotnet/corefx#34385)

* Add test targets to build script

* Remove few manual copy targets in projects

* Remove PlatformAbstractions dependency

* Update ArchiveTests type to enum

* Set warnaserror false on arm/arm64

* Update docs

* Darc update from build '20190221.4'

Commit migrated from https://github.com/dotnet/corefx/commit/a619534cac9b7d000f0899248656d232cb44f61f

5 years agoUpdate CoreFxOptimizationData to master-20190221.1 (dotnet/corefx#35482)
dotnet-maestro-bot [Thu, 21 Feb 2019 12:22:00 +0000 (04:22 -0800)]
Update CoreFxOptimizationData to master-20190221.1 (dotnet/corefx#35482)

Commit migrated from https://github.com/dotnet/corefx/commit/d86f48243bdd9ec9b187d6e142e209a0adccc761

5 years agoadd StreamState and rework HTTP2 stream state handling
Geoff Kizer [Wed, 20 Feb 2019 20:54:39 +0000 (12:54 -0800)]
add StreamState and rework HTTP2 stream state handling

cleanup

Commit migrated from https://github.com/dotnet/corefx/commit/1eba83637d47fde09c8e1748b0ebb4ca42da5ca4

5 years agoRemove unused upload-tests.proj (dotnet/corefx#35475)
Santiago Fernandez Madero [Thu, 21 Feb 2019 02:41:48 +0000 (18:41 -0800)]
Remove unused upload-tests.proj (dotnet/corefx#35475)

Commit migrated from https://github.com/dotnet/corefx/commit/8a9dd52ae5bab85ec3bd1d3cf73ba165668332f0

5 years agoImprove BitArray's Get, Set, SetAll and Not methods performance (dotnet/corefx#35364)
OmariO [Thu, 21 Feb 2019 02:25:20 +0000 (02:25 +0000)]
Improve BitArray's Get, Set, SetAll and Not methods performance (dotnet/corefx#35364)

* Improve BitArray's Get, Set, Set All and Not methods performance. The generated code is smaller and allows to use AggressiveInlining for Get and Set.

* Update BitArray.cs

Commit migrated from https://github.com/dotnet/corefx/commit/2b8e77e0b1e8699db7e3656a6ad86d181317a155

5 years agoMove Thread to shared CoreLib (dotnet/corefx#35462)
Filip Navara [Thu, 21 Feb 2019 02:23:41 +0000 (03:23 +0100)]
Move Thread to shared CoreLib (dotnet/corefx#35462)

Commit migrated from https://github.com/dotnet/corefx/commit/694eeba312046e2097c731d40f32c1cac675aa03

5 years agodon't dispose the HTTP2 connection writer lock, to avoid race (dotnet/corefx#35468)
Geoff Kizer [Thu, 21 Feb 2019 02:23:19 +0000 (18:23 -0800)]
don't dispose the HTTP2 connection writer lock, to avoid race (dotnet/corefx#35468)

* don't dispose the writer lock, to avoid race

* Update Http2Connection.cs

Commit migrated from https://github.com/dotnet/corefx/commit/c4c8f72cd8d18d6ec00afea6644ae2077d442869

5 years agoUpdate intellisense files for S.Mem, S.T.Json, S.Runtime based on (dotnet/corefx...
Ahson Khan [Thu, 21 Feb 2019 00:29:57 +0000 (16:29 -0800)]
Update intellisense files for S.Mem, S.T.Json, S.Runtime based on (dotnet/corefx#35467)

02-14-2019 doc build.

Commit migrated from https://github.com/dotnet/corefx/commit/84b4bed23b55d47adb8da0134dc6346b622ca8eb

5 years agoFactor IPAddress.Loopback.MapToIPv6() into IPAddress.IsLooback (dotnet/corefx#35463)
Stephen Toub [Thu, 21 Feb 2019 00:24:39 +0000 (19:24 -0500)]
Factor IPAddress.Loopback.MapToIPv6() into IPAddress.IsLooback (dotnet/corefx#35463)

Simply change to check for IPAddress.Loopback.MapToIPv6() in addition to IPAddress.Loopback and IPAddress.IPv6Loopback in IPAddress.IsLoopback.  Doing so caused a small regression in throughput for IPAddress.Equals, so I made a few other tweaks to avoid the regression.

Commit migrated from https://github.com/dotnet/corefx/commit/a8945a36bb2d6068dc2e6b07573f0207e4eb8b85

5 years agoFix xNodeBuilder test (again) (dotnet/corefx#35464)
Stephen Toub [Wed, 20 Feb 2019 23:55:04 +0000 (18:55 -0500)]
Fix xNodeBuilder test (again) (dotnet/corefx#35464)

They're failing on netfx after my previous test fix, because on netfx float.MaxValue.ToString() != float.MaxValue.ToString("R").

Commit migrated from https://github.com/dotnet/corefx/commit/16e56860466ec2eb32f8544a5fb1b4b8aafadcf8

5 years agoSimplify ProcessorCount tests to fix sporadic failures (dotnet/corefx#35465)
Stephen Toub [Wed, 20 Feb 2019 23:54:35 +0000 (18:54 -0500)]
Simplify ProcessorCount tests to fix sporadic failures (dotnet/corefx#35465)

We do complicated logic based on a variety of conditions to detect the processor count on Unix; trying to duplicate that logic in the test would essentially just be a copy and paste of the shipping code, which isn't particularly useful.  Until we can do something better, I'm simplifying the tests to just check that we get a valid count out of ProcessorCount.

Commit migrated from https://github.com/dotnet/corefx/commit/fc3a20282c73f2b4a5c582c0e3be441d7301b4d8

5 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-27421-00, beta-27421-00, respectively...
dotnet-maestro-bot [Wed, 20 Feb 2019 21:47:10 +0000 (13:47 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27421-00, beta-27421-00, respectively (dotnet/corefx#35461)

Commit migrated from https://github.com/dotnet/corefx/commit/16ba574ccebea1175ff5b20139b76c4a68022856

5 years agoProcess.KillTree: Unix: don't throw for processes that have exited already (dotnet...
Tom Deseyn [Wed, 20 Feb 2019 20:45:09 +0000 (21:45 +0100)]
Process.KillTree: Unix: don't throw for processes that have exited already (dotnet/corefx#35452)

Commit migrated from https://github.com/dotnet/corefx/commit/ac3ccfe29a9ecb675e779c1548386ee050a072cd

5 years agoBump S.S.C.Pkcs AssemblyVersion Minor version (dotnet/corefx#35429)
Jeremy Barton [Wed, 20 Feb 2019 19:43:18 +0000 (11:43 -0800)]
Bump S.S.C.Pkcs AssemblyVersion Minor version (dotnet/corefx#35429)

* Bump S.S.C.Pkcs AssemblyVersion Minor version

New API was added for .NET Core 3.0, so the assembly minor needs to bump.

* Fix packaging validation errors

* Apply review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/b4f94abd2bc7c8f3167cd7301147a08cbf2ea3df

5 years agoSimplify ConnectHelper.ConnectAsync to just return Stream (dotnet/corefx#35411)
Stephen Toub [Wed, 20 Feb 2019 19:38:31 +0000 (14:38 -0500)]
Simplify ConnectHelper.ConnectAsync to just return Stream (dotnet/corefx#35411)

* Simplify ConnectHelper.ConnectAsync to just return Stream

SocketsHttpHandler's ConnectHelper.ConnectAsync currently returns a tuple of (Socket, Stream).  We can instead just have it return the Stream and allow the call site to fish out the Socket from the Stream if it can.  This is slightly more efficient memory-wise, in that the state machine involved will be smaller, but it also allows for a potential extensibility point that's simpler (abstracting out the ConnectAsync as a callback) and potentially allows us to in the future get a Socket in more cases, e.g. any connection helper handing back a NetworkStream.

Unfortunately, NetworkStream.Socket is protected rather than public.  Until such time that there's a public property for this, there are two options here:
1. Use reflection to create a delegate we can then use to get at the property; "Socket" is part of the exposed surface area, so the only dependency here is on documented surface area.
2. Create a custom NetworkStream-derived type that exposes the protected as a public.

I started with (2), which works fine for our own internal needs currently, but shifted to (1), as it's more flexible.

* Don't use reflection

Commit migrated from https://github.com/dotnet/corefx/commit/d9cdbc3cca0f75e5d7692f9ae03978dd0ed9b2e9

5 years agoStop blocking thread pool threads in VirtualNetwork-based tests (dotnet/corefx#35453)
Stephen Toub [Wed, 20 Feb 2019 19:35:52 +0000 (14:35 -0500)]
Stop blocking thread pool threads in VirtualNetwork-based tests (dotnet/corefx#35453)

The SslStream tests and others use an internal VirtualNetwork helper.  It's stream's ReadAsync method currently queues a work item to the thread pool that then blocks.  This results in spurious failures and timeouts as all of the threads in the pool get blocked under load.

Commit migrated from https://github.com/dotnet/corefx/commit/6b2628c69abaafda37dcd4fcb57e173a4f689e0c

5 years agoMerge pull request dotnet/corefx#35432 from geoffkizer/windowupdatethreshold
Geoff Kizer [Wed, 20 Feb 2019 19:26:12 +0000 (11:26 -0800)]
Merge pull request dotnet/corefx#35432 from geoffkizer/windowupdatethreshold

defer sending WINDOW_UDPATE frames until a minimum threshold has been met

Commit migrated from https://github.com/dotnet/corefx/commit/852602a3cebc2bfa14199cf6c39368bad1903c6c

5 years agoAdd net472 build3260 blobs (dotnet/corefx#35448)
Viktor Hofer [Wed, 20 Feb 2019 17:52:01 +0000 (18:52 +0100)]
Add net472 build3260 blobs (dotnet/corefx#35448)

Commit migrated from https://github.com/dotnet/corefx/commit/b018ced265fe099679be0ec1e7afa805a154d49a

5 years agoFix tizen rootfs building (dotnet/corefx#35450)
Konstantin Baladurin [Wed, 20 Feb 2019 16:53:12 +0000 (19:53 +0300)]
Fix tizen rootfs building (dotnet/corefx#35450)

Move tizen-release package from base to unified repo

Commit migrated from https://github.com/dotnet/corefx/commit/17344dbf36ab683804eb69a173f61c66de1a605d

5 years agoUpdate CoreFxOptimizationData, ProjectNTfs, ProjectNTfsTestILC to master-20190220...
dotnet-maestro-bot [Wed, 20 Feb 2019 15:38:19 +0000 (07:38 -0800)]
Update CoreFxOptimizationData, ProjectNTfs, ProjectNTfsTestILC to master-20190220.1, beta-27420-00, beta-27420-00, respectively (dotnet/corefx#35440)

Commit migrated from https://github.com/dotnet/corefx/commit/c71537350eeb786e80326473bfa5d7fcab172988

5 years agoAdded some doc comments to AsStream (dotnet/corefx#35442)
David Fowler [Wed, 20 Feb 2019 11:56:06 +0000 (03:56 -0800)]
Added some doc comments to AsStream (dotnet/corefx#35442)

Commit migrated from https://github.com/dotnet/corefx/commit/817d0557250ba0ea57f3aeba10934e1188fc0e88

5 years agoMerge pull request dotnet/corefx#35415 from ViktorHofer/UWP-CI
Viktor Hofer [Wed, 20 Feb 2019 09:16:12 +0000 (10:16 +0100)]
Merge pull request dotnet/corefx#35415 from ViktorHofer/UWP-CI

Reenable UWP CI legs and upgrade to RS5

Commit migrated from https://github.com/dotnet/corefx/commit/5385874fa7ab20f9e33997ebd20f31ae272bf7c5

5 years agoPR feedback
Geoff Kizer [Wed, 20 Feb 2019 03:54:30 +0000 (19:54 -0800)]
PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/8b4d2f58cd89efbe0d0b2a487d5ce96353c83150

5 years agoUpdate CoreFxOptimizationData to master-20190219.1 (dotnet/corefx#35431)
dotnet-maestro-bot [Wed, 20 Feb 2019 01:50:37 +0000 (17:50 -0800)]
Update CoreFxOptimizationData to master-20190219.1 (dotnet/corefx#35431)

Commit migrated from https://github.com/dotnet/corefx/commit/a92b750a5edd4d262422e16260c4223ef7771c39

5 years agoDisallow dangerous Unicode decompositions (dotnet/corefx#35428)
Max Kerr [Wed, 20 Feb 2019 01:29:37 +0000 (17:29 -0800)]
Disallow dangerous Unicode decompositions (dotnet/corefx#35428)

* Merged PR 159084: [2.2 Servicing] MSRC 47421: Disallow dangerous Unicode decompositions in System.Uri

This is a direct port of PR 158405.

This change blocks any Unicode decompositions that change the semantics of a URI. See the comments included in the change for more details.

Unlike the netfx implementation of this change, there is no mechanism for users to disable the fix. I believe that this is the correct choice for two reasons:

(1) Domain name registrars have disallowed these characters for almost as long as they have allowed punycode, so it's unlikely there are legitimate domains using them.
(2) The consequences of disabling the fix are significant, and are likely non-obvious to most users.

* Temporarily disable test on netfx

* Add a note on why the test is disabled on netfx.

Commit migrated from https://github.com/dotnet/corefx/commit/b8654425442fef4ba4b58510be53d9859887be1a

5 years agoMake Http2Connection.SendFrameAsync return ValueTask (dotnet/corefx#35426)
Stephen Toub [Wed, 20 Feb 2019 01:27:49 +0000 (20:27 -0500)]
Make Http2Connection.SendFrameAsync return ValueTask (dotnet/corefx#35426)

This method frequently completes synchronously, and in such cases we can avoid the task allocation.

Commit migrated from https://github.com/dotnet/corefx/commit/52993e52f9d3ab30da54884f7c5e0cdea2518e28

5 years agoRemove dead code (dotnet/corefx#35430)
Alaa Masoud [Wed, 20 Feb 2019 01:04:45 +0000 (04:04 +0300)]
Remove dead code (dotnet/corefx#35430)

Commit migrated from https://github.com/dotnet/corefx/commit/000aa2e0740524bdc2db690201e1b3521dd417a3

5 years agodefer sending WINDOW_UDPATE frames until a minimum threshold has been met
Geoff Kizer [Tue, 19 Feb 2019 09:43:27 +0000 (01:43 -0800)]
defer sending WINDOW_UDPATE frames until a minimum threshold has been met

Commit migrated from https://github.com/dotnet/corefx/commit/99f8d99738f78b6791e2b30b9fababa9f8daa643

5 years agoImprove HTTP2 connection diagnostics in SocketsHttpHandler (dotnet/corefx#35423)
David Shulman [Tue, 19 Feb 2019 22:33:43 +0000 (14:33 -0800)]
Improve HTTP2 connection diagnostics in SocketsHttpHandler (dotnet/corefx#35423)

Modified the top-level exception being returned (HttpRequestException) to always include
the inner exception.

Contributes to dotnet/corefx#35422

Commit migrated from https://github.com/dotnet/corefx/commit/fcf46bea903c78accd9586fa2fb355ade70c485e

5 years agoAdded AsStream to PipeReader and PipeWriter (dotnet/corefx#35399)
David Fowler [Tue, 19 Feb 2019 22:24:50 +0000 (14:24 -0800)]
Added AsStream to PipeReader and PipeWriter (dotnet/corefx#35399)

- This adds a new virtual member to PipeReader and PipeWriter to get a read only or write only stream from the PipeReader and PipeWriter
- This introduces a new field on the base types
- Added tests

Commit migrated from https://github.com/dotnet/corefx/commit/968a6a4450ca5acd3aed6a6f6e1f8b445348e729

5 years agoUse SourceBranch vs. SourceBranchName (dotnet/corefx#35413)
Matt Mitchell [Tue, 19 Feb 2019 18:29:21 +0000 (10:29 -0800)]
Use SourceBranch vs. SourceBranchName (dotnet/corefx#35413)

* Use SourceBranch vs. SourceBranchName
SourceBranchName only evaluates to the last path name of the branch:
- 3.0 in release/3.0
We want the full branch, with refs/heads for consistency with the rest of the repos

Commit migrated from https://github.com/dotnet/corefx/commit/36167bc544b968ed0bd67915f6512043a07734e0

5 years agoRemove dead code (dotnet/corefx#35405)
Alaa Masoud [Tue, 19 Feb 2019 17:54:29 +0000 (20:54 +0300)]
Remove dead code (dotnet/corefx#35405)

Commit migrated from https://github.com/dotnet/corefx/commit/9ccba7612721c347c8373cd4d226b1ac1329a73f

5 years agoUpgrade uwp windows machines to RS5
Viktor [Tue, 19 Feb 2019 17:20:35 +0000 (18:20 +0100)]
Upgrade uwp windows machines to RS5

Commit migrated from https://github.com/dotnet/corefx/commit/56ad4b45a23b13f289fb9145c6eb5dca1969a1cc

5 years agoRevert "Don't run tests on uap PR leg"
Viktor [Tue, 19 Feb 2019 17:18:06 +0000 (18:18 +0100)]
Revert "Don't run tests on uap PR leg"

This reverts commit dotnet/corefx@c34a9be660974ca1461a5f87d99e6750ae8dcb6b.

Commit migrated from https://github.com/dotnet/corefx/commit/e8d186bc8eff2878ebe4a129cfba61a23343b516

5 years agoFix Negotiate/SPNEGO Kerberos to NTLM fallback on Linux (dotnet/corefx#35383)
David Shulman [Tue, 19 Feb 2019 17:14:44 +0000 (09:14 -0800)]
Fix Negotiate/SPNEGO Kerberos to NTLM fallback on Linux (dotnet/corefx#35383)

This PR adds support to our Linux gssapi layer so that we properly handle the Negotiate
protocol (SPNEGO) being able to to fall back from Kerberos to NTLM.

Windows Negotiate SSPI implements the SPNEGO protocol. However, it has built-in error
handling for dealing with quick fallback from Kerberos to NTLM in error cases such as where
the client is not on a domain/Kerberos realm, the client is using a local credential, the
client is talking to a non-domain server, etc.

However, the Linux implementation of SPNEGO doesn't handle those error cases very well.
So, I added the proper retry logic when generating the initial context token. Now, we will
be able to fall back from SPNEGO-wrapped Kerberos to SPNEGO-wrapped NTLM protocol blobs.

A similar bug exists in libcurl which is why Curl and CurlHandler are unable to connect to
Negotiate servers when not part of the Kerberos realm. I am considering proposing my fixes
to the libcurl repo as well.

I added more tests to support this PR and did manual testing. I added some additional
EventSource tracing as well.

Contributes to dotnet/corefx#34878

Commit migrated from https://github.com/dotnet/corefx/commit/1fd3ba126538c2fed76d2279db26dc7ba5ceed41

5 years agoFix product name included in the binaries (dotnet/corefx#35408)
Jan Kotas [Tue, 19 Feb 2019 16:18:53 +0000 (08:18 -0800)]
Fix product name included in the binaries (dotnet/corefx#35408)

Commit migrated from https://github.com/dotnet/corefx/commit/6999d5e9809c22be73b71ab1f16d83721cc245e4

5 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-27419-00, beta-27419-00, respectively...
dotnet-maestro-bot [Tue, 19 Feb 2019 15:07:11 +0000 (07:07 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27419-00, beta-27419-00, respectively (dotnet/corefx#35402)

Commit migrated from https://github.com/dotnet/corefx/commit/d9e276e451a8f4dded8272822d13001555a28ff3

5 years agoUse Environment.TickCount instead of DateTime{Offset}.UtcNow in SocketsHttpHandler...
Stephen Toub [Tue, 19 Feb 2019 05:38:07 +0000 (00:38 -0500)]
Use Environment.TickCount instead of DateTime{Offset}.UtcNow in SocketsHttpHandler (dotnet/corefx#35401)

We don't need the accuracy of UtcNow nor the absolute time when getting a time stamp in order to determine whether a connection should be retired; rather, we only need an approximate difference in time.  This means the resolution of TickCount is fine, and the worst that happens if a connection happens to be alive for more than its ~49 day period is we may allow the connection to then live even longer than we otherwise would.  In exchange, we get a much cheaper mechanism (~20x on Windows) mechanism for computing the connection age.

Commit migrated from https://github.com/dotnet/corefx/commit/dca39727b02ceb4413d0fde11467965099ab4a2f

5 years agoRemove old TestCategories property (dotnet/corefx#35397)
Viktor Hofer [Tue, 19 Feb 2019 02:40:02 +0000 (03:40 +0100)]
Remove old TestCategories property (dotnet/corefx#35397)

Commit migrated from https://github.com/dotnet/corefx/commit/18452453fe8de55a065841798eb5e7a56c3436cb