platform/upstream/iotivity.git
9 years agoResolved Compilation issues in Routing Manager
vimala.v [Mon, 21 Sep 2015 05:20:57 +0000 (10:50 +0530)]
Resolved Compilation issues in Routing Manager

Change-Id: Ibc911824538e2d2b12e346fad802d9b6ecbd7060
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2807
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoModify Improper deletion of ArrayList
Jaehong Jo [Mon, 21 Sep 2015 07:44:56 +0000 (16:44 +0900)]
Modify Improper deletion of ArrayList

As array list member is not created in runtime, deletion causes memory crash.

Change-Id: Idc15349b70ff77a8446e76488ff3ca13c055e475
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2829
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoandroid: add misssing error codes to stackResultToStr()
Hauke Mehrtens [Thu, 17 Sep 2015 16:51:33 +0000 (18:51 +0200)]
android: add misssing error codes to stackResultToStr()

The OC_STACK_UNAUTHORIZED_REQ error code and some others were missing in
the method for translating them into strings.
Without this patch it resulted in this exception:
org.iotivity.base.OcException: stack error in onObserveCallback JNI_INVALID_VALUE

Change-Id: I739dfecafff55c035702a27a9b5d8dcb925993f4
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2643
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agofixed the prevent issues for CA linux platform.
hyuna0213.jo [Fri, 18 Sep 2015 07:23:29 +0000 (16:23 +0900)]
fixed the prevent issues for CA linux platform.

-remove the build warning
-memory free logic
-changed the structure initialization

Change-Id: Iab788102c0ea259fac54ae43c01fcb504ba8eec3
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2679
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoUpdated java doc comments for services : TM and RE layer
Jay Sharma [Tue, 22 Sep 2015 11:38:45 +0000 (17:08 +0530)]
Updated java doc comments for services : TM and RE layer

- updated comments for bundle-java-api of Resurce Container module
- updated comments of Things Manager.

Change-Id: I39970e0cce8920488ac034d3b110421dce2fc0de
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2923
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoFix a build failure issue of resource-encapsulation for android-debug mode.
coderhyme [Tue, 22 Sep 2015 08:51:29 +0000 (01:51 -0700)]
Fix a build failure issue of resource-encapsulation for android-debug mode.

Change-Id: I8bc556913b9582814144ef05fd5a9484b857a241
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2917
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoUpdate unittest of notification-manager.
jyong2.kim [Tue, 22 Sep 2015 06:58:28 +0000 (15:58 +0900)]
Update unittest of notification-manager.

Adding unittest for HostingObject Class,
and fixing release of smart pointer.

Change-Id: Ia27070b5908c5b42348a430dc602e136b70a9217
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2911
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoFix handler setters of RcsResourceObject of resource-encapsulation android api.
coderhyme [Tue, 22 Sep 2015 07:36:48 +0000 (00:36 -0700)]
Fix handler setters of RcsResourceObject of resource-encapsulation android api.

Handler setters should accept null to erase one set earlier.
It is to make apis consistent between c++ and android.

Additionally an issue caused by using old exception class name is fixed.

Change-Id: I273755b6d2ab48a489d1829aa932b2f675332db6
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2915
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoFix broken tests of resource-encapsulation.
coderhyme [Tue, 22 Sep 2015 04:21:38 +0000 (21:21 -0700)]
Fix broken tests of resource-encapsulation.

DiscoveryManagerTest is moved.
ResourceClientTest is modified to conform to the modified discovery manager.

Change-Id: I55b1fcfa00e4a606796f44ee4c84351dfaebc4c7
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2907
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years ago[Resource-Encapsulation] Prevent fixes for Linux Sample applications.
Jay Sharma [Mon, 21 Sep 2015 06:24:35 +0000 (11:54 +0530)]
[Resource-Encapsulation] Prevent fixes for Linux Sample applications.

Change-Id: Ibd2ec1c4af6994a7022526f5afb8c2c274f20ec8
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2815
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agocorrect the comment about mis-definition of class "RCSResourceContainer" for doxygen
Rami Jung [Mon, 21 Sep 2015 23:59:16 +0000 (08:59 +0900)]
correct the comment about mis-definition of class "RCSResourceContainer" for doxygen

The mismatch between the real name of a class RCSResourceContainer and it's comment resulted in the wrong doxygen description .
It means that Doxygen had two seperate definitions like RCSResourceContainer and ResourceContainer.

Change-Id: I3a3647ace72b641862cd05b7d4ee2c8d98aeaf75
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2885
Reviewed-by: Markus Jung <markus.jung@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agochange resource type names of resource container samples
Minji Park [Mon, 21 Sep 2015 11:18:31 +0000 (20:18 +0900)]
change resource type names of resource container samples

- modify container sample bundles, unittest and bundle configfiles
- change resource types of sample input sensors

Change-Id: I2738a8c2ad1f5e28ea5a3dd2d6c48739b7be9a5b
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2857
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoUpdate SConscript in service
hunje.yeon [Mon, 21 Sep 2015 14:24:52 +0000 (23:24 +0900)]
Update SConscript in service

Cleans SConscript in service folder by removing soft-sensor and
protocol plugin SConscript

Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Change-Id: Iccc880151f6b77a43f6f956eb6a7a40da25547ee
Reviewed-on: https://gerrit.iotivity.org/gerrit/2869
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoFixed bug in SRMIsSecurityResourceURI()
vimala.v [Mon, 21 Sep 2015 13:24:22 +0000 (18:54 +0530)]
Fixed bug in SRMIsSecurityResourceURI()

SRMIsSecurityResourceURI() API was returning "TRUE" for all resources with
URI starting with "/oic".  sizeof() char * is always 4.  Changed to strlen().

Change-Id: I2287ee29c677bf7229a80779fa150c73abb7db19
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2863
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoUpdate Sconscript of notification-manager.
jyong2.kim [Mon, 21 Sep 2015 11:33:05 +0000 (20:33 +0900)]
Update Sconscript of notification-manager.

Samples exclude from the install target,
and library header include to the install target.

Change-Id: I06c7a2b8302c8d43d00cf2884098af97eb75bddf
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2855
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoAdd missing copyright
coderhyme [Mon, 21 Sep 2015 10:22:01 +0000 (03:22 -0700)]
Add missing copyright

Change-Id: Ib376f468e060920ce0315ab36d582c365f7aea1e
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2845
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoFix bugs in things manager reported as defects
Jihun Ha [Mon, 21 Sep 2015 10:10:51 +0000 (19:10 +0900)]
Fix bugs in things manager reported as defects

CIDs: 65815, 65820, 65838, 65877, 77411, 77412, 81301, 81305, 81306, 81584

Additionally, modify resource type to be compatible to RFC 6690 guideline
for factory set resource.

Change-Id: Ia598cc00f8b3810a14a6341e941f20b11e3c4bfd
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2843
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoRemove wrapping '(' and ')' in OC_LOG arguments to resolve Tizen Build error.
Woochul Shim [Mon, 21 Sep 2015 07:44:59 +0000 (16:44 +0900)]
Remove wrapping '(' and ')' in OC_LOG arguments to resolve Tizen Build error.

Change-Id: I5ca0849bcde655c6eb8962c28bc5c4320f4bf925
Signed-off-by: Woochul Shim <woochul.shim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2827
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoRename resource-encapsulation exception classes.
coderhyme [Mon, 21 Sep 2015 06:25:15 +0000 (23:25 -0700)]
Rename resource-encapsulation exception classes.

It is to make class names consistent.
All exposed classes in resource-encapsultion layer as the API must start with RCS.

Change-Id: I64280bc959a60d368cfabab731196e35a7383a94
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2817
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoModify NotificationManager code to change resource type
Younghyun Joo [Mon, 21 Sep 2015 08:43:49 +0000 (17:43 +0900)]
Modify NotificationManager code to change resource type

- change the capital of resource type into the small letter

Change-Id: I85d34e25c903a826f2b4a16781991ee61b75b16b
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2835
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoMaking simulator build optional through scons command line argument "SIMULATOR".
Harish Kumara Marappa [Mon, 21 Sep 2015 07:09:11 +0000 (12:39 +0530)]
Making simulator build optional through scons command line argument "SIMULATOR".

simulator module will be built only if scons command passed with SIMULATOR
argument having one of the case insensitive value from "True", "Yes", "Y" and "1".

Example: scons SIMULATOR=1

Change-Id: Ie5dcd839d8770d219de1d623d60c23be0133bb1c
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2823
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoFix the build failures on Ubuntu 12.04 32-bit machine.
Ravi Nanjundappa [Mon, 21 Sep 2015 05:33:15 +0000 (11:03 +0530)]
Fix the build failures on Ubuntu 12.04 32-bit machine.

Changes incorporate inclusion of "condition_variable" header file
in notification-manager dir.

Change-Id: I8dcf2a54579d8c5a1ce9f60a6498007eb7fe2c37
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2809
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years ago[Resource-Encapsulation] Tizen build fixes. Removal of SSM and PPM library references.
arya.k [Mon, 21 Sep 2015 06:46:03 +0000 (12:16 +0530)]
[Resource-Encapsulation] Tizen build fixes. Removal of SSM and PPM library references.

Change-Id: I038be50d750333696fcc1ee111fb7fc53bf7729e
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2819
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoMerge branch 'plugin-interface' into master
Joseph Morrow [Sun, 20 Sep 2015 22:06:56 +0000 (15:06 -0700)]
Merge branch 'plugin-interface' into master

Change-Id: Idb58ff366694797d8bc433e974faf2c6124091aa
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
9 years agoAdded Telegesis & Zigbee Wrappers, mapping logic, and plugin interface.
Joseph Morrow [Sun, 20 Sep 2015 20:57:00 +0000 (13:57 -0700)]
Added Telegesis & Zigbee Wrappers, mapping logic, and plugin interface.

These additions encompass the first pre-release of the plugin
interface.

A unit test, server, client application are also included.

Change-Id: Ia61a01223f611ffc1e38e79b8e3a8317fb3f34cd
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Signed-off-by: Thuyen Tran <thuyen.c.tran@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2771
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoChanged zigbee sample to use signal-atomic
Joseph Morrow [Sat, 19 Sep 2015 03:27:03 +0000 (20:27 -0700)]
Changed zigbee sample to use signal-atomic

The signal atomic type is more reliable than bool, since it is
guaranteed to enforce thread safety. Also fixed the logic in the 'while'
loop so that this will function properly when the calls work.

Change-Id: I1ef4713f9e894592b1b25c874327bce810c83352
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2769
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoAdding an IoTivity/Zigbee sample server
Joseph Morrow [Sat, 19 Sep 2015 03:24:55 +0000 (20:24 -0700)]
Adding an IoTivity/Zigbee sample server

Added functionality for the IoTivity/Zigbee server.  Added file
for addition of the client.  Changed the PluginStart to have the correct
parameters.  Corrected SConscript to properly include the IoTivity
logger and CSDK.

Change-Id: I20aca3403c6a0a1e198fdb337a6affe13c389417
Signed-off-by: Erich Keane <erich.keane@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2122
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2767
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoDo not build the Plugin Interface for unsupported platforms (ie. !linux).
Joseph Morrow [Sat, 19 Sep 2015 19:40:05 +0000 (12:40 -0700)]
Do not build the Plugin Interface for unsupported platforms (ie. !linux).

This will ensure the Plugin Interface is only run on the Linux platform
as this is the only validated platform for the Plugin Interface thus far.

Change-Id: I14507336d54a47cc32102c76cd1d4f1891cb3687
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2785
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoFix broken observe requests and GETs being treated as OBSERVEs
Mandeep Shetty [Thu, 17 Sep 2015 23:47:21 +0000 (16:47 -0700)]
Fix broken observe requests and GETs being treated as OBSERVEs

args to some functions were validated for NULL to return error codes even though
NULLs were legal for the args.
For eg. it is legal for options to be NULL.

These incorrect validations caused early returns and observation actions
were not set to OC_OBSERVE_NO_OPTION which is 2. The field in the struct
instead defaulted to OC_OBSERVE_REGISTER = 0 due to default inits.

Fixed both by removing or replacing the incorrect validations with more
appropriate ones.

Change-Id: Ia7453227a668bb26971b2b7d84381f64151b88f9
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2659
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
9 years agoMerge branch 'security-summit' into 'master'
Sachin Agrawal [Sun, 20 Sep 2015 02:14:42 +0000 (19:14 -0700)]
Merge branch 'security-summit' into 'master'

* security-summit:
  Added AMS functionality to support on-demand ACL provisioning.
  Added Android support for Provisioning APIs
  Quick fix on getting secure port information

Conflicts:
android/android_api/base/jni/JniOcStack.cpp
android/examples/settings.gradle
resource/csdk/security/include/internal/secureresourcemanager.h
resource/csdk/security/src/secureresourcemanager.c

Change-Id: I57d1157e4c1e74425fe27757e7dfa8a4ef8d427a
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
9 years agoAdded AMS functionality to support on-demand ACL provisioning.
Sachin Agrawal [Sun, 20 Sep 2015 00:31:39 +0000 (17:31 -0700)]
Added AMS functionality to support on-demand ACL provisioning.

This change includes the new "AMS Manager" (amsmgr.c) module, as well
as modifications to the SRM proper, policy engine, and doxmresource,
which are required to enable Access Management Service functionality in
the SRM.

Change-Id: Ibf10e00bebeeafd238ac083c7d45c1bbf7a46dd3
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2486
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
9 years agoInitial commit of "Plugin Interface" & supporting directory structure.
Joseph Morrow [Sat, 19 Sep 2015 03:24:11 +0000 (20:24 -0700)]
Initial commit of "Plugin Interface" & supporting directory structure.

This commit will allow follow-up contributions between contributors to
this new feature to IoTivity.

Change-Id: I41b812c048e44dded31a7fefa75f1e3830fc8daf
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2091
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2765
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Tested-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoChanged if/rt to be space-delimited strings in CBOR encoding
Erich Keane [Thu, 17 Sep 2015 22:48:18 +0000 (15:48 -0700)]
Changed if/rt to be space-delimited strings in CBOR encoding

The Spec says that if/rt should be space-delimited values rather than
just an array of strings, so this changes all encodings of if and rt to
be space-delimited.

Also adds some unit tests to validate the defensive nature of this
reading.

Change-Id: Iebd1d5a215a06abb023bb1b33112dac1df3511a1
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2645
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoAndroid: Added Device/Platform discovery client/server examples.
Tim Kourt [Fri, 11 Sep 2015 22:47:12 +0000 (15:47 -0700)]
Android: Added Device/Platform discovery client/server examples.

In addition it also modifies the respective functions in the base
Note: this commit depends on gerrit.iotivity.org/gerrit/#/c/2433/

Set 3: Changed the tests to be in accordance with the modified API

Change-Id: I1a91166a54ef7f277d95c4d62961888c782383c5
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2489
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoMerge "Merge branch 'security-CKM' into 'master'"
Sachin Agrawal [Sat, 19 Sep 2015 16:28:51 +0000 (16:28 +0000)]
Merge "Merge branch 'security-CKM' into 'master'"

9 years agoMerge branch 'security-CKM' into 'master'
Dmitrii Zhuravlev [Sat, 19 Sep 2015 14:01:27 +0000 (17:01 +0300)]
Merge branch 'security-CKM' into 'master'

* security-CKM:
  Add PKIX build
  implement certificate key manager
  CA retrieve PKIX resource from SRM using callbacks
  Add PKIX provisioning
  Add PKIX resources
  Add PKIX API for CA
  add support of X.509 into tinyDTLS external library
  Add certificate verification
  Add ASN.1 for PKIX

Conflicts:
resource/csdk/security/provisioning/SConscript
resource/csdk/security/provisioning/include/ocprovisioningmanager.h
resource/csdk/security/provisioning/src/ocprovisioningmanager.c
resource/csdk/security/provisioning/src/secureresourceprovider.c
resource/csdk/security/src/doxmresource.c
resource/csdk/security/src/resourcemanager.c
resource/csdk/security/src/secureresourcemanager.c

Change-Id: I7ec588eeec8e04e0bf9de84ebf520023a3f97dfe
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Signed-off-by: Dmytro Zhuravlev <d.zhuravlev@samsung.com>
9 years agoclean up RoutingManager codes in here and there.
jihwan.seo [Fri, 18 Sep 2015 11:09:55 +0000 (20:09 +0900)]
clean up RoutingManager codes in here and there.

Change-Id: Ib4ac2c34033f594c8d2821898d4831e18869a3d3
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2693
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoAdd validation to resource type/interface addition
Erich Keane [Wed, 16 Sep 2015 21:33:19 +0000 (14:33 -0700)]
Add validation to resource type/interface addition

The functions that add resource type/interfaces to the resources were
not correctly validating them to the RFC.  This commit adds validation
to these such that RFC6690 is enforced, and gives the developer
immediate/early warning of invalid values.

Change-Id: If04f72c1aa69ec2f9fbc83d849a503c2ee86f502
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2605
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoAndroid: Adding PresenceClient\PresenceServer examples
Tim Kourt [Wed, 9 Sep 2015 20:47:46 +0000 (13:47 -0700)]
Android: Adding PresenceClient\PresenceServer examples

PS2: adding modified settings.gradle

Change-Id: Iedba236264ab2b58bb55e11e8f4ea7f8b3871603
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2433
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoMerge branch 'simulator'
Harish Kumara Marappa [Sat, 19 Sep 2015 11:06:55 +0000 (16:36 +0530)]
Merge branch 'simulator'

OC::ObservationInfo is modified only as per the requirement of simulator module.
Please refer this change set for more information https://gerrit.iotivity.org/gerrit/#/c/2323/.

Change-Id: Ib4d762348f250697642d417798780e37cf62bdb0
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
9 years agoMerge "Merge branch 'master' into resource-encapsulation" into resource-encapsulation
Younghyun Joo [Sat, 19 Sep 2015 09:09:56 +0000 (18:09 +0900)]
Merge "Merge branch 'master' into resource-encapsulation" into resource-encapsulation

Change-Id: I56e84e31987766e5fc97cf3dafa7882f55ae1ef4
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
9 years agoOSLV fixes for RE layer.
Jay Sharma [Fri, 18 Sep 2015 20:02:48 +0000 (01:32 +0530)]
OSLV fixes for RE layer.

- Updated Android sample apps.

Change-Id: I6df99717227d1515e40a08560550b3cb2c82d54c
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2723
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoFix for prevent tool reported defects.
Harish Kumara Marappa [Fri, 18 Sep 2015 18:43:35 +0000 (00:13 +0530)]
Fix for prevent tool reported defects.

Change details:
1. Prevent issues fix.
2. Removal of white spaces from Java files.
3. Simulator tool UI changes.
4. Fix for issues observed during regression testing.

Change-Id: I4141541587421bc3de7ee321e8124a0444f37dd5
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2593
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoMerge branch 'master' into resource-encapsulation
Younghyun Joo [Sat, 19 Sep 2015 08:23:47 +0000 (17:23 +0900)]
Merge branch 'master' into resource-encapsulation

Change-Id: Ib07cb15d2b953ac870166383fe51fc7a26aaf73b
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
9 years agoModify Notification Manager for updating resource encapsulation
Younghyun Joo [Sat, 19 Sep 2015 06:26:32 +0000 (15:26 +0900)]
Modify Notification Manager for updating resource encapsulation

- Modify Notification Manager files
- Add UnitTest codes

Change-Id: I7b3ac0931a77935fc26a9c060a96200f13de27ca
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2775
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoEliminate result code from RCSGetResponse and RCSSetResponse.
coderhyme [Fri, 18 Sep 2015 11:02:46 +0000 (04:02 -0700)]
Eliminate result code from RCSGetResponse and RCSSetResponse.

It turned out there is no reason for users to set the result code.
The only scenario that RCSResponses have not OK for the result is that there is an error occurred
and in that case it should be an exception on resource-encapsulation layer.

Change-Id: Icef409ea5e224f9f02e12e174231baa4e11c5a33
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2705
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoModify resourceContainer code files for active discovery manager
Younghyun Joo [Sat, 19 Sep 2015 05:21:27 +0000 (14:21 +0900)]
Modify resourceContainer code files for active discovery manager

- add variable for RCSDiscoveryTask.

Change-Id: Ic26daafcb70c8c59242debcddcbd1307e84aae01
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2773
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoCode formatting for RCSDiscovery implementation.
doil.kwon [Fri, 18 Sep 2015 08:10:01 +0000 (17:10 +0900)]
Code formatting for RCSDiscovery implementation.

Change-Id: I2734731b8c467204e9382a08b185f6f9b9a7797e
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2683
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoRefactoring the android api for resorce-encapsulation.
coderhyme [Fri, 18 Sep 2015 09:50:35 +0000 (02:50 -0700)]
Refactoring the android api for resorce-encapsulation.

SConscript is added to conform to scons build.
JNI files are renamed to conform to the style.
JNI files are restructureed to make folder hierarchy simple.
android apis are refined to follow java convention.
Comments for apis are updated.

Change-Id: I1bef70c9468d767b1694f29165704a70370bbe90
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2703
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoAdd PKIX build
Sachin Agrawal [Fri, 18 Sep 2015 23:47:56 +0000 (16:47 -0700)]
Add PKIX build

To build with X.509 support:
scons SECURED=1 DTLS_WITH_X509=1

Change-Id: I63f0b9e4b1efa6f5871ee23d30ed5975424366ef
Signed-off-by: Dmytro Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2491

9 years agoimplement certificate key manager
Oleksii Udod [Mon, 14 Sep 2015 14:11:13 +0000 (17:11 +0300)]
implement certificate key manager

Change-Id: Ie77bc7f7cffe9536a0ca7a24625af17d01bf63ed
Signed-off-by: Oleksii Udod <o.udod@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2447
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
9 years agoMerge "Merge branch 'master' into simulator" into simulator
Madan Lanka [Fri, 18 Sep 2015 22:21:36 +0000 (22:21 +0000)]
Merge "Merge branch 'master' into simulator" into simulator

9 years ago[ANDROID] Remove GroupSynchronization in things manager.
arya.k [Fri, 18 Sep 2015 13:50:09 +0000 (19:20 +0530)]
[ANDROID] Remove GroupSynchronization in things manager.

Change-Id: I3d3324636ee7642cdba7657cba3c92105831159b
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2713
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoModify initialization for non-static class member.
doil.kwon [Fri, 18 Sep 2015 11:47:09 +0000 (20:47 +0900)]
Modify initialization for non-static class member.

- Non-static class member m_timerHandle is initialized in this constructor.

Change-Id: I6fa35c75f529b13f9c312e298b6536bca5dbd64b
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2699
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoRemove SSM and PPM service foler
hunje.yeon [Fri, 18 Sep 2015 11:13:28 +0000 (20:13 +0900)]
Remove SSM and PPM service foler

The SSM and PPM service in IoTivity is supported by Resource Container
as Protocol Bridge and Soft Sensor Template. Therefore, the exsisting
SSM and PPM folder is not required anymore.
This commit deletes both service folders and update service/SConscript.

Change-Id: I0864db18a6141b345fc883ae4740c152dbe868ab
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2695
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years ago[TIZEN] Resource Encapsulation Tizen build fixes.
arya.k [Fri, 18 Sep 2015 10:13:08 +0000 (15:43 +0530)]
[TIZEN] Resource Encapsulation Tizen build fixes.

Change-Id: I0ada98200f182992326c2fd448730f47b30da2be
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2689
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoCA retrieve PKIX resource from SRM using callbacks
Dmitrii Zhuravlev [Wed, 16 Sep 2015 17:38:50 +0000 (20:38 +0300)]
CA retrieve PKIX resource from SRM using callbacks

Change-Id: I179c485a4b71003115d579b4d9c80ed0bc59f4f6
Signed-off-by: Dmitrii Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2601
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: Sachin Agrawal <sachin.agrawal@intel.com>
9 years agoresource: Add test for ConstructResourceObject without coap scheme
Ravi Nanjundappa [Mon, 14 Sep 2015 13:42:31 +0000 (19:12 +0530)]
resource: Add test for ConstructResourceObject without coap scheme

Added a test case for ConstructResourceTest to simulate the scenario
of Resource creation with no "coap" scheme in the the host value

Change-Id: Iaec6f6f0038a049b969d08685cc057e6bae80455
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2517
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
9 years agoAdd iotivity.pc.in file and generate iotivity.pc file
Ravi Nanjundappa [Fri, 4 Sep 2015 10:55:09 +0000 (16:25 +0530)]
Add iotivity.pc.in file and generate iotivity.pc file

This patch addresses the second part of IOT-524. The current
changes include adding a new iotivity.pc.in file and generating
the iotivity.pc file using .pc.in file.

Making the relevant changes in gbsbuild.sh files to include iotivity.pc.in
file during tizen builds.

Change-Id: Ie3ed7ccdf6e29d427362d0bb2b85439508997b6b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2378
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
9 years agoAdd PKIX provisioning
Dmytro Zhuravlev [Thu, 10 Sep 2015 17:29:30 +0000 (20:29 +0300)]
Add PKIX provisioning

Implementation for certificate, crl resources generation and provisioning

Change-Id: Ib8bd72186da5a0d8314b00f28dbe05cb60d9b344
Signed-off-by: Dmytro Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2453
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
9 years agoFixed android local reference overflow
Jaehong Jo [Fri, 18 Sep 2015 07:01:58 +0000 (16:01 +0900)]
Fixed android local reference overflow

Delete JNI local reference

Change-Id: I1b0b54ec775be075a3fe9e127d57fe0bc882c9a8
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2675
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agooptimization to use the existing buffer in blockwise-transfer.
hyuna0213.jo [Mon, 14 Sep 2015 09:32:49 +0000 (18:32 +0900)]
optimization to use the existing buffer in blockwise-transfer.

if we have to update payload data, we always allocate new memory.
so we modified the code to use the existing memory if one exists.
This patch addresses the first part of IOT-690.

Change-Id: I04ca551273caf02f783c62a76f11f7e07409d8dd
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2503
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoRemove unnecessary include.
Thiago Macieira [Thu, 17 Sep 2015 23:44:13 +0000 (16:44 -0700)]
Remove unnecessary include.

syscall(3) is not used, so <sys/syscall.h> is not required. It's a
Linux-specific header anyway, so it should never have been on this file.

Change-Id: I42e7ef1a481840699a8dffff1404e8e982839caf
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2651
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agofixed the prevent issues for CA android platform.
jihwanseo [Wed, 16 Sep 2015 11:55:46 +0000 (20:55 +0900)]
fixed the prevent issues for CA android platform.

-remove the logically dead code
-memory leak
-dereferencing null pointer

Change-Id: Ided9d1fc0a909f10309df47e23b04d7f1ca8db22
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2591
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoUpload command update for Arduino DUE
sandipan.p [Mon, 14 Sep 2015 12:51:55 +0000 (18:21 +0530)]
Upload command update for Arduino DUE

With the previous implementation, CA and RI binaries were trying to get uploaded
on DUE board during SConscript parsing.

Change-Id: I12955a09e5695192b6cb756f2252b12bc62c0726
Signed-off-by: sandipan.p <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2515
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoMerge branch 'master' into simulator
Harish Kumara Marappa [Fri, 18 Sep 2015 14:37:25 +0000 (20:07 +0530)]
Merge branch 'master' into simulator

Change-Id: I76a7d8c501e2122a3c4eddd73ede9f7195fe1055
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
9 years agoAdding Raml and JsonSchema Parser changes for
Abitha Shankar [Fri, 18 Sep 2015 07:14:43 +0000 (12:44 +0530)]
Adding Raml and JsonSchema Parser changes for

1. Doxygen comments.
2. Klocwork fixes.
3 prevent issue fixes.
4. added smart pointer implemetation for JsonSchema Parser.

Change-Id: I8a6ff026fb9b03932ab7c15a19631143e0c653fa
Signed-off-by: Abitha Shankar <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2563
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoModify RCSBundleInfo API, make constructor and destructor of the container protected.
Minji Park [Fri, 18 Sep 2015 05:44:50 +0000 (14:44 +0900)]
Modify RCSBundleInfo API, make constructor and destructor of the container protected.

- remove RCSBundleInfo APIs to build bundleinfo and set bundle information, since bundleinfo only can be created and set only by the container internally
- make constructor and destructor of the container protected to make container exists as singleton

Change-Id: I677ec510f046a3f5b7d2be584c0d42a915d17082
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2671
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoMerge "Merge branch 'master' into resource-encapsulation" into resource-encapsulation
Madan Lanka [Fri, 18 Sep 2015 09:44:02 +0000 (09:44 +0000)]
Merge "Merge branch 'master' into resource-encapsulation" into resource-encapsulation

9 years agoAdding scope to RCSDiscoveryTask
ChaJiwon [Fri, 18 Sep 2015 08:24:41 +0000 (17:24 +0900)]
Adding scope to RCSDiscoveryTask

- adding scope 'RCSDiscoveryManager' to RCSDiscoveryTask in resource-encapsulation sample client
- modify DiscoveryTask name

Change-Id: Id2140350a54e2f2089322a57a9307572fb8746cb
Signed-off-by: ChaJiwon <jw_wonny.cha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2687
Reviewed-by: kwon doil <doil.kwon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoModify empty parameter handling in RCSDiscoveryManager
doil.kwon [Fri, 18 Sep 2015 04:51:15 +0000 (13:51 +0900)]
Modify empty parameter handling in RCSDiscoveryManager
and tranfer "RCSDiscoveryTask"'s location into "RCSDiscoveryMananger".

- if input value(relativeUri) is empty, will be discovered after be changed into "OC_RSRVD_WELL_KNOWN_URI".
- delete white space.
- According to move "RCSDiscoveryTask" into "RCSDiscoveryManager", changed name from "RCSDiscoveryTask" to "DiscoverTask".

Change-Id: I544d001e5b3a2f0fda75452f86430aceee2b46e5
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2663
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoExecute bundle activation in separate thread
Markus Jung [Fri, 18 Sep 2015 05:51:23 +0000 (14:51 +0900)]
Execute bundle activation in separate thread

This change executes the bundle activation in a separate thread. The calling thread waits
a defined time for the bundle activation to be completed before continuing the program flow.

Change-Id: I07dbb2e7b87658f5a0b1de827b458c2d55c5d16c
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2669
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agomodify resouce-encapsulation sample server and client
ChaJiwon [Fri, 18 Sep 2015 05:46:30 +0000 (14:46 +0900)]
modify resouce-encapsulation sample server and client

sampleResourceClient
- add the function that discover resouce
- add the function that cancel discover resource

sampleResourceServer
- select presence mode
- select resource type

Change-Id: I9e5867569be687fc25a9d1eca7a2cdff585b2963
Signed-off-by: ChaJiwon <jw_wonny.cha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2631
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agomodify doxygen comment
Heewon Park [Fri, 18 Sep 2015 05:43:55 +0000 (14:43 +0900)]
modify doxygen comment

-RCSResourceObject.h

Change-Id: I958572760b25d100ed2e8f4aaf6252a1625cad0b
Signed-off-by: Heewon Park <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2667
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoUpdated Java SDK of RE layer
Jay Sharma [Thu, 17 Sep 2015 12:15:33 +0000 (17:45 +0530)]
Updated Java SDK of RE layer

- Updated the RCSResourceAttributes class to support Nested Attributes.
- Updated the JNI Layer.

Change-Id: Ief1fe17a2d497a1167d4b6cc3bc727b0dfe62096
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2639
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rami Jung <rami.jung@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoMerge branch 'master' into resource-encapsulation
hunje.yeon [Fri, 18 Sep 2015 06:22:18 +0000 (15:22 +0900)]
Merge branch 'master' into resource-encapsulation

Update the changes of master branch into resource-encapsulation branch.

Change-Id: Ie553d5813809f0f7d686e074b95ff330eb82bc88
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
9 years agoRemove GroupSynchronization class in things manager
Jihun Ha [Fri, 18 Sep 2015 04:31:13 +0000 (13:31 +0900)]
Remove GroupSynchronization class in things manager

We've decided to remove the GroupSynchronization class because the current
implementation of the class is not clear to be used and does not provide
any useful functionalities to developers.
We will re-design this features more concretely and re-summit it in the future.

For Android and Tizen platform, we will summit patchsets soon.

Change-Id: Icd8116c69f9078af275aa91216c0f28db4378d32
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2661
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoPrefix for bundle activation function
Markus Jung [Wed, 16 Sep 2015 10:54:51 +0000 (19:54 +0900)]
Prefix for bundle activation function

This patch introduces a prefix for the activator functions of C++ bundles.
Multiple bundles can now be linked into one application.

Change-Id: I7f345bf1a81eac9616adbf9b975a7f8565c8c172
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2581
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agotinydtls: remove certificate_list length field for raw public keys
Hauke Mehrtens [Tue, 15 Sep 2015 16:53:35 +0000 (18:53 +0200)]
tinydtls: remove certificate_list length field for raw public keys

This fixes https://jira.iotivity.org/browse/IOT-715
This patch introduces an API incompatible change, old IoTivity clients
using Raw Public key will not be able to communicate with clients
with this change.

backport of tinydtls upstream commit:
From 71d5f5c9247bbdb5ae1f43533f94c13be1153160 Mon Sep 17 00:00:00 2001
From: Olaf Bergmann <bergmann@tzi.org>
Date: Wed, 26 Aug 2015 21:35:26 +0200
Subject: [PATCH] dtls.c: remove certificate_list length field for raw public
 keys

RFC 7250 has changed the format of the Certificate structure from
RFC 5246 to the following:

opaque ASN.1Cert<1..2^24-1>;

struct {
    select(certificate_type) {

        // certificate type defined in RFC 7250
        case RawPublicKey:
           opaque ASN.1_subjectPublicKeyInfo<1..2^24-1>;

        // X.509 certificate defined in RFC 5246
        case X.509:
           ASN.1Cert certificate_list<0..2^24-1>;
    };
} Certificate;

Thus, there must be no additional length field indicating a
certificate list in case the message contains a raw public key.

Change-Id: I3887fe962548e8e9d0c5bbb9f450073b9f95d1cb
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2569
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
9 years agoAdded Android support for Provisioning APIs
Sandeep Sharma [Tue, 1 Sep 2015 11:34:51 +0000 (17:04 +0530)]
Added Android support for Provisioning APIs

- Unowned/Owned device discovery, ACL, Credential provisioning
- Ownership transfer

[Patch #2] fixed wrong code comment.
[Patch #3] Added JNI and Java Interface for Unlink, revocation and Dashboard.
           Added Android Provisioning sample app.
[Patch #4] Revert Sconscript Changes with causes failure for automatic rebase.
[Patch #5] Addressed Ashwini's review commnets.
[Patch #6] Few fixes and addressed Randeep's review comments.
[Patch #7] Renamed sample app and more memory fixes.
[Patch #8] Addressed Tim's review comments.
[Patch #13] Addresses review comments.

NOTE: This change set won't build. It depends upon change set #2320

Change-Id: I41a29c0467976ea2b8439d8f85926b0a0ae6d79f
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2334
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
9 years agoupdated CA sample app related to removed CA_SUCCESS
jihwan.seo [Thu, 17 Sep 2015 00:31:20 +0000 (09:31 +0900)]
updated CA sample app related to removed CA_SUCCESS

https://gerrit.iotivity.org/gerrit/#/c/2549/

Change-Id: I625b24978e7d4b418dbcb311f04ad683e1990bf2
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2609
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoModified the argument in CAAddBlockOption()
hyuna0213.jo [Thu, 17 Sep 2015 04:22:10 +0000 (13:22 +0900)]
Modified the argument in CAAddBlockOption()

In CAAddBlockOption1 and CAAddBlockOption2 the second argument
is a CAInfo_t. but This is a large array. so we have to use pointer.
This patch addresses the first part of IOT-690.

Change-Id: I78ce8799a6db1a4a378bca016dd27c3529109e2e
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2613
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoMerge remote-tracking branch 'origin/routing-manager'
Jaehong Jo [Thu, 17 Sep 2015 02:26:45 +0000 (11:26 +0900)]
Merge remote-tracking branch 'origin/routing-manager'

Implementation for Routing Manager.
1) Gateway resource Hosting and exchange of routing tables.
2) Linklist implemenation.
3) Routing table manager to add, remove, get next hop etc.
4) Routing message parser using cbor parser funtions.
5) Dynamic route updates on addition/removal of gateways.
6) Support for Endpoint

Please refer to below links for wiki and jira updates.
https://wiki.iotivity.org/routing_through_heterogeneous_transports
https://jira.iotivity.org/browse/IOT-565

Change-Id: I228b59ef922f55552386fb0b0e1b2bb2343b1adb
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Signed-off-by: vimala.v <vimala.v@samsung.com>
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2301
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoFixed a session problem related to BT off/on for Android BLE.
jihwan.seo [Wed, 16 Sep 2015 08:23:21 +0000 (17:23 +0900)]
Fixed a session problem related to BT off/on for Android BLE.

when BT turn off/on while device is connected,
BLE is not connected again.
so i have modified something like in below

- when BLE Disconnect event is called
  server have to start advertising again.
- the dataList of server/client have to destroy, when BT turn off.
- client have to start device scan again, when BT turn on.

Change-Id: I97b75d349a0e3205e221e1347d3f24ca23f4e139
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2579
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoFixed wrong update of ip information
jnashok [Mon, 14 Sep 2015 06:30:47 +0000 (15:30 +0900)]
Fixed wrong update of ip information

interface name is assigned instead of ip address
port is assigned with 0 instead of correct port number
This patch fixes both

Change-Id: Id88e02d37bfb7a83c59100b997a021782f67099a
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2501
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoMerge "Merge branch 'security-summit' into 'master'"
Sachin Agrawal [Thu, 17 Sep 2015 15:56:04 +0000 (15:56 +0000)]
Merge "Merge branch 'security-summit' into 'master'"

9 years agomodify bundle resource and request handler to update multiple attributes
Minji Park [Wed, 16 Sep 2015 11:32:10 +0000 (20:32 +0900)]
modify bundle resource and request handler to update multiple attributes

- modify set, get request handler in the container
- add setAttributes in bundle resource to update multiple attributes
- modify protocol bridge, softsensor resource template and samples

Change-Id: I361c0b2a8d01f3a783e2a22bb2469aee0445a9e0
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2585
Reviewed-by: Markus Jung <markus.jung@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoRemoved Eesysetup implementation for validation
Madan Lanka [Thu, 17 Sep 2015 00:50:16 +0000 (20:50 -0400)]
Removed Eesysetup implementation for validation

Removed Easysetup implementation due to pending internal code validation step.
The support will be added after validation is completed

Change-Id: I8cc1499a1d033ed0eeb5cfff1ceb0c729e2968d4
Signed-off-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2611
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
9 years agoAdd unitTest for RCSDiscoveryManager.
doil.kwon [Thu, 17 Sep 2015 06:11:05 +0000 (15:11 +0900)]
Add unitTest for RCSDiscoveryManager.

Change the class name "DiscoveryTask" to "RCSDiscoveryTask".

Add handling about move operator and copy operator and move constructor and copy constructor for "RCSDiscoveryTask" class.

Modify Sconscript to build RCSDiscoveryManager UnitTest.

Change-Id: If409727bab435f38dd1ef4846880bf1a0bab827a
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2623
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoModify permissions for files in Things Manager
Jihun Ha [Thu, 17 Sep 2015 05:20:14 +0000 (14:20 +0900)]
Modify permissions for files in Things Manager

All files with "Excutable bit" has been changed into "Non-executable bit"
(755 -> 664)
And, I've modified typo strings in con-client and con-server applications

Change-Id: I6498d22b96fadd078e0ae9a05e782dfccb84bb07
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2615
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoQuick fix on getting secure port information
Woochul Shim [Thu, 17 Sep 2015 06:03:20 +0000 (15:03 +0900)]
Quick fix on getting secure port information

Change-Id: Ife4f339fadb8319b15a1409aa87bbdf06a8dda92
Signed-off-by: Woochul Shim <woochul.shim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2621
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: Sachin Agrawal <sachin.agrawal@intel.com>
9 years agoMerge branch 'security-summit' into 'master'
Sachin Agrawal [Thu, 17 Sep 2015 05:36:46 +0000 (22:36 -0700)]
Merge branch 'security-summit' into 'master'

* security-summit:
  Add assignment of newly introduced member in OCProvisionDev_t - AddDevice() and PMCloneOCProvisionDev() are changed.   Since change 2333 introduced DeviceStatus memeber in OCProvisionDev_t,   Add and Clone functions should handle this new member properly.
  Add C++ API for OCUnlink / OCRemove CAPI to Provisioning Manager
  Add 'sct' (Supported Credential Types) in doxm resource. - Implements madatory property 'sct' in doxm resource.
  Updated ACL & DOXM entity handler to process GET query
  Fix 2 warnings in C Provisioning Module - Comparision between size_t and int type incurs warning.   Add typecast of int when int is zero or positive value.
  Refactored provisioning client sample on C-level API
  Added Device dashboard OC APIs
  Remove unnecessary data type in PM - OTMStates is not used/required in current version.
  Added C++ API for Provisioning Manager
  Add OCUnlink / OCRemove API to Provisioning Manager
  Check PDM Initialization before excuting exposed PDM APIs - There is a case that user might call PDM API without initialization.   This patch could prevent this case by checking initialized status of sqlite DB.
  Remove unnecessary OC API in Provisioning Manager - OCDeleteProvisionResults() is not required any more   because OCProvisionResult_t is freed after user callback is hitted.
  Removed global variables from OTM
  Add filter to Owned Device Discovery. - Previous version discovers devices with condition 'owned=true'.   This patch adds one more condition that 'owned=true' and 'owner=myself'   This filter is required to screen out devices that are out of control.
  Added PDM Module to Provisioning APIs
  Bug-fix & Internal API name change
  1. Change OCDeleteProvisionResults() parameters    - double pointer -> single pointer
  Updated provisioning API to cater different connectivity type.

Conflicts:
resource/csdk/security/provisioning/src/pmutility.c

Change-Id: Idcfcc236f1a0f7a6c8c40dbfe21914eb2a935393
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
9 years agoRCSDiscovermanager's discovery feature extension for active discovery
doil.kwon [Fri, 11 Sep 2015 06:14:51 +0000 (15:14 +0900)]
RCSDiscovermanager's discovery feature extension for active discovery

- Previous Versions of RCSDiscoveryManager can discover only things that is available during discovery.
  Now RCSDisvoveryManger's Function is extended for active discovery. It can discover things that is incoming after discovering, andcan discover resource what is not supported presence function.

- RCSDiscoveryManagerImpl codes(.h file and .cpp file) are included.so also added its path in Sconscript.

- RCSDiscoveryManagerImpl Constructor is not setting about default.

- when DiscoveryTask's deconstructor is called, called cancel() API.

- delete white spaces and tabs to spaces.

- modify polling interval time 5sec -> 1min

- modify limited line.

Change-Id: I324d5be818655e258cdd2118ace7cabffae97d36
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2459
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoUpdated URI parsing code in server and added code to keep observed resources list...
Harish Kumara Marappa [Wed, 16 Sep 2015 15:14:29 +0000 (20:44 +0530)]
Updated URI parsing code in server and added code to keep observed resources list in client

Change set include below given changes:
1. Updating Javadoc comments
2. Eclipse plugin UI fixes.
3. Updated sample RAML file without OIC related information.
4. Handling exceptions.

Change-Id: I13d51876fdf6df72e09b74277dd4a813aa7ed8c9
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2599
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years ago[TIZEN] Enriched RE Sample Application with nested resource attribute.
arya.k [Wed, 16 Sep 2015 11:37:01 +0000 (17:07 +0530)]
[TIZEN] Enriched RE Sample Application with nested resource attribute.

Change-Id: I2b32519b1f107421c834e4bd8ac22467cd3b1c7f
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2587
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoModify ResourceContainer UnitTest code for including Resource RCS Client module
Younghyun Joo [Wed, 16 Sep 2015 11:20:36 +0000 (20:20 +0900)]
Modify ResourceContainer UnitTest code for including Resource RCS Client module

    - add UnitTest case for DiscoverResourceUnit
    - add UnitTest case for RemoteResourceUnit

Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
Change-Id: I789db92d51ece367ff42babcf599b4d4c1093874
Reviewed-on: https://gerrit.iotivity.org/gerrit/2583
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoRE - Enriched Linux sample application with nested resource attributes.
arya.k [Wed, 16 Sep 2015 11:07:46 +0000 (16:37 +0530)]
RE - Enriched Linux sample application with nested resource attributes.

Change-Id: Ieea592f3d490f56de6ab058078dbc1a7f1910a12
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2575
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
9 years agoChanged from c++11 to c++0x in Tizen csdk samples.
vimala.v [Wed, 16 Sep 2015 11:48:21 +0000 (17:18 +0530)]
Changed from c++11 to c++0x in Tizen csdk samples.

Change-Id: Ic95783e7227f8bebb3b279fc9938013155feae0c
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2589
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoremoved unneccessary code to check sending data in BLE
jihwan.seo [Wed, 16 Sep 2015 13:28:36 +0000 (22:28 +0900)]
removed unneccessary code to check sending data in BLE

although data is sending,
error message is calling from unnecessary spot.
it have to modify

Change-Id: I4172da1ec18707a12bd02775bd78ee68511a4a52
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2595
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
9 years agoreplace meaningless comment with detail comment.
jihwan.seo [Tue, 15 Sep 2015 17:29:29 +0000 (02:29 +0900)]
replace meaningless comment with detail comment.

OC is not available name as layer or module

Change-Id: Iba4cd83a3b59d3b82e720bcdb65930e7544f1a7a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2573
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>