platform/upstream/dotnet/runtime.git
6 years agoFactors out few GC specific tests (dotnet/corefx#29647)
Marek Safar [Tue, 15 May 2018 19:05:03 +0000 (21:05 +0200)]
Factors out few GC specific tests (dotnet/corefx#29647)

* Factors out few GC specific tests

* Tweaks to address the review

Commit migrated from https://github.com/dotnet/corefx/commit/ae9c3608e6ecb0389c668e8e6fbc6ee8f6b7ddfa

6 years agoFix a test and add a argument check for DiagnosticsHandler (dotnet/corefx#29701)
Caesar Chen [Tue, 15 May 2018 17:47:07 +0000 (10:47 -0700)]
Fix a test and add a argument check for DiagnosticsHandler (dotnet/corefx#29701)

* fix test and add a check for DiagnosticsHandler

* address feedback

* improve comment

Commit migrated from https://github.com/dotnet/corefx/commit/cda3d63089ec3e1e4d51d635da444b7319b98440

6 years agoAdd unit test to check edge case in Array.Reverse(Array, ...) (dotnet/corefx#29559)
Levi Broderick [Tue, 15 May 2018 13:15:24 +0000 (06:15 -0700)]
Add unit test to check edge case in Array.Reverse(Array, ...) (dotnet/corefx#29559)

* Fix Array.Reverse tests to match validation checks in corelib

* Revert "Fix Array.Reverse tests to match validation checks in corelib"

Commit migrated from https://github.com/dotnet/corefx/commit/c75431cd74a92f97d7be15e754b15f76d9bce28c

6 years agoAdd missing Read/Write{Async} overrides on Streams in ref assemblies (dotnet/corefx...
Stephen Toub [Mon, 14 May 2018 21:54:29 +0000 (17:54 -0400)]
Add missing Read/Write{Async} overrides on Streams in ref assemblies (dotnet/corefx#29658)

For non-sealed types, not specifying an override in a ref can lead to a derived type skipping the method in the hierarchy when calling to base.Method().

Commit migrated from https://github.com/dotnet/corefx/commit/33b44346378ba0caebb1ab96ab015e4098868c16

6 years agoUpdate CoreClr, CoreSetup to preview1-26514-05, preview1-26514-01, respectively ...
dotnet-maestro-bot [Mon, 14 May 2018 21:20:16 +0000 (16:20 -0500)]
Update CoreClr, CoreSetup to preview1-26514-05, preview1-26514-01, respectively (dotnet/corefx#29692)

Commit migrated from https://github.com/dotnet/corefx/commit/dd996990012c21ff6f0aaf30e4ba0eb6e7375dcd

6 years agoAdded Filters Property to FileSystemWatcher class (dotnet/corefx#29315)
Anirudh Agnihotry [Mon, 14 May 2018 19:33:38 +0000 (01:03 +0530)]
Added Filters Property to FileSystemWatcher class (dotnet/corefx#29315)

* Filters Property and tests added

* Tests fixed for osx

* Tests fixed for netfx and error message improved

* Tests fixed for netfx and error message improved

* Added tests for insert,contains ,removeat, index of , to string and gettype

* ToString removed and asser.equal corrected

* Comments and overload of epectevent added for netcoreapp

* Removed duplicate code

* setup and execution separated

* Expected patshs argument added

* ExpectNoEvent Added, negative added for all the test , expected path problem corrected

* handler

* Storing tuple and Unexpected Events

* name added to return values tuples

Commit migrated from https://github.com/dotnet/corefx/commit/9f2377fcd4e46f2c607d03672ed0bb92fe9cb68e

6 years agoRelease the HDC when disposing graphics (dotnet/corefx#29630)
Hugh Bellamy [Mon, 14 May 2018 18:57:16 +0000 (19:57 +0100)]
Release the HDC when disposing graphics (dotnet/corefx#29630)

Commit migrated from https://github.com/dotnet/corefx/commit/145ef1ab8e5bf54b6e29e7753b2edff8635ec519

6 years agoConsolidate Image code between Unix/Windows (dotnet/corefx#29632)
Hugh Bellamy [Mon, 14 May 2018 18:55:55 +0000 (19:55 +0100)]
Consolidate Image code between Unix/Windows (dotnet/corefx#29632)

* Consolidate Image code

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/3bbe534e51f22aa5475511cfbc26aba93467cfa2

6 years agoMove StringTests.cs to Common.Tests (dotnet/corefx#29601)
Marco Rossignoli [Mon, 14 May 2018 17:58:24 +0000 (19:58 +0200)]
Move StringTests.cs to Common.Tests (dotnet/corefx#29601)

* move StringTests to common, add ref for S.M.T. S.R.T.

* address PR feedback

* nit: space cleanup

* remove duplicates from S.M.T.

Commit migrated from https://github.com/dotnet/corefx/commit/1e9b1f278e8638a19e34bae6e40b67784483084c

6 years agoMerge pull request dotnet/corefx#29684 from WonyoungChoi/add_rids_for_tizen
Eric StJohn [Mon, 14 May 2018 17:54:54 +0000 (10:54 -0700)]
Merge pull request dotnet/corefx#29684 from WonyoungChoi/add_rids_for_tizen

Add missing RIDs for Tizen

Commit migrated from https://github.com/dotnet/corefx/commit/12a019e0156c4cb715ecf09e295563d62fb41ea1

6 years agoFix Pen test failures with latest libgdiplus (dotnet/corefx#29631)
Hugh Bellamy [Mon, 14 May 2018 17:06:30 +0000 (18:06 +0100)]
Fix Pen test failures with latest libgdiplus (dotnet/corefx#29631)

Commit migrated from https://github.com/dotnet/corefx/commit/b5b75ee8969f2c67689eafe7b1ba73d0bddda019

6 years agoSkipping test on uap-aot because metadata removed for perf reason (dotnet/corefx...
Maryam Ariyan [Mon, 14 May 2018 16:35:21 +0000 (09:35 -0700)]
Skipping test on uap-aot because metadata removed for perf reason (dotnet/corefx#29670)

Fixes: dotnet/corefx#29652

Commit migrated from https://github.com/dotnet/corefx/commit/9034a2a79051d99fb74896089131c107dc61bd62

6 years agoUpdate CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26514...
dotnet-maestro-bot [Mon, 14 May 2018 05:05:37 +0000 (00:05 -0500)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26514-01, preview1-26514-01, preview1-26513-04, beta-26514-00, beta-26514-00, respectively (dotnet/corefx#29681)

Commit migrated from https://github.com/dotnet/corefx/commit/ccdb5a48a49d3e932aa00d02749777464f4c8d5b

6 years agoAdd missing RIDs for Tizen
Wonyoung Choi [Fri, 11 May 2018 06:44:53 +0000 (15:44 +0900)]
Add missing RIDs for Tizen

Commit migrated from https://github.com/dotnet/corefx/commit/e6abbd366f75062bd828c5f1e26806be26b644d4

6 years agoStyle C# blocks in Activity user guide for readability (dotnet/corefx#29682)
Nick Craver [Sun, 13 May 2018 17:15:41 +0000 (13:15 -0400)]
Style C# blocks in Activity user guide for readability (dotnet/corefx#29682)

This styles some generic code blocks as C# to make this far more readable - trivial markdown change to make life a bit easier.

Commit migrated from https://github.com/dotnet/corefx/commit/cb749a1e158cce702bbb98bcb3e974e43459d179

6 years agoUpdate official runs to use RS4 target queues (dotnet/corefx#29666)
Santiago Fernandez Madero [Sun, 13 May 2018 13:38:43 +0000 (06:38 -0700)]
Update official runs to use RS4 target queues (dotnet/corefx#29666)

Commit migrated from https://github.com/dotnet/corefx/commit/cfd24117e523a5da6bebc5c9adba4b726fc0ef09

6 years agoUpdate CoreClr, CoreFx, CoreSetup to preview1-26513-01, preview1-26513-01, preview1...
dotnet-maestro-bot [Sun, 13 May 2018 04:11:12 +0000 (23:11 -0500)]
Update CoreClr, CoreFx, CoreSetup to preview1-26513-01, preview1-26513-01, preview1-26512-04, respectively (dotnet/corefx#29677)

Commit migrated from https://github.com/dotnet/corefx/commit/ca293c071b88cfc0f0c7d6b43775b0a3982ba3c3

6 years agoUpdate CoreClr, CoreFx, CoreSetup to preview1-26512-05, preview1-26512-05, preview1...
dotnet-maestro-bot [Sat, 12 May 2018 17:59:20 +0000 (12:59 -0500)]
Update CoreClr, CoreFx, CoreSetup to preview1-26512-05, preview1-26512-05, preview1-26512-01, respectively (dotnet/corefx#29672)

Commit migrated from https://github.com/dotnet/corefx/commit/344c31c7ba9bc171bbab31167acdd279e9f6027c

6 years agoUpdate CoreClr, CoreFx to preview1-26512-01, preview1-26512-01, respectively (dotnet...
dotnet-maestro-bot [Sat, 12 May 2018 07:34:58 +0000 (02:34 -0500)]
Update CoreClr, CoreFx to preview1-26512-01, preview1-26512-01, respectively (dotnet/corefx#29671)

Commit migrated from https://github.com/dotnet/corefx/commit/c3207180abe28433e4a801f38b6b883f2fbe2a68

6 years agoSwitch recently re-enabled tests to run only on new versions of .NET Framework (dotne...
Max Kerr [Fri, 11 May 2018 23:29:14 +0000 (16:29 -0700)]
Switch recently re-enabled tests to run only on new versions of .NET Framework (dotnet/corefx#29663)

* Switch recently re-enabled tests to run only on new versions of .NET Framework.

* Fix method naming, add support for PlatformDetection.IsNetfx472OrNewer, change check from > 4.7 to > 4.7.1

* Update comment.

Commit migrated from https://github.com/dotnet/corefx/commit/5310249c2d8939b38c008a2b10f7548e2162ac17

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to...
dotnet-maestro-bot [Fri, 11 May 2018 22:45:23 +0000 (17:45 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02810-02, preview1-26511-05, preview1-26511-04, preview1-26511-03, beta-26511-00, beta-26511-00, respectively (dotnet/corefx#29646)

Commit migrated from https://github.com/dotnet/corefx/commit/1b30478fa0857637ea0616933acaecd217fdc51a

6 years agoDisable parallelization of System.Transactions tests (dotnet/corefx#29665)
Stephen Toub [Fri, 11 May 2018 22:44:55 +0000 (18:44 -0400)]
Disable parallelization of System.Transactions tests (dotnet/corefx#29665)

Commit migrated from https://github.com/dotnet/corefx/commit/4e065e31c8bc9e1ae52b1f6ac18ea0c2e5764299

6 years agoFix TaskContinuationOptions => TaskCreationOptions in test (dotnet/corefx#29667)
Stephen Toub [Fri, 11 May 2018 22:44:31 +0000 (18:44 -0400)]
Fix TaskContinuationOptions => TaskCreationOptions in test (dotnet/corefx#29667)

Commit migrated from https://github.com/dotnet/corefx/commit/1b5782d29d18f96c20d26e5c8f2844f5d082c887

6 years agoUse shared StringBuilderCache (dotnet/corefx#29657)
Stephen Toub [Fri, 11 May 2018 21:39:06 +0000 (17:39 -0400)]
Use shared StringBuilderCache (dotnet/corefx#29657)

Commit migrated from https://github.com/dotnet/corefx/commit/03df812785e99885efde06a0f88d82578955276e

6 years agoFix terminfo number reading with 32-bit integers (dotnet/corefx#29655)
Stephen Toub [Fri, 11 May 2018 17:32:59 +0000 (13:32 -0400)]
Fix terminfo number reading with 32-bit integers (dotnet/corefx#29655)

Commit migrated from https://github.com/dotnet/corefx/commit/62bbc0bfef4ff22bc5215349b9db5f5a53f3a580

6 years agoFix compat pack dependencies now that we bumped them to 4.6.0-* for netcoreapp2.2...
Santiago Fernandez Madero [Fri, 11 May 2018 16:21:14 +0000 (09:21 -0700)]
Fix compat pack dependencies now that we bumped them to 4.6.0-* for netcoreapp2.2 (dotnet/corefx#29592)

* Fix compat pack dependencies now that we bumped them to 4.6.0-* for netcoreapp2.2

* Use PackageVersion in Packaging.props for PrereleaseLibrary

* Remove unnecessary target override that was already fixed in newest package

Commit migrated from https://github.com/dotnet/corefx/commit/7f2604e4346d98cbdd3034257e548e04ee6e2ab5

6 years agoMerge pull request dotnet/corefx#29636 from stephentoub/formatmessage
Stephen Toub [Fri, 11 May 2018 02:27:53 +0000 (22:27 -0400)]
Merge pull request dotnet/corefx#29636 from stephentoub/formatmessage

Improvements to FormatMessage

Commit migrated from https://github.com/dotnet/corefx/commit/48ce3254e28f2dae2d9a5efe7dd42cfab119d287

6 years agoObject model attributes (dotnet/corefx#29639)
Eric StJohn [Fri, 11 May 2018 02:13:05 +0000 (19:13 -0700)]
Object model attributes (dotnet/corefx#29639)

* Add ValueSerializerAttribute to System.ObjectModel

* Move TypeConverterAttribute down to System.ObjectModel

This enables types to plug into TypeConverter without taking a dependency on it.

One type in particular which requires this is ICommand in System.ObjectModel.

* Fix ValueSerializerAttribute formatting

Commit migrated from https://github.com/dotnet/corefx/commit/2db76263e64ab73c8d284060f597816158406810

6 years agoMerge pull request dotnet/corefx#29614 from AfsanehR/github29391
Afsaneh Rafighi [Fri, 11 May 2018 00:20:27 +0000 (17:20 -0700)]
Merge pull request dotnet/corefx#29614 from AfsanehR/github29391

Fixed GithubIssue dotnet/corefx#29391

Commit migrated from https://github.com/dotnet/corefx/commit/8e1d7bda3a56c7ec2f937e83a704dc6478477654

6 years agoAdding delay to fix assertion on tests. (dotnet/corefx#29638)
Maryam Ariyan [Thu, 10 May 2018 23:41:16 +0000 (16:41 -0700)]
Adding delay to fix assertion on tests. (dotnet/corefx#29638)

Fixes dotnet/corefx#29634

Commit migrated from https://github.com/dotnet/corefx/commit/76dffd6a6f4e713e51d75402472f38b6cb621c41

6 years agoAdd EventSource tracing to WinHttpHandler (dotnet/corefx#29604)
David Shulman [Thu, 10 May 2018 21:33:25 +0000 (14:33 -0700)]
Add EventSource tracing to WinHttpHandler (dotnet/corefx#29604)

Add EventSource tracing to WinHttpHandler

Removed the custom OutputDebugString-style tracing from WinHttpHandler and replaced it with
NetEventSource. Didn't define any new event id's but tried to use "Info" vs. "Error"
in more places.

Due to the unique way the WinHttpHandler class gets built into two different binaries,
I needed to add a new EventSource name/GUID for the standalone System.Net.Http.WinHttpHandler.dll
binary. The logging output is similar but will show up in either "Microsoft-System-Net-Http" or
"Microsoft-System-Net-Http-WinHttpHandler" EventSource's depending on which binary is being used,
i.e. whether "new HttpClientHandler()" or "new WinHttpHandler()" was used.

For those curious about how the new GUID for "Microsoft-System-Net-Http-WinHttpHandler" was done, it
was not generated randomly. EventSource GUID's are generated based on the string name for the
EventSource according to a well-defined formula. Doing a construct like this will return back the
information:

```c#
Type esType = typeof(WinHttpHandler).GetTypeInfo().Assembly.GetType("System.Net.NetEventSource", true, false);
Console.WriteLine($"Name={EventSource.GetName(esType)}, Guid={EventSource.GetGuid(esType).ToString()}");
```

Closes dotnet/corefx#7856

Commit migrated from https://github.com/dotnet/corefx/commit/11222269ae3bc45cd414dcb973f2d92f1bad73f8

6 years agoMinor improvements to SocketsHttpHandler redirect logging (dotnet/corefx#29584)
Max Kerr [Thu, 10 May 2018 21:29:08 +0000 (14:29 -0700)]
Minor improvements to SocketsHttpHandler redirect logging (dotnet/corefx#29584)

* Minor additions to redirect logging.

* Fix logging of original request method.

* Whitespace

* Update to use the HandlerMessage format.

Commit migrated from https://github.com/dotnet/corefx/commit/fe3df48064dfe35d19b8ff98dfb4eac4f606eaf2

6 years agoFix extra space in MSBuild variable that causes BuildingAnOfficialBuildLeg to be...
Chris Rummel [Thu, 10 May 2018 21:01:49 +0000 (16:01 -0500)]
Fix extra space in MSBuild variable that causes BuildingAnOfficialBuildLeg to be set incorrectly. (dotnet/corefx#29641)

Commit migrated from https://github.com/dotnet/corefx/commit/68fbecc4ce4e0410df92630b09d6238a436aadcf

6 years agoUpdate XML comments to use correct interface name (dotnet/corefx#29627)
David Gardiner [Thu, 10 May 2018 20:38:50 +0000 (06:38 +1000)]
Update XML comments to use correct interface name (dotnet/corefx#29627)

Interface is named "IConfigurationSectionHandler", not "IConfigSectionHandler"

(maybe there's some history there, or someone didn't want to type "uration" :-)

Commit migrated from https://github.com/dotnet/corefx/commit/986fc93181a682954fd768e4e2e8fd9a3eaa0a71

6 years agoMark Microsoft.Win32.Exception with ILLinkClearInitLocals
Stephen Toub [Thu, 10 May 2018 19:55:04 +0000 (15:55 -0400)]
Mark Microsoft.Win32.Exception with ILLinkClearInitLocals

Commit migrated from https://github.com/dotnet/corefx/commit/f872d7420254b4c191fbf25912763a5fbcffa0f0

6 years agoUse FORMAT_MESSAGE_ALLOCATE_BUFFER with FormatMessage
Stephen Toub [Thu, 10 May 2018 19:53:12 +0000 (15:53 -0400)]
Use FORMAT_MESSAGE_ALLOCATE_BUFFER with FormatMessage

Avoid looping and growing a managed heap buffer when we can instead just ask the native side to allocate one of the right size for us.

Commit migrated from https://github.com/dotnet/corefx/commit/e118304d264163f03e79965e4f2ab1d5c1a43961

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to...
dotnet-maestro-bot [Thu, 10 May 2018 20:08:19 +0000 (15:08 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02810-01, preview1-26510-06, preview1-26510-05, preview1-26510-01, beta-26510-00, beta-26510-00, respectively (dotnet/corefx#29628)

Commit migrated from https://github.com/dotnet/corefx/commit/81bb57084c5a40c71e37a8502a22b9ad64f83492

6 years agoChange IsSynchronized and SyncRoot of CryptographicAttributeObjectCollection class...
Maxim Lipnin [Thu, 10 May 2018 20:05:25 +0000 (23:05 +0300)]
Change IsSynchronized and SyncRoot of CryptographicAttributeObjectCollection class from explicitly implementing the interface to implicitly implementing the interface. (dotnet/corefx#29635)

* Change IsSynchronized and SyncRoot of CryptographicAttributeObjectCollection class from explicitly implementing the interface to implicitly implementing the interface.

* Remove redundant call of IsSyncronized because it's always going to return false.

* Remove unnecessary change

Commit migrated from https://github.com/dotnet/corefx/commit/56b8169b386914c83bd50e4d221ed8f3678f405a

6 years agoReplace shared Interop.FormatMessage.cs with non-shared one
Stephen Toub [Thu, 10 May 2018 14:07:36 +0000 (10:07 -0400)]
Replace shared Interop.FormatMessage.cs with non-shared one

Commit migrated from https://github.com/dotnet/corefx/commit/f3414d6cc3463b9e243e5d732d7e401c2d037d05

6 years agochanged Fact to CheckConnStrSetupFact
Afsaneh Rafighi [Thu, 10 May 2018 18:42:29 +0000 (11:42 -0700)]
changed Fact to CheckConnStrSetupFact

Commit migrated from https://github.com/dotnet/corefx/commit/63828972d76fef57c4d276c013aebe582a512597

6 years agoresolve the exception with CI.
Afsaneh Rafighi [Thu, 10 May 2018 18:15:16 +0000 (11:15 -0700)]
resolve the exception with CI.

Commit migrated from https://github.com/dotnet/corefx/commit/76922b95a7134124ac48282b7d14e5afede31e32

6 years agoReflection.Emit: Add test for `ParameterBuilder.SetConstant(null)` (dotnet/corefx...
stakx [Thu, 10 May 2018 14:50:38 +0000 (16:50 +0200)]
Reflection.Emit: Add test for `ParameterBuilder.SetConstant(null)` (dotnet/corefx#29532)

* Reflection.Emit: Test P'Builder.SetConstant(null)

Verifies that `ParameterBuilder.SetConstant(null)` works for any type,
including non-nullable value types.

* Exclude SetConstant(null) for value types on NETFX

Commit migrated from https://github.com/dotnet/corefx/commit/5c521c8dd9e46c2da34ead4046000c3c3c4e998f

6 years agoReflection: Add test verifying ParameterInfo.DefaultValue doesn't throw for optional...
stakx [Thu, 10 May 2018 14:50:01 +0000 (16:50 +0200)]
Reflection: Add test verifying ParameterInfo.DefaultValue doesn't throw for optional DateTime parameter (dotnet/corefx#29533)

* Reflection: Test DefaultValue for DateTime params

* Exclude DateTime test cases for NETFX

Commit migrated from https://github.com/dotnet/corefx/commit/156cbfaad66d1dc0a2bb9ef8846de6d6a6007f56

6 years agoRemove StringBuilder marshaling from X509Certificates (dotnet/corefx#29605)
Stephen Toub [Thu, 10 May 2018 10:54:51 +0000 (06:54 -0400)]
Remove StringBuilder marshaling from X509Certificates (dotnet/corefx#29605)

* Remove StringBuilder marshaling from X509Certificates

This avoids allocations for the StringBuilder itself, and if the data is small enough to be put on the stack, also the char[].  It also avoids marshaling overheads associated with doing a wstrlen on the resulting data, as we're told exactly how long the string is.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/7edeec59d41460b3bf41610850827b99d20ad0df

6 years agoAdd tests for Type.FilterName{IgnoreCase} and Module.FilterTypeName{IgnoreCase} ...
Stephen Toub [Thu, 10 May 2018 10:54:33 +0000 (06:54 -0400)]
Add tests for Type.FilterName{IgnoreCase} and Module.FilterTypeName{IgnoreCase} (dotnet/corefx#29624)

I made a change in coreclr that touched these members, and I noticed they didn't have any tests, so I'm adding some.

Commit migrated from https://github.com/dotnet/corefx/commit/679090706f73c9d893a3ea9c2122eadd8efcb19d

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to...
dotnet-maestro-bot [Thu, 10 May 2018 04:35:35 +0000 (23:35 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02808-01, preview1-26510-01, preview1-26510-01, preview1-26509-06, beta-26509-00, beta-26509-00, respectively (dotnet/corefx#29561)

Commit migrated from https://github.com/dotnet/corefx/commit/013a2ed3e6312dd2579a2d79f2e2324706fc4bc3

6 years agoRemove intermediate char[] allocation from ToHexStringUpper (dotnet/corefx#29612)
Stephen Toub [Thu, 10 May 2018 01:06:35 +0000 (21:06 -0400)]
Remove intermediate char[] allocation from ToHexStringUpper (dotnet/corefx#29612)

Use the new String.Create overload to write the hex representation directly into the target string rather than first writing into an allocated char[] and then creating a string from that.

Commit migrated from https://github.com/dotnet/corefx/commit/9deaec59658a91df87991aa90ea466a353ad33e0

6 years agoSslApplicationProtocol: don't use local functions to support older compilers. (dotnet...
Martin Baulig [Thu, 10 May 2018 01:06:18 +0000 (21:06 -0400)]
SslApplicationProtocol: don't use local functions to support older compilers. (dotnet/corefx#29617)

Commit migrated from https://github.com/dotnet/corefx/commit/6e4db3f55bfdec4c681361b77b619b4a7474a3b7

6 years agoRe-enable tests that depend on new netfx behaviors. (dotnet/corefx#29621)
Max Kerr [Thu, 10 May 2018 00:21:23 +0000 (17:21 -0700)]
Re-enable tests that depend on new netfx behaviors. (dotnet/corefx#29621)

Several tests in System.Private.Uri.FunctionalTests were disabled because they depended on fixes that were not yet present in .NET Framework. Now that we're running against a newer version that includes the fixes, I've re-enabled these tests.

Fixes: dotnet/corefx#15145

Commit migrated from https://github.com/dotnet/corefx/commit/140a84d88636ae3067eea5adf4df32e895e6eb73

6 years agoadded license header file and formatted code
Afsaneh Rafighi [Wed, 9 May 2018 21:46:31 +0000 (14:46 -0700)]
added license header file and formatted code

Commit migrated from https://github.com/dotnet/corefx/commit/205f2cf7147f8f4365b739bdf56fc2626c663afa

6 years agoMerge pull request dotnet/corefx#29616 from ianhays/master_sx
Ian Hays [Wed, 9 May 2018 20:54:55 +0000 (13:54 -0700)]
Merge pull request dotnet/corefx#29616 from ianhays/master_sx

Misc fixes to sxl

Commit migrated from https://github.com/dotnet/corefx/commit/6d571f70a69a3a1dcf54f73ab828c545de40690a

6 years agoSignedXMl misc improvements
Ian Hays [Thu, 29 Mar 2018 19:35:27 +0000 (12:35 -0700)]
SignedXMl misc improvements

Commit migrated from https://github.com/dotnet/corefx/commit/8322265bb13336b40e0cfd3b9fe0216eadf51df8

6 years agoAdd net472 version to PlatformDetection.GetFrameworkVersion (dotnet/corefx#29606)
Santiago Fernandez Madero [Wed, 9 May 2018 18:55:29 +0000 (11:55 -0700)]
Add net472 version to PlatformDetection.GetFrameworkVersion (dotnet/corefx#29606)

Commit migrated from https://github.com/dotnet/corefx/commit/8c47d918d13ecbad90f2f2e9c4ef994d8415be60

6 years agoFixed GithubIssue29391
Afsaneh Rafighi [Wed, 9 May 2018 17:59:52 +0000 (10:59 -0700)]
Fixed GithubIssue29391

Commit migrated from https://github.com/dotnet/corefx/commit/fc34319aea1f47a554b890286ec6ff942a901137

6 years agoUpdate intellisense files based on 5-7-2018 doc build (dotnet/corefx#29587)
Wes Haggard [Wed, 9 May 2018 16:18:27 +0000 (09:18 -0700)]
Update intellisense files based on 5-7-2018 doc build (dotnet/corefx#29587)

Commit migrated from https://github.com/dotnet/corefx/commit/a9249665664236494d59adb14d27bff7b900832d

6 years agoConcurrentDictionary: improve documentation (dotnet/corefx#29599)
Bruno Juchli [Wed, 9 May 2018 14:40:39 +0000 (16:40 +0200)]
ConcurrentDictionary: improve documentation (dotnet/corefx#29599)

* ConcurrentDictionary: improve documentation

Improve the summary of ConcurrentyDictionary.TryUpdate. The summary mentions parameters in a different order and with different names than they are represented in the method signature. This is confusing.
To clear things up, I've replaced the "verbal" parameter references by `<paramref name="XYZ"/>`.

* ConcurrentDictionary: improve documentation

Improving summary of ConcurrentDictionary.TryUpdate by mentioning parameters in the same order as they occur in the method signature.

Commit migrated from https://github.com/dotnet/corefx/commit/91eb6661d95b9826e66579251faebe6f40fe1134

6 years agoCreating ~/.local/share directory if not created yet (dotnet/corefx#29514)
Maryam Ariyan [Wed, 9 May 2018 05:34:36 +0000 (22:34 -0700)]
Creating ~/.local/share directory if not created yet (dotnet/corefx#29514)

* Creating ~/.local/share directory if not created yet

Fixes: dotnet/corefx#29354

Commit migrated from https://github.com/dotnet/corefx/commit/fd0d17874bdbfc5b6f662c62720428867aaea486

6 years agoEnable build S.R.WindowRuntime for .netcoreapp (dotnet/corefx#29579)
Luqun Lou [Wed, 9 May 2018 05:06:06 +0000 (22:06 -0700)]
Enable build S.R.WindowRuntime for .netcoreapp (dotnet/corefx#29579)

* Enable build S.R.WindowRuntime and mscorlib facade for .netcoreapp

Commit migrated from https://github.com/dotnet/corefx/commit/40a548403d4b3462303ad8650f5cfbf6b9257326

6 years agoRemove StringBuilder usage from Dns.GetHostName (dotnet/corefx#29594)
Stephen Toub [Wed, 9 May 2018 03:36:45 +0000 (23:36 -0400)]
Remove StringBuilder usage from Dns.GetHostName (dotnet/corefx#29594)

Commit migrated from https://github.com/dotnet/corefx/commit/92614331de9f6ebe65c492354bcfdc85a2a895e6

6 years agoMerge pull request dotnet/corefx#29552 from vancem/DiagSourceGuidance
Vance Morrison [Tue, 8 May 2018 22:01:54 +0000 (15:01 -0700)]
Merge pull request dotnet/corefx#29552 from vancem/DiagSourceGuidance

Added Additional DiagnosticSource Guidance

Commit migrated from https://github.com/dotnet/corefx/commit/e274d0ab8706a68604d5326e7e1141a3137659fc

6 years agofeedback
Vance Morrison [Tue, 8 May 2018 17:44:33 +0000 (10:44 -0700)]
feedback

Commit migrated from https://github.com/dotnet/corefx/commit/b3cfc7daade9305fd74a0544ebee7fc5a87b8ee9

6 years agoRemove unused SpinWait from Socket.Dispose (dotnet/corefx#29572)
Tom Deseyn [Tue, 8 May 2018 12:08:36 +0000 (14:08 +0200)]
Remove unused SpinWait from Socket.Dispose (dotnet/corefx#29572)

Commit migrated from https://github.com/dotnet/corefx/commit/7a1007f2ef04fd9ec576cdb198ff53af4f18c77b

6 years agoSkip Unix domain sockets tests in 32-bit process on 64-bit Windows (dotnet/corefx...
Stephen Toub [Tue, 8 May 2018 11:03:31 +0000 (07:03 -0400)]
Skip Unix domain sockets tests in 32-bit process on 64-bit Windows (dotnet/corefx#29556)

Workaround a current Windows limitation.

Commit migrated from https://github.com/dotnet/corefx/commit/b21589f01d699617fb2fba6589af4e43c02d4f31

6 years agoMerge pull request dotnet/corefx#29493 from weshaggard/FilterStablePkgprojs-m
Wes Haggard [Mon, 7 May 2018 22:53:43 +0000 (15:53 -0700)]
Merge pull request dotnet/corefx#29493 from weshaggard/FilterStablePkgprojs-m

Exclude private framework packages from stable update

Commit migrated from https://github.com/dotnet/corefx/commit/e060215a62ee0bf84c437192ed3d975ecfe14b1e

6 years agoAdd missing ConfigureAwait(false) to UAP HttpClientHandler (dotnet/corefx#29553)
David Shulman [Mon, 7 May 2018 22:30:55 +0000 (15:30 -0700)]
Add missing ConfigureAwait(false) to UAP HttpClientHandler (dotnet/corefx#29553)

Fixes dotnet/corefx#29517

Commit migrated from https://github.com/dotnet/corefx/commit/0f3814b1c002efd94f7a81f57f8c48f2022d14be

6 years agoAdd link to activites doc
Vance Morrison [Mon, 7 May 2018 21:45:47 +0000 (14:45 -0700)]
Add link to activites doc

Commit migrated from https://github.com/dotnet/corefx/commit/19d6df8798ea69c40d05fdb129f5ddc5feb0da14

6 years agoAddeded Additional Guidance
Vance Morrison [Mon, 7 May 2018 21:06:19 +0000 (14:06 -0700)]
Addeded Additional Guidance

Commit migrated from https://github.com/dotnet/corefx/commit/e653635edbf87b3cd7fcbb3ceec68de4666d9b4b

6 years agoImprove Http authentication logging (dotnet/corefx#29501)
Max Kerr [Mon, 7 May 2018 21:20:50 +0000 (14:20 -0700)]
Improve Http authentication logging (dotnet/corefx#29501)

This should help developers debug several common scenarios:

- Pre-authentication credentials rejected
- No match between client and server supported schemes
- Missing or invalid digest tokens

It also logs the value of the www-authenticate header received and the scheme selected, which should help detect a large number of errors.

Commit migrated from https://github.com/dotnet/corefx/commit/e160ef76df64a2114addf774a05af2f995f18bca

6 years agoRemoved duplicated type HttpVersionInternal (dotnet/corefx#29545)
David Shulman [Mon, 7 May 2018 21:00:19 +0000 (14:00 -0700)]
Removed duplicated type HttpVersionInternal (dotnet/corefx#29545)

Removed duplicated type HttpVersionInternal

We added HttpVersionInternal back when it differed from the System.Net.Primitives HttpVersion type. But now that the two types are the same, we can remove the duplicated internal type.

Fixes dotnet/corefx#26492

Commit migrated from https://github.com/dotnet/corefx/commit/40faa4ed5c699e84afbb78f6ff96feb7b99db320

6 years agoMerge pull request dotnet/corefx#29543 from weshaggard/FixUpStablePackageTarget_m
Wes Haggard [Mon, 7 May 2018 19:39:25 +0000 (12:39 -0700)]
Merge pull request dotnet/corefx#29543 from weshaggard/FixUpStablePackageTarget_m

Clear Configuration property when gathering stable versions

Commit migrated from https://github.com/dotnet/corefx/commit/e7b553f293dccbbaa4554adc42357813f1e46885

6 years agoMerge pull request dotnet/corefx#29539 from stephentoub/asspan
Stephen Toub [Mon, 7 May 2018 18:03:09 +0000 (14:03 -0400)]
Merge pull request dotnet/corefx#29539 from stephentoub/asspan

Replace several Substrings with AsSpans

Commit migrated from https://github.com/dotnet/corefx/commit/fe6422fdbf99b38968b2168c492b78be51890403

6 years agoRevert "Add config to force OpenSsl error queue cleanup before Encrypt/Decrypt (dotne...
Paulo Janotti [Mon, 7 May 2018 17:30:21 +0000 (10:30 -0700)]
Revert "Add config to force OpenSsl error queue cleanup before Encrypt/Decrypt (dotnet/corefx#29186)" (dotnet/corefx#29528)

This reverts commit dotnet/corefx@2750fdda40995d53893a5ae141538fe55939fdf9.

Commit migrated from https://github.com/dotnet/corefx/commit/3f5d26c720503f143333f7e51a006c5976f2ee66

6 years agoClear Configuration property when gathering stable versions
Wes Haggard [Fri, 4 May 2018 19:39:40 +0000 (12:39 -0700)]
Clear Configuration property when gathering stable versions

When building using the traversal logic we end up setting
Configuration as a global property in some cases and thus
it gets propagated to other MSBuild calls. That alters the
package id when trying to gather it for stable versioning.

To avoid this we should clear out the Configuration property
and let it be recomputed by the pkgproj's themselves instead
of overriding.

Commit migrated from https://github.com/dotnet/corefx/commit/c6b71622f29bae61a2a076ba6970cf1151a1c75e

6 years agoSSL error clean up: incorporate PR feedback from 2.1 into master (dotnet/corefx#29529)
Paulo Janotti [Mon, 7 May 2018 17:02:13 +0000 (10:02 -0700)]
SSL error clean up: incorporate PR feedback from 2.1 into master (dotnet/corefx#29529)

* PR feedback 00

* PR feedback 01

Commit migrated from https://github.com/dotnet/corefx/commit/b7d9b6efb6c542a9d0b56af2d711913fc07b7ede

6 years agoLog binary and temp with drive format, and current directory (dotnet/corefx#29519)
Dan Moseley [Mon, 7 May 2018 16:59:10 +0000 (09:59 -0700)]
Log binary and temp with drive format, and current directory (dotnet/corefx#29519)

Commit migrated from https://github.com/dotnet/corefx/commit/53a0ae5d8956c657ac6d1d18121cf067b7868f50

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to...
dotnet-maestro-bot [Mon, 7 May 2018 16:10:26 +0000 (11:10 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02804-04, preview1-26507-05, preview1-26507-04, preview1-26507-01, beta-26507-00, beta-26507-00, respectively (dotnet/corefx#29521)

Commit migrated from https://github.com/dotnet/corefx/commit/4e17d32c4367722d0191da9ec99dfe41c5b29819

6 years agoUse AsSpan instead of Substring in FrameworkName
Stephen Toub [Mon, 7 May 2018 13:11:42 +0000 (09:11 -0400)]
Use AsSpan instead of Substring in FrameworkName

Commit migrated from https://github.com/dotnet/corefx/commit/344a86370291696e578357328aa1cd3a3ce6cc25

6 years agoUse AsSpan instead of Substring in System.Diagnostics.Process
Stephen Toub [Mon, 7 May 2018 13:10:53 +0000 (09:10 -0400)]
Use AsSpan instead of Substring in System.Diagnostics.Process

Use AsSpan in a few places instead of creating substrings

Commit migrated from https://github.com/dotnet/corefx/commit/9989eb3d739aa1948c6d4fb3ae499a0a7b209c1d

6 years agoRemove roadmap (dotnet/corefx#29530)
Immo Landwerth [Fri, 4 May 2018 22:42:07 +0000 (15:42 -0700)]
Remove roadmap (dotnet/corefx#29530)

While CoreFX is quite large, having a roadmap here hasn't worked super
well because roadmaps tend to be more vague and thus high-level. It
seems more appropriate to have a centralized roadmap that covers .NET
Core all up, which we already have in the dotnet/core repo.

Commit migrated from https://github.com/dotnet/corefx/commit/3ecf563f751f1817a6e0f60c9e7ee8d044e28951

6 years ago Add missing awaits to XmlTextReaderImplAsync (dotnet/corefx#29518)
Stephen Toub [Fri, 4 May 2018 20:08:59 +0000 (16:08 -0400)]
 Add missing awaits to XmlTextReaderImplAsync (dotnet/corefx#29518)

* Comment on awaits that don't need ConfigureAwait(false)

- Add comments to several awaits on tasks where ConfigureAwait is unnecessary for a variety of reasons
- Rather than commenting, change one await to GetAwaiter().GetResult() where we know the task is already completed (rather than just commenting to that effect)

* Add missing awaits to XmlTextReaderImplAsync

Commit migrated from https://github.com/dotnet/corefx/commit/b758c3b1f1293ada2e46f9e221be0b392838cc41

6 years agoRemove LStat call in enumeration (dotnet/corefx#29515)
Jeremy Kuhne [Fri, 4 May 2018 19:58:43 +0000 (12:58 -0700)]
Remove LStat call in enumeration (dotnet/corefx#29515)

It shouldn't be necessary. We included it for 2.1 as we made the same call
in 2.0 while enumerating and didn't have time to let removing the call bake.

Commit migrated from https://github.com/dotnet/corefx/commit/db62f1d4cd961f74b249932b5f9bcc083e5bfa91

6 years agoUpdate CoreFx to preview1-26504-05 (dotnet/corefx#29513)
dotnet-maestro-bot [Fri, 4 May 2018 18:50:58 +0000 (13:50 -0500)]
Update CoreFx to preview1-26504-05 (dotnet/corefx#29513)

Commit migrated from https://github.com/dotnet/corefx/commit/c5525733b5f822b91ce00ef1e6502a2e1a6720e7

6 years agoUpdate CoreClr, CoreSetup to preview1-26504-05, preview1-26504-02, respectively ...
dotnet-maestro-bot [Fri, 4 May 2018 16:33:51 +0000 (11:33 -0500)]
Update CoreClr, CoreSetup to preview1-26504-05, preview1-26504-02, respectively (dotnet/corefx#29509)

Commit migrated from https://github.com/dotnet/corefx/commit/9d38df5b1f63aeceec8832411ff6b6d4ab2133ed

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to...
dotnet-maestro-bot [Fri, 4 May 2018 13:47:41 +0000 (08:47 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02804-02, preview1-26504-01, preview1-26504-01, preview1-26503-05, beta-26504-00, beta-26504-00, respectively (dotnet/corefx#29485)

Commit migrated from https://github.com/dotnet/corefx/commit/20a54ede07347ac450fa3e203f4ffe6d589ee3eb

6 years agoDelete package verification workarounds (dotnet/corefx#29508)
Jan Kotas [Fri, 4 May 2018 06:07:47 +0000 (23:07 -0700)]
Delete package verification workarounds (dotnet/corefx#29508)

Fixes dotnet/corefx#29322 dotnet/corefx#29382

Commit migrated from https://github.com/dotnet/corefx/commit/c627bcd85c17c8f707c047d2badf65fe2b1f35a8

6 years agoFix handling of Unix directories (dotnet/corefx#29502)
Jeremy Kuhne [Fri, 4 May 2018 04:34:15 +0000 (21:34 -0700)]
Fix handling of Unix directories (dotnet/corefx#29502)

Some file systems return DT_UNKNOWN for directories. Additionally we need
to handle if Stat fails and fall back to LStat.

This showed up on RHEL 7.2 with xfs.

Commit migrated from https://github.com/dotnet/corefx/commit/da81e551027e41beb287a1fef90c5a2d8a6b6f3a

6 years agoUnify setting null CookieContainer behavior on HttpClientHandler (dotnet/corefx#29337)
Caesar Chen [Thu, 3 May 2018 21:32:32 +0000 (14:32 -0700)]
Unify setting null CookieContainer behavior on HttpClientHandler (dotnet/corefx#29337)

* unify set null CookieContainer behavior

* address test issue, and address feedback

* disable a test

Commit migrated from https://github.com/dotnet/corefx/commit/e30a7494292f3e6e66c0d152ad3240fa1f6dc766

6 years agomiscellaneous fix (dotnet/corefx#29492)
Caesar Chen [Thu, 3 May 2018 21:31:45 +0000 (14:31 -0700)]
miscellaneous fix (dotnet/corefx#29492)

Commit migrated from https://github.com/dotnet/corefx/commit/38ad17100349ef286edeb67ddffe4c44ba4e51e1

6 years agoUpdate Windows.10.Amd64.ClientRS*.Open to use RS4 rather than RS2 (dotnet/corefx...
Stephen Toub [Thu, 3 May 2018 21:04:00 +0000 (17:04 -0400)]
Update Windows.10.Amd64.ClientRS*.Open to use RS4 rather than RS2 (dotnet/corefx#29456)

* Update Windows.10.Amd64.ClientRS*.Open to use RS4 rather than RS2

* Move Windows.10.Amd64.ClientRS3.ES.Open to Windows.10.Amd64.ClientRS4.ES.Open

* Revert ClientRS3 to ClientRS4 change

Commit migrated from https://github.com/dotnet/corefx/commit/fe27f8f0f49b851a207cda03daa11ce7605754dc

6 years agoTest decryption failure with a certificate with false SKID (dotnet/corefx#29464)
Krzysztof Wicher [Thu, 3 May 2018 20:45:35 +0000 (13:45 -0700)]
Test decryption failure with a certificate with false SKID (dotnet/corefx#29464)

* test decryption failure with a certificate with false SKID

* (hopefully) add friendly name to pfxs and rename fields/properties

* remove friendly name from pfx

Commit migrated from https://github.com/dotnet/corefx/commit/73be0c527bbafe624e4a9875d598503912ecce69

6 years agoQuote rereference argument in Microsoft.XmlSerializer.Generator.targets. (dotnet...
Huangli Wu [Thu, 3 May 2018 20:42:04 +0000 (13:42 -0700)]
Quote rereference argument in Microsoft.XmlSerializer.Generator.targets. (dotnet/corefx#29442)

* Quote rereference argument in Microsoft.XmlSerializer.Generator.targets.

* Add quote around %(_TargetSerializationAssembly.Identity).

* Add quote in IntermediateOutputPath. Remove double quote in the outputdirectory if it ends with double quote because if pass in a path "obj\Debug\netcoreapp2.0\", the passed in directory will be obj\Debug\netcoreapp2.0\", which is invalid and not exist.

* Throw exception for a non-existing directory theat does not end with quotes.

* Modify code to avoid duplicate code. Add comments for the change.

* fix typo.

Commit migrated from https://github.com/dotnet/corefx/commit/df38755750623adb51f77517b04eda77747062af

6 years agoExclude private framework packages from stable update
Wes Haggard [Thu, 3 May 2018 18:48:56 +0000 (11:48 -0700)]
Exclude private framework packages from stable update

We don't need to update the package index with the
private framework packages because they aren't interesting
from a stable prospective. They always remain non-stable
because they are only for transporting to core-setup.

Commit migrated from https://github.com/dotnet/corefx/commit/46f5470aa94d348fb7378bcb6ee20f9041e506c4

6 years agoFix GetMessageUsingEventMessageDLL event log test on RS4 (dotnet/corefx#29489)
Stephen Toub [Thu, 3 May 2018 19:21:51 +0000 (15:21 -0400)]
Fix GetMessageUsingEventMessageDLL event log test on RS4 (dotnet/corefx#29489)

The RS4 machine's security event log is apparently empty, causing the test to throw an index out of range exception.

Commit migrated from https://github.com/dotnet/corefx/commit/e2b1a82d542dbf6762e6c8865a452dc0065158c8

6 years agoFix BeginConnect_EndPoint_AddressFamily_Throws_NotSupported test for netfx (dotnet...
Stephen Toub [Thu, 3 May 2018 19:02:55 +0000 (15:02 -0400)]
Fix BeginConnect_EndPoint_AddressFamily_Throws_NotSupported test for netfx (dotnet/corefx#29484)

* Fix BeginConnect_EndPoint_AddressFamily_Throws_NotSupported test for netfx

The test fails on .NET 4.7.2 due to trying to use the same Socket instance for a connection attempt after invalid arguments were passed to a previous attempt.  Since that's not what this test is about, I'm just fixing it to avoid reusing the same Socket instance.

* Fix comment typo

Commit migrated from https://github.com/dotnet/corefx/commit/c69beb44032ff18d6134e1e42daf295169d064d3

6 years agoDelete Brotli_External_DecompressesResponse_Success test (dotnet/corefx#29486)
Stephen Toub [Thu, 3 May 2018 19:01:39 +0000 (15:01 -0400)]
Delete Brotli_External_DecompressesResponse_Success test (dotnet/corefx#29486)

We have Brotli_DecompressesResponse_Success which just uses a loopback server.  I'd added Brotli_External_DecompressesResponse_Success as a way to test against another Brotli implementation, but that's not really something we need to do in the System.Net.Http tests; rather, it's up to the System.IO.Compression.Brotli tests to ensure compliance.  Given that, and this tests ends up causing failures when httpbin.org goes down, I'm just deleting it.

Commit migrated from https://github.com/dotnet/corefx/commit/e85573f9b778ba65925f17da6fc485bb43d2c055

6 years agoUpdate CoreClr, CoreFx to preview1-26503-05, preview1-26503-04, respectively (dotnet...
dotnet-maestro-bot [Thu, 3 May 2018 16:31:30 +0000 (11:31 -0500)]
Update CoreClr, CoreFx to preview1-26503-05, preview1-26503-04, respectively (dotnet/corefx#29475)

Commit migrated from https://github.com/dotnet/corefx/commit/5086f389296886774c9009c89d241055e5157c42

6 years agoFix race condition in Sockets ExecutionContextFlowTest (dotnet/corefx#29471)
Stephen Toub [Thu, 3 May 2018 13:01:31 +0000 (09:01 -0400)]
Fix race condition in Sockets ExecutionContextFlowTest (dotnet/corefx#29471)

It's possible that the awaited operation continues on another thread,
restoring the ExecutionContext, at the same time that the initial thread
is unwinding out of the async invocation, and thus also restoring an
ExecutionContext, both of which will invoke the AsyncLocal's callback,
and thus we need to synchronize its work to avoid issues like multiple
threads all calling StringBuilder.AppendLine concurrently.

Commit migrated from https://github.com/dotnet/corefx/commit/8cb7675e8702d76dad15f1ac9858abe475b8324c

6 years agoUpdate CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26503-01, beta-26503...
dotnet-maestro-bot [Thu, 3 May 2018 12:31:13 +0000 (07:31 -0500)]
Update CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26503-01, beta-26503-00, beta-26503-00, respectively (dotnet/corefx#29473)

Commit migrated from https://github.com/dotnet/corefx/commit/c8635cc9a7bbacc71afcfd18b4ccd99754ab1247

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to...
dotnet-maestro-bot [Thu, 3 May 2018 02:56:32 +0000 (21:56 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02801-01, preview1-26503-01, preview1-26503-01, preview1-26502-05, beta-26502-00, beta-26502-00, respectively (dotnet/corefx#29441)

Commit migrated from https://github.com/dotnet/corefx/commit/8e7b583e2b8ad5081e4c43d258c98a65f0781d60

6 years agoImprove ManualResetValueTaskSource prototype (dotnet/corefx#29468)
Stephen Toub [Thu, 3 May 2018 02:56:16 +0000 (19:56 -0700)]
Improve ManualResetValueTaskSource prototype (dotnet/corefx#29468)

In .NET Core 2.1 we added the public `IValueTaskSource` and `IValueTaskSource<T>` interfaces, with associated support in `ValueTask` and `ValueTask<T>`, and while we implemented the interfaces on several types internally, we didn't expose any public implementations.

We should consider exposing several in the future, including a manual-reset and an auto-reset IValueTaskSource implementation.  We already have a ManualResetValueTaskSource implementation in our tests.  This commit improves upon it in a few ways:
- Separates out the logic into a separate public struct.  The ManualResetValueTaskSource class wraps the struct, giving developers a choice to either use the class directly, or to embed the struct in their own implementation.
- Fixes context capture to behave more similarly to Task, handling both SynchronizationContext and TaskSchedulers
- Adds a prototype implementation of an IAsyncEnumerable, demonstrating how the compiler could utilize ManualResetValueTaskSourceLogic in its implementation.

This is all still prototype, used only in tests.

Commit migrated from https://github.com/dotnet/corefx/commit/df43abbed58fa534a36ad1840ff597efc7b00f85