Steffen Mueller [Tue, 2 Jul 2013 17:06:01 +0000 (19:06 +0200)]
-DPERL_TRACE_OPS to produce reports on executed OP counts
This produces a report on the number of OPs of a given type that were
executed at the end of a program run. This can be useful in multiple
ways. One, it can help determine hotspots for optimization (yes, I know
execution count is not equal execution time). It can also help with
determining whether a given change to perl has had the desired effect on
deterministic programs.
Nicholas Clark [Mon, 17 Jun 2013 13:52:30 +0000 (15:52 +0200)]
Remove defunct DESCRIP.MMS cleanup rules.
Rules to remove C and object files from vms/ext were made redundant when
commit
26dd53a231877708 in Sep 2009 moved the XS extensions from there to
ext/
The wildcard rule to remove t/lib/vms*.t, which has been in
vms/descrip_mms.template since the file was added by commit
97abc6adffcd3efc
in June 1998 was effectively made redundant when it was duplicated by 4
specific rules for the 4 files it matched added by commit
493ba88a837f5a6b
in June 2001.
The rule to delete t/lib/vmsish.t was made redundant when vms/ext/vmsish.*
were moved to lib/ by commit
9f84c00564fd021b in Nov 2001.
Nicholas Clark [Mon, 17 Jun 2013 09:49:39 +0000 (11:49 +0200)]
Move VMS::Filespec from vms/ext to ext/
This simplifies the VMS Makefile. It would have simplified the VMS Makefile
further if it had had the correct rules to delete [.lib.VMS]Filespec.pm
which are now no longer needed. (The generated ext/VMS-Filespec/DESCRIP.MMS
will now take care of this.)
Nicholas Clark [Mon, 17 Jun 2013 09:37:50 +0000 (10:37 +0100)]
vms/ext/filespec.t does not need to be +x
The mode of this file has rattled back and forth between +x and -x since it
was first added. It makes no difference which it is, so remove -x and hence
1 special case.
Nicholas Clark [Tue, 2 Jul 2013 13:33:46 +0000 (15:33 +0200)]
Merge in the improvements to the build helper module FindExt.
Nicholas Clark [Mon, 17 Jun 2013 09:27:16 +0000 (11:27 +0200)]
Refactor FindExt, merging scan_ext() and find_ext().
The return value of FindExt::scan_ext() has never been used, since FindExt
was first added by commit
8e2329934bcca9c5 in April 2001. The call to
FindExt::extensions() has no side effects, so it can be eliminated. Hence
FindExt::scan_ext() is a trivial wrapper around FindExt::find_ext(), and the
two can be merged.
Also, simplify the logic for "known" extensions. The complexity of checking
the hash first was needed when extension directories were nested. It should
have been removed as part of commit
1f8a0b38638b171c in Feb 2009.
Nicholas Clark [Mon, 17 Jun 2013 08:50:33 +0000 (10:50 +0200)]
Skip most of FindExt's tests for troublesome configurations.
There are various various things that break the test's assumptions.
1) If Encode is a static extension, then Configure has special case logic
to add Encode/* as static extensions
2) -Uusedl causes Encode to be a static extension, and drops building
XS::APItest and XS::Typemap
3) Any use of -Dnoextensions to choose not to build a extension is not known
by the test
If any of these are true, FindExt::extensions() and $Config{extensions} will
differ, and most of the tests are going to fail. Moreover, failure doesn't
tell us anything interesting. So don't run those tests.
Nicholas Clark [Mon, 17 Jun 2013 08:19:48 +0000 (10:19 +0200)]
In FindExt.t, move the main loop's comparison logic into a subroutine.
Nicholas Clark [Fri, 14 Jun 2013 09:28:31 +0000 (11:28 +0200)]
Minor refactors to FindExt's test, removing code duplication.
Use a ternary instead of if/unless on the same $^O test.
Use a loop to call FindExt::scan_ext()
As FindExt exports nothing, we can require it rather than using it.
Nicholas Clark [Wed, 5 Jun 2013 19:19:12 +0000 (21:19 +0200)]
Thanks to FindExt::apply_config() we're now able to test dynamic extensions.
FindExt::apply_config() mimic's Configure's logic, which means that FindExt's
idea of which extensions should be built is consistent with Configure's.
Nicholas Clark [Wed, 5 Jun 2013 18:15:12 +0000 (20:15 +0200)]
Correct a type in FindExt::apply_config in the "I18N-Langinfo" code.
Commit
557ab4cb986767c7 (Feb 2011) which added this routine had
$config->{i_nl_langinfo} not $config->{d_nl_langinfo} ('i' should be 'd').
The logic for I18N::Langinfo should now be correct.
Nicholas Clark [Fri, 14 Jun 2013 15:10:31 +0000 (17:10 +0200)]
In FindExt, eliminate _ext_ne() and make extensions() a simple subroutine.
Previously _ext_ne() was a generator function, and extensions() and
known_extensions() were generated by it. Now that known_extensions() has a
different implementation, extensions() was the last user of _ext_ne(), so
there's no saving by keeping the complexity.
Nicholas Clark [Tue, 18 Jun 2013 10:00:38 +0000 (12:00 +0200)]
Also add Encode's sub-modules to known_extensions when building statically.
There is code in Configure to treat Encode specially when it is specified as
a statically linked extension. By default, Encode builds separated shared
objects for each of its subdirectories. This works well with DynaLoader,
and the top level perl Makefile doesn't even notice this, because it doesn't
have to list these libraries as things it links with at compile time.
For a static link, Encode builds a separate *.a file for each of its
subdirectories. The top level Makefile *does* need to know about these, as
a static link requires them all to be listed. Hence the work-around is to
treat Encode as a set of nested modules if linked statically.
We can't do this in Makefile.SH because the various Encode submodules are
installed as separate *.a files in the tree, and so need to continue to be
treated as distinct modules in case ExtUtils::MakeMaker is asked to (re)link
a static perl with an additional extension.
I suspect that the most elegant fix would be to tweak Encode's top level
Makefile.PL to link everything into one *.a if it is building statically.
I'm not sure how to do that, and it would need to be accepted upstream.
Nicholas Clark [Fri, 14 Jun 2013 14:56:28 +0000 (16:56 +0200)]
Add non-XS extensions to known_extensions.
Previously "known_extensions" was misnamed, as it only contained known XS
extensions. grep.cpan.me suggests that there are only 10 mentions of it
outside the core, and none of them rely on this existing behaviour.
Update the descriptions of extensions, known_extensions and nonxs_ext in
Porting/Glossary.
These changes need replicating into configure.com.
Nicholas Clark [Fri, 14 Jun 2013 14:19:06 +0000 (16:19 +0200)]
Remove Configure code that supported the old-style nested layout for ext/
5.10.1 switched to the new layout, so this code would only be useful for
backporting to maint-5.8. That isn't going happen, so it can go.
Nicholas Clark [Mon, 30 Apr 2012 16:00:39 +0000 (18:00 +0200)]
Trim the explicit Makefile rules to generate {mini,}perlmain.o
These duplicate the suffix rules used for general .c -> .o compilation.
makedepend automatically generates a dependency for miniperlmain.o on
patchlevel.h
Tony Cook [Tue, 2 Jul 2013 05:27:12 +0000 (15:27 +1000)]
OP*method was added in
c106c2be8b83ee but never used
Steffen Mueller [Tue, 2 Jul 2013 05:25:45 +0000 (07:25 +0200)]
Branch predictor hints: exists is mostly run on hashes
Peter Martini [Mon, 1 Jul 2013 20:09:02 +0000 (16:09 -0400)]
S_strip_spaces doesn't need to be seen out of core
Tony Cook [Tue, 25 Jun 2013 06:43:35 +0000 (16:43 +1000)]
Patches must not be sent via git's format-patch/send-email
updated to match perlgit.pod
Daniel Dragan [Sat, 29 Jun 2013 00:53:12 +0000 (20:53 -0400)]
#118675 fix 4 porting/pod_rules.t uses different perl than compiled one
See rt ticket #118675 for background on this patch.
Brian Gottreu [Tue, 2 Jul 2013 00:54:03 +0000 (19:54 -0500)]
dist/lib/Makefile.PL: change INSTALLDIRS to 'site' for 5.12 and later
Tony Cook [Tue, 2 Jul 2013 01:25:29 +0000 (11:25 +1000)]
perldelta for
c448c12411b1ba
Niko Tyni [Thu, 27 Jun 2013 11:37:01 +0000 (14:37 +0300)]
Make perlbug look up the list of local patches at run time
Re-parsing patchlevel.h in Perl by perlbug.PL is error prone
and apparently unnecessary. The same information is available
to perlbug via Config::local_patches().
This fixes [perl #118433].
Steffen Mueller [Mon, 1 Jul 2013 19:29:14 +0000 (21:29 +0200)]
Fix to make
8d455b9f99c1046e969462419b0eb5b8bf740a47 not a lie
Previous commit
8d455b9f99c1046e969462419b0eb5b8bf740a47 was a partial
lie. This commit fixes it up not to be a lie and to avoid mortalizing
the HV.
Steffen Mueller [Mon, 1 Jul 2013 18:33:05 +0000 (20:33 +0200)]
Avoid needless refcount and mortialization on pp_anonhash
pp_anonhash can be used to construct both bare hashes and hashrefs. In
the hashref case, it used to create an HV and mortalize it. Then it went
through the parameters on the stack and copied them into the hashref.
This can throw exceptions which would make the HV leak if it hadn't been
mortalized.
After potentially copying the arguments, pp_anonhash would then in the
hashREF case increment the refcount on the HV *again*, create an RV for
the HV, and mortalize that RV before pushing it on the stack.
Instead, we can get away with constructing the HV and only mortalizing
it if there's no mortalizable ref to clean up if there's an exception.
This should remove a fair fraction of work in the common case of empty {}
hash ref construction.
Karl Williamson [Mon, 1 Jul 2013 16:26:14 +0000 (10:26 -0600)]
Fix regex seqfault 5.18 regression
This segfault is a result of an optimization that can leave the
compilation in an inconsistent state.
/f{0}/
doesn't match anything, and hence should be removable from the regex for
all f. However,
qr{(?&foo){0}(?<foo>)}
caused a segfault. What was happening prior to this commit is that
(?&foo) refers to a named capture group further along in the regex.
The "{0}" caused the "(?&foo)" to be discarded prior to setting up the
pointers between the two related subexpressions; a segfault follows.
This commit removes the optimization, and should be suitable for a
maintenance release.
One might think that no one would be writing code like this, but this
example was distilled from machine-generated code in Regexp::Grammars.
Perhaps this optimization can be done, but the location I chose for
checking it was during parsing, which turns out to be premature. It
would be better to do it in the optimization phase of regex compilation.
Another option would be to retain it where it was, but for it to operate
only on a limited set of nodes, such as EXACTish, which would have no
unintended consequences. But that is for looking at in the future; the
important thing is to have a simple patch suitable for fixing this
regression in a maintenance release.
For the record, the code being reverted was mistakenly added by me in
commit
3018b823898645e44b8c37c70ac5c6302b031381, and wasn't even
mentioned in that commit message. It should have had its own commit.
Nicholas Clark [Mon, 1 Jul 2013 09:40:12 +0000 (11:40 +0200)]
Merge the branch that purged various under-used Makefile targets.
Nicholas Clark [Mon, 1 Jul 2013 09:39:39 +0000 (11:39 +0200)]
Document the removed Makefile targets in perldelta.
Nicholas Clark [Thu, 20 Jun 2013 14:46:05 +0000 (16:46 +0200)]
In perlhacktips, suggest a shell loop to generate all .gcov files.
Nicholas Clark [Thu, 20 Jun 2013 11:52:15 +0000 (13:52 +0200)]
Eliminate the perl.gprof and perl.gcov Makefile targets.
I don't feel that it's worthwhile having specific named targets for
building named binaries for use with gprof and gcov given that one has to
(re)Configure with the appropriate C compiler flags, hence all the object
files and the F<perl> that the build tree would build are just as enabled
(or contaminated) with profiling code as the specially named binary.
Update the documentation on using gprof and gcov to reflect that the binary
named F<perl> is now the binary that is profiled.
Nicholas Clark [Thu, 20 Jun 2013 09:00:34 +0000 (11:00 +0200)]
Run Porting/podtidy on pod/perlhacktips.pod
Nicholas Clark [Thu, 20 Jun 2013 08:51:17 +0000 (10:51 +0200)]
Update perlhacktips to note that Address Sanitizer is now also in gcc 4.8
Also s/linux/Linux/ in two places.
Nicholas Clark [Thu, 20 Jun 2013 08:15:31 +0000 (10:15 +0200)]
In perlhacktips, no need to give 3 ways to set an environment variable.
Nicholas Clark [Thu, 20 Jun 2013 08:01:20 +0000 (10:01 +0200)]
Remove the explicit purify/quantify/purecov targets and documentation.
It's not clear whether IBM still sell quantify or purecov. They still seem
to sell purify, but I'm not sure if anyone is using it these days to detect
bugs in perl.
This doesn't prevent anyone from using these tools if they have them, as
it's still possible to run the commands by "hand". But by removing probably
unused code and documentation, the signal to noise ratio improves.
Nicholas Clark [Wed, 19 Jun 2013 19:39:39 +0000 (21:39 +0200)]
We don't actually need to set $ENV{PERL} for the tests to work.
Whatever the executable is named at the top level, it's always symlinked
as ./perl in t, so there's no need to set an environment variable to
override the expected name.
Nicholas Clark [Wed, 19 Jun 2013 19:13:45 +0000 (21:13 +0200)]
valgrind doesn't require that perl was built with -g, so remove the check.
C<make test.valgrind> will run quite happily on a perl built with
optimisation and without debugging symbols. So don't enforce -g.
Nicholas Clark [Wed, 19 Jun 2013 12:09:55 +0000 (14:09 +0200)]
Inline the Makefile target minitest.prep into its only user.
This is strictly a refactoring, so do not change the rules themselves, despite
them being ugly and fragile.
Nicholas Clark [Wed, 19 Jun 2013 11:37:25 +0000 (13:37 +0200)]
Remove Makefile targets and tools related to Irix and Tru64 debugging tools.
Remove the targets:
perl.pixie perl.pixie.atom perl.pixie.config perl.pixie.irix perl.third
perl.third.config
It's still possible to run the actions these targets "by hand", if desired.
This commit removes the convenience targets from the Makefile, reducing its
complexity. It also removes the related support scripts testall.atom and
thirdclean from Porting/
pixie is a performance analysis tool for Irix and Tru64
Third Degree is a memory checker tool for Tru64
Given that Tru64 went out of support at the end of 2012, and Irix goes out
of support at the end of 2013, it's very unlikely that anyone is still
actively profiling or debugging perl on either platform, and hence using
these targets. It's been several years since we've even had a regular bug
report from either platform.
Nicholas Clark [Wed, 19 Jun 2013 10:35:33 +0000 (12:35 +0200)]
Remove various rarely used test targets from the generated Makefile.
Remove these targets and their documentation:
check.third check.utf16 check.utf8 coretest minitest.utf16 test.deparse
test.taintwarn test.third test.torture test.utf16 test.utf8
test_notty.deparse test_notty.third test_prep.third torturetest ucheck
ucheck.third ucheck.utf16 ucheck.valgrind utest utest.third utest.utf16
utest.valgrind
It's still possible to run the actions these targets "by hand", if desired.
This commit simply removes the convenience targets from the Makefile,
reducing its complexity.
Tony Cook [Mon, 24 Jun 2013 06:27:42 +0000 (16:27 +1000)]
[perl #71680] hints to use gdbm compat for [NO]DBM_File on Win32
James E Keenan [Sat, 26 Jan 2013 15:05:29 +0000 (10:05 -0500)]
Small stylistic improvement; add one POD formatting character.
Hojung Youn [Fri, 25 Jan 2013 09:52:53 +0000 (18:52 +0900)]
Give little more examples to interpolated typemap variables
Added an example for $type Perl variable interpolated by typemap.
and adjusted an example of $ntype Perl variable of typemap to
illustrate its effect.
Craig A. Berry [Mon, 1 Jul 2013 02:09:21 +0000 (21:09 -0500)]
Make t/comp/parser.t get the correct libraries.
In principle it shouldn't need libraries, but an eval of a utf8
constant now triggers automatic loading of utf8.pm, and it was
looking for that in the usual @INC locations set at configuration
time. Which just might match an installed perl rather than the
perl being tested. So make sure we get the correct libraries.
Ruslan Zakirov [Mon, 25 Feb 2013 09:46:02 +0000 (13:46 +0400)]
change tied_method to use SVs with precomputed hash values
Ruslan Zakirov [Sun, 24 Feb 2013 12:05:51 +0000 (16:05 +0400)]
change magic_methcall to use SV with shared hash value
Perl_magic_methcall is not public API, so there is no
need to add another function and we can just change
function's arguments.
Ruslan Zakirov [Mon, 25 Mar 2013 01:31:35 +0000 (05:31 +0400)]
SV_CONST(name) and PL_sv_consts
SV_CONST(XXX) returns SV* that contains "XXX" string.
SVs are built on demand and stored in interp's structure
for re-use. All SVs have precomputed hash value.
Creates SVs on demand, we don't want 35 SV created during
compile time or cloned during thread creation.
Ruslan Zakirov [Sat, 29 Sep 2012 16:41:10 +0000 (20:41 +0400)]
G_METHOD_NAMED flag for call_method and call_sv
Can be used when it's known that method name has no
package part - just method name.
With flag set SV with precomputed hash value is used
and pp_method_named is called instead of pp_method.
Method lookup is faster.
Father Chrysostomos [Sun, 30 Jun 2013 06:44:30 +0000 (23:44 -0700)]
perldiag: Consistent spaces after dots
Chris 'BinGOs' Williams [Sat, 29 Jun 2013 21:34:17 +0000 (22:34 +0100)]
Update IPC-Cmd to CPAN version 0.82
[DELTA]
Changes for 0.82 Sat Jun 29 22:11:22 BST 2013
=================================================
* Typo fixes (David Steinbrunner)
Father Chrysostomos [Sat, 29 Jun 2013 01:31:26 +0000 (18:31 -0700)]
op.c: Suppress compiler warning
Sorry, commit
08aff5359 was not quite ready and I pushed it too soon.
The purpose of the if block that it removed was to suppress a warn-
ing about an unused variable, but it was a very strange way of accom-
plishing that.
We have a much simpler way that takes only one line and expresses its
intent clearly.
Brian Gottreu [Fri, 28 Jun 2013 23:43:41 +0000 (18:43 -0500)]
regenerate t/porting/known_pod_issues.dat
Brian Gottreu [Fri, 28 Jun 2013 23:07:49 +0000 (18:07 -0500)]
Run the pedantic checks when regenerating the database
Make the two checks of possible poor uses of C<>
pedantic checks.
Allow --pedantic to turn on those tests in addition to
the environmnt variable.
Ricardo Signes [Tue, 18 Jun 2013 23:45:56 +0000 (19:45 -0400)]
do not worry about long verbatim lines w/o env var
To run these tests, set PERL_POD_PEDANTIC in the environment.
This needs further testing, at least, to ensure that it behaves correctly
when regenerating the known problem files.
Ricardo Signes [Tue, 18 Jun 2013 23:27:11 +0000 (19:27 -0400)]
Revert "Make t/podcheck.t less sensitive"
This reverts commit
f26da014a698383ac348973050af3e754752e6ab.
Conflicts:
t/porting/known_pod_issues.dat
Father Chrysostomos [Fri, 28 Jun 2013 21:24:59 +0000 (14:24 -0700)]
op.c: Remove dummy code from const_sv_xsub
This was added in commit
9cbac4c7 with no explanation. It has been
#ifdeffed out since it was added. That commit was supposedly just for
compiler warnings. I think this was something else the author was
playing with that got combined in the same patch by mistake.
Father Chrysostomos [Fri, 28 Jun 2013 19:45:41 +0000 (12:45 -0700)]
perlfunc: consistent spaces after dots
plus one typo fix
Johan Vromans [Mon, 24 Jun 2013 07:23:49 +0000 (09:23 +0200)]
Clarify variable lists for my, our, state.
Neil Bowers [Wed, 26 Jun 2013 21:53:55 +0000 (22:53 +0100)]
7b2d3c0 Added description of the Benchmark object to doc
Father Chrysostomos [Fri, 28 Jun 2013 07:09:02 +0000 (00:09 -0700)]
op.c:cv_ckproto_len_flags: do null checks first
Checking local variables for nullness is faster than calling ckWARN_d,
which involves a function call.
Father Chrysostomos [Wed, 26 Jun 2013 03:31:54 +0000 (20:31 -0700)]
Reinstate UTF8f
This format string allows char*s to be interpolated with the
utf8ness and length specified as well, avoiding the need to create
extra SVs:
Perl_croak(aTHX_ "Couldn't twiggle the twoggle in \"%"UTF8f"\"",
UTF8fARG(is_utf8, len, s));
This is the second attempt.
I screwed up in commits
1c8b67b38f0a5 and
b3e714770ee1 because
I didn’t really understand how varargs functions receive their
arguments.
They are like structs, in that different members can be different
sizes. So therefore both ends--the caller and the called--*must* get
the casts right, or the data will be corrupted.
The main mistake I made was to use %u in the format for the first
argument and then retrieve it as UV (a simple typo, I meant unsigned
int or U32--I don’t remember).
To be on the safe side, I added a UTF8fARG macro (after SVfARG), which
(unlike SVfARG) takes three arguments and casts them explicitly, mak-
ing it much harder to get this wrong at call sites.
Tony Cook [Fri, 28 Jun 2013 01:55:27 +0000 (11:55 +1000)]
make sure the prototype actually matches
because:
a) I think it better demonstrates the fix, the following failed without
the patch:
./perl -Ilib -le 'my $proto = "\x{30cd}"; eval "sub f($proto) {}"; print prototype(\&f); print prototype(\&f) eq $proto'
b) I can envision bugs that might preserve UTF-8 but mis-manage the content
Brian Fraser [Sun, 24 Mar 2013 08:58:43 +0000 (05:58 -0300)]
pad.c, S_cv_clone: Maintain the utf8-ness of the cloned cv
Because of a missing SvUTF8_on() in cv_clone(), these two were different:
use utf8;
eval " sub foo ($;\x{30cd});"
eval "my sub foo ($;\x{30cd});"
Because the lexical version would lose the UTF8 flag in the
prototype.
Ricardo Signes [Thu, 27 Jun 2013 02:12:34 +0000 (22:12 -0400)]
perlexperiment: mark :pop layer as accepted
Brian Gottreu [Thu, 27 Jun 2013 03:11:17 +0000 (22:11 -0500)]
MANIFEST: add t/porting/readme.t
Brian Gottreu [Thu, 27 Jun 2013 00:44:34 +0000 (19:44 -0500)]
Fix Porting/README.pod so it passes its new test.
Added entries for sync-with-cpan and README.pod itself. Rearranged
entries to be sorted consistently.
Brian Gottreu [Thu, 27 Jun 2013 00:39:25 +0000 (19:39 -0500)]
t/porting/readme.t: Check Porting/README.pod consistency
This is a slightly expanded (or bloated) version of the patch
Dennis Kaarsemaker <dennis@kaarsemaker.net> submitted.
Chris 'BinGOs' Williams [Thu, 27 Jun 2013 15:15:32 +0000 (16:15 +0100)]
Correct the SYNOPSIS for Module::CoreList::Utils
Chris 'BinGOs' Williams [Thu, 27 Jun 2013 10:04:53 +0000 (11:04 +0100)]
Update HTTP-Tiny to CPAN version 0.034
[DELTA]
0.034 2013-06-26 19:02:25 America/New_York
[ADDED]
- Added support for 'Basic' authorization from
user:password parameters in the URL
Peter Martini [Thu, 27 Jun 2013 04:06:16 +0000 (00:06 -0400)]
cv_ckproto should disregard spaces
This included some refactoring to break down the original
large if block into smaller, more manageable chunks,
although the only functional change was to pass the two
string buffers through S_strip_spaces.
Karl Williamson [Wed, 26 Jun 2013 23:51:36 +0000 (17:51 -0600)]
t/re/reg_mesg.t: Add diagnostic output on some failures
Aristotle Pagaltzis [Thu, 27 Jun 2013 01:55:13 +0000 (11:55 +1000)]
[perl #117751] prevent POSIX::AUTOLOAD recursing if POSIX$(so) fails to load
Reini Urban [Mon, 8 Apr 2013 17:25:27 +0000 (12:25 -0500)]
Use -Wno-unused-value also on other clang compilers
clang++ or clang-3.2, ...
Father Chrysostomos [Thu, 27 Jun 2013 01:03:04 +0000 (18:03 -0700)]
[perl #117535, #76910] Fix bogus ambiguity warnings
‘Ambiguous use of * resolved as operator *’: This message can occur in
cases where there is no multiplication operator, so what it is saying
is completely wrong.
When the lexer parses a bareword, it looks at the previous character
and warns if it happens to match /[*%&]/, so foo**bar and foo&&bar
result in this warning, as does print $%foo.
The purpose of the code is to catch *bar *bar or &black &sheep.
To avoid false positives, when emitting one of the three operators
* % & the lexer can record that fact, so when it sees a bareword pre-
ceded by one of those three characters, instead of guessing that the
infix operator was used, it will *know*.
The test cases added also trigger ‘Bareword found where operator
expected’. I don’t know whether that should change, but at least the
current behaviour is tested, so we will know when it does change.
Karl Williamson [Wed, 26 Jun 2013 21:52:01 +0000 (15:52 -0600)]
regen/genpacksizetables.pl: Add comment
Karl Williamson [Wed, 26 Jun 2013 21:50:37 +0000 (15:50 -0600)]
perlguts: Nit
Father Chrysostomos [Wed, 26 Jun 2013 13:05:06 +0000 (06:05 -0700)]
embed.fnc: S_ptr_hash is inline
S_ptr_hash is declared with PERL_STATIC_INLINE in hv.c, but embed
thinks it is just static, so the proto.h and hv.c definitions do not
match, resulting in warnings.
Chris 'BinGOs' Williams [Wed, 26 Jun 2013 11:42:13 +0000 (12:42 +0100)]
Update Digest-SHA to CPAN version 5.85
[DELTA]
5.85 Wed Jun 26 04:05:26 MST 2013
- workaround for repeated calls to shaclose (ref. Bug #86295)
-- need to explicitly reset internal pointer to NULL
ref. shaclose() in SHA.xs
- corrected typos in shasum script
-- ref. Bug #85430
Father Chrysostomos [Wed, 26 Jun 2013 07:38:52 +0000 (00:38 -0700)]
Put all sort arguments in list context
The arguments following the first were using the context the enclosing
function was called in.
sub context { warn qw[void scalar list][wantarray + defined wantarray ] }
sub foo { sort +context, context; print "------\n"; }
foo;
$_ = foo;
[foo];
__END__
Output:
list at - line 1.
void at - line 1.
------
list at - line 1.
scalar at - line 1.
------
list at - line 1.
list at - line 1.
------
Extend the list context to all arguments.
Father Chrysostomos [Wed, 26 Jun 2013 08:08:29 +0000 (01:08 -0700)]
Fix up f_sort.t for changes in the prev commit
Father Chrysostomos [Wed, 26 Jun 2013 07:32:58 +0000 (00:32 -0700)]
Put sort arguments in lvalue context
Since $a and $b are aliased to the actual scalars being sorted, and
since they can be modified, the list of items needs to be in lvalue
context, like the arguments to grep. Otherwise implementation
details leak through, in that sort{$a=1} $_,... will modify $_, but
sort{$a=1} $#_,... will fail to modify $#_.
The way I have written the loop and if() condition (the if inside the
loop) may seem odd and inefficient, but the next commit will take
advantage of that.
Father Chrysostomos [Wed, 26 Jun 2013 07:18:03 +0000 (00:18 -0700)]
In-place sort should not leave array read-only
$ ./perl -Ilib -e '@a=1..2; eval { @a=sort{die} @a }; warn "ok so far\n"; @a = 1'
ok so far
Modification of a read-only value attempted at -e line 1.
If something goes wrong inside the sort block and it dies, we still
need to make sure we turn off the read-only flag on that array.
Moritz Lenz [Sun, 21 Apr 2013 14:11:06 +0000 (16:11 +0200)]
document that it is the operator that determines the operation
In many other dynamic languages it is the operator plus the type of the
first operand, so it is worth mentioning.
Father Chrysostomos [Wed, 26 Jun 2013 06:31:34 +0000 (23:31 -0700)]
Increase $if::VERSION to 0.0603
Neil Bowers [Mon, 24 Jun 2013 23:51:49 +0000 (00:51 +0100)]
Added example usage and SEE ALSO links to similar modules in doc for if.pm
Father Chrysostomos [Wed, 26 Jun 2013 05:06:57 +0000 (22:06 -0700)]
op.c:S_simplify_sort: remove redundant OPf_STACKED check
S_simplify_sort is only called from one spot and only when the
OPf_STACKED flag is not set.
Father Chrysostomos [Wed, 26 Jun 2013 04:47:44 +0000 (21:47 -0700)]
op.c:ck_sort: Restore HINT_LOCALIZE_HH check
I remove this by mistake in commit
354dd559d99. It makes no
difference to the behaviour. This check is just for efficiency.
Karl Williamson [Wed, 26 Jun 2013 00:42:45 +0000 (18:42 -0600)]
Revert "Use UTF8f in more places"
This reverts commit
acc19697c67fa63c10e07491b670a26c48f4175f.
This and the other UTF8f patch are causing significant problems on some
configurations on 32-bit platforms. We've decided to revert them until
they can be resubmitted after the kinks get ironed out.
Karl Williamson [Wed, 26 Jun 2013 00:40:42 +0000 (18:40 -0600)]
Revert "UTF8f"
This reverts commit
670610ebb17508101065cc5f5ecfe616aace5335.
This and the other UTF8f patch are causing significant problems on some
configurations on 32-bit platforms. We've decided to revert them until
they can be resubmitted after the kinks get ironed out.
Yves Orton [Tue, 25 Jun 2013 22:59:09 +0000 (00:59 +0200)]
Add tests for a backreference following a literal, which is a different codepath
/\87/ is parsed through a different code path than /foo\87/ so we
test that they both work properly when there are sufficient capture
buffers defined. We test the fail cases in the re/re_tests corpus,
but the success cases are easier managed in re/pat.t.
Yves Orton [Tue, 25 Jun 2013 19:01:27 +0000 (21:01 +0200)]
Fix rules for parsing numeric escapes in regexes
Commit
726ee55d introduced better handling of things like \87 in a
regex, but as an unfortunate side effect broke latex2html.
The rules for handling backslashes in regexen are a bit arcane.
Anything starting with \0 is octal.
The sequences \1 through \9 are always backrefs.
Any other sequence is interpreted as a decimal, and if there
are that many capture buffers defined in the pattern at that point
then the sequence is a backreference. If however it is larger
than the number of buffers the sequence is treated as an octal digit.
A consequence of this is that \118 could be a backreference to
the 118th capture buffer, or it could be the string "\11" . "8". In
other words depending on the context we might even use a different
number of digits for the escape!
This also left an awkward edge case, of multi digit sequences
starting with 8 or 9 like m/\87/ which would result in us parsing
as though we had seen /87/ (iow a null byte at the start) or worse
like /\x{00}87/ which is clearly wrong.
This patches fixes the cases where the capture buffers are defined,
and causes things like the \87 or \97 to throw the same error that
/\8/ would. One might argue we should complain about an illegal
octal sequence, but this seems more consistent with an error like
/\9/ and IMO will be less surprising in an error message.
This patch includes exhaustive tests of patterns of the form
/(a)\1/, /((a))\2/ etc, so that we dont break this again if we
change the logic more.
Steffen Mueller [Mon, 24 Jun 2013 05:59:30 +0000 (07:59 +0200)]
Document and clean up -s option to xsubpp
At the same time, discourage its use. It's an obscure option that, most
of the time, does the opposite of what people actually need. If nothing
else, it should be a feature of XS instead of xsubpp.
But it exists, so documenting it with a warning is the right thing to
do.
Daniel Dragan [Sat, 25 May 2013 16:06:27 +0000 (18:06 +0200)]
Stop "sv_2mortal(&PL_sv_yes)" and "(void)sv_newmortal()" in ParseXS
This problem was brought up in #115796. Both of those lines of code that
ParseXS put out when dealing with T_BOOL were unnecessary, and caused a
some inefficiencies (extra calls). Since typemaps can have complicated
evaluation and include Perl code, see commit
9712754a3e, it is best to
eval the typemap entry first, then regexp it to see what it looks like,
not regexp the unevaled entry possibly containing Perl. In case a typemap
entry is maintaining state inside ParseXS (venturing into the undocumented
and unsupported), (I've never seen it done) don't eval it twice if it can
be avoided. Someone might want to change the typemap entry to multiple
eval in the future, but don't introduce it now if it can be avoided.
Using T_BOOL by name to see an immortal is a bad idea, since any XS module
can reuse the typemap entry, so best to regexp for something that looks
like it would return an immortal, "= &PL_sv_* ;" or "= boolSV(". In the
future someone might want to introduce a macro that does nothing, except
gives a signal to ParseXS that an expression returns an immortal or an
already mortaled SV, to suppress the sv_2mortal call.
The tests in 001-basic.t might break in the future with changes to ParseXS
or the Perl API, but I assume they will be fixed at that point in time.
Note: This patch was amended by the committer to apply cleanly to a
newer version of ExtUtils::ParseXS and to include all necessary test
changes.
Steffen Mueller [Wed, 22 May 2013 20:08:42 +0000 (22:08 +0200)]
EU::ParseXS: Test cleanup
Lots of dead code and some inflexibilities wrt. running tests from / or
t/.
Steffen Mueller [Wed, 22 May 2013 20:07:59 +0000 (22:07 +0200)]
EU::ParseXS: Move several constants out of the runtime object
Steffen Mueller [Wed, 22 May 2013 20:07:10 +0000 (22:07 +0200)]
EU::ParseXS: Cosmetics; more explicitness in *_handler
Basically, using named lexical beats $_ by a long shot since they don't
magically propagate into functions called.
Steffen Mueller [Wed, 22 May 2013 20:04:51 +0000 (22:04 +0200)]
EU::ParseXS: Use OO version of ExtUtils::ParseXS in test
Sort of. Breaking encapsulation, but that's better than not even having
a blessed object at all.
Steffen Mueller [Wed, 22 May 2013 20:03:38 +0000 (22:03 +0200)]
EU::ParseXS: Simplify output typemap code generation (targetable)
Steffen Mueller [Wed, 22 May 2013 20:00:48 +0000 (22:00 +0200)]
EU::ParseXS: Cosmetics; better variable naming
Steffen Mueller [Wed, 22 May 2013 19:57:59 +0000 (21:57 +0200)]
EU::ParseXS: Fix targetable size detection
Adds new / vastly improved tests for 'targetable'.
Also improves targetable documentation.