Andy Hanson [Mon, 8 Jul 2019 23:12:06 +0000 (16:12 -0700)]
Return HardLimitBytes from GCMemoryInfo.TotalAvailableMemoryBytes (dotnet/coreclr#25437)
* Add property HardLimitBytes to GCMemoryInfo
This adds a new property HardLimitBytes.
Unlike TotalAvailableMemoryBytes,
this will reflect an explicitly set COMPLUS_GCHeapHardLimit.
It will also reflect the fraction of a container's size that we use,
where TotalAvailableMemoryBytes is the total container size.
Normally, though, it is equal to TotalAvailableMemoryBytes.
Fix dotnet/coreclr#38821
* Remove HardLimitBytes; have TotalAvailableMemoryBytes take on its behavior
* Fix typos
* Separate total_physical_mem and heap_hard_limit
so we can compute highMemoryLoadThresholdBytes and memoryLoadBytes
* Do more work in gc.cpp instead of Gc.cs
* Consistently end names in "Bytes"
Commit migrated from https://github.com/dotnet/coreclr/commit/
11137fbe46f524dfd6c2f7bb2a77035aa225524c
Steve MacLean [Mon, 8 Jul 2019 21:36:31 +0000 (17:36 -0400)]
Add arm64 floatconversion.S (dotnet/coreclr#25597)
* Add arm64 floatconversion.S
* Update comment
Commit migrated from https://github.com/dotnet/coreclr/commit/
8749c016e520bcaa23c56a862fe5f57eba1b879b
Matt Galbraith [Sun, 7 Jul 2019 15:09:02 +0000 (08:09 -0700)]
Fixes spelling
Commit migrated from https://github.com/dotnet/coreclr/commit/
085398b5c6913b03180c855f56b967e2a7d6edde
Maoni Stephens [Sat, 6 Jul 2019 07:09:32 +0000 (00:09 -0700)]
fix merge error (dotnet/coreclr#25573)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1d78ed88ff9078febdbb5c37173b313da5c023a3
dotnet-maestro[bot] [Fri, 5 Jul 2019 23:12:43 +0000 (16:12 -0700)]
[master] Update dependencies from dotnet/corefx (dotnet/coreclr#25564)
- Microsoft.NETCore.Platforms - 3.0.0-preview8.19354.4
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19354.4
* Disable failing test
Commit migrated from https://github.com/dotnet/coreclr/commit/
09d454011f5b302ef526036266993f8b0e92f1fd
Sergiy Kuryata [Fri, 5 Jul 2019 20:03:34 +0000 (13:03 -0700)]
Re-enable Microsoft.VisualBasic tests (dotnet/coreclr#25572)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce2ff9d543a06f4ff43f5a5f3230243b0af5f156
Maoni Stephens [Fri, 5 Jul 2019 19:48:34 +0000 (12:48 -0700)]
many core (dotnet/coreclr#25350)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c7d12d2b91f79802a12484d4d56c41ba355b7058
Fadi Hanna [Fri, 5 Jul 2019 04:48:48 +0000 (21:48 -0700)]
Fix instantiation stub maker for case where no register is used by function parameters (dotnet/coreclr#25558)
* Fix instantiation stub maker for case where no register is used by function parameters
Commit migrated from https://github.com/dotnet/coreclr/commit/
b7ba5fac2058f6c59acb6a34b699ad2e069f3d6c
Mike McLaughlin [Thu, 4 Jul 2019 14:07:51 +0000 (07:07 -0700)]
Fix dotnet-dump/createdump launch failure (dotnet/coreclr#25562)
On CentOS or OpenSUSE dotnet-dump collect fails but a
valid coredump is generated. The "prctl()" call is failing
that gives the child createdump process permission to ptrace
to the runtime process. On CentOS/OpenSUSE the PR_SET_PTRACER
option isn't supported and not needed.
Issue: https://github.com/dotnet/diagnostics/issues/334
Commit migrated from https://github.com/dotnet/coreclr/commit/
036e426e7fffa6b10c2347c61a030d3ed8eb428e
Aaron Robinson [Thu, 4 Jul 2019 04:38:04 +0000 (21:38 -0700)]
Remove legacy resource value (PrivateBuild) in binaries. (dotnet/coreclr#25560)
* Remove legacy resource value (PrivateBuild) in binaries.
* Never set the private file flag on the binary
Commit migrated from https://github.com/dotnet/coreclr/commit/
a985dda162403ec995c4752e194bc5a062f444a5
José Rivero [Thu, 4 Jul 2019 03:05:22 +0000 (20:05 -0700)]
Fix getting rundown events during EventPipe::Shutdown (dotnet/coreclr#25450)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4312aeb47447039574e9e905cdcb2bae6388e101
Steve MacLean [Thu, 4 Jul 2019 02:29:07 +0000 (22:29 -0400)]
arm64singlestepper (dotnet/coreclr#25512)
Add single step emulation for arm64 Linux
Add a copy and rework armsinglestepper to arm64singlestepper
Add arm64 emulation of all armv8 user space instructions which read or write PC.
- ADR, ADRP
- Branch instructions: B, BL, B.cond, BR, BLR, RET
- LDR (literal)
* Add FEATURE_EMULATE_SINGLESTEP
* Enable for ARM64 linux
* Debugging fixes
Fix IsSSFlagEnabled bug
Fix opcode type
Fix code buffer asserts
Fix CBZ typo
Fix BitExtract
Fix m_targetPc
Minimize written instructions
Fix comments
Fix Bypass address truncation
Fix false assert
Add additional logging
Use %lx to log addresses
Remove stray LOG
Remove stray assert
Commit migrated from https://github.com/dotnet/coreclr/commit/
613f9f233abde4159a85aa8130b7fcb57dc7a4ef
John Salem [Thu, 4 Jul 2019 00:52:53 +0000 (17:52 -0700)]
Prevent EventPipe rundown from blocking on write (dotnet/coreclr#25523)
* Write all rundown events to the buffer manager to prevent the write from blocking while holding the CodeManager lock
* * Incorporate PR feedback
* changed to one suspend rather than suspend->resume->suspend
* added some comments
* update comments
Commit migrated from https://github.com/dotnet/coreclr/commit/
ae3430d8ce50c9e954192e89871aff783da375e2
David Mason [Thu, 4 Jul 2019 00:15:47 +0000 (17:15 -0700)]
Add check to prevent attaching a profiler when one is already present (dotnet/coreclr#25520)
* Don't load multiple profilers
* add comment
* Move check to LoadProfiler, and eliminate race condition between attach profiler and startup profiled
Commit migrated from https://github.com/dotnet/coreclr/commit/
1893a9c21d21a860094155b330efca9e598581d0
Jarret Shook [Wed, 3 Jul 2019 23:23:22 +0000 (16:23 -0700)]
Enable coredumps on unix (dotnet/coreclr#25551)
* Enable coredumps on unix
* Remove morph change
Commit migrated from https://github.com/dotnet/coreclr/commit/
16b6f2c9c2196bfc32020dcd12cda4c4f34279df
Koundinya Veluri [Wed, 3 Jul 2019 23:22:31 +0000 (16:22 -0700)]
Fix GCStress modes that do code instrumentation to work with code versioning (dotnet/coreclr#25261)
- SOS changes are in https://github.com/dotnet/diagnostics/pull/369
- Fixes https://github.com/dotnet/coreclr/issues/17646
Commit migrated from https://github.com/dotnet/coreclr/commit/
01da3bdd734c887856f89037cd4a3f2b5a072967
Sung Yoon Whang [Wed, 3 Jul 2019 22:50:46 +0000 (15:50 -0700)]
Add test for eventcounter (dotnet/coreclr#25555)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f36453660859bb88875b655922b4c3e8d28da4c0
Jan Kotas [Wed, 3 Jul 2019 15:59:25 +0000 (08:59 -0700)]
Cleanup IL linker heuristic usage (dotnet/coreclr#25547)
Prep-work for using mainstream IL linker
Commit migrated from https://github.com/dotnet/coreclr/commit/
60f1e6265bd1039f023a82e0643b524d6aaf7845
Jan Kotas [Wed, 3 Jul 2019 07:34:50 +0000 (00:34 -0700)]
Delete some dead code (dotnet/coreclr#25546)
Commit migrated from https://github.com/dotnet/coreclr/commit/
87f4eff9188456c26ffab6efbcc725110630a3dd
Brian Robbins [Wed, 3 Jul 2019 05:50:26 +0000 (22:50 -0700)]
Add a new CompilationDiagnostic ETW Keyword (dotnet/coreclr#25544)
Commit migrated from https://github.com/dotnet/coreclr/commit/
19c6c5d05c666ed6a15f8149a5de6d75085bb1aa
David Mason [Wed, 3 Jul 2019 01:30:43 +0000 (18:30 -0700)]
Merge ReadyToRunInfo::GenericMethodIterator in to ReadyToRunInfo::MethodIterator (dotnet/coreclr#25518)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8f46ffbf40cd9896a3bf2f6a2a4568b4dc8492c7
Andrew Au [Tue, 2 Jul 2019 23:35:40 +0000 (16:35 -0700)]
Ensure YIELD_WHILE() in EventPipeBufferManager::SuspendWriteEvent() always terminates (dotnet/coreclr#25491)
Commit migrated from https://github.com/dotnet/coreclr/commit/
bf3dce315eb9fe8da4491b711fecddb4116e2314
Matt Galbraith [Tue, 2 Jul 2019 22:13:35 +0000 (15:13 -0700)]
Merge pull request dotnet/coreclr#25540 from MattGal/update-more-docker-images
Fix all remaining Python 2 Helix Docker images
Commit migrated from https://github.com/dotnet/coreclr/commit/
d98efbef7016d38036f69ed69dc041c5876755b6
Egor Chesakov [Tue, 2 Jul 2019 18:24:57 +0000 (11:24 -0700)]
Remove test method exclusions addressed in https://github.com/dotnet/corefx/pull/38856 (dotnet/coreclr#25389)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9651b3ddf5b04777288d107f025c8d5a789cf083
Matt Galbraith [Tue, 2 Jul 2019 17:12:01 +0000 (10:12 -0700)]
This should finish off updating all of CoreCLR's images to versions supporting python 3 from https://github.com/dotnet/dotnet-buildtools-prereqs-docker (also saves some time by preinstalling virtualenv stuff)
Commit migrated from https://github.com/dotnet/coreclr/commit/
712350ef64653f90a273d0281c8fd3673b7f6d77
Michal Strehovský [Tue, 2 Jul 2019 13:33:16 +0000 (15:33 +0200)]
Use Array.MaxArrayLength in ArrayList (dotnet/coreclr#25530)
Now that `ArrayList` is in CoreLib, we don't need the copy.
Commit migrated from https://github.com/dotnet/coreclr/commit/
948e0f2713c78fac5278826ee724a3f1503f2e2e
Ilya [Tue, 2 Jul 2019 12:54:03 +0000 (17:54 +0500)]
Reduce allocations in GetLocale() (dotnet/coreclr#25531)
Commit migrated from https://github.com/dotnet/coreclr/commit/
db90a795f5280ead19d5cc1780e9e25aad29fb8d
Sung Yoon Whang [Tue, 2 Jul 2019 07:08:30 +0000 (00:08 -0700)]
Add RundownRequested switch to EventPipe IPC protocol (dotnet/coreclr#25495)
* Add RundownRequested switch to EventPipe IPC protocol
* Fix linux build
* make the rundownRequested field a bool
* some renaming
* Make a new command that has an option for disabling rundown instead of breaking change
* code review feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
eb13fb092778db9fa8a0dea755393494959b71a6
Sung Yoon Whang [Tue, 2 Jul 2019 06:19:07 +0000 (23:19 -0700)]
Decrease EventListener buffer size (dotnet/coreclr#25526)
* Reduce the default EventPipe circularBufferSize to 10MB for EventListener sessions
* make it a static var instead of random # in the code
Commit migrated from https://github.com/dotnet/coreclr/commit/
f9a6e873747dbefeca9016e31378d532ce56f293
Sung Yoon Whang [Tue, 2 Jul 2019 05:25:31 +0000 (22:25 -0700)]
test DisplayUnits/DisplayRateTimeScale properties (dotnet/coreclr#25525)
Commit migrated from https://github.com/dotnet/coreclr/commit/
0d8304713fb2766b84c90616d2b88a622db1924e
Michal Strehovský [Mon, 1 Jul 2019 05:15:28 +0000 (07:15 +0200)]
Use AssemblyLoadContext from shared partition (dotnet/corertdotnet/coreclr#7570)
We were missing methods that got added for 3.0. The only LoadContext that works is the default one though.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
e6e170fdec2bb20a76126bd9b40e4a284e6c92f2
Jan Kotas [Tue, 2 Jul 2019 02:46:37 +0000 (19:46 -0700)]
Delete dead code (dotnet/coreclr#25513)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f93906ced7725b5fcd248b10950fbdfef8188c5b
Michal Strehovský [Tue, 2 Jul 2019 02:46:24 +0000 (04:46 +0200)]
Get rid of warnings while building tests (dotnet/coreclr#25514)
Commit migrated from https://github.com/dotnet/coreclr/commit/
78b7ac7ef79a5c3c4a4b4965b29e8078f4433230
Russ Keldorph [Mon, 1 Jul 2019 04:06:55 +0000 (21:06 -0700)]
Disable windows formatting job in PRs (dotnet/coreclr#25507)
Temporarily disable this job to stop redness in PRs until dotnet/coreclr#25499 is addressed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8aa6c18bce4b47ce8c7805b934c9c53ca44a2309
Bruce Forstall [Sat, 29 Jun 2019 21:57:58 +0000 (14:57 -0700)]
Remove an old CoreFX exclusion file (dotnet/coreclr#25500)
Plus, add comments to the new exclusion file
Commit migrated from https://github.com/dotnet/coreclr/commit/
2b4f1592057c8868f330d31041a5ab94a5087721
Bruce Forstall [Sat, 29 Jun 2019 16:50:02 +0000 (09:50 -0700)]
Update documentation for corefx testing in coreclr repo (dotnet/coreclr#25493)
* Update documentation for corefx testing in coreclr repo
* Apply suggestions from code review
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
* Update a command line; improve clarity
Commit migrated from https://github.com/dotnet/coreclr/commit/
96609bc07cc823c9336061713926556fff2c1bc0
Bruce Forstall [Sat, 29 Jun 2019 15:57:05 +0000 (08:57 -0700)]
Re-enable corefx tests (dotnet/coreclr#25490)
Re-enable corefx tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
884c40279f5ea9110c217496c6c17a26b418f405
Brian Sullivan [Sat, 29 Jun 2019 08:26:37 +0000 (01:26 -0700)]
Fix GCStress issue on x86 and Arm (dotnet/coreclr#25445)
* Fix GCStress issue on x86 and Arm32
When we write one of the new gc stress instruction, such as INTERRUPT_INSTR_PROTECT_FIRST_RET
we might be writing it in the epilog region on x86 or ARM as a direct call can be the last
instruction before an epilog. (This isn't allowed on x64)
This fix expands the set of instructions we are allowed by IsMarkerInstr() toinclude these
newly added gc stress instructions.
added comment to GetGcMarkerExceptionCode
Fix DAC build
* Code review feedback
* Additional code review chnages
Commit migrated from https://github.com/dotnet/coreclr/commit/
f968db93773f756b8b94b0d752dd70cb26884f38
Koundinya Veluri [Sat, 29 Jun 2019 07:27:20 +0000 (00:27 -0700)]
Fix a mutex abandon case with WaitHandle.WaitAll in the PAL (dotnet/coreclr#25452)
Fixes https://github.com/dotnet/coreclr/issues/25108
- Upon a `WaitAll` when all waits are already satisfied, the abandoned flag is overwritten with the abandoned state of the last wait object in the array
- So if the first wait object is an abandoned mutex and the second wait object is a signaled event, the `WaitAll` succeeds and does not report that anything was abandoned
- Fixed to accumulate into the flag instead of overwriting it
Commit migrated from https://github.com/dotnet/coreclr/commit/
e0a9df573c1d208dc70b92cc7fcb7e487614c4f1
Sung Yoon Whang [Sat, 29 Jun 2019 00:06:19 +0000 (17:06 -0700)]
Stop using reflection on pollingcounter tests (dotnet/coreclr#25489)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ce8eaf4d4acad83f8e38095651ff765d339aab2
Sung Yoon Whang [Fri, 28 Jun 2019 20:57:19 +0000 (13:57 -0700)]
Don't return TRUE on tracepoint_enabled if LTTng library does not exist on build (dotnet/coreclr#25459)
Commit migrated from https://github.com/dotnet/coreclr/commit/
59e7be03ddb77e36b8e36574682d23cb6dc38f5c
Jan Kotas [Fri, 28 Jun 2019 20:31:19 +0000 (13:31 -0700)]
Use regular static variable for EEConfig storage (dotnet/coreclr#25479)
Fixes dotnet/coreclr#25475
Commit migrated from https://github.com/dotnet/coreclr/commit/
c381bc0c982f36b9492975d49e5fed82680a749d
Koundinya Veluri [Fri, 28 Jun 2019 20:08:22 +0000 (13:08 -0700)]
Fix an assertion failure in the thread pool's QueueUserWorkItemCallbackBase (dotnet/coreclr#25482)
Fixes https://github.com/dotnet/coreclr/issues/25242
- The issue could be that there is no memory barrier (or in the wrong place) on the thread reading the value, and an old value could be cached and read
Commit migrated from https://github.com/dotnet/coreclr/commit/
c191f92b30e212b7638e0ae3b71240c73991b369
Andrew Au [Fri, 28 Jun 2019 17:41:31 +0000 (10:41 -0700)]
Avoid the multiplication generated by mc.exe (dotnet/coreclr#25454)
Commit migrated from https://github.com/dotnet/coreclr/commit/
141d587472ee2fe6ab522c603c352936defeaac3
Jarret Shook [Fri, 28 Jun 2019 15:41:05 +0000 (08:41 -0700)]
Add windows arm32 native vararg excludes (dotnet/coreclr#25429)
* Add windows arm32 native vararg excludes
* Fix typo
Commit migrated from https://github.com/dotnet/coreclr/commit/
89719998adc464255cf0c45e3bd66d017cd028ec
Konstantin Baladurin [Fri, 28 Jun 2019 14:04:00 +0000 (17:04 +0300)]
arm32_ci_script.sh: Fix tizen armel build (dotnet/coreclr#25087)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8464fd3bba2d5fde5469111873c2e3981789c46c
Sung Yoon Whang [Fri, 28 Jun 2019 06:04:58 +0000 (23:04 -0700)]
Enable parsing multiple providers for LTTngConfig variable (dotnet/coreclr#25451)
* Enable parsing multiple providers for LTTngConfig variable
* Handle case where LTTngConfig==NULL
* renaming some methods
* Add comment about the format of environment variable being parsed
Commit migrated from https://github.com/dotnet/coreclr/commit/
6ab02e1cc487c64fb733fbb9d1be653337691aff
Sung Yoon Whang [Fri, 28 Jun 2019 05:47:25 +0000 (22:47 -0700)]
Add test for IncrementingEventCounter (dotnet/coreclr#25462)
* Add test for IncrementingEventCounter
* Some cleanup
* Remove unused using
Commit migrated from https://github.com/dotnet/coreclr/commit/
a9976e15e2a6182e40a15f07f3004b3079d0742e
Bruce Forstall [Fri, 28 Jun 2019 04:29:47 +0000 (21:29 -0700)]
Move coreclr-corefx pipelines into their own files (dotnet/coreclr#25465)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f094ebe85aab8b86d68118bb1f3a8940fc2d845a
Vladimir Sadov [Thu, 27 Jun 2019 23:16:07 +0000 (16:16 -0700)]
removed unnecessary WriteLine form a test (dotnet/coreclr#25460)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9ac22dd3b67c41e9fa65f7a14a4f2d32a8ec67f4
William Godbe [Thu, 27 Jun 2019 20:23:32 +0000 (13:23 -0700)]
Merge pull request dotnet/coreclr#25424 from dotnet/darc-master-
e048b5ab-4671-4e74-8671-
932e8299b22b
[master] Update dependencies from dotnet/arcade
Commit migrated from https://github.com/dotnet/coreclr/commit/
3cfe2a1fe1eb0a5223d883fcbed1ec926850a885
Jan Vorlicek [Thu, 27 Jun 2019 19:46:26 +0000 (21:46 +0200)]
Fix VersionBubbles test (dotnet/coreclr#25392)
The test was not crossgening with large version bubble enabled since
the part of the .csproj that generates part of the .sh/.bat test
running scripts was commented out. There were also bugs in the
commented out code. Also, to ensure that it works, tiered compilation
and jit minopts need to be disables to ensure that the test method
won't be re-jitted.
Commit migrated from https://github.com/dotnet/coreclr/commit/
65d75c7e2d3b8a35249ad66413f98d8c6075e699
Carol Eidt [Thu, 27 Jun 2019 18:35:14 +0000 (11:35 -0700)]
Don't reload or spill for keepAliveThis (dotnet/coreclr#25441)
Fix dotnet/coreclr#25433
Commit migrated from https://github.com/dotnet/coreclr/commit/
c6c7a00e0bf1be7cf847a2c34cb15fb8e03ea7f6
Santiago Fernandez Madero [Thu, 27 Jun 2019 17:39:13 +0000 (10:39 -0700)]
React to new compiler nullability warnings
Commit migrated from https://github.com/dotnet/coreclr/commit/
b5ccdc3d9b9c8f6020e9c458e19a8504eb845910
Vladimir Sadov [Thu, 27 Jun 2019 17:48:47 +0000 (10:48 -0700)]
Fix SIGSEGV in GC when dealing with large double[] on ARM32 (dotnet/coreclr#25403)
* Fix for dotnet/coreclr#25252
* revert to special casing 8-alignement for double[] in GC helpers for x86
Commit migrated from https://github.com/dotnet/coreclr/commit/
7a74a0b4f94b993f61f1c02ce0b8a2c6611771c3
Fadi Hanna [Thu, 27 Jun 2019 16:05:58 +0000 (09:05 -0700)]
Update linux-instructions.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
c671a7f1356b0ee25a661c0925c8ead88fb19a42
William Godbe [Thu, 27 Jun 2019 03:41:42 +0000 (20:41 -0700)]
Hardcode LKG version of ucrtbased.dll (dotnet/coreclr#25444)
* Hardcode LKG version of ucrtbased.dll
* Only use hardcoded UCRT version when search path fails
* Add missing single-quotes
Commit migrated from https://github.com/dotnet/coreclr/commit/
aa038335628e8d886e3d6bf8c4cfb48e661d4a4a
Jan Kotas [Thu, 27 Jun 2019 01:25:21 +0000 (18:25 -0700)]
Fix typo & make the code leaner (dotnet/coreclr#25442)
Enum.HasFlag generates bigger IL and depends on complex JIT optimization for a good code.
The classic bit check is strongly preferred accross CoreCLR and CoreFX.
Commit migrated from https://github.com/dotnet/coreclr/commit/
2e6510fd823cd8eb4f223199feed9a46ee6f2feb
Stephen Toub [Tue, 25 Jun 2019 02:10:45 +0000 (22:10 -0400)]
Fix ActivityTracker ES_BUILD_STANDALONE build
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
928e6c8b16e1fb3653533eedd09b446c3ad3d668
Stephen Toub [Thu, 27 Jun 2019 01:02:19 +0000 (21:02 -0400)]
Tweak nullable attribute per API review (dotnet/coreclr#25443)
Commit migrated from https://github.com/dotnet/coreclr/commit/
cc40591acb739e6cad1ca99c3a6d68af1ae21c44
Jan Kotas [Wed, 26 Jun 2019 23:47:04 +0000 (16:47 -0700)]
Update docs (dotnet/coreclr#25446)
- Delete references to Jenkins CI
- Add note on Squash&Merge
Commit migrated from https://github.com/dotnet/coreclr/commit/
1a8f735d4f397424349f1de0017314f16296f638
Andrew Au [Wed, 26 Jun 2019 22:21:39 +0000 (15:21 -0700)]
EventPipe events should only be sent to sessions that are listening to the event (dotnet/coreclr#25401)
Commit migrated from https://github.com/dotnet/coreclr/commit/
18168f63efda22f7a9e6f1d0e49c3a5604fe8f6c
Levi Broderick [Wed, 26 Jun 2019 22:05:53 +0000 (15:05 -0700)]
Fix EncoderNLS / DecoderNLS regression in reporting error index (dotnet/coreclr#25397)
Also fixes incorrect asserts in the Encoding type
Commit migrated from https://github.com/dotnet/coreclr/commit/
baf85a5bee088258f7ad0c8ec1dd5af2e35bdff5
Mikhail Aksenov [Wed, 26 Jun 2019 19:16:40 +0000 (22:16 +0300)]
[createdump] Write page offset in NT_FILE note (dotnet/coreclr#25384)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7cb9a9b96990ada2d771b525f3e4843bd07e1976
William Godbe [Wed, 26 Jun 2019 19:14:21 +0000 (12:14 -0700)]
Update branding to preview8 in master (dotnet/coreclr#25438)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5f5bae6a9905b737e7f516bb210963366f1a5de8
dotnet-maestro[bot] [Wed, 26 Jun 2019 18:53:11 +0000 (11:53 -0700)]
[master] Update dependencies from dotnet/corefx (dotnet/coreclr#25425)
* Update dependencies from https://github.com/dotnet/corefx build
20190626.2
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19326.2
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19326.2
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19326.2
* Reenable globalization tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
7f0840ee0930f869c47ae442d9a3d0edfd592eec
Santiago Fernandez Madero [Wed, 26 Jun 2019 17:54:35 +0000 (10:54 -0700)]
Tweak some annotations on EventRegistrationTokenTable<T> (dotnet/coreclr#25386)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8c4695f0e3c89a569032a533568ea1af5a55b534
Juan Hoyos [Wed, 26 Jun 2019 17:11:56 +0000 (10:11 -0700)]
Delegate inspection API in the DBI (dotnet/coreclr#25362)
* Add ICorDebugDelegateObjectValue interfaces
* Expose appropriate HR (CORDBG_E_UNSUPPORTED_DELEGATE)
* Partially DACize DelegateObject
* Add DacDbi method for delegate inspection
Commit migrated from https://github.com/dotnet/coreclr/commit/
394edf40a089ac3fae5415dba8235b89c7133319
Bruce Forstall [Wed, 26 Jun 2019 16:49:21 +0000 (09:49 -0700)]
Merge pull request dotnet/coreclr#25326 from BruceForstall/CrossPlatTestHost
Expand corefx testing in coreclr repo
Currently, corefx testing is done on Windows/x64.
Expand testing to include:
1. Linux/x64, Linux/arm, Linux/arm64, Windows/x86 platforms.
Windows/arm should be added after corefx official builds
publish tests and test manifest. Windows/arm64 should be
added after corefx tests are published, and we have
sufficient hardware.
2. All JIT stress modes that are used in normal coreclr testing.
Testing is split into 4 Azure DevOps Pipelines: coreclr-corefx,
coreclr-corefx-jitstress, coreclr-corefx-jitstressregs, and
coreclr-corefx-jitstress2-jitstressregs.
In addition, we now use the corefx meta-package Microsoft.Private.CoreFx.OOB
instead of a list of individual assemblies when constructing
the testhost.
Commit migrated from https://github.com/dotnet/coreclr/commit/
be31aaea6402390d808fa41d4cd1fa9b68f4cdd0
José Rivero [Wed, 26 Jun 2019 16:45:47 +0000 (09:45 -0700)]
Fix disabling wrong session on EventPipe::Shutdown (dotnet/coreclr#25409)
- It's safe to call EventPipe::Disable during shutdown (eventpipe being disabled)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e23ea61503b2d7b724a7976201dd9e44001622ed
Rafael Lillo [Wed, 26 Jun 2019 15:31:16 +0000 (16:31 +0100)]
Fixes link to install SOS on linux (dotnet/coreclr#25420)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff02091612aa42f79e5d3adbd608b36da9f47fdb
Ben Adams [Wed, 26 Jun 2019 12:55:14 +0000 (14:55 +0200)]
Don't show AggressiveInlining items in exception stacks (dotnet/coreclr#25408)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3063e668d045d5bc2fbdbbc99e68fac0d771190e
Tanner Gooding [Wed, 26 Jun 2019 05:36:36 +0000 (22:36 -0700)]
Reverting the ShouldRoundUp logic to not change for custom numeric format strings. (dotnet/coreclr#25400)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d9d31e6b03758abdd1621cf9da6fdd35b778a6fa
Mukul Sabharwal [Wed, 26 Jun 2019 05:00:28 +0000 (22:00 -0700)]
Fix incorrect signature of QCall (dotnet/coreclr#25419)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d53a3ee7d2e772f7fad8a96657adc606d63ea02a
Sung Yoon Whang [Wed, 26 Jun 2019 04:03:04 +0000 (21:03 -0700)]
Fix LTTng filtering for runtime providers (dotnet/coreclr#25374)
* LTTng filtering
* Fix Windows build, make IsInitialized check faster
* Cleanup/change default to no keywords/level set
* Keep the default to be the current policy - enable everything
* more cleanup
* No need to check for initialization
* Fix Windows build
Commit migrated from https://github.com/dotnet/coreclr/commit/
68f6fd0b3294894d2d39357eff895b5a6b11433f
Santiago Fernandez Madero [Wed, 26 Jun 2019 03:19:28 +0000 (20:19 -0700)]
Tell the compiler to emit nullable attributes for public API only (dotnet/coreclr#25398)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ad5f29d5e3009396c92047220255f36b33eddcf
David Mason [Wed, 26 Jun 2019 03:15:02 +0000 (20:15 -0700)]
Fix ReJIT failures (dotnet/coreclr#25377)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d344fff2f063aa242c41da6b4a5ee2ddb95e1d6a
David Mason [Wed, 26 Jun 2019 03:13:31 +0000 (20:13 -0700)]
emit rundown event for generic methods in R2R images (dotnet/coreclr#25371)
* emit rundown event for generic methods in R2R images
* fix mac build
* Code Review Feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
b497f76f9ab6a4f351bc9ec24437b0e2c5e4a1af
Bruce Forstall [Thu, 20 Jun 2019 20:05:53 +0000 (13:05 -0700)]
Expand corefx testing in coreclr repo
Currently, corefx testing is done on Windows/x64.
Expand testing to include:
1. Linux/x64, Linux/arm, Linux/arm64, Windows/x86 platforms.
Windows/arm should be added after corefx official builds
publish tests and test manifest. Windows/arm64 should be
added after corefx tests are published, and we have
sufficient hardware.
2. All JIT stress modes that are used in normal coreclr testing.
Testing is split into 4 Azure DevOps Pipelines: coreclr-corefx,
coreclr-corefx-jitstress, coreclr-corefx-jitstressregs, and
coreclr-corefx-jitstress2-jitstressregs.
In addition, we now use the corefx meta-package Microsoft.Private.CoreFx.OOB
instead of a list of individual assemblies when constructing
the testhost.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9565b16a8d348048c73572d1c4ee8ea9a7fec455
Tomáš Rylek [Wed, 26 Jun 2019 00:27:50 +0000 (17:27 -0700)]
Remove the Crossgen-specific VSD flag from R2RDump (dotnet/coreclr#25391)
Based on JanK's advice I have removed the VSD flag from R2RDump.
The flag should get never observed by the dump tool as it's just
an intermediate contract internal to the Crossgen ZAP logic.
Thanks
Tomas
Commit migrated from https://github.com/dotnet/coreclr/commit/
4d8ab39b383e5300adf9b1be451d4d46a982f586
Jan Kotas [Wed, 26 Jun 2019 00:24:40 +0000 (17:24 -0700)]
Delete DeserializationBlockedException (dotnet/coreclr#25393)
Contributes to dotnet/corefxdotnet/coreclr#36723
Commit migrated from https://github.com/dotnet/coreclr/commit/
27b7c2e673c85568374681d1a3270c60946fc3cd
Noah Falk [Tue, 25 Jun 2019 23:33:08 +0000 (16:33 -0700)]
Policheck comment adjustment
Commit migrated from https://github.com/dotnet/coreclr/commit/
74ccf988e52f083e24b5ac3bc0db0702588b2572
Stephen Toub [Tue, 25 Jun 2019 19:12:08 +0000 (15:12 -0400)]
React to compiler respecting nullable attributes on properties
Commit migrated from https://github.com/dotnet/coreclr/commit/
6fd104557b71a1639b5e105abfc21a2ad4ea73d7
Andrew Au [Tue, 25 Jun 2019 20:36:18 +0000 (13:36 -0700)]
Make sure EventPipeProvider::m_keywords is accurate after EventPipeConfiguration::Disable (dotnet/coreclr#25358)
Commit migrated from https://github.com/dotnet/coreclr/commit/
86fcae86d32d6b7117a7f7ca6b4788eb1759c867
Michal Strehovský [Tue, 25 Jun 2019 20:25:02 +0000 (22:25 +0200)]
JitBench: Run PowerShell with an execution policy (dotnet/coreclr#25259)
PowerShell is useless without this argument in default Windows configurations.
Commit migrated from https://github.com/dotnet/coreclr/commit/
277f3fa59979fd370871fbcee5ce097b66169a3d
Tarek Mahmoud Sayed [Tue, 25 Jun 2019 20:23:56 +0000 (13:23 -0700)]
Map C Locale to Invariant (dotnet/coreclr#25373)
ICU map the C locale to en-US_POSIX which has a non desired collation behavior as it doesn't support case insensitive comparison.
This change is to force mapping C locale to Invariant instead.
Commit migrated from https://github.com/dotnet/coreclr/commit/
098a4af997f5b83fe90e483361699e8168afe6dd
Tanner Gooding [Tue, 25 Jun 2019 20:23:33 +0000 (13:23 -0700)]
Updating the zapper to filter out some named intrinsics which are dependent on the ISAs supported by the target CPU. (dotnet/coreclr#25365)
Commit migrated from https://github.com/dotnet/coreclr/commit/
133e857a2800c53e0803d995964a812a13f714e1
Jan Kotas [Tue, 25 Jun 2019 20:22:23 +0000 (13:22 -0700)]
Fix StackChange value for OpCodes.Stelem (dotnet/coreclr#25382)
Fixes dotnet/corefxdotnet/coreclr#37955
Commit migrated from https://github.com/dotnet/coreclr/commit/
52f10ff250d2a7bfdd8bf98299c8005aa2956659
Egor Chesakov [Tue, 25 Jun 2019 19:59:49 +0000 (12:59 -0700)]
Add pr.yml ci.yml internal.yml pipelines to /eng/pipelines (dotnet/coreclr#25385)
Commit migrated from https://github.com/dotnet/coreclr/commit/
85235f81b5bfc6635c0a2abcfc27cb7c587c784b
John Salem [Tue, 25 Jun 2019 19:39:16 +0000 (12:39 -0700)]
Remove outputPath parameter for EventPipe IPC protocol (dotnet/coreclr#25363)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1649a0fe42501d40465f9aa41bae1ed73a621650
Jan Vorlicek [Tue, 25 Jun 2019 19:32:47 +0000 (21:32 +0200)]
Fix StackFrameIterator::IsValid check race (dotnet/coreclr#25359)
* Fix StackFrameIterator::IsValid check race
During GC stress >= 4, there could be a race when we would compute
bRedirectedPinvoke as false, but before the condition of the following
_ASSERTE is evaluated, the thread that is being walked pushes a
ResumableFrame to the explicit frames stack of that thread in the GC
marker handler.
The fix to prevent this race is to evaluate all the conditions that
formed the bRedirectedPinvoke after the conditions in the _ASSERTE.
Commit migrated from https://github.com/dotnet/coreclr/commit/
93d7c4631663b4d6547d04a94688d8cfe6074246
Omair Majid [Tue, 25 Jun 2019 00:41:13 +0000 (20:41 -0400)]
Add a note about ReadyToRun to ManagedNativeHeader
Commit migrated from https://github.com/dotnet/coreclr/commit/
3cc3c00757cf622bac20073392ac44e67849ceec
José Rivero [Tue, 25 Jun 2019 14:24:43 +0000 (07:24 -0700)]
Stop deallocating provider/events on shutdown (dotnet/coreclr#25369)
Commit migrated from https://github.com/dotnet/coreclr/commit/
bc54f6e493303884c40de0e47914ae309888eba3
Peter Sollich [Tue, 25 Jun 2019 13:55:05 +0000 (15:55 +0200)]
Brick table (dotnet/coreclr#25349)
Fix brick table logic to fix perf issue in several ASP.NET tests, remove #ifdef FFIND_OBJECT.
What I observed was that some GCs spent a lot of time in find_first_object called from find_object, which is called during stack scanning to find the containing object for interior pointers. A substantial fraction of generation 0 was being scanned, indicating that the brick table logic didn't work properly in these cases.
The root cause was the fact that the brick table entries were not being set in adjust_limit_clr if the allocation was satisfied from the free list in gen0 instead of newly allocated space. This is the case if there are pinned objects in gen0 as well.
The main fix is in adjust_limit_clr - if the allocation is satisfied from the freelist, seg is nullptr, the change is to set the bricks in this case as well if we are allocating in gen0 and the allocated piece is above a reasonable size threshold.
The bricks are not set always set during allocation - instead, when we detect an interior pointer during GC, we make the allocator set the bricks during the next GC cycles by setting gen0_must_clear_bricks. I changed the way this is handled for server GC (multiple heaps). We used to multiply the decay time by the number of heaps (gc_heap::n_heaps), but only applied it to the single heap where an interior pointer was found. Instead, I think it's better to instead set gen0_must_clear_bricks for all heaps, but leave the decay time unchanged compared to workstation GC.
Maoni suggested to remove the #ifdef FFIND_OBJECT - interior pointers are not going away, so the #ifdefs are unnecessary clutter.
Addressed code review feedback:
- add parentheses as per GC coding conventions
- use max instead of if-statement
- merge body of for-loop over all into existing for-loop
Commit migrated from https://github.com/dotnet/coreclr/commit/
899f7faa6e2b0b2a9c9a2aaa5a78909a3ae79fe3
Sung Yoon Whang [Tue, 25 Jun 2019 09:47:48 +0000 (02:47 -0700)]
Fix broken ETW events (dotnet/coreclr#25364)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3eac718c85cde9121fb5f03da58bb949914b51e1
José Rivero [Tue, 25 Jun 2019 03:31:14 +0000 (20:31 -0700)]
Make s_numberOfSessions Volatile as advertisement to other devs that the data is being used across multiple threads and a portion of that usage is lock-free (dotnet/coreclr#25366)
Commit migrated from https://github.com/dotnet/coreclr/commit/
46b22d8706a17d48de1259b3cd75a55903bd2dfd
Sung Yoon Whang [Tue, 25 Jun 2019 00:36:54 +0000 (17:36 -0700)]
Events with keyword 0 needs to be fired (dotnet/coreclr#25361)
Commit migrated from https://github.com/dotnet/coreclr/commit/
56bc2579ee99fed75681f80aaae232efe990c94b
Santiago Fernandez Madero [Tue, 25 Jun 2019 00:11:32 +0000 (19:11 -0500)]
Address last round of nullable feedback - S.Resources.ResourceManager, System.Reflection.Emit and ILGeneration (dotnet/coreclr#25318)
* Address nullable feedback for System.Resources.ResourceManager
* Address nullable feedback for System.Reflection.Emit.ILGeneration
* Address nullable feedback for System.Reflection.Emit
* PR Feedback and clean-up redundant casts
Commit migrated from https://github.com/dotnet/coreclr/commit/
560467709747d75f5897e0d9cf441c91ac4e65a8
Egor Chesakov [Tue, 25 Jun 2019 00:09:14 +0000 (17:09 -0700)]
Add /eng/pipelines/*.yml (dotnet/coreclr#25325)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d12d7c01c19534911a1110e02c3c507db7897bc4
Jarret Shook [Mon, 24 Jun 2019 23:18:14 +0000 (16:18 -0700)]
Throw platform unsupported error for windows arm32 varargs (dotnet/coreclr#25320)
* Throw unsupported platform for native vcarargs on Arm32 Windows
* Re-enable baseservices vararg test
Commit migrated from https://github.com/dotnet/coreclr/commit/
0c957b6e69639fe06add31e43bc90e0db60743ac