platform/upstream/dotnet/runtime.git
6 years agoMake curl http handler use SSL_CERT_FILE/SSL_CERT_DIR environment variables.
Tom Deseyn [Mon, 13 Nov 2017 12:07:52 +0000 (13:07 +0100)]
Make curl http handler use SSL_CERT_FILE/SSL_CERT_DIR environment variables.

Commit migrated from https://github.com/dotnet/corefx/commit/2e3f4d5ce9a138423e6f93a736da0e077ff8c3de

6 years agoAllow passing null to JsonArray.Add() (dotnet/corefx#25104)
Alexander Köplinger [Wed, 8 Nov 2017 05:50:42 +0000 (06:50 +0100)]
Allow passing null to JsonArray.Add() (dotnet/corefx#25104)

* Allow passing null to JsonArray.Add()

null is a valid value in a JSON array, so there is no reason to forbid
adding null to the array.

JsonArray.Save() already handles null values in the array.

* Fix JsonArray test

Commit migrated from https://github.com/dotnet/corefx/commit/c0718f870f12493f8359a95443362ee208aeb8a0

6 years agoImprove throughput of Enumerable.Contains for default comparer (dotnet/corefx#25097)
Stephen Toub [Wed, 8 Nov 2017 01:44:01 +0000 (20:44 -0500)]
Improve throughput of Enumerable.Contains for default comparer (dotnet/corefx#25097)

When no comparer or a null comparer is specified to Enumerable.Contains with a non-collection enumerable, `EqualityComparer<TSource>.Default` is used.  However, with recent improvements to the JIT around devirtualization and inlining of `EqualityComparer<TSource>.Default`, we can do much better for this case by having a loop dedicated to the comparer==null case.  For an enumerable of ints, this speeds up Contains in my measurements by up to 33% (which logically makes sense, as we're effectively eliminating one of three interface calls invoked per element).

Commit migrated from https://github.com/dotnet/corefx/commit/4cc7cd68cd544c8703d740ced9a31cd9b16479e3

6 years agoProductize Utf8Parser and Utf8Formatter (dotnet/corefx#25078)
Atsushi Kanamori [Tue, 7 Nov 2017 23:37:28 +0000 (15:37 -0800)]
Productize Utf8Parser and Utf8Formatter (dotnet/corefx#25078)

* Produce Utf8Parser and Utf8Formatter

Fixes https://github.com/dotnet/corefx/issues/24607

Remaining debt (cut for time):

Parsing Intgers with the "N" format

  https://github.com/dotnet/corefx/issues/24986

  Some questions to be resolved as to whether to be compatible
  (BCL doesn't care where you put the commas) or correct.

Format of floating point is still a wrapper hack

  https://github.com/dotnet/corefx/issues/25077

  The portable DoubleToNumber() code was never ported
  to C# (though the big block comment advertising it
  was).

* PR feedback.

- Move StandardFormat to System.Buffers

- Mark it readonly

- Fix spelling: "Seperator"

- Deduplicate namespace in ref .cs

* PR feedback.

- Assert that a culture-invariant ToString() on double produced ASCII characters only

- Add magic literal comments for the 4-byte compares in DateTimeOffset parsing.

- More "seperator" vs. "separator"

- Rename formatter benchmarks to be you know, "formatter"-like.

* PR feedback.

- Improve perf of long.MinValue path in TryFormat(long)

- Make TryParseDateTimeOffset compare exact casing for Rfx1123 formats ('R' and 'l')

* PR feedback.

- Lots of small items in the last round of feedback.

* PR feedback (ThrowHelper, AllocHelper, random easy stuff)

* PR feedback (StandardFormat.Parse/ToString())

Removed the extra allocations from this path
(though I still can't imagine anyone who cares
enough about perf to use this parser wanting
to use these apis) and addressed the outstanding
feedback surrounding these.

Removed the 1.2% false positive noise
from Utf8Parser code coverage. It's now at 100%.

* Replace 'buffer' text in XML docs

Commit migrated from https://github.com/dotnet/corefx/commit/d9924a578be5dab9237eaa2d324ecd66488eab96

6 years agoMake Microsoft.CSharp.RuntimeBinder.Syntax.NameManager static (dotnet/corefx#25071)
Jon Hanna [Tue, 7 Nov 2017 20:17:59 +0000 (20:17 +0000)]
Make Microsoft.CSharp.RuntimeBinder.Syntax.NameManager static (dotnet/corefx#25071)

State is only ever cleared in rare ResetBindException case, and will
then fill with same contents as before, so it does not need to reset.

Making static avoids waste and delays in the rare case, and reduces
passing around of per-context singleton in the common case, reducing
coupling.

Commit migrated from https://github.com/dotnet/corefx/commit/5fd4bcab041abbd7097e12e668cb5837c3353670

6 years agoMerge pull request dotnet/corefx#25092 from brianrob/missing_define
Vance Morrison [Tue, 7 Nov 2017 19:07:39 +0000 (11:07 -0800)]
Merge pull request dotnet/corefx#25092 from brianrob/missing_define

Add PLATFORM_WINDOWS define for MDT EventSource package

Commit migrated from https://github.com/dotnet/corefx/commit/dc4648c6cf402338be1286d6c6d3b1f33e97870b

6 years agoMerge pull request dotnet/corefx#25086 from terrajobst/api-guidelines
Immo Landwerth [Tue, 7 Nov 2017 17:54:01 +0000 (09:54 -0800)]
Merge pull request dotnet/corefx#25086 from terrajobst/api-guidelines

Add API Guidlines

Commit migrated from https://github.com/dotnet/corefx/commit/e50ddc30deca8fa7434fcc32991354d5a38b5efd

6 years agoUpdate CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-25906-02, beta-25907...
dotnet-maestro-bot [Tue, 7 Nov 2017 14:09:40 +0000 (06:09 -0800)]
Update CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-25906-02, beta-25907-00, beta-25907-00, respectively (dotnet/corefx#25095)

Commit migrated from https://github.com/dotnet/corefx/commit/4c74936578de44763ab2d2b9a3fca2ca7077cccb

6 years agoRetries,Backing off and A very large delay (dotnet/corefx#25087)
Anirudh Agnihotry [Tue, 7 Nov 2017 04:11:08 +0000 (20:11 -0800)]
Retries,Backing off and A very large delay (dotnet/corefx#25087)

* more retries and backing off

* 30 sec delay

* Tries changes to 50 and corrected infinite loop

* Added stopwatch

* writing if delay greater than 5 secs

* logging seconds

Commit migrated from https://github.com/dotnet/corefx/commit/ea39ed02605c52876d539275af367cd6073b581d

6 years agoAddress code review feedback
Immo Landwerth [Tue, 7 Nov 2017 03:12:38 +0000 (19:12 -0800)]
Address code review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/b1aba4690d99f829bb04adf2ceaf03fb94ae7318

6 years agoReset Syndication src\ (dotnet/corefx#25059)
Shin Mao [Tue, 7 Nov 2017 01:20:20 +0000 (17:20 -0800)]
Reset Syndication src\ (dotnet/corefx#25059)

* Reset Syndication \src

* Marked a test with ActiveIssue.

* CodeFormatted Syndication src\.

* Removed old header.

* Minor changes.

* Remove unused string resources

* Second round of code formatting

Commit migrated from https://github.com/dotnet/corefx/commit/5197ece2f6f492f011b300eaf4616faa4f96dca8

6 years agoAdd PLATFORM_WINDOWS define for MDT EventSource package.
Brian Robbins [Tue, 7 Nov 2017 00:58:02 +0000 (16:58 -0800)]
Add PLATFORM_WINDOWS define for MDT EventSource package.

Commit migrated from https://github.com/dotnet/corefx/commit/9a8de436b0145f7499542a105d0469efe6959729

6 years agoUpdate CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-25906-03, previ...
dotnet-maestro-bot [Mon, 6 Nov 2017 23:43:58 +0000 (15:43 -0800)]
Update CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-25906-03, preview1-25905-03, beta-25906-00, beta-25906-00, respectively (dotnet/corefx#25068)

Commit migrated from https://github.com/dotnet/corefx/commit/48532ae994e704119b701d98aa24c4135cf9c4d2

6 years agoSupport Reference Assemblies in SGEN. (dotnet/corefx#24491)
Huangli Wu [Mon, 6 Nov 2017 22:37:16 +0000 (14:37 -0800)]
Support Reference Assemblies in SGEN. (dotnet/corefx#24491)

* Support Reference Assemblies in SGEN.

* Several fixes based on Shin's feedback.

* minor change.

* Publish serializer for reference assemblies.

* Add publish

* correct the assembly name to be copied

* small format and naming change.

* Add a space.

* Rename some variables.

* Rename some variables.

Commit migrated from https://github.com/dotnet/corefx/commit/f7ed59d0b7812637c1a27b70d26b27e841a187b5

6 years agoAdd guidance for System.Memory & friends
Immo Landwerth [Mon, 6 Nov 2017 19:56:44 +0000 (11:56 -0800)]
Add guidance for System.Memory & friends

Commit migrated from https://github.com/dotnet/corefx/commit/106fa73c05efd7cb0820b39f3b2ff08d5422a24d

6 years agoAdd document explaining API guidelines process
Immo Landwerth [Mon, 6 Nov 2017 19:56:22 +0000 (11:56 -0800)]
Add document explaining API guidelines process

Commit migrated from https://github.com/dotnet/corefx/commit/e14ad34dc9de4fc1a4c7d8febff38b78a221eddd

6 years agoPort System.Runtime.Caching to .NET Core (dotnet/corefx#24756)
KKhurin [Mon, 6 Nov 2017 17:57:08 +0000 (09:57 -0800)]
Port System.Runtime.Caching to .NET Core (dotnet/corefx#24756)

* initial System.Runtime.Caching project check in

* Initial check in of System.Runtime.Cachine code
Including updated project file with missing dependency on System.Private.CoreLib

* S.R.Caching src and ref

- addressed the PR review commends
- added ref cs and csproj files

* Fix NETFX build

* Fix configs

* Adding resources
and addressing PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/2e1f9fc09800515a41e03431470a3c04133c814b

6 years agoFix ConfigurationGroup property in symbol publish
Wes Haggard [Mon, 6 Nov 2017 03:10:06 +0000 (19:10 -0800)]
Fix ConfigurationGroup property in symbol publish

Commit migrated from https://github.com/dotnet/corefx/commit/63f536f9f70fcab7bb5bf0fdd0088558481fcd8d

6 years agoCorrect source field is used to get column ordinal. (dotnet/corefx#24655)
Stano Peťko [Sun, 5 Nov 2017 19:43:15 +0000 (20:43 +0100)]
Correct source field is used to get column ordinal. (dotnet/corefx#24655)

Commit migrated from https://github.com/dotnet/corefx/commit/552ef49e5fc61fbfa17ccc8c723e9b468668914d

6 years agoBetter exception when JScript.NET is targeted (dotnet/corefx#25045)
Paulo Janotti [Sun, 5 Nov 2017 00:06:22 +0000 (17:06 -0700)]
Better exception when JScript.NET is targeted (dotnet/corefx#25045)

* Better exception when JScript.NET is targeted

Generates the same exception for the other languages that are not
supported: ArgumentOutOfRangeException.

No tests are being added for these exceptions because failure to
generate the file keeps the file locked, so that would leave files with
size 0 on the test box.

* Add test to validate exceptions

Commit migrated from https://github.com/dotnet/corefx/commit/a9cf418b9a2517b559e0ce06507b7935fbc239bb

6 years agoSystem.Web.HttpUtility Refactoring (dotnet/corefx#23921)
Jon Hanna [Sat, 4 Nov 2017 22:20:58 +0000 (22:20 +0000)]
System.Web.HttpUtility Refactoring (dotnet/corefx#23921)

* Use named arguments instead of comments.

* Remove ignoreAscii parameter from UrlEncodeUnicode method

Only ever false.

* Remove alwasyCreateNewReturnValue from UrlEncodeNonAscii

Always false.

* Remove ValidateUrlEncodingParameters check from UrlEncodeNonAscii

Cases covered can't happen as bytes comes from Encoding.GetBytes call and sizes are based on that.

* Remove string.IsnullOrEmpty and e == null branches from UrlEncodeNonAscii

Guaranteed by only caller not to be hit. Replace with assertions.

* Remove bytes == null branch from UrlDecodeToBytes

Exists in a bytes != null branch, so never true.

* Remove sb.Length test from HttpQSCollection.ToString()

In a path for which there will always be at least one value added, so
always true, so just use offset & length overload of ToString.

* Remove check that authorityIndex != -1.

Cannot be false in the branch it is in.

* Change JavaScriptStringEncode call to avoid unnecessary branch.

Can just call HttpEncoder.JavaScriptStringEncode directly.

* Move switch for determining js escape into first CharRequiresJavaScriptEncoding branch.

Removes need for double-check.

* Add test for JavaScriptStringEncode with false for addDoubleQuotes

* Always have braces in if

* Remove redundant casts.

* Use explicit types.

* Use expression-body syntax

* Use PascalCase for constant.

* Revert "Remove check that authorityIndex != -1."

This reverts commit dotnet/corefx@3b76035d61d0a5682c5172fb274fe4c5f673f554.

* Test handling of HttpUtility.UrlPathEncode with bidi character in host

Commit migrated from https://github.com/dotnet/corefx/commit/d19a246dfd5c638b6f8f2e66cef2a71e968ab0da

6 years agoChange Compatibility package version to 2.0.0 (dotnet/corefx#25051)
Santiago Fernandez Madero [Sat, 4 Nov 2017 20:06:29 +0000 (13:06 -0700)]
Change Compatibility package version to 2.0.0 (dotnet/corefx#25051)

* Change Compatibility package version to 2.0.0

* Edit compatibility packages description

Commit migrated from https://github.com/dotnet/corefx/commit/c38c52f2c93980e00dde4411d34e48c867c784f1

6 years agoCleanup Windows 10 version detection (dotnet/corefx#25052)
David Shulman [Sat, 4 Nov 2017 18:09:38 +0000 (11:09 -0700)]
Cleanup Windows 10 version detection (dotnet/corefx#25052)

* Cleanup Windows 10 version detection

Windows 10 Version 1709 ("Fall Creators Update") has been released. This
PR cleans up the version detection to use the latest RTM build numbers
and removes obsolete InsiderPreview detection for those tests.

Also, removed ActiveIssue for tests that are now fixed due to Windows 10
fixes.

Fixes dotnet/corefx#22187

* Addressed feedback

Commit migrated from https://github.com/dotnet/corefx/commit/ac410223aa763a0f67880815057ee1bfe0f4cb6e

6 years agoEventLog GetEntry Exception (dotnet/corefx#25048)
Anirudh Agnihotry [Sat, 4 Nov 2017 03:17:44 +0000 (20:17 -0700)]
EventLog GetEntry Exception (dotnet/corefx#25048)

* Latency between write entry and getting entries

* commenting

* increased retries for slower system

* win32 exception at getting count in win7

* redistribution of functions

* item not added to list but count incremented

* On all Platform changes

* flag removed and failure after 20 tries

* Set event Flag event handler

* Argument exception moved to helpers

Commit migrated from https://github.com/dotnet/corefx/commit/b82d38be3ca7462f81ed76449ecc8b0eea4f8772

6 years agorename PlatformDetection.OSXKernelVersion to PlatformDetection.OSXVersion (dotnet...
Krzysztof Wicher [Sat, 4 Nov 2017 00:33:08 +0000 (17:33 -0700)]
rename PlatformDetection.OSXKernelVersion to PlatformDetection.OSXVersion (dotnet/corefx#25057)

Commit migrated from https://github.com/dotnet/corefx/commit/a387baf8dd0b5b53aec62c7ce73d6f9f44d371bd

6 years agoReadOnlyMemory: Fix copy/paste mistake in doc comment (dotnet/corefx#25055)
Justin Van Patten [Sat, 4 Nov 2017 00:07:04 +0000 (17:07 -0700)]
ReadOnlyMemory: Fix copy/paste mistake in doc comment (dotnet/corefx#25055)

Commit migrated from https://github.com/dotnet/corefx/commit/58518df9912b68f9f22ebf2e90941bfd0126800c

6 years agoadd xunit trait to xslt tests depending on xsltc.exe (dotnet/corefx#25054)
Krzysztof Wicher [Fri, 3 Nov 2017 23:04:30 +0000 (16:04 -0700)]
add xunit trait to xslt tests depending on xsltc.exe (dotnet/corefx#25054)

Commit migrated from https://github.com/dotnet/corefx/commit/0c1dbd7f8f44fc9c6227fa0e909efafb60606d12

6 years agoPass working directory to blob feed publish
Wes Haggard [Fri, 3 Nov 2017 22:21:08 +0000 (15:21 -0700)]
Pass working directory to blob feed publish

Commit migrated from https://github.com/dotnet/corefx/commit/d190e52309a3d435d33a7efc47cfd43fff5a98d6

6 years agoUse distro detection from Microsoft.DotNet.PlatformAbstractions (dotnet/corefx#24531)
Krzysztof Wicher [Fri, 3 Nov 2017 21:30:47 +0000 (14:30 -0700)]
Use distro detection from Microsoft.DotNet.PlatformAbstractions (dotnet/corefx#24531)

Commit migrated from https://github.com/dotnet/corefx/commit/4bf90198c5e7710ea67b7c1b467e859ec8bb78e5

6 years agoMerge pull request dotnet/corefx#24857 from Priya91/cancellation
Lakshmi Priya Sekar [Fri, 3 Nov 2017 21:05:15 +0000 (14:05 -0700)]
Merge pull request dotnet/corefx#24857 from Priya91/cancellation

Implement cancellation token for SslStream new AuthenticateAs*Async methods

Commit migrated from https://github.com/dotnet/corefx/commit/7cbb09bb43a42e80f3849215c7c4ed61961b17f2

6 years agoDeleted dead code from System.Security.Cryptography.Csp. (dotnet/corefx#25000)
Stano Peťko [Fri, 3 Nov 2017 19:53:31 +0000 (20:53 +0100)]
Deleted dead code from System.Security.Cryptography.Csp. (dotnet/corefx#25000)

Commit migrated from https://github.com/dotnet/corefx/commit/55773858a5363a1bc49bb48fe170131f3bc0d1cb

6 years agoUpdate BuildTools to prerelease-02203-01 (dotnet/corefx#25049)
dotnet-maestro-bot [Fri, 3 Nov 2017 19:51:16 +0000 (12:51 -0700)]
Update BuildTools to prerelease-02203-01 (dotnet/corefx#25049)

Commit migrated from https://github.com/dotnet/corefx/commit/341c928b62d04d2ded429aa4a2bb34965a869cab

6 years agoMerge pull request dotnet/corefx#25035 from stephentoub/channel_fixes
Stephen Toub [Fri, 3 Nov 2017 18:58:37 +0000 (14:58 -0400)]
Merge pull request dotnet/corefx#25035 from stephentoub/channel_fixes

 Add back ChannelReader.ReadAsync to System.Threading.Channels

Commit migrated from https://github.com/dotnet/corefx/commit/4f6d9f3e458fda665d5980cb3939c064b5aa789f

6 years agoAdd Microsoft.Windows.Compatibility.Shims package and rename compat pack (dotnet...
Santiago Fernandez Madero [Fri, 3 Nov 2017 18:42:47 +0000 (11:42 -0700)]
Add Microsoft.Windows.Compatibility.Shims package and rename compat pack (dotnet/corefx#24967)

* Add Microsoft.NETFramework.Compatibility.Shims package and fix package versions in Compat pack

* PR Feedback

* Add System.Management and System.DirectoryServices packages into compat pack

* Add netstandard 2.0 placeholder file and depend on S.S.Cryptography.Cng stable package

* Rename compat and shims packages, also update descriptions and PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/1100d8faa87656f447bfe8944686d13e7b3af5e9

6 years agoStabilize configurations for compat pack (dotnet/corefx#25017)
Santiago Fernandez Madero [Fri, 3 Nov 2017 18:41:04 +0000 (11:41 -0700)]
Stabilize configurations for compat pack (dotnet/corefx#25017)

* Stabilize configurations for Microsoft.Win32.Registry

* Stabilize configurations for System.IO.FileSystem.AccessControl

* Stabilize configurations for System.IO.Packaging

* Stabilize configurations for System.Security.AccessControl

* Stabilize configurations for System.Principal.Windows

* Stabilize configurations for System.ServiceProcess.ServiceController

* Stabilize configurations for System.Text.Encoding.CodePages

* Some extra cleanup

* Fix CI failures

Commit migrated from https://github.com/dotnet/corefx/commit/39cdb933600c5dcdec1157b8d5755ec37950e2e0

6 years agoSwitch from batch file to command line task VSTS build steps
Wes Haggard [Fri, 3 Nov 2017 18:32:24 +0000 (11:32 -0700)]
Switch from batch file to command line task VSTS build steps

This should fix the issue with msbuild not found on the path

Commit migrated from https://github.com/dotnet/corefx/commit/c9e61c9b58c3374508ec3a791dfe6c53a329edeb

6 years agoFix flaky test.
Lakshmi Priya Sekar [Fri, 3 Nov 2017 18:20:06 +0000 (11:20 -0700)]
Fix flaky test.

Commit migrated from https://github.com/dotnet/corefx/commit/b2e9cd1b8842c007d546c7e42317ec5a089a8d36

6 years agoUpdate issue-guide.md
Dan Moseley [Fri, 3 Nov 2017 16:47:29 +0000 (09:47 -0700)]
Update issue-guide.md

Commit migrated from https://github.com/dotnet/corefx/commit/3ccd76f297b4ca3bb1bd5ee8f5a4d98949c7dbb8

6 years agoMerge pull request dotnet/corefx#24234 from tijoytom/master
Tijoy Tom [Fri, 3 Nov 2017 16:46:43 +0000 (09:46 -0700)]
Merge pull request dotnet/corefx#24234 from tijoytom/master

Adding UTF8 Marshalling API tests

Commit migrated from https://github.com/dotnet/corefx/commit/46ffc7e7fdd0f8293c1b84fe3a5e7b2a4bec8a43

6 years agoUpdates to issue guide (dotnet/corefx#25044)
Dan Moseley [Fri, 3 Nov 2017 16:45:04 +0000 (09:45 -0700)]
Updates to issue guide (dotnet/corefx#25044)

Commit migrated from https://github.com/dotnet/corefx/commit/6f77b61879ebee664c0855301cef1e00c52866a0

6 years agoSwitch to new PB_SkipTestBuild property to disable the test build
Wes Haggard [Fri, 3 Nov 2017 16:05:03 +0000 (09:05 -0700)]
Switch to new PB_SkipTestBuild property to disable the test build

We need to always turn off tests for for some legs like alpine so
but setting the PB_SkipTests property in pipeline file doesn't
seem to correctly override the global value of this property. Perhaps
that is a bug in pipebuild but for now just using a different property
name to make forward progress.

Commit migrated from https://github.com/dotnet/corefx/commit/4b45eb323d9531a0043ef5796c58a5be808c924d

6 years agoFix UpdateBlobs regression, reenabling ValueTuple tests on Core, add Dictionary<strin...
Viktor Hofer [Fri, 3 Nov 2017 15:41:57 +0000 (16:41 +0100)]
Fix UpdateBlobs regression, reenabling ValueTuple tests on Core, add Dictionary<string,string> serialization test case (dotnet/corefx#24962)

* Fix UpdateBlobs regression, reenabling ValueTuple tests on Core

* Add Dictionary<string,string> serialization test case

Commit migrated from https://github.com/dotnet/corefx/commit/b2dcf2c4c392b228ce7a35a7d1873eab0846ab9e

6 years agoUpdate ref assemblies with readonly changes
Stephen Toub [Thu, 2 Nov 2017 15:02:12 +0000 (11:02 -0400)]
Update ref assemblies with readonly changes

Commit migrated from https://github.com/dotnet/corefx/commit/45b724f6b6391910edea8a70f3f22a4a7996696d

6 years agoMark applicable structs as readonly
Stephen Toub [Thu, 2 Nov 2017 15:11:12 +0000 (11:11 -0400)]
Mark applicable structs as readonly

Commit migrated from https://github.com/dotnet/corefx/commit/54e889a7c71bf22f9f1ef244a9d040fee64c74d5

6 years agoMark applicable structs as readonly (dotnet/coreclrdotnet/corefx#14789)
Stephen Toub [Fri, 3 Nov 2017 11:45:14 +0000 (07:45 -0400)]
Mark applicable structs as readonly (dotnet/coreclrdotnet/corefx#14789)

In a few cases (e.g. nullable), I added readonly to fields in order to allow readonly on the type.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/2765e11812f0ffb614959dc09cbd7a5f469da479

6 years agoUpdate CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-25902-08, previ...
dotnet-maestro-bot [Fri, 3 Nov 2017 11:40:11 +0000 (04:40 -0700)]
Update CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-25902-08, preview1-25902-04, beta-25903-00, beta-25903-00, respectively (dotnet/corefx#25030)

Commit migrated from https://github.com/dotnet/corefx/commit/2fd69b9e967a64fedb09749325a4ed0b48d4c044

6 years agoAdd System.Threading.Channels perf tests
Stephen Toub [Thu, 2 Nov 2017 23:05:51 +0000 (19:05 -0400)]
Add System.Threading.Channels perf tests

Core perf tests.  More can be added later.

Commit migrated from https://github.com/dotnet/corefx/commit/0582579451b6d6c5701f9fa2a407b060a03e8925

6 years agoAdd back ChannelReader.ReadAsync
Stephen Toub [Thu, 2 Nov 2017 19:53:36 +0000 (15:53 -0400)]
Add back ChannelReader.ReadAsync

In the API review, we'd said to remove ReadAsync if we could, as we didn't like that it encouraged exceptions as control flow, due to exceptions getting thrown when attempting to read from a completed channel.

However, removing it is problematic for a few reasons:
- While for most channels its behavior can be achieved external to the channels on top of TryRead and WaitToReadAsync, that's not the case for UnbufferedChannel.  UnbufferedChannel.ReadAsync provides unique functionality that can only be achieved from within the implementation, as reads need to exist concurrently with writes in order for them to pair up.
- Channels in go don't have the notion of completion, which means the ReadAsync equivalent is very common there.  Any code written in that style and trying to port to this will expect a similar function but will instead be forced to emulate it with WaitToReadAsync/TryRead.

As such, I'm putting it back as a base virtual method and an override just on UnbufferedChannel's implementation.

Commit migrated from https://github.com/dotnet/corefx/commit/3c73f4621fe891aa25e97be2bbf772d7a747d263

6 years agoFix CookieContainer to return all relevant cookies
James Pelcis [Fri, 3 Nov 2017 03:34:05 +0000 (22:34 -0500)]
Fix CookieContainer to return all relevant cookies

Fixes dotnet/corefx#24368

Commit migrated from https://github.com/dotnet/corefx/commit/2427e05827c6e6f1eeaa77b01a3596f9a03582ff

6 years agoMerge pull request dotnet/corefx#25006 from weshaggard/UpdateBuildDefinitions
Wes Haggard [Fri, 3 Nov 2017 02:21:12 +0000 (19:21 -0700)]
Merge pull request dotnet/corefx#25006 from weshaggard/UpdateBuildDefinitions

Update build definitions

Commit migrated from https://github.com/dotnet/corefx/commit/e71a2557bfc42f0c8e8612eb039e3dc227812dbd

6 years agoChange TaskCanceledException to OperationCancelledException.
Lakshmi Priya Sekar [Fri, 3 Nov 2017 00:48:57 +0000 (17:48 -0700)]
Change TaskCanceledException to OperationCancelledException.

Commit migrated from https://github.com/dotnet/corefx/commit/cbc0b590e402f9ff95a752c5d5d170faebb9c8d4

6 years agoMerge pull request dotnet/corefx#25031 from karajas/removeFlat
Wes Haggard [Fri, 3 Nov 2017 00:40:17 +0000 (17:40 -0700)]
Merge pull request dotnet/corefx#25031 from karajas/removeFlat

Remove PublishFlatContainer From PushToBlobFeed

Commit migrated from https://github.com/dotnet/corefx/commit/6f8305e0c43f40b5bdd4b404ad93ffc97f0d5663

6 years agoRemove PublishFlatContainer From PushToBlobFeed
Karthik Rajasekaran [Thu, 2 Nov 2017 23:22:32 +0000 (16:22 -0700)]
Remove PublishFlatContainer From PushToBlobFeed

Commit migrated from https://github.com/dotnet/corefx/commit/3f776a874baa592851c58d80053c1e27a04301f7

6 years agoallow xml tests run tests with /t:BuildAndTest (dotnet/corefx#25028)
Krzysztof Wicher [Thu, 2 Nov 2017 23:09:06 +0000 (16:09 -0700)]
allow xml tests run tests with /t:BuildAndTest (dotnet/corefx#25028)

Commit migrated from https://github.com/dotnet/corefx/commit/023ffe9610133f633650872452bcb49e22206326

6 years agoClean UdpReceiveResult (dotnet/corefx#25003)
Raul Hidalgo Caballero [Thu, 2 Nov 2017 23:00:28 +0000 (00:00 +0100)]
Clean UdpReceiveResult (dotnet/corefx#25003)

Simplificate UdpReceiveResult

* Added XML Docs

Commit migrated from https://github.com/dotnet/corefx/commit/76fa6f1cf99db135bbb0d4e83b2fb7fd0715c022

6 years agoDeleted dead code from System.Security.Cryptography.Cng. (dotnet/corefx#24996)
Stano Peťko [Thu, 2 Nov 2017 22:40:52 +0000 (23:40 +0100)]
Deleted dead code from System.Security.Cryptography.Cng. (dotnet/corefx#24996)

Commit migrated from https://github.com/dotnet/corefx/commit/2803bae61a4d256d8b498141527cdd4bb7ccab83

6 years agoPass PB_RestoreSource as a package source for our builds
Wes Haggard [Wed, 1 Nov 2017 23:29:03 +0000 (16:29 -0700)]
Pass PB_RestoreSource as a package source for our builds

Passed it in via DotNetRestoreSources instead of OverridePackageSource
because this isn't an override but instead an additional source

Commit migrated from https://github.com/dotnet/corefx/commit/8b19633c0d4ffa7a13faaf94f52966291ad70249

6 years agoSupport PB_SignType with public instead of oss potential values
Wes Haggard [Wed, 1 Nov 2017 23:21:58 +0000 (16:21 -0700)]
Support PB_SignType with public instead of oss potential values

Commit migrated from https://github.com/dotnet/corefx/commit/1d3bea669d00feeb3138e8ac24484717b2e5bb81

6 years agoSupport PB_SkipTests property in our build definitions
Wes Haggard [Wed, 1 Nov 2017 23:06:10 +0000 (16:06 -0700)]
Support PB_SkipTests property in our build definitions

Commit migrated from https://github.com/dotnet/corefx/commit/2982be20bb44a6fa530355f2368e2b3436857cbf

6 years agoUse new publish build variables
Wes Haggard [Wed, 1 Nov 2017 22:21:57 +0000 (15:21 -0700)]
Use new publish build variables

PB_PublishType
PB_PublishBlobFeedUrl
PB_PublishBlobFeedKey

Commit migrated from https://github.com/dotnet/corefx/commit/b5ad6604d1db66d603e77a930cd234da90c2bacf

6 years agoFix incorrect HAVE_OPENSSL_ALPN testing (dotnet/corefx#25014)
Jan Vorlicek [Thu, 2 Nov 2017 21:09:36 +0000 (14:09 -0700)]
Fix incorrect HAVE_OPENSSL_ALPN testing (dotnet/corefx#25014)

This define is incorrectly tested using #ifdef instead of #if, so build
on e.g. Ubuntu 14.04 where this symbol is set to zero fails.

Commit migrated from https://github.com/dotnet/corefx/commit/cfef66e228c6f96caa23fb8f2652f694f2ae250e

6 years agoMerge pull request dotnet/corefx#25007 from dotnet-maestro-bot/master-UpdateDependencies
Wes Haggard [Thu, 2 Nov 2017 19:04:27 +0000 (12:04 -0700)]
Merge pull request dotnet/corefx#25007 from dotnet-maestro-bot/master-UpdateDependencies

Update BuildTools, CoreClr to prerelease-02202-02, preview1-25901-06, respectively (master)

Commit migrated from https://github.com/dotnet/corefx/commit/6f074e00fe5d5d2dd2287ac24bc3dcf8d6d88456

6 years agoReact to SignType moving from oss to public
Wes Haggard [Thu, 2 Nov 2017 18:01:46 +0000 (11:01 -0700)]
React to SignType moving from oss to public

Commit migrated from https://github.com/dotnet/corefx/commit/75bbd3b94f1f212e7ef353cd8436ca71cf352f2b

6 years agoUpdate BuildTools, CoreClr to prerelease-02202-02, preview1-25901-06, respectively
dotnet-maestro-bot [Thu, 2 Nov 2017 17:14:25 +0000 (10:14 -0700)]
Update BuildTools, CoreClr to prerelease-02202-02, preview1-25901-06, respectively

Commit migrated from https://github.com/dotnet/corefx/commit/3c9ee7ede0850d431aab2bbcb37b4101f0d3cf89

6 years agoFix a few WebSocketHandle.Managed issues (dotnet/corefx#25010)
Stephen Toub [Thu, 2 Nov 2017 14:35:38 +0000 (10:35 -0400)]
Fix a few WebSocketHandle.Managed issues (dotnet/corefx#25010)

- At least until socket send/receives respect cancellation, we need to poll for cancellation after the handler's SendAsync completes.
- We're unnecessarily allocating another CTS if no external cancellation was provided.
- We're not disposing of the response object in the case of an error after SendAsync completes.

Commit migrated from https://github.com/dotnet/corefx/commit/baf2128a7cdf4a7638be1e86a6fc18651f3945d3

6 years agoFix concurrency in MultipleWaitingClients_ServerServesOneAtATime test (dotnet/corefx...
Stephen Toub [Thu, 2 Nov 2017 03:43:42 +0000 (23:43 -0400)]
Fix concurrency in MultipleWaitingClients_ServerServesOneAtATime test (dotnet/corefx#25004)

The Unix implementation works by having clients connect to the server socket, and connects are satisifed not when an accept happens but when there's room in the listen backlog.  Thus multiple clients might end up having their connects immediately satisfied, and we might try to then read/write the wrong client, and end up deadlocking.

Commit migrated from https://github.com/dotnet/corefx/commit/9495387c0faa0ab252f36049d148fbb50677721d

6 years agoAdd a simple way to test wmi remote (dotnet/corefx#24989)
Paulo Janotti [Thu, 2 Nov 2017 03:36:09 +0000 (20:36 -0700)]
Add a simple way to test wmi remote (dotnet/corefx#24989)

Simply using an environment variable, WmiTestTargetMachine, to specify
the target machine. When running the tests ensure that the account
running the tests has rights on the target machine.

There is not much value in adding similar scope to other tests since
regarding remote connectivity they actually end up hitting the same
code, so keep this just for some key tests.

Commit migrated from https://github.com/dotnet/corefx/commit/4e16caee7a21f17dd646e65db4e1d2765118c7bc

6 years agoMerge pull request dotnet/corefx#25001 from dotnet/tfUrlUpdate
JC Aguilera [Wed, 1 Nov 2017 22:41:27 +0000 (15:41 -0700)]
Merge pull request dotnet/corefx#25001 from dotnet/tfUrlUpdate

TransportFeed URL update

Commit migrated from https://github.com/dotnet/corefx/commit/44e7a3e79a399aad60427fcc2c0d16b7d3b277e0

6 years agoMerge pull request dotnet/corefx#24999 from weshaggard/SnapToStandard20
Wes Haggard [Wed, 1 Nov 2017 21:42:26 +0000 (14:42 -0700)]
Merge pull request dotnet/corefx#24999 from weshaggard/SnapToStandard20

Fix standard dependency to 2.0.0 release branch

Commit migrated from https://github.com/dotnet/corefx/commit/a3b906bcc338151954ec7e3759129526feb426cf

6 years agoMerge pull request dotnet/corefx#24883 from Drawaes/ALPN-Linux
Lakshmi Priya Sekar [Wed, 1 Nov 2017 21:37:58 +0000 (14:37 -0700)]
Merge pull request dotnet/corefx#24883 from Drawaes/ALPN-Linux

Fix matching algo

Commit migrated from https://github.com/dotnet/corefx/commit/c9c292c28943c84d82afe1d263017be7dbed2b28

6 years agoFix exceptions on failing alpn protocol mismatch test.
Lakshmi Priya Sekar [Wed, 25 Oct 2017 02:04:32 +0000 (19:04 -0700)]
Fix exceptions on failing alpn protocol mismatch test.

Commit migrated from https://github.com/dotnet/corefx/commit/d5e72b11d5bba0ea12b602059ce5011ef0c3e197

6 years agoImplement cancellation policy for sslstream.
Lakshmi Priya Sekar [Tue, 24 Oct 2017 22:34:44 +0000 (15:34 -0700)]
Implement cancellation policy for sslstream.

Commit migrated from https://github.com/dotnet/corefx/commit/f2c8a559f52fdc3bd771d39744f86c6e42844c27

6 years agoFix standard dependency to 2.0.0 release branch
Wes Haggard [Wed, 1 Nov 2017 15:56:04 +0000 (08:56 -0700)]
Fix standard dependency to 2.0.0 release branch

Commit migrated from https://github.com/dotnet/corefx/commit/a8aed31b440d5308ebdf5dec1f56f2650a07be82

6 years agoUpdate CoreClr, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25901-01, beta...
dotnet-maestro-bot [Wed, 1 Nov 2017 15:49:48 +0000 (08:49 -0700)]
Update CoreClr, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25901-01, beta-25831-01, beta-25831-01, preview1-25901-01, respectively (dotnet/corefx#24991)

Commit migrated from https://github.com/dotnet/corefx/commit/2d4a639cfd1fd908d0e3051a5f0c51c6193e277a

6 years agoDisable a few new pipes tests that may be causing a CI hang on OSX (dotnet/corefx...
Stephen Toub [Wed, 1 Nov 2017 15:47:40 +0000 (11:47 -0400)]
Disable a few new pipes tests that may be causing a CI hang on OSX (dotnet/corefx#24995)

Commit migrated from https://github.com/dotnet/corefx/commit/0a16ff4757eb478a40bd96618ae26332bd95e09d

6 years agoAdd -g flag to generate debuginfo on unix platforms (dotnet/corefx#24979)
Omair Majid [Wed, 1 Nov 2017 04:13:41 +0000 (00:13 -0400)]
Add -g flag to generate debuginfo on unix platforms (dotnet/corefx#24979)

The windows build already includes /Zi /Zl as part of commit 920fd2f3
(PR dotnet/corefx#7840). It looks like it was simply missed on Unix.

This change also makes the native debug information closer to what
CoreCLR does on all platforms. See
https://github.com/dotnet/coreclr/pull/3445 for more information.

This is also needed for the end-to-end debuginfo generation as part of
source-build. See https://github.com/dotnet/source-build/issues/267

Commit migrated from https://github.com/dotnet/corefx/commit/efe76524067c7948e2ccdbf735c5419a7554ddc3

6 years agoFind native dll via registry (dotnet/corefx#24983)
Paulo Janotti [Wed, 1 Nov 2017 03:28:24 +0000 (20:28 -0700)]
Find native dll via registry (dotnet/corefx#24983)

* Find native dll via registry

Perform a best effort to throw PNSE for Windows versions without the
full framework.

* Using Dan's message for PNSE

Commit migrated from https://github.com/dotnet/corefx/commit/362afc07aa7ed9b0cf2be9178035b6bee46fd93b

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Stand...
dotnet-maestro-bot [Wed, 1 Nov 2017 03:15:46 +0000 (20:15 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to prerelease-02201-02, preview1-25831-09, preview1-25831-01, preview1-25830-04, beta-25831-00, beta-25831-00, preview1-25831-01, respectively (dotnet/corefx#24964)

Commit migrated from https://github.com/dotnet/corefx/commit/3b8cfbf49c8dc9c1b2671fab6f39a27e7a595077

6 years agoMerge pull request dotnet/corefx#24798 from stephentoub/namedpipes_lifetime
Stephen Toub [Wed, 1 Nov 2017 02:42:20 +0000 (22:42 -0400)]
Merge pull request dotnet/corefx#24798 from stephentoub/namedpipes_lifetime

Change lifetime of Socket used in NamedPipeServerStream on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/b5d0c3277dc384a23fee2e57a0b5c232c99dbd88

6 years agoEventLog tests enabled on windows 7 (dotnet/corefx#24959)
Anirudh Agnihotry [Wed, 1 Nov 2017 02:34:44 +0000 (19:34 -0700)]
EventLog tests enabled on windows 7 (dotnet/corefx#24959)

* Extention function added

* Last or default corrected

* write entry event corrected

* windows 7 enabled and icollection done

* Copy collection corrected

* EventLog tests editing

* extebtion class name corrected

* copy collection retrive bug

* empty line corrected

* write event corrected in eventlogtests file

* Entry written file made robust

* calling using reflection method

* using delegates

* eventlogwriteEntry corrected

* Entry Retrive corrected

* tests mostly replaced

* delete done

* Combining generics left

* Generics Optimised

* Write event corrected

* infinite wait corrected

* make changes according to review

* Minor changes

* Empty line removed

Commit migrated from https://github.com/dotnet/corefx/commit/436ed2e8d744f0eb26fc12b8374a7a7d6996787d

6 years agoMake wmi test with Win32_Process more reliable (dotnet/corefx#24975)
Paulo Janotti [Wed, 1 Nov 2017 01:36:29 +0000 (18:36 -0700)]
Make wmi test with Win32_Process more reliable (dotnet/corefx#24975)

This should fix 24912: it seems that the process id is being re-used and
the call to Get is not throwing the expected exception. This change
should prevent re-use of process id while the test is running.

undo sln changes

Commit migrated from https://github.com/dotnet/corefx/commit/79ef2120ec939cf94b07aa81d960a32dcef72666

6 years agoFix System.DirectoryServices configurations and generate PNS assembly correctly for...
Santiago Fernandez Madero [Tue, 31 Oct 2017 23:14:22 +0000 (16:14 -0700)]
Fix System.DirectoryServices configurations and generate PNS assembly correctly for UAP (dotnet/corefx#24878)

* Fix System.DirectoryServices configurations and generate PNS assembly correctly

* Fix CI adding UapVNext as a target framework for the pkg

* Fix configurations to be PNSE when targeting netstandard or any non-windows configuration

* Disable test that is using DirectoryServices and is getting PNSE

Commit migrated from https://github.com/dotnet/corefx/commit/3be15ca3d519fafc149c08b20727f88cb0f76e6a

6 years agoImprove code comments around TextWriter.NewLine for xplat (dotnet/corefx#24982)
Jared Nance [Tue, 31 Oct 2017 22:52:41 +0000 (17:52 -0500)]
Improve code comments around TextWriter.NewLine for xplat (dotnet/corefx#24982)

Commit migrated from https://github.com/dotnet/corefx/commit/b3d44d26342260d516993c52b4e8e8422a0bad43

6 years agoUpdate dogfooding.md
Dan Moseley [Tue, 31 Oct 2017 21:52:59 +0000 (14:52 -0700)]
Update dogfooding.md

Commit migrated from https://github.com/dotnet/corefx/commit/bd45cc9809cfe936d18e99d46eedbe79be0bbd16

6 years agoMerge pull request dotnet/corefx#24924 from karajas/addFeedToRestore
Wes Haggard [Tue, 31 Oct 2017 17:42:55 +0000 (10:42 -0700)]
Merge pull request dotnet/corefx#24924 from karajas/addFeedToRestore

Add blob feed as a restore source

Commit migrated from https://github.com/dotnet/corefx/commit/2ba93796dcf132de447886d4d634414ee8cb069d

6 years agoImplement maxNumberOfServerInstances support on Unix
Stephen Toub [Mon, 23 Oct 2017 18:51:21 +0000 (14:51 -0400)]
Implement maxNumberOfServerInstances support on Unix

Only supported with multiple servers in the same process, but that's a common-enough case to make it worthwhile to implement, e.g. a server process wanting to handle multiple named pipes clients concurrently.

Commit migrated from https://github.com/dotnet/corefx/commit/4c6fcfc30410c9f915d79e6344cc83445d976049

6 years agoUpdate dogfooding.md
Dan Moseley [Tue, 31 Oct 2017 16:05:19 +0000 (09:05 -0700)]
Update dogfooding.md

Commit migrated from https://github.com/dotnet/corefx/commit/2e4c07f4af4a2e4d8cec870fc85b71c74c042b3f

6 years agoChange lifetime of Socket used in NamedPipeServerStream on Unix
Stephen Toub [Sun, 22 Oct 2017 13:23:52 +0000 (09:23 -0400)]
Change lifetime of Socket used in NamedPipeServerStream on Unix

We currently create and destroy the unix domain socket each time WaitForConnection{Async} is called, and it lives until the client connects.  This causes problems when multiple clients try to connect before WaitForConnection{Async} is called; any number that's under the min listen limit applied by the OS will have their connections completed, even though Accept hasn't been called, and then when the socket is closed, the connections will all fail.  This change moves the UDS creation to when the NamedPipeServerStream is created, deleting it when the NPSS is disposed.

Commit migrated from https://github.com/dotnet/corefx/commit/16b29a8ca2f075edfb27a720782320e720bb8941

6 years agoRemove dead code from System.Private.Uri (dotnet/corefx#24937)
Stano Peťko [Tue, 31 Oct 2017 13:35:16 +0000 (14:35 +0100)]
Remove dead code from System.Private.Uri (dotnet/corefx#24937)

* Deleted dead code from System.Private.Uri.

* Reverted changes in UriSyntax.cs.

Commit migrated from https://github.com/dotnet/corefx/commit/a7d59c16e8e1f7975b26e0f9780eadcd8526cbab

6 years agoRemove irrelevant material from dogfooding.md
Dan Moseley [Tue, 31 Oct 2017 03:40:37 +0000 (20:40 -0700)]
Remove irrelevant material from dogfooding.md

Commit migrated from https://github.com/dotnet/corefx/commit/c0e459bf4638bd10d080d44125a7329941535ee7

6 years agoAdd information on myget feed and local SDK (dotnet/corefx#24958)
Dan Moseley [Tue, 31 Oct 2017 03:37:37 +0000 (20:37 -0700)]
Add information on myget feed and local SDK (dotnet/corefx#24958)

* Add information on myget feed and local SDK

* More edits

* Numbering

* change to 2.1

Commit migrated from https://github.com/dotnet/corefx/commit/c53e2c9269172543f93f576e58f1e0103d64b4d6

6 years agoRemove private reflection agaist RuntimeWrappedException constructor (dotnet/corefx...
Jan Kotas [Mon, 30 Oct 2017 19:06:02 +0000 (12:06 -0700)]
Remove private reflection agaist RuntimeWrappedException constructor (dotnet/corefx#24945)

RuntimeWrappedException constructor is public in CoreLib now. It can be called directly.

Commit migrated from https://github.com/dotnet/corefx/commit/778dd1f8766578a3822083287ce819fcd7642d15

6 years agoDelete unnecessary internal forwarders (dotnet/corefx#24939)
Jan Kotas [Mon, 30 Oct 2017 19:05:18 +0000 (12:05 -0700)]
Delete unnecessary internal forwarders (dotnet/corefx#24939)

The optimized enum comparers used can never show up in the binary serialization payload. We do not need the internal forwarders for them.

Commit migrated from https://github.com/dotnet/corefx/commit/aca208104d2013e4c3c7fd56c8f169080fbb4ea1

6 years agoRemove dead code from System.Net.WebSocket.Client (dotnet/corefx#24932)
Stano Peťko [Mon, 30 Oct 2017 19:04:15 +0000 (20:04 +0100)]
Remove dead code from System.Net.WebSocket.Client (dotnet/corefx#24932)

* Deleted dead code from System.Neet.WebSocket.Client.

* Reverted changes in WinHttpWebSocketCallback.

Commit migrated from https://github.com/dotnet/corefx/commit/7a3d591c8e4e308c32e9f4932eaf8fa9ed1d760b

6 years agoDeleted dead code from System.Net.WebClient. (dotnet/corefx#24930)
Stano Peťko [Mon, 30 Oct 2017 19:03:08 +0000 (20:03 +0100)]
Deleted dead code from System.Net.WebClient. (dotnet/corefx#24930)

Commit migrated from https://github.com/dotnet/corefx/commit/16b1d87149c8ee7984d29ab2f3ebb1ee92112bde

6 years agoAdd ManagedHandler support for cancelling connect operations (dotnet/corefx#24873)
Stephen Toub [Mon, 30 Oct 2017 19:02:27 +0000 (15:02 -0400)]
Add ManagedHandler support for cancelling connect operations (dotnet/corefx#24873)

Commit migrated from https://github.com/dotnet/corefx/commit/0e517d15d2a90aceffdd6bbc6c1de80b8582a154

6 years agoAddress System.Threading.Channels PR feedback (dotnet/corefx#24955)
Stephen Toub [Mon, 30 Oct 2017 19:02:02 +0000 (15:02 -0400)]
Address System.Threading.Channels PR feedback (dotnet/corefx#24955)

Addressing a few pieces of feedback on the previous PR, plus some auto-cleanup.

Commit migrated from https://github.com/dotnet/corefx/commit/9a90c2e1fcfb3276275a39f6cdc383e8a3012df0

6 years agoUpdate BuildTools, CoreClr, CoreFx to prerelease-02128-02, preview1-25829-02, preview...
dotnet-maestro-bot [Mon, 30 Oct 2017 19:01:29 +0000 (12:01 -0700)]
Update BuildTools, CoreClr, CoreFx to prerelease-02128-02, preview1-25829-02, preview1-25830-01, respectively (master) (dotnet/corefx#24944)

* WIP: Move OpenCommPort to api set

It will fail until changes in buildtools (https://github.com/dotnet/buildtools/pull/1766) reach corefx.

* Including OpenCommPort only for Uap

It was already only used in uap but per review it is better to make it
explicit on the project too.

* Update BuildTools, CoreClr, CoreFx to prerelease-02128-02, preview1-25829-02, preview1-25830-01, respectively

Commit migrated from https://github.com/dotnet/corefx/commit/51a96959a764e25932735f22fa41b93a960b241f

6 years agoMove UTF8 tests to netcoreapp section
tijoytk [Mon, 30 Oct 2017 18:35:00 +0000 (11:35 -0700)]
Move UTF8 tests to netcoreapp section

Commit migrated from https://github.com/dotnet/corefx/commit/a05512ca2ef2c4f53e67a44f8434551b64748344

6 years agoFix System.DirectoryServices.AccountManagement configurations (dotnet/corefx#24887)
Santiago Fernandez Madero [Mon, 30 Oct 2017 17:54:55 +0000 (10:54 -0700)]
Fix System.DirectoryServices.AccountManagement configurations (dotnet/corefx#24887)

* Fix System.DirectoryServices.AccountManagement configurations

* Update comment to AssemblyInfo.cs

* Delete AssemblyInfo.cs file and netfx configuration in tests

* Make netstandard PNSE assembly and netfx only a placeholder in the pkgproj

Commit migrated from https://github.com/dotnet/corefx/commit/bb52baa59e4ebe0cc4e962f5895fc2566c7b0c14