Henry Wilkes [Mon, 2 Mar 2020 12:23:07 +0000 (12:23 +0000)]
container: freeze notifies during add and remove
Hold the notify signals for the container and the children until after
the child has been fully added or removed.
After the previous commit, this was used to ensure that the
notify::priority signal was sent for children of a clip *after* the
child-removed signal. This stopped being the case when the code in
->child_removed was moved to ->remove_child (the latter is called before
the child-removed signal is emitted, whilst the former is called
afterwards). Rather than undo this move of code, which was necessary to
ensure that ->add_child was always reversed, the notify::priority signal
is now simply delayed until after removing the child has completed. This
was done for all notify signals, as well as in the add method, to ensure
consistency.
This allows the test_clips.py test_signal_order_when_removing_effect to
pass.
Also make subclasses take a copy of the list of the children before
setting the start and duration, since this can potentially re-order the
children (if they have the SET_SIMPLE flag set).
Henry Wilkes [Mon, 2 Mar 2020 13:35:20 +0000 (13:35 +0000)]
clip: make remove_child a reverse of add_child
Previously, we relied on ->child_removed to reverse the priority changes
that occured in ->add_child. However, ->child_removed is not always
called (the signal child-removed is not always emitted) when a
->add_child needs to be removed. However, ->remove_child is always
called to reverse ->add_child, so the code was moved here. Otherwise, we
risk that the priorities of the clip will contain gaps, which will cause
problems when another child is added to the clip.
Henry Wilkes [Mon, 2 Mar 2020 13:25:21 +0000 (13:25 +0000)]
clip: tidy handling of child priorities
Handle the child priorities in a way that keeps the container children
list sorted by priority at all times. Also, no longer rely on the
control_mode of the container, since we have less control over its value,
compared to private variables.
Also fixed the changing of priorities in set_top_effect_index:
previously *all* children whose priority was above or below the new
priority were shifted, when we should have been only shifting priorities
for the children whose priority lied *between* the old and the new
priority of the effect. E.g.
effect: A B C D E F
index: 0 1 2 3 4 5
After moving effect E to index 1, previously, we would get
effect: A B C D E F
index: 0 2 3 4 1 6
(this would have also shifted the priority for the core children as
well!). Whereas now, we have the correct:
effect: A B C D E F
index: 0 2 3 4 1 5
Henry Wilkes [Mon, 2 Mar 2020 12:56:03 +0000 (12:56 +0000)]
clip: only allow core elements as children
Only allow elements that were created by ges_clip_create_track_elements
(or copied from such an element) to be added to a clip. This prevents
users from adding arbitrary elements to a clip.
As an exception, a user can add GESBaseEffects to clips whose class
supports it, i.e. to a GESSourceClip and a GESBaseEffectClip.
This change also introduces a distinction between the core elements of a
clip (created by ges_clip_create_track_elements) and non-core elements
(currently, only GESBaseEffects, for some classes). In particular,
GESBaseEffectClip will now distinguish between its core elements and
effects added by the user. This means that the core elements will always
have the lowest priority, and will not be listed as top effects. This is
desirable because it brings the behaviour of GESBaseEffectClip in line
with other clip types.
Thibault Saunier [Wed, 11 Mar 2020 22:38:19 +0000 (19:38 -0300)]
nle: Delay marking object as not in composition
Instead of doing it at the time of resetting `object->in_composition`
when user calls `gst_bin_remove` do it after we actually removed
it from the object thread, and do it in the `nle_object_reset`
method where it belongs
Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/96
Henry Wilkes [Tue, 10 Mar 2020 21:54:56 +0000 (21:54 +0000)]
auto-transition: fix setting of SET_SIMPLE flag
Previously, the SET_SIMPLE flag was non unset for auto-transitions after
it had been set.
Sebastian Dröge [Wed, 11 Mar 2020 11:42:50 +0000 (13:42 +0200)]
Fix build with Python 3.8 by also checking for python-3.X-embed.pc
Since Python 3.8 the normal checks don't include the Python libraries
anymore and linking of the Python formatters would fail.
See also https://github.com/mesonbuild/meson/issues/5629
and https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28
Thibault Saunier [Mon, 9 Mar 2020 14:49:33 +0000 (11:49 -0300)]
validate: Handle checking/setting subprojects ges properties
Thibault Saunier [Mon, 9 Mar 2020 14:49:02 +0000 (11:49 -0300)]
project: Do not warn when resetting URI to the same one
Thibault Saunier [Thu, 5 Mar 2020 18:56:28 +0000 (15:56 -0300)]
ges: Make setting start/duration move or trim generic
We were implementing the logic for moving/trimming elements specific
to SourceClip but this was not correct ass the new timeline tree allows
us to handle that for all element types in a generic and nice way.
This make us need to have groups trimming properly implemented in the
timeline tree, leading to some fixes in the group tests.
This adds tests for the various cases known to not be handled properly
by the previous code.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/92
Thibault Saunier [Wed, 4 Mar 2020 20:42:46 +0000 (17:42 -0300)]
group: Update priority when a child is removed
Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/93
Thibault Saunier [Wed, 4 Mar 2020 20:16:18 +0000 (17:16 -0300)]
clip: Don't split clips at illegal position
Make sure that when we split a clip, the resulting timeline would
not be in an illegal state.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/94
Henry Wilkes [Thu, 5 Mar 2020 19:00:20 +0000 (19:00 +0000)]
pipeline: don't link tracks unnecessarily
Unless the pipeline is in certain modes, we do not want to try and link
every track. The previous debug message implied this, but the method did
not actually end early.
Also, we always end early if we receive a track that is neither video
nor audio.
Henry Wilkes [Thu, 5 Mar 2020 18:15:41 +0000 (18:15 +0000)]
asset: fix handling of proxies
Previous usage of the property proxy-target seemed to alternate between
the two definitions:
+ The asset we are the default proxy of
+ The asset we are in the proxy list of
Now, the latter definition is used, which seems more useful to a user
since knowing the latter can easily allow you to find out the former.
The previous behaviour of ges_asset_set_proxy (asset, NULL) was not very
clear. It is now defined so that it clears all the proxies for 'asset'.
This means that after this call, the GESAsset:proxy property will indeed
be NULL.
Also fixed:
+ We can call ges_asset_set_proxy (asset, proxy) when 'proxy' is already
in the proxy list of 'asset'.
+ Handling of removing the default proxy in ges_asset_unproxy. This was
sending out the wrong notifies.
+ Prohibiting circular proxying. Before we could only prevent one case,
we should now be able to prevent all cases. This will prevent a hang
in ges_asset_request.
Henry Wilkes [Wed, 4 Mar 2020 17:00:46 +0000 (17:00 +0000)]
test: remove asset test that needs internal method
The test_proxy_asset test needs the internal method
ges_asset_finish_proxy. The test also uses the associated internal methods
ges_asset_try_proxy and ges_asset_cache_lookup. However, these are
marked with GES_API in ges-internal.h, which allows us access to them
here.
The new method is not marked as GES_API because it would not allow us to
remove the method in the future without removing it from the symbols list.
We do not want to add to the problem.
The test was simply commented out since we may wish to support tests
that access internal methods in the future using meson.
Henry Wilkes [Wed, 4 Mar 2020 13:05:58 +0000 (13:05 +0000)]
asset: fix ownership in ges_asset_request
Fix the ownership in ges_asset_request. This should be transfer-full,
but for proxies it would fail to add a reference. Also,
ges_asset_cache_put was leaking memory if the asset already existed.
Henry Wilkes [Wed, 4 Mar 2020 11:31:32 +0000 (11:31 +0000)]
asset: move set_proxy (NULL, proxy) behaviour to new method
We should not be accepting ges_asset_set_proxy (NULL, proxy) as part of
the API! This behaviour was used internally in combination with
ges_asset_try_proxy, which is called on a still loading asset, so it was
moved to ges_asset_finish_proxy.
Henry Wilkes [Wed, 4 Mar 2020 10:34:45 +0000 (10:34 +0000)]
asset: deprecate ->proxied method
This method was no longer called, so it has been deprecated.
Henry Wilkes [Wed, 4 Mar 2020 09:59:33 +0000 (09:59 +0000)]
asset: make proxy-target read only
We should not be able to set this property.
Henry Wilkes [Thu, 27 Feb 2020 16:08:45 +0000 (16:08 +0000)]
timeline: fix layer priority argument in trim
Previously, we tested that the given priority was `>0`, when it seems
that `>=0` was intended. A priority of `-1` means leave the priority
unchanged, whilst a priority of 0, or more, means move to this layer
priority.
Henry Wilkes [Fri, 21 Feb 2020 09:23:34 +0000 (09:23 +0000)]
timeline-element: use default ->list_children_properties
Stop overwriting the ->list_children_properties virtual method in
subclasses because the timeline element class handles everything itself
anyway.
Note that containers already automatically add the children properties of
their child elements in ges_container_add.
Henry Wilkes [Tue, 25 Feb 2020 08:16:58 +0000 (08:16 +0000)]
group: fix memory leak in child layer callback
We were leaking the sigids->layer argument because gst_clip_get_layer
returns a new reference.
Henry Wilkes [Mon, 24 Feb 2020 20:19:12 +0000 (20:19 +0000)]
container: fix child duration callback
Previously, we were setting the inpoint_offset using the start offset in
the duration callback!
Also added a notify for when the duration is changed in the child start
callback.
Henry Wilkes [Mon, 24 Feb 2020 18:58:55 +0000 (18:58 +0000)]
group: fix max layer priority
The maximum priority is `height - prio - 1`. Previously missing the -1.
Related to, but does not completely fix,
https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/91
Henry Wilkes [Tue, 18 Feb 2020 18:02:08 +0000 (18:02 +0000)]
clip: allow for neither track nor type in search
Previously, either the track or track_type arguments had to be specified
in order to find **any** track elements. Now, you can specify neither,
which will match any track element, of the specified type.
Henry Wilkes [Tue, 18 Feb 2020 12:17:50 +0000 (12:17 +0000)]
pythontests: change num layers in timeline to 1
In the test_timeline.test_auto_transition, the corresponding xges only
has one layer, so we should only expect one layer when we extract the
timeline. This fixes a change that was missing from commit
d3e2cf55e3ad6258ff09220ee6393655fdd833f1
Henry Wilkes [Tue, 18 Feb 2020 12:14:25 +0000 (12:14 +0000)]
extractable: check extractable-type of set asset
When setting the asset of a GESExtractable object, first make sure that
the asset's extractable-type matches the type of the object.
Henry Wilkes [Tue, 18 Feb 2020 09:17:09 +0000 (09:17 +0000)]
layer: fix ownership when failing to add clip
If a clip is already part of a layer, then adding it to another layer
should fail. Previously, in this case, `ges_layer_add_clip` was adding a
reference to the clip instead, without subsequently giving up ownership.
This meant that the clip would be left with an unowned reference.
This has now been corrected by also calling `unref` after the
`ref_sink`.
Note that, since `clip` is already part of `current_layer`, it should
already be non-floating, so the `ref_sink`-`unref` should do nothing
overall. But we keep both to make the ownership (transfer floating/none)
explicit.
Henry Wilkes [Wed, 12 Feb 2020 22:23:38 +0000 (22:23 +0000)]
docs: update GESAudioTrack and GESVideoTrack
Henry Wilkes [Tue, 21 Jan 2020 12:01:41 +0000 (12:01 +0000)]
docs: update GESPipeline
Henry Wilkes [Fri, 17 Jan 2020 20:10:23 +0000 (20:10 +0000)]
docs: update GESMetaContainer
Henry Wilkes [Fri, 17 Jan 2020 15:27:29 +0000 (15:27 +0000)]
docs: update GESExtractable
Henry Wilkes [Fri, 17 Jan 2020 12:20:11 +0000 (12:20 +0000)]
docs: update GESAsset
Henry Wilkes [Wed, 15 Jan 2020 14:46:02 +0000 (14:46 +0000)]
docs: update GESTrackElement
Henry Wilkes [Wed, 15 Jan 2020 14:44:38 +0000 (14:44 +0000)]
docs: update GESTrack
Henry Wilkes [Thu, 9 Jan 2020 12:11:35 +0000 (12:11 +0000)]
docs: update GESClip
Henry Wilkes [Thu, 9 Jan 2020 12:09:15 +0000 (12:09 +0000)]
docs: update GESGroup
Henry Wilkes [Wed, 8 Jan 2020 09:26:07 +0000 (09:26 +0000)]
docs: update GESContainer
Henry Wilkes [Tue, 7 Jan 2020 17:40:53 +0000 (17:40 +0000)]
docs: update GESTimelineElement
Henry Wilkes [Fri, 20 Dec 2019 12:30:54 +0000 (12:30 +0000)]
validate: unref copied and pasted
Henry Wilkes [Fri, 20 Dec 2019 11:20:49 +0000 (11:20 +0000)]
timeline: fix paste ownership
The method steals ownership of `copied_from`, so should be responsible
for unreffing it. Also make sure we fail when `layer != -1`, since this
functionality is not supported.
Henry Wilkes [Wed, 18 Dec 2019 20:33:45 +0000 (20:33 +0000)]
docs: update GESTimeline and GESLayer
Thibault Saunier [Tue, 3 Mar 2020 21:07:32 +0000 (18:07 -0300)]
python: Cleanup overrides using monkey patching
Following the PyGObject guidelines[0], this starts monkey patching
overridden elements instead of subclassing them.
[0]: https://pygobject.readthedocs.io/en/latest/devguide/override_guidelines.html#python-override-guidelines
Jens Göpfert [Thu, 29 Nov 2018 18:12:24 +0000 (19:12 +0100)]
add assets to layer and adjust position and duration (closes #45)
Thibault Saunier [Mon, 2 Mar 2020 22:06:17 +0000 (19:06 -0300)]
python: Add a Timeline.iter_clips() helper to iterate clips
Thibault Saunier [Mon, 24 Feb 2020 15:21:11 +0000 (12:21 -0300)]
meson: Add an option to enable/disable validate integration
Thibault Saunier [Sat, 22 Feb 2020 17:23:45 +0000 (14:23 -0300)]
framepositioner: Reposition source when the user positioned them
Keeping the same proportion in the size and position and only if
the aspect ratio is conserved.
Thibault Saunier [Mon, 24 Feb 2020 11:50:04 +0000 (08:50 -0300)]
ges:launch: Handle setting playback information in scenarios
This way we can avoid real sinks when implementing scenarios
Thibault Saunier [Mon, 24 Feb 2020 11:47:11 +0000 (08:47 -0300)]
validate: Handle absolute control binding support when setting keyframes
And minor fix in set-control-source
Thibault Saunier [Wed, 19 Feb 2020 21:09:19 +0000 (18:09 -0300)]
ges: Properly position video sources in the scene by default
We try to do our best to have the video frames scaled the best way
to fill most space on the final frames, keeping aspect ratio. The user
can later on rescale or move the sources as usual but it makes the
default behaviour a better and more natural especially now that we
set default restriction caps to the video tracks.
And fix the unit test to take that change into account
Thibault Saunier [Wed, 19 Feb 2020 21:06:26 +0000 (18:06 -0300)]
ges: Add a method to retrieve the 'natural' size of VideoSource
This way the user can easily know how the clip would look like
if no scaling was applied to the clip, this is useful to be able
to properly position the clips with the framepositionner element.
Thibault Saunier [Wed, 19 Feb 2020 18:31:28 +0000 (15:31 -0300)]
ges: Call the right ->set_child_property vmethod
We used to always call the `->set_child_property` virtual method
of the object that `ges_timeline_element_set_child_property` was called
from, but that means that, in the case of referencing GESContainer
children properties from its children, the children wouldn't know
what child property have been set, and the children override wouldn't
be takent into account, in turns, it means that the behaviour could be
different in the setter depending on parent the method was called,
which is totally unexpected.
We now make sure that the vmethod from the element that introduced the
child property is called whatever parent method is called, making the
behaviour more uniform.
Fix the python override to make sure that new behaviour is respected.
Thibault Saunier [Tue, 18 Feb 2020 19:31:15 +0000 (16:31 -0300)]
ges: Deprecate the GESTimeline::track field
It is not MT safe to access it, and user should use the proper getter
Thibault Saunier [Tue, 18 Feb 2020 19:09:55 +0000 (16:09 -0300)]
ges: Set default caps for GESVideoTrack
By default, video track output full HD@30fps, this makes the behaviour
of clip position much more understandable and guarantess that we
always have a framerate.
The user can modify the values whenever he wants
Thibault Saunier [Thu, 20 Feb 2020 15:28:59 +0000 (12:28 -0300)]
framepositioner: Stop lying about the source size
Basically we were advertising that the source size would be the
size of the track if it hadn't been defined by end user, but since
we started to let scaling happen in the compositor, this is not true
as the source size is now the natural size of the underlying video
stream.
Remove the unit test and reimplemented using a validate scenario which
make the test much simpler to read :=)
Thibault Saunier [Thu, 20 Feb 2020 15:27:37 +0000 (12:27 -0300)]
validate: Add action types to set/check various child properties at once
And add a way to take into account control bindings.
Thibault Saunier [Thu, 20 Feb 2020 15:22:19 +0000 (12:22 -0300)]
ges: Allow setting children property using the set_object_arg format
This make it much simpler for the user to set enum values and should not cause any issue
Thibault Saunier [Thu, 20 Feb 2020 20:13:46 +0000 (17:13 -0300)]
ges: Plug leaks in new ges-launch and related
Thibault Saunier [Tue, 25 Feb 2020 20:38:15 +0000 (17:38 -0300)]
validate: Port to the new REPORT_ACTION API
Thibault Saunier [Wed, 19 Feb 2020 02:08:53 +0000 (23:08 -0300)]
nlesource: When standalone consider object.duration==0 as not set
nleobject.duration defaults to 0, but this is pretty unintuitive for
end user in the case nlesource is use standalone, just consider
duration=0 equivalent to duration=GST_CLOCK_TIME_NONE as it makes
the element much simpler to use, we could actually forbid 0 as a value
in the future.
Also take into account potential CLOCK_TIME_NONE
Thibault Saunier [Mon, 10 Feb 2020 21:05:38 +0000 (18:05 -0300)]
ges: Avoid adding unnecessary converters for nested timelines
Basically we know that if we are using mixing, compositor will be
able to do video conversion and scaling for us, so avoid adding those
usless elements.
This optimizes a lot caps negotiation for deeply nested timelines.
Thibault Saunier [Mon, 10 Feb 2020 21:00:33 +0000 (18:00 -0300)]
plugins:ges: Fix pushing tags after
e8c782d119eccf364fa24812cdc90c40f60d65d6
Basically the tags we send before STREAM_START are now ignored, meaning
that we could not detect nested timelines anymore, this commits makes
sure that we send our tag event after getting pushing STREAM_START.
Thibault Saunier [Thu, 6 Feb 2020 19:42:25 +0000 (16:42 -0300)]
nlecomposition: Optimize prerolling when using nested compositions
When a composition is nested into anotherone, we *know* that the
toplevel composition is going to send a stack initializing seek,
we can thus avoid sending it on the subcomposition itself when
prerolling. This avoid seeking roundtrips and we now have one and
only one seek travelling in the overall pipeline (after it has
prerolled).
Thibault Saunier [Thu, 6 Feb 2020 15:43:57 +0000 (12:43 -0300)]
nlesource: Fix seeks when used standalone
The 'start' of nleobject is in the 'composition' scale, inpoint is in
the media scale, when outside a composition, a nleobject->start value
doesn't mean anything.
Thibault Saunier [Thu, 6 Feb 2020 15:39:12 +0000 (12:39 -0300)]
nle: Seek the whole stack on initialization
Instead of seeking each nleobject separately to setup new stack, wait
for the whole stack to preroll and then seek that newly setup stack,
leading to the same code path and seek 'tweaking' as when processing
a seek on the composition (without stack changes).
This is mandatory to properly handle filter that tweak segments to handle
time remapping for example.
Thibault Saunier [Thu, 6 Feb 2020 15:37:37 +0000 (12:37 -0300)]
nle: Minor typo fixes
Thibault Saunier [Tue, 4 Feb 2020 20:07:39 +0000 (17:07 -0300)]
validate: Allow overriding ges-launch options through scenarios
In
99c45d42cfd1cafb658b63abf0b506db20167499 we allowed setting
track-types but in the end we could do it generically using the
following synthax in the scenario 'properties' metadata:
`ges-options={--track-types=video,--disable-mixing}`
Thibault Saunier [Fri, 7 Feb 2020 12:39:39 +0000 (09:39 -0300)]
ges: Ignore deprecation of GParameter
GParameter is part of our API, and for GLib < 2.54 we do not even have
a way around avoiding it (namely `g_object_new_with_properties`).
We should stop using GParameter once we depend on GLib 2.54.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/86
Thibault Saunier [Tue, 20 Aug 2019 21:46:09 +0000 (17:46 -0400)]
ges: Use G_DEPRECATE to mark deprecated methods
Cleanup a few things on the way.
And move ges-track-element deprecations to a dedicated header file
Henry Wilkes [Sat, 14 Dec 2019 17:04:54 +0000 (17:04 +0000)]
ges-source-clip: fixed return of duration setter
In general, brought the behaviour of the `start`, `duration` and
`inpoint` setters in line with each other. In particular:
1. fixed return value the GESSourceClip `duration` setter
2. changed the GESClip `start` setter
3. fixed the inpoint callback for GESContainer
4. changed the type of `res` in GESTimelineElement to be gint to
emphasise that the GES library is using the hack that a return of -1
from klass->set_duration means no notify signal should be sent out.
Also added a new test for clips to ensure that the setters work for
clips within and outside of timelines, and that the `start`, `inpoint`
and `duration` of a clip will match its children.
Thibault Saunier [Thu, 5 Dec 2019 17:23:04 +0000 (14:23 -0300)]
pipeline: Ensure that encodebin enforces a single segment sent to encoders
Thibault Saunier [Fri, 4 Oct 2019 12:58:17 +0000 (09:58 -0300)]
validate: Move to the new GstValidateEncodingTestInterface API
Edward Hervey [Wed, 20 Nov 2019 06:52:56 +0000 (07:52 +0100)]
xml-formatter: Free structure after usage
CID: 1416901
CID: 1439518
CID: 1439527
Edward Hervey [Wed, 20 Nov 2019 06:46:47 +0000 (07:46 +0100)]
formatter: Free path object after usage
As it's done everywhere else
CID: 1455511
Nirbheek Chauhan [Thu, 7 Nov 2019 11:24:32 +0000 (16:54 +0530)]
meson: Fix disabling of the python support
Cannot call python.dependency() if the python module was not found.
Niels De Graef [Thu, 29 Aug 2019 05:45:45 +0000 (07:45 +0200)]
Don't pass default GLib marshallers for signals
By passing NULL to `g_signal_new` instead of a marshaller, GLib will
actually internally optimize the signal (if the marshaller is available
in GLib itself) by also setting the valist marshaller. This makes the
signal emission a bit more performant than the regular marshalling,
which still needs to box into `GValue` and call libffi in case of a
generic marshaller.
Note that for custom marshallers, one would use
`g_signal_set_va_marshaller()` with the valist marshaller instead.
Henry Wilkes [Wed, 16 Oct 2019 18:26:55 +0000 (19:26 +0100)]
marker: add color meta
Support optionally coloring markers by reserving GES_META_MARKER_COLOR
for an ARGB guint.
Henry Wilkes [Wed, 16 Oct 2019 12:40:57 +0000 (13:40 +0100)]
meta-container: add register_static_meta
Allows us to register a static meta without having to set a value.
Henry Wilkes [Wed, 16 Oct 2019 10:37:23 +0000 (11:37 +0100)]
meta-container: move comment
The comment that was above _register_meta is actually meant for
_set_value.
Thibault Saunier [Wed, 23 Oct 2019 14:04:01 +0000 (16:04 +0200)]
ges-launch: Document timeline description format under --help
Making it simpler for user to get the documentation
Rico Tzschichholz [Tue, 22 Oct 2019 20:51:41 +0000 (22:51 +0200)]
marker-list: Use proper parameters names even in the docs
Otherwise there will be parameters with hyphen in their name in the GIR.
Thibault Saunier [Tue, 22 Oct 2019 11:30:36 +0000 (13:30 +0200)]
nlecomposition: Enhance dumping stack output
Thibault Saunier [Tue, 22 Oct 2019 10:21:04 +0000 (12:21 +0200)]
ges: Handle empty marker lists
Thibault Saunier [Tue, 22 Oct 2019 09:53:36 +0000 (11:53 +0200)]
validate: Tear down pipeline when openning a new project
Avoiding potential deadlock when we remove tracks on a playing pipeline
Thibault Saunier [Tue, 22 Oct 2019 09:50:02 +0000 (11:50 +0200)]
ges: Fix setting GError when adding children to containers
We were misusing assertion and not properly setting the GError value
Thibault Saunier [Tue, 22 Oct 2019 09:31:04 +0000 (11:31 +0200)]
smart-video-mixer: Handle segment updates
We were basically ignoring any segment update which could potentially
lead to setting a wrong stream time leading to wrong alpha value
being used.
Thibault Saunier [Thu, 17 Oct 2019 14:30:49 +0000 (16:30 +0200)]
launcher: Enhance printed output
Thibault Saunier [Thu, 17 Oct 2019 14:21:28 +0000 (16:21 +0200)]
launcher: Use the output URI extension to set encoding format
And print a description of the encoding profile.
Thibault Saunier [Thu, 17 Oct 2019 14:19:11 +0000 (16:19 +0200)]
pipeline: Be smarter about how we match encoding profiles and tracks
Tim-Philipp Müller [Thu, 17 Oct 2019 23:50:16 +0000 (00:50 +0100)]
meson: build gir even when cross-compiling if introspection was enabled explicitly
This can be made to work in certain circumstances when
cross-compiling, so default to not building g-i stuff
when cross-compiling, but allow it if introspection was
enabled explicitly via -Dintrospection=enabled.
See gstreamer/gstreamer#454 and gstreamer/gstreamer#381
Henry Wilkes [Wed, 16 Oct 2019 15:40:27 +0000 (16:40 +0100)]
marker-list: add prev position to ::marker-moved
Additionally give the previous marker position in the
GESMarkerList::marker-moved signal, since a user may want to know
where a move was from.
Also, fixed the documentation for GESMarkerList::marker-added
https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/78
Tim-Philipp Müller [Sun, 13 Oct 2019 12:37:11 +0000 (13:37 +0100)]
Remove autotools build system
Todo:
- hook up data/completions/ges-launch-1.0 in Meson (#77)
Sebastian Dröge [Tue, 1 Oct 2019 15:02:27 +0000 (18:02 +0300)]
ges: Hide internal debug category behind a GOnce
Otherwise it might be used (e.g. by the plugin loader via the GES
plugin!) before ges_init() is called.
Sebastian Dröge [Tue, 1 Oct 2019 15:01:21 +0000 (18:01 +0300)]
gesdemux: Initialize debug category before first using it
Prevents critical warnings during class_init()
Thibault Saunier [Mon, 23 Sep 2019 19:10:59 +0000 (16:10 -0300)]
project: Add missing safe guard when listing assets
Thibault Saunier [Mon, 23 Sep 2019 19:07:58 +0000 (16:07 -0300)]
launch: Add an option to embed nested timelines when saving
Henry Wilkes [Mon, 19 Aug 2019 13:38:12 +0000 (14:38 +0100)]
xml-formatter: increase xges version to 0.6
Increase minor_version to 6 if a sub-project is saved under an asset or an asset includes a child stream-info element.
Thibault Saunier [Fri, 23 Aug 2019 21:26:51 +0000 (17:26 -0400)]
tests: Fix transition project tests
Basically the test project was plain broken as it had fully overlapping
clips is prohibited since the timeline edition API was reimplemented.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/62
Thibault Saunier [Wed, 21 Aug 2019 18:41:46 +0000 (14:41 -0400)]
asset: Fix asset cache for CLips and TrackElement with same ID
We clearly uniquely identify assets by both their IDs and their
extractable type, and we should make sure that you can have a
TrackElement and a Clip with the same ID.
There is one exception in our implementation which is GESFormatter
because we treat their subclasses as 1 type with different IDs.
Thibault Saunier [Sat, 17 Aug 2019 15:59:38 +0000 (11:59 -0400)]
ges: Expose ges mixer to be used as effects