platform/core/ml/nnfw.git
6 years agoAdd build command for benchmark/acl (#974)
김용섭/동작제어Lab(SR)/Engineer/삼성전자 [Mon, 30 Apr 2018 07:55:23 +0000 (16:55 +0900)]
Add build command for benchmark/acl (#974)

Now `BENCHMARK_ACL_BUILD=1 make build` runs building benchmark/acl.

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
6 years agoIntroduce NEON DepthwiseConv2D (#973)
김정현/동작제어Lab(SR)/Senior Engineer/삼성전자 [Mon, 30 Apr 2018 07:31:20 +0000 (16:31 +0900)]
Introduce NEON DepthwiseConv2D (#973)

This commit introduces DepthwiseConv2D implementation for NEON.

Signed-off-by: Junghyun Kim <jh0822.kim@samsung.com>
6 years agoIntroduce a test code of multi-channel DepthwiseConv2D (#972)
김정현/동작제어Lab(SR)/Senior Engineer/삼성전자 [Mon, 30 Apr 2018 07:30:19 +0000 (16:30 +0900)]
Introduce a test code of multi-channel DepthwiseConv2D (#972)

This commit introduces a test code of multi-channel DepthwiseConv2D.

Signed-off-by: Junghyun Kim <jh0822.kim@samsung.com>
6 years agoAdd tools and tests dir into nnfw-test.rpm (#966)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Mon, 30 Apr 2018 05:38:16 +0000 (14:38 +0900)]
Add tools and tests dir into nnfw-test.rpm (#966)

nnfw-test rpm contains tools and tests folder to support test on tizen target.

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
6 years agoIntroduce DepthwiseConv2D to support MobileNet (#967)
김정현/동작제어Lab(SR)/Senior Engineer/삼성전자 [Mon, 30 Apr 2018 05:32:00 +0000 (14:32 +0900)]
Introduce DepthwiseConv2D to support MobileNet (#967)

This commit introduces DepthwiseConv2D layer to support Mobilenet
with a simple test case.

Signed-off-by: Junghyun Kim <jh0822.kim@samsung.com>
6 years agoReflect dir changes to gen_coverage_report script (#962)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Mon, 30 Apr 2018 03:58:51 +0000 (12:58 +0900)]
Reflect dir changes to gen_coverage_report script (#962)

Now, coverage report's target includes libs, include, runtimes, and
tools folder.

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
6 years agoCleanup ci and docker directory (#960)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Mon, 30 Apr 2018 00:52:44 +0000 (09:52 +0900)]
Cleanup ci and docker directory (#960)

- Cleanup ci and docker directory

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoFix typo in script (#961)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 11:39:09 +0000 (20:39 +0900)]
Fix typo in script (#961)

- Fix typo in script

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoFix typo in docker_gbs_build.sh (#959)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 10:20:53 +0000 (19:20 +0900)]
Fix typo in docker_gbs_build.sh (#959)

- Fix typo in docker_gbs_build.sh

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoUpdate Tizen build scripts with new directory structure (#958)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 10:16:19 +0000 (19:16 +0900)]
Update Tizen build scripts with new directory structure (#958)

- Update Tizen build scripts with new directory structure

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoUpdate scripts in new location (#957)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 09:48:16 +0000 (18:48 +0900)]
Update scripts in new location (#957)

- Update scripts in new location

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoRename src as runtimes (#956)
서상민/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 09:42:03 +0000 (18:42 +0900)]
Rename src as runtimes (#956)

For issue #831 and #925

This patch renames `src` as `runtimes`.

Signed-off-by: Sangmin Seo <sangmin7.seo@samsung.com>
6 years agoUpdate change_gitmodule.sh and using it (#954)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 09:31:10 +0000 (18:31 +0900)]
Update change_gitmodule.sh and using it (#954)

- Update change_gitmodule.sh with new directory structure
- Update follow scripts using change_gitmodule.sh
    docker_build_ubuntu_svace.sh
    docker_cross_test_coverage_build.sh
    docker_run_test.sh

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoMove `src/nn/runtime/sample` to `src/tests/BringUpTest` (#955)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 27 Apr 2018 09:23:43 +0000 (18:23 +0900)]
Move `src/nn/runtime/sample` to `src/tests/BringUpTest` (#955)

* Move `src/nn/runtime/sample` to `src/tests/BringUpTest`

As discussed from #831, this commit changes directory structure.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
* Fix the way of adding subdirectory

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
6 years agoRename src/runtime/test as src/tests/NeuralNetworksTest (#953)
서상민/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 08:42:48 +0000 (17:42 +0900)]
Rename src/runtime/test as src/tests/NeuralNetworksTest (#953)

For issue #831 and #925

This commit renames src/runtime/test as src/tests/NeuralNetworksTest.

Signed-off-by: Sangmin Seo <sangmin7.seo@samsung.com>
6 years agoUpdate scripts/command (#952)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 08:37:41 +0000 (17:37 +0900)]
Update scripts/command (#952)

Make following scrtips work well in new directory structure

- scripts/command/docker_build.sh
- scripts/command/docker_build_cross_arm_ubuntu.sh
- scripts/command/docker_build_cross_arm_ubuntu_without_aclbuild.sh

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoExtract CMakeLists.txt for sample directory (#951)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 27 Apr 2018 08:26:52 +0000 (17:26 +0900)]
Extract CMakeLists.txt for sample directory (#951)

This commit extracts test executable part from `src/nn/runtime/CMakeLists.txt`
into `src/nn/runtime/sample/CMakeLists.txt`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
6 years agoRelocate NeuralNetworks.h to include (#950)
서상민/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 08:21:22 +0000 (17:21 +0900)]
Relocate NeuralNetworks.h to include (#950)

For issue #831 and #925

This commit moves NeuralNetworks.h to the top-level include directory.

Signed-off-by: Sangmin Seo <sangmin7.seo@samsung.com>
6 years agoRelocate NN runtime from src/runtime/ref to src (#949)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 07:57:49 +0000 (16:57 +0900)]
Relocate NN runtime from src/runtime/ref to src (#949)

* Relocate NN runtime from src/runtime/ref to src

- Relocate NN runtime from src/runtime/ref to src

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoMake a copy of scripts and files in docker from scripts/command
Hyung-Kyu Choi [Fri, 27 Apr 2018 07:06:30 +0000 (16:06 +0900)]
Make a copy of scripts and files in docker from scripts/command

- Make a copy of scripts and files in ./docker from ./scripts/command
- This files will be used with currrent CI and
  will be removed when CI is updated

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoMove scripts in docker to scripts/command
Hyung-Kyu Choi [Fri, 27 Apr 2018 07:04:09 +0000 (16:04 +0900)]
Move scripts in docker to scripts/command

- Move scripts in docker to scripts/command
- We have to leave copies in old location for CI which is not update yet

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoMake a copy of scripts and files in ci from scripts/command
Hyung-Kyu Choi [Fri, 27 Apr 2018 06:55:01 +0000 (15:55 +0900)]
Make a copy of scripts and files in ci from scripts/command

- Make a copy of scripts and files in ci from scripts/command
- This files will be used with currrent CI and
  will be removed when CI is updated

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoMove all files in ./ci to ./scripts/command
Hyung-Kyu Choi [Fri, 27 Apr 2018 06:51:52 +0000 (15:51 +0900)]
Move all files in ./ci to ./scripts/command

- Move all files in ./ci to ./scripts/command
- We need to make a copy for backward compatibility with CI

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoMove all Dockerfile from docker to scripts/docker
Hyung-Kyu Choi [Fri, 27 Apr 2018 06:15:21 +0000 (15:15 +0900)]
Move all Dockerfile from docker to scripts/docker

- Move all Dockerfile from docker to scripts/docker

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoMove tools/nnapi_bindings/* to src/ (#947)
서상민/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 07:20:38 +0000 (16:20 +0900)]
Move tools/nnapi_bindings/* to src/ (#947)

For #831

This commit moves tools/nnapi_bindings/* to src/.  The header `nnapi.h`
in tools/nnapi_bindings/include is also moved to the top-level include
directory.

Signed-off-by: Sangmin Seo <sangmin7.seo@samsung.com>
6 years agoMove src/support to libs (#945)
오형석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 07:03:05 +0000 (16:03 +0900)]
Move src/support to libs (#945)

Move src/support to libs/support

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
6 years agoMove NNOP kernels into libs (#944)
김정현/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 06:52:17 +0000 (15:52 +0900)]
Move NNOP kernels into libs (#944)

This commit moves NNOP kernel source code from `src/kernel` to
`libs/kernel`.

Signed-off-by: Junghyun Kim <jh0822.kim@samsung.com>
6 years agoMove labs/* to contrib (#943)
서상민/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 06:51:23 +0000 (15:51 +0900)]
Move labs/* to contrib (#943)

For #831

This commit moves sub-directories in labs to contrib.

Signed-off-by: Sangmin Seo <sangmin7.seo@samsung.com>
6 years agoAdd the first draft of SW high level design (#921)
서상민/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 06:16:35 +0000 (15:16 +0900)]
Add the first draft of SW high level design (#921)

* Add the first draft of SW high level design

This commit adds the first draft of SW high level design.

Signed-off-by: Sangmin Seo <sangmin7.seo@samsung.com>
6 years agoFix wrong pair of ifdef comment in TestValidation.cpp (#934)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 27 Apr 2018 06:10:21 +0000 (15:10 +0900)]
Fix wrong pair of ifdef comment in TestValidation.cpp (#934)

* Make ifdef comment correct in TestValidation.cpp

This commit makes ifdef comment correct int TestValidation.cpp

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Change todo comment

* Fix typo se->we

6 years agoRelocate badState helper to the top of ModelBuilder (#935)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 27 Apr 2018 06:09:14 +0000 (15:09 +0900)]
Relocate badState helper to the top of ModelBuilder (#935)

As we've discussed in https://github.sec.samsung.net/STAR/nnfw/pull/809#discussion_r48662, once this helper was merged for easy to review, and then we've planed rearrange the order to easy to read in another PR.
This is why I make this PR.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
6 years agoAdd the first draft of SW requirement specification (#920)
서상민/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 06:07:08 +0000 (15:07 +0900)]
Add the first draft of SW requirement specification (#920)

This commit adds the first draft of SW requirement specification.

Signed-off-by: Sangmin Seo <sangmin7.seo@samsung.com>
6 years agoChange externals/acl as a submodule (#827)
서상민/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 27 Apr 2018 04:28:11 +0000 (13:28 +0900)]
Change externals/acl as a submodule (#827)

This patch removes externals/acl and adds ACL again as a submodule.

For issue #554

Signed-off-by: Sangmin Seo sangmin7.seo@samsung.com
6 years agoResolve NN runtime unit test Assertion (#903)
PRAVEEN DORESWAMY NAIDU/SRI-Bangalore-System SW/./삼성전자 [Fri, 27 Apr 2018 02:58:20 +0000 (02:58 +0000)]
Resolve NN runtime unit test Assertion (#903)

Assertion generated in NN runtime unit test, need to check the need for assertion, disabling it as ToDo-NNRT

6 years agoAdd license to sources for tools, tests, include (#936)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Fri, 27 Apr 2018 01:52:22 +0000 (10:52 +0900)]
Add license to sources for tools, tests, include (#936)

Related issue: #840

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
6 years agoAdd license to sources under libs and src/support (#933)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Fri, 27 Apr 2018 00:44:52 +0000 (09:44 +0900)]
Add license to sources under libs and src/support (#933)

Related issue: #840

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
6 years agoChange TestValidation2.cpp to default NN Runtime test (#928)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 27 Apr 2018 00:02:41 +0000 (09:02 +0900)]
Change TestValidation2.cpp to default NN Runtime test (#928)

This commit changes TestValidation2.cpp to default NN Runtime test.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
6 years agoAdd test rpm for obs build (#914)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Thu, 26 Apr 2018 22:30:44 +0000 (07:30 +0900)]
Add test rpm for obs build (#914)

* Add test rpm for obs build

nnfw-test.rpm contains unittests and its install path
is /opt/usr/nnfw-test/

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
6 years agoReduce indent level (#927)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 26 Apr 2018 09:01:17 +0000 (18:01 +0900)]
Reduce indent level (#927)

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
6 years agoEnable rootfs using tools/cross/build-rootfs.sh (#929)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Thu, 26 Apr 2018 09:01:01 +0000 (18:01 +0900)]
Enable rootfs using tools/cross/build-rootfs.sh (#929)

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
6 years agoAdd ANEURALNETWORKS_BAD_DATA check in validateOperandType/setFromPointer (#916)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 26 Apr 2018 07:05:17 +0000 (16:05 +0900)]
Add ANEURALNETWORKS_BAD_DATA check in validateOperandType/setFromPointer (#916)

* add additional ANEURALNETWORKS_BAD_DATA check in validateOperandType/setFromPointer

This commit adds additional ANEURALNETWORKS_BAD_DATA check in below
- validateOperandType
- setFromPointer

These codes have copied from android NN master branch(af63a36)

Fix : #805

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Add detailed comment to TODO comment

6 years agoAdd LICENSE in root directory (#913)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Thu, 26 Apr 2018 07:00:44 +0000 (16:00 +0900)]
Add LICENSE in root directory (#913)

The purpose of LICENSE is to provide full text of license
that the corresponding source contains only partial and/or
link to full text.

It contains the following licenses:

- Apache License 2.0 (for ours)
- Mozilla Public License 2.0 (almost all of eigen)

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
6 years agoFix and update docs tizen xu4 file (#918)
박세희/동작제어Lab(SR)/Principal Engineer/삼성전자 [Thu, 26 Apr 2018 06:58:49 +0000 (15:58 +0900)]
Fix and update docs tizen xu4 file (#918)

This will fix xu4_tizen.md file that had a wrong script file name
- also update to latest tizen image file name that now doesn't have version number like `4.0`

Signed-off-by: SaeHie Park <saehie.park@samsung.com>
6 years agoRevert "Add assertion to check divide by zero (#892)" (#924)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Thu, 26 Apr 2018 06:39:52 +0000 (15:39 +0900)]
Revert "Add assertion to check divide by zero (#892)" (#924)

This reverts commit 8abe4dba8ff6b5209561dc728b980fc7e8def816.

This was made for fixing the Coverity warning (#891) but it does not work.
We decide this warning to be a false alarm.

6 years agoRevert "Disable memory bound check in MemoryTracker for 32bit arch" (#922)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 26 Apr 2018 06:39:44 +0000 (15:39 +0900)]
Revert "Disable memory bound check in MemoryTracker for 32bit arch" (#922)

This was made for fixing the UNREACHABLE_CODE detected by SVACE but it doesn't work.
We decide this warning to be a false alarm.

This reverts commit 3b01060eda993c1c9863237af561b04ed30c7dd0.
This reverts commit d22e4225050092a53b685f73cb0bcabc7c144a74.

6 years agoAdd doc for aarch64 build (#917)
김용섭/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 26 Apr 2018 06:25:38 +0000 (15:25 +0900)]
Add doc for aarch64 build (#917)

* Add doc for aarch64 build

Add doc for aarch64 build. This is copied from doc for arm.

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
6 years agoAdd NNFW_KERNELS_ env on benchmark test (#912)
김용섭/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 26 Apr 2018 05:04:55 +0000 (14:04 +0900)]
Add NNFW_KERNELS_ env on benchmark test (#912)

Adds NNFW_KERNELS env such as convFloat32, averagePoolFloat32 on
benchmark test. The envs are written on nnfw_kernel_env_list.txt.

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
6 years agoAdd additional ANEURALNETWORKS_BAD_DATA check into updateDimensionInfo (#910)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 26 Apr 2018 05:04:00 +0000 (14:04 +0900)]
Add additional ANEURALNETWORKS_BAD_DATA check into updateDimensionInfo (#910)

This commit adds additional ANEURALNETWORKS_BAD_DATA check into updateDimensionInfo.
These codes have copied from android NN master branch(af63a36)

Fix : #805

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
6 years agoCan pass SVACE binary path (#900)
오형석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Thu, 26 Apr 2018 05:01:54 +0000 (14:01 +0900)]
Can pass SVACE binary path (#900)

Can pass SVACE binary path using environment variable

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
6 years agoUpdate NN Runtime TestTrivialModel test (#907)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 26 Apr 2018 04:54:47 +0000 (13:54 +0900)]
Update NN Runtime TestTrivialModel test (#907)

This commit updates NN Rumtime TestTrivialModel test to android NN master branch.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
6 years agoFix build_rootfs.sh message (#909)
박세희/동작제어Lab(SR)/Principal Engineer/삼성전자 [Thu, 26 Apr 2018 04:49:26 +0000 (13:49 +0900)]
Fix build_rootfs.sh message (#909)

This will fix build_rootfs.sh script that shows `[: missing `]'` warning

Signed-off-by: SaeHie Park <saehie.park@samsung.com>
6 years agonnapi_test check arguments (#902)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 26 Apr 2018 04:15:44 +0000 (13:15 +0900)]
nnapi_test check arguments (#902)

This commit fixes when .tflite file is not given from the argument.
Which has caused segmentation fault.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
6 years agoEnable build aarch64 for tizen&cross (#885)
김용섭/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 26 Apr 2018 02:40:10 +0000 (11:40 +0900)]
Enable build aarch64 for tizen&cross (#885)

Enable build aarch64 for tizen&cross

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
6 years agoAdd license for sources under src/runtime (#904)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Thu, 26 Apr 2018 02:34:08 +0000 (11:34 +0900)]
Add license for sources under src/runtime (#904)

Related issue: #840, #839

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
6 years agoDisable memory bound check in MemoryTracker for 32bit arch (#886)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 26 Apr 2018 00:57:32 +0000 (09:57 +0900)]
Disable memory bound check in MemoryTracker for 32bit arch (#886)

* Disable memory bound check in MemoryTracker for 32bit arch

This commit disables memory bound check in MemoryTracker for 32bit archtecture.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Change supported bit check mechanism

6 years agoAdd assertion to check divide by zero (#892)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Thu, 26 Apr 2018 00:56:48 +0000 (09:56 +0900)]
Add assertion to check divide by zero (#892)

- Add assertion to check divide by zero
  In this context, the value will not be zero.
  But coverity complains this, so let's guard it with assertion.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoFree memory at early exit (#899)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Thu, 26 Apr 2018 00:56:33 +0000 (09:56 +0900)]
Free memory at early exit (#899)

- Free memory at early exit
  This was reported by Coverity (118950 Resource leak)

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoIntroduce badstate checker in ModelBuilder (#809)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 25 Apr 2018 09:01:47 +0000 (18:01 +0900)]
Introduce badstate checker in ModelBuilder (#809)

* Introduce badstate checker in ModelBuilder

This commit introduces badstate checker in ModuleBuilder to fix #804 failure.
These codes have copied from android NN master branch(af63a36).

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Move badState to the end of file

6 years agotflite file generator (from Tensoflow model in python source code) (#810)
윤현식/동작제어Lab(SR)/Principal Engineer/삼성전자 [Wed, 25 Apr 2018 08:48:27 +0000 (17:48 +0900)]
tflite file generator (from Tensoflow model in python source code) (#810)

PR for #660

Summary of current work.
1. One monolithic file was splitted into several py files.
   - Base class (a template for subclasses)
   - Several subclass which define model (to be converted later)
   - main()
1. Code to generate *.tflite was added (by calling TOCO internally)
   (Tensorflow model in python code is converted to *.tflite file.)

Remaining work:
- Supporting multiple outputs

6 years agoFix coverity error (118949) (#897)
윤현식/동작제어Lab(SR)/Principal Engineer/삼성전자 [Wed, 25 Apr 2018 08:29:25 +0000 (17:29 +0900)]
Fix coverity error (118949) (#897)

Fix coverity error (118949) (#897)

6 years agoExit on nnapi_test fail (#890)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Wed, 25 Apr 2018 07:21:16 +0000 (16:21 +0900)]
Exit on nnapi_test fail (#890)

1. remove `set +e` from nnapi_test

Now, test fails on any nnapi_test fail.

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
6 years agoAdd license for sources under src/kernel (#879)
이상규/동작제어Lab(SR)/Principal Engineer/삼성전자 [Wed, 25 Apr 2018 07:20:45 +0000 (16:20 +0900)]
Add license for sources under src/kernel (#879)

Related issue: #840, #839

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
6 years agoAdd a script for generation RootFS for Android (#884)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 25 Apr 2018 06:17:00 +0000 (15:17 +0900)]
Add a script for generation RootFS for Android (#884)

This script generates a standalone build environment for Android.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
6 years agoCheck if ashmem region is created. (#878)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 25 Apr 2018 05:57:27 +0000 (14:57 +0900)]
Check if ashmem region is created. (#878)

This commit checks if ashmem region is created.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
6 years agoWorkaround: temporary disable concat2 test (#889)
오형석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Wed, 25 Apr 2018 01:47:05 +0000 (10:47 +0900)]
Workaround: temporary disable concat2 test (#889)

Temporary disable concat2 test until problem solved

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
6 years agoBuild runtime only for SVACE (#888)
오형석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Wed, 25 Apr 2018 01:40:36 +0000 (10:40 +0900)]
Build runtime only for SVACE (#888)

Build runtime only for SVACE report

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
6 years agoRemove execute mode from source files in NN runtime (#876)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Wed, 25 Apr 2018 00:51:11 +0000 (09:51 +0900)]
Remove execute mode from source files in NN runtime (#876)

- Remove execute mode from source files in NN runtime

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoRemove dead code in Activation.cpp (#862)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Wed, 25 Apr 2018 00:50:33 +0000 (09:50 +0900)]
Remove dead code in Activation.cpp (#862)

- Remove dead code in Activation.cpp
- This was reported as UNCHECKED_FUNC_RES.STAT from SVACE

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoAdd rootfs for ARM64 (#877)
김용섭/동작제어Lab(SR)/Engineer/삼성전자 [Wed, 25 Apr 2018 00:49:19 +0000 (09:49 +0900)]
Add rootfs for ARM64 (#877)

* Add rootfs for ARM64

Prepares nnfw to support cross/ARM64 build

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
6 years agoRemove double semicolon in Memory code (#881)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Tue, 24 Apr 2018 10:45:16 +0000 (19:45 +0900)]
Remove double semicolon in Memory code (#881)

This commit removes double semicolon in Memory code.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
6 years agoClose 'dupfd' if returned unexpected null (#861)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Tue, 24 Apr 2018 10:39:21 +0000 (19:39 +0900)]
Close 'dupfd' if returned unexpected null (#861)

This commit closes 'dupfd' if returned unexpected null.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
6 years agoMake option: runtime build only (#864)
오형석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Tue, 24 Apr 2018 10:10:51 +0000 (19:10 +0900)]
Make option: runtime build only (#864)

Introduce new make option: runtime build only
Can build runtime only by "make runtime"

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
6 years agoDisable depthwiseConvQuant8 in NN runtime (#866)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Tue, 24 Apr 2018 08:08:02 +0000 (17:08 +0900)]
Disable depthwiseConvQuant8 in NN runtime (#866)

- Disable depthwiseConvQuant8 in NN runtime
- We disable this because
  - we don't have test set for this yet
  - and we want to exclude unused code from code coverage test.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoUpdate pthread to `${LIB_PTHREAD}` (#868)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Tue, 24 Apr 2018 08:07:38 +0000 (17:07 +0900)]
Update pthread to `${LIB_PTHREAD}` (#868)

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
6 years agoscript to download model files (#858)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Tue, 24 Apr 2018 08:07:23 +0000 (17:07 +0900)]
script to download model files (#858)

Usage : ./run_test.sh --download=on

6 years agoFix incorrect md5sum for inceptionv3_module (#854)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Tue, 24 Apr 2018 08:04:52 +0000 (17:04 +0900)]
Fix incorrect md5sum for inceptionv3_module (#854)

6 years ago[Build] Support Android build for nnapi_test (#869)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Tue, 24 Apr 2018 07:53:03 +0000 (16:53 +0900)]
[Build] Support Android build for nnapi_test (#869)

Support Android build for nnapi_test and its dependencies.
Need to add a document how to create rootfs.

Fix #515

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
6 years agoFix typo of a condition (#873)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Tue, 24 Apr 2018 07:45:08 +0000 (16:45 +0900)]
Fix typo of a condition (#873)

`&` here is supposed to be `&&`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
6 years agoFix memory leak in Conv2D.cpp (#865)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Tue, 24 Apr 2018 07:28:54 +0000 (16:28 +0900)]
Fix memory leak in Conv2D.cpp (#865)

- Fix memory leak in Conv2D.cpp
- These were reported as MEMORY_LEAK.EX in SVACE (Issue #849, #850)

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoRemove unnecessary return statement (#846)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Tue, 24 Apr 2018 04:30:00 +0000 (13:30 +0900)]
Remove unnecessary return statement (#846)

- Remove unnecessary return statement which make below code unreachable.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years agoRemove tools and depend directory from coverage (#856)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Tue, 24 Apr 2018 04:29:25 +0000 (13:29 +0900)]
Remove tools and depend directory from coverage (#856)

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
6 years agoFix c++ and python coding format in tools (#843)
오형석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Tue, 24 Apr 2018 04:06:49 +0000 (13:06 +0900)]
Fix c++ and python coding format in tools (#843)

Fix c++ and python format based on decided coding rule

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
6 years agoupload concatenation files to the mooo server (#836)
최성진/동작제어Lab(SR)/Principal Engineer/삼성전자 [Tue, 24 Apr 2018 01:02:10 +0000 (10:02 +0900)]
upload concatenation files to the mooo server (#836)

Signed-off-by: SungJin Choi <lotieye.choi@samsung.com>
6 years agoDocker build for svace analyzer (#844)
오형석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Mon, 23 Apr 2018 13:34:18 +0000 (22:34 +0900)]
Docker build for svace analyzer (#844)

Add script for docker build with svace analyzer

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
6 years agoFix test error on tizen (#847)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Mon, 23 Apr 2018 10:41:37 +0000 (19:41 +0900)]
Fix test error on tizen (#847)

dirname does not accept multiple arguments.
To run test on tizen, dirname is executed as a part of find command.

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
6 years agoFramework tests for RELU and RELU6 operations (#830)
Siva Sai Vaddipati/SRI-Bangalore-System SW/./삼성전자 [Mon, 23 Apr 2018 08:29:33 +0000 (13:59 +0530)]
Framework tests for RELU and RELU6 operations (#830)

* Framework tests for RELU and RELU6 operations

This commit enables the framework tests for RELU and RELU6 activation functions

* Update config.sh

6 years agoAdd reshape op to NNFWKernel to test performance (#835)
최성진/동작제어Lab(SR)/Principal Engineer/삼성전자 [Mon, 23 Apr 2018 05:24:42 +0000 (14:24 +0900)]
Add reshape op to NNFWKernel to test performance (#835)

Signed-off-by: SungJin Choi <lotieye.choi@samsung.com>
6 years agoRemove external/protobuf and tools/tf_model_tools (#826)
서상민/동작제어Lab(SR)/Senior Engineer/삼성전자 [Sun, 22 Apr 2018 23:35:44 +0000 (08:35 +0900)]
Remove external/protobuf and tools/tf_model_tools (#826)

For #553

This patch removes external/protobuf and tools/tf_model_tools.

tools/tf_model_tools has been copied to
https://github.sec.samsung.net/RS7-RuntimeNTools/nnas_tools

Signed-off-by: Sangmin Seo <sangmin7.seo@samsung.com>
6 years agoTFLite model tool: PEP8 Format (#821)
오형석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 20 Apr 2018 09:28:08 +0000 (18:28 +0900)]
TFLite model tool: PEP8 Format (#821)

Fix python code format based on PEP8

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
6 years agoRemove local repo from gbs build (#817)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 20 Apr 2018 07:40:13 +0000 (16:40 +0900)]
Remove local repo from gbs build (#817)

1. remove local repo
2. add --include-all option to gbs build command for local test

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
6 years agoCheck C++ files: .cc extension (#822)
오형석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 20 Apr 2018 07:39:15 +0000 (16:39 +0900)]
Check C++ files: .cc extension (#822)

Add .cc extension to check C++ coding rule

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
6 years agoIntroduce 'libs' directory (#820)
박종현/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 20 Apr 2018 07:38:53 +0000 (16:38 +0900)]
Introduce 'libs' directory (#820)

This commit introduces 'libs' directory which will hold various
libraries used for runtime implementation.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
6 years agoFix build break for benchmark on ci (#819)
김용섭/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 20 Apr 2018 06:16:45 +0000 (15:16 +0900)]
Fix build break for benchmark on ci (#819)

Print json with quot. Exactly its spec is not well descriptive. This
solution is workaround.

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
6 years agoUpdate document of docker image (#790)
최형규/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 20 Apr 2018 04:06:30 +0000 (13:06 +0900)]
Update document of docker image (#790)

- Update document of docker image
- The latest version of docker image is nnfw_docker:1.4

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
6 years ago[Build] Fix hardcoded value from Makefile (#786)
이한종/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 20 Apr 2018 04:00:25 +0000 (13:00 +0900)]
[Build] Fix hardcoded value from Makefile (#786)

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
6 years agoPrint benchmark's result to json (#811)
김용섭/동작제어Lab(SR)/Engineer/삼성전자 [Fri, 20 Apr 2018 01:43:10 +0000 (10:43 +0900)]
Print benchmark's result to json (#811)

* Print benchmark's result to json

Print benchmark's result to json for visualizing on jenkins. The json
file's content fit to specification of benchmark(one of jenkins plugin).

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
6 years agoUnify NEON and OpenCL versions of Reshape unit test (#813)
김정현/동작제어Lab(SR)/Senior Engineer/삼성전자 [Fri, 20 Apr 2018 01:19:11 +0000 (10:19 +0900)]
Unify NEON and OpenCL versions of Reshape unit test (#813)

- extract common features to `src/Reshape.test.h`
- implement different parts into `neon/Reshape.test.cpp` and
  `cl/Reshape.test.cpp`

Signed-off-by: Junghyun Kim <jh0822.kim@samsung.com>
6 years agoAdd coverage report script for CI (#801)
이춘석/동작제어Lab(SR)/Senior Engineer/삼성전자 [Thu, 19 Apr 2018 23:46:56 +0000 (08:46 +0900)]
Add coverage report script for CI (#801)

This script is used on CI to generate lcov coverage info.

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
6 years agoCheck nullptr of the buffer in setInput (#807)
김수진/동작제어Lab(SR)/Engineer/삼성전자 [Thu, 19 Apr 2018 09:04:07 +0000 (18:04 +0900)]
Check nullptr of the buffer in setInput (#807)

* Check nullptr of the buffer in setInput

This commit checks nullptr of the buffer in setInput to fix #806.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Separate nullptr checks in setInput

6 years agoEnabling RELU and RELU6 (#787)
Siva Sai Vaddipati/SRI-Bangalore-System SW/./삼성전자 [Thu, 19 Apr 2018 09:02:33 +0000 (14:32 +0530)]
Enabling RELU and RELU6 (#787)

Enable relu and relu6 operations in cpuexecutor