philn@webkit.org [Thu, 12 Apr 2012 15:48:13 +0000 (15:48 +0000)]
Unreviewed, GTK test_expectations post-Skipped-migration update.
* platform/gtk/fast/dynamic/layer-hit-test-crash-expected.txt:
* platform/gtk/http/tests/misc/acid2-expected.txt:
* platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Copied from LayoutTests/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt.
* platform/gtk/svg/hixie/perf/001-expected.txt: Added.
* platform/gtk/svg/hixie/perf/002-expected.txt: Added.
* platform/gtk/svg/hixie/perf/003-expected.txt:
* platform/gtk/svg/hixie/perf/004-expected.txt:
* platform/gtk/svg/hixie/perf/005-expected.txt:
* platform/gtk/svg/hixie/perf/006-expected.txt:
* platform/gtk/svg/hixie/perf/007-expected.txt:
* platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
* platform/gtk/svg/text/text-deco-01-b-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/gtk/test_expectations.txt:
* svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 12 Apr 2012 15:43:30 +0000 (15:43 +0000)]
[Chromium] LayoutTest update for several Mac filter tests
https://bugs.webkit.org/show_bug.cgi?id=83717
Unreviewed Chromium test expectations update.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
* platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/foreign-object-skew-expected.png: Modified property svn:mime-type.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 12 Apr 2012 15:38:48 +0000 (15:38 +0000)]
More Mac rebaselines.
Unreviewed.
* platform/chromium-mac-leopard/css2.1/
20110323/replaced-elements-001-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Thu, 12 Apr 2012 15:35:13 +0000 (15:35 +0000)]
[Qt][WK2] Nested fixed elements scroll too fast
https://bugs.webkit.org/show_bug.cgi?id=83720
Reviewed by Noam Rosenthal.
.:
* ManualTests/nested-fixed-position.html: Added.
Source/WebCore:
Before setting the scrollPositionDelta to a fixed layer, check if it has an ancestor which also has fixed position.
If it does, do not set scrollPositionDelta.
Added a flag to TextureMapperLayer and GraphicsLayerTextureMapper indicating if it is a fixed position layer.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::setFixedToViewport):
(WebCore::GraphicsLayerTextureMapper::fixedToViewport):
(GraphicsLayerTextureMapper):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
(WebCore::TextureMapperLayer::isAncestorFixedToViewport):
(WebCore):
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
* platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
(WebCore::TextureMapperLayer::setFixedToViewport):
Source/WebKit2:
Set the fixedToViewport flag on the fixed position layers and adjust to
the new function name for setting scrollPositionDelta.
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::setLayerState):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Thu, 12 Apr 2012 15:32:21 +0000 (15:32 +0000)]
[Qt] Unreviewed gardening after r113968
Since we now use QRawFont, some tests need a Qt5 specific baseline.
* platform/qt-5.0/Skipped: skipped two tests with suspicious results.
* platform/qt-5.0/css1/text_properties/letter_spacing-expected.txt: Added.
* platform/qt-5.0/editing/inserting/5549929-2-expected.txt: Added.
* platform/qt-5.0/editing/inserting/5549929-3-expected.txt: Added.
* platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt: Added.
* platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt: Added.
* platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt: Added.
* platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt: Added.
* platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt: Added.
* platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt: Added.
* platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt: Added.
* platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt: Added.
* platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt: Added.
* platform/qt-5.0/editing/pasteboard/paste-text-at-tabspan-003-expected.txt: Added.
* platform/qt-5.0/editing/selection/editable-html-element-expected.txt: Added.
* platform/qt-5.0/editing/selection/extend-by-word-001-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt: Added.
* platform/qt-5.0/fast/css/word-space-extra-expected.txt: Added.
* platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
* platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
* platform/qt-5.0/fast/table/border-collapsing/004-expected.txt: Added.
* platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt: Added.
* platform/qt-5.0/fast/text/text-letter-spacing-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/textPosition-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/textPosition2-expected.txt: Added.
* platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
* platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 12 Apr 2012 15:12:44 +0000 (15:12 +0000)]
[GTK] Migrate Skipped tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=83768
Reviewed by Martin Robinson.
This will hopefully simplify gardening tasks. The tests without
bug entry have been marked with BUGWKGTK and the most problematic
suites (mostly for unimplemented or heavily unreliable features
(inspector)) have been SKIP flagged.
* platform/gtk/Skipped: Removed.
* platform/gtk/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mifenton@rim.com [Thu, 12 Apr 2012 15:09:33 +0000 (15:09 +0000)]
Pattern matching for hexadecimal should include * as an allowable count.
https://bugs.webkit.org/show_bug.cgi?id=83779
Reviewed by Rob Buis.
Update pattern matching check to allow wildcard for number
of characters allowed.
PR 148907.
Reviewed Internally by Gen Mak.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 12 Apr 2012 15:07:22 +0000 (15:07 +0000)]
Mark test as flaky on all platforms and add new failure mode.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 12 Apr 2012 15:01:50 +0000 (15:01 +0000)]
Rebaseline Mac expectations.
Unreviewed.
* platform/chromium-mac-leopard/fast/block/float/avoiding-float-centered-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 12 Apr 2012 14:55:48 +0000 (14:55 +0000)]
Mark test as flaking on all platforms.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Thu, 12 Apr 2012 14:55:27 +0000 (14:55 +0000)]
[BlackBerry] Revert the patch for 82764
https://bugs.webkit.org/show_bug.cgi?id=83767
Reviewed by Rob Buis.
Revert the patch for 82764, which is causing misfunction.
The internal commit is:
800213f5
* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformDestroy):
* plugins/blackberry/PluginViewPrivateBlackBerry.h:
(PluginViewPrivate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 12 Apr 2012 14:52:05 +0000 (14:52 +0000)]
[Qt]{Mac] Unreviewed, skip new failing tests to paint the bot green.
* platform/qt-mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Thu, 12 Apr 2012 14:43:38 +0000 (14:43 +0000)]
Move viewport meta handling to the web process side
https://bugs.webkit.org/show_bug.cgi?id=83771
Reviewed by Simon Hausmann.
Instead of computing the viewport attributes on both sides,
we now do everything on the web process side, and just send
over the computed result.
* Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/WebCoreArgumentCoders.h:
(WebCore):
* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::didChangeViewportProperties):
* UIProcess/API/efl/PageClientImpl.h:
(PageClientImpl):
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::didChangeViewportProperties):
* UIProcess/API/gtk/PageClientImpl.h:
(PageClientImpl):
* UIProcess/API/mac/PageClientImpl.h:
(PageClientImpl):
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didChangeViewportProperties):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):
* UIProcess/PageClient.h:
(WebCore):
(PageClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeViewportProperties):
* UIProcess/WebPageProxy.h:
(WebCore):
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::didChangeViewportProperties):
* UIProcess/qt/QtPageClient.h:
(QtPageClient):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::didChangeViewportProperties):
* UIProcess/win/WebView.h:
(WebView):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
(WebKit):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit):
(WebKit::WebPage::setViewportSize):
* WebProcess/WebPage/WebPage.h:
(WebPage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 12 Apr 2012 14:23:42 +0000 (14:23 +0000)]
[Qt] One more unreviewed gardening after r113945 and r113961.
* platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 12 Apr 2012 14:21:52 +0000 (14:21 +0000)]
[Chromium] Enable INPUT_TYPE_DATE
https://bugs.webkit.org/show_bug.cgi?id=83761
Reviewed by Kentaro Hara.
Source/WebCore:
* html/DateInputType.cpp:
Touch it to avoid build issues. No code changes.
* html/DateInputType.h: ditto.
* html/InputType.cpp: ditto.
Source/WebKit/chromium:
* features.gypi: Turn ENABLE_INPUT_TYPE_DATE on.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 12 Apr 2012 14:13:49 +0000 (14:13 +0000)]
Web Inspector: annotate the rest of profiler front-end for closure compiler
https://bugs.webkit.org/show_bug.cgi?id=83781
All remaining Profiler front-end files are annotated for closure compiler.
Reviewed by Pavel Feldman.
* inspector/compile-front-end.py:
* inspector/front-end/CSSSelectorProfileView.js:
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorkerWrapper):
(WebInspector.HeapSnapshotWorkerWrapper.prototype.postMessag):
(WebInspector.HeapSnapshotWorkerWrapper.prototype.terminate):
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod):
(WebInspector.HeapSnapshotProxyObject.prototype.callMethod):
* inspector/front-end/HeapSnapshotWorkerDispatcher.js:
* inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
* inspector/front-end/externs.js:
(addEventListener):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 13:39:54 +0000 (13:39 +0000)]
Web Inspector: Node Value should not get corrupt while jump over different matches in search.
https://bugs.webkit.org/show_bug.cgi?id=83758
The order in which updateEntryHide is called for cached
highlightResults is changed in "last changed first corrected" order to preserve the semantic of node.
Patch by Sam D <dsam2912@gmail.com> on 2012-04-12
Reviewed by Pavel Feldman.
No new tests required.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._updateSearchHighlight):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 13:33:24 +0000 (13:33 +0000)]
[GTK] Test runner crashes without recent versions of pulseaudio-utils
https://bugs.webkit.org/show_bug.cgi?id=83774
Patch by Simon Pena <spena@igalia.com> on 2012-04-12
Reviewed by Philippe Normand.
Besides checking that pactl is available, check also that its output
is the expected one, and handle gracefully when it isn't, when
trying to unload pulseaudio modules.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._unload_pulseaudio_module):
(GtkPort._restore_pulseaudio_module):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Thu, 12 Apr 2012 13:28:22 +0000 (13:28 +0000)]
[Qt] Use QRawFont when building with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=78001
Source/WebCore:
Up until now, fonts in the Qt port have been handled via
the QFont API. QRawFont offers a lower-level API enabling
us to be more in line with what other WebKit ports do.
This patch proceeds to switching over to QRawFont, and
effectively use an earlier change by Andreas Kling
that remained guarded up until now.
Reviewed by Simon Hausmann.
No new tests since this is refactoring of existing
functionality.
* Target.pri:
* platform/graphics/Font.cpp:
(WebCore::Font::drawText):
* platform/graphics/Font.h:
(Font):
(WebCore):
(WebCore::Font::syntheticFont): Added.
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::getQtRawFont):
(WebCore):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::rawFontForCharacters):
(WebCore):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/qt/FontCustomPlatformData.h:
(FontCustomPlatformData):
* platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
(FontPlatformDataPrivate):
(FontPlatformData):
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore):
(WebCore::FontPlatformData::operator==):
* platform/graphics/qt/FontQt.cpp:
(WebCore::fillPenForContext):
(WebCore::pathForGlyphs):
(WebCore::drawQtGlyphRun):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::initFormatForTextLayout):
(WebCore):
(WebCore::Font::drawGlyphs):
(WebCore::Font::syntheticFont):
(WebCore::Font::rawFont):
* platform/graphics/qt/FontQt4.cpp: Copied from Source/WebCore/platform/graphics/qt/FontQt.cpp.
(WebCore):
(WebCore::fromRawDataWithoutRef):
(WebCore::setupLayout):
(WebCore::fillPenForContext):
(WebCore::strokePenForContext):
(WebCore::drawTextCommon):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):
(WebCore::Font::primaryFontHasGlyphForCharacter):
(WebCore::Font::emphasisMarkAscent):
(WebCore::Font::emphasisMarkDescent):
(WebCore::Font::emphasisMarkHeight):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::font):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::fileListNameForWidth):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
Source/WebKit/qt:
Since QFont is not used internally, we now need
to query for a QFont that should be a good
enough match.
Reviewed by Simon Hausmann.
* Api/qwebpage.cpp:
(QWebPage::inputMethodQuery):
* WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):
* WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
Tools:
Flip the QRawFont switch for Qt 5.
Reviewed by Simon Hausmann.
* qmake/mkspecs/features/features.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 13:22:26 +0000 (13:22 +0000)]
Calculate the cover rect of tiled backing store with the trajectory vector.
https://bugs.webkit.org/show_bug.cgi?id=83462
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-04-12
Reviewed by Kenneth Rohde Christiansen.
When trajectory vector is not zero, it is able to calculate the proper cover area.
No new tests - no new functionality.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 12 Apr 2012 13:12:48 +0000 (13:12 +0000)]
Source/WebCore: Web Inspector: extracting NetworkRequest from Resource (step 2)
https://bugs.webkit.org/show_bug.cgi?id=83773
Reviewed by Yury Semikhatsky.
This step moves request-related views from being resource-based to request-based.
See https://bugs.webkit.org/show_bug.cgi?id=61363 for the meta bug.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/ContentProviders.js:
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
(WebInspector.RequestContentView):
(WebInspector.RequestContentView.prototype._ensureInnerViewShown):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._showPopover):
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.resource):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createContentProvider):
* inspector/front-end/RequestCookiesView.js: Renamed from Source/WebCore/inspector/front-end/ResourceCookiesView.js.
(WebInspector.RequestCookiesView):
* inspector/front-end/RequestHTMLView.js: Renamed from Source/WebCore/inspector/front-end/ResourceHTMLView.js.
(WebInspector.RequestHTMLView):
(WebInspector.RequestHTMLView.prototype._createIFrame):
* inspector/front-end/RequestHeadersView.js: Renamed from Source/WebCore/inspector/front-end/ResourceHeadersView.js.
(WebInspector.RequestHeadersView):
* inspector/front-end/RequestJSONView.js: Renamed from Source/WebCore/inspector/front-end/ResourceJSONView.js.
(WebInspector.RequestJSONView):
(WebInspector.RequestJSONView.parseJSON.WebInspector.RequestJSONView.parseJSONP):
* inspector/front-end/RequestPreviewView.js: Renamed from Source/WebCore/inspector/front-end/ResourcePreviewView.js.
(WebInspector.RequestPreviewView):
(WebInspector.RequestPreviewView.prototype.contentLoaded):
(WebInspector.RequestPreviewView.prototype._createPreviewView):
* inspector/front-end/RequestResponseView.js: Renamed from Source/WebCore/inspector/front-end/ResourceResponseView.js.
(WebInspector.RequestResponseView):
(WebInspector.RequestResponseView.prototype.get sourceView):
(WebInspector.RequestResponseView.prototype.contentLoaded):
* inspector/front-end/RequestTimingView.js: Renamed from Source/WebCore/inspector/front-end/ResourceTimingView.js.
(WebInspector.RequestTimingView):
(WebInspector.RequestTimingView.prototype._refresh):
* inspector/front-end/RequestView.js: Copied from Source/WebCore/inspector/front-end/NetworkRequest.js.
(WebInspector.RequestView):
(WebInspector.RequestView.prototype.hasContent):
(WebInspector.RequestView.hasTextContent):
(WebInspector.RequestView.nonSourceViewForRequest):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame._canonicalMIMEType):
(WebInspector.ResourceSourceFrame._mimeTypeForResource):
(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
Tools: Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.
The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
LayoutTests: Web Inspector: extracting NetworkRequest from Resource (step 2)
https://bugs.webkit.org/show_bug.cgi?id=83773
Reviewed by Yury Semikhatsky.
* http/tests/inspector/network/network-request-revision-content.html:
* http/tests/inspector/network/request-parameters-decoding.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 12 Apr 2012 12:42:04 +0000 (12:42 +0000)]
[Qt] Unreviewed gardening after r113945, update platform specific expected files.
* platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt-5.0/Skipped: Unskip dom/prototype-inheritance-2.html and update its results.
* platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 12 Apr 2012 12:19:23 +0000 (12:19 +0000)]
2012-04-12 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix a couple of compiler annotations after r113963.
* inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridTree):
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 12 Apr 2012 12:03:46 +0000 (12:03 +0000)]
Web Inspector: add closure compiler annotations for profiler code
https://bugs.webkit.org/show_bug.cgi?id=83700
Basic type annotations are added to most of the profiler front-end. Some
dead code removed.
Reviewed by Pavel Feldman.
* inspector/compile-front-end.py:
* inspector/front-end/BinarySearch.js:
(Object.defineProperty):
* inspector/front-end/BottomUpProfileDataGridTree.js:
(WebInspector.BottomUpProfileDataGridNode.prototype._restore):
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
(WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
(WebInspector.BottomUpProfileDataGridTree):
* inspector/front-end/DataGrid.js:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._changeBase):
(WebInspector.DetailedHeapshotView.prototype._setRetainmentDataGridSource):
(WebInspector.DetailedHeapshotView.prototype._helpClicked.appendHelp):
(WebInspector.DetailedHeapshotView.prototype._helpClicked):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot):
(HeapSnapshotMetainfo):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.insertChild):
(WebInspector.ProfileDataGridNode.prototype.removeChild):
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
(WebInspector.ProfileDataGridNode.prototype._populate):
(WebInspector.ProfileDataGridTree.propertyComparator):
* inspector/front-end/ProfileView.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.parsed):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype.performSearch.finishedCallback):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
* inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridTree):
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
* inspector/front-end/externs.js:
(Array.prototype.binaryIndexOf):
(Array.prototype.sortRange):
(WebInspector.CSSSelectorProfileType):
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotWorker.prototype.createObject):
(WebInspector.HeapSnapshotWorker.prototype.startCheckingForLongRunningCalls):
* inspector/front-end/heapProfiler.css:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 11:12:10 +0000 (11:12 +0000)]
[Qt][WK2] Zoom gesture with double tap crashes on iframe when main frame has scroll offset.
https://bugs.webkit.org/show_bug.cgi?id=83428
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-12
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
When delegate scrolling is on, the frame view needs to ignore scrolling offset when converting
coordinates. It is already done at ScrollView base class and this patch copies the logic to the
FrameView subclass.
Also make sure that TouchAdjustment's findBest*() functions' return value are not ignored by the caller.
Test: touchadjustment/iframe-with-mainframe-scroll-offset.html
* page/EventHandler.cpp:
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
* page/EventHandler.h:
(EventHandler):
* page/FrameView.cpp:
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
* page/GestureTapHighlighter.cpp:
* testing/Internals.cpp:
(WebCore::Internals::setDelegatesScrolling):
(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::bestZoomableAreaForTouchPoint):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit2:
When delegate scrolling is on, the frame view needs to ignore scrolling offset when converting
coordinates. It is already done at ScrollView base class and this patch copies the logic to the
FrameView subclass.
Also make sure that TouchAdjustment's findBest*() functions' return value are not ignored by the caller.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):
LayoutTests:
* touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset-expected.txt: Added.
* touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html: Added.
* touchadjustment/zoom-basic.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 12 Apr 2012 11:01:40 +0000 (11:01 +0000)]
[Qt] Unreviewed gardening after r113945, update platform specific expected files.
* platform/qt-4.8/fast/dom/Window/window-properties-expected.txt:
* platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt-5.0/fast/dom/Window/window-properties-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 12 Apr 2012 10:52:14 +0000 (10:52 +0000)]
[Qt] Two canvas tests fail with QT_IMAGE_DECODER=0 setup
https://bugs.webkit.org/show_bug.cgi?id=83764
The following tests were failed after r108792:
- canvas-toDataURL-case-insensitive-mimetype.html
- toDataURL-supportedTypes.html
because supportedImageMIMETypesForEncoding wasn't filled
with MIME types in case of QT_IMAGE_DECODER=0 build setup.
Patch by Zoltan Horvath <zoltan@webkit.org> on 2012-04-12
Reviewed by Csaba Osztrogonác.
Fixes existing tests.
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypesForEncoding):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 10:32:26 +0000 (10:32 +0000)]
Unreviewed, rolling out r113931.
http://trac.webkit.org/changeset/113931
https://bugs.webkit.org/show_bug.cgi?id=83766
broke 4 tests on JSC platforms (Requested by philn-tp on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12
Source/WebCore:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::createPrototype):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8BindingPerContextData.cpp:
(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):
* bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/WrapperTypeInfo.h:
(WrapperTypeInfo):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* dom/NodeList.idl:
LayoutTests:
* fast/dom/HTMLSelectElement/named-options-expected.txt:
* fast/dom/HTMLSelectElement/script-tests/named-options.js:
* fast/dom/NodeList/node-list-array-class-expected.txt: Removed.
* fast/dom/NodeList/node-list-array-class.html: Removed.
* fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
* platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
* platform/chromium/inspector/console/command-line-api-expected.txt: Removed.
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 12 Apr 2012 10:26:42 +0000 (10:26 +0000)]
[Chromium] Fix !ENABLE(PAGE_POPUP) build
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl): Wrap m_pagePopup with ENABLE(PAGE_POPUP).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Thu, 12 Apr 2012 10:19:27 +0000 (10:19 +0000)]
Unreviewed, remove test expectations for worker-reload.html, as
the source of flakiness was removed in r113292.
* platform/chromium/test_expectations.txt:
* platform/mac/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 12 Apr 2012 09:59:33 +0000 (09:59 +0000)]
[Chromium] Add PagePopup implementation
https://bugs.webkit.org/show_bug.cgi?id=81081
Reviewed by Adam Barth.
Add WebPagePopupImpl class, which is an implementation of
WebCore::PagePopup interface and WebKit::WebPagePopup interface. It's a
WebWidget which has a Page object.
No new tests because this makes no behavior change yet.
* WebKit.gyp: Add WebPagePopupImpl.h.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::hasOpenedPopup): Supports the PagePopup.
(WebKit::ChromeClientImpl::openPagePopup):
just delegate to WebViewImpl::openPagePopup().
(WebKit::ChromeClientImpl::closePagePopup): ditto.
* src/WebPagePopupImpl.cpp:
(PagePopupChromeClient):
This is a light implementation of ChromeClient for the page in
WebPagePopupImpl. This is a friend of WebPagePopupImpl becase of ease of
access to its members.
(WebKit::PagePopupChromeClient::PagePopupChromeClient):
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
(WebKit::WebPagePopupImpl::~WebPagePopupImpl):
(WebKit::WebPagePopupImpl::init):
(WebKit::WebPagePopupImpl::initPage):
(WebKit::WebPagePopupImpl::size):
(WebKit::WebPagePopupImpl::animate): Calls PageWidgetDelegate::animate().
(WebKit::WebPagePopupImpl::composite):
(WebKit::WebPagePopupImpl::layout): Calls PageWidgetDelegate::layout().
(WebKit::WebPagePopupImpl::paint): Calls PageWidgetDelegate::paint().
(WebKit::WebPagePopupImpl::resize):
(WebKit::WebPagePopupImpl::handleKeyEvent):
(WebKit::WebPagePopupImpl::handleCharEvent):
(WebKit::WebPagePopupImpl::handleGestureEvent):
(WebKit::WebPagePopupImpl::handleInputEvent):
(WebKit::WebPagePopupImpl::setFocus):
(WebKit::WebPagePopupImpl::close): Delete the page, and kill itself.
(WebKit::WebPagePopupImpl::closePopup):
(WebKit::WebPagePopup::create):
* src/WebPagePopupImpl.h: Added.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl): Initialize m_pagePopup.
(WebKit::WebViewImpl::handleKeyEvent):
Renamed from keyEvent(). Forward key events to a PagePopup if it is open.
(WebKit::WebViewImpl::handleCharEvent):
Renamed from charEvent(). Forward char events to a PagePopup if it is open.
(WebKit::WebViewImpl::openPagePopup):
Added. Instantiate a WebPagePopupImpl, calculates a good bounding
rectangle of the page popup from the specified element rectangle,
initialize the WebPagePopupImpl, and stop caret blink.
(WebKit::WebViewImpl::closePagePopup):
Close the popup, clear m_pagePopup, and resume caret blink.
(WebKit::WebViewImpl::setFocus): Hide all the popups.
(WebKit::WebViewImpl::hidePopups): Hide the page popup too.
* src/WebViewImpl.h:
(WebKit::WebViewImpl::hasOpenedPopup): Checks the page popup too.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 12 Apr 2012 09:51:00 +0000 (09:51 +0000)]
[Qt][ARM] Buildfix after r113934.
Reviewed by Zoltan Herczeg.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::compare8):
(MacroAssemblerARM):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 12 Apr 2012 09:01:45 +0000 (09:01 +0000)]
[Qt] Unreviewed gardening after r113885.
* platform/qt/css2.1/
20110323/replaced-elements-001-expected.png:
* platform/qt/css2.1/
20110323/replaced-elements-001-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Thu, 12 Apr 2012 08:51:40 +0000 (08:51 +0000)]
[BlackBerry] Upstreaming BlackBerry-specific changes to PluginView -- remove unused functions
https://bugs.webkit.org/show_bug.cgi?id=83756
Reviewed by George Staikos.
PluginView::halt(), PluginView::restart() have been removed from
upstreaming code, should remove them from BlackBerry porting also.
* plugins/blackberry/PluginViewBlackBerry.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 12 Apr 2012 08:50:53 +0000 (08:50 +0000)]
[Qt] Unreveiwed gardening. Skip the failing reftest.
* platform/qt/Skipped: skip fast/workers/worker-multi-startup.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Thu, 12 Apr 2012 08:49:04 +0000 (08:49 +0000)]
[Chromium] The size of glyphStorage should be passed to substituteWithVerticalGlyphs()
https://bugs.webkit.org/show_bug.cgi?id=83751
Reviewed by Kent Tamura.
The last argument of substituteWithVerticalGlyphs() should be
the size of |glyphStorage|.
No new tests because we can't test the fix by layout tests.
I confirmed the fix with ASAN.
* platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::GlyphPage::fill):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 08:37:26 +0000 (08:37 +0000)]
[BlackBerry] We shouldn't set empty Content-Length & Content-Type to a request's headers.
https://bugs.webkit.org/show_bug.cgi?id=83349
When there is a redirection for a POST request, we change POST to GET and set
Content-Length/Content-Type to empty strings.
We should remove these headers instead of adding empty strings.
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-12
Reviewed by George Staikos.
No new tests. Refactor.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleRedirect):
* platform/network/blackberry/ResourceRequest.h:
(ResourceRequest):
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::clearHTTPContentLength):
(WebCore):
(WebCore::ResourceRequest::clearHTTPContentType):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Thu, 12 Apr 2012 08:31:26 +0000 (08:31 +0000)]
[Qt] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
https://bugs.webkit.org/show_bug.cgi?id=83746
Reviewed by Simon Hausmann.
Canonical image mimeTypes begin with "image/", and this is tested by an ASSERT
guard in toDataURL(): that checks the WebCore mimeType registry for image-for-
encoding mimeType. There is no need to also test mimeType.startsWith("image/")
since that is a given.
No new tests. Covered by existing fast/canvas/*toDataURL* tests.
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::toDataURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 12 Apr 2012 08:22:26 +0000 (08:22 +0000)]
[Chromium] Move some code of WebViewImpl and WebFrameImpl to PageWidgetDelegate
https://bugs.webkit.org/show_bug.cgi?id=83750
Reviewed by Adam Barth.
In order to share code in WebViewImpl and the incoming WebPagePopupImpl,
we move some code of WebViewImpl and WebFrameImpl to PageWidgetDelegate.
PageWidgetDelegate is a set of static functions because we can't use
virtual inheritance in this case and we don't want to move WebView's
data members to another class.
No new tests. Just refactoring.
* WebKit.gyp: Add PageWidgetDelegate.{cpp,h} and WebPagePopupImpl.h.
* src/PageWidgetDelegate.cpp: Added.
(WebKit::mainFrameView):
(WebKit::PageWidgetDelegate::animate):
Moved from a part of WebViewImpl::animatie()
(WebKit::PageWidgetDelegate::layout):
Moved from WebViewImpl::layout() and WebFrameImpl::layout().
(WebKit::PageWidgetDelegate::paint):
Moved from WebFrameImpl::paint() and paintWithContext().
(WebKit::PageWidgetDelegate::handleInputEvent):
Moved from a part of WebViewImpl::handleInputEvent().
(WebKit::PageWidgetEventHandler::handleMouseMove):
Common implementation of an event handling.
(WebKit::PageWidgetEventHandler::handleMouseLeave): ditto.
(WebKit::PageWidgetEventHandler::handleMouseDown): ditto.
(WebKit::PageWidgetEventHandler::handleMouseUp): ditto.
(WebKit::PageWidgetEventHandler::handleMouseWheel): ditto.
(WebKit::PageWidgetEventHandler::handleTouchEvent): ditto.
* src/PageWidgetDelegate.h: Added.
* src/WebFrameImpl.cpp:
Remove layout(), paintWithContext(), and paint(). They are moved to
PageWidgetDelegate.
* src/WebFrameImpl.h:
(WebFrameImpl): Remove layout(), paintWithContext(), and paint().
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseLeave):
Renamed from mouseLeave(), use PageWidgetDelegate::handleMouseLeave().
(WebKit::WebViewImpl::handleMouseDown):
Renamed from mouseDown(), use PageWidgetDelegate::handleMouseDown().
(WebKit::WebViewImpl::handleMouseUp):
Renamed from mouseUp(), use PageWidgetDelegate::handleMouseUp().
(WebKit::WebViewImpl::scrollBy): Calls renamed handleMouseWheel().
(WebKit::WebViewImpl::handleGestureEvent): Renamed from gestureEvent().
(WebKit::WebViewImpl::handleKeyEvent): Renamed from keyEvent().
(WebKit::WebViewImpl::handleCharEvent): Renamed from charEvent().
(WebKit::WebViewImpl::updateAnimations): Uses PageWidgetDelegate::animate().
(WebKit::WebViewImpl::layout): Uses PageWidgetDelegate::layout().
(WebKit::WebViewImpl::paint): Uses PageWidgetDelegate::paint().
(WebKit::WebViewImpl::handleInputEvent): Uses PageWidgetDelegate::handleInputEvent().
* src/WebViewImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 12 Apr 2012 08:09:03 +0000 (08:09 +0000)]
[chromium] Fix Windows compiler warnings in webkit_unit_test target
https://bugs.webkit.org/show_bug.cgi?id=83732
Reviewed by Kent Tamura.
* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
* tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
* tests/CCQuadCullerTest.cpp:
(WebCore::TEST):
* tests/FloatQuadTest.cpp:
(WebCore::TEST):
* tests/ScrollAnimatorNoneTest.cpp:
(TEST_F):
* tests/TreeSynchronizerTest.cpp:
(WebKitTests::TEST):
* tests/WebLayerTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 12 Apr 2012 07:08:09 +0000 (07:08 +0000)]
Unreviewed, GTK rebaseline after r113945.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 12 Apr 2012 06:35:40 +0000 (06:35 +0000)]
Implement Location.ancestorOrigins
https://bugs.webkit.org/show_bug.cgi?id=83493
Reviewed by David Levin.
Source/WebCore:
Test: fast/dom/Window/Location/ancestor-origins.html
This patch implements Location.ancestorOrigins(), which returns a list
of the origins of the enclosing frames. This API has been discussed
both on webkit-dev (see discussion following
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020090.html)
and on the whatwg list (see discussion following
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035188.html).
* page/Location.cpp:
(WebCore::Location::ancestorOrigins):
(WebCore):
* page/Location.h:
(Location):
* page/Location.idl:
LayoutTests:
* fast/dom/Window/Location/ancestor-origins-expected.txt: Added.
* fast/dom/Window/Location/ancestor-origins.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 06:05:29 +0000 (06:05 +0000)]
Unreviewed rebaseline.
Patch by Antonio Gomes <agomes@rim.com> on 2012-04-11
* media/nodesFromRect-shadowContent-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 05:51:16 +0000 (05:51 +0000)]
IndexedDB: Stub out WebKit interface for get(IndexedKeyRange)
https://bugs.webkit.org/show_bug.cgi?id=83637
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-11
Reviewed by Kent Tamura.
This is just a stub-out of IDBObjectStore.get(IDBKeyRange) to coordinate
a landing in chromium
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::get):
(WebIDBObjectStore):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::get):
(WebKit):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::get):
(WebKit):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 05:40:27 +0000 (05:40 +0000)]
fast/text/international/font-fallback-to-common-script.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=83743
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-04-11
Reviewed by Kent Tamura.
Change test not assume that there is no font setting for Simplified Chinese.
* fast/text/international/font-fallback-to-common-script.html:
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 12 Apr 2012 04:19:07 +0000 (04:19 +0000)]
It is incorrect to short-circuit Branch(LogicalNot(@a)) if boolean speculations on @a may fail
https://bugs.webkit.org/show_bug.cgi?id=83744
<rdar://problem/
11206946>
Source/JavaScriptCore:
Reviewed by Andy Estes.
This does the conservative thing: it only short-circuits Branch(LogicalNot(@a)) if @a is a node
that is statically known to return boolean results.
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
LayoutTests:
Rubber stamped by Andy Estes.
* fast/js/dfg-branch-not-fail-expected.txt: Added.
* fast/js/dfg-branch-not-fail.html: Added.
* fast/js/script-tests/dfg-branch-not-fail.js: Added.
(foo):
(bar):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 03:48:45 +0000 (03:48 +0000)]
AudioContext createChannelSplitter() method should have optional argument for number of outputs
https://bugs.webkit.org/show_bug.cgi?id=83648
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-11
Reviewed by Chris Rogers.
Check https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.
Source/WebCore:
Test: webaudio/audiochannelsplitter.html
* Modules/webaudio/AudioChannelSplitter.cpp:
(WebCore::AudioChannelSplitter::create):
(WebCore::AudioChannelSplitter::AudioChannelSplitter):
(WebCore::AudioChannelSplitter::process):
* Modules/webaudio/AudioChannelSplitter.h:
(AudioChannelSplitter):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createChannelSplitter):
(WebCore):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/AudioContext.idl:
LayoutTests:
* webaudio/audiochannelsplitter-expected.txt: Added.
* webaudio/audiochannelsplitter.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Thu, 12 Apr 2012 03:34:14 +0000 (03:34 +0000)]
[BlackBerry] Revert the changes that depend on Event changes, which is reverted already internally.
https://bugs.webkit.org/show_bug.cgi?id=83456
Reviewed by George Staikos.
No new tests, just to make BlackBerry-porting to build.
* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::handleWheelEvent):
(WebCore::PluginView::handleTouchEvent):
(WebCore::PluginView::handleMouseEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 03:06:24 +0000 (03:06 +0000)]
[BlackBerry] There shouldn't be two or more Accept-Language in platformRequest's headerList.
https://bugs.webkit.org/show_bug.cgi?id=83670
FrameLoaderClientBlackBerry::dispatchWillSendRequest and NetworkManager::startJob will call
ResourceRequest::initializePlatformRequest. Accept-Language is added two times.
We should avoid the second adding to improve performance.
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-11
Reviewed by Rob Buis.
No new tests. Refactor.
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 02:10:26 +0000 (02:10 +0000)]
[BlackBerry] MMRPlayer will hang webkit thread when retrieving media metadata
https://bugs.webkit.org/show_bug.cgi?id=80978
Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-04-11
Reviewed by Rob Buis.
Source/WebCore:
RIM PR: 143471
Implemented the interface function onWaitMetadataNotified()
which starts a timer to wait for the metadata retrieving to
finish, and pops up a dialog to notify the user what to do
if there still is no metadata when the timer fires.
This patch also contributed by Max Feil <mfeil@rim.com>.
Internally reviewed by Max Feil.
Test: http/tests/media/video-throttled-load-metadata.html
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayerPrivate::onWaitMetadataNotified):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
LayoutTests:
RIM PR: 143471
Added a layout test which simulates a slow network, and starts a web worker
thread to write a log message when retrieving media metadata to see if the
webkit thread is blocked by media retrieving thread.
* http/tests/media/video-throttled-load-metadata-expected.txt: Added.
* http/tests/media/video-throttled-load-metadata-worker.js: Added.
* http/tests/media/video-throttled-load-metadata.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Thu, 12 Apr 2012 01:55:35 +0000 (01:55 +0000)]
[chromium] Fix Windows warnings in WebSocketDeflaterTest
https://bugs.webkit.org/show_bug.cgi?id=83731
Reviewed by Kent Tamura.
Use const char* instead of const char[] to suppress warnings on
Windows.
* tests/WebSocketDeflaterTest.cpp:
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Thu, 12 Apr 2012 01:38:41 +0000 (01:38 +0000)]
Invalid Union Reference in StructureStubInfo.{cpp.h}
https://bugs.webkit.org/show_bug.cgi?id=83735
Reviewed by Filip Pizlo.
Changed the references to u.getByIdProtoList and u.getByIdSelfList
to be consistent.
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::visitWeakReferences):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdSelfList):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 12 Apr 2012 01:13:07 +0000 (01:13 +0000)]
Unreviewed attempting to make Qt's eccentric hardware work.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::compare8):
(MacroAssemblerARM):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::compare8):
(MacroAssemblerMIPS):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::compare8):
(MacroAssemblerSH4):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 12 Apr 2012 01:09:06 +0000 (01:09 +0000)]
Layout Test webaudio/* is flaky
https://bugs.webkit.org/show_bug.cgi?id=83624
Reviewed by Chris Rogers.
Source/WebCore:
No new tests; fixes webaudio/ layout tests.
A merge error led to an Mutex overunlock situation, which caused all future mutex trylock
attempts to fail, but only on Windows. Remove the extraneous mutex unlock().
* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process):
LayoutTests:
Re-enable webaudio/ layout tests on chromium-win.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 12 Apr 2012 01:02:34 +0000 (01:02 +0000)]
Correct pixel snapping error in RenderBox::pixelSnappedClientWidth/Height
https://bugs.webkit.org/show_bug.cgi?id=83621
Reviewed by Eric Seidel.
Though the problem wouldn't yet manifest itself since we haven't flipped the switch on sub-pixel
layout, clientWidth and clientHeight, when pixel snapped, need to take the RenderBox's location
into account. Previously, ClientLeft/Top were used, but these are simply the width of the borders,
and don't include the box's sub-pixel location, which is needed to properly snap the width/height.
No new tests. Untestable until we switch to FractionalLayoutUnits. A test case that covers this
is in the subpixellayout branch and will land with the switch.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollWidth): Replacing a raw zero with ZERO_LAYOUT_UNIT.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Thu, 12 Apr 2012 01:00:28 +0000 (01:00 +0000)]
Add support for [ArrayClass] and use that on NodeList
https://bugs.webkit.org/show_bug.cgi?id=81573
Reviewed by Adam Barth.
With this patch NodeLists now have Array.prototype on their prototype chain which allows
methods such as forEach and map to work on NodeLists.
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-nodelist
For V8 we need to set a flag on the WrapperTypeInfo since V8 uses FunctionTemplates which
does not allow setting the prototype to a non FunctionTemplate so the prototype is therefore
set when the constructor is created.
For JSC we just pass the right prototype object when creating the NodeList prototype. JSC has
a bug (81588) that prevents toString to work as specced on Array.prototype.toString. This
causes test failures in the tests until that has been fixed.
Source/WebCore:
Test: fast/dom/NodeList/node-list-array-class.html
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Include ArrayPrototype.h if an ArrayClass.
(GenerateImplementation): If ArrayClass use arrayPrototype as prototype.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation): Adds a flag to the WrapperTypeInfo.
* bindings/scripts/IDLAttributes.txt: Adds new attribute: ArrayClass.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::createPrototype):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/v8/V8BindingPerContextData.cpp:
(WebCore::V8BindingPerContextData::init): Get the array prototype too.
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): If this is an ArrayClass we need to
set the [[Prototype]].
* bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/WrapperTypeInfo.h:
(WrapperTypeInfo):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* dom/NodeList.idl:
LayoutTests:
* fast/dom/HTMLSelectElement/named-options-expected.txt:
* fast/dom/HTMLSelectElement/script-tests/named-options.js:
* fast/dom/NodeList/node-list-array-class-expected.txt: Added.
* fast/dom/NodeList/node-list-array-class.html: Added.
* fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
* platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Copied from LayoutTests/fast/dom/HTMLSelectElement/named-options-expected.txt.
* platform/chromium/inspector/console/command-line-api-expected.txt: Added.
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 12 Apr 2012 00:55:44 +0000 (00:55 +0000)]
op_is_foo should be optimized
https://bugs.webkit.org/show_bug.cgi?id=83666
Reviewed by Gavin Barraclough.
This implements inlining of op_is_undefined, op_is_string, op_is_number,
and op_is_boolean in LLInt and the baseline JIT. op_is_object and
op_is_function are not inlined because they are quite a bit more complex.
This also implements all of the op_is_foo opcodes in the DFG, but it does
not do any type profiling based optimizations, yet.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::compare8):
(MacroAssemblerARMv7):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::compare8):
(MacroAssemblerX86Common):
* assembler/MacroAssemblerX86_64.h:
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::testPtr):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArguments):
(CCallHelpers):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
(JIT):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_is_undefined):
(JSC):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_is_undefined):
(JSC):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):
* jit/JITStubs.cpp:
(JSC):
* llint/LLIntSlowPaths.cpp:
(LLInt):
* llint/LLIntSlowPaths.h:
(LLInt):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* offlineasm/armv7.rb:
* offlineasm/instructions.rb:
* offlineasm/x86.rb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 12 Apr 2012 00:43:14 +0000 (00:43 +0000)]
Fix regression introduced in r113927.
Unreviewed, build fix.
I failed to rename skipped_tests() to skipped_layout_tests()
everywhere it needed to be renamed. The unit tests didn't catch
this because the TestPort was one of the places that didn't get
renamed :(.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.parse_expectations):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.skipped_layout_tests):
* Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations._model):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 12 Apr 2012 00:29:34 +0000 (00:29 +0000)]
If you use an IntegerOperand and want to return it with integerResult, you need to
zero extend to get rid of the box
https://bugs.webkit.org/show_bug.cgi?id=83734
<rdar://problem/
11232296>
Reviewed by Oliver Hunt.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 12 Apr 2012 00:13:39 +0000 (00:13 +0000)]
new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
https://bugs.webkit.org/show_bug.cgi?id=47528
Reviewed by Adam Barth.
The skipped-ports command has been replaced by 'webkit-patch
print-expectations', which offers the equivalent functionality
via 'webkit-patch print-expectations --platform \* -t skip'
(and other features, of course).
This also allows me to fix a nasty layering violation where the
chromium port had to know about the TestExpectations objects in
order to implement the command properly.
Lastly, this allows me to rename skipped_tests() to
skipped_layout_tests() to more consistent with
skipped_perf_tests().
This patch removes skips_layout_test() from the Port interface,
because that can't be implemented without the port knowing about
Expectations objects (and skipped-ports was the only thing using it).
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.skipped_layout_tests):
(Port.skipped_perf_tests):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_configuration_notfound):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.test_expectations_overrides):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort.skipped_layout_tests):
* Scripts/webkitpy/tool/commands/queries.py:
(execute):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(QueryCommandsTest.test_tree_status):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 11 Apr 2012 23:46:20 +0000 (23:46 +0000)]
Remove an autorelease pool made redundant by r113923.
https://bugs.webkit.org/show_bug.cgi?id=83730
Reviewed by Dan Bernstein.
Remove flushLayer()'s autorelease pool, since one now exists in the
call frame above it (in LayerFlushScheduler::runLoopObserverCallback()).
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::flushLayers):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 11 Apr 2012 23:41:53 +0000 (23:41 +0000)]
Try to fix build with XSLT disabled.
Not reviewed.
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::parseStyleSheet):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Wed, 11 Apr 2012 23:31:18 +0000 (23:31 +0000)]
File API does not support DOM events (like addEventListener)
https://bugs.webkit.org/show_bug.cgi?id=83688
Reviewed by Adam Barth.
Source/WebCore:
The IDL files where missing addEventListener, removeEventListener and dispatchEvent.
Tests: fast/filesystem/file-writer-events.html
fast/speech/scripted/basics.html
* Modules/filesystem/FileWriter.idl: Add missing methods.
* Modules/mediastream/LocalMediaStream.idl: This one gets its EventTarget from MediaStream.
* Modules/speech/SpeechRecognition.idl: Add missing methods.
LayoutTests:
* fast/filesystem/resources/file-writer-events.js:
(runTest):
* fast/speech/scripted/basics-expected.txt:
* fast/speech/scripted/basics.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 11 Apr 2012 23:28:30 +0000 (23:28 +0000)]
LayerFlushScheduler's run loop observer should have an autorelease pool.
https://bugs.webkit.org/show_bug.cgi?id=83729
Reviewed by Dan Bernstein.
LayerFlushScheduler's run loop observer needs an autorelease pool.
NSApplication creates one, but it is only drained after processing user
input. In the case where a WebView is displaying composited content but
not receiving user input, NSApplication's pool will accumulate a large
number of objects autoreleased by the run loop observer. Have
LayerFlushScheduler create an autorelease pool that is drained after
each run loop observer callback.
* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
(WebCore::LayerFlushScheduler::runLoopObserverCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 11 Apr 2012 23:20:55 +0000 (23:20 +0000)]
Split CSSStyleSheet into internal and CSSOM type
https://bugs.webkit.org/show_bug.cgi?id=83612
Reviewed by Andreas Kling.
This will complete the separation of our style sheet data structures from CSSOM.
The internal parts of CSSStyleSheet move to StyleSheetInternal. CSS parser
and style selector will now operate on internal types. Unlike other CSSOM types
CSSStyleSheets are still always instantiated to hold the top level author stylesheets
(by Nodes).
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):
* css/CSSFontFaceSrcValue.h:
(CSSFontFaceSrcValue):
* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore):
(WebCore::CSSImportRule::styleSheet):
* css/CSSImportRule.h:
(WebCore):
(StyleRuleImport):
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::styleSheet):
(CSSImportRule):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::insertRule):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseFontFaceValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseFlowThread):
* css/CSSParser.h:
(WebCore):
(CSSParser):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::addSubresourceStyleURLs):
* css/CSSReflectValue.h:
(CSSReflectValue):
* css/CSSRule.h:
(CSSRule):
* css/CSSStyleSelector.cpp:
(RuleSet):
(WebCore):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::CSSStyleSelector::determineScope):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::parseUASheet):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
Add a set for root CSSStyleSheet objects so that the wrappers created in ensureFullCSSOMWrapperForInspector
stay valid.
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::~StyleSheetInternal):
(WebCore::StyleSheetInternal::parserAppendRule):
(WebCore::StyleSheetInternal::createChildRuleCSSOMWrapper):
(WebCore::StyleSheetInternal::ruleCount):
(WebCore::StyleSheetInternal::clearCharsetRule):
(WebCore::StyleSheetInternal::clearRules):
(WebCore::StyleSheetInternal::parserSetEncodingFromCharsetRule):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):
(WebCore::StyleSheetInternal::addNamespace):
(WebCore::StyleSheetInternal::determineNamespace):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore::StyleSheetInternal::isLoading):
(WebCore::StyleSheetInternal::checkLoaded):
(WebCore::StyleSheetInternal::notifyLoadedSheet):
(WebCore::StyleSheetInternal::startLoadingDynamicSheet):
(WebCore::StyleSheetInternal::findStyleSheetOwnerNode):
(WebCore::StyleSheetInternal::findDocument):
(WebCore::StyleSheetInternal::setMediaQueries):
(WebCore::StyleSheetInternal::styleSheetChanged):
(WebCore):
(WebCore::StyleSheetInternal::baseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::StyleSheetInternal::addSubresourceStyleURLs):
(WebCore::StyleSheetInternal::parentStyleSheet):
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::media):
(WebCore::CSSStyleSheet::parentStyleSheet):
* css/CSSStyleSheet.h:
(WebCore):
(WebCore::StyleSheetInternal::create):
(WebCore::StyleSheetInternal::createInline):
(StyleSheetInternal):
(WebCore::StyleSheetInternal::ownerNode):
(WebCore::StyleSheetInternal::clearOwnerNode):
(WebCore::StyleSheetInternal::ownerRule):
(WebCore::StyleSheetInternal::originalURL):
(WebCore::StyleSheetInternal::title):
(WebCore::StyleSheetInternal::setTitle):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::finalURL):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::removeRule):
(WebCore::CSSStyleSheet::clearOwnerRule):
(WebCore::CSSStyleSheet::styleSheetChanged):
(WebCore::CSSStyleSheet::findDocument):
(WebCore::CSSStyleSheet::internal):
(WebCore::CSSStyleSheet::isCSSStyleSheet):
(WebCore::CSSStyleSheet::type):
* css/CSSValue.cpp:
(WebCore::CSSValue::addSubresourceStyleURLs):
* css/CSSValue.h:
(WebCore):
(CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::addSubresourceStyleURLs):
* css/CSSValueList.h:
(CSSValueList):
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFaceValue):
* css/CSSValuePool.h:
(WebCore):
(CSSValuePool):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
* css/PropertySetCSSStyleDeclaration.h:
(WebCore):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
* css/StylePropertySet.h:
(WebCore):
(StylePropertySet):
* css/StyleSheet.cpp:
(WebCore):
* css/StyleSheet.h:
(StyleSheet):
(WebCore::StyleSheet::media):
(WebCore::StyleSheet::ownerRule):
(WebCore::StyleSheet::isXSLStyleSheet):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::insertRule):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createCSSStyleSheet):
* dom/Document.cpp:
(WebCore::Document::updateBaseURL):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::elementSheet):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):
* dom/Document.h:
(WebCore):
(Document):
(WebCore::Document::documentUserSheets):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet):
(WebCore::ProcessingInstruction::parseStyleSheet):
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore):
(WebCore::StyledElement::addPropertyToAttributeStyle):
* dom/StyledElement.h:
(WebCore):
* html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):
* inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::styleSheetURL):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::parseAttribute):
* xml/XSLStyleSheet.h:
(XSLStyleSheet):
(WebCore::XSLStyleSheet::finalURL):
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::isLoading):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 23:14:28 +0000 (23:14 +0000)]
Unreviewed, rolling out r113912.
http://trac.webkit.org/changeset/113912
https://bugs.webkit.org/show_bug.cgi?id=83727
broke atsui-spacing-features.html on windows (Requested by
simonjam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11
Source/WebCore:
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::justify):
LayoutTests:
* fast/text/international/arabic-justify.html: Removed.
* platform/chromium-win/fast/text/international/arabic-justify-expected.png: Removed.
* platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Removed.
* platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 11 Apr 2012 23:08:13 +0000 (23:08 +0000)]
Remove a fprintf from LayoutTestController.
This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
It was added for no apparent reason by Ryosuke in r113651.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::redirectionDestinationForURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 11 Apr 2012 22:52:00 +0000 (22:52 +0000)]
SpeculativeJIT::fillStorage() should work with all the states that a cell may be in
https://bugs.webkit.org/show_bug.cgi?id=83722
Reviewed by Gavin Barraclough.
It's now possible to do StorageOperand on a cell, in the case that the storage is
inline. But this means that fillStorage() must be able to handle all of the states
that a cell might be in. Previously it didn't.
With this change, it now does handle all of the states, and moreover, it does so
by preserving the DataFormat of cells and performing all of the cell speculations
that should be performed if you're using a cell as storage. But if you use this on
something that is known to be storage already then it behaves as it did before.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillStorage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 22:48:44 +0000 (22:48 +0000)]
[chromium] When rendering goes idle, do not count that time against frame rate
https://bugs.webkit.org/show_bug.cgi?id=73454
The FPS counter had a few issues with its reporting. The first
3 swapbuffers are non-blocking and create FPS rates that are
unrealistically high, throwing off the moving averages and
introducing false spikes into the FPS graph. There was also no
way to monitor the smoothness of the animation, or to focus in
on a particular animation or transition.
This patch updates the FPS counter code so that bad data points
are trimmed and not graphed; so that the graph itself is taller
and more legible; so that there is a clear boundary between 40FPS
and better; and to keep statistics on frame rate between
pauses in the activity in the UI so that you can trigger a
transition and read off the average and standard deviation for
that transition to judge it smooth enough or not.
Patch by Alex Nicolaou <anicolao@chromium.org> on 2012-04-11
Reviewed by James Robinson.
HUD is not testable in webkit.
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 11 Apr 2012 22:44:57 +0000 (22:44 +0000)]
Add two flaky plug-in tests.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 11 Apr 2012 22:38:35 +0000 (22:38 +0000)]
Add tests that broke in r113900 to the Skipped list.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Wed, 11 Apr 2012 22:12:37 +0000 (22:12 +0000)]
WebGLRenderingContext should defer caching program info
https://bugs.webkit.org/show_bug.cgi?id=83513
Reviewed by Kenneth Russell.
* html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::WebGLProgram):
(WebCore::WebGLProgram::numActiveAttribLocations): call cacheInfoIfNeeded();
(WebCore::WebGLProgram::getActiveAttribLocation): Ditto.
(WebCore::WebGLProgram::isUsingVertexAttrib0): Ditto.
(WebCore::WebGLProgram::getLinkStatus): Ditto.
(WebCore):
(WebCore::WebGLProgram::cacheActiveAttribLocations):
(WebCore::WebGLProgram::cacheInfoIfNeeded): Cache link status, active attire locations, etc if needed.
(WebCore::WebGLProgram::increaseLinkCount): also invalidate cached info.
* html/canvas/WebGLProgram.h:
(WebGLProgram):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::linkProgram): Do not cache program info immediately.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 22:04:01 +0000 (22:04 +0000)]
Add keySystem attribute to canPlayType() for Encrypted Media Extensions
https://bugs.webkit.org/show_bug.cgi?id=82973
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-11
Reviewed by Adam Barth.
The new attribute is behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#extensions.
Source/Platform:
* chromium/public/WebMimeRegistry.h:
(WebKit::WebMimeRegistry::supportsMediaMIMEType):
Source/WebCore:
Tests: media/encrypted-media/encrypted-media-can-play-type-webm.html
media/encrypted-media/encrypted-media-can-play-type.html
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::loadNextSourceChild):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::havePotentialSourceChild):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::getPluginProxyParams):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLMediaElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore):
(WebCore::bestMediaEngineForTypeAndCodecs):
(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::supportsType):
(WebCore::MediaPlayer::networkStateChanged):
* platform/graphics/MediaPlayer.h:
(MediaPlayer):
(WebCore):
Source/WebKit/chromium:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::supportsType):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
LayoutTests:
* media/encrypted-media/encrypted-media-can-play-type-expected.txt: Added.
* media/encrypted-media/encrypted-media-can-play-type-webm-expected.txt: Added.
* media/encrypted-media/encrypted-media-can-play-type-webm.html: Added.
* media/encrypted-media/encrypted-media-can-play-type.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 11 Apr 2012 21:43:59 +0000 (21:43 +0000)]
[Qt] InspectorServer: Add an API level auto test
https://bugs.webkit.org/show_bug.cgi?id=83594
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.
* Source/tests.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Wed, 11 Apr 2012 21:42:57 +0000 (21:42 +0000)]
[chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227
Reviewed by Kent Tamura.
Source/WebCore:
GDI used to do Kashida justification.
After switch to Skia, we need to use space padding to justify the text
(assume Skia can not do Kashida justification -- stretching words).
Test: fast/text/international/arabic-justify.html
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::justify):
LayoutTests:
* fast/text/international/arabic-justify.html: Added.
* platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
* platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
* platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 11 Apr 2012 21:33:19 +0000 (21:33 +0000)]
Unreviewed, GTK rebaseline after r113885.
* platform/gtk/css2.1/
20110323/replaced-elements-001-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Wed, 11 Apr 2012 21:27:21 +0000 (21:27 +0000)]
All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests
https://bugs.webkit.org/show_bug.cgi?id=83411
Reviewed by Eric Carlson.
Patch by Antonio Gomes <agomes@rim.com>
Fix obvious problems with the test in order to make tests lets
flaky.
* media/nodesFromRect-shadowContent.html:
* platform/gtk/media/nodesFromRect-shadowContent-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 11 Apr 2012 21:07:47 +0000 (21:07 +0000)]
[CAIRO] Make GLContextGLX a subclass of GLContext
https://bugs.webkit.org/show_bug.cgi?id=81285
Reviewed by Gustavo Noronha Silva.
.:
* GNUmakefile.am: Add a configuration option for activating GLX.
This is selected automatically now, but in the future there will be
the choice to turn on EGL and turn off GLX at compilation time.
* configure.ac: Ditto.
Source/WebCore:
No new tests. This should not change behavior.
* GNUmakefile.list.am: Add new GLContextGLX files.
* platform/graphics/cairo/GLContext.cpp: Added. Composed of the
EGL/GLX independent portions of GLContext. Made the current context
a static variable so we can keep getting the current context platform-
-independent.
* platform/graphics/cairo/GLContext.h: Make this class an abstract
class. GLContextGLX is a concrete implementation.
* platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Updated to reflect
slightly different calling conventions to create a sharing context.
* platform/graphics/glx/GLContextGLX.cpp: Updated to reflect
that this code is in a subclass now.
* platform/graphics/glx/GLContextGLX.h: Copied from Source/WebCore/platform/graphics/cairo/GLContext.h.
* platform/graphics/gtk/GLContextGtk.cpp:
(WebCore::GLContext::getContextForWidget): Updated to respect the new
USE(GLX) flag.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 11 Apr 2012 21:03:30 +0000 (21:03 +0000)]
fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html should be text tests
https://bugs.webkit.org/show_bug.cgi?id=83715
Reviewed by Rob Buis.
Converted the fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html to dumpAsText tests.
* fast/dom/dom-parse-serialize-display-expected.txt: Added.
* fast/dom/dom-parse-serialize-display.html:
* fast/dom/dom-parse-serialize-expected.txt: Added.
* fast/dom/dom-parse-serialize.html:
* platform/chromium-linux/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/chromium-linux/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/chromium-mac-leopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/chromium-mac-leopard/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/chromium-mac/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/chromium-mac/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/chromium-win/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/chromium-win/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
* platform/chromium-win/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/chromium-win/fast/dom/dom-parse-serialize-expected.txt: Removed.
* platform/efl/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/efl/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
* platform/efl/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/efl/fast/dom/dom-parse-serialize-expected.txt: Removed.
* platform/gtk/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/gtk/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
* platform/gtk/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/gtk/fast/dom/dom-parse-serialize-expected.txt: Removed.
* platform/mac-leopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/mac-leopard/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/mac/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/mac/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
* platform/mac/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/mac/fast/dom/dom-parse-serialize-expected.txt: Removed.
* platform/qt/fast/dom/dom-parse-serialize-display-expected.png: Removed.
* platform/qt/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
* platform/qt/fast/dom/dom-parse-serialize-expected.png: Removed.
* platform/qt/fast/dom/dom-parse-serialize-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 11 Apr 2012 20:51:21 +0000 (20:51 +0000)]
Global variable predictions should not be coalesced unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=83678
Reviewed by Geoff Garen.
Removed the PredictionTracker and everyone who used it. Converted GetGlobalVar
to have a heapPrediction like a civilized DFG opcode ought to.
No performance effect.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
* bytecode/PredictionTracker.h: Removed.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGenerationInfo.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(Graph):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Wed, 11 Apr 2012 20:34:52 +0000 (20:34 +0000)]
Unreviewed gardening and fix naming on EFL expected.txt files
* platform/chromium-linux/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
* platform/chromium-mac-leopard/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
* platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
* platform/chromium-mac-snowleopard/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
* platform/chromium-mac/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/chromium-mac/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
* platform/chromium-win/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/chromium-win/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt.
* platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-006-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-007-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-008-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-009-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt.
* platform/efl/ietestcenter/css3/text/textshadow-010-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt.
* platform/efl/test_expectations.txt:
* platform/mac/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/mac/test_expectations.txt:
* platform/qt/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/qt/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Wed, 11 Apr 2012 20:25:27 +0000 (20:25 +0000)]
[BlackBerry] Upstream BlackBerry change to PatternSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=83361
Reviewed by Antonio Gomes.
Upstream a cleaned up version.
* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 11 Apr 2012 20:19:45 +0000 (20:19 +0000)]
[chromium] Add OVERRIDE annotations for cc layer types
https://bugs.webkit.org/show_bug.cgi?id=83658
Reviewed by Daniel Bates.
This adds OVERRIDE annotations to overrides of functions on these classes:
- CCLayerImpl
- LayerChromium
- TiledLayerChromium
Source/WebCore:
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/CanvasLayerChromium.h:
(CanvasLayerChromium):
* platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
* platform/graphics/chromium/PluginLayerChromium.h:
(PluginLayerChromium):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/VideoLayerChromium.h:
(VideoLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
* platform/graphics/chromium/cc/CCTextureLayerImpl.h:
(CCTextureLayerImpl):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):
Source/WebKit/chromium:
* src/WebLayerImpl.cpp:
* src/WebLayerImpl.h:
(WebLayerImpl): Removed unused and empty paintContents() function.
* tests/CCLayerIteratorTest.cpp:
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
* tests/CCTiledLayerTestCommon.h:
(FakeTiledLayerChromium):
* tests/LayerChromiumTest.cpp:
* tests/TreeSynchronizerTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Wed, 11 Apr 2012 20:16:47 +0000 (20:16 +0000)]
[mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
https://bugs.webkit.org/show_bug.cgi?id=83709
Reviewed by Anders Carlsson.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventCarbon):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 11 Apr 2012 20:13:16 +0000 (20:13 +0000)]
[Mac] lang, xml:lang, content-language ignored when choosing fonts
https://bugs.webkit.org/show_bug.cgi?id=10874
<rdar://problem/3220202>
Reviewed by Dan Bernstein.
Adding a default font table for Mac port. Clients can still override these if they want to,
but knowing which fonts to use is more about the platform than about the client.
Tests: platform/mac/fonts/han-disunification.html
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* Resources/DefaultFonts.plist.in: Added.
Added SettingsMac.mm. Added preprocessed property list with default fonts.
* page/Settings.cpp:
(WebCore::setGenericFontFamilyMap): Don't notify the page if we don't have one yet.
(WebCore::Settings::Settings): Assign to m_page after calling initializeDefaultFontFamilies,
so that we won't try to call page->setNeedsRecalcStyleInAllFrames() in a half-initialized
Page that's creating settings.
(WebCore::Settings::initializeDefaultFontFamilies): Dummy imlplementation for ports that
rely on client to set defaults.
* page/Settings.h: Added initializeDefaultFontFamilies().
* page/mac/SettingsMac.mm: Added.
(WebCore::defaultFontFamilyDictionary):
(WebCore::Settings::initializeDefaultFontFamilies):
Load defaults from a plist file inside WebCore framework.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Wed, 11 Apr 2012 20:05:04 +0000 (20:05 +0000)]
[Chromium] Unreviewed gardening.
* platform/chromium-linux/css2.1/
20110323/replaced-elements-001-expected.png:
* platform/chromium-linux/css2.1/
20110323/replaced-elements-001-expected.txt:
* platform/chromium-linux/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/
20110323/replaced-elements-001-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/chromium-mac/css2.1/
20110323/replaced-elements-001-expected.png:
* platform/chromium-mac/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/replaced-elements-001-expected.png:
* platform/chromium-win/css2.1/
20110323/replaced-elements-001-expected.txt:
* platform/chromium-win/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/chromium-win/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/chromium-win/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 11 Apr 2012 20:03:25 +0000 (20:03 +0000)]
Crash in CSSStyleSheet::deleteRule
https://bugs.webkit.org/show_bug.cgi?id=83708
Source/WebCore:
Reviewed by Andreas Kling.
Andreas spotted that the wrapper needs to be null checked before calling setParentStyleSheet(0).
Test: fast/css/delete-rule-crash.html
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::deleteRule):
LayoutTests:
Reviewed by Andreas Kling.
* fast/css/delete-rule-crash.html: Added.
* fast/css/delete-rule-crash-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 11 Apr 2012 20:00:26 +0000 (20:00 +0000)]
[MutationObservers] Setting an attributeFilter should filter out all namespaced attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=83706
Reviewed by Ryosuke Niwa.
Source/WebCore:
The patch amounts to plumbing QualifiedName all the way down to shouldReceiveMutationFrom
as it now needs to know about namespaceURI as well as localName.
This change is coming soon to the DOM4 spec, see
https://www.w3.org/Bugs/Public/show_bug.cgi?id=16563 for more discussion.
* dom/MutationObserverInterestGroup.cpp:
(WebCore::MutationObserverInterestGroup::createIfNeeded):
* dom/MutationObserverInterestGroup.h:
(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(MutationObserverInterestGroup):
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
* dom/MutationObserverRegistration.h:
(WebCore):
(MutationObserverRegistration):
* dom/Node.cpp:
(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
* dom/Node.h:
(Node):
LayoutTests:
Updated attributes test to match new behavior.
* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rafael.lobo@openbossa.org [Wed, 11 Apr 2012 19:52:22 +0000 (19:52 +0000)]
Adding myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=83711
Unreviewed update to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 11 Apr 2012 19:51:15 +0000 (19:51 +0000)]
Add two more DOM storage tests to the Skipped list.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 19:45:42 +0000 (19:45 +0000)]
[EFL] LayoutTestController needs implementation of pageProperty
https://bugs.webkit.org/show_bug.cgi?id=82449
Source/WebKit/efl:
Add missing implementation pageProperty to EFL's
DumpRenderTreeSupport.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::pageProperty):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Add missing implementation pageProperty to EFL's LayoutTestController
in order to unskip printing/page-rule-selection.html
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::pageProperty):
LayoutTests:
Unskip printing/page-rule-selection.html
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 11 Apr 2012 19:40:10 +0000 (19:40 +0000)]
Move fast/js/navigator-language.html to platform/qt
https://bugs.webkit.org/show_bug.cgi?id=83710
Reviewed by Ryosuke Niwa.
This test was for a Qt specific bug, and using setlocale on Mac will not update the preferred language correctly.
* platform/qt/fast/js/navigator-language-expected.txt: Renamed from LayoutTests/fast/js/navigator-language-expected.txt.
* platform/qt/fast/js/navigator-language.html: Renamed from LayoutTests/fast/js/navigator-language.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Wed, 11 Apr 2012 19:39:19 +0000 (19:39 +0000)]
[Chromium/Linux] fonts-glyph-04-t.svg fails after r87152
https://bugs.webkit.org/show_bug.cgi?id=61370
Unreviewed Chromium linux expectations update.
This test is now behaving like Mac. No complaints there, just a font change.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Wed, 11 Apr 2012 19:33:07 +0000 (19:33 +0000)]
[chromium] svg/wicd/test-rightsizing-a.xhtml is flaky
https://bugs.webkit.org/show_bug.cgi?id=66320
Unreviewed Chromium test expectations cleanup.
This test had been fixed some time ago and has no appearance in the flakiness board.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 11 Apr 2012 19:26:28 +0000 (19:26 +0000)]
add stereo source support in EqualPowerPanner
https://bugs.webkit.org/show_bug.cgi?id=81092
Patch by Wei James <james.wei@intel.com> on 2012-04-11
Reviewed by Chris Rogers.
Source/WebCore:
Test: webaudio/panner-equalpower-stereo.html
* platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::pan):
LayoutTests:
* webaudio/panner-equalpower-stereo-expected.txt: Added.
* webaudio/panner-equalpower-stereo.html: Copied from LayoutTests/webaudio/panner-equalpower.html.
* webaudio/panner-equalpower.html:
* webaudio/resources/audio-testing.js:
(createStereoImpulseBuffer):
* webaudio/resources/panner-model-testing.js:
(createGraph):
(createTestAndRun):
(equalPowerGain):
(checkResult):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Wed, 11 Apr 2012 19:23:01 +0000 (19:23 +0000)]
[chromium] Need new image baseline for svg/dom/SVGTransformList-basics.xhtml
https://bugs.webkit.org/show_bug.cgi?id=63036
Unreviewed Chromium test expectations update.
* platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Wed, 11 Apr 2012 19:21:59 +0000 (19:21 +0000)]
StyleElement ownerNode is not cleared correctly
https://bugs.webkit.org/show_bug.cgi?id=83696
Reviewed by Antti Koivisto.
Source/WebCore:
When the css text changes in such a way that we remove the sheet of a style element or a link[rel=stylesheet]
element we need to ensure that the ownerNode of the sheet is cleared. If we don't do this and there is a
wrapper for the sheet the sheet is kept alive but the ownerNode of the sheet may point to a deleted node.
Tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html
fast/dom/StyleSheet/detached-sheet-owner-node.html
* dom/StyleElement.cpp:
(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearSheet):
(WebCore):
(WebCore::StyleElement::createSheet):
* dom/StyleElement.h:
(StyleElement):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::clearSheet):
(WebCore):
* html/HTMLLinkElement.h:
(HTMLLinkElement):
LayoutTests:
* fast/dom/StyleSheet/detached-sheet-owner-node-expected.txt: Added.
* fast/dom/StyleSheet/detached-sheet-owner-node-link-expected.txt: Added.
* fast/dom/StyleSheet/detached-sheet-owner-node-link.html: Added.
* fast/dom/StyleSheet/detached-sheet-owner-node.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Wed, 11 Apr 2012 19:09:31 +0000 (19:09 +0000)]
Optimize String.split() for 1 character separator
https://bugs.webkit.org/show_bug.cgi?id=83546
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-11
Reviewed by Gavin Barraclough.
This patch adds a serie of optimizations to make stringProtoFuncSplit() faster in the common case
where the separator is a single character.
The two main gains are:
-Use of the find() function with a single character instead of doing a full string matching.
-Use of WTF::find() instead of UString::find() to avoid branching on is8Bit() and have a simpler inline
function.
The code is also changed to avoid making unnecessary allocations by converting the 8bit string to 16bits.
This makes String.split() faster by about 13% in that particular case.
* runtime/StringPrototype.cpp:
(JSC):
(JSC::splitStringByOneCharacterImpl):
(JSC::stringProtoFuncSplit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 11 Apr 2012 18:35:37 +0000 (18:35 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=83614
<rdar://problem/
11177351>
REGRESSION: Table on wikipedia overlaps float on right hand side.
Revise how auto margins are resolved so that for objects that avoid floats, the available line
width is always used instead of the overall containing block width. computeLogicalWidth now
always properly computes inline margins (based off the object's current logicalTop() position)
and so the code in computeStartPositionDeltaForChildAvoidingFloats that recomputes inline
direction margins can now be removed.
Reviewed by Dan Bernstein.
Added new test in fast/block/float.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::shrinkToAvoidFloats):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=83614
Improve how auto margins are handled on objects that avoid floats. Add a new test covering this
for tables and overflow sections and revise existing results. The CSS2.1 test in particular is
a progression.
Reviewed by Dan Bernstein.
* fast/block/float/avoiding-float-centered.html: Added.
* platform/mac/css2.1/
20110323/replaced-elements-001-expected.txt:
* platform/mac/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/mac/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Wed, 11 Apr 2012 18:30:52 +0000 (18:30 +0000)]
Unreviewed gardening. Found EFL results.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt: Added.
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc