rniwa@webkit.org [Sat, 31 Mar 2012 07:06:55 +0000 (07:06 +0000)]
Build fix after r112781.
* BuildSlaveSupport/built-product-archive:
(createZipManually):
(createZip):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sat, 31 Mar 2012 06:50:09 +0000 (06:50 +0000)]
Chromium bots should upload archived built files
https://bugs.webkit.org/show_bug.cgi?id=82666
Reviewed by Tony Chang.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/built-product-archive:
(main):
(determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
call out to webkit-build-directory.
(removeDirectoryIfExists): Extracted.
(copyBuildFiles): Added to avoid archiving useless intermedinate files.
(createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
(createZipManually.addToArchive):
(createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
(archiveBuiltProduct): Add support for Chromium port.
* Scripts/webkit-build-directory: Add support for --platform options.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 31 Mar 2012 06:10:30 +0000 (06:10 +0000)]
[Chromium] Move ResourceHandle to WebCore/platform/network/chromium
https://bugs.webkit.org/show_bug.cgi?id=82657
Reviewed by James Robinson.
Source/WebCore:
We finally arive at our destination. This patch actually moves
WebCore::ResourceHandle from Source/WebKit/chromium/src to
Source/WebCore/network/chromium, matching its location in other ports.
To make this happen, we also need to move WrappedResourceRequest and
WrappedResourceResponse.
This patch is the last patch from
https://github.com/abarth/webkit/compare/master...webcore-platform
* WebCore.gypi:
* platform/chromium/support/WrappedResourceRequest.h: Copied from Source/WebCore/platform/chromium/support/WrappedResourceRequest.h.
* platform/chromium/support/WrappedResourceResponse.h: Copied from Source/WebCore/platform/chromium/support/WrappedResourceResponse.h.
* platform/network/chromium/ResourceHandle.cpp: Copied from Source/WebCore/platform/network/chromium/ResourceHandle.cpp.
* platform/network/chromium/ResourceHandleInternal.h: Copied from Source/WebCore/platform/network/chromium/ResourceHandleInternal.h.
Source/WebKit/chromium:
* WebKit.gyp:
* src/ResourceHandle.cpp: Removed.
* src/ResourceHandleInternal.h: Removed.
* src/WrappedResourceRequest.h: Removed.
* src/WrappedResourceResponse.h: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sat, 31 Mar 2012 05:16:34 +0000 (05:16 +0000)]
Add a compile assert for the size of RenderText
https://bugs.webkit.org/show_bug.cgi?id=82780
Reviewed by Dirk Pranke.
Added an assertion. Also moved m_maxWidth, m_beginMinWidth, and m_endMinWidth
to right beneath m_minWidth so that gcc on GTK+ can pack floats properly.
* rendering/RenderText.cpp:
(SameSizeAsRenderText):
(WebCore):
* rendering/RenderText.h:
(RenderText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 31 Mar 2012 05:16:28 +0000 (05:16 +0000)]
Two more link errors. This time it's v8 we're missing.
* WebKitUnitTests.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sat, 31 Mar 2012 05:04:59 +0000 (05:04 +0000)]
Add a compile assert for the size of ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=82822
Reviewed by Dirk Pranke.
Added the assertion. Also made m_scrollOriginChanged a bitfield so that it can be packed nicely.
* platform/ScrollableArea.cpp:
(SameSizeAsScrollableArea):
(WebCore):
* platform/ScrollableArea.h:
(ScrollableArea):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sat, 31 Mar 2012 04:44:42 +0000 (04:44 +0000)]
Stop creating the Web Inspector's NSWindow when detaching on close.
This fixes a UI process crash that would happen when detaching because of a Web Process crash.
https://webkit.org/b/82820
rdar://problem/
11085467
Reviewed by Dan Bernstein.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformDetach): Moved the creation and showing code to the end
and added an early return if we are not visible in the middle.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 31 Mar 2012 04:35:39 +0000 (04:35 +0000)]
Attempt to fix the Windows component build. It seems we're just
missing GURL now.
* WebKitUnitTests.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 31 Mar 2012 04:01:28 +0000 (04:01 +0000)]
Reverted r112767, because it caused many vertical text tests to fail.
Source/WebCore:
* WebCore.exp.in:
* platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
* platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(FontPlatformData):
(WebCore::FontPlatformData::isColorBitmapFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(DerivedFontData):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::fill):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore):
Tools:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/fonts/SampleFont.sfont: Removed.
* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
(activateTestingFonts):
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
(WTR::activateFonts):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/fonts/SampleFont.sfont: Removed.
LayoutTests:
* fast/text/international/text-spliced-font.html: Removed.
* platform/mac/fast/text/international/text-spliced-font-expected.png: Removed.
* platform/mac/fast/text/international/text-spliced-font-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 31 Mar 2012 03:44:24 +0000 (03:44 +0000)]
Tried to fix the Chromium Mac build after r112767.
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(DerivedFontData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Sat, 31 Mar 2012 03:36:38 +0000 (03:36 +0000)]
Colors seem to be parsed using HTML quirks in SVG attributes
https://bugs.webkit.org/show_bug.cgi?id=46112
Source/WebCore:
Reviewed by Eric Seidel.
Finally move to SVGAttributeMode on parsing SVG presentation attributes. SVG attributes are
mainly parsed in the strict mode, which affects strict parsing of colors and no spaces between
values and units. Unit less values are still allowed.
Tests: svg/css/svg-attribute-length-parsing.html
svg/css/svg-attribute-parser-mode.html
* css/CSSGrammar.y: No quirks mode for SVG.
* css/CSSParser.h:
(WebCore::CSSParser::inStrictMode): SVGAttributeMode also implies strict parsing.
(WebCore::CSSParser::inQuirksMode): Remove SVGAttributeMode from quirks mode.
* css/CSSParserMode.h:
(isStrictParserMode): Ditto.
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateAttributeStyle):
* svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
* svg/SVGStyledElement.cpp: Switch to SVGAttributeMode if we parse a SVG presentation attribute.
(WebCore::SVGStyledElement::getPresentationAttribute):
LayoutTests:
Test that values of SVG presentation attributes are parsed in strict mode. At the moment
this affects strict color parsing and no spaces between values and units.
Reviewed by Eric Seidel.
* svg/animations/script-tests/animate-color-fill-from-by.js:
* svg/css/script-tests/svg-attribute-length-parsing.js: Added.
* svg/css/script-tests/svg-attribute-parser-mode.js: Added.
* svg/css/svg-attribute-length-parsing-expected.txt: Added.
* svg/css/svg-attribute-length-parsing.html: Added.
* svg/css/svg-attribute-parser-mode-expected.txt: Added.
* svg/css/svg-attribute-parser-mode.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 31 Mar 2012 03:24:06 +0000 (03:24 +0000)]
Attempt to fix the Windows component build. The way we link the unit
tests in the component build is kind of nutty. Hopefully this approach
will eliminate the duplicate symbols we've been seeing.
* WebKitUnitTests.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 31 Mar 2012 03:13:52 +0000 (03:13 +0000)]
Source/WebCore: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/
10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810
CoreText have already the features enabled, here we added this to WebKit text layout and rendering.
A member function getCompositeFontReferenceFontData is added to the SimpleFontData class for the component font
correspond to the platformData, in this case, a NSFont. This is used when CoreText layout had resulted
a component of the Composite Font Reference and its corresponding SimpleFontData object is then cached
in the SimpleFontData object of the posting font (Composite Font Reference).
When glyphs are encoded to form the GlyphPage for rendering, the Composite Font Reference is handled throught
the CoreText layout path (using CTLine), here the resulting glyph is associated with a font which could
be not the original font request. In this case, these are the component fonts of the Composite Font
Reference. This is then identified and then added to the GlyphPage appropriately.
To support this feature, a member function isCompositeFontReference is added to FontPlatformData to
indicate a font is a Composite Font Reference. Also in order to pass the component font correctly a boolean
isPrinterFont is added to one the FontPlatformData constructors to describe the NSFont.
Patch by Tony Tseung <tseung@apple.com> on 2012-03-30
Reviewed by Dan Bernstein.
Added test LayoutTests/fast/text/international/text-spliced-font.html
* WebCore.exp.in:
Replaced obsolete FontPlatformData constructor entry.
* platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
Copy of the additional m_isCompositeFontReference and m_isPrinterFont data members.
(WebCore::FontPlatformData::operator=):
Assignment of the additional m_isCompositeFontReference and m_isPrinterFont data members.
* platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(FontPlatformData):
Default value of m_isCompositeFontReference and m_isPrinterFont data members are set to false in various constructors.
(WebCore::FontPlatformData::isCompositeFontReference):
Newly added for Composite Font Reference type font.
(WebCore::FontPlatformData::isPrinterFont):
Newly added for describing the NSFont parameter if is applicable.
(WebCore::FontPlatformData::operator==):
Comparison of the additional m_isCompositeFontReference and m_isPrinterFont data members.
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
Clean up the cache for component fonts of the Composite Font References.
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
Added member function const SimpleFontData* getCompositeFontReferenceFontData(NSFont *key) const.
(DerivedFontData):
Added CFDictionary for caching the component font of Composite Font Reference.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
Data members m_isCompositeFontReference and m_isPrinterFont are initialised and their values are determined in the body of the contructor.
(WebCore::FontPlatformData::setFont):
Data members m_isCompositeFontReference and m_isPrinterFont are determined and set.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
Boolean value isUsingPrinterFont is passed in the new FontPlatformData constructor.
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
Added the condition for Composite Font Reference type font.
(WebCore::GlyphPage::fill):
In the case of Composite Font Reference, when iterate the runs, component font of Composite Font
Reference is used to fill the glyph index in the GlyphPage.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
Newly added method for the component fonts correspond to the platformData, in this case, a NSFont.
This SimpleFontData is created and cached in this object and will only be deleted when the destructor
if this is called.
Tools: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/
10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810
A new test font of this kind as been added to the test tools for running the webkit-tests
Patch by Tony Tseung <tseung@apple.com> on 2012-03-30
Reviewed by Dan Bernstein.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Added new dependency SampleFont.sfont
* DumpRenderTree/fonts/SampleFont.sfont: Added.
* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
(activateTestingFonts):
Added the registration of the Composite Font Referene sample font
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
(WTR::activateFonts):
Added the registration of the Composite Font Referene sample font
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Added new dependency SampleFont.sfont
* WebKitTestRunner/fonts/SampleFont.sfont: Added.
LayoutTests: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/
10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810
Added new LayoutTests/fast/text/international/text-spliced-font.html
Patch by Tony Tseung <tseung@apple.com> on 2012-03-30
Reviewed by Dan Bernstein.
* fast/text/international/text-spliced-font.html: Added.
* platform/mac/fast/text/international/text-spliced-font-expected.png: Added.
* platform/mac/fast/text/international/text-spliced-font-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Sat, 31 Mar 2012 03:07:24 +0000 (03:07 +0000)]
[BlackBerry] Use KURL::protocolIsInHTTPFamily() instead KURL::protocolInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=82707
Reviewed by Rob Buis.
No new tests, just BlackBerry build fix.
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 31 Mar 2012 02:46:08 +0000 (02:46 +0000)]
styleForElement() should use enums instead of bools so we can all understand what it's doing
https://bugs.webkit.org/show_bug.cgi?id=82807
Reviewed by Adam Barth.
No change in behavior, thus no tests.
Mostly this is just replacing true/false with the correct new enum value
or removing true/false from the callsites when they would have been default anyway.
I think this makes the code *way* more clear.
The old code was extra confusing because the defaults were "true, false". :)
The new defaults are AllowStyleSharing, MatchAllRules.
It's very uncommon for callers to want to override either of these behaviors.
I think most callers which specify DisallowStyleSharing likely don't actually need to
(our style-sharing code should be smart enough to only share when safe anyway).
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
- Use enums and remove bogus comment (m_rootDefaultStyle is a RefPtr!)
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
* css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
* dom/Element.cpp:
(WebCore::Element::styleForRenderer):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getUncachedPseudoStyle):
- Updated to use enums
- Also fixed this to use toElement and modern early-return styles.
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::computeStyleInRegion):
* svg/SVGElement.cpp:
(WebCore::SVGElement::customStyleForRenderer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 31 Mar 2012 02:36:35 +0000 (02:36 +0000)]
[BlackBerry] Headers with no content shouldn't be dropped by platform's request.
https://bugs.webkit.org/show_bug.cgi?id=82691
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-30
Reviewed by Rob Buis.
Test : http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 31 Mar 2012 02:27:52 +0000 (02:27 +0000)]
Skip more tests. Tracking bugs are listed in the Skipped file.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 31 Mar 2012 02:21:35 +0000 (02:21 +0000)]
DFG should optimize a==b for a being an object and b being either an object or
null/undefined, and vice versa
https://bugs.webkit.org/show_bug.cgi?id=82656
Reviewed by Oliver Hunt.
Implements additional object equality optimizations for the case that one
operand is predicted to be an easily speculated object (like FinalObject or
Array) and the other is either an easily speculated object or Other, i.e.
Null or Undefined.
2-5% speed-up on V8/raytrace, leading to a sub-1% progression on V8.
I also took the opportunity to clean up the control flow for the speculation
decisions in the various Compare opcodes. And to fix a build bug in SamplingTool.
And to remove debug cruft I stupidly committed in my last patch.
* bytecode/SamplingTool.h:
(SamplingRegion):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(DFG):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(DFG):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 31 Mar 2012 02:17:14 +0000 (02:17 +0000)]
Skip two SVG tests that asserted. Tracked by
https://bugs.webkit.org/show_bug.cgi?id=82815
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 31 Mar 2012 01:37:03 +0000 (01:37 +0000)]
Add tests for iframe seamless and support for parsing webkitseamless attribute
https://bugs.webkit.org/show_bug.cgi?id=82795
Reviewed by Adam Barth.
Source/WebCore:
This just adds support for parsing/reflecting the "webkitseamess" attribute.
I'll add the actual CSS, navigation, security, and layout changes in
separate follow-up patches.
Tests: fast/frames/seamless/seamless-basic.html
fast/frames/seamless/seamless-css-cascade.html
fast/frames/seamless/seamless-nested.html
fast/frames/seamless/seamless-sandbox-flag.html
* html/HTMLAttributeNames.in:
* html/HTMLIFrameElement.idl:
LayoutTests:
* fast/frames/seamless/resources/css-cascade-child.html: Added.
* fast/frames/seamless/resources/nested-seamless.html: Added.
* fast/frames/seamless/resources/square.html: Added.
* fast/frames/seamless/seamless-basic-expected.txt: Added.
* fast/frames/seamless/seamless-basic.html: Added.
* fast/frames/seamless/seamless-css-cascade-expected.txt: Added.
* fast/frames/seamless/seamless-css-cascade.html: Added.
* fast/frames/seamless/seamless-nested-expected.txt: Added.
* fast/frames/seamless/seamless-nested.html: Added.
* fast/frames/seamless/seamless-sandbox-flag-expected.txt: Added.
* fast/frames/seamless/seamless-sandbox-flag.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 31 Mar 2012 01:15:55 +0000 (01:15 +0000)]
Unreviewed, fix Leopard/SL expectations for remaining SVG tests.
Also, mark zoom-img-preserveAspectRatio-support-1 as still failing.
* platform/chromium-mac-snowleopard/fast/overflow/overflow-x-y-expected.txt:
* platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
* platform/chromium-mac-snowleopard/svg/custom/mask-colorspace-expected.txt:
* platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-use-expected.txt:
* platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt:
* platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.txt:
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Sat, 31 Mar 2012 00:57:47 +0000 (00:57 +0000)]
Change WebKit/WebKit2 platform code to use pixel snapped values
https://bugs.webkit.org/show_bug.cgi?id=82549
Source/WebCore:
Reviewed by Eric Seidel.
Change WebKit and WebKit2 platform code to use rounded locations and
pixel snapped rects and sizes. This largely avoids having to expose the
fractional layout types to the platform code.
No new tests. No change in functionality.
* dom/Node.h:
(WebCore::Node::pixelSnappedRenderRect):
Add pixel snapped version of renderRect
* rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedFrameRect):
Add pixel snapped version of frameRect
Source/WebKit/chromium:
Reviewed by Eric Seidel.
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::boundingBoxRect):
Use pixelSnappedBoundingBoxRect instead of boundingBoxRect which returns
a LayoutRect.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::characterIndexForPoint):
Use roundedPoint instead of point for hit testing as ranges use screen
cordinates which are represented with pixel accuracy.
Source/WebKit/mac:
Change WebKit and WebKit2 platform code to use rounded locations and
pixel snapped rects and sizes. This largely avoids having to expose the
fractional layout types to the platform code.
Reviewed by Eric Seidel.
* DOM/WebDOMOperations.mm:
(-[DOMNode _renderRect:]):
Source/WebKit/qt:
Reviewed by Eric Seidel.
* Api/qwebelement.cpp:
(QWebElement::geometry):
Replace getRect with getPixelSnappedRect to avoid having to expose
subpixel types to the platform layer.
* Api/qwebpage.cpp:
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
Use pixel snapped element rect when comparing with the touch rect as the
touch rect use screen cordinates which are represented with pixel
accuracy.
* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::scrollRectIntoView):
Change scrollRectIntoView to take a LayoutRect to match base class
interface.
Source/WebKit2:
Change WebKit and WebKit2 platform code to use rounded locations and
pixel snapped rects and sizes. This largely avoids having to expose the
fractional layout types to the platform code.
Reviewed by Eric Seidel.
* Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::WebRenderObject):
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::renderRect):
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::invalidateScrollbarRect):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::characterIndexForPoint):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 31 Mar 2012 00:54:50 +0000 (00:54 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=82761
Try to narrow down the cause of this assertion by adding
an assertion about m_frame.
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Sat, 31 Mar 2012 00:52:52 +0000 (00:52 +0000)]
Fix return type for virtual borderBoundingBox method
https://bugs.webkit.org/show_bug.cgi?id=82561
Reviewed by Eric Seidel.
No new tests, no change in functionality.
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
* rendering/RenderBox.h:
(WebCore::RenderBox::borderBoxRect):
Rename pixelSnappedBorderBoxRect to borderBoxRect and remove LayoutRect
version of same as we always want to use the pixel snapped version to
ensure proper rounding and alignment to device pixels.
(The way this rect is pixel snapped, using the m_frameRect location,
makes it hard for calling code to take the subpixel rect and correctly
snap it).
(WebCore::RenderBox::borderBoundingBox):
* rendering/RenderBoxModelObject.h:
Change pure virtual definition of borderBoundingBox to return an IntRect
to match implementation in RenderBox.
(RenderBoxModelObject):
* rendering/RenderInline.h:
(WebCore::RenderInline::borderBoundingBox):
Change overloaded method to IntRect to match RenderBox implementation.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 31 Mar 2012 00:46:04 +0000 (00:46 +0000)]
shape-inside and shape-outside are not in the list of computed style properties
https://bugs.webkit.org/show_bug.cgi?id=82667
Patch by Bear Travis <betravis@adobe.com> on 2012-03-30
Reviewed by Ryosuke Niwa.
Source/WebCore:
Adding prefixed shape-inside and shape-outside to the list of computed style properties.
Added properties to existing tests for computed style results
* css/CSSComputedStyleDeclaration.cpp:
(WebCore): added -webkit-shape-inside and -webkit-shape-outside to computedProperties
LayoutTests:
Adding prefixed shape-inside and shape-outside to the list of computed style properties.
Updating tests that look at all properties on a computed style declaration.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/svg/css/getComputedStyle-basic-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 31 Mar 2012 00:31:48 +0000 (00:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=82582
Move CPP files related to ResourceHandle to WebCore/platform
Reviewed by James Robinson.
Source/WebCore:
This patch moves a number of files that implement parts of the platform
portion of the Chromium WebKit API from the WebKit layer to
WebCore/platform. These files are in the dependency cone of
ResourceHandle and have no dependencies on anything outside
WebCore/platform.
* WebCore.gypi:
* platform/chromium/support/WebHTTPBody.cpp: Copied from Source/WebKit/chromium/src/WebHTTPBody.cpp.
* platform/chromium/support/WebHTTPLoadInfo.cpp: Copied from Source/WebKit/chromium/src/WebHTTPLoadInfo.cpp.
* platform/chromium/support/WebURL.cpp: Copied from Source/WebKit/chromium/src/WebURL.cpp.
* platform/chromium/support/WebURLError.cpp: Copied from Source/WebKit/chromium/src/WebURLError.cpp.
* platform/chromium/support/WebURLRequest.cpp: Copied from Source/WebKit/chromium/src/WebURLRequest.cpp.
* platform/chromium/support/WebURLRequestPrivate.h: Copied from Source/WebKit/chromium/src/WebURLRequestPrivate.h.
* platform/chromium/support/WebURLResponse.cpp: Copied from Source/WebKit/chromium/src/WebURLResponse.cpp.
* platform/chromium/support/WebURLResponsePrivate.h: Copied from Source/WebKit/chromium/src/WebURLResponsePrivate.h.
Source/WebKit/chromium:
* WebKit.gyp:
* src/WebHTTPBody.cpp: Removed.
* src/WebHTTPLoadInfo.cpp: Removed.
* src/WebURL.cpp: Removed.
* src/WebURLError.cpp: Removed.
* src/WebURLRequest.cpp: Removed.
* src/WebURLRequestPrivate.h: Removed.
* src/WebURLResponse.cpp: Removed.
* src/WebURLResponsePrivate.h: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 31 Mar 2012 00:25:18 +0000 (00:25 +0000)]
Unreviewed, expectations update.
* platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-win-xp/svg/batik/masking/maskRegions-expected.png: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Sat, 31 Mar 2012 00:13:20 +0000 (00:13 +0000)]
Fix usage of LayoutUnits in table code.
https://bugs.webkit.org/show_bug.cgi?id=82765
Reviewed by Eric Seidel.
Clean up usage of ints and LayoutUnits in table code in preparation for
turning on subpixel layout.
No new tests, no change in functionality.
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
Cast maxWidth to int as all table layout is done on int bounds.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
Change borders to LayoutUnit as paddings can have subpixel precision.
* rendering/RenderTable.h:
(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::columnPositions):
Change getColumnPos and columnPositions to ints as the values are always
on pixel bounds.
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleOrColLogicalWidth):
Remove unnecessary cast.
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
Use LayoutPoint instead of left/top.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderTableSection.h:
Change baseline and baselineDescent to int to avoid unnecessary type
conversion.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 31 Mar 2012 00:05:21 +0000 (00:05 +0000)]
Spec renamed Viewport-relative lengths to Viewport-percentage lengths
https://bugs.webkit.org/show_bug.cgi?id=82773
Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-30
Reviewed by Antti Koivisto.
As per the latest version of CSS Values and Units Module Level 3 specification released on 29 March 2012
(http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths) Viewport-relative lengths is renamed to Viewport-percentage lengths.
Source/WebCore:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::viewportPercentageLength):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportPercentageLength):
(CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/LengthFunctions.cpp:
(WebCore::minimumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):
* platform/Length.h:
(WebCore::Length::isViewportPercentage):
(WebCore::Length::viewportPercentageLength):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::textIndentOffset):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeContentLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
* rendering/RenderInline.cpp:
(WebCore::computeMargin):
* rendering/style/RenderStyle.h:
LayoutTests:
* css3/viewport-percentage-lengths: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-absolute-expected.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-absolute.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-expected.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-absolute-expected.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-absolute.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-expected.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-absolute-expected.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-absolute.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-expected.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw.html: Added.
* css3/viewport-relative-lengths: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Removed.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 31 Mar 2012 00:01:14 +0000 (00:01 +0000)]
Note more flaky crashes for bug 82505.
Unreviewed, expectations change.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Mar 2012 23:47:13 +0000 (23:47 +0000)]
Skip two WebGL tests. Tracked by https://bugs.webkit.org/show_bug.cgi?id=82805
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 30 Mar 2012 23:34:02 +0000 (23:34 +0000)]
[wx] Move wxWebKit API into WebKit namespace.
https://bugs.webkit.org/show_bug.cgi?id=82740
Reviewed by Kevin Ollivier.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achicu@adobe.com [Fri, 30 Mar 2012 23:30:03 +0000 (23:30 +0000)]
[CSS Filters] Drop Shadow is not repainting correctly when repaint area is smaller than the filtered element
https://bugs.webkit.org/show_bug.cgi?id=80323
Source/WebCore:
Reviewed by Dean Jackson.
The problem is that shadow and blur (and custom filters - although not treated in this patch) need the full source image of
the surface that needs to be filtered. Until now the filter was computed only using the area defined by the dirty repaint rectangle.
Those filters need full image source because they displace pixel positions, meaning that pixels in the current dirty rectangle
have a dependency on pixels from the RenderLayer outside the dirty rect. See the bug pictures for an example of how that could go wrong.
The fix is to always keep a copy of the RenderLayer representation in memory. When repaint is needed we still invalidate
only the parts that changed, but the filter is computed using the full source image and not only the dirty rectangle.
In order to make that work, we needed the full repaint rectangle of the current RenderLayer and not just the clipped version that
we get through the ::paint methods. Also, because filters sometime need to repaint more than just the dirty area (because of the
outsets of the filters - ie blur, drop-shadow), it makes it easier to just capture all the repaints in the RenderLayer itself in a
similar way WebKit does now for composited layers. As a result the repaint container can also be a filtered layer (not just composited ones), so
that we can catch all the filter repaints in one place in the RenderLayer. Also with this change I removed the need to add visual overflow to
the RenderBox and also there's no need to patch the repaintUsingContainer. By the way, repaintUsingContainer did not always work because of the
LayoutState optimizations, so repaints during layout would fail (I know that that could be fixed by disabling the LayoutState for filtered areas).
Also part of this patch I extracted a function from RenderLayerCompositor::calculateCompositedBounds, so that we can also use it from RenderLayer.
I called it RenderLayer::calculateLayerBounds and there should be no change in functionality. It now also includes the outsets of the filter. I've
added a different bug to avoid adding the outsets when the filter is computed in hardware. That's because some platforms do not support that yet:
https://bugs.webkit.org/show_bug.cgi?id=81239
Also the visual overflow doesn't include the child RenderLayers, meaning that the outsets would have been applied to the border and not to the bounding box
of the RenderLayer. The end result was that some child RenderLayers could be clipped out of the filtered area.
Tests: css3/filters/filter-repaint-blur.html
css3/filters/filter-repaint-child-layers.html
css3/filters/filter-repaint-composited-fallback-crash.html
css3/filters/filter-repaint-composited-fallback.html
css3/filters/filter-repaint-sepia.html
css3/filters/filter-repaint-shadow-clipped.html
css3/filters/filter-repaint-shadow-rotated.html
css3/filters/filter-repaint-shadow.html
* platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::getOutsets): Drop shadow should only enlarge the outsets and never make them smaller.
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build): Caching the operations.hasFilterThatMovesPixels() in the FilterEffectRenderer.
(WebCore::FilterEffectRenderer::updateBackingStore): It now returns true when the backing store was recreated, so that we can repaint it all.
(WebCore):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect): Separated beginFilterEffect into two methods. One that computed the rects
and one that prepares the draw context.
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
* rendering/FilterEffectRenderer.h:
(FilterEffectRendererHelper):
(FilterEffectRenderer):
(WebCore::FilterEffectRenderer::hasFilterThatMovesPixels):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint): No need to include the outsets in the repaint rect here, we will do it later in RenderLayer.
(WebCore::RenderBox::addVisualEffectOverflow): Removed outsets from the overflow.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::computeRectForRepaint): Removed the outsets from this method. We now compute that in
RenderLayer::setFilterBackendNeedsRepaintingInRect.
* rendering/RenderLayer.cpp:
(WebCore):
In this change I introduce a new dirty rectangle used by filters. It accumulates all the repaint requests inside the filtered layer,
so that we can invalidate the areas that are outside the clipping rectangle. Such cases include "overflow:scroll" and "overflow:hidden", when
we still want to blur or drop shadow based on content that is not actually displayed on screen (but the shadow for that content is visible). That rectangle
is called m_filterRepaintRect and resets back to zero when the next repaint is finished. All the filtered layers that apply blur and drop-shadow
will have an extra backing surface and only the invalidated areas are repainted in that surface. This is very similar to how composited layers work.
(WebCore::RenderLayer::requiresFullLayerImageForFilters): Returns true in CPU mode and only if the layer needs the full source image of
the layer to compute the filter. Otherwise GPU layers already have access to the full bakcing image.
(WebCore::RenderLayer::enclosingFilterLayer): Returns the enclosing layer that returns true on requiresFullLayerImageForFilters.
(WebCore::RenderLayer::enclosingFilterRepaintLayer): Returns the enclosing layer that can be used to repaint the current layer. Usually that
is the RenderView layer or the parent RenderLayer that is composited.
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect): Intercepts all the repaint queries for the filtered layers and uses
enclosingFilterRepaintLayer to enforce the repaint using the parent container.
(WebCore::RenderLayer::paintLayerContents): Consolidated the filters code in one single place. Also, it is now sending the bounding box and the
dirty rect to the FilterEffectRendererHelper::prepareFilterEffect to make sure the backing store is repainted accordingly. In some cases it might
rewrite the dirty rectangle used to paint the current layer, so that all the dirty areas in the backing store are covered.
(WebCore::RenderLayer::calculateLayerBounds): Extracted from RenderLayerCompositor::calculateCompositedBounds.
(WebCore::RenderLayer::updateOrRemoveFilterEffect): We should not create the filter builder when there's no filter specified.
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds): Now using the code from RenderLayer::calculateLayerBounds
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint): Using RenderLayer::enclosingFilterLayer to also find the parent filtered area.
(WebCore::RenderObject::repaintUsingContainer): Removed the need to add filter outsets in this method. We now compute that in
RenderLayer::setFilterBackendNeedsRepaintingInRect.
LayoutTests:
Reviewed by Dean Jackson.
Added more tests to cover all the repaint issues on filtered RenderLayers.
* css3/filters/filter-repaint-blur-expected.png: Added.
* css3/filters/filter-repaint-blur-expected.txt: Added.
* css3/filters/filter-repaint-blur.html: Added. Checking that the full image of the RenderLayer is used to compute
the blur, even if only a sub-section of the layer has repainted.
* css3/filters/filter-repaint-child-layers-expected.png: Added.
* css3/filters/filter-repaint-child-layers-expected.txt: Added.
* css3/filters/filter-repaint-child-layers.html: Added. Checking that the bounding box of the RenderLayer
and all its children are taken into account when computing the filter box.
* css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
* css3/filters/filter-repaint-composited-fallback-crash-expected.txt: Added.
* css3/filters/filter-repaint-composited-fallback-crash.html: Added. There was a crash when filters changed from CPU to GPU.
* css3/filters/filter-repaint-composited-fallback-expected.png: Added.
* css3/filters/filter-repaint-composited-fallback-expected.txt: Added.
* css3/filters/filter-repaint-composited-fallback.html: Added. Checking that repaint still works when platform GPU is not able to
compute the filter.
* css3/filters/filter-repaint-sepia-expected.png: Added.
* css3/filters/filter-repaint-sepia-expected.txt: Added.
* css3/filters/filter-repaint-sepia.html: Added. Testing that repaint still works correctly on simple filter that do not need the full
source image of the RenderLayer (ie. they are not displacing pixels positions).
* css3/filters/filter-repaint-shadow-clipped-expected.png: Added.
* css3/filters/filter-repaint-shadow-clipped-expected.txt: Added.
* css3/filters/filter-repaint-shadow-clipped.html: Added. Checking that an element that's out of view (clipped by the viewport) can
still drop a shadow that might be visible.
* css3/filters/filter-repaint-shadow-expected.png: Added.
* css3/filters/filter-repaint-shadow-expected.txt: Added.
* css3/filters/filter-repaint-shadow-rotated-expected.png: Added.
* css3/filters/filter-repaint-shadow-rotated-expected.txt: Added. Testing that transforms and clipping applied on filtered areas
work correctly with the new repaint methods.
* css3/filters/filter-repaint-shadow-rotated.html: Added.
* css3/filters/filter-repaint-shadow.html: Added. Checking that the full image of the RenderLayer is used to compute
the shadow, even if only a sub-section of the layer has repainted.
* platform/chromium/test_expectations.txt: Chromium needs expected results for the tests. Also the old filter-repaint.html had incorrect
expected results.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 30 Mar 2012 23:28:44 +0000 (23:28 +0000)]
Remove expectations for tests that are now passing.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 30 Mar 2012 23:27:51 +0000 (23:27 +0000)]
Add a compile assert for the size of BidiContext
https://bugs.webkit.org/show_bug.cgi?id=82793
Reviewed by Eric Seidel.
Added the assertion. Also reduced the number of bits used for bidi levels from
8 to 6 as done in InlineBox since bidi levels require exactly 6 bits.
* rendering/InlineBox.h: Added a comment about why bidi level needs exactly 6 bits.
* platform/text/BidiContext.cpp:
(SameSizeAsBidiContext):
(WebCore):
* platform/text/BidiContext.h:
(BidiContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
efidler@rim.com [Fri, 30 Mar 2012 23:26:53 +0000 (23:26 +0000)]
Enable OpenType Sanitizer for BlackBerry port.
https://bugs.webkit.org/show_bug.cgi?id=82782
Reviewed by Eric Seidel.
.:
* Source/cmake/OptionsBlackBerry.cmake: define USE(OPENTYPE_SANITIZER)
Source/WebKit:
* PlatformBlackBerry.cmake: add libots to link
Tools:
* Scripts/webkitdirs.pm:
(blackberryCMakeArguments): add OTS to include path
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Fri, 30 Mar 2012 23:04:47 +0000 (23:04 +0000)]
IndexedDB: Race condition causes version change transaction to commit after onblocked
https://bugs.webkit.org/show_bug.cgi?id=82678
Source/WebCore:
For a version change event, the blocked and success events could both be queued
before either is dispatched. The transaction would erroneously be allowed to commit
after the blocked event was dispatched; it should not be, as the request was not
finished.
Reviewed by Tony Chang.
Test: storage/indexeddb/dont-commit-on-blocked.html
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
LayoutTests:
Landing test marked PASS FAIL as WK82776 prevents it from running in DRT; will
run it as a Chromium browser test for now.
Reviewed by Tony Chang.
* platform/chromium/test_expectations.txt:
* storage/indexeddb/dont-commit-on-blocked.html: Added.
* storage/indexeddb/resources/dont-commit-on-blocked-worker.js: Added.
(request.onsuccess):
(onSetVersionBlocked):
(onSetVersionSuccess):
(onTransactionComplete):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Mar 2012 23:00:46 +0000 (23:00 +0000)]
run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
is found.
<rdar://problem/
11158581>
Reviewed by Mark Rowe.
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._start):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Mar 2012 23:00:38 +0000 (23:00 +0000)]
Skip another cookie test. Tracked by
https://bugs.webkit.org/show_bug.cgi?id=82749
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 30 Mar 2012 22:49:31 +0000 (22:49 +0000)]
Cleanup a bunch of useless junk that's accumulated over time.
Also delete comments that add no value.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 30 Mar 2012 22:36:08 +0000 (22:36 +0000)]
Add a compile assert for the size of FontDescription
https://bugs.webkit.org/show_bug.cgi?id=82786
Reviewed by Eric Seidel.
Added the assertion. Also converted a couple of boolean bitfields to unsinged.
I've verified that the conversions are safe (they're only used in FontDescription.h/cpp).
* platform/graphics/FontDescription.cpp:
(SameSizeAsFontDescription):
(WebCore):
* platform/graphics/FontDescription.h:
(FontDescription):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 30 Mar 2012 22:32:48 +0000 (22:32 +0000)]
Roll chromium DEPS from 129593 to 129574.
Unreviewed.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Mar 2012 22:27:03 +0000 (22:27 +0000)]
Disable run-api-tests on release mac builds
https://bugs.webkit.org/show_bug.cgi?id=82788
Reviewed by Ryosuke Niwa.
TestWebKitAPI crashes every time in release builds currently
(https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
run-api-tests on mac release builders.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(unitTestsSupported):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 30 Mar 2012 22:24:51 +0000 (22:24 +0000)]
[EFL] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=82741
Reviewed by Andreas Kling.
Modify the #include declarations for several EFL-related files
so that the wtf types are included using the full path.
* ewk/ewk_frame.cpp:
* ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
* ewk/ewk_tiled_matrix.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 30 Mar 2012 22:23:26 +0000 (22:23 +0000)]
Move CPP files related to ResourceHandle to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=82582
Reviewed by James Robinson.
Source/WebCore:
Re-land a tiny piece of http://trac.webkit.org/changeset/112572 in the
hopes of not breaking the component build this time.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/support/WebData.cpp: Copied from Source/WebKit/chromium/src/WebData.cpp.
Source/WebKit/chromium:
* WebKit.gyp:
* src/WebData.cpp: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Fri, 30 Mar 2012 22:21:43 +0000 (22:21 +0000)]
Kill CSSTimingFunctionValue.
<http://webkit.org/b/82787>
Reviewed by Antti Koivisto.
Remove CSSTimingFunctionValue and let the 3 subclasses inherit directly from CSSValue.
CSSTimingFunctionValue is a pointless middle-man class that adds nothing.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSTimingFunctionValue.h:
(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):
(WebCore::CSSCubicBezierTimingFunctionValue::CSSCubicBezierTimingFunctionValue):
(WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue):
* css/CSSValue.h:
(WebCore::CSSValue::isCubicBezierTimingFunctionValue):
(WebCore::CSSValue::isLinearTimingFunctionValue):
(WebCore::CSSValue::isStepsTimingFunctionValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Fri, 30 Mar 2012 21:44:56 +0000 (21:44 +0000)]
[chromium] Bump max texture updates per frame to 48
https://bugs.webkit.org/show_bug.cgi?id=82779
Reviewed by James Robinson.
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WTF):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Fri, 30 Mar 2012 21:42:01 +0000 (21:42 +0000)]
Merge FrameLoader::finishedLoading() into DocumentLoader::finishedLoading().
https://bugs.webkit.org/show_bug.cgi?id=82653
Reviewed by Adam Barth.
No new tests, no functionality change intended.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didFinishLoading):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 30 Mar 2012 21:23:35 +0000 (21:23 +0000)]
Cache origin check result to RuleData
https://bugs.webkit.org/show_bug.cgi?id=82774
Reviewed by Andreas Kling.
You wan't be able to get back to the stylesheet from a css style rule soon.
We need to do the origin check when we know the sheet it came from.
* css/CSSStyleSelector.cpp:
(RuleData):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(RuleSet):
(WebCore::makeRuleSet):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::RuleFeature::RuleFeature):
(RuleFeature):
(Features):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Fri, 30 Mar 2012 21:16:40 +0000 (21:16 +0000)]
Remove deadcode behind "SafeSkia" flag
https://bugs.webkit.org/show_bug.cgi?id=82771
Reviewed by Stephen White.
Just removing dead code (behind obsolete build flag), existing webkit tests apply
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 30 Mar 2012 21:14:26 +0000 (21:14 +0000)]
Add a compile assert for the size of InlineFlowBox
https://bugs.webkit.org/show_bug.cgi?id=82767
Reviewed by Tony Chang.
Add a compile assert to ensure InlineFlowBox stays small.
Also make some of the member variables not used in RootInlineBox private.
Changing these booleans to unsigned is safe as I've audited all code that
uses these member variables (they're all in InlineFlowBox or RootInlineBox).
* rendering/InlineFlowBox.cpp:
(SameSizeAsInlineFlowBox):
(WebCore):
* rendering/InlineFlowBox.h:
(InlineFlowBox):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 30 Mar 2012 21:11:54 +0000 (21:11 +0000)]
Unreviewed, new baseline.
* platform/chromium-win/svg/text/text-align-05-b-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Mar 2012 20:55:48 +0000 (20:55 +0000)]
Fix defective size_t overflow in GestureTapHighlighter.
https://bugs.webkit.org/show_bug.cgi?id=82605
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-30
Reviewed by Kenneth Rohde Christiansen.
.:
* ManualTests/tap-gesture-in-iframe-with-tap-highlight-crash.html: Added.
Source/WebCore:
In pathForRenderer, the for loop has 'i < rects().size() - 1' as test expression,
where rects().size() returns with size_t.
In case of empty rect, it leads to unsigned int overflow. Overflow value makes
the associated for loop run with invalid values.
Fix it by making loop variable int and stop using size_t type in the test expression.
Also, return early, if no focus ring found.
Manual test added. Tap gesture highlighter is getting triggered by UI process.
* page/GestureTapHighlighter.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Mar 2012 20:55:47 +0000 (20:55 +0000)]
Fix Lion build.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mifenton@rim.com [Fri, 30 Mar 2012 20:51:30 +0000 (20:51 +0000)]
[BlackBerry] Speed up processing of Selection region generation.
https://bugs.webkit.org/show_bug.cgi?id=82766
Reviewed by Rob Buis.
PR 136593.
Refactor generation of Selection IntRectRegion to avoid
the need for IntRectRegion's helper functions which were
not available when using it as a container without
unioning the rects.
This greatly speeds up rendering by maintaining the distinct
rects as the union operation was length with large numbers of
rects.
Reviewed Internally by Gen Mak, Mike Lattanzio and Tyler Abbott.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::visibleTextQuads):
(DOMSupport):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(WebKit):
(BlackBerry::WebKit::regionRectListContainsPoint):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
* WebKitSupport/SelectionHandler.h:
(WebCore):
(SelectionHandler):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Mar 2012 20:50:09 +0000 (20:50 +0000)]
GEOLOCATION should be implemented as Page Supplement
https://bugs.webkit.org/show_bug.cgi?id=82228
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-30
Reviewed by Adam Barth.
Source/WebCore:
Geolocation now uses the Supplement interface instead of
keeping an instance variable on Page. This allows us to
remove all geolocation-related functions, variables, and
ifdefs out of Page and into Modules/geolocation/.
* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
* Modules/geolocation/Geolocation.h:
(WebCore):
* Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::supplementName):
(WebCore):
(WebCore::provideGeolocationTo):
* Modules/geolocation/GeolocationController.h:
(GeolocationController):
(WebCore::GeolocationController::from):
* WebCore.exp.in:
* page/GeolocationClient.h:
(WebCore):
(GeolocationClient):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):
* page/Page.h:
(WebCore):
(PageClients):
(Page):
Source/WebKit/blackberry:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
* WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):
* WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
Source/WebKit/chromium:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Source/WebKit/gtk:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/GeolocationClientGtk.cpp:
(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
Source/WebKit/mac:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):
Source/WebKit/qt:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/GeolocationClientQt.cpp:
(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):
Source/WebKit/win:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
* WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):
Source/WebKit2:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
* WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setGeoLocationPermission):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Mar 2012 20:47:03 +0000 (20:47 +0000)]
This is fun.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Mar 2012 20:38:52 +0000 (20:38 +0000)]
Rebaseline due to wkbug.com/80423
https://bugs.webkit.org/show_bug.cgi?id=82743
Patch by Philip Rogers <pdr@google.com> on 2012-03-30
Reviewed by Simon Fraser.
* platform/mac/Skipped:
* platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Mar 2012 20:33:36 +0000 (20:33 +0000)]
Yet another build fix attempt.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Mar 2012 20:29:42 +0000 (20:29 +0000)]
Integrate IETC CSS : textshadow tests
https://bugs.webkit.org/show_bug.cgi?id=81936
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-30
Reviewed by Adam Barth.
Adding expected pngs and render tree dumps for IETC text shadow tests.
* platform/chromium-linux/ietestcenter/css3/text/textshadow-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/text/textshadow-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/text/textshadow-003-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/text/textshadow-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/text/textshadow-005-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/text/textshadow-006-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/text/textshadow-007-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/text/textshadow-008-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/text/textshadow-009-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/text/textshadow-010-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-001-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-002-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-003-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-004-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-005-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-006-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-007-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-008-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-009-expected.png: Added.
* platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-010-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-003-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-005-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-006-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-007-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-008-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-009-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-010-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-003-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-005-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-006-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-007-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-008-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-009-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-010-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-003-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-005-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-006-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-007-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-008-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-009-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 30 Mar 2012 20:21:35 +0000 (20:21 +0000)]
More SVG rebaselining.
Unreviewed, new baselines and expectations, for:
svg/W3C-SVG-1.1/animate-elem-37-t.svg
svg/W3C-SVG-1.1/animate-elem-81-t.svg
svg/W3C-SVG-1.1/animate-elem-82-t.svg
svg/W3C-SVG-1.1/animate-elem-83-t.svg
svg/W3C-SVG-1.1/struct-frag-02-t.svg
svg/W3C-SVG-1.1/text-align-05-b.svg
svg/text/text-align-05-b.svg
svg/zoom/page/zoom-coords-viewattr-01-b.svg
svg/zoom/text/zoom-coords-viewattr-01-b.svg
svg/W3C-SVG-1.1/types-basicDOM-01-b.svg
* platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Mar 2012 20:19:22 +0000 (20:19 +0000)]
[BlackBerry] Make sure strings do not leak in PluginViewBlackberry.
https://bugs.webkit.org/show_bug.cgi?id=82764
Update PluginViewBlackBerry to follow the changes in
BlackBerry::Platform::Window which now returns std::string instead of char* for
strings. Also copy the windowGroup and rootGroup strings in PluginViewPrivate
instead of just saving a pointer to the returned memory, which could become
invalid at any time.
Patch by Joe Mason <jmason@rim.com> on 2012-03-30
Reviewed by Rob Buis.
* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformDestroy):
* plugins/blackberry/PluginViewPrivateBlackBerry.h:
(PluginViewPrivate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Mar 2012 20:03:10 +0000 (20:03 +0000)]
Another build fix.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 30 Mar 2012 19:56:45 +0000 (19:56 +0000)]
Add new renderer for circles and ellipses
https://bugs.webkit.org/show_bug.cgi?id=80423
One more unreviewed gardening after r112667.
* platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 30 Mar 2012 19:31:54 +0000 (19:31 +0000)]
Unreviewed, expectations updates for Lion, Linux for some SVG tests.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
* platform/chromium-mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt.
* platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
* platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
* platform/chromium-mac/svg/custom/viewbox-syntax-expected.txt:
* platform/chromium-mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
* platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
* platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
* platform/chromium-win/svg/custom/viewbox-syntax-expected.txt:
* platform/chromium/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Mar 2012 19:22:24 +0000 (19:22 +0000)]
Fix build.
* page/scrolling/mac/ScrollingTreeMac.mm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 30 Mar 2012 19:06:53 +0000 (19:06 +0000)]
Chromium garden-o-matic rebaselines for expected failures.
Most of these are one of the following:
-text-rendering differences
-anti-aliasing differences
-form control/scrollbar rendering
-different error messages from V8 vs. JSC
-Mac bots paint repaint shadow at a slightly different shade
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Mar 2012 19:05:59 +0000 (19:05 +0000)]
[chromium] Flaky animation unit test CCLayerTreeHostTestSynchronizeAnimationStartTimes
https://bugs.webkit.org/show_bug.cgi?id=82731
Patch by Ian Vollick <vollick@chromium.org> on 2012-03-30
Reviewed by James Robinson.
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::animateLayers):
(CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::notifyAnimationStarted):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Mar 2012 18:59:49 +0000 (18:59 +0000)]
Show a scrolling indicator light when compositing borders are turned on
https://bugs.webkit.org/show_bug.cgi?id=82758
<rdar://problem/
11143892>
Reviewed by Andreas Kling.
Source/WebCore:
With this change, turning on compositing borders also turn on a tiny indicator in the top left corner.
This indicator uses color coding to show where wheel events are handled and where the scroll layer position is updated:
- Green means that both wheel events and scroll layer position updates are handled on the scrolling thread.
- Yellow means that wheel events need to be dispatched to the main thread (due to wheel event handlers), but that scroll layer position
updates still happen on the scrolling thread.
- Red means that scroll layer position updates happen on the main thread (due to background-attachment: fixed or fixed position objects).
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
Call updateDebugRootLayer().
* page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThread):
Make this public.
(ScrollingTreeNode):
* page/scrolling/mac/ScrollingTreeMac.mm: Added.
(WebCore::ScrollingTree::setDebugRootLayer):
Set up a new debug info sublayer.
(WebCore::ScrollingTree::updateDebugRootLayer):
Update the debug root layer background color based on the scrolling tree state.
Source/WebKit2:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::updatePreferences):
Add a hook for letting drawing area subclasses know when preferences change.
* WebProcess/WebPage/WebPage.cpp:
Call DrawingArea::updatePreferences.
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Call updatePreferences.
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
If compositing borders are enabled, create a debug root layer and tell the scrolling tree about it.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
If we have a debug root layer, make sure it's in front.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 30 Mar 2012 18:54:04 +0000 (18:54 +0000)]
Web Inspector: CodeGeneratorInspector.py: add missing runtime assert method for InspectorObject
https://bugs.webkit.org/show_bug.cgi?id=82753
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-30
Reviewed by Vsevolod Vlasov.
Type validator generator is extended to support missing InspectorObject type and
made more accurate for "int" type.
Strict types are enabled for 2 more domains.
* inspector/CodeGeneratorInspector.py:
(RawTypes.BaseType.generate_validate_method):
(RawTypes.String.get_validate_method_params.ValidateMethodParams):
(RawTypes.Int):
(RawTypes.Int.generate_validate_method):
(RawTypes.Int.get_raw_validator_call_text):
(RawTypes.Number.get_validate_method_params.ValidateMethodParams):
(RawTypes.Bool.get_validate_method_params.ValidateMethodParams):
(RawTypes.Object.get_validate_method_params.ValidateMethodParams):
(RawTypes.Object.get_validate_method_params):
(TypeBindings.create_type_declaration_.ClassBinding.request_internal_runtime_cast):
(PlainObjectBinding.request_internal_runtime_cast):
(PlainObjectBinding.get_validator_call_text):
(ArrayBinding.request_internal_runtime_cast):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Mar 2012 18:49:40 +0000 (18:49 +0000)]
Fix a typo in the Skipped list.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Mar 2012 18:44:58 +0000 (18:44 +0000)]
Skip some more failing/timing-out tests.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Mar 2012 18:39:43 +0000 (18:39 +0000)]
[chromium] assertion being hit in CCLayerAnimationController
https://bugs.webkit.org/show_bug.cgi?id=82237
Patch by Ian Vollick <vollick@chromium.org> on 2012-03-30
Reviewed by James Robinson.
Source/WebCore:
Animations are no longer pushed to the impl thread if they have already completed.
Tested in CCLayerAnimationControllerTest.doNotSyncFinishedAnimation
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
Source/WebKit/chromium:
* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 30 Mar 2012 18:32:18 +0000 (18:32 +0000)]
Build fix after r112699.
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::findPropertyWithId):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 30 Mar 2012 18:27:16 +0000 (18:27 +0000)]
Add a compile assert for the size of CSSProperty
https://bugs.webkit.org/show_bug.cgi?id=82756
Reviewed by Andreas Kling.
Add a compile assert to ensure CSSProperty instances stay small.
Also make member variables of CSSProperty private as they should have been,
and extract wrapValueInCommaSeparatedList from createFontFaceRule.
* css/CSSParser.cpp:
(WebCore::CSSParser::createFontFaceRule):
* css/CSSProperty.cpp:
(SameSizeAsCSSProperty):
(WebCore):
(WebCore::CSSProperty::wrapValueInCommaSeparatedList):
* css/CSSProperty.h:
(CSSProperty):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Fri, 30 Mar 2012 18:24:18 +0000 (18:24 +0000)]
2012-03-30 Chang Shu <cshu@webkit.org>
Unreviewed. Update my email.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 30 Mar 2012 18:20:30 +0000 (18:20 +0000)]
Let there be a clean xcodeproj.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shawnsingh@chromium.org [Fri, 30 Mar 2012 18:13:11 +0000 (18:13 +0000)]
Unreviewed rebaseline after r112436
* platform/chromium-linux/compositing/reflections/nested-reflection-on-overflow-expected.png:
* platform/chromium-mac-leopard/compositing/reflections/nested-reflection-on-overflow-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-on-overflow-expected.png:
* platform/chromium-mac/compositing/reflections/nested-reflection-on-overflow-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-on-overflow-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 30 Mar 2012 18:09:29 +0000 (18:09 +0000)]
[Chromium] Unreviewed Chromium Mac build fix.
* src/WebDevToolsAgentPrivate.h:
(WebKit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 30 Mar 2012 18:07:27 +0000 (18:07 +0000)]
AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
https://bugs.webkit.org/show_bug.cgi?id=82745
Reviewed by Simon Fraser.
Source/WebCore:
Test: platform/mac/accessibility/range-for-position.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::index):
Tools:
* DumpRenderTree/AccessibilityUIElement.cpp:
(rangeForPositionCallback):
(AccessibilityUIElement::rangeForPosition):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::rangeForPosition):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::rangeForPosition):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR):
LayoutTests:
* platform/mac/accessibility/range-for-position-expected.txt: Added.
* platform/mac/accessibility/range-for-position.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 30 Mar 2012 18:02:13 +0000 (18:02 +0000)]
[Chromium] Unreviewed, rebaseline part of expectations after r112667 using garden-o-matic (224 files affected).
* platform/chromium-linux-x86/svg/: [...]
* platform/chromium-linux/svg/: [...]
* platform/chromium-mac-leopard/svg/: [...]
* platform/chromium-mac-snowleopard/svg/: [...]
* platform/chromium-mac/svg/: [...]
* platform/chromium-win-vista/svg/: [...]
* platform/chromium-win-xp/svg/: [...]
* platform/chromium-win/svg/: [...]
* platform/chromium/svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/hixie/shapes/path/001-expected.txt.
* platform/chromium/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
* platform/gtk/svg/hixie/perf/001-expected.txt: Removed.
* platform/gtk/svg/hixie/perf/002-expected.txt: Removed.
* platform/gtk/svg/hixie/shapes/path/001-expected.txt: Removed.
* platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png: Removed.
* svg/hixie/mixed/004-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/mixed/004-expected.txt.
* svg/hixie/mixed/005-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/mixed/005-expected.txt.
* svg/hixie/perf/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/001-expected.txt.
* svg/hixie/perf/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/002-expected.txt.
* svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/shapes/path/001-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 30 Mar 2012 18:00:41 +0000 (18:00 +0000)]
Certain emoji characters should not be displayed in user-visible URL strings.
<https://bugs.webkit.org/show_bug.cgi?id=82739>
<rdar://problem/9205643>
Reviewed by Alexey Proskuryakov
* platform/mac/WebCoreNSURLExtras.mm:
(WebCore::isLookalikeCharacter):
Added five emoji characters to the list.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 30 Mar 2012 17:54:03 +0000 (17:54 +0000)]
Web Inspector: [Chromium] Implement Chromium-specific part of the device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82612
This change implements the Chromium-specific code for overriding the device metrics, such as screen size
(by setting the FrameView size) and font zoom factor (necessary for certain emulated devices,)
and for painting the gutter overlay covering the WebView area not occupied by the associated FrameView.
Reviewed by Pavel Feldman.
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canOverrideDeviceMetrics):
(WebKit):
(WebKit::InspectorClientImpl::overrideDeviceMetrics):
(WebKit::InspectorClientImpl::autoZoomPageToFitWidth):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(OverlayZOrders):
(DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::~DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::setDeviceMetrics):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::applySizeOverrideIfNecessary):
(WebKit::DeviceMetricsSupport::restore):
(WebKit::DeviceMetricsSupport::applySizeOverrideInternal):
(WebKit::DeviceMetricsSupport::paintPageOverlay):
(WebKit::DeviceMetricsSupport::frameView):
(WebKit):
(WebKit::WebDevToolsAgentImpl::mainFrameViewCreated):
(WebKit::WebDevToolsAgentImpl::metricsOverridden):
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
(WebKit::WebDevToolsAgentImpl::autoZoomPageToFitWidth):
(WebKit::WebDevToolsAgentImpl::highlight):
* src/WebDevToolsAgentImpl.h:
(WebCore):
(WebKit):
(WebDevToolsAgentImpl):
* src/WebDevToolsAgentPrivate.h:
(WebKit):
(WebDevToolsAgentPrivate):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setEmulatedTextZoomFactor):
(WebKit):
(WebKit::WebViewImpl::updateLayerTreeViewport):
* src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::emulatedTextZoomFactor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Mar 2012 17:53:28 +0000 (17:53 +0000)]
Skip some more failing tests.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Mar 2012 17:37:20 +0000 (17:37 +0000)]
Skip fast/css/font-face-data-uri.html which is flaky.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=82744
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Mar 2012 17:35:16 +0000 (17:35 +0000)]
Skip a test, tracked by https://bugs.webkit.org/show_bug.cgi?id=82743.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Mar 2012 17:31:33 +0000 (17:31 +0000)]
Skip two lineboxcontain tests. Tracked by
https://bugs.webkit.org/show_bug.cgi?id=82742
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Mar 2012 17:17:03 +0000 (17:17 +0000)]
Split up top-level .gitignore and .gitattributes
https://bugs.webkit.org/show_bug.cgi?id=82687
Patch by David Barr <davidbarr@chromium.org> on 2012-03-30
Reviewed by Tor Arne Vestbø.
.:
Jeff King <peff@peff.net> suggested this on the git mailing list.
http://article.gmane.org/gmane.comp.version-control.git/194294
He reported a 1.6 times speed up for 'git status'.
* .gitattributes:
* .gitignore:
* ManualTests/.gitattributes: Added.
* Source/.gitignore: Added.
* Websites/.gitattributes: Added.
PerformanceTests:
* .gitattributes: Added.
Source/JavaScriptCore:
* JavaScriptCore.gyp/.gitignore: Added.
Source/Platform:
* Platform.gyp/.gitignore: Added.
Source/ThirdParty:
* glu/.gitignore: Added.
Source/WebCore:
No new tests, source control administrivia.
* .gitattributes: Added.
* WebCore.gyp/.gitignore: Added.
Source/WebKit/chromium:
* .gitignore: Added.
Source/WTF:
* WTF.gyp/.gitignore: Added.
Tools:
* .gitattributes: Added.
* .gitignore: Added.
* DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
* TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
LayoutTests:
* .gitattributes: Added.
* .gitignore: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Fri, 30 Mar 2012 17:08:51 +0000 (17:08 +0000)]
pass alpha directly to player, rather than creating a layer (for performance)
https://bugs.webkit.org/show_bug.cgi?id=82360
Reviewed by Stephen White.
Performance change, existing webkit tests apply.
* public/WebMediaPlayer.h:
(WebMediaPlayer):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 30 Mar 2012 16:53:54 +0000 (16:53 +0000)]
[WinCE] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=82713
Reviewed by Eric Seidel.
Modify the #include declarations for several WinCE-related files
so that the wtf types are included using the full path.
Source/WebCore:
* platform/graphics/wince/ImageBufferWinCE.cpp:
Source/WebKit/wince:
* WebView.cpp:
* WebView.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 30 Mar 2012 16:47:35 +0000 (16:47 +0000)]
Windows (make based) build fix.
* JavaScriptCore.vcproj/JavaScriptCore.make: Copy WTF header files into a place where JavaScriptCore build can see them.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 30 Mar 2012 16:39:02 +0000 (16:39 +0000)]
Web Inspector: ScriptsNavigator scripts selection/focus polish.
https://bugs.webkit.org/show_bug.cgi?id=82732
Reviewed by Pavel Feldman.
Script could be selected by space in ScriptsNavigator now.
This patch also polishes focus behavior when using ScriptsNavigator.
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._scriptSelected): Added focusSource param to give clients possibility to release focus.
(WebInspector.NavigatorScriptTreeElement.prototype.onspace): Added script selection on space pressed.
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
* inspector/front-end/ScriptsPanel.js: _hideNavigatorOverlay moved to the end of events processing to set focus correctly.
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
* inspector/front-end/treeoutline.js:
(TreeOutline.prototype._treeKeyDown): onspace event added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Fri, 30 Mar 2012 16:33:11 +0000 (16:33 +0000)]
remove unneeded copies of SkPaths, remove unneeded save/restore
https://bugs.webkit.org/show_bug.cgi?id=82641
Reviewed by Stephen White.
Performance change, existing webkit tests apply.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 30 Mar 2012 16:31:14 +0000 (16:31 +0000)]
Actually remove the ChromiumOS GTK builder, like r112673 said it would.
* TestResultServer/static-dashboards/builders.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 30 Mar 2012 16:24:35 +0000 (16:24 +0000)]
Web Inspector: undo-ing edit that consists of a Tab does not work.
https://bugs.webkit.org/show_bug.cgi?id=82733
Reviewed by Vsevolod Vlasov.
Source/WebCore:
We should never modify the range returned by the edit operation manually.
And we should clone ranges that get into the model so that subsequent edits
don't mutate them.
Drive-by: restore selection after undo via selecting all the text that undo
operation produced.
Test: inspector/editor/text-editor-undo-redo.html
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
* inspector/front-end/TextViewer.js:
LayoutTests:
* inspector/editor/text-editor-undo-redo-expected.txt: Added.
* inspector/editor/text-editor-undo-redo.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 30 Mar 2012 16:23:45 +0000 (16:23 +0000)]
Update ChromiumOS bot names in builders.js to reflect changes made by
http://crrev.com/129835
Also removes the ChromiumOS GTK builder, which was removed by
http://crrev.com/129835
* TestResultServer/static-dashboards/builders.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Mar 2012 16:18:39 +0000 (16:18 +0000)]
[GTK] Disable introspection build in the at-spi2-core module.
https://bugs.webkit.org/show_bug.cgi?id=82729
Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-30
Reviewed by Philippe Normand.
This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
* gtk/jhbuild.modules: Disable introspection.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 30 Mar 2012 16:00:29 +0000 (16:00 +0000)]
Add new renderer for circles and ellipses
https://bugs.webkit.org/show_bug.cgi?id=80423
Unreviewed gardening after r112667.
* platform/qt/svg/ [...] : Updated.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 30 Mar 2012 15:57:26 +0000 (15:57 +0000)]
[wx] Implement Gradient and ImageBuffer support.
https://bugs.webkit.org/show_bug.cgi?id=82710
Reviewed by Kevin Ollivier.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Mar 2012 15:47:04 +0000 (15:47 +0000)]
[Qt] Find zoomable area using area-based hit-testing
https://bugs.webkit.org/show_bug.cgi?id=82609
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-30
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Implement API for calculating the best zoomable area for a
tap-to-zoom gesture.
It picks the area with the largest intersection with the touch. In most
cases this will be all areas fully containing the area, and returns the
smallest inner-most of these.
* page/EventHandler.cpp:
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
* page/EventHandler.h:
* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::nodeIsZoomTarget):
(WebCore::TouchAdjustment::appendZoomableSubtargets):
(WebCore::TouchAdjustment::compileZoomableSubtargets):
(WebCore::TouchAdjustment::areaOfIntersection):
(WebCore::TouchAdjustment::findAreaWithLargestIntersection):
(WebCore::findBestZoomableArea):
* page/TouchAdjustment.h:
* platform/graphics/IntSize.h:
(WebCore::IntSize::area):
Source/WebKit2:
Add area to findZoomableAreaForPoint and use new TOUCH_ADJUSTMENT
code-path to find the best zoomable area.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findZoomableAreaForPoint):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleDoubleTapEvent):
* WebProcess/WebPage/WebPage.cpp:
(WebKit):
(WebKit::WebPage::findZoomableAreaForPoint):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc