Daniel Stenberg [Sat, 24 Sep 2011 22:02:58 +0000 (00:02 +0200)]
POST: always set postfieldsize
When we use binary posts and regular ones intermixed on a single command
line, we cannot do strlen() etc on the data to figure out the length
(when inserting '&' and more). We must therefore keep track of the post
data length. Then we also end up setting the libcurl option with the
known size, so that we don't risk that libcurl will do strlen() on the
data.
This has the minor side-effect that --libcurl source codes now always
will use CURLOPT_POSTFIELDSIZE but I don't consider that terribly
damaging.
Bug: http://curl.haxx.se/bug/view.cgi?id=3413181
Reported by: Taneli Vähäkangas
Yang Tse [Sat, 24 Sep 2011 16:33:59 +0000 (18:33 +0200)]
curl tool: fix a compiler warning
Yang Tse [Sat, 24 Sep 2011 15:38:16 +0000 (17:38 +0200)]
curl tool: reviewed code moved to tool_*.[ch] files
Guenter Knauf [Sat, 24 Sep 2011 13:06:21 +0000 (15:06 +0200)]
Added header to be included by dist script.
Probably the wrong place, but I dont know better.
Yang Tse [Sat, 24 Sep 2011 03:32:51 +0000 (05:32 +0200)]
curl tool: fix some OOM handling issues
Daniel Stenberg [Fri, 23 Sep 2011 22:05:58 +0000 (00:05 +0200)]
http header: allow Content-Length to be replaced
In some cases Content-Length: couldn't be replaced by an application
Also, indented some code properly
Guenter Knauf [Fri, 23 Sep 2011 01:56:34 +0000 (03:56 +0200)]
MinGW64 has this prototype already.
Guenter Knauf [Fri, 23 Sep 2011 01:21:50 +0000 (03:21 +0200)]
Fixed scanf format for WORD = unsigned short.
Guenter Knauf [Fri, 23 Sep 2011 01:00:32 +0000 (03:00 +0200)]
Added Win32-only samples.
Guenter Knauf [Thu, 22 Sep 2011 23:22:18 +0000 (01:22 +0200)]
Added a workaround for printing size_t.
Daniel Stenberg [Thu, 22 Sep 2011 20:34:54 +0000 (22:34 +0200)]
Curl_pgrsStartNow: keep HEADERS_OUT set
To avoid that the progress meter headers get output between each
transfer, make sure the bits gets kept when (re-)inited.
Reported by: Christopher Stone
Yang Tse [Thu, 22 Sep 2011 19:20:28 +0000 (21:20 +0200)]
curl tool: fix some OOM handling issues
Yang Tse [Thu, 22 Sep 2011 09:16:34 +0000 (11:16 +0200)]
curl tool: reviewed code moved to tool_*.[ch] files
my_setopt and my_setopt_str no longer ignores curl_easy_setopt result.
Fixed some OOM handling issues.
Guenter Knauf [Thu, 22 Sep 2011 12:34:58 +0000 (14:34 +0200)]
Added NetWare examples makefile.
Yang Tse [Wed, 21 Sep 2011 22:24:02 +0000 (00:24 +0200)]
NTLM_WB: fix disabling of NTLM_WB when NTLM is disabled
Daniel Stenberg [Wed, 21 Sep 2011 20:32:27 +0000 (22:32 +0200)]
test 814: smtp without --mail-from
Verifies the fix from commit
322f3d5af7093
Gisle Vanem [Wed, 21 Sep 2011 20:24:45 +0000 (22:24 +0200)]
smtp: without a MAIL_FROM, send blank MAIL FROM
I think curl should ignore this case and smtp.c should test for this.
Since RFC-2821 seems to allow a "null reverse-path". Ref. "MAIL
FROM:<>" in section 3.7, page 25.
Dave Reisner [Wed, 21 Sep 2011 19:19:29 +0000 (21:19 +0200)]
lib/http: add missing whitespace in verbose output
Example:
* upload completely sent off: 35out of 35 bytes
Should be:
* upload completely sent off: 35 out of 35 bytes
Guenter Knauf [Wed, 21 Sep 2011 16:21:05 +0000 (18:21 +0200)]
Another MinGW example makefile tweak.
Guenter Knauf [Wed, 21 Sep 2011 16:09:34 +0000 (18:09 +0200)]
Fixed sample to compile for Windows platform.
Yang Tse [Wed, 21 Sep 2011 02:28:46 +0000 (04:28 +0200)]
curl tool: make my_setopt ignore curl_easy_setopt result again.
Related code not ready yet for this kind of checks.
Guenter Knauf [Wed, 21 Sep 2011 01:25:19 +0000 (03:25 +0200)]
Changed suffix rules to pattern rules.
Suffix rules cannot have any prerequisites of their own.
Guenter Knauf [Wed, 21 Sep 2011 00:13:18 +0000 (02:13 +0200)]
Added dependency so that curlbuild.h is created.
Guenter Knauf [Wed, 21 Sep 2011 00:02:31 +0000 (02:02 +0200)]
Some more MinGW build tweaks.
Added envvars to specify OpenSSL include, libpath and lib.
Added rule to create curlbuild.h from curlbuild.h.dist.
Yang Tse [Tue, 20 Sep 2011 23:54:14 +0000 (01:54 +0200)]
curl tool: reviewed code moved to tool_*.[ch] files
my_setopt and my_setopt_str no longer ignores curl_easy_setopt result.
Fixed some OOM handling issues.
Yang Tse [Tue, 20 Sep 2011 13:58:35 +0000 (15:58 +0200)]
curl tool: reviewed code moved to tool_*.[ch] files
Overhauled FindWin32CACert()
Guenter Knauf [Tue, 20 Sep 2011 13:05:28 +0000 (15:05 +0200)]
A bunch of MinGW build tweaks.
All paths to dependencies now quoted; synced examples makefile.
Guenter Knauf [Tue, 20 Sep 2011 10:32:04 +0000 (12:32 +0200)]
Changed Windows 64bit OS define to x86_64.
Also added check for __x86_64__ define since MinGW64 seems to define
the _M_X64 macro through a header not available for config-win32.h.
Guenter Knauf [Tue, 20 Sep 2011 10:05:31 +0000 (12:05 +0200)]
Also skip certs masked as CKT_NSS_TRUST_UNKNOWN.
Fix posted by Tomas Hoger <thoger redhat com>.
Guenter Knauf [Tue, 20 Sep 2011 09:59:10 +0000 (11:59 +0200)]
Added _WIN32_WINNT define for IPv6 builds.
Daniel Stenberg [Tue, 20 Sep 2011 09:13:32 +0000 (11:13 +0200)]
Curl_follow: handle redirects to "//hostname/path"
Yang Tse [Mon, 19 Sep 2011 18:27:25 +0000 (20:27 +0200)]
curl tool: truly fix compiler warning
Yang Tse [Mon, 19 Sep 2011 17:45:58 +0000 (19:45 +0200)]
curl tool: fix compiler warning
Yang Tse [Mon, 19 Sep 2011 16:18:17 +0000 (18:18 +0200)]
curl tool: reviewed code moved to tool_*.[ch] files
Daniel Stenberg [Sun, 18 Sep 2011 21:42:29 +0000 (23:42 +0200)]
CURLOPT_URL docs: no need to mention function names
Steve Holme [Sun, 18 Sep 2011 13:16:13 +0000 (14:16 +0100)]
CURLOPT_URL: Expanded URL description
Expanded the section about CURLOPT_URL to include the format of the URL
and detailed information and examples relating to specific protocols.
Steve Holme [Tue, 13 Sep 2011 21:19:47 +0000 (22:19 +0100)]
Curl_gethostname: return un-qualified machine name
Fixed Curl_gethostname() so that it always returns the un-qualified
machine name rather than being dependent on the socket provider.
Note: The return of getenv("CURL_GETHOSTNAME") is also parsed in case
the developer / test harness provided a fully qualified domain name as
it's value as well.
Yang Tse [Sat, 17 Sep 2011 23:58:18 +0000 (01:58 +0200)]
curl tool: create tool_myfunc.[ch] which later on will hold my_* functions
Additionally function my_useragent() now provides default User-Agent string
Yang Tse [Sat, 17 Sep 2011 12:09:36 +0000 (14:09 +0200)]
curl tool: reorder free_config_fields() field handling
Reorder handling of fields to match same order as the one given by current
definition order of 'Configurable' struct fields. Fields currently not handled
marked for further inspection.
Guenter Knauf [Sat, 17 Sep 2011 15:59:35 +0000 (17:59 +0200)]
Fixed MinGW WinIDN lib dependency.
Yang Tse [Sat, 17 Sep 2011 01:28:57 +0000 (03:28 +0200)]
tool_convert.c: fix no newline at end of file
Yang Tse [Fri, 16 Sep 2011 19:55:13 +0000 (21:55 +0200)]
curl tool: add new files to Symbian's .mmp project file
Yang Tse [Fri, 16 Sep 2011 19:44:45 +0000 (21:44 +0200)]
curl tool: move 'Configurable' and free_config_fields() to tool_cfgable.[ch]
Reviewing fields being free'd in free_config_fields() still pending
Yang Tse [Fri, 16 Sep 2011 19:12:32 +0000 (21:12 +0200)]
src/setup.h: add conditional include of assert.h
Yang Tse [Fri, 16 Sep 2011 17:46:01 +0000 (19:46 +0200)]
curl tool: move so called 'multi_files' stuff into tool_mfiles.[ch]
Additionally some code reorganization and direct OOM handling fixes,
just another step towards fixing curl tool issues uncovered 2011-09-15
Yang Tse [Fri, 16 Sep 2011 13:31:29 +0000 (15:31 +0200)]
curl tool: move convert_* functions into tool_convert.[ch]
Additionally fix data type of result vars for iconv() calls
Yang Tse [Thu, 15 Sep 2011 22:57:54 +0000 (00:57 +0200)]
main.c: convert GetStr() into a macro to ease leak debugging
Yang Tse [Thu, 15 Sep 2011 22:36:21 +0000 (00:36 +0200)]
main.c: de-obfuscate a couple for-loop exit conditions
Yang Tse [Thu, 15 Sep 2011 18:03:30 +0000 (20:03 +0200)]
curl tool: fix a bunch of double free's uncovered 2011-09-15
Re-enabling MemoryTracking capability on 'src' subdirectory files and torture
tests have uncovered many issues which were going unnoticed in curl tool. So
here we go fixing some of them. Others still remain and should be addressed
ASAP, given that curl tool is used in our test harness also for test server
start verification purposes. There are even non-socket file descriptor leaks.
Yang Tse [Thu, 15 Sep 2011 15:35:23 +0000 (17:35 +0200)]
Make Curl_safefree() macro assign NULL to given pointer when free'd
Yang Tse [Thu, 15 Sep 2011 09:40:54 +0000 (11:40 +0200)]
curl MSVC project files: adjust resource compiler include path
Yang Tse [Wed, 14 Sep 2011 18:31:23 +0000 (20:31 +0200)]
src/Makefile.vc6: adjust resource compiler include path
Yang Tse [Wed, 14 Sep 2011 09:27:12 +0000 (11:27 +0200)]
curl tool: re-enable MemoryTracking capability on 'src' subdirectory files.
Use same preprocessor logic for curl tool MemoryTracking activation in source
files located in 'src' subdirectory as the one used for libcurl sources.
Yang Tse [Wed, 14 Sep 2011 08:36:29 +0000 (10:36 +0200)]
ftp.c: add a couple of failure messages
warp kawada [Thu, 8 Sep 2011 22:39:39 +0000 (15:39 -0700)]
Curl_add_custom_headers: support headers with no data
A custom HTTP header ending in a semicolon instead of a colon
will be treated as a header to be added without any data
portion.
Daniel Stenberg [Tue, 13 Sep 2011 20:47:34 +0000 (22:47 +0200)]
progressfunc: a simple CURLOPT_PROGRESSFUNCTION example
Daniel Stenberg [Tue, 13 Sep 2011 18:04:03 +0000 (20:04 +0200)]
7.22.1: start working
Daniel Stenberg [Tue, 13 Sep 2011 18:03:17 +0000 (20:03 +0200)]
THANKS: 16 new contributors from 7.22.0
Daniel Stenberg [Tue, 13 Sep 2011 16:53:00 +0000 (18:53 +0200)]
RELEASE-NOTES: ready for 7.22.0
Daniel Stenberg [Tue, 13 Sep 2011 16:46:09 +0000 (18:46 +0200)]
codestyle: minor whitespace fix
Jeff Pohlmeyer [Tue, 13 Sep 2011 16:44:41 +0000 (18:44 +0200)]
polarssl: build with PolarSSL-1.0.0
With this fix, it should work for PolarSSL-1.0.0 (and SVN-1091 trunk)
and retain compatibility with earlier versions. (Tested with 0.14.1)
PolarSSL still doesn't play nicely with curl's CA bundle (we discussed
this before) but I was at least able to retrieve the
https://www.gmail.com/ login page using a modified ca-certificates.crt
file with all 3 versions of PolarSSL.
Daniel Stenberg [Tue, 13 Sep 2011 11:05:31 +0000 (13:05 +0200)]
BUGS: spellfixed, slightly reformatted for web looks
Reported by: Jeff Pohlmeyer
Dan Fandrich [Mon, 12 Sep 2011 21:45:22 +0000 (14:45 -0700)]
Document NTLM winbind options (and caveats)
Daniel Stenberg [Mon, 12 Sep 2011 21:02:41 +0000 (23:02 +0200)]
BUGS: renumbered to look better in the web version
Daniel Stenberg [Mon, 12 Sep 2011 20:55:40 +0000 (22:55 +0200)]
BUGS: revamped bug report documentation
Yang Tse [Mon, 12 Sep 2011 14:01:07 +0000 (16:01 +0200)]
Mention that BSD-style lwIP TCP/IP stack support on Windows is experimental.
Yang Tse [Mon, 12 Sep 2011 13:16:07 +0000 (15:16 +0200)]
ftp.c: fix socket leak torture tests detected 2011-08-30
Also fix inappropriate error handling when sending ftp EPRT or PORT commands.
Daniel Stenberg [Sun, 11 Sep 2011 13:51:38 +0000 (15:51 +0200)]
TODO: remove 4 entries, add one new
Zero-copy and "Avoid having to remove/readd handles" are not really
features we think are worthwhile to add. Removed.
SRP features have been added already, removed.
11.9 IPv6 addresses with globbing added
Daniel Stenberg [Sun, 11 Sep 2011 13:42:11 +0000 (15:42 +0200)]
spell-checked comments
Daniel Stenberg [Sun, 11 Sep 2011 13:31:01 +0000 (15:31 +0200)]
TODO-RELEASE: postpone the remainders
There's three pending bug fixes but there's no time left so let's
try to get them fixed for next release...
Guenter Knauf [Sun, 11 Sep 2011 14:49:28 +0000 (16:49 +0200)]
Updated makefiles to latest libssh2.
Yang Tse [Sat, 10 Sep 2011 16:46:05 +0000 (18:46 +0200)]
urlglob.c: fix OOM handling
Yang Tse [Sat, 10 Sep 2011 03:05:27 +0000 (05:05 +0200)]
ftp.c: fix ftp active connects which got broken with commit
fdf157abdf
Yang Tse [Fri, 9 Sep 2011 23:23:21 +0000 (01:23 +0200)]
runtests.pl: replace TAB with spaces
Yang Tse [Fri, 9 Sep 2011 23:14:52 +0000 (01:14 +0200)]
test harness: revert needless commit
0a5bbb2ac1
https, ftps and ssh servers allowed start up time back to previous values
Yang Tse [Fri, 9 Sep 2011 22:52:13 +0000 (00:52 +0200)]
ssh.c: revert needless commit
7b7c45879e
Daniel Stenberg [Fri, 9 Sep 2011 13:38:30 +0000 (15:38 +0200)]
RELEASE-NOTES: synced with
303c90074d4c
Five more bugfixes, one more contributor
Daniel Stenberg [Fri, 9 Sep 2011 13:20:31 +0000 (15:20 +0200)]
tcpnodelay: rename variable
Renamed the variable from 'proto' to 'level' simply because it is not
protocol you set but level and that is the name of the argument used in
man pages and the POSIX documentation of the setsockopt function.
Guenter Knauf [Thu, 8 Sep 2011 09:17:16 +0000 (11:17 +0200)]
Avoid ftruncate() static define with MinGW64.
Yang Tse [Thu, 8 Sep 2011 09:08:00 +0000 (11:08 +0200)]
libssh2: use calloc as alloc function for libssh2 versions older than 1.3
This workarounds old libssh2 versions not properly initializing
some ssh session variables, which would trigger memory debuggers
warnings on memory being used without having been initialized.
Adriano Meirelles [Thu, 8 Sep 2011 06:38:59 +0000 (08:38 +0200)]
Curl_speedcheck: don't mistakenly clear Curl_expire()
The current version of speedcheck.c may disable timeout by setting zero
to Curl_expire. Which is fine using the curl_multi_perform, because it
recheck all timeout internals, but when using custom event poller (like
hiperfifo.c) it may keep stalle connection forever.
Yang Tse [Wed, 7 Sep 2011 23:22:47 +0000 (01:22 +0200)]
lib582.c: fix segfault triggered when torture testing test case 582
Daniel Stenberg [Wed, 7 Sep 2011 20:46:06 +0000 (22:46 +0200)]
ftp_state_use_port: minor code indent fix
Daniel Stenberg [Wed, 7 Sep 2011 20:45:43 +0000 (22:45 +0200)]
checksrc: detect "}else" uses as well
Daniel Stenberg [Wed, 7 Sep 2011 20:43:28 +0000 (22:43 +0200)]
getinmemory.c: use better argument names for write callback
Yang Tse [Tue, 6 Sep 2011 23:26:43 +0000 (01:26 +0200)]
ssh.c: fix memory leaks triggered upon OOM or other failures
Yang Tse [Tue, 6 Sep 2011 17:59:42 +0000 (19:59 +0200)]
test case 583: ensure that test failures don't go unnoticed - follow-up
Yang Tse [Tue, 6 Sep 2011 16:11:11 +0000 (18:11 +0200)]
test suite: libtest header inclusion cleanup - follow-up
Adjust tests/libtest/Makefile.inc and remove a couple of unused headers from
tests/libtest/lib583.c
Yang Tse [Tue, 6 Sep 2011 15:56:39 +0000 (17:56 +0200)]
test case 583: ensure that test failures don't go unnoticed
Yang Tse [Tue, 6 Sep 2011 15:47:54 +0000 (17:47 +0200)]
test suite: libtest header inclusion cleanup
Added missing memoryTracking to test cases 560 and 583. If this triggers
leak detection on these, it only means that previously it was going unnoticed.
Yang Tse [Mon, 5 Sep 2011 23:57:21 +0000 (01:57 +0200)]
fix bool variables checking and assignment
Yang Tse [Mon, 5 Sep 2011 21:45:04 +0000 (23:45 +0200)]
pingpong.c: avoid a memmove call in function Curl_pp_vsendf
Yang Tse [Mon, 5 Sep 2011 18:46:09 +0000 (20:46 +0200)]
fix bool variables checking and assignment
Yang Tse [Mon, 5 Sep 2011 10:39:50 +0000 (12:39 +0200)]
test suite: use test case specific netrc file names
Guenter Knauf [Sun, 4 Sep 2011 20:04:45 +0000 (22:04 +0200)]
Fixed final message output.
Daniel Stenberg [Sun, 4 Sep 2011 17:41:34 +0000 (19:41 +0200)]
TODO-RELEASE: deleteing five issues due to no response
No feedback and no updates, removing these issues
Yang Tse [Sun, 4 Sep 2011 15:09:22 +0000 (17:09 +0200)]
setup_once.h cleanup and sync
Guenter Knauf [Sun, 4 Sep 2011 15:05:49 +0000 (17:05 +0200)]
Fix to skip untrusted certs.
Guenter Knauf [Sun, 4 Sep 2011 08:03:08 +0000 (10:03 +0200)]
Added SPNEGO to MinGW makefiles.
Yang Tse [Sat, 3 Sep 2011 23:56:30 +0000 (01:56 +0200)]
NTLM WB: fix file descriptor leak upon OOM condition