reed [Thu, 6 Aug 2015 18:25:15 +0000 (11:25 -0700)]
remove guard for SrcPtr in drawBitmapRect for android
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/
1277963002
mtklein [Thu, 6 Aug 2015 18:18:50 +0000 (11:18 -0700)]
Purge non-NEON ARM code.
As I begin to wade in here, it's nice to remove as much code as possible.
BUG=skia:4117
Review URL: https://codereview.chromium.org/
1277953002
mtklein [Thu, 6 Aug 2015 18:17:06 +0000 (11:17 -0700)]
__ARM_NEON is defined both by ARMv8 and ARMv7 + -mfpu=neon.
Can't hurt to simplify a little.
BUG=skia:4117
Review URL: https://codereview.chromium.org/
1274513003
egdaniel [Thu, 6 Aug 2015 17:54:13 +0000 (10:54 -0700)]
Move some work from backend onClear to base class clear
BUG=skia:
Review URL: https://codereview.chromium.org/
1275543005
senorblanco [Thu, 6 Aug 2015 17:28:55 +0000 (10:28 -0700)]
Implement caching of stroked paths in the tessellating path renderer.
This requires adding the stroke info to the cache key, and doing the
stroking and dashing before rendering as triangles.
BUG=skia:3755
Committed: https://skia.googlesource.com/skia/+/
29e0d3f267a03546f236023347cdb4595ece2fd1
Review URL: https://codereview.chromium.org/
1275553002
reed [Thu, 6 Aug 2015 17:02:53 +0000 (10:02 -0700)]
flag to use const& instead of const* for src-rect
BUG=skia:
Review URL: https://codereview.chromium.org/
1272713005
bsalomon [Thu, 6 Aug 2015 15:52:49 +0000 (08:52 -0700)]
Don't pass pipeline to GrBatch::generateGeometry()
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/
1275083002
joshualitt [Thu, 6 Aug 2015 15:39:22 +0000 (08:39 -0700)]
Another small fix for reordering
BUG=skia:
Review URL: https://codereview.chromium.org/
1274763008
mtklein [Thu, 6 Aug 2015 15:17:16 +0000 (08:17 -0700)]
Port SkTextureCompression opts to SkOpts
Pretty vanilla translation. I cleaned up who calls whom a little.
Used to be utils -> opts -> utils, now it's just utils -> opts.
I may follow up with a pass over the NEON code for readability
and to clean up dead code.
This turns on NEON A8->R11EAC conversion for ARMv8.
Unit tests which now hit the NEON code still pass.
I can't find any related bench.
BUG=skia:4117
Review URL: https://codereview.chromium.org/
1273103002
robertphillips [Thu, 6 Aug 2015 14:08:31 +0000 (07:08 -0700)]
Remove SK_LEGACY_SKPOINT3_CTORS flag
Cannot land before Blink https://codereview.chromium.org/
1274673002/ (Remove reliance on legacy Skia SkPoint3 ctors in FELighting.cpp)
Review URL: https://codereview.chromium.org/
1269383003
fmalita [Thu, 6 Aug 2015 14:04:51 +0000 (07:04 -0700)]
SkSurface copy-on-write can yield stale GPU render targets.
Prepare_rt_for_external_access() grabs the render target and then fires
access notifications.
But the notification handlers may trigger copy-on-write, causing the
returned render target to be stale (pointing at the detached snapshot).
We should grab the render target after firing notifications.
R=reed@google.com,bsalomon@google.com
Review URL: https://codereview.chromium.org/
1276713002
senorblanco [Thu, 6 Aug 2015 13:52:10 +0000 (06:52 -0700)]
Minor cleanup: remove GR_TESSELLATING_PATH_RENDERING #ifdef.
Also, new -> SkNEW.
Review URL: https://codereview.chromium.org/
1280433002
reed [Thu, 6 Aug 2015 13:51:52 +0000 (06:51 -0700)]
use kFast_SrcRectConstraint to match drawAtlas semantics
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1272743003
scroggo [Thu, 6 Aug 2015 13:08:18 +0000 (06:08 -0700)]
Support decoding PNG to 565.
Although we initially discussed not supporting 565, SkCodec needs to
support Android's BitmapFactory and BitmapRegionDecoder, which need to
support 565.
We could instead implement 565 on top of SkCodec, but this would require
more memory and run more slowly.
An open question is whether to support dithering, and how. In order to
support dithering, we need to pass y to RowProc, which I believe means
we will need to pass y to SkSwizzler::swizzle().
I dislike having an option which is typically ignored - SkImageDecoder
allows you to turn on dithering when decoding to any color type, but it
is only meaningful only if the output color type is 565.
We could also make the client implement dithering, which I believe would
mean forcing them to do the conversion to 565 (since we have already
thrown away data when we convered to 565 without dithering).
BUG=skia:3257
Review URL: https://codereview.chromium.org/
1277593002
reed [Thu, 6 Aug 2015 12:14:11 +0000 (05:14 -0700)]
simulate drawatlas
BUG=skia:
Review URL: https://codereview.chromium.org/
1279733002
mtklein [Wed, 5 Aug 2015 23:18:03 +0000 (16:18 -0700)]
Rephrase Windows gyp instructions
The existing instructions seem misleading.
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1275753002
Review URL: https://codereview.chromium.org/
1275753002
joshualitt [Wed, 5 Aug 2015 21:36:31 +0000 (14:36 -0700)]
Fix reording across rendertarget switching
BUG=skia:
Review URL: https://codereview.chromium.org/
1276633003
mtklein [Wed, 5 Aug 2015 21:17:32 +0000 (14:17 -0700)]
Detect MIPS DSP and DSPR2 programattically.
Procedure:
$ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -dM -E - < /dev/null | sort > vanilla.mips
$ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdsp -dM -E - < /dev/null | sort > dsp.mips
$ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdspr2 -dM -E - < /dev/null | sort > dspr2.mips
$ diff vanilla.mips dsp.mips
239a240,241
> #define __mips_dsp 1
> #define __mips_dsp_rev 1
$ diff vanilla.mips dspr2.mips
239a240,242
> #define __mips_dsp 1
> #define __mips_dsp_rev 2
> #define __mips_dspr2 1
So, defined(__mips_dsp) -> SK_MIPS_HAS_DSP, defined(__mips_dspr2) -> SK_MIPS_HAS_DSPR2.
BUG=skia:
Review URL: https://codereview.chromium.org/
1274873002
brucedawson [Wed, 5 Aug 2015 21:05:17 +0000 (14:05 -0700)]
Fix variable shadowing and unreachable code that it caused
Change https://codereview.chromium.org/
1261643004 renamed a function
parameter so that some code became unreachable. This renames that
parameter back.
R=bsalomon@google.com
BUG=skia:4169
Review URL: https://codereview.chromium.org/
1271353003
msarett [Wed, 5 Aug 2015 20:59:40 +0000 (13:59 -0700)]
Fix ASAN error for wbmp swizzles
BUG=skia:
Review URL: https://codereview.chromium.org/
1269413006
bungeman [Wed, 5 Aug 2015 20:57:49 +0000 (13:57 -0700)]
IWYU: 'core' target, files starting A-C.
TBR=reed@google.com
Verbal lgtm, does not change API.
Committed: https://skia.googlesource.com/skia/+/
7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69
Review URL: https://codereview.chromium.org/
1265033002
senorblanco [Wed, 5 Aug 2015 20:37:49 +0000 (13:37 -0700)]
Revert of Implement caching of stroked paths in the tessellated path renderer. (patchset #4 id:60001 of https://codereview.chromium.org/
1275553002/ )
Reason for revert:
Breaking/asserting in Debug on DM.
Original issue's description:
> Implement caching of stroked paths in the tessellated path renderer.
>
> This requires adding the stroke info to the cache key, and doing the
> stroking and dashing before rendering as triangles.
>
> BUG=skia:3755
>
> Committed: https://skia.googlesource.com/skia/+/
29e0d3f267a03546f236023347cdb4595ece2fd1
TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3755
Review URL: https://codereview.chromium.org/
1276633002
senorblanco [Wed, 5 Aug 2015 20:18:03 +0000 (13:18 -0700)]
Implement caching of stroked paths in the tessellated path renderer.
This requires adding the stroke info to the cache key, and doing the
stroking and dashing before rendering as triangles.
BUG=skia:3755
Review URL: https://codereview.chromium.org/
1275553002
mtklein [Wed, 5 Aug 2015 20:08:12 +0000 (13:08 -0700)]
Update NOPRESUBMIT docs.
"NOPRESUBMIT=true" does not work anymore for me.
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1271423002
Review URL: https://codereview.chromium.org/
1271423002
msarett [Wed, 5 Aug 2015 19:58:26 +0000 (12:58 -0700)]
Scanline decoding for wbmp
We are also changing the wbmp to use SkSwizzler. This
will allow us to take advantage of the sampling routines
that are being implemented in SkSwizzler.
The image in this upload came from:
https://commons.wikimedia.org/wiki/File:Android_robot.png
It is licensed under the Creative Commons Attribution-Share Alike 3.0 Unported license.
BUG=skia:
Review URL: https://codereview.chromium.org/
1254483004
oysteine [Wed, 5 Aug 2015 19:54:40 +0000 (12:54 -0700)]
Moved common cross-project functionality out from SkTraceEvent.h into SkTraceEventCommon.h
Traditionally, SkTraceEvent.h was manually kept in sync with base/trace_event/trace_event.h, with project-specific parts intermixed, and tended to drift out of sync a lot (mainly in Blink, less so in Skia).
The SkTraceEventCommon.h now has only the cross-project parts, and can be copy-pasted verbatim between projects (it's an identical copy of base/trace_event/trace_event_common.h), meaning SkTraceEvent.h shouldn't go out of sync as it has before.
BUG=skia:
[mtklein mucking around below here]
NOPRESUBMIT=true
CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot
Review URL: https://codereview.chromium.org/
1270783002
bungeman [Wed, 5 Aug 2015 19:09:57 +0000 (12:09 -0700)]
Add skstd::move and skstd::forward.
Since we can't use the c++11 standard library, re-implement the bits
we want to use now.
TBR=reed@google.com
The next CL is try to move SkTemplates into private.
Review URL: https://codereview.chromium.org/
1273813002
joshualitt [Wed, 5 Aug 2015 19:02:27 +0000 (12:02 -0700)]
Expose coord transforms from GrPipeline
BUG=skia:
Review URL: https://codereview.chromium.org/
1275603002
joshualitt [Wed, 5 Aug 2015 18:05:22 +0000 (11:05 -0700)]
This CL wires up the backend portion necessary for sending transformed coords via vertex attributes.
BUG=skia:
Review URL: https://codereview.chromium.org/
1243583002
bsalomon [Wed, 5 Aug 2015 17:50:01 +0000 (10:50 -0700)]
Move impl of stroke rect batch from h to cpp
Review URL: https://codereview.chromium.org/
1275633003
bsalomon [Wed, 5 Aug 2015 17:34:05 +0000 (10:34 -0700)]
Give strokerectbatch a proper home
Review URL: https://codereview.chromium.org/
1274763002
joshualitt [Wed, 5 Aug 2015 16:30:02 +0000 (09:30 -0700)]
fix for GrFragmentProcessor isEqual in GrPipeline
BUG=skia:
Review URL: https://codereview.chromium.org/
1273693003
robertphillips [Wed, 5 Aug 2015 16:07:12 +0000 (09:07 -0700)]
Remove SHADER_AA_FILL_RECT flag
Review URL: https://codereview.chromium.org/
1271243004
mtklein [Wed, 5 Aug 2015 15:58:45 +0000 (08:58 -0700)]
Update yasm .gyp for tweaked ASAN bots.
They're not passing -fsanitize=address anymore, rather
-fsanitize=address,bool,etc,etc,etc...
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1269383002
mtklein [Wed, 5 Aug 2015 15:40:19 +0000 (08:40 -0700)]
Revert of Intentionally crash DM to make sure all bots are up-to-date. (patchset #1 id:1 of https://codereview.chromium.org/
1274693002/ )
Reason for revert:
win x64 looks fixed
Original issue's description:
> Intentionally crash DM to make sure all bots are up-to-date.
>
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
3749b9646103f544f17aa926fab050f1e5178b17
TBR=borenet@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1275543003
Eric Boren [Wed, 5 Aug 2015 15:30:28 +0000 (11:30 -0400)]
Fix make.py: BUILDTYPE
TBR=mtklein
BUG=skia:
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1273793003 .
Mike Klein [Wed, 5 Aug 2015 15:13:59 +0000 (11:13 -0400)]
Intentionally crash DM to make sure all bots are up-to-date.
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1274693002 .
Mike Klein [Wed, 5 Aug 2015 14:12:33 +0000 (10:12 -0400)]
Add tools/ubsan.supp.
Should unbreak TSAN bots.
BUG=skia:
Review URL: https://codereview.chromium.org/
1272213003 .
bsalomon [Wed, 5 Aug 2015 13:58:39 +0000 (06:58 -0700)]
init atomic bool in SkImage_Gpu
BUG=chromium:516860
TBR=reed@google.com
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1269243004
joshualitt [Wed, 5 Aug 2015 13:46:09 +0000 (06:46 -0700)]
Revert of Break LCD and Bitmap text dependency on hardcoded atlas values (patchset #2 id:20001 of https://codereview.chromium.org/
1271873002/ )
Reason for revert:
Breaks S3
Original issue's description:
> Break LCD and Bitmap text dependency on hardcoded atlas values
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
846b022f6b469cfde285372f26e0d5c593d122ac
TBR=jvanverth@google.com,bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1271163003
joshualitt [Wed, 5 Aug 2015 13:36:39 +0000 (06:36 -0700)]
Move atlas creation to internal to GrResourceProvider
BUG=skia:
Review URL: https://codereview.chromium.org/
1260183006
reed [Wed, 5 Aug 2015 01:46:38 +0000 (18:46 -0700)]
- allow for stepping through a picture with 'n' and 'p'
- save current slide as .skp with 'K'
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1272063002
reed [Wed, 5 Aug 2015 01:44:56 +0000 (18:44 -0700)]
Revert of IWYU: 'core' target, files starting A-C. (patchset #5 id:80001 of https://codereview.chromium.org/
1265033002/ )
Reason for revert:
revert to unblock DEPS roll
../../chrome/browser/chromeos/display/overscan_calibrator.cc:43:10: error: variable has incomplete type 'SkPath'
SkPath base_path;
Original issue's description:
> IWYU: 'core' target, files starting A-C.
>
> TBR=reed@google.com
> Verbal lgtm, does not change API.
>
> Committed: https://skia.googlesource.com/skia/+/
7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69
TBR=reed@google.com,mtklein@google.com,bungeman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1273613002
bungeman [Tue, 4 Aug 2015 21:56:53 +0000 (14:56 -0700)]
IWYU: 'core' target, files starting A-C.
TBR=reed@google.com
Verbal lgtm, does not change API.
Review URL: https://codereview.chromium.org/
1265033002
borenet [Tue, 4 Aug 2015 21:23:48 +0000 (14:23 -0700)]
Whitespace change to test Gerrit ACLs
BUG=skia:
TBR=mtklein
Review URL: https://codereview.chromium.org/
1255313004
mtklein [Tue, 4 Aug 2015 21:09:09 +0000 (14:09 -0700)]
Port morphology to SkOpts.
Nothing too fancy.
Direction enums become enum classes so they don't get all confused. An
alternative is to create one single Direction enum that both blur and
morphology opts use.
BUG=skia:4117
Review URL: https://codereview.chromium.org/
1267343004
halcanary [Tue, 4 Aug 2015 21:08:42 +0000 (14:08 -0700)]
Remove experimental/PdfViewer
Motivation: maintaining this code doesn't seem worth the time,
since no one seems to be using it. If someone wants to use it
in the future, just revert this CL.
Review URL: https://codereview.chromium.org/
1266093003
fmalita [Tue, 4 Aug 2015 20:53:14 +0000 (13:53 -0700)]
SkPictureImageGenerator
R=reed@google.com
Review URL: https://codereview.chromium.org/
1240093004
Mike Klein [Tue, 4 Aug 2015 20:48:43 +0000 (16:48 -0400)]
Reorganize to keep similar code together.
This organizes memset16, memset32, and rsqrt the same way as the other code. No functional change.
BUG=skia:4117
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
1264423002 .
Eric Boren [Tue, 4 Aug 2015 20:38:38 +0000 (16:38 -0400)]
whitespace change to test whether I can commit
BUG=skia:
Review URL: https://codereview.chromium.org/
1268663005 .
Mike Klein [Tue, 4 Aug 2015 19:49:09 +0000 (15:49 -0400)]
Remove dead code.
BUG=skia:4117
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
1262213005 .
senorblanco [Tue, 4 Aug 2015 17:01:58 +0000 (10:01 -0700)]
Implement caching of filled paths in the tessellated path renderer.
Paths are cached as tessellated triangle meshes in vertex buffers on the GPU. Stroked paths are not (yet) cached.
Paths containing no curved segments (linear paths) are reused at all scales. Paths containing curved segments are reused within a scale tolerance threshold.
In order to invalidate the cache when an SkPath is changed or deleted,
this required implementing genID change notification in SkPath. This is
modelled almost exactly on SkPixelRef::GenIDChangeListener.
However, It does not currently implement the check for unique genIDs,
so notifiers will fire when the first instance of an SkPathRef
using a given genID is destroyed.
Another caveat is that you cannot successfully add a change notifier
to an empty path, since it uses the "canonical" empty path which is
never modified or destroyed. For this reason, we prevent adding
listeners to it.
BUG=skia:4121,skia:4122, 497403
DOCS_PREVIEW= https://skia.org/?cl=
1114353004
Committed: https://skia.googlesource.com/skia/+/
468dfa72eb6694145487be17876804dfca3b7adb
Review URL: https://codereview.chromium.org/
1114353004
joshualitt [Tue, 4 Aug 2015 16:40:02 +0000 (09:40 -0700)]
Break LCD and Bitmap text dependency on hardcoded atlas values
BUG=skia:
Review URL: https://codereview.chromium.org/
1271873002
scroggo [Tue, 4 Aug 2015 16:24:45 +0000 (09:24 -0700)]
Create a scanline decoder without creating a codec
Prior to this CL, if a client wanted to decode scanlines, they had to
create an SkCodec in order to get an SkScanlineDecoder. This introduces
complications if input data is not easily shared between the two
objects.
Instead, add methods to SkScanlineDecoder for creating a new one from
input data, and remove the creation functions from SkCodec.
Update DM and tests.
Review URL: https://codereview.chromium.org/
1267583002
joshualitt [Tue, 4 Aug 2015 16:24:30 +0000 (09:24 -0700)]
Add cheat sheet to wrangler doc
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1264313003
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
1264313003
mtklein [Tue, 4 Aug 2015 15:49:21 +0000 (08:49 -0700)]
Port SkBlurImage opts to SkOpts.
+268 -535 lines
I also rearranged the code a little bit to encapsulate itself better,
mostly replacing static helper functions with lambdas. This also
let me merge the SSE2 and SSE4.1 code paths.
BUG=skia:4117
Review URL: https://codereview.chromium.org/
1264103004
mtklein [Tue, 4 Aug 2015 15:46:16 +0000 (08:46 -0700)]
Revert "Implement caching of filled paths in the tessellated path renderer."
This reverts commit
468dfa72eb6694145487be17876804dfca3b7adb.
This CL caused signficant GM diffs.
Revert "Fix resource cache test."
This reverts commit
b001c41ed37d2018d38ce787b412ed741585d75d.
Revert "Fix SkData leaks at GrResourceKey::setCustomData() call sites."
This reverts commit
c369348aa596d7be05c9ce0ca5d349e5d1903789.
These CLs depend on the first one.
BUG=skia:
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
1260363007
reed [Tue, 4 Aug 2015 15:42:40 +0000 (08:42 -0700)]
update image bench to test gpu and cpu images against raster surface
BUG=513695
TBR=
Review URL: https://codereview.chromium.org/
1261043003
reed [Tue, 4 Aug 2015 15:10:13 +0000 (08:10 -0700)]
cache private readback for gpu-images
Does not try to cache calls to readPixels at the moment:
- not triggered by drawing
- not clear if we want to perform any pixel transformations (that readPixels allows) on the GPU or CPU
Can consider that another time.
BUG=513695
Review URL: https://codereview.chromium.org/
1262923003
robertphillips [Tue, 4 Aug 2015 15:04:29 +0000 (08:04 -0700)]
Remove IGNORE_ROT_AA_RECT_OPT flag
It looks like the positive version was added (SHADER_AA_FILL_RECT) but the negative version wasn't removed.
Review URL: https://codereview.chromium.org/
1271903003
wangyix [Tue, 4 Aug 2015 14:59:37 +0000 (07:59 -0700)]
Added registerChild; transforms, textures, glKey automatically handled.
BUG=skia:
Review URL: https://codereview.chromium.org/
1266633003
Stephen White [Tue, 4 Aug 2015 01:53:09 +0000 (21:53 -0400)]
Fix SkData leaks at GrResourceKey::setCustomData() call sites.
BUG=skia:
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
1270103003 .
mtklein [Tue, 4 Aug 2015 01:08:29 +0000 (18:08 -0700)]
Revert of SkCanvas::onDrawPicture() quick-reject (patchset #3 id:40001 of https://codereview.chromium.org/
1264133003/ )
Reason for revert:
webkit_unit_tests :(
Original issue's description:
> SkCanvas::onDrawPicture() quick-reject
>
> R=reed@google.com,mtklein@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
48ed62b29d45e42b971aac8858da06781c93e6d7
TBR=reed@google.com,fmalita@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1273433002
fmalita [Mon, 3 Aug 2015 22:30:35 +0000 (15:30 -0700)]
SkCanvas::onDrawPicture() quick-reject
R=reed@google.com,mtklein@google.com
Review URL: https://codereview.chromium.org/
1264133003
reed [Mon, 3 Aug 2015 21:44:32 +0000 (14:44 -0700)]
remove flags that control no code
BUG=skia:
Review URL: https://codereview.chromium.org/
1259653004
bsalomon [Mon, 3 Aug 2015 21:23:03 +0000 (14:23 -0700)]
Fix elliptical rrect clip shaders for large radii on devices with mediump
BUG=chromium:426217
Review URL: https://codereview.chromium.org/
1256353004
reed [Mon, 3 Aug 2015 21:18:04 +0000 (14:18 -0700)]
add bench for gpu-image -> cpu-surface
BUG=513695
TBR=
Review URL: https://codereview.chromium.org/
1261663004
Stephen White [Mon, 3 Aug 2015 20:30:23 +0000 (16:30 -0400)]
Fix resource cache test.
TBR=bsalomon@chromium.org
Review URL: https://codereview.chromium.org/
1257253007 .
senorblanco [Mon, 3 Aug 2015 20:04:03 +0000 (13:04 -0700)]
Implement caching of filled paths in the tessellated path renderer.
Paths are cached as tessellated triangle meshes in vertex buffers on the GPU. Stroked paths are not (yet) cached.
Paths containing no curved segments (linear paths) are reused at all scales. Paths containing curved segments are reused within a scale tolerance threshold.
In order to invalidate the cache when an SkPath is changed or deleted,
this required implementing genID change notification in SkPath. This is
modelled almost exactly on SkPixelRef::GenIDChangeListener.
However, It does not currently implement the check for unique genIDs,
so notifiers will fire when the first instance of an SkPathRef
using a given genID is destroyed.
Another caveat is that you cannot successfully add a change notifier
to an empty path, since it uses the "canonical" empty path which is
never modified or destroyed. For this reason, we prevent adding
listeners to it.
BUG=skia:4121,skia:4122, 497403
DOCS_PREVIEW= https://skia.org/?cl=
1114353004
Review URL: https://codereview.chromium.org/
1114353004
reed [Mon, 3 Aug 2015 18:45:34 +0000 (11:45 -0700)]
remove getdevice guard for android
BUG=skia:
NOTRY=True
Review URL: https://codereview.chromium.org/
1266363002
joshualitt [Mon, 3 Aug 2015 18:35:28 +0000 (11:35 -0700)]
Use new API everywhere for GrDefaultGeoProcFactory
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
801823b3d825d96baadeb9077c5ed1a8ada05cf2
Review URL: https://codereview.chromium.org/
1261083003
mtklein [Mon, 3 Aug 2015 17:20:28 +0000 (10:20 -0700)]
Missing overrides for Sinks in HWUI.
See crrev.com/
1263113002
BUG=skia:4138
Review URL: https://codereview.chromium.org/
1263143004
joshualitt [Mon, 3 Aug 2015 17:17:44 +0000 (10:17 -0700)]
Add abliity to set textblob cache budget to GrContext
BUG=skia:
Review URL: https://codereview.chromium.org/
1264283002
bsalomon [Mon, 3 Aug 2015 17:15:25 +0000 (10:15 -0700)]
Update assert to allow config conversion effect for all configs when not premul/unpremuling
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
1258763006
joshualitt [Mon, 3 Aug 2015 16:32:36 +0000 (09:32 -0700)]
Revert of Use new API everywhere for GrDefaultGeoProcFactory (patchset #5 id:80001 of https://codereview.chromium.org/
1261083003/)
Reason for revert:
breaking things
Original issue's description:
> Use new API everywhere for GrDefaultGeoProcFactory
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
801823b3d825d96baadeb9077c5ed1a8ada05cf2
TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1264283004
joshualitt [Mon, 3 Aug 2015 16:03:33 +0000 (09:03 -0700)]
Use new API everywhere for GrDefaultGeoProcFactory
BUG=skia:
Review URL: https://codereview.chromium.org/
1261083003
Derek Sollenberger [Mon, 3 Aug 2015 15:41:53 +0000 (11:41 -0400)]
add missing comma
Review URL: https://codereview.chromium.org/
1268483003 .
bungeman [Mon, 3 Aug 2015 14:56:16 +0000 (07:56 -0700)]
Update NulCanvas so everything builds.
SkNulCanvas.h is out of date, so the 'all' target fails.
Review URL: https://codereview.chromium.org/
1270633004
halcanary [Mon, 3 Aug 2015 13:55:20 +0000 (06:55 -0700)]
Documentation: SkPathEffect
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/api/skpaint?cl=
1269563008
Review URL: https://codereview.chromium.org/
1269563008
djsollen [Mon, 3 Aug 2015 13:03:06 +0000 (06:03 -0700)]
fix tests for android framework build
Review URL: https://codereview.chromium.org/
1263243003
joshualitt [Sat, 1 Aug 2015 17:33:40 +0000 (10:33 -0700)]
Add BW masks to random scaler context
TBR=bsalomon@google.com
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
a4a530614e9ba856aac3f16c29683e6a2a9153d9
Review URL: https://codereview.chromium.org/
1270793003
joshualitt [Sat, 1 Aug 2015 17:17:53 +0000 (10:17 -0700)]
Revert of Add BW masks to random scaler context (patchset #1 id:1 of https://codereview.chromium.org/
1270793003/)
Reason for revert:
breaks mac
Original issue's description:
> Add BW masks to random scaler context
>
> TBR=bsalomon@google.com
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
a4a530614e9ba856aac3f16c29683e6a2a9153d9
TBR=joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1264843003
joshualitt [Sat, 1 Aug 2015 16:36:02 +0000 (09:36 -0700)]
Add BW masks to random scaler context
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1270793003
joshualitt [Sat, 1 Aug 2015 14:33:41 +0000 (07:33 -0700)]
adding gm to use random scaler context
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
853336c532504b3436d7dcbf252419f00c79066d
Review URL: https://codereview.chromium.org/
1268853008
reed [Sat, 1 Aug 2015 14:03:20 +0000 (07:03 -0700)]
remove now-dead flags
BUG=skia:
Review URL: https://codereview.chromium.org/
1258963005
bungeman [Fri, 31 Jul 2015 22:46:03 +0000 (15:46 -0700)]
Fix no-gpu debugger.
Review URL: https://codereview.chromium.org/
1262723005
joshualitt [Fri, 31 Jul 2015 22:18:08 +0000 (15:18 -0700)]
Move strike to subrun in GrAtlasTextContext
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
77d89f7dd243a17452d3a5f16a98622993e6bdd9
Review URL: https://codereview.chromium.org/
1257253005
halcanary [Fri, 31 Jul 2015 22:16:23 +0000 (15:16 -0700)]
C API: remove dead code, simplify boilerplate
Review URL: https://codereview.chromium.org/
1261953006
joshualitt [Fri, 31 Jul 2015 22:10:31 +0000 (15:10 -0700)]
Revert of adding gm to use random scaler context (patchset #4 id:60001 of https://codereview.chromium.org/
1268853008/)
Reason for revert:
breaking bots
Original issue's description:
> adding gm to use random scaler context
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
853336c532504b3436d7dcbf252419f00c79066d
TBR=bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1259033004
mtklein [Fri, 31 Jul 2015 21:47:25 +0000 (14:47 -0700)]
disable SkOpts on x86 iOS (simulator)
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
1266443006
joshualitt [Fri, 31 Jul 2015 21:46:46 +0000 (14:46 -0700)]
adding gm to use random scaler context
BUG=skia:
Review URL: https://codereview.chromium.org/
1268853008
scroggo [Fri, 31 Jul 2015 21:29:26 +0000 (14:29 -0700)]
Fix straggling SK_VIRTUAL_CONSTRAINT_TYPEs
These were removed with crrev.com/
1239193002, but a few were missed
in files that are only build on Android framework.
Brings the Android build one step closer to building.
Review URL: https://codereview.chromium.org/
1268603003
joshualitt [Fri, 31 Jul 2015 21:07:50 +0000 (14:07 -0700)]
Revert of Move strike to subrun in GrAtlasTextContext (patchset #3 id:40001 of https://codereview.chromium.org/
1257253005/)
Reason for revert:
breaking bots
Original issue's description:
> Move strike to subrun in GrAtlasTextContext
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
77d89f7dd243a17452d3a5f16a98622993e6bdd9
TBR=bsalomon@google.com,robertphillips@google.com,jvanverth@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1266253002
mtklein [Fri, 31 Jul 2015 21:02:36 +0000 (14:02 -0700)]
Move SkOpts.h back to src/core.
The Chrome opts targets (sse2, ssse3, sse41, etc) don't have include/private on
their include path. This should unblock the roll.
TBR=reed@google.com
BUG=skia:4117
Review URL: https://codereview.chromium.org/
1268853007
bsalomon [Fri, 31 Jul 2015 20:59:30 +0000 (13:59 -0700)]
Some cleanup in GrTextureProvider and GrResourceProvider.
Review URL: https://codereview.chromium.org/
1261643004
joshualitt [Fri, 31 Jul 2015 20:58:27 +0000 (13:58 -0700)]
Move strike to subrun in GrAtlasTextContext
BUG=skia:
Review URL: https://codereview.chromium.org/
1257253005
halcanary [Fri, 31 Jul 2015 20:38:06 +0000 (13:38 -0700)]
C API: add sk_xfermode.h, impl, test
Review URL: https://codereview.chromium.org/
1242403005
bsalomon [Fri, 31 Jul 2015 19:15:50 +0000 (12:15 -0700)]
Speculative fix for http://crbug.com/515966
BUG=chromium:515966
Review URL: https://codereview.chromium.org/
1268723005
halcanary [Fri, 31 Jul 2015 19:02:18 +0000 (12:02 -0700)]
Documentation spelling error
BUG=skia:4157
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/
1267843002
halcanary [Fri, 31 Jul 2015 18:58:13 +0000 (11:58 -0700)]
Documentation: SkXfermode::Mode
BUG=skia:4157
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/api/skpaint?cl=
1270643004
Review URL: https://codereview.chromium.org/
1270643004