JunsuChoi [Thu, 27 Sep 2018 09:22:22 +0000 (11:22 +0200)]
ecore_con: Add docs for ecore_con legacy functions
Summary:
Find docs of missing legacy functions
from 9c33623(ecore: add ecore_con_url_ssl_ca_set.),
40edc9c(ecore: add ecore_con_url_ssl_verify_peer_set patch by Raoul Hecky.)
and add them.
Test Plan: make doc
Reviewers: cedric, Hermet, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7117
JunsuChoi [Thu, 27 Sep 2018 09:12:46 +0000 (11:12 +0200)]
ecore_timer: Add docs for ecore_timer legacy functions
Summary:
Find docs of missing legacy functions
from 47cdbe3 and add them.
Test Plan: make doc
Reviewers: cedric, Hermet, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7118
Jaehyun Cho [Fri, 21 Sep 2018 12:30:50 +0000 (12:30 +0000)]
efl_vg: calculate center point with double type
Although the center point is double type, the calculation is integer type.
To calculate center point correctly, calculate with double type.
Differential Revision: https://phab.enlightenment.org/D7097
Alastair Poole [Mon, 24 Sep 2018 10:26:23 +0000 (10:26 +0000)]
efreet_menu: remove unused and unreachable code.
Coverity doesn't like this unreachable code. This purges
efreet_menu of all unused code for the deprecated and
non-working menu_async methods. The warnings remain
at compile time and run time.
Differential Revision: https://phab.enlightenment.org/D7101
Yeongjong Lee [Thu, 27 Sep 2018 07:33:37 +0000 (07:33 +0000)]
efl_ui_stack: Partially Revert "efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value"
This partially reverts commit
820dcb9cd975e93271977246aaf1b1a707435851.
top_cd can be NULL when cd->stack is NULL.
Thanks to bu5hm4n for reporting.
Differential Revision: https://phab.enlightenment.org/D7116
Yeongjong Lee [Thu, 27 Sep 2018 05:10:31 +0000 (14:10 +0900)]
eina_value: return null when eina_value_pget failed
Summary:
Add return value check.
found by coverity.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7107
Yeongjong Lee [Thu, 27 Sep 2018 05:08:39 +0000 (14:08 +0900)]
elm_genlist: prevent null pointer access
Summary: found by coverity
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7108
Yeongjong Lee [Thu, 27 Sep 2018 04:58:08 +0000 (13:58 +0900)]
efl_exe: check fcntl return
Summary: Found by coverity
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7110
Yeongjong Lee [Thu, 27 Sep 2018 04:57:33 +0000 (13:57 +0900)]
efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value
Summary:
Becase EINA_INLIST_CONTAINER_GET always return true, it doesn't need to check
whether return value is null.
Reviewers: Jaehyun_Cho, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7112
Yeongjong Lee [Thu, 27 Sep 2018 04:55:20 +0000 (13:55 +0900)]
efl_ui_list: fix wrong variable usage
Reviewers: SanghyeonLee, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7113
Lauro Moura [Wed, 26 Sep 2018 15:01:49 +0000 (12:01 -0300)]
efl-csharp: Fix event struct marshalling.
Summary:
The efl.Event struct has a class field that gets generated normally but
can be problematic when marshalling the struct back from C to C#. The
compilation works fine but when C# runtime tries to marshall the C data
(e.g. accessing the Event.Info field), it becomes erratic, either
complaining about missing references to object or even segfault.
This commit changes the event handling code to use the
"Event_StructInternal" struct as is already done when receiving structs
from C code.
In order to work with other assemblies, the _StructInternal fields were
made publit too.
Fixes the events tests and the text editor app.
Test Plan: make check and run the text editor app in examples repo.
Reviewers: segfaultxavi, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7106
Xavi Artigas [Wed, 26 Sep 2018 07:21:26 +0000 (09:21 +0200)]
docs: Fix Efl.Ui.Focus.Object.Focus() docs
Summary:
The same description was used for both the Setter and the Getter, which makes
no sense.
Reviewers: zmike, bu5hm4n, bryceharrington, devilhorns
Reviewed By: bu5hm4n, devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7071
Youngbok Shin [Mon, 24 Sep 2018 10:17:26 +0000 (11:17 +0100)]
elementary_test: use snprintf to prevent memory overflow in test_efl_ui_text
Summary: To prevent memory overflow, use snprintf instead of sprintf.
Test Plan: N/A
Reviewers: raster, cedric, zmike, Hermet, netstar
Reviewed By: netstar
Subscribers: netstar, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7095
Bryce Harrington [Fri, 21 Sep 2018 18:34:28 +0000 (14:34 -0400)]
eina: Improve doxygen formatting for eina_debug.h
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7098
Carsten Haitzler (Rasterman) [Fri, 21 Sep 2018 12:39:45 +0000 (13:39 +0100)]
examples - fix avahi examples to compile
add links to avahi system client libs.
JunsuChoi [Fri, 21 Sep 2018 11:05:44 +0000 (20:05 +0900)]
Colorselector : Add docs of elm_colorselector_palette_item_* APIs
Summary:
Add documentation for these APIs
elm_colorselector_palette_item_color_get
elm_colorselector_palette_item_color_set
elm_colorselector_palette_item_selected_get
elm_colorselector_palette_item_selected_set
Test Plan: make doc
Reviewers: cedric, Hermet, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7091
JunsuChoi [Fri, 21 Sep 2018 11:03:18 +0000 (20:03 +0900)]
Docs: Fix incorrectly information for elm_config_softcursor_mode_set
Summary: N/A
Test Plan: make doc
Reviewers: cedric, Hermet, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7094
JunsuChoi [Fri, 21 Sep 2018 11:02:33 +0000 (20:02 +0900)]
Docs: Add a group of APIs for which group is not declared in elm_config
Summary:
Longpress
elm_config_longpress_timeout_get
elm_config_longpress_timeout_set
SotfCursor
elm_config_softcursor_mode_set
elm_config_softcursor_mode_get
Tooltips (Add in Elm_Tooltips)
elm_config_tooltip_delay_get
elm_config_tooltip_delay_set
Test Plan: make doc
Reviewers: cedric, Hermet, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7093
Hermet Park [Fri, 21 Sep 2018 08:59:30 +0000 (17:59 +0900)]
edje: add missing eina_deprecated to apis.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7090
Hermet Park [Fri, 21 Sep 2018 08:55:14 +0000 (17:55 +0900)]
Edje: update doc.
Summary: fix and add missing doxygen conent.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7088
Taehyub Kim [Fri, 21 Sep 2018 09:04:49 +0000 (18:04 +0900)]
elm_entry: update documentation for elm_entnry_textonly_mode_set/get
Summary: update documentation
Reviewers: Jaehyun_Cho, raster
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7089
Bowon Ryu [Fri, 21 Sep 2018 08:25:56 +0000 (17:25 +0900)]
docs: correct group name of segmentcontrol for API docs.
Summary:
correct group name of segmentcontrol for API docs consistency.
Elm_SegmentControl -> Elm_Segment_Control
Test Plan: N/A
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7087
Hermet Park [Fri, 21 Sep 2018 07:56:05 +0000 (16:56 +0900)]
edje example: fix svg data.
Summary:
these svg data format didn't have the standard.
Specify 0 ~ 100 in % unit i.e. 50%
Otherwise, 0 ~ 1 in normalized value. i.e. 0.5
Reviewers: #committers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7054
Bryce Harrington [Fri, 21 Sep 2018 07:55:36 +0000 (16:55 +0900)]
eina: Grammar improvements
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7058
Youngbok Shin [Fri, 21 Sep 2018 07:50:30 +0000 (16:50 +0900)]
elementary: fix memory leak from Efl.Ui.Layout.Object
Summary:
The 'data' could not be added to hash in a condition.
It has to be free'd before ending the function.
@fix
Test Plan: N/A
Reviewers: cedric, raster, Hermet, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7083
Youngbok Shin [Fri, 21 Sep 2018 07:32:07 +0000 (16:32 +0900)]
evas cache: add more null check for cache
Summary:
The 'cache' pointer is checked against null but then
dereferenced anyway. It needs to add null checking conditions.
Test Plan: N/A
Reviewers: raster, cedric, Hermet, zmike
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7084
Marcel Hollerbach [Wed, 12 Sep 2018 19:16:39 +0000 (21:16 +0200)]
evas_object_callbacks: do not error on NULL on del
it does not really matter if a obj is NULL or not when deleting a callback.
The result might be NULL anyways when the callback is not found.
Additionally, this is very verbose, and leads to the fact that most of
the time normal calls to evas_object_event_callback_del* should be if
(!obj) evas_object_event_callback_del* which is annoying and wastefull.
Differential Revision: https://phab.enlightenment.org/D7028
Youngbok Shin [Fri, 21 Sep 2018 07:23:36 +0000 (07:23 +0000)]
elementary: remove meaningless memory allocation and leaking
'evt_data' was allocated. Actually, it was not used in anywhere in its function.
@fix
Differential Revision: https://phab.enlightenment.org/D7086
Taehyub Kim [Fri, 21 Sep 2018 06:05:58 +0000 (15:05 +0900)]
eina_vpath: fix the memory leak
Summary:
fix the memory leak
@fix
Reviewers: Jaehyun_Cho, bu5hm4n
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7081
Taehyub Kim [Fri, 21 Sep 2018 05:46:50 +0000 (14:46 +0900)]
ecore_main: fix the invalid return value
Summary:
fix the invalid return value
@fix
Reviewers: Jaehyun_Cho, raster, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7080
Bryce Harrington [Tue, 18 Sep 2018 23:41:52 +0000 (08:41 +0900)]
eina: Improve explanation of read-only binbuf's
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7057
Bryce Harrington [Tue, 18 Sep 2018 23:38:32 +0000 (08:38 +0900)]
eina: Refer to sin/cos as sine/cosine instead of sinus/cosinus
Summary:
Sinus and cosinus are just the Latin words for sine and cosine, but we
should use the English versions to avoid any possible confusion.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7059
Bryce Harrington [Tue, 18 Sep 2018 23:37:39 +0000 (08:37 +0900)]
eina promise: Fix example error message in docs
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7060
Bryce Harrington [Tue, 18 Sep 2018 23:35:02 +0000 (08:35 +0900)]
eina cow: Cleanup doxygen syntax
Summary:
The "be careful" advice seems a bit odd in api docs, better to just flag
them with doxygen @note's.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7061
Derek Foreman [Tue, 18 Sep 2018 14:43:22 +0000 (09:43 -0500)]
emotion: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7051
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7052
Derek Foreman [Tue, 18 Sep 2018 14:43:17 +0000 (09:43 -0500)]
efl_canvas_animation_player: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7050
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7051
Derek Foreman [Tue, 18 Sep 2018 14:43:14 +0000 (09:43 -0500)]
emotion: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7049
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7050
Derek Foreman [Tue, 18 Sep 2018 14:43:09 +0000 (09:43 -0500)]
elu_ews_wm: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7048
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7049
Derek Foreman [Tue, 18 Sep 2018 14:43:05 +0000 (09:43 -0500)]
elm_transit: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7047
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7048
Derek Foreman [Tue, 18 Sep 2018 14:43:02 +0000 (09:43 -0500)]
elm_genlist: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7046
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7047
Derek Foreman [Tue, 18 Sep 2018 14:42:58 +0000 (09:42 -0500)]
elm_gengrid: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7045
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7046
Derek Foreman [Tue, 18 Sep 2018 14:42:54 +0000 (09:42 -0500)]
elm_box: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7044
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7045
Derek Foreman [Tue, 18 Sep 2018 14:42:50 +0000 (09:42 -0500)]
elm_actionslider: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7043
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7044
Derek Foreman [Tue, 18 Sep 2018 14:42:46 +0000 (09:42 -0500)]
efl_ui_flip: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7042
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7043
Derek Foreman [Tue, 18 Sep 2018 14:42:42 +0000 (09:42 -0500)]
selection_manager: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7041
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7042
Derek Foreman [Tue, 18 Sep 2018 14:42:38 +0000 (09:42 -0500)]
ecore: Add new way to register animators
Summary:
We have back-ends that can generate their own tick sources, but
ecore_animator_add()/ecore_animator_timeline_add() gives no indication
which backend the animator is running on. This means that all animators
have to cause all currently in use backends to tick.
For example, if under wayland 4 application windows are open, all 4
windows will create ticks when any animator is present.
These new animator APIs that take an evas object allow us to figure out
out the backend and only cause the appropriate one to tick.
Depends on D7040
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7041
Derek Foreman [Tue, 18 Sep 2018 14:42:34 +0000 (09:42 -0500)]
ecore_anim: Move struct Ecore_Animator to private header
Summary:
We're going to use this in ecore_evas shortly.
Depends on D7039
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7040
Derek Foreman [Tue, 18 Sep 2018 14:42:29 +0000 (09:42 -0500)]
ecore_evas: Refactor out ticking start/stop as functions
Summary:
These are the refcounted ticky guts of the signal add/del catchers, we'll
need to use these to start/stop from other call chains in the near
future.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7039
Woochanlee [Thu, 27 Sep 2018 10:35:55 +0000 (19:35 +0900)]
efl_ui_clock: Support legacy part name for tizen_only code.
Change-Id: I2ea63abf10edc693ee9b0eb683b9ac5e6381bb38
Hermet Park [Thu, 27 Sep 2018 09:35:19 +0000 (18:35 +0900)]
evas/vg: add legacy api - evas_object_vg_mmap_set()
Change-Id: Iaacf5db82da7332e3717cb9eaf08b8a76d61d5b1
Wonki Kim [Thu, 27 Sep 2018 05:23:51 +0000 (14:23 +0900)]
evas: Modify configure to branch by architectures for neon
Summary:
neon code is only needed to be included for the arm architecture.
so that this code modify automake configure files to support it.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7096
Change-Id: I70920f8cbabefc1e27deb4c9521d43d07974e404
Hermet Park [Wed, 12 Sep 2018 04:35:42 +0000 (13:35 +0900)]
evas neon: fix build break.
there is a grammatic error, just fix it.
Change-Id: I45593866e40e75d0f1da4b4b1ff6d17572f28715
Hermet Park [Thu, 27 Sep 2018 05:38:27 +0000 (14:38 +0900)]
Revert "Revert "evas: replace a current copy color function for neon""
This reverts commit
733774ed22e446096492b09f13637bd3daadf482.
Fix build break by
2e8f00c1ff0addfe32cfef329e808e8ef41c7a6f
Change-Id: I65b47d0bd8ba66049105e8b4015d6e41032d0424
Hermet Park [Thu, 27 Sep 2018 05:37:21 +0000 (14:37 +0900)]
Revert " evas_op_copy: disable neon in _op_copy_c_dp_neon"
This reverts commit
0d7891289fc8afe35af6e98bba117358eb8ad8ad.
Apply pixman-neon-copy implementation.
Change-Id: I1abd9bf6365f54d2bf533275c1cc4b2b2ac62e1b
JunsuChoi [Thu, 27 Sep 2018 02:14:39 +0000 (11:14 +0900)]
eo: Add null check
Summary:
This commit add null check on _efl_object_invalidate
In EO_OBJ_POINTER, if obj_id is null, obj can also be null.
Test Plan: N/A
Reviewers: cedric, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7068
Change-Id: I59fa9c6be5ea1502b6e783636c6456cbfe3a063b
JunsuChoi [Thu, 27 Sep 2018 02:13:36 +0000 (11:13 +0900)]
efl_ui_focus_manager: Add null check
Summary:
This commit add null check on _next and _request_subchild function.
The value 'node' is can be null.
Test Plan: N/A
Reviewers: bu5hm4n, YOhoho, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7069
Change-Id: I9c12ebc17bd2e959a4fc388ad761ee7d171581fd
JunsuChoi [Thu, 27 Sep 2018 02:11:56 +0000 (11:11 +0900)]
efl_ui_list: Add return value check
Summary:
efl_ui_layout_object_theme_set without checking return value.
so add return value check and log message.
Test Plan: N/A
Reviewers: SanghyeonLee, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7070
Change-Id: I9b2a28f390ce6886384c8f0e3ae007fcf4d4f1a6
JunsuChoi [Thu, 27 Sep 2018 02:10:25 +0000 (11:10 +0900)]
ctxpopup: Add return value check
Summary:
Using elm_widget_theme_object_set without checking return value.
so add return value check and log message
Test Plan: N/A
Reviewers: herb, cedric, Hermet
Reviewed By: Hermet
Subscribers: Hermet, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7072
Change-Id: I372f7ad1ea1989b34243b034f5209711e2b48c23
Jaehyun Cho [Thu, 26 Jul 2018 03:01:42 +0000 (12:01 +0900)]
evas_events: Use ecore mouse device instead of default mouse device
In Tizen, ecore uses mouse device handle corresponding to actual mouse
device.
However, evas uses both ecore mouse device handles and default mouse
handle at the same time.
This causes that "mouse_in" state is not preserved.
Consequently, mouse in/out callback is not called correctly.
To resolve above issue, evas stores the last activated ecore mouse
device handle to "last_mouse" variable.
This patch should be applied with
00004cb2e36842c41b866027ae7f486c6a9ad204
Change-Id: I5da9da5662c55af0df191c9a876487831f5f33d9
Signed-off-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Jaehyun Cho [Fri, 21 Sep 2018 09:40:05 +0000 (18:40 +0900)]
efl_ui_list: Return function if data get is failed
Summary: Check data and return function if data get is failed.
Reviewers: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7092
Change-Id: I37a3789d21c715dc3a64151daafa707808484f10
Shinwoo Kim [Fri, 21 Sep 2018 03:11:24 +0000 (03:11 +0000)]
eina_vpath_vdg: free locally allocated memory before return
The eina_vpath_resolve could allocate memory and return it.
But the eina_xdg_env_init does not release it.
*Detected by static analysis with the Coverity
Differential Revision: https://phab.enlightenment.org/D7066
Change-Id: Ic243f70632dd731cf1cab426d1abfe013afa362b
Shinwoo Kim [Fri, 21 Sep 2018 07:46:03 +0000 (16:46 +0900)]
evas_object_smart: fix dereference of null
Summary:
The cso could b NULL so we need to check if the cso is NULL or not before
dereferencing it.
Reviewers: jpeg, Hermet, jypark
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7075
Change-Id: Ic3b28206a263f4a145a0cd00b315652f00144407
Taehyub Kim [Fri, 21 Sep 2018 06:05:49 +0000 (15:05 +0900)]
Efl.Ui.Popup.Alert: add icon parameter for icon button of popup
Summary: add icon parameter for icon button of popup
Test Plan:
1. run elementry_test
2. run Efl.Ui.Popup.Alert sample
3. call set button function of popup and pass the icon by parameter
4. see the result of the popup
Reviewers: Jaehyun_Cho, jpeg, raster, cedric, woohyun
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7079
Change-Id: Ida7570b8089fe6138a06f850b3cdb7d03ba9e09f
Youngbok Shin [Fri, 21 Sep 2018 08:32:01 +0000 (17:32 +0900)]
evas-wayland-shm: add a missing code caused by upstream migration
@tizen_fix
Change-Id: I9788ac96a85195dabc66552fa34a58a1c60c22e7
Wonki Kim [Fri, 21 Sep 2018 06:32:40 +0000 (15:32 +0900)]
elm_atspi_bride: Add missing changes from cherry-picking
tizen patch
51f850df676956d4085002afb401d2c649ffb93f was cherry-picked from
upstream patch
804fc1667ac72338e3691447e149e54261a9ffe6.
however some changes were not cherry-picked by mistake.
this patch appends the missing changes.
Change-Id: I03323992f8b429f97fce16e512e801cce0057b1d
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Jaehyun Cho [Wed, 19 Sep 2018 12:01:55 +0000 (21:01 +0900)]
els_tooltip: Fix to show correct arrow type
Summary:
Current calculation for arrow type is not based on mouse position.
Consequently, tooltip arrow type is incorrect when tooltip shows on
mouse position with ELM_TOOLTIP_ORIENT_NONE.
Test Plan:
1. Execute "Tooltip" in elementary_test
2. Hover mouse on any button and move mouse
Reviewers: Hermet, raster, woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7074
Change-Id: I60920f4c5320cb649a8ef19359bca77ad2e7d315
Radoslaw Cybulski [Mon, 20 Aug 2018 13:38:39 +0000 (15:38 +0200)]
fix for wrong object passed to _elm_widget_accessibility_highlight_grabbing_set
Turning screen-reader on on setting app and flicking right until
reaching "device" item would crash setting due to invalid object
passed to _elm_widget_accessibility_highlight_grabbing_set function.
Change-Id: I055afee745ff782b870c5663fc124059df3db2f7
Taehyub Kim [Fri, 21 Sep 2018 04:26:26 +0000 (13:26 +0900)]
elc_multibuttonentry: fix the invalid return value
Change-Id: I9bab03d012bb391cc4114c3c8dbd4763ccde6179
SangHyeon Jade Lee [Fri, 21 Sep 2018 05:43:27 +0000 (14:43 +0900)]
evas_filter: fix wrong merge commit in evas filter
Change-Id: I8b8a44ab11b0c473aaee98b5e167e02b51f42999
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Joogab Yun [Fri, 21 Sep 2018 02:58:13 +0000 (11:58 +0900)]
ecore_evas_wayland_common : remove duplicate engine_info_set
We calculate the rotation value at the end of _rotation_do () and then we do the engine_info_set.
So we do not need engine_info_set here.
Myfiles -> search -> keybord -> input text -> look at the mangifier
-> rotate 90 or 270 -> input text -> rotate 0 -> input text -> look at
the mangifier -> issue
Change-Id: I6d729815f6749937693ed7934b08019b5a98c2cb
Youngbok Shin [Thu, 20 Sep 2018 04:32:59 +0000 (13:32 +0900)]
eina: add the last fallback runtime directory as /tmp
When XDG_RUNTIME_DIR environment value is empty,
Eina Vpath tries to use fallback runtime dir by calling _fallback_runtime_dir with "home".
But, that "home" path is not allowed for using runtime dir in Tizen.
So, we are going to add one more fallback directory as "/tmp" which is allowed in Tizen.
@tizen_fix
Change-Id: Ib57e2976d919bfe2a9a4babaa3e8c4626aaa2f8f
Jiyoun Park [Thu, 20 Sep 2018 05:48:09 +0000 (14:48 +0900)]
evas_op_copy: disable neon in _op_copy_c_dp_neon
crash occured in _op_copy_c_dp_neon function's neon code.
so disable neon code in that function until find the root cause.
Change-Id: Ic70585922c839d4dfae31cc5ffbfa5a4e8cf01b6
JunsuChoi [Wed, 19 Sep 2018 11:05:39 +0000 (20:05 +0900)]
ecore_wl2: Add return value check for coverity issue
Using wl_display_dispatch_pending without checking return value.
so add return value check and log message.
Change-Id: Ifa21cad0b0b64ff836215a0e56449c2ef07d6c2b
JunsuChoi [Wed, 19 Sep 2018 10:42:15 +0000 (19:42 +0900)]
ctxpopup: Add return value check for elm_layout_theme_set
Using elm_layout_theme_set without checking return value.
so add return value check and log message.
Change-Id: I849f04464df71b6e5bbd0a677b9f0031a70aaac6
JunsuChoi [Wed, 19 Sep 2018 08:10:32 +0000 (17:10 +0900)]
efl_ui_tab_pager : Fix type mismatch for calloc
Summary:
Fix type mismatch.
The return value of function 'calloc' is cast to type 'App_Data *',
which doesn't match the sizeof expression 'sizeof (ad)' passed as its 2nd argument 'sizeof (ad)'.
The size of the result is 8 bytes, value of the sizeof expression is 4.
Test Plan: N/A
Reviewers: bowonryu, SanghyeonLee
Reviewed By: bowonryu, SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7067
Change-Id: I2bd5cc58056c97c288e1bfbab93705568ba2b5f4
Woochanlee [Wed, 19 Sep 2018 04:47:26 +0000 (13:47 +0900)]
ecore_wl2_window: Fix incorrectly implemented null check.
https://phab.enlightenment.org/D7065
Change-Id: I5b97ce038dccaa9d20637802b30fb03686415c25
Taehyub Kim [Wed, 19 Sep 2018 04:40:13 +0000 (13:40 +0900)]
elm_genlist: add internal keyword for making private rootstrap
- To make private rootstrap, @internal keyword is needed.
Change-Id: I7b68ab0558658c38dd1ee5cf6d7a4370aef5594d
Shinwoo Kim [Tue, 18 Sep 2018 10:57:00 +0000 (19:57 +0900)]
ecore_wl2_window: make TIZEN aux_hint interface work
Upstream changed its condition before using aux_hint interface.
The tizen aux_hint interface did not work because of this.
The win->display->wl.efl_aux_hints is NULL on the tizen (downstream).
So there is not a logic change.
*tizen_fix
Change-Id: I767bca40e8605d7dfc46d550f93a349eeb846402
Hermet Park [Tue, 18 Sep 2018 11:59:52 +0000 (20:59 +0900)]
evas vg: fix non rendering issue of vg direct commands.
That's my critical mistake that
I supposed vg is only available at file input.
Change-Id: I9f112cc4e4b6d6058320214855b97716eef9d6bf
Hermet Park [Wed, 19 Sep 2018 02:10:30 +0000 (11:10 +0900)]
evas vg: add 2 more legacy apis.
evas_object_vg_animated_frame_count_get()
evas_object_vg_animated_frame_set()
@feature
Change-Id: I3081551f6da06cdaaecf20471296f58d5412781c
SangHyeon Jade Lee [Mon, 17 Sep 2018 10:54:41 +0000 (19:54 +0900)]
genlist: fix item show/bring in coordinate calculation with zero-sized pan.
item show and bring can be processed with zero-sized pan.
item's coordinate will be calculated with this zero-sized pan,
so target position of scroll region bring in is not proper.
it occurs wrong result of SCROLLTO_MIDDLE and SCROLLTO_BOTTOM cases.
now we check pan size, and if less than 1, deferred call.
this is port of upstream patch D7037
Change-Id: Ie5d5ecd039d835caefa47c272547506946e91a37
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
SangHyeon Jade Lee [Mon, 17 Sep 2018 10:48:12 +0000 (19:48 +0900)]
genlist: missing scrollto_bottom condition in item_scroll is fixed.
ELM_GENLIST_ITEM_SCROLLTO_BOTTOM condition is considered in coordinate_calc,
but not considered in item_scroll which calls deferred for item calculation.
so put the proper condition for ELM_GENLIST_ITEM_SCROLLTO_BOTTOM in item scroll.
this is port of upstream patch D7035
Change-Id: I2b5606c9eee9a7dac31d5aa75598ac0a52f66387
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Youngbok Shin [Tue, 18 Sep 2018 09:01:48 +0000 (18:01 +0900)]
Revert "elm_genlist: add internal keyword for making private rootstrap"
This reverts commit
c898de4c3ad10564599f38ba8bd6e8320ac404bb.
It is reverted to fix build failure.
Change-Id: Ic57982ab987665e965f0c649b103db8fc8bec34e
Youngbok Shin [Tue, 18 Sep 2018 08:41:41 +0000 (17:41 +0900)]
edje: Remove hack code
Summary:
special calculation for textblock is for fit calculation.
This is obvious from code that fit is being calculated
before text is actually been set to textblock.
I am not sure whether this is intentional or mistake
but it make sense to calculate fit after text is being
set so that formatted and native calculation can be proper.
@fix
Test Plan: NA
Reviewers: cedric, zmike, herdsman, devilhorns
Subscribers: stefan_schmidt, #reviewers, #committers, shilpasingh
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6045
Change-Id: Ib3d2256f11027690e756dce438ebc68deeaa02f0
Mike Blumenkrantz [Tue, 28 Aug 2018 18:09:05 +0000 (14:09 -0400)]
ci: run tests up to 5 times before failing
when travis is throttling resourcse more than usual (resources are
dynamically allocated since we are not using a paid service), it
can be the case that tests fail even more than usual.
this number may need to be increased further if 5 does not provide enough
reliability
Differential Revision: https://phab.enlightenment.org/D6920
Marcel Hollerbach [Wed, 1 Aug 2018 14:41:45 +0000 (16:41 +0200)]
elm-containers: use alive api
check if the object is in its correct lifetime before performing
operations
Differential Revision: https://phab.enlightenment.org/D6724
Marcel Hollerbach [Wed, 1 Aug 2018 14:41:14 +0000 (16:41 +0200)]
eo: add funktion for alive checks
The function simply checks if the object is finalized and not
started to be invalidated or invalidated.
Differential Revision: https://phab.enlightenment.org/D6723
Mike Blumenkrantz [Wed, 25 Jul 2018 15:41:39 +0000 (11:41 -0400)]
build: make configure not error if cxx compiler is not found when not needed
a cxx compiler is not required unless physics, poppler, or ddraw support are
enabled, so don't fail configure unless one of those cases is true
ref T2838
Differential Revision: https://phab.enlightenment.org/D6683
Mike Blumenkrantz [Wed, 25 Jul 2018 15:44:21 +0000 (11:44 -0400)]
build: break out ddraw and cocoa static engine builds into utility libraries
these engines include c++ and objc files, meaning the final evas library will
use cxx/objc compilers for linking--even if they are not enabled--as long as
they are added to libevas.la in any condition
by compiling them into separate libraries and linking those into libevas.la,
cc can be used for linking in all cases
fix T2838
Differential Revision: https://phab.enlightenment.org/D6682
Mike Blumenkrantz [Fri, 14 Sep 2018 08:49:45 +0000 (10:49 +0200)]
ci: silence libtool
attempt to disable some libtool warnings throughout the build
https://phab.enlightenment.org/D6661
[Hand edited to get it applied. Stefan]
Yeongjong Lee [Tue, 11 Sep 2018 07:37:56 +0000 (07:37 +0000)]
spinner_example: add focused, unfocused callback to test focus signal
add focused, unfocused callback for test
Differential Revision: https://phab.enlightenment.org/D7019
Marcel Hollerbach [Mon, 13 Aug 2018 13:47:18 +0000 (15:47 +0200)]
ethumb: fix module loading when running in tree
Differential Revision: https://phab.enlightenment.org/D6820
Yeongjong Lee [Tue, 11 Sep 2018 07:22:06 +0000 (07:22 +0000)]
test_gengrid: add focused, unfocused callback to test focus signal
add focused, unfocused callback for test
Differential Revision: https://phab.enlightenment.org/D7018
Mike Blumenkrantz [Mon, 6 Aug 2018 18:14:02 +0000 (14:14 -0400)]
tests/elm: use custom tick source for animator events
ensure that animator ticks are occurring at the same time as render
dumping in order to further speed up tests
Differential Revision: https://phab.enlightenment.org/D6766
Alastair Poole [Wed, 12 Sep 2018 19:18:03 +0000 (19:18 +0000)]
evas_events: NULL check before evas_event_freezes_through.
In some cases focused_obj can be NULL. Add a check before
calling evas_event_freezes_through. Was causing a SEGV
in some situations. Avoiding a crash here is good
but we also need to warn for future debugging to
be more useful.
Differential Revision: https://phab.enlightenment.org/D7027
Alastair Poole [Wed, 12 Sep 2018 19:01:57 +0000 (20:01 +0100)]
efl_ui_focus_manager_calc: invalidate obj on delete.
Summary:
In some situations focus is being set to a deleted object.
Use EFL_EVENT_INVALIDATE on object deletion not
EFL_EVENT_DEL. This prevents the object to be again selected for restoring focus when a redirect is deleted.
This fixes SEGV with some widgets including popup tests.
Test Plan:
* elementary_test -to popup
* popup-center-text + 3 button (check add, remove buttons).
* Close popup, enter text (reopen popup and repeat).
* Crash should be avoided.
Reviewers: bu5hm4n, zmike
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7026
Marcel Hollerbach [Wed, 12 Sep 2018 12:39:14 +0000 (08:39 -0400)]
ecore_wl2: add support for intree loading of the module
Summary: the module was not loaded when we were running intree.
Reviewers: ManMower, devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7023
Derek Foreman [Tue, 11 Sep 2018 16:22:06 +0000 (12:22 -0400)]
wayland_egl: Fix drop shadows on radeon
Summary:
We're doing this all wrong.
We've asking for "at least 1 bit" of A, R, G, B color depth.
ARGB2101010 fits that nicely, so mesa on radeon gives it to us.
This only fixes the drop shadows though, it's entirely possible that
a fullscreen window without alpha would get ARGB2101010 instead of
XRGB8888, so this code probably needs a rethink for multiple engines.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7022
Lauro Moura [Tue, 11 Sep 2018 14:31:51 +0000 (11:31 -0300)]
efl-csharp: Add copy constructor for eina.Value.
Summary: This will allow deep copying the given value from C#.
Reviewers: felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: vitor.sousa, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7017
Alastair Poole [Tue, 11 Sep 2018 11:22:34 +0000 (12:22 +0100)]
elm_code: Make sure we handle python3 mime type.
Summary:
Let's not miss python3 mimetype when setting up
syntax highlighting.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7000