Benedikt Meurer [Thu, 4 Dec 2014 11:19:28 +0000 (12:19 +0100)]
[turbofan] Narrow upper bounds during typed lowering.
This is a temporary solution, which optionally narrows upper bounds of
nodes when changing the operator of a node.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
741503006
Cr-Commit-Position: refs/heads/master@{#25658}
ulan [Thu, 4 Dec 2014 10:52:33 +0000 (02:52 -0800)]
Do not embed function in DirectLoadGlobalFunctionPrototype.
BUG=v8:3629
LOG=N
Review URL: https://codereview.chromium.org/
778673002
Cr-Commit-Position: refs/heads/master@{#25657}
Benedikt Meurer [Thu, 4 Dec 2014 10:50:43 +0000 (11:50 +0100)]
[turbofan] Reduce context accesses during typed lowering.
TEST=unittests
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
776243002
Cr-Commit-Position: refs/heads/master@{#25656}
machenbach [Thu, 4 Dec 2014 10:37:36 +0000 (02:37 -0800)]
Make JSTests ready for Android measurements.
This adds a common perf configuration for JSTests including
Classes, Collections, Iterators and Strings. This allows
the android test runner to handle subdirectories correctly
and to share the base.js resource in the parent directory.
The new json config has added resources configs for the
Android runner.
The perf runner's relative paths on the device are fixed as
well. Resources are only pushed on the configuration node
where they are specified. They are pushed to a dir on the
device that follows the same directory structure as on the
host. The binary is executed in the benchmark folder on the
device like on the host to allow relative path file
loading.
BUG=chromium:374740
LOG=n
TEST=python -m unittest run_perf_test
TBR=ulan@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/
779923002
Cr-Commit-Position: refs/heads/master@{#25655}
machenbach [Thu, 4 Dec 2014 10:31:13 +0000 (02:31 -0800)]
Revert of Encode reservation meta data in the snapshot blob. (patchset #3 id:40001 of https://codereview.chromium.org/
781443002/)
Reason for revert:
[sheriff] Breaks http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/1540
Original issue's description:
> Encode reservation meta data in the snapshot blob.
>
> This also makes reserving multiple chunks per object space possible.
>
> R=vogelheim@chromium.org
TBR=vogelheim@chromium.org,baixo@chromium.org,yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
780833002
Cr-Commit-Position: refs/heads/master@{#25654}
weiliang.lin [Thu, 4 Dec 2014 10:13:13 +0000 (02:13 -0800)]
[x64] check sahf correctly
BUG=
Review URL: https://codereview.chromium.org/
777173002
Cr-Commit-Position: refs/heads/master@{#25653}
yangguo [Thu, 4 Dec 2014 09:50:27 +0000 (01:50 -0800)]
Encode reservation meta data in the snapshot blob.
This also makes reserving multiple chunks per object space possible.
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/
781443002
Cr-Commit-Position: refs/heads/master@{#25652}
machenbach [Thu, 4 Dec 2014 08:58:01 +0000 (00:58 -0800)]
Fix path construction in perf runner.
BUG=chromium:374740
LOG=n
TEST=python -m unittest run_perf_test
TBR=ulan@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/
776873005
Cr-Commit-Position: refs/heads/master@{#25651}
aandrey [Thu, 4 Dec 2014 08:53:23 +0000 (00:53 -0800)]
Fix Promise.resolve/Promise.reject unnecessarily scheduling a microtask.
R=rossberg@chromium.org, yangguo@chromium.org, adamk@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/
777703002
Cr-Commit-Position: refs/heads/master@{#25650}
cdai2 [Thu, 4 Dec 2014 04:32:42 +0000 (12:32 +0800)]
X87: Use weak cells to embed maps in store handler.
port
3fc9c9b665baaa434c672efcbff632a2eae86f56
original commit message:
Use weak cells to embed maps in store handler.
BUG=v8:3629
R=weiliang.lin@intel.com
Review URL: https://codereview.chromium.org/
779843002
Cr-Commit-Position: refs/heads/master@{#25649}
chunyang.dai [Thu, 4 Dec 2014 02:59:52 +0000 (18:59 -0800)]
X87: CheckPrototypes uses weak cells to embed maps.
port
062a032f50291ce181462226ff41b4ef9b11deba
original commit message:
CheckPrototypes uses weak cells to embed maps.
BUG=
Review URL: https://codereview.chromium.org/
761093004
Cr-Commit-Position: refs/heads/master@{#25648}
balazs.kilvady [Wed, 3 Dec 2014 18:32:57 +0000 (10:32 -0800)]
MIPS: Use weak cells to embed maps in store handler.
Port
3fc9c9b665baaa434c672efcbff632a2eae86f56
BUG=v8:3629
LOG=N
Review URL: https://codereview.chromium.org/
762483004
Cr-Commit-Position: refs/heads/master@{#25647}
titzer [Wed, 3 Dec 2014 17:53:31 +0000 (09:53 -0800)]
Reland "[turbofan] Reuse forward fixpoint algorithm in Typer by making it a Reducer."
This reverts commit
918ef9d712ab77bc33ffb8eb985a6fd5672602f6.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
780623002
Cr-Commit-Position: refs/heads/master@{#25646}
balazs.kilvady [Wed, 3 Dec 2014 17:37:01 +0000 (09:37 -0800)]
MIPS: CheckPrototypes uses weak cells to embed maps.
Port
062a032f50291ce181462226ff41b4ef9b11deba
BUG=v8:3629
LOG=N
Review URL: https://codereview.chromium.org/
777673002
Cr-Commit-Position: refs/heads/master@{#25645}
machenbach [Wed, 3 Dec 2014 15:34:53 +0000 (07:34 -0800)]
Optimize pushing files in android perf test runner.
BUG=chromium:374740
LOG=n
TEST=python -m unittest run_perf_test
NOTRY=true
Review URL: https://codereview.chromium.org/
754463005
Cr-Commit-Position: refs/heads/master@{#25644}
Ben L. Titzer [Wed, 3 Dec 2014 15:03:16 +0000 (16:03 +0100)]
Revert "[turbofan] Reuse forward fixpoint algorithm in Typer by making it a Reducer."
This reverts commit
a48ad24a7c258d95acf3a6ae126036953a9122dd.
BUG=
Review URL: https://codereview.chromium.org/
763773004
Cr-Commit-Position: refs/heads/master@{#25643}
wingo [Wed, 3 Dec 2014 14:52:36 +0000 (06:52 -0800)]
Move more don't-crankshaft computation to numbering pass
The "do I inline?" decision needs many of the same inputs as the "should
I even try to crankshaft?" decision. This change consolidates these
checks in the numbering pass. It also removes the is_generator() check,
as that's already handled when visiting the initial Yield expression.
R=svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
775693003
Cr-Commit-Position: refs/heads/master@{#25642}
balazs.kilvady [Wed, 3 Dec 2014 14:18:23 +0000 (06:18 -0800)]
MIPS64: [turbofan] Add checked load/store operators.
Port
c516d4f09408879602520748333754d3866224fb
BUG=
Review URL: https://codereview.chromium.org/
773113005
Cr-Commit-Position: refs/heads/master@{#25641}
arv [Wed, 3 Dec 2014 14:17:16 +0000 (06:17 -0800)]
Simplify template literal raw string creation
BUG=v8:3710
LOG=Y
R=dslomov@chromium.org, marja@chromium.org
Review URL: https://codereview.chromium.org/
768203002
Cr-Commit-Position: refs/heads/master@{#25640}
ulan [Wed, 3 Dec 2014 13:36:50 +0000 (05:36 -0800)]
Use weak cells to embed maps in store handler.
BUG=v8:3629
LOG=N
Review URL: https://codereview.chromium.org/
774473004
Cr-Commit-Position: refs/heads/master@{#25639}
mstarzinger [Wed, 3 Dec 2014 13:24:49 +0000 (05:24 -0800)]
Prevent redundant node revisit in ControlEquivalence.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
773133003
Cr-Commit-Position: refs/heads/master@{#25638}
hpayer [Wed, 3 Dec 2014 13:13:49 +0000 (05:13 -0800)]
Restart idle round on context disposal.
BUG=
Review URL: https://codereview.chromium.org/
754363008
Cr-Commit-Position: refs/heads/master@{#25637}
Dusan Milosavljevic [Wed, 3 Dec 2014 13:09:46 +0000 (14:09 +0100)]
MIPS: Improve pushing arguments on stack.
TEST=
BUG=
R=paul.lind@imgtec.com
Review URL: https://codereview.chromium.org/
769283002
Cr-Commit-Position: refs/heads/master@{#25636}
Dusan Milosavljevic [Wed, 3 Dec 2014 12:50:38 +0000 (13:50 +0100)]
MIPS: Fix ambiguous double constant loading after adding checked load/store operators.
The V8_INFINITY macro expands to constant expression of type float.
TEST=mjsunit/constant-folding-2
BUG=
R=balazs.kilvady@imgtec.com
Review URL: https://codereview.chromium.org/
779433003
Cr-Commit-Position: refs/heads/master@{#25635}
ulan [Wed, 3 Dec 2014 12:34:26 +0000 (04:34 -0800)]
CheckPrototypes uses weak cells to embed maps.
BUG=v8:3629
LOG=N
Review URL: https://codereview.chromium.org/
770373002
Cr-Commit-Position: refs/heads/master@{#25634}
titzer [Wed, 3 Dec 2014 11:51:55 +0000 (03:51 -0800)]
[turbofan] Reuse forward fixpoint algorithm in Typer by making it a Reducer.
R=jarin@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
769303002
Cr-Commit-Position: refs/heads/master@{#25633}
bmeurer [Wed, 3 Dec 2014 10:33:47 +0000 (02:33 -0800)]
[turbofan] Initial work on cleaning up the Node class.
- Remove use_count_, only used for debug builds and tests.
- Use BitField instead of the unreliable C++ bit fields.
- Improve memory layout.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
780503002
Cr-Commit-Position: refs/heads/master@{#25632}
hpayer [Wed, 3 Dec 2014 10:03:14 +0000 (02:03 -0800)]
Print finalize incremental marking event in idle notification.
BUG=
Review URL: https://codereview.chromium.org/
775013002
Cr-Commit-Position: refs/heads/master@{#25631}
hpayer [Wed, 3 Dec 2014 09:36:54 +0000 (01:36 -0800)]
Slow down incremental marking on main thread when idle notification is active.
BUG=
Review URL: https://codereview.chromium.org/
771703004
Cr-Commit-Position: refs/heads/master@{#25630}
yangguo [Wed, 3 Dec 2014 09:12:28 +0000 (01:12 -0800)]
Serializer: cache recent back references for shorter encoding.
And some refactorings.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
766893002
Cr-Commit-Position: refs/heads/master@{#25629}
marja [Wed, 3 Dec 2014 08:23:37 +0000 (00:23 -0800)]
Make test-parsing faster: don't run parsing tests with all experimental flag combinations.
Instead, make it possible for indifidual tests to pass "always true flags" which
are not part of the varying flag set.
The downside is that if an experimental flag changes parsing of some of the
unrelated code snippets, it's noticed later (only after the flag is turned on by
default). But this is a reasonable trade off for faster tests.
Additional fix: Some tests (ErrorsFutureStrictReservedWords) were using
always_flags incorrectly (running two different tests with different
always_flags basically iterates over every flag combination anyway - most of
them twice).
BUG=v8:3707
LOG=N
Review URL: https://codereview.chromium.org/
772823002
Cr-Commit-Position: refs/heads/master@{#25628}
Benedikt Meurer [Wed, 3 Dec 2014 07:34:47 +0000 (08:34 +0100)]
[turbofan] Combine additional Word32And with Int32Add and negative power of two.
- (y << L + x) & (-1 << L) => (x & (-1 << L)) + y << L
- (x + y << L) & (-1 << L) => (x & (-1 << L)) + y << L
TEST=unittests
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
758603003
Cr-Commit-Position: refs/heads/master@{#25627}
paul.lind [Wed, 3 Dec 2014 00:28:07 +0000 (16:28 -0800)]
MIPS: [turbofan] Add checked load/store operators.
Port
c516d4f09408879602520748333754d3866224fb
Partial port to un-break the build. There are a few failing
tests, and the code is suboptimal for smaller offsets.
Fixes and mips64 port will come in another CL.
BUG=
Review URL: https://codereview.chromium.org/
762853004
Cr-Commit-Position: refs/heads/master@{#25626}
adamk [Tue, 2 Dec 2014 23:06:44 +0000 (15:06 -0800)]
Optimize non-mutation Map and Set operations for String keys
Review URL: https://codereview.chromium.org/
757143002
Cr-Commit-Position: refs/heads/master@{#25625}
vogelheim [Tue, 2 Dec 2014 18:53:27 +0000 (10:53 -0800)]
Fix NativesCollection<.>::GetScriptName in natives-external.cc
As there's no associated bug, here's the issue:
- Some ES6 functionality in Chrome is presently broken; this fixes it.
- The natives (built-in libraries) can be accessed by their 'name'.
This is used to active ES6 flags.
- Strangely enough, there's an id and a name, where the name is derived
from the id as "native %s.js", with %s for the id.
- NativesCollection<.>::GetScriptName uses the name.
- NativesCollection<.>::GetIndex uses the id.
- Example:
NativesCollection<EXPERIMENTAL>::GetIndex("harmony-string") -> 3
NativesCollection<EXPERIMENTAL>::GetScriptName(3) -> "native harmony-string.js"
- Nobody knows why; it's quite mysterious.
- When introducing the "external startup data", I didn't fully understand this
and used the id in both places.
- When the "external startup data" was turned on in Chrome, ES6 features broke
in Chrome since the libraries could no longer be found.
- This CL fixes this and makes the external startup data behave just like the
built-in version.
R=dslomov
BUG=
Review URL: https://codereview.chromium.org/
774613003
Cr-Commit-Position: refs/heads/master@{#25624}
baptiste.afsa [Tue, 2 Dec 2014 18:45:30 +0000 (10:45 -0800)]
[turbofan] Enable DivIsSafe flag for arm64.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
773803003
Cr-Commit-Position: refs/heads/master@{#25623}
mstarzinger [Tue, 2 Dec 2014 16:51:48 +0000 (08:51 -0800)]
Switch CFGBuilder to use NodeMarker.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
753063004
Cr-Commit-Position: refs/heads/master@{#25622}
mstarzinger [Tue, 2 Dec 2014 15:56:22 +0000 (07:56 -0800)]
Restrict floating control to minimal control-connected component.
R=jarin@chromium.org
TEST=cctest/test-scheduler/NestedFloatingDiamondWithChain
Review URL: https://codereview.chromium.org/
738613005
Cr-Commit-Position: refs/heads/master@{#25621}
mstarzinger [Tue, 2 Dec 2014 15:37:52 +0000 (07:37 -0800)]
Make generic algorithm a little less generic.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
760493003
Cr-Commit-Position: refs/heads/master@{#25620}
weiliang.lin [Tue, 2 Dec 2014 15:30:03 +0000 (07:30 -0800)]
[ia32] Introduce FMA3 instructions on scalar data elements.
port
83a635e0d70f144300ea83be0d7effc1eb1bf6ef
BUG=
Review URL: https://codereview.chromium.org/
773783002
Cr-Commit-Position: refs/heads/master@{#25619}
jochen [Tue, 2 Dec 2014 15:09:19 +0000 (07:09 -0800)]
Trace how long it takes to compute the weak closure during mark-compact
BUG=none
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
769253002
Cr-Commit-Position: refs/heads/master@{#25618}
dslomov [Tue, 2 Dec 2014 14:54:31 +0000 (06:54 -0800)]
Stage ES6 classes and object literal extensions.
R=arv@chromium.org,rossberg@chromium.org
BUG=v8:3330
LOG=Y
Review URL: https://codereview.chromium.org/
774653002
Cr-Commit-Position: refs/heads/master@{#25617}
danno [Tue, 2 Dec 2014 14:38:55 +0000 (06:38 -0800)]
Clean up node iteration
- Create a first-class Edge type.
- Separate node and edge iterators
- Make iterators only responsible for iteration
- Make it possible to modify the use edge iterator while iterating.
- Add the ability to update inputs to Edges directly.
Review URL: https://codereview.chromium.org/
765983002
Cr-Commit-Position: refs/heads/master@{#25616}
ulan [Tue, 2 Dec 2014 14:25:17 +0000 (06:25 -0800)]
Reland parts of 'Use weak cells in map checks in polymorphic ICs'
This relands macroassembler instructions and weak cell caching and
does not include parts that caused "Linux ASan LSan" test failures.
BUG=v8:3663
LOG=N
Review URL: https://codereview.chromium.org/
764003003
Cr-Commit-Position: refs/heads/master@{#25615}
machenbach [Tue, 2 Dec 2014 14:23:51 +0000 (06:23 -0800)]
Add Android platform to performance runner.
BUG=chromium:374740
LOG=n
TEST=python -m unittest run_perf_test
NOTRY=true
Review URL: https://codereview.chromium.org/
768143002
Cr-Commit-Position: refs/heads/master@{#25614}
svenpanne [Tue, 2 Dec 2014 13:47:10 +0000 (05:47 -0800)]
Fixed environment handling for LFlooringDivI on ARM.
Beautiful code... :-}
BUG=chromium:437765
LOG=y
Review URL: https://codereview.chromium.org/
775613002
Cr-Commit-Position: refs/heads/master@{#25613}
Marja Hölttä [Tue, 2 Dec 2014 13:23:30 +0000 (14:23 +0100)]
Make the ParserSync test faster (and re-enable it).
Most of the run time came from testing with all possible flag combinations. None
of the flags passed affect the test, and there are specialized tests for testing
the features behind the flags; no need to slow down the generic test.
With these changes, run time for debug build goes from 186 s to 0.5 s.
In addition, fixed some missing commas between the test cases.
R=svenpanne@chromium.org
BUG=v8:3707
LOG=N
Review URL: https://codereview.chromium.org/
766673003
Cr-Commit-Position: refs/heads/master@{#25612}
Benedikt Meurer [Tue, 2 Dec 2014 12:45:08 +0000 (13:45 +0100)]
[turbofan] Use the temporary zone for the VN cache.
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
760403003
Cr-Commit-Position: refs/heads/master@{#25611}
Benedikt Meurer [Tue, 2 Dec 2014 12:41:31 +0000 (13:41 +0100)]
[turbofan] Cache the Branch operator(s).
TEST=unittests
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
771153002
Cr-Commit-Position: refs/heads/master@{#25610}
Benedikt Meurer [Tue, 2 Dec 2014 11:40:25 +0000 (12:40 +0100)]
[turbofan] Cache the JSStoreProperty operator(s).
TEST=unittests
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
769193003
Cr-Commit-Position: refs/heads/master@{#25609}
dslomov [Tue, 2 Dec 2014 11:34:29 +0000 (03:34 -0800)]
Restore correct logic in GC test.
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
767453004
Cr-Commit-Position: refs/heads/master@{#25608}
hpayer [Tue, 2 Dec 2014 11:24:58 +0000 (03:24 -0800)]
Perform smaller marking steps incrementally in idle notification.
BUG=
Review URL: https://codereview.chromium.org/
767233003
Cr-Commit-Position: refs/heads/master@{#25607}
jochen [Tue, 2 Dec 2014 11:23:51 +0000 (03:23 -0800)]
After moving unreachable weak global handles only process harmony collections
Groups and implicit references are no longer relevant at this point.
Also add tests that fail if the first or second round of ephemeral
marking is omitted
BUG=none
R=mstarzinger@chromium.org,hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
761343004
Cr-Commit-Position: refs/heads/master@{#25606}
Benedikt Meurer [Tue, 2 Dec 2014 11:10:46 +0000 (12:10 +0100)]
[turbofan] Add missing tests for SimplifiedOperatorBuilder.
TEST=unittests
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
772723003
Cr-Commit-Position: refs/heads/master@{#25605}
titzer [Tue, 2 Dec 2014 11:07:17 +0000 (03:07 -0800)]
[turbofan] Enable stage 1.
R=danno@chromium.org,bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
770203003
Cr-Commit-Position: refs/heads/master@{#25604}
marja [Tue, 2 Dec 2014 10:58:11 +0000 (02:58 -0800)]
ES6 unicode extensions, part 1.
Allows \u{xxxxx} in variable names and string literals (not yet in regexps).
Everything's behind the --harmony-unicode flag.
BUG=
Review URL: https://codereview.chromium.org/
716423002
Cr-Commit-Position: refs/heads/master@{#25603}
titzer [Tue, 2 Dec 2014 10:43:00 +0000 (02:43 -0800)]
[turbofan] Initialize less frequently used types in typer.cc lazily.
R=jarin@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
771683002
Cr-Commit-Position: refs/heads/master@{#25602}
marja [Tue, 2 Dec 2014 10:31:40 +0000 (02:31 -0800)]
Parser: Removing debug code.
The mystery crash never reappeared once the debugging code was in place.
R=jochen@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
760863003
Cr-Commit-Position: refs/heads/master@{#25601}
titzer [Tue, 2 Dec 2014 10:02:38 +0000 (02:02 -0800)]
[turbofan] Make context specialization into a reducer.
R=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
771713002
Cr-Commit-Position: refs/heads/master@{#25600}
Hannes Payer [Tue, 2 Dec 2014 09:27:41 +0000 (10:27 +0100)]
Fix idle time trace printing.
BUG=
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
771123002
Cr-Commit-Position: refs/heads/master@{#25599}
yurys [Tue, 2 Dec 2014 09:13:16 +0000 (01:13 -0800)]
Add GetIdentityHash to v8::Name object API
v8::Object already has GetIdentityHash on it. This change adds its counterpart to v8::Name.
BUG=chromium:437416
LOG=Y
Review URL: https://codereview.chromium.org/
753373003
Cr-Commit-Position: refs/heads/master@{#25598}
machenbach [Tue, 2 Dec 2014 08:16:43 +0000 (00:16 -0800)]
Revert of Use weak cells in map checks in polymorphic ICs. (patchset #8 id:140001 of https://codereview.chromium.org/
753993003/)
Reason for revert:
[Sheriff] Speculative revert for breaking chromium asan (roll blocker):
http://build.chromium.org/p/client.v8/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/1683
Original issue's description:
> Use weak cells in map checks in polymorphic ICs.
>
> BUG=v8:3663
> LOG=N
TBR=mvstanton@chromium.org,akos.palfi@imgtec.com,weiliang.lin@intel.com,ulan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=v8:3663
Review URL: https://codereview.chromium.org/
771033003
Cr-Commit-Position: refs/heads/master@{#25597}
machenbach [Tue, 2 Dec 2014 08:15:30 +0000 (00:15 -0800)]
Revert of MIPS: Use weak cells in map checks in polymorphic ICs. (patchset #1 id:1 of https://codereview.chromium.org/
767623003/)
Reason for revert:
Need to revert the ported CL:
https://codereview.chromium.org/
771033003/
Original issue's description:
> MIPS: Use weak cells in map checks in polymorphic ICs.
>
> Port
45a36948e1bb0f02d395ecbcfe6306553898268b
>
> Fix typo in the mips ports.
>
> BUG=
TBR=ulan@chromium.org,danno@chromium.org,akos.palfi@imgtec.com,balazs.kilvady@imgtec.com,gergely.kis@imgtec.com,dusan.milosavljevic@imgtec.com,paul.lind@imgtec.com
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
768303002
Cr-Commit-Position: refs/heads/master@{#25596}
weiliang.lin [Tue, 2 Dec 2014 08:09:39 +0000 (00:09 -0800)]
[ia32] Introduce vex prefix version of float64 arithmetic binop
port
50c4d8826b838596cda892d76ec84eb7a0eab9c1
BUG=
Review URL: https://codereview.chromium.org/
770183002
Cr-Commit-Position: refs/heads/master@{#25595}
bmeurer [Tue, 2 Dec 2014 07:30:36 +0000 (23:30 -0800)]
[turbofan] Workaround inconsistency of the type system.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
770193002
Cr-Commit-Position: refs/heads/master@{#25594}
bmeurer [Tue, 2 Dec 2014 07:25:36 +0000 (23:25 -0800)]
Get rid of the unused __my_bool__ macro.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
770163002
Cr-Commit-Position: refs/heads/master@{#25593}
thakis [Tue, 2 Dec 2014 05:23:09 +0000 (21:23 -0800)]
Set V8_CC_GNU or V8_CC_MSVC for clang in gcc / cl mode.
Also, remove V8_CC_CLANG since it's not read anywhere (and ideally shouldn't
be).
Clang tries to be compatible with gcc in clang mode, and with msvc in clang-cl
mode. It wants to go down the same code paths that these compilers want to go
down in most cases.
For example, V8PRIxPTR was set incorrectly on Windows 64-bit before this change
since macros.h assumed that checking for V8_CC_MSVC is enough to find LLP64
systems, but V8_CC_MSVC wasn't set for clang. Most other existing checks for
V8_CC_MSVC should be taken for clang-cl too (and for the remaining ones,
clang-cl is happy with either code path).
Likewise, V8_IMMEDIATE_CRASH is currently set to a suboptimal value with clang
since __builtin_trap() is only used if V8_CC_GNU is set.
Including clang in the gcc and cl macros is also what chromium does.
BUG=chromium:82385
LOG=y
Review URL: https://codereview.chromium.org/
757553004
Cr-Commit-Position: refs/heads/master@{#25592}
Benedikt Meurer [Tue, 2 Dec 2014 04:48:57 +0000 (05:48 +0100)]
[turbofan] Add checked load/store operators.
TEST=mjsunit,cctest,unittests
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
763963002
Cr-Commit-Position: refs/heads/master@{#25591}
paul.lind [Mon, 1 Dec 2014 22:26:37 +0000 (14:26 -0800)]
MIPS: Use weak cells in map checks in polymorphic ICs.
Port
45a36948e1bb0f02d395ecbcfe6306553898268b
Fix typo in the mips ports.
BUG=
Review URL: https://codereview.chromium.org/
767623003
Cr-Commit-Position: refs/heads/master@{#25590}
dslomov [Mon, 1 Dec 2014 20:13:44 +0000 (12:13 -0800)]
harmony-classes: Fix some issues with syntactic restriction on super(...).
R=arv@chromium.org
BUG=v8:3330
LOG=N
Review URL: https://codereview.chromium.org/
770843002
Cr-Commit-Position: refs/heads/master@{#25589}
hpayer [Mon, 1 Dec 2014 17:02:54 +0000 (09:02 -0800)]
Use just one marking deque.
BUG=
Review URL: https://codereview.chromium.org/
770453003
Cr-Commit-Position: refs/heads/master@{#25588}
titzer [Mon, 1 Dec 2014 16:15:36 +0000 (08:15 -0800)]
[turbofan] Add a PhaseScope for initialization.
R=dcarney@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
773443002
Cr-Commit-Position: refs/heads/master@{#25587}
svenpanne [Mon, 1 Dec 2014 14:30:25 +0000 (06:30 -0800)]
Improved Makefile.android's readability a bit.
Review URL: https://codereview.chromium.org/
770783003
Cr-Commit-Position: refs/heads/master@{#25586}
ishell [Mon, 1 Dec 2014 14:19:11 +0000 (06:19 -0800)]
Do not call Heap::IterateAndMarkPointersToFromSpace() for unboxed double fields.
BUG=chromium:437143
LOG=N
Review URL: https://codereview.chromium.org/
768113002
Cr-Commit-Position: refs/heads/master@{#25585}
ulan [Mon, 1 Dec 2014 14:06:18 +0000 (06:06 -0800)]
Android ARM: enable PIE.
BUG=
Review URL: https://codereview.chromium.org/
757103003
Cr-Commit-Position: refs/heads/master@{#25584}
titzer [Mon, 1 Dec 2014 11:50:37 +0000 (03:50 -0800)]
[turbofan] NodeMarker in ControlReducer.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
767743003
Cr-Commit-Position: refs/heads/master@{#25583}
Weiliang Lin [Mon, 1 Dec 2014 10:45:02 +0000 (11:45 +0100)]
[x64] introduce vex prefix version of float64 arithmetic binop
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
764863002
Patch from Weiliang Lin <weiliang.lin@intel.com>.
Cr-Commit-Position: refs/heads/master@{#25582}
ulan [Mon, 1 Dec 2014 10:41:01 +0000 (02:41 -0800)]
Use weak cells in map checks in polymorphic ICs.
BUG=v8:3663
LOG=N
Review URL: https://codereview.chromium.org/
753993003
Cr-Commit-Position: refs/heads/master@{#25581}
danno [Mon, 1 Dec 2014 10:04:32 +0000 (02:04 -0800)]
[turbofan]: Use "leal" more prevasively on x64
Only use "addl" and "subl" in cases that have been measured to be
faster (currently only immediate operations).
Review URL: https://codereview.chromium.org/
735293004
Cr-Commit-Position: refs/heads/master@{#25580}
halton.huo [Mon, 1 Dec 2014 09:17:24 +0000 (01:17 -0800)]
Fix clang++ warnings on -Wtautological-constant-out-of-range-compare
BUG=v8:3730
LOG=N
R=dslomov@chromium.org
Review URL: https://codereview.chromium.org/
750093003
Cr-Commit-Position: refs/heads/master@{#25579}
jochen [Mon, 1 Dec 2014 09:15:03 +0000 (01:15 -0800)]
Make sure we have non-zero idle time even after rounding to size_t
BUG=v8:3728
R=machenbach@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
764263002
Cr-Commit-Position: refs/heads/master@{#25578}
dslomov [Fri, 28 Nov 2014 20:07:11 +0000 (12:07 -0800)]
Introduce a kill-switch for shipping features.
R=rossberg@chromium.org
TBR=hpayer@chromium.org
Committed: https://chromium.googlesource.com/v8/v8/+/
d6285620868b15c84eb9affa59f6b4e869f074b8
Review URL: https://codereview.chromium.org/
763273002
Cr-Commit-Position: refs/heads/master@{#25577}
machenbach [Fri, 28 Nov 2014 18:39:41 +0000 (10:39 -0800)]
Abstract platform in perf runner.
This is basically a refactoring that extracts desktop
specific code into a separate class.
Also adds flags for android runs (not used yet).
BUG=chromium:374740
LOG=n
TEST=python -m unittest run_perf_test
NOTRY=true
Review URL: https://codereview.chromium.org/
762163002
Cr-Commit-Position: refs/heads/master@{#25576}
mstarzinger [Fri, 28 Nov 2014 18:38:31 +0000 (10:38 -0800)]
Remove deprecated NodeData class.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
768853002
Cr-Commit-Position: refs/heads/master@{#25575}
dslomov [Fri, 28 Nov 2014 18:27:45 +0000 (10:27 -0800)]
Revert of Introduce a kill-switch for shipping features. (patchset #2 id:20001 of https://codereview.chromium.org/
763273002/)
Reason for revert:
Reverted for breaking nosnap: http://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20nosnap/builds/1003/steps/Check/logs/Threading3
Original issue's description:
> Introduce a kill-switch for shipping features.
>
> R=rossberg@chromium.org
>
> Committed: https://chromium.googlesource.com/v8/v8/+/
d6285620868b15c84eb9affa59f6b4e869f074b8
TBR=rossberg@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
763353002
Cr-Commit-Position: refs/heads/master@{#25574}
dslomov [Fri, 28 Nov 2014 15:41:34 +0000 (07:41 -0800)]
Stage @@toStringTag (--harmony-tostring)
R=rossberg@chromium.org,caitpotter88@gmail.com
LOG=Y
Review URL: https://codereview.chromium.org/
768833002
Cr-Commit-Position: refs/heads/master@{#25573}
mstarzinger [Fri, 28 Nov 2014 15:21:33 +0000 (07:21 -0800)]
De-generify the GenericNode.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
756073004
Cr-Commit-Position: refs/heads/master@{#25572}
aandrey [Fri, 28 Nov 2014 14:48:58 +0000 (06:48 -0800)]
Expose generator object internal properties via mirrors.
BUG=v8:3292
R=yangguo@chromium.org, wingo@igalia.com
LOG=N
Review URL: https://codereview.chromium.org/
760303002
Cr-Commit-Position: refs/heads/master@{#25571}
Dmitry Lomov [Fri, 28 Nov 2014 14:32:07 +0000 (15:32 +0100)]
Introduce a kill-switch for shipping features.
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
763273002
Cr-Commit-Position: refs/heads/master@{#25570}
mstarzinger [Fri, 28 Nov 2014 14:21:01 +0000 (06:21 -0800)]
De-generify the GenericGraph.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
767733002
Cr-Commit-Position: refs/heads/master@{#25569}
Dusan Milosavljevic [Fri, 28 Nov 2014 13:35:00 +0000 (14:35 +0100)]
MIPS64: Fix MULT in simulator to conform the spec.
TEST=mjsunit/numops-fuzz-part4
BUG=
R=balazs.kilvady@imgtec.com
Review URL: https://codereview.chromium.org/
756073003
Cr-Commit-Position: refs/heads/master@{#25568}
Ben L. Titzer [Fri, 28 Nov 2014 13:04:49 +0000 (14:04 +0100)]
[turbofan] Add NodeMarker and use it in the GraphReducer.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
768763002
Cr-Commit-Position: refs/heads/master@{#25567}
yangguo [Fri, 28 Nov 2014 12:07:40 +0000 (04:07 -0800)]
Serializer: use opcode to signal new chunk.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
757813003
Cr-Commit-Position: refs/heads/master@{#25566}
mstarzinger [Fri, 28 Nov 2014 11:57:08 +0000 (03:57 -0800)]
Remove deprecated pieces from generic algorithm.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
752263003
Cr-Commit-Position: refs/heads/master@{#25565}
hpayer [Fri, 28 Nov 2014 11:53:59 +0000 (03:53 -0800)]
Use incremental marking deque in idle notification.
BUG=
Review URL: https://codereview.chromium.org/
766663006
Cr-Commit-Position: refs/heads/master@{#25564}
machenbach [Fri, 28 Nov 2014 11:35:37 +0000 (03:35 -0800)]
Make resources config ready for android test runner.
This switches off the resources feature. It will be solely
used for configuring files to be copied to android devices
in a follow up CL.
TBR=svenpanne@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/
764013002
Cr-Commit-Position: refs/heads/master@{#25563}
dcarney [Fri, 28 Nov 2014 11:07:34 +0000 (03:07 -0800)]
add fast path for hashing small cons strings
R=yangguo@chromium.org
LOG=N
BUG=437280
Review URL: https://codereview.chromium.org/
769453002
Cr-Commit-Position: refs/heads/master@{#25562}
mstarzinger [Fri, 28 Nov 2014 11:06:16 +0000 (03:06 -0800)]
Remove duplicate code for searching SharedFunctionInfo.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
762123002
Cr-Commit-Position: refs/heads/master@{#25561}
hpayer [Fri, 28 Nov 2014 10:59:18 +0000 (02:59 -0800)]
Use deadline in IdleNotification.
BUG=417668
LOG=n
Review URL: https://codereview.chromium.org/
750813003
Cr-Commit-Position: refs/heads/master@{#25560}
machenbach [Fri, 28 Nov 2014 10:34:28 +0000 (02:34 -0800)]
Add test flags feature to perf runner.
TBR=svenpanne@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/
722023006
Cr-Commit-Position: refs/heads/master@{#25559}