kjlubick [Fri, 25 Mar 2016 12:53:57 +0000 (05:53 -0700)]
patch battery charging until recipe is updated
BUG=skia:5111
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834793003
Review URL: https://codereview.chromium.org/
1834793003
halcanary [Fri, 25 Mar 2016 12:52:57 +0000 (05:52 -0700)]
SkPDF: speed up SkPDFShader generation.
Stop using SkString::append() when SkDynamicMemoryWStream
works better.
Also add a bench to prove that this speeds things up:
before:
micros bench
59.33 ? PDFShader nonrendering
after:
micros bench
34.55 ? PDFShader nonrendering
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1833793002
Review URL: https://codereview.chromium.org/
1833793002
kjlubick [Fri, 25 Mar 2016 12:22:40 +0000 (05:22 -0700)]
Splitting up wait_for_device into two pieces
BUG=skia:5111
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1829753004
Review URL: https://codereview.chromium.org/
1829753004
robertphillips [Fri, 25 Mar 2016 11:55:58 +0000 (04:55 -0700)]
Revert of Consolidate GPU buffer implementations (patchset #10 id:180001 of https://codereview.chromium.org/
1825393002/ )
Reason for revert:
Lots of Android redness
Original issue's description:
> Consolidate GPU buffer implementations
>
> Consolidates all the different buffer implementations into a single
> GrBuffer class. This will allow us to add new buffer types, use DSA in
> OpenGL, track buffer bindings by unique ID, cache buffers without
> respect to the type of data they have been used for previously, etc.
> This change is strictly a refactor; it introduces no change in
> functionality.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825393002
>
> Committed: https://skia.googlesource.com/skia/+/
8b1bff29675afd25843439eade634a57f68fe16f
TBR=bsalomon@google.com,egdaniel@google.com,jvanverth@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1831133004
robertphillips [Fri, 25 Mar 2016 11:49:22 +0000 (04:49 -0700)]
Switch SkMorphologyImageFilter over to new onFilterImage interface
This now relies on: https://codereview.chromium.org/
1826233002/ (Add rowBytesAsPixels and shiftPerPixel to SkPixmap)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1819393002
Review URL: https://codereview.chromium.org/
1819393002
cdalton [Fri, 25 Mar 2016 08:54:54 +0000 (01:54 -0700)]
Consolidate GPU buffer implementations
Consolidates all the different buffer implementations into a single
GrBuffer class. This will allow us to add new buffer types, use DSA in
OpenGL, track buffer bindings by unique ID, cache buffers without
respect to the type of data they have been used for previously, etc.
This change is strictly a refactor; it introduces no change in
functionality.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825393002
Review URL: https://codereview.chromium.org/
1825393002
benjaminwagner [Fri, 25 Mar 2016 02:07:58 +0000 (19:07 -0700)]
Change type of SkGlyph::fAdvance[XY] to float.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1737693006
Review URL: https://codereview.chromium.org/
1737693006
ericrk [Thu, 24 Mar 2016 22:35:45 +0000 (15:35 -0700)]
Add getDeferredTextureImageData early out
Currently, when dealing with deferred texture image data, we will decode the image even if it will later fail to
upload to the GPU due to size constraints.
This change adds an early out to our initial decode /
sizing logic.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1831873002
Review URL: https://codereview.chromium.org/
1831873002
brianosman [Thu, 24 Mar 2016 19:20:01 +0000 (12:20 -0700)]
Ignore sampleapp_prefs.txt in git.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834743002
Review URL: https://codereview.chromium.org/
1834743002
bungeman [Thu, 24 Mar 2016 18:27:05 +0000 (11:27 -0700)]
Draw black on white for CG glyph masks.
BUG=skia:5095
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1827963002
Review URL: https://codereview.chromium.org/
1827963002
robertphillips [Thu, 24 Mar 2016 18:21:25 +0000 (11:21 -0700)]
Add rowBytesAsPixels and shiftPerPixel to SkPixmap
This is intended to make it easier to manipulate SkBitmaps and SkPixmaps in a parallel manner (e.g., in https://codereview.chromium.org/
1819393002/ (Switch SkMorphologyImageFilter over to new onFilterImage interface))
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1826233002
Review URL: https://codereview.chromium.org/
1826233002
fmalita [Thu, 24 Mar 2016 18:05:28 +0000 (11:05 -0700)]
Relocate SK_SUPPORT_LEGACY_PICTURE_PTR
Move to platform-specific defines.
(Chromium already has this guard)
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1831053002
Review URL: https://codereview.chromium.org/
1831053002
msarett [Thu, 24 Mar 2016 17:41:47 +0000 (10:41 -0700)]
Delete SkImageDecoder
This image decoding implementation has been replaced
by SkCodec in Android.
Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.
Now we can delete SkImageDecoder :).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820503002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Committed: https://skia.googlesource.com/skia/+/
f799706656f2581c5bf5510d94df3fa17cce1607
Committed: https://skia.googlesource.com/skia/+/
5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb
Committed: https://skia.googlesource.com/skia/+/
f037fdebda2a2626e6512d7532063f2cd41a264d
Review URL: https://codereview.chromium.org/
1820503002
brianosman [Thu, 24 Mar 2016 17:33:42 +0000 (10:33 -0700)]
Blacklist giant (4k) wbmp from GPU bots.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1827063004
Review URL: https://codereview.chromium.org/
1827063004
mtklein [Thu, 24 Mar 2016 17:12:37 +0000 (10:12 -0700)]
Sk4x4f: NEON impl.
Notable tricks:
- v{ld,st}4q_f32 handle transposing loads and stores of floats in one step
- vcvtq_n_{f32_u32,u32_f32} let us do conversion to and from floats without shifts
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1828613002
Review URL: https://codereview.chromium.org/
1828613002
egdaniel [Thu, 24 Mar 2016 16:50:58 +0000 (09:50 -0700)]
Remove debug prints in GrVkGpu
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834663002
Review URL: https://codereview.chromium.org/
1834663002
halcanary [Thu, 24 Mar 2016 16:18:14 +0000 (09:18 -0700)]
images with offset bitmap don't share genid
BUG=skia:5096
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1813793002
Review URL: https://codereview.chromium.org/
1813793002
robertphillips [Thu, 24 Mar 2016 15:29:40 +0000 (08:29 -0700)]
Fix debugger w.r.t. sk_sp changes
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1828273002
Review URL: https://codereview.chromium.org/
1828273002
bungeman [Thu, 24 Mar 2016 15:17:55 +0000 (08:17 -0700)]
Don't force lcd on non-opaque portion of layer.
SkCanvas::saveLayerPreserveLCDTextRequests allows for lcd in layers but
forces the user to ensure that the lcd text is only drawn on opaque parts
of the layer. Otherwise the behavior is more or less undefined. This GM
did this on purpose to demonstrate, but it turns out this is unstable and
depends on the alignment of the glyph masks in CPU. Since we don't support
this mode anyway, drop it from the gm.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834673002
Review URL: https://codereview.chromium.org/
1834673002
tomhudson [Thu, 24 Mar 2016 14:50:14 +0000 (07:50 -0700)]
Add missing SK_API to SkSwizzle.h
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1828733003
Review URL: https://codereview.chromium.org/
1828733003
brianosman [Thu, 24 Mar 2016 14:27:43 +0000 (07:27 -0700)]
https://codereview.chromium.org/
1830973002 fixed this bug. Re-enable the
tests and remove comments referencing it.
BUG=skia:4822
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1830163002
Review URL: https://codereview.chromium.org/
1830163002
robertphillips [Thu, 24 Mar 2016 14:26:32 +0000 (07:26 -0700)]
Switch new SkImageFilter internal methods over to sk_sp
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1826893002
Review URL: https://codereview.chromium.org/
1826893002
brianosman [Thu, 24 Mar 2016 13:56:32 +0000 (06:56 -0700)]
Convert Gray8 images to N32 before uploading. Previously, we were
treating them as Alpha8, which was wrong. Fixes incorrect images on the
filterbitmap_image_mandrill_64.png_g8 GM.
BUG=skia:4822
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1830973002
Review URL: https://codereview.chromium.org/
1830973002
mtklein [Thu, 24 Mar 2016 13:44:03 +0000 (06:44 -0700)]
NDK: r11 -> r11b
Just bug fixes. Nothing terribly exciting.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825213007
Review URL: https://codereview.chromium.org/
1825213007
robertphillips [Thu, 24 Mar 2016 13:31:25 +0000 (06:31 -0700)]
Switch SkColorFilterImageFilter over to new onFilterImage interface
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782083002
Committed: https://skia.googlesource.com/skia/+/
ec950c4d215c6141b31b98ed6a8182a97baeb8b9
Review URL: https://codereview.chromium.org/
1782083002
robertphillips [Thu, 24 Mar 2016 12:01:23 +0000 (05:01 -0700)]
Switch SkBlurImageFilter over to new onFilterImage interface
This CL relies on:
https://codereview.chromium.org/
1787883002/ (Add SkSpecialImage::extractSubset & NewFromPixmap)
https://codereview.chromium.org/
1808743003/ (Allow SkGpuDevice::drawSprite to handle subset SkBitmaps)
https://codereview.chromium.org/
1813813002/ (Add SkSpecialImage::makeTextureImage entry point)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1785643003
Committed: https://skia.googlesource.com/skia/+/
3c935bc87020bfd19a08922f7394db3a801d168b
Review URL: https://codereview.chromium.org/
1785643003
msarett [Thu, 24 Mar 2016 11:45:39 +0000 (04:45 -0700)]
Revert of Delete SkImageDecoder (patchset #9 id:150001 of https://codereview.chromium.org/
1820503002/ )
Reason for revert:
Roll still failing
Original issue's description:
> Delete SkImageDecoder
>
> This image decoding implementation has been replaced
> by SkCodec in Android.
>
> Additionally, we have replaced uses of SkImageDecoder
> in Skia and Google3 with uses of SkCodec.
>
> Now we can delete SkImageDecoder :).
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820503002
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
f799706656f2581c5bf5510d94df3fa17cce1607
>
> Committed: https://skia.googlesource.com/skia/+/
5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb
>
> Committed: https://skia.googlesource.com/skia/+/
f037fdebda2a2626e6512d7532063f2cd41a264d
TBR=scroggo@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1830943002
msarett [Thu, 24 Mar 2016 02:19:28 +0000 (19:19 -0700)]
Delete SkImageDecoder
This image decoding implementation has been replaced
by SkCodec in Android.
Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.
Now we can delete SkImageDecoder :).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820503002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Committed: https://skia.googlesource.com/skia/+/
f799706656f2581c5bf5510d94df3fa17cce1607
Committed: https://skia.googlesource.com/skia/+/
5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb
Review URL: https://codereview.chromium.org/
1820503002
reed [Thu, 24 Mar 2016 01:59:25 +0000 (18:59 -0700)]
switch surface to sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1817383002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1817383002
msarett [Thu, 24 Mar 2016 01:52:40 +0000 (18:52 -0700)]
Revert of Delete SkImageDecoder (patchset #8 id:130001 of https://codereview.chromium.org/
1820503002/ )
Reason for revert:
Testing the roll - it's still failing
Original issue's description:
> Delete SkImageDecoder
>
> This image decoding implementation has been replaced
> by SkCodec in Android.
>
> Additionally, we have replaced uses of SkImageDecoder
> in Skia and Google3 with uses of SkCodec.
>
> Now we can delete SkImageDecoder :).
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820503002
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
f799706656f2581c5bf5510d94df3fa17cce1607
>
> Committed: https://skia.googlesource.com/skia/+/
5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb
TBR=scroggo@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1828433004
msarett [Thu, 24 Mar 2016 01:10:14 +0000 (18:10 -0700)]
Delete SkImageDecoder
This image decoding implementation has been replaced
by SkCodec in Android.
Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.
Now we can delete SkImageDecoder :).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820503002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Committed: https://skia.googlesource.com/skia/+/
f799706656f2581c5bf5510d94df3fa17cce1607
Review URL: https://codereview.chromium.org/
1820503002
robertphillips [Wed, 23 Mar 2016 23:38:05 +0000 (16:38 -0700)]
Revert of Switch SkColorFilterImageFilter over to new onFilterImage interface (patchset #5 id:80001 of https://codereview.chromium.org/
1782083002/ )
Reason for revert:
seems to be breaking the 10k skp bot
Original issue's description:
> Switch SkColorFilterImageFilter over to new onFilterImage interface
>
> TBR=bsalomon@google.com
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782083002
>
> Committed: https://skia.googlesource.com/skia/+/
ec950c4d215c6141b31b98ed6a8182a97baeb8b9
TBR=senorblanco@google.com,senorblanco@chromium.org,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1829993003
herb [Wed, 23 Mar 2016 22:14:23 +0000 (15:14 -0700)]
Add index-8 sampler to the pipeline.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1829883002
Review URL: https://codereview.chromium.org/
1829883002
bsalomon [Wed, 23 Mar 2016 21:55:21 +0000 (14:55 -0700)]
Make GrGLGetDriverInfo work for null strings.
The media unit tests in Chromium use a test context that returns nullptr for its vendor/renderer strings.
TBR=robertphillips@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1831633002
Review URL: https://codereview.chromium.org/
1831633002
robertphillips [Wed, 23 Mar 2016 21:03:43 +0000 (14:03 -0700)]
Revert of Switch SkBlurImageFilter over to new onFilterImage interface (patchset #15 id:270001 of https://codereview.chromium.org/
1785643003/ )
Reason for revert:
serialize-8888 broken for some reason
Original issue's description:
> Switch SkBlurImageFilter over to new onFilterImage interface
>
> This CL relies on:
> https://codereview.chromium.org/
1787883002/ (Add SkSpecialImage::extractSubset & NewFromPixmap)
> https://codereview.chromium.org/
1808743003/ (Allow SkGpuDevice::drawSprite to handle subset SkBitmaps)
> https://codereview.chromium.org/
1813813002/ (Add SkSpecialImage::makeTextureImage entry point)
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1785643003
>
> Committed: https://skia.googlesource.com/skia/+/
3c935bc87020bfd19a08922f7394db3a801d168b
TBR=senorblanco@google.com,senorblanco@chromium.org,bsalomon@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1831603002
egdaniel [Wed, 23 Mar 2016 20:49:40 +0000 (13:49 -0700)]
Set up cache in vulkan to reuse GrVkPrograms (aka VkPipelines)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1816153002
Review URL: https://codereview.chromium.org/
1816153002
senorblanco [Wed, 23 Mar 2016 20:44:26 +0000 (13:44 -0700)]
Make a generic list of filters for use in ImageFilterTests.
Factor list of image filters out of one test for re-use elsewhere.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1829913002
Review URL: https://codereview.chromium.org/
1829913002
mtklein [Wed, 23 Mar 2016 19:54:54 +0000 (12:54 -0700)]
force no SSE on iOS simulator
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1832533002
Review URL: https://codereview.chromium.org/
1832533002
robertphillips [Wed, 23 Mar 2016 19:50:46 +0000 (12:50 -0700)]
Switch SkBlurImageFilter over to new onFilterImage interface
This CL relies on:
https://codereview.chromium.org/
1787883002/ (Add SkSpecialImage::extractSubset & NewFromPixmap)
https://codereview.chromium.org/
1808743003/ (Allow SkGpuDevice::drawSprite to handle subset SkBitmaps)
https://codereview.chromium.org/
1813813002/ (Add SkSpecialImage::makeTextureImage entry point)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1785643003
Review URL: https://codereview.chromium.org/
1785643003
fmalita [Wed, 23 Mar 2016 19:28:14 +0000 (12:28 -0700)]
Planar ramp() for S32 linear gradients
R=mtklein@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825333003
Review URL: https://codereview.chromium.org/
1825333003
msarett [Wed, 23 Mar 2016 19:26:29 +0000 (12:26 -0700)]
Revert of Delete SkImageDecoder (patchset #7 id:110001 of https://codereview.chromium.org/
1820503002/ )
Reason for revert:
Various problems
Original issue's description:
> Delete SkImageDecoder
>
> This image decoding implementation has been replaced
> by SkCodec in Android.
>
> Additionally, we have replaced uses of SkImageDecoder
> in Skia and Google3 with uses of SkCodec.
>
> Now we can delete SkImageDecoder :).
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820503002
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
f799706656f2581c5bf5510d94df3fa17cce1607
TBR=scroggo@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1830723002
bsalomon [Wed, 23 Mar 2016 18:50:26 +0000 (11:50 -0700)]
Add unit test for vertex attribute count.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1826863002
Review URL: https://codereview.chromium.org/
1826863002
msarett [Wed, 23 Mar 2016 18:28:09 +0000 (11:28 -0700)]
Delete SkImageDecoder
This image decoding implementation has been replaced
by SkCodec in Android.
Additionally, we have replaced uses of SkImageDecoder
in Skia and Google3 with uses of SkCodec.
Now we can delete SkImageDecoder :).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820503002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1820503002
caryclark [Wed, 23 Mar 2016 18:15:57 +0000 (11:15 -0700)]
fix path getSegment comment
R=djsollen@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1828753002
Review URL: https://codereview.chromium.org/
1828753002
jvanverth [Wed, 23 Mar 2016 18:01:22 +0000 (11:01 -0700)]
GrVkGpu initialization cleanup.
Add GrVkBackendContext for GrVkGpu initialization
Add missing extension initialization
Use device function pointers rather than instance
BUG=skia:5116
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825593002
Review URL: https://codereview.chromium.org/
1825593002
tomhudson [Wed, 23 Mar 2016 17:51:20 +0000 (10:51 -0700)]
Publicly expose one accelerated swizzle.
SkOpts is intentionally internal, but we want to give Chrome access
to those pieces that would seriously benefit them.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1822363002
Review URL: https://codereview.chromium.org/
1822363002
bsalomon [Wed, 23 Mar 2016 17:40:53 +0000 (10:40 -0700)]
Make max number of vertex attributes be checked dynamically
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1822343002
Review URL: https://codereview.chromium.org/
1822343002
mtklein [Wed, 23 Mar 2016 16:52:13 +0000 (09:52 -0700)]
Sk4x4f: Simplify x86 down to SSE2.
- This drops the minimum requirement for Sk4x4f on x86 to SSE2 by
removing calls to _mm_shuffle_epi8(). Instead we use good old
shifting and masking.
- Performance is very similar to SSSE3, close enough I'm having trouble
telling which is faster. I think we should let ourselves circle back
on whether we need an SSSE3 version later. When possible it's nice
to stick to SSE2: it's most available, and performs most uniformly
across different chips.
This makes Sk4x4f fast on Windows and Linux, and may help mobile x86.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1817353005
Review URL: https://codereview.chromium.org/
1817353005
robertphillips [Wed, 23 Mar 2016 16:42:12 +0000 (09:42 -0700)]
Switch SkColorFilterImageFilter over to new onFilterImage interface
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1782083002
Review URL: https://codereview.chromium.org/
1782083002
herb [Wed, 23 Mar 2016 16:00:33 +0000 (09:00 -0700)]
WIP: experimental bilerp pipeline.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1775963002
Review URL: https://codereview.chromium.org/
1775963002
benjaminwagner [Wed, 23 Mar 2016 15:38:59 +0000 (08:38 -0700)]
Google3 Android no longer has undefok.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1826793002
Review URL: https://codereview.chromium.org/
1826793002
msarett [Wed, 23 Mar 2016 13:50:59 +0000 (06:50 -0700)]
Workaround to set the sRGB flag on SkImageGenerator
BUG=skia:4895
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820413002
Review URL: https://codereview.chromium.org/
1820413002
mtklein [Wed, 23 Mar 2016 13:29:12 +0000 (06:29 -0700)]
Port S32A_opaque blit row to SkOpts.
This should be a pixel-for-pixel (i.e. bug-for-bug) port.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820313002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1820313002
halcanary [Wed, 23 Mar 2016 13:26:31 +0000 (06:26 -0700)]
SkPDF: Hold page objects, not SkPDFDevices.
Page Contents:
serialize early, at endPage()
SkPDFDocument:
Rather than holding all SkPDFDevices until onClose(), store
fGlyphUseage and array of pages objects.
perform_font_subsetting function removed:
First half moved to onEndPage.
Second half moved to onClose.
create_pdf_page function removed:
Merged into onEndPage.
generate_page_tree:
Refactored to use SkTArray<sk_sp<T>> over SkTDArray<T*>.
(the former is explicit about ownership, the latter is unclear.)
No longer populates a structure of objects to be dumped,
unnecessary since dump is always called after serialization.
Takes ownership of fPages and returns root of tree-ified version.
Less reference churn.
SkPDFGlyphSetMap:
use new-style iterator.
BUG=skia:5087
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1823683005
Review URL: https://codereview.chromium.org/
1823683005
robertphillips [Wed, 23 Mar 2016 12:00:01 +0000 (05:00 -0700)]
Switch SkDropShaderImageFilter over to new onFilterImage interface
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1784863003
Review URL: https://codereview.chromium.org/
1784863003
robertphillips [Wed, 23 Mar 2016 11:40:01 +0000 (04:40 -0700)]
Switch SkLocalMatrixImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1780233002
Review URL: https://codereview.chromium.org/
1780233002
mtklein [Wed, 23 Mar 2016 01:30:44 +0000 (18:30 -0700)]
Use Sk4x4f in srcover_srgb_dst_1.
I've also pulled out the common parts shared with sRGB srcover_n,
and rearranged to make the similarities a bit more clear.
This speeds up about 25%.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1829513002
Review URL: https://codereview.chromium.org/
1829513002
senorblanco [Wed, 23 Mar 2016 00:32:59 +0000 (17:32 -0700)]
Remove SK_SUPPORT_LEGACY_FILTERBOUNDS_RETURN.
It's now-unused.
BUG=skia:5094
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1823243002
Review URL: https://codereview.chromium.org/
1823243002
mtklein [Wed, 23 Mar 2016 00:17:44 +0000 (17:17 -0700)]
Sk4x4f
An API for loading and storing 4 Sk4f with transpose.
This has SSSE3+ and portable versions.
SSE2 and NEON versions to follow.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825663002
Review URL: https://codereview.chromium.org/
1825663002
msarett [Tue, 22 Mar 2016 21:30:27 +0000 (14:30 -0700)]
Use SkColorSpacePrintf instead of SkDebugf
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1828503002
Review URL: https://codereview.chromium.org/
1828503002
jvanverth [Tue, 22 Mar 2016 20:15:44 +0000 (13:15 -0700)]
Fix borrowed GrVkImage::Resource.
With the current system, if we wrap a given GrVkTextureInfo*, add a
command using it to the command buffer, then delete the texture, the
command buffer will unref the GrVkImage::Resource when it's done, which
will delete the VkImage and VkDeviceMemory. This subclasses
GrVkImage::Resource for those cases, and will not delete the data on
an unref.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1824123002
Review URL: https://codereview.chromium.org/
1824123002
mtklein [Tue, 22 Mar 2016 19:36:01 +0000 (12:36 -0700)]
fix --threads 4, blacklist interlaced1,2,3 on GPU
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1827543002
Review URL: https://codereview.chromium.org/
1827543002
robertphillips [Tue, 22 Mar 2016 19:20:15 +0000 (12:20 -0700)]
Remove SkPixmap::release
No longer need this for ImageFilters
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1821303002
Review URL: https://codereview.chromium.org/
1821303002
mtklein [Tue, 22 Mar 2016 18:46:53 +0000 (11:46 -0700)]
SkRecord: infer return type for visit() and mutate().
Review URL: https://codereview.chromium.org/
1824983003
mtklein [Tue, 22 Mar 2016 18:08:24 +0000 (11:08 -0700)]
Try throttling x86 desktop bots down with fewer threads.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825163002
Review URL: https://codereview.chromium.org/
1825163002
bungeman [Tue, 22 Mar 2016 17:59:09 +0000 (10:59 -0700)]
Correctly handle lfWidth in GDI.
The LOGFONT::lfWidth field is related to the LOGFONT::lfHeight field,
it is not related in any way to the OS/2::usWidthClass (unlike
LOGFONT::lfWeight, which mirrors the OS/2::usWeightClass). Be sure to
canonicalize this field to 0 (default) and not use it as a style value.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1819973003
Review URL: https://codereview.chromium.org/
1819973003
reed [Tue, 22 Mar 2016 17:17:23 +0000 (10:17 -0700)]
Reland of [2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (patchset #1 id:1 of https://codereview.chromium.org/
1821103004/ )
Reason for revert:
guard has now landed in chrome
Original issue's description:
> Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (patchset #3 id:40001 of https://codereview.chromium.org/
1825073002/ )
>
> Reason for revert:
> CreateModeFilter not compiling
>
> Original issue's description:
> > Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.org/
1822623002/ )"
> >
> > Fixed legacy withColorFilter to call new(er) make method
> >
> > This reverts commit
1eb81db650d31f50be67b12d60c4f9e7dd08432f.
> >
> > BUG=skia:
> > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825073002
> >
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/
4c9776b046dd5e9e46e2d1ce35154855c8fcb381
>
> TBR=
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
d6889293dd0942f27f9593f679722c956831f2c4
TBR=
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
Review URL: https://codereview.chromium.org/
1827433002
robertphillips [Tue, 22 Mar 2016 16:56:58 +0000 (09:56 -0700)]
Fix second memory leak in SkSpecialImage
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825073003
Review URL: https://codereview.chromium.org/
1825073003
borenet [Tue, 22 Mar 2016 16:37:57 +0000 (09:37 -0700)]
Add experimental Swarmbucket bot
Docs here:
https://chromium.googlesource.com/infra/infra/+/master/appengine/cr-buildbucket/doc/swarming.md
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820323002
Review URL: https://codereview.chromium.org/
1820323002
abarth [Tue, 22 Mar 2016 16:14:40 +0000 (09:14 -0700)]
Make GrCircleBlurFragmentProcessor::onIsEqual include the position
Previously we would fail to draw two adjacent blurred circles if they differed
only by their position.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1824693003
Review URL: https://codereview.chromium.org/
1824693003
msarett [Tue, 22 Mar 2016 16:01:20 +0000 (09:01 -0700)]
Blacklist RAW images on x86 Ubuntu
BUG=skia:5115
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1822033002
Review URL: https://codereview.chromium.org/
1822033002
reed [Tue, 22 Mar 2016 15:59:19 +0000 (08:59 -0700)]
Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (patchset #3 id:40001 of https://codereview.chromium.org/
1825073002/ )
Reason for revert:
CreateModeFilter not compiling
Original issue's description:
> Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.org/
1822623002/ )"
>
> Fixed legacy withColorFilter to call new(er) make method
>
> This reverts commit
1eb81db650d31f50be67b12d60c4f9e7dd08432f.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825073002
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
4c9776b046dd5e9e46e2d1ce35154855c8fcb381
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1821103004
msarett [Tue, 22 Mar 2016 15:58:35 +0000 (08:58 -0700)]
Refactor SkBmpCodec
I started working on indicating the native encoded formats
and things got really complicated for bmp. I think starting
with this refactor may help a little, and I also think that
this is a good change by itself.
BUG=skia:4133
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1820283002
Review URL: https://codereview.chromium.org/
1820283002
reed [Tue, 22 Mar 2016 15:10:17 +0000 (08:10 -0700)]
Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.org/
1822623002/ )"
Fixed legacy withColorFilter to call new(er) make method
This reverts commit
1eb81db650d31f50be67b12d60c4f9e7dd08432f.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825073002
TBR=
Review URL: https://codereview.chromium.org/
1825073002
reed [Tue, 22 Mar 2016 14:35:17 +0000 (07:35 -0700)]
Revert of switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.org/
1822623002/ )
Reason for revert:
need to fix unguarded makeWithFilter
Original issue's description:
> switch colorfilters to sk_sp
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1822623002
>
> Committed: https://skia.googlesource.com/skia/+/
f809d7687a4fb7b88b651b046da2bc0035d6aa09
TBR=fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1820303002
mtklein [Tue, 22 Mar 2016 14:28:12 +0000 (07:28 -0700)]
Revert of Clean up SSSE3 and SSE4 stubs. (patchset #1 id:1 of https://codereview.chromium.org/
1810183003/ )
Reason for revert:
I've just had a better idea about how to fix this. Let's revert while I work on it.
Original issue's description:
> Clean up SSSE3 and SSE4 stubs.
>
> We added these stubs to work around OpenBSD's old compiler, which had
> support for SSE2 but not SSSE3 or SSE4.
>
> We now already have other unstubbed files that require SSSE3 and SSE4 compiler
> support. All the compilers we support have SSSE3 and SSE4 support, and all the
> way up to at least AVX2.
>
> (Requiring C++11 has had some nice ripple effects...)
>
>
> And, <immintrin.h> is already auto-included for these files, so no need for smmintrin or tmmintrin.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1810183003
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
2b1b40e11afc41452b4d2f74cdebb1b6e6f7cc96
TBR=djsollen@google.com,mtklein@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
Review URL: https://codereview.chromium.org/
1819223003
reed [Tue, 22 Mar 2016 14:23:24 +0000 (07:23 -0700)]
switch colorfilters to sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1822623002
Review URL: https://codereview.chromium.org/
1822623002
egdaniel [Tue, 22 Mar 2016 14:16:10 +0000 (07:16 -0700)]
Fully implement onResetContext for Vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1819343002
Review URL: https://codereview.chromium.org/
1819343002
robertphillips [Tue, 22 Mar 2016 13:15:47 +0000 (06:15 -0700)]
Potential fix for SpecialImageTest memory leak
TBR=bsalomon@google.com
NOTREECHECKS=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825043002
Review URL: https://codereview.chromium.org/
1825043002
jcgregorio [Tue, 22 Mar 2016 12:26:57 +0000 (05:26 -0700)]
nanobench: Stop reporting median_ms, it's no better than min_ms.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1825473002
Review URL: https://codereview.chromium.org/
1825473002
senorblanco [Mon, 21 Mar 2016 21:51:59 +0000 (14:51 -0700)]
Change signatures of filter bounds methods to return a rect.
Change filterBounds(), onFilterBounds() and onFilterNodeBounds() and computeFastBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.
BUG=skia:5094
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1823573003
Review URL: https://codereview.chromium.org/
1823573003
halcanary [Mon, 21 Mar 2016 21:33:17 +0000 (14:33 -0700)]
SkPDF: SkPDFDevice has ptr to SkPDFDocument
This is necessary for pre-serialization of images.
BUG=skia:5087
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1802963002
Review URL: https://codereview.chromium.org/
1802963002
egdaniel [Mon, 21 Mar 2016 21:24:14 +0000 (14:24 -0700)]
fix release build vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1819853004
Review URL: https://codereview.chromium.org/
1819853004
halcanary [Mon, 21 Mar 2016 20:45:05 +0000 (13:45 -0700)]
SkPDF: SkPDFDocument reorganized so that some objects can be serialized early.
No change in output.
BUG=skia:5087
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1802033003
Review URL: https://codereview.chromium.org/
1802033003
robertphillips [Mon, 21 Mar 2016 20:44:18 +0000 (13:44 -0700)]
Update SkSpecialImage to be able to create tight SkImages and SkSurfaces
This calved off of: https://codereview.chromium.org/
1810693003/ (Switch SkTileImageFilter over to new onFilterImage interface) since the TileImageFilter needs a tight bitmap/texture/image to perform its draw.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1816223002
Review URL: https://codereview.chromium.org/
1816223002
msarett [Mon, 21 Mar 2016 20:35:43 +0000 (13:35 -0700)]
Disable the WIC encoder for jpegs
My fix from https://codereview.chromium.org/
1791583002/ is not
sufficient.
WIC will only encode JPEGs if we pass in a bitmap in BGR
format. For now, let's disable the WIC encoder on JPEGs
and fall back on SkImageEncoder_libjpeg.
This should fix the scaled-generator gm.
https://gold.skia.org/search2?query=source_type%3Dgm%26name%3Dscale-generator&include=false&head=true&unt=true&pos=false&neg=false&limit=100
BUG=skia:3969
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1823743002
Review URL: https://codereview.chromium.org/
1823743002
reed [Mon, 21 Mar 2016 20:25:16 +0000 (13:25 -0700)]
guard rasterizer and drawlooper setters
Need to land https://codereview.chromium.org/
1823513002/ first
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1821533002
Review URL: https://codereview.chromium.org/
1821533002
fmalita [Mon, 21 Mar 2016 20:16:51 +0000 (13:16 -0700)]
Refactor 4f gradients using trait templates
Some 4f gradient housekeeping.
1) replace <DstPtrType, ColorProfile> specialization tuples with an enum covering all dest types
(L32, S32, F16, F32)
2) group various template helpers into dest trait classes, specialized for each dest type
(2a - conflate current dst_swizzle and scale_for_dest ops into one load op)
R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1816883002
Review URL: https://codereview.chromium.org/
1816883002
halcanary [Mon, 21 Mar 2016 20:01:34 +0000 (13:01 -0700)]
SkPDF: Add SkPDFCanvas to intercept some draw calls
Motivation: this simplifies implementation at the device level.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1812063002
Review URL: https://codereview.chromium.org/
1812063002
jvanverth [Mon, 21 Mar 2016 18:46:00 +0000 (11:46 -0700)]
Minor fixes to avoid NVPR in Vulkan and provide good GrVkGpu teardown.
BUG=skia:5097
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1818093002
Review URL: https://codereview.chromium.org/
1818093002
caryclark [Mon, 21 Mar 2016 18:25:42 +0000 (11:25 -0700)]
exit computeFilters if filter width is zero
The fuzzer associated with this bug triggered an assert
when building the resize filter. I can't tell if there
is a more fundemental bug here or not.
Checking for a zero-sized filter fixes the fuzzer.
R=fmalita@chromium.org
BUG=595856
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1810333002
Review URL: https://codereview.chromium.org/
1810333002
benjaminwagner [Mon, 21 Mar 2016 17:45:01 +0000 (10:45 -0700)]
Exclude new file in Google3 build.
The new file was added in https://codereview.chromium.org/
1817633002
Review URL: https://codereview.chromium.org/
1823703002
ethannicholas [Mon, 21 Mar 2016 17:19:39 +0000 (10:19 -0700)]
unified PNG encoding between SkDrawCommand and skiaserve
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1818043003
Review URL: https://codereview.chromium.org/
1818043003
halcanary [Mon, 21 Mar 2016 17:05:23 +0000 (10:05 -0700)]
SkPDF: add drop() virtual to release resources early.
Call drop() after calling emitObject() on top-level objects. In Debug
mode, assert that each object is emited exactly once by asserting that
emitObject is never called after drop(). Same for addResources().
To make sure that top level objects don't get deleted prematurely,
SkPDFObjNumMap takes a reference.
Motivation: save RAM. Allow even earlier serialization with later
changes.
Also: Switch some SkTDArrays to SkTArrays.
BUG=skia:5087
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1790023003
Review URL: https://codereview.chromium.org/
1790023003
mtklein [Mon, 21 Mar 2016 17:04:46 +0000 (10:04 -0700)]
SkNx refresh
- rearrange a bit
- fewer macros
- hooks for all operators
- add left and right scalar operator overrides
- add +=, &=, <<=, etc.
- add SkNx_split() and SkNx_join()
- simplify the many rsqrt() and invert() options to just what we actually use
This refactoring pointed out that our float <-> int NEON conversions are not specialized, so I've implemented them. It seems nice that this is an error rather than silently falling back to serial code.
It's unclear to me if split/join want to be external, static methods, or non-static methods (SkNx_join(), Sk4f::Join(), x.join()). Time will tell?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1812233003
CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot;client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1812233003
mtklein [Mon, 21 Mar 2016 16:35:33 +0000 (09:35 -0700)]
Remove transitional explicit operator bool.
These should no longer be necessary. Android's STL should now
be sane.
TBR=reed
This just removes code.
Review URL: https://codereview.chromium.org/
1817153002
bsalomon [Mon, 21 Mar 2016 16:04:26 +0000 (09:04 -0700)]
Make the debug interface a GrGLTestInterface subclass.
The debug interface subsumes the GrDebugGL singleton which allows multiple instances.
Fixes a few issues that existed before this CL (pack alignment wasn't tracked or respected, and we weren't initializing a texture id to 0 in one GM). Apparently this is not currently run on the bots.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1812323002
Review URL: https://codereview.chromium.org/
1812323002
borenet [Mon, 21 Mar 2016 16:02:51 +0000 (09:02 -0700)]
Swarming: Ensure depot_tools is in PATH when compiling
Turns out we were "lucky" for our Linux bots which already have depot_tools in PATH. The Mac bot does have depot_tools, but it's not in PATH. Add it in the script to ensure we can always get to it.
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1823653002
Review URL: https://codereview.chromium.org/
1823653002
jbroman [Mon, 21 Mar 2016 15:38:58 +0000 (08:38 -0700)]
Make SkComposeImageFilter::onFilterImage filter the bounds given to the inner filter.
Previously, the bounds requested by the caller would be passed to both the
inner and outer filter, but since the outer filter may move pixels, this is not
necessarily sufficient to supply the pixels required by the outer filter to fill
the bounds.
Unit test included.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1813373002
Review URL: https://codereview.chromium.org/
1813373002
reed [Mon, 21 Mar 2016 15:30:19 +0000 (08:30 -0700)]
add SK_SUPPORT_LEGACY_PATHEFFECT_PTR for google3 roll fix
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1817113002
TBR=mtklein
NOTRY=True
Review URL: https://codereview.chromium.org/
1817113002