platform/upstream/libHarfBuzzSharp.git
5 years agoFix offset drift in graphite integration
Martin Hosken [Mon, 4 Mar 2019 04:12:21 +0000 (11:12 +0700)]
Fix offset drift in graphite integration

5 years agoMinor, remove .editorconfig hack
Ebrahim Byagowi [Fri, 1 Mar 2019 23:54:49 +0000 (03:24 +0330)]
Minor, remove .editorconfig hack

As vscode is going to support it soon

5 years agoMake hb_subset_input_glyph_set () actually do something.
Garret Rieger [Fri, 1 Mar 2019 01:25:05 +0000 (17:25 -0800)]
Make hb_subset_input_glyph_set () actually do something.

5 years ago[dwrite] hb_directwrite_face_create, a new API
Ebrahim Byagowi [Fri, 22 Feb 2019 09:43:42 +0000 (13:13 +0330)]
[dwrite] hb_directwrite_face_create, a new API

It makes a hb_face_t from IDWriteFontFace, useful when using
DirectWrite facilities for font selection, loading and rendering
but using harfbuzz for shaping.

5 years agoFix or document unsupported font-feature-settings
David Corbett [Tue, 19 Feb 2019 03:30:40 +0000 (22:30 -0500)]
Fix or document unsupported font-feature-settings

5 years agoRemove Forcing Diagnostic Colours from CMakeLists.txt (#1597)
Joël R. Langlois [Mon, 25 Feb 2019 20:26:58 +0000 (15:26 -0500)]
Remove Forcing Diagnostic Colours from CMakeLists.txt (#1597)

Fixes https://github.com/harfbuzz/harfbuzz/issues/1596

5 years agominor edit
Michiharu Ariza [Wed, 20 Feb 2019 21:23:12 +0000 (13:23 -0800)]
minor edit

5 years agofix crash in hb_map_t::clear()
Michiharu Ariza [Wed, 20 Feb 2019 20:43:18 +0000 (12:43 -0800)]
fix crash in hb_map_t::clear()

in case called immediately after init()

5 years ago[doc] Move hb_variation_t to hb-common section
Khaled Hosny [Tue, 19 Feb 2019 19:14:11 +0000 (21:14 +0200)]
[doc] Move hb_variation_t to hb-common section

5 years ago[doc] Move feature_t and its function to hb-common
Khaled Hosny [Tue, 19 Feb 2019 17:27:28 +0000 (19:27 +0200)]
[doc] Move feature_t and its function to hb-common

It is rather confusing to have script, language etc, in hb-common section
while feature is in hb-shape section. I keep looking for it in hb-common
section then using the API index because I can’t find it there.

5 years agoTypo (#1588)
Evgeniy Reizner [Tue, 19 Feb 2019 16:35:00 +0000 (18:35 +0200)]
Typo (#1588)

Fixed a small typo.
[skip ci]

5 years ago[doc] Document hb_feature_from_string() syntax
Khaled Hosny [Tue, 19 Feb 2019 00:23:58 +0000 (02:23 +0200)]
[doc] Document hb_feature_from_string() syntax

Copied and edited from the util option documentation. The docbook table
syntax is too verbose, but that is the best I can come up with.

5 years agoMerge pull request #1557 from harfbuzz/cff-more-arrayof-fixes
Behdad Esfahbod [Fri, 15 Feb 2019 23:54:51 +0000 (15:54 -0800)]
Merge pull request #1557 from harfbuzz/cff-more-arrayof-fixes

CFF more arrayof fixes

5 years agoMerge pull request #1583 from harfbuzz/cff-retain-gids
Behdad Esfahbod [Fri, 15 Feb 2019 23:54:13 +0000 (15:54 -0800)]
Merge pull request #1583 from harfbuzz/cff-retain-gids

[subset] Implement --retain-gids with CFF/CFF2

5 years agoMerge branch 'master' into cff-more-arrayof-fixes
Michiharu Ariza [Fri, 15 Feb 2019 22:48:10 +0000 (14:48 -0800)]
Merge branch 'master' into cff-more-arrayof-fixes

5 years agoMerge branch 'master' into cff-retain-gids
Michiharu Ariza [Fri, 15 Feb 2019 22:47:38 +0000 (14:47 -0800)]
Merge branch 'master' into cff-retain-gids

5 years agoSupport xlclang++ on AIX. (#1584)
Martin [Fri, 15 Feb 2019 18:23:46 +0000 (19:23 +0100)]
Support xlclang++ on AIX. (#1584)

5 years ago[CI] Install more packages
Behdad Esfahbod [Thu, 14 Feb 2019 19:34:28 +0000 (11:34 -0800)]
[CI] Install more packages

Wish there was a way to streamline this :(.

5 years agoMerge branch 'master' into cff-more-arrayof-fixes
Michiharu Ariza [Thu, 14 Feb 2019 18:09:19 +0000 (10:09 -0800)]
Merge branch 'master' into cff-more-arrayof-fixes

5 years agoMerge branch 'master' into cff-retain-gids
Michiharu Ariza [Thu, 14 Feb 2019 18:08:16 +0000 (10:08 -0800)]
Merge branch 'master' into cff-retain-gids

5 years ago[CI] Install wget on clang-O3-O0 bot
Behdad Esfahbod [Thu, 14 Feb 2019 07:46:17 +0000 (23:46 -0800)]
[CI] Install wget on clang-O3-O0 bot

5 years agoMinor, use a meaningful naming in template parameter (#1582)
Ebrahim Byagowi [Wed, 13 Feb 2019 20:57:01 +0000 (00:27 +0330)]
Minor, use a meaningful naming in template parameter (#1582)

5 years agoMerge branch 'master' into cff-more-arrayof-fixes
Michiharu Ariza [Wed, 13 Feb 2019 19:25:00 +0000 (11:25 -0800)]
Merge branch 'master' into cff-more-arrayof-fixes

5 years agoMerge branch 'master' into cff-retain-gids
Michiharu Ariza [Wed, 13 Feb 2019 19:24:38 +0000 (11:24 -0800)]
Merge branch 'master' into cff-retain-gids

5 years agoFix djgpp complains by tweaking templates (#1579)
Ebrahim Byagowi [Wed, 13 Feb 2019 09:28:01 +0000 (12:58 +0330)]
Fix djgpp complains by tweaking templates (#1579)

For some reasons djgpp doesn't understand "unsigned int" can be same
with one of uint*_t anyway so lets do that for it explicitly.

Just to note, our CI's djgpp is based GCC 7.2.0 and isn't old.

5 years agoMerge branch 'cff-retain-gids' of https://github.com/harfbuzz/harfbuzz into cff-retai...
Michiharu Ariza [Tue, 12 Feb 2019 23:10:59 +0000 (15:10 -0800)]
Merge branch 'cff-retain-gids' of https://github.com/harfbuzz/harfbuzz into cff-retain-gids

5 years agoMerge branch 'master' into cff-retain-gids
Michiharu Ariza [Tue, 12 Feb 2019 23:10:50 +0000 (15:10 -0800)]
Merge branch 'master' into cff-retain-gids

5 years agotweaked --desubroutinize to remove hintmask only subrs
Michiharu Ariza [Tue, 12 Feb 2019 23:10:43 +0000 (15:10 -0800)]
tweaked --desubroutinize to remove hintmask only subrs

5 years agoMerge branch 'master' into cff-retain-gids
Michiharu Ariza [Mon, 11 Feb 2019 22:25:21 +0000 (14:25 -0800)]
Merge branch 'master' into cff-retain-gids

5 years agoMerge branch 'master' into cff-more-arrayof-fixes
Michiharu Ariza [Mon, 11 Feb 2019 22:16:25 +0000 (14:16 -0800)]
Merge branch 'master' into cff-more-arrayof-fixes

5 years agohb-coretext.cc: remove TARGET_OS_MAC from test (#1578)
Ken [Mon, 11 Feb 2019 07:46:05 +0000 (23:46 -0800)]
hb-coretext.cc: remove TARGET_OS_MAC from test (#1578)

it is always true when building on APPLE systems
and this file only builds on APPLE systems

5 years ago[ci] Install 'base-devel' on ArchLinux CI bot
Ebrahim Byagowi [Sat, 9 Feb 2019 21:38:05 +0000 (01:08 +0330)]
[ci] Install 'base-devel' on ArchLinux CI bot

5 years ago[ci] Install 'which' in ArchLinux bot
Ebrahim Byagowi [Sat, 9 Feb 2019 13:28:02 +0000 (16:58 +0330)]
[ci] Install 'which' in ArchLinux bot

5 years ago[ci] Speculative fix for Alpine and ArchLinux bots
Ebrahim Byagowi [Sat, 9 Feb 2019 13:03:28 +0000 (16:33 +0330)]
[ci] Speculative fix for Alpine and ArchLinux bots

5 years agoMerge branch 'master' into cff-retain-gids
Michiharu Ariza [Fri, 8 Feb 2019 22:44:20 +0000 (14:44 -0800)]
Merge branch 'master' into cff-retain-gids

5 years agoUpdated expected/cff-japanese fonts with retained FDs
Michiharu Ariza [Fri, 8 Feb 2019 22:44:13 +0000 (14:44 -0800)]
Updated expected/cff-japanese fonts with retained FDs

5 years ago[ci] Disable the just added bot
Ebrahim Byagowi [Fri, 8 Feb 2019 12:00:17 +0000 (15:30 +0330)]
[ci] Disable the just added bot

Doesn't play well with CircleCI apparently

https://circleci.com/gh/harfbuzz/harfbuzz/74289

5 years ago[ci] Add a Void Linux bot
Ebrahim Byagowi [Fri, 8 Feb 2019 11:48:26 +0000 (15:18 +0330)]
[ci] Add a Void Linux bot

https://voidlinux.org/ is yet another and different distro written from scratch, thus completely eligible to have a bot here!

Seriously however not that useful yet however but I will try to overload it other tasks later, like our other bots.

No test yet also, couldn't install cairo-devel, will try to fix that later.

Their harfbuzz package source: https://github.com/void-linux/void-packages/blob/master/srcpkgs/harfbuzz/template

5 years agoretain FDSelect & FDArray with --retain-gids
Michiharu Ariza [Thu, 7 Feb 2019 23:32:32 +0000 (15:32 -0800)]
retain FDSelect & FDArray with --retain-gids

so in sync with fonttools behavior

5 years agoMerge branch 'master' into cff-more-arrayof-fixes
Michiharu Ariza [Thu, 7 Feb 2019 18:29:40 +0000 (10:29 -0800)]
Merge branch 'master' into cff-more-arrayof-fixes

5 years agoMerge branch 'master' into cff-retain-gids
Michiharu Ariza [Thu, 7 Feb 2019 18:28:13 +0000 (10:28 -0800)]
Merge branch 'master' into cff-retain-gids

5 years agominor change
Michiharu Ariza [Thu, 7 Feb 2019 18:27:43 +0000 (10:27 -0800)]
minor change

5 years agoMerge pull request #1571 from kencu/cleanostests
Behdad Esfahbod [Wed, 6 Feb 2019 21:36:52 +0000 (13:36 -0800)]
Merge pull request #1571 from kencu/cleanostests

hb-coretext.cc: clean up macosx test

5 years agohb-coretext.cc: clean up macosx test
Ken Cunningham [Wed, 6 Feb 2019 04:26:49 +0000 (20:26 -0800)]
hb-coretext.cc: clean up macosx test

TARGET_OS_OSX was introduced only in late OS versions
so always returns as "0" on older systems.

if !TARGET_OS_IPHONE can work, as it returns as !0 on older
systems where TARGET_OS_IPHONE is not defined, but is not
specific

if TARGET_OS_MAC && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
is both specific and accurate on all systems.

5 years agoseparate CFF from TrueType in full font tests
Michiharu Ariza [Mon, 4 Feb 2019 19:28:15 +0000 (11:28 -0800)]
separate CFF from TrueType in full font tests

5 years agoremoved unused test data
Michiharu Ariza [Fri, 1 Feb 2019 23:58:03 +0000 (15:58 -0800)]
removed unused test data

5 years agoMerge branch 'master' into cff-retain-gids
Michiharu Ariza [Fri, 1 Feb 2019 22:50:34 +0000 (14:50 -0800)]
Merge branch 'master' into cff-retain-gids

5 years agoadded desubroutinize & retain-gids full test cases with CFF fonts
Michiharu Ariza [Fri, 1 Feb 2019 22:50:01 +0000 (14:50 -0800)]
added desubroutinize & retain-gids full test cases with CFF fonts

and CFF retain-gids fixes

5 years agoImplement subset --regain-gids option with CFF1/2
Michiharu Ariza [Thu, 31 Jan 2019 22:16:37 +0000 (14:16 -0800)]
Implement subset --regain-gids option with CFF1/2

along with api tests & expected results

5 years agoAdjust hb_is_signed<>
Behdad Esfahbod [Thu, 31 Jan 2019 21:56:58 +0000 (13:56 -0800)]
Adjust hb_is_signed<>

Fixes https://github.com/harfbuzz/harfbuzz/issues/1535

5 years agoRemove stale comment
Behdad Esfahbod [Thu, 31 Jan 2019 21:49:18 +0000 (13:49 -0800)]
Remove stale comment

5 years agoMerge branch 'master' into cff-more-arrayof-fixes
Michiharu Ariza [Thu, 31 Jan 2019 20:54:36 +0000 (12:54 -0800)]
Merge branch 'master' into cff-more-arrayof-fixes

5 years agoMerge pull request #1567 from googlefonts/fuzzer
Behdad Esfahbod [Wed, 30 Jan 2019 23:36:57 +0000 (18:36 -0500)]
Merge pull request #1567 from googlefonts/fuzzer

[subset] Update the subset fuzzer to get  options to use from test case.

5 years ago[subset] Update the subset fuzzer to determine which options to use based on data...
Garret Rieger [Wed, 30 Jan 2019 23:23:19 +0000 (15:23 -0800)]
[subset] Update the subset fuzzer to determine which options to use based on data in the fuzzing test case.
Add support for toggling retain_gids.

5 years ago[configure] Fix up
Behdad Esfahbod [Wed, 30 Jan 2019 23:10:23 +0000 (15:10 -0800)]
[configure] Fix up

5 years ago[configure] Print compiler version info in report
Behdad Esfahbod [Wed, 30 Jan 2019 23:06:22 +0000 (15:06 -0800)]
[configure] Print compiler version info in report

5 years agoMerge pull request #1564 from googlefonts/retain_gids
Behdad Esfahbod [Wed, 30 Jan 2019 22:17:59 +0000 (17:17 -0500)]
Merge pull request #1564 from googlefonts/retain_gids

[subset] Add --retain-gids option to the subsetter.

5 years ago2.3.1
Behdad Esfahbod [Wed, 30 Jan 2019 21:54:15 +0000 (13:54 -0800)]
2.3.1

5 years ago[subset] Add expected files for retain-gids integration tests.
Garret Rieger [Tue, 29 Jan 2019 02:12:19 +0000 (18:12 -0800)]
[subset] Add expected files for retain-gids integration tests.

5 years ago[subset] For retain gids don't truncate glyphs past the highest requested subset...
Garret Rieger [Tue, 29 Jan 2019 02:10:56 +0000 (18:10 -0800)]
[subset] For retain gids don't truncate glyphs past the highest requested subset glyph.

5 years ago[subset] Add retain-gids option to hb-subset executable.
Garret Rieger [Tue, 29 Jan 2019 01:43:42 +0000 (17:43 -0800)]
[subset] Add retain-gids option to hb-subset executable.

5 years ago[subset] Add some subsetting integration tests covering retain gids.
Garret Rieger [Tue, 29 Jan 2019 01:43:11 +0000 (17:43 -0800)]
[subset] Add some subsetting integration tests covering retain gids.

5 years ago[subset] A few small fixes for the new subset plan api.
Garret Rieger [Tue, 29 Jan 2019 01:05:04 +0000 (17:05 -0800)]
[subset] A few small fixes for the new subset plan api.

5 years ago[subset] Update hb-subset-plan.cc to match hb-subset-plan.hh.
Garret Rieger [Tue, 29 Jan 2019 00:59:15 +0000 (16:59 -0800)]
[subset] Update hb-subset-plan.cc to match hb-subset-plan.hh.

5 years ago[subset] Update hb-subset-glyf.cc to use new hb-subset-plan API.
Garret Rieger [Tue, 29 Jan 2019 00:53:01 +0000 (16:53 -0800)]
[subset] Update hb-subset-glyf.cc to use new hb-subset-plan API.

5 years ago[subset] Update gsub to use glyphset() method of subset plan.
Garret Rieger [Tue, 29 Jan 2019 00:51:27 +0000 (16:51 -0800)]
[subset] Update gsub to use glyphset() method of subset plan.

5 years ago[subset] Correct maxp num glyph's to use new subset plan method.
Garret Rieger [Tue, 29 Jan 2019 00:50:56 +0000 (16:50 -0800)]
[subset] Correct maxp num glyph's to use new subset plan method.

5 years ago[subset] Re-add glyphs array to subset plan, with new name 'glyphs_deprecated'. Switc...
Garret Rieger [Tue, 29 Jan 2019 00:50:20 +0000 (16:50 -0800)]
[subset] Re-add glyphs array to subset plan, with new name 'glyphs_deprecated'. Switch CFF subsetting to use it.

5 years agoRe-implement HMTX/VMTX subsetting. Update it to support glyph renumbering and simplif...
Garret Rieger [Tue, 29 Jan 2019 00:15:06 +0000 (16:15 -0800)]
Re-implement HMTX/VMTX subsetting. Update it to support glyph renumbering and simplify the implementation.

5 years agoUpdate hb-ot-vorg-table and hb-ot-layout-common to use the updated subset plan api.
Garret Rieger [Sat, 26 Jan 2019 02:04:41 +0000 (18:04 -0800)]
Update hb-ot-vorg-table and hb-ot-layout-common to use the updated subset plan api.

5 years agoRemove glyph array from subset plan, make num_glyphs and glyphset private.
Garret Rieger [Sat, 26 Jan 2019 02:03:47 +0000 (18:03 -0800)]
Remove glyph array from subset plan, make num_glyphs and glyphset private.

5 years ago[subset] Fix hdmx subsetting when retain gids is enabled.
Garret Rieger [Sat, 19 Jan 2019 02:33:21 +0000 (18:33 -0800)]
[subset] Fix hdmx subsetting when retain gids is enabled.

5 years ago[subset] Compute num_glyphs during subset plan construction.
Garret Rieger [Sat, 19 Jan 2019 01:49:35 +0000 (17:49 -0800)]
[subset] Compute num_glyphs during subset plan construction.
Update maxp to use the correct num glyphs.

5 years ago[subset] Add unit test for glyf subsetting and retain gids.
Garret Rieger [Sat, 19 Jan 2019 01:36:32 +0000 (17:36 -0800)]
[subset] Add unit test for glyf subsetting and retain gids.

5 years ago[subset] fix failure to init instruction ranges values for an invalid glyph.
Garret Rieger [Sat, 19 Jan 2019 00:41:08 +0000 (16:41 -0800)]
[subset] fix failure to init instruction ranges values for an invalid glyph.

5 years ago[subset] Do some refactoring in hb-subset-glyf.cc.
Garret Rieger [Fri, 18 Jan 2019 23:11:26 +0000 (15:11 -0800)]
[subset] Do some refactoring in hb-subset-glyf.cc.
- Extract code out into helper methods in several places.
- Bundle loca address, size and is short into a struct.

5 years agoAdd retain_gids option to subset input. Update glyf and loca handling to respect...
Garret Rieger [Fri, 18 Jan 2019 02:55:56 +0000 (18:55 -0800)]
Add retain_gids option to subset input. Update glyf and loca handling to respect retain_gids.

5 years agoMerge branch 'master' into cff-more-arrayof-fixes
Michiharu Ariza [Tue, 29 Jan 2019 20:19:57 +0000 (12:19 -0800)]
Merge branch 'master' into cff-more-arrayof-fixes

5 years ago[CI] Peg CircleCI badge link to master branch
Behdad Esfahbod [Tue, 29 Jan 2019 01:47:58 +0000 (20:47 -0500)]
[CI] Peg CircleCI badge link to master branch

[skip ci]

5 years ago[ci] Peg build status badges to master branch
Behdad Esfahbod [Tue, 29 Jan 2019 01:43:43 +0000 (20:43 -0500)]
[ci] Peg build status badges to master branch

[skip ci]

5 years agoSwitch README / README.md
Behdad Esfahbod [Tue, 29 Jan 2019 01:38:15 +0000 (20:38 -0500)]
Switch README / README.md

[skip ci]

5 years ago[uniscribe] Whitelist function type cast
Behdad Esfahbod [Mon, 28 Jan 2019 19:15:18 +0000 (14:15 -0500)]
[uniscribe] Whitelist function type cast

5 years agoFix sign comparison error
Behdad Esfahbod [Mon, 28 Jan 2019 19:12:41 +0000 (14:12 -0500)]
Fix sign comparison error

5 years agoFix warning
Behdad Esfahbod [Mon, 28 Jan 2019 19:09:59 +0000 (14:09 -0500)]
Fix warning

c:\projects\harfbuzz\src\hb-ot-color-cbdt-table.hh(59): warning C4146: unary minus operator applied to unsigned type, result still unsigned [C:\projects\harfbuzz\build\harfbuzz.vcxproj]

5 years ago[pragma] Silence MSVC unknown-pragma warning
Behdad Esfahbod [Mon, 28 Jan 2019 19:09:45 +0000 (14:09 -0500)]
[pragma] Silence MSVC unknown-pragma warning

5 years agoFix -Wcast-function-type warnings in util/ with gcc 4.8
Behdad Esfahbod [Sat, 26 Jan 2019 13:04:51 +0000 (14:04 +0100)]
Fix -Wcast-function-type warnings in util/ with gcc 4.8

5 years agoFix mac test
Behdad Esfahbod [Fri, 25 Jan 2019 15:11:45 +0000 (16:11 +0100)]
Fix mac test

5 years agoMore static constexpr
Behdad Esfahbod [Fri, 25 Jan 2019 15:08:25 +0000 (16:08 +0100)]
More static constexpr

5 years ago[AAT] Add test for recent Ligature stack fix, using Zapfino on Mac
Behdad Esfahbod [Fri, 25 Jan 2019 14:11:47 +0000 (15:11 +0100)]
[AAT] Add test for recent Ligature stack fix, using Zapfino on Mac

5 years agoMerge branch 'master' into cff-more-arrayof-fixes
Michiharu Ariza [Thu, 24 Jan 2019 21:19:18 +0000 (13:19 -0800)]
Merge branch 'master' into cff-more-arrayof-fixes

5 years ago[AAT] Minor sign
Behdad Esfahbod [Thu, 24 Jan 2019 17:16:17 +0000 (18:16 +0100)]
[AAT] Minor sign

5 years ago[AAT] Use a ring buffer for ligature stack
Behdad Esfahbod [Thu, 24 Jan 2019 17:12:25 +0000 (18:12 +0100)]
[AAT] Use a ring buffer for ligature stack

I think Apple does very similarly, but probably with a stack size of 16.
We do it with a stack size that is currently set to 64.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1531

5 years agoWhitespace
Behdad Esfahbod [Thu, 24 Jan 2019 17:06:17 +0000 (18:06 +0100)]
Whitespace

5 years ago[AAT] Handle transition errors during machine operation
Behdad Esfahbod [Thu, 24 Jan 2019 17:01:07 +0000 (18:01 +0100)]
[AAT] Handle transition errors during machine operation

Before we used to give up.  Now, just ignore error and continue processing.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1531

5 years agoMerge branch 'master' into cff-more-arrayof-fixes
Michiharu Ariza [Thu, 24 Jan 2019 16:53:28 +0000 (08:53 -0800)]
Merge branch 'master' into cff-more-arrayof-fixes

5 years ago[AAT] Ignore machine errors and continue
Behdad Esfahbod [Thu, 24 Jan 2019 16:23:11 +0000 (17:23 +0100)]
[AAT] Ignore machine errors and continue

5 years ago[AAT] Minor
Behdad Esfahbod [Thu, 24 Jan 2019 16:21:41 +0000 (17:21 +0100)]
[AAT] Minor

5 years ago[AAT] Handle out-of-bounds classes
Behdad Esfahbod [Thu, 24 Jan 2019 16:17:00 +0000 (17:17 +0100)]
[AAT] Handle out-of-bounds classes

5 years ago[AAT] Minor
Behdad Esfahbod [Thu, 24 Jan 2019 16:10:12 +0000 (17:10 +0100)]
[AAT] Minor

5 years ago[AAT] Minor
Behdad Esfahbod [Thu, 24 Jan 2019 16:06:16 +0000 (17:06 +0100)]
[AAT] Minor