sdk/emulator/qemu.git
15 years agoFix sys-queue.h conflict for good
Blue Swirl [Sat, 12 Sep 2009 07:36:22 +0000 (07:36 +0000)]
Fix sys-queue.h conflict for good

Problem: Our file sys-queue.h is a copy of the BSD file, but there are
some additions and it's not entirely compatible. Because of that, there have
been conflicts with system headers on BSD systems. Some hacks have been
introduced in the commits 15cc9235840a22c289edbe064a9b3c19c5f49896,
f40d753718c72693c5f520f0d9899f6e50395e94,
96555a96d724016e13190b28cffa3bc929ac60dc and
3990d09adf4463eca200ad964cc55643c33feb50 but the fixes were fragile.

Solution: Avoid the conflict entirely by renaming the functions and the
file. Revert the previous hacks.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoTry to fix BSD breakage by 806b60248218bd5f74a8b070f5a99a864e8e51c6
Blue Swirl [Sat, 12 Sep 2009 06:19:16 +0000 (06:19 +0000)]
Try to fix BSD breakage by 806b60248218bd5f74a8b070f5a99a864e8e51c6

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoInclude sys-queue.h early to override system queue definitions on BSD
Blue Swirl [Sat, 12 Sep 2009 06:19:15 +0000 (06:19 +0000)]
Include sys-queue.h early to override system queue definitions on BSD

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoUnbreak BSD: use qemu_fdatasync instead of fdatasync
Blue Swirl [Sat, 12 Sep 2009 06:19:14 +0000 (06:19 +0000)]
Unbreak BSD: use qemu_fdatasync instead of fdatasync

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoUse proper format conversion specifier when printing size_t value
malc [Fri, 11 Sep 2009 23:18:18 +0000 (03:18 +0400)]
Use proper format conversion specifier when printing size_t value

And untabify this while we are at it.

Signed-off-by: malc <av1474@comtv.ru>
15 years agoaudio: remove lsbindex/popcount in favour of host-utils's ctz32
malc [Fri, 11 Sep 2009 22:39:29 +0000 (02:39 +0400)]
audio: remove lsbindex/popcount in favour of host-utils's ctz32

Signed-off-by: malc <av1474@comtv.ru>
15 years agoalsa: poll mode handling
malc [Fri, 11 Sep 2009 22:29:25 +0000 (02:29 +0400)]
alsa: poll mode handling

Signed-off-by: malc <av1474@comtv.ru>
15 years agooss: poll mode handling
malc [Fri, 11 Sep 2009 22:29:16 +0000 (02:29 +0400)]
oss: poll mode handling

Signed-off-by: malc <av1474@comtv.ru>
15 years agoaudio: poll mode infrastructure
malc [Fri, 11 Sep 2009 22:28:45 +0000 (02:28 +0400)]
audio: poll mode infrastructure

Signed-off-by: malc <av1474@comtv.ru>
15 years agogus: Do not manually free the state, qdev does it for us
malc [Fri, 11 Sep 2009 06:27:41 +0000 (10:27 +0400)]
gus: Do not manually free the state, qdev does it for us

Signed-off-by: malc <av1474@comtv.ru>
15 years agooss: Unbreak mmaping the ability to mmap oss fd on Linux
malc [Fri, 11 Sep 2009 06:13:55 +0000 (10:13 +0400)]
oss: Unbreak mmaping the ability to mmap oss fd on Linux

Signed-off-by: malc <av1474@comtv.ru>
15 years agokvm_arch_get_registers() shouldn't be called directly
Gleb Natapov [Thu, 10 Sep 2009 11:32:55 +0000 (14:32 +0300)]
kvm_arch_get_registers() shouldn't be called directly

Direct call to kvm_arch_get_registers() bypass logic in
cpu_synchronize_state()

Signed-off-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port cirrus_vga device
Juan Quintela [Thu, 10 Sep 2009 01:04:47 +0000 (03:04 +0200)]
vmstate: port cirrus_vga device

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port serial device
Juan Quintela [Thu, 10 Sep 2009 01:04:46 +0000 (03:04 +0200)]
vmstate: port serial device

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port hpet device
Juan Quintela [Thu, 10 Sep 2009 01:04:45 +0000 (03:04 +0200)]
vmstate: port hpet device

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agohpet: it is imposible that qemu_timer field is NULL at this point
Juan Quintela [Thu, 10 Sep 2009 01:04:44 +0000 (03:04 +0200)]
hpet: it is imposible that qemu_timer field is NULL at this point

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port ioapic device
Juan Quintela [Thu, 10 Sep 2009 01:04:43 +0000 (03:04 +0200)]
vmstate: port ioapic device

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: add uint64 array support
Juan Quintela [Thu, 10 Sep 2009 01:04:42 +0000 (03:04 +0200)]
vmstate: add uint64 array support

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port pckbd device
Juan Quintela [Thu, 10 Sep 2009 01:04:41 +0000 (03:04 +0200)]
vmstate: port pckbd device

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port vmmouse device
Juan Quintela [Thu, 10 Sep 2009 01:04:40 +0000 (03:04 +0200)]
vmstate: port vmmouse device

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port dma device
Juan Quintela [Thu, 10 Sep 2009 01:04:39 +0000 (03:04 +0200)]
vmstate: port dma device

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: add support for arrays of uint16_t
Juan Quintela [Thu, 10 Sep 2009 01:04:38 +0000 (03:04 +0200)]
vmstate: add support for arrays of uint16_t

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port fdc device
Juan Quintela [Thu, 10 Sep 2009 01:04:37 +0000 (03:04 +0200)]
vmstate: port fdc device

We can't move fifo back to an embeded array because it needs to be aligned

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: add support for uint8_t equal
Juan Quintela [Thu, 10 Sep 2009 01:04:36 +0000 (03:04 +0200)]
vmstate: add support for uint8_t equal

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port i8259 device
Juan Quintela [Thu, 10 Sep 2009 01:04:35 +0000 (03:04 +0200)]
vmstate: port i8259 device

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port fw_cfg device
Juan Quintela [Thu, 10 Sep 2009 01:04:34 +0000 (03:04 +0200)]
vmstate: port fw_cfg device

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: port cpu_comon
Juan Quintela [Thu, 10 Sep 2009 01:04:33 +0000 (03:04 +0200)]
vmstate: port cpu_comon

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: Add pre/post_save() hooks
Juan Quintela [Thu, 10 Sep 2009 01:04:32 +0000 (03:04 +0200)]
vmstate: Add pre/post_save() hooks

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: Add pre_load() hook
Juan Quintela [Thu, 10 Sep 2009 01:04:31 +0000 (03:04 +0200)]
vmstate: Add pre_load() hook

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: rename run_after_load() -> post_load()
Juan Quintela [Thu, 10 Sep 2009 01:04:30 +0000 (03:04 +0200)]
vmstate: rename run_after_load() -> post_load()

This naming was used in kvm tree, and is easier to remember

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmstate: add sensible arguments to vmstate_unregister()
Juan Quintela [Thu, 10 Sep 2009 01:04:29 +0000 (03:04 +0200)]
vmstate: add sensible arguments to vmstate_unregister()

vmsd alone is not enugh, because we can have several structs saved with the same description (vmsd).

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoMake get_ticks_per_sec() a static inline
Anthony Liguori [Fri, 11 Sep 2009 15:28:26 +0000 (10:28 -0500)]
Make get_ticks_per_sec() a static inline

ticks_per_sec is a constant.  There's no need to store it as a variable as it
never changes since our time is based on units.

Convert get_ticks_per_sec() to a static inline and move the constant into
qemu-timer.h.  Remove all references to QEMU_TIMER_BASE so that we consistently
use this interface.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agotimers: move them to VMState
Juan Quintela [Thu, 10 Sep 2009 01:04:28 +0000 (03:04 +0200)]
timers: move them to VMState

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agotimers: Createt TimersState and put all timers state there
Juan Quintela [Thu, 10 Sep 2009 01:04:27 +0000 (03:04 +0200)]
timers: Createt TimersState and put all timers state there

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoUnexport ticks_per_sec variable. Create get_ticks_per_sec() function
Juan Quintela [Thu, 10 Sep 2009 01:04:26 +0000 (03:04 +0200)]
Unexport ticks_per_sec variable. Create get_ticks_per_sec() function

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agotimers: remove useless check
Juan Quintela [Thu, 10 Sep 2009 01:04:25 +0000 (03:04 +0200)]
timers: remove useless check

loadvm_state is called from: vl.c during startup, vmstart() is called after finishing loading.  The other caller do_loadvm() does the call after a vm_stop().  At both places where we can be saving state we are stoped a few lines before

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoRemove SaveVM v2 support
Juan Quintela [Thu, 10 Sep 2009 01:04:24 +0000 (03:04 +0200)]
Remove SaveVM v2 support

In previosu series I remove v2 support for RAM (that was the version that was
supported when SaveVM v3 appeared).  Now we can't load RAM for any image saved in SaveVM v2, we can as well remove SaveVM v2 entirely.

Note: That SaveVM RAM was at v2 when General SaveVM support went from v2 to v3 makes talking about versions confusing at least

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoram: Remove SaveVM Version 2 support
Juan Quintela [Thu, 10 Sep 2009 01:04:23 +0000 (03:04 +0200)]
ram: Remove SaveVM Version 2 support

It don't work.  It fails in this check

        if (qemu_get_be32(f) != last_ram_offset)

With 512MB of ram, values were for me:

v = 20c00000 last_ram_offset = 20840000

Last time that some code changed that was this one.

    commit 94a6b54fd6d2d3321066cb4db7abeeb417af9365
    Implement dynamic guest ram allocation.
    (I.e. it has been broken since at least April)

Going back to the previous commit, ram load correctly, but vga screen gets
corrupted and ide don't load correctly.  At this point I decide that removing
support is the only viable thing.

The last user of the ram_compress_* were RAM_SAVE_FLAG_FULL flag, but
that flag was never ever been stored in an image. Mark the flag obsolete
and remove the functions.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoram: remove support for loading v1
Juan Quintela [Thu, 10 Sep 2009 01:04:22 +0000 (03:04 +0200)]
ram: remove support for loading v1

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agomove mux focus field from CharDriverState to MuxDriver
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:55 +0000 (10:58 +0200)]
move mux focus field from CharDriverState to MuxDriver

Now that monitor stopped using focus we can make it internal
to the mux driver.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agomonitor: fix muxing
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:54 +0000 (10:58 +0200)]
monitor: fix muxing

make the mux driver send mux_in and mux_out events when switching
focus while hooking up more handlers.

stop using CharDriverState->focus in monitor.c, track state using
the mux events instead.  This also removes the implicit assumtion
that a muxed monitor allways has mux channel 0.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqdev: add parser for chardev properties
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:53 +0000 (10:58 +0200)]
qdev: add parser for chardev properties

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoAllow -serial chardev:<name>
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:52 +0000 (10:58 +0200)]
Allow -serial chardev:<name>

Lets put -chardev into use now.  With this patch applied chardev:name is
accepted as chardev specification everywhere, i.e. now you can:

-chardev stdio,id=ttyS0
-serial chardev:ttyS0

which does the same as '-serial stdio".

Muxing can be done this way:

-chardev stdio,id=mux,mux=on
-serial chardev:mux
-monitor chardev:mux

You can mux more than two streams.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert udp chardev to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:51 +0000 (10:58 +0200)]
convert udp chardev to QemuOpts.

While being at it: create a new inet_dgram_opts() function for udp setup,
so udp can handle IPv6 now.

new cmd line syntax:
    -chardev udp,id=name,host=remotehost,port=remoteport,\
localaddr=bindaddr,localport=bindport

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert mux chardev to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:50 +0000 (10:58 +0200)]
convert mux chardev to QemuOpts.

new cmd line syntax:  you can add mux=1 to any chardev to enable muxing,
then attach it multiple times, like this:

-chardev pty,name=mux,mux=on

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert vc chardev to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:49 +0000 (10:58 +0200)]
convert vc chardev to QemuOpts.

new cmd line syntax:
    -chardev vc,id=name
    -chardev vc,id=name,width=pixels,height=pixels
    -chardev vc,id=name,cols=chars,rows=chars

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert tty + parport chardevs to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:48 +0000 (10:58 +0200)]
convert tty + parport chardevs to QemuOpts.

new cmd line syntax:
    -chardev tty,id=name,path=/dev/tty*
    -chardev parport,id=name,path=/dev/parport*

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert windows console chardev to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:47 +0000 (10:58 +0200)]
convert windows console chardev to QemuOpts.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert braille chardev to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:46 +0000 (10:58 +0200)]
convert braille chardev to QemuOpts.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert msmouse chardev to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:45 +0000 (10:58 +0200)]
convert msmouse chardev to QemuOpts.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert stdio chardev to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:44 +0000 (10:58 +0200)]
convert stdio chardev to QemuOpts.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert pty chardev to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:43 +0000 (10:58 +0200)]
convert pty chardev to QemuOpts.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert unix+tcp chardevs to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:42 +0000 (10:58 +0200)]
convert unix+tcp chardevs to QemuOpts.

new cmd line syntax:
  unix socket:
    -chardev socket,id=name,path=/path/to/socket
  tcp socket:
    -chardev socket,id=name,host=hostaddr|ipaddr,port=portnr

server and nowait options work as usual.  Alternatively you can use
server=[on|off] + wait=[on|off] syntax.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agosockets: add inet_listen_opts
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:41 +0000 (10:58 +0200)]
sockets: add inet_listen_opts

Add inet_listen_opts().  Does the same as inet_listen(), but uses
QemuOpts.  inet_listen() is a compatibility wrapper for
inet_listen_opts() now and should go away some day.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agosockets: add inet_connect_opts
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:40 +0000 (10:58 +0200)]
sockets: add inet_connect_opts

Add inet_connect_opts().  Does the same as inet_connect(), but uses
QemuOpts.  inet_connect() is a compatibility wrapper for
inet_connect_opts() now and should go away some day.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agosockets: add unix_*_opts for windows.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:39 +0000 (10:58 +0200)]
sockets: add unix_*_opts for windows.

Add unix_*_opts function dummys for windows.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agosockets: add unix_listen_opts
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:38 +0000 (10:58 +0200)]
sockets: add unix_listen_opts

Add unix_listen_opts().  Does the same as unix_listen(), but uses
QemuOpts.  unix_listen() is a compatibility wrapper for
unix_listen_opts() now and should go away some day.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agosockets: add unix_connect_opts
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:37 +0000 (10:58 +0200)]
sockets: add unix_connect_opts

Add unix_connect_opts().  Does the same as unix_connect(), but uses
QemuOpts.  unix_connect() is a compatibility wrapper for
unix_connect_opts() now and should go away some day.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoconvert file+pipe chardevs to QemuOpts.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:36 +0000 (10:58 +0200)]
convert file+pipe chardevs to QemuOpts.

new cmd line syntax:
    -chardev file,id=name,path=/path/to/file
    -chardev pipe,id=name,path=/path/to/pipe

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoswitch chardev to QemuOpts: infrastructure, null device
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:35 +0000 (10:58 +0200)]
switch chardev to QemuOpts: infrastructure, null device

start switching chardevs to QemuOpts.  This patch adds the
infrastructure and converts the null device.

The patch brings two new functions:

qemu_chr_open_opts()
same as qemu_chr_open(), but uses QemuOpts instead of a
option char string.

qemu_chr_parse_compat()
accepts a traditional chardev option string, returns the
corresponding QemuOpts instance, to handle backward
compatibility.

The patch also adds a new -chardev switch which can be used to create
named+unconnected chardevs, like this:

-chardev null,id=test

This uses the new qemu_chr_open_opts.  Thus with this patch alone only
the null device works.  The other devices will follow ...

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqemu-option.h include protectors
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:34 +0000 (10:58 +0200)]
qemu-option.h include protectors

qemu-option.h has no protection against including it twice.
This patch adds the usual "#ifndef header" bits.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoQemuOpts: split option parser into two functions.
Gerd Hoffmann [Thu, 10 Sep 2009 08:58:33 +0000 (10:58 +0200)]
QemuOpts: split option parser into two functions.

looking for id= and creating a new QemuOpts instance is splitted from
the actual option parser code now, so the parser can be called from
other contexts too.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqdev: Fix i6300 upcast
Markus Armbruster [Fri, 4 Sep 2009 22:13:04 +0000 (00:13 +0200)]
qdev: Fix i6300 upcast

Use DO_UPCAST() instead of container_of() to go from PCIDevice to
I6300State.  This ensures that PCIDevice is the first member of struct
I6300State.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoVirtIO: Fix QEMU crash during Windows PNP tests
Yan Vugenfirer [Tue, 8 Sep 2009 14:49:41 +0000 (10:49 -0400)]
VirtIO: Fix QEMU crash during Windows PNP tests

Hello,

In some cases bus driver can deassert "bus master" bit in PCI command
register. The driver will no longer be able to update related registers in
the device. Eventually it will cause QEMU to exit in "virtqueue_num_heads"
function.

Attached path that fixes the described issue.

Best regards,
Yan Vugenfirer.

>From 3fdafbdfad676ec8479dc073cff70bf356868bfe Mon Sep 17 00:00:00 2001
From: Yan Vugenfirer <yvugenfi@redhat.com>
Date: Tue, 8 Sep 2009 10:08:14 -0400
Subject: [PATCH] VirtIO: Fix QEMU crash during Windows PNP tests

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovirtio-blk: add volatile writecache feature
Christoph Hellwig [Fri, 4 Sep 2009 17:02:23 +0000 (19:02 +0200)]
virtio-blk: add volatile writecache feature

Add a new VIRTIO_BLK_F_WCACHE feature to virtio-blk to indicate that we have
a volatile write cache that needs controlled flushing.  Implement a
VIRTIO_BLK_T_FLUSH operation to flush it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoide: use bdrv_aio_flush
Christoph Hellwig [Fri, 4 Sep 2009 17:02:06 +0000 (19:02 +0200)]
ide: use bdrv_aio_flush

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoblock: add aio_flush operation
Christoph Hellwig [Fri, 4 Sep 2009 17:01:49 +0000 (19:01 +0200)]
block: add aio_flush operation

Instead stalling the VCPU while serving a cache flush try to do it
asynchronously.  Use our good old helper thread pool to issue an
asynchronous fdatasync for raw-posix.  Note that while Linux AIO
implements a fdatasync operation it is not useful for us because
it isn't actually implement in asynchronous fashion.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoblock: use fdatasync instead of fsync if possible
Christoph Hellwig [Fri, 4 Sep 2009 17:01:32 +0000 (19:01 +0200)]
block: use fdatasync instead of fsync if possible

If we are flushing the caches for our image files we only care about the
data (including the metadata required for accessing it) but not things
like timestamp updates.  So try to use fdatasync instead of fsync to
implement the flush operations.

Unfortunately many operating systems still do not support fdatasync,
so we add a qemu_fdatasync wrapper that uses fdatasync if available
as per the _POSIX_SYNCHRONIZED_IO feature macro or fsync otherwise.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoblock: add enable_write_cache flag
Christoph Hellwig [Fri, 4 Sep 2009 17:01:15 +0000 (19:01 +0200)]
block: add enable_write_cache flag

Add a enable_write_cache flag in the block driver state, and use it to
decide if we claim to have a volatile write cache that needs controlled
flushing from the guest.  The flag is off if cache=writethrough is
defined because O_DSYNC guarantees that every write goes to stable
storage, and it is on for cache=none and cache=writeback.

Both scsi-disk and ide now use the new flage, changing from their
defaults of always off (ide) or always on (scsi-disk).

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqemu: init all queues to NO_VECTOR value
Michael S. Tsirkin [Mon, 7 Sep 2009 18:20:15 +0000 (21:20 +0300)]
qemu: init all queues to NO_VECTOR value

initialize vectors for all vqs to VIRTIO_NO_VECTOR rather than 0 which
is a valid vector. This fixes migration which happened before driver
was loaded.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: Amit Shah <amit.shah@redhat.com>
Tested-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqemu: make virtio-blk PCI compliant by default
Michael S. Tsirkin [Mon, 7 Sep 2009 18:14:37 +0000 (21:14 +0300)]
qemu: make virtio-blk PCI compliant by default

commit bf011293faaa7f87e4de83185931e7411b794128 made virtio-blk-pci not
PCI-compliant, since it makes region 0 (which is an i/o region)
size > 256, and, since PCI 2.1, i/o regions are limited to 256 bytes size.

When the ATA serial number feature is off, which is the default,
make the device spec compliant again, by making region 0 smaller.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: Vadim Rozenfeld <vrozenfe@redhat.com>
Tested-by: Vadim Rozenfeld <vrozenfe@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agousb-linux.c: fix buffer overflow
Jim Paris [Mon, 24 Aug 2009 18:56:12 +0000 (14:56 -0400)]
usb-linux.c: fix buffer overflow

In usb-linux.c:usb_host_handle_control, we pass a 1024-byte buffer and
length to the kernel.  However, the length was provided by the caller
of dev->handle_packet, and is not checked, so the kernel might provide
too much data and overflow our buffer.

For example, hw/usb-uhci.c could set the length to 2047.
hw/usb-ohci.c looks like it might go up to 4096 or 8192.

This causes a qemu crash, as reported here:
  http://www.mail-archive.com/kvm@vger.kernel.org/msg18447.html

This patch increases the usb-linux.c buffer size to 2048 to fix the
specific device reported, and adds a check to avoid the overflow in
any case.

Signed-off-by: Jim Paris <jim@jtan.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoFix conditional compilation (MIPS host)
Stefan Weil [Sun, 6 Sep 2009 17:55:12 +0000 (19:55 +0200)]
Fix conditional compilation (MIPS host)

Compilation for MIPS host (not part of official QEMU)
checks __mips_isa_rev which is not always defined.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovirtio-blk: Use bdrv_aio_multiwrite
Kevin Wolf [Wed, 9 Sep 2009 15:53:38 +0000 (17:53 +0200)]
virtio-blk: Use bdrv_aio_multiwrite

It is quite common for virtio-blk to submit more than one write request in a
row to the qemu block layer. Use bdrv_aio_multiwrite to allow block drivers to
optimize its handling of the requests.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoAdd bdrv_aio_multiwrite
Kevin Wolf [Wed, 9 Sep 2009 15:53:37 +0000 (17:53 +0200)]
Add bdrv_aio_multiwrite

One performance problem of qcow2 during the initial image growth are
sequential writes that are not cluster aligned. In this case, when a first
requests requires to allocate a new cluster but writes only to the first
couple of sectors in that cluster, the rest of the cluster is zeroed - just
to be overwritten by the following second request that fills up the cluster.

Let's try to merge sequential write requests to the same cluster, so we can
avoid to write the zero padding to the disk in the first place.

As a nice side effect, also other formats take advantage of dealing with less
and larger requests.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoRevert "don't call cpu_sychronize_state from reset handlers"
Anthony Liguori [Thu, 10 Sep 2009 13:45:43 +0000 (08:45 -0500)]
Revert "don't call cpu_sychronize_state from reset handlers"

This reverts commit 733318ea9c6d846a6a047b87619e7d9d6e9707d1.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agomicroblaze: Trap if QEMU finds an unknown insns.
Edgar E. Iglesias [Fri, 11 Sep 2009 08:38:31 +0000 (10:38 +0200)]
microblaze: Trap if QEMU finds an unknown insns.

If PVR settings enable illegal insn trap, trap when QEMU finds an
insn it knows nothing about.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
15 years agomicroblaze: Correct prio between MMU and unaligned exceptions.
Edgar E. Iglesias [Fri, 11 Sep 2009 08:35:27 +0000 (10:35 +0200)]
microblaze: Correct prio between MMU and unaligned exceptions.

The microblaze gives MMU faults priority. For stores we still
have a flaw that the value leaks to memory in the case of an
unaligned exception.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
15 years agomicroblaze: HW Exception fixes.
Edgar E. Iglesias [Fri, 11 Sep 2009 08:27:38 +0000 (10:27 +0200)]
microblaze: HW Exception fixes.

* Correct PVR checks for masking off individual exceptions.
* Correct FPU exception code.
* Set EAR on unaligned and unassigned exceptions.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
15 years agoUpdate OpenBIOS images to r577
Aurelien Jarno [Fri, 11 Sep 2009 07:13:04 +0000 (09:13 +0200)]
Update OpenBIOS images to r577

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
15 years agoX86_64: Use proper jumps/calls when displacement exceeds +-2G
malc [Thu, 3 Sep 2009 00:20:01 +0000 (04:20 +0400)]
X86_64: Use proper jumps/calls when displacement exceeds +-2G

Signed-off-by: malc <av1474@comtv.ru>
15 years agoRemove bit-rotten threshold handling
malc [Thu, 10 Sep 2009 17:08:53 +0000 (21:08 +0400)]
Remove bit-rotten threshold handling

Thanks to Toshiya Takeda for bringing up an unrelated issue which led
to this.

Signed-off-by: malc <av1474@comtv.ru>
15 years agoF_DUPFD_CLOEXEC is not universally available
malc [Sun, 6 Sep 2009 02:31:59 +0000 (06:31 +0400)]
F_DUPFD_CLOEXEC is not universally available

The same issue (and the same patch to the byte) was experienced/proposed
by Vince Weaver.

Signed-off-by: malc <av1474@comtv.ru>
15 years agoAdd information w.r.t default GUS IRQ assigment
malc [Thu, 10 Sep 2009 16:05:59 +0000 (20:05 +0400)]
Add information w.r.t default GUS IRQ assigment

15 years agoFix formatting
malc [Thu, 10 Sep 2009 15:59:50 +0000 (19:59 +0400)]
Fix formatting

15 years agoFix formatting, get rid of conf and fix description
malc [Thu, 10 Sep 2009 15:59:41 +0000 (19:59 +0400)]
Fix formatting, get rid of conf and fix description

15 years agoFix formatting and and description field
malc [Thu, 10 Sep 2009 15:59:00 +0000 (19:59 +0400)]
Fix formatting and and description field

15 years agoqdev/isa: convert real time clock
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:35 +0000 (11:43 +0200)]
qdev/isa: convert real time clock

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoqdev/isa: finish pckbd conversion
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:34 +0000 (11:43 +0200)]
qdev/isa: finish pckbd conversion

drop old init path and switch remaining users to
isa_create_simple().

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoqdev/isa: convert ne2000
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:33 +0000 (11:43 +0200)]
qdev/isa: convert ne2000

Also split the isa bits into a separate source file, so we don't drag in
a dependency for isa-bus.o for machines which want ne2k_pci only.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoqdev/isa: convert gravis ultrasound
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:32 +0000 (11:43 +0200)]
qdev/isa: convert gravis ultrasound

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoqdev/isa: convert cs4231a sound card
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:31 +0000 (11:43 +0200)]
qdev/isa: convert cs4231a sound card

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoqdev/isa: convert soundblaster
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:30 +0000 (11:43 +0200)]
qdev/isa: convert soundblaster

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoqdev: add isa_create() function
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:29 +0000 (11:43 +0200)]
qdev: add isa_create() function

Like isa_create_simple, but doesn't call qdev_init, so one can set
properties after creating and before initializing the device.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoqdev: tag isabus-bridge as no-user
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:28 +0000 (11:43 +0200)]
qdev: tag isabus-bridge as no-user

isabus-bridge isn't supposed to be added via -device ...

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoqdev: simplify isa irq assignments
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:27 +0000 (11:43 +0200)]
qdev: simplify isa irq assignments

isa-bus owns the isa irqs now, so it can hand them out directly.
There is no need for the separate isa_connect_irqs step, drop it.

Also hard-code isa interrupts which can't be configured anyway.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoqdev: drop iobase properties from isa bus
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:26 +0000 (11:43 +0200)]
qdev: drop iobase properties from isa bus

Lot of ISA devices work at fixed addresses, so having iobase
as bus property doesn't make much sense.  Devices which can
have different iobases will get a device property.

Also simply hard-code stuff which can't be configured anyway.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoqdev: add property type for 32bit signed integers.
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:25 +0000 (11:43 +0200)]
qdev: add property type for 32bit signed integers.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoisapc: pick a more sane default cpu for such old hardware.
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:24 +0000 (11:43 +0200)]
isapc: pick a more sane default cpu for such old hardware.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
15 years agoisapc: Fix irq routing
Gerd Hoffmann [Thu, 10 Sep 2009 09:43:23 +0000 (11:43 +0200)]
isapc: Fix irq routing

Only send irqs to ioapic in case we have one.
Fixes qemu segfault.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>