Yang Tse [Sat, 10 Sep 2011 03:05:27 +0000 (05:05 +0200)]
ftp.c: fix ftp active connects which got broken with commit
fdf157abdf
Yang Tse [Fri, 9 Sep 2011 23:23:21 +0000 (01:23 +0200)]
runtests.pl: replace TAB with spaces
Yang Tse [Fri, 9 Sep 2011 23:14:52 +0000 (01:14 +0200)]
test harness: revert needless commit
0a5bbb2ac1
https, ftps and ssh servers allowed start up time back to previous values
Yang Tse [Fri, 9 Sep 2011 22:52:13 +0000 (00:52 +0200)]
ssh.c: revert needless commit
7b7c45879e
Daniel Stenberg [Fri, 9 Sep 2011 13:38:30 +0000 (15:38 +0200)]
RELEASE-NOTES: synced with
303c90074d4c
Five more bugfixes, one more contributor
Daniel Stenberg [Fri, 9 Sep 2011 13:20:31 +0000 (15:20 +0200)]
tcpnodelay: rename variable
Renamed the variable from 'proto' to 'level' simply because it is not
protocol you set but level and that is the name of the argument used in
man pages and the POSIX documentation of the setsockopt function.
Guenter Knauf [Thu, 8 Sep 2011 09:17:16 +0000 (11:17 +0200)]
Avoid ftruncate() static define with MinGW64.
Yang Tse [Thu, 8 Sep 2011 09:08:00 +0000 (11:08 +0200)]
libssh2: use calloc as alloc function for libssh2 versions older than 1.3
This workarounds old libssh2 versions not properly initializing
some ssh session variables, which would trigger memory debuggers
warnings on memory being used without having been initialized.
Adriano Meirelles [Thu, 8 Sep 2011 06:38:59 +0000 (08:38 +0200)]
Curl_speedcheck: don't mistakenly clear Curl_expire()
The current version of speedcheck.c may disable timeout by setting zero
to Curl_expire. Which is fine using the curl_multi_perform, because it
recheck all timeout internals, but when using custom event poller (like
hiperfifo.c) it may keep stalle connection forever.
Yang Tse [Wed, 7 Sep 2011 23:22:47 +0000 (01:22 +0200)]
lib582.c: fix segfault triggered when torture testing test case 582
Daniel Stenberg [Wed, 7 Sep 2011 20:46:06 +0000 (22:46 +0200)]
ftp_state_use_port: minor code indent fix
Daniel Stenberg [Wed, 7 Sep 2011 20:45:43 +0000 (22:45 +0200)]
checksrc: detect "}else" uses as well
Daniel Stenberg [Wed, 7 Sep 2011 20:43:28 +0000 (22:43 +0200)]
getinmemory.c: use better argument names for write callback
Yang Tse [Tue, 6 Sep 2011 23:26:43 +0000 (01:26 +0200)]
ssh.c: fix memory leaks triggered upon OOM or other failures
Yang Tse [Tue, 6 Sep 2011 17:59:42 +0000 (19:59 +0200)]
test case 583: ensure that test failures don't go unnoticed - follow-up
Yang Tse [Tue, 6 Sep 2011 16:11:11 +0000 (18:11 +0200)]
test suite: libtest header inclusion cleanup - follow-up
Adjust tests/libtest/Makefile.inc and remove a couple of unused headers from
tests/libtest/lib583.c
Yang Tse [Tue, 6 Sep 2011 15:56:39 +0000 (17:56 +0200)]
test case 583: ensure that test failures don't go unnoticed
Yang Tse [Tue, 6 Sep 2011 15:47:54 +0000 (17:47 +0200)]
test suite: libtest header inclusion cleanup
Added missing memoryTracking to test cases 560 and 583. If this triggers
leak detection on these, it only means that previously it was going unnoticed.
Yang Tse [Mon, 5 Sep 2011 23:57:21 +0000 (01:57 +0200)]
fix bool variables checking and assignment
Yang Tse [Mon, 5 Sep 2011 21:45:04 +0000 (23:45 +0200)]
pingpong.c: avoid a memmove call in function Curl_pp_vsendf
Yang Tse [Mon, 5 Sep 2011 18:46:09 +0000 (20:46 +0200)]
fix bool variables checking and assignment
Yang Tse [Mon, 5 Sep 2011 10:39:50 +0000 (12:39 +0200)]
test suite: use test case specific netrc file names
Guenter Knauf [Sun, 4 Sep 2011 20:04:45 +0000 (22:04 +0200)]
Fixed final message output.
Daniel Stenberg [Sun, 4 Sep 2011 17:41:34 +0000 (19:41 +0200)]
TODO-RELEASE: deleteing five issues due to no response
No feedback and no updates, removing these issues
Yang Tse [Sun, 4 Sep 2011 15:09:22 +0000 (17:09 +0200)]
setup_once.h cleanup and sync
Guenter Knauf [Sun, 4 Sep 2011 15:05:49 +0000 (17:05 +0200)]
Fix to skip untrusted certs.
Guenter Knauf [Sun, 4 Sep 2011 08:03:08 +0000 (10:03 +0200)]
Added SPNEGO to MinGW makefiles.
Yang Tse [Sat, 3 Sep 2011 23:56:30 +0000 (01:56 +0200)]
NTLM WB: fix file descriptor leak upon OOM condition
Yang Tse [Sat, 3 Sep 2011 16:26:21 +0000 (18:26 +0200)]
revert changes not intended to be pushed with commit
6b75d2c2
Yang Tse [Sat, 3 Sep 2011 14:06:10 +0000 (16:06 +0200)]
fix a bunch of MSVC compiler warnings
Guenter Knauf [Sat, 3 Sep 2011 12:01:09 +0000 (14:01 +0200)]
Updated dependecies versions.
Guenter Knauf [Sat, 3 Sep 2011 11:55:16 +0000 (13:55 +0200)]
Some MinGW makefile tweaks for MinGW64.
Guenter Knauf [Sat, 3 Sep 2011 11:37:29 +0000 (13:37 +0200)]
Changed MinGW to use own winidn prototypes.
Dan Fandrich [Fri, 2 Sep 2011 20:15:58 +0000 (13:15 -0700)]
Fix NTLM winbind support to pass the torture tests
Calling sclose() both in the child and the parent fools the
socket leak detector into thinking it's been closed twice.
Calling close() in the child instead overcomes this problem. It's
not as portable as the sclose() macro, but this code is highly
POSIX-specific, anyway.
Yang Tse [Fri, 2 Sep 2011 17:40:53 +0000 (19:40 +0200)]
MemoryTracking: fix logging of free() calls done where Curl_safefree is called
Just internal stuff...
Curl_safefree is now a macro defined in memdebug.h instead of a function
prototyped in url.h and implemented in url.c, so inclusion of url.h is no
longer required in order to simply use Curl_safefree.
Provide definition of macro WHILE_FALSE in setup_once.h in order to allow
other macros such as DEBUGF and DEBUGASSERT, and code using it, to compile
without 'conditional expression is constant' warnings.
The WHILE_FALSE stuff fixes 150+ MSVC compiler warnings.
Yang Tse [Fri, 2 Sep 2011 15:41:39 +0000 (17:41 +0200)]
transfer.c: fix parentheses/braces placement for vi/emacs delimiter matching
Yang Tse [Thu, 1 Sep 2011 22:06:19 +0000 (00:06 +0200)]
transfer.c: fix loadhostpairs() OOM handling
Yang Tse [Thu, 1 Sep 2011 20:21:57 +0000 (22:21 +0200)]
test harness: https, ftps and ssh servers allowed start up time increased 33%
Yang Tse [Thu, 1 Sep 2011 15:09:46 +0000 (17:09 +0200)]
hostip.c: return immediately from Curl_resolv_timeout() upon expired timeout.
Ensure existing logic in Curl_resolv_timeout() is not subverted upon getting a
negative timeout from resolve_server(). The timeout in resolve_server() could
be checked to avoid calling Curl_resolv_timeout() with an expired timeout, but
fixing this in this way allows existing logic in resolve_server() to be kept
unchanged.
Yang Tse [Thu, 1 Sep 2011 13:38:30 +0000 (15:38 +0200)]
ftp.c: fix some leaks torture tests detected 2011-08-30 - follow-up
follow-up for commit
d20408e8
Yang Tse [Wed, 31 Aug 2011 17:59:26 +0000 (19:59 +0200)]
test harness: fix detection of test harness client knownhosts file
Regenerate curl's tests client knownhosts file also when, somehow,
this file is empty.
Yang Tse [Wed, 31 Aug 2011 16:16:14 +0000 (18:16 +0200)]
test harness: fix detection of test harness host and client key files
Regenerate curl's tests host and client key files also when, somehow,
any of these files are empty.
Yang Tse [Wed, 31 Aug 2011 16:15:29 +0000 (18:15 +0200)]
ssh.c: fix realloc() OOM handling
Yang Tse [Wed, 31 Aug 2011 16:14:38 +0000 (18:14 +0200)]
ftp.c: fix some leaks torture tests detected 2011-08-30 - follow-up
follow-up for commit
c06de200
Yang Tse [Wed, 31 Aug 2011 01:50:07 +0000 (03:50 +0200)]
fix some leaks torture tests detected 2011-08-30
Yang Tse [Tue, 30 Aug 2011 23:58:06 +0000 (01:58 +0200)]
fix some leaks torture tests detected 2011-08-30
Daniel Stenberg [Mon, 29 Aug 2011 13:37:06 +0000 (15:37 +0200)]
RELEASE-NOTES: synced with
3445fa2e3f
Kamil Dudka [Fri, 26 Aug 2011 09:10:58 +0000 (11:10 +0200)]
tests: break busy loops in tests 502, 555, and 573
Yang Tse [Mon, 29 Aug 2011 12:27:06 +0000 (14:27 +0200)]
pingpong.c: fix Curl_pp_vsendf() arbitrary restrictions on command length
This removes command length restrictions on calling functions.
Yang Tse [Sun, 28 Aug 2011 09:29:09 +0000 (11:29 +0200)]
NTLM: header inclusion cleanup follow-up
Yang Tse [Sun, 28 Aug 2011 05:15:46 +0000 (07:15 +0200)]
NTLM: header inclusion cleanup
Yang Tse [Sun, 28 Aug 2011 00:00:02 +0000 (02:00 +0200)]
NTLM: END of refactoring/splitting/moving
First:
File curl_ntlm.h renamed curl_ntlm_msgs.h
File curl_ntlm.c renamed curl_ntlm_msgs.c
Afterwards:
File http_ntlm.c renamed curl_ntlm.c
File http_ntlm.h renamed curl_ntlm.h
Yang Tse [Sat, 27 Aug 2011 23:19:08 +0000 (01:19 +0200)]
NTLM: move NTLM core specifics into curl_ntlm_core.[ch]
Yang Tse [Sat, 27 Aug 2011 17:16:10 +0000 (19:16 +0200)]
NTLM_WB: move NTLM_WB specifics into curl_ntlm_wb.[ch]
Yang Tse [Sat, 27 Aug 2011 04:31:18 +0000 (06:31 +0200)]
NTLM_WB: final congruency naming adjustments
Configure script option --enable-wb-ntlm-auth renamed to --enable-ntlm-wb
Configure script option --disable-wb-ntlm-auth renamed to --disable-ntlm-wb
Preprocessor symbol WINBIND_NTLM_AUTH_ENABLED renamed to NTLM_WB_ENABLED
Preprocessor symbol WINBIND_NTLM_AUTH_FILE renamed to NTLM_WB_FILE
Test harness env var CURL_NTLM_AUTH renamed to CURL_NTLM_WB_FILE
Static function wb_ntlm_close renamed to ntlm_wb_cleanup
Static function wb_ntlm_initiate renamed to ntlm_wb_init
Static function wb_ntlm_response renamed to ntlm_wb_response
Yang Tse [Fri, 26 Aug 2011 23:32:49 +0000 (01:32 +0200)]
NTLM single-sign on adjustments (XI)
Feature string literal NTLM_SSO renamed to NTLM_WB.
Preprocessor symbol USE_NTLM_SSO renamed to WINBIND_NTLM_AUTH_ENABLED.
curl's 'long' option 'ntlm-sso' renamed to 'ntlm-wb'.
Fix some comments to make clear that this is actually a NTLM delegation.
Daniel Stenberg [Fri, 26 Aug 2011 21:23:07 +0000 (23:23 +0200)]
--cookie-jar: activates the cookie engine
Daniel Stenberg [Thu, 25 Aug 2011 20:42:02 +0000 (22:42 +0200)]
Curl_read_plain: indent code
Yang Tse [Fri, 26 Aug 2011 16:57:50 +0000 (18:57 +0200)]
NTLM single-sign on adjustments (X)
Functions renamed:
Curl_output_ntlm_sso -> Curl_output_ntlm_wb
sso_ntlm_close -> wb_ntlm_close
sso_ntlm_response -> wb_ntlm_response
sso_ntlm_initiate -> wb_ntlm_initiate
Preprocessor symbols renamed:
CURLAUTH_NTLM_SSO -> CURLAUTH_NTLM_WB
CURL_VERSION_NTLM_SSO -> CURL_VERSION_NTLM_WB
Daniel Stenberg [Thu, 25 Aug 2011 14:04:55 +0000 (16:04 +0200)]
TODO: progress callback without doubles
Steve Holme [Thu, 25 Aug 2011 13:09:30 +0000 (15:09 +0200)]
http NTLM: refactoring followup
Output of Curl_ntlm_create_type1_message() and Curl_ntlm_create_type3_message()
functions is now already base64 encoded.
Kamil Dudka [Wed, 24 Aug 2011 21:50:59 +0000 (23:50 +0200)]
docs: the next release is going to be 7.22.0
Yang Tse [Wed, 24 Aug 2011 12:00:42 +0000 (14:00 +0200)]
include limits.h for INT_MAX
Yang Tse [Wed, 24 Aug 2011 11:58:37 +0000 (13:58 +0200)]
add missing semicolons
Daniel Stenberg [Wed, 24 Aug 2011 09:56:23 +0000 (11:56 +0200)]
add missing semicolons
Daniel Stenberg [Wed, 24 Aug 2011 09:55:49 +0000 (11:55 +0200)]
safefree use: fix compiler warning
include the prototype header
Steve Holme [Wed, 24 Aug 2011 06:55:25 +0000 (08:55 +0200)]
SMTP authentication: fix ordering of preferred authentication method
Fixed the order of the preferred SMTP authentication method to:
AUTH CRAM-MD5, AUTH LOGIN then AUTH PLAIN.
AUTH PLAIN should be the last as it slightly more insecure than AUTH LOGIN
as the username and password are sent together - there is no handshaking
between the client and server like there is with AUTH LOGIN.
Yang Tse [Wed, 24 Aug 2011 06:07:36 +0000 (08:07 +0200)]
base64: fix Curl_base64_encode and Curl_base64_decode interfaces
Previous interfaces for these libcurl internal functions did not allow to tell
apart a legitimate zero size result from an error condition. These functions
now return a CURLcode indicating function success or otherwise specific error.
Output size is returned using a pointer argument.
All usage of these two functions, and others closely related, has been adapted
to the new interfaces. Relative error and OOM handling adapted or added where
missing. Unit test 1302 also adapted.
Daniel Stenberg [Tue, 23 Aug 2011 14:31:10 +0000 (16:31 +0200)]
resolve.c: new example showing off CURLOPT_RESOLVE
Daniel Stenberg [Tue, 23 Aug 2011 09:28:35 +0000 (11:28 +0200)]
externalsocket.c: new example
Steve Holme [Mon, 22 Aug 2011 14:42:59 +0000 (16:42 +0200)]
http NTLM: remaining bits from 0001-Moved-ntlm-[...]-curl_ntlm-mod_3.patch
* Added function comments:
- Curl_ntlm_decode_type2_message
- Curl_ntlm_create_type1_message
- Curl_ntlm_create_type3_message
* Modification of ntlm processing state to NTLMSTATE_TYPE2 is now done
only when Curl_ntlm_decode_type2_message() has fully succeeded.
Yang Tse [Sun, 21 Aug 2011 17:25:35 +0000 (19:25 +0200)]
runtests.pl: option -gw for single test windowed debugging (where possible)
Yang Tse [Sun, 21 Aug 2011 11:15:34 +0000 (13:15 +0200)]
zlib: ensure user provided memory functions are used by zlib, when given
As a bonus, this lets our MemoryTracking subsystem track zlib operations.
And also fixes a shortcut some zlib 1.2.x versions took using malloc()
instead of calloc(), which would trigger memory debuggers warnings on
memory being used without having been initialized.
Daniel Stenberg [Sun, 21 Aug 2011 10:59:06 +0000 (12:59 +0200)]
main: fix segfault
Follow-up to commit
5eb2396cd as that wasn't complete.
At times HEADERFUNCTION+HEADERDATA was set only to have only HEADERDATA
set in the subsequent loop which could cause a NULL to get sent as
userdata to 'header_callback' which wasn't made to handle that.
Now HEADERFUNCTION is explicitly set to NULL if it isn't set to the
callback.
Yang Tse [Sun, 21 Aug 2011 04:10:52 +0000 (06:10 +0200)]
MemoryTracking: adjust initialization calling - followup
Fix macro definition
Yang Tse [Sat, 20 Aug 2011 15:26:02 +0000 (17:26 +0200)]
MemoryTracking: adjust initialization calling
Calling of curl_memdebug() was still done with a pending free()
Daniel Stenberg [Fri, 19 Aug 2011 21:38:45 +0000 (23:38 +0200)]
tcpconnect: follow-up commit after
b998d95b
As I modified conn->bits.tcpconnect to become an array that holds one
bool for each potential connection all uses of that struct field must
index it correctly.
Yang Tse [Fri, 19 Aug 2011 19:25:39 +0000 (21:25 +0200)]
ssh.c: add PATH_MAX definition for WIN32
Daniel Stenberg [Thu, 18 Aug 2011 22:16:01 +0000 (00:16 +0200)]
connect: set TIMER_CONNECT
When connecting, make sure TIMER_CONNECT is set.
Daniel Stenberg [Thu, 18 Aug 2011 22:15:37 +0000 (00:15 +0200)]
test573: fix the keywords
Daniel Stenberg [Thu, 18 Aug 2011 21:35:15 +0000 (23:35 +0200)]
FTP: fix proxy connect race condition
When using the multi interface, a SOCKS proxy, and a connection that
wouldn't immediately consider itself connected (which my Linux tests do
by default), libcurl would be tricked into doing _two_ connects to the
SOCKS proxy when it setup the data connection and then of course the
second attempt would fail miserably and cause error.
This problem is a regression that was introduced by commit
4a42e5cdaa344755 that was introduced in the 7.21.7 release.
Bug: http://curl.haxx.se/mail/lib-2011-08/0199.html
Reported by: Fabian Keil
Daniel Stenberg [Thu, 18 Aug 2011 21:28:50 +0000 (23:28 +0200)]
Curl_SOCKS4: minor code compression
Yang Tse [Thu, 18 Aug 2011 18:09:26 +0000 (20:09 +0200)]
zlib: enforce full initialization of our data space z_stream structs
Daniel Stenberg [Wed, 17 Aug 2011 21:51:37 +0000 (23:51 +0200)]
VC makefiles: fixed variable name mistake
Yang Tse [Wed, 17 Aug 2011 17:02:42 +0000 (19:02 +0200)]
MemoryTracking: adjust curl_domalloc() and curl_dofree() memory filling
Until 2011-08-17 libcurl's Memory Tracking feature also performed
automatic malloc and free filling operations using 0xA5 and 0x13
values. Our own preinitialization of dynamically allocated memory
might be useful when not using third party memory debuggers, but
on the other hand this would fool memory debuggers into thinking
that all dynamically allocated memory is properly initialized.
As a default setting, libcurl's Memory Tracking feature no longer
performs preinitialization of dynamically allocated memory on its
own. If you know what you are doing, and really want to retain old
behavior, you can achieve this compiling with preprocessor symbols
CURL_MT_MALLOC_FILL and CURL_MT_FREE_FILL defined with appropriate
values.
Yang Tse [Tue, 16 Aug 2011 20:24:23 +0000 (22:24 +0200)]
MemoryTracking: make curl_docalloc() call calloc() avoiding our zero fill
Daniel Stenberg [Mon, 15 Aug 2011 21:22:06 +0000 (23:22 +0200)]
MSVC makefiles: provide SSH build targets
"release-ssl-ssh2-zlib" and "debug-ssl-ssh2-zlib" are two new makefile
targets that build libcurl with MSVC and link with libssh2
Bug: http://curl.haxx.se/bug/view.cgi?id=3388920
Reported by: "kdekker"
Daniel Stenberg [Mon, 15 Aug 2011 20:40:28 +0000 (22:40 +0200)]
test572: fixed
Two problems were fixed:
GET_PARAMETER responses that have no body must be 204 response or
properly set length to 0.
One of the <data> sections had the wrong content-length for its
GET_PARAMETER response.
Enabled test 572 again.
Daniel Stenberg [Mon, 15 Aug 2011 20:08:58 +0000 (22:08 +0200)]
Curl_pgrsStartNow: clear all flags but HIDE
As bug 3385258 pointed out but I missed up the fix for. This is another
take at a fix.
Bug: http://curl.haxx.se/bug/view.cgi?id=3392101
Reported by: Wu Yongzheng
Yang Tse [Mon, 15 Aug 2011 16:27:59 +0000 (18:27 +0200)]
unittests: disable unit tests for some autobuild configurations
IRIX 6.5.24 gcc 3.3 autobuilds fail unittests library compilation due to a
problem related with OpenSSL headers and library versions not matching.
All AIX autobuilds fails unit tests linking against unittests library due to
unittests library being built with no symbols or members. Libtool ?
Kamil Dudka [Mon, 15 Aug 2011 11:48:45 +0000 (13:48 +0200)]
nss: start with no database if the selected database is broken
Bug: https://bugzilla.redhat.com/728562
Yang Tse [Sun, 14 Aug 2011 23:34:34 +0000 (01:34 +0200)]
http NTLM: reinstate "nssg.h" "curl_sspi.h" header inclusions
Yang Tse [Sun, 14 Aug 2011 22:19:23 +0000 (00:19 +0200)]
tests: disable #572
Daniel Stenberg [Sun, 14 Aug 2011 21:29:24 +0000 (23:29 +0200)]
TODO-RELEASE: synced
Added comments to some remaining issues
Daniel Stenberg [Sun, 14 Aug 2011 21:26:09 +0000 (23:26 +0200)]
telnet: allow programatic use on Windows
Summary of the issue can be found at:
http://curl.haxx.se/mail/lib-2010-04/0367.html
That patch only updated the unix sockets code - the winsock code was not
updated and no longer works the same was as the unix code. This change
updates the windows code accordingly.
Bug: http://curl.haxx.se/bug/view.cgi?id=3163118
Daniel Stenberg [Sun, 14 Aug 2011 17:10:54 +0000 (19:10 +0200)]
TODO-RELEASE: fixed issue #291
291 - bug 3383692 "GET PARAMETER request and body in response"
Yang Tse [Sun, 14 Aug 2011 19:16:01 +0000 (21:16 +0200)]
http NTLM: reinstate "memdebug.h" header inclusion
Inclusion of header "memdebug.h" in http_ntlm.c got lost in commit
98fb0ef7.
Daniel Stenberg [Sun, 14 Aug 2011 17:07:54 +0000 (19:07 +0200)]
RTSP: GET_PARAMETER requests have a body
Bug: http://curl.haxx.se/bug/view.cgi?id=3383692
Daniel Stenberg [Sun, 14 Aug 2011 16:54:21 +0000 (18:54 +0200)]
Curl_output_ntlm: remove unused variable
Yang Tse [Sun, 14 Aug 2011 15:26:42 +0000 (17:26 +0200)]
http NTLM: add curl_ntlm.c to Symbian's libcurl.mmp