scroggo@google.com [Fri, 20 Apr 2012 18:42:55 +0000 (18:42 +0000)]
Fix the Android build.
Use the correct macro for SkEmbossMaskFilter
Review URL: https://codereview.appspot.com/
6081045
git-svn-id: http://skia.googlecode.com/svn/trunk@3743
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Fri, 20 Apr 2012 18:35:38 +0000 (18:35 +0000)]
Hooks up the GrCustomStage/GrGLProgramStageFactory/GrGLProgramStage
classes from r3726 so they can be used. Does not implement any actual
effect stages.
Has one large known bug: if custom stages are provided, GrSamplerState
comparisons will break; this should preserve correct drawing, but decrease
performance - among other things, we'll break draw batching. To fix this
we'll need a RTTI system for GrCustomState objects, and we'll need to change
the GrSamplerState comparison from a memcmp to something that also does a
deep type-sensitive compare of any GrCustomState objects present.
http://codereview.appspot.com/
6074043/
git-svn-id: http://skia.googlecode.com/svn/trunk@3742
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 20 Apr 2012 17:39:51 +0000 (17:39 +0000)]
Fixes for drawing through an SkGPipe.
Implement SkGPipeCanvas::drawBitmap.
Fix a bug where needOpBytes did not necessarily provide as
many bytes as requested.
Fix a bug where needOpBytes would wipe old data without
calling notify.
Register SkEmbossMaskFilter so it can be flattened.
Override drawBitmapNine (currently unimplemented) so an
SkGPipeCanvas does not call its base class' method (which
would fail).
Review URL: https://codereview.appspot.com/
6071045
git-svn-id: http://skia.googlecode.com/svn/trunk@3741
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 20 Apr 2012 15:26:28 +0000 (15:26 +0000)]
Fix gdi assert that the font is not a vector FON font.
See http://code.google.com/p/chromium/issues/detail?id=124313
git-svn-id: http://skia.googlecode.com/svn/trunk@3740
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 20 Apr 2012 15:10:32 +0000 (15:10 +0000)]
only add pathmeasure segment if the accumulated length was actually changed,
and not based on if the local length was > 0. This is necessary since
assert(delta > 0); // true
prevDistance = distance;
distance += delta;
assert(distance > prevDistance); // not always true
Fixes https://bugs.webkit.org/show_bug.cgi?id=78979
git-svn-id: http://skia.googlecode.com/svn/trunk@3739
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 19 Apr 2012 21:01:24 +0000 (21:01 +0000)]
add x() and y() aliases for fLeft and fTop (matching SkIRect)
git-svn-id: http://skia.googlecode.com/svn/trunk@3737
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 19 Apr 2012 19:27:19 +0000 (19:27 +0000)]
Fix undefined GLint in Mac builds
git-svn-id: http://skia.googlecode.com/svn/trunk@3736
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 19 Apr 2012 19:25:49 +0000 (19:25 +0000)]
silence warning
git-svn-id: http://skia.googlecode.com/svn/trunk@3735
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 19 Apr 2012 19:15:35 +0000 (19:15 +0000)]
Make GM able to run MSAA modes and multiple GPU configs in a single run.
Review URL: http://codereview.appspot.com/
6061051/
git-svn-id: http://skia.googlecode.com/svn/trunk@3734
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 19 Apr 2012 18:59:25 +0000 (18:59 +0000)]
fix unused-return-result-warning for invert/getPosTan
git-svn-id: http://skia.googlecode.com/svn/trunk@3733
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 19 Apr 2012 18:52:39 +0000 (18:52 +0000)]
retarget fonttable tests to use SkTypeface api, rather than (should-be-private) SkFontHost api
git-svn-id: http://skia.googlecode.com/svn/trunk@3732
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 19 Apr 2012 13:27:04 +0000 (13:27 +0000)]
Fix class/struct warning
Review URL: http://codereview.appspot.com/
6073044/
git-svn-id: http://skia.googlecode.com/svn/trunk@3730
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 18 Apr 2012 21:19:26 +0000 (21:19 +0000)]
mirror 3713 for non-antialiased-hairlines. clamp lines to 32K to avoid fixedpoint overflow
fixes crbug.com/123105
git-svn-id: http://skia.googlecode.com/svn/trunk@3729
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 18 Apr 2012 20:16:18 +0000 (20:16 +0000)]
speculative fix for debug/release problem on windows with mirror bitmaps
Review URL: https://codereview.appspot.com/
6063051
git-svn-id: http://skia.googlecode.com/svn/trunk@3728
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 18 Apr 2012 18:32:04 +0000 (18:32 +0000)]
inline common case when we are left-aligned in drawPosText
Review URL: https://codereview.appspot.com/
6051051
git-svn-id: http://skia.googlecode.com/svn/trunk@3727
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Wed, 18 Apr 2012 17:49:20 +0000 (17:49 +0000)]
Infrastructure for new Ganesh shader pipeline: base classes for GPU
implementation of user-defined effects.
http://codereview.appspot.com/
6052047/
git-svn-id: http://skia.googlecode.com/svn/trunk@3726
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Wed, 18 Apr 2012 17:11:19 +0000 (17:11 +0000)]
Fix some float/scalar/int confusion.
Review URL: https://codereview.appspot.com/
6064043
git-svn-id: http://skia.googlecode.com/svn/trunk@3725
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 18 Apr 2012 16:19:17 +0000 (16:19 +0000)]
fix memory leaks
Review URL: https://codereview.appspot.com/
6063049
git-svn-id: http://skia.googlecode.com/svn/trunk@3724
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 18 Apr 2012 15:40:50 +0000 (15:40 +0000)]
Basic support for bitmap fonts on Windows.
http://codereview.appspot.com/
6062044/
git-svn-id: http://skia.googlecode.com/svn/trunk@3723
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 18 Apr 2012 15:35:37 +0000 (15:35 +0000)]
Remove unecessary virtual calls by having SkPicture use SkReader32 directly.
Review URL: https://codereview.appspot.com/
6048046
git-svn-id: http://skia.googlecode.com/svn/trunk@3722
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 18 Apr 2012 14:39:58 +0000 (14:39 +0000)]
Added glBlendEquation to GL interface
http://codereview.appspot.com/
6057047/
git-svn-id: http://skia.googlecode.com/svn/trunk@3720
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 18 Apr 2012 14:07:57 +0000 (14:07 +0000)]
In SampleWindow, pass ownership of menus to SkWindow, so it can safely
delete them in its destructor.
BUG=557
TEST=Run SampleApp on linux. Then press escape.
Review URL: https://codereview.appspot.com/
6050047
git-svn-id: http://skia.googlecode.com/svn/trunk@3719
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 18 Apr 2012 13:57:47 +0000 (13:57 +0000)]
Fix bug where SkGPipe'ed clips do not happen.
Modify SkGPipeCanvas::clipRect and ::clipPath so they correctly
override the SkCanvas versions, and therefore get called. Also use
SK_OVERRIDE for its virtual functions to help catch this in the
future.
BUG=572
Review URL: https://codereview.appspot.com/
6055050
git-svn-id: http://skia.googlecode.com/svn/trunk@3718
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 18 Apr 2012 13:36:54 +0000 (13:36 +0000)]
Make gm tool able to read and write image files in the same run
BUG=http://code.google.com/p/skia/issues/detail?id=571
Review URL: https://codereview.appspot.com/
6052050
git-svn-id: http://skia.googlecode.com/svn/trunk@3717
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 18 Apr 2012 13:29:52 +0000 (13:29 +0000)]
Track oval in SkPath
Committed on behalf of Guanqun.Lu@gmail.com
Review URL:http://codereview.appspot.com/
6012047/
git-svn-id: http://skia.googlecode.com/svn/trunk@3716
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Tue, 17 Apr 2012 22:31:52 +0000 (22:31 +0000)]
[PDF] Handle failures of matrix inversion
Previously reviewed in https://codereview.appspot.com/
6033047. Rolled back
because of unrelated fixed-point bugs.
Review URL: https://codereview.appspot.com/
6052051
git-svn-id: http://skia.googlecode.com/svn/trunk@3715
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Tue, 17 Apr 2012 21:46:18 +0000 (21:46 +0000)]
Fix some fixed-point bugs.
Review URL: https://codereview.appspot.com/
6047046
git-svn-id: http://skia.googlecode.com/svn/trunk@3714
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 17 Apr 2012 20:43:47 +0000 (20:43 +0000)]
chop hairlines against 32K bounds, since that is our limit (currently)
for a fixedpoint implementation.
git-svn-id: http://skia.googlecode.com/svn/trunk@3713
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Tue, 17 Apr 2012 20:37:37 +0000 (20:37 +0000)]
Revert "[PDF] Handle failures of matrix inversion" while I investigate fixed point failures.
This reverts commit r3711
Review URL: https://codereview.appspot.com/
6050049
git-svn-id: http://skia.googlecode.com/svn/trunk@3712
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Tue, 17 Apr 2012 20:19:03 +0000 (20:19 +0000)]
[PDF] Handle failures of matrix inversion.
Review URL: https://codereview.appspot.com/
6033047
git-svn-id: http://skia.googlecode.com/svn/trunk@3711
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 17 Apr 2012 19:29:51 +0000 (19:29 +0000)]
Fix reset of scissor state in onResetContext
Review URL: http://codereview.appspot.com/
6061046/
git-svn-id: http://skia.googlecode.com/svn/trunk@3709
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 17 Apr 2012 18:01:31 +0000 (18:01 +0000)]
expose font-table APIs to SkTypeface
Review URL: https://codereview.appspot.com/
6050046
git-svn-id: http://skia.googlecode.com/svn/trunk@3707
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 17 Apr 2012 15:38:20 +0000 (15:38 +0000)]
Revert r3705 for fixed pt failures.
git-svn-id: http://skia.googlecode.com/svn/trunk@3706
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 17 Apr 2012 15:22:06 +0000 (15:22 +0000)]
track oval in SkPath
Committed on behalf of Guanqun.Lu@gmail.com
Review URL: http://codereview.appspot.com/
6012047/
git-svn-id: http://skia.googlecode.com/svn/trunk@3705
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 17 Apr 2012 14:43:38 +0000 (14:43 +0000)]
we have to explicitly pin the results from sect_with_horizontal, since even with
doubles we can get the wrong results (computed X value outside of [start...stop].
added regression test inside the code
fixes bug in Fuzzer samplecode
git-svn-id: http://skia.googlecode.com/svn/trunk@3704
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 17 Apr 2012 12:43:00 +0000 (12:43 +0000)]
Add coverage AA support for SampleApp root layers (windows only)
Review URL: http://codereview.appspot.com/
6043045/
git-svn-id: http://skia.googlecode.com/svn/trunk@3703
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 17 Apr 2012 11:40:34 +0000 (11:40 +0000)]
work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@3702
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 16 Apr 2012 19:21:30 +0000 (19:21 +0000)]
Add cast to support 64 bit.
http://code.google.com/p/skia/issues/detail?id=524
Review URL: https://codereview.appspot.com/
6038053
git-svn-id: http://skia.googlecode.com/svn/trunk@3701
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 16 Apr 2012 19:11:17 +0000 (19:11 +0000)]
add defer canvas to bench
Committed on behalf of Guanqun.Lu@gmail.com
Review URL: http://codereview.appspot.com/
6013051
git-svn-id: http://skia.googlecode.com/svn/trunk@3700
2bbb7eff-a529-9590-31e7-
b0007b416f81
justinlin@google.com [Mon, 16 Apr 2012 19:10:21 +0000 (19:10 +0000)]
Add SK_SYSTEM_ZLIB define.
Review URL: https://codereview.appspot.com/
5991067
git-svn-id: http://skia.googlecode.com/svn/trunk@3699
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 16 Apr 2012 18:03:03 +0000 (18:03 +0000)]
Minor refactoring to pull GrClipMaskManager into its own files
http://codereview.appspot.com/
5978055/
git-svn-id: http://skia.googlecode.com/svn/trunk@3697
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Mon, 16 Apr 2012 18:00:40 +0000 (18:00 +0000)]
Allow specifying multiple configs for bench, e.g. -config 8888 -config GPU.
Patch courtesy of Guanqun Lu.
http://codereview.appspot.com/
6031057/
git-svn-id: http://skia.googlecode.com/svn/trunk@3696
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 16 Apr 2012 17:14:36 +0000 (17:14 +0000)]
rebaseline for fixes to cubic clipping
git-svn-id: http://skia.googlecode.com/svn/trunk@3695
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 16 Apr 2012 17:12:38 +0000 (17:12 +0000)]
need to invert the alpha computation for single scanline on innerfill
found by Fuzzer
git-svn-id: http://skia.googlecode.com/svn/trunk@3694
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 16 Apr 2012 17:07:57 +0000 (17:07 +0000)]
rebaseline for quad clipper fix
git-svn-id: http://skia.googlecode.com/svn/trunk@3693
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 16 Apr 2012 16:33:13 +0000 (16:33 +0000)]
First pass at stencil clip mask refactoring
http://codereview.appspot.com/
6031043/
git-svn-id: http://skia.googlecode.com/svn/trunk@3692
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 16 Apr 2012 16:27:09 +0000 (16:27 +0000)]
fix clamping when we chop a cubic
Review URL: https://codereview.appspot.com/
6039048
git-svn-id: http://skia.googlecode.com/svn/trunk@3691
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 16 Apr 2012 16:24:35 +0000 (16:24 +0000)]
Minor code cleanup of Debug GL Interface
http://codereview.appspot.com/
6032043/
git-svn-id: http://skia.googlecode.com/svn/trunk@3690
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 16 Apr 2012 15:50:18 +0000 (15:50 +0000)]
Addressed more Windows compiler complaint issues
http://codereview.appspot.com/
6007056/
git-svn-id: http://skia.googlecode.com/svn/trunk@3689
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 16 Apr 2012 15:49:04 +0000 (15:49 +0000)]
roll out code.google.com/p/skia/source/detail?r=3687 because Mac 10.6 bot is failing
git-svn-id: http://skia.googlecode.com/svn/trunk@3688
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 16 Apr 2012 15:14:22 +0000 (15:14 +0000)]
Make Mac build generate both 32-bit and 64-bit code.
BUG=http://code.google.com/p/skia/issues/detail?id=524
Review URL: https://codereview.appspot.com/
6022057
git-svn-id: http://skia.googlecode.com/svn/trunk@3687
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 16 Apr 2012 15:04:45 +0000 (15:04 +0000)]
Fix 64-bit build on Mac
BUG=http://code.google.com/p/skia/issues/detail?id=524
Thanks to mmaerean@adobe.com for the patch.
Review URL: https://codereview.appspot.com/
6022058
git-svn-id: http://skia.googlecode.com/svn/trunk@3686
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 16 Apr 2012 14:49:14 +0000 (14:49 +0000)]
Propagated AA flags through Ganesh's clip stack (in preparation for GL AA clipping)
http://codereview.appspot.com/
6038051/
git-svn-id: http://skia.googlecode.com/svn/trunk@3685
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 16 Apr 2012 14:41:02 +0000 (14:41 +0000)]
Revert r3681 due to fixed point failures in tests.
git-svn-id: http://skia.googlecode.com/svn/trunk@3684
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 16 Apr 2012 14:19:32 +0000 (14:19 +0000)]
Add file missing from r3682 checkin
git-svn-id: http://skia.googlecode.com/svn/trunk@3683
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 16 Apr 2012 14:10:47 +0000 (14:10 +0000)]
add gm circles
Committed on behalf of Guanqun.Lu@gmail.com
Review URL: http://codereview.appspot.com/
6005047/
git-svn-id: http://skia.googlecode.com/svn/trunk@3682
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 16 Apr 2012 14:06:50 +0000 (14:06 +0000)]
add isSimilarityTransform() and some tests
Committed on behalf of Guanqun.Lu@gmail.com
Review URL: http://codereview.appspot.com/
5999050/
git-svn-id: http://skia.googlecode.com/svn/trunk@3681
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 16 Apr 2012 12:19:42 +0000 (12:19 +0000)]
rebaseline after clamp fix to quad clipper in rev. 3677
git-svn-id: http://skia.googlecode.com/svn/trunk@3680
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sat, 14 Apr 2012 19:06:16 +0000 (19:06 +0000)]
proper handling if SkMatrix::invert failes, addresses hack fix in rev. 3657
git-svn-id: http://skia.googlecode.com/svn/trunk@3679
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sat, 14 Apr 2012 12:55:17 +0000 (12:55 +0000)]
dd DrawPathTest to gyp
add regression tests for bug 533
git-svn-id: http://skia.googlecode.com/svn/trunk@3678
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 13 Apr 2012 21:04:55 +0000 (21:04 +0000)]
pin the edge points to the clip, rather than just calling clamp_ge/le in the
quad chopper. This fixes some gaps we were seeing when the float match lost
precisions.
fixes http://code.google.com/p/skia/issues/detail?id=533
git-svn-id: http://skia.googlecode.com/svn/trunk@3677
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 13 Apr 2012 20:45:46 +0000 (20:45 +0000)]
[PDF] If matrix inversion fails, use the identity matrix.
BUG=chrome:123078
Review URL: https://codereview.appspot.com/
6007044
git-svn-id: http://skia.googlecode.com/svn/trunk@3676
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 13 Apr 2012 16:05:44 +0000 (16:05 +0000)]
Some fonts do not measure correctly in Mountain Lion,
carrying over a bug from Lion. Add the check
appropriately.
Review URL: https://codereview.appspot.com/
6026045
git-svn-id: http://skia.googlecode.com/svn/trunk@3675
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 13 Apr 2012 15:29:12 +0000 (15:29 +0000)]
rebaseline after SkScalarNearlyZero() change (< to <=) rev. 3652
git-svn-id: http://skia.googlecode.com/svn/trunk@3674
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Apr 2012 15:02:57 +0000 (15:02 +0000)]
Revert gm baseline deletions from r3653 and r3656, so I can rebaseline them with proper diffs
Review URL: https://codereview.appspot.com/
6021047
git-svn-id: http://skia.googlecode.com/svn/trunk@3673
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Apr 2012 14:27:49 +0000 (14:27 +0000)]
exercise buildbot change in r3671
git-svn-id: http://skia.googlecode.com/svn/trunk@3672
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 13 Apr 2012 13:50:27 +0000 (13:50 +0000)]
replace getTotalClipStack() with replayClips()+ClipVisitor
git-svn-id: http://skia.googlecode.com/svn/trunk@3670
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 12 Apr 2012 19:53:31 +0000 (19:53 +0000)]
Fixed uninitialized memory issue on Linux when running "gm --debuggl"
http://codereview.appspot.com/
6012052/
git-svn-id: http://skia.googlecode.com/svn/trunk@3666
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 12 Apr 2012 19:44:38 +0000 (19:44 +0000)]
add SK_WARN_UNUSED_RESULT warning to SkPathMeasure methods that might leave
POD var-arguments uninitialized.
git-svn-id: http://skia.googlecode.com/svn/trunk@3665
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 12 Apr 2012 18:02:25 +0000 (18:02 +0000)]
Make download_baselines.py download *all* platforms, if none are specified.
Simplifies the Skia rebaselining process... updated the --help pages in both scripts, too.
BUG=http://code.google.com/p/skia/issues/detail?id=486
Review URL: https://codereview.appspot.com/
6016045
git-svn-id: http://skia.googlecode.com/svn/trunk@3664
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 12 Apr 2012 17:17:59 +0000 (17:17 +0000)]
rename compare-baselines.py and download-baselines.py using underscores instead of hyphens, as per python requirements
git-svn-id: http://skia.googlecode.com/svn/trunk@3663
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 12 Apr 2012 16:32:04 +0000 (16:32 +0000)]
If skdiff encounters image size mismatch, do not display diff images
Currently, if skdiff encounters images whose expected and actual dimensions do not match, it will attempt (incorrectly) to display diffs. Better to not display the diffs at all than to display misleading diffs...
Review URL: https://codereview.appspot.com/
6015049
git-svn-id: http://skia.googlecode.com/svn/trunk@3662
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 12 Apr 2012 16:12:16 +0000 (16:12 +0000)]
mark getTotalClip as deprecated
remove unimplemented (and duplicate) getTotalClipBounds
git-svn-id: http://skia.googlecode.com/svn/trunk@3661
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 12 Apr 2012 15:53:23 +0000 (15:53 +0000)]
Fix crash with LCD vertical text.
https://codereview.appspot.com/
6012050/
git-svn-id: http://skia.googlecode.com/svn/trunk@3660
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 12 Apr 2012 14:27:42 +0000 (14:27 +0000)]
can't perform fast top_bottom cull if the text is vertical
git-svn-id: http://skia.googlecode.com/svn/trunk@3659
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 12 Apr 2012 14:23:58 +0000 (14:23 +0000)]
Reinstate early out from antialiased path rendering if we anticipate
overflow (or if the path is completely clipped out).
Fixes http://code.google.com/p/chromium/issues/detail?id=121405
Reviewed at http://codereview.appspot.com/
5989070/
git-svn-id: http://skia.googlecode.com/svn/trunk@3658
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 12 Apr 2012 13:52:14 +0000 (13:52 +0000)]
always check the result of SkMatrix::invert
git-svn-id: http://skia.googlecode.com/svn/trunk@3657
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 12 Apr 2012 13:46:51 +0000 (13:46 +0000)]
rebaseline
git-svn-id: http://skia.googlecode.com/svn/trunk@3656
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 12 Apr 2012 13:24:30 +0000 (13:24 +0000)]
detect when pathmeasure fails, and don't access uninitialized tangent
git-svn-id: http://skia.googlecode.com/svn/trunk@3655
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 12 Apr 2012 13:24:04 +0000 (13:24 +0000)]
Decouple the SkFlattenable from SkReader32/SkWriter32.
The current impl for SkFlattenable read/write buffers is
that they extend from SkReader32 and SkWriter32, but that
dependency must be abstract if we are to add any other
serialization format.
Review URL: https://codereview.appspot.com/
5999045
git-svn-id: http://skia.googlecode.com/svn/trunk@3654
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 12 Apr 2012 13:13:48 +0000 (13:13 +0000)]
these need to be rebaselined (acceptable change due to rev. 3652)
git-svn-id: http://skia.googlecode.com/svn/trunk@3653
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 12 Apr 2012 12:51:32 +0000 (12:51 +0000)]
allow the tolerance to be zero for nearlyzero
git-svn-id: http://skia.googlecode.com/svn/trunk@3652
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 11 Apr 2012 18:16:41 +0000 (18:16 +0000)]
Add support for GL_NV_framebuffer_multisample_coverage
Review URL: http://codereview.appspot.com/
6005043
git-svn-id: http://skia.googlecode.com/svn/trunk@3651
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 11 Apr 2012 17:51:01 +0000 (17:51 +0000)]
Fix SkPathStroker::lineTo() for line with length SK_ScalarNearlyZero
Review URL: https://codereview.appspot.com/
5992077
git-svn-id: http://skia.googlecode.com/svn/trunk@3650
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 11 Apr 2012 15:34:46 +0000 (15:34 +0000)]
add circle benchmark
Committed on behalf of Guanqun.Lu@gmail.com
Review URL: http://codereview.appspot.com/
5999047/
git-svn-id: http://skia.googlecode.com/svn/trunk@3649
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 10 Apr 2012 21:03:23 +0000 (21:03 +0000)]
Make it possible to share a comparison func with both SkTSearch and SkQSort
Review URL: http://codereview.appspot.com/
6006043/
git-svn-id: http://skia.googlecode.com/svn/trunk@3648
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 10 Apr 2012 19:26:38 +0000 (19:26 +0000)]
Updated blur to use A8/R8 (instead of RGBA8) when available - this provides a performance gain for large blurs
http://codereview.appspot.com/
5988071/
git-svn-id: http://skia.googlecode.com/svn/trunk@3647
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 10 Apr 2012 19:16:21 +0000 (19:16 +0000)]
Since we only have 1 proc for SA8_alpha_D32 (i.e. no opaque special-case) we
remove the bogus assert from CHECKSTATE.
git-svn-id: http://skia.googlecode.com/svn/trunk@3646
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Tue, 10 Apr 2012 19:14:48 +0000 (19:14 +0000)]
Clean up more Visual Studio warnings, including apparent bug in Arithmetic mode.
git-svn-id: http://skia.googlecode.com/svn/trunk@3645
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 10 Apr 2012 18:32:35 +0000 (18:32 +0000)]
Minor Windows compiler complaint fixes
http://codereview.appspot.com/
5988072/
git-svn-id: http://skia.googlecode.com/svn/trunk@3644
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 10 Apr 2012 18:28:55 +0000 (18:28 +0000)]
shape ops work in progress
more quadratics work
git-svn-id: http://skia.googlecode.com/svn/trunk@3643
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Tue, 10 Apr 2012 17:42:21 +0000 (17:42 +0000)]
Fix miscellaneous compiler warnings from Visual Studio 2010.
Changes serialization path for MorphologyImageFilter, handling of Windows
HRESULTS; otherwise just tweaks tests.
git-svn-id: http://skia.googlecode.com/svn/trunk@3642
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 10 Apr 2012 17:25:44 +0000 (17:25 +0000)]
Clamp dilate and erode radius to image width and height.
NOTE: This will require new baselines for the morphology GM.
git-svn-id: http://skia.googlecode.com/svn/trunk@3641
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 10 Apr 2012 16:20:41 +0000 (16:20 +0000)]
misc fixes
Submitted on behalf of Guanqun.Lu@gmail.com
Review URL: http://codereview.appspot.com/
5988070/
git-svn-id: http://skia.googlecode.com/svn/trunk@3640
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 10 Apr 2012 15:56:29 +0000 (15:56 +0000)]
Tear down Gr stuff before GL context in SampleApp
Review URL: http://codereview.appspot.com/
6000043/
git-svn-id: http://skia.googlecode.com/svn/trunk@3639
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 10 Apr 2012 13:34:11 +0000 (13:34 +0000)]
Minor bug fix in SampleApp
http://codereview.appspot.com/
5992081/
git-svn-id: http://skia.googlecode.com/svn/trunk@3638
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 9 Apr 2012 22:33:11 +0000 (22:33 +0000)]
Warn when ignoring result of SkMatrix::invert.
http://codereview.appspot.com/
5989067/
git-svn-id: http://skia.googlecode.com/svn/trunk@3637
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Apr 2012 21:40:54 +0000 (21:40 +0000)]
Don't use the usage flag to determine whether an SkGpuDevice needs to be cleared. Fixes regression in testimagefilters introduced by r3565. Also add baselines for testimagefilters gm on windows.
git-svn-id: http://skia.googlecode.com/svn/trunk@3635
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 9 Apr 2012 20:49:03 +0000 (20:49 +0000)]
Stroked text should check inverse return.
http://codereview.appspot.com/
5986067/
git-svn-id: http://skia.googlecode.com/svn/trunk@3633
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 9 Apr 2012 20:20:10 +0000 (20:20 +0000)]
change -d option to write out complete images (that differed from the baseline)
git-svn-id: http://skia.googlecode.com/svn/trunk@3632
2bbb7eff-a529-9590-31e7-
b0007b416f81