platform/upstream/nodejs.git
11 years agohttps: fix default port
Koichi Kobayashi [Sun, 4 Aug 2013 06:39:50 +0000 (15:39 +0900)]
https: fix default port

https.get('https://github.com/') should use port 443, not 80.

11 years agohttp: Fix overlooked agent.globalAgent export
isaacs [Mon, 5 Aug 2013 19:33:19 +0000 (12:33 -0700)]
http: Fix overlooked agent.globalAgent export

Noticed by @bnoordhuis in https://github.com/joyent/node/pull/5991#discussion_r5575946

11 years agov8: fix openbsd build
Ben Noordhuis [Mon, 5 Aug 2013 00:50:45 +0000 (02:50 +0200)]
v8: fix openbsd build

This is [1] applied ahead of time. Summary:

    OpenBSD doesn't have <ucontext.h>. ucontext_t lives in <signal.h>
    and is a typedef for struct sigcontext. There is no uc_mcontext.

[1] https://codereview.chromium.org/21705003/

11 years agotls: fix handling of `SNICallback` server option
Fedor Indutny [Fri, 2 Aug 2013 16:11:17 +0000 (20:11 +0400)]
tls: fix handling of `SNICallback` server option

It shouldn't ignore it!

There're two possibile cases, which should be handled properly:

1. Having a default `SNICallback` which is using contexts, added with
  `server.addContext(...)` routine
2. Having a custom `SNICallback`.

In first case we may want to opt-out setting `.onsniselect` method (and
thus save some CPU time), if there're no contexts added. But, if custom
`SNICallback` is used, `.onsniselect` should always be set, because
server contexts don't affect it.

11 years agosrc: use static_cast for void-to-T casts
Ben Noordhuis [Sat, 3 Aug 2013 20:50:15 +0000 (22:50 +0200)]
src: use static_cast for void-to-T casts

Code cleanup, replace a few uses of reinterpret_cast<T*>(void_ptr) with
static_cast<T*>(void_ptr).

11 years agosrc: use PersistentToLocal() in a few more places
Ben Noordhuis [Sat, 3 Aug 2013 20:18:35 +0000 (22:18 +0200)]
src: use PersistentToLocal() in a few more places

Update a few more `Local<T>::New(isolate, persistent)` call sites to
`PersistentToLocal(isolate, persistent)` - the latter has a fast path
for non-weak persistent references.

11 years agocrypto: fix another over-run in bio
Fedor Indutny [Sat, 3 Aug 2013 09:09:02 +0000 (13:09 +0400)]
crypto: fix another over-run in bio

When doing `FreeEmpty`, `NodeBIO` skips pre-allocated `head_` buffer.
However this might lead to double-freeing buffers since in `~NodeBIO()`
we're starting deallocation from `head_` buffer.

11 years agosrc: remove non-isolate PersistentToLocal(), v2
Ben Noordhuis [Fri, 2 Aug 2013 23:28:51 +0000 (01:28 +0200)]
src: remove non-isolate PersistentToLocal(), v2

Commit 78d9094 updated src/*.cc to use the version of PersistentToLocal
that takes a v8::Isolate* as its first argument. This commit removes
the non-isolate version.

11 years agoprocess: set key properties as ReadOnly
Trevor Norris [Thu, 1 Aug 2013 21:53:52 +0000 (14:53 -0700)]
process: set key properties as ReadOnly

11 years agosrc: remove non-isolate PersistentToLocal()
Ben Noordhuis [Fri, 2 Aug 2013 21:12:56 +0000 (23:12 +0200)]
src: remove non-isolate PersistentToLocal()

There is no need for it and it's a tiny bit slower than the version of
PersistentToLocal() that takes a v8::Isolate* as its first argument.

11 years agosmalloc: remove double checks
Trevor Norris [Fri, 2 Aug 2013 20:00:54 +0000 (13:00 -0700)]
smalloc: remove double checks

Now that values are checks in JS, no need for them to be checked in C++.

11 years agosmalloc: fix assertion fails/segfault
Trevor Norris [Fri, 2 Aug 2013 19:52:43 +0000 (12:52 -0700)]
smalloc: fix assertion fails/segfault

* Numeric values passed to alloc were converted to int32, not uint32
  before the range check, which allows wrap around on ToUint32. This
  would cause massive malloc calls and v8 fatal errors.
* dispose would not check if value was an Object, causing segfault if a
  Primitive was passed.
* kMaxLength was not enumerable.

11 years agoutil: add isPrimitive check
Trevor Norris [Fri, 2 Aug 2013 19:52:34 +0000 (12:52 -0700)]
util: add isPrimitive check

11 years agobuild: fix --without-ssl build
Ben Noordhuis [Fri, 2 Aug 2013 11:52:20 +0000 (13:52 +0200)]
build: fix --without-ssl build

Build breakage accidentally introduced in 8e29ce9 during code cleanup.

HAVE_OPENSSL is always defined (as either 0 or 1) so use #if rather
than #ifdef.

Fixes #5979.

11 years agosrc: Replace macros with util functions
isaacs [Fri, 26 Jul 2013 21:38:08 +0000 (14:38 -0700)]
src: Replace macros with util functions

11 years agobenchmark: update misc to new v8 API
Trevor Norris [Thu, 1 Aug 2013 22:02:38 +0000 (15:02 -0700)]
benchmark: update misc to new v8 API

11 years agotest: add mac to test-os
Trevor Norris [Thu, 1 Aug 2013 20:53:19 +0000 (13:53 -0700)]
test: add mac to test-os

Fix test from 30701d6.

11 years agotls_wrap: parse tls session ticket extension
Fedor Indutny [Sun, 21 Jul 2013 16:16:26 +0000 (23:16 +0700)]
tls_wrap: parse tls session ticket extension

And, if present and non-empty, don't invoke `resumeSession` callback.

fix #5872

11 years agoos: add mac address to networkInterfaces() output
Brian White [Wed, 31 Jul 2013 23:13:36 +0000 (19:13 -0400)]
os: add mac address to networkInterfaces() output

11 years agocpplint: exclude src/node_win32_perfctr_provider.cc
Ben Noordhuis [Thu, 1 Aug 2013 10:33:33 +0000 (12:33 +0200)]
cpplint: exclude src/node_win32_perfctr_provider.cc

It's forced to violate the build/include_order rule because it includes
a header file generated with ctrpp.exe that doesn't include perflib.h
itself.

11 years agosrc: don't include <string.h> twice in src/node.cc
Ben Noordhuis [Thu, 1 Aug 2013 10:26:23 +0000 (12:26 +0200)]
src: don't include <string.h> twice in src/node.cc

11 years agobuild: disable some msvc compiler warnings
Bert Belder [Thu, 1 Aug 2013 09:53:41 +0000 (11:53 +0200)]
build: disable some msvc compiler warnings

These are not real problems, and they are so plenty that actual problems
are hidden from view.

11 years agobuild: un-break the windows build
Bert Belder [Thu, 1 Aug 2013 09:39:25 +0000 (11:39 +0200)]
build: un-break the windows build

11 years agosrc: more lint after cpplint tightening
Ben Noordhuis [Wed, 31 Jul 2013 21:16:08 +0000 (23:16 +0200)]
src: more lint after cpplint tightening

Commit 847c6d9 adds a 'project headers before system headers' check
to cpplint. Update the files in src/ to make the linter pass again.

11 years agotools: cpplint: fix up build/include_order rule
Ben Noordhuis [Wed, 31 Jul 2013 20:34:34 +0000 (22:34 +0200)]
tools: cpplint: fix up build/include_order rule

Change the build/include_order rule to match our preference:
project headers before system headers.

The rationale is that system headers before project headers makes it
easy to slip in bugs where a project header that requires a definition
from a system header, forgets to include the system header but still
compiles because the source files that include the project header
coincidentally include the system header too.

A good example is the size_t type. A project header file that needs the
definition of size_t should include stddef.h but forgetting to do so
will probably go unnoticed for a long time because almost every other
system header includes stddef.h (either directly or indirectly) and
almost every source file includes one or more system headers.

Ergo, project headers before system headers. It's a good thing.

11 years agodoc: remove travis status image
Antony Bailey [Wed, 31 Jul 2013 18:28:29 +0000 (19:28 +0100)]
doc: remove travis status image

The project has moved to Jenkins. The status image is no longer
needed and perpetually shows a failed build. Remove it.

11 years agoetw_provider: unbreak windows build
Fedor Indutny [Wed, 31 Jul 2013 18:35:46 +0000 (22:35 +0400)]
etw_provider: unbreak windows build

11 years agomake: add `cpplint` to `test` target
Fedor Indutny [Wed, 31 Jul 2013 10:54:06 +0000 (14:54 +0400)]
make: add `cpplint` to `test` target

Also, exclude some C-headers, machine generated headers and tweaked
sources from cpplint file list.

11 years agosrc: lint c++ code
Fedor Indutny [Wed, 31 Jul 2013 18:07:29 +0000 (22:07 +0400)]
src: lint c++ code

11 years agocpplint: make lint rules closer to node's source
Fedor Indutny [Wed, 31 Jul 2013 18:05:31 +0000 (22:05 +0400)]
cpplint: make lint rules closer to node's source

* Support C-style header guards (/* comments */)
* Support `class NODE_EXTERN something`
* Support `}  // extern "C"` closures
* Ignore header order
* Ignore `long/short` usage (because of OpenSSL's API)

11 years agonode: add inTick and lastThrew to infoBox
Trevor Norris [Tue, 30 Jul 2013 22:06:45 +0000 (15:06 -0700)]
node: add inTick and lastThrew to infoBox

To prevent all unnecessary calls to JS from MakeCallback, the remaining
two immediate return variables inTick and lastThrew have been added to
infoBox. Now MakeCallback should never need to call into JS unless it
absolutely has to.

Also removed Tock. Performance tests showed it was at least as fast or
faster than using a normal object, and this is more readable.

11 years agoutil: don't throw on circular %j input to format()
Ben Noordhuis [Mon, 29 Jul 2013 19:00:33 +0000 (21:00 +0200)]
util: don't throw on circular %j input to format()

Don't throw an exception when the argument to %j is an object that
contains circular references, it's not helpful. Catch the exception
and return the string '[Circular]'.

11 years agofs: write strings directly to disk
Trevor Norris [Tue, 2 Jul 2013 07:27:26 +0000 (00:27 -0700)]
fs: write strings directly to disk

Prior, strings would first be converted to a Buffer before being written
to disk. Now the intermediary step has been removed.

Other changes of note:

* Class member "must_free" was added to req_wrap so to track if the
  memory needs to be manually cleaned up after use.
* External String Resource support, so the memory will be used directly
  instead of copying out the data.
* Docs have been updated to reflect that if position is not a number
  then it will assume null. Previously it specified the argument must be
  null, but that was not how the code worked. An attempt was made to
  only support == null, but there were too many tests that assumed !=
  number would be enough.
* Docs update show some of the write/writeSync arguments are optional.

11 years agostring_bytes: export GetExternalParts
Trevor Norris [Tue, 2 Jul 2013 07:07:47 +0000 (00:07 -0700)]
string_bytes: export GetExternalParts

The method is useful elsewhere when needing to check if external and
grab data.

11 years agodeps: upgrade libuv to joyent/libuv@4bdb7d8
Ben Noordhuis [Tue, 30 Jul 2013 21:32:53 +0000 (23:32 +0200)]
deps: upgrade libuv to joyent/libuv@4bdb7d8

Non-release upgrade so pending patches can land.

11 years agocrypto: simplify DH modp group name matcher
Ben Noordhuis [Mon, 29 Jul 2013 18:36:11 +0000 (20:36 +0200)]
crypto: simplify DH modp group name matcher

* Use ARRAY_SIZE() rather than scanning until we hit a NULL entry.
* Fix `-fsigned-char -Wnarrowing` compiler warnings. Harmless but
  numerous and annoying.
* Static-ify the modp_group and mod_groups arrays.
* Const-ify the modp_groups array.

11 years agosrc: const-ify variables in src/node_crypto*
Ben Noordhuis [Tue, 30 Jul 2013 19:42:47 +0000 (21:42 +0200)]
src: const-ify variables in src/node_crypto*

No functional changes, just some code tightening. Clean up some style
inconsistencies while we are here.

11 years agosrc: remove unused import in src/node_os.cc
Ben Noordhuis [Tue, 30 Jul 2013 19:32:43 +0000 (21:32 +0200)]
src: remove unused import in src/node_os.cc

11 years agostring_bytes: don't use named imports in header
Ben Noordhuis [Tue, 30 Jul 2013 19:28:43 +0000 (21:28 +0200)]
string_bytes: don't use named imports in header

It imports the definition into every source file that includes
string_bytes.h, as evidenced by the build suddenly breaking left
and right because of missing Handle/Local/String/Value imports.

11 years agov8: upgrade v8 to 3.20.11
Ben Noordhuis [Tue, 30 Jul 2013 15:14:55 +0000 (17:14 +0200)]
v8: upgrade v8 to 3.20.11

11 years agoMerge remote-tracking branch 'origin/v0.10'
Ben Noordhuis [Tue, 30 Jul 2013 13:19:48 +0000 (15:19 +0200)]
Merge remote-tracking branch 'origin/v0.10'

Conflicts:
AUTHORS
ChangeLog
deps/uv/ChangeLog
deps/uv/src/version.c
deps/uv/src/win/fs.c
src/node.cc
src/node_crypto.cc
src/node_os.cc
src/node_version.h

11 years agocrypto: fix assert() on malformed hex input
Ben Noordhuis [Tue, 30 Jul 2013 12:27:13 +0000 (14:27 +0200)]
crypto: fix assert() on malformed hex input

Use the StringBytes::IsValidString() function introduced in commit
dce26cc to ensure that the input string meets the expectations of the
other StringBytes functions before processing it further.

Fixes the following assertion:

    Assertion failed: (str->Length() % 2 == 0 && "invalid hex string
    length"), function StorageSize, file ../../src/string_bytes.cc,
    line 301.

Fixes #5725.

11 years agostring_bytes: add StringBytes::IsValidString()
Ben Noordhuis [Tue, 30 Jul 2013 12:26:11 +0000 (14:26 +0200)]
string_bytes: add StringBytes::IsValidString()

Performs a quick, non-exhaustive check on the input string to see if
it's compatible with the specified string encoding.

Curently it only checks that hex strings have a length that is a
multiple of two.

11 years agoassert: replace !!!value with just !value
Ben Noordhuis [Tue, 30 Jul 2013 11:28:48 +0000 (13:28 +0200)]
assert: replace !!!value with just !value

Not harmful, just code cleanup.

Fixes #5885.

11 years agodgram: report send errors to cb, don't pass bytes
Ben Noordhuis [Wed, 26 Jun 2013 22:43:23 +0000 (00:43 +0200)]
dgram: report send errors to cb, don't pass bytes

Passing the number of sent bytes to the callback is superfluous;
datagram sockets operate in atomic mode: either the sendmsg() system
call succeeds or it fails but it never does partial writes.

Instead, report send errors to the callback. UDP error reporting is
fairly haphazard on most platforms. You should not expect reliable
delivery of anything besides EMSGSIZE and (possibly) ENETDOWN and
ENETUNREACH.

Fixes #2608.

11 years agosrc: don't use NewExternal() with unaligned strings
Ben Noordhuis [Mon, 29 Jul 2013 03:07:07 +0000 (05:07 +0200)]
src: don't use NewExternal() with unaligned strings

V8 3.20.9 enforces that external pointers are aligned on a two-byte
boundary.

We cannot portably guarantee that for the source code strings that
tools/js2c.py generates so simply stop using String::NewExternal()
altogether (and by extension String::ExternalAsciiStringResource).

Fixes the following run-time assert:

  FATAL ERROR: v8::String::NewExternal() Pointer is not aligned

11 years agov8: upgrade to v8 3.20.9
Ben Noordhuis [Mon, 29 Jul 2013 19:21:03 +0000 (21:21 +0200)]
v8: upgrade to v8 3.20.9

11 years agodoc: vm: fix incorrect API documentation
Andrew Paprocki [Mon, 29 Jul 2013 15:34:12 +0000 (17:34 +0200)]
doc: vm: fix incorrect API documentation

On timeout, an Error object is thrown, not null.

11 years agochild_process: add 'shell' option to .exec()
Ben Noordhuis [Mon, 29 Jul 2013 14:20:24 +0000 (16:20 +0200)]
child_process: add 'shell' option to .exec()

No test, we can't rely on an alternate shell being available.

Fixes #5935.

11 years agotest: loosen timeout in https-no-reader
Fedor Indutny [Mon, 29 Jul 2013 09:33:01 +0000 (13:33 +0400)]
test: loosen timeout in https-no-reader

fix #5925

11 years agosrc: remove unused tick_spinner
Ben Noordhuis [Sun, 28 Jul 2013 17:07:59 +0000 (19:07 +0200)]
src: remove unused tick_spinner

11 years agotest: cluster: add 'bind to privileged port' tests
Ben Noordhuis [Sun, 28 Jul 2013 12:50:03 +0000 (14:50 +0200)]
test: cluster: add 'bind to privileged port' tests

11 years agocluster: fix shared handle bind error propagation
Ben Noordhuis [Sun, 28 Jul 2013 10:19:34 +0000 (12:19 +0200)]
cluster: fix shared handle bind error propagation

A failed bind() was already being correctly reported in round-robin
mode. This commit fixes bind() error reporting in shared handle mode.

Fixes #5774.

11 years agocluster: remove duplicate this.errno assignment
Ben Noordhuis [Sun, 28 Jul 2013 09:36:12 +0000 (11:36 +0200)]
cluster: remove duplicate this.errno assignment

11 years agodoc: clarify fs.read() offset argument
Ben Noordhuis [Sat, 27 Jul 2013 22:05:10 +0000 (00:05 +0200)]
doc: clarify fs.read() offset argument

11 years agodoc: add nodejs.geek.nz to the community page
Andrew Chilton [Sat, 27 Jul 2013 11:13:55 +0000 (23:13 +1200)]
doc: add nodejs.geek.nz to the community page

11 years agodoc: add nodejs.org.au to community listing
Rod Vagg [Sat, 27 Jul 2013 05:20:08 +0000 (15:20 +1000)]
doc: add nodejs.org.au to community listing

11 years agodoc: document possible return values of os.arch()
Maciej Małecki [Fri, 26 Jul 2013 21:48:57 +0000 (23:48 +0200)]
doc: document possible return values of os.arch()

11 years agodoc: Fix missing backtick in debugger doc
Dav Glass [Wed, 24 Jul 2013 18:17:28 +0000 (13:17 -0500)]
doc: Fix missing backtick in debugger doc

11 years agostreams: Don't emit 'end' until read() past EOF
isaacs [Wed, 24 Jul 2013 23:05:54 +0000 (16:05 -0700)]
streams: Don't emit 'end' until read() past EOF

This prevents the following sort of thing from being confusing:

```javascript
stream.on('data', function() { console.error('got data'); });
stream.pause(); // stop reading

// turns out no data is available
stream.push(null);

// Hand the stream to someone else, who does stuff...
setTimeout(function() {
  // too late! 'end' is already emitted!
  stream.on('end', function() { console.error('got end'); });
});
```

With this change, the `end` event is not emitted until you call `read()`
*past* the EOF null.  So, a paused stream will not swallow the `end`
event and emit it before you `resume()` the stream.

11 years agoopenssl: use asm for sha, md5, rmd
Fedor Indutny [Thu, 25 Jul 2013 14:27:26 +0000 (18:27 +0400)]
openssl: use asm for sha, md5, rmd

11 years agotest: fix simple/test-setproctitle
Ben Noordhuis [Thu, 25 Jul 2013 10:24:40 +0000 (12:24 +0200)]
test: fix simple/test-setproctitle

The title shouldn't be too long; libuv's uv_set_process_title() out of
security considerations no longer overwrites envp, only argv, so the
maximum title length is possibly quite short.

Fixes #5908.

11 years agoblog: Post for v0.10.15
Timothy J Fontaine [Fri, 26 Jul 2013 00:03:21 +0000 (17:03 -0700)]
blog: Post for v0.10.15

11 years agoNow working on 0.10.16
Timothy J Fontaine [Fri, 26 Jul 2013 00:03:03 +0000 (17:03 -0700)]
Now working on 0.10.16

11 years agoMerge branch 'v0.10.15-release' into v0.10
Timothy J Fontaine [Fri, 26 Jul 2013 00:02:38 +0000 (17:02 -0700)]
Merge branch 'v0.10.15-release' into v0.10

11 years ago2013.07.25, Version 0.10.15 (Stable) v0.10.15
Timothy J Fontaine [Thu, 25 Jul 2013 23:26:15 +0000 (16:26 -0700)]
2013.07.25, Version 0.10.15 (Stable)

* src: fix process.getuid() return value (Ben Noordhuis)

11 years agosrc: fix process.getuid() return value
Ben Noordhuis [Thu, 25 Jul 2013 22:24:27 +0000 (00:24 +0200)]
src: fix process.getuid() return value

And process.getgid() too.

Commit ed80638 changed fs.chown() and fs.fchown() to only accept
unsigned integers. Make process.getuid() and process.getgid() follow
suit.

This commit should unbreak npm on OS X - it's hitting the new 'uid must
be an unsigned int' check when installing as e.g. user 'nobody' (which
has an UID of -2 in /etc/passwd or 4294967294 when cast to an uid_t.)

Fixes #5904.

11 years agodoc: document tls.Server 'secureProtocol' option
Ben Noordhuis [Thu, 25 Jul 2013 21:21:52 +0000 (23:21 +0200)]
doc: document tls.Server 'secureProtocol' option

11 years agoblog: Post for v0.10.14
Timothy J Fontaine [Thu, 25 Jul 2013 20:54:55 +0000 (13:54 -0700)]
blog: Post for v0.10.14

11 years agoNow working on 0.10.15
Timothy J Fontaine [Thu, 25 Jul 2013 20:54:16 +0000 (13:54 -0700)]
Now working on 0.10.15

11 years agoMerge branch 'v0.10.14-release' into v0.10
Timothy J Fontaine [Thu, 25 Jul 2013 20:53:45 +0000 (13:53 -0700)]
Merge branch 'v0.10.14-release' into v0.10

11 years ago2013.07.25, Version 0.10.14 (Stable) v0.10.14
Timothy J Fontaine [Thu, 25 Jul 2013 18:49:01 +0000 (11:49 -0700)]
2013.07.25, Version 0.10.14 (Stable)

* uv: Upgrade to v0.10.13

* npm: Upgrade to v1.3.5

* os: Don't report negative times in cpu info (Ben Noordhuis)

* fs: Handle large UID and GID (Ben Noordhuis)

* url: Fix edge-case when protocol is non-lowercase (Shuan Wang)

* doc: Streams API Doc Rewrite (isaacs)

* node: call MakeDomainCallback in all domain cases (Trevor Norris)

* crypto: fix memory leak in LoadPKCS12 (Fedor Indutny)

11 years agouv: Upgrade to v0.10.13
Timothy J Fontaine [Thu, 25 Jul 2013 17:48:29 +0000 (10:48 -0700)]
uv: Upgrade to v0.10.13

11 years agotls: share tls tickets key between cluster workers
Fedor Indutny [Sun, 21 Jul 2013 03:11:02 +0000 (10:11 +0700)]
tls: share tls tickets key between cluster workers

fix #5871

11 years agocluster: support setting data on shared server
Fedor Indutny [Sun, 21 Jul 2013 03:09:47 +0000 (10:09 +0700)]
cluster: support setting data on shared server

If `obj` given to `cluster._getServer` has `_setServerData` or
`_getServerData` methods, the data will be synchronized across workers
and stored in master.

11 years agodoc: explicitly set industry logo height
isaacs [Wed, 24 Jul 2013 20:37:20 +0000 (13:37 -0700)]
doc: explicitly set industry logo height

11 years agonpm: Upgrade to v1.3.5
isaacs [Wed, 24 Jul 2013 20:23:44 +0000 (13:23 -0700)]
npm: Upgrade to v1.3.5

11 years agosrc: move NODE_MODULE_VERSION to node_version.h
Ben Noordhuis [Wed, 24 Jul 2013 20:13:43 +0000 (22:13 +0200)]
src: move NODE_MODULE_VERSION to node_version.h

11 years agolib: macro-ify type checks
Ben Noordhuis [Wed, 24 Jul 2013 16:03:53 +0000 (18:03 +0200)]
lib: macro-ify type checks

Increases the grep factor. Makes it easier to harmonize type checks
across the code base.

11 years agotools: fix js2c macro expansion bug
Ben Noordhuis [Wed, 24 Jul 2013 16:13:25 +0000 (18:13 +0200)]
tools: fix js2c macro expansion bug

If the same macro was used twice in close proximity, the second one
didn't get expanded.

11 years agosrc: rename macros.py to notrace_macros.py
Ben Noordhuis [Wed, 24 Jul 2013 10:53:28 +0000 (12:53 +0200)]
src: rename macros.py to notrace_macros.py

This incarnation of macros.py is only used to disable the (d)trace
macros. Rename it so it better reflects its purpose. A new macros.py
will be added in a follow-up commit.

11 years agosrc: cares_wrap: remove two unused variables
Ben Noordhuis [Wed, 24 Jul 2013 16:48:48 +0000 (18:48 +0200)]
src: cares_wrap: remove two unused variables

11 years agosmalloc: add external to alloc with callbacks
Trevor Norris [Tue, 23 Jul 2013 23:56:22 +0000 (16:56 -0700)]
smalloc: add external to alloc with callbacks

Forgot to actually assign cb_info to the External in smalloc::Alloc()
that accepts a callback to be run in the weak callback.

11 years agobuffer: misc logic simplification
Trevor Norris [Tue, 23 Jul 2013 18:02:47 +0000 (11:02 -0700)]
buffer: misc logic simplification

Includes:
* No need for `typeof` when checking undefined.
* length is coerced to uint so no need to check if < 0.
* Stay consistent and always throw `new` errors.
* Returning offset + magic number in every write is error prone. Instead
  return the central write function which returns the correct offset.

11 years agobuffer: revert length and parent check
Trevor Norris [Tue, 23 Jul 2013 17:43:48 +0000 (10:43 -0700)]
buffer: revert length and parent check

In a rush to implement the fix 35e0d60 I overlooked the logic that
causes 0-length buffer instantiation to automatically not assign the
parent regardless.

11 years agosrc: os: use Number::New() for CPU info
Ben Noordhuis [Tue, 23 Jul 2013 15:09:09 +0000 (17:09 +0200)]
src: os: use Number::New() for CPU info

The return values from uv_cpu_info() don't necessarily fit in a 32 bits
signed integer.

Fixes #5732.

11 years agofs: uids and gids must be unsigned ints
Ben Noordhuis [Tue, 23 Jul 2013 11:28:14 +0000 (13:28 +0200)]
fs: uids and gids must be unsigned ints

Before this commit, fs.chown() and fs.fchown() coerced the uid and gid
arguments to signed integers which is wrong because uid_t and gid_t are
unsigned on most all platforms and IDs that don't fit in a signed
integer do exist.

This commit changes the aforementioned functions to take unsigned ints
instead.  No test because we can't assume the system has [GU]IDs that
large.

This change depends on joyent/libuv@d779eb5.

Fixes #5890.

11 years agocrypto: Add test for sha.write(''); sha.end()
David Björklund [Thu, 4 Jul 2013 14:22:31 +0000 (16:22 +0200)]
crypto: Add test for sha.write(''); sha.end()

11 years agobuffer: slice on zero length buffer
Trevor Norris [Tue, 23 Jul 2013 00:04:17 +0000 (17:04 -0700)]
buffer: slice on zero length buffer

SlowBuffer(0) passes NULL instead of doing malloc(0). So when someone
attempted to SlowBuffer(0).slice(0, 1) an assert would fail in
smalloc::SliceOnto.

It's important that the check go where it is because the resulting
Buffer needs to have external array data allocated. In the case a user
tries to slice a zero length Buffer it will also have NULL passed as the
data argument.

Also fixed where the .parent attribute was set for zero length Buffers.
There is no need to track the source of slice if the slice isn't
actually occurring.

11 years agostream: Simplify flowing, passive data listening
isaacs [Thu, 18 Jul 2013 01:24:02 +0000 (18:24 -0700)]
stream: Simplify flowing, passive data listening

Closes #5860

In streams2, there is an "old mode" for compatibility.  Once switched
into this mode, there is no going back.

With this change, there is a "flowing mode" and a "paused mode".  If you
add a data listener, then this will start the flow of data.  However,
hitting the `pause()` method will switch *back* into a non-flowing mode,
where the `read()` method will pull data out.

Every time `read()` returns a data chunk, it also emits a `data` event.
In this way, a passive data listener can be added, and the stream passed
off to some other reader, for use with progress bars and the like.

There is no API change beyond this added flexibility.

11 years agoutil: removed duplicated isArray check
Wyatt Preul [Sat, 20 Jul 2013 05:56:31 +0000 (00:56 -0500)]
util: removed duplicated isArray check

11 years agov8: reapply floating patches
Ben Noordhuis [Wed, 3 Jul 2013 02:23:36 +0000 (04:23 +0200)]
v8: reapply floating patches

11 years agosrc: update v8 build requirements
Trevor Norris [Mon, 22 Jul 2013 22:53:43 +0000 (15:53 -0700)]
src: update v8 build requirements

In v8 3.20.4 build/common.gypi was moved to build/toolchain.gypi and
build/features.gypi.

11 years agov8: upgrade to v8 3.20.7
Trevor Norris [Mon, 22 Jul 2013 22:26:27 +0000 (15:26 -0700)]
v8: upgrade to v8 3.20.7

11 years agosrc: fix windows build error from 221c689e
Ben Noordhuis [Sat, 20 Jul 2013 19:42:20 +0000 (21:42 +0200)]
src: fix windows build error from 221c689e

Just forward declare struct sockaddr, the struct is never actually
dereferenced in src/node_internals.h.

Before this commit, it included sys/socket.h but that header doesn't
exist on Windows.

11 years agotest: move two tests from simple/ to internet/
Ben Noordhuis [Sat, 20 Jul 2013 10:34:53 +0000 (12:34 +0200)]
test: move two tests from simple/ to internet/

Fixes #5876.

11 years agobench: fix up benchmarks after internal api change
Ben Noordhuis [Fri, 19 Jul 2013 21:59:41 +0000 (23:59 +0200)]
bench: fix up benchmarks after internal api change

11 years agotest: fix up tests after internal api change
Ben Noordhuis [Fri, 19 Jul 2013 21:33:06 +0000 (23:33 +0200)]
test: fix up tests after internal api change

11 years agosrc, lib: update after internal api change
Ben Noordhuis [Thu, 18 Jul 2013 21:18:50 +0000 (23:18 +0200)]
src, lib: update after internal api change

Libuv now returns errors directly.  Make everything in src/ and lib/
follow suit.

The changes to lib/ are not strictly necessary but they remove the need
for the abominations that are process._errno and node::SetErrno().

11 years agosrc, lib: deduplicate errnoException
Ben Noordhuis [Tue, 16 Jul 2013 21:28:38 +0000 (23:28 +0200)]
src, lib: deduplicate errnoException