Daniel Kolesa [Sun, 26 May 2019 16:19:20 +0000 (18:19 +0200)]
eolian: add API to query unit version
Daniel Kolesa [Sun, 26 May 2019 16:09:34 +0000 (18:09 +0200)]
eolian: initial versioning implementation
This implements initial support for specifying unit versions.
The default version is 1, specifying the basic feature level.
If you want to specify another version, you need to specify
something like `#version 2` at the beginning of the .eo or
.eot file; the version number must be higher than 0 and lower
than USHRT_MAX (typically 65536).
The beginning of the file is now called the "header section";
other things may be added into the header section later.
Version cannot be specified twice, and it cannot be specified
once other contents (like types or class definition) appear.
Comments do not count as other contents, so those are fine
to appear before #version.
@feature
Daniel Kolesa [Sun, 26 May 2019 15:41:22 +0000 (17:41 +0200)]
eolian: rename @warn_unused and its associated API
@warn_unused in syntax is now called @no_unused - this is because
"warning about unused" is a C thing (or rather, an extension to C)
and various languages might want to use stricter behavior for this.
Its associated API does the reverse now - it lets you query whether
being unused is allowed at all. This is to match future behavior
of Eolian (once it supports versioning) that will likely reverse it.
@feature
Daniel Kolesa [Sun, 26 May 2019 15:25:15 +0000 (17:25 +0200)]
eolian: remove param @nonull
This has been deprecated for a while and is not strictly necessary
- as a part of an effort to stabilize Eolian, remove this. Eolian
will eventually gain support for versioning and use a reversed
behavior (i.e. no NULL by default), but the API it wlll use for
that will be very different. Features can always be added, it's
much harder to drop them.
@feature
Xavi Artigas [Fri, 24 May 2019 16:30:31 +0000 (12:30 -0400)]
Rename Efl.Ui.Direction -> Efl.Ui.Layout_Orientation
Summary:
This clarifies a bit the whole Orientation vs. Direction confusion, at the
expense of longer names (Image_Orientation vs. Layout_Orientation).
Also, the interfaces are now adjectives (Orientable) and the enums have long
names (*_Orientation).
Pretty big patch, but no functional changes.
Relates to T7863
Test Plan:
Everything builds and passes tests.
Elementary_tests show same behavior, including the "inverted" widgets, which
are the only parts which received a bit of code changes.
Proof:
https://travis-ci.org/Enlightenment/efl/builds/
536277282
Reviewers: zmike, bu5hm4n, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8946
Xavi Artigas [Fri, 24 May 2019 09:26:06 +0000 (11:26 +0200)]
Fix last missing reference to old efl_orientation headers
This is now efl_gfx_orientable.
We are not building the C++ examples, so I did not pick this up sooner.
Travis does not build C++ bidings at all.
Jaehyun Cho [Fri, 24 May 2019 08:46:16 +0000 (17:46 +0900)]
efl_mono: fix autogen make check error
Previously, autogen make check error happened because
some .eo.h files were not generated but were included in
libefl_mono_native_test.h.
Now, all .eo.c and .eo.h files are generated.
Also CLEANFILES are fixed to include all the generated files.
Lauro Moura [Thu, 23 May 2019 23:45:29 +0000 (20:45 -0300)]
csharp: Fix autotools build
Summary: After the tests split
Reviewers: vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9015
Mike Blumenkrantz [Thu, 23 May 2019 17:55:50 +0000 (13:55 -0400)]
efl/gesture: include .h file in private header, not .c file
Summary:
a generated eolian c file cannot be included multiple times or else it will
create multiple definitions of symbols defined in that file and break the build
ref
54175998d538e0b2173fc023bb822f1e6536e58f
fix T7960
Reviewers: devilhorns, vtorri
Reviewed By: vtorri
Subscribers: cedric, #reviewers, #committers
Tags: #efl_build
Maniphest Tasks: T7960
Differential Revision: https://phab.enlightenment.org/D8945
Mike Blumenkrantz [Thu, 23 May 2019 13:32:11 +0000 (09:32 -0400)]
elm_widget_item_static_focus: mark param as used
Summary: Depends on D8935
Reviewers: bu5hm4n, devilhorns
Reviewed By: bu5hm4n, devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8936
Mike Blumenkrantz [Thu, 23 May 2019 13:32:00 +0000 (09:32 -0400)]
efl_ui_focus_manager_sub: handle manager change when tree is set to unfocusable
Summary:
in this case, the event is emitted and no manager exists because the objects
are not focusable
@fix
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8935
Mike Blumenkrantz [Thu, 23 May 2019 13:31:50 +0000 (09:31 -0400)]
elm_color_class: use legacy event for genlist selection
Summary:
this fixes the selection callback and makes the widget work again
@fix
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D8913
Mike Blumenkrantz [Thu, 23 May 2019 13:31:42 +0000 (09:31 -0400)]
evas/render: fix proxy clipping when source_clip is disabled
Summary:
when source_clip is disabled, the clipper used should be the one used by
the proxy object. previously this would never be the case, meaning that
disabling source_clip had no effect
@fix
Depends on D8879
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8880
Vincent Torri [Thu, 23 May 2019 11:25:27 +0000 (20:25 +0900)]
Emotion gst1 module: fix "empty if statement" warning
Summary: the macro GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS can be undefined (see gst core doc), hence the if statement may have no body
Test Plan: compilation
Reviewers: zmike, raster, cedric, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8939
Vincent Torri [Thu, 23 May 2019 11:24:46 +0000 (20:24 +0900)]
Emotion gst1 module: remove whitespaces
Reviewers: zmike, cedric, raster, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8938
Shinwoo Kim [Thu, 23 May 2019 11:11:44 +0000 (20:11 +0900)]
Efl.Ui.Textpath: fix a size problem
Summary:
Textpath set its hint_size using its position and calulated path information.
The path information is calculated using center postion, radius & start angle.
For example, if textpath position is 0,0 and center positon of path is 100,100
and radius 50, then text will be located on the rigth side of textpath object.
Moreover there is another problem.
[Step to reproduce]
1. Launch elementary_test
2. open Efl.Ui.Textpath
3. see circle is not center aligned.
4. click Clockwise 1 ~ 2 times center position is changed repeatedly.
This occurs because textpath size is calculated by position_set.
It does not make sense that changing postion defines its size.
So this patch is setting textpath hint_size using only given center position.
The text will position on the middle of textpath object always.
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8930
Lauro Moura [Wed, 22 May 2019 20:21:02 +0000 (17:21 -0300)]
csharp: Split test files
Summary: Make it easier to add new tests
Reviewers: vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8937
Xavi Artigas [Wed, 22 May 2019 18:16:16 +0000 (14:16 -0400)]
Rename Efl.Gfx.Orientation -> Efl.Gfx.Image_Orientation
Summary:
This will help disambiguate later on when we rename Efl.Ui.Direction
to Efl.Ui.Layout_Orientation.
Relates to T7919
Test Plan: Everything still builds and passes tests.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8934
Christopher Michael [Wed, 22 May 2019 12:45:24 +0000 (08:45 -0400)]
benchmarks: Fix copy-paste error
Coverity reports this as a copy-paste error, and checking the code it
certainly looks that way, so lets call the proper hash function here
Fixes CID1401052
@fix
Hosang Kim [Wed, 22 May 2019 12:01:58 +0000 (08:01 -0400)]
ecore_ipc: close dialer io closer when dialer is deleted.
Summary:
dialer uses copier class, so dialer's close on invalidate flag is EINA_FALSE.
Therefore dialer io closer is not closed automatically.
Reviewers: barbieri, raster, Hermet, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8922
Vincent Torri [Wed, 22 May 2019 11:59:05 +0000 (07:59 -0400)]
include evil_private.h in last files, and disable symbolic links on Windows in a couple of files
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8933
Christopher Michael [Wed, 22 May 2019 11:37:36 +0000 (07:37 -0400)]
ecore-evas-drm: Check if vblank is supported
Small patch to check if the video driver supports drmWaitVBlank. If
not, we can fall back to timer based animators and avoid freezing (due
to usage of vsync'd animators).
@fix
Christopher Michael [Wed, 22 May 2019 11:35:45 +0000 (07:35 -0400)]
ecore-drm2: Add API to check if vblank is supported
This patch adds a small API that we can use to check if the current
video driver supports the usage of drmWaitVBlank. This check is
required for certain drivers (like vbox) which do not support
drmWaitVBlank and thus are causing our animators in ecore_evas to
freeze. We can now use this API from within Ecore_Evas to disable
vsync'd animators and fall back to timer based ones.
@feature
Xavi Artigas [Tue, 21 May 2019 18:23:17 +0000 (20:23 +0200)]
evas/scale_sample: even more code deduplication
Summary:
how many times was this block of code copied around???
no functional changes
Depends on D8848
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8849
Mike Blumenkrantz [Tue, 21 May 2019 18:23:16 +0000 (20:23 +0200)]
evas/scale_sample: remove unnecessary clamping to mask geometry
Summary:
this is now handled entirely in the masking helper function
no functional changes
Depends on D8847
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8848
Mike Blumenkrantz [Tue, 21 May 2019 18:23:15 +0000 (20:23 +0200)]
evas/scale_sample: further deduplicate masking code
Summary:
by adding a couple extra params to existing functions, we can reuse
existing code instead of copying it around and adding more bugs
no functional changes
Depends on D8846
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8847
Mike Blumenkrantz [Tue, 21 May 2019 18:23:13 +0000 (20:23 +0200)]
evas/scale_sample: deduplicate masking code
Summary:
these functions provide identical functionality to the inline blocks
no functional changes
Depends on D8841
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8846
Vincent Torri [Tue, 21 May 2019 17:35:01 +0000 (13:35 -0400)]
Eio: avoid symbolic link on Windows
Summary: On Windows, symbolic links do not exist
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8931
Marcel Hollerbach [Tue, 21 May 2019 16:28:47 +0000 (12:28 -0400)]
eina: move builtin detection to eina_config.h
Summary: this means we don't need to handle this in the buildtool at all.
Reviewers: vtorri, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8553
Daniel Kolesa [Tue, 21 May 2019 14:01:07 +0000 (16:01 +0200)]
eolian: remove @nullable keyword
This was an experiment that never properly took off and was never
used by any generator. Its use was highly variable, so it could
not be relied upon. We will still want to reverse the current
behavior eventually (no null by default), but that will be
done with eo file versioning in the future.
@feature
Daniel Kolesa [Tue, 21 May 2019 13:43:02 +0000 (15:43 +0200)]
docs: remove obsolete docgen from the tree
This has long been replaced with tools/edocgen.git and most likely
does not even work.
Shinwoo Kim [Tue, 21 May 2019 05:31:12 +0000 (14:31 +0900)]
Efl.Ui.Textpath: support center align for each direction
Summary:
The textpath draws text from the start_angle. User needs to set correct
start_angle to center the text. This start_angle could be changed according to
each parameters of circle_set such as x, y, radius, direction and text itself.
So this patch is introducing direction EFL_UI_TEXTPATH_DIRECTION_CC(W)_CENTER.
The center of textpath will be located at the start_angle with this direction.
Test Plan: I will add example if this patch is acceptable.
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8892
Shinwoo Kim [Tue, 21 May 2019 01:47:58 +0000 (10:47 +0900)]
Efl.Ui.Textpath: draw text immediately in the position.set
Summary:
Efl.Ui.Textpath was drawing its text on the job. Because of this, textpath was
slower than other objects which are scrolling on the same scroller.
So this patch makes textpath not use job in the position.set.
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8924
Xavi Artigas [Mon, 20 May 2019 18:25:19 +0000 (20:25 +0200)]
autotools: add new ui_image tests to proper makefile
Mike Blumenkrantz [Mon, 20 May 2019 15:34:51 +0000 (17:34 +0200)]
elm_test: add efl.ui.image tests which mimic elm_image tests
Summary:
these should look and feel the same as the original tests.
should.
Depends on D8914
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8915
Mike Blumenkrantz [Mon, 20 May 2019 15:52:20 +0000 (11:52 -0400)]
elm_test: fix some bugs in elm_image tests
Summary:
* passing label object to elm_image_file_get
* using fill hint during weight set
@fix
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8914
Xavi Artigas [Mon, 20 May 2019 15:52:10 +0000 (11:52 -0400)]
Rename Efl.Orient -> Efl.Gfx.Orientation
Summary:
And the Efl.Orientation interface -> Efl.Gfx.Orientable
(with proper c_prefix so it is not too cumbersome to use from C).
Also, turned the theme_rotation_apply() parameter into an int to avoid confusion.
Fixes T7919
Depends on D8912
Test Plan: Everything continues to build and pass tests
Reviewers: zmike, bu5hm4n, cedric, Hermet, Jaehyun_Cho
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7919
Differential Revision: https://phab.enlightenment.org/D8926
Xavi Artigas [Mon, 20 May 2019 15:51:56 +0000 (11:51 -0400)]
Merge Efl.Orient and Efl.Flip into the same enum
Summary:
This is similar to how it is in Evas, and simplifies the Efl.Orientation
interface, which only needs one property now.
Relates to T7919
Test Plan: Everything builds and tests pass. There's only one example of efl_orientation_set() so there's not much to test yet.
Reviewers: zmike, bu5hm4n, cedric, Hermet, Jaehyun_Cho
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7919
Differential Revision: https://phab.enlightenment.org/D8912
Vincent Torri [Mon, 20 May 2019 13:10:00 +0000 (09:10 -0400)]
remove Evil.h when not necessary, include evil_private.h when necessary
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8925
Hermet Park [Mon, 20 May 2019 12:52:11 +0000 (08:52 -0400)]
evas example: add a png scale down example.
Reviewers: cedric, #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8886
Marcel Hollerbach [Mon, 20 May 2019 12:48:29 +0000 (08:48 -0400)]
meson: fix installed .eo files and fix cross compile
Summary:
if things are a array in a array, then flattening only seems to work
when the first element is a target object. But not when the first
element is then also an string, then the string in the array gets
concatted and added to root array. This is a meson bug, investigation
going on. Additionally, this fixes installed .eo files, as we might want
to installed gesture files when we require them in other objects.
Reviewers: Jaehyun_Cho, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8910
Vincent Torri [Mon, 20 May 2019 12:46:02 +0000 (08:46 -0400)]
Evas: remove Evil.h when not needed and use evil_private when needed
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8921
Xavi Artigas [Thu, 16 May 2019 11:03:33 +0000 (13:03 +0200)]
Efl.Pack_Table: remove table_direction
Summary:
The only implementation of this interface, `Efl.Ui.Table`, only supports two fill
directions (horizontal or vertical), therefore the table_direction property which
supports primary and secondary directions is unnecessarily complicated. Remove it
and use only `Efl.Ui.Direction.direction` to select the fill direction.
Also, expanded the documentation.
Fixes T7962
Test Plan:
Everything builds and tests pass. Efl.Ui.Table elementary_test still work.
Examples need to be adjusted to stop using table_direction.
Reviewers: zmike, YOhoho, bu5hm4n, SanghyeonLee, Jaehyun_Cho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7962
Differential Revision: https://phab.enlightenment.org/D8902
Vincent Torri [Fri, 17 May 2019 18:02:21 +0000 (14:02 -0400)]
bin/ecore_evas: remove useless inclusion of Evil.h
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8917
Vincent Torri [Fri, 17 May 2019 17:51:50 +0000 (13:51 -0400)]
bin/eet and ecore_con: remove Evil.h when not necessary and include evil_private.h when necessary
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8911
Daniel Kolesa [Fri, 17 May 2019 14:08:23 +0000 (16:08 +0200)]
eolian tests: rename owning.eo.c to clear confusion
Jaehyun Cho [Fri, 17 May 2019 08:35:00 +0000 (17:35 +0900)]
efl_mono: generate efl_canvas_text.eo.cs
To use canvas text in efl csharp bindings, it is permitted to generate
efl_canvas_text.eo.cs.
Vincent Torri [Fri, 17 May 2019 10:52:58 +0000 (11:52 +0100)]
Eet: remove useless inclusion of Evil.h
Test Plan: compilation
Reviewers: raster, zmike, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8909
Vincent Torri [Fri, 17 May 2019 10:52:41 +0000 (11:52 +0100)]
bin/efl and ecore: include evil_private.h when appropriate
Test Plan: compilation
Reviewers: raster, zmike, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8908
Jaehyun Cho [Fri, 17 May 2019 10:32:24 +0000 (19:32 +0900)]
evas_gesture: fix meson.build to build and install correctly
Vincent Torri [Thu, 16 May 2019 17:49:39 +0000 (13:49 -0400)]
Evil: remove fall through warning
Summary: gcc and clang support the usage of "fall through" comment to suppress this warning
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8904
Vincent Torri [Thu, 16 May 2019 17:48:59 +0000 (13:48 -0400)]
Eina: replace Evil.h with evil_private.h and remove Evil.h when not necessary
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8903
Xavi Artigas [Thu, 16 May 2019 16:06:46 +0000 (18:06 +0200)]
docfx: Use the public repo url for www-content
Otherwise, you need to have credentials, etc.
Daniel Kolesa [Thu, 16 May 2019 13:57:39 +0000 (15:57 +0200)]
eolian: rename eolian_event_c_name_get
This is for consistency with the new eolian_class_c_macro_get
as well as for better clarity, as c_name_get is already provided
by Object and refers to something else.
Daniel Kolesa [Thu, 16 May 2019 13:52:46 +0000 (15:52 +0200)]
eolian: rename eolian_typedecl_enum_field_c_name_get
This is to allow for better object oriented APIs, as the `c_name`
field would be inherited from Object. This also makes it more
clear in C.
Daniel Kolesa [Thu, 16 May 2019 13:31:37 +0000 (15:31 +0200)]
eolian: add API to retrieve the C name of an object
This is to prepare for type/class renaming support. This adds
the necessary API to retrieve C-specific names. Other refactoring
is necessary elsewhere for now.
This also renames the old API eolian_class_c_name_get to
eolian_class_c_macro_get to avoid conflict as well as clarify
the intention.
Vincent Torri [Thu, 16 May 2019 12:36:12 +0000 (14:36 +0200)]
Eo: replace Evil.h with evil_private.h
Test Plan: compilation
Reviewers: q66, raster, zmike
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8905
WooHyun Jung [Thu, 16 May 2019 08:02:28 +0000 (10:02 +0200)]
csharp: fix formatting in generated .eo.cs codes
Summary: There was duplicated scope_tab, so I removed it.
Test Plan:
- ./autogen --enable-csharp-bindings
- make
Reviewers: lauromoura, felipealmeida, Jaehyun_Cho, YOhoho, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8901
Marcel Hollerbach [Wed, 15 May 2019 15:45:56 +0000 (17:45 +0200)]
theme: add a macro file for making themes easier
CLICKABLE_SIGNAL_EMITS now can be used to setup all the events required
to have automatically emission of all the clickable events
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8899
Mike Blumenkrantz [Wed, 15 May 2019 16:44:27 +0000 (12:44 -0400)]
meson: enforce 61s timeout for tests, remove explicit timeouts from build files
unit tests automatically abort with info after 60s, and tests should be run with
an appropriate timeout to avoid conflict with the test runner's default 30s timeout
set explicit timeout in eio test for now because there's still frequent bugs here
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8894
Marcel Hollerbach [Wed, 15 May 2019 13:49:48 +0000 (09:49 -0400)]
Revert "remove vpath test for user dir the test was broken and fixing is insane"
Summary:
This reverts commit
954a534bc0e7f30e66cc7dfd15ac79544e92671f.
It appears that the concerns from this commit are invalid. The case of
~asdf/ does not have any fallback case, if there is no getpwent on this
system, then there will be simply an error, same for the case of a
missing user. In such a case nothing will be written in the buffer /
returned by eina_vpath. The windows build problem can be
fixed by a simple #ifdef'ing the test code.
Reviewers: raster, zmike, cedric, vtorri
Reviewed By: vtorri
Subscribers: vtorri, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8671
Carsten Haitzler (Rasterman) [Wed, 15 May 2019 13:26:11 +0000 (14:26 +0100)]
meson buildtype - use plain not debug as debug will be insanely slow
eina cow backtraces on write make this impractically slow to use
debug. also the switch back to dev mode was not the reverse of
switching to release mode. this fixes that.
Marcel Hollerbach [Wed, 15 May 2019 13:09:04 +0000 (09:09 -0400)]
efl_ui_frame: migrate to efl.ui.clickable
Summary:
frame now uses efl.ui.clickable, which ensures correct click emittion.
The click event is not needed in the event anymore. However, now
efl,action,press / efl,action,unpress is needed.
Depends on D8825
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8826
Vincent Torri [Wed, 15 May 2019 11:27:37 +0000 (12:27 +0100)]
Evil: move the inclusion of all headers in evil_private.h
Summary: first step for making Evil private. evil_private.h will be included in the EFL source code instead of Evil.h
Test Plan: compilation
Reviewers: raster, cedric, zmike
Reviewed By: raster
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8893
WooHyun Jung [Wed, 15 May 2019 06:14:15 +0000 (15:14 +0900)]
Makefile_Cxx: add include dependency with evas/gesture
Summary:
There was a build break when "make check". This patch will
fix the issue.
Test Plan:
- ./autogen.sh --with-tests=regular --enable-csharp-bindings
- make
- sudo make install
- sudo make check
Reviewers: Jaehyun_Cho, CHAN, zmike, segfaultxavi
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8896
JunsuChoi [Wed, 15 May 2019 02:22:45 +0000 (11:22 +0900)]
ector_software_rasterizer: Improved masking calculation.
Summary:
The memory allocation for the buffer size is improved to
allocate only the width size.
Test Plan: N/A
Reviewers: Hermet, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, smohanty, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8873
Marcel Hollerbach [Tue, 14 May 2019 19:51:12 +0000 (15:51 -0400)]
efl_ui: remove Efl.Ui.Clickable from containers
Summary:
these widgets here are containers, means: they contain items that can be
clicked, but the container itself cannot be clicked. Later on, we should
introduce a new interface which contains events that reflect the clicked
event of theire items.
Depends on D8827
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8828
Marcel Hollerbach [Tue, 14 May 2019 19:51:06 +0000 (15:51 -0400)]
efl_ui_tab_bar: remove Efl.Ui.Clickable
Summary:
nothing here uses this directly, and nothing emits events. For now the
implementation is removed. If this is required later on, it can be
readded.
Depends on D8826
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8827
Marcel Hollerbach [Tue, 14 May 2019 19:50:53 +0000 (15:50 -0400)]
efl_ui_panes: migrate to efl_ui_clickable
Summary:
the implementation of efl_ui_clickable is now used to tricker the
events. efl,action,click and efl,action,click,double is not needed
anymore from the theme.
Depends on D8824
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8825
Marcel Hollerbach [Tue, 14 May 2019 19:50:47 +0000 (15:50 -0400)]
efl_ui_text: migrate to efl_ui_clickable
Summary:
This now uses the efl_ui_clickable mixin. It is impossible right now to
test this in the test suite, as every single configuration of the
efl.ui.text object is ending up in an error. Which is not allowed in the
test suite. Additionally, simulating clicks on the objects gets it into
some sort of inifinite recursion when asking for cursor positions.
Depends on D8823
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8824
Marcel Hollerbach [Tue, 14 May 2019 19:50:39 +0000 (15:50 -0400)]
efl_ui_image: migrate to efl.ui.clickable
Summary:
the mixin is now used to emit the events of the mixins. This is verified
by the testsuite. The testsuite needs a special treatment for the
object, because a missing image-file of the object would result in a 0x0
image size.
Depends on D8822
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8823
Marcel Hollerbach [Tue, 14 May 2019 19:50:32 +0000 (15:50 -0400)]
efl_test_clickable: introduce new tests
Summary:
the new test checks if the events are correctly emitted
Depends on D8821
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8822
Marcel Hollerbach [Tue, 14 May 2019 19:50:25 +0000 (15:50 -0400)]
efl_ui_button: port to efl.ui.clickable
Summary: Depends on D8820
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8821
Marcel Hollerbach [Tue, 14 May 2019 19:50:15 +0000 (15:50 -0400)]
efl_ui: move clickable from efl to efl_ui
Summary:
efl_ui_clickable is now a mixin. The mixin now brings two APIs the press
and unpress API can be used to tell the implementation the state of the
presses. Within the implementation the calls to press / unpress are then
converted to longpress / clicked events.
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8820
Xavi Artigas [Tue, 14 May 2019 06:51:05 +0000 (08:51 +0200)]
efl-mono: Use Efl.Ui.Win API instead of Elm.Policy
Summary:
This removes another bit of legacy API from the C# bindings.
This also reverts "elm: Put back Policy and Policy_Quit in EO files"
(
a9132a9a66955608e913bb1228e4adb371310b09) so that these two Elm enums are
definitely out of the EO files.
Test Plan:
Everything, including mono bindings, continue to build.
At runtime, C# apps still exit when all windows are closed.
Reviewers: lauromoura, vitor.sousa, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8890
Woochanlee [Tue, 14 May 2019 07:37:20 +0000 (16:37 +0900)]
Gesture Manager: Add gestures and fix gesture managing, recognizer logic.
Summary:
https://phab.enlightenment.org/T7544
Provides a way for a user to get a gesture manager, recognizer instance.
Supports different recognizer properties for each target(Eo).
Gesture, Touch Class Life-cycle re-implementation. for supporting multiple touches.
Add below gestures.
efl_canvas_gesture_tap
efl_canvas_gesture_double_tap
efl_canvas_gesture_triple_tap
efl_canvas_gesture_long_tap
efl_canvas_gesture_momentum
efl_canvas_gesture_zoom
efl_canvas_gesture_flick
Test Plan:
Simple test -> test_gesture_framework.c
More test cases will upload.
Reviewers: woohyun, smohanty, segfaultxavi, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: Jaehyun_Cho, segfaultxavi, cedric
Tags: #efl, #do_not_merge
Differential Revision: https://phab.enlightenment.org/D7579
Lauro Moura [Tue, 14 May 2019 06:38:50 +0000 (08:38 +0200)]
csharp: Fix event marshalling for value types
Summary:
It was wrongly assuming value types were passed by value.
As stated in the documentation, all arguments are passed with a single
level of indirection.
Fixes T7957
Reviewers: woohyun, felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7957
Differential Revision: https://phab.enlightenment.org/D8889
Marcel Hollerbach [Mon, 13 May 2019 19:14:20 +0000 (15:14 -0400)]
elc_fileselector: make a few events again legacy
Summary:
the events changed here should not be used. They should use legacy
events.
Depends on D8816
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8819
Marcel Hollerbach [Mon, 13 May 2019 19:14:13 +0000 (15:14 -0400)]
elementary: do not emit new events in legacy
Summary:
This commits prepares the tree in order to mess with the events in the
Efl.Ui.Clickable event. Events which have been emitted in a none legacy
widget, are now emitted either with evas, when the widget is legacy due
to inheritance. Or via the normal event and normal event functions.
In case the widget is a legacy only widget (not used at all in the new
api), then the events are for now emitted with
evas_object_smart_callback_call.
Cases where event handlers have been added to legacy widgets, smart
events are now used, and not the eo one anymore.
ref T7844
Depends on D8813
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7844
Differential Revision: https://phab.enlightenment.org/D8816
Marcel Hollerbach [Mon, 13 May 2019 19:14:03 +0000 (15:14 -0400)]
efl_ui_clickable: move repeat event
Summary:
the repeat event is only emitted by the implementations of
efl_ui_autorepeat. Additionally, the event should only be used by those
who implement this interface.
Depends on D8832
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike, segfaultxavi
Subscribers: jpeg, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8813
Marcel Hollerbach [Mon, 13 May 2019 19:13:54 +0000 (15:13 -0400)]
elm_panel: do not use the unfocusable state here
Summary:
the widget itself is a focus_layer which means, the tree is orphaned and
cannot be accessed until the panel is visible. There is not need for us
to manually track this state.
fix T7908
Depends on D8831
Reviewers: marcellus, zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7908
Differential Revision: https://phab.enlightenment.org/D8832
Marcel Hollerbach [Mon, 13 May 2019 19:13:46 +0000 (15:13 -0400)]
meson: we are not in release mode anymore
Test Plan:
Run the build, enable debug messages, and you will see that DBG messages start to appear again on your screen.
As an example ´EINA_LOG_LEVELS="elementary_focus:10" ./src/bin/elementary_test´
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8831
Mike Blumenkrantz [Mon, 13 May 2019 15:45:13 +0000 (11:45 -0400)]
evas/image: fix broken auto_fill mechanism when manually changing fill
Summary:
if auto_fill is set (which is the default for image objects), manually setting
the fill for the image would previously only persist until the image was resized,
at which point the auto_fill would activate and re-set the image's fill to be
the same as the image's object geometry
this fixes the auto_fill behavior to stop modifying the image's fill geometry
if the fill is manually changed by the user, which fixes using fill on most
image objects
@fix
Reviewers: cedric, Hermet
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8879
Mike Blumenkrantz [Mon, 13 May 2019 15:44:27 +0000 (11:44 -0400)]
evas/scale_sample: call alloca for the scanline buffer after clamping width
Summary:
this is already a risky call for larger scanlines, so use the clamped value
to further reduce the chance of blowing out the stack
Depends on D8839
Reviewers: cedric, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8840
Mike Blumenkrantz [Mon, 13 May 2019 15:44:18 +0000 (11:44 -0400)]
evas/scale_sample: fix mask geometry clamping in scale thread
Summary:
the 'y' parameter is not relevant here. this clamping exists solely
to avoid reading outside the bounds of the mask, and 'y' is the scanline
at which to begin the masking
subtracting the mask size here does not make sense: we are attempting to clamp
to the size of the mask in order to avoid buffer over-read, so this means that
we are mapping the maximum y coordinate of the mask (mask_y + mask_h) to be
relative to the clipped y coordinate (dst_clip_y)
Depends on D8838
Reviewers: cedric, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8839
Mike Blumenkrantz [Mon, 13 May 2019 15:44:11 +0000 (11:44 -0400)]
evas/scale_sample: slightly refactor some mask geometry clamping
Summary:
this was a bit confusing to read since the comparators are not ordered
as expected
no functional changes
Depends on D8837
Reviewers: cedric, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8838
Mike Blumenkrantz [Mon, 13 May 2019 15:44:02 +0000 (11:44 -0400)]
evas_render: deduplicate mapped mask render code
Summary:
this code block was repeated multiple times throughout the function
no functional changes
Reviewers: cedric, kimcinoo
Reviewed By: kimcinoo
Subscribers: kimcinoo, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8837
Carsten Haitzler (Rasterman) [Mon, 13 May 2019 13:40:08 +0000 (14:40 +0100)]
edje src - mark with efl version so we don't get warnings
Carsten Haitzler (Rasterman) [Mon, 13 May 2019 13:21:04 +0000 (14:21 +0100)]
ecore drm2 - fix warnigns in DBG eina logs for long types
on 32bit longs are 32bit so cast appropriately to not have warnings.
Carsten Haitzler (Rasterman) [Mon, 13 May 2019 13:12:28 +0000 (14:12 +0100)]
eina - value - test - cats warnings on 32bit to get some silence
longs will be truncated on 32bit in these tests so be explicit to not
have warinings.
note - eina value tests are broken on 32bit anyway already - the
conversions to/from long types are broken and fail. this doesn't fix
that.
Xavi Artigas [Mon, 13 May 2019 09:27:40 +0000 (11:27 +0200)]
elm: Put back Policy and Policy_Quit in EO files
In
e027ad2626 these enums were moved to header files, which is correct,
since they are legacy and should not be present in EO files.
However, the C# bindings are still using them.
Until nobody is using these two enums, adding them back to EO fixes the build.
Jaehyun Cho [Fri, 10 May 2019 10:36:17 +0000 (19:36 +0900)]
efl_mono: generate efl_canvas_vg_object.eo.cs by meson
This commit is the same as
0e8f289d7dfb4c5877559917a57a3ac08545fb86
but this commit is for meson.
To use vector graphics in efl csharp bindings, it is permitted to
generate efl_canvas_vg_object.eo.cs.
Other efl_canvas_vg .eo.cs files have already been generated because the
file names were changed from efl_vg to efl_canvas_vg.
Jaehyun Cho [Fri, 10 May 2019 10:29:34 +0000 (19:29 +0900)]
efl_mono: move libeflcustomexportsmono.so to lib with versions by meson
meson generates libeflcustomexportsmono.so to lib/efl-mono-1/ directory
unlike other so files.
Moreover, the so file does not have versions in the file name unlike
other so files.
Like other so files, libeflcustomexportsmono.so is moved to lib
directory with versions in the file name.
Shinwoo Kim [Mon, 13 May 2019 04:09:24 +0000 (13:09 +0900)]
Efl.Ui.Textpath: enhance to support legacy API
Summary:
The legacy API is available after https://phab.enlightenment.org/D7033 but
internal function does not care of it. This change makes textpath work with
the legacy style file(./data/elementary/themes/edc/elm/textpath.edc).
Reviewers: Hermet, jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8875
Marcel Hollerbach [Mon, 29 Apr 2019 09:11:10 +0000 (11:11 +0200)]
efl_canvas_animation: reply on the correct API
the animation itself does not implement the player interface, and
nothing forces it to do so. Additionally, we should ask the reference
object for the current progress. Not the animation object.
This fixes pos_set / pos_get.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8783
Vincent Torri [Wed, 8 May 2019 20:28:05 +0000 (20:28 +0000)]
eina vpath: fix warning on Windows, as well as the public path
Differential Revision: https://phab.enlightenment.org/D8866
Cedric BAIL [Fri, 10 May 2019 21:42:57 +0000 (14:42 -0700)]
eina: add tests for the new Vpath syntax.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8884
Cedric BAIL [Fri, 10 May 2019 21:37:24 +0000 (14:37 -0700)]
eina: update vpath to also support a more classic syntax for variable.
This enable vpath to recognize also ${} as a variable. It does mimic
what Efl.ViewModel provide with Efl.ViewModel.PropertyText and various
other language.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8883
Cedric BAIL [Fri, 10 May 2019 21:28:49 +0000 (14:28 -0700)]
eina: refactor and simplify vpath.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8882
Cedric BAIL [Sat, 11 May 2019 00:58:33 +0000 (17:58 -0700)]
ecore: forgotten autotools update.
projects / platform / upstream / efl.git / log