Matthew Leibowitz [Wed, 13 Jul 2016 23:42:15 +0000 (01:42 +0200)]
Merge branch 'feature-patheffect' into update-skia-m52
# Conflicts:
# include/c/xamarin/sk_x_types.h
# src/c/xamarin/sk_x_types_priv.h
Matthew Leibowitz [Wed, 13 Jul 2016 23:23:36 +0000 (01:23 +0200)]
make sure that we always build for shared libraries
Matthew Leibowitz [Wed, 13 Jul 2016 23:23:13 +0000 (01:23 +0200)]
undoing change to opts.gyp
Matthew Leibowitz [Wed, 13 Jul 2016 23:22:26 +0000 (01:22 +0200)]
both arm/x86 require the fix
Matthew Leibowitz [Wed, 13 Jul 2016 16:56:01 +0000 (18:56 +0200)]
Added path effects to the C API
Matthew Leibowitz [Tue, 12 Jul 2016 01:31:52 +0000 (03:31 +0200)]
Added empty C files
Matthew Leibowitz [Mon, 11 Jul 2016 13:38:49 +0000 (15:38 +0200)]
Revert "Revert "Work around missing __mulodi4() on ARMv7 + Clang builds.""
This reverts commit
50876c22fa75cb0d64129b8d0c87d00f2486351f.
Matthew Leibowitz [Mon, 11 Jul 2016 13:34:18 +0000 (15:34 +0200)]
Revert "Work around missing __mulodi4() on ARMv7 + Clang builds."
This reverts commit
1b112ecdbd187474b9bfb5603dccc280b75cf9b6.
Miguel de Icaza [Sat, 9 Jul 2016 02:46:53 +0000 (22:46 -0400)]
[C API] Add sk_image_new_from_bitmap
Miguel de Icaza [Wed, 6 Jul 2016 14:30:24 +0000 (10:30 -0400)]
[C API] Cast everything to ints to avoid compile time errors on Android
Miguel de Icaza [Wed, 6 Jul 2016 02:21:47 +0000 (22:21 -0400)]
[C API] Add support for SkPath.RawIter, in addition to SkPath.Iter
Miguel de Icaza [Sun, 3 Jul 2016 04:27:23 +0000 (00:27 -0400)]
[C API] Add SkPath APIs to add sub-paths
Miguel de Icaza [Sun, 3 Jul 2016 04:10:18 +0000 (00:10 -0400)]
[C API] Add sk_path's iterators, and add the missing sk_matrix methods that I lost
Miguel de Icaza [Sat, 2 Jul 2016 02:47:24 +0000 (22:47 -0400)]
[Skia/C] Add bindings for SKPath Reset/Rewind
Miguel de Icaza [Wed, 29 Jun 2016 00:17:42 +0000 (20:17 -0400)]
[C API] Add convenience SkCanvas draw circle
Miguel de Icaza [Tue, 28 Jun 2016 23:48:46 +0000 (19:48 -0400)]
[C API] add more Matrix APIs
Miguel de Icaza [Tue, 28 Jun 2016 03:06:07 +0000 (23:06 -0400)]
[C API] Add more sk_matrix operations
Matthew Leibowitz [Fri, 24 Jun 2016 17:48:22 +0000 (19:48 +0200)]
Merge branch 'chrome/m52' into update-skia-m52
mtklein [Thu, 23 Jun 2016 18:20:58 +0000 (11:20 -0700)]
Work around missing __mulodi4() on ARMv7 + Clang builds.
__mulodi4() is roughly,
int64_t __mulodi4(int64_t a, int64_t b, int* overflow) {
int64_t result = a*b;
*overflow = did_overflow(result);
return result;
}
It's used by Clang's __builtin_smulll_overflow(), which is basically the same
except it swaps the positions of the return value and the out parameter.
DNG SDK in turn uses __builtin_smulll_overflow().
When building ARMv7 binaries with Clang, __mulodi4() turns up as a missing symbol.
That's because it's defined in a separate compiler-rt library. I have not been
able to link that. Instead, I've provided our own trivial __builtin_smulll_overflow().
Before this patch both nanobench and DM failed dynamically linking __mulodi4(). After this patch nanobench runs for a while, eventually segfaulting. DM immediately segfaults.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2011073002
Review-Url: https://codereview.chromium.org/
2011073002
Matthew Leibowitz [Wed, 22 Jun 2016 10:00:18 +0000 (12:00 +0200)]
Add the TLS bits back, but use the FLS instead
mtklein [Tue, 21 Jun 2016 19:03:37 +0000 (12:03 -0700)]
Cherry-pick
875e13ca0 to M52.
TBR=
Original description:
Simplify mask/clip intersection, making sure to explicitly check for an empty mask.
Previously we were only asserting the mask wasn't empty, which isn't necessarily true when we're given pathological float coordinates like +Inf or NaN.
A local run of nanobench --match text_ was not able to show this is faster or slower.
This patch fixed this first Chrome bug on my desktop, and the second is probably a dupe.
BUG=chromium:619378,chromium:613912
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2073873002
Review-Url: https://codereview.chromium.org/
2073873002
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
2085023002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2085023002
Matthew Leibowitz [Tue, 21 Jun 2016 15:43:38 +0000 (17:43 +0200)]
A few "Conversion from 'type1' to 'type2', possible loss of data" for ARM
fmalita [Sat, 18 Jun 2016 11:47:49 +0000 (04:47 -0700)]
[M52] add fail condition to addexpanded
(cherry-pick of
013e0e6d482f61181b829bf5ebfcad912c0061b1)
If coincident pairs don't match,
give up rather than deref null.
TBR=fmalita@chromium.org,caryclark@google.com
BUG=618991
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2058773002
Review-Url: https://codereview.chromium.org/
2058773002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2078183002
Matthew Leibowitz [Fri, 17 Jun 2016 18:34:32 +0000 (20:34 +0200)]
we renamed the file
Matthew Leibowitz [Fri, 17 Jun 2016 18:33:48 +0000 (20:33 +0200)]
Update the Xamarin code:
- using more ToX and AsX instead of casting
- SkImageDecoder is no more, using SkCodec
- using more skia smart pointers 'sk_sp'
- SkImageInfo can now be cast to/from the C type
Matthew Leibowitz [Fri, 17 Jun 2016 18:12:11 +0000 (20:12 +0200)]
Merge branch 'chrome/m52' into update-skia-m52
# Conflicts:
# gm/imagefilterscropped.cpp
# gm/imagefiltersgraph.cpp
# include/private/SkTLogic.h
# src/core/SkImageFilter.cpp
# src/core/SkTime.cpp
# src/effects/SkBlurImageFilter.cpp
# src/effects/SkDisplacementMapEffect.cpp
# src/pdf/SkPDFDevice.cpp
bsalomon [Wed, 15 Jun 2016 16:25:22 +0000 (09:25 -0700)]
Check for abandoned texture in GrTextureAdjuster::refTextureSafeForParams
Cherry-pick for M52
BUG=chromium:618858
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2063313002
TBR=egdaniel@google.com
Review-Url: https://codereview.chromium.org/
2063313002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2066493006
Matthew Leibowitz [Thu, 9 Jun 2016 12:47:24 +0000 (14:47 +0200)]
fix that last whitespace diff
Matthew Leibowitz [Thu, 9 Jun 2016 12:46:13 +0000 (14:46 +0200)]
make the file match the google
Matthew Leibowitz [Thu, 9 Jun 2016 12:41:36 +0000 (14:41 +0200)]
rather exclude the whole file than use defines
bsalomon [Wed, 8 Jun 2016 19:32:02 +0000 (12:32 -0700)]
When setting up a copySurface dst texture make the orientation match the src when glBlitFramebuffer requires it
TBR=egdaniel@google.com
BUG=chromium:618122
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2049753002
Review-Url: https://codereview.chromium.org/
2049753002
Cherry-pick from master to chrome/m52
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2049493003
Matthew Leibowitz [Mon, 6 Jun 2016 17:20:01 +0000 (19:20 +0200)]
Using convenience methods instead of direct casting (uniformity)
Matthew Leibowitz [Fri, 3 Jun 2016 12:45:51 +0000 (14:45 +0200)]
Added PDF Support (#13)
- Added the SkDocument methods
- Added the SkWStream methods, and the sub classes
- Added destructors for the SkStream types
fmalita [Sat, 28 May 2016 13:57:33 +0000 (06:57 -0700)]
[M52] Cherry-pick
e6c515f3d34096426b6822ad90a757131e8baf31
Fix int32 overflow in LinearGradientContext::shade4_dx_clamp
The unconditional increment in shade4_dx_clamp can overflow int32
=> n == SK_MinS32
=> count ~= SK_MinS32
=> we skip the main shader loop 'cause count < 0
Also include trivial
0e59bb7aaad272ac42d6fba53e8439bd9fa1ff3d followup
to ensure we're not tripping ASAN.
TBR=reed@google.com,mtklein@google.com
BUG=chromium:599458
Review-Url: https://codereview.chromium.org/
2010843002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2021673002
bsalomon [Mon, 23 May 2016 16:57:46 +0000 (09:57 -0700)]
Cherry Pick
8b6fa5e8a9016ebbf3a03009abc3845b71452550 to M52.
Make GrAtlasTextBlob::run own effects it points to.
BUG=chromium:608566
TBR=bungeman@google.com
Currently the run has bare pointers and the effects can be destroyed while a run is pointing at them.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1993213003
Review-Url: https://codereview.chromium.org/
1993213003
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2005923002
bsalomon [Wed, 18 May 2016 20:52:05 +0000 (13:52 -0700)]
Revert of Don't allow uncacheable paths in tessellated path renderer (patchset #2 id:20001 of https://codereview.chromium.org/
1990793003/ )
Reason for revert:
Caused innershapes test to be rendered incorrectly on the N10. This might be a driver bug.
Original issue's description:
> Don't allow uncacheable paths in tessellated path renderer
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1990793003
>
> Committed: https://skia.googlesource.com/skia/+/
aebd0fd32f8fde610de03b4f1e6d11ce24bfb73d
TBR=senorblanco@google.com,senorblanco@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
1993923002
benjaminwagner [Wed, 18 May 2016 20:28:56 +0000 (13:28 -0700)]
Fix example code in skpaint.md.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1993903002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1993903002
Review-Url: https://codereview.chromium.org/
1993903002
borenet [Wed, 18 May 2016 19:23:58 +0000 (12:23 -0700)]
Blacklist HTC.dng on 32-bit Win CPU bots
BUG=skia:5318
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1995703002
Review-Url: https://codereview.chromium.org/
1995703002
borenet [Wed, 18 May 2016 15:12:51 +0000 (08:12 -0700)]
Skip composeshader_bitmap GM on 64-bit Win CPU Test bots
Temporary measure to get the bots green while the real issue is sorted out.
BUG=skia:5315
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1989323002
Review-Url: https://codereview.chromium.org/
1989323002
bsalomon [Wed, 18 May 2016 14:30:00 +0000 (07:30 -0700)]
Don't allow uncacheable paths in tessellated path renderer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1990793003
Review-Url: https://codereview.chromium.org/
1990793003
tomhudson [Wed, 18 May 2016 14:24:16 +0000 (07:24 -0700)]
SkCanvas::adjustToTopLayer()
Given a matrix and a clip bounds, offsets them to reflect the difference
between device coordinates and global coordinates. Useful when a client
wants an OS-specific backing for a canvas.
R=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1986383002
Review-Url: https://codereview.chromium.org/
1986383002
bsalomon [Wed, 18 May 2016 14:15:46 +0000 (07:15 -0700)]
Reformat circle blur profile computation and add comments.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1981923002
BUG=skia:5224
Review-Url: https://codereview.chromium.org/
1981923002
jvanverth [Wed, 18 May 2016 14:01:16 +0000 (07:01 -0700)]
Revert of Add OpenGL context to Viewer. (patchset #7 id:120001 of https://codereview.chromium.org/
1978573003/ )
Reason for revert:
sk_app/WindowContext.cpp is missing. Need to add file and resubmit.
Original issue's description:
> Add OpenGL context to Viewer.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978573003
>
> Committed: https://skia.googlesource.com/skia/+/
56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
TBR=brianosman@google.com,bsalomon@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
1990893002
senorblanco [Wed, 18 May 2016 14:00:08 +0000 (07:00 -0700)]
Image filters: fix filtering of transparent black in CFIF.
SkColorFilterImageFilter has a codepath to filter transparent black
regions outside of the input image. However, it was treating the
exterior as opaque black, rather than trasparent black.
Note: the results of imagefiltercropexpand GM will change, as it
was tweaked a bit to show this bug.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978363002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
1978363002
reed [Wed, 18 May 2016 13:55:17 +0000 (06:55 -0700)]
remove animator from SampleApp
There is no xml parser hooked up, so the animator test file (already behind #if 0) is not testable. Removing the files to speedup building SampleApp.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1987963002
Review-Url: https://codereview.chromium.org/
1987963002
msarett [Wed, 18 May 2016 13:28:43 +0000 (06:28 -0700)]
Parse parametric gamma curves
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1972403002
Review-Url: https://codereview.chromium.org/
1972403002
msarett [Wed, 18 May 2016 13:23:57 +0000 (06:23 -0700)]
Delete SkBitmapRegionCanvas
This was an approach we considered for implementing Android's
BitmapRegionDecoder.
It was useful for testing and comparison, but now is no longer worth
maintaining and testing.
The approach to subset/scaled decodes (clipped decode, then scale)
may be worth reconsidering at some point.
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1990543002
Review-Url: https://codereview.chromium.org/
1990543002
kkinnunen [Wed, 18 May 2016 05:15:39 +0000 (22:15 -0700)]
Remove NVPR related env var from command buffer GL context creation
NVPR is now enabled by default for Chromium command buffer.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1975753005
Review-Url: https://codereview.chromium.org/
1975753005
bsalomon [Wed, 18 May 2016 01:36:23 +0000 (18:36 -0700)]
Make SkBlend_optsTests fail rather than crash when resources are missing
BUG=skia:5314
TBR=herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1987143002
Review-Url: https://codereview.chromium.org/
1987143002
Matthew Leibowitz [Wed, 18 May 2016 00:43:07 +0000 (02:43 +0200)]
Return SkString instead of char[]
msarett [Tue, 17 May 2016 20:57:15 +0000 (13:57 -0700)]
SkColorSpace follow-ups
Based on comments from:
https://codereview.chromium.org/
1985903002/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1986833002
Review-Url: https://codereview.chromium.org/
1986833002
Matthew Leibowitz [Tue, 17 May 2016 20:42:01 +0000 (22:42 +0200)]
Merge pull request #11 from agallero/typeface
Added methods to SkTypeface
bsalomon [Tue, 17 May 2016 20:18:03 +0000 (13:18 -0700)]
Remove GrFontScaler class.
This class is now effectively a set of helpers for interacting with a SkGlyphCache by GrBatchTextStrike. The class is deleted and the code is made into static functions in GrBatchFontCache.cpp
BUG=chromium:608566
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1985163002
Review-Url: https://codereview.chromium.org/
1985163002
liyuqian [Tue, 17 May 2016 19:44:20 +0000 (12:44 -0700)]
Implement touch control
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1982643004
Review-Url: https://codereview.chromium.org/
1982643004
msarett [Tue, 17 May 2016 19:37:39 +0000 (12:37 -0700)]
Fix leak of SkGammas
TBR=borenet@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1990533002
Review-Url: https://codereview.chromium.org/
1990533002
bungeman [Tue, 17 May 2016 19:24:24 +0000 (12:24 -0700)]
Fix code guarded by SK_FONT_HOST_USE_SYSTEM_SETTINGS.
BUG=skia:5313
Review-Url: https://codereview.chromium.org/
1988913003
jvanverth [Tue, 17 May 2016 19:15:48 +0000 (12:15 -0700)]
Add OpenGL context to Viewer.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978573003
Review-Url: https://codereview.chromium.org/
1978573003
bsalomon [Tue, 17 May 2016 18:58:24 +0000 (11:58 -0700)]
Remove GrFontDescKey.
This was a reference counted wrapper of SkDescriptor. It doesn't seem like the copies are performance critical. This gets us closer to removing GrFontScaler.
Also removes some unused member functions on GrBatchTextStrike and GrFontScaler.
BUG=chromium:608566
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1988833003
Review-Url: https://codereview.chromium.org/
1988833003
brianosman [Tue, 17 May 2016 18:47:32 +0000 (11:47 -0700)]
Set the "mutable format" bit on sRGB images at creation time.
This allows us to later create an image view with a linear format, for
legacy-mode non-sRGB access.
No actual API change (just a comment change in public header).
TBR=bsalomon@google.com
BUG=skia:5308
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1981333004
Review-Url: https://codereview.chromium.org/
1981333004
borenet [Tue, 17 May 2016 17:26:15 +0000 (10:26 -0700)]
Make VisualBench bot build the visualbench target
Plus drive-by fixes for expectations/coverage.
BUG=skia:5185
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1986273002
Review-Url: https://codereview.chromium.org/
1986273002
bsalomon [Tue, 17 May 2016 17:17:45 +0000 (10:17 -0700)]
Rename SkDescriptor::equals to SkDescriptor::operator==
BUG=chromium:608566
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1986253002
Review-Url: https://codereview.chromium.org/
1986253002
robertphillips [Tue, 17 May 2016 16:57:46 +0000 (09:57 -0700)]
(Mostly) Retract GrRenderTarget from SkGpuDevice
This gets us most of the way to having SkGpuDevice exclusively use a GrDrawContext instead of a GrRenderTarget. There are a few other refactorings (e.g., rm need for fLegacyBitmap and accessRenderTarget) before the GrRenderTarget can be completely removed.
Has calved off:
https://codereview.chromium.org/
1925313002/ (Tighten up SkSpecialSurface factory functions)
https://codereview.chromium.org/
1925803004/ (Add sk_sp to SkSurface_Gpu and SkGpuDevice)
https://codereview.chromium.org/
1956473002/ (Retract GrRenderTarget a bit within SkGpuDevice)
https://codereview.chromium.org/
1979913002/ (Rename GrDrawingMgr::abandon to wasAbandoned & add a matching entry point to GrDrawingContext)
https://codereview.chromium.org/
1982583002/ (Add isUnifiedMultisampled entry point to GrDrawContext)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1930013002
Review-Url: https://codereview.chromium.org/
1930013002
herb [Tue, 17 May 2016 16:57:34 +0000 (09:57 -0700)]
Add tests and benches to support the sRGB blitter for SkOpts
1,370.85 LinearSrcOvericonstrip.pngVSkOptsSSE41
2,359.69 LinearSrcOvericonstrip.pngVSkOptsDefault
1,828.72 LinearSrcOvericonstrip.pngVSkOptsNonSimdCore
3,277.40 LinearSrcOvericonstrip.pngVSkOptsTrivial
9,862.34 LinearSrcOvericonstrip.pngVSkOptsBruteForce
633.55 LinearSrcOvermandrill_512.pngVSkOptsSSE41
684.29 LinearSrcOvermandrill_512.pngVSkOptsDefault
1,201.88 LinearSrcOvermandrill_512.pngVSkOptsNonSimdCore
2,382.63 LinearSrcOvermandrill_512.pngVSkOptsTrivial
10,888.74 LinearSrcOvermandrill_512.pngVSkOptsBruteForce
209.14 LinearSrcOverplane.pngVSkOptsSSE41
562.24 LinearSrcOverplane.pngVSkOptsDefault
272.64 LinearSrcOverplane.pngVSkOptsNonSimdCore
436.46 LinearSrcOverplane.pngVSkOptsTrivial
1,327.23 LinearSrcOverplane.pngVSkOptsBruteForce
318.01 LinearSrcOverbaby_tux.pngVSkOptsSSE41
529.05 LinearSrcOverbaby_tux.pngVSkOptsDefault
441.33 LinearSrcOverbaby_tux.pngVSkOptsNonSimdCore
720.50 LinearSrcOverbaby_tux.pngVSkOptsTrivial
2,191.10 LinearSrcOverbaby_tux.pngVSkOptsBruteForce
479.68 LinearSrcOveryellow_rose.pngVSkOptsSSE41
1,095.03 LinearSrcOveryellow_rose.pngVSkOptsDefault
668.60 LinearSrcOveryellow_rose.pngVSkOptsNonSimdCore
1,257.19 LinearSrcOveryellow_rose.pngVSkOptsTrivial
4,970.25 LinearSrcOveryellow_rose.pngVSkOptsBruteForce
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1939513002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Committed: https://skia.googlesource.com/skia/+/
554784cd85029c05d9ed04b1aeb71520d196153a
Committed: https://skia.googlesource.com/skia/+/
bc927548db17accec2195af6e15053f7918bb3f5
Review-Url: https://codereview.chromium.org/
1939513002
msarett [Tue, 17 May 2016 16:31:20 +0000 (09:31 -0700)]
Prepare SkColorSpace to be a public API
Moves implementation details into SkColorSpacePriv.h
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1985903002
Review-Url: https://codereview.chromium.org/
1985903002
msarett [Tue, 17 May 2016 16:31:04 +0000 (09:31 -0700)]
Update libpng to 1.6.22rc01
If there are no issues, this version will be released May 26.
Let's start testing with it, so we are ready to update Chrome when
it is available.
BUG=skia:4710
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1983853002
Review-Url: https://codereview.chromium.org/
1983853002
msarett [Tue, 17 May 2016 15:52:11 +0000 (08:52 -0700)]
Ensure that SkColorTable->fCount is set properly after decodes
We now have some blits that will process the color table.
If we erroneously report that the size of the color table is 256,
we will do extra work and annoy MSAN.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1982753002
Review-Url: https://codereview.chromium.org/
1982753002
bsalomon [Tue, 17 May 2016 15:36:41 +0000 (08:36 -0700)]
Make GrFontScaler not be ref-counted
This object is made invalid when the SkGlyphCache that it points to is destroyed.
BUG=chromium:608566
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1982303002
Review-Url: https://codereview.chromium.org/
1982303002
herb [Tue, 17 May 2016 13:50:15 +0000 (06:50 -0700)]
Revert of Change to sRGB default for codec generated images. (patchset #2 id:20001 of https://codereview.chromium.org/
1955063002/ )
Reason for revert:
TBR=brianosman@google.com
Original issue's description:
> Change to sRGB default for codec generated images.
>
> Compared the gm and skps for 8888 and srgb. There are no differences for 8888, there are 100 differences for sRGB, but the 100 look correct compared to the old ones.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1955063002
>
> Committed: https://skia.googlesource.com/skia/+/
7acc00853174361cf921ecac8fbeaf6812f53eed
TBR=brianosman@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
1982323002
kkinnunen [Tue, 17 May 2016 13:01:40 +0000 (06:01 -0700)]
Remove workarounds initializing command buffer EGL
The eglDisplay() of command buffer EGL implementation now does not
allocate a new EGL display per call, rather just returns the global.
The EGL implementation is fixed as part of bug 581634.
Removes eglTerminate call, as it's should not be used in Skia at the
moment. The call will terminate all of EGL, which is not intendend. The
previous usage was only due to incorrect implementation of the API. Not
added back to anywhere else, leaking EGL globals is as
designed. Discussed in https://chromiumcodereview.appspot.com/
1733323002.
BUG=581634, 603223
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978733003
Review-Url: https://codereview.chromium.org/
1978733003
reed [Tue, 17 May 2016 10:07:01 +0000 (03:07 -0700)]
Revert of Add specialized sRGB blitter for SkOpts (patchset #21 id:400001 of https://codereview.chromium.org/
1939513002/ )
Reason for revert:
broke some debug bots:
Running LinearSrcOvericonstrip.pngVSkOptsSSE41 nonrendering
../../../bench/SkBlend_optsBench.cpp:118: fatal error: ""fPixmap.colorType() == kRGBA_8888_SkColorType""
Original issue's description:
> Add tests and benches to support the sRGB blitter for SkOpts
>
> 1,370.85 LinearSrcOvericonstrip.pngVSkOptsSSE41
> 2,359.69 LinearSrcOvericonstrip.pngVSkOptsDefault
> 1,828.72 LinearSrcOvericonstrip.pngVSkOptsNonSimdCore
> 3,277.40 LinearSrcOvericonstrip.pngVSkOptsTrivial
> 9,862.34 LinearSrcOvericonstrip.pngVSkOptsBruteForce
>
> 633.55 LinearSrcOvermandrill_512.pngVSkOptsSSE41
> 684.29 LinearSrcOvermandrill_512.pngVSkOptsDefault
> 1,201.88 LinearSrcOvermandrill_512.pngVSkOptsNonSimdCore
> 2,382.63 LinearSrcOvermandrill_512.pngVSkOptsTrivial
> 10,888.74 LinearSrcOvermandrill_512.pngVSkOptsBruteForce
>
> 209.14 LinearSrcOverplane.pngVSkOptsSSE41
> 562.24 LinearSrcOverplane.pngVSkOptsDefault
> 272.64 LinearSrcOverplane.pngVSkOptsNonSimdCore
> 436.46 LinearSrcOverplane.pngVSkOptsTrivial
> 1,327.23 LinearSrcOverplane.pngVSkOptsBruteForce
>
> 318.01 LinearSrcOverbaby_tux.pngVSkOptsSSE41
> 529.05 LinearSrcOverbaby_tux.pngVSkOptsDefault
> 441.33 LinearSrcOverbaby_tux.pngVSkOptsNonSimdCore
> 720.50 LinearSrcOverbaby_tux.pngVSkOptsTrivial
> 2,191.10 LinearSrcOverbaby_tux.pngVSkOptsBruteForce
>
> 479.68 LinearSrcOveryellow_rose.pngVSkOptsSSE41
> 1,095.03 LinearSrcOveryellow_rose.pngVSkOptsDefault
> 668.60 LinearSrcOveryellow_rose.pngVSkOptsNonSimdCore
> 1,257.19 LinearSrcOveryellow_rose.pngVSkOptsTrivial
> 4,970.25 LinearSrcOveryellow_rose.pngVSkOptsBruteForce
>
>
>
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1939513002
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
554784cd85029c05d9ed04b1aeb71520d196153a
>
> Committed: https://skia.googlesource.com/skia/+/
bc927548db17accec2195af6e15053f7918bb3f5
TBR=mtklein@google.com,fmalita@chromium.org,herb@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
1986763002
herb [Mon, 16 May 2016 21:27:51 +0000 (14:27 -0700)]
Add tests and benches to support the sRGB blitter for SkOpts
1,370.85 LinearSrcOvericonstrip.pngVSkOptsSSE41
2,359.69 LinearSrcOvericonstrip.pngVSkOptsDefault
1,828.72 LinearSrcOvericonstrip.pngVSkOptsNonSimdCore
3,277.40 LinearSrcOvericonstrip.pngVSkOptsTrivial
9,862.34 LinearSrcOvericonstrip.pngVSkOptsBruteForce
633.55 LinearSrcOvermandrill_512.pngVSkOptsSSE41
684.29 LinearSrcOvermandrill_512.pngVSkOptsDefault
1,201.88 LinearSrcOvermandrill_512.pngVSkOptsNonSimdCore
2,382.63 LinearSrcOvermandrill_512.pngVSkOptsTrivial
10,888.74 LinearSrcOvermandrill_512.pngVSkOptsBruteForce
209.14 LinearSrcOverplane.pngVSkOptsSSE41
562.24 LinearSrcOverplane.pngVSkOptsDefault
272.64 LinearSrcOverplane.pngVSkOptsNonSimdCore
436.46 LinearSrcOverplane.pngVSkOptsTrivial
1,327.23 LinearSrcOverplane.pngVSkOptsBruteForce
318.01 LinearSrcOverbaby_tux.pngVSkOptsSSE41
529.05 LinearSrcOverbaby_tux.pngVSkOptsDefault
441.33 LinearSrcOverbaby_tux.pngVSkOptsNonSimdCore
720.50 LinearSrcOverbaby_tux.pngVSkOptsTrivial
2,191.10 LinearSrcOverbaby_tux.pngVSkOptsBruteForce
479.68 LinearSrcOveryellow_rose.pngVSkOptsSSE41
1,095.03 LinearSrcOveryellow_rose.pngVSkOptsDefault
668.60 LinearSrcOveryellow_rose.pngVSkOptsNonSimdCore
1,257.19 LinearSrcOveryellow_rose.pngVSkOptsTrivial
4,970.25 LinearSrcOveryellow_rose.pngVSkOptsBruteForce
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1939513002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Committed: https://skia.googlesource.com/skia/+/
554784cd85029c05d9ed04b1aeb71520d196153a
Review-Url: https://codereview.chromium.org/
1939513002
bsalomon [Mon, 16 May 2016 21:09:56 +0000 (14:09 -0700)]
Implement vulkan fence syncs for nanobench
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1974913003
Review-Url: https://codereview.chromium.org/
1974913003
bungeman [Mon, 16 May 2016 19:39:23 +0000 (12:39 -0700)]
Remove unneeded reference count churn.
An object was ref'ed only to be automatically unref'ed.
Review-Url: https://codereview.chromium.org/
1979193009
borenet [Mon, 16 May 2016 17:38:51 +0000 (10:38 -0700)]
Move VisualBench_APK and SampleApp_APK to "everything" target
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1986433002
Review-Url: https://codereview.chromium.org/
1986433002
robertphillips [Mon, 16 May 2016 16:50:03 +0000 (09:50 -0700)]
Add isUnifiedMultisampled entry point to GrDrawContext
GrRenderTargetProxy supports the isUnifiedMultisampled call so GrDrawContext will be able to support it even when GrRenderTargetProxy-backed.
This is split out of: https://codereview.chromium.org/
1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1982583002
Review-Url: https://codereview.chromium.org/
1982583002
herb [Mon, 16 May 2016 16:43:54 +0000 (09:43 -0700)]
Change to sRGB default for codec generated images.
Compared the gm and skps for 8888 and srgb. There are no differences for 8888, there are 100 differences for sRGB, but the 100 look correct compared to the old ones.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1955063002
Review-Url: https://codereview.chromium.org/
1955063002
bsalomon [Mon, 16 May 2016 16:36:44 +0000 (09:36 -0700)]
Make blurcircles2 run as a benchmark.
In bench mode it does not draw the comparison paths (or line separators). It also randomly perturbs the blur and circle radii to avoid trivially hitting the same cache entries and each repetition.
BUG=skia:5224
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1985713002
Review-Url: https://codereview.chromium.org/
1985713002
msarett [Mon, 16 May 2016 16:23:42 +0000 (09:23 -0700)]
Recognize Adobe RGB profiles
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1971203002
Review-Url: https://codereview.chromium.org/
1971203002
robertphillips [Mon, 16 May 2016 16:14:53 +0000 (09:14 -0700)]
Rename GrDrawingMgr::abandon to wasAbandoned & add a matching entry point to GrDrawingContext
Since GrDrawingContext is generally replacing GrRenderTarget, this is to provide functionality similar to GrRenderTarget::wasDestroyed.
This is split out of https://codereview.chromium.org/
1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1979913002
Review-Url: https://codereview.chromium.org/
1979913002
bsalomon [Mon, 16 May 2016 16:09:18 +0000 (09:09 -0700)]
Run GM benchs in bench mode
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978253002
Review-Url: https://codereview.chromium.org/
1978253002
scroggo [Mon, 16 May 2016 16:04:18 +0000 (09:04 -0700)]
Only run kStripe_Mode on JPEGs
It was designed to test code in libjpeg-turbo. Skipping scanlines is
tested more generally in other tests.
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978013002
Review-Url: https://codereview.chromium.org/
1978013002
scroggo [Mon, 16 May 2016 16:04:13 +0000 (09:04 -0700)]
Drop AndroidCodecSrc::kDivisor_Mode
This is redundant with BRD tests.
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1976303002
Review-Url: https://codereview.chromium.org/
1976303002
robertphillips [Sun, 15 May 2016 14:53:35 +0000 (07:53 -0700)]
Retract GrRenderTarget from AlphaClipMask code
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1977793004
Committed: https://skia.googlesource.com/skia/+/
93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d
Review-Url: https://codereview.chromium.org/
1977793004
update-skps [Sun, 15 May 2016 07:41:23 +0000 (00:41 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1979893002
Review-Url: https://codereview.chromium.org/
1979893002
bsalomon [Sun, 15 May 2016 00:55:32 +0000 (17:55 -0700)]
Fix return from nullptr to false in GrVkTexture.cpp
TBR=egdaniel@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978113002
Review-Url: https://codereview.chromium.org/
1978113002
adrian gallero [Fri, 13 May 2016 23:14:04 +0000 (20:14 -0300)]
Merge remote-tracking branch 'mono/xamarin-mobile-bindings' into typeface
bsalomon [Fri, 13 May 2016 20:48:48 +0000 (13:48 -0700)]
Add blurcircles2 GM
In GM mode this draws an array of circles with different radii and different blur radii. Below each circle an almost-circle path is drawn with the same blur filter for comparison.
In Sample mode this draws a single circle and almost-circle with animating radius and blur radius.
BUG=skia:5224
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1974353003
Review-Url: https://codereview.chromium.org/
1974353003
bsalomon [Fri, 13 May 2016 20:47:04 +0000 (13:47 -0700)]
Revert of Retract GrRenderTarget from AlphaClipMask code (patchset #3 id:40001 of https://codereview.chromium.org/
1977793004/ )
Reason for revert:
Possible cause of leak in ASAN bot:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/3351
Original issue's description:
> Retract GrRenderTarget from AlphaClipMask code
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1977793004
>
> Committed: https://skia.googlesource.com/skia/+/
93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d
TBR=robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
1975353002
egdaniel [Fri, 13 May 2016 20:43:44 +0000 (13:43 -0700)]
Fix msaa on GrVkRenderTarget
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1977113002
Review-Url: https://codereview.chromium.org/
1977113002
robertphillips [Fri, 13 May 2016 18:51:23 +0000 (11:51 -0700)]
Retract GrRenderTarget from AlphaClipMask code
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1977793004
Review-Url: https://codereview.chromium.org/
1977793004
fmalita [Fri, 13 May 2016 18:40:07 +0000 (11:40 -0700)]
SkPictureGpuAnalyzer
Stateful helper for gathering multi-picture GPU stats.
Exposes the existing SkPicture GPU veto semantics, while preserving
the SKP impl (which has some nice properties: lazy, hierarchical,
cached per pic).
R=reed@google.com,bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1974833003
Review-Url: https://codereview.chromium.org/
1974833003
egdaniel [Fri, 13 May 2016 18:30:37 +0000 (11:30 -0700)]
Refactor Vulkan image, texture, RTs so that create and getter handles match.
This allows allows us to track and notify clients when either side changes
and image layout.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1974983002
Review-Url: https://codereview.chromium.org/
1974983002
cdalton [Fri, 13 May 2016 18:27:15 +0000 (11:27 -0700)]
Abort stencil draws when the attachment fails
BUG=skia:611514
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1971353003
Review-Url: https://codereview.chromium.org/
1971353003
robertphillips [Fri, 13 May 2016 18:20:46 +0000 (11:20 -0700)]
Retract GrRenderTarget a bit within SkGpuDevice
Split off of: https://codereview.chromium.org/
1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1956473002
Committed: https://skia.googlesource.com/skia/+/
d215a95882485026d176a81bf58871276b21c89c
Review-Url: https://codereview.chromium.org/
1956473002
cdalton [Fri, 13 May 2016 17:25:00 +0000 (10:25 -0700)]
Convert GrClip to an abstract base class
Converts GrClip to an abstract base class and adds a "GrFixedClip"
implementation. GrFixedClip denotes a clip implemented with fixed-
function hardware. GrFixedClip allows us to remove the stateful
"fClipMode" member from GrClipMaskManager, and in the future will
be able to nicely encapsulate window rectangles.
After this change GrClipMaskManager is just a wrapper around
GrDrawTarget. We may want to consider removing it altogether.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1971343002
Review-Url: https://codereview.chromium.org/
1971343002
Matthew Leibowitz [Fri, 13 May 2016 17:16:45 +0000 (19:16 +0200)]
more fixes for android
herb [Fri, 13 May 2016 17:04:46 +0000 (10:04 -0700)]
This has all the different source types in and working. There are many SkDiffs, but they seem to be due to better resolution.
This seems to fix all the bugs involved with make all the images produced by the codec to default to sRGB.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1967283002
Review-Url: https://codereview.chromium.org/
1967283002
liyuqian [Fri, 13 May 2016 16:57:44 +0000 (09:57 -0700)]
Change Android activity title from JNI call
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978843002
Review-Url: https://codereview.chromium.org/
1978843002
Matthew Leibowitz [Fri, 13 May 2016 16:54:59 +0000 (18:54 +0200)]
op will never be NULL as it is an integer/enum
Matthew Leibowitz [Fri, 13 May 2016 16:52:01 +0000 (18:52 +0200)]
make sure to init the clip operation