Pushpinder Singh [Wed, 21 Apr 2021 14:04:44 +0000 (14:04 +0000)]
[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed
This patch adds new clang tool named amdgpu-arch which uses
HSA to detect installed AMDGPU and report back latter's march.
This tool is built only if system has HSA installed.
The value printed by amdgpu-arch is used to fill -march when
latter is not explicitly provided in -Xopenmp-target.
Reviewed By: JonChesterfield, gregrodgers
Differential Revision: https://reviews.llvm.org/D99949
Snehasish Kumar [Wed, 21 Apr 2021 21:41:12 +0000 (14:41 -0700)]
[CodeGen] Do not split functions with attr "implicit-section-name".
The #pragma clang section can be used at a coarse granularity to specify
the section used for bss/data/text/rodata for global objects. When split
functions is enabled, the function may be split into two parts violating
user expectations.
Reference:
https://clang.llvm.org/docs/LanguageExtensions.html#specifying-section-names-for-global-objects-pragma-clang-section
Differential Revision: https://reviews.llvm.org/D101004
Peter Collingbourne [Thu, 22 Apr 2021 02:13:36 +0000 (19:13 -0700)]
scudo: Obtain tag from pointer instead of loading it from memory. NFCI.
Since we already have a tagged pointer available to us, we can just
extract the tag from it and avoid an LDG instruction.
Differential Revision: https://reviews.llvm.org/D101014
Chen Zheng [Tue, 20 Apr 2021 02:03:44 +0000 (22:03 -0400)]
[Debug-Info] implement -gstrict-dwarf
This patch implements -gstrict-dwarf option in clang FE.
Reviewed By: dblaikie, probinson, aprantl
Differential Revision: https://reviews.llvm.org/D100809
Serge Pavlov [Thu, 5 Nov 2020 06:59:52 +0000 (13:59 +0700)]
[RISCV] Custom lowering of FLT_ROUNDS_
Differential Revision: https://reviews.llvm.org/D90854
thomasraoux [Fri, 16 Apr 2021 20:38:15 +0000 (13:38 -0700)]
[mlir][linalg] Add pattern to push reshape after elementwise operation
This help expose more fusion opportunities.
Differential Revision: https://reviews.llvm.org/D100685
Craig Topper [Thu, 22 Apr 2021 03:15:39 +0000 (20:15 -0700)]
[RISCV] Teach lowerSPLAT_VECTOR_PARTS to detect cases where Hi is sign extended from Lo.
This recognizes the case when Hi is (sra Lo, 31). We can use
SPLAT_VECTOR_I64 rather than splatting the high bits and
combining them in the vector register.
Chuanqi Xu [Thu, 22 Apr 2021 03:20:20 +0000 (11:20 +0800)]
[Coroutine] Collect CoroBegin if all of terminators are dominated by one coro.destroy
Summary: The original logic seems to be we could collecting a CoroBegin
if one of the terminators could be dominated by one of coro.destroy,
which doesn't make sense.
This patch rewrites the logics to collect CoroBegin if all of
terminators are dominated by one coro.destroy. If there is no such
coro.destroy, we would call hasEscapePath to evaluate if we should
collect it.
Test Plan: check-llvm
Reviewed by: lxfind
Differential Revision: https://reviews.llvm.org/D100614
Evgeniy Brevnov [Thu, 22 Apr 2021 03:04:49 +0000 (10:04 +0700)]
Wordsmith the semantics of invariant.load
Don't phrase the semantics in terms of the optimizer. Instead have a
more straightforward execution based semantic.
Reviewed By: ebrevnov
Differential Revision: https://reviews.llvm.org/D63439
Jonas Devlieghere [Thu, 22 Apr 2021 02:56:38 +0000 (19:56 -0700)]
[lldb] Disable TestSimulatorPlatform.py because it's causing a SIGHUP
Ever since Dave Zarzycki's patch to sort test start times based on prior
test timing data (https://reviews.llvm.org/D98179) the test suite aborts
with a SIGHUP. I don't believe his patch is to blame, but rather
uncovers an preexisting issue by making test runs more deterministic.
I was able to narrow down the issue to TestSimulatorPlatform.py. The
issue also manifests itself on the standalone bot on GreenDragon [1].
This patch disables the test until we can figure this out.
[1] http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/
rdar://
76995109
Rob Suderman [Mon, 19 Apr 2021 20:40:33 +0000 (13:40 -0700)]
[mlir][tosa] Add tosa.avg_pool2d lowering
Added the float lowerings for avg pool with corresponding tests.
Differential Revision: https://reviews.llvm.org/D100793
Matt Arsenault [Tue, 20 Apr 2021 19:30:18 +0000 (15:30 -0400)]
AMDGPU: Fix assert when trying to fold reg_sequence of physreg copies
Giorgis Georgakoudis [Wed, 21 Apr 2021 18:41:31 +0000 (11:41 -0700)]
[OpenMP] Simplify offloading parallel call codegen
This revision simplifies Clang codegen for parallel regions in OpenMP GPU target offloading and corresponding changes in libomptarget: SPMD/non-SPMD parallel calls are unified under a single `kmpc_parallel_51` runtime entry point for parallel regions (which will be commonized between target, host-side parallel regions), data sharing is internalized to the runtime. Tests have been auto-generated using `update_cc_test_checks.py`. Also, the revision contains changes to OpenMPOpt for remark creation on target offloading regions.
Reviewed By: jdoerfert, Meinersbur
Differential Revision: https://reviews.llvm.org/D95976
Fangrui Song [Thu, 22 Apr 2021 01:44:12 +0000 (18:44 -0700)]
Delete le32/le64 targets
They are unused now.
Note: NaCl is still used and is currently expected to be needed until 2022-06
(https://blog.chromium.org/2020/08/changes-to-chrome-app-support-timeline.html).
Differential Revision: https://reviews.llvm.org/D100981
Jessica Paquette [Tue, 20 Apr 2021 20:10:30 +0000 (13:10 -0700)]
[AArch64][GlobalISel] Fix regbankselect for G_FCMP with vector destinations
These should always go to a FPR, since they always use the vector registers.
Differential Revision: https://reviews.llvm.org/D100885
Jessica Paquette [Wed, 21 Apr 2021 00:48:17 +0000 (17:48 -0700)]
[AArch64][GlobalISel] Mark some vector G_ABS cases as legal
Each of the cases marked as legal here have an imported pattern in
AArch64GenGlobalISel.inc. So, if we mark them as legal, we get selection for
free.
Technically this is only supposed to happen if we have NEON support. But, we
fall back if we don't have that in the legalizer right now. I suppose it'd be
better to have a FIXME so we can write the testcase when the time comes.
(Plus, it'd just fall back in selection if NEON isn't available, so it's not
*wrong*, I guess?)
This fixes some fallbacks in the test suite.
(Also use `isScalar` from LegalityPredicates.cpp while we're here just to tidy
things a little bit.)
Differential Revision: https://reviews.llvm.org/D100916
Hongtao Yu [Tue, 20 Apr 2021 01:04:43 +0000 (18:04 -0700)]
[CSSPGO][llvm-profgen] Always report dangling probes for frames with real samples.
Report dangling probes for frames that have real samples collected. Dangling probes are the probes associated to an empty block. When reported, sample count on a dangling probe will not be trusted by the compiler and we will rely on the counts inference algorithm to get the probe a reasonable count. This actually fixes a bug where previously only those dangling probes with samples collected were reported.
This patch also fixes two existing issues. Pseudo probes are stored in `Address2ProbesMap` and their pointers are used in `PseudoProbeInlineTree`. Previously `std::vector` was used to store probes and the pointers to probes may get obsolete as the vector grows. I'm changing `std::vector` to `std::list` instead.
The other issue is that all outlined functions shared the same inline frame previously due to the unchanged `Index` value as the dummy inlineSite identifier.
Good results seen for SPEC2017 in general regarding profile quality.
Reviewed By: wenlei, wlei
Differential Revision: https://reviews.llvm.org/D100235
Matt Morehouse [Thu, 22 Apr 2021 00:06:09 +0000 (17:06 -0700)]
[HWASan] Untag argument to __hwasan_tag_memory.
__hwasan_tag_memory expects untagged pointers, so make sure our pointer
is untagged.
Eugene Zhulenev [Wed, 21 Apr 2021 22:52:50 +0000 (15:52 -0700)]
[mlir] Linalg : do not forward memrefs to outputs when do bufferization
Example:
```
%0 = linalg.init_tensor : tensor<...>
%1 = linalg.generic ... outs(%0: tensor<...>)
%2 = linalg.generic ... outs(%0: tensor<...>)
```
Memref allocated as a result of `init_tensor` bufferization can be incorrectly overwritten by the second linalg.generic operation
Reviewed By: silvas
Differential Revision: https://reviews.llvm.org/D100921
Fangrui Song [Wed, 21 Apr 2021 23:20:50 +0000 (16:20 -0700)]
[IR] Add doc about Function::createWithDefaultAttr. NFC
Fangrui Song [Wed, 21 Apr 2021 22:58:20 +0000 (15:58 -0700)]
[IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables
On ELF targets, if a function has uwtable or personality, or does not have
nounwind (`needsUnwindTableEntry`), it marks that `.eh_frame` is needed in the module.
Then, a function gets `.eh_frame` if `needsUnwindTableEntry` or `-g[123]` is specified.
(i.e. If -g[123], every function gets `.eh_frame`.
This behavior is strange but that is the status quo on GCC and Clang.)
Let's take asan as an example. Other sanitizers are similar.
`asan.module_[cd]tor` has no attribute. `needsUnwindTableEntry` returns true,
so every function gets `.eh_frame` if `-g[123]` is specified.
This is the root cause that
`-fno-exceptions -fno-asynchronous-unwind-tables -g` produces .debug_frame
while
`-fno-exceptions -fno-asynchronous-unwind-tables -g -fsanitize=address` produces .eh_frame.
This patch
* sets the nounwind attribute on sanitizer module ctor/dtor.
* let Clang emit a module flag metadata "uwtable" for -fasynchronous-unwind-tables. If "uwtable" is set, sanitizer module ctor/dtor additionally get the uwtable attribute.
The "uwtable" mechanism is generic: synthesized functions not cloned/specialized
from existing ones should consider `Function::createWithDefaultAttr` instead of
`Function::create` if they want to get some default attributes which
have more of module semantics.
Other candidates: "frame-pointer" (https://github.com/ClangBuiltLinux/linux/issues/955
https://github.com/ClangBuiltLinux/linux/issues/1238), dso_local, etc.
Differential Revision: https://reviews.llvm.org/D100251
Walter Erquinigo [Wed, 21 Apr 2021 22:46:02 +0000 (15:46 -0700)]
Fix VSCode/TestOptions.test
Found by https://lab.llvm.org/buildbot/#/builders/96/builds/6936
Petr Hosek [Sat, 17 Apr 2021 04:33:18 +0000 (21:33 -0700)]
[libcxx] Stop using use c++ subdirectory for libc++ library
The new layout more closely matches the layout used by other compilers.
This is only used when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is enabled.
Differential Revision: https://reviews.llvm.org/D100869
Michael Holman [Wed, 21 Apr 2021 22:29:19 +0000 (15:29 -0700)]
[CodeView] Add CodeView support for PGO debug information
This change adds debug information about whether PGO is being used or
not.
Microsoft performance tooling (e.g. xperf, WPA) uses this information to
show whether functions are optimized with PGO or not, as well as whether
PGO information is invalid.
This information is useful for validating whether training scenarios are
providing good coverage of real world scenarios, showing if profile data
is out of date, etc.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D99994
Walter Erquinigo [Wed, 21 Apr 2021 22:20:42 +0000 (15:20 -0700)]
Fix TestVSCode_runInTerminal
It failed in https://lab.llvm.org/buildbot/#/builders/68/builds/10912
And it was caused due to https://reviews.llvm.org/rG64f47c1e58a1
Walter Erquinigo [Wed, 21 Apr 2021 22:06:44 +0000 (15:06 -0700)]
[lldb-vscode] Distinguish shadowed variables in the scopes request
VSCode doesn't render multiple variables with the same name in the variables view. It only renders one of them. This is a situation that happens often when there are shadowed variables.
The nodejs debugger solves this by adding a number suffix to the variable, e.g. "x", "x2", "x3" are the different x variables in nested blocks.
In this patch I'm doing something similar, but the suffix is " @ <file_name:line>), e.g. "x @ main.cpp:17", "x @ main.cpp:21". The fallback would be an address if the source and line information is not present, which should be rare.
This fix is only needed for globals and locals. Children of variables don't suffer of this problem.
When there are shadowed variables
{
F16182150}
Without shadowed variables
{
F16182152}
Modifying these variables through the UI works
Reviewed By: clayborg
Differential Revision: https://reviews.llvm.org/D99989
Louis Dionne [Wed, 21 Apr 2021 21:56:58 +0000 (17:56 -0400)]
[libc++] Move the debug_level feature to the DSL
Craig Topper [Wed, 21 Apr 2021 15:51:00 +0000 (08:51 -0700)]
[RISCV] Cleanup up the spec version references around fmaxnum/fminnum.
This previously made references to 2.3-draft which was a short
lived version number in 2017. It was replaced by date based
versions leading up to ratification.
This patch uses the latest ratified version number and just says
what the behavior is. Nothing here is in flux.
Reviewed By: frasercrmck
Differential Revision: https://reviews.llvm.org/D100878
Craig Topper [Wed, 21 Apr 2021 07:25:42 +0000 (00:25 -0700)]
[RISCV] Temporary in vmsge(u).vx pseudo instructions can't be V0.
This was checked in some asserts, but not enforced by the
instruction matching.
There's still a second bug that we don't check that vt and vd
are different registers, but that will require custom checking.
Differential Revision: https://reviews.llvm.org/D100928
Walter Erquinigo [Wed, 21 Apr 2021 21:20:17 +0000 (14:20 -0700)]
[lldb-vscode] redirect stderr/stdout to the IDE's console
In certain occasions times, like when LLDB is initializing and
evaluating the .lldbinit files, it tries to print to stderr and stdout
directly. This confuses the IDE with malformed data, as it talks to
lldb-vscode using stdin and stdout following the JSON RPC protocol. This
ends up terminating the debug session with the user unaware of what's
going on. There might be other situations in which this can happen, and
they will be harder to debug than the .lldbinit case.
After several discussions with @clayborg, @yinghuitan and @aadsm, we
realized that the best course of action is to simply redirect stdout and
stderr to the console, without modifying LLDB itself. This will prove to
be resilient to future bugs or features.
I made the simplest possible redirection logic I could come up with. It
only works for POSIX, and to make it work with Windows should be merely
changing pipe and dup2 for the windows equivalents like _pipe and _dup2.
Sadly I don't have a Windows machine, so I'll do it later once my office
reopens, or maybe someone else can do it.
I'm intentionally not adding a stop-redirecting logic, as I don't see it
useful for the lldb-vscode case (why would we want to do that, really?).
I added a test.
Note: this is a simpler version of D80659. I first tried to implement a
RIIA version of it, but it was problematic to manage the state of the
thread and reverting the redirection came with some non trivial
complexities, like what to do with unflushed data after the debug
session has finished on the IDE's side.
River Riddle [Wed, 21 Apr 2021 21:33:30 +0000 (14:33 -0700)]
[mlir][mlir-lsp-server] Add some initial documentation on the MLIR LSP server
This covers some of the basic documentation, but is still missing some documentation/examples of features provided by the server. Feature documentation will be added in a followup.
Differential Revision: https://reviews.llvm.org/D100690
River Riddle [Wed, 21 Apr 2021 21:33:18 +0000 (14:33 -0700)]
[mlir] Add a vscode language extension for MLIR
This utilizes the mlir-lsp server to provide language services for MLIR files opened in vscode. The extension currently supports syntax highlighting, as well as tracking definitions/uses/source locations for SSA values and blocks.
Differential Revision: https://reviews.llvm.org/D100607
River Riddle [Wed, 21 Apr 2021 21:33:04 +0000 (14:33 -0700)]
[mlir][mlir-lsp] Add a new C++ LSP server for MLIR named mlir-lsp-server
This commits adds a basic LSP server for MLIR that supports resolving references and definitions. Several components of the setup are simplified to keep the size of this commit down, and will be built out in later commits. A followup commit will add a vscode language client that communicates with this server, paving the way for better IDE experience when interfacing with MLIR files.
The structure of this tool is similar to mlir-opt and mlir-translate, i.e. the implementation is structured as a library that users can call into to implement entry points that contain the dialects/passes that they are interested in.
Note: This commit contains several files, namely those in `mlir-lsp-server/lsp`, that have been copied from the LSP code in clangd and adapted for use in MLIR. This copying was decided as the best initial path forward (discussed offline by several stake holders in MLIR and clangd) given the different needs of our MLIR server, and the one for clangd. If a strong desire/need for unification arises in the future, the existence of these files in mlir-lsp-server can be reconsidered.
Differential Revision: https://reviews.llvm.org/D100439
River Riddle [Wed, 21 Apr 2021 21:32:50 +0000 (14:32 -0700)]
Add a new AsmParserState class to capture detailed source information for .mlir files
This information isn't useful for general compilation, but is useful for building tools that process .mlir files. This class will be used in a followup to start building an LSP language server for MLIR.
Differential Revision: https://reviews.llvm.org/D100438
Petr Hosek [Tue, 20 Apr 2021 23:14:02 +0000 (16:14 -0700)]
[MC] Use COMDAT for LSDA only if IR comdat type is any
This fixed issue introduced in
16af97393346ad636298605930a8b503a55eb40a
and
796feb61637c407aefcc0d462f24a1cc41f350d8.
Differential Revision: https://reviews.llvm.org/D100909
Walter Erquinigo [Wed, 21 Apr 2021 21:33:02 +0000 (14:33 -0700)]
Fix TestVSCode_launch test
Broken in https://lab.llvm.org/buildbot/#/builders/96/builds/6933
We don't really need to run this test on arm, but would be worth fixing
it later.
Olle Fredriksson [Wed, 21 Apr 2021 20:48:28 +0000 (22:48 +0200)]
[MemCpyOpt] Allow variable lengths in memcpy optimizer
This makes the memcpy-memcpy and memcpy-memset optimizations work for
variable sizes as long as they are equal, relaxing the old restriction
that they are constant integers. If they're not equal, the old
requirement that they are constant integers with certain size
restrictions is used.
The implementation works by pushing the length tests further down in the
code, which reveals some places where it's enough that the lengths are
equal (but not necessarily constant).
Differential Revision: https://reviews.llvm.org/D100870
Jonas Devlieghere [Wed, 21 Apr 2021 20:59:54 +0000 (13:59 -0700)]
Re-land "[Driver] Support default libc++ library location on Darwin"
This reverts commit
05eeed9691aeb3e0316712195b998e9078cdceb0 and after
fixing the impacted lldb tests in
5d1c43f333c2327be61604dc90ea675f0d1e6913.
[Driver] Support default libc++ library location on Darwin
Darwin driver currently uses libc++ headers that are part of Clang
toolchain when available (by default ../include/c++/v1 relative to
executable), but it completely ignores the libc++ library itself
because it doesn't pass the location of libc++ library that's part
of Clang (by default ../lib relative to the exceutable) to the linker
always using the system copy of libc++.
This may lead to subtle issues when the compilation fails because the
headers that are part of Clang toolchain are incompatible with the
system library. Either the driver should ignore both headers as well as
the library, or it should always try to use both when available.
This patch changes the driver behavior to do the latter which seems more
reasonable, it makes it easy to test and use custom libc++ build on
Darwin while still allowing the use of system version. This also matches
the Clang driver behavior on other systems.
Differential Revision: https://reviews.llvm.org/D45639
Yaxun (Sam) Liu [Wed, 21 Apr 2021 18:34:37 +0000 (14:34 -0400)]
[HIP] Add option -fgpu-inline-threshold
Add option -fgpu-inline-threshold for inline threshold for device compilation only.
Reviewed by: Artem Belevich
Differential Revision: https://reviews.llvm.org/D99233
Louis Dionne [Wed, 21 Apr 2021 21:12:01 +0000 (17:12 -0400)]
[libc++] Move macOS testing out of the 2nd CI stage
It's too slow, which delays the posting of CI results to Phabricator
when another step in the same stage fails.
Peter Collingbourne [Tue, 20 Apr 2021 21:54:32 +0000 (14:54 -0700)]
scudo: Make prepareTaggedChunk() and resizeTaggedChunk() generic.
Now that we have a more efficient implementation of storeTags(),
we should start using it from resizeTaggedChunk(). With that, plus
a new storeTag() function, resizeTaggedChunk() can be made generic,
and so can prepareTaggedChunk(). Make it so.
Now that the functions are generic, move them to combined.h so that
memtag.h no longer needs to know about chunks.
Differential Revision: https://reviews.llvm.org/D100911
Peter Collingbourne [Tue, 20 Apr 2021 21:53:41 +0000 (14:53 -0700)]
scudo: Use DC GZVA instruction in storeTags().
DC GZVA can operate on multiple granules at a time (corresponding to
the CPU's cache line size) so we can generally expect it to be faster
than STZG in a loop.
Differential Revision: https://reviews.llvm.org/D100910
Walter Erquinigo [Mon, 12 Apr 2021 20:00:37 +0000 (13:00 -0700)]
[lldb-vscode] Add postRunCommands
This diff ass postRunCommands, which are the counterpart of the preRunCommands. TThey will be executed right after the target is launched or attached correctly, which means that the targets can assume that the target is running.
Differential Revision: https://reviews.llvm.org/D100340
Arthur Eubanks [Wed, 21 Apr 2021 16:41:17 +0000 (09:41 -0700)]
[Evaluator] Bitcast result of pointer stripping
Trying to evaluate a GEP would assert with
"Ty == cast<PointerType>(C->getType()->getScalarType())->getElementType()"
because the type of the pointer we would evaluate the GEP argument to
would be a different type than the GEP was expecting. We should treat
pointer stripping as a bitcast.
The test adds a redundant GEP that would crash due to type mismatch.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D100970
Jonas Devlieghere [Wed, 21 Apr 2021 20:18:36 +0000 (13:18 -0700)]
[lldb] Use the compiler from the SDK in simulator tests
Use the clang compiler from the SDK to build the simulator test programs
to ensure we pick up the correct libc++.
Mehdi Chinoune [Wed, 21 Apr 2021 19:00:55 +0000 (14:00 -0500)]
[flang][msvc] Fix compilation of external-hello-world test with MSVC.
MSVC doesn't accept division by zero.
Reviewed By: Meinersbur
Differential Revision: https://reviews.llvm.org/D96069
Alexey Bataev [Wed, 21 Apr 2021 20:00:28 +0000 (13:00 -0700)]
[SLP]Add a test with broadcast shuffle kind in SLP, NFC.
Arthur Eubanks [Wed, 21 Apr 2021 19:13:53 +0000 (12:13 -0700)]
[LLParser] Print mismatched types in error message
Helps with debugging invalid handcrafted IR.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D100990
Dávid Bolvanský [Wed, 21 Apr 2021 19:59:46 +0000 (21:59 +0200)]
[LoopIdiom] Added testcase from PR44378; NFC
Jez Ng [Wed, 21 Apr 2021 19:43:38 +0000 (15:43 -0400)]
[lld-macho][nfc] Add accessors for commonly-used PlatformInfo fields
As discussed here: https://reviews.llvm.org/D100523#inline-951543
Reviewed By: #lld-macho, thakis, alexshap
Differential Revision: https://reviews.llvm.org/D100978
Nikita Popov [Wed, 21 Apr 2021 19:15:22 +0000 (21:15 +0200)]
Revert "[InstCombine] Fold multiuse shr eq zero"
This reverts commit
9423f78240a216e3f38b394a41fe3427dee22c26.
A performance regression with this patch has been reported at
https://reviews.llvm.org/rG9423f78240a2#990953. Reverting for now.
Roland McGrath [Sat, 17 Apr 2021 02:00:25 +0000 (19:00 -0700)]
[scudo] Avoid empty statement warnings
An empty macro that expands to just `... else ;` can get
warnings from some compilers (e.g. GCC's -Wempty-body).
Reviewed By: cryptoad, vitalybuka
Differential Revision: https://reviews.llvm.org/D100693
Jordan Rupprecht [Mon, 19 Apr 2021 21:32:26 +0000 (14:32 -0700)]
[lldb] Fix RichManglingContext::FromCxxMethodName() leak
`RichManglingContext::FromCxxMethodName` allocates a m_cxx_method_parser, but never deletes it.
This fixes a `-DLLVM_USE_SANITIZER=Leaks` failure.
Reviewed By: teemperor
Differential Revision: https://reviews.llvm.org/D100795
sstefan1 [Wed, 21 Apr 2021 19:02:28 +0000 (21:02 +0200)]
[FuncAttrs] Don't infer willreturn for nonexact definitions
Discovered during attributor testing comparing stats with
and without the attributor. Willreturn should not be inferred
for nonexact definitions.
Differential Revision: https://reviews.llvm.org/D100988
Emily Shi [Sat, 10 Apr 2021 00:47:54 +0000 (17:47 -0700)]
[compiler-rt] check max address from kernel is <= mmap range size
If these sizes do not match, asan will not work as expected. Previously, we added compile-time checks for non-iOS platforms. We check at run time for iOS because we get the max VM size from the kernel at run time.
rdar://
76477969
Reviewed By: delcypher
Differential Revision: https://reviews.llvm.org/D100784
sstefan1 [Tue, 20 Apr 2021 17:55:11 +0000 (19:55 +0200)]
[SimplifyLibCalls] Don't change alignment when creating memset
Fix for PR49984
This was discovered during Attributor testing.
Memset was always created with alignment of 1
and in case when strncpy alignment was changed
it triggered an assertion in the AttrBuilder.
Memset will now be created with appropriate alignment.
Differential Revision: https://reviews.llvm.org/D100875
Ahmed Taei [Mon, 19 Apr 2021 23:52:47 +0000 (16:52 -0700)]
Fix FoldReshapeOpWithUnitExtent generating illegal reshape
This will prevent fusion that spains all dims and generates
(d0, d1, ...) -> () reshape that isn't legal
Differential Revision: https://reviews.llvm.org/D100805
Sanjay Patel [Wed, 21 Apr 2021 18:13:30 +0000 (14:13 -0400)]
[InstSimplify] generalize ctlz-of-shifted-constant
https://alive2.llvm.org/ce/z/zWL_VQ
Sanjay Patel [Wed, 21 Apr 2021 18:07:34 +0000 (14:07 -0400)]
[InstSimplify] add tests for ctlz-of-shift-constant; NFC
Nico Weber [Wed, 21 Apr 2021 18:21:36 +0000 (14:21 -0400)]
[lld/mac] add aarch64 to requirements of encryption-info.s test
Mark de Wever [Wed, 21 Apr 2021 18:12:03 +0000 (20:12 +0200)]
[libc++][doc] Improve Phabricator links.
Removes the "reviews." part of the links as suggested by @ldionne in
D100707.
Krzysztof Parzyszek [Wed, 21 Apr 2021 17:50:40 +0000 (12:50 -0500)]
[Polly] Explicitly include all std headers
There were some recent header changes, and now some std classes
are no longer available in ScopDetection.cpp with the pre-existing
includes.
Simon Pilgrim [Wed, 21 Apr 2021 16:43:23 +0000 (17:43 +0100)]
[X86][SSE] getFauxShuffleMask - don't decode OR(SHUFFLE,SHUFFLE) containing UNDEFs. (PR50049)
PR50049 demonstrated an infinite loop between OR(SHUFFLE,SHUFFLE) <-> BLEND(SHUFFLE,SHUFFLE) patterns.
The UNDEF elements were allowing a combined shuffle mask to be widened which lost the undef element, resulting us needing to use the BLEND pattern (as the undef element would need to be zero for the OR pattern). But then bitcast folds would re-expose the undef element allowing us to use OR again.....
Michał Górny [Mon, 23 Nov 2020 13:24:54 +0000 (14:24 +0100)]
[lldb] [test/Register] Initial tests for regsets in core dumps
Add initial tests for reading register sets from core dumps. This
includes a C++ program to write registers and dump core, resulting core
dumps for Linux, FreeBSD and NetBSD, and the tests to verify them.
The tests are split into generic part, verifying user-specified register
values, and coredump-specific tests that verify memory addresses that
differ for every dump.
At this moment, all platforms support GPRs and FPRs up to XMM for amd64
target. The i386 target does not work on NetBSD at all, and is missing
FPRs entirely on FreeBSD.
Differential Revision: https://reviews.llvm.org/D91963
Jez Ng [Wed, 21 Apr 2021 17:35:12 +0000 (13:35 -0400)]
[lld-macho] Support LC_ENCRYPTION_INFO
This load command records a range spanning from the end of the load
commands to the end of the `__TEXT` segment. Presumably the kernel will encrypt
all this data.
Reviewed By: #lld-macho, thakis
Differential Revision: https://reviews.llvm.org/D100973
Alexey Bataev [Fri, 16 Apr 2021 18:29:01 +0000 (11:29 -0700)]
[OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.
The implicitly generated mappings for allocation/deallocation in mappers
runtime should be mapped as implicit, also no need to clear member_of
flag to avoid ref counter increment. Also, the ref counter should not be
incremented for the very first element that comes from the mapper
function.
Differential Revision: https://reviews.llvm.org/D100673
Fangrui Song [Wed, 21 Apr 2021 17:27:55 +0000 (10:27 -0700)]
[lsan][docs] Clarify supported platforms
Differential Revision: https://reviews.llvm.org/D100907
Christopher Di Bella [Wed, 21 Apr 2021 16:41:13 +0000 (16:41 +0000)]
[libcxx][iterator] adds `std::indirectly_readable` and `std::indirectly_writable`
Implements parts of:
* P0896R4 The One Ranges Proposal`
Depends on D99873.
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D100073
Michael Kruse [Wed, 21 Apr 2021 15:12:23 +0000 (10:12 -0500)]
[PollyACC] Fix declaration/stub definition mismatch. NFC.
external.c defines stub functions that are never used because of how
Polly uses PPCG. Unfortunately, they are declared as functions without
return values or parameters which does not match their declarations.
Since they are never called, this was usually not a problem, but an LTO
build gets confused with differently declared functions, or in case of
pet_options_args, a global variable declaration that is defined as a
function
Resolve by including the declaring headers in external.c which forces
the declaration and definition to match at compile-time.
This fixes llvm.org/50021
Arthur O'Dwyer [Mon, 19 Apr 2021 01:47:08 +0000 (21:47 -0400)]
[libc++] s/_LIBCPP_NO_HAS_CHAR8_T/_LIBCPP_HAS_NO_CHAR8_T/g
This was raised in D94511.
Differential Revision: https://reviews.llvm.org/D100736
Arthur O'Dwyer [Tue, 20 Apr 2021 18:14:35 +0000 (14:14 -0400)]
[libc++] [test] Remove epicyclic workarounds for vector/span; use T[] or std::array.
Simplify the test code, and drive-by also test that these algorithms
return the right iterator as their return value.
Differential Revision: https://reviews.llvm.org/D100876
Hongtao Yu [Wed, 21 Apr 2021 16:14:50 +0000 (09:14 -0700)]
[CSSPGO] Exclude pseudo probe from slotindex verification.
Nico Weber [Wed, 21 Apr 2021 15:49:17 +0000 (11:49 -0400)]
[gn build] add llvm-profgen to gn build
Didn't notice it missing due to https://reviews.llvm.org/D89707#2705110
LLVM GN Syncbot [Wed, 21 Apr 2021 15:39:33 +0000 (15:39 +0000)]
[gn build] Port
97e383aa061b
Alexander Shaposhnikov [Wed, 21 Apr 2021 15:18:20 +0000 (08:18 -0700)]
[lld][MachO] Refactor findCommand
Refactor findCommand to allow passing multiple types. NFC.
Test plan: make check-lld-macho
Differential revision: https://reviews.llvm.org/D100954
Pavel Labath [Wed, 21 Apr 2021 15:31:41 +0000 (17:31 +0200)]
[lldb/test] Clean up TestThreadSpecificBpPlusCondition inferior
The test had a race that could cause two threads to end up with the same
"thread local" value. I believe this would not cause the test to fail,
but it could cause it to succeed even when the functionality is broken.
The new implementation removes this uncertainty, and removes a lot of
cruft left over from the time this test was written using pthreads.
Stanislav Mekhanoshin [Tue, 20 Apr 2021 22:58:01 +0000 (15:58 -0700)]
[AMDGPU] Lower regbanks reassign threshold to 15000
Let it work on a very small kernels only. Measurements showed
the performance benefit is not worth the compile time.
Differential Revision: https://reviews.llvm.org/D100904
Louis Dionne [Tue, 20 Apr 2021 18:40:43 +0000 (14:40 -0400)]
[libc++] Add std::ranges::iter_move and std::iter_rvalue_reference_t
Original patch by @cjdb, modified by @ldionne.
Differential Revision: https://reviews.llvm.org/D99873
Nico Weber [Wed, 21 Apr 2021 15:10:45 +0000 (11:10 -0400)]
[flang] iwyu fixes after
ba7a92c01e8
Nico Weber [Wed, 21 Apr 2021 15:02:58 +0000 (11:02 -0400)]
[mlir] hopefully final round of iwyu fixes after
ba7a92c01e8
Pavel Labath [Fri, 16 Apr 2021 19:52:59 +0000 (21:52 +0200)]
[lldb/test] Modernize lldb-server test inferior
Avoid c string manipulation by introducing a StringRef-like
consume_front operation.
Nico Weber [Wed, 21 Apr 2021 14:54:44 +0000 (10:54 -0400)]
[mlir] yet more iwyu fixes after
ba7a92c01e8
Nico Weber [Wed, 21 Apr 2021 14:50:59 +0000 (10:50 -0400)]
[mlir] more iwyu fixes after
ba7a92c01e8
Nico Weber [Wed, 21 Apr 2021 14:48:54 +0000 (10:48 -0400)]
[mlir] some iwyu fixes after
ba7a92c01e8
Martin Probst [Wed, 21 Apr 2021 13:43:41 +0000 (15:43 +0200)]
clang-format: [JS] do not wrap after `asserts`
`asserts` is a pseudo keyword in TypeScript used in return types.
Wrapping after it triggers automatic semicolon insertion, which
breaks the code semantics/syntax.
`asserts` is different from other pseudo keywords in that it is
specific to TS and only carries meaning in a very specific location.
Thus introducing a token type is probably overkill.
Differential Revision: https://reviews.llvm.org/D100953
dfukalov [Wed, 21 Apr 2021 13:38:53 +0000 (16:38 +0300)]
[TTI] NFC: Change getVectorSplitCost to return InstructionCost
This patch migrates the TTI cost interfaces to return an InstructionCost.
See this patch for the introduction of the type: https://reviews.llvm.org/D91174
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146408.html
Reviewed By: sdesmalen
Differential Revision: https://reviews.llvm.org/D100952
Anirudh Prasad [Wed, 21 Apr 2021 14:19:52 +0000 (10:19 -0400)]
[AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string.
- Previously, https://reviews.llvm.org/D72680 introduced a new attribute called `AllowSymbolAtNameStart` (in relation to the MAsmParser changes) in `MCAsmInfo.h` which (according to the comment in the header) allows the following behaviour:
```
/// This is true if the assembler allows $ @ ? characters at the start of
/// symbol names. Defaults to false.
```
- However, the usage of this field in AsmLexer.cpp doesn't seem completely accurate* for a couple of reasons.
```
default:
if (MAI.doesAllowSymbolAtNameStart()) {
// Handle Microsoft-style identifier: [a-zA-Z_$.@?][a-zA-Z0-9_$.@#?]*
if (!isDigit(CurChar) &&
isIdentifierChar(CurChar, MAI.doesAllowAtInName(),
AllowHashInIdentifier))
return LexIdentifier();
}
```
1. The Dollar and At tokens, when occurring at the start of the string, are treated as separate tokens (AsmToken::Dollar and AsmToken::At respectively) and not lexed as an Identifier.
2. I'm not too sure why `MAI.doesAllowAtInName()` is used when `AllowAtInIdentifier` could be used. For X86 platforms, afaict, this shouldn't be an issue, since the `CommentString` attribute isn't "@". (alternatively the call to the setter can be set anywhere else as needed). The `AllowAtInName` does have an additional important meaning, but in the context of AsmLexer, shouldn't mean anything different compared to `AllowAtInIdentifier`
My proposal is the following:
- Introduce 3 new fields called `AllowQuestionTokenAtStartOfString`, `AllowDollarTokenAtStartOfString` and `AllowAtTokenAtStartOfString` in MCAsmInfo.h which will encapsulate the previously documented behaviour of "allowing $, @, ? characters at the start of symbol names")
- Introduce these fields where "$", "@" are lexed, and treat them as identifiers depending on whether `Allow[Dollar|At]TokenAtStartOfString` is set.
- For the sole case of "?", append it to the existing logic for treating a "default" token as an Identifier.
z/OS (HLASM) will also make use of some of these fields in follow up patches.
completely accurate* - This was based on the comments and the intended behaviour the code. I might have completely misinterpreted it, and if that is the case my sincere apologies. We can close this patch if necessary, if there are no changes to be made :)
Depends on https://reviews.llvm.org/D99374
Reviewed By: Jonathan.Crowther
Differential Revision: https://reviews.llvm.org/D99889
thomasraoux [Wed, 21 Apr 2021 14:02:17 +0000 (07:02 -0700)]
[mlir][NFC] Refactor linalg substituteMin and AffineMinSCF canonizalizations
Break up the dependency between SCF ops and substituteMin helper and make a
more generic version of AffineMinSCFCanonicalization. This reduce dependencies
between linalg and SCF and will allow the logic to be used with other kind of
ops. (Like ID ops).
Differential Revision: https://reviews.llvm.org/D100321
Nico Weber [Wed, 21 Apr 2021 14:00:30 +0000 (10:00 -0400)]
[Support] Don't include VirtualFileSystem.h in CommandLine.h
CommandLine.h is indirectly included in ~50% of TUs when building
clang, and VirtualFileSystem.h is large.
(Already remarked by jhenderson on D70769.)
No behavior change.
Differential Revision: https://reviews.llvm.org/D100957
Simon Pilgrim [Wed, 21 Apr 2021 14:06:35 +0000 (15:06 +0100)]
[PhaseOrdering] Add test case for PR45682
Ensures that the correct sequence of simplifycfg/instcombine/sroa reduce the IR to just a icmp+assume (which will be dropped in backend)
Simon Pilgrim [Wed, 21 Apr 2021 10:42:17 +0000 (11:42 +0100)]
[MC] MCInstrDesc.h - remove unnecessary <string> include. NFCI.
Victor Campos [Mon, 12 Apr 2021 16:03:06 +0000 (17:03 +0100)]
[Clang][ARM] Define __VFP_FP__ macro unconditionally
Clang only defines __VFP_FP__ when the FPU is enabled. However, gcc
defines it unconditionally.
This patch aligns Clang with gcc.
Reviewed By: peter.smith, rengolin
Differential Revision: https://reviews.llvm.org/D100372
Fraser Cormack [Wed, 21 Apr 2021 13:37:50 +0000 (14:37 +0100)]
[SelectionDAG] Fix minor typo in ISDOpcodes.h. NFC
Aaron Ballman [Wed, 21 Apr 2021 13:25:00 +0000 (09:25 -0400)]
Do not pass null attributes to BuildAttributedStmt during instantiation
When transforming an attribute during template instantiation, if the
transformation fails, it may result in a null attribute being returned.
This null attribute should not be passed in as one of the attributes
used to create an attributed statement.
If all of the attributes fail to transform, we do not create an
attributed statement at all.
There are no attributes that return null currently, so there is no easy
way to test this currently. However, this fixes a crash caused by
8344675908424ee532d4ae30e5043c5a5834e02c.
Guillaume Chatelet [Wed, 21 Apr 2021 13:25:24 +0000 (13:25 +0000)]
[libc] Enhance ArrayRef + unittests
This patch mostly adds unittests for `ArrayRef` and `MutableArrayRef`, additionnaly:
- We mimic the behavior of `std::vector` and disallow CV qualified type (`ArrayRef<const X>` is not allowed).
This is to make sure that the type traits are always valid (e.g. `value_type`, `pointer`, ...).
- In the previous implementation `ArrayRef` would define `value_type` as `const T` but this is not correct, it should be `T` for both `MutableArrayRef` and `ArrayRef`.
- We add the `equals` method to ease testing,
- We define the constructor taking an `Array` outside of the base implementation to ensure we match `const Array<T>&` and not `Array<const T>&` in the case of `ArrayRef`.
Differential Revision: https://reviews.llvm.org/D100732
Caroline Concatto [Mon, 12 Apr 2021 10:22:53 +0000 (11:22 +0100)]
[AArch64][SVE] Fix crash with icmp+select
This patch changes the lowering of SELECT_CC from Legal to Expand for scalable
vector and adds support for scalable vectors in performSelectCombine.
When selecting the nodes to lower in visitSELECT it checks if it is possible to
use SELECT_CC in cases where SETCC is followed by SELECT. visistSELECT checks
if SELECT_CC is legal or custom to replace SELECT by SELECT_CC.
SELECT_CC used to be legal for scalable vector, so the node changes to
SELECT_CC. This used to crash the compiler as there is no support for SELECT_CC
with scalable vectors. So now the compiler lowers to VSELECT instead of
SELECT_CC.
Differential Revision: https://reviews.llvm.org/D100485
Matt Arsenault [Tue, 20 Apr 2021 18:44:41 +0000 (14:44 -0400)]
AMDGPU: Fix indirect tail calls
Fix a selection error on uniform callees, and use a regular call if
divergent.
Neal (nealsid) [Wed, 21 Apr 2021 13:11:17 +0000 (15:11 +0200)]
Some FormatEntity.cpp cleanup and unit testing
Just fixing a few things I noticed as I am working on another feature for format
strings in the prompt: forward decls, adding constexpr constructors, various
checks, and unit tests for FormatEntity::Parse and new Definition constructors,
etc.
Reviewed By: teemperor
Differential Revision: https://reviews.llvm.org/D98153
LemonBoy [Wed, 21 Apr 2021 13:08:44 +0000 (15:08 +0200)]
[clang] Recognize ppc32 as valid mcpu value
The `ppc32` cpu model was introduced a while ago in
a9321059b912155cd81cf0776d54a7d6838ef7ab as an independent copy of the `ppc` one but was never wired into clang.
Reviewed By: #powerpc, nemanjai
Differential Revision: https://reviews.llvm.org/D100933
John Brawn [Wed, 21 Apr 2021 12:44:54 +0000 (13:44 +0100)]
Fix clang/test/Frontend/plugin-annotate-functions.c
FileCheck now gives an error when there's a check for an undefined
variable, which this test does in one of its NOT checks. Fix this by
being a bit looser in what the test checks.