Julien Isorce [Tue, 22 Aug 2017 12:48:26 +0000 (13:48 +0100)]
example: port testegl.c to desktop
Will be easier to maintain.
Also uniformize autotool build with meson build which is
already retrieving the gl libs.
https://bugzilla.gnome.org/show_bug.cgi?id=781606
Julien Isorce [Mon, 11 Dec 2017 15:55:44 +0000 (15:55 +0000)]
meson: move omx features check after target selection
And uses gst_omx_args instead of add_global_arguments.
Similar to
c69232852120d064c689caef07b3c68ad8fe6288
which was only for configure.ac
Useful to get omxvp8dec with meson too:
meson . buildtmp -D with_omx_target=tizonia
https://bugzilla.gnome.org/show_bug.cgi?id=782800
Julien Isorce [Mon, 4 Dec 2017 17:11:04 +0000 (17:11 +0000)]
config: add OMX.Aratelia.audio_decoder.aac to Tizonia config
Useful mostly for testing/debugging purpose as this is a software
based decoder (libfaad) for which GStreamer provides a direct
wrapper.
https://bugzilla.gnome.org/show_bug.cgi?id=791482
Guillaume Desmottes [Wed, 29 Nov 2017 13:18:41 +0000 (14:18 +0100)]
omxvideodec: retrieve OMX_IndexParamVideoPortFormat before setting it
The usual pattern when setting OMX params is to first get the struct
param, override the values we want to set and then set the updated
param.
We were not doing this with OMX_IndexParamVideoPortFormat and so were
resetting some fields such as OMX_VIDEO_PARAM_PORTFORMATTYPE.xFramerate
https://bugzilla.gnome.org/show_bug.cgi?id=790979
Julien Isorce [Sun, 21 May 2017 16:34:51 +0000 (17:34 +0100)]
omxaacenc: also set 'profile' if mpegversion is 4
Like done by gst_codec_utils_aac_caps_set_level_and_profile
which is called by avenc_aac, ffaac and voaacenc.
https://bugzilla.gnome.org/show_bug.cgi?id=735208
Guillaume Desmottes [Tue, 24 Oct 2017 10:19:50 +0000 (12:19 +0200)]
omx: wait for flush complete and buffers being released when flushing
As stated in the existing comment, when flusing we should wait for OMX
to send the flush command complete event AND all ports being released.
We were stopping as soon as one of those condition was met.
Fix a race between FillThisBufferDone/EmptyBufferDone and the flush
EventCmdComplete messages. The OMX implementation is supposed to release
its buffers before posting the EventCmdComplete event but the ordering
isn't guaranteed as the FillThisBufferDone/EmptyBufferDone and
EventHandler callbacks can be called from different threads (cf 2.7
'Thread Safety' in the spec).
https://bugzilla.gnome.org/show_bug.cgi?id=789475
Guillaume Desmottes [Tue, 24 Oct 2017 09:45:20 +0000 (11:45 +0200)]
gst_omx_port_set_flushing: simplify waiting loop
No semantic change so far, I just made the 'while' end condition easier
to understand as a first step before changing it.
- move error/time out checks inside the loop to make it clearer on what
we are actually waiting for.
- group port->buffers checks together with parenthesis as they are part
of the same conceptual check: waiting for all buffers to be released.
https://bugzilla.gnome.org/show_bug.cgi?id=789475
Matthew Waters [Mon, 27 Nov 2017 09:17:17 +0000 (20:17 +1100)]
Automatic update of common submodule
From 3f4aa96 to e8c7a71
Guillaume Desmottes [Thu, 23 Nov 2017 14:03:48 +0000 (15:03 +0100)]
zynqultrascaleplus: add support for extra AVC levels
The Zynqultrascaleplus has support for extra AVC levels not defined in
the OMX spec as a customer extension.
https://bugzilla.gnome.org/show_bug.cgi?id=790758
Guillaume Desmottes [Mon, 16 Oct 2017 12:47:07 +0000 (14:47 +0200)]
add test support
Most of the boilerplate and the states test has been copied from
gst-plugins-good.
https://bugzilla.gnome.org/show_bug.cgi?id=789094
Guillaume Desmottes [Tue, 17 Oct 2017 11:07:05 +0000 (13:07 +0200)]
meson: add tools support
Looks like the tools directory was left out during the initial port to
meson.
https://bugzilla.gnome.org/show_bug.cgi?id=789090
Guillaume Desmottes [Mon, 16 Oct 2017 12:24:50 +0000 (14:24 +0200)]
omx: fix build on rpi
The nTimeStamp field is a OMX_TICKS struct on the rpi so use the proper
macro to set it.
Fix build on the build which has been broken by
b3173144b7c1b12c9e1b7571f78659be45d813f6
https://bugzilla.gnome.org/show_bug.cgi?id=789052
Guillaume Desmottes [Tue, 17 Oct 2017 10:11:04 +0000 (12:11 +0200)]
check if Allegro headers are present when building zynqultrascaleplus
The Zynq UltraScale+ uses a custom version of OMX implementing several
3rd party extensions. Make sure those are present when building this
target.
https://bugzilla.gnome.org/show_bug.cgi?id=788064
Guillaume Desmottes [Mon, 16 Oct 2017 10:42:44 +0000 (12:42 +0200)]
omxvideodec: remove redundant debug message
We have already a debug message right after.
https://bugzilla.gnome.org/show_bug.cgi?id=789058
Guillaume Desmottes [Mon, 16 Oct 2017 11:26:38 +0000 (13:26 +0200)]
omxh265: fix enum casting when using Allegro HEVC extensions
Allegro's HEVC implementation defines a superset of the profiles and
enums from the Android implementation.
Properly cast to fix -Wenum-conversion warnings from clang.
https://bugzilla.gnome.org/show_bug.cgi?id=789057
Guillaume Desmottes [Mon, 16 Oct 2017 11:08:12 +0000 (13:08 +0200)]
properly cast extension enums
OMX's allow 3rds party to define extensions using their own enums
(like OMX_VIDEO_CODINGEXTTYPE) and to be used as the general
ones (like OMX_VIDEO_CODINGTYPE).
Properly cast those to fix -Wenum-conversion warnings from some
compilers such as clang.
https://bugzilla.gnome.org/show_bug.cgi?id=789057
Guillaume Desmottes [Mon, 9 Oct 2017 11:12:35 +0000 (13:12 +0200)]
omx: also reset nTimeStamp when re-using buffers
Some OMX implementations may check if the timestamp of the output buffers
they receive is actually not set.
https://bugzilla.gnome.org/show_bug.cgi?id=788711
Guillaume Desmottes [Wed, 4 Oct 2017 15:11:55 +0000 (17:11 +0200)]
omx: factor out gst_omx_buffer_reset()
https://bugzilla.gnome.org/show_bug.cgi?id=788711
Guillaume Desmottes [Mon, 9 Oct 2017 15:27:22 +0000 (17:27 +0200)]
add gst_omx_buffer_flags_to_string()
Make debug logs more readable so users don't have to manually figure out
the meaning of flags.
https://bugzilla.gnome.org/show_bug.cgi?id=788767
Ponnam Srinivas [Wed, 27 Sep 2017 14:17:29 +0000 (19:47 +0530)]
h263enc: fix caps leak in error code path
https://bugzilla.gnome.org/show_bug.cgi?id=788245
Ponnam Srinivas [Thu, 21 Sep 2017 09:51:36 +0000 (15:21 +0530)]
omxh264enc: fix caps leak
https://bugzilla.gnome.org/show_bug.cgi?id=787711
Ponnam Srinivas [Thu, 21 Sep 2017 06:06:46 +0000 (11:36 +0530)]
omxh265enc: fix caps leak
https://bugzilla.gnome.org/show_bug.cgi?id=787714
Guillaume Desmottes [Wed, 13 Sep 2017 13:32:51 +0000 (15:32 +0200)]
omxvideodec: log info about frame before releasing it
gst_video_decoder_release_frame() takes ownership of the frame and will
destroy it. So we should no longer use it after calling it.
https://bugzilla.gnome.org/show_bug.cgi?id=787628
Gurkirpal Singh [Sun, 20 Aug 2017 14:49:33 +0000 (20:19 +0530)]
configure: Show tizonia target in help
https://bugzilla.gnome.org/show_bug.cgi?id=786544
Guillaume Desmottes [Wed, 12 Jul 2017 12:35:10 +0000 (14:35 +0200)]
omxh265dec: add H265 decoder
Add HEVC decoder for the zynqultrascaleplus platform.
I used the H264 decoder code as a template.
https://bugzilla.gnome.org/show_bug.cgi?id=785434
Guillaume Desmottes [Wed, 12 Jul 2017 09:01:15 +0000 (11:01 +0200)]
omxh265enc: add H265 encoder
The OMX spec doesn't support HEVC but the OMX stack of the
zynqultrascaleplus adds it as a custom extension.
It uses the same API as the one of Android's OMX stack.
I used the H264 encoder code as a template.
https://bugzilla.gnome.org/show_bug.cgi?id=785434
Guillaume Desmottes [Mon, 28 Aug 2017 11:56:22 +0000 (13:56 +0200)]
omxvideoenc: use caps from query in propose_allocation
Prevent crash by not deferencing a NULL pointer if self->input_state
isn't defined when propose_allocation() is called.
https://bugzilla.gnome.org/show_bug.cgi?id=786442
Guillaume Desmottes [Mon, 4 Sep 2017 07:34:03 +0000 (09:34 +0200)]
omx: display states as string if changing failed
Improve the error message by displaying the states in their string
representation rather than their numerical value.
https://bugzilla.gnome.org/show_bug.cgi?id=787235
Julien Isorce [Tue, 22 Aug 2017 09:22:45 +0000 (10:22 +0100)]
omxvideodec: EGLDisplay is not indirectly defined by gstgl headers inclusion
Just use gpointer as done in GstGL to not include
EGL/egl.h just for EGLDisplay.
https://bugzilla.gnome.org/show_bug.cgi?id=784779
Gurkirpal Singh [Fri, 14 Jul 2017 11:04:04 +0000 (16:34 +0530)]
config: expose OMX.mesa h264 decoder and encoder in Tizonia config
https://bugzilla.gnome.org/show_bug.cgi?id=783976
Julien Isorce [Fri, 11 Aug 2017 14:48:37 +0000 (07:48 -0700)]
omxvideodec: remove wrong SettingsChanged ack
Partially revert 1b7d0b8:
omxvideodec: handle IL 1.2 behavior for OMX_SetParameter
It turned out it was a problem in the decoder which was
not updating some local variables upon SetParameter.
https://bugzilla.gnome.org/show_bug.cgi?id=783976
Julien Isorce [Thu, 20 Jul 2017 08:43:19 +0000 (09:43 +0100)]
omx{audio,video}{dec,enc}: sequentially disable ports because buffers are not shared
For the history, the parallel disable port has been introduced by:
"00be69f omxvideodec: Disable output port when setting a new format"
and then replicated to videoenc, audiodec and audioenc.
This is only required to do 'parallel' if buffers are shared between ports.
But for decoders and encoders the input and output buffer are of different
nature by definition (bitstream vs images). So they cannot be shared.
Also starting from IL 1.2.0 it is written in the spec that the parallel
disable is not allowed and will return an error. Except when buffers are
shared.
Again here we know in advance that they are not shared so let's always
do a sequential disable.
Tested on Desktop, rpi and zynqultrascaleplus.
https://bugzilla.gnome.org/show_bug.cgi?id=786348
Tim-Philipp Müller [Thu, 17 Aug 2017 11:26:05 +0000 (12:26 +0100)]
Automatic update of common submodule
From 48a5d85 to 3f4aa96
Guillaume Desmottes [Thu, 10 Aug 2017 16:16:53 +0000 (12:16 -0400)]
omxvideodec: use the decoder API to set latency
https://bugzilla.gnome.org/show_bug.cgi?id=785125
Guillaume Desmottes [Thu, 6 Jul 2017 12:19:19 +0000 (14:19 +0200)]
omxvideoenc/dec: declare latency on zynqultrascaleplus
The OMX specification doesn't provide any API to expose the latency
introduced by encoders and decoders. We implemented this as a custom
extension as declaring the latency is needed for live pipelines like
video conferencing.
https://bugzilla.gnome.org/show_bug.cgi?id=785125
Guillaume Desmottes [Mon, 7 Aug 2017 17:16:01 +0000 (13:16 -0400)]
omxvideoenc: adjust stride and slice height from input
Use the stride and slice height information from the first buffer meta
data to adjust the settings of the input port.
This will ensure that the OMX input buffers match the GStreamer ones
and so will save us from having to copy line-by-line each one.
This is also the first step to allow the OMX encoder to receive dmabuf.
Tested on rpi and zynqultrascaleplus.
https://bugzilla.gnome.org/show_bug.cgi?id=785967
Guillaume Desmottes [Mon, 7 Aug 2017 15:45:29 +0000 (11:45 -0400)]
omxvideoenc: delay buffer configuration until component is enabled
No significant change for now. Just delay the input port configuration
of the buffer size related fields (stride, slice height, buffer size)
until the component is activated.
This will allow us to use the actual stride/height of the first input
and so avoid the buffer copying code path in most cases.
Tested on rpi and zynqultrascaleplus.
https://bugzilla.gnome.org/show_bug.cgi?id=785967
Guillaume Desmottes [Mon, 24 Jul 2017 11:52:35 +0000 (13:52 +0200)]
omxvideodec/enc: delay allocation after the allocation query
Allocating OMX components buffers in set_format() is too early.
Doing it when receiving the first buffers will allow the element to use
the information from the allocation query and/or the first incoming
buffer to pick to best allocation mode.
Tested on raspberry pi with dynamic resolution changes on decoder and
encoder input.
https://bugzilla.gnome.org/show_bug.cgi?id=785967
Guillaume Desmottes [Tue, 25 Jul 2017 12:27:45 +0000 (14:27 +0200)]
omxvideoenc: start src thread in handle_frame()
Makes the code simpler as we no longer need to restart the thread in
gst_omx_video_enc_flush() and It's more symetric which the omxvideodec
implementation.
I'm also going to move the enabling of the OMX component in
handle_frame() and the src pad thread needs to be started after it.
https://bugzilla.gnome.org/show_bug.cgi?id=785967
Guillaume Desmottes [Tue, 25 Jul 2017 12:07:30 +0000 (14:07 +0200)]
omxvideodec: earlier return if downstream_flow_ret is not OK
There is no point to (re)start the src thread if, for example, we are
flushing.
https://bugzilla.gnome.org/show_bug.cgi?id=785967
Guillaume Desmottes [Mon, 24 Jul 2017 10:31:37 +0000 (12:31 +0200)]
omxvideodec: factor out enable and disable code
No semantic change, just factor out the code enabling and disabling the
component to their own functions.
Makes the code easier to read as the set_format() method was already
pretty big. Will also allow us to easily change the enabling logic.
https://bugzilla.gnome.org/show_bug.cgi?id=785967
Guillaume Desmottes [Mon, 24 Jul 2017 10:31:37 +0000 (12:31 +0200)]
omxvideoenc: factor out enable and disable code
No semantic change, just factor out the code enabling and disabling the
component to their own functions.
Makes the code easier to read as the set_format() method was already
pretty big. Will also allow us to easily change the enabling logic.
https://bugzilla.gnome.org/show_bug.cgi?id=785967
Guillaume Desmottes [Thu, 27 Jul 2017 10:12:01 +0000 (12:12 +0200)]
omx: also reset nFilledLen before calling OMX_FillThisBuffer()
The spec states that the buffer passed to OMX_FillThisBuffer() needs to be
empty. Some implementation may check it actually is by checking its
nFilledLen field, so best to reset it as well.
https://bugzilla.gnome.org/show_bug.cgi?id=785623
Julien Isorce [Mon, 17 Jul 2017 20:06:47 +0000 (21:06 +0100)]
omxvideodec: make generic the OMX_UseEGLImage code path
Will be easier to maintain and to make enhancements.
Tested with Tizonia on Desktop.
Also tested with Bellagio to make sure it does not crash when
calling OMX_UseEGLImage and indeed it returns NotImplemented.
Then gst-omx fallback to OMX_UseBuffer if it can and so on.
Also tested on rpi to make sure there is no regression.
https://bugzilla.gnome.org/show_bug.cgi?id=784365
Nicolas Dufresne [Fri, 21 Jul 2017 15:52:00 +0000 (11:52 -0400)]
omxvideodec: Fix segment seek
On segment seek, unlike EOS, we drain, but we cannot expect a flush
later to reset the decoder state. As a side effect, the decoder would
remain in EOS state and ignore any new incoming buffers.
To fix this, we call _flush() inside the _drain() function, and
_finish() becomes what _drain() was before. This way, for _finish() (the
eos case) we only drain, for _drain() triggered by segment seek or new
caps, we also reset the decoder state so it's ready to accept buffers.
https://bugzilla.gnome.org/show_bug.cgi?id=785237
Guillaume Desmottes [Mon, 10 Jul 2017 13:00:58 +0000 (15:00 +0200)]
omxvideoenc: ensure enough buffers are allocated in the pool
Handle allocation query and ensure enough buffers are allocated in
the negotiated pool. This help preventing buffer starvation in the pipeline.
https://bugzilla.gnome.org/show_bug.cgi?id=785122
Guillaume Desmottes [Tue, 4 Jul 2017 10:16:39 +0000 (12:16 +0200)]
omxvideodec: add dmabuf support for output
The zynqultrascaleplus OMX implementation has a custom extension
allowing decoders to output dmabuf and so avoid buffers copy between OMX
and GStreamer.
Make use of this extension when built on the zynqultrascaleplus. The
buffer pool code should be re-usable for other platforms as well.
https://bugzilla.gnome.org/show_bug.cgi?id=784847
Julien Isorce [Mon, 19 Jun 2017 23:13:33 +0000 (00:13 +0100)]
config: add OMX.Aratelia.video_decoder.vp8 to Tizonia config
Useful mostly for testing/debugging purpose as this is a software
based encoder (libvpxdec) for which GStreamer provides a direct
wrapper.
https://bugzilla.gnome.org/show_bug.cgi?id=783976
Julien Isorce [Mon, 19 Jun 2017 22:56:02 +0000 (23:56 +0100)]
omxvideodec: handle IL 1.2 behavior for OMX_SetParameter
It triggers SettingsChanged on the other port and it is up to
the client to decide if it should lead to a port reconfiguration.
Settings are propagated to the other port for fields they have
in common. But this event is only triggered on the other port
if it actually change a setting.
https://bugzilla.gnome.org/show_bug.cgi?id=783976
Julien Isorce [Tue, 18 Jul 2017 22:41:17 +0000 (23:41 +0100)]
config: set rank to 0 for Tizonia's mp3 decoder
Should have been 0 from the initial commit
eed49b4231a063639f90279c8044404c2149902a
Julien Isorce [Mon, 17 Jul 2017 20:03:55 +0000 (21:03 +0100)]
omxvideodec: fix file permissions
Introduced by
ebc9b4903cbdac2793c24b05a1bb7acc3b67fae5
Julien Isorce [Thu, 29 Jun 2017 22:17:26 +0000 (23:17 +0100)]
omxvideodec: fix buffer leak when eglimage setup fails
Can happen if gst_buffer_pool_acquire_buffer succeeds but
gst_buffer_n_memory (buffer) is not exactly 1.
In theory this should not happen because the decoder requests
EGLImage(RGBA) but better to fix any leak on corner cases.
https://bugzilla.gnome.org/show_bug.cgi?id=784365
Satya Prakash Gupta [Mon, 17 Jul 2017 13:06:36 +0000 (18:36 +0530)]
omx: Possible Memory leak in gst_caps_from_string
https://bugzilla.gnome.org/show_bug.cgi?id=784978
Satya Prakash Gupta [Mon, 17 Jul 2017 10:18:44 +0000 (15:48 +0530)]
omxvideoenc: Fix deadlock in error case when draining
https://bugzilla.gnome.org/show_bug.cgi?id=784972
Satya Prakash Gupta [Mon, 17 Jul 2017 08:14:54 +0000 (13:44 +0530)]
omxaudioenc: Fix deadlock in error case when draining
https://bugzilla.gnome.org/show_bug.cgi?id=784967
Guillaume Desmottes [Fri, 2 Jun 2017 10:36:30 +0000 (12:36 +0200)]
build: include OMX_IndexExt and OMX_ComponentExt if present
These files may be used by OMX implementation to define custom extensions.
Include them if present as we are already doing with OMX_VideoExt.h
https://bugzilla.gnome.org/show_bug.cgi?id=784847
Jan Schmidt [Thu, 13 Jul 2017 06:40:26 +0000 (16:40 +1000)]
omxh264enc: Re-add periodicty-idr property for backward compat
Retain backwards compatibility by adding a duplicate
property for periodicty-idr
https://bugzilla.gnome.org/show_bug.cgi?id=784370
Guillaume Desmottes [Fri, 30 Jun 2017 13:15:06 +0000 (15:15 +0200)]
omxh264enc: fix typo in "periodicty-idr" property name
Also fix the 'nick' of the property.
https://bugzilla.gnome.org/show_bug.cgi?id=784370
Julien Isorce [Thu, 29 Jun 2017 21:48:47 +0000 (22:48 +0100)]
omxvideodec: use OMX_UseBuffer
For example this allows the omx decoder to directly fill the
pixmaps coming from the video sink.
It only avoids a buffer copy when the decoder uses a pool provided
by a downstream element. So let's restrict this usage to situations
where the decoder decides to use a downstream buffer pool.
Tested with Tizonia/OMX.Aratelia.video_decoder.vp8
and with Bellagio/OMX.mesa.video_decoder.avc.
If it fails to setup buffers with OMX_UseBuffer the decoders
fallbacks to usual OMX_AllocateBuffer.
Also it allows to test on desktop the GstOMXBufferPool->other_pool
management which was previously only used in the OMX_UseEGLImage
case, i.e. on Rpi.
https://bugzilla.gnome.org/show_bug.cgi?id=784069
Julien Isorce [Wed, 12 Jul 2017 09:29:16 +0000 (10:29 +0100)]
omx: do not always print an error if OMX_{UseBuffer,EGLImage} fails
Let the caller decide to print an error. Because it can be part of
a normal trial path.
https://bugzilla.gnome.org/show_bug.cgi?id=784069
Guillaume Desmottes [Wed, 12 Jul 2017 14:00:53 +0000 (16:00 +0200)]
meson: add gstomxmp3enc
Commit
02d493e85921596f7cac7ef4af02fde500e9a5d8 didn't add
gstomxmp3enc.c to meson.
https://bugzilla.gnome.org/show_bug.cgi?id=784848
Julien Isorce [Tue, 23 May 2017 09:32:58 +0000 (10:32 +0100)]
config: add OMX.Aratelia.audio_encoder.mp3 to Tizonia config
Useful mostly for testing/debugging purpose as this is a software
based encoder (libmp3lame) for which GStreamer provides a direct
wrapper.
https://bugzilla.gnome.org/show_bug.cgi?id=782988
Julien Isorce [Tue, 23 May 2017 09:32:06 +0000 (10:32 +0100)]
omx: add gstomxmp3enc
Initial support and only tested with the software based
encoder OMX.Aratelia.audio_encoder.mp3 from Tizonia which
internally uses libmp3lame.
https://bugzilla.gnome.org/show_bug.cgi?id=782988
Guillaume Desmottes [Tue, 28 Mar 2017 14:27:10 +0000 (16:27 +0200)]
h264dec: add hack to pass profile and level to OMX
This information can be useful to zynqultrascaleplus decoders. They may
use this information to reduce startup latency by configuring itself
before receiving the first frames.
We also have a custom OMX extension allowing the decoder to report the
latency. The profile/level information helps it reporting a more
accurate latency earlier.
https://bugzilla.gnome.org/show_bug.cgi?id=783114
Guillaume Desmottes [Mon, 3 Jul 2017 11:17:11 +0000 (13:17 +0200)]
omxh264enc: move profile and level parsing functions to their own files
Will allow to re-use them in the decoder element.
https://bugzilla.gnome.org/show_bug.cgi?id=783114
Gurkirpal Singh [Mon, 3 Jul 2017 21:45:00 +0000 (03:15 +0530)]
meson: Add tizonia option
https://bugzilla.gnome.org/show_bug.cgi?id=782800
Gurkirpal Singh [Fri, 28 Apr 2017 21:26:59 +0000 (02:56 +0530)]
config: add omxmp3dec config for tizonia
GST_OMX_CONFIG_DIR=$HOME/gst/master/gst-omx/config/tizonia/ \
gst-launch-1.0 filesrc location=mpthreetest.mp3 ! id3demux ! \
mpegaudioparse ! omxmp3dec ! audioconvert ! pulsesink
v2: [Nicolas] Use template to create gstomx.conf using pkg-config
v3: [Nicolas] Ignore only config/tizonia/gstomx.conf
v4: [Nicolas] Add "/" for single occurence
https://bugzilla.gnome.org/show_bug.cgi?id=782800
Gurkirpal Singh [Sun, 7 May 2017 14:39:54 +0000 (20:09 +0530)]
omx: always ignore OMX_ErrorPortUnpopulated
It is safe to ignore it always. Tizonia notifies this error to pass
some khronos conformance tests. Problem is that gst-omx saves this
error in comp->last_error and then gst_omx_port_set_enabled early
error out which fails the pipeline.
https://bugzilla.gnome.org/show_bug.cgi?id=782800
Gurkirpal Singh [Fri, 28 Apr 2017 21:23:26 +0000 (02:53 +0530)]
omx: guard some omx enums with IL version
Some enums that existed in 1.1.2 just do not exit in 1.2.0
See https://www.khronos.org/registry/OpenMAX-IL/specs/OpenMAX_IL_1_2_0_Specification_redline.pdf
https://bugzilla.gnome.org/show_bug.cgi?id=782800
Gurkirpal Singh [Fri, 28 Apr 2017 20:26:01 +0000 (01:56 +0530)]
configure.ac: add tizonia target for --with-omx-target flag.
This will check for tizilheaders.pc which adds path to omx-il
headers its cflags. Can be installed all together with the 1.2 headers
with package tizilheaders if not building from sources:
https://github.com/tizonia/tizonia-openmax-il
It is also adviced to remove libomxil-bellagio-dev package because
it installs headers /usr/include directly, ex: /usr/include/OMX_Video.h.
https://bugzilla.gnome.org/show_bug.cgi?id=782800
Julien Isorce [Wed, 5 Jul 2017 09:47:41 +0000 (10:47 +0100)]
omxaudioenc: update local port_def after reopening the component
gst_omx_audio_enc_open will only update GstOMXAudioEnc->port->port_def.
Note that the component is reopen only if the flag
GST_OMX_HACK_NO_COMPONENT_RECONFIGURE is set.
https://bugzilla.gnome.org/show_bug.cgi?id=782418
Julien Isorce [Wed, 5 Jul 2017 09:48:52 +0000 (10:48 +0100)]
omxvideoenc: update local port_def after reopening the component
gst_omx_video_enc_open will only update GstOMXVideoEnc->port->port_def.
Note that the component is reopen only if the flag
GST_OMX_HACK_NO_COMPONENT_RECONFIGURE is set.
https://bugzilla.gnome.org/show_bug.cgi?id=782418
Sejun Park [Wed, 10 May 2017 03:38:39 +0000 (12:38 +0900)]
omxvideodec: update local port_def after reopening the component
gst_omx_video_dec_open will only update GstOMXVideoDec->port->port_def.
Note that the component is reopen only if the flag
GST_OMX_HACK_NO_COMPONENT_RECONFIGURE is set.
https://bugzilla.gnome.org/show_bug.cgi?id=782418
Guillaume Desmottes [Mon, 3 Jul 2017 14:33:06 +0000 (16:33 +0200)]
omxvideodec: increase the minimum number of allocated buffers
Ensure that enough buffers are allocated by adding up component's own
minimal plus the number of buffers requested by downstream.
This should prevent buffers starvation problem if downstream elements
are holding some of the buffers they required.
Also simplify the check on the maximum on buffers. What we actually care
about is to make sure the pool can hold the minimum of required buffers.
https://bugzilla.gnome.org/show_bug.cgi?id=784479
Guillaume Desmottes [Mon, 3 Jul 2017 08:54:50 +0000 (10:54 +0200)]
omxh264enc: raise a warning if AVCIntraPeriod is not supported
Some platforms may not implement OMX_IndexConfigVideoAVCIntraPeriod and
use OMX_IndexParamVideoAvc instead to configure the GOP pattern.
So raise a warning instead of an error if this API is not implemented.
https://bugzilla.gnome.org/show_bug.cgi?id=784379
Guillaume Desmottes [Thu, 29 Jun 2017 12:16:19 +0000 (14:16 +0200)]
omxh264enc: add 'b-frames' property
Add a property to control the number of B-frames produced by the
encoder using the OMX_VIDEO_PARAM_AVCTYPE OMX API.
https://bugzilla.gnome.org/show_bug.cgi?id=784379
Guillaume Desmottes [Fri, 30 Jun 2017 12:18:35 +0000 (14:18 +0200)]
omxh264enc: fix typo in 'set_avc_intra_period'
https://bugzilla.gnome.org/show_bug.cgi?id=784379
Guillaume Desmottes [Mon, 22 May 2017 09:23:33 +0000 (11:23 +0200)]
add 'zynqultrascaleplus' as OMX target
Adding support for the 'Zynq UltraScale+' as a new OMX target.
See https://www.xilinx.com/products/silicon-devices/soc/zynq-ultrascale-mpsoc.html
for details about the platform.
https://bugzilla.gnome.org/show_bug.cgi?id=783097
Julien Isorce [Sun, 21 May 2017 14:23:09 +0000 (15:23 +0100)]
config: add OMX.mesa.video_decoder.{avc,mpeg2} for Bellagio config
Install libomxil-bellagio0 and make sure mesa has been built with
--enable-omx. Check there is /usr/lib/libomxil-bellagio0/libomx_mesa.so
then run omxregister-bellagio to regenerate $XDG_DATA_HOME/.omxregister
Then omxh264dec and omxmpeg2dec should load.
https://bugzilla.gnome.org/show_bug.cgi?id=782926
Julien Isorce [Thu, 18 May 2017 12:50:56 +0000 (13:50 +0100)]
configure.ac: move omx features check after target selection
Does not change anything, except this will be useful for future commits.
Indeed some targets provide a .pc file where to look for the omx headers.
https://bugzilla.gnome.org/show_bug.cgi?id=782800
Guillaume Desmottes [Thu, 29 Jun 2017 14:48:07 +0000 (16:48 +0200)]
omxh264dec: remove 'parsed=true' from sink pad
The decoder only requires to receive one frame per buffer which is
already enforced with 'alignment=au'. There is no need to require to
have a parser upstream.
Allow to run "encode ! decode" pipeline without having a parser.
https://bugzilla.gnome.org/show_bug.cgi?id=784344
Guillaume Desmottes [Fri, 16 Jun 2017 11:28:33 +0000 (13:28 +0200)]
omxh264enc: set profile/level using OMX_VIDEO_PARAM_AVCTYPE as well
The OMX specification defines two API to set the AVC profile and level:
using OMX_VIDEO_PARAM_PROFILELEVELTYPE and OMX_VIDEO_PARAM_AVCTYPE.
We were already supporting the former but not the latter. We are now
setting both so implementation don't have to rely on a specific one.
https://bugzilla.gnome.org/show_bug.cgi?id=783862
Guillaume Desmottes [Fri, 16 Jun 2017 11:19:33 +0000 (13:19 +0200)]
omxh264enc: factor out update_param_profile_level()
https://bugzilla.gnome.org/show_bug.cgi?id=783862
Guillaume Desmottes [Fri, 16 Jun 2017 10:53:15 +0000 (12:53 +0200)]
omxh264enc: factor out string to profile/level enum conversion
https://bugzilla.gnome.org/show_bug.cgi?id=783862
Guillaume Desmottes [Wed, 28 Jun 2017 13:06:10 +0000 (15:06 +0200)]
omxh264enc: use OMX_IndexConfigBrcmVideoIntraPeriod on pi
The OMX_VIDEO_CONFIG_AVCINTRAPERIOD.nPFrames setting isn't of any use on
the raspbery pi. Instead it uses a custom extension to define the I
frame period.
https://bugzilla.gnome.org/show_bug.cgi?id=783829
Guillaume Desmottes [Wed, 28 Jun 2017 13:03:52 +0000 (15:03 +0200)]
omxh264enc: factor out set_avc_intra_perdiod()
https://bugzilla.gnome.org/show_bug.cgi?id=783829
Guillaume Desmottes [Fri, 2 Jun 2017 10:48:57 +0000 (12:48 +0200)]
meson: define HAVE_VIDEO_EXT if OMX_VideoExt.h is present
Meson build wasn't defining the HAVE_VIDEO_EXT like configure.ac does.
https://bugzilla.gnome.org/show_bug.cgi?id=783346
Graham Leggett [Sun, 11 Jun 2017 12:32:01 +0000 (12:32 +0000)]
omxvideoenc: Improve debug output when setting codec state due to new codec_data fails
https://bugzilla.gnome.org/show_bug.cgi?id=783657
Julien Isorce [Sat, 20 May 2017 13:49:20 +0000 (14:49 +0100)]
omx: allow 0 feature
Previously the omx plugin was blacklisted if GST_OMX_CONFIG_DIR
points to an invalid path or if the gstomx.conf contains 0 valid
component.
Problem is that once the plugin is blacklisted, a rescan is not
triggered upon changes of the env var or the gstomx.conf file
despite being setup with gst_plugin_add_dependency.
This also makes it more consistent with other plugins that auto
generate features. For example gst-{ffmeg,libav}, gstreamer-vaapi,
v4l2 video dec.
To clarify the diff, the plugin_init func will return TRUE even if
g_key_file_get_groups returns 0 element and even if
g_key_file_load_from_dirs fails.
https://bugzilla.gnome.org/show_bug.cgi?id=782867
Gurkirpal Singh [Wed, 26 Apr 2017 17:22:17 +0000 (22:52 +0530)]
config: add OMX.st.audio_decoder.mp3.mad for Bellagio config
MP3 Software decoder (libmad based) but useful for testing
and to compare with other targets.
GST_OMX_CONFIG_DIR=$HOME/gst/master/gst-omx/config/bellagio/ \
gst-launch-1.0 filesrc location=mpthreetest.mp3 ! id3demux ! \
mpegaudioparse ! omxmp3dec ! audioconvert ! pulsesink
Didn't add 'local' in core-name path compared to other components
in that same gstomx.conf file because OMX.st.audio_decoder.mp3.mad
comes with the Ubuntu package 'libomxil-bellagio0-components-mad'.
All other components listed in this gstomx.conf for Bellagio, are
not provided by any Ubuntu packages. It could explain the 'local',
i.e. requiring to build them from source.
dpkg -L libomxil-bellagio0
/usr/lib/libomxil-bellagio.so.0
https://bugzilla.gnome.org/show_bug.cgi?id=781786
Signed-off-by: Gurkirpal Singh <gurkirpal204@gmail.com>
Signed-off-by: Julien Isorce <jisorce@oblong.com>
Nicolas Dufresne [Tue, 16 May 2017 18:39:04 +0000 (14:39 -0400)]
Remove plugin specific static build option
Static and dynamic plugins now have the same interface. The standard
--enable-static/--enable-shared toggle are sufficient.
Sejun Park [Wed, 10 May 2017 03:10:10 +0000 (12:10 +0900)]
omxvideodec: Removed unreachable code
https://bugzilla.gnome.org/show_bug.cgi?id=782416
Guillaume Desmottes [Tue, 9 May 2017 14:26:44 +0000 (16:26 +0200)]
meson: add dep on GModule
libgstomx uses the GModule API and so needs it in its dependencies list.
https://bugzilla.gnome.org/show_bug.cgi?id=782387
Tim-Philipp Müller [Tue, 9 May 2017 13:27:28 +0000 (13:27 +0000)]
meson: fix config.h generation
"No such input file config.h.meson", but it's not needed anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=782382
Sebastian Dröge [Thu, 4 May 2017 15:59:33 +0000 (18:59 +0300)]
Back to development
Sebastian Dröge [Thu, 4 May 2017 12:48:56 +0000 (15:48 +0300)]
Release 1.12.0
Sebastian Dröge [Thu, 27 Apr 2017 14:53:50 +0000 (17:53 +0300)]
Release 1.11.91
Guillaume Desmottes [Mon, 17 Apr 2017 15:02:48 +0000 (17:02 +0200)]
videoenc: use GST_ROUND_UP_N() macro
Makes the code much easier to read and understand.
https://bugzilla.gnome.org/show_bug.cgi?id=781409
Tim-Philipp Müller [Mon, 24 Apr 2017 19:30:21 +0000 (20:30 +0100)]
Automatic update of common submodule
From 60aeef6 to 48a5d85
Tim-Philipp Müller [Mon, 10 Apr 2017 22:51:00 +0000 (23:51 +0100)]
Automatic update of common submodule
From 39ac2f5 to 60aeef6