rniwa@webkit.org [Fri, 27 May 2011 09:11:30 +0000 (09:11 +0000)]
2011-05-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Convert editing/pasteboard/paste-text-002.html and paste-text-003.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61614
Converted paste-text-002.html and paste-text-003.html to dump-as-markup tests.
Also added some descriptions to the tests.
* editing/pasteboard/paste-text-002-expected.txt: Added.
* editing/pasteboard/paste-text-002.html:
* editing/pasteboard/paste-text-003-expected.txt: Added.
* editing/pasteboard/paste-text-003.html:
* platform/chromium-linux/editing/pasteboard/paste-text-002-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-003-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-002-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-003-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-002-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-002-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-003-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-003-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-002-expected.png: Removed.
* platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-003-expected.png: Removed.
* platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 08:26:49 +0000 (08:26 +0000)]
2011-05-27 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
CachedResourceLoader stores data: urls in validated URL set
https://bugs.webkit.org/show_bug.cgi?id=61604
CachedResourceLoader maintains a set of URLs that have been validated to avoid validating the same resource
multiple times for loads within the same document. This doesn't make sense for data: URLs and just wastes
memory.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 27 May 2011 08:01:49 +0000 (08:01 +0000)]
[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Windows (bots are slow :(
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 27 May 2011 07:56:25 +0000 (07:56 +0000)]
2011-05-23 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Refactoring] DocumentMarker should be carried around as a pointer, not value.
https://bugs.webkit.org/show_bug.cgi?id=61262
- Changed return value of markersInRange() from Vector<DocumentMarker> to Vector<DocumentMarker*>.
- Introduced markersFor() that returns Vector<DocumentMarker*>
- Removed DocumentMarkerController::setRenderedRectForMarker() which now can be replaced by
RenderedDocumentMarker::setRenderedRect().
- This change didn't remove markersForNode() beucase there is patches on review which depends
markersForNode(). I'll remove its call after these patches are landed.
No new tests. No behavior change.
* WebCore.exp.in:
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addTextMatchMarker):
(WebCore::DocumentMarkerController::markersFor):
(WebCore::DocumentMarkerController::markersInRange):
(WebCore::DocumentMarkerController::hasMarkers):
* dom/DocumentMarkerController.h:
* dom/RenderedDocumentMarker.h:
(WebCore::toRenderedDocumentMarker):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
* editing/Editor.cpp:
(WebCore::Editor::selectionStartHasMarkerFor):
* editing/SpellingCorrectionController.cpp:
(WebCore::markersHaveIdenticalDescription):
(WebCore::SpellingCorrectionController::respondToChangedSelection):
(WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
* editing/SpellingCorrectionController.h:
(WebCore::SpellingCorrectionController::shouldStartTimerFor):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintDocumentMarkers):
* rendering/InlineTextBox.h:
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 27 May 2011 07:54:44 +0000 (07:54 +0000)]
[Chromium] Unreviewed, suppress http/tests/local/formdata/ test crashes after r87460
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 27 May 2011 07:45:34 +0000 (07:45 +0000)]
[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Linux
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 27 May 2011 07:26:34 +0000 (07:26 +0000)]
2011-05-26 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
WebCore::HTMLSummaryElement::isMainSummary crashes
https://bugs.webkit.org/show_bug.cgi?id=61511
* fast/html/details-summary-document-child-expected.txt: Added.
* fast/html/details-summary-document-child.html: Added.
2011-05-26 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
WebCore::HTMLSummaryElement::isMainSummary ReadAV@NULL
https://bugs.webkit.org/show_bug.cgi?id=61511
Removed Unnecessary wrong cast to Elmement, which can be non-Element.
Test: fast/html/details-summary-document-child.html
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::detailsElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 27 May 2011 06:54:19 +0000 (06:54 +0000)]
2011-05-26 Adam Barth <abarth@webkit.org>
Reviewed by Ryosuke Niwa.
FrameLoader cannot be null
https://bugs.webkit.org/show_bug.cgi?id=61609
This code has a bunch of cargo-cult null checking.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createRenderer):
(WebCore::HTMLMediaElement::attach):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::getPluginProxyParams):
(WebCore::HTMLMediaElement::createMediaPlayerProxy):
(WebCore::HTMLMediaElement::updateWidget):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 06:43:29 +0000 (06:43 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Convert editing/pasteboard/paste-blockquote-1.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61608
Converted paste-blockquote-1.html to a dump-as-markup test.
* editing/pasteboard/paste-blockquote-1-expected.txt: Added.
* editing/pasteboard/paste-blockquote-1.html:
* platform/chromium-linux/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 06:42:19 +0000 (06:42 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Convert editing/pasteboard/merge-end-*.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61607
* editing/pasteboard/merge-end-1-expected.txt: Added.
* editing/pasteboard/merge-end-1.html:
* editing/pasteboard/merge-end-2-expected.txt: Added.
* editing/pasteboard/merge-end-2.html:
* editing/pasteboard/merge-end-3-expected.txt: Added.
* editing/pasteboard/merge-end-3.html:
* editing/pasteboard/merge-end-4-expected.txt: Added.
* editing/pasteboard/merge-end-4.html:
* editing/pasteboard/merge-end-5-expected.txt: Added.
* editing/pasteboard/merge-end-5.html:
* platform/chromium-linux/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/chromium-mac-leopard/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-1-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-2-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-3-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-4-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-5-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-1-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-2-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-3-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-4-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-5-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-1-expected.txt: Removed.
* platform/mac/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-2-expected.txt: Removed.
* platform/mac/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-3-expected.txt: Removed.
* platform/mac/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-4-expected.txt: Removed.
* platform/mac/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-5-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-1-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-1-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-2-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-2-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-3-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-3-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-4-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-4-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-5-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-5-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 06:40:43 +0000 (06:40 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Convert editing/pasteboard/interchange-newline-*.html to dump-as-markup tests.
https://bugs.webkit.org/show_bug.cgi?id=61605
Converted interchange-newline-1 thorugh 4 to dump-as-markup tests.
Also revised some test descriptions.
* editing/pasteboard/interchange-newline-1-expected.txt: Added.
* editing/pasteboard/interchange-newline-1.html:
* editing/pasteboard/interchange-newline-2-expected.txt: Added.
* editing/pasteboard/interchange-newline-2.html:
* editing/pasteboard/interchange-newline-3-expected.txt: Added.
* editing/pasteboard/interchange-newline-3.html:
* editing/pasteboard/interchange-newline-4-expected.txt: Added.
* editing/pasteboard/interchange-newline-4.html:
* platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/interchange-newline-2-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/interchange-newline-3-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/interchange-newline-4-expected.png: Removed.
* platform/chromium-mac-leopard/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-2-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-3-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-4-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-2-expected.png: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-3-expected.png: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-4-expected.png: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/interchange-newline-2-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/interchange-newline-3-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/interchange-newline-4-expected.png: Removed.
* platform/mac/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/mac/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
* platform/mac/editing/pasteboard/interchange-newline-2-expected.png: Removed.
* platform/mac/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
* platform/mac/editing/pasteboard/interchange-newline-3-expected.png: Removed.
* platform/mac/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
* platform/mac/editing/pasteboard/interchange-newline-4-expected.png: Removed.
* platform/mac/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
* platform/qt/editing/pasteboard/interchange-newline-1-expected.png: Removed.
* platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
* platform/qt/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
* platform/qt/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 06:28:40 +0000 (06:28 +0000)]
2011-05-26 Shane Stephens <shanestephens@google.com>
Reviewed by James Robinson.
REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689
* transforms/2d/set-transform-and-top-expected.txt: Added.
* transforms/2d/set-transform-and-top.html: Added.
2011-05-26 Shane Stephens <shanestephens@google.com>
Reviewed by James Robinson.
REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689
When a transform is modified in a style, we were upgrading our understanding
of the difference from PositionedMovementOnly to SimplifiedLayout. However,
if the position of the style is independently changed at the same time, both
PositionedMovement and SimplifiedLayout passes are required.
Test: transforms/2d/set-transform-and-top.html
* rendering/RenderObject.cpp:
Added checks for SimplifiedLayoutAndPositionedMovement - when encountered,
set both PositionedMovement and SimplifiedLayout update flasgs.
* rendering/style/RenderStyleConstants.h:
Added a new StyleDifference enum value (SimplifiedLayoutAndPositionedMovement) for
cases when both PositionedMovement and SimplifiedLayout are required.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 06:26:57 +0000 (06:26 +0000)]
2011-05-26 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Implement webkit margin collapse CSS properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=61589
No new tests as no new functionality added.
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Add handlers for:
CSSPropertyWebkitMarginBeforeCollapse
CSSPropertyWebkitMarginAfterCollapse
CSSPropertyWebkitMarginTopCollapse
CSSPropertyWebkitMarginBottomCollapse
CSSPropertyWebkitMarginCollapse
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove cases that are no longer required.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 27 May 2011 06:12:45 +0000 (06:12 +0000)]
2011-05-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support cross-origin property for images
https://bugs.webkit.org/show_bug.cgi?id=61015
Test various cases involving CORS requests and canvas tainting.
* http/tests/security/canvas-remote-read-remote-image-allowed-expected.txt: Added.
* http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
* http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html: Added.
* http/tests/security/canvas-remote-read-remote-image-allowed.html: Added.
* http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
* http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin.html: Added.
* http/tests/security/resources/abe-allow-credentials.php: Added.
* http/tests/security/resources/abe-allow-star.php: Added.
2011-05-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support cross-origin property for images
https://bugs.webkit.org/show_bug.cgi?id=61015
This patch add support for the crossorigin attribute of images and
teaches 2D canvas to respect that flag and not taint a canvas if the
image drawn on the canvas is allowed by CORS.
While I was editing this code, I couldn't resist a couple touch-up
changes.
Tests: http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html
http/tests/security/canvas-remote-read-remote-image-allowed.html
http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin.html
* html/HTMLAttributeNames.in:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::securityOrigin):
* html/HTMLCanvasElement.h:
* html/HTMLImageElement.idl:
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::checkOrigin):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::passesAccessControlCheck):
* loader/cache/CachedResource.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 05:33:49 +0000 (05:33 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
editing/pasteboard/4700297.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61595
Renamed 4700297.html to insert-div-text-into-text.html and converted it into a dump-as-markup test.
* editing/pasteboard/4700297.html: Removed.
* editing/pasteboard/insert-div-text-into-text-expected.txt: Added.
* editing/pasteboard/insert-div-text-into-text.html: Copied from LayoutTests/editing/pasteboard/4700297.html.
* platform/chromium-linux/editing/pasteboard/4700297-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/4700297-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/4700297-expected.txt: Removed.
* platform/gtk/editing/pasteboard/4700297-expected.png: Removed.
* platform/gtk/editing/pasteboard/4700297-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/4700297-expected.png: Removed.
* platform/mac/editing/pasteboard/4700297-expected.png: Removed.
* platform/mac/editing/pasteboard/4700297-expected.txt: Removed.
* platform/qt/editing/pasteboard/4700297-expected.png: Removed.
* platform/qt/editing/pasteboard/4700297-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 05:31:57 +0000 (05:31 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Hajime Morita.
editing/pasteboard/5483567.html should be renamed and converted to a dump-as-markup test.
https://bugs.webkit.org/show_bug.cgi?id=61599
Renamed 5483567.html to pasting-word-in-div-extra-line.html and converted it to
a dump-as-markup test.
* editing/pasteboard/5483567.html: Removed.
* editing/pasteboard/pasting-word-in-div-extra-line-expected.txt: Added.
* editing/pasteboard/pasting-word-in-div-extra-line.html: Copied from
LayoutTests/editing/pasteboard/5483567.html.
* platform/chromium-linux/editing/pasteboard/5483567-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5483567-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5483567-expected.txt: Removed.
* platform/gtk/editing/pasteboard/5483567-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/5483567-expected.png: Removed.
* platform/mac/editing/pasteboard/5483567-expected.png: Removed.
* platform/mac/editing/pasteboard/5483567-expected.txt: Removed.
* platform/qt/editing/pasteboard/5483567-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 05:29:57 +0000 (05:29 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
editing/pasteboard/5089327.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61597
Renamed 5089327.html to paste-into-blockquote-with-document-font-color.html and converted it
to a dump-as-markup test.
* editing/pasteboard/5089327.html: Removed.
* editing/pasteboard/paste-into-blockquote-with-document-font-color-expected.txt: Added.
* editing/pasteboard/paste-into-blockquote-with-document-font-color.html: Copied from
LayoutTests/editing/pasteboard/5089327.html.
* platform/chromium-linux/editing/pasteboard/5089327-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5089327-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5089327-expected.txt: Removed.
* platform/gtk/editing/pasteboard/5089327-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/5089327-expected.png: Removed.
* platform/mac/editing/pasteboard/5089327-expected.png: Removed.
* platform/mac/editing/pasteboard/5089327-expected.txt: Removed.
* platform/qt/editing/pasteboard/5089327-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 27 May 2011 05:29:45 +0000 (05:29 +0000)]
2011-05-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571
As part of working on r87423, I noticed a couple of inconsistencies in
argument names:
- We would use worldId in .h files but worldID in .cpp files.
Standardize on the latter
- SecurityOrigin::addOriginAccessWhitelistEntry would take a
destinationDomains argument, even though the actual parameter was for
a single domain (renamed to be singular).
* bindings/v8/ScriptController.h:
* bindings/v8/V8Proxy.h:
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry):
(WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry):
* page/SecurityOrigin.h:
2011-05-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571
As part of working on r87423, I noticed a couple of inconsistencies in
argument names:
- We would use worldId in .h files but worldID in .cpp files.
Standardize on the latter
- SecurityOrigin::addOriginAccessWhitelistEntry would take a
destinationDomains argument, even though the actual parameter was for
a single domain (renamed to be singular).
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
(WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
* src/WebFrameImpl.h:
2011-05-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571
As part of working on r87423, I noticed a couple of inconsistencies in
argument names:
- We would use worldId in .h files but worldID in .cpp files.
Standardize on the latter
- SecurityOrigin::addOriginAccessWhitelistEntry would take a
destinationDomains argument, even though the actual parameter was for
a single domain (renamed to be singular).
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 05:27:50 +0000 (05:27 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
editing/pasteboard/5027857.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61602
Renamed 5027857.html to paste-code-in-pre.html and converted it to a dump-as-markup test.
* editing/pasteboard/5027857.html: Removed.
* editing/pasteboard/paste-code-in-pre-expected.txt: Added.
* editing/pasteboard/paste-code-in-pre.html: Copied from LayoutTests/editing/pasteboard/5027857.html.
* platform/chromium-linux/editing/pasteboard/5027857-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5027857-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5027857-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-code-in-pre-expected.txt: Added.
* platform/gtk/editing/pasteboard/5027857-expected.png: Removed.
* platform/gtk/editing/pasteboard/5027857-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/5027857-expected.png: Removed.
* platform/mac/editing/pasteboard/5027857-expected.png: Removed.
* platform/mac/editing/pasteboard/5027857-expected.txt: Removed.
* platform/qt/editing/pasteboard/5027857-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Fri, 27 May 2011 04:53:46 +0000 (04:53 +0000)]
2011-05-26 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Replace RenderLayer::x/y/width/height with location/size
https://bugs.webkit.org/show_bug.cgi?id=61414
Covered by existing tests.
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::computeRelativePosition):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
(WebCore::RenderBox::maxLayoutOverflow):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::offsetFromResizeCorner):
(WebCore::RenderLayer::calculateRects):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::location):
(WebCore::RenderLayer::setSize):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::writeLayers):
(WebCore::externalRepresentation):
* rendering/RenderView.cpp:
(WebCore::RenderView::absoluteRects):
(WebCore::RenderView::absoluteQuads):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 04:18:25 +0000 (04:18 +0000)]
2011-05-26 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
Delete table in contentEditable/designMode produces odd contents
https://bugs.webkit.org/show_bug.cgi?id=57148
Add a test for the case given in the bug: deleting an unstyled table
should not leave behind a style span.
Rebaseline tests now that border-collapse, -webkit-border-horizontal-spacing,
and -webkit-border-vertical-spacing style spans are no longer added on
table and table cell deletion, and no longer applied when copying to the
clipboard.
* editing/deleting/5026848-2-expected.txt:
* editing/deleting/5026848-3-expected.txt:
* editing/deleting/5032066-expected.txt:
* editing/deleting/5115601-expected.txt:
* editing/deleting/5206311-2-expected.txt:
* editing/deleting/delete-block-table-expected.txt:
* editing/deleting/delete-last-char-in-table-expected.txt: Added.
* editing/deleting/delete-last-char-in-table.html: Added. New test for bug.
* editing/deleting/delete-select-all-001-expected.txt:
* editing/pasteboard/data-transfer-items-expected.txt:
* editing/pasteboard/onpaste-text-html-expected.txt:
* editing/selection/4895428-1-expected.txt:
* editing/selection/4895428-4-expected.txt:
* fast/events/ondrop-text-html-expected.txt:
2011-05-26 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
Delete table in contentEditable/designMode produces odd contents
https://bugs.webkit.org/show_bug.cgi?id=57148
Removes border-collapse, -webkit-border-horizontal-spacing, and
-webkit-border-vertical-spacing from the list of properties which
should be preserved during edit operations. Also renames this
list to editingInheritableProperties to be more clear about what
the list is for.
Test: editing/deleting/delete-last-char-in-table.html
* editing/EditingStyle.cpp: Removes border vertical/horizontal
spacing from editingStyleProperties.
* editing/EditingStyle.h: Renames OnlyInheritableProperties to
OnlyEditingInheritableProperties.
* editing/markup.cpp: Renames InheritablePropertiesAndBackgroundColorInEffect.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 04:14:46 +0000 (04:14 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Simon Fraser.
editing/pasteboard/style-from-rules.html is flaky on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=61586
Don't attach an event listener to dump markup on paste when ran by DRT
because we manually dump markup in DRT.
* editing/pasteboard/style-from-rules.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Fri, 27 May 2011 03:24:02 +0000 (03:24 +0000)]
2011-05-26 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721
* http/tests/websocket/tests/client-close-expected.txt: Added.
* http/tests/websocket/tests/client-close.html: Added. Test client-initiated close.
* http/tests/websocket/tests/client-close_wsh.py: Added.
* http/tests/websocket/tests/close-before-open-expected.txt: Add a new console message.
* http/tests/websocket/tests/close-event-expected.txt:
* http/tests/websocket/tests/close-event.html: Test if closeEvent.wasClean is true.
* http/tests/websocket/tests/close-unref-websocket-expected.txt: Add a new console message.
* http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
We need to stop pywebsocket from starting the closing handshake. Otherwise, pywebsocket
waits for a close frame to arrive and this test will time out.
* http/tests/websocket/tests/server-close-expected.txt: Added.
* http/tests/websocket/tests/server-close.html: Added. Test server-initiated close.
* http/tests/websocket/tests/server-close_wsh.py: Added.
* http/tests/websocket/tests/websocket-event-target-expected.txt: Add a new console message.
2011-05-26 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721
Implement WebSocket closing handshake based on Ian Hickson's
WebSocket protocol draft 76.
Tests: http/tests/websocket/tests/client-close.html
http/tests/websocket/tests/server-close.html
* platform/network/SocketStreamHandleBase.cpp:
(WebCore::SocketStreamHandleBase::send):
Do not send a message if we are in Closing state.
(WebCore::SocketStreamHandleBase::close):
Do not disconnect if we have pending data which have not been sent yet.
In this case, the actual disconnection will happen in sendPendingData().
(WebCore::SocketStreamHandleBase::disconnect):
Renamed from close(). Disconnect the connection immediately.
(WebCore::SocketStreamHandleBase::sendPendingData):
* platform/network/SocketStreamHandleBase.h:
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus)
to didClose().
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
Fail if close() is attempted before the connection is established.
Otherwise, set the state to CLOSING and start the closing handshake.
(WebCore::WebSocket::bufferedAmount):
If the state is CLOSING, we need to consider buffered data in m_channel and sent after close().
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
We need to invoke message event in CLOSING state as well as OPEN state.
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didStartClosingHandshake):
(WebCore::WebSocket::didClose):
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::close):
Start the closing handshake.
(WebCore::WebSocketChannel::disconnect):
Disconnect the socket stream, instead of close.
(WebCore::WebSocketChannel::didClose):
(WebCore::WebSocketChannel::didReceiveData): Ditto.
(WebCore::WebSocketChannel::didFail): Ditto.
(WebCore::WebSocketChannel::processBuffer):
Ditto.
Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started.
(WebCore::WebSocketChannel::startClosingHandshake):
Send 0xFF 0x00 byte sequence.
(WebCore::WebSocketChannel::closingTimerFired):
Disconnect the socket stream if the closing handshake has timed out.
* websockets/WebSocketChannel.h:
m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol
specification).
* websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didStartClosingHandshake): Added.
(WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
* websockets/WorkerThreadableWebSocketChannel.cpp:
Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake().
(WebCore::WorkerThreadableWebSocketChannel::Peer::close):
(WebCore::workerContextDidStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
* websockets/WorkerThreadableWebSocketChannel.h:
2011-05-26 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721
* Scripts/webkitpy/thirdparty/__init__.py:
Pull in pywebsocket 0.6b1. We need to update pywebsocket
to get the right behavior of closing handshake.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 May 2011 02:22:41 +0000 (02:22 +0000)]
2011-05-26 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Dmitry Titov.
Add missing compile guards for WebWorkers in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=61536
* src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::canEstablishDatabase):
* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
* src/PlatformBridge.cpp:
* src/WebFileSystemCallbacksImpl.cpp:
(WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
* src/WorkerAsyncFileSystemChromium.cpp:
* src/WorkerAsyncFileSystemChromium.h:
* src/WorkerAsyncFileWriterChromium.cpp:
* src/WorkerAsyncFileWriterChromium.h:
* src/WorkerFileSystemCallbacksBridge.cpp:
* src/WorkerFileSystemCallbacksBridge.h:
* src/WorkerFileWriterCallbacksBridge.cpp:
* src/WorkerFileWriterCallbacksBridge.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 27 May 2011 02:16:21 +0000 (02:16 +0000)]
2011-05-26 David Levin <levin@chromium.org>
Reviewed by Dmitry Titov.
WebKit's font notification has problems when the WebKit main thread != UI thread.
https://bugs.webkit.org/show_bug.cgi?id=61391
This doesn't happen in DumpRenderTree, so it needs a unit test which is taking me
some time to write correctly. In the meantime, this issues happens to be causing
some crashes in Chrome so here's the fix alone for the time being.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::invalidateFontCache): Ensure that FontCache::invalidate is only called on WebKit's main thread.
(WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Call common function for font cache invalidation.
Note that the call to fontCache() is fine since the singleton is initialized well before calling this function. Theoretically,
there could be a problem due to a lack of a memory barrier but that is highly unlikely and this is debug only code.
(WebCore::fontCacheATSNotificationCallback): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 27 May 2011 02:07:09 +0000 (02:07 +0000)]
2011-05-26 MORITA Hajime <morrita@google.com>
Unreviewed expectations update for <details>.
* platform/chromium-linux-x86/fast/html/details-add-child-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-add-child-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-add-details-child-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-add-details-child-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-add-summary-child-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-add-summary-child-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-nested-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-nested-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-remove-child-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-remove-child-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-remove-summary-child-1-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-remove-summary-child-2-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/chromium-linux-x86/fast/html/details-replace-text-expected.png: Added.
* platform/chromium-linux-x86/fast/html/details-replace-text-expected.txt: Added.
* platform/chromium-linux/fast/html/details-add-child-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-child-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-details-child-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-details-child-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-child-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-child-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-nested-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-nested-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-child-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-child-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-replace-summary-child-expected.png: Added.
* platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/chromium-linux/fast/html/details-replace-text-expected.png: Added.
* platform/chromium-linux/fast/html/details-replace-text-expected.txt: Added.
* platform/chromium-mac-leopard/fast/html/details-add-child-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-child-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-details-child-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-details-child-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-child-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-child-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-nested-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-nested-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-child-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-child-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-child-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-child-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-replace-summary-child-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-replace-text-expected.png: Added.
* platform/chromium-win/fast/html/details-add-child-1-expected.png: Added.
* platform/chromium-win/fast/html/details-add-child-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-child-2-expected.png: Added.
* platform/chromium-win/fast/html/details-add-child-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-details-child-1-expected.png: Added.
* platform/chromium-win/fast/html/details-add-details-child-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-details-child-2-expected.png: Added.
* platform/chromium-win/fast/html/details-add-details-child-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
* platform/chromium-win/fast/html/details-add-summary-child-1-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-child-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-child-2-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-child-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-nested-1-expected.png: Added.
* platform/chromium-win/fast/html/details-nested-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-nested-2-expected.png: Added.
* platform/chromium-win/fast/html/details-nested-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-no-summary1-expected.txt:
* platform/chromium-win/fast/html/details-no-summary2-expected.txt:
* platform/chromium-win/fast/html/details-no-summary3-expected.txt:
* platform/chromium-win/fast/html/details-no-summary4-expected.txt:
* platform/chromium-win/fast/html/details-open-javascript-expected.txt:
* platform/chromium-win/fast/html/details-open1-expected.txt:
* platform/chromium-win/fast/html/details-open2-expected.txt:
* platform/chromium-win/fast/html/details-open3-expected.txt:
* platform/chromium-win/fast/html/details-open4-expected.txt:
* platform/chromium-win/fast/html/details-open5-expected.txt:
* platform/chromium-win/fast/html/details-open6-expected.txt:
* platform/chromium-win/fast/html/details-position-expected.txt:
* platform/chromium-win/fast/html/details-remove-child-1-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-child-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-child-2-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-child-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-child-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-child-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-replace-summary-child-expected.png: Added.
* platform/chromium-win/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/chromium-win/fast/html/details-replace-text-expected.png: Added.
* platform/chromium-win/fast/html/details-replace-text-expected.txt: Added.
* platform/chromium-win/fast/html/details-writing-mode-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 27 May 2011 01:36:54 +0000 (01:36 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=61345
part of <rdar://problem/8675177>
Roll back in now that the Crashes are fixed. ResourceResponseBase and ResourceResponse had two different definitions
for m_isNull. ResourceResponse treats m_isNull as meaning there isn't any platform ResourceResponse.
ResourceResponseBase treats m_isNull as meaning no fields have been initialized. Consolidate calls into ResourceResponseBase meaning.
Reviewed by Geoff Garen.
Don't initialize ResourceResponse.m_suggestedFilename until we want to use it. Initializing it requires reading in and parsing a plist.
Add new initialization state CommonAndUncommonFields to ResourceResponse. This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.
No new functionality so no new tests.
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
* platform/network/ResourceResponseBase.h:
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Fri, 27 May 2011 01:16:57 +0000 (01:16 +0000)]
2011-05-26 James Kozianski <koz@chromium.org>
Reviewed by Eric Seidel.
Implement a whitelist for registerProtocolHandler.
Described in the thread here
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2011-April/031220.html
https://bugs.webkit.org/show_bug.cgi?id=60322
* fast/dom/register-protocol-handler.html:
2011-05-26 James Kozianski <koz@chromium.org>
Reviewed by Eric Seidel.
Implement a whitelist for registerProtocolHandler
https://bugs.webkit.org/show_bug.cgi?id=60322
* page/Navigator.cpp:
(WebCore::initProtocolHandlerWhitelist):
(WebCore::isProtocolWhitelisted):
(WebCore::verifyProtocolHandlerScheme):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 27 May 2011 01:12:21 +0000 (01:12 +0000)]
Safari's AXFocusedUIElement attribute returns WebArea object with AXSelectedTextMarkerRange of nil
https://bugs.webkit.org/show_bug.cgi?id=61492
Reviewed by Darin Adler.
The method for determining which WebPage is actually focused and foreground was faulty. More
extensive checks are required to check which WebPage should be returned as the focusable one.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowIsFocused):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 27 May 2011 01:00:59 +0000 (01:00 +0000)]
2011-05-26 Adam Klein <adamk@chromium.org>
Unreviewed. Remove some passing tests from the test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Fri, 27 May 2011 00:29:40 +0000 (00:29 +0000)]
2011-05-26 Jon Lee <jonlee@apple.com>
Reviewed by Darin Adler.
REGRESSION (5.0.5-Jazz): Transition to full screen video animates in wrong location when scrolled (61559)
https://bugs.webkit.org/show_bug.cgi?id=61559
<rdar://problem/9496054>
The CALayer that gets animated has a position that is offset by the scroll position of the web view. To
fix this, we set the destination location based on the rect of the full screen, and add a position
animation which keeps the position of the layer centered. This prevents glitches if others
are trying to change the layer position while the animation is running.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Refactor the calculation of the CALayer windowed
position into a private helper function, as well as the animation setup.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::animateFullScreen): Sets up the zoom animation, and the position offset
animation.
(WebKit::WebFullScreenManagerMac::windowedCGTransform): Calculates the placement of the windowed layer
in screen coordinates.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evan@chromium.org [Fri, 27 May 2011 00:18:32 +0000 (00:18 +0000)]
2011-05-26 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] simplify TestNetscapePlugIn naming logic
https://bugs.webkit.org/show_bug.cgi?id=61577
* WebKit.gyp: drop use of product_prefix, just use the name
needed directly.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 May 2011 00:08:09 +0000 (00:08 +0000)]
2011-05-26 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
[debug feature] CSSStyleDeclaration should have a way to print cssText
https://bugs.webkit.org/show_bug.cgi?id=61570
Adds a method to print the cssText to stderr for debugging.
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::showStyle): New method to print cssText to stderr
* css/CSSStyleDeclaration.h: New method declaration
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
qi.2.zhang@nokia.com [Fri, 27 May 2011 00:00:42 +0000 (00:00 +0000)]
2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676
Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:
2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676
Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAuthorAndUserStylesEnabled):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAuthorAndUserStylesEnabled):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676
Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 May 2011 23:58:38 +0000 (23:58 +0000)]
2011-05-26 Syed Idris Shah <syed.idris-shah@nokia.com>
Reviewed by Andreas Kling.
[Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
https://bugs.webkit.org/show_bug.cgi?id=60377
LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html
For an array of active uniform, we should be careful while truncating the name of the uniform.
Currently we are truncating the last three characters of an array with out checking for [0].
As a result we are truncating the the actual name of the active uniforms i.e. color to co.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniform): Strip "[0]" from the name if it's an array and is part of the name.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 26 May 2011 23:47:40 +0000 (23:47 +0000)]
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Renamed heapRootMarker to heapRootVisitor to match its class name
https://bugs.webkit.org/show_bug.cgi?id=61584
* heap/Heap.cpp:
(JSC::Heap::markProtectedObjects):
(JSC::Heap::markTempSortVectors):
(JSC::Heap::markRoots):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 26 May 2011 23:47:32 +0000 (23:47 +0000)]
2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87444.
http://trac.webkit.org/changeset/87444
https://bugs.webkit.org/show_bug.cgi?id=61582
Layout test regressions in Chromium/WebKit: fast/css/first-
letter-text-fragment-crash.html, fast/css/first-letter-
visibility.html (Requested by aklein on #webkit).
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::setContentsSize):
* page/FrameView.h:
2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87444.
http://trac.webkit.org/changeset/87444
https://bugs.webkit.org/show_bug.cgi?id=61582
Layout test regressions in Chromium/WebKit: fast/css/first-
letter-text-fragment-crash.html, fast/css/first-letter-
visibility.html (Requested by aklein on #webkit).
* public/WebFrameClient.h:
* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 26 May 2011 23:39:22 +0000 (23:39 +0000)]
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed some interdependency between Heap and SmallStrings by simplifying
the SmallStrings lifetime model
https://bugs.webkit.org/show_bug.cgi?id=61579
SunSpider reports no change.
Using Weak<T> could accomplish this too, but we're not sure it will give
us the performance we need. This is a first step, and it accomplishes
most of the value of using Weak<T>.
* heap/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::markRoots):
(JSC::Heap::reset): Finalize small strings just like other weak handles.
* runtime/SmallStrings.cpp:
(JSC::finalize):
(JSC::SmallStrings::finalizeSmallStrings):
* runtime/SmallStrings.h: Make all small strings trivially weak, instead
of having an "all for one, one for all" memory model.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 26 May 2011 22:58:52 +0000 (22:58 +0000)]
2011-05-26 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make RegExpCache a weak map
https://bugs.webkit.org/show_bug.cgi?id=61554
Switch to a weak map for the regexp cache, and hide that
behaviour behind RegExp::create.
When a RegExp is compiled it attempts to add itself to
the "strong" cache. This cache is a simple round-robin
buffer as was the old strong cache. Happily this can
be smaller than the old strong cache as RegExps are only
added when they're compiled so it is under less pressure
to evict.
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
(JSC::RegExp::match):
* runtime/RegExp.h:
(JSC::RegExp::gcShouldInvalidateCode):
(JSC::RegExp::hasCode):
(JSC::RegExp::key):
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::RegExpCache):
(JSC::RegExpCache::isReachableFromOpaqueRoots):
(JSC::RegExpCache::finalize):
* runtime/RegExpCache.h:
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 26 May 2011 22:49:48 +0000 (22:49 +0000)]
Need a callback for when the preferred rendered size changed.
https://bugs.webkit.org/show_bug.cgi?id=61309
Reviewed by Darin Fisher.
Source/WebCore:
No new tests needed since no new functionality is exposed.
* page/Chrome.cpp:
(WebCore::Chrome::contentsPreferredSizeChanged): Plumbed through the call.
* page/Chrome.h: Added the new method.
* page/ChromeClient.h: Ditto.
* page/FrameView.cpp:
(WebCore::FrameView::setContentsSize): Added calculations for the preferred size
and the call to contentsPreferredSizeChanged.
Source/WebKit/chromium:
* public/WebFrameClient.h
(WebKit::WebFrameClient::didChangeContentsPreferredSize): Added stub.
* src/ChromeClientImpl.h:
(WebKit::ChromeClientImpl::contentsPreferredSizeChanged): Added declaration.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::contentsPreferredSizeChanged): Added call to WebFrameClient::didChangeContentsPreferredSize.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 26 May 2011 22:49:00 +0000 (22:49 +0000)]
2011-05-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch controlClipRect to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=60806
Switching controlClipRect to take an IntPoint representing the
offset to be added instead of a pair of ints.
No new tests as this is just refactoring.
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
* rendering/RenderBox.h:
(WebCore::RenderBox::controlClipRect):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::controlClipRect):
* rendering/RenderButton.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemBackground):
(WebCore::RenderListBox::controlClipRect):
* rendering/RenderListBox.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::controlClipRect):
* rendering/RenderMenuList.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::controlClipRect):
* rendering/RenderTextControlSingleLine.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Thu, 26 May 2011 22:43:51 +0000 (22:43 +0000)]
Fullscreen content is sometimes obscured by taskbar (which even covers up the "exit fullscreen" button)
https://bugs.webkit.org/show_bug.cgi?id=61569
<rdar://problem/9454315>
Reviewed by Steve Falkenburg.
Normally, when the background fullscreen window is animated in, the Windows taskbar will be hidden, but this doesn't always work for some reason.
Workaround this issue by setting the real fullscreen window to be a topmost window.
* platform/graphics/win/FullScreenController.cpp:
(FullScreenController::Private::fullscreenClientWndProc): Exit fullscreen when m_fullScreenWindow is deactivated.
(FullScreenController::enterFullScreenRepaintCompleted): Make m_fullScreenWindow a topmost window before animating it in to ensure the taskbar is hidden.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 26 May 2011 22:43:07 +0000 (22:43 +0000)]
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Moved Heap-related functions out of JSCell.h and into respective header files
https://bugs.webkit.org/show_bug.cgi?id=61567
* heap/Heap.h:
(JSC::Heap::allocate):
(JSC::Heap::heap):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::allocate):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
* runtime/JSCell.h:
(JSC::JSCell::destructor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 26 May 2011 22:37:11 +0000 (22:37 +0000)]
Try to fix Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 26 May 2011 22:30:53 +0000 (22:30 +0000)]
2011-05-26 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
[skia] Add area check to ImageBufferData::getImageData
https://bugs.webkit.org/show_bug.cgi?id=61375
No change in behavior, just a sanity check.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 26 May 2011 22:09:55 +0000 (22:09 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
[debug feature] WTFString should have show() method
https://bugs.webkit.org/show_bug.cgi?id=61149
Added String::show and AtomicString::show in NDEBUG.
* wtf/text/AtomicString.cpp:
(WTF::AtomicString::show):
* wtf/text/AtomicString.h:
* wtf/text/WTFString.cpp:
(String::show):
* wtf/text/WTFString.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 26 May 2011 22:06:54 +0000 (22:06 +0000)]
2011-05-26 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch positionOverflowControls to IntSize
https://bugs.webkit.org/show_bug.cgi?id=61493
Switching positionOverflowControls to take a layerOffset IntSize
as opposed to a pair of ints.
No new tests since this is just refactoring.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintOverflowControls):
* rendering/RenderLayer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ademar.reis@openbossa.org [Thu, 26 May 2011 21:58:57 +0000 (21:58 +0000)]
2011-05-26 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QtTestBrowser "Switch User Agent" dialog is broken
https://bugs.webkit.org/show_bug.cgi?id=61527
The setMaximumHeight() call is unecessary and breaks the dialog at
least on my setup.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::showUserAgentDialog):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 26 May 2011 21:50:52 +0000 (21:50 +0000)]
2011-05-26 Adam Klein <adamk@chromium.org>
Unreviewed. Add Leopard rebaseline.
* platform/chromium-mac-leopard/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 26 May 2011 21:46:09 +0000 (21:46 +0000)]
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen.
Factored out some Heap ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=61565
* JavaScriptCore.exp:
* heap/Heap.cpp:
(JSC::isValidSharedInstanceThreadState):
(JSC::isValidThreadState):
(JSC::Heap::markRoots):
(JSC::Heap::isValidAllocation):
* heap/Heap.h:
* runtime/JSCell.h:
(JSC::JSCell::Heap::allocate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 26 May 2011 21:43:56 +0000 (21:43 +0000)]
2011-05-26 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
Reviewed by Martin Robinson.
Cleanup postCommitFrameViewSetup parameters which are no longer
necessary after the adjustments handling refactoring.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::postCommitFrameViewSetup):
(WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame):
(WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 May 2011 21:39:33 +0000 (21:39 +0000)]
2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87368.
http://trac.webkit.org/changeset/87368
https://bugs.webkit.org/show_bug.cgi?id=61564
Wrong approach, will do the wrong thing if the element needs
simplified normal flow layout but is not positioned (Requested
by jamesr on #webkit).
* transforms/2d/set-transform-and-top-expected.txt: Removed.
* transforms/2d/set-transform-and-top.html: Removed.
2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87368.
http://trac.webkit.org/changeset/87368
https://bugs.webkit.org/show_bug.cgi?id=61564
Wrong approach, will do the wrong thing if the element needs
simplified normal flow layout but is not positioned (Requested
by jamesr on #webkit).
* rendering/RenderObject.h:
(WebCore::RenderObject::needsPositionedMovementLayout):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 26 May 2011 21:37:05 +0000 (21:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=61508
DFG JIT - Add support for get by id self caching.
Reviewed by Geoff Garen.
Change the call out to be an unexpected call (using silent spill/fill functions),
add a structure check & compact load to the JIT code, and add repatching mechanisms.
Since DFGOperations may want to be be implemented in asm, make these symbols be extern
"C". Add an asm wrapper to pass the return address to the optimizing get-by-id operation,
so that it can look up its StructureStubInfo.
* JavaScriptCore.xcodeproj/project.pbxproj:
- Added new files.
* bytecode/StructureStubInfo.h:
- Added 'unset' entries to union.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheck):
- Return the call, we need this to populate the StructureStubInfo.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- Populate the CodebBlock's StructureStubInfo Vector.
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):
- Return the call, we need this to populate the StructureStubInfo.
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
- Add structures to record property access info during compilation.
* dfg/DFGOperations.cpp:
- Made all external methods extern "C".
(JSC::DFG::operationPutByValInternal):
- Moved outside of the extern "C" block.
* dfg/DFGOperations.h:
- Made all external methods extern "C".
* dfg/DFGRepatch.cpp: Added.
(JSC::DFG::dfgRepatchCall):
- repatch a call to link to a new callee function.
(JSC::DFG::dfgRepatchGetByIdSelf):
- Modify the JIT code to optimize self accesses.
(JSC::DFG::tryCacheGetByID):
- Internal implementation of dfgRepatchGetByID (factor out failing cases).
(JSC::DFG::dfgRepatchGetByID):
- Used to optimize 'operationGetByIdOptimize' - repatches to 'operationGetById', and tries to optimize self accesses!
* dfg/DFGRepatch.h: Added.
- Expose dfgRepatchGetByID.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Changed implementation of GetById ops.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 26 May 2011 21:36:22 +0000 (21:36 +0000)]
Remvoe the directory too, since I apparently forgot the magic git-svn argument to clean up empty directories.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87430
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 26 May 2011 21:04:32 +0000 (21:04 +0000)]
2011-05-02 Robert Hogan <robert@webkit.org>
Reviewed by Adam Roben.
[Qt] Allow popup windows from plugins when initiated by a user gesture
https://bugs.webkit.org/show_bug.cgi?id=41292
* platform/qt/Skipped: Unskip plugin-initiate-popup-window.html
* platform/qt/plugins/plugin-initiate-popup-window-expected.txt: Copied from LayoutTests/platform/mac/plugins/plugin-initiate-popup-window-expected.txt.
* plugins/plugin-initiate-popup-window.html: Plugins are only windowless
by default on OSX, so make the plugins windowless explicitly.
2011-05-02 Robert Hogan <robert@webkit.org>
Reviewed by Adam Roben.
[Qt] Allow popup windows from plugins when initiated by a user gesture
https://bugs.webkit.org/show_bug.cgi?id=41292
If the event is from a user gesture and the plugin doesn't support
NPN_PushPopupsEnabledState() and NPN_PopPopupsEnabledState(), allow popups.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::dispatchNPEvent):
2011-05-02 Robert Hogan <robert@webkit.org>
Reviewed by Adam Roben.
[Qt] Allow popup windows from plugins when initiated by a user gesture
https://bugs.webkit.org/show_bug.cgi?id=41292
Support parameters introduced in plugin-initiate-popup-window.html
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
(webkit_test_plugin_handle_event):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 26 May 2011 20:49:24 +0000 (20:49 +0000)]
Remove a bogus .xcworkspace file that was checked in and is causing problems with tab completion.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87428
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 26 May 2011 20:39:30 +0000 (20:39 +0000)]
Rolled back in trac.webkit.org/changeset/87408 with Windows build fixed.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
* wtf/DoublyLinkedList.h:
(WTF::::DoublyLinkedListNode):
(WTF::::setPrev):
(WTF::::setNext):
(WTF::::prev):
(WTF::::next):
(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::size):
(WTF::::clear):
(WTF::::head):
(WTF::::append):
(WTF::::remove):
(WTF::::removeHead):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 May 2011 20:09:55 +0000 (20:09 +0000)]
2011-05-26 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Dmitry Titov.
[V8] Add missing compile guards for WebWorkers in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=61535
No new tests - refactoring only.
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 26 May 2011 19:53:00 +0000 (19:53 +0000)]
2011-05-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843
Add test for doing a cross-origin XHR in an isolated world via
setIsolatedWorldSecurityOrigin and addOriginAccessWhitelistEntry.
Skipped on JSC ports.
* http/tests/security/isolatedWorld/cross-origin-xhr-expected.txt: Added.
* http/tests/security/isolatedWorld/cross-origin-xhr.html: Added.
* http/tests/security/isolatedWorld/resources/cross-origin-xhr.txt: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2011-05-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843
Allows isolated worlds to be associated with a different SecurityOrigin
(exposed as a setIsolatedWorldSecurityOrigin function in
ScriptController).
The XMLHttpRequest constructor can then check that it's being
instantiated in an isolated world and use its security origin.
XMLHttpRequest, ThreadableLoader and DocumentThreadableLoader had to be
changed to use the copied SecurityOrigin instead of always grabbing the
Document's.
Test: http/tests/security/isolatedWorld/cross-origin-xhr.html
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
* bindings/v8/ScriptController.h:
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::setSecurityOrigin):
* bindings/v8/V8IsolatedContext.h:
(WebCore::V8IsolatedContext::securityOrigin):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setIsolatedWorldSecurityOrigin):
(WebCore::V8Proxy::resetIsolatedWorlds):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::preflightSuccess):
(WebCore::DocumentThreadableLoader::isAllowedRedirect):
(WebCore::DocumentThreadableLoader::securityOrigin):
* loader/DocumentThreadableLoader.h:
* loader/ThreadableLoader.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::create):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::securityOrigin):
(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::setRequestHeader):
(WebCore::XMLHttpRequest::getAllResponseHeaders):
(WebCore::XMLHttpRequest::getResponseHeader):
* xml/XMLHttpRequest.h:
2011-05-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843
Expose setIsolatedWorldSecurityOrigin in the WebFrame API.
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
* src/WebFrameImpl.h:
2011-05-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843
Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setIsolatedWorldSecurityOrigin):
* DumpRenderTree/chromium/LayoutTestController.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 26 May 2011 19:48:46 +0000 (19:48 +0000)]
WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=61474
<rdar://problem/9468337>
Reviewed by Adam Roben.
Source/WebKit2:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::statusBarIsVisible): Call the function on the client
if it exists.
(WebKit::InjectedBundlePageUIClient::menuBarIsVisible): Ditto.
(WebKit::InjectedBundlePageUIClient::toolbarsAreVisible): Ditto.
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::statusbarVisible): Add a possible short-circuit in the injected bundle.
(WebKit::WebChromeClient::menubarVisible): Ditto.
(WebKit::WebChromeClient::toolbarsVisible): Ditto.
Tools:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michaeln@google.com [Thu, 26 May 2011 19:43:47 +0000 (19:43 +0000)]
2011-05-26 Michael Nordman <michaeln@google.com>
Reviewed by Darin Fisher.
[Chromium] Use SecurityOrigin produced databaseIdentifier strings, instead of
SecurityOrigin RefPtrs, as the top level key into the DatabaseTracker's
collection of open databases. Otherwise we can fail to lookup databases when
trying to forceably close them via WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=61417
* src/WebDatabase.cpp:
(WebKit::WebDatabase::closeDatabaseImmediately):
2011-05-26 Michael Nordman <michaeln@google.com>
Reviewed by Darin Fisher.
[Chromium] Use SecurityOrigin produced databaseIdentifier strings, instead of
SecurityOrigin RefPtrs, as the top level key into the DatabaseTracker's
collection of open databases. Otherwise we can fail to lookup databases when
trying to forceably close them via WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=61417
New new functionality, no tests.
* storage/DatabaseTracker.h:
* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 26 May 2011 19:42:08 +0000 (19:42 +0000)]
2011-05-26 Adam Klein <adamk@chromium.org>
Unreviewed. Suppress more flaky Linux tests.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 May 2011 19:36:13 +0000 (19:36 +0000)]
2011-05-26 Sailesh Agrawal <sail@chromium.org>
Reviewed by Tony Chang.
Expose willStartLiveResize and willEndLiveResize in WebWidget
https://bugs.webkit.org/show_bug.cgi?id=60518
* public/WebWidget.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::willStartLiveResize):
(WebKit::WebPopupMenuImpl::willEndLiveResize):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::willStartLiveResize):
(WebKit::WebViewImpl::willEndLiveResize):
* src/WebViewImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 26 May 2011 19:34:17 +0000 (19:34 +0000)]
Rolled out trac.webkit.org/changeset/87408 because it broke the
Windows build.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::setPrev):
(JSC::MarkedBlock::setNext):
(JSC::MarkedBlock::prev):
(JSC::MarkedBlock::next):
* wtf/DoublyLinkedList.h:
(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::head):
(WTF::::append):
(WTF::::remove):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 26 May 2011 19:33:58 +0000 (19:33 +0000)]
2011-05-26 Adam Klein <adamk@chromium.org>
Unreviewed. Suppress flaky timeouts and crashes in a few tests.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 26 May 2011 19:30:48 +0000 (19:30 +0000)]
2011-05-25 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Safari Web Content crashes while entering/exiting the full screen mode of the video content
https://bugs.webkit.org/show_bug.cgi?id=61498
No new tests, as DRT does not currently animate the full screen transition.
To guard against m_fullScreenRenderer being called after it has been deleted, add
code in RenderFullScreen which notifies the document when its full-screen renderer
will be destroyed.
Also, add some sanity checks when accessing the full-screen renderer's layer backing.
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement): Guard against a missing
full-screen renderer layer.
(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRenderer): Added ASSERT.
(WebCore::Document::fullScreenRendererDestroyed): Added.
(WebCore::Document::setAnimatingFullScreen): Guard against the full-screen
element having been removed from the document.
* dom/Document.h:
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::destroy): Added. Tell the Document that it's full-screen
renderer is about to be destroyed.
* rendering/RenderFullScreen.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 26 May 2011 19:26:39 +0000 (19:26 +0000)]
2011-05-26 Andreas Kling <kling@webkit.org>
Unreviewed, correct address to webkit-committers mailing list.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 26 May 2011 19:25:08 +0000 (19:25 +0000)]
2011-05-26 Andreas Kling <kling@webkit.org>
Reviewed by Geoffrey Garen.
Overload resolution in generated JSC bindings could be more efficient.
https://bugs.webkit.org/show_bug.cgi?id=61544
Only fetch the arguments once, and not until they are needed (less work
in the case of an early return.)
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 26 May 2011 19:14:16 +0000 (19:14 +0000)]
2011-05-26 Adam Klein <adamk@chromium.org>
Unreviewed. Remove test expectations for now-passing tests.
* platform/chromium/test_expectations.txt: Narrow some failures to Win/Linux; remove tests now passing due to rollout.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 26 May 2011 19:06:47 +0000 (19:06 +0000)]
2011-05-26 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Be robust to empty viewports in the compositor
https://bugs.webkit.org/show_bug.cgi?id=61545
It's possible for a frame to be requested to be drawn before it is
non-empty. The compositor should be robust to that possibility. The
changes in LayerTilerChromium are the only required changes to handle
this, but having an early out in LayerRendererChromium seemed like a
good sanity check.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateAndDrawLayers):
(WebCore::LayerRendererChromium::drawLayers):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::prepareToUpdate):
(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 26 May 2011 18:54:25 +0000 (18:54 +0000)]
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Filled out some features in DoublyLinkedList
https://bugs.webkit.org/show_bug.cgi?id=61549
* heap/MarkedBlock.h: Use DoublyLinkedListNode to simplify our class
definition.
* wtf/DoublyLinkedList.h:
(WTF::::DoublyLinkedListNode):
(WTF::::setPrev):
(WTF::::setNext):
(WTF::::prev):
(WTF::::next): Added a helper base class for being a node in a list.
The odd idioms here allow subclasses to choose their own data member
layout, which is sometimes important for performance.
(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::size):
(WTF::::clear):
(WTF::::head):
(WTF::::append):
(WTF::::remove):
(WTF::::removeHead): Change "Node" to "T" to be more idiomatic, and added
clear(), removeHead(), and size() functions.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Thu, 26 May 2011 18:46:57 +0000 (18:46 +0000)]
2011-05-26 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Change RenderObject to use FloatPoint::scale and FloatQuad::scale
https://bugs.webkit.org/show_bug.cgi?id=61497
Covered by existing test.
* platform/graphics/FloatQuad.h:
(WebCore::FloatQuad::scale):
* rendering/RenderObject.h:
(WebCore::adjustFloatQuadForAbsoluteZoom):
(WebCore::adjustFloatRectForAbsoluteZoom):
(WebCore::adjustFloatQuadForPageScale):
(WebCore::adjustFloatRectForPageScale):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 26 May 2011 18:43:40 +0000 (18:43 +0000)]
2011-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Provide a real owner when copying a property table, for the sake of
write barriers.
https://bugs.webkit.org/show_bug.cgi?id=61547
No test because we can't enable the writeBarrier() ASSERT just yet.
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 26 May 2011 18:34:52 +0000 (18:34 +0000)]
2011-05-26 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix for Qt and QuickTime backend.
r87328 added a new system interface, we need to add it too.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
2011-05-26 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix for Qt and QuickTime backend.
r87328 added a new system interface, we need to add it too.
* platform/qt/WebCoreSystemInterface.h:
* platform/qt/WebCoreSystemInterface.mm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 26 May 2011 18:28:43 +0000 (18:28 +0000)]
2011-05-26 Adam Klein <adamk@chromium.org>
Unreviewed. Rebaselines for SVG tests added in r87284.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 26 May 2011 18:22:00 +0000 (18:22 +0000)]
2011-05-26 Ryosuke Niwa <rniwa@webkit.org>
GTK & Qt rebaselines for r87400.
* platform/gtk/editing/pasteboard/5780697-2-expected.txt:
* platform/qt/editing/pasteboard/5780697-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 26 May 2011 18:15:16 +0000 (18:15 +0000)]
2011-05-26 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Skipping 3 new inspector tests on mac-wk2, see http://webkit.org/b/61437
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 26 May 2011 18:05:04 +0000 (18:05 +0000)]
2011-05-26 Andrey Kosyakov <caseq@chromium.org>
Unreviewed follow-up to r87395, added checks to avoid accessing undefined member for certain timeline events.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.FormattedRecord):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 26 May 2011 17:49:36 +0000 (17:49 +0000)]
2011-05-25 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
WebKit duplicates styles from css rules on copy and paste
https://bugs.webkit.org/show_bug.cgi?id=61466
Fixed the bug by removing duplicate properties from inline style declarations in ReplaceSelectionCommand.
Also moved the code to obtain style from rules from markup.cpp to EditingStyle.cpp to share code.
Test: editing/pasteboard/style-from-rules.html
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::EditingStyle): Added a null check.
(WebCore::EditingStyle::extractFontSizeDelta): Ditto.
(WebCore::styleFromMatchedRulesForElement): Moved from markup.cpp.
(WebCore::EditingStyle::mergeStyleFromRules): Extracted from StyledMarkupAccumulator::appendElement.
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization): Ditto.
(WebCore::EditingStyle::removeStyleFromRules): Added.
* editing/EditingStyle.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Renamed from
negateStyleRulesThatAffectAppearance; Calls removeStyleFromRules.
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendElement): Calls mergeStyleFromRulesForSerialization.
(WebCore::styleFromMatchedRulesAndInlineDecl): Calls mergeStyleFromRules; changed the return type
from CSSMutableStyleDeclaration to EditingStyle.
(WebCore::isElementPresentational): Calls styleFromMatchedRulesAndInlineDecl.
(WebCore::shouldIncludeWrapperForFullySelectedRoot): Ditto.
(WebCore::highestAncestorToWrapMarkup): Calls shouldIncludeWrapperForFullySelectedRoot.
(WebCore::createMarkup): Calls styleFromMatchedRulesAndInlineDecl.
2011-05-25 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
WebKit duplicates styles from css rules on copy and paste
https://bugs.webkit.org/show_bug.cgi?id=61466
Added a test to ensure Webkit does not leave redundant inline style declarations after paste.
Also rebaselined several tests that progressed.
* editing/pasteboard/4922709-expected.txt:
* editing/pasteboard/5780697-2-expected.txt:
* editing/pasteboard/paste-text-012-expected.txt:
* editing/pasteboard/style-from-rules-expected.txt: Added.
* editing/pasteboard/style-from-rules.html: Added.
* platform/chromium-win/editing/pasteboard/5780697-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 26 May 2011 17:16:28 +0000 (17:16 +0000)]
2011-05-26 Michael Schneider <michschn@google.com>
Reviewed by Pavel Feldman.
WebInspector: Added API to access the timeline data in a inspector extension.
https://bugs.webkit.org/show_bug.cgi?id=61098
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.InspectorExtensionAPI):
(WebInspector.injectedExtensionAPI):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._addRecordToTimeline):
(WebInspector.ExtensionServer.prototype._onSubscribe):
(WebInspector.ExtensionServer.prototype._onUnsubscribe):
(WebInspector.ExtensionServer.prototype._registerHandler):
(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
* inspector/front-end/TimelineManager.js: Added.
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.start):
(WebInspector.TimelineManager.prototype.stop):
(WebInspector.TimelineDispatcher):
(WebInspector.TimelineDispatcher.prototype.started):
(WebInspector.TimelineDispatcher.prototype.stopped):
(WebInspector.TimelineDispatcher.prototype.eventRecorded):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-05-26 Michael Schneider <michschn@google.com>
Reviewed by Pavel Feldman.
WebInspector: Added tests for timeline data API in a inspector extension.
https://bugs.webkit.org/show_bug.cgi?id=61098
* inspector/extensions/extensions-api-expected.txt:
* inspector/extensions/extensions-events-expected.txt:
* inspector/extensions/extensions-events.html:
* inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.startTimeline):
(initialize_Timeline.InspectorTest.stopTimeline):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 26 May 2011 17:11:49 +0000 (17:11 +0000)]
2011-05-26 Adam Klein <adamk@chromium.org>
Unreviewed. Added baselines after r87387.
* platform/chromium-linux-x86/fast/borders/border-antialiasing-expected.png: Added.
* platform/chromium-linux-x86/fast/borders/border-antialiasing-expected.txt: Added.
* platform/chromium-linux/fast/borders/border-antialiasing-expected.png: Added.
* platform/chromium-linux/fast/borders/border-antialiasing-expected.txt: Added.
* platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png: Added.
* platform/chromium-win-vista/fast/borders/border-antialiasing-expected.png: Added.
* platform/chromium-win-vista/fast/borders/border-antialiasing-expected.txt: Added.
* platform/chromium/test_expectations.txt: Removed override.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 26 May 2011 17:05:17 +0000 (17:05 +0000)]
2011-05-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebKit2 bundle missing localization subdirectories
https://bugs.webkit.org/show_bug.cgi?id=61512
Better fix for this. We just need to specify CFBundleAllowMixedLocalizations.
* win/WebKit2WebProcess.resources/English.lproj: Removed.
* win/WebKit2WebProcess.resources/Info.plist:
* win/WebKit2WebProcess.resources/da.lproj: Removed.
* win/WebKit2WebProcess.resources/de.lproj: Removed.
* win/WebKit2WebProcess.resources/es.lproj: Removed.
* win/WebKit2WebProcess.resources/fi.lproj: Removed.
* win/WebKit2WebProcess.resources/fr.lproj: Removed.
* win/WebKit2WebProcess.resources/it.lproj: Removed.
* win/WebKit2WebProcess.resources/ja.lproj: Removed.
* win/WebKit2WebProcess.resources/ko.lproj: Removed.
* win/WebKit2WebProcess.resources/nb.lproj: Removed.
* win/WebKit2WebProcess.resources/nl.lproj: Removed.
* win/WebKit2WebProcess.resources/pl.lproj: Removed.
* win/WebKit2WebProcess.resources/pt.lproj: Removed.
* win/WebKit2WebProcess.resources/pt_PT.lproj: Removed.
* win/WebKit2WebProcess.resources/ru.lproj: Removed.
* win/WebKit2WebProcess.resources/sv.lproj: Removed.
* win/WebKit2WebProcess.resources/zh_CN.lproj: Removed.
* win/WebKit2WebProcess.resources/zh_TW.lproj: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 26 May 2011 16:56:19 +0000 (16:56 +0000)]
2011-05-26 Adam Klein <adamk@chromium.org>
Unreviewed. Test expectations update/rebaseline.
* platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
* platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
* platform/chromium-win-vista/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
* platform/chromium/test_expectations.txt: BUGCR84052, border-antialiasing.html IMAGE+TEXT.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 26 May 2011 16:36:38 +0000 (16:36 +0000)]
2011-05-26 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: TimelinePanel should not modify input timeline data when processing timeline event
https://bugs.webkit.org/show_bug.cgi?id=61529
Do not modify input timeline data when processing timeline event.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._refreshDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2011-05-26 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: TimelinePanel should not modify input timeline data when processing timeline event
https://bugs.webkit.org/show_bug.cgi?id=61529
Do not modify input timeline data when processing timeline event.
* inspector/timeline/timeline-network-resource-expected.txt:
* platform/chromium/inspector/timeline/timeline-network-resource-expected.txt
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 26 May 2011 16:35:30 +0000 (16:35 +0000)]
2011-05-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebKit2 bundle missing localization subdirectories
https://bugs.webkit.org/show_bug.cgi?id=61512
<rdar://problem/9498607>
These lproj directories are intentionally left empty.
Their presence indicates that this exe is localized to this
set of languages.
* win/WebKit2WebProcess.resources/English.lproj: Added.
* win/WebKit2WebProcess.resources/da.lproj: Added.
* win/WebKit2WebProcess.resources/de.lproj: Added.
* win/WebKit2WebProcess.resources/es.lproj: Added.
* win/WebKit2WebProcess.resources/fi.lproj: Added.
* win/WebKit2WebProcess.resources/fr.lproj: Added.
* win/WebKit2WebProcess.resources/it.lproj: Added.
* win/WebKit2WebProcess.resources/ja.lproj: Added.
* win/WebKit2WebProcess.resources/ko.lproj: Added.
* win/WebKit2WebProcess.resources/nb.lproj: Added.
* win/WebKit2WebProcess.resources/nl.lproj: Added.
* win/WebKit2WebProcess.resources/pl.lproj: Added.
* win/WebKit2WebProcess.resources/pt.lproj: Added.
* win/WebKit2WebProcess.resources/pt_PT.lproj: Added.
* win/WebKit2WebProcess.resources/ru.lproj: Added.
* win/WebKit2WebProcess.resources/sv.lproj: Added.
* win/WebKit2WebProcess.resources/zh_CN.lproj: Added.
* win/WebKit2WebProcess.resources/zh_TW.lproj: Added.
* win/WebKit2WebProcessPostBuild.cmd: Copy entire resources directory, exclude .svn directories.
* win/xcopy.excludes: Added. Excludes .svn directories.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 26 May 2011 16:32:11 +0000 (16:32 +0000)]
2011-05-26 Tony Chang <tony@chromium.org>
Unreviewed, fixing the expected results for a test that had the
output duplicated.
* platform/chromium/test_expectations.txt:
* storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Thu, 26 May 2011 16:13:10 +0000 (16:13 +0000)]
2011-05-26 Rob Buis <rbuis@rim.com>
Reviewed by Dirk Schulze.
Dynamically created <animate> elements do not animate upon document insertion as they should
https://bugs.webkit.org/show_bug.cgi?id=20028
Tests: svg/animations/animate-insert-begin.html
svg/animations/animate-insert-no-begin.html
Move animation initializing and rescheduling to insertedIntoDocument. This way animate elements
dynamicaly inserted into the document using js start as well.
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedIntoDocument):
* svg/animation/SVGSMILElement.h:
2011-05-26 Rob Buis <rbuis@rim.com>
Reviewed by Dirk Schulze.
Dynamically created <animate> elements do not animate upon document insertion as they should
https://bugs.webkit.org/show_bug.cgi?id=20028
Add tests for dynamically inserting <animate>.
* svg/animations/animate-insert-begin-expected.txt: Added.
* svg/animations/animate-insert-begin.html: Added.
* svg/animations/animate-insert-no-begin-expected.txt: Added.
* svg/animations/animate-insert-no-begin.html: Added.
* svg/animations/script-tests/animate-insert-begin.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/animate-insert-no-begin.js: Added.
(sample1):
(sample2):
(executeTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Thu, 26 May 2011 16:08:43 +0000 (16:08 +0000)]
2011-05-26 Chang Shu <cshu@webkit.org>
Unreviewed.
[Qt] http/tests/websocket/tests/reload-crash.html fails intermittently with time out
https://bugs.webkit.org/show_bug.cgi?id=50152
Unskip the test case as it's not reproducible. Will watch the buildbot results.
* platform/qt/Skipped: Unskip http/tests/websocket/tests/reload-crash.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 May 2011 16:05:43 +0000 (16:05 +0000)]
2011-05-26 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
JSC DOM bindings: ExecState::argumentCount() is size_t, not int.
https://bugs.webkit.org/show_bug.cgi?id=61530
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 26 May 2011 15:56:47 +0000 (15:56 +0000)]
2011-05-26 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
Some repeating linear gradients look wrong
https://bugs.webkit.org/show_bug.cgi?id=61371
Test: fast/gradients/css3-repeating-linear-gradients2.html
Fix incorrect stop duplication code when filling forwards a repeating
gradient. The "if (srcStopOrdinal < originalNumStops - 1)" test was wrong
because srcStopOrdinal had been adjusted for stops added by start-filling,
but originalNumStops had not. Fix by considering srcStopOrdinal as an index
into the original stops, so comparing it with originalNumStops remains valid.
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 May 2011 15:54:54 +0000 (15:54 +0000)]
2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: In network panel, show transfer size in a first line of resource row.
https://bugs.webkit.org/show_bug.cgi?id=61354
* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._createTable):
(WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 26 May 2011 15:34:48 +0000 (15:34 +0000)]
2011-05-25 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Always antialias borders, outlines and rules when scaling
https://bugs.webkit.org/show_bug.cgi?id=61502
r84273 changed the behavior of drawLineForBoxSide() to never antialias by default.
This actually disabled antialiasing in some circumstances where it used to be enabled,
for example collapsed table border drawing.
Fix by allowing antialiasing for collapsed table borders, column rules and span
outlines when the context is scaled.
Test: fast/borders/border-antialiasing.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorder):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Thu, 26 May 2011 15:01:44 +0000 (15:01 +0000)]
[Chromium] Unreviewed. Mark inspector/profiler/cpu-profiler-profiling.html as flaky on Linux
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 26 May 2011 14:54:04 +0000 (14:54 +0000)]
[Qt][WK2] Update expected files after r87320.
* platform/qt-wk2/Skipped:
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Added.
* platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
qi.2.zhang@nokia.com [Thu, 26 May 2011 14:35:13 +0000 (14:35 +0000)]
2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] Remove test cases related to layoutTestController.dumpBackForwardList from qt-wk2/Skipped
https://bugs.webkit.org/show_bug.cgi?id=61462
WebKitTestRunner already support layoutTestController.dumpBackForwardList from r70723.
* platform/qt-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 26 May 2011 14:28:04 +0000 (14:28 +0000)]
2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=59193
* inspector/debugger/source-frame.html:
2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=59193
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
(WebInspector.NetworkItemView._contentViewForResource):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._refreshResource):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get messages):
(WebInspector.Resource.prototype.addMessage):
(WebInspector.Resource.prototype.set errors):
(WebInspector.Resource.prototype.set warnings):
(WebInspector.Resource.prototype.clearErrorsAndWarnings):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.hasTextContent):
(WebInspector.ResourceView.nonSourceViewForResource):
(WebInspector.ResourceSourceFrame):
(WebInspector.ResourceSourceFrame.mimeTypeForResource):
(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype.suggestedFileName):
(WebInspector.EditableResourceSourceFrame):
(WebInspector.EditableResourceSourceFrame.prototype.doubleClick):
(WebInspector.EditableResourceSourceFrame.prototype.editContent):
(WebInspector.EditableResourceSourceFrame.prototype.cancelEditing):
(WebInspector.EditableResourceSourceFrame.prototype.afterTextChanged):
(WebInspector.EditableResourceSourceFrame.prototype._clearIncrementalUpdateTimer):
(WebInspector.ResourceRevisionSourceFrame):
(WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showResource):
(WebInspector.ResourcesPanel.prototype._showResourceView):
(WebInspector.ResourcesPanel.prototype._resourceViewForResource):
(WebInspector.ResourcesPanel.prototype._showRevisionView):
(WebInspector.ResourcesPanel.prototype._sourceViewForRevision):
(WebInspector.ResourcesPanel.prototype.searchCanceled):
(WebInspector.ResourcesPanel.prototype._findTreeElementForRevision):
(WebInspector.ResourcesPanel.prototype._findTreeElementForRevision.getParent):
(WebInspector.FrameResourceTreeElement):
(WebInspector.FrameResourceTreeElement.prototype.onattach):
(WebInspector.FrameResourceTreeElement.prototype._updateErrorsAndWarningsBubbles):
(WebInspector.FrameResourceTreeElement.prototype._errorsWarningsCleared):
(WebInspector.FrameResourceTreeElement.prototype._errorsWarningsMessageAdded):
(WebInspector.FrameResourceTreeElement.prototype._appendRevision):
(WebInspector.FrameResourceTreeElement.prototype.sourceView):
(WebInspector.FrameResourceTreeElement.prototype._createSourceView):
(WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
(WebInspector.ResourceRevisionTreeElement):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
(WebInspector.ResourceRevisionTreeElement.prototype.sourceView):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 26 May 2011 14:01:38 +0000 (14:01 +0000)]
2011-05-26 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip flaky test on GTK.
[GTK] http/tests/eventsource/workers/eventsource-simple.html is flaky crash
https://bugs.webkit.org/show_bug.cgi?id=61523
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 26 May 2011 13:28:11 +0000 (13:28 +0000)]
2011-05-26 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK baselines for new tests.
* platform/gtk/fast/box-shadow/scaled-box-shadow-expected.txt: Added.
* platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt: Added.
* platform/gtk/fast/html/details-add-details-child-2-expected.txt: Added.
* platform/gtk/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/gtk/fast/html/details-replace-text-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 26 May 2011 13:20:00 +0000 (13:20 +0000)]
Don't assume that builds finish in the order they were started
Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
build when one slave is taking a long time to finish a build
Reviewed by Antti Koivisto.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
newer than the oldest in-progress build are also themselves in progress. Just check whether
each build is actually in progress (as signified by its presence in the currentBuilds set).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Thu, 26 May 2011 12:54:31 +0000 (12:54 +0000)]
[Chromium] Unreviewed test expectations update. Mark 3 tests as flaky
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
projects / profile / ivi / webkit-efl.git / log