platform/upstream/mesa.git
11 months agonvk: simplify code by using new helpers
Thomas H.P. Andersen [Sun, 2 Apr 2023 23:41:22 +0000 (01:41 +0200)]
nvk: simplify code by using new helpers

All tests still pass:
dEQP-VK.query_pool.*.compute_shader_invocations*

Test run totals:
  Passed:        78/78 (100.0%)
  Failed:        0/78 (0.0%)
  Not supported: 0/78 (0.0%)
  Warnings:      0/78 (0.0%)
  Waived:        0/78 (0.0%)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Reset offset value in ResetDescriptorPool
Echo J [Sun, 2 Apr 2023 13:29:19 +0000 (16:29 +0300)]
nvk: Reset offset value in ResetDescriptorPool

This is another secret change you've been waiting for 🐸

This change resets the current_offset value to 0 in ResetDescriptorPool
(without it the offset would keep counting until it reaches the limit
which causes allocation issues and/or application crashes/freezes)

RADV does the same thing, so I think this change is correct 🤓

BTW this meme seems to be relevant: https://youtu.be/1stQbTuUBIE

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add bufferImageGranularity limit
Echo J [Thu, 30 Mar 2023 19:34:18 +0000 (22:34 +0300)]
nvk: Add bufferImageGranularity limit

This is the secret change everyone has been waiting for 🐸

But anyway, this change adds the bufferImageGranularity limit (which
is needed by both DXVK and osu!lazer; DXVK will be a corrupted mess
without it and osu!lazer simply throws an exception)

The values have been scraped from https://vulkan.gpuinfo.org BTW
(because of that I'm not sure if they're actually accurate)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Advertise EXT_shader_viewport_index_layer on MaxwellB+
Faith Ekstrand [Fri, 31 Mar 2023 16:37:58 +0000 (11:37 -0500)]
nvk: Advertise EXT_shader_viewport_index_layer on MaxwellB+

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Sort SPIR-V caps
Faith Ekstrand [Fri, 31 Mar 2023 18:56:38 +0000 (13:56 -0500)]
nvk: Sort SPIR-V caps

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Implement VK_KHR_map_memory2
Faith Ekstrand [Fri, 31 Mar 2023 16:11:22 +0000 (11:11 -0500)]
nvk: Implement VK_KHR_map_memory2

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Use vk_device_memory
Faith Ekstrand [Fri, 31 Mar 2023 16:07:36 +0000 (11:07 -0500)]
nvk: Use vk_device_memory

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Set spirv_to_nir_options::min_*_alignment
Faith Ekstrand [Thu, 30 Mar 2023 22:41:47 +0000 (17:41 -0500)]
nvk: Set spirv_to_nir_options::min_*_alignment

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add a separate #define for SSBO alignment
Faith Ekstrand [Thu, 30 Mar 2023 22:40:35 +0000 (17:40 -0500)]
nvk: Add a separate #define for SSBO alignment

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Expose VK_KHR_maintenance2
Faith Ekstrand [Thu, 30 Mar 2023 20:42:01 +0000 (15:42 -0500)]
nvk: Expose VK_KHR_maintenance2

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Set pointClippingBehavior
Faith Ekstrand [Thu, 30 Mar 2023 20:40:57 +0000 (15:40 -0500)]
nvk: Set pointClippingBehavior

This is what the blob advertises.  I don't know if it's correct or not
because the CTS test for this seems to pass either way:

    dEQP-VK.clipping.clip_volume.depth_clamp.point_list

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Implement uncompressed views of compressed images
Faith Ekstrand [Thu, 30 Mar 2023 16:38:16 +0000 (11:38 -0500)]
nvk: Implement uncompressed views of compressed images

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonil: Add an image_level_as_uncompressed helper
Faith Ekstrand [Thu, 30 Mar 2023 16:33:54 +0000 (11:33 -0500)]
nil: Add an image_level_as_uncompressed helper

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonil: Add a nil_image_for_level helper
Faith Ekstrand [Thu, 30 Mar 2023 16:24:22 +0000 (11:24 -0500)]
nil: Add a nil_image_for_level helper

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Support geometry shaders
George Ouzounoudis [Tue, 18 Oct 2022 18:51:37 +0000 (21:51 +0300)]
nvk: Support geometry shaders

This enables geometry shaders for nvk.  Physical device limits taken
from nouveau codebase and http://www.vulkan.gpuinfo.org

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Fix geometry shader active stream mask
George Ouzounoudis [Sat, 26 Nov 2022 16:39:20 +0000 (18:39 +0200)]
nvk: Fix geometry shader active stream mask

This sets StreamOutMask in the shader header correctly based on:
https://download.nvidia.com/open-gpu-doc/Shader-Program-Header/1/Shader-Program-Header.html

After this fix transform feedback CTS tests with geometry shader streams
are passing.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Disable PRIMITIVE_RESTART_VERTEX_ARRAY by default
George Ouzounoudis [Mon, 21 Nov 2022 19:01:14 +0000 (21:01 +0200)]
nvk: Disable PRIMITIVE_RESTART_VERTEX_ARRAY by default

This made various strip geometry tests fail.  Tests with primitive
restart do not seem affected after this.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Increase the push runout to 512 dwords
Faith Ekstrand [Thu, 30 Mar 2023 19:46:40 +0000 (14:46 -0500)]
nvk: Increase the push runout to 512 dwords

This is needed in order to do all of viewport state in a single push.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add A8B8G8R8_*_PACK32 format support
Echo J [Thu, 30 Mar 2023 16:58:28 +0000 (19:58 +0300)]
nvk: Add A8B8G8R8_*_PACK32 format support

Here it is; the long-awaited change (as requested by 2 people on Discord 🥺)

This change originally added one Vulkan format which was needed for STK's
Vulkan renderer, but @gfxstrand suggested to add all of the A8B8G8R8_*_PACK32
formats in a GitLab thread)

This obviously fixes SuperTuxKart crashing with the Vulkan renderer 🐸

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Advertise VK_KHR_multiview
Rebecca Mckeever [Thu, 16 Feb 2023 00:47:30 +0000 (16:47 -0800)]
nvk: Advertise VK_KHR_multiview

Closes: https://gitlab.freedesktop.org/nouveau/mesa/-/issues/52

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add input attachments support for multiview
Rebecca Mckeever [Fri, 3 Mar 2023 19:51:07 +0000 (11:51 -0800)]
nvk: Add input attachments support for multiview

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add query support for multiview
Rebecca Mckeever [Mon, 27 Feb 2023 21:14:56 +0000 (13:14 -0800)]
nvk: Add query support for multiview

When multiview is enabled, queries must use N consecutive query indices in the
query pool, where N is the number of bits set in the view mask in the subpass
the query is used in.

In our case, only the first query is used, so we emit zeros for the remaining
queries.

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add draw support for multiview
Rebecca Mckeever [Tue, 7 Mar 2023 00:09:55 +0000 (16:09 -0800)]
nvk: Add draw support for multiview

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Break the inner MME draw loop into a helper
Faith Ekstrand [Fri, 17 Mar 2023 15:29:54 +0000 (10:29 -0500)]
nvk: Break the inner MME draw loop into a helper

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Spill DRAW_IDX pre-Turing
Faith Ekstrand [Mon, 27 Mar 2023 22:44:33 +0000 (17:44 -0500)]
nvk: Spill DRAW_IDX pre-Turing

Spill draw_idx to shadow scratch once we've written it to the root
descriptor.  This saves us a bit of register pressure around a pretty
tight seciton.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Rework spill helpers and DRAW_COUNT spilling
Faith Ekstrand [Mon, 27 Mar 2023 21:22:12 +0000 (16:22 -0500)]
nvk: Rework spill helpers and DRAW_COUNT spilling

The new helpers, now moved to nvk_mme.h, take an nvk_mme_scratch value
to ensure no overlap.  They also ensure that we use exactly the same
register for the unspilled value as the spilled value.  This makes
spilling safe for loop-carried values and the like.  The old
nvk_mme_fill() helper just loads a spilled value to a new, possibly
different register.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Add a helper for re-allocating registers
Faith Ekstrand [Mon, 27 Mar 2023 21:09:54 +0000 (16:09 -0500)]
nouveau/mme: Add a helper for re-allocating registers

This helper unlike alloc, tries to use the same value as the register
had before.  This is intended for manual spill/unspill code which wants
to keep register numbers the same while carefully spilling around high-
pressure regions.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Use the new load/store_scratch helpers for DRAW_PAD_DW
Faith Ekstrand [Mon, 27 Mar 2023 21:32:41 +0000 (16:32 -0500)]
nvk: Use the new load/store_scratch helpers for DRAW_PAD_DW

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add begin to mme_scratch
Faith Ekstrand [Fri, 24 Mar 2023 00:18:36 +0000 (19:18 -0500)]
nvk: Add begin to mme_scratch

Introduce helpers to make it easier to work with the nvk mme shadow
scratch. Store begin in the shadow scratch in vkCmdDraw* related code to
save registers, which is necessary for Fermi.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Lower nir_intrinsic_load_view_index
Rebecca Mckeever [Fri, 17 Feb 2023 02:40:45 +0000 (18:40 -0800)]
nvk: Lower nir_intrinsic_load_view_index

Lower view_index intrinsics to a load_ubo using NIR.

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add view_index to root descriptor table
Rebecca Mckeever [Fri, 17 Feb 2023 01:41:07 +0000 (17:41 -0800)]
nvk: Add view_index to root descriptor table

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Fix while loops pre-Turing
Faith Ekstrand [Wed, 29 Mar 2023 04:34:29 +0000 (23:34 -0500)]
nouveau/mme: Fix while loops pre-Turing

Pre-Turing, we don't have a full condition built into the loop so, for
mme_while(b, ine, x, y) we have to generate the following:

[top]   BR -> [cond]
        /* loop body */
[cond]  XOR tmp, x, y
        BRZ !tmp -> [top]

However, due to an accounting error, we were generating

[top]   BR -> [cond]
        /* loop body */
        XOR tmp, x, y
[cond]  BRZ !tmp -> [top]

which meant that the XOR (or ADD if one is an immediate) was getting
skipped, leading to the loop either never terminating or always
terminating.  The way to fix this accounting error is to close the while
first, then compute the condition value, then do the jump.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Use ADD for ine with an immediate
Faith Ekstrand [Wed, 29 Mar 2023 04:31:20 +0000 (23:31 -0500)]
nouveau/mme: Use ADD for ine with an immediate

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add a macro to set MMIO registers via falcons
Karol Herbst [Thu, 23 Mar 2023 14:43:05 +0000 (15:43 +0100)]
nvk: Add a macro to set MMIO registers via falcons

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: add a macro exit helper
Karol Herbst [Thu, 23 Mar 2023 14:39:03 +0000 (15:39 +0100)]
nouveau/mme: add a macro exit helper

At the moment it's turing+ only.

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: add test for BEQ with magic exit offset
Karol Herbst [Thu, 23 Mar 2023 16:54:47 +0000 (17:54 +0100)]
nouveau/mme: add test for BEQ with magic exit offset

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Fix some cast defines
Echo J [Mon, 27 Mar 2023 21:03:33 +0000 (00:03 +0300)]
nvk: Fix some cast defines

This removes compiler warnings on 32-bit builds 🐸

Also other drivers do define casts this way, so this should actually
be an uncontroversial change 😁

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add instace WSI entrypoints
Faith Ekstrand [Mon, 27 Mar 2023 20:49:50 +0000 (15:49 -0500)]
nvk: Add instace WSI entrypoints

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Advertise ICD/loader interface version 4
Faith Ekstrand [Mon, 27 Mar 2023 16:29:36 +0000 (11:29 -0500)]
nvk: Advertise ICD/loader interface version 4

We can't advertise v5 yet because we don't support Vulkan 1.1 yet.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Use the same lock for the submit and the memory objects list
Faith Ekstrand [Wed, 22 Mar 2023 21:09:23 +0000 (16:09 -0500)]
nvk: Use the same lock for the submit and the memory objects list

We need to lock the memory objects list around the entire push builder
process.  Otherwise, a memory object could get destroyed between adding
it to the BO list and doing the submit, leading to the kernel rejecting
our pushbuf.

When the time comes that we switch to the new uAPI both uses of
nvk_device::mutex will go away.  We'll no longer be passing lists of BOs
to the kernel and we'll move to syncobj and be able to drop all the
nvk_bo_sync nonsense.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: advertise DemoteToHelperInvocation
Mohamed Ahmed [Mon, 20 Mar 2023 19:26:36 +0000 (21:26 +0200)]
nvk: advertise DemoteToHelperInvocation

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: fix r32_sint format support
Dave Airlie [Wed, 22 Mar 2023 06:34:33 +0000 (16:34 +1000)]
nvk: fix r32_sint format support

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: add min_lod to spirv caps.
Dave Airlie [Wed, 22 Mar 2023 00:56:42 +0000 (10:56 +1000)]
nvk: add min_lod to spirv caps.

We expose the vulkan feature

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: add compute support for ampere
Dave Airlie [Wed, 22 Mar 2023 00:10:13 +0000 (10:10 +1000)]
nvk: add compute support for ampere

ampere has support for QMDv3, it's not mandatory but lets use it for now.

the more important change is the PCAS2_B call.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Clamp viewport clip to max range
Faith Ekstrand [Wed, 22 Mar 2023 17:28:44 +0000 (12:28 -0500)]
nvk: Clamp viewport clip to max range

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk/barrier: handle host bit.
Dave Airlie [Tue, 21 Mar 2023 06:23:19 +0000 (16:23 +1000)]
nvk/barrier: handle host bit.

Fixes dEQP-VK.pipeline.monolithic.timestamp.transfer_tests.host_stage* crashes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Support vertex shader transform feedback on Fermi
George Ouzounoudis [Tue, 31 Jan 2023 20:53:56 +0000 (22:53 +0200)]
nvk: Support vertex shader transform feedback on Fermi

Byte counts should be fetched with a different way in case of Fermi.
We cannot read the buffer directly in the mme.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Support transform feedback queries
George Ouzounoudis [Sat, 26 Nov 2022 17:46:48 +0000 (19:46 +0200)]
nvk: Support transform feedback queries

We need 2 reports for these. One for successfully written primitives
and one for needed primitives. Also we need to use report semaphore's
sub_report member to specify the query's corresponding vertex stream.
Finally availability index is 2 in the query results, as we have 2
results for succeeded and needed primitives.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Support transform feedback geometry streams
George Ouzounoudis [Sat, 26 Nov 2022 16:32:22 +0000 (18:32 +0200)]
nvk: Support transform feedback geometry streams

We just need to set the correct limits and features.  The meaningful
change here is the selected stream for rasterization which is configured
through the graphics pipeline.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Support transform feedback indirect draws
George Ouzounoudis [Fri, 25 Nov 2022 19:10:30 +0000 (21:10 +0200)]
nvk: Support transform feedback indirect draws

This draw needs to read the byte count indirectly so it is implemented
as an mme function.  Some refactoring was done in the draw functions, so
that nvk_mme_build_draw could be used for this case.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: De-duplicate MME code for setting draw params
Faith Ekstrand [Wed, 22 Mar 2023 16:42:19 +0000 (11:42 -0500)]
nvk: De-duplicate MME code for setting draw params

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Ensure that zero-initizlied mme_value is ZERO
Faith Ekstrand [Wed, 22 Mar 2023 15:31:48 +0000 (10:31 -0500)]
nouveau/mme: Ensure that zero-initizlied mme_value is ZERO

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Support for vertex shader transform feedback
George Ouzounoudis [Wed, 16 Nov 2022 20:29:57 +0000 (22:29 +0200)]
nvk: Support for vertex shader transform feedback

For starters, we support only vertex shader output transform feedback.
Optional support for queries, streams and indirect draw are left out for
now.

Pipeline and shader state is based on nvc0 code. Most of the shader
state is going to change with the new compiler.

Required support for pause/resume is implemented with an mme function
that loads the offset indirectly from the counter buffer on resume.
For pause, we store the offset indirectly with a SET_REPORT_SEMAPHORE.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk/nil: don't ask for compressed image kind
Dave Airlie [Sun, 19 Mar 2023 23:41:38 +0000 (09:41 +1000)]
nvk/nil: don't ask for compressed image kind

These need special kernel handling around the mmu, avoid asking
for them, nvidia don't seem to use them with gsp either yet.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/winsys: allocate unique object handles across channels.
Dave Airlie [Fri, 17 Mar 2023 05:54:14 +0000 (15:54 +1000)]
nouveau/winsys: allocate unique object handles across channels.

GSP requires unique object handles across channels, otherwise
it reports an error.

This fixes vulkaninfo on gsp enabled fw

Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Add a bfe helper
Faith Ekstrand [Fri, 17 Mar 2023 18:29:34 +0000 (13:29 -0500)]
nouveau/mme: Add a bfe helper

This extracts a fixed number of bits from a possibly variable position
in the source value.  Very helpful for testing for a bit.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Advertise shaderImageGatherExtended
Faith Ekstrand [Fri, 17 Mar 2023 16:24:45 +0000 (11:24 -0500)]
nvk: Advertise shaderImageGatherExtended

Closes: https://gitlab.freedesktop.org/nouveau/mesa/-/issues/62
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Rework features enables
Faith Ekstrand [Thu, 16 Mar 2023 23:37:44 +0000 (18:37 -0500)]
nvk: Rework features enables

Use the new feature enables framework.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Rework extension enables
Faith Ekstrand [Thu, 16 Mar 2023 23:43:33 +0000 (18:43 -0500)]
nvk: Rework extension enables

Take an nv_device_info instead of a full nvk_physical_device.  This
prevents errors where nvk_get_device_extensions() may access an
uninitialized field of nvk_physical_device.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: advertise VK_KHR_maintenance4
Mohamed Ahmed [Sat, 11 Mar 2023 21:45:55 +0000 (23:45 +0200)]
nvk: advertise VK_KHR_maintenance4

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: implement vkGetDeviceBufferMemoryRequirementsKHR()
Mohamed Ahmed [Sat, 11 Mar 2023 20:48:02 +0000 (22:48 +0200)]
nvk: implement vkGetDeviceBufferMemoryRequirementsKHR()

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: add stub for vkGetDeviceImageSparseMemoryRequirementsKHR()
Mohamed Ahmed [Fri, 10 Mar 2023 22:07:31 +0000 (00:07 +0200)]
nvk: add stub for vkGetDeviceImageSparseMemoryRequirementsKHR()

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: implement vkGetDeviceImageMemoryRequirementsKHR()
Mohamed Ahmed [Fri, 10 Mar 2023 22:02:41 +0000 (00:02 +0200)]
nvk: implement vkGetDeviceImageMemoryRequirementsKHR()

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Add a helper to dump instructions
Faith Ekstrand [Mon, 13 Mar 2023 14:53:14 +0000 (09:53 -0500)]
nouveau/mme: Add a helper to dump instructions

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Fix nested while instructions on Turing+
Faith Ekstrand [Thu, 9 Mar 2023 21:45:44 +0000 (15:45 -0600)]
nouveau/mme: Fix nested while instructions on Turing+

Closes: https://gitlab.freedesktop.org/nouveau/mesa/-/issues/49
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Bump init context batch size
Faith Ekstrand [Thu, 9 Mar 2023 21:43:51 +0000 (15:43 -0600)]
nvk: Bump init context batch size

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: set device info before use in nvk_get_device_extensions
Thomas H.P. Andersen [Fri, 3 Mar 2023 23:07:16 +0000 (00:07 +0100)]
nvk: set device info before use in nvk_get_device_extensions

nvk_get_device_extensions uses device->info to enable extensions
only for supported device architectures.

Only info is needed, but it seemed cleaner to keep all the three
changed lines together.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Implement VK_KHR_draw_indirect_count on Turing+
Thomas H.P. Andersen [Thu, 3 Nov 2022 22:30:53 +0000 (23:30 +0100)]
nvk: Implement VK_KHR_draw_indirect_count on Turing+

v2: handle maxDrawCount parameter
v3: assert on pre-turing. Free regsisters after use.
v4: less register presure. Update to pass new tests

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: add warning on non-nouveau drm driver
Thomas H.P. Andersen [Wed, 25 Jan 2023 21:53:15 +0000 (22:53 +0100)]
nvk: add warning on non-nouveau drm driver

Check that the drm kernel driver in use is nouveau, and
add a short description of the issue.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Return VK_ERROR_INCOMPATIBLE_DRIVER if the PCI vendor isn't NVIDIA
Faith Ekstrand [Tue, 28 Feb 2023 18:32:33 +0000 (12:32 -0600)]
nvk: Return VK_ERROR_INCOMPATIBLE_DRIVER if the PCI vendor isn't NVIDIA

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Support VK_KHR_shader_draw_parameters
George Ouzounoudis [Sat, 5 Nov 2022 19:55:25 +0000 (21:55 +0200)]
nvk: Support VK_KHR_shader_draw_parameters

We need to supply the base vertex, the base instance and draw index to
the shader for this extension. Similar to the base instance we supported
before, we load base vertex and draw index as root constants at draw time.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Simplify mme build function argument
George Ouzounoudis [Thu, 26 Jan 2023 17:39:28 +0000 (19:39 +0200)]
nvk: Simplify mme build function argument

We do not need the full nvk_device struct for the mme builder functions,
just the nv_device_info is enough. We keep a pointer in the
mme_builder so we can use this instead. Also, when we run mme builder
tests we do not need to initialize a device struct.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Keep device info in mme_builder
George Ouzounoudis [Thu, 26 Jan 2023 17:36:53 +0000 (19:36 +0200)]
nouveau/mme: Keep device info in mme_builder

We keep a pointer to nv_device_info instead of just copying the GPU's
3D engine class.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Advertise VK_EXT_robustness2
Rebecca Mckeever [Mon, 23 Jan 2023 19:59:18 +0000 (11:59 -0800)]
nvk: Advertise VK_EXT_robustness2

Closes: https://gitlab.freedesktop.org/nouveau/mesa/-/issues/39

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Advertise VK_EXT_image_robustness
Rebecca Mckeever [Fri, 27 Jan 2023 06:06:28 +0000 (22:06 -0800)]
nvk: Advertise VK_EXT_image_robustness

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Set image index to zero for NULL nvk_buffer_view
Rebecca Mckeever [Fri, 27 Jan 2023 19:47:34 +0000 (11:47 -0800)]
nvk: Set image index to zero for NULL nvk_buffer_view

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Advertise VK_EXT_mutable_descriptor_type
Rebecca Mckeever [Fri, 13 Jan 2023 23:36:25 +0000 (15:36 -0800)]
nvk: Advertise VK_EXT_mutable_descriptor_type

Closes: https://gitlab.freedesktop.org/nouveau/mesa/-/issues/41

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Enable VK_KHR_maintenance3
Rebecca Mckeever [Fri, 20 Jan 2023 17:53:59 +0000 (09:53 -0800)]
nvk: Enable VK_KHR_maintenance3

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Implement nvk_GetDescriptorSetLayoutSupport
Rebecca Mckeever [Sat, 14 Jan 2023 05:32:02 +0000 (21:32 -0800)]
nvk: Implement nvk_GetDescriptorSetLayoutSupport

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Don't over-size push descriptor sets
Faith Ekstrand [Tue, 31 Jan 2023 02:12:07 +0000 (20:12 -0600)]
nvk: Don't over-size push descriptor sets

We were over-allocating them by 4x.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Replace asserts with conditional that sets type_list = NULL
Rebecca Mckeever [Sat, 14 Jan 2023 04:35:00 +0000 (20:35 -0800)]
nvk: Replace asserts with conditional that sets type_list = NULL

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Update mutable descriptor struct type
Rebecca Mckeever [Fri, 13 Jan 2023 23:36:47 +0000 (15:36 -0800)]
nvk: Update mutable descriptor struct type

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: fix print inst for case MME_FERMI_OP_MERGE
Mauro Rossi [Sat, 14 Jan 2023 07:18:32 +0000 (08:18 +0100)]
nouveau/mme: fix print inst for case MME_FERMI_OP_MERGE

By applying the same coding style of the other case statements,
this patch fixes the following building errors:

../src/nouveau/mme/mme_fermi.c:209:10: error: expected expression
         uint32_t src_bit  = inst->bitfield.src_bit;
         ^
../src/nouveau/mme/mme_fermi.c:216:39: error: use of undeclared identifier 'src_bit'; did you mean 'dst_bit'?
         fprintf(fp, " (%u, %u, %u)", src_bit, size, dst_bit);
                                      ^~~~~~~
                                      dst_bit
../src/nouveau/mme/mme_fermi.c:211:19: note: 'dst_bit' declared here
         uint32_t dst_bit  = inst->bitfield.dst_bit;
                  ^
2 errors generated.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: use fermi enum in fermi builder
Thomas H.P. Andersen [Sat, 14 Jan 2023 17:27:35 +0000 (18:27 +0100)]
nouveau/mme: use fermi enum in fermi builder

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add a build test for MMEs
Faith Ekstrand [Tue, 31 Jan 2023 02:12:07 +0000 (20:12 -0600)]
nvk: Add a build test for MMEs

This simple test compiles all the MMEs for Turing and Volta to ensure
that they build and don't run out of registers.  We could, in theory, do
actual unit testing here with gtest but just building is enough to
ensure that no one breaks driver start-up on hardware they don't own.
They can still break the driver functionally, of course, but at least
it'll initialize.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agovulkan/meta: Use the new NIR texture helpers
Faith Ekstrand [Tue, 31 Jan 2023 02:12:07 +0000 (20:12 -0600)]
vulkan/meta: Use the new NIR texture helpers

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Implement Draw*Indirect on pre-Turing
Faith Ekstrand [Tue, 31 Jan 2023 02:12:07 +0000 (20:12 -0600)]
nvk: Implement Draw*Indirect on pre-Turing

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/push: Add an NV_PUSH_MAX_COUNT #define
Faith Ekstrand [Tue, 31 Jan 2023 02:12:07 +0000 (20:12 -0600)]
nouveau/push: Add an NV_PUSH_MAX_COUNT #define

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Reduce register pressure in nvk_mme_build_draw*()
Faith Ekstrand [Tue, 31 Jan 2023 02:12:07 +0000 (20:12 -0600)]
nvk: Reduce register pressure in nvk_mme_build_draw*()

Re-order things a bit so we deal with vertex offset and first instance
separately and free those regs when we're done.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Don't allow WaW dependencies in the same Turing instruction
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nouveau/mme: Don't allow WaW dependencies in the same Turing instruction

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Make some MME builder names more consistent
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nvk: Make some MME builder names more consistent

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Add a helper for pushing indirect data
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nvk: Add a helper for pushing indirect data

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk: Rework nvk_cmd_push a bit
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nvk: Rework nvk_cmd_push a bit

Instead of taking an nvk_cmd_bo take a nouveau_ws_bo and keep the map
pointer separate.  We'll need to do this when we start pushing stuff
that isn't nvk_cmd_bo.  Also, rework the bounds to be in bytes.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonvk/drm: Take a byte offset/range in push_add_push
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nvk/drm: Take a byte offset/range in push_add_push

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: nouveau/mme: Add builder tests for SLL and SRL
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nouveau/mme: nouveau/mme: Add builder tests for SLL and SRL

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Use a uint32_t for size in mme_fermi_bfe()
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nouveau/mme: Use a uint32_t for size in mme_fermi_bfe()

It will never be a non-fixed value.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Add builder tests for SUB
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nouveau/mme: Add builder tests for SUB

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Add some generic builder tests
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nouveau/mme: Add some generic builder tests

These don't need hardware and instead run entirely in the simulator.
The goal is to have something that we can run in CI and which ensures
consistency between the Turing and Fermi MMEs.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Unify some of the test framework
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nouveau/mme: Unify some of the test framework

Most of the actual nouveau device enumeration and test running framework
was copy+paste between the two.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

11 months agonouveau/mme: Take a const nv_device_info in mme_builder_init
Faith Ekstrand [Tue, 31 Jan 2023 02:12:06 +0000 (20:12 -0600)]
nouveau/mme: Take a const nv_device_info in mme_builder_init

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>