Gwenole Beauchesne [Fri, 4 Nov 2011 16:23:48 +0000 (17:23 +0100)]
test: rename H.264 encoding buffer structs with a Baseline suffix.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Austin Yuan [Thu, 2 Aug 2012 10:24:20 +0000 (18:24 +0800)]
va_trace.c: fix a wrong conditional check
Should check trace_fp_codedbuf instead of trace_fp_log because
we write to trace_fp_codedbuf
Signed-off-by: Austin Yuan <shengquan.yuan@intel.com>
Austin Yuan [Wed, 25 Apr 2012 06:17:03 +0000 (23:17 -0700)]
vatrace: VAEncXXXH264Baseline: start to drop VAEncXXXXBaseline
Signed-off-by: Austin Yuan <shengquan.yuan@intel.com>
Ermilov, Dmitry [Thu, 19 Apr 2012 00:50:34 +0000 (08:50 +0800)]
vatrace: trace H.264 encode parameters
Signed-off-by: Ermilov, Dmitry <dmitry.ermilov@intel.com>
Gwenole Beauchesne [Wed, 9 Nov 2011 10:08:28 +0000 (02:08 -0800)]
vatrace: API: drop H.264 specific VA buffer types.
VAEncH264VUIBufferType and VAEncH264SEIBufferType were never used
in any driver. Besides, they are codec-specific which is against
the generic buffer type policy. A new scheme will be developed.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Fri, 4 Nov 2011 16:23:48 +0000 (17:23 +0100)]
vatrace: API: rename H.264 encoding buffer structs with a Baseline suffix.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Xiang, Haihao [Wed, 6 Feb 2013 01:39:34 +0000 (09:39 +0800)]
Don't try to build the documentation if doxygen isn't found
Making all in doc
make[2]: Entering directory `/home/xhh/graphics/ex/vaapi/libva/doc'
enable_docs=no Doxyfile
/bin/bash: Doxyfile: command not found
make[2]: *** [html-out/index.html] Error 127
make[2]: Leaving directory `/home/xhh/graphics/ex/vaapi/libva/doc'
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Gwenole Beauchesne [Fri, 18 Nov 2011 12:49:32 +0000 (12:49 +0000)]
doc/vpp: link modules from the main page.
Gwenole Beauchesne [Fri, 18 Nov 2011 12:52:29 +0000 (12:52 +0000)]
doc/encode: link modules from the main page.
Gwenole Beauchesne [Fri, 4 Nov 2011 16:33:48 +0000 (17:33 +0100)]
doc: add placeholder for the Core API.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Tue, 3 Apr 2012 14:42:23 +0000 (16:42 +0200)]
API: bump version to 0.34.0 (libva 1.2.0).
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Xiang, Haihao [Fri, 10 May 2013 02:28:52 +0000 (10:28 +0800)]
va: Remove VAProcFilterColorStandard
Color primary conversion is an implicit operation for the pipeline,
surface_color_standard (input) and output_color_standard (output)
in VAProcPipelineParameterBuffer are used to indicate the color
primary conversion.
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Jonathan Bian [Mon, 1 Apr 2013 00:14:50 +0000 (17:14 -0700)]
Renamed de-interlacing flags to be more general and added new flag VA_DEINTERLACING_ONE_FIELD
Jonathan Bian [Wed, 9 Jan 2013 22:44:18 +0000 (14:44 -0800)]
Added "flags" field to VAProcFilterParameterBufferDeinterlacing to indicate TOP/BOTTOM field in the input frame and which field to use for BOB deinterlacing.
Binglin Chen [Wed, 8 Aug 2012 06:42:23 +0000 (14:42 +0800)]
Add maximum type number define, and one addition VPP flag
Add maximum type number define for VAEntryPoint,
VAConfigAttribTypeMax, VABufferTypeMax, which can be used as
the current total number of entrypoint/attribute/buffer type.
Add END of stream flag for VPP pipeline which indicates it's
the last frames in the pipeline.
Signed-off-by: Binglin Chen <binglin.chen@intel.com>
Austin Yuan [Thu, 1 Mar 2012 05:44:02 +0000 (21:44 -0800)]
VAProcPipelineParameterBufferType: start from 41 in case there are more encode buffer types to be added in future
Signed-off-by: Austin Yuan <shengquan.yuan@intel.com>
Gwenole Beauchesne [Tue, 3 Apr 2012 08:36:22 +0000 (10:36 +0200)]
API: vpp: remove extraneous flags member.
VAProcPipelineCaps contained an extra flags member which existed before
its split into pipeline_flags and filter_flags.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Xiang, Haihao [Tue, 21 Feb 2012 08:15:41 +0000 (16:15 +0800)]
Fix sample code for VPP
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Gwenole Beauchesne [Sun, 18 Dec 2011 17:04:24 +0000 (18:04 +0100)]
vpp: fix comments for *Count enumerations.
Gwenole Beauchesne [Sun, 18 Dec 2011 17:00:54 +0000 (18:00 +0100)]
vpp: allow input/output color primaries as requested.
XXX: this is still a complicated usage model. The color primary could
be a surface atttribute instead.
Gwenole Beauchesne [Sun, 18 Dec 2011 16:39:45 +0000 (17:39 +0100)]
vpp: move reference frames to pipeline parameter buffer.
Gwenole Beauchesne [Sun, 18 Dec 2011 16:24:50 +0000 (17:24 +0100)]
vpp: note that application of subpictures is now optional.
Gwenole Beauchesne [Sun, 18 Dec 2011 16:22:58 +0000 (17:22 +0100)]
vpp: add pipeline flags.
Gwenole Beauchesne [Sun, 18 Dec 2011 16:12:09 +0000 (17:12 +0100)]
vpp: explain filter flags more.
Gwenole Beauchesne [Sun, 18 Dec 2011 15:22:06 +0000 (16:22 +0100)]
vpp: add auto-saturation, auto-brightness, auto-contrast attributes.
Gwenole Beauchesne [Sun, 18 Dec 2011 15:06:32 +0000 (16:06 +0100)]
vpp: clarify background color semantics and driver behaviour.
Gwenole Beauchesne [Sun, 18 Dec 2011 14:56:30 +0000 (15:56 +0100)]
vpp: keep VAProcFilterParameterBuffer value type as float.
Gwenole Beauchesne [Sun, 18 Dec 2011 14:56:05 +0000 (15:56 +0100)]
vpp: fix vaQueryVideoProcPipelineCaps() semantics.
Gwenole Beauchesne [Mon, 28 Nov 2011 13:46:32 +0000 (13:46 +0000)]
vpp: mention that source surface also covers its associated subpictures.
Gwenole Beauchesne [Mon, 28 Nov 2011 13:38:33 +0000 (13:38 +0000)]
vpp: improve documentation for VAProcPipelineParameterBuffer.
Gwenole Beauchesne [Mon, 28 Nov 2011 12:36:10 +0000 (12:36 +0000)]
vpp: fix vaQueryVideoProcFilterCaps() prototype.
Gwenole Beauchesne [Thu, 24 Nov 2011 14:24:36 +0000 (14:24 +0000)]
vpp: remove obsolete sample code.
Gwenole Beauchesne [Thu, 24 Nov 2011 14:23:46 +0000 (14:23 +0000)]
vpp: fix VAProcPipelineParameterBuffer typedef.
Gwenole Beauchesne [Sun, 18 Dec 2011 17:44:49 +0000 (18:44 +0100)]
vpp: add video processing hooks.
Gwenole Beauchesne [Thu, 17 Nov 2011 19:08:15 +0000 (19:08 +0000)]
API: add video processing interfaces.
Xiang, Haihao [Fri, 10 May 2013 02:28:50 +0000 (10:28 +0800)]
va: Remove user_data from MPEG-2 encoding APIs
The application can insert a raw packed header if user data is needed
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Xiang, Haihao [Tue, 19 Jun 2012 01:07:03 +0000 (09:07 +0800)]
API for MPEG-2 encoding
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Xiang, Haihao [Fri, 10 May 2013 02:28:51 +0000 (10:28 +0800)]
va: Add a flag to signal APP whether the driver support raw packed header
Modify the comments for VAEncPackedHeaderRawData as well
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Xiang, Haihao [Thu, 16 Feb 2012 06:55:42 +0000 (14:55 +0800)]
install va_enc_h264.h
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Jonathan Bian [Wed, 29 Aug 2012 04:03:08 +0000 (21:03 -0700)]
Added baseline to the list of profiles for the documentation.
Jonathan Bian [Sat, 3 Mar 2012 00:29:41 +0000 (16:29 -0800)]
Added aspect ratio related fields to VAEncSequenceParameterBufferH264
Signed-off-by: Jonathan Bian <jonathan.bian@intel.com>
Gwenole Beauchesne [Thu, 24 Nov 2011 17:04:10 +0000 (17:04 +0000)]
API: h264 encode: add more explicit packed header types for H.264.
Gwenole Beauchesne [Thu, 24 Nov 2011 13:56:37 +0000 (13:56 +0000)]
API: h264 encode: move up num_macroblocks, next to macroblock_address.
Gwenole Beauchesne [Thu, 24 Nov 2011 13:51:10 +0000 (13:51 +0000)]
API: h264 encode: remove dec_ref_pic_marking().
Gwenole Beauchesne [Thu, 24 Nov 2011 13:49:39 +0000 (13:49 +0000)]
API: h264 encode: remove ref_pic_list_modification().
Gwenole Beauchesne [Thu, 24 Nov 2011 13:29:51 +0000 (13:29 +0000)]
API: h264 encode: fix comment for RefPicList0/1.
Gwenole Beauchesne [Thu, 24 Nov 2011 13:13:49 +0000 (13:13 +0000)]
API: h264 encode: add intra_idr_period to sequence parameter.
Gwenole Beauchesne [Tue, 15 Nov 2011 10:42:46 +0000 (10:42 +0000)]
API: h264 encode: document DPB usage.
Gwenole Beauchesne [Wed, 9 Nov 2011 10:23:51 +0000 (02:23 -0800)]
API: h264 encode: drop extraneous comment.
Gwenole Beauchesne [Wed, 9 Nov 2011 10:11:54 +0000 (02:11 -0800)]
API: h264 encode: drop profile_idc.
Jonathan Bian [Mon, 22 Oct 2012 04:49:51 +0000 (21:49 -0700)]
Added new VAEncPackedHeaderRawData value to VAEncPackedHeaderType
Austin Yuan [Wed, 25 Apr 2012 06:17:03 +0000 (23:17 -0700)]
VAEncXXXH264Baseline: start to drop VAEncXXXXBaseline
Signed-off-by: Austin Yuan <shengquan.yuan@intel.com>
Austin Yuan [Thu, 1 Mar 2012 06:48:42 +0000 (22:48 -0800)]
VACodedBufferSegment: correct the description
Signed-off-by: Austin Yuan <shengquan.yuan@intel.com>
Austin Yuan [Thu, 1 Mar 2012 05:41:40 +0000 (21:41 -0800)]
VA_STATUS_ERROR_HW_BUSY: error code to indicate HW is busy
Example: the harward only supports one way encode, but we
start two encode apps. This error code can return to app
Signed-off-by: Austin Yuan <shengquan.yuan@intel.com>
Austin Yuan [Thu, 1 Mar 2012 05:37:34 +0000 (21:37 -0800)]
VAEncMiscParameterRateControl: add back some fields and refine the comments
Signed-off-by: Austin Yuan <shengquan.yuan@intel.com>
Austin Yuan [Tue, 28 Feb 2012 00:46:16 +0000 (19:46 -0500)]
VACodedBufferSegment: modify the semantics/description
VACodedBufferSegment may contain more than one NALs, and flag
VA_CODED_BUF_STATUS_SINGLE_NALU will be used to singal the
segment only contain one NAL
Signed-off-by: Austin Yuan <shengquan.yuan@intel.com>
Xiang, Haihao [Thu, 16 Feb 2012 01:53:43 +0000 (09:53 +0800)]
Add VAEncMiscParameterHRD data structure to pass HRD parameters to driver
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Gwenole Beauchesne [Sun, 18 Dec 2011 18:13:43 +0000 (19:13 +0100)]
API: encode: document VACodedBufferSegment.
Make it clear that there shall be one VACodedBufferSegment per NAL unit.
It's up to the driver to calculate the various offsets to the NAL units.
Gwenole Beauchesne [Sun, 18 Dec 2011 18:03:25 +0000 (19:03 +0100)]
API: h264 encode: add VA_RC_VBR_CONSTRAINED.
Gwenole Beauchesne [Sun, 18 Dec 2011 18:00:45 +0000 (19:00 +0100)]
API: h264 encode: fix VAConfigAttribEncMaxRefFrames semantics.
Gwenole Beauchesne [Thu, 24 Nov 2011 16:50:42 +0000 (16:50 +0000)]
API: h264 encode: add packed SEI header.
Gwenole Beauchesne [Thu, 24 Nov 2011 13:57:41 +0000 (13:57 +0000)]
API: h264 encode: add macroblock-info config attribute.
Gwenole Beauchesne [Thu, 24 Nov 2011 13:08:39 +0000 (13:08 +0000)]
API: h264 encode: fix max-frame-size parameter buffer type.
Gwenole Beauchesne [Thu, 24 Nov 2011 13:04:19 +0000 (13:04 +0000)]
API: h264 encode: add max-frame-size misc buffer type.
Gwenole Beauchesne [Thu, 24 Nov 2011 12:29:06 +0000 (12:29 +0000)]
API: h264 encode: remove TABs in newly added code.
Gwenole Beauchesne [Thu, 24 Nov 2011 12:24:40 +0000 (12:24 +0000)]
API: h264 encode: add constant QP rate control attribute.
Gwenole Beauchesne [Thu, 24 Nov 2011 12:15:52 +0000 (12:15 +0000)]
API: h264 encode: fix comments.
Gwenole Beauchesne [Thu, 24 Nov 2011 12:14:27 +0000 (12:14 +0000)]
API: h264 encode: add new VA config attributes (max-slices, slice-structure).
Gwenole Beauchesne [Thu, 24 Nov 2011 10:53:19 +0000 (10:53 +0000)]
API: h264 encode: renumber config attributes used for encoding.
Gwenole Beauchesne [Thu, 24 Nov 2011 10:46:09 +0000 (10:46 +0000)]
API: h264 encode: improve VA config attributes documentation.
Gwenole Beauchesne [Tue, 15 Nov 2011 13:24:09 +0000 (13:24 +0000)]
API: h264 encode: add new config attributes for encoding (max-ref-frames).
Gwenole Beauchesne [Thu, 10 Nov 2011 17:23:54 +0000 (17:23 +0000)]
API: h264 encode: add macroblock parameter buffer.
Gwenole Beauchesne [Thu, 10 Nov 2011 17:06:19 +0000 (17:06 +0000)]
API: h264 encode: rename insert_emulation_bytes to has_emulation_bytes.
Gwenole Beauchesne [Wed, 9 Nov 2011 10:10:42 +0000 (02:10 -0800)]
API: h264 encode: re-define packed-headers buffer type ids.
Gwenole Beauchesne [Fri, 4 Nov 2011 16:25:20 +0000 (17:25 +0100)]
API: add new H.264 encoding API for main and high profiles.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Wed, 9 Nov 2011 10:08:28 +0000 (02:08 -0800)]
API: drop H.264 specific VA buffer types.
VAEncH264VUIBufferType and VAEncH264SEIBufferType were never used
in any driver. Besides, they are codec-specific which is against
the generic buffer type policy. A new scheme will be developed.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Fri, 4 Nov 2011 16:23:48 +0000 (17:23 +0100)]
API: rename H.264 encoding buffer structs with a Baseline suffix.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Tue, 15 Nov 2011 17:33:41 +0000 (17:33 +0000)]
API: add a generic value type.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Xiang, Haihao [Tue, 19 Mar 2013 04:55:25 +0000 (12:55 +0800)]
libva: bump version for development.
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Xiang, Haihao [Tue, 19 Mar 2013 01:42:21 +0000 (09:42 +0800)]
libva 1.1.1
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Armin K [Fri, 15 Mar 2013 17:13:55 +0000 (18:13 +0100)]
Automake 1.13 fixups
error: 'AM_CONFIG_HEADER': this macro is obsolete.
You should use the 'AC_CONFIG_HEADERS' macro instead.
warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
changed NO_CONFIGURE to NOCONFIGURE to be consistent with other packages
Damien Lespiau [Fri, 28 Sep 2012 14:33:11 +0000 (15:33 +0100)]
.gitignore: updates.
Add compile, m4 directory and putsurface_wayland test.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Rob Bradford [Fri, 2 Nov 2012 10:57:47 +0000 (10:57 +0000)]
wayland: port to 1.0 protocol.
With the change in protocol the hash of globals maintained by the client was
dropped. Instead we must setup a listener on the registry and get the globals
in a stream from that.
Signed-off-by: Rob Bradford <rob@linux.intel.com>
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Rob Bradford [Fri, 2 Nov 2012 11:39:33 +0000 (11:39 +0000)]
tests: fix printf in putsurface_wayland test
Signed-off-by: Rob Bradford <rob@linux.intel.com>
Gwenole Beauchesne [Thu, 4 Oct 2012 13:42:53 +0000 (15:42 +0200)]
libva: bump version for development.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Thu, 4 Oct 2012 13:10:37 +0000 (15:10 +0200)]
1.1.0.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Thu, 4 Oct 2012 13:28:07 +0000 (15:28 +0200)]
tests: fix build with alternate X11 paths.
If a program explicitly uses libfoo functions (libX11 for instance here),
then it shall be explicitly linked against that library. So, fix all
instances where X11 functions are called to include the right paths
to headers and libraries.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Wed, 3 Oct 2012 09:56:18 +0000 (11:56 +0200)]
debian: split libva packages based on the implemented API.
Align with OSVs (Ubuntu, Debian) for libva package names. i.e. split
the main libva1 package into Core (libva1) and as many packages as
there are backends enabled configure/dist time.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Wed, 3 Oct 2012 09:21:45 +0000 (11:21 +0200)]
debian: generate packing files from configure.
Use configure script substitution capabilities to handle Debian packaging
files, hence removing custom replacement functions at make dist time. This
also makes it possible to automatically generate the correct library major
version in package names.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Wed, 3 Oct 2012 08:58:53 +0000 (10:58 +0200)]
debian: drop references to obsolete libva 0.29.
Completely drop any reference the ancient libva 0.29. We don't care
of that any more, and people hardly used it distribution-wise.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Fri, 28 Sep 2012 14:10:59 +0000 (16:10 +0200)]
NEWS: updates.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Thu, 26 Jul 2012 14:26:37 +0000 (16:26 +0200)]
glx: fix gl_create_context() with parent context set.
If GLX window was created from a foreign Display, then that same Display shall
be used for subsequent glXMakeCurrent(). This means that gl_create_context()
will now use the same Display that the parent, if available.
This fixes cluttersink with the Intel GenX VA driver.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Fri, 28 Sep 2012 13:12:10 +0000 (15:12 +0200)]
dummy_drv_video: drop unused variables.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Fri, 28 Sep 2012 12:41:25 +0000 (14:41 +0200)]
dummy_drv_video: sanitize coding style of VA objects utilities.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Krzysztof Kotlenga [Wed, 19 Sep 2012 14:28:41 +0000 (16:28 +0200)]
dummy_drv_video: fix threading issues with VA objects.
Make base VA objects thread-safe. This is a straightforward port of
76ea06bab9c3e3ae9abb6150296504019d36fe7e from the VA intel-driver.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Xiang, Haihao [Mon, 26 Mar 2012 06:12:27 +0000 (14:12 +0800)]
dummy_drv_video: don't reallocate object heap, create new buckets instead.
When a heap needs to be expanded, don't reallocate the heap because objects
would be moved to a new address, while some threads would still rely on the
previous locations.
Initial patch from VA intel-driver and authored by Haihao Xiang.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Fri, 28 Sep 2012 09:03:53 +0000 (11:03 +0200)]
Drop VA/dummy backend.
This backend had no practical use but for bootstrapping/testing the
VA/Android backend.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Haitao Huang [Tue, 21 Aug 2012 18:26:28 +0000 (13:26 -0500)]
android: use common DRM driver detection code.
Change the driver used for android. Libva has to load the correct
driver and retain the vendor and device id's.
This change is to re-use common drm utils code for driver name
detection. Also removed non-android code in android specific files
and unneeded files in android directory.
Change-Id: I2893d8fcadfbf911e7c0b421a4e90d5aeb0d619e
Signed-off-by: Daniel Charles <daniel.charles@intel.com> (change driver)
Signed-off-by: Haitao Huang <haitao.huang@intel.com> (update using drm util)
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com> (add missing headers)
Haitao Huang [Tue, 21 Aug 2012 18:26:26 +0000 (13:26 -0500)]
android: fix tests for Android ICS.
Change-Id: I478063713883fbb5fb1fac372dbc418b19ff7d2b
Signed-off-by: Haitao Huang <haitao.huang@intel.com>
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Haitao Huang [Tue, 21 Aug 2012 18:26:27 +0000 (13:26 -0500)]
android: export JPEG decode header.
Change-Id: Ic9aec3c23a3c1b40a0147aec88cbe14627591562
Signed-off-by: Haitao Huang <haitao.huang@intel.com>
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com> (sort lines)