Karol Herbst [Sun, 18 Jun 2023 14:53:08 +0000 (16:53 +0200)]
rusticl/format: enable all trivial to support optional image formats
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Karol Herbst [Sun, 18 Jun 2023 16:14:24 +0000 (18:14 +0200)]
rusticl/format: move format table generation into a macro
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Karol Herbst [Sun, 18 Jun 2023 17:40:28 +0000 (19:40 +0200)]
rusticl/format: document cl to pipe format mapping
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Karol Herbst [Sun, 18 Jun 2023 13:01:19 +0000 (15:01 +0200)]
rusticl/format: add required format table for CL2.0
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Karol Herbst [Sun, 18 Jun 2023 12:41:11 +0000 (14:41 +0200)]
rusticl/format: drop req_for_3d_image_write_ext
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Karol Herbst [Sun, 18 Jun 2023 12:20:25 +0000 (14:20 +0200)]
rusticl/format: extract required format checks into const functions
Also dropping the 3D image write special case, because there is nothing in
the spec treating it differently.
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Karol Herbst [Sun, 18 Jun 2023 11:54:52 +0000 (13:54 +0200)]
rusticl/format: extract CL format to pipe format mapping into const function
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Karol Herbst [Sun, 18 Jun 2023 11:37:22 +0000 (13:37 +0200)]
rusticl/format: pass order and type to rusticl_image_format directly
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Karol Herbst [Sun, 18 Jun 2023 16:30:57 +0000 (18:30 +0200)]
rusticl/mem: fix validation of packed image formats
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Karol Herbst [Sun, 18 Jun 2023 15:21:27 +0000 (17:21 +0200)]
rusticl/mem: cache the pipe_format
This moves the expensive to_pipe_format call to image creation time.
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Karol Herbst [Mon, 19 Jun 2023 09:12:12 +0000 (11:12 +0200)]
docs/cl: improve reporting of image features
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23714>
Eric Engestrom [Mon, 19 Jun 2023 10:16:01 +0000 (11:16 +0100)]
Revert "ci: remove clang-format testing"
This reverts commit
d666a8d259a0bb0a14e5bf42e90f167e150f185b.
Let's move past that tantrum and hope we can have an adult conversation
if one person wants to go against all the other developers.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23719>
Eric Engestrom [Mon, 19 Jun 2023 10:19:33 +0000 (11:19 +0100)]
radv: fix formatting
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23719>
Illia Abernikhin [Thu, 8 Sep 2022 08:35:01 +0000 (11:35 +0300)]
docs: remove i965 features from docs/features.txt
Upgrade docs/features.txt
Signed-off-by: Illia Abernikhin <illia.abernikhin@globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4990
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17251>
Illia Abernikhin [Thu, 8 Sep 2022 08:28:07 +0000 (11:28 +0300)]
docs: add crocus features to docs/features.txt
Upgrade docs/features.txt with crocus extensions
Signed-off-by: Illia Abernikhin <illia.abernikhin@globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17251>
Illia Abernikhin [Tue, 6 Sep 2022 20:15:57 +0000 (23:15 +0300)]
docs: add iris features to docs/features.txt
Upgrade docs/features.txt with iris extensions
Signed-off-by: Illia Abernikhin <illia.abernikhin@globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17251>
Iago Toral Quiroga [Tue, 13 Jun 2023 08:40:07 +0000 (10:40 +0200)]
v3dv: expose shaderImageGatherExtended
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23616>
Iago Toral Quiroga [Tue, 13 Jun 2023 08:34:33 +0000 (10:34 +0200)]
broadcom/compiler: handle textureGatherOffsets
There is a lowering in NIR for this so we just need to enable it.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23616>
Iago Toral Quiroga [Thu, 15 Jun 2023 08:19:17 +0000 (10:19 +0200)]
nir/lower_tex: handle lower_tg4_offsets with lower_tg4_broadcom_swizzle
This pass uses a safe iterator so it can't lower new instructions that are
injected as part of the lowering, which is exactly what lower_tg4_offsets
does, and if lower_tg4_broadcom_swizzle is also set then we need to lower
these new instructions. Handle this by running the pass twice when both
are set: the first pass will only handle lower_tg4_offsets and
the second pass (which will see the new tg4 instructions produced with
lower_tg4_offsets) will process the remaining options, including
lower_tg4_broadcom_swizzle.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23616>
Iago Toral Quiroga [Tue, 13 Jun 2023 08:27:57 +0000 (10:27 +0200)]
nir/lower_tex: copy missing fields when creating copy of tex instruction
This is missing both texture and sampler indices.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23616>
Samuel Pitoiset [Thu, 15 Jun 2023 08:58:41 +0000 (10:58 +0200)]
radv: use cs_execute_ib() for GFX, MBCP and DGC IBs
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23671>
Samuel Pitoiset [Thu, 15 Jun 2023 08:58:33 +0000 (10:58 +0200)]
radv/amdgpu: add cs_execute_ib() for executing IBs
This will be used to implement support for DGC with RADV_DEBUG=noibs,
DGC for secondaries and for future work.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23671>
Samuel Pitoiset [Thu, 15 Jun 2023 08:03:44 +0000 (10:03 +0200)]
radv/amdgpu: remove useless assert in radv_amdgpu_winsys_cs_submit_internal()
The zero CS submission path is used instead, and this assertion isn't
really useful.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23669>
Samuel Pitoiset [Thu, 15 Jun 2023 08:00:57 +0000 (10:00 +0200)]
radv/amdgpu: fix a buffer overflow for submissions with RADV_DEBUG=noibs
With RADV_DEBUG=noibs (aka no chaining) the number of IBs to submit
depends on the number of old IB buffers of every CS.
This fixes a stack smashing error.
Fixes:
53b439d24fa ("radv/amdgpu: Use STACK_ARRAY for IB array to reduce stack usage."
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23669>
Samuel Pitoiset [Thu, 15 Jun 2023 09:34:09 +0000 (11:34 +0200)]
radv: reserve space for shadowed regs
Tested on RDNA2, hopefully the space reservation is large enough for
other chips as well.
Fixes:
7893040f807f ("radv: Add stricter space checks.")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23672>
Samuel Pitoiset [Thu, 15 Jun 2023 08:47:32 +0000 (10:47 +0200)]
radv: use IB for the GFX preamble on GFX6
GFX6 supports IBs without any issues.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23670>
Samuel Pitoiset [Thu, 15 Jun 2023 08:46:16 +0000 (10:46 +0200)]
radv: do not use IB for the GFX preamble with RADV_DEBUG=noibs
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23670>
David Heidelberg [Sun, 18 Jun 2023 18:09:25 +0000 (20:09 +0200)]
ci/docs: fixup incorrect spacing around console block
Fixes:
dcf5dfbbf8d3 ("ci: implement farms handling trough files inside .ci-farms")
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23713>
Gert Wollny [Sun, 18 Jun 2023 07:58:32 +0000 (09:58 +0200)]
r600/sfn: Don't deref unused group slots
Fixes:
e57643cf5 (r600/sfn: Add handling for R600 indirect access alias handling)
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9219
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23711>
Gert Wollny [Sun, 18 Jun 2023 07:11:30 +0000 (09:11 +0200)]
r600: Split tex CF only if written component is read
There is no need to split the CF if only the register ID
in a previous write is the same, we should look at the actual
slots instead, ut we have also to take writes of 0 and 1 into
account.
Cc: mesa-stable
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23710>
Marek Olšák [Sat, 17 Jun 2023 21:04:35 +0000 (17:04 -0400)]
intel/ci: disable iris-jsl-deqp because it always fails for an AMD MR
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sat, 17 Jun 2023 18:55:00 +0000 (14:55 -0400)]
ci: remove clang-format testing
The way it's used is unacceptable. Here's the change it suggested:
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index
05b9cb0a3f1..
e58abfa885f 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -783,8 +783,7 @@ radv_CreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCr
device->overallocation_disallowed = overallocation_disallowed;
mtx_init(&device->overallocation_mutex, mtx_plain);
- if (physical_device->rad_info.register_shadowing_required ||
- device->instance->debug_flags & RADV_DEBUG_SHADOW_REGS)
+ if (physical_device->rad_info.register_shadowing_required || device->instance->debug_flags & RADV_DEBUG_SHADOW_REGS)
device->uses_shadow_regs = true;
/* Create one context per queue priority. */
This is the dumbest reason to prevent merging a MR. I don't want to see this
in projects I work on.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Wed, 7 Jun 2023 19:48:46 +0000 (15:48 -0400)]
radeonsi: remove gfx10 NGG streamout
Unused and unstable. Keep it only for gfx11.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Tue, 6 Jun 2023 17:20:14 +0000 (13:20 -0400)]
radeonsi: handle GE_CNTL and IA_MULTI_VGT_PARAM as a tracked register
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Tue, 6 Jun 2023 16:55:26 +0000 (12:55 -0400)]
radeonsi: handle VGT_LS_HS_CONFIG like a tracker register
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Tue, 6 Jun 2023 16:40:20 +0000 (12:40 -0400)]
radeonsi: handle VGT_GS_OUT_PRIM_TYPE like a tracked register
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Mon, 5 Jun 2023 18:59:25 +0000 (14:59 -0400)]
radeonsi: eliminate redundant compute SH register changes
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sat, 3 Jun 2023 11:15:41 +0000 (07:15 -0400)]
radeonsi: handle demoted si_pm4_set_reg_idx3 as si_pm4_set_reg
to allow merging packets; otherwise no change in behavior
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sat, 3 Jun 2023 09:42:06 +0000 (05:42 -0400)]
radeonsi: set non-graphics uconfig registers first in the preamble
we want to keep all SH registers next to each other, so that we can use
only one SET_SH_REG_PAIRS_PACKED packet
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Fri, 2 Jun 2023 18:50:02 +0000 (14:50 -0400)]
radeonsi: remove sscreen parameter from si_pm4_set_reg_idx3
si_pm4_state now contains the screen.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Fri, 2 Jun 2023 18:48:12 +0000 (14:48 -0400)]
radeonsi: add more variables into si_pm4_state and rework how it's created
to be used later
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Wed, 7 Jun 2023 16:22:09 +0000 (12:22 -0400)]
radeonsi: don't needlessly invalidate L0/L1 caches at the beginning of IBs
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Mon, 5 Jun 2023 19:01:29 +0000 (15:01 -0400)]
radeonsi: don't do PFP_SYNC_ME before CP DMA and compute blits
It's not needed before them, and we already set it after them.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Thu, 8 Jun 2023 03:27:18 +0000 (23:27 -0400)]
radeonsi: shrink the last field of tcs_offchip_layout due to LDS limit
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Tue, 23 Aug 2022 23:23:09 +0000 (19:23 -0400)]
radeonsi: change si_emit_derived_tess_state into a state atom
This splits the state into an update function and an emit function
setting the registers, and only 2 functions update it: set_patch_vertices
and si_update_shaders.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Tue, 6 Jun 2023 18:23:02 +0000 (14:23 -0400)]
radeonsi: fix RB+ and gfx11 issues with framebuffer state
This fixes most gfx11 test failures.
Fixes:
9fecac091f31 - radeonsi/gfx11: scattered register deltas
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Mon, 5 Jun 2023 14:41:54 +0000 (10:41 -0400)]
radeonsi/ci: add glx@glx-visuals-stencil to skips because it gets stuck often
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sat, 10 Jun 2023 20:37:42 +0000 (16:37 -0400)]
radeonsi: set register_shadowing_enabled if AMD_DEBUG=shadowregs is set
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sun, 11 Jun 2023 05:16:33 +0000 (01:16 -0400)]
amd: skip redundant INDEX_TYPE even with register shadowing
same as PAL
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sun, 11 Jun 2023 05:16:33 +0000 (01:16 -0400)]
amd: skip redundant PKT3_NUM_INSTANCES even with register shadowing
same as PAL
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sun, 11 Jun 2023 01:02:58 +0000 (21:02 -0400)]
amd: update shadowed register tables for gfx11
The new table format is identical to the source to facilitate backporting.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sun, 11 Jun 2023 00:45:57 +0000 (20:45 -0400)]
amd: add a new helper that prints all non-shadowed regs
for validating our tables against register definitions
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sun, 11 Jun 2023 00:43:53 +0000 (20:43 -0400)]
amd: remove ac_check_shadowed_regs
not useful anymore
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sun, 11 Jun 2023 00:40:18 +0000 (20:40 -0400)]
amd: remove non-shadowed register tables
not useful
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sat, 10 Jun 2023 22:04:17 +0000 (18:04 -0400)]
amd: fix GPU cache sizes retrieved from the kernel
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Wed, 7 Jun 2023 14:50:56 +0000 (10:50 -0400)]
amd: don't set PA_RATE_CNTL because it has no effect
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Mon, 5 Jun 2023 17:51:10 +0000 (13:51 -0400)]
amd: increase the attribute ring size on gfx1103_r1
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Tue, 6 Jun 2023 17:22:50 +0000 (13:22 -0400)]
amd: rename mid_command_buffer_preemption_enabled -> register_shadowing_required
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Fri, 2 Jun 2023 18:33:10 +0000 (14:33 -0400)]
amd: improve the IB parser, parse more packets
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sat, 3 Jun 2023 07:04:50 +0000 (03:04 -0400)]
amd: update SET_*_REG_PAIRS* documentation and remove radeon_info options
All released firmware supports the packets.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Marek Olšák [Sat, 10 Jun 2023 18:49:42 +0000 (14:49 -0400)]
radeonsi: don't convert L8A8 to R8A8 when blitting via compute to fix gfx7
Fixes:
0482ff31588d5c - radeonsi: don't do image stores with RGBX, L, LA, I, and SRGB formats
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8707
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9176
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23687>
Karol Herbst [Sat, 17 Jun 2023 21:15:04 +0000 (23:15 +0200)]
rusticl: advertize cl_khr_spirv_no_integer_wrap_decoration
It's supported with all drivers already.
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23708>
Karol Herbst [Sat, 17 Jun 2023 21:13:52 +0000 (23:13 +0200)]
docs/cl: fix whitespace issues and add missing entries
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23708>
Karol Herbst [Sat, 17 Jun 2023 19:44:30 +0000 (21:44 +0200)]
rusticl: advertize cl_khr_extended_versioning
We already implemented the OpenCL 3.0 core bits, but the extension also
has a `CL_DEVICE_OPENCL_C_NUMERIC_VERSION_KHR` query.
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23707>
Karol Herbst [Sat, 17 Jun 2023 19:43:40 +0000 (21:43 +0200)]
rusticl/version: use cl_version instead of cl_uint and provide a From impl
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23707>
Karol Herbst [Sat, 17 Jun 2023 19:28:55 +0000 (21:28 +0200)]
rusticl/device: sort cl_device_info queries
Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Nora Allen <blackcatgames@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23707>
Karol Herbst [Fri, 16 Jun 2023 21:26:12 +0000 (23:26 +0200)]
rusticl/device: add intel usm queries DPCPP cares about
We don't implement them and we don't advertise the extension, but DPCPP
queries them regardless. We ultimately plan to implement the intel USM
extension. However until we do, just return 0 for those queries.
Signed-off-by: Karol Herbst <git@karolherbst.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23705>
Marek Olšák [Sun, 11 Jun 2023 05:10:09 +0000 (01:10 -0400)]
gallium/hud: append results to files instead of overwriting them
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23706>
Iván Briano [Thu, 15 Jun 2023 23:22:53 +0000 (16:22 -0700)]
anv: do not explode on 32 bit builds
Fixes:
930e862af7a ("anv: add shaders for copying query results")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9213
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23686>
David Heidelberg [Thu, 15 Jun 2023 08:49:40 +0000 (10:49 +0200)]
ci: implement farms handling trough files inside .ci-farms
- Disable farm with `git mv .ci-farm{,-disabled}/$farm_name`.
- Re-enable farm with `git mv .ci-farm{-disabled,}/$farm_name`.
NEVER MIX FARM MAINTENANCE WITH ANY OTHER CHANGE IN THE SAME MERGE REQUEST!
Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23629>
David Heidelberg [Wed, 14 Jun 2023 10:46:53 +0000 (12:46 +0200)]
ci/crocus: depend on state of the Anholt farm
Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23629>
David Heidelberg [Wed, 14 Jun 2023 10:42:10 +0000 (12:42 +0200)]
ci/amd: hide vaapi job dependent on Collabora farm when it's down
Fixes:
ae9c67d773a7 ("ci/amd: add radeonsi-raven-va-full job to cover all VA-API tests")
Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23629>
David Heidelberg [Tue, 13 Jun 2023 21:28:01 +0000 (23:28 +0200)]
ci/etnaviv: if farm is down, we expect no manual jobs can be triggered
Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23629>
David Heidelberg [Tue, 13 Jun 2023 21:06:59 +0000 (23:06 +0200)]
ci/windows: move microsoft farm rules
No functional changes intended, align with other farms.
Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Daniel Stone <daniels@collabora.com>
Acked-by: Jesse Natalie <jenatali@microsoft.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23629>
Charmaine Lee [Fri, 16 Jun 2023 01:45:16 +0000 (04:45 +0300)]
svga: lower images before ntt
ntt requires lowered images, so call gl_nir_lower_images first before
passing the shader to ntt.
Fixes piglit failures spec@glsl-4.30@execution@built-in-functions@cs*
Fixes:
0ac95418048 ("gallium: Drop PIPE_SHADER_CAP_PREFERRED_IR")
Reviewed-by: Neha Bhende <bhenden@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23697>
Thomas H.P. Andersen [Tue, 13 Jun 2023 19:08:09 +0000 (21:08 +0200)]
tgsi: remove unused functions and structs
These are no longer used and can be removed
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23637>
Eric Engestrom [Fri, 26 May 2023 11:56:20 +0000 (12:56 +0100)]
ci: enforce formatting for RADV & ACO
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23253>
Eric Engestrom [Fri, 26 May 2023 11:55:35 +0000 (12:55 +0100)]
aco: reformat according to its .clang-format
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23253>
Eric Engestrom [Fri, 26 May 2023 11:56:20 +0000 (12:56 +0100)]
radv: reformat according to its .clang-format
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23253>
Eric Engestrom [Fri, 26 May 2023 18:14:31 +0000 (19:14 +0100)]
radv,aco: tweaks to get clang-format to print nicer code
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23253>
Eric Engestrom [Fri, 2 Jun 2023 18:24:17 +0000 (19:24 +0100)]
clang-format: add explanation for anyone reading .clang-format-include
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23253>
Eric Engestrom [Fri, 15 Mar 2019 11:58:16 +0000 (11:58 +0000)]
egl: return correct error for EGL_KHR_image_pixmap
EGL_KHR_image_pixmap says:
> If <target> is EGL_NATIVE_PIXMAP_KHR, and <ctx> is not EGL_NO_CONTEXT,
> the error EGL_BAD_PARAMETER is generated.
Reported-by: Rohan Garg <rohan@garg.io>
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/166
Fixes:
a1c4a8a3c855d52fbfef "egl: Add support for EGL_KHR_image."
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/454>
Jianxun Zhang [Thu, 27 Oct 2022 20:20:06 +0000 (13:20 -0700)]
iris: Support MTL modifier MC_CCS
Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>
Jianxun Zhang [Thu, 27 Oct 2022 20:19:16 +0000 (13:19 -0700)]
intel/isl: Add MTL MC CCS modifier into modifier info
Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>
Jianxun Zhang [Tue, 18 Oct 2022 19:53:08 +0000 (12:53 -0700)]
iris: Support I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC modifier
Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>
Jianxun Zhang [Wed, 7 Dec 2022 20:22:25 +0000 (12:22 -0800)]
intel/isl: Add MTL RC CCS CC modifier into modifier info
Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>
Jianxun Zhang [Mon, 10 Oct 2022 18:08:40 +0000 (11:08 -0700)]
iris: Support I915_FORMAT_MOD_4_TILED_MTL_RC_CCS modifier
Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>
Jianxun Zhang [Mon, 10 Oct 2022 16:53:53 +0000 (09:53 -0700)]
intel/isl: Add MTL RC CCS modifier into modifier info
Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>
Jianxun Zhang [Mon, 12 Jun 2023 17:01:27 +0000 (10:01 -0700)]
include/uapi: Update drm_fourcc.h from drm kernel
From:
ba57b9b11f78530146f02b776854b2b6b6d344a4
Merge:
959294e47953 24335848e543
Author: Dave Airlie <airlied@redhat.com>
Date: Fri Jun 9 16:43:35 2023 +1000
Merge tag 'drm-intel-gt-next-2023-06-08' of
git://anongit.freedesktop.org/drm/drm-intel into drm-next
UAPI Changes:
- I915_GEM_CREATE_EXT_SET_PAT for Mesa on Meteorlake.
Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>
Jianxun Zhang [Mon, 12 Jun 2023 20:30:02 +0000 (20:30 +0000)]
iris: Fix memory alignment when importing dmabuf (GFX12.5)
Fix the failure in modifier tests on MTL:
../src/intel/common/intel_aux_map.c:609: intel_aux_map_add_mapping:
Assertion `(address & get_page_mask(main_page_size)) == 0' failed.
Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20327>
Yonggang Luo [Mon, 12 Jun 2023 05:58:00 +0000 (13:58 +0800)]
dri: Replace usage of boolean/TRUE/FALSE with bool/true/false
First do the find/replace in src/gallium/frontends/dri/ folder,
then fixes the compiling errors manually:
Because of this, the prototype of functions in include/GL/internal/dri_interface.h
are changed
Acked-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23582>
Konstantin Seurer [Thu, 15 Jun 2023 15:17:35 +0000 (17:17 +0200)]
radv/rt: Enable RT pipelines on GFX10_3+ excluding vangogh
Reviewed-by: Friedrich Vock <friedrich.vock@gmx.de>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23677>
Konstantin Seurer [Thu, 15 Jun 2023 15:15:25 +0000 (17:15 +0200)]
Revert "radv: Enable ray tracing pipelines by default"
This partially reverts commit
374bd4e1bef25ba2aeef6016ac35b41df07f3a99.
Reviewed-by: Friedrich Vock <friedrich.vock@gmx.de>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23677>
Friedrich Vock [Thu, 15 Jun 2023 16:48:18 +0000 (18:48 +0200)]
radv: Add the BOs of all shaders in a RT pipeline
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23681>
Georg Lehmann [Sat, 22 Apr 2023 11:40:58 +0000 (13:40 +0200)]
aco/opcodes: delete wrong comment copy pasted from NIR
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21882>
Georg Lehmann [Mon, 13 Mar 2023 19:05:26 +0000 (20:05 +0100)]
aco: remove v_cvt_pkrtz_f16_f32_e64 when it's actually VOP2
More consistent with how we handle all the opcodes which were moved to VOP3.
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21882>
Georg Lehmann [Mon, 13 Mar 2023 18:23:25 +0000 (19:23 +0100)]
aco/opcodes: move v_cndmask_b32 back to the VOP2 list
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21882>
Tony Wasserka [Wed, 21 Jul 2021 15:19:13 +0000 (17:19 +0200)]
aco/spill: Use arena allocator for spills
Gives a marginal speedup.
Co-authored-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12000>
Tony Wasserka [Tue, 20 Jul 2021 15:05:43 +0000 (17:05 +0200)]
aco/spill: Use arena allocator for next use distances
Speedup of aco::spill(): ~50%
Co-authored-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12000>
Karol Herbst [Sat, 5 Nov 2022 10:49:11 +0000 (11:49 +0100)]
nouveau: eliminate busy waiting on fences
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19543>
projects / platform / upstream / mesa.git / log