Steve MacLean [Wed, 28 Feb 2018 17:00:31 +0000 (12:00 -0500)]
Revise init-tools.sh to support bootstrapping
Add $DotNetBootstrapCliTarPath
Disable ILAsm nuget fetch while bootstrapping
Mike McLaughlin [Fri, 2 Mar 2018 17:54:31 +0000 (09:54 -0800)]
Fix !threads -special spurious error message (#16701)
Fix !threads -special spurious error message
Generate portable PDB for SOS.NETCore.
Fix issue #16665. Incorrect command names in messages on Linux.
dotnet-maestro-bot [Fri, 2 Mar 2018 16:40:09 +0000 (10:40 -0600)]
Update CoreClr to preview2-26302-06 (#16706)
Carol Eidt [Fri, 2 Mar 2018 14:41:05 +0000 (15:41 +0100)]
Merge pull request #16646 from fiigii/insertextract
Implement SSE4.1 Insert/Extract and simplify SSE/SSE2 intrinsic
Michal Strehovský [Fri, 2 Mar 2018 09:28:43 +0000 (10:28 +0100)]
Work around MCG bug around `ref char` marshalling (dotnet/corert#5481)
The change in the P/invoke signature that came from CoreCLR triggers a bug in MCG on the TFS side.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Egor Chesakov [Fri, 2 Mar 2018 06:06:19 +0000 (22:06 -0800)]
Merge pull request #16617 from echesakovMSFT/UseCodeTTypedefArm
[RyuJIT/ARM32]Use emitter::code_t typedef for ARM
Carol Eidt [Fri, 2 Mar 2018 06:03:45 +0000 (07:03 +0100)]
Merge pull request #16669 from tannergooding/hwintrin-sse2-maskmove
Implement the SSE2 MaskMove intrinsic
Anirudh Agnihotry [Fri, 2 Mar 2018 05:53:25 +0000 (21:53 -0800)]
Fixing GetFullPath (#16670)
dotnet-maestro-bot [Fri, 2 Mar 2018 04:27:00 +0000 (22:27 -0600)]
Update CoreClr, CoreFx to preview2-26302-01, preview2-26228-08, respectively (#16702)
Eric Erhardt [Fri, 2 Mar 2018 00:51:06 +0000 (18:51 -0600)]
Vectorize String.IndexOf(char) and String.LastIndexOf(char) (#16392)
* Vectorize String.IndexOf(char) using the same algorithm as SpanHelpers
IndexOf(byte).
* Respond to feedback.
* Vectorize String.LastIndexOf
Clean up IndexOf vectorization.
Tarek Mahmoud Sayed [Fri, 2 Mar 2018 00:36:39 +0000 (16:36 -0800)]
Fix Adar month name in Hebrew calendar (#16697)
The returned data from ICU has 6th month name as 'Adar I' and 7th month name as 'Adar'
We need to adjust that in the list used with non-leap year to have 6th month as 'Adar' and 7th month as 'Adar II'
note that when formatting non-leap year dates, 7th month shouldn't get used at all.
Brian Sullivan [Thu, 1 Mar 2018 23:39:12 +0000 (15:39 -0800)]
Merge pull request #16668 from briansull/simd-ins-opt
Refactor the signature of genGetSimdInsOpt to use emitAttr
Ben Adams [Wed, 20 Dec 2017 23:06:41 +0000 (23:06 +0000)]
1-base Dictionary buckets to reduce initalization
Ben Adams [Fri, 15 Dec 2017 22:07:42 +0000 (22:07 +0000)]
Use EqualityComparer<TKey>.Default Intrinsic
Ben Adams [Mon, 11 Dec 2017 06:09:03 +0000 (06:09 +0000)]
Improve Dictionary TryInsert CQ
Ben Adams [Mon, 11 Dec 2017 02:19:19 +0000 (02:19 +0000)]
Improve Dictionary FindEntry CQ
Stephen Toub [Thu, 1 Mar 2018 21:58:54 +0000 (16:58 -0500)]
Change several ValueTask properties to methods (#16691)
These do unsafe casts on an object, and we don't want a debugger's automatic evaluation accidentally invoking them. That means either making them methods or adding [DebuggerBrowsable(DebuggerBrowsableState.Never)], and the former seems cleaner.
Fei Peng [Thu, 1 Mar 2018 21:45:45 +0000 (13:45 -0800)]
Implement SSE4.1 insert and extract
Ahson Khan [Thu, 1 Mar 2018 21:18:37 +0000 (13:18 -0800)]
Move MemoryExtensions.TryGetString to MemoryMarshal and remove TryGetArray (#16692)
* Remove Span.NonGenerics and update leftover AsRoS -> AsSpan changes
* Move MemoryExtensions.TryGetString to MemoryMarshal and remove TryGetArray
* Move TryGetString to common MemoryMarshal.cs
* Remove the `this` keyword, not an extension method
Ahson Khan [Thu, 1 Mar 2018 20:23:01 +0000 (12:23 -0800)]
Remove Span.NonGenerics and update leftover AsRoS -> AsSpan changes (#16689)
Fei Peng [Wed, 28 Feb 2018 07:15:29 +0000 (23:15 -0800)]
Update 64-bit intrinsics and simplify SSE/SSE2 intrinsic
Egor Chesakov [Thu, 1 Mar 2018 19:27:55 +0000 (11:27 -0800)]
Merge pull request #16660 from echesakovMSFT/UseTarget64BitMacro
Use _TARGET_64BIT_ macro
Fei Peng [Wed, 28 Feb 2018 20:46:32 +0000 (12:46 -0800)]
Add tests and templates for insert/extract
Egor Chesakov [Fri, 9 Feb 2018 17:52:17 +0000 (09:52 -0800)]
Define emitter::code_t for _TARGET_ARM_ and use this type rather than ssize_t or size_t to hold encoded instructions in emitter
Tanner Gooding [Wed, 28 Feb 2018 08:36:49 +0000 (00:36 -0800)]
Adding tests for additional AVX hardware intrinsics
Tanner Gooding [Wed, 28 Feb 2018 08:35:36 +0000 (00:35 -0800)]
Adding support for additional AVX hardware intrinsics
Stephen Toub [Thu, 1 Mar 2018 13:59:32 +0000 (08:59 -0500)]
Adjust System.Threading.Tasks.Extensions for IValueTaskSource
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
mikedn [Thu, 1 Mar 2018 15:34:12 +0000 (17:34 +0200)]
Improve MemoryMarshal.Cast (#16659)
Avoid unnecessary checked and signed arithmetic. Handle special cases such as cast between same size types and from byte sized types, the JIT is unable to optimize these cases currently.
Jan Kotas [Thu, 1 Mar 2018 12:25:35 +0000 (04:25 -0800)]
Add back argument check for TypeForwardedFromAttribute (#16680)
Fixes dotnet/corefx#27554
Stephen Toub [Thu, 1 Mar 2018 04:18:35 +0000 (23:18 -0500)]
Fix build break in System.Memory due to incorrect XML comments
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Stephen Toub [Thu, 1 Mar 2018 11:14:38 +0000 (06:14 -0500)]
Merge pull request #16618 from stephentoub/valuetaskextensibility
Implement ValueTask extensibility
Jeremy Kuhne [Thu, 1 Mar 2018 06:30:31 +0000 (22:30 -0800)]
Remove span helpers, use mirrored PathInternal helper (#27585)
* Remove span helpers, use mirrored PathInternal helper
Remove other unnecessary helpers (notably with Path.Join available)
* Fix Unix
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Jeremy Kuhne [Thu, 1 Mar 2018 00:54:35 +0000 (16:54 -0800)]
Fix GetPathRoot issues (dotnet/corefx#27572)
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Mandar Sahasrabuddhe [Thu, 1 Mar 2018 06:30:07 +0000 (12:00 +0530)]
Edits to fix conflicts in generated Vector.cs file (#16666)
Fixed minor space changes and one syntax error that causes conflict between checked in Vector.cs file and the freshly auto-generated Vector.cs file.
Tanner Gooding [Wed, 28 Feb 2018 23:16:58 +0000 (15:16 -0800)]
Adding tests for the SSE2 MaskMove intrinsic
Tanner Gooding [Wed, 28 Feb 2018 23:16:45 +0000 (15:16 -0800)]
Implementing the SSE2 MaskMove intrinsic
Luqun Lou [Thu, 1 Mar 2018 06:26:00 +0000 (22:26 -0800)]
Release memory correctly during ComCallWrapperTemplate::Cleanup (#16671)
Fixes #15632
Egor Chesakov [Thu, 1 Mar 2018 06:25:16 +0000 (22:25 -0800)]
Remove ConvertILOnlyPE32ToPE64 and ConvertILOnlyPE32ToPE64Worker (#16676)
Stephen Toub [Thu, 1 Mar 2018 03:43:29 +0000 (22:43 -0500)]
Move IValueTaskSource and friends to System.Threading.Tasks.Sources
Group these more advanced types into a subnamespace.
Stephen Toub [Thu, 1 Mar 2018 03:25:02 +0000 (22:25 -0500)]
Add token to IValueTaskSource
Stephen Toub [Wed, 28 Feb 2018 05:53:03 +0000 (00:53 -0500)]
Implement ValueTask extensibility
This commit adds support for extending `ValueTask<T>` with arbitrary backing sources. Prior to this change, `ValueTask<T>` could wrap a `T` or a `Task<T>`; now it can also wrap an `IValueTaskSource<T>`, which can be implemented by arbitrary objects to be represented by `ValueTask<T>`. These objects can then be pooled and reused to minimize allocation. The commit also adds a non-generic `ValueTask` that can represent void-returning operations, including a `default` synchronous success, `Task`, and `IValueTaskSource`. For the non-generic `ValueTask`, the commit also includes awaiters and async method builders, so it can be both awaited and used as the return type of an async method.
The rest of the changes fall into a few buckets all related to enabling this support:
- Modifying `AsyncTaskMethodBuilder<TResult>.AwaitUnsafeOnCompleted` to specially recognize any `ValueTask` and utilize either the `Task` or `IValueTaskSource` that backs it to avoid allocating an Action MoveNext method. If every object awaited in an async method is either a `Task`/`Task<T>` or `ValueTask`/`ValueTask<T>`, regardless of what the `ValueTask`/`ValueTask<T>` wraps, we'll be able to avoid allocating the delegate and only allocate the single state machine object that also serves as the returned object.
- Changing `Stream.WriteAsync` to return `ValueTask` instead of `Task`. This enables interested overriding stream types to use a reusable/pooled object to avoid `WriteAsync` allocations.
- Modifying Stream.CopyToAsync to use the new `Memory`-based overloads of `ReadAsync` and `WriteAsync`. This enables the default `CopyToAsync` implementation to take advantage of any pooling done by derived streams, but even without pooling to take advantage of synchronously completing `ReadAsync`s returning `ValueTask<int>`s that contained an `int` rather than an allocated object. (While I was modifying this, I also removed some unnecessary array clearing that we'd added before later deciding it wasn't needed in general.)
- Modifying StreamReader/Writer to use the new `ReadAsync`/`WriteAsync` overloads.
Alfred Myers [Thu, 1 Mar 2018 03:55:33 +0000 (00:55 -0300)]
Minor documentation improvements (#16677)
Victor "Nate" Graf [Thu, 1 Mar 2018 02:03:12 +0000 (18:03 -0800)]
Create test for rundown events with EventPipe (#16667)
Egor Chesakov [Fri, 9 Feb 2018 20:51:30 +0000 (12:51 -0800)]
Replace sizeof(LPVOID)==4 with #ifdef _TARGET_64BIT_ in fieldmarshaler.cpp
Egor Chesakov [Thu, 1 Mar 2018 01:45:12 +0000 (17:45 -0800)]
Replace ambiguous _WIN64 and BIT64 with _TARGET_64BIT_ macro
Jan Kotas [Thu, 1 Mar 2018 01:28:30 +0000 (17:28 -0800)]
Delete unnecesary StackCrawlMarks (#16648)
CAS leftovers
dotnet-maestro-bot [Thu, 1 Mar 2018 00:51:16 +0000 (18:51 -0600)]
Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02528-07, preview2-26228-08, preview2-26228-03, master-
20180228-0037, respectively (#16661)
Brian Sullivan [Wed, 28 Feb 2018 22:45:23 +0000 (14:45 -0800)]
Refactor the signature of genGetSimdInsOpt to use emitAttr
Eliminates the use of bool is16Byte from the code base
Added my comments from the code review of PR #16565 to emitarm64.cpp
Brian Robbins [Wed, 28 Feb 2018 22:16:49 +0000 (14:16 -0800)]
Update EventSource* Tests for EventPipe (#16645)
Brian Sullivan [Wed, 28 Feb 2018 21:23:30 +0000 (13:23 -0800)]
Merge pull request #16657 from debayang/crypto_arm64_intrinsics
Crypto arm64 intrinsics
Tanner Gooding [Wed, 28 Feb 2018 04:40:19 +0000 (20:40 -0800)]
Set isInternalRegDelayFree for several of the x86 hwintrinsics
Bruce Forstall [Wed, 28 Feb 2018 18:45:04 +0000 (10:45 -0800)]
Merge pull request #16538 from sdmaclea/PR-ARM64-R2R_FAIL
[Arm64/Windows] Make r2r green in CI
Atsushi Kanamori [Wed, 28 Feb 2018 18:33:24 +0000 (10:33 -0800)]
Add the array/arraysegment->Span/Memory overloads to CoreCLR. (#16658)
Part of https://github.com/dotnet/corefx/issues/26894
Andy Ayers [Wed, 28 Feb 2018 18:08:32 +0000 (10:08 -0800)]
Revert: Simplify test dependencies for benchmarks (#16647)
This reverts commit
0598b6b8af0fb560837ce0bb8f3c8236c05bbdc9.
Updates to xunit console runner break things in Helix. So reverting
until we can get that part sorted.
Also undoes version updates from #16597; we can't move these forward
yet as we're back to netstandard 1.4 for the time being.
Egor Chesakov [Wed, 28 Feb 2018 17:56:18 +0000 (09:56 -0800)]
Merge pull request #16531 from echesakovMSFT/MakeTarget64BitMacroGlobal
Make _TARGET_64BIT_ macro global to coreclr
Debayan Ghosh [Wed, 28 Feb 2018 16:26:03 +0000 (21:56 +0530)]
ARM64 Crypto intrinsics tests for AES/SHA1/SHA256
Debayan Ghosh [Wed, 28 Feb 2018 16:21:38 +0000 (21:51 +0530)]
ARM64 SHA256 Crypto intrinsics implementation
Debayan Ghosh [Wed, 28 Feb 2018 16:00:45 +0000 (21:30 +0530)]
ARM64 SHA1 Crypto intrinsics implementation
Andy Ayers [Wed, 28 Feb 2018 15:23:16 +0000 (07:23 -0800)]
Mark MemoryMarshal.Cast methods for aggressive inlining (#16654)
Inlining doesn't streamline the cast logic any, but it facilitates
caller struct promotion which can substantially boost perf.
See discussion in dotnet/corefx#27485.
Jan Kotas [Wed, 28 Feb 2018 15:22:29 +0000 (07:22 -0800)]
Add Thread.GetCurrentProcessorId() API (#16650)
Contributes to https://github.com/dotnet/corefx/issues/16767
Tanner Gooding [Tue, 27 Feb 2018 15:45:35 +0000 (07:45 -0800)]
Adding some asserts that we won't overwrite one of the hwintrinsic operand registers.
Tanner Gooding [Sun, 25 Feb 2018 17:28:36 +0000 (09:28 -0800)]
Adding tests for the implemented SSE41 hardware intrinsics
Tanner Gooding [Sun, 25 Feb 2018 17:27:18 +0000 (09:27 -0800)]
Adding partial support for the SSE41 hardware intrinsics
Debayan Ghosh [Wed, 28 Feb 2018 14:11:49 +0000 (19:41 +0530)]
ARM64 Aes Crypto intrinsics implementation
Carol Eidt [Wed, 28 Feb 2018 08:59:44 +0000 (00:59 -0800)]
Merge pull request #16599 from fiigii/fixstaticcast
Fix generic hardware intrinsics with NotSupportedException
Fei Peng [Wed, 28 Feb 2018 06:18:06 +0000 (22:18 -0800)]
Fix StaticCast with NotSupportedException
Jeremy Kuhne [Wed, 28 Feb 2018 02:53:54 +0000 (18:53 -0800)]
Add Path.Join() methods. (#16561)
* Add Path.Join() methods.
See #25536.
* Address feedback and fix a couple issues now that I've got tests running correctly.
* Update per final API approval
* Fix Unix, remove redundant helper.
* Merge and tweak join methods in GetFullPath(string, string)
* Tweak again
Rex Morgan [Wed, 28 Feb 2018 02:53:11 +0000 (20:53 -0600)]
Fixing lambda capture unused errors. (#16555)
These errors were happening when compiling with clang 5.0.1.
Since the whole method is defined inside a #if DEBUG, it was
erroring when compiling in release mode because the lambda
variables were not being used.
Anirudh Agnihotry [Tue, 27 Feb 2018 20:04:53 +0000 (12:04 -0800)]
Tests For GetPathRoot and Enabling NormalizeDirectorySeparatorTests (#27494)
Corrects its Implementation too
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Jan Kotas [Wed, 28 Feb 2018 02:48:09 +0000 (18:48 -0800)]
Use the same default value of MarshalAs.IidParamIndex for both Windows and Unix (#16639)
Brian Sullivan [Wed, 28 Feb 2018 01:34:53 +0000 (17:34 -0800)]
Merge pull request #16637 from dotnet-bot/from-tfs
Merge changes from TFS
Brian Sullivan [Wed, 28 Feb 2018 00:11:23 +0000 (16:11 -0800)]
Minimal Fix for the incorrect rangecheck elimination issue reported by Mike Danes
RangeCheck::IsBinOpMonotonicallyIncreasing has a bug that results in incorrect range check elimination – when the second operand is a lclvar it does not check if it’s a positive value, it only checks if it’s monotonically increasing and any constant is treated as such.
[tfs-changeset: 1689890]
Anirudh Agnihotry [Tue, 27 Feb 2018 23:56:23 +0000 (15:56 -0800)]
Bug in GetFullPath(basePath, Path) (#16598)
* GetFullPath and GetRootLength Corrected
* Removed getpathroot
* using span
* "\\" changed to @"\"
Brian Sullivan [Tue, 27 Feb 2018 22:00:08 +0000 (14:00 -0800)]
Merge pull request #16533 from briansull/default-fill
Implement JitDefaultFill
Stephen Toub [Tue, 27 Feb 2018 21:43:32 +0000 (16:43 -0500)]
Change new ThreadPool.QueueUserWorkItem method to be generic (#16570)
Adam Sitnik [Tue, 27 Feb 2018 20:25:35 +0000 (21:25 +0100)]
Event pipe guid in metadata (#16316), fixes #16105
* some refactor to remove dumplicated code in tests and make them fit 1 screen
* write the failing test for no activity id
* use 17, the "free slot" of TypeCode enum to represent Guid in event pipe metadata
* remove the test which would not pass until new trace event is released and Event Pipe enabled for Windows
* added comment to TypeCode about using the value 17
* post code review fixes (thanks @justinvp)
* post code review fixes (thanks @brianrob)
* refactor the rest of event pipe tests to use NetPerfFile helper
Brian Sullivan [Fri, 23 Feb 2018 22:06:16 +0000 (14:06 -0800)]
Implement JitDefaultFill
- Changes and bugs fixes when changing the JitDefaultFill value from 0xff to 0xdd
- Implement randomized DefaultFill for stress
- Added comment header for compGetJitDefaultFill
- Changed C style comments to C++ comments
Jan Kotas [Tue, 27 Feb 2018 20:08:59 +0000 (12:08 -0800)]
Fix P1 test build break (#16631)
Sergey Andreenko [Tue, 27 Feb 2018 18:55:24 +0000 (10:55 -0800)]
add PHASE_COMPUTE_REACHABILITY (#16574)
crntn [Tue, 27 Feb 2018 18:42:56 +0000 (19:42 +0100)]
Debugger FIFO pipes are created in TMPDIR if defined #16234 (#16452)
Debugger FIFO pipes are created in TMPDIR if defined #16234
Init name to null termination to ensure failure if GetTempPathA fails
Ahson Khan [Tue, 27 Feb 2018 18:41:47 +0000 (10:41 -0800)]
Add MemoryExtensions to CoreLib along with necessary SpanHelpers (#16521)
* Add MemoryExtensions to CoreLib along with necessary SpanHelpers
* Make the newly added AsSpan/AsMemory into array extension methods.
* Remove StringSpanHelpers.Trim
* Leftover AsReadOnlySpan -> AsSpan for *Unix.cs files
* Address PR feedback.
* Remove duplicate methods in the Span class.
* Temporarily disable AsBytes SpanBench test.
* Add back AsBytes
* Re-enable AsBytes SpanBench test
Egor Chesakov [Tue, 27 Feb 2018 18:37:48 +0000 (10:37 -0800)]
Merge pull request #16514 from echesakovMSFT/UseTargetPointerSizeMacro
Replace sizeof(void*)-like expressions with TARGET_POINTER_SIZE macro
Jan Kotas [Tue, 27 Feb 2018 14:41:45 +0000 (06:41 -0800)]
Delete left-over globalization CoreCLR tests (#16571)
Sung Yoon Whang [Tue, 27 Feb 2018 11:56:54 +0000 (03:56 -0800)]
Add test for GC.GetAllocatedBytesForCurrentThread (#16428)
* Add test for GC.GetAllocatedBytesForCurrentThread
* modified test to fit coreclr test runner
* add testing with/without gc.collect()
* Address object size difference on x86 machines
Sung Yoon Whang [Tue, 27 Feb 2018 04:10:44 +0000 (20:10 -0800)]
Re-attempt fixing case in GC reliability/stress night config (#16607)
* Address more config case error
Fei Peng [Mon, 26 Feb 2018 21:02:12 +0000 (13:02 -0800)]
Update the table-driven framework to support x86 imm-intrinsics.
And add a new range-check IR for x86 imm-intrinsics.
Fei Peng [Thu, 22 Feb 2018 08:34:20 +0000 (00:34 -0800)]
Add tests/templates for AVX2/SSE2 shift intrinsics
Fei Peng [Tue, 13 Feb 2018 08:50:06 +0000 (00:50 -0800)]
Add tests ShiftLeft/RightLogicalVariable
Fei Peng [Thu, 8 Feb 2018 03:30:16 +0000 (19:30 -0800)]
Add AVX.Compare/CompareScalar tests
Fei Peng [Wed, 7 Feb 2018 19:24:46 +0000 (11:24 -0800)]
Add Avx.SetZeroVector256<T> tests
Brian Robbins [Tue, 27 Feb 2018 02:01:00 +0000 (18:01 -0800)]
Upgrade TraceEvent and XUnit-Performance to the latest versions. (#16597)
Ben Adams [Tue, 27 Feb 2018 01:23:56 +0000 (01:23 +0000)]
Fix ascii range check (#16535)
Sung Yoon Whang [Tue, 27 Feb 2018 00:36:27 +0000 (16:36 -0800)]
Fix for incorrect case in GC reliability/stress night config (#16595)
* Fix case for Concurrentspin2.exe
Victor "Nate" Graf [Tue, 27 Feb 2018 00:19:28 +0000 (16:19 -0800)]
Fix SoDBench by retargeting ASP Net feed (#16596)
Update aspnetcore feed
Egor Chesakov [Fri, 23 Feb 2018 20:35:29 +0000 (12:35 -0800)]
Define _TARGET_64BIT_ macro if not defined when _TARGET_AMD64_ or _TARGET_ARM64_ in src/jit/jit.h
Stephen Toub [Mon, 26 Feb 2018 23:45:41 +0000 (18:45 -0500)]
Avoid async method caching of a 0 decimal task (#16588)
Egor Chesakov [Fri, 9 Feb 2018 18:18:50 +0000 (10:18 -0800)]
Replace sizeof(void*)-like expressions with TARGET_POINTER_SIZE macro
Mike McLaughlin [Mon, 26 Feb 2018 23:19:00 +0000 (15:19 -0800)]
Fixed mixed mode attach/JIT debugging. (#16552)
Fixed mixed mode attach/JIT debugging.
The mixed mode debugging attach uses TLS slot to communicate between debugger break-in thread and the right side. Unfortunately, the __thread static variables cannot be used on debugger breakin
thread because of it does not have storage allocated for them.
The fix is to switch the storage for debugger word to classic TlsAlloc allocated slot that works
fine on debugger break-in thread.
There was also problem (that is also in 2.0) where the WINNT_OFFSETOF__TEB__ThreadLocalStoragePointer was using the define for 64/32 bit and ended up always the 32 bit Windows value. This caused the right side GetEEThreadValue, GetEETlsDataBlock unmanaged thread functions to always fail.
Bruce Forstall [Mon, 26 Feb 2018 21:12:42 +0000 (13:12 -0800)]
Merge pull request #16591 from BruceForstall/FixArmTestExclusions
Fix arm32/arm64 test exclusions
Bruce Forstall [Mon, 26 Feb 2018 20:16:11 +0000 (12:16 -0800)]
Fix arm32/arm64 test exclusions
Use the table of smarty exclusion tags in validArmWindowsScenarios
to drive what tests should be excluded.
Update the exclude table to add `R2R_EXCLUDE` (for consistency),
and tag R2R MinOpts and GCStress jobs appropriately.
Also, run Pri-1 tests for all runs except the 'innerloop' scenario.