Fumitoshi Ukai [Wed, 10 May 2017 03:51:39 +0000 (12:51 +0900)]
Merge pull request #186 from shinh/backport
Backport internal changes
Shinichiro Hamaji [Tue, 9 May 2017 08:35:18 +0000 (17:35 +0900)]
Add a hack for naive include scanners
Shinichiro Hamaji [Tue, 9 May 2017 08:22:38 +0000 (17:22 +0900)]
Define OS_LINUX only if it's not defined yet
Shinichiro Hamaji [Tue, 9 May 2017 08:21:16 +0000 (17:21 +0900)]
symbolize: Allow 4kB stack consumption on PPC64
Shinichiro Hamaji [Tue, 9 May 2017 08:11:51 +0000 (17:11 +0900)]
x86 stacktrace: Use __builtin_frame_address if possible
Shinichiro Hamaji [Tue, 9 May 2017 08:05:55 +0000 (17:05 +0900)]
Relax test for symbolize
Don't rely on an internal-linkage extern "C" function having an
unmangled name. This isn't required by the ABI, and in fact is not
valid for a conforming compiler(!). Instead, allow symbolization to
produce either a mangled or an unmangled name here.
Shinichiro Hamaji [Tue, 9 May 2017 08:01:07 +0000 (17:01 +0900)]
Use LOG(FATAL) instead of CHECK(false)
Shinichiro Hamaji [Tue, 9 May 2017 07:41:58 +0000 (16:41 +0900)]
Run src/windows/preprocess.sh
Shinichiro Hamaji [Tue, 9 May 2017 07:24:50 +0000 (16:24 +0900)]
glog: release 0.3.5
Fumitoshi Ukai [Fri, 21 Apr 2017 00:54:53 +0000 (09:54 +0900)]
Merge pull request #179 from renning22/master
CHECK_NOTNULL works with smart pointers when compiled in C++11.
Ning Ren [Thu, 20 Apr 2017 22:30:42 +0000 (15:30 -0700)]
CHECK_NOTNULL works with smart pointers when compiled in C++11.
Fumitoshi Ukai [Tue, 7 Mar 2017 03:44:37 +0000 (12:44 +0900)]
Merge pull request #169 from mayah/windows-no-return
Add __declspec(noreturn) on Win
mayah [Tue, 7 Mar 2017 02:22:24 +0000 (11:22 +0900)]
Add __declspec(noreturn) on Win
Currently cl.exe doesn't know LOG(FATAL) exits the program. Set
__declspec(noreturn).
Fumitoshi Ukai [Thu, 9 Feb 2017 02:04:00 +0000 (11:04 +0900)]
Merge pull request #164 from yoshisatoyanagisawa/dcheck_always_on
DCHECK_ALWAYS_ON to make D* enabled under NDEBUG
Yoshisato Yanagisawa [Tue, 7 Feb 2017 06:47:51 +0000 (15:47 +0900)]
DCHECK_ALWAYS_ON to make D* enabled under NDEBUG
The macro NDEBUG could be automatically defined for release build on
some build environments (e.g. MSVC). If we use NDEBUG as a key to
distinguish using DCHECK as CHECK (I call this DCHECK is enabled) or
not, we cannot make DCHECK enabled for release build on such
environments.
Considering people use a program with glog for presubmit testing or
dogfooding, they should need to do release build with DCHECK enabled.
Fumitoshi Ukai [Thu, 20 Oct 2016 06:52:27 +0000 (15:52 +0900)]
Update github.com/sergiud in AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Wed, 19 Oct 2016 07:40:55 +0000 (16:40 +0900)]
Merge pull request #132 from sergiud/cmake-disable-unittests
cmake: allow to disable building unit tests
Sergiu Deitsch [Wed, 19 Oct 2016 07:28:19 +0000 (09:28 +0200)]
cmake: allow to disable building unit tests
This commit introduces a CMake `BUILD_TESTING` boolean option that
allows to disable unit tests. This is especially useful in superbuilds
where typically only the main library is built. By default, this option
is enabled.
Fumitoshi Ukai [Wed, 19 Oct 2016 07:29:34 +0000 (16:29 +0900)]
Merge pull request #127 from MinGW-caffe/master
try to avoid the error "conflicting declaration 'typedef DWORD pthread_t'" etc. in MinGW
Fumitoshi Ukai [Wed, 19 Oct 2016 07:28:53 +0000 (16:28 +0900)]
Add MiniLight to AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Wed, 19 Oct 2016 07:10:39 +0000 (16:10 +0900)]
Merge pull request #123 from yying/master
Set sinks_ to NULL after deletion in LogDestination::DeleteLogDestinations
Fumitoshi Ukai [Wed, 19 Oct 2016 07:09:41 +0000 (16:09 +0900)]
Add Andy Ying to AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Wed, 19 Oct 2016 07:06:38 +0000 (16:06 +0900)]
Merge pull request #116 from pcc/fix2
Fix autotools build.
Fumitoshi Ukai [Wed, 19 Oct 2016 07:02:49 +0000 (16:02 +0900)]
Merge pull request #98 from willyd/relocatable
Added $<BUILD_INTERFACE> to gflags include directory
Fumitoshi Ukai [Wed, 19 Oct 2016 06:59:24 +0000 (15:59 +0900)]
Add Guillaume Dumont to AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Wed, 19 Oct 2016 06:52:32 +0000 (15:52 +0900)]
Merge pull request #129 from sergiud/cmake-PIC
cmake: enable position independent code (PIC)
Fumitoshi Ukai [Wed, 19 Oct 2016 06:51:45 +0000 (15:51 +0900)]
Merge pull request #130 from sergiud/cmake-warning-fix
cmake: fixed clang warning propagation to gcc
Sergiu Deitsch [Fri, 7 Oct 2016 09:03:19 +0000 (11:03 +0200)]
cmake: fixed clang warning propagation to gcc
Sergiu Deitsch [Fri, 7 Oct 2016 08:54:14 +0000 (10:54 +0200)]
cmake: enable position independent code (PIC)
MiniLight [Sun, 2 Oct 2016 16:38:15 +0000 (00:38 +0800)]
try to avoid the error "conflicting declaration 'typedef DWORD
pthread_t'" etc.
Andy Ying [Sun, 11 Sep 2016 05:16:32 +0000 (01:16 -0400)]
NULL sinks_ after deletion to prevent dangling pointer
Fumitoshi Ukai [Thu, 14 Jul 2016 01:47:13 +0000 (10:47 +0900)]
Add Peter Collingbourne <pcc@google.com> to CONTRIBUTORS
Fumitoshi Ukai [Thu, 14 Jul 2016 01:44:18 +0000 (10:44 +0900)]
Merge pull request #115 from pcc/fix1
symbolize: Calculate a module's zero VA using program headers.
Peter Collingbourne [Thu, 23 Jun 2016 01:34:48 +0000 (18:34 -0700)]
Fix autotools build.
It looks like commit 3c49b93 modified the auto-generated file src/config.h.in
to add a definition of macro GOOGLE_GLOG_DLL_DECL. One of the autotools
reverts this change upon running "make", causing the build to fail when a
source file includes demangle.h.
To fix the problem, revert the change to src/config.h.in and include
glog/logging.h from demangle.h which provides a definition of that macro.
Peter Collingbourne [Thu, 23 Jun 2016 01:18:06 +0000 (18:18 -0700)]
symbolize: Calculate a module's zero VA using program headers.
Previously we were using a module's "start address", i.e. the
address at which the module's executable region was mapped, as the
zero virtual address, i.e. the address from which the DSO's virtual
addresses are calculated. This works fine for DSOs created by the
bfd and gold linkers, which will emit a PT_LOAD directive into the
program header which loads the executable region at virtual address
(p_vaddr) and file offset (p_offset) 0.
However, the lld linker may place a read-only region before the
executable region, meaning that both p_vaddr and p_offset for the
executable region are non-zero. This means that any symbols resolved
by the symbolizer are resolved to an incorrect virtual address. To
correctly calculate the address corresponding to virtual address zero,
we need to take into account p_vaddr and p_offset.
Specifically, the calculation starts with the "base address", i.e. the
start address minus the file offset. To get from the base address to
virtual address zero, we first add p_offset. This gives us the mapped
address of the start of the segment, or in other words the mapped
address corresponding to the virtual address of the segment. (Note
that this is distinct from the start address, as p_offset is not
guaranteed to be page aligned.) We then subtract p_vaddr, which takes
us to virtual address zero.
Fumitoshi Ukai [Fri, 15 Apr 2016 08:05:30 +0000 (17:05 +0900)]
Merge pull request #101 from yasushi-saito/master
Allow permission line in /proc/self/map to be "rwx", not just "r-x".
Fumitoshi Ukai [Wed, 13 Apr 2016 05:00:49 +0000 (14:00 +0900)]
Merge pull request #91 from abdasgupta/master
Added support for PowerPC.
Fumitoshi Ukai [Wed, 13 Apr 2016 04:59:08 +0000 (13:59 +0900)]
Merge pull request #82 from sergiud/cmake-imported-target
Better support and documentation for CMake projects that consume glog
Yaz Saito on W541 [Mon, 11 Apr 2016 21:35:42 +0000 (14:35 -0700)]
Allow permission line in /proc/self/map to be "rwx", not just "r-x". At
least in Ubuntu14, a binary file that's writable by the process owner
has permission "rwx", not "r-x".
Guillaume Dumont [Tue, 5 Apr 2016 18:02:42 +0000 (14:02 -0400)]
Added $<BUILD_INTERFACE> to gflags include to avoid including the gflags include dir in the glog-targets.cmake
Fumitoshi Ukai [Thu, 31 Mar 2016 08:50:09 +0000 (17:50 +0900)]
Merge pull request #96 from mayah/update-windows
Update src/windows/glog/logging.h to ToT
mayah [Thu, 31 Mar 2016 08:29:36 +0000 (17:29 +0900)]
Run src/windows/preprocess.sh
src/windows/glog/logging.h is not generated by the current source.
Let me run src/windows/preprocess.sh and update the source.
Abhishek Dasgupta [Wed, 16 Mar 2016 09:28:18 +0000 (05:28 -0400)]
Added support for PowerPC.
Sergiu Dotenco [Fri, 8 Jan 2016 14:21:24 +0000 (15:21 +0100)]
added CMake usage instructions
Sergiu Dotenco [Fri, 8 Jan 2016 13:55:58 +0000 (14:55 +0100)]
cmake: allow to refer to imported glog target as glog::glog
Fumitoshi Ukai [Thu, 17 Dec 2015 07:31:55 +0000 (16:31 +0900)]
use namespace GFLAGS_NAMESPACE instead namespace gflags
only signalhandler_unittest.cc uses "using namespace gflags".
others use "using namespace GFLAGS_NAMESPACE", so
signalhandler_unittest.cc does the same way.
fixes #62
Fumitoshi Ukai [Thu, 17 Dec 2015 06:40:25 +0000 (15:40 +0900)]
win: use _fdopen instead of fdopen
The POSIX function fdopen is deprecated.
Use the ISO C++ conformant _fdopen instead.
https://msdn.microsoft.com/library/ms235351.aspx
fixes #73
Fumitoshi Ukai [Thu, 17 Dec 2015 06:36:40 +0000 (15:36 +0900)]
win: FAILED macro can't be used with HANDLE.
FAILED macro is for HRESULT, not for HANDLE.
FindFirstFile returns INVALID_HANDLE_VALUE when error or not found.
https://msdn.microsoft.com/library/windows/desktop/
aa364418(v=vs.85).aspx
fixes #79
Fumitoshi Ukai [Thu, 17 Dec 2015 06:26:15 +0000 (15:26 +0900)]
avoid calling new/malloc in signalhandler.
FlushLogFilesUnsafe would be called in FailureSignalHandler,
so should avoid calling new/malloc, which are not signal safe.
fixes #78
Fumitoshi Ukai [Fri, 27 Nov 2015 04:18:55 +0000 (13:18 +0900)]
Merge pull request #74 from yoshisatoyanagisawa/fix_sigabrt_action
Reset SIGABRT action only if FailureSignalHandler is installed.
Yoshisato Yanagisawa [Wed, 18 Nov 2015 06:40:12 +0000 (15:40 +0900)]
Reset SIGABRT action only if FailureSignalHandler is installed.
When I set my own signal handler to SIGABRT, it did not executed
with CHECK. That is because SIGABRT handler is reset to default
just before glog calls abort.
Let me make it reset only if the handler is what glog installed
i.e. FailureSignalHandler.
Fumitoshi Ukai [Tue, 10 Nov 2015 08:11:29 +0000 (17:11 +0900)]
Merge pull request #58 from ruslo/fix.include
Fix missing public include directory
Fumitoshi Ukai [Tue, 10 Nov 2015 08:10:29 +0000 (17:10 +0900)]
Merge pull request #56 from rhencke/fix-test
Fix double-free in unit test on Windows.
Fumitoshi Ukai [Tue, 10 Nov 2015 08:05:10 +0000 (17:05 +0900)]
Merge pull request #51 from flandr/pthread-cmake-build
Link libpthread when necessary in CMake builds
Ruslan Baratov [Tue, 8 Sep 2015 21:33:31 +0000 (00:33 +0300)]
Fix missing public include directory
Path "<prefix>/include" will not be added to the headers search of dependent
targets without specifying INSTALL_INTERFACE, i.e. compilation
will fail with error:
"fatal error: 'glog/logging.h' file not found".
Nate Rosenblum [Sun, 6 Sep 2015 15:09:29 +0000 (08:09 -0700)]
Add pthread library to linker list when needed
Robert Hencke [Sun, 6 Sep 2015 13:53:22 +0000 (09:53 -0400)]
Fix double-free in unit test on Windows.
The LOG_SYSRESULT refers to result twice. Since, in this test,
result expands to FindClose(handle), the handle was being freed twice.
Fumitoshi Ukai [Wed, 12 Aug 2015 07:10:40 +0000 (16:10 +0900)]
Merge pull request #49 from sergiud/cmake-visibility
Fixed warning caused by policy CMP0063 introduced in CMake 3.3
Fumitoshi Ukai [Wed, 12 Aug 2015 07:09:02 +0000 (16:09 +0900)]
Merge pull request #47 from sergiud/master
Allow to disable multithreading support using CMake
Fumitoshi Ukai [Wed, 12 Aug 2015 07:06:34 +0000 (16:06 +0900)]
Add Teddy Reed to AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Wed, 12 Aug 2015 07:05:28 +0000 (16:05 +0900)]
Merge pull request #26 from theopolis/feature-mode-flag
[#23] Add logfile_mode to control logfile permissions
Sergiu Dotenco [Tue, 11 Aug 2015 16:56:28 +0000 (18:56 +0200)]
cmake: fixed warning caused by policy CMP0063
Teddy Reed [Wed, 13 May 2015 06:22:24 +0000 (23:22 -0700)]
[#23] Add logfile_mode to control logfile permissions
Sergiu Dotenco [Sat, 8 Aug 2015 17:07:07 +0000 (19:07 +0200)]
cmake: allow to disable multithreading support
This commit additionally enables threading for win32 by default.
Fumitoshi Ukai [Thu, 6 Aug 2015 08:17:55 +0000 (17:17 +0900)]
Merge pull request #35 from bsilver8192/fix-mocklog-unused-arguments
Fix mocklog unused arguments
Fumitoshi Ukai [Thu, 6 Aug 2015 08:15:44 +0000 (17:15 +0900)]
Merge pull request #34 from bsilver8192/fix-macro-redefinition
Fix redefinition of _XOPEN_SOURCE.
Fumitoshi Ukai [Thu, 6 Aug 2015 08:10:21 +0000 (17:10 +0900)]
Add tomange to AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Thu, 6 Aug 2015 08:09:02 +0000 (17:09 +0900)]
Merge pull request #20 from UbimoLTD/patch-1
Don't call RAW_VLOG with locking vmodule_lock
SetVLOGLevel locks vmodule_lock however RAW_VLOG at the end also implicitly locks it via InitVLOG3__.
This causes deadlock/segfault.
fixes #29
Fumitoshi Ukai [Thu, 6 Aug 2015 07:57:51 +0000 (16:57 +0900)]
Merge pull request #12 from ukai/fix_leak
delete LogDestination::sinks_ at DeleteLogDestinations().
fixes #8
Fumitoshi Ukai [Thu, 6 Aug 2015 07:55:37 +0000 (16:55 +0900)]
Add Sergiu Dotenco to AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Thu, 6 Aug 2015 07:53:55 +0000 (16:53 +0900)]
Merge pull request #7 from sergiud/master
Add CMake support. closes #4
Fumitoshi Ukai [Thu, 6 Aug 2015 07:45:44 +0000 (16:45 +0900)]
Add Michael Tanner and tbennun to AUTORS/CONTRIBUTORS
Sergiu Dotenco [Tue, 21 Apr 2015 14:11:25 +0000 (16:11 +0200)]
cmake: link to libunwind
Sergiu Dotenco [Mon, 20 Apr 2015 20:51:42 +0000 (22:51 +0200)]
cmake: support gflags in static builds
Sergiu Dotenco [Fri, 27 Mar 2015 17:12:24 +0000 (18:12 +0100)]
cmake: disabled 'template argument uses unnamed type' warning
Sergiu Dotenco [Thu, 26 Mar 2015 14:57:21 +0000 (15:57 +0100)]
added missing include
Sergiu Dotenco [Thu, 26 Mar 2015 14:54:33 +0000 (15:54 +0100)]
fixed vc 14.0 ctp 6 compilation error
Sergiu Dotenco [Thu, 26 Mar 2015 14:52:15 +0000 (15:52 +0100)]
determine gflags namespace automatically
Sergiu Dotenco [Thu, 26 Mar 2015 14:59:00 +0000 (15:59 +0100)]
do not redefine snprintf if it's already available
Sergiu Dotenco [Thu, 26 Mar 2015 14:58:01 +0000 (15:58 +0100)]
do not redefine stl logging macros
Sergiu Dotenco [Thu, 26 Mar 2015 14:56:33 +0000 (15:56 +0100)]
allow to define TEST_SRC_DIR as a macro
Sergiu Dotenco [Thu, 26 Mar 2015 14:55:37 +0000 (15:55 +0100)]
allow to use __declspec(noreturn)
Sergiu Dotenco [Thu, 26 Mar 2015 14:50:47 +0000 (15:50 +0100)]
export the Demangle function
Sergiu Dotenco [Thu, 26 Mar 2015 14:48:56 +0000 (15:48 +0100)]
added cmake support
Brian Silverman [Tue, 16 Jun 2015 23:50:25 +0000 (16:50 -0700)]
Fix redefinition of _XOPEN_SOURCE.
Under Debian Jessie, I get a warning about redefining _XOPEN_SOURCE
which is easy to fix.
Brian Silverman [Tue, 16 Jun 2015 23:50:01 +0000 (16:50 -0700)]
Fix unused arguments warning in ScopedMockLog.
Brian Silverman [Tue, 16 Jun 2015 23:49:53 +0000 (16:49 -0700)]
Add Brian Silverman to AUTHORS+CONTRIBUTORS.
romange [Thu, 30 Apr 2015 17:28:32 +0000 (20:28 +0300)]
Update vlog_is_on.cc
SetVLOGLevel locks vmodule_lock however RAW_VLOG at the end also implicitly locks it via InitVLOG3__.
This causes deadlock/segfault.
Pierre Phaneuf [Thu, 23 Apr 2015 10:41:53 +0000 (11:41 +0100)]
Add Abhishek Parmar to the AUTHORS/CONTRIBUTORS files.
Fumitoshi Ukai [Fri, 10 Apr 2015 15:05:05 +0000 (00:05 +0900)]
don't remove sinks_ elements.
Abhishek Parmar [Wed, 8 Apr 2015 17:19:06 +0000 (10:19 -0700)]
Guard GOOGLE_PREDICT_TRUE|FALS with #ifndef to avoid collision with other google opensource projects like protobuf.
Fumitoshi Ukai [Fri, 27 Mar 2015 08:23:20 +0000 (17:23 +0900)]
delete LogDestination::sinks_ at DeleteLogDestinations().
fixes #8 AddLogSink memory leak
Fumitoshi Ukai [Fri, 27 Mar 2015 07:43:58 +0000 (16:43 +0900)]
Merge pull request #10 from jmr/std_vector
LOG_STRING: use std::vector and std::string.
Jesse Rosenstock [Thu, 26 Mar 2015 18:25:14 +0000 (14:25 -0400)]
LOG_STRING: use std::vector and std::string.
Previously, plain vector and string were used.
This assumed that there were "using" directives or
declarations before the macro was used. This will
not always be the case.
Fumitoshi Ukai [Thu, 26 Mar 2015 08:51:44 +0000 (17:51 +0900)]
Merge pull request #6 from darkwind-mt/master
Adds color output support for tmux terminals
Michael Tanner [Mon, 23 Mar 2015 10:56:04 +0000 (10:56 +0000)]
Adds color output support for tmux terminals
Fumitoshi Ukai [Wed, 18 Mar 2015 05:54:40 +0000 (14:54 +0900)]
Merge pull request #2 from tbennun/master
Fix x64/Debug build on MSVS
Pierre Phaneuf [Mon, 16 Mar 2015 10:50:32 +0000 (10:50 +0000)]
Add the typical Google contributors and authors files.
Also add a CONTRIBUTING.md, that GitHub will link to in the pull request
creation page.
tbennun [Fri, 13 Mar 2015 05:56:59 +0000 (07:56 +0200)]
Fix x64/Debug build on MSVS
Fumitoshi Ukai [Wed, 11 Mar 2015 04:02:27 +0000 (13:02 +0900)]
Merge pull request #1 from ukai/release_0.3.4
glog: release 0.3.4