Bryce Harrington [Wed, 26 Apr 2017 17:34:52 +0000 (13:34 -0400)]
ecore_evas: Add doxygen for ecore_evas_gl_x11_options_new()
Reviewers: devilhorns
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4828
Daniel Kolesa [Wed, 26 Apr 2017 14:18:49 +0000 (16:18 +0200)]
eo: move all the key_ properties to C
Daniel Kolesa [Wed, 26 Apr 2017 13:01:44 +0000 (15:01 +0200)]
eo: move wref_add/wref_del to C
Daniel Kolesa [Wed, 26 Apr 2017 12:25:37 +0000 (14:25 +0200)]
eo: move future_link to C
Stefan Schmidt [Wed, 26 Apr 2017 13:12:53 +0000 (15:12 +0200)]
ecore: efl_promise: remove superfluous NULL check
f is already checked against NULL in the eina array macro. No need to check
again.
CID: 1362730
Stefan Schmidt [Wed, 26 Apr 2017 12:49:37 +0000 (14:49 +0200)]
eldbus: check return of dbus_signature_iter_next()
CID: 1341856
Stefan Schmidt [Wed, 26 Apr 2017 12:16:14 +0000 (14:16 +0200)]
evas_filter: initialize was_empty to false to have a defined state
It is used further below in an if clause but might not have been
initialized at that point.
CID: 1374276
Stefan Schmidt [Wed, 26 Apr 2017 11:56:59 +0000 (13:56 +0200)]
evas: gl_filters: fix leak of evas image
Make sure we free the allocated use_map evas image before leaving scope.
CID: 1374275
Jaeun Choi [Wed, 26 Apr 2017 08:16:16 +0000 (17:16 +0900)]
evas: fix logic in evas_events.c
Summary:
when collecting the objects under a mouse pointer,
evas uses the geometry of an object to decide
whether the mouse pointer is inside the area of the object,
which is inappropriate for a mapped object.
so mapped objects don't receive mouse events when they should.
this patch fixes the issue.
Test Plan: A sample code will be added as comments
Reviewers: jpeg, raster
Subscribers: cedric, eunue
Differential Revision: https://phab.enlightenment.org/D4826
Vyacheslav Reutskiy [Wed, 26 Apr 2017 08:16:01 +0000 (11:16 +0300)]
elm_fileselector: made fileselector styling more flexible
Previously the progressbar in fileselector use hardcoded style name
"wheel", that made unpossible to create different style for
fileselector. This commit made it possible.
@fix
Vyacheslav Reutskiy [Wed, 26 Apr 2017 05:57:22 +0000 (08:57 +0300)]
elm_cursor: add style name for sub cursor
Missing style name for sub cursor call the next error output:
ERR<24193>:elementary lib/elementary/els_cursor.c:734 elm_cursor_theme()
Could not apply the theme to the cursor style=(null)
Also this error call extra recalc for cursor hot spots.
Fixes T5408
@fix
Vincent Torri [Wed, 26 Apr 2017 05:32:11 +0000 (07:32 +0200)]
Ecore_Evas: use window states and event property to fix ecore_evas_fullscreen_set()
This implies that elm_win_fullscreen_set() is also fixed
@fix
Vincent Torri [Wed, 26 Apr 2017 05:17:04 +0000 (07:17 +0200)]
Ecore_Win32: add Property event API
@feature
Vincent Torri [Wed, 26 Apr 2017 05:10:21 +0000 (07:10 +0200)]
Ecore_Win32: add ecore_win32_window_state_get() API to retrieve a window states
@feature
Vincent Torri [Wed, 26 Apr 2017 04:56:42 +0000 (06:56 +0200)]
Ecore_Win32: update fullscreen state
Vincent Torri [Wed, 26 Apr 2017 04:53:57 +0000 (06:53 +0200)]
Ecore_Win32: follow a bit more X code
Vincent Torri [Wed, 26 Apr 2017 04:47:13 +0000 (06:47 +0200)]
Ecore_Evas: clean up Windows module
Vincent Torri [Wed, 26 Apr 2017 04:19:20 +0000 (06:19 +0200)]
Ecore_Win32: fix information message
Vincent Torri [Wed, 26 Apr 2017 04:17:08 +0000 (06:17 +0200)]
Ecore_Win32: fix spelling
Jeeyong Um [Wed, 26 Apr 2017 02:33:47 +0000 (11:33 +0900)]
edje_cc: Convert anchors to beta feature (require -beta when compiled)
Jeeyong Um [Tue, 25 Apr 2017 09:29:26 +0000 (18:29 +0900)]
edje_cc: Allow to set float position for anchors
Jeeyong Um [Tue, 25 Apr 2017 09:27:52 +0000 (18:27 +0900)]
edje_cc: Allow part to be anchored to GROUP and the part named as "GROUP"
Jeeyong Um [Tue, 25 Apr 2017 09:03:04 +0000 (18:03 +0900)]
edje_cc: Fix warning caused by missing const modifier
Bryce Harrington [Tue, 25 Apr 2017 23:29:43 +0000 (16:29 -0700)]
efl_ui_focus_manager: check for null return from node_get
Summary:
node_get() can return NULL sometimes. Add a missing check, and add dox
for the function to document the error return.
>>> CID 1374434: Null pointer dereferences (NULL_RETURNS)
>>> Assigning: "node" = null return value from "node_get".
@fix CID1374434
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4824
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Bryce Harrington [Tue, 25 Apr 2017 23:28:15 +0000 (16:28 -0700)]
examples/evas: fix spelling
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4807
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jeeyong Um [Tue, 25 Apr 2017 23:25:11 +0000 (16:25 -0700)]
edje_cc: introduce "Anchors" - easy way to set parts relationship
Test Plan: compile src/examples/edc-anchors.c and run
Reviewers: zmike, raster, cedric, jpeg
Reviewed By: raster, jpeg
Subscribers: raster, barbieri, zmike, SanghyeonLee, taxi2se, Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4775
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Tue, 25 Apr 2017 23:15:37 +0000 (16:15 -0700)]
evas: do not rely on Evas canvas for Evas Ector engine backend.
Marcel Hollerbach [Tue, 25 Apr 2017 15:04:50 +0000 (17:04 +0200)]
elm_box/table: set the order directly when a container is registered
The following situation:
- A Box in a naviframe, with n children.
- All added children register to the focus graph with the box as parent,
order gets set correctly.
- Naviframe hides this item, so box property tree unfocusable gets set
to true, it gets unregistered from the focus graph, even every single
child gets unregistered.
- The item gets shown - every child and the table are getting
registered again.
- Order is not set again, since the box does not get changed
- Order of the children is mixed up.
This should fix this case since the order is flushed every time the box
gets registered.
Marcel Hollerbach [Tue, 25 Apr 2017 14:51:30 +0000 (16:51 +0200)]
efl_ui_focus_manager: safe fields from the node
There could be the case that the item gets freed due to some handling in
a event handler of the event EFL_UI_FOCUS_MANAGER_EVENT_FOCUSED.
So the code now sets the node to NULL after the event is called and
saves the fields that are rfom use later.
Gustavo Sverzut Barbieri [Tue, 25 Apr 2017 14:16:40 +0000 (11:16 -0300)]
efl.net: rename Ip.Address to Ip_Address.
It's unlikely that we'll have other stuff under Ip namespace, also not
that likely to have other than Ip Addresses (to invert it to
Address.Ip), thus make a toplevel entry Ip_Address as suggested by
DaveMDS.
Vyacheslav Reutskiy [Tue, 25 Apr 2017 13:34:03 +0000 (16:34 +0300)]
elm_entry: reset 'icon' and 'end' swallow when style changed
Fixes T5397
Jean-Philippe Andre [Tue, 25 Apr 2017 12:21:54 +0000 (21:21 +0900)]
efl/gfx: Remove unused function
This fixes a warning with -Wunused-function
Jean-Philippe Andre [Tue, 25 Apr 2017 12:18:22 +0000 (21:18 +0900)]
evas: Fix crash in idle_flush
As reported by raster on the ML. The pointer passed to the
engines is not an engine output but an Efl_Canvas_Output.
Stefan Schmidt [Tue, 25 Apr 2017 09:54:25 +0000 (11:54 +0200)]
itests: elm_focus: rename local variable to avoid clash with main()
tests/elementary/elm_test_focus_sub.c:88:25: warning: ‘main’ is usually a function [-Wmain]
Stefan Schmidt [Tue, 25 Apr 2017 09:32:36 +0000 (11:32 +0200)]
docs: efl_ui_focus_manager: document last missing items in this new file
Stefan Schmidt [Tue, 25 Apr 2017 09:32:03 +0000 (11:32 +0200)]
docs: elm_widget: document new foc us_register method
Stefan Schmidt [Tue, 25 Apr 2017 09:13:12 +0000 (11:13 +0200)]
docs: efl_ui_focus_manager: document focus relations struct members
Jean-Philippe Andre [Tue, 25 Apr 2017 05:34:03 +0000 (14:34 +0900)]
evas render: Fix issue with map render
Test case:
elementary_test -to "Gesture Layer"
Just move the pictures around (eg. to the bottom). They could
disappear entirely.
This is because the geometry used was based on the smart
object "bounding box" rather than the mapped output.
@fix
Jeeyong Um [Tue, 25 Apr 2017 00:41:46 +0000 (09:41 +0900)]
edje_cc: Fix external param smart parser
Cedric BAIL [Mon, 24 Apr 2017 22:09:25 +0000 (15:09 -0700)]
evas: remove engine.data.output.
This is the first step toward handling multi output. This patch
remove engine.data.output from Evas structure and use an Eina_List
for it instead. It also start moving code around to fetch an output
or an engine context (which are the same at the moment, but will be
split in a later patch).
Cedric BAIL [Mon, 24 Apr 2017 21:53:52 +0000 (14:53 -0700)]
evas: start setting up output independently of the engine.
Cedric BAIL [Wed, 19 Apr 2017 22:48:22 +0000 (15:48 -0700)]
evas: evas_render actually need to access that structure.
Bryce Harrington [Mon, 24 Apr 2017 12:28:31 +0000 (08:28 -0400)]
evas: Fix grammar of which vs. that
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4809
Bryce Harrington [Mon, 24 Apr 2017 12:27:49 +0000 (08:27 -0400)]
evas: Fix grammar for which vs. that
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4808
Bryce Harrington [Mon, 24 Apr 2017 12:26:18 +0000 (08:26 -0400)]
ecore_evas: Fix grammar for at/to/for/on/which/etc.
Summary:
Fixes some grammar confusion for in that/this, that/which, to/at,
to/for, at/by, etc.
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4806
Bryce Harrington [Mon, 24 Apr 2017 12:25:22 +0000 (08:25 -0400)]
Fix spelling of 'alpha channel'
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4817
Youngbok Shin [Sun, 23 Apr 2017 06:22:42 +0000 (09:22 +0300)]
evas: round glyph's advance before adding it to pen_x
Summary:
Rounding the sum of glyph's advance could cause inconsistency of
each glyph's positions. When Evas enables Harfbuzz library,
Each glyph's position has to be handled by only nearby glyphs.
But, currently, totally unrelated glyph's advacne could change
other glyphs positions.
ex) 1. "connect."
2. "Tap here to connect."
You can see different gap between "c" and "o" of word "connect".
It should be same even if there was a different text before the word "connect".
@fix
Test Plan: N/A
Reviewers: raster, herdsman, jpeg
Reviewed By: raster
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D4782
Jean-Philippe Andre [Mon, 24 Apr 2017 02:56:15 +0000 (11:56 +0900)]
tests: Fix make check with build dir
This changes how the eo files are compiled for the focus test
case, and adds the include folder with -I.
Carsten Haitzler (Rasterman) [Sun, 23 Apr 2017 01:58:07 +0000 (10:58 +0900)]
efreetd - make ability to not connect to efreetd non-critical
it's an error we can survive, so make it that level
Carsten Haitzler (Rasterman) [Sun, 23 Apr 2017 01:33:41 +0000 (10:33 +0900)]
efreetd - make efreetd use eio and not ecore_file_monitor for monitoring
this should fix T5130 - freebsd's efreetd polling regularly
@fix
Shinwoo Kim [Sun, 23 Apr 2017 08:02:14 +0000 (17:02 +0900)]
elementary: fix typo on comment
change "an widget" to "a widget".
Marcel Hollerbach [Sat, 22 Apr 2017 08:41:07 +0000 (10:41 +0200)]
efl_ui_focus_manager: change the new order that gets set
Lets say there is a box with the following ordered children:
|Button|Box|Button|Box|Button| the two boxes do not have any children
at the time of the setup. The logic of the order_update will only order
the children like that:
|Button|Button|Button| Which is correct by that time, the two boxes dont
have any children.
Now the two boxes are also getting children, the order will not
selfupdate or anything so the logical chain would be:
|Button|Button|Button|Box|Box|. Which is wrong. To solve that the
manager keeps the order that got set last, and reapplies the order again
if something gets added to the parent where the order was set.
This should fix strange next / prev operations in ephoto.
Carsten Haitzler (Rasterman) [Sat, 22 Apr 2017 03:20:06 +0000 (12:20 +0900)]
ecore - fix epoll ifdefs and case handling
Derek Foreman [Fri, 21 Apr 2017 21:37:18 +0000 (16:37 -0500)]
ecore_drm2: Fix ticking when atomic mode set is enabled
Putting the PAGE_FLIP_EVENT flag on the set rotation request resulted
in an extra event on the drm device fd that screwed up page flipping
badly from that point on.
@fix
Mike Blumenkrantz [Fri, 21 Apr 2017 20:14:57 +0000 (16:14 -0400)]
tests: add test for large eina tiler rect
Mike Blumenkrantz [Fri, 21 Apr 2017 20:14:57 +0000 (16:14 -0400)]
eina_tiler: use int size matching Eina_Rectangle internally to avoid overflow
since this code's creation it seems that the internal int size was set to use
short in order to micro-optimize memory usage, while the api function parameters
used Eina_Rectangle which had a larger int size. when initializing the internal
rect struct, this would lead to overflows which resulted in broken tilers which
returned iterators with no valid rects after having valid rects added
test case: run weston-subsurfaces
@fix
Mike Blumenkrantz [Fri, 21 Apr 2017 20:14:57 +0000 (16:14 -0400)]
elm_win: do not require mouse buttons to be pressed to activate csd move/resize
the api function requires this, but the unified handler for api+edje handler does
not, since edje singals are deferred and the button which triggered the move
may be released before the signal is processed
ref
ea7bbfe47dc1df5f51725be05eadf7ebce1d8361
@fix
Mike Blumenkrantz [Fri, 21 Apr 2017 20:14:57 +0000 (16:14 -0400)]
ecore-wl2: move ecore_wl2_display_inputs_get() into ecore_wl2_display.c
Cedric Bail [Fri, 21 Apr 2017 18:29:38 +0000 (11:29 -0700)]
eina: some architecture don't like prefetch on NULL apparently.
Daniel Kolesa [Fri, 21 Apr 2017 15:58:38 +0000 (17:58 +0200)]
eo: hide dbg_info from eo files
Continues
b780cf2af299ce17be260486bb7ab64badddbaec.
Daniel Kolesa [Fri, 21 Apr 2017 13:47:12 +0000 (15:47 +0200)]
eo: move event related structures and callback to C
We don't need to keep this in eo files anymore because the APIs
using them are now fully in C. This also allows removal of the
event callback builtin from Eolian.
Carsten Haitzler (Rasterman) [Fri, 21 Apr 2017 07:49:29 +0000 (16:49 +0900)]
elm test - unused vars - fix warning and remove them
Carsten Haitzler (Rasterman) [Fri, 21 Apr 2017 07:40:36 +0000 (16:40 +0900)]
evas gl filter blur - fix uninitialized vare warning for sum
Carsten Haitzler (Rasterman) [Fri, 21 Apr 2017 07:39:20 +0000 (16:39 +0900)]
gl filter blur - fix warning about possible uninit vars by initting them
Carsten Haitzler (Rasterman) [Fri, 21 Apr 2017 07:39:06 +0000 (16:39 +0900)]
eio monitor - remove unused vars and fix warning
Carsten Haitzler (Rasterman) [Fri, 21 Apr 2017 07:38:40 +0000 (16:38 +0900)]
eina mmap - fix warnings thanks to missing include
add include for eina_file.h
Carsten Haitzler (Rasterman) [Fri, 21 Apr 2017 07:38:18 +0000 (16:38 +0900)]
eina debug - fix include of eina_file.h that was missing
fixes new warnings
Carsten Haitzler (Rasterman) [Fri, 21 Apr 2017 07:23:16 +0000 (16:23 +0900)]
efl_io_closer - fix warning about error print
lazy removal of fcntl without fixing up error print... fixed.
Carsten Haitzler (Rasterman) [Fri, 21 Apr 2017 07:19:43 +0000 (16:19 +0900)]
ecore_pipe - fix warning of sign vs unsigned comparison
Carsten Haitzler (Rasterman) [Fri, 21 Apr 2017 06:58:04 +0000 (15:58 +0900)]
elm widget - fix weak reference messup that causes segv's
welm widget weak refered the logical parent slot but never unreffed
the weak ref - ever. this should fix that. in fact it does. one crash
less with:
elementary_test -to "icon standard"
@fix
Ivan Furs [Fri, 21 Apr 2017 02:30:05 +0000 (11:30 +0900)]
evas_async_events: Integrated Ecore_Pipe in evas_async_events
Summary: Integrated Ecore_Pipe in evas_async_events
Reviewers: vtorri, artem.popov, cedric, jpeg, raster, #eflete
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4622
Jean-Philippe Andre [Fri, 21 Apr 2017 05:24:45 +0000 (14:24 +0900)]
focus: Review EO file and adjust doc a bit
I was reading it to understand this new focus system. So I also
made some cosmetic changes here and there in the file: wrap, fix
a few typos, add missing docs. I'm not pretending that the doc
is perfect now. This really was just a personal review.
Jean-Philippe Andre [Fri, 21 Apr 2017 05:52:30 +0000 (14:52 +0900)]
focus: Fix shadow variable warning
Jean-Philippe Andre [Fri, 21 Apr 2017 01:08:52 +0000 (10:08 +0900)]
ecore wl2: Fix compilation
Jean-Philippe Andre [Thu, 20 Apr 2017 09:59:02 +0000 (18:59 +0900)]
elm_image: Improve test case from previous patch
This refers to
331bf9f74683aad72415e007af14c3d4713f112b
See also, for 1.19:
4eda12b5e1d6e968fb0b057f11c280a87916e93f
Derek Foreman [Thu, 20 Apr 2017 19:40:29 +0000 (14:40 -0500)]
ecore_wl2: Don't crash when drag and drop is unsupported by compositor
Check for presence of data device manager so we don't crash if it's not
there.
Daniel Kolesa [Thu, 20 Apr 2017 16:24:38 +0000 (18:24 +0200)]
eo: move unbindable event APIs to C
In a few classes, this requires some manual expansion. This should
not break anything but it's also fairly ugly; a better solution
would be appreciated, for now we do this.
Similar changes will be done to a few other Efl.Object APIs as
well at later point.
Daniel Kolesa [Thu, 20 Apr 2017 14:14:18 +0000 (16:14 +0200)]
eo: move Efl_Event definition back to C
It's not used anywhere in eo files and has a void pointer.
Marcel Hollerbach [Thu, 20 Apr 2017 08:15:53 +0000 (10:15 +0200)]
efl_ui_focus_manager: select the widget with the smallest distance
this improves the correctness-feeling when moving focus through a
elementary application.
Marcel Hollerbach [Wed, 19 Apr 2017 12:11:02 +0000 (14:11 +0200)]
elm_interface_scrollable: add focus override
it seems this override got lost somewhere
Marcel Hollerbach [Wed, 19 Apr 2017 12:10:43 +0000 (14:10 +0200)]
elementary: fix focus tests
Marcel Hollerbach [Wed, 11 Jan 2017 15:17:05 +0000 (16:17 +0100)]
elm_list: migrate to new focus system
Marcel Hollerbach [Mon, 2 Jan 2017 10:42:35 +0000 (11:42 +0100)]
fix .eo file breaks
Marcel Hollerbach [Fri, 23 Dec 2016 19:11:12 +0000 (20:11 +0100)]
focus_tests: fix the test suite
this brings back the working testsuite and fixes a bug in the
submanager.
Marcel Hollerbach [Fri, 23 Dec 2016 12:49:12 +0000 (13:49 +0100)]
efl_ui_focus_manager: the order contains nodes not focusables
Marcel Hollerbach [Fri, 23 Dec 2016 12:48:46 +0000 (13:48 +0100)]
elementary: introduce helper functions for the redirects
Marcel Hollerbach [Fri, 23 Dec 2016 12:48:00 +0000 (13:48 +0100)]
update according to cedrics review comments
Marcel Hollerbach [Wed, 21 Dec 2016 23:28:24 +0000 (00:28 +0100)]
focus: update object definition
Summary: This introduces a new focus system and the migration to this system.
Test Plan: run elementary_test
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D4511
Marcel Hollerbach [Wed, 21 Dec 2016 20:40:52 +0000 (21:40 +0100)]
elm_widget: add unfocusable to debug informations
Marcel Hollerbach [Wed, 21 Dec 2016 19:23:55 +0000 (20:23 +0100)]
efl_ui_focus_manager: make setting a order easier
Marcel Hollerbach [Wed, 21 Dec 2016 18:30:21 +0000 (19:30 +0100)]
elm_box,grid,table: take the resize object as evas object
Marcel Hollerbach [Wed, 21 Dec 2016 12:19:47 +0000 (13:19 +0100)]
efl_ui_focus_manager: if there is no normal item then just do nothing
Marcel Hollerbach [Wed, 21 Dec 2016 12:06:54 +0000 (13:06 +0100)]
efl_ui_flip: migrate to new focus system
Marcel Hollerbach [Wed, 21 Dec 2016 11:29:06 +0000 (12:29 +0100)]
elm_grid: migrate to new focus system
Marcel Hollerbach [Wed, 21 Dec 2016 11:28:44 +0000 (12:28 +0100)]
efl_ui_focus_manager: there is the case that n can be NULL
Marcel Hollerbach [Wed, 21 Dec 2016 10:42:41 +0000 (11:42 +0100)]
efl_ui_focus_manager_sub: do not update if parent is NULL
is is actually a dangerous case, and should NEVER happen
Marcel Hollerbach [Wed, 21 Dec 2016 10:41:55 +0000 (11:41 +0100)]
efl_ui_frame: migrate to new focus system
when collapsed the subtree is unfocusable
Marcel Hollerbach [Wed, 21 Dec 2016 10:05:49 +0000 (11:05 +0100)]
elm_table: migrate to new focus system
Marcel Hollerbach [Tue, 20 Dec 2016 17:21:58 +0000 (18:21 +0100)]
elm_interface_scrollable: fix bringing in of items
Marcel Hollerbach [Tue, 20 Dec 2016 16:34:08 +0000 (17:34 +0100)]
elm_scroller: migrate to new focus system
the scrollable interface is doing most of the work, if we know that
something is already focused we just leave the action_move.