platform/upstream/folks.git
13 years agoUpdated Slovenian translation
Matej Urbančič [Tue, 20 Sep 2011 11:07:06 +0000 (13:07 +0200)]
Updated Slovenian translation

13 years agoUpdated Slovenian translation
Matej Urbančič [Mon, 19 Sep 2011 14:14:53 +0000 (16:14 +0200)]
Updated Slovenian translation

13 years agoUpdate NEWS file for next release
Raul Gutierrez Segales [Mon, 19 Sep 2011 11:09:24 +0000 (12:09 +0100)]
Update NEWS file for next release

13 years agobuild: Post-release version bump
Philip Withnall [Sun, 18 Sep 2011 18:32:44 +0000 (19:32 +0100)]
build: Post-release version bump

13 years agobuild: Release version 0.6.3 FOLKS_0_6_3
Philip Withnall [Sun, 18 Sep 2011 18:30:23 +0000 (19:30 +0100)]
build: Release version 0.6.3

13 years agourl-details: s/HOMEPAGE/HOME_PAGE/
Philip Withnall [Sun, 18 Sep 2011 18:01:31 +0000 (19:01 +0100)]
url-details: s/HOMEPAGE/HOME_PAGE/

Quick, before this gets released and frozen!

13 years agoeds: Fix potential false matches in _is_in_source_list()
Philip Withnall [Sun, 18 Sep 2011 17:24:50 +0000 (18:24 +0100)]
eds: Fix potential false matches in _is_in_source_list()

It's possible for the relative URIs of two ESources to be equal (though it's
unlikely). Consequently, we need to compare by UID as well.

13 years agoBug 653623 — Would like a set of standard "type" parameters for UrlDetails
Philip Withnall [Fri, 16 Sep 2011 22:34:39 +0000 (23:34 +0100)]
Bug 653623 — Would like a set of standard "type" parameters for UrlDetails

Add some consts for TYPE and some common values for it for UrlFieldDetails.

Closes: bgo#653623

13 years agoindividual: Prefer set properties over unset ones
Philip Withnall [Sun, 18 Sep 2011 15:56:23 +0000 (16:56 +0100)]
individual: Prefer set properties over unset ones

I can't believe I didn't notice/think of this when I first wrote this code.
I think my licence to write software should be revoked.

13 years agoUpdate British English translation
Philip Withnall [Sun, 18 Sep 2011 13:09:12 +0000 (14:09 +0100)]
Update British English translation

13 years agoBug 657738 — Favorite people are not always displayed
Philip Withnall [Sat, 17 Sep 2011 21:16:07 +0000 (22:16 +0100)]
Bug 657738 — Favorite people are not always displayed

Ensure the TpLogger connection in Tpf.PersonaStore is always prepared before
we first attempt to use favourite contact data.

This should fix the situation where IM connections are already prepared before
folks is prepared (i.e. _connection_ready_cb() is called as soon as the
Tpf.PersonaStore is prepared).

Closes: bgo#657738

13 years agoUpdated Czech translation
Marek Černocký [Sat, 17 Sep 2011 20:20:58 +0000 (22:20 +0200)]
Updated Czech translation

13 years agoUpdated Polish translation
Piotr Drąg [Sat, 17 Sep 2011 19:58:43 +0000 (21:58 +0200)]
Updated Polish translation

13 years agoi18n: Remove untranslatable identifiers from translatable strings
Philip Withnall [Sat, 17 Sep 2011 11:40:22 +0000 (12:40 +0100)]
i18n: Remove untranslatable identifiers from translatable strings

Also remove some trailing newline characters which don't need translating.

13 years agoi18n: Fix a few en_GB-isms in C locale strings
Philip Withnall [Sat, 17 Sep 2011 11:31:40 +0000 (12:31 +0100)]
i18n: Fix a few en_GB-isms in C locale strings

13 years agoBug 658161 — Consistently use “contact” in translatable strings
Philip Withnall [Sat, 17 Sep 2011 11:27:10 +0000 (12:27 +0100)]
Bug 658161 — Consistently use “contact” in translatable strings

Use “contact” and “Telepathy contact” where appropriate instead of “persona”,
to try and reduce the amount of technical vocabulary in the translatable
strings.

Closes: bgo#658161

13 years agoBug 646847 — Rename _update () in Trf.Persona
Philip Withnall [Sat, 17 Sep 2011 19:36:43 +0000 (20:36 +0100)]
Bug 646847 — Rename _update () in Trf.Persona

…or just remove it entirely, since it was only called from one place.

Closes: bgo#646847

13 years agoeds: Add gender as an always-writeable property
Philip Withnall [Sat, 17 Sep 2011 18:19:43 +0000 (19:19 +0100)]
eds: Add gender as an always-writeable property

This is because it uses a custom vCard attribute, so no EDS backend actually
says it's supported. We assume that the backends will save these custom
vCard attributes safely.

13 years agoBug 658328 — Return PropertyError.NOT_WRITEABLE from Persona property setters
Philip Withnall [Sat, 17 Sep 2011 17:58:40 +0000 (18:58 +0100)]
Bug 658328 — Return PropertyError.NOT_WRITEABLE from Persona property setters

Only the EDS backend was affected, and it's not been changed to check whether
properties are writeable before attempting to set them.

Closes: bgo#658328

13 years agoeds: Remove duplicate change checks from Edsf.Persona.change_avatar()
Philip Withnall [Sat, 17 Sep 2011 17:37:22 +0000 (18:37 +0100)]
eds: Remove duplicate change checks from Edsf.Persona.change_avatar()

Helps: bgo#658328

13 years agoBug 658531 — Sometimes avatar caching doesn't work
Philip Withnall [Sat, 17 Sep 2011 16:24:30 +0000 (17:24 +0100)]
Bug 658531 — Sometimes avatar caching doesn't work

Work around bug #659324 (in GIO) to ensure that we never close the same FD
more than once when storing avatars to the cache.

Closes: bgo#658531

13 years agoeds: Re-use a GTimeZone instance for converting birthday timezones
Philip Withnall [Sat, 17 Sep 2011 16:23:19 +0000 (17:23 +0100)]
eds: Re-use a GTimeZone instance for converting birthday timezones

Every time a GTimeZone is created, /etc/localtime is opened. Reduce this
overhead by sharing a single GTimeZone instance between all Edsf.Personas
for all time.

This makes our strace a little tidier.

13 years agoUpdated Slovenian translation
Matej Urbančič [Sat, 17 Sep 2011 15:29:32 +0000 (17:29 +0200)]
Updated Slovenian translation

13 years agoUpdate British English translation
Philip Withnall [Sat, 17 Sep 2011 11:06:15 +0000 (12:06 +0100)]
Update British English translation

13 years agoUpdated Czech translation
Marek Černocký [Fri, 16 Sep 2011 22:07:53 +0000 (00:07 +0200)]
Updated Czech translation

13 years agoabstract-field-details: Minor documentation fix
Philip Withnall [Fri, 16 Sep 2011 20:56:07 +0000 (21:56 +0100)]
abstract-field-details: Minor documentation fix

13 years agoe-d-s: test case for changing primary store
Raul Gutierrez Segales [Thu, 1 Sep 2011 18:29:06 +0000 (19:29 +0100)]
e-d-s: test case for changing primary store

13 years agoe-d-s: allow setting default address books in tests
Raul Gutierrez Segales [Thu, 1 Sep 2011 18:31:28 +0000 (19:31 +0100)]
e-d-s: allow setting default address books in tests

13 years agoe-d-s: notify when an address book is configured as default
Raul Gutierrez Segales [Thu, 15 Sep 2011 14:38:11 +0000 (15:38 +0100)]
e-d-s: notify when an address book is configured as default

Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657141

13 years agocore: add Folks.PersonaStore.user-set-default property
Raul Gutierrez Segales [Thu, 15 Sep 2011 14:33:58 +0000 (15:33 +0100)]
core: add Folks.PersonaStore.user-set-default property

With this property we can tell if a Store (i.e.: an e-d-s address
book) has been marked by the user as his default store (either from
Evo or from GOA, etc).

Helps: https://bugzilla.gnome.org/show_bug.cgi?id=657141

13 years agoIndividualAggregator: improve naming for primary store related methods
Raul Gutierrez Segales [Thu, 15 Sep 2011 13:43:36 +0000 (14:43 +0100)]
IndividualAggregator: improve naming for primary store related methods

Renamed _set_primary_store () to _configure_primary_store () and refactor
the code that actually sets the primary store into _set_primary_store ().

Helps: https://bugzilla.gnome.org/show_bug.cgi?id=657141

13 years agoLet each PersonaStore manage its trust-level
Raul Gutierrez Segales [Wed, 14 Sep 2011 19:48:47 +0000 (20:48 +0100)]
Let each PersonaStore manage its trust-level

Previously, the IndividualAggregator was in charge of
downgrading and upgrading the trust-level of each
PersonaStore. From now on, we let each Store manage its
trust-level since it's the natural way to do it.

Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=659075

13 years agoBug 659128 — If a persona store goes away we don't remove its personas
Philip Withnall [Thu, 15 Sep 2011 21:09:36 +0000 (22:09 +0100)]
Bug 659128 — If a persona store goes away we don't remove its personas

Handle removal of the address books backing Edsf.PersonaStores by notifying
of the removal of all the personas in the store, then emitting
PersonaStore.removed.

Test included.

Closes: bgo#659128

13 years agoindividual: Prefer data from personas with writeable properties
Philip Withnall [Wed, 14 Sep 2011 21:26:04 +0000 (22:26 +0100)]
individual: Prefer data from personas with writeable properties

As an addition to the fix for bgo#657783, if two personas come from stores
which have equal is-primary-store values, we now prefer the persona which
lists the given property as writeable. If both personas list (or don't list)
the property as writeable, we fall back to the given ordering function as
before.

Closes: bgo#657783

13 years agotracker: configure primary store for tests via env var
Raul Gutierrez Segales [Fri, 16 Sep 2011 13:59:09 +0000 (14:59 +0100)]
tracker: configure primary store for tests via env var

No need for GConf to set up primary store for tests, doing it
via en env var is good enough.

Helps: https://bugzilla.gnome.org/show_bug.cgi?id=647909

13 years agoe-d-s: configure primary store for link-personas test via env var
Raul Gutierrez Segales [Fri, 16 Sep 2011 13:30:12 +0000 (14:30 +0100)]
e-d-s: configure primary store for link-personas test via env var

For tests, it's much simpler to do it via an env variable than via
GConf and we avoid ourselves a dependency.

Helps: https://bugzilla.gnome.org/show_bug.cgi?id=647909

13 years agoUpdated Polish translation
Piotr Drąg [Thu, 15 Sep 2011 18:13:51 +0000 (20:13 +0200)]
Updated Polish translation

13 years agoFolks.Individual: don't use is-writeable in change_avatar
Raul Gutierrez Segales [Thu, 15 Sep 2011 13:04:13 +0000 (14:04 +0100)]
Folks.Individual: don't use is-writeable in change_avatar

This is a follow-up for commit 96539acd, using PersonaStore.is_writeable
is deprecated in favour of checking Persona.writeable_properties

13 years agobuild: Clean the .typelib file in clean rather than maintainer-clean
Philip Withnall [Wed, 14 Sep 2011 22:54:25 +0000 (23:54 +0100)]
build: Clean the .typelib file in clean rather than maintainer-clean

It's built by `make` not the maintainer, so according to
http://www.gnu.org/software/hello/manual/automake/Clean.html it should be
cleaned by `make clean`.

Also remove it from BUILT_SOURCES, since it doesn't belong there.

13 years agoDon't distribute the typelib file.
Travis Reitter [Wed, 14 Sep 2011 22:34:23 +0000 (15:34 -0700)]
Don't distribute the typelib file.

Typelib files are architecture-specific, so they shouldn't be distributed.

Closes: bgo#659095 - Don't distribute typelib file

13 years agoFolks.Individual: use is-primary-store instead of is-writeable
Raul Gutierrez Segales [Tue, 13 Sep 2011 16:48:17 +0000 (17:48 +0100)]
Folks.Individual: use is-primary-store instead of is-writeable

Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658324

13 years agoIndividualAggregator: s/writeable_store/primary_store/g
Raul Gutierrez Segales [Tue, 13 Sep 2011 16:35:07 +0000 (17:35 +0100)]
IndividualAggregator: s/writeable_store/primary_store/g

Renamed _writeable_store to _primary_store to augument clarity.
Also, stop listening and setting is-writeable properties and
work with is-primary-store properties.

Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658324

13 years agoFolks.PersonaStore: add is-primary-store and deprecate is-writeable
Raul Gutierrez Segales [Tue, 13 Sep 2011 16:33:44 +0000 (17:33 +0100)]
Folks.PersonaStore: add is-primary-store and deprecate is-writeable

Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658324

13 years agocore: use always-writeable instead of is-writeable
Raul Gutierrez Segales [Thu, 8 Sep 2011 17:12:56 +0000 (18:12 +0100)]
core: use always-writeable instead of is-writeable

Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658324

13 years agocore: deprecate FOLKS_WRITEABLE_STORE for FOLKS_PRIMARY_STORE
Raul Gutierrez Segales [Thu, 8 Sep 2011 16:21:10 +0000 (17:21 +0100)]
core: deprecate FOLKS_WRITEABLE_STORE for FOLKS_PRIMARY_STORE

Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658323

13 years agoe-d-s: always open address books (regardless of it existing or not)
Raul Gutierrez Segales [Wed, 14 Sep 2011 19:50:40 +0000 (20:50 +0100)]
e-d-s: always open address books (regardless of it existing or not)

This helps Gnome Contacts which needs to make sure that at least
the system address book exists.

13 years agoBug 657065 — Cache keeps around contacts from disabled accounts
Philip Withnall [Mon, 22 Aug 2011 22:54:08 +0000 (23:54 +0100)]
Bug 657065 — Cache keeps around contacts from disabled accounts

Add some extra conditions on loading and storing the Tpf.PersonaStore cache,
so as to prevent loading it when the account is disabled or invalid, and to
prevent storing it unnecessarily.

This also adds some extra debug output to Tpf.PersonaStore's caching methods.

Closes: bgo#657065

13 years agoBug 658002 — defective typelib
Philip Withnall [Wed, 14 Sep 2011 17:34:57 +0000 (18:34 +0100)]
Bug 658002 — defective typelib

Pass the libtool dlname for libfolks.so to g-ir-compiler rather than
libfolks.la.

Closes: bgo#658002

13 years agoUpdated Slovenian translation
Matej Urbančič [Wed, 14 Sep 2011 13:41:20 +0000 (15:41 +0200)]
Updated Slovenian translation

13 years agoRemove extra definition of BACKEND_EDS
Rodrigo Moya [Tue, 13 Sep 2011 10:17:37 +0000 (12:17 +0200)]
Remove extra definition of BACKEND_EDS

13 years agoe-d-s: add test for auto linking via emails and IM addresses
Raul Gutierrez Segales [Tue, 13 Sep 2011 13:51:48 +0000 (14:51 +0100)]
e-d-s: add test for auto linking via emails and IM addresses

13 years agoe-d-s: assume certain e-mail addresseses are IM IDs too
Raul Gutierrez Segales [Tue, 13 Sep 2011 11:44:08 +0000 (12:44 +0100)]
e-d-s: assume certain e-mail addresseses are IM IDs too

Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657142

13 years agoavatar-cache: Add some more debug output
Philip Withnall [Tue, 13 Sep 2011 21:03:02 +0000 (22:03 +0100)]
avatar-cache: Add some more debug output

13 years agoUpdated Polish translation
Piotr Drąg [Tue, 13 Sep 2011 19:22:52 +0000 (21:22 +0200)]
Updated Polish translation

13 years agoBug 633781 — Allow to set avatar on individuals
Philip Withnall [Fri, 12 Aug 2011 10:18:16 +0000 (12:18 +0200)]
Bug 633781 — Allow to set avatar on individuals

Make Individual.avatar writeable and write new avatars back to the personas
from writeable persona stores in an individual.

Closes: bgo#633781

13 years agobuild: use AM_MAINTAINER_MODE([enable]) instead of AM_MAINTAINER_MODE
Raul Gutierrez Segales [Tue, 13 Sep 2011 09:26:37 +0000 (10:26 +0100)]
build: use AM_MAINTAINER_MODE([enable]) instead of AM_MAINTAINER_MODE

Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658894

13 years agoBug 658730 — ngettext (Plural forms) needed…
Philip Withnall [Mon, 12 Sep 2011 20:55:04 +0000 (21:55 +0100)]
Bug 658730 — ngettext (Plural forms) needed…

Use ngettext() instead of gettext() for a plural string.

Closes: bgo#658730

13 years agoBug 658874 — Typo?
Philip Withnall [Tue, 13 Sep 2011 07:09:27 +0000 (08:09 +0100)]
Bug 658874 — Typo?

Fix a typo in a translatable string in the Tracker backend.

Closes: bgo#658874

13 years agoBug 658331 — Ensure read-only PersonaStores have empty writeable-properties
Philip Withnall [Mon, 12 Sep 2011 22:31:06 +0000 (23:31 +0100)]
Bug 658331 — Ensure read-only PersonaStores have empty writeable-properties

Ensure that Edsf.PersonaStore.always-writeable-properties is empty for
EDS address books which are read-only. Similarly, ensure that
Edsf.Persona.writeable-properties is also empty for such address books (which
follows because it passes through the value of always-writeable-properties).

No other backends need modifying for this, since no others have a concept
of “read only” except libsocialweb, which already has empty
writeable-properties properties.

Closes: bgo#658331

13 years agoe-d-s: only emit notifications if properties have changed
Raul Gutierrez Segales [Tue, 13 Sep 2011 10:45:17 +0000 (11:45 +0100)]
e-d-s: only emit notifications if properties have changed

This is a follow-up for what was suggested in:

https://bugzilla.gnome.org/show_bug.cgi?id=658411

about dealing with updating properties and emitting notifications.

13 years agoBug 658631 — crash at empathy startup
Philip Withnall [Mon, 12 Sep 2011 22:09:10 +0000 (23:09 +0100)]
Bug 658631 — crash at empathy startup

In the case that a persona is removed and the individual containing that
persona is replaced by a different non-null individual which doesn't contain
that persona (because it's been removed), we need to set the persona's
individual pointer to null rather than the replacement individual.

This stops us tripping the assertion in the setter for Persona.individual.

Closes: bgo#658631

13 years agoindividual-aggregator: Add some more debug output
Philip Withnall [Mon, 12 Sep 2011 22:07:33 +0000 (23:07 +0100)]
individual-aggregator: Add some more debug output

It turns out to be really useful to see what's being emitted by
IndividualAggregator.individuals-changed-detailed.

13 years agoAdded Swedish translation
Daniel Nylander [Mon, 12 Sep 2011 18:26:31 +0000 (20:26 +0200)]
Added Swedish translation

13 years agoCzech translation
Marek Černocký [Sun, 11 Sep 2011 09:15:34 +0000 (11:15 +0200)]
Czech translation

13 years agoAdded Czech language
Marek Černocký [Sun, 11 Sep 2011 09:15:15 +0000 (11:15 +0200)]
Added Czech language

13 years agoe-d-s: Make sure consecutive property changes work
Alexander Larsson [Fri, 9 Sep 2011 12:52:17 +0000 (14:52 +0200)]
e-d-s: Make sure consecutive property changes work

Don't send any notification due to property changes until we've
done updating an entire persona, otherwise code that listens to
such notifies will see the persona in an intermediate state, whic
can cause problems. For instance, if such a callback tries to
change a property it might not recieve change notification for it.

13 years agoe-d-s: Make sure we clear old attributes when setting im_addresses
Alexander Larsson [Fri, 9 Sep 2011 08:25:37 +0000 (10:25 +0200)]
e-d-s: Make sure we clear old attributes when setting im_addresses

The previous code called e_contact_get_attributes() which returns
a copy of the attributes, and tried to remove it with
e_vcard_remove_attribute () which matches on pointer values, so
it always failed.

13 years agoAdded Polish translation
Piotr Drąg [Thu, 8 Sep 2011 20:26:56 +0000 (22:26 +0200)]
Added Polish translation

13 years agoPost-release version bump
Raul Gutierrez Segales [Thu, 8 Sep 2011 18:21:21 +0000 (19:21 +0100)]
Post-release version bump

13 years agoRelease version 0.6.2.1 FOLKS_0_6_2_1
Raul Gutierrez Segales [Thu, 8 Sep 2011 17:51:29 +0000 (18:51 +0100)]
Release version 0.6.2.1

13 years agoIndividualAggregator: copy the list of stores before looping over it
Raul Gutierrez Segales [Thu, 8 Sep 2011 17:19:35 +0000 (18:19 +0100)]
IndividualAggregator: copy the list of stores before looping over it

Because a Backend's list of PersonaStores can change while we are
iterating it, we do a copy before starting.

Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658580

13 years agoNEWS: add new section for next release
Raul Gutierrez Segales [Thu, 8 Sep 2011 09:53:15 +0000 (10:53 +0100)]
NEWS: add new section for next release

13 years agoPost-release version bump
Raul Gutierrez Segales [Thu, 8 Sep 2011 09:53:00 +0000 (10:53 +0100)]
Post-release version bump

13 years agoRelease version 0.6.2 FOLKS_0_6_2
Raul Gutierrez Segales [Thu, 8 Sep 2011 08:44:16 +0000 (09:44 +0100)]
Release version 0.6.2

13 years agoUpdate @since tags
Raul Gutierrez Segales [Thu, 8 Sep 2011 08:21:04 +0000 (09:21 +0100)]
Update @since tags

13 years agoUpdated galician translations
Fran Dieguez [Thu, 8 Sep 2011 02:01:17 +0000 (04:01 +0200)]
Updated galician translations

13 years agoUpdated NEWS file
Raul Gutierrez Segales [Wed, 7 Sep 2011 22:10:38 +0000 (23:10 +0100)]
Updated NEWS file

13 years agotracker: update link personas test
Raul Gutierrez Segales [Wed, 7 Sep 2011 22:04:07 +0000 (23:04 +0100)]
tracker: update link personas test

13 years agotracker: update IM addresses updates test
Raul Gutierrez Segales [Wed, 7 Sep 2011 22:03:32 +0000 (23:03 +0100)]
tracker: update IM addresses updates test

13 years agotracker: update add persona tes
Raul Gutierrez Segales [Wed, 7 Sep 2011 22:02:28 +0000 (23:02 +0100)]
tracker: update add persona tes

13 years agotracker: update set-im-addresses test
Raul Gutierrez Segales [Wed, 7 Sep 2011 22:01:59 +0000 (23:01 +0100)]
tracker: update set-im-addresses test

Because IM addresses are linkable property, a new Individual
is created when they are modified.

13 years agoe-d-s: update set-im-addresses test
Raul Gutierrez Segales [Wed, 7 Sep 2011 22:01:19 +0000 (23:01 +0100)]
e-d-s: update set-im-addresses test

Because IM addresses are linkable property, a new Individual
is created when they are modified.

13 years agoe-d-s: only emit notifications if linkable properties changed
Raul Gutierrez Segales [Wed, 7 Sep 2011 22:00:48 +0000 (23:00 +0100)]
e-d-s: only emit notifications if linkable properties changed

Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658411

13 years agoe-d-s: move Set comparison method into it's own class
Raul Gutierrez Segales [Wed, 7 Sep 2011 21:59:41 +0000 (22:59 +0100)]
e-d-s: move Set comparison method into it's own class

This refactoring is so we can reuse the method with other
types.

13 years agoBug 656689 — Re-link personas on linkable properties being changed
Philip Withnall [Tue, 6 Sep 2011 21:22:52 +0000 (22:22 +0100)]
Bug 656689 — Re-link personas on linkable properties being changed

Listen for notifications of changes to the linkable properties of every
persona in the IndividualAggregator. When we receive such a notification,
relink that persona by artificially removing them from the aggregator and
immediately re-adding them.

Like many things in the IndividualAggregator, this is ugly — but it appears
to work, and I can get my head around it.

Closes: bgo#656689

13 years agocore: Fix individuals_changed_detailed mappings for unlinked individuals
Philip Withnall [Tue, 6 Sep 2011 21:20:12 +0000 (22:20 +0100)]
core: Fix individuals_changed_detailed mappings for unlinked individuals

It turns out that we can do a post-processing phase on the mappings to be
emitted by IndividualAggregator.individuals_changed_detailed and ensure that
individuals who've been unlinked are represented by a mapping from themselves
to the set of individuals replacing them, rather than a mapping from
themselves to null, and null to the set of individuals replacing them.

This probably isn't the most efficient way to fix the problem, but it works
and I can just about understand it.

Helps: bgo#656689, bgo#657282

13 years agocore: Be more thorough when removing individuals from the link map
Philip Withnall [Tue, 6 Sep 2011 21:16:44 +0000 (22:16 +0100)]
core: Be more thorough when removing individuals from the link map

Since the values of personas' linkable properties could've changed since we
added them to the link map, we have to be more thorough when removing
individuals from the map. We therefore now remove them by examining all the
values in the map, and removing every mapping to the individual we're
interested in.

Helps: bgo#656689

13 years agocore: Add more debug output and validation to the IndividualAggregator
Philip Withnall [Tue, 6 Sep 2011 21:10:20 +0000 (22:10 +0100)]
core: Add more debug output and validation to the IndividualAggregator

Everyone loves debug output, and validating that we aren't leaving stale
entries in the link map which will later cause whoever's looking into
aggregator bugs to hide in a corner and cry.

Helps: bgo#656689

13 years agocore: Clarify that Persona.linkable_properties doesn't change at runtime
Philip Withnall [Tue, 6 Sep 2011 21:04:20 +0000 (22:04 +0100)]
core: Clarify that Persona.linkable_properties doesn't change at runtime

Helps: bgo#656689

13 years agocore: Ensure we always notify of new Individuals
Philip Withnall [Tue, 6 Sep 2011 20:57:42 +0000 (21:57 +0100)]
core: Ensure we always notify of new Individuals

In the following situation, it was possible for
IndividualAggregator.individuals_changed_detailed to not emit a notification
that an individual was added:

If two personas were added by a given store in the same emission of
PersonaStore.personas_changed, the IA would create an Individual, i1, from
the first and add a mapping (null → i1) to the change set. It would then
process the second, destroying the first individual and creating a new
Individual, i2, (correctly) containing both personas. In doing so, it would
remove the mapping (null → i1) from the change set, but would incorrectly
not add a mapping (null → i2) in its place.

This situation can be extended to others where a single new Individual is
formed from multiple new personas coming from a single emission of
PersonaStore.personas_changed.

Closes: bgo#657282 (again)

13 years agoe-d-s: kill gconfd-2 after running a test
Raul Gutierrez Segales [Wed, 7 Sep 2011 14:52:27 +0000 (15:52 +0100)]
e-d-s: kill gconfd-2 after running a test

I thought we were properly cleaning up the GConf entries
generated by each test run but it turns out that sometimes
gconfd-2 exits /after/ we've supposedly nuked it's directory.
So before cleaning up GConf's files we now kill gconfd-2
to prevent it from sync-ing to disc afterwards.

Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658327

13 years agoBump required Vala version.
Travis Reitter [Wed, 7 Sep 2011 21:23:39 +0000 (14:23 -0700)]
Bump required Vala version.

This avoids breaking the build due to valac --fatal-warnings for our
internal code.

13 years agoUpdate for translatable strings in group-details
Travis Reitter [Wed, 7 Sep 2011 21:17:53 +0000 (14:17 -0700)]
Update for translatable strings in group-details

13 years agoFix birthday calculation in eds tests.
Travis Reitter [Wed, 7 Sep 2011 18:37:12 +0000 (11:37 -0700)]
Fix birthday calculation in eds tests.

It's not nice to discriminate against people born outside of UTC.

13 years agoUpdated Slovenian translation
Matej Urbančič [Wed, 7 Sep 2011 13:36:23 +0000 (15:36 +0200)]
Updated Slovenian translation

13 years agoAdded British English translation
Bruce Cowan [Wed, 7 Sep 2011 12:47:10 +0000 (13:47 +0100)]
Added British English translation

13 years agoe-d-s: remove invalid assertion in set-roles test case
Raul Gutierrez Segales [Wed, 7 Sep 2011 11:42:31 +0000 (12:42 +0100)]
e-d-s: remove invalid assertion in set-roles test case

13 years agoe-d-s: free resources properly between tests cases on link-persona test unit
Raul Gutierrez Segales [Wed, 7 Sep 2011 11:41:09 +0000 (12:41 +0100)]
e-d-s: free resources properly between tests cases on link-persona test unit

13 years agoe-d-s: eliminate another case of possible WebServiceFieldDetails with null value
Raul Gutierrez Segales [Wed, 7 Sep 2011 11:32:08 +0000 (12:32 +0100)]
e-d-s: eliminate another case of possible WebServiceFieldDetails with null value

13 years agoe-d-s: don't instantiate WebServiceFieldDetails with null values
Raul Gutierrez Segales [Wed, 7 Sep 2011 10:55:08 +0000 (11:55 +0100)]
e-d-s: don't instantiate WebServiceFieldDetails with null values

Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658327