Merge pull request dotnet/coreclr#4069 from swgillespie/gc-test-fixups

Fix a number of tests that make invalid assumptions about object life…

Commit migrated from https://github.com/dotnet/coreclr/commit/475f4479a092da692f711f78fda3ef4601aaa8de

Merge pull request dotnet/coreclr#4072 from briansull/safe-refactor

Safe refactoring changes and code cleanup items

Commit migrated from https://github.com/dotnet/coreclr/commit/9128fbfdf573a11d7b22787c302f0a2ac434aa7d

Safe refactoring changes and code cleanup items

Fixed the dumper so that GT_LCL_VAR and GT_LCL_FLD use a common code path
and we now  display (last use) correctly
Moved the checking for invalid GT_LISTs with an op1 arg of a GT_LIST from gtNewArgList to the constructor
and called IsListForMultiRegArg in the new assert
Renamed IsListofLclFlds to IsListForMultiRegArgs and added ARM64 support
Modifed the dump to display the GTF_MORPHED flag using a '+'
Fix dumper's gtGetLateArgMsg to display each register for a multireg struct passed using a GT_LIST
Modified the NYI_<target> macros to include the target in their message
Fixed the gtCosts for GT_LIST, GT_OBJ, GT_MKREFANY and GT_BOX nodes
When we construct a new GT_LCL_FLD, initialize the gtFieldSeq to NotAField rather than nullptr
Fix comment header for getStructGcPtrsFromOp
Removed the define on ARM64 that changed the asserts(p) macro to notYetImplemented
In NewPutArg renamed the "fp" argument to be called "info" instead

Commit migrated from https://github.com/dotnet/coreclr/commit/4de1138be664fb43448b08149b5aab4eb720b7a9

Fix a number of tests that make invalid assumptions about object lifetimes. Fixes dotnet/coreclr#3391

Commit migrated from https://github.com/dotnet/coreclr/commit/8eabd431f323867184e9af9b519056d0de712e5d

Merge pull request dotnet/coreclr#4071 from fadimounir/gentests

Add generics constraint test

Commit migrated from https://github.com/dotnet/coreclr/commit/387b83fc040ca06c08b602d9174bc7ac80d39f15

Add generics test

Commit migrated from https://github.com/dotnet/coreclr/commit/479ab6fefe6ba4ab1214ec1fb99d3167d07fe9d6

Merge pull request dotnet/coreclr#4042 from sivarv/refactor2

Refactor Unix structDesc of GenTreeCall node into MultiRegReturnTypeDesc

Commit migrated from https://github.com/dotnet/coreclr/commit/d62613deb7af2c1d9126e3abfa368536d3df5a04

Merge pull request dotnet/coreclr#4065 from jashook/smarty_parser

Add a smarty parser.

Commit migrated from https://github.com/dotnet/coreclr/commit/dd6fcf795e9b1ecc7d970553d0b0ca8e820f32cf

Merge pull request dotnet/coreclr#4058 from sejongoh/fix_call_setup_runtime_dep

Update setup-runtime-dependencies.cmd to specify runtime explicitly

Commit migrated from https://github.com/dotnet/coreclr/commit/ee57f743ebaa15ec9fd602c5d2039b1a941023ca

Refactor Unix structDesc of GenTreeCall node into MultiRegReturnTypeDesc.

Commit migrated from https://github.com/dotnet/coreclr/commit/563bcf4b0b896a99776d9973ada1e462d9797192

Merge pull request dotnet/coreclr#4053 from RussKeldorph/test32

Fix some of the tests failing on x86

Commit migrated from https://github.com/dotnet/coreclr/commit/32350dc140602bc9bccfab2010e32c57973e3e4d

Merge pull request dotnet/coreclr#3958 from gkhanna79/FixR2RScripts

Fix to add error checks for crossgen compilation

Commit migrated from https://github.com/dotnet/coreclr/commit/4f8370743ef58a8192b1d71721c84e14b3c1873d

Add a smarty parser.

This can be used in the future by the arm64 ci to report output.

Commit migrated from https://github.com/dotnet/coreclr/commit/a646383e4f9e7258c37ea861cabe6162f57c6c24

Fix to add error checks for crossgen compilation

Commit migrated from https://github.com/dotnet/coreclr/commit/be17b1f867a15164911503850f562739fabbaf9f

Merge pull request dotnet/coreclr#4045 from LLITCHEV/Issue3601

Don't add nop padding for rejitting a funclet prolog.

Commit migrated from https://github.com/dotnet/coreclr/commit/bd05196930765de1e2ce2518904be1357128a578

Merge pull request dotnet/coreclr#4060 from jkotas/remove-r2r-workaround

Remove ReadyToRun workaround

Commit migrated from https://github.com/dotnet/coreclr/commit/03fb23215d32adb5a46aa4dff24b66c7ed65dde0

Update setup-runtime-dependencies.cmd to specify runtime explicitly

Commit migrated from https://github.com/dotnet/coreclr/commit/f408f842c44932dc5bf991d0d813d32678620b94

Remove ReadyToRun workaround

Commit migrated from https://github.com/dotnet/coreclr/commit/fcd4ba3453c6caed8561af7747e8aed9b803326b

Merge pull request dotnet/coreclr#4051 from sejongoh/fix_singlinkgen_test

Fix singlinkgen test.

Commit migrated from https://github.com/dotnet/coreclr/commit/6eed833dd35ce5340c48055bf1e036588b80b798

Fix some of the tests failing on x86

Some tests were ported exclusively for x64 but originally had non-x64
variants, so I'm just completing the porting of those for x86.  For
dblarray4, it is supposed to run with an env var set.  The way this is
done is pretty ugly ("precommands"), and if we require more of this, we
should add a better way to do it to the test harness.

Fixes 3972
Fixes part of 2877

Commit migrated from https://github.com/dotnet/coreclr/commit/ffcd556694a55032fa4d8046c3d320aecfbfc5a8

Enabling Helix perf test runs for CoreCLR

Enabling Helix perf test runs for CoreCLR

Commit migrated from https://github.com/dotnet/coreclr/commit/de540c5ae788fd666d223c40921ea5e05567802d

Merge pull request dotnet/coreclr#4052 from yizhang82/master

Add mac ulimit -n 2048 workaround and more debug spew in CLI installation into init-tools.sh

Commit migrated from https://github.com/dotnet/coreclr/commit/b6eb7de001be523aa07f56965f5c872e3306486c

Add mac ulimit -n 2048 workaround and more debug spew in CLI installation into init-tools.sh

Commit migrated from https://github.com/dotnet/coreclr/commit/d7653d909ad252b9e9ffab9c6d2089767cb6981f

Fix singlinkgen test.

If the address of SingLink is stored at stack, GC.Collect() cannot collect
the object since the address variable is still alive at stack.

Commit migrated from https://github.com/dotnet/coreclr/commit/030136228abccb8b6d4737f92358bec8a9a50c09

Merge pull request dotnet/coreclr#4004 from sejongoh/use_corefx_outerloop_test

Use corefx outerloop tests

Commit migrated from https://github.com/dotnet/coreclr/commit/21f5e97a0eea6d24965a7cda3e892befaf5daea1

Merge pull request dotnet/coreclr#4047 from kyulee1/fixclean

Fix clean build that deletes Tools

Commit migrated from https://github.com/dotnet/coreclr/commit/b533436efafb831f8a16b4a1fed2d211eb1004fd

Don't add nop padding for rejitting a funclet prolog.

This is along standing issue in RyuJit. When ngenning the crossgen tool
passes CORJIT_FLG_PROF_REJIT_NOPS flag. The padding for rejitting should
be added only for the main function and not the funclets when compiling a
method. Trying to generate a rejit padding for a funclet in debug and
checked build results in a failing assertion.

Fixes issue 3601.

Commit migrated from https://github.com/dotnet/coreclr/commit/40409548f182d26c75a0b850484c660ab5987281

Fix clean build that deletes Tools

Commit migrated from https://github.com/dotnet/coreclr/commit/ed465d97cbb2164d9cd7872ce0aaf44978383ba0

Merge pull request dotnet/coreclr#3961 from natgla/adams

Changing adams benchmark

Commit migrated from https://github.com/dotnet/coreclr/commit/4f29f251e6597180724d4a0f6883810143e94161

Merge pull request dotnet/coreclr#4038 from adityamandaleeka/extest

Disable ForeignThreadExceptions test on ARM64

Commit migrated from https://github.com/dotnet/coreclr/commit/1c131d9aacfccaccf5037fefbd5807ac542fe125

Merge pull request dotnet/coreclr#4031 from dagood/upgrade-cli

Upgrade dotnet cli to 1.0.0-beta-002173

Commit migrated from https://github.com/dotnet/coreclr/commit/3f2bfaf602e2915354325bd98e0f419dac9b2def

Merge pull request dotnet/coreclr#4041 from erozenfeld/gtTreeHasSideEffectsFix

Fix exponential explosion in gtTreeHasSideEffects.

Commit migrated from https://github.com/dotnet/coreclr/commit/8734d7ec680ed0e30712327ce2087f29b1c88552

Merge pull request dotnet/coreclr#4039 from manu-silicon/open_delegates

Disable FEATURE_STUBS_AS_IL on ARM 32-bit

Commit migrated from https://github.com/dotnet/coreclr/commit/b8bf943917b420ed73f7779b544b814c8696692c

Merge pull request dotnet/coreclr#4034 from gkhanna79/PortFix

Port workaround for AOT packaging

Commit migrated from https://github.com/dotnet/coreclr/commit/ebb839f3218a9410f76f4595574155304c5e101e

Disable FEATURE_STUBS_AS_IL on ARM 32-bit

This enables open delegates on ARM (an additional 43 tests are now passing)

Commit migrated from https://github.com/dotnet/coreclr/commit/b8f1a49697c2994c032cd128300e487e9a052055

Disable ForeignThreadExceptions test on ARM64.

Commit migrated from https://github.com/dotnet/coreclr/commit/d9f0d424f5055cf73763a735bf19a446f417d74b

Fix exponential explosion in gtTreeHasSideEffects.

gtTreeHasSideEffects has special code to deal with helper calls.
If the helper satisfies certain properties and its arguments don't have relevant
side effects, than the tree corresponding to the helper call is considered not to have
side effects. The bug was that both gtTreeHasSideEffects and gtNodeHasSideEffects
(called by gtTreeHasSideEffects and calling gtTreeHasSideEffects) had code to check
the helper arguments for side effects. That made the algorithm exponential (2^n)
for a tree like the one below.
Because of that ngen would take days to compile the method with such trees.
The fix is to remove the argument checking code from gtTreeHasSideEffects since it always
calls gtNodeHasSideEffects. Compilation time goes back to milliseconds or seconds.

I ran full desktop testing and verified no SuperPMI diffs.

No measurable impact on cqNGenTP.

Fixes dotnet/coreclr#3768.

N139 (255,169)              [000064] --CXG-------             *  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $179
N137 (255,163)              [000062] --CXG------- arg0 in rcx \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $177
N135 (255,157)              [000060] --CXG------- arg0 in rcx    \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $175
N133 (255,151)              [000058] --CXG------- arg0 in rcx       \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $173
N131 (255,145)              [000056] --CXG------- arg0 in rcx          \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $171
N129 (255,139)              [000054] --CXG------- arg0 in rcx             \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $16f
N127 (255,133)              [000052] --CXG------- arg0 in rcx                \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $16d
N125 (255,127)              [000050] --CXG------- arg0 in rcx                   \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $16b
N123 (255,121)              [000048] --CXG------- arg0 in rcx                      \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $169
N121 (255,115)              [000046] --CXG------- arg0 in rcx                         \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $167
N119 (253,109)              [000044] --CXG------- arg0 in rcx                            \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $165
N117 (239,103)              [000042] --CXG------- arg0 in rcx                               \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $163
N115 (225, 97)              [000040] --CXG------- arg0 in rcx                                  \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $161
N113 (211, 91)              [000038] --CXG------- arg0 in rcx                                     \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $15f
N111 (197, 85)              [000036] --CXG------- arg0 in rcx                                        \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $15d
N109 (183, 79)              [000034] --CXG------- arg0 in rcx                                           \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $15b
N107 (169, 73)              [000032] --CXG------- arg0 in rcx                                              \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $159
N105 (155, 67)              [000030] --CXG------- arg0 in rcx                                                 \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $157
N103 (141, 61)              [000028] --CXG------- arg0 in rcx                                                    \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $155
N101 (127, 55)              [000026] --CXG------- arg0 in rcx                                                       \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $153
N099 (113, 49)              [000024] --CXG------- arg0 in rcx                                                          \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $151
N097 ( 99, 43)              [000022] --CXG------- arg0 in rcx                                                             \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $14f
N095 ( 85, 37)              [000020] --CXG------- arg0 in rcx                                                                \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $14d
N093 ( 71, 31)              [000018] --CXG------- arg0 in rcx                                                                   \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $14b
N091 ( 57, 25)              [000016] --CXG------- arg0 in rcx                                                                      \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $149
N089 ( 43, 19)              [000014] --CXG------- arg0 in rcx                                                                         \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $147
N087 ( 29, 13)              [000012] --CXG------- arg0 in rcx                                                                            \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $145
N085 ( 15,  7)              [000010] --CXG------- arg0 in rcx                                                                               \--*  call help ref    HELPER.CORINFO_HELP_READYTORUN_CHKCAST $143
N083 (  1,  1)              [000008] ------------ arg0 in rcx                                                                                  \--*  lclVar    ref    V00 tmp0         u:2 (last use) $140

Commit migrated from https://github.com/dotnet/coreclr/commit/f8c8dc2b6df8ebdfede6302b9b08d4d1ac82bae8

Merge pull request dotnet/coreclr#4035 from kyulee1/common

Update build script for arm64

Commit migrated from https://github.com/dotnet/coreclr/commit/8ac11d8e0680092d1f9aafc6e57c1d9eb0982738

Update build script for arm64

Commit migrated from https://github.com/dotnet/coreclr/commit/49281684b4e146848b7216afcc38f88a9c2bfc8c

Port workaround for AOT packaging

Commit migrated from https://github.com/dotnet/coreclr/commit/e847fdec96c1d6174ec1a655a0c860d57397a364

Merge pull request dotnet/coreclr#4007 from adityamandaleeka/extest

Add test for exception handling on foreign threads.

Commit migrated from https://github.com/dotnet/coreclr/commit/d0c0c99bf258c97b09d85b14ce66a2016d752a05

Merge pull request dotnet/coreclr#3295 from chuck-mitchell/feature

Initial version of CoreCLR JIT Performance Harness

Commit migrated from https://github.com/dotnet/coreclr/commit/503251d26cfa811cda361ae28ab32a241b11fcef

Merge pull request dotnet/coreclr#4015 from sejongoh/update_dotnet_cli_path

Fix tests/setup-runtime-dependencies.sh as per dotnet cli changes

Commit migrated from https://github.com/dotnet/coreclr/commit/1e78c916be0f286c797a07a54fce0f5159e7949c

Merge pull request dotnet/coreclr#4006 from jashook/arm32_ci_pr

Add arm32 build per pr.

Commit migrated from https://github.com/dotnet/coreclr/commit/6958194a4263e5e876761964430e170c698a38d5

Upgrade dotnet cli to 1.0.0-beta-002173.

Commit migrated from https://github.com/dotnet/coreclr/commit/c84b7246da274bf5c2ba51d3b75a7ee5b6e9027f

Merge pull request dotnet/coreclr#4024 from AlexGhiondea/mscorlibBuild

Fix issues with building mscorlib inside VS

Commit migrated from https://github.com/dotnet/coreclr/commit/5caeaa19a838acc48d96706093226f160493b777

Moving validation out of measured code

Commit migrated from https://github.com/dotnet/coreclr/commit/347f1646757bf149c1da5e25f0e53ed2fb70c47c

Merge pull request dotnet/coreclr#3953 from LLITCHEV/Issue3604

Make sure 4 outgoing arg slots are generated for methods that call

Commit migrated from https://github.com/dotnet/coreclr/commit/6a48c498ae50dead47383bb371f8dcfe1d3751ac

Merge pull request dotnet/coreclr#4029 from pgavlin/Host64Bit

Replace uses of _WIN64 with _HOST_64BIT_.

Commit migrated from https://github.com/dotnet/coreclr/commit/23508cb6cc0f99dde29808679711ca098c95207d

Replace uses of _WIN64 with _HOST_64BIT_.

This terminology is more accurate. This change also corrects
a few bits of code that were making target-related decisions
based on the host's bitness.

Commit migrated from https://github.com/dotnet/coreclr/commit/1e9cadbd87fffbb4342a5090941b349a4d0a2fd9

Merge pull request dotnet/coreclr#3914 from cmckinsey/GitHub_3600

Fix for stack overflow in CFG/DOM analysis GHdotnet/coreclr#3600

Commit migrated from https://github.com/dotnet/coreclr/commit/965c6a7517541bf4df96e225c562af01972c52e2

Merge pull request dotnet/coreclr#4030 from kyulee1/updateryujit

Update RyuJit version

Commit migrated from https://github.com/dotnet/coreclr/commit/ace460f20ba8fac014923805abda15c2e83b5583

Update RyuJit version

Commit migrated from https://github.com/dotnet/coreclr/commit/9cd61a9aba4ea783a85b73754c182344220d9d05

Add arm32 build per pr.

Commit migrated from https://github.com/dotnet/coreclr/commit/91af0e517a246935b1d4629d93a0b031e941a81f

Merge pull request dotnet/coreclr#4018 from mikem8361/sosplugfix

sos fails to load if binaries are copied to different location than built

Commit migrated from https://github.com/dotnet/coreclr/commit/7aa7212428eda7e244585775c5376523be79ec0e

Merge pull request dotnet/coreclr#4009 from pgavlin/EmitXarchClarify

Clarify register aliasing in the X86 encoder.

Commit migrated from https://github.com/dotnet/coreclr/commit/4e2b9b6be2b59a2cbf6663cccd6bc1b6091f6eac

Merge pull request dotnet/coreclr#4014 from dagood/upgrade-cli

Upgrade dotnet cli to take win7 fix

Commit migrated from https://github.com/dotnet/coreclr/commit/a91efd26f26ef7f28023380cb73ec7766cac620d

Merge pull request dotnet/coreclr#3967 from stephentoub/empty_memorystream

Avoid array allocation in "new MemoryStream()"

Commit migrated from https://github.com/dotnet/coreclr/commit/da1d0bfc093df8ab3d1f7aec268dcc3fbbf9bb98

Fix tests/setup-runtime-dependencies.sh as per dotnet cli changes

Commit migrated from https://github.com/dotnet/coreclr/commit/7bbd985be6eb703a2e6f3822acae68c7305dd325

Merge pull request dotnet/coreclr#4021 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/d3502c29c511292d0c6046b1aafe87295d2372d9

We should no longer need to use the '/test:moduleName=CommonLanguageRuntimeLibrary' flag when building mscorlib.

Commit migrated from https://github.com/dotnet/coreclr/commit/42de492c0390c9dea8417cfe30a0046098839d49

Do not use the 'Visible' metadata on the items in the ItemGroup 'MscorlibSources'

We are going to import that itemgroup into the 'Compile' ItemGroup which will
make them show up in VS. Having the 'Visible' metadata on the items means we end
up with duplicated items in Solution Explorer.

Commit migrated from https://github.com/dotnet/coreclr/commit/5fa60fc71b34b63c4202411cb6a7b1f244b7e903

Merge pull request dotnet/coreclr#4008 from leemgs/upstream-typo-build-mode

Improve description of build type spelling for consistency

Commit migrated from https://github.com/dotnet/coreclr/commit/0cce34c8976fd887bee0cf877c36b9abfa555635

Merge pull request dotnet/coreclr#4020 from JohnChen0/master

Fix CrossGen documentation error

Commit migrated from https://github.com/dotnet/coreclr/commit/255c421c4a21e2f603c49d8233bfb77c7bb1cbdc

Merge pull request dotnet/coreclr#3944 from leemgs/upstream-cross-arm-stripping-symbols

[Linux/ARM32] objcopy: Support cross-build  for stripping symbols.

Commit migrated from https://github.com/dotnet/coreclr/commit/2d67d180baf9b8a5cbcb10dd49dd02e38bd684d8

Merge pull request dotnet/coreclr#3989 from bbowyersmyth/StringEquals

Port String.Equals from CoreRT

Commit migrated from https://github.com/dotnet/coreclr/commit/7b8fc40b13a1000a8b8617ec8be7ec0456a37573

Merge pull request dotnet/coreclr#3981 from manu-silicon/context

Fix RtlRestoreContext

Commit migrated from https://github.com/dotnet/coreclr/commit/3be49cd4b6f25ad315ad0c48e53dd46c4e9f39ba

Fix CrossGen documentation error

Commit migrated from https://github.com/dotnet/coreclr/commit/79d8f0478049271c370c2b2feb99df4b466717d8

Fix RtlRestoreContext

Due to macro expansion, the previous computed offsets to restore Lr and Pc
were incorrect, causing a memory corruption (see Issue dotnet/coreclr#3856 for C# code
reproducing that problem).
Made assembly more obvious when just restoring Sp, Lr and Pc.

Commit migrated from https://github.com/dotnet/coreclr/commit/8b37a203524b88c9b003e9779822fb8fdf77e119

Merge pull request dotnet/coreclr#4016 from dotnet/revert-3960-check_runtime_to_pull_coredistools

Revert "Add architeture information to a script downloading coredistools"

Commit migrated from https://github.com/dotnet/coreclr/commit/99329c67db66a4def852a681c240569553026e19

Fix R2R fixups for delegate ctors

- Add getReadyToRunDelegateHelper to JIT-EE interface. This method has an extra argument describing the type of the delegate. This argument is required to emit correct fixups.
- Call the new method in both JIT and JIT32
- Add the new method to superpmi
- Bump minor version of R2R file format
- Add regression test for dotnet/coreclr#3975 to R2R unit test

Fixes https://github.com/dotnet/coreclr/issues/3975

[tfs-changeset: 1591698]

Commit migrated from https://github.com/dotnet/coreclr/commit/c4378e7f0773577e9924ff4ebad0cc3af43fb3a8

Merge pull request dotnet/coreclr#4017 from mikem8361/issue3987

Fixed issue dotnet/coreclr#3987 "Debugger fails to stop on entry due to stack walk failure"

Commit migrated from https://github.com/dotnet/coreclr/commit/184a61dd82d7da989d630dcdbcecdb1b9c3e316e

Fixed issue dotnet/coreclr#3987 "Debugger fails to stop on entry due to stack walk failure"

By initializing m_rgHijackFunction to NULL.

Commit migrated from https://github.com/dotnet/coreclr/commit/3cd2f88c398cfba986202a9766047b8fc231602d

Add back explicitly loading mscordaccore so libsos will properly load when installed at a different location than it was built.

Commit migrated from https://github.com/dotnet/coreclr/commit/0572670952204fe3d861044a5a6b7c5297de80d0

Merge pull request dotnet/coreclr#3982 from mikem8361/readmemoryav2

Fix ReadMemory AV.

Commit migrated from https://github.com/dotnet/coreclr/commit/1bc24d14dce4876197492211f4989b656f08aedb

Revert "Add architeture information to a script downloading coredistools"

Commit migrated from https://github.com/dotnet/coreclr/commit/72c2da31f0f4136daa5be81ef24e1b7289b781fb

Merge pull request dotnet/coreclr#4002 from kyulee1/fixcmd

ARM64: Running cmd instead of exe

Commit migrated from https://github.com/dotnet/coreclr/commit/7b5202380fd78006592564d954f445c63495fb97

Getting SOS to work on ARm64:

     This mainly involved DACizing the VM code.
      A bulk edit for changing RUNTIME_FUNCTION to T_RUNTIME_FUNCTION

[tfs-changeset: 1591667]

Commit migrated from https://github.com/dotnet/coreclr/commit/6a2e3b34c3c9ac32456d38567b9f44ab6aea2f63

ARM64: Running cmd instead of exe

Our test framework (smarty) directly runs test executable on corerun.exe.
But some of tests expect arguments via environment variable specified in .cmd.
The fix is to change the test list file to run .cmd. So the expected pass
value is also updated to 0 instead of 100. Now we don't need to pass /host
that specifies corerun.exe.
3 additional tests are now passed:
 InterlockedAddLongWithSubtract/CompareExchangeTString/Polyrec

Commit migrated from https://github.com/dotnet/coreclr/commit/cc5518a491dd31a308b205bc52de31e834b47e72

Changes from code review

Added verification to the benchmark,
put most of output under #if VERBOSE.
Also fixed number of iterations for xunit.perf runs.

Commit migrated from https://github.com/dotnet/coreclr/commit/f32f0b30a2fc05cb63b2e2ab8873db37a5c6c75c

Upgrade dotnet cli to take win7 fix.

Commit migrated from https://github.com/dotnet/coreclr/commit/24311cd3d73944cfdee5534f5b124affb366e21b

Change spelling of build type for consistenty

This is trivial patch.
Let's display a help manual with lower case for better consistency
when the developers run "./build.sh --help".

Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/91aef995434cbe1646b2661cc4111ecfc1e6b487

Move dllexport to platformdefines.h.

Commit migrated from https://github.com/dotnet/coreclr/commit/064744a23663cb0a34c6364618c3be308ee87933

Clarify register aliasing in the X86 encoder.

Certain registers are aliased with control bits in the ModRM byte
of an X86 instruction. Encapsulate the checks that accommodate this
aliasing into a pair of functions.

Commit migrated from https://github.com/dotnet/coreclr/commit/850f3124db3cbcac3f5db192906ff7234564f66f

Add test for exception handling on foreign threads.

Commit migrated from https://github.com/dotnet/coreclr/commit/77f4b171604a66b14e85f25be2167aaa09e4d5ba

Merge pull request dotnet/coreclr#4003 from briansull/update-tests-lst

Update with 10 additional passing tests, and two moved to unstable

Commit migrated from https://github.com/dotnet/coreclr/commit/531de762ff569f52049e35cb69032b9c3da22238

Merge pull request dotnet/coreclr#4005 from dotnet/revert-3943-upstream-gawk-char-class

Revert "Fix bracket expression matches a character at gawk"

Commit migrated from https://github.com/dotnet/coreclr/commit/ef38b9d88463c427896457f7f03b3c2976c9b307

Revert "Fix bracket expression matches a character at gawk"

Commit migrated from https://github.com/dotnet/coreclr/commit/e65dcb5321a86f0d4e1cee92e2f36f8c84013904

Update with 10 additional pasing tests, and two moved to unstable

Commit migrated from https://github.com/dotnet/coreclr/commit/575eecb4ae0415f2be2196a0435c79ff6365eff9

Use cirefx outerloop tests

Commit migrated from https://github.com/dotnet/coreclr/commit/7eb8932b37c7ad76508ab3472a50e741ba096969

Merge pull request dotnet/coreclr#3955 from davmason/master

Fixing tracelogging on linux

Commit migrated from https://github.com/dotnet/coreclr/commit/d47a3984e4f3277337c710579407d3a5e1d94714

Make sure 4 outgoing arg slots are generated for methods that call
THROW_HELPERS for Windows x64.

This is a long standing bug in RyuJit.
When compiling a method for debug mode if there is a call to THROW_HELPER
(and it is the only call) the frame for the method that calls the
THROW_HELPER is not properly set - it is missing the 4 ougoing arg slots.

This was discovered by R2R codegen. In normal jitting of such method in
debug mode the jit always adds a call to CORINFO_HELP_DBG_IS_JUST_MY_CODE
early enough, so the frame size will be properly calculated. This call is
not generated for R2R.

If the method generated for R2R has only a call to a throw helper
and it is compiled for debug mode, the call is not generated in the IR.
The CodeGen generates the call directly instead. The call is generated
after the stack frame is calculated. This leads to improperly generated
stack frame that doen't have the 4 outgoing arg slots that the Windows x64
ABI requires.

Compiling such method for release mode is never a problem since in
FlowGraph we always generate IR for a block that contains the
THROW_HELPER. This happens before the stack frame is calculated, so the 4
outgoing stack slots are always calculated.

Commit migrated from https://github.com/dotnet/coreclr/commit/8df64093caa4ce1720970d38140261822247b3ae

Merge pull request dotnet/coreclr#3996 from kyulee1/fixconv

ARM64: Fix conversion double to unsigned int

Commit migrated from https://github.com/dotnet/coreclr/commit/831ce3c7db6b532420dcb778918a7554a6fc2965

ARM64: Fix conversion double to unsigned int

For ARM/ARM64, converting negative double to unsigned int is 0, which aligns with all native compilers.
I also removed the part of tests that depends on architecture specific values.
Since ARM64 tests were prepopulated, I just updated the tag so that we can update the tests later.

Commit migrated from https://github.com/dotnet/coreclr/commit/bbfdcebb6bed3ed646bb5e17028166bcc9404653

Merge pull request dotnet/coreclr#3960 from sejongoh/check_runtime_to_pull_coredistools

Add architeture information to a script downloading coredistools

Commit migrated from https://github.com/dotnet/coreclr/commit/debff19365d06a66fc3cd50342ded48518a25f01

Merge pull request dotnet/coreclr#3983 from svick/getresourcestring-culture

Remove unused CultureInfo from GetResourceString

Commit migrated from https://github.com/dotnet/coreclr/commit/918bb2e8bfb46d44291507d4b0d017f8aba5b0d8

Fixing contracts violations, and adding missing contracts to some APIs.
Changing native format reader failure mode to fail fast instead of throwing and exception.

[tfs-changeset: 1591477]

Commit migrated from https://github.com/dotnet/coreclr/commit/a62cb372fb7edf1cf7d7b783bfa653f58dc68a7a

Merge pull request dotnet/coreclr#3994 from dagood/upgrade-cli

Apply dotnet cli upgrade also to tests\dir.props

Commit migrated from https://github.com/dotnet/coreclr/commit/72f6c4e1d552474f80b1814288eeb79e09e5760f

Apply dotnet cli upgrade also to tests\dir.props.

Commit migrated from https://github.com/dotnet/coreclr/commit/f9fc3284d2c864aff5b685548470813359a07d02

Merge pull request dotnet/coreclr#3993 from dagood/upgrade-cli

Upgrade dotnet cli version

Commit migrated from https://github.com/dotnet/coreclr/commit/a4bb869f1091f2514f5cd705a5e3548d0d28b62a