platform/upstream/dotnet/runtime.git
5 years agoMerge pull request dotnet/coreclr#19458 from BruceForstall/DisableTests
Bruce Forstall [Mon, 13 Aug 2018 19:12:23 +0000 (12:12 -0700)]
Merge pull request dotnet/coreclr#19458 from BruceForstall/DisableTests

Disable System.Linq.Expressions.Tests against dotnet/coreclr#19457

Commit migrated from https://github.com/dotnet/coreclr/commit/1a5e7515ac7d128518b7ec8ce34f632f5b368e66

5 years agoDisable System.Linq.Expressions.Tests against dotnet/coreclr#19457
Bruce Forstall [Mon, 13 Aug 2018 19:10:50 +0000 (12:10 -0700)]
Disable System.Linq.Expressions.Tests against dotnet/coreclr#19457

Commit migrated from https://github.com/dotnet/coreclr/commit/5dfbf227c3c4723d9f9bf5064f1a6c41f9c1996e

5 years agoRemove unused local from List<T>.RemoveRange (dotnet/corefxdotnet/coreclr#31727)
Robin Sue [Mon, 13 Aug 2018 02:49:39 +0000 (04:49 +0200)]
Remove unused local from List<T>.RemoveRange (dotnet/corefxdotnet/coreclr#31727)

`int i` appears to be unused so i removed it.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/1f02c30e053b1da4410e20c3b715128e3d1e354a

5 years agonon shared changes and feedback addressed
Anipik [Sun, 12 Aug 2018 22:42:34 +0000 (15:42 -0700)]
non shared changes and feedback addressed

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/35dafea02d196d5acb998c8a4fff3e6a37365db8

5 years agoFix a couple of apartment state issues (dotnet/coreclr#19384)
Koundinya Veluri [Mon, 13 Aug 2018 01:35:48 +0000 (18:35 -0700)]
Fix a couple of apartment state issues (dotnet/coreclr#19384)

* Fix a couple of apartment state issues

Fix for https://github.com/dotnet/coreclr/issues/17822
- The apartment state now defaults to MTA for the main thread along with a CoInitialize
- Calling `Thread.SetApartmentState` with STA now fails as expected (different behavior from previous netcore, same behavior as netfx)

Fix for https://github.com/dotnet/coreclr/issues/17787
- `WaitHandle.WaitAll` for multiple handles is not supported on an STA thread due to issues described in https://github.com/dotnet/coreclr/issues/17787#issuecomment-385117537
- It now throws `NotSupportedException` as expected (different behavior from previous netcore, same behavior as netfx)

Fix for https://github.com/dotnet/coreclr/issues/19225

* Temporarily exclude invalid CoreFX test

Commit migrated from https://github.com/dotnet/coreclr/commit/3a56afe6de4113c83b66a5d3a467b8accfaafa1f

5 years agoCreate Microsoft.IO.Redist (dotnet/corefxdotnet/coreclr#31679)
Jeremy Kuhne [Sat, 11 Aug 2018 00:06:39 +0000 (17:06 -0700)]
Create Microsoft.IO.Redist (dotnet/corefxdotnet/coreclr#31679)

* Create Microsoft.Internal.IO

Includes all of Path, Directory, *Info, etc. from System.IO with targets of NetFX 4.6.1 and NetCore 2.1.

* Tweaks / minor fixes

* Remove netstandard build.

* Add package

Update to build for 4.7.2 only

* Rename folder to prepare for project rename

* Change the name to Microsoft.IO.Redist

* Namespace tweaks

* Use open key, tweak references

* More tweaks on feedback

Also grab latest build tools for 4.7.x RIDs

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/4ccd7a52827a9078b35e167bea488b3389538e92

5 years agoSilence WinRT type assert in crossgen (dotnet/coreclr#19442)
Simon Nattress [Mon, 13 Aug 2018 00:09:55 +0000 (17:09 -0700)]
Silence WinRT type assert in crossgen (dotnet/coreclr#19442)

Disable type loader assert that fires when resolving a type from a WinMD. Instead, compilation should fail gracefully, or at runtime a type load exception will be thrown.

Commit migrated from https://github.com/dotnet/coreclr/commit/8589689bc34eb7fab6b33c88505bb041de9e9995

5 years ago[local gc] disable feature redhawk (dotnet/coreclr#17769)
David Mason [Sat, 11 Aug 2018 17:11:49 +0000 (10:11 -0700)]
[local gc] disable feature redhawk  (dotnet/coreclr#17769)

Commit migrated from https://github.com/dotnet/coreclr/commit/d4738d1e9e9b50d00023eb4caca225812cabe285

5 years agoMake RuntimeType sealed and deleted support for introspection only loads (dotnet...
Jan Kotas [Sat, 11 Aug 2018 14:43:16 +0000 (07:43 -0700)]
Make RuntimeType sealed and deleted support for introspection only loads (dotnet/coreclr#19427)

- Sealed Runtime makes `is RuntimeType` and similar checks faster. These checks are fairly common in reflection.
- Delete support for introspection only loads from the runtime. We do not plan to use in .NET Core. The support for introspection loads inherited from RuntimeType and thus it is incompatible with sealed RuntimeType.

Commit migrated from https://github.com/dotnet/coreclr/commit/af4ec7c89d0192ad14392da04e8c097da8ec9e48

5 years agomoved to shared (dotnet/coreclr#19419)
Anirudh Agnihotry [Sat, 11 Aug 2018 07:31:01 +0000 (00:31 -0700)]
moved to shared (dotnet/coreclr#19419)

Commit migrated from https://github.com/dotnet/coreclr/commit/f551543427176850c84b9e11c7b8d528c3f282a7

5 years agoMoved SpinLock.cs to shared (dotnet/coreclr#19391)
Anirudh Agnihotry [Sat, 11 Aug 2018 06:19:28 +0000 (23:19 -0700)]
Moved SpinLock.cs to shared (dotnet/coreclr#19391)

* m removed from names, spaces after \\ and braces added

* Moved to shared

Commit migrated from https://github.com/dotnet/coreclr/commit/b2c4c8c4713a029b8c59f481c967dec3c98f005a

5 years agoDon't early terminate on null for 64bit NR HashCode (dotnet/coreclr#19331)
Ben Adams [Sat, 11 Aug 2018 05:44:19 +0000 (06:44 +0100)]
Don't early terminate on null for 64bit NR HashCode (dotnet/coreclr#19331)

* Don't early terminate on null for 64bit NR HashCode

* Improved GetNonRandomizedHashCode

* Update message on GetNonRandomizedHashCode

* Consume null terminator rather than special case odd lengths

Commit migrated from https://github.com/dotnet/coreclr/commit/c9ad0e8656df10f3aab4b989a1dc72e548d24176

5 years agoMerge pull request dotnet/coreclr#19434 from BruceForstall/DisableR2rDumpTest2
Bruce Forstall [Sat, 11 Aug 2018 03:00:44 +0000 (20:00 -0700)]
Merge pull request dotnet/coreclr#19434 from BruceForstall/DisableR2rDumpTest2

Disable R2RDumpTest for JIT stress modes

Commit migrated from https://github.com/dotnet/coreclr/commit/2c9d4e3be809f11750c6bd1a7c68837f1f3bf343

5 years agoDisable R2RDumpTest for JIT stress modes
Bruce Forstall [Sat, 11 Aug 2018 00:41:17 +0000 (17:41 -0700)]
Disable R2RDumpTest for JIT stress modes

Commit migrated from https://github.com/dotnet/coreclr/commit/0ae96a6054de5334c74c68fb233fc50f21d55d19

5 years agoMerge pull request dotnet/coreclr#19433 from BruceForstall/UpdateTriggerPhrases
Bruce Forstall [Sat, 11 Aug 2018 00:32:02 +0000 (17:32 -0700)]
Merge pull request dotnet/coreclr#19433 from BruceForstall/UpdateTriggerPhrases

Update existing trigger phrases documentation

Commit migrated from https://github.com/dotnet/coreclr/commit/965cfb4557fd3ee80b3145507c075a5ed6eb380b

5 years agoUpdate existing trigger phrases documentation
Bruce Forstall [Sat, 11 Aug 2018 00:29:59 +0000 (17:29 -0700)]
Update existing trigger phrases documentation

Commit migrated from https://github.com/dotnet/coreclr/commit/91dbe617eac9b4ac4683c54333c2ece3875268de

5 years agoCORDbgSetInstruction: clear thumb bit of the address before flushing icache (dotnet...
Konstantin Baladurin [Fri, 10 Aug 2018 23:10:53 +0000 (02:10 +0300)]
CORDbgSetInstruction: clear thumb bit of the address before flushing icache (dotnet/coreclr#19409)

We should clear thumb bit of the address before flushing icache otherwise
we may not flush the cache for the first byte of the instruction.

Commit migrated from https://github.com/dotnet/coreclr/commit/303c8b78151bb7a8f17b32f6e22f52a2227146b2

5 years agoMoved to shared (dotnet/coreclr#19399)
Anirudh Agnihotry [Fri, 10 Aug 2018 23:09:48 +0000 (16:09 -0700)]
Moved to shared (dotnet/coreclr#19399)

Commit migrated from https://github.com/dotnet/coreclr/commit/ee09ff4b55b39bd65aecbe6930ca38b5bda6b80c

5 years agoupdate order of locks so jitstress is unblocked (dotnet/coreclr#19401)
David Mason [Fri, 10 Aug 2018 22:40:39 +0000 (15:40 -0700)]
update order of locks so jitstress is unblocked (dotnet/coreclr#19401)

Commit migrated from https://github.com/dotnet/coreclr/commit/8bd4256dc2e3f001be1fa02e99578db0f46b7586

5 years agoMerge pull request dotnet/coreclr#19344 from adityamandaleeka/aa64_vm_callconv_changes
Aditya Mandaleeka [Fri, 10 Aug 2018 20:38:09 +0000 (13:38 -0700)]
Merge pull request dotnet/coreclr#19344 from adityamandaleeka/aa64_vm_callconv_changes

CallDescr/TransitionBlock changes for ARM64 calling convention

Commit migrated from https://github.com/dotnet/coreclr/commit/30f0be906507bef99d951efc5eb9a1664bde9ddd

5 years agoAdd SoA raytracer as a CQ test for Intel hardware intrinsic
Fei Peng [Mon, 6 Aug 2018 22:10:50 +0000 (15:10 -0700)]
Add SoA raytracer as a CQ test for Intel hardware intrinsic

Commit migrated from https://github.com/dotnet/coreclr/commit/b9028b31caba6e69d1fab99bd1219ae879782802

5 years agoMerge pull request dotnet/coreclr#19414 from BruceForstall/ReduceCorefxInnerloopTesting
Bruce Forstall [Fri, 10 Aug 2018 18:43:05 +0000 (11:43 -0700)]
Merge pull request dotnet/coreclr#19414 from BruceForstall/ReduceCorefxInnerloopTesting

Reduce the number of innerloop CoreFX jobs

Commit migrated from https://github.com/dotnet/coreclr/commit/a69e1653ed0734cb0d0192abe302978ee0115b4d

5 years agoReduce the number of innerloop CoreFX jobs
Bruce Forstall [Fri, 10 Aug 2018 18:30:04 +0000 (11:30 -0700)]
Reduce the number of innerloop CoreFX jobs

1. Stop doing any OSX CoreFX jobs; they're too unreliable.
2. Stop running Debug jobs.

Commit migrated from https://github.com/dotnet/coreclr/commit/72c1ce3c61e46bbe35c1d95dd80872a43e34b8ef

5 years agoMerge pull request dotnet/coreclr#19387 from dotnetrt/parallel-test-build
Bruce Forstall [Fri, 10 Aug 2018 18:10:21 +0000 (11:10 -0700)]
Merge pull request dotnet/coreclr#19387 from dotnetrt/parallel-test-build

Reenable parallel msbuild execution - 2x faster test build

Commit migrated from https://github.com/dotnet/coreclr/commit/cc512301e04098d3b1c9e6de2e6cd8e19bc1807d

5 years agoAlign the Contents of EventPipeBuffers (dotnet/coreclr#19375)
Brian Robbins [Fri, 10 Aug 2018 17:22:40 +0000 (10:22 -0700)]
Align the Contents of EventPipeBuffers (dotnet/coreclr#19375)

Commit migrated from https://github.com/dotnet/coreclr/commit/d6850f7830da3ced9e80948263fe821a3c7a3960

5 years agoUpdating the ilproj-sdk to also copy native dependencies from Microsoft.NETCore.JIT
Tanner Gooding [Thu, 9 Aug 2018 19:33:21 +0000 (12:33 -0700)]
Updating the ilproj-sdk to also copy native dependencies from Microsoft.NETCore.JIT

Commit migrated from https://github.com/dotnet/coreclr/commit/88690582f2e310c0277d6bd5a349bfac8858e46f

5 years agoUpdate DynamicHelper for Unix to match Win.
Aditya Mandaleeka [Thu, 9 Aug 2018 22:43:35 +0000 (15:43 -0700)]
Update DynamicHelper for Unix to match Win.

Commit migrated from https://github.com/dotnet/coreclr/commit/c891df0a89a995c4e559ef9cefc0c07533ae88b4

5 years agoMerge pull request dotnet/coreclr#19385 from BruceForstall/WhichCoreFxCommit
Bruce Forstall [Thu, 9 Aug 2018 21:01:34 +0000 (14:01 -0700)]
Merge pull request dotnet/coreclr#19385 from BruceForstall/WhichCoreFxCommit

Print out the checked out commit hash

Commit migrated from https://github.com/dotnet/coreclr/commit/a7dbd1fd87364d7cd7cd48170254bd9d5b4a7feb

5 years agoAdding the Avx.MaskStore tests
Tanner Gooding [Wed, 8 Aug 2018 18:03:53 +0000 (11:03 -0700)]
Adding the Avx.MaskStore tests

Commit migrated from https://github.com/dotnet/coreclr/commit/40ffce5bb99c77fafe588583ef9a6c1f1c8db90b

5 years agoImplementing the Avx.MaskStore intrinsics
Tanner Gooding [Tue, 7 Aug 2018 20:31:30 +0000 (13:31 -0700)]
Implementing the Avx.MaskStore intrinsics

Commit migrated from https://github.com/dotnet/coreclr/commit/2110b70551bac4f4ad65fcbbdfd853eea9000b4e

5 years agoReenable parallel msbuild execution - 2x faster test build
Jacek Blaszczynski [Thu, 9 Aug 2018 18:04:43 +0000 (20:04 +0200)]
Reenable parallel msbuild execution - 2x faster test build

Commit migrated from https://github.com/dotnet/coreclr/commit/5f386bfb3989c0212bfd7bb9c89e3b6cb859b098

5 years agoPrint out the checked out commit hash
Bruce Forstall [Thu, 9 Aug 2018 18:52:56 +0000 (11:52 -0700)]
Print out the checked out commit hash

This is useful to see exactly which version of CoreFX you are testing against.

Commit migrated from https://github.com/dotnet/coreclr/commit/5ceef2eccb16222ac8c1c64c3254ca7db3d287b9

5 years agoUpdating init-tools to be inline with the CoreFX copy
Tanner Gooding [Thu, 9 Aug 2018 15:02:43 +0000 (08:02 -0700)]
Updating init-tools to be inline with the CoreFX copy

Commit migrated from https://github.com/dotnet/coreclr/commit/ce175cbb849378c2ef1985ff3994cd0d82f3d8fe

5 years agoUpdate CheckProjects to support `DebugType=Embedded` for RelType projects
Tanner Gooding [Thu, 9 Aug 2018 14:56:22 +0000 (07:56 -0700)]
Update CheckProjects to support `DebugType=Embedded` for RelType projects

Commit migrated from https://github.com/dotnet/coreclr/commit/7d2ca2b50ac35e08f2959c71f30a857cf7d320d9

5 years agoUpdating the x86 HWIntrinsic tests to include embedded pdbs
Tanner Gooding [Wed, 8 Aug 2018 19:52:23 +0000 (12:52 -0700)]
Updating the x86 HWIntrinsic tests to include embedded pdbs

Commit migrated from https://github.com/dotnet/coreclr/commit/2aa0cf8f53a1f51e3c9f87bf743fc082725165ec

5 years agoMerge pull request dotnet/coreclr#19350 from dotnet/dev/unix_test_workflow
Bruce Forstall [Thu, 9 Aug 2018 18:06:21 +0000 (11:06 -0700)]
Merge pull request dotnet/coreclr#19350 from dotnet/dev/unix_test_workflow

Simplify PR trigger creation; fix related bugs

Commit migrated from https://github.com/dotnet/coreclr/commit/0b40bfb824e0c50b90e197d9ce877ac6ef09ec5a

5 years agoMerge pull request dotnet/coreclr#19382 from BruceForstall/FixSwitch
Bruce Forstall [Thu, 9 Aug 2018 17:38:09 +0000 (10:38 -0700)]
Merge pull request dotnet/coreclr#19382 from BruceForstall/FixSwitch

Fix `--` application to managed tests build command-line

Commit migrated from https://github.com/dotnet/coreclr/commit/3cbeacca33c39413161d576829860ec99e6d063b

5 years agoFix `--` application to managed tests build comamnd-line
Bruce Forstall [Thu, 9 Aug 2018 17:20:25 +0000 (10:20 -0700)]
Fix `--` application to managed tests build comamnd-line

Commit migrated from https://github.com/dotnet/coreclr/commit/c517566e4dd1a540a4c75139e18406393ef89364

5 years agoChange CoreLib native image to be R2R by default on all platforms (dotnet/coreclr...
Jan Kotas [Thu, 9 Aug 2018 06:29:32 +0000 (23:29 -0700)]
Change CoreLib native image to be R2R by default on all platforms (dotnet/coreclr#19359)

* Change CoreLib native image to be R2R by default on all platforms

* Delete unused argument

Commit migrated from https://github.com/dotnet/coreclr/commit/d485659348af3528b688ac5b7e4c58dacba6de58

5 years agoUpdating init-tools.cmd to pass through PACKAGES_DIR
Tanner Gooding [Wed, 8 Aug 2018 22:04:07 +0000 (15:04 -0700)]
Updating init-tools.cmd to pass through PACKAGES_DIR

Commit migrated from https://github.com/dotnet/coreclr/commit/71f72eee4243dafe1a17441269eb155ccde7ee62

5 years agoUpdate BuildTools, CoreSetup to preview1-03108-01, preview1-26808-05, respectively
dotnet-maestro-bot [Wed, 8 Aug 2018 20:53:23 +0000 (13:53 -0700)]
Update BuildTools, CoreSetup to preview1-03108-01, preview1-26808-05, respectively

Commit migrated from https://github.com/dotnet/coreclr/commit/8d8760291df9c91a0085273a0f0304c17d007a8b

5 years agoMove methodbody and exceptionHandlingClause to shared (dotnet/coreclr#19364)
Anirudh Agnihotry [Thu, 9 Aug 2018 03:08:38 +0000 (20:08 -0700)]
Move methodbody and exceptionHandlingClause to shared  (dotnet/coreclr#19364)

* Changing names and making runtime files

* Movel methodbody and exceptionHandlingClause to shared

* Fixing build error

Commit migrated from https://github.com/dotnet/coreclr/commit/4f92fa9f95b0e45935374da29066978719a7701d

5 years agoMerge pull request dotnet/coreclr#19363 from nattress/crossgen_skip_windowsruntime
Bruce Forstall [Thu, 9 Aug 2018 03:03:13 +0000 (20:03 -0700)]
Merge pull request dotnet/coreclr#19363 from nattress/crossgen_skip_windowsruntime

Skip Crossgen of S.R.WindowsRuntime.dll

Commit migrated from https://github.com/dotnet/coreclr/commit/e197121636cdde973370fe6a3914a1db3503b922

5 years agoMerge pull request dotnet/coreclr#19367 from BruceForstall/RestorePassThroughArg
Bruce Forstall [Thu, 9 Aug 2018 02:53:41 +0000 (19:53 -0700)]
Merge pull request dotnet/coreclr#19367 from BruceForstall/RestorePassThroughArg

Restore handling of __PassThroughArg for `--`

Commit migrated from https://github.com/dotnet/coreclr/commit/fa80abf431111e6e784007021aff1a24a999b9ab

5 years agoFix R2R DynamicHelper to use the correct offset to x0 reg.
Aditya Mandaleeka [Thu, 9 Aug 2018 02:30:48 +0000 (19:30 -0700)]
Fix R2R DynamicHelper to use the correct offset to x0 reg.

Commit migrated from https://github.com/dotnet/coreclr/commit/8eb7b455e251035148e8526fdb512de28cee693b

5 years agoReNaming and rearranging the variables to reduce the diff (dotnet/coreclr#19338)
Anirudh Agnihotry [Wed, 8 Aug 2018 22:54:13 +0000 (15:54 -0700)]
ReNaming and rearranging the variables to reduce the diff (dotnet/coreclr#19338)

* Names changes in managed side and native side

* name changes in native side

* Removing serialization field

* lower case corrected

Commit migrated from https://github.com/dotnet/coreclr/commit/df8e05daed1d45dc5bcec2614667fc3ec0992ce6

5 years agoRestore handling of __PassThroughArg for `--`
Bruce Forstall [Wed, 8 Aug 2018 21:27:22 +0000 (14:27 -0700)]
Restore handling of __PassThroughArg for `--`

Commit migrated from https://github.com/dotnet/coreclr/commit/74883eb0ce122ed25510fe47d4e81d5739be3892

5 years agoMerge pull request dotnet/coreclr#19275 from dotnetrt/test-warnings-msbuild
Bruce Forstall [Wed, 8 Aug 2018 20:38:23 +0000 (13:38 -0700)]
Merge pull request dotnet/coreclr#19275 from dotnetrt/test-warnings-msbuild

build-test - fix ~ 2.1k MSBuild warnings due to bad framework and bad project references

Commit migrated from https://github.com/dotnet/coreclr/commit/d1804ad5634ef85d88b52331b99b1f58626dacf2

5 years agoJIT: update lvaGrabTemp for new minopts/debug ref counting approach (dotnet/coreclr...
Andy Ayers [Wed, 8 Aug 2018 20:05:47 +0000 (13:05 -0700)]
JIT: update lvaGrabTemp for new minopts/debug ref counting approach (dotnet/coreclr#19351)

If the jit has started normal ref counting and is in minopts or debug,
set all new temps to be implicitly referenced by default.

Closes dotnet/coreclr#19346.

Commit migrated from https://github.com/dotnet/coreclr/commit/585cd3685fdad34e8a1ab76b3c98265b26b7aa24

5 years agoSkip Crossgen of S.R.WindowsRuntime.dll
Simon Nattress [Wed, 8 Aug 2018 18:44:33 +0000 (11:44 -0700)]
Skip Crossgen of S.R.WindowsRuntime.dll

System.Runtime.WindowsRuntime contains assembly refs to Windows platform WinMD types which are not available on Unix and required to crossgen the assembly.

Commit migrated from https://github.com/dotnet/coreclr/commit/83be4e97152212bc045a383720563c179603618a

5 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03107-02, preview1...
dotnet-maestro-bot [Wed, 8 Aug 2018 17:02:46 +0000 (10:02 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03107-02, preview1-26808-04, preview1-26807-04, preview1-26807-04, master-20180808-0056, respectively (dotnet/coreclr#19329)

Commit migrated from https://github.com/dotnet/coreclr/commit/0a84a4d68a2059d03f2f1baa348979e244da4f4d

5 years agoMerge pull request dotnet/coreclr#19343 from BruceForstall/SimplifyPrTriggers
Bruce Forstall [Wed, 8 Aug 2018 05:56:56 +0000 (22:56 -0700)]
Merge pull request dotnet/coreclr#19343 from BruceForstall/SimplifyPrTriggers

Simplify the code to create PR triggers

Commit migrated from https://github.com/dotnet/coreclr/commit/f8b94076b5796df62537c5f8f0574426a1ad28fd

5 years agoSimplify the code to create PR triggers
Bruce Forstall [Wed, 8 Aug 2018 00:46:43 +0000 (17:46 -0700)]
Simplify the code to create PR triggers

Also, create PR triggers for jobs that currently don't have them
(which is a bug), such as Debug and Release Windows x64 jobs.

Commit migrated from https://github.com/dotnet/coreclr/commit/e1a46af39014796606d1f40ecd090602f987a145

5 years agoFix non-Windows assembly code to match Windows calldescr/arg reg changes.
Aditya Mandaleeka [Wed, 8 Aug 2018 00:47:43 +0000 (17:47 -0700)]
Fix non-Windows assembly code to match Windows calldescr/arg reg changes.

Commit migrated from https://github.com/dotnet/coreclr/commit/093dc0e035d1e15ed4a82d4e6afea3184ea211a5

5 years agoUse dotnet MSBuild for tests (dotnet/coreclr#19324)
Aaron Robinson [Wed, 8 Aug 2018 00:42:15 +0000 (17:42 -0700)]
Use dotnet MSBuild for tests (dotnet/coreclr#19324)

* Revert "Revert "Build managed tests with dotnet (dotnet/coreclr#19254)""
* Reenable MSBuild support through dotnet instead of global MSBuild

Commit migrated from https://github.com/dotnet/coreclr/commit/b4131b9f9dc9c73e47b315fff886db66374b1b21

5 years agoFillRegDisplay: initialize volatileCurrContextPointers for ARM and ARM64 (dotnet...
Konstantin Baladurin [Tue, 7 Aug 2018 23:25:07 +0000 (02:25 +0300)]
FillRegDisplay: initialize volatileCurrContextPointers for ARM and ARM64 (dotnet/coreclr#19332)

We need to initialize volatileCurrContextPointers because they could be
used by GC in the case of the leaf frame. This patch fixes crashes during
GC when we are single stepping using managed debugger.

Commit migrated from https://github.com/dotnet/coreclr/commit/c488296b594db3054e7cd2af2dab10428ccf0e42

5 years agoMake VM-side changes for ARM64 Windows calling convention.
Aditya Mandaleeka [Tue, 7 Aug 2018 22:17:52 +0000 (15:17 -0700)]
Make VM-side changes for ARM64 Windows calling convention.

Commit migrated from https://github.com/dotnet/coreclr/commit/87174a2fdf97938b0ee8d64a0b784f1c01bf2932

5 years agoR2RDump - Tests for Debug, avoid copying expected xml files (dotnet/coreclr#19321)
Amy [Tue, 7 Aug 2018 22:06:01 +0000 (15:06 -0700)]
R2RDump - Tests for Debug, avoid copying expected xml files (dotnet/coreclr#19321)

* Add Debug expected xml, pass xml path to R2RDumpTest

* Pass expected xml path as argument

* Remove copy expected xml, clean up

Commit migrated from https://github.com/dotnet/coreclr/commit/25452220f8486f9ecb56b7ffa84a37d80136b750

5 years agoAdd basic check that the correct number of tests is built (dotnet/coreclr#19290)
Bruce Forstall [Tue, 7 Aug 2018 21:58:12 +0000 (14:58 -0700)]
Add basic check that the correct number of tests is built (dotnet/coreclr#19290)

Fixes dotnet/coreclr#19286

Commit migrated from https://github.com/dotnet/coreclr/commit/01908e9fe3b5a3c51935e1f6622ef4bf10b805c3

5 years agoMerge pull request dotnet/coreclr#19336 from dotnet/dev/unix_test_workflow
Bruce Forstall [Tue, 7 Aug 2018 21:43:39 +0000 (14:43 -0700)]
Merge pull request dotnet/coreclr#19336 from dotnet/dev/unix_test_workflow

Update vc-runtime package used by Windows ARM/ARM64 testing

Commit migrated from https://github.com/dotnet/coreclr/commit/525b5e1f990a37c16f4db797e6a5e20419f4059a

5 years agoMerge pull request dotnet/coreclr#19325 from AndyAyersMS/RecomputeRefCounts2
Andy Ayers [Tue, 7 Aug 2018 21:42:47 +0000 (14:42 -0700)]
Merge pull request dotnet/coreclr#19325 from AndyAyersMS/RecomputeRefCounts2

JIT: recompute local ref counts after lower

Commit migrated from https://github.com/dotnet/coreclr/commit/6140e3b35f186a6ba45c311e6b5222d71a8dd8f7

5 years agoMerge pull request dotnet/coreclr#19335 from AndyAyersMS/FixDumpIssue
Andy Ayers [Tue, 7 Aug 2018 21:19:29 +0000 (14:19 -0700)]
Merge pull request dotnet/coreclr#19335 from AndyAyersMS/FixDumpIssue

fix bug in jit dump output

Commit migrated from https://github.com/dotnet/coreclr/commit/d7bbded1a41764eb45e0fc99263725b206646329

5 years agoAdd support to use an indirected address for JMP instructions to ARM64 (dotnet/corecl...
David Wrighton [Tue, 7 Aug 2018 20:49:03 +0000 (13:49 -0700)]
Add support to use an indirected address for JMP instructions to ARM64 (dotnet/coreclr#19281)

* Add support to use an indirected address for JMP instructions to ARM64
- Merge logic between ARM and ARM64

Commit migrated from https://github.com/dotnet/coreclr/commit/fde763073fcce978141bf0b31e4479df507acfb8

5 years agoMerge pull request dotnet/coreclr#19291 from BruceForstall/CleanUpBuildCmd
Bruce Forstall [Tue, 7 Aug 2018 19:35:11 +0000 (12:35 -0700)]
Merge pull request dotnet/coreclr#19291 from BruceForstall/CleanUpBuildCmd

Clean up build.cmd/build-test.cmd/runtest.cmd

Commit migrated from https://github.com/dotnet/coreclr/commit/b37c6d8ee5b4ad9833f21cfc30582b56797e37b4

5 years agofix bug in jit dump output
Andy Ayers [Tue, 7 Aug 2018 18:25:00 +0000 (11:25 -0700)]
fix bug in jit dump output

Commit migrated from https://github.com/dotnet/coreclr/commit/d050a4eae353ae82fb56f34aa8f0afb772fc3181

5 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03106-01, preview1...
dotnet-maestro-bot [Tue, 7 Aug 2018 05:37:31 +0000 (22:37 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03106-01, preview1-26806-04, preview1-26806-04, preview1-26806-01, master-20180802-0110, respectively (master) (dotnet/coreclr#19263)

* Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03106-01, preview1-26806-04, preview1-26806-04, preview1-26806-01, master-20180802-0110, respectively

* Disable outdated tests

Commit migrated from https://github.com/dotnet/coreclr/commit/ab9b4511180d1dfde09d1480c29a7bbacf3587dd

5 years agoJIT: recompute local ref counts after lower
Andy Ayers [Thu, 2 Aug 2018 18:23:27 +0000 (11:23 -0700)]
JIT: recompute local ref counts after lower

Update `lvaComputeRefCounts` to encapsulate running ref counts post-lower
and to also handle the fast jitting cases.

Invoke this after lower to provide recomputed (and more accurate) counts.

Part of dotnet/coreclr#18969.

Commit migrated from https://github.com/dotnet/coreclr/commit/0862b3077b301195fbbcfeb4d302e31cfe74845d

5 years agoJIT: refactor ref count computation into a reusable utility method (dotnet/coreclr...
Andy Ayers [Tue, 7 Aug 2018 01:55:56 +0000 (18:55 -0700)]
JIT: refactor ref count computation into a reusable utility method (dotnet/coreclr#19240)

Extract out the basic ref count computation into a method that we
can conceptually call later on if we want to recompute counts.

Move one existing RCS_EARLY count for promoted fields of register
args into this recomputation since losing this count bump causes
quite a few diffs.

The hope is to eventually call this method again later in the jit
phase pipeline and then possibly get rid of all the (non-early)
incremental count maintenance we do currently.

Part of dotnet/coreclr#18969

Commit migrated from https://github.com/dotnet/coreclr/commit/aa1d28a7b24f896df4a389db5f8fa984e84764b7

5 years agoFix throughput testing (dotnet/coreclr#19314)
Michelle McDaniel [Tue, 7 Aug 2018 01:46:02 +0000 (18:46 -0700)]
Fix throughput testing (dotnet/coreclr#19314)

Also adds architecture to throughput trigger phrase.

Commit migrated from https://github.com/dotnet/coreclr/commit/e1e525663ce21ec6aff28fbc8302cede65a49352

5 years agoMerge pull request dotnet/coreclr#19319 from BruceForstall/UpdateArmCrtDependendencies
Bruce Forstall [Tue, 7 Aug 2018 00:34:34 +0000 (17:34 -0700)]
Merge pull request dotnet/coreclr#19319 from BruceForstall/UpdateArmCrtDependendencies

Update vc-runtime package to support ARM and ARM64 with current builds

Commit migrated from https://github.com/dotnet/coreclr/commit/f801ef77752163992a5c77b017b697ab99d2f61a

5 years agoR2RDumpTests on Windows_NT.x64.Release (dotnet/coreclr#19315)
Amy [Tue, 7 Aug 2018 00:28:39 +0000 (17:28 -0700)]
R2RDumpTests on Windows_NT.x64.Release (dotnet/coreclr#19315)

Commit migrated from https://github.com/dotnet/coreclr/commit/1f24e7adf2d2a238d094437acf7fb23a455f5409

5 years agoMerge pull request dotnet/coreclr#19318 from BruceForstall/AddDavidArm64
Bruce Forstall [Tue, 7 Aug 2018 00:16:58 +0000 (17:16 -0700)]
Merge pull request dotnet/coreclr#19318 from BruceForstall/AddDavidArm64

Update arm64 users list

Commit migrated from https://github.com/dotnet/coreclr/commit/0852f328303edf7a94e617cd5171102e9b03156b

5 years ago[WIP] Update vc-runtime package to support ARM and ARM64 with current builds.
Bruce Forstall [Fri, 3 Aug 2018 03:34:21 +0000 (20:34 -0700)]
[WIP] Update vc-runtime package to support ARM and ARM64 with current builds.

Commit migrated from https://github.com/dotnet/coreclr/commit/377ee6ce052d5615e38dfe1c649f1d6fcd3b67bb

5 years agoUpdate arm64 users list
Bruce Forstall [Mon, 6 Aug 2018 23:02:08 +0000 (16:02 -0700)]
Update arm64 users list

Commit migrated from https://github.com/dotnet/coreclr/commit/fb626fa5c73a283fecfa72a3f4dd5d62b7f30b78

5 years agoPort x86 unwinder fix from .NET Framework (dotnet/coreclr#19311)
Jan Kotas [Mon, 6 Aug 2018 22:43:30 +0000 (15:43 -0700)]
Port x86 unwinder fix from .NET Framework (dotnet/coreclr#19311)

We have not hit this case in CoreCLR yet, but there is a good chance that we will at some point.

Commit migrated from https://github.com/dotnet/coreclr/commit/c10efe004d8720a799bf666d3fac3b800f204848

5 years agoMerge pull request dotnet/coreclr#19228 from AndyAyersMS/FixDevirtFinalMethod
Andy Ayers [Mon, 6 Aug 2018 21:25:12 +0000 (14:25 -0700)]
Merge pull request dotnet/coreclr#19228 from AndyAyersMS/FixDevirtFinalMethod

Fix resolveVirtualMethodHelper to check for explicit override cases

Commit migrated from https://github.com/dotnet/coreclr/commit/8d952c21e566ffe2fa939d452dcba7626ef3f1a4

5 years agoOnly register signals and create alt exception stack in coreclr. (dotnet/coreclr...
Mike McLaughlin [Mon, 6 Aug 2018 19:16:49 +0000 (12:16 -0700)]
Only register signals and create alt exception stack in coreclr. (dotnet/coreclr#19309)

There was a couple of places where the DAC (IsValidObject, GetAppDomainForObject)
assumed that a NULL target/debuggee address would throw an exception that would
be caught by try/catch. Any other invalid address is handled with a software
exception throwed by the read memory functions. In general it is a better overall
design not to have any of the DBI/DAC, etc. code depend on hardware exceptions
being caught. On Linux the C++ runtime sometimes can't handle it. There is a
slight risk that there are other places in the DAC that make the NULL address
assumption but testing so far has found any.

Added PAL_SetInitializeDLLFlags as a fallback to allow the PAL_InitializeDLL flags
to be set for a PAL instance for the DAC where we could still register h/w signals
but not the altstack switching to reduce this risk. The flags can't be build time
conditional because we only build one coreclrpal.a library that all the modules
used. Having a PAL_InitializeFlags function doesn't really help either because of
the PAL_RegisterModule call to PAL_IntializeDLL and the LoadLibrary dance/protocol
that uses it to call the loading module's DLLMain.

Add PAL_SetInitializeFlags; remove flags from PAL_INITIALIZE and PAL_INITIALIZE_DLL
default. Add PAL_InitializeFlags() to allowing the default to be overriden.

Commit migrated from https://github.com/dotnet/coreclr/commit/5306f704e8b4bb30315313033880c36adca6e7f0

5 years agoRegenerating the templated x86 HWIntrinsic tests.
Tanner Gooding [Mon, 6 Aug 2018 15:08:06 +0000 (08:08 -0700)]
Regenerating the templated x86 HWIntrinsic tests.

Commit migrated from https://github.com/dotnet/coreclr/commit/3b9b7b6edf77819f6b9670b0857d8757e95e9fb0

5 years agoUpdating the x86 HWIntrinsic test templates to log the scenarios they run.
Tanner Gooding [Mon, 6 Aug 2018 15:06:32 +0000 (08:06 -0700)]
Updating the x86 HWIntrinsic test templates to log the scenarios they run.

Commit migrated from https://github.com/dotnet/coreclr/commit/588de48d8cf16f03654037a4638eae93a3baaccc

5 years agoupdate test case
Andy Ayers [Mon, 6 Aug 2018 17:34:04 +0000 (10:34 -0700)]
update test case

Commit migrated from https://github.com/dotnet/coreclr/commit/f543bcfd89a18eaa62a135f430231139cc7e4a1e

5 years agoR2RDump - Ignore sensitive properties to pass tests (dotnet/coreclr#19155)
Amy [Mon, 6 Aug 2018 17:29:08 +0000 (10:29 -0700)]
R2RDump - Ignore sensitive properties to pass tests (dotnet/coreclr#19155)

* Ignore sensitive properties in tests

* Enable for JIT stress

* Keep logic for ignoreSensitive in XmlDumper

* Only ignoreSensitive when option is set

Commit migrated from https://github.com/dotnet/coreclr/commit/c056fe7375c61b952d7f40d7d09800ea1ae0bdc1

5 years agoImprove StreamWriter format perf (dotnet/coreclr#19235)
Jeremy Kuhne [Mon, 6 Aug 2018 06:22:57 +0000 (23:22 -0700)]
Improve StreamWriter format perf (dotnet/coreclr#19235)

* Improve StreamWriter format perf

Override the format overloads for TextWriter and skip the extra string allocation for the formatted string by using StringBuilder directly, copying straight to the output buffer.

Improves performance roughtly 10% and cuts allocations by 10x and up (formatting a string into a string goes to *zero* allocations).

* Fix copy/paste slipup- test added to CoreFX PR

Commit migrated from https://github.com/dotnet/coreclr/commit/ac8f8e52c49b0ffa712d68730a41883d281bea01

5 years agoDisable NETClientPrimitives test (dotnet/coreclr#19294)
Bruce Forstall [Mon, 6 Aug 2018 01:07:02 +0000 (18:07 -0700)]
Disable NETClientPrimitives test (dotnet/coreclr#19294)

* Disable NETClientPrimitives test

Fails on many R2R and JitStress jobs.

Tracked by dotnet/coreclr#19164

* Remove disabling under build against packages

Commit migrated from https://github.com/dotnet/coreclr/commit/29b59d54f3816886742cb9aaff6b96ee0625264c

5 years agoClean up build.cmd/build-test.cmd/runtest.cmd
Bruce Forstall [Sat, 4 Aug 2018 23:45:59 +0000 (16:45 -0700)]
Clean up build.cmd/build-test.cmd/runtest.cmd

Various minor cleanups:
1. Use the same naming/style for all three.
2. Make the style consistent throughout each. E.g., consistent indents,
   capitalization.
3. Add more consistent output, including the prefix tag used everywhere.
4. build.cmd: only build cross components if native build is enabled.
5. Use new __Logging variable to consolidate all logging arguments,
   to reduce large (unexpanded) command line lengths.

Commit migrated from https://github.com/dotnet/coreclr/commit/a248d79b29f7c8f6858248a3b1661a6795d6ce19

5 years agoMerge pull request dotnet/coreclr#19287 from BruceForstall/Revert19254
Bruce Forstall [Sat, 4 Aug 2018 03:38:39 +0000 (20:38 -0700)]
Merge pull request dotnet/coreclr#19287 from BruceForstall/Revert19254

Revert "Build managed tests with dotnet (dotnet/coreclr#19254)"

Commit migrated from https://github.com/dotnet/coreclr/commit/9d1e7dd8eb744b14eb4a90b401e854d7a5f79fff

5 years agoRevert "Build managed tests with dotnet (dotnet/coreclr#19254)"
Bruce Forstall [Sat, 4 Aug 2018 00:54:30 +0000 (17:54 -0700)]
Revert "Build managed tests with dotnet (dotnet/coreclr#19254)"

This reverts commit dotnet/coreclr@101baee1010eaad47cd7afd1e041a7f422aefa78.

Commit migrated from https://github.com/dotnet/coreclr/commit/c8480f5058ddaf203460befc6b8f8f26daa36ba0

5 years agoUpdating the x86 HWIntrinsics program to print out the list of supported ISAs
Tanner Gooding [Fri, 3 Aug 2018 20:20:38 +0000 (13:20 -0700)]
Updating the x86 HWIntrinsics program to print out the list of supported ISAs

Commit migrated from https://github.com/dotnet/coreclr/commit/a29c8dfa26b11189566dd09ff0e268accd339b40

5 years agoMoved LocalVariableInfo to shared (dotnet/coreclr#19184)
Anirudh Agnihotry [Fri, 3 Aug 2018 20:03:35 +0000 (13:03 -0700)]
Moved LocalVariableInfo to shared (dotnet/coreclr#19184)

* File Modified

* Moved to shared

* Introducing RuntimeLocalVariableInfo

* Build Corefx change

* sealed added

Commit migrated from https://github.com/dotnet/coreclr/commit/b3db1041998be9c63a730240a8f16918597c0ed5

5 years agoHandle MovRelocatableImmediate on ARM32 as a special case (IF_T2_N3) (dotnet/coreclr...
Egor Chesakov [Fri, 3 Aug 2018 19:35:33 +0000 (12:35 -0700)]
Handle MovRelocatableImmediate on ARM32 as a special case (IF_T2_N3) (dotnet/coreclr#19013)

* Add IF_T2_N3 instruction form and make this a specific case of IF_T2_N when EA_IS_RELOC(attr) is true
* Move "movw/movt reg,relocatableImm" case to function emitIns_MovRelocatableImmediate
* Introduce new instruction descriptor instrDescReloc
* Delete unused CnsVal from ARM32 and ARM64 emitters
* Introduce target_ssize_t and use this type for non-relocatable constants

Commit migrated from https://github.com/dotnet/coreclr/commit/f6e2b9c3b311f58497ccfc337e5925a95a2d008a

5 years agoMerge pull request dotnet/coreclr#19274 from MattGal/remove-ubuntu-1710
Matt Galbraith [Fri, 3 Aug 2018 17:37:53 +0000 (10:37 -0700)]
Merge pull request dotnet/coreclr#19274 from MattGal/remove-ubuntu-1710

Remove EOL Ubuntu 17.10

Commit migrated from https://github.com/dotnet/coreclr/commit/d1c6a938e0f641f978fceb7834314ac6dba14adb

5 years agoRemove EOL Ubuntu 17.10
Matt Galbraith [Fri, 3 Aug 2018 17:32:08 +0000 (10:32 -0700)]
Remove EOL Ubuntu 17.10

Commit migrated from https://github.com/dotnet/coreclr/commit/dc50510d750c5b246e7743569c03054fd7eed50b

5 years agoMerge pull request dotnet/coreclr#19259 from MattGal/update-fedoras
Matt Galbraith [Fri, 3 Aug 2018 17:20:28 +0000 (10:20 -0700)]
Merge pull request dotnet/coreclr#19259 from MattGal/update-fedoras

Remove Fedora 26, add Fedora 28

Commit migrated from https://github.com/dotnet/coreclr/commit/6e488e82b0d12ee0c14545cd92319ad4d8e63f95

5 years agoBuild managed tests with dotnet (dotnet/coreclr#19254)
Chris Sienkiewicz [Fri, 3 Aug 2018 17:11:32 +0000 (10:11 -0700)]
Build managed tests with dotnet (dotnet/coreclr#19254)

* Change managed projects to build with dotnet msbuild, rather than desktop msbuild

* Build sdk tests as AnyCPU

* Correct args passed through to dotnet for tests

* Remove extra backslash from baseIntermediateOutputPath that was causing individual test exe builds to fail

* Fix double import warning for sdk projects

* Add default params from config.json to build-test dotnet invocations

* Fix priority argument passing from the command line for tests

Commit migrated from https://github.com/dotnet/coreclr/commit/101baee1010eaad47cd7afd1e041a7f422aefa78

5 years agoMerge pull request dotnet/coreclr#18223 from mikedn/inc-codegen
Bruce Forstall [Fri, 3 Aug 2018 16:32:41 +0000 (09:32 -0700)]
Merge pull request dotnet/coreclr#18223 from mikedn/inc-codegen

Get rid of codegenlinear.h and x86_instrs.h

Commit migrated from https://github.com/dotnet/coreclr/commit/1ef1f2a27c2e79ce0eaab59a6cefe84d8a79fc95

5 years agoFix invalid project references in test projects
Jacek Blaszczynski [Fri, 3 Aug 2018 15:43:53 +0000 (17:43 +0200)]
Fix invalid project references in test projects

Fixes usually double reference or invalid absolute
path reference which is changed to valid relative
path reference

Commit migrated from https://github.com/dotnet/coreclr/commit/d265f21fdcbba61d8421b6941c2fb078ae9fc06d

5 years agoFix performance tests and HW intrinsics test references
Jacek Blaszczynski [Fri, 3 Aug 2018 15:42:18 +0000 (17:42 +0200)]
Fix performance tests and HW intrinsics test references

Commit migrated from https://github.com/dotnet/coreclr/commit/2d1a86806ef50b9b49cd95fc336a4fa73f6765ce

5 years agoFix MSBuild warnigs caused by double reference to different frameworks
Jacek Blaszczynski [Fri, 3 Aug 2018 01:32:49 +0000 (03:32 +0200)]
Fix MSBuild warnigs caused by double reference to different frameworks

Commit migrated from https://github.com/dotnet/coreclr/commit/91f40df549c8f100a8889ed7b37d5e0935f36d3b

5 years agoFix resolveVirtualMethodHelper to check for explicit override cases
Andy Ayers [Fri, 3 Aug 2018 02:20:48 +0000 (19:20 -0700)]
Fix resolveVirtualMethodHelper to check for explicit override cases

Explicit method overrides in a class can override a virtual final method
with different method. This is only possible if the different method
first is introduced in a new slot. So when devirtualizing, verify that the
slot of the derived method matches the slot of the base method.

If they don't match, just bail on devirtualizing.

Fixes dotnet/coreclr#19222.

Commit migrated from https://github.com/dotnet/coreclr/commit/50584f2129b7b76a6567bce8879031cf974af15e

5 years agoFix interop test targets
Morgan Brown [Fri, 3 Aug 2018 02:04:45 +0000 (19:04 -0700)]
Fix interop test targets

Fix interop test targets

Remove TargetFramework from Interop.settings.targets since it already gets handled by the build environment and 2.0 doesn't work.

Commit migrated from https://github.com/dotnet/coreclr/commit/134b906abc87dbd78ddc49f7068ce5e6a06dc8e8

5 years agoMoved NativeCallable Attribute to shared (dotnet/coreclr#19258)
Anirudh Agnihotry [Fri, 3 Aug 2018 00:34:32 +0000 (17:34 -0700)]
Moved NativeCallable Attribute to shared (dotnet/coreclr#19258)

Commit migrated from https://github.com/dotnet/coreclr/commit/779217b3add24853a450eda4bf37b69450fd1564