platform/upstream/libHarfBuzzSharp.git
6 years ago[name] Rebuild language list, include missing entries
Behdad Esfahbod [Wed, 24 Oct 2018 05:44:36 +0000 (22:44 -0700)]
[name] Rebuild language list, include missing entries

6 years ago[name] Fix cmp for invalid language
Behdad Esfahbod [Wed, 24 Oct 2018 05:19:09 +0000 (22:19 -0700)]
[name] Fix cmp for invalid language

6 years ago[name] Fix nul-termination bug
Behdad Esfahbod [Wed, 24 Oct 2018 05:16:32 +0000 (22:16 -0700)]
[name] Fix nul-termination bug

6 years ago[name] Add language mapping
Behdad Esfahbod [Wed, 24 Oct 2018 05:00:19 +0000 (22:00 -0700)]
[name] Add language mapping

6 years ago[name] Start adding language support
Behdad Esfahbod [Wed, 24 Oct 2018 04:19:56 +0000 (21:19 -0700)]
[name] Start adding language support

6 years ago[name] Remove unused cmp function
Behdad Esfahbod [Wed, 24 Oct 2018 04:12:58 +0000 (21:12 -0700)]
[name] Remove unused cmp function

6 years ago[name] Hook things up
Behdad Esfahbod [Wed, 24 Oct 2018 03:51:53 +0000 (20:51 -0700)]
[name] Hook things up

Accept Mac Latin name entries as ASCII as well.

6 years ago[name] More
Behdad Esfahbod [Wed, 24 Oct 2018 03:30:40 +0000 (20:30 -0700)]
[name] More

It assumes all names are encoded in UTF16-BE.  Other than that, and not
listing languages correctly, it's *supposed* to work.

6 years ago[name] Fix check
Behdad Esfahbod [Wed, 24 Oct 2018 03:15:53 +0000 (20:15 -0700)]
[name] Fix check

6 years ago[name] Flesh out UTF-X to UTF-X conversion routines
Behdad Esfahbod [Wed, 24 Oct 2018 03:04:05 +0000 (20:04 -0700)]
[name] Flesh out UTF-X to UTF-X conversion routines

6 years ago[name] Fix for rebase changes to hb_array_t
Behdad Esfahbod [Tue, 23 Oct 2018 10:16:03 +0000 (03:16 -0700)]
[name] Fix for rebase changes to hb_array_t

6 years ago[name] Some more
Behdad Esfahbod [Wed, 17 Oct 2018 12:42:23 +0000 (05:42 -0700)]
[name] Some more

6 years ago[name] Return full string length from API
Behdad Esfahbod [Wed, 17 Oct 2018 02:55:17 +0000 (19:55 -0700)]
[name] Return full string length from API

6 years ago[utf] Add UTF16-BE and UTF32-BE
Behdad Esfahbod [Wed, 17 Oct 2018 02:04:48 +0000 (19:04 -0700)]
[utf] Add UTF16-BE and UTF32-BE

6 years ago[name] Hide internal details from public API
Behdad Esfahbod [Tue, 16 Oct 2018 20:06:56 +0000 (13:06 -0700)]
[name] Hide internal details from public API

6 years ago[name] More
Behdad Esfahbod [Tue, 16 Oct 2018 06:34:54 +0000 (23:34 -0700)]
[name] More

6 years ago[name] Add hb_ot_name_get_utf()
Behdad Esfahbod [Tue, 16 Oct 2018 06:32:08 +0000 (23:32 -0700)]
[name] Add hb_ot_name_get_utf()

6 years ago[name] Pre-allocate array
Behdad Esfahbod [Tue, 16 Oct 2018 06:28:49 +0000 (23:28 -0700)]
[name] Pre-allocate array

6 years ago[name] Start implementing hb_ot_name_get_utf16()
Behdad Esfahbod [Tue, 16 Oct 2018 06:09:28 +0000 (23:09 -0700)]
[name] Start implementing hb_ot_name_get_utf16()

6 years ago[name] Implement hb_bytes_t get_name()
Behdad Esfahbod [Tue, 16 Oct 2018 06:00:27 +0000 (23:00 -0700)]
[name] Implement hb_bytes_t get_name()

6 years ago[name] Add hb-ot-name.cc for realz
Behdad Esfahbod [Tue, 16 Oct 2018 05:53:40 +0000 (22:53 -0700)]
[name] Add hb-ot-name.cc for realz

6 years ago[name] Implement hb_ot_name_get_names()
Behdad Esfahbod [Tue, 16 Oct 2018 05:48:48 +0000 (22:48 -0700)]
[name] Implement hb_ot_name_get_names()

6 years ago[name] Finish accelerator sorting
Behdad Esfahbod [Tue, 16 Oct 2018 05:42:04 +0000 (22:42 -0700)]
[name] Finish accelerator sorting

6 years ago[name] Start implementing public API infrastructure
Behdad Esfahbod [Tue, 16 Oct 2018 05:22:50 +0000 (22:22 -0700)]
[name] Start implementing public API infrastructure

6 years ago[name] Add public API declarations
Behdad Esfahbod [Tue, 16 Oct 2018 04:34:10 +0000 (21:34 -0700)]
[name] Add public API declarations

6 years ago[indic/khmer/myanmar/use] Clarify clear_syllable
Behdad Esfahbod [Fri, 26 Oct 2018 22:40:12 +0000 (15:40 -0700)]
[indic/khmer/myanmar/use] Clarify clear_syllable

No logic change.

6 years ago[fuzz] Add a new testcase
Ebrahim Byagowi [Fri, 26 Oct 2018 08:44:30 +0000 (12:14 +0330)]
[fuzz] Add a new testcase

6 years ago[layout] Try to speed up collect_lookups some more
Behdad Esfahbod [Fri, 26 Oct 2018 05:25:29 +0000 (22:25 -0700)]
[layout] Try to speed up collect_lookups some more

Barely made a dent :(.

6 years ago[layout] Memoize collect_features
Behdad Esfahbod [Fri, 26 Oct 2018 04:42:19 +0000 (21:42 -0700)]
[layout] Memoize collect_features

Fixes https://github.com/harfbuzz/harfbuzz/pull/1317
Fixes https://oss-fuzz.com/v2/testcase-detail/6543700493598720

6 years ago[layout] Remove unintentionally added code
Behdad Esfahbod [Fri, 26 Oct 2018 04:33:12 +0000 (21:33 -0700)]
[layout] Remove unintentionally added code

6 years ago[layout] Add hb_collect_features_context_t
Behdad Esfahbod [Fri, 26 Oct 2018 04:26:08 +0000 (21:26 -0700)]
[layout] Add hb_collect_features_context_t

Towards https://github.com/harfbuzz/harfbuzz/pull/1317

6 years ago[lookup] Fold another function inline
Behdad Esfahbod [Fri, 26 Oct 2018 04:17:30 +0000 (21:17 -0700)]
[lookup] Fold another function inline

6 years ago[layout] More prep work to memoize collect_features() work
Behdad Esfahbod [Fri, 26 Oct 2018 03:58:34 +0000 (20:58 -0700)]
[layout] More prep work to memoize collect_features() work

6 years ago[lookup] More prep work for memoizing collect_features
Behdad Esfahbod [Fri, 26 Oct 2018 03:48:20 +0000 (20:48 -0700)]
[lookup] More prep work for memoizing collect_features

https://github.com/harfbuzz/harfbuzz/pull/1317

6 years ago[layout] Minor
Behdad Esfahbod [Fri, 26 Oct 2018 03:34:29 +0000 (20:34 -0700)]
[layout] Minor

We were returning the accelerator's lookup count.  Returns table's.
They are the same except for OOM cases.  Just shorter code.

6 years ago[layout] Fold one function inline
Behdad Esfahbod [Fri, 26 Oct 2018 03:32:05 +0000 (20:32 -0700)]
[layout] Fold one function inline

Preparation for fixing https://github.com/harfbuzz/harfbuzz/pull/1317

6 years ago[morx] Use deleted-glyph, instead of actual deletion, in Ligation
Behdad Esfahbod [Fri, 26 Oct 2018 00:41:26 +0000 (17:41 -0700)]
[morx] Use deleted-glyph, instead of actual deletion, in Ligation

Closer to what CoreText does.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1302

6 years ago[morx] Remove deleted-glyph at the end of processing
Behdad Esfahbod [Fri, 26 Oct 2018 00:36:33 +0000 (17:36 -0700)]
[morx] Remove deleted-glyph at the end of processing

6 years ago[aat] Minor
Behdad Esfahbod [Fri, 26 Oct 2018 00:33:48 +0000 (17:33 -0700)]
[aat] Minor

6 years ago[aat] Start adding support for DELETED-GLYPH
Behdad Esfahbod [Fri, 26 Oct 2018 00:29:32 +0000 (17:29 -0700)]
[aat] Start adding support for DELETED-GLYPH

https://github.com/harfbuzz/harfbuzz/issues/1302

6 years ago[vector] Make it act more like pointer
Behdad Esfahbod [Thu, 25 Oct 2018 23:50:38 +0000 (16:50 -0700)]
[vector] Make it act more like pointer

Add pointer cast operator and plus operator.

6 years ago[set] Minor
Behdad Esfahbod [Thu, 25 Oct 2018 23:37:53 +0000 (16:37 -0700)]
[set] Minor

6 years ago[set] Make array access more explicit
Behdad Esfahbod [Thu, 25 Oct 2018 23:35:36 +0000 (16:35 -0700)]
[set] Make array access more explicit

Follow up on 94e421abbfc7ede9aaf3c8d86bb0ff9992ea3123

6 years agoFix again
Behdad Esfahbod [Thu, 25 Oct 2018 21:30:24 +0000 (14:30 -0700)]
Fix again

6 years ago[docs] Add hb-ot-color section
Ebrahim Byagowi [Thu, 25 Oct 2018 20:53:45 +0000 (00:23 +0330)]
[docs] Add hb-ot-color section

6 years agoFixup
Behdad Esfahbod [Thu, 25 Oct 2018 20:37:08 +0000 (13:37 -0700)]
Fixup

6 years ago[test] Rename some fonts
Behdad Esfahbod [Thu, 25 Oct 2018 20:23:33 +0000 (13:23 -0700)]
[test] Rename some fonts

If we have duplicae font files in different directories, that would
break the oss-fuzz build currently.  So, rename some to avoid
name class with text-rendering-test.  Would be better to find
another solution.

6 years agoFix possible overflow in bsearch impls
Behdad Esfahbod [Thu, 25 Oct 2018 20:19:34 +0000 (13:19 -0700)]
Fix possible overflow in bsearch impls

From bungeman.

Fixes https://github.com/harfbuzz/harfbuzz/pull/1314

6 years agoRemove some use of Crap in hb-set.
Ben Wagner [Thu, 25 Oct 2018 17:44:27 +0000 (13:44 -0400)]
Remove some use of Crap in hb-set.

When hb_set_t::page_for_insert needs to insert at the end of the page_map
it ends up evaluating '&page_map[i + 1]' which has hb_vector return an
lvalue of a Crap so that nothing can be moved to its address. This turns
into issues with ThreadSanitizer on Crap when two threads modify different
hb_set_t instances. This can be avoided by using '&page_map[i] + 1'
instead.

6 years agoSet up CI with Azure Pipelines
azure-pipelines[bot] [Thu, 25 Oct 2018 15:22:54 +0000 (15:22 +0000)]
Set up CI with Azure Pipelines

6 years ago[appveyor] Drop Cygwin builds again
Khaled Hosny [Wed, 24 Oct 2018 23:55:10 +0000 (01:55 +0200)]
[appveyor] Drop Cygwin builds again

They are so slow and we had only a couple of Cygwin build failure
reported in ~5 years.

6 years ago[appveyor] Limit make to three jobs
Khaled Hosny [Wed, 24 Oct 2018 20:58:22 +0000 (22:58 +0200)]
[appveyor] Limit make to three jobs

https://github.com/harfbuzz/harfbuzz/pull/1309#issuecomment-432778270

6 years ago[vowel-constraints] Reset continuation on all dottedcircles
Behdad Esfahbod [Wed, 24 Oct 2018 23:46:07 +0000 (16:46 -0700)]
[vowel-constraints] Reset continuation on all dottedcircles

One of the was missed before.  Not intentional.

6 years ago[appveyor] Build on Cygwin and msys2 in parallel
Khaled Hosny [Wed, 24 Oct 2018 09:37:09 +0000 (11:37 +0200)]
[appveyor] Build on Cygwin and msys2 in parallel

6 years ago[appveyor] Do not update msys2
Khaled Hosny [Wed, 24 Oct 2018 09:23:21 +0000 (11:23 +0200)]
[appveyor] Do not update msys2

Looks like AppVeyor has new enough packages for our needs. Cuts CI build
time by 5 minutes.

6 years ago[appveyor] Organize config file a bit
Khaled Hosny [Wed, 24 Oct 2018 07:49:08 +0000 (09:49 +0200)]
[appveyor] Organize config file a bit

6 years ago[appveyor] Don’t build branches with open PR twice
Khaled Hosny [Wed, 24 Oct 2018 07:43:10 +0000 (09:43 +0200)]
[appveyor] Don’t build branches with open PR twice

6 years ago[ot-font] Fix sign of ascent/descent
Behdad Esfahbod [Wed, 24 Oct 2018 00:00:49 +0000 (17:00 -0700)]
[ot-font] Fix sign of ascent/descent

Some fonts, like msmincho, have positive number as descent
in vhea table.  That's wrong.  Just enforce sign on ascent/descent
when reading both horizontal and vertical metrics.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1248

6 years ago[morx] Fix cluster-merging when ligating
Behdad Esfahbod [Tue, 23 Oct 2018 23:46:10 +0000 (16:46 -0700)]
[morx] Fix cluster-merging when ligating

Only merge when actual ligature happened.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1305

6 years agoFix size calculation in DEFINE_SIZE_ARRAY_SIZED.
Garret Rieger [Tue, 23 Oct 2018 22:45:35 +0000 (15:45 -0700)]
Fix size calculation in DEFINE_SIZE_ARRAY_SIZED.

6 years ago[aat] Fix up previous commit and add files
Behdad Esfahbod [Tue, 23 Oct 2018 21:31:51 +0000 (14:31 -0700)]
[aat] Fix up previous commit and add files

6 years ago[aat] Allow enabling/disabling features
Behdad Esfahbod [Tue, 23 Oct 2018 21:14:03 +0000 (14:14 -0700)]
[aat] Allow enabling/disabling features

Only works at entire-buffer range, not sub-ranges.

Test with:

$ hb-shape Zapfino.dfont Zapfino
[Z_a_p_f_i_n_o=0+2333]

$ hb-shape Zapfino.dfont Zapfino --features=-dlig
[Z=0+416|a=1@-21,0+264|p_f=2+433|i=4+181|n=5+261|o=6+250]

$ hb-shape Zapfino.dfont Zapfino --features=+dlig
[Z_a_p_f_i_n_o=0+2333]

Fixes https://github.com/harfbuzz/harfbuzz/issues/1303

6 years ago[ot-map] Minor
Behdad Esfahbod [Tue, 23 Oct 2018 20:39:50 +0000 (13:39 -0700)]
[ot-map] Minor

6 years agoMinor
Behdad Esfahbod [Tue, 23 Oct 2018 20:25:03 +0000 (13:25 -0700)]
Minor

6 years agoShift code around
Behdad Esfahbod [Tue, 23 Oct 2018 20:09:30 +0000 (13:09 -0700)]
Shift code around

6 years ago[trak] Allow disabling tracking for ranges of text
Behdad Esfahbod [Tue, 23 Oct 2018 10:10:56 +0000 (03:10 -0700)]
[trak] Allow disabling tracking for ranges of text

Fixes https://github.com/harfbuzz/harfbuzz/issues/1303

6 years agoWhen parsing feature ranges, accept ';' instead of ':'
Behdad Esfahbod [Tue, 23 Oct 2018 10:07:48 +0000 (03:07 -0700)]
When parsing feature ranges, accept ';' instead of ':'

6 years agoMake tracking optout possible using 'trak' ot feature
Ebrahim Byagowi [Mon, 22 Oct 2018 21:22:05 +0000 (00:52 +0330)]
Make tracking optout possible using 'trak' ot feature

So '--features=-trak' or 'font-feature-settings: 'trak' 0;' can prevent
applying of tracking if used.

6 years agoTouch up on previous commit
Behdad Esfahbod [Tue, 23 Oct 2018 09:51:42 +0000 (02:51 -0700)]
Touch up on previous commit

https://github.com/harfbuzz/harfbuzz/pull/1273

6 years ago[use] Prohibit visually ambiguous vowel sequences
David Corbett [Fri, 12 Oct 2018 20:54:54 +0000 (16:54 -0400)]
[use] Prohibit visually ambiguous vowel sequences

6 years ago[VORG] Hook up to hb-ot-font's v_origin
Behdad Esfahbod [Tue, 23 Oct 2018 09:19:32 +0000 (02:19 -0700)]
[VORG] Hook up to hb-ot-font's v_origin

Fixes https://github.com/harfbuzz/harfbuzz/issues/544

Test added with NotoSansCJK, eg. with U+FF38.

6 years ago[VORG] Add get_y_origin()
Behdad Esfahbod [Tue, 23 Oct 2018 09:09:42 +0000 (02:09 -0700)]
[VORG] Add get_y_origin()

Unhooked.

6 years ago[VORG] Add VORG table
Behdad Esfahbod [Tue, 23 Oct 2018 08:58:59 +0000 (01:58 -0700)]
[VORG] Add VORG table

Cherry-picked from cff-subset branch.

6 years ago[morx] Add a few debug messages to Ligature chain
Behdad Esfahbod [Tue, 23 Oct 2018 08:32:08 +0000 (01:32 -0700)]
[morx] Add a few debug messages to Ligature chain

6 years ago[morx] Clear stack upon underflow when acting ligatures
Behdad Esfahbod [Tue, 23 Oct 2018 07:39:44 +0000 (00:39 -0700)]
[morx] Clear stack upon underflow when acting ligatures

6 years ago[test/text-rendering-tests] Update from upstream
Behdad Esfahbod [Tue, 23 Oct 2018 06:41:47 +0000 (23:41 -0700)]
[test/text-rendering-tests] Update from upstream

6 years ago[morx] Leave ligature on stack after ligating
Behdad Esfahbod [Tue, 23 Oct 2018 06:38:34 +0000 (23:38 -0700)]
[morx] Leave ligature on stack after ligating

Test with Apple Color Emoji.ttf of ~66MB and following sequence:

./hb-shape Apple\ Color\ Emoji-old.ttf --font-funcs=ot -u U+1F468,200d,U+1F469,200d,U+1F467,200d,1f466

Should form full family if matching works correctly.  It first makes
family of three, then makes family of four out of that and the last
two characters.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1292

6 years ago[ci] Disable llvm-gcc
Ebrahim Byagowi [Tue, 23 Oct 2018 05:53:48 +0000 (09:23 +0330)]
[ci] Disable llvm-gcc

  #define Null(Type) Null<typename hb_remove_const<typename hb_remove_reference<Type>::value>::value>()

raises:
  hb-blob.cc: In function 'hb_blob_t* hb_blob_get_empty()':
  hb-blob.cc:194: error: using 'typename' outside of template
  hb-blob.cc:194: error: using 'typename' outside of template

Removing "typename"s fixes the issue but makes newer compiler fail apparently.

Probably downstream can patch that locally till we get a solution.

6 years agoUnbreak builds
Behdad Esfahbod [Tue, 23 Oct 2018 04:49:42 +0000 (21:49 -0700)]
Unbreak builds

6 years agoAdd hb_array<>() specialization for UnsizedArrayOf
Behdad Esfahbod [Tue, 23 Oct 2018 04:33:18 +0000 (21:33 -0700)]
Add hb_array<>() specialization for UnsizedArrayOf

Related https://github.com/harfbuzz/harfbuzz/issues/1301

6 years agoAdd hb_array<>()
Behdad Esfahbod [Tue, 23 Oct 2018 04:27:45 +0000 (21:27 -0700)]
Add hb_array<>()

Simplifies transient object creation.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1301

6 years ago[color] Use Index for colorIdx
Behdad Esfahbod [Tue, 23 Oct 2018 04:22:25 +0000 (21:22 -0700)]
[color] Use Index for colorIdx

Doesn't matter, but matches the description.

6 years agoRemove const and references when binding Null()
Behdad Esfahbod [Tue, 23 Oct 2018 04:18:27 +0000 (21:18 -0700)]
Remove const and references when binding Null()

Fixes https://github.com/harfbuzz/harfbuzz/issues/1299

Removes anomaly I was seeing in cpal table trying to use implicit Null(NameID).

6 years ago[color] Add HB_COLOR
Behdad Esfahbod [Tue, 23 Oct 2018 01:20:57 +0000 (18:20 -0700)]
[color] Add HB_COLOR

Normally I would have added to_string / from_string like other types
have.  But since we don't use hb_color_t much, I'm not going to do that.
Although, if we did, we could use it in hb-view to parse colors...

6 years ago[color] Finish reviewing / revamping CPAL
Behdad Esfahbod [Mon, 22 Oct 2018 23:55:12 +0000 (16:55 -0700)]
[color] Finish reviewing / revamping CPAL

Now to hb_color_t.

6 years ago[color] Minor
Behdad Esfahbod [Mon, 22 Oct 2018 23:35:03 +0000 (16:35 -0700)]
[color] Minor

6 years ago[color] Rely on CPALV1Tail Null object
Behdad Esfahbod [Mon, 22 Oct 2018 23:30:30 +0000 (16:30 -0700)]
[color] Rely on CPALV1Tail Null object

6 years agoRemove const from hb_array_t details
Behdad Esfahbod [Mon, 22 Oct 2018 23:18:34 +0000 (16:18 -0700)]
Remove const from hb_array_t details

Will come in through <T> if desired.

6 years ago[color] Use hb_array_t in CPAL
Behdad Esfahbod [Mon, 22 Oct 2018 23:16:21 +0000 (16:16 -0700)]
[color] Use hb_array_t in CPAL

Doesn't work though, ouch :(.  Need to figure out if it's unreasonable
to expect Null(T) inside hb_array_t<T> to see the later specialization
of Null for NameID.

6 years ago[color] Check for null CPAL arrays
Behdad Esfahbod [Mon, 22 Oct 2018 21:54:55 +0000 (14:54 -0700)]
[color] Check for null CPAL arrays

We cannot use a nullable offset here though.

6 years ago[color] More CPAL rename
Behdad Esfahbod [Mon, 22 Oct 2018 21:51:40 +0000 (14:51 -0700)]
[color] More CPAL rename

6 years ago[color] More CPAL rename
Behdad Esfahbod [Mon, 22 Oct 2018 21:46:21 +0000 (14:46 -0700)]
[color] More CPAL rename

6 years ago[color] Rename vars in CPAL
Behdad Esfahbod [Mon, 22 Oct 2018 21:43:12 +0000 (14:43 -0700)]
[color] Rename vars in CPAL

6 years agoAdopt dump-emoji with latest unreleased APIs changes (#1297)
Ebrahim Byagowi [Mon, 22 Oct 2018 22:03:45 +0000 (01:33 +0330)]
Adopt dump-emoji with latest unreleased APIs changes (#1297)

6 years ago[color] Revamp palette API
Behdad Esfahbod [Mon, 22 Oct 2018 20:02:04 +0000 (13:02 -0700)]
[color] Revamp palette API

6 years ago[color] Rewrite colr access
Behdad Esfahbod [Mon, 22 Oct 2018 19:40:38 +0000 (12:40 -0700)]
[color] Rewrite colr access

COLR table has one function: return layers for a glyph, and we expose exactly
that, so should just wire it through.  Also use sub_array() for verifiable
safety.

Also, BaseGlyphRecord's null object is enough.  We don't need to special-case
the not-found.

6 years ago[colr] Add hb_ot_color_layer_t
Behdad Esfahbod [Mon, 22 Oct 2018 17:29:01 +0000 (10:29 -0700)]
[colr] Add hb_ot_color_layer_t

We never return parallel arrays from functions.  That's inconvenient
and hard to bind.

6 years ago[color] Rename / reorder a bit
Behdad Esfahbod [Mon, 22 Oct 2018 02:23:11 +0000 (19:23 -0700)]
[color] Rename / reorder a bit

Implement has_data() for realz.

6 years ago[cpal] Touch up palette flags
Behdad Esfahbod [Mon, 22 Oct 2018 02:08:25 +0000 (19:08 -0700)]
[cpal] Touch up palette flags

6 years ago[color] Rename "gid" to "glyph"
Behdad Esfahbod [Mon, 22 Oct 2018 02:02:47 +0000 (19:02 -0700)]
[color] Rename "gid" to "glyph"

We don't expose "gid" in API.