Tom McDonald [Wed, 16 May 2018 18:31:34 +0000 (11:31 -0700)]
Implement ICorDebugManagedCallback4::DataBreakpoint
Andrew Au [Wed, 16 May 2018 00:42:29 +0000 (17:42 -0700)]
Saving progress
Andrew Au [Tue, 15 May 2018 20:54:46 +0000 (13:54 -0700)]
ICorDebugValue -> ICorDebugObjectValue on GetContainerObject()
Andrew Au [Mon, 14 May 2018 22:52:55 +0000 (15:52 -0700)]
A dummy implementation of the GetContainerObject API
Andrew Au [Mon, 14 May 2018 17:18:38 +0000 (10:18 -0700)]
Boilerplate for adding new DBI method
Andrew Au [Thu, 10 May 2018 23:43:54 +0000 (16:43 -0700)]
Passing ICorDebugProcess instead of ICorDebugController
Andrew Au [Thu, 10 May 2018 21:49:39 +0000 (14:49 -0700)]
The GC events are now working, somewhat ...
Andrew Au [Thu, 10 May 2018 16:39:33 +0000 (09:39 -0700)]
Make sure we block after sending the events
Andrew Au [Wed, 9 May 2018 16:40:47 +0000 (09:40 -0700)]
Saving progress - works towards gc events
Andrew Au [Fri, 4 May 2018 20:33:12 +0000 (13:33 -0700)]
Add x86 data breakpoint support
Cagri (Charlie) Aslan [Wed, 28 Mar 2018 02:39:16 +0000 (19:39 -0700)]
Initial data breakpoint changes
temporary changes towards multiple data breakpoints
add multiple hardware bp support
Remove Complus.log
revert log.cpp changes
Jeremy Koritzinsky [Wed, 7 Nov 2018 00:26:40 +0000 (16:26 -0800)]
Disable running ILAsm round-trip build on COM Tests (#20822)
* Disable running ILAsm round-trip build on COM (requires ilasm resource embedding support).
* ILAsmTestKind -> IlrtTestKind
Tomas Weinfurt [Tue, 6 Nov 2018 23:10:18 +0000 (15:10 -0800)]
try to use exclude on same line as Include instead of remove in separate step (#20846)
Jack Pappas [Tue, 6 Nov 2018 23:07:47 +0000 (18:07 -0500)]
Loop-free GC rounding helpers with _BitScanReverse. (#20157)
Jeremy Koritzinsky [Tue, 6 Nov 2018 21:33:29 +0000 (13:33 -0800)]
Remove /RESOURCE flag documentation on ilasm. (#20818)
* Remove /RESOURCE flag on ilasm.
* Revert "Remove /RESOURCE flag on ilasm."
This reverts commit
7d1a9ac959a94359d2f1ef5f70ec7041804ec6f4.
* Update documentation in ilasm switches.
* Update documentation to say that the obj file has to come from a .res file.
* Remove documentation of the /RESOURCE switch. Leave the switch code-path in place for corefx.
Levi Broderick [Tue, 6 Nov 2018 19:02:16 +0000 (11:02 -0800)]
Improve performance of Memory<T>.Span property getter (#20386)
- We can use our knowledge of object representation in the runtime to speed up type checks.
- We leave the ref T and the length deconstructed until the very end, optimizing register usage.
- The Length property getter is once again just a simple field accessor with no bitwise logic.
Bruce Forstall [Tue, 6 Nov 2018 18:52:40 +0000 (10:52 -0800)]
Merge pull request #20633 from BruceForstall/FixSPCheck
Fix SP check for x64/x86, remove for arm32/arm64
Mike McLaughlin [Tue, 6 Nov 2018 18:42:53 +0000 (10:42 -0800)]
Enable SyncBlk for xplat SOS (#20830)
Add SyncBlk to xplat SOS.
Sergey Andreenko [Tue, 6 Nov 2018 18:24:37 +0000 (10:24 -0800)]
fix corefx folder (#20828)
Bruce Forstall [Tue, 6 Nov 2018 17:52:29 +0000 (09:52 -0800)]
Merge pull request #20834 from BruceForstall/FixArmElJob
Fix corefx folder for Tizen job
Bruce Forstall [Tue, 6 Nov 2018 17:28:45 +0000 (09:28 -0800)]
Fix corefx folder for Tizen job
https://ci.dot.net/job/dotnet_coreclr/job/master/job/armel_cross_checked_tizen_innerloop_prtest/
Oded Hanson [Tue, 6 Nov 2018 16:31:49 +0000 (18:31 +0200)]
Added support for running in a sandbox on Mac (#20735)
* Added support for running in a sandbox on Mac
When running in a sandbox, the Mac operating system will limit access to resources, esp. the file system. Right now both Mutex and SharedMemory in the PAL are accessing the /tmp folder for which Mac does not provide the application permissions to access.
Instead, the sandbox provides the ability to share information between applications by using a shared container folder. This is done by registering the application with an Application Group ID. Using this ID, we can access the shared folder and read/write from it.
Since the .Net runtime can be loaded in multiple ways, we decided that the easiest way to let the runtime know what the application group ID is via an environment variable. Thus, if the NETCOREAPP_SANDBOX_APPLICATION_GROUP_ID environment variable is set (on Mac), the runtime will assume we are sandboxed, and will use the value provided as the application group ID. Note that due to limitations on semaphore file lengths, we will not allow application group IDs longer than 13 characters. This gives us 10 characters for the developer ID, and 3 extra characters for the group name.
When sandbox is disabled (the environment variable is empty) then the folder for Mutex and SharedMemory will continue to be rooted in /tmp. However when the sandbox is enabled, these files will be created under /user/{loginname}/Library/Group Containers/{AppGroupId}/.
Fixes #20473
* Made gApplicationContainerPath a pointer so it does not get automatically deleted by the c runtime
* Made s_runtimeTempDirectoryPath and s_sharedMemoryDirectoryPath pointers so they are not automatically deleted by the c runtime
* Renamed gApplicationContainerPath to gSharedFilesPath
* Renamed NETCOREAPP_SANDBOX_APPLICATION_GROUP_ID to DOTNET_SANDBOX_APPLICATION_GROUP_ID
* Fixed usage of VerifyStringOperation
* Replaced new with InternalNew
* Wrapped Apple specific code with #ifdef
* Added exception handling during close
* Moved VerifyStringOperation macro into SharedMemoryManager
* Moved PathCharString variable declarations before AutoCleanup is declared.
* Fixed initialization functions not to throw
* Renamed CopyPath to BuildSharedFilesPath
* Fixed misc nits
* Fixed implicit conversions from BOOL to bool
* Moved MAX_APPLICATION_GROUP_ID_LENGTH inside ifdef APPLE
* Removed PAL_IsApplicationSandboxed
Bruce Forstall [Tue, 6 Nov 2018 02:41:16 +0000 (18:41 -0800)]
Fix calling convention for 3 p/invoke test cases
Bruce Forstall [Fri, 26 Oct 2018 07:06:38 +0000 (00:06 -0700)]
Fix SP check for x64/x86, remove for arm32/arm64
The actual checking had gotten lost between JIT32 and RyuJIT.
I fixed the "on return from function" case for x86/x64, and
the "around every call site" case for x86.
I removed the arm64 case because it's not easy to store SP to a
stack local or directly compare SP against a stack local without
a temporary. Also, for the fixed outgoing arg space ABIs (all but x86),
these checks don't seem too useful anyway, so I also removed the
arm case.
Mike McLaughlin [Tue, 6 Nov 2018 00:43:03 +0000 (16:43 -0800)]
Exclude FreeBSD symbol packages from symbol uploader (Part 3) (#20824)
Levi Broderick [Tue, 6 Nov 2018 00:06:32 +0000 (16:06 -0800)]
Add support for BSWAP intrinsic (#18398)
With this change, the JIT will recognize a call to BinaryPrimitives.ReverseEndianness and will emit a bswap instruction.
This logic is currently only hooked up for x86 and x64; ARM still uses fallback logic.
If the JIT can't emit a bswap instruction (for example, trying to emit a 64-bit bswap in a 32-bit process), it will fall back to a software implementation, so the APIs will work across all architectures.
Tanner Gooding [Mon, 5 Nov 2018 23:37:36 +0000 (15:37 -0800)]
Adding some new functions to System.Math and System.MathF (#20788)
* Adding BitIncrement, BitDecrement, CopySign, MaxMagnitude, and MinMagnitude to Math and MathF
* Adding FusedMultiplyAdd, IlogB, Log2, and ScaleB to Math and MathF
* Adding some basic PAL tests for fma, ilogb, log2, and scalbn
* Fixing a couple typos and adding clarifying comments
* Fixing the MSVC _VVV FCALL declarations
Tanner Gooding [Mon, 5 Nov 2018 23:37:14 +0000 (15:37 -0800)]
Updating the importer to throw a NotImplementedException if it finds a mustExpand intrinsic that it can't expand (#20792)
* Updating the importer to throw a NotImplementedException if it finds a mustExpand hwintrinsic that it can't expand
* Updating the JITEEVersionIdentifier
Krzysztof Wicher [Mon, 5 Nov 2018 18:48:53 +0000 (10:48 -0800)]
Improve/fix SerialStream.Dispose (dotnet/corefx#33221)
* Improve/fix SerialStream.Dispose
* Review feedback
* remove unused using statement
* Use ToFileDescriptor
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Brian Sullivan [Mon, 5 Nov 2018 23:13:05 +0000 (15:13 -0800)]
Merge pull request #20736 from briansull/issue_18672
Fix ValueNumber constant propagation with nested structs
Tobias Loew [Mon, 5 Nov 2018 19:28:01 +0000 (20:28 +0100)]
Fiber-friendly Vectored Exception Handling (#20746)
* Fiber-friendly Vectored Exception Handling
Check during exception handling if the cached and the current stack-base match to detect Fibers.
Brian Sullivan [Thu, 1 Nov 2018 00:11:38 +0000 (17:11 -0700)]
Fix constant propagation with nested structs
Fixes #18672
Test case is here: JIT/Regression/JitBlue/GitHub_18672/GitHub_18672.cs
Matt Galbraith [Mon, 5 Nov 2018 18:03:38 +0000 (10:03 -0800)]
Bump FreeBSD AzDO build timeout to 90 minutes
Sergey Andreenko [Mon, 5 Nov 2018 17:03:43 +0000 (09:03 -0800)]
Fix perf regression in master. (#20762)
* Fix comments.
We count implict byref argument occurrences for all lclVars not only for promoted.
* Fix the regression.
Return the old behaiour where both parent and promoted lclVar have updated ref counters.
* rename `UpdateImplicitByRefCounter` to `UpdateEarlyRefCountForImplicitByRef`
* Fix comment.
Pent Ploompuu [Sun, 4 Nov 2018 20:42:11 +0000 (22:42 +0200)]
System.Decimal code style and comments clean-up (#20793)
dotnet-maestro[bot] [Sun, 4 Nov 2018 15:49:22 +0000 (15:49 +0000)]
[Darc-Update] Update dependencies from build
20181102.21 of https://github.com/dotnet/arcade (#20783)
* Updating version files
* Updating version files
Nick Craver [Sun, 4 Nov 2018 07:11:47 +0000 (02:11 -0500)]
Optimization: Reduce many array allocations in GetCustomAtttributes()'s inherited path (#20779)
* Optimization: avoid 2 array allocations in inherited attribute misses
This is a follow-up to many allocations recognized in #20448.
A lot of methods ultimately call through CustomAttributes.GetCustomAttributes(). In the inherited search path (default for most searches above), the inheritance path of a class is traversed, resulting in an array allocation per crawled type, a copy to the overall List<object> and then after that - in current code - an array allocation from that list and a typed array allocation it's copied to.
However, in the common miss case as simple as:
typeof(T).GetCustomAttributes(typeof(TAttr), true);
...and many other overloads, all the same path underneath...
We can avoid the last 2 arrays in the miss case. We have the List<object> to go off of. If that's a zero-entry list, we can return an Array.Empty<TAttr>(). That's effectively what this change does.
While converting the entire attribute pipeline to generics is problematic and has issue since some object[] return abstracts aren't sealed, we can at least somewhat trivially cache an array per attribute type (only one static, ultimately from Array.Empty<T> underneath) and return that for the miss case.
There are far more wins to be had here, but they require more changes.
* Move RuntimeType empty array cache generation to Attribute.CreateAttributeArrayHelper
This exposes Attribute.CreateAttributeArrayHelper to internal and uses it directly on the RuntimeType caching for empty arrays. Though this allocated 1 additional array overall, it's simpler, faster to init, and still is an infinite win over the per-call allocations before this overall changesets.
* CustomAttributes: remove needless array copy in the inherited hit case
This removes a .ToArray() for the sake of Array.Copy() where a simple for loop suffices and removes the allocation. Reversing the "empty" result checks is also just a bit cleaner here.
This also expands the same fix to the MemberInfo path.
Note: should DRY these up too (longstanding issue) - but let's do that in a separate commit for clarity.
* GetCusomAttributes: use ListBuilder<object> for inheritance crawls
This exposes RuntimeType.ListBuilder<T> for internal usage and replaces the List<T> allocation in GetCustomAttributes() paths to reduce allocations and increase performance in the inherited crawl paths (which is the default for many optional-parameter methods in layers above).
Note: there is a subtle behavior depending on previous-null (not possible with a struct now) in AttributeUsageCheck() that I believe still behaves correctly, but could use another set of eyes and a full test suite run to confirm. object[] attributes was removed there simply because it wasn't used before - only cleaning up.
* Attribute caching: use Array.CreateInstance() directly on RuntimeType
This also reverts the CreateAttributeArrayHelper => internal change, since it's no longer needed.
* Ref passing for RuntimeType.ListBuilder<object> & CustomAttribute simplification
This fixes the struct passing duplication and tweaks how we're creating arrays a bit, centralizing the zero-element checks to cover all cases as well as simplify the per-method code to rely on the fact this is happening underneath.
Jan Kotas [Sat, 3 Nov 2018 23:14:10 +0000 (16:14 -0700)]
Improve error messages for byref-like type loading errors (#20789)
Related to dotnet/corefx#33233
Bruce Forstall [Sat, 3 Nov 2018 22:23:17 +0000 (15:23 -0700)]
Merge pull request #20780 from dotnet/dev/unix_test_workflow
PMI asm diffs changes
Wraith2 [Sat, 3 Nov 2018 20:54:23 +0000 (20:54 +0000)]
Add StringBuilder.Append(ROM<char>) (#20773)
* added Append(ROM<char>)
* address feedback
* revert sln
dotnet-maestro-bot [Sat, 3 Nov 2018 20:49:44 +0000 (13:49 -0700)]
Update CoreFx, CoreSetup, IbcData, PgoData to preview.18553.3, preview-27103-01, master-
20181103-0046, master-
20181103-0042, respectively (#20785)
Jan Kotas [Sat, 3 Nov 2018 16:45:30 +0000 (09:45 -0700)]
Cleanup and improve name formatting in reflection (#20781)
* Delete internal Array.UnsafeCreateInstance method
* Delete binary serialization specific type name formatting
* Use ValueStringBuilder to format method names in reflection
dotnet-maestro-bot [Sat, 3 Nov 2018 12:31:32 +0000 (05:31 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, IbcData, PgoData to preview1-03402-01, preview-27102-02, preview.18552.1, preview-27102-03, master-
20181102-0044, master-
20181102-0041, respectively (master) (#20745)
* Update BuildTools, CoreClr, CoreFx, CoreSetup, IbcData, PgoData to preview1-03402-01, preview-27102-02, preview.18552.1, preview-27102-03, master-
20181102-0044, master-
20181102-0041, respectively
* Disabled outdated test
Levi Broderick [Sat, 3 Nov 2018 02:15:43 +0000 (19:15 -0700)]
Perf improvements to Span and Memory (#20771)
* Perf improvements to Span and Memory
- Improves perf of AsSpan, AsMemory, ctor, and Slice
* PR feedback - add comments
Stephen Toub [Sat, 3 Nov 2018 02:08:35 +0000 (22:08 -0400)]
Use C# compiler's static data support in Encoding.Preamble (#20768)
* Use C# compiler's static data support in Encoding.Preamble
Also avoid Array.Empty and just use default span for an empty preamble.
* Address PR feedback
Stephen Toub [Sat, 3 Nov 2018 00:51:26 +0000 (20:51 -0400)]
Add remaining IAsyncDisposable implementations to CoreLib (#20676)
* Add remaining IAsyncDisposable implementations to CoreLib
* Address PR feedback
Andrew Au [Sat, 3 Nov 2018 00:22:36 +0000 (17:22 -0700)]
Fix logging so that we can see the full 64 bit integer in the log file (#20741)
Levi Broderick [Sat, 3 Nov 2018 00:15:47 +0000 (17:15 -0700)]
Improve performance of String.Equals(..., OrdinalIgnoreCase) (#20734)
- Tries to consume multiple chars in parallel when possible
- Didn't vectorize because inputs to this function are generally fairly small
- Moved static GlobalizationMode lookup out of hot path
- Removed indirection so that StringComparer now calls directly into workhorse routine
Bruce Forstall [Fri, 2 Nov 2018 21:27:02 +0000 (14:27 -0700)]
Merge pull request #20769 from BruceForstall/FixArm
Need to archive and transfer the Product directory for Linux arm/arm64
Juan Hoyos [Fri, 2 Nov 2018 20:48:49 +0000 (13:48 -0700)]
Merge pull request #20760 from hoyosjs/arcade
Add base arcade scripts and versioning files
Bruce Forstall [Fri, 2 Nov 2018 20:47:35 +0000 (13:47 -0700)]
Merge pull request #20770 from BruceForstall/EnableMoreDiffs
Do PMI diffs on frameworks and benchmarks
Bruce Forstall [Fri, 2 Nov 2018 20:45:59 +0000 (13:45 -0700)]
Do PMI diffs on frameworks and benchmarks
Maryam Ariyan [Fri, 2 Nov 2018 20:42:11 +0000 (13:42 -0700)]
Allows Debug.Fail to go through Trace Listeners (#20764)
Bruce Forstall [Fri, 2 Nov 2018 20:39:53 +0000 (13:39 -0700)]
Need to archive and transfer the Product directory for Linux arm/arm64 PMI diffs
Stephen Toub [Fri, 2 Nov 2018 16:52:42 +0000 (12:52 -0400)]
Avoid unnecessary interlocked in ManualResetValueTaskSourceCore (#20742)
When a ManualResetValueTaskSourceCore is used as the implementation for a ValueTask, it's set up for the operation, and then two things happen: a callback is hooked up at some point, and the operation completes at some point. The former generally occurs before the latter, however there is a race condition, and so both paths currently use an Interlocked.CompareExchange to coordinate. But that means that we always end up with two CompareExchange operations. In the common path, there's no contention between these, and so we can avoid one of the CompareExchanges by first doing a normal read of the target field (we were already doing that read in one of the two cases, but we weren't taking advantage of it).
Sergey Andreenko [Fri, 2 Nov 2018 00:43:17 +0000 (17:43 -0700)]
Fix the test. (#20701)
As https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.gchandle.free?view=netframework-4.7.2 says "The caller must ensure that for a given handle, Free is called only once.".
So delete the second call to `Free()`.
I believe it changes the desired behaviour for this test but it was added before 2010 (via source depo) and there are no comments about the regression that it was able to repro, so it is not worth to investigate that.
Eugene Rozenfeld [Fri, 2 Nov 2018 00:19:34 +0000 (17:19 -0700)]
Remove redundant zero-initializations for long-lifetime structs. (#20753)
When compInitMem is true long-lifetime structs (i.e., the ones with lvIsTemp set to false)
are zero-initialized in the prolog: https://github.com/dotnet/coreclr/blob/
c8a63947382b0db428db602238199ca81badbe8e/src/jit/codegencommon.cpp#L4765
Therefore, these structs don't need an explicit zero-initialization in blocks that are not in a loop.
Juan Sebastian Hoyos Ayala [Thu, 1 Nov 2018 20:59:59 +0000 (13:59 -0700)]
Add base arcade scripts and versioning files
Mike McLaughlin [Thu, 1 Nov 2018 22:08:17 +0000 (15:08 -0700)]
Fix freebsd symbol upload failure. (#20759)
Tomas Weinfurt [Thu, 1 Nov 2018 21:39:42 +0000 (14:39 -0700)]
one more place to add case for freebsd (#20756)
Egor Bogatov [Thu, 1 Nov 2018 21:13:10 +0000 (00:13 +0300)]
Display offset in TimeZoneInfo.DisplayName (#20728)
* Display offset in TimeZoneInfo.DisplayInfo
* Display offset in TimeZoneInfo.DisplayInfo
* prefer +00.00
* Update TimeZoneInfo.Unix.cs
Bruce Forstall [Thu, 1 Nov 2018 21:07:15 +0000 (14:07 -0700)]
Merge pull request #20755 from dotnet/dev/unix_test_workflow
Enable triggers for Linux x64 PMI asm diffs
Bruce Forstall [Thu, 1 Nov 2018 20:03:43 +0000 (13:03 -0700)]
Merge pull request #20752 from BruceForstall/EnableLinuxX64PmiDiffs
Fix PMI job triggers for x64 Linux
Bruce Forstall [Thu, 1 Nov 2018 19:49:42 +0000 (12:49 -0700)]
Merge pull request #20750 from BruceForstall/ReduceExpectedTestCount
Fix expected Pri-1 test count
Jan Kotas [Thu, 1 Nov 2018 19:11:20 +0000 (12:11 -0700)]
Disable outdated CoreFX tests (#20749)
Bruce Forstall [Thu, 1 Nov 2018 18:44:51 +0000 (11:44 -0700)]
Fix PMI job triggers for x64 Linux
Also, convert asm from ZIP to tar on non-Windows.
Matt Mitchell [Thu, 1 Nov 2018 18:01:57 +0000 (11:01 -0700)]
Merge pull request #20720 from dotnet/mmitche-patch-1
preview1 -> preview
Bruce Forstall [Thu, 1 Nov 2018 17:56:53 +0000 (10:56 -0700)]
Fix expected Pri-1 test count
https://github.com/dotnet/coreclr/pull/20693 reduced the number of
Pri-1 tests significantly, which caused this error to appear on
some Pri-1 builds, e.g., Ubuntu x64 Checked builds.
Bruce Forstall [Thu, 1 Nov 2018 17:46:41 +0000 (10:46 -0700)]
Fix JIT flags for ARM64 altjit (#20711)
The ARM64 altjit was interpreting some JIT flags from the (mismatched)
x64 runtime incorrectly: they actually specify x64 architecture
capabilities, not ARM64 capabilities. And some of these capabilities
are not fully implemented/tested, so were leading to crashes doing
altjit asm diffs.
Mike McLaughlin [Thu, 1 Nov 2018 17:14:39 +0000 (10:14 -0700)]
Workaround FreeBSD symbol publishing problem. (#20733)
Issue #https://github.com/dotnet/coreclr/issues/20722
Bruce Forstall [Thu, 1 Nov 2018 16:59:04 +0000 (09:59 -0700)]
Update PMI asm diffs in the CI (#20743)
* Respond to PMI asm diffs code review feedback
Add some try/finally code to improve robustness.
Remove direct invocation of run.cmd.
Also, simplify the generated asm directory hierarchy.
* Improve PMI script error code
Only return non-zero if there is a fatal error. For non-fatal error,
such as the existence of asm diffs, return zero. This will allow
subsequent "build" steps in netci.groovy to run, namely, the
archiving of the asm directory.
Later, determine a better way figure out how to deal with the existence
of asm diffs.
* Update dotnet SDK download links
Maryam Ariyan [Thu, 1 Nov 2018 03:18:02 +0000 (20:18 -0700)]
corert compile fixes, corert class Debug should be partial and s_WriteCore need to be assigned
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jack Pappas [Thu, 1 Nov 2018 05:50:23 +0000 (01:50 -0400)]
Make BitScanForward/BitScanForward64 PAL wrappers branchless. (#20412)
The BitScanForward/BitScanForward64 wrapper functions from the PAL and
gcenv have been modified so they're faster (and branchless), while also
adhering more closely to the behavior of the MSVC intrinsics.
Use _BitScanForward64 when targeting 64-bit Windows.
The _WIN32 macro is always defined by MSVC, even when targeting 64-bit
versions of Windows. Use the _WIN64 macro instead to check whether the
build is targeting 64-bit Windows, and if so, use the _BitScanForward64
intrinsic for the BitScanForward64 wrapper instead of the 32-bit-based
fallback.
dotnet-maestro-bot [Thu, 1 Nov 2018 03:03:51 +0000 (20:03 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, IbcData, PgoData to preview1-03330-01, preview1-27031-03, preview1.18530.5, preview1-27031-02, master-
20181031-1450, master-
20181031-1447, respectively (#20665)
Jeremy Koritzinsky [Thu, 1 Nov 2018 00:56:38 +0000 (17:56 -0700)]
Clean up string literal implicit const casting and some two-phase lookup nits on Windows (#20730)
* Remove implicit c-string const casting and clean up some C++ standards conformance bugs.
* Fix const string conversion in FCSigCheck.
Jan Kotas [Wed, 31 Oct 2018 20:43:20 +0000 (13:43 -0700)]
Detect integer overflow in String.Replace
Fixes #20719
Jan Kotas [Wed, 31 Oct 2018 18:19:32 +0000 (11:19 -0700)]
Fix corrupted StringBuilder state after out of memory exception
Fixes #20718
Jeremy Koritzinsky [Tue, 30 Oct 2018 23:30:16 +0000 (16:30 -0700)]
Make the check for a struct fitting in a register check for either managed or native depending on the situation (i.e. managed call, reflection, P/Invoke) instead of only for managed. Fixes #20702.
Clean up duplicate #ifdefs.
Move #ifdef into method impl instead of outside the implementations.
Move IsRegPassedStruct out of UNIX_AMD64_ABI #ifdef.
Move check for enregistered struct out of UNIX_AMD64_ABI #ifdef
Add dummy implementation of IsRegPassedStruct and IsNativeStructPassedInRegisters when UNIX_AMD64_ABI isn't defined.
Jiang Zeng (Pactera Technologies Inc) [Wed, 8 Aug 2018 09:19:42 +0000 (02:19 -0700)]
Add PInvoke/Structures tests
Fix compile warnings
Fix compile warnings
Fix compile warnings
Remove duplicate tests. Move ReversePinvoke tests under StructMarshalling.
Clean up some compile errors.
More string cleanup.
More string fixes
Clean up consts and typedefs.
Fix typo.
Change TP_slen return type to match xplatform.h
Fix printf specifiers.
Don't define wcslen in xplatform if it's been macro redefined (to platformdefines.h's TP_slen)
Fix build breaks.
Remove extension from DllImport so it will correctly resolve xplat.
Fix printf specifiers again...
Fix Windows x86 calling convention mismatch.
Fix HRESULT size off-Windows
Zeng Jiang [Thu, 1 Nov 2018 00:02:52 +0000 (08:02 +0800)]
Add PInvoke/NativeCallManagedComVisible tests (#19328)
* Add PInvoke/NativeCallManagedComVisible tests
* Update to current infrastructure and disable off-Windows
* Fix incorrect S_OK value and made the native side actually return an HRESULT in hr.
Carol Eidt [Wed, 31 Oct 2018 23:51:17 +0000 (16:51 -0700)]
Merge pull request #20683 from CarolEidt/FixDD710234
Arm32: Handle live-out double reg in resolution
Bruce Forstall [Wed, 31 Oct 2018 22:06:24 +0000 (15:06 -0700)]
Merge pull request #20723 from BruceForstall/ImproveNOWAYOutput
Improve the assert output for NO_WAY and BADCODE
Tomas Weinfurt [Wed, 31 Oct 2018 21:58:06 +0000 (14:58 -0700)]
more changes to fix packaging on FreeBSD. runtime.json now contains freebsd-x64 and portable build/packaging works (#20725)
Maryam Ariyan [Wed, 31 Oct 2018 21:32:19 +0000 (14:32 -0700)]
Making Debug and Trace behavior consistent with eachother and Desktop (#20581)
* Making Debug and Trace behavior more consistent with Desktop and eachother
* Syncs IndentLevel and IndentSize for Debug and Trace
* Completing DebugProvider APIs. Fixing Indentation bugs
* Make WriteCore public
* Make s_provider and s_indentSize volatile
* Applied PR feedbacks
Michał Janiszewski [Wed, 31 Oct 2018 20:30:48 +0000 (21:30 +0100)]
Remove superfluous 'const' qualifier from trivial return types (#20652)
The 'const' used in this context has no meaning
Jarret Shook [Wed, 31 Oct 2018 19:52:19 +0000 (12:52 -0700)]
Re-Enable Windows tests with JitOptSensitive flag (#20697)
* Re-Enable windows with JitOptSensitive flag
The check in batch targets would keep us from running jitOptimiztionSensitiveTests
with COMPlus_TieredCompilation=0.
* Address pr feedback
Sergey Andreenko [Wed, 31 Oct 2018 19:13:25 +0000 (12:13 -0700)]
Fix DevDiv issue with JitStressRegs=0x3 on arm32. (#20485)
* Fix the issue.
* Fix the comment.
* update the comment
Bruce Forstall [Wed, 31 Oct 2018 17:59:44 +0000 (10:59 -0700)]
Improve the assert output for NO_WAY and BADCODE
Include the file and line number information that we already have.
Jan Vorlicek [Wed, 31 Oct 2018 17:02:36 +0000 (18:02 +0100)]
Fix Windows x86 EH for exception from UMThunkPrestub (#20704)
The exception handling was poping an explicit frame in
UMThunkPrestubHandler down the call chain from CallRtlUnwindSafe, but it
was not updating the tct.pBottomFrame after returning from that function
back to CPFH_RealFirstPassHandler. And the call to COMPlusAfterUnwind
then called UnwindFrames starting at the old frame that was already
removed from the chain.
Egor Chesakov [Wed, 31 Oct 2018 16:28:09 +0000 (09:28 -0700)]
Work around XUnit FileLoadException issues (#20644)
In order to mitigate System.IO.FileLoadException we built our own xunit.console.dll with ConcurrentDictionary used for DependencyContextAssemblyCache.managedAssemblyCache instead of Dictionary and use this instead of the one pulled from NuGet.
Carol Eidt [Mon, 29 Oct 2018 23:05:25 +0000 (16:05 -0700)]
Arm32: Handle live-out double reg in resolution
When handling critical edges, live-in and live-out reg masks must contain both halves of double regs.
Carol Eidt [Wed, 31 Oct 2018 15:42:48 +0000 (08:42 -0700)]
Merge pull request #20638 from fiigii/movetest
Move SSE/SSE2/AVX Load* intrinsic tests to the template framework
Matt Mitchell [Wed, 31 Oct 2018 15:17:09 +0000 (08:17 -0700)]
preview1 -> preview
.NET Core 3.0 previews should not have numeric suffixes.
Bruce Forstall [Wed, 31 Oct 2018 06:57:20 +0000 (23:57 -0700)]
Merge pull request #20710 from BruceForstall/DisableNonPRJobsMaster
Disable non-PR triggers in dev/unix_test_workflow branch
Bruce Forstall [Wed, 31 Oct 2018 06:37:20 +0000 (23:37 -0700)]
Disable non-PR triggers in dev/unix_test_workflow branch
Jan Kotas [Wed, 31 Oct 2018 02:47:26 +0000 (19:47 -0700)]
Delete redundant framework API tests (#20693)
This is the last batch of deleting tests that are obviously redundant. The remaining framework API tests in CoreCLR can be dealt with as needed if it ever becomes a problem.
Fixes #12782
David Wrighton [Wed, 31 Oct 2018 01:05:39 +0000 (18:05 -0700)]
Add support for large number of argumets in CCW call on Arm64 (#20670)
* Fix CCW with large numbers of arguments on arm64
- Correctly align the stack in COMToCLRDispatchHelper
- Add tests for naturally 16 byte aligned stack growth, and non-aligned growth
* New many arguments COM test
* Add support for the IL stub ETW diagnostic event
Matt Galbraith [Tue, 30 Oct 2018 23:06:29 +0000 (16:06 -0700)]
Merge pull request #20703 from MattGal/bsd-pipebuild-tweaks
Remove DotNetBootstrapCliTarPath from variables
Sergey Andreenko [Tue, 30 Oct 2018 23:04:24 +0000 (16:04 -0700)]
Fix printing in `CodeGen::siEndScope`. (#20698)
lastsannin [Tue, 30 Oct 2018 23:03:00 +0000 (00:03 +0100)]
Fixed small typo in a comment (#20695)
fixed a simple typo, "co-" should contain a dash in this case.