Youngcheol Kang [Tue, 11 Aug 2015 11:04:57 +0000 (20:04 +0900)]
[M44_2403] Add arm64 support to ffmpeg
We need to regenerate this arm64 support patch in ffmpeg
until ffmpeg supports arm64 architecture in mainstream.
The following commands were executed within arm64 GBS wayland chroot:
$ # enter chroot
$ gbs chroot --root
~/GBS-ROOT-3.0-MOBILE-ARM64-WAYLAND/local/BUILD-ROOTS/scratch.aarch64.0/
$ # copy over src/third_party/ffmpeg to chroot (e.g.: /home/abuild)
$ cd ffmpeg
$ ./chromium/scripts/build_ffmpeg.py linux arm64
$ ./chromium/scripts/copy_config.sh
$ # edit chromium/scripts/generate_gyp.py; add "arm64" to support
platforms.
$ python chromium/scripts/generate_gyp.py
$ edit ffmpeg.gyp; add "asm_sources" to the build
$ # generate the patch against a unchanged ffmpeg copy
This patch referred to http://165.213.202.130/gerrit/#/c/80261
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14159
Reviewed by: Antonio Gomes, joonhwan kwon
Change-Id: Ic7e6b1a8ab9b3976f0cf3fc3eafb2a7d9202708a
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngsoo Choi [Fri, 7 Aug 2015 03:43:50 +0000 (12:43 +0900)]
Remove dependencies of tizen v2.2.1
The tizen v2.2.1 is not supported anymore.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14148
Reviewed by: SeungSeop Park, Antonio Gomes
Change-Id: I3072ff0cf6825caaf8cc487061df9ee0c3aae7d9
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Antonio Gomes [Thu, 6 Aug 2015 22:05:21 +0000 (18:05 -0400)]
[dev/m42][uBrowser] No selection handler on long text
Our text selection and context menu code has some logic
to _not_ show the context menu when it calculates handles
are not positioned properly. See for example, some of cases
returning 'false' in ContextMenuControllerEfl::ShowContextMenu.
This has two problems:
1) It only takes into account the "start" handle, and no
matter if the "end" handle were onscreen, it was ignored.
2) It was not only not showing the context menu.
By returning "false" in ContextMenuControllerEfl::ShowContextMenu,
selection was actually canceled, leaving SelectionController
and the renderer process selection code out of sync.
In s-browser (verified on S6) context menu is not shown
if both handles are offscreen and the selected content itself
is also offscreen.
Patch makes us behavior similarly to s-browser by.
implementing the first patch of the behavior described:
if no handles are on screen (i.e. both are scrolled away from
viewport), do not show the context menu.
Another big different from the previous behavior is that
we do not leave selection mode when handles are offscreen.
Instead, we do not show context menu only. Once handles
are onscreen again, context menu is shown just fine.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13431
Reviewed by: SeungSeop Park
Change-Id: Ic39d9497f2fa4400096bd8c8356183b0cab760d6
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Thu, 6 Aug 2015 22:05:49 +0000 (18:05 -0400)]
Make context menu available on desktop builds.
By setting the "copypaste" which is Tizen specific,
context menu fails to show.
Patch makes this workaround (as per the comment describing
it) OS Tizen specific.
Reviewed by: SeungSeop Park
Change-Id: Ie3342b1e50ca3e1d0f41bc6a4796a0e11b709428
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Youngcheol Kang [Wed, 29 Jul 2015 06:51:54 +0000 (15:51 +0900)]
[M44_2403] Chromium upversion to m44_2403 branch
This patch cherry-picked from below patches of dev/master branch,
[Origin Patch]
- [M43_2357] Chromium upversion to m43_2357 branch
(http://165.213.202.130/gerrit/#/c/79126/)
- fixup! [M43_2357] Chromium upversion to m43_2357 branch
(http://165.213.202.130/gerrit/#/c/80912/)
- Always forward touch events to the TouchEventQueue
(http://165.213.202.130/gerrit/#/c/80137/)
- [M44_2403] Chromium upversion to m44_2403 branch
(http://165.213.202.130/gerrit/#/c/81624/)
- [M44_2403][EWK_BRINGUP] modify to call WebContents::ClosePage()
(http://165.213.202.130/gerrit/#/c/82170/)
- [M44_2403][EWK_BRINGUP] modify to call RenderViewHostImpl::Blur() directly
(http://165.213.202.130/gerrit/#/c/82168/)
This patch deals with following upstream changes:
1. Folder and class name changes
- Changed the name of the LayoutThemeChromium* to the LayoutTheme*
- Changed the name of the devtools_target.h to the
devtools_target_descriptor.h. Also the namespace and path changed to
the components/devtools_discovery from the content/public/browser
- Changed the path of the content_renderer to the relative path from the
absolute path
- Changed the path of the skcanvas_video_renderer.h to the media/blink
from the media/filters
- Changed the path of the video_capture_types.h to the media/base from
the media/video/capture
- Changed the namespace and path of the devtools_http_handler.h to the
components/devtools_http_handler from the content/public/browser
Because of this the namespace of the DevToolsDelegateEfl class in
impl/ changed to the devtools_http_handler from the content
- Changed the namespace and path of the sqlite_persistent_cookie_store.h
to the net/extras/sqlite from the content/browser/net
2. API changes
- Added the CreateGPUTimingClient API in the gfx::GLContext class
- Added the CreatePlugin API in LoadablePluginPlaceholder class
- Added the DidHostRunInsecureContent, HostRanInsecureContent API in
SSLHostStateDelegate class
- Added the GetPermissionManager API in the BrowserContext class
- Added the GetFrontendResource, GetPageThumbnailData API in
DevToolsHttpHandlerDelegate class
- Added the GetImageTextureTarget, GetTaskGraphRunner API in
ContextFactory class
- Changed the argument of Compositor API in ui class
- Changed the argument of CreateNewWindow API in Shell class
- Changed the argument of CreateOutputSurface API in ContextFactory
class
- Changed the argument of DownloadImage API in WebContentsImpl class
- Changed the argument of DidStartLoading API in RenderViewImpl class
- Changed the argument of EnterFullscreenModeForTab API in
WebContentsDelegate class
- Changed the argument of InProcessGpuThread in content class
- Changed the argument of ReadbackYUV API in ReadbackYUVImpl class
- Changed the argument of RemoveReflector API in ContextFactory class
- Changed the argument of SQLitePersistentCookieStore API in net class
- Changed the argement of ReportValueChanged, SetValue, RemoveValue API
in PersistentPrefStore class
- Changed the return type of CreateReflector API in ContextFactory class
- Changed the ExecuteJavaScriptForTests API to the
ExecuteJavaScriptWithUserGestureForTests API in the RenderFrameHost
class
- Changed the GetLastActivityTime API to the GetLastActiveTime API in
the DevToolsTargetDescriptor class. Also the return type was changed
to the base::Time from the base::TimeTicks
- Changed the OnUnmaskVerificationResult, GetRapporService,
PropagateAutofillPredictions, IsAutocompleteSavingEnabled API in
AutofillClient class
- Changed the PermissionType class to enum class
- Removed the Blur API in RenderWidgetHostView class
- Removed the BundlesFrontendResources, GetDebugFrontendDir API in
DevToolsHttpHandlerDelegate class
- Removed the CreateMediaSourceErrorEvent API in MediaLog Class
- Removed the CreateNewTarget, EnumerateTargets, GetPageThumbnailData
API in DevToolsManagerDelegate class
- Removed the DidCreateScriptContext API in ContentRendererClient class
- Removed the GetCompositorMessageLoop API in ContextFactory class
- Removed the IsAutocompleteSavingEnabled, DetectAccountCreationForms
API in AutofillClient class
- Removed the OrientationLock API in ScreenOrientationDelegate class
- Removed the OrientationLock, OrientationUnlock class in
WebContentsDelegate class
- Removed the ShouldForwardTouchEvent API in RenderWidgetHostImpl class
- Removed the WebContentsDestroyed API and added the ResetDialogState
API in JavaScriptDialogManager class
3. Need to change API (TODO issues)
- The icu function has been changed. Temporary using the icu of the
chromium instead of the system.
(http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13290)
- The multimedia function has been changed. Temporary disabling the
'tizen_multimedia_support' flag
(http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14037)
- The Reflector class has been changed. Temporary disabling the codes
(http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14038)
- The KillProcessAPI was removed in base class. Temporary disabling the
codes (http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14039)
- Some switch was removed in the cc::switches class. Temporary disabling
the codes (http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14040)
- The GestureConfiguration class has been changed. Temporary disabling
the 'gesture_detection' setting
(http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14041)
- The PersonalDataManager class has been changed. Temporary disabling
the codes (http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14042)
- The RequestPermission class has been changed. Temporary disabling the
codes (http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14043)
- The DevToolsHttpHandler class has been changed. Temporary disabling
the codes (http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14044)
- The g_app_info_launch_default_for_uri API was undefined in desktop
build (http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14045)
- The GPU function has been changed. Temporary disabling the
'tizen_disable_gpu_thread' flag
(http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14046)
- The build breaks in libGLESv2.gypi. For the temporary solution the
patch file into the /src/tizen_src/build/patches
(http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14048)
4. Verification
- This patch supports to the mobile and tv target on Tizen 2.4 and 3.0
- There is no build breaks in all target
- The browser (efl_webview_app, mini_browser, ubrowser) is working in
all target
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14049
Change-Id: Ic9f5cf9bde8340030ac8a296d6c324f35c547f3c
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngsoo Choi [Tue, 4 Aug 2015 09:19:50 +0000 (18:19 +0900)]
Fixing warnings of conflicted gcc switches for tizen v2.4 product tv
[issue]
There are tons of warnings like below, during build for tizen v2.4 tv.
>> warning: switch -mcpu=cortex-a15.cortex-a7 conflicts with
>> -march=armv7-a switch
[cause]
The tizen v2.4 platform provides a switch '-mcpu=cortex-a15.cortex-a7'.
Simultaneously, some of chromium gyp try to insert a switch '-march=armv7-a'.
Current gcc version does not support a combination of the switches
'-mcpu=cortex-a15.cortex-a7' and '-march=armv7-a'.
[resolve]
The options '-mcpu' and '-march' are used to schedule things appropriately
for particular chip.
>> -march=cpu-type
>> Generate instructions for the machine type cpu-type.
>> The choices for cpu-type are the same as for -mcpu.
>> Moreover, specifying -march=cpu-type implies -mcpu=cpu-type.
According to above gnu docs, march implies mcpu,
so one of them can be chosen alone.
This patch utilizes platform switch '-mcpu=cortex-a15.cortex-a7',
instead of chromium switch '-march=armv7-a' to avoid the confliction,
and another platform switch '-mtune=cortex-a15.cortex-a7' too.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14098
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I933a78c8dda63809e5aa7bf82c67c0a0cc83891f
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngcheol Kang [Wed, 5 Aug 2015 10:10:11 +0000 (19:10 +0900)]
fixup! Bringup Text selection.
Disabled the CompositedSelectionUpdate by disable-blink-features
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14120
Change-Id: Iea324e315b808581279bb6375f4d973f6d1fa4d3
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Tue, 4 Aug 2015 05:05:28 +0000 (14:05 +0900)]
Share more configuration options between desktop and Tizen builds
This patch cherry-picked from the dev/master by Laszlo Gombos
Origin Patch : http://165.213.202.130/gerrit/#/c/83779
Sharing more options makes the desktop build closer
to Tizen specific builds and enablers better simulation
of Tizen environment on desktop.
This change also disables alsa, gconf, kerberos for
desktop builds.
Bug: None.
Change-Id: I7364cf703b8f20c1692a274de7d8c0a84c8fae0e
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Antonio Gomes [Tue, 4 Aug 2015 17:32:33 +0000 (13:32 -0400)]
Introduce version-aware Tizen macros
Previously there were #if defined(TIZEN_V_XXX) guards
over the code in order to condition compilation to specific
Tizen versions.
Although it works, it is not elegant and other parts of
the source base do not use similar practice.
Instead, expanding macros are used to condition code
to a specific compiler version or alike
(see GCC_VERSION in third_party/WebKit/Source/wtf/Compiler.h).
Patch implements and deploys a set of macros to improve the code:
- TIZEN_VERSION_EQ(major,minor,patch)
- TIZEN_VERSION_AT_LEAST(major,minor,patch)
The old TIZEN_V_XXX macros are still available
to be used by our sample apps (ubrowser, mini_browser,
and efl_webview_app) through tizen_version_defines_for_apps.gypi
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=7198
Reviewed by: SeungSeop Park, arno renevier
Change-Id: Id1df977540edfa95b2eb509db4743539157c3922
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Umesh Kumar Patel [Fri, 31 Jul 2015 06:44:50 +0000 (12:14 +0530)]
[MM] Enabling MM features for Tizen v2.4 on TV
This patch contains following change list:
1. Using software path for MM, until pixmap is enabled.
2. Using GST Port for ME, as MediaPacket is not supported.
3. Changes to use legacy capi for HawkP 2.4
4. Moved related changes tizen_multimedia_use_capi_for_me
to media_efl.gypi
5. Removed ASM related obsolete files
6. Other dependency and build error changes
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14072
Reviewed by: SeungSeop Park, Sharath Kamath
Change-Id: I1af848361483ed6d0dae0101621db02ec9884bbc
Signed-off-by: Umesh Kumar Patel <umeshk.patel@samsung.com>
DongJun Kim [Thu, 30 Jul 2015 11:23:58 +0000 (20:23 +0900)]
Implement ssl_host_state_delegate
Certificate popup have always showing up,
because certificate decisions are not remembering on "blink" side.
"ssl_host_state_delegate" is for managing decisions from user,
but it was not implemented on latest code.
We need to add it for resolving this issue.
Reviewed by: Hyunhak Kim, Janusz Majnert
Change-Id: I9d11b7414816431047c91a6c87cd83d93a9db192
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
ws29.jung [Wed, 22 Jul 2015 11:12:33 +0000 (20:12 +0900)]
[MM] Proper use of tts_get_speed_range()
We should pass non-null parameters to |tts_get_speed_range|.
Otherwise, invalid parameter error would be raised by TTS engine.
In addition to fixing above, patch does followings as well.
- Update the logic of converting from float rate to int speed used by
TTS engine. According to platform team, the rate-to-speed mapping varies
depending on specific TTS engine on use, but current setting is roughly
as follows:
'tts_speed' | rate
-----------------
Min. | 0.6
Normal | 1.0
Max. | 2.0
Linear interpolation method is adopted to get |tts_speed| from
an arbitrary |rate|.
- Make the private method that did the conversion as a local free function.
- Drop legacy 2.3 code path, which seems no longer valid.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13980
Reviewed by: SeungSeop Park, Sharath Kamath
Change-Id: Ic3964561b5fc8bf62d6d3e1f67c55669db978039
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
Youngcheol Kang [Tue, 4 Aug 2015 04:56:38 +0000 (13:56 +0900)]
Fix crash in WebContentsViewEfl::UpdateDragDest function
This patch cherry-picked from the dev/master by Hyunhak Kim
Origin Patch : http://165.213.202.130/gerrit/#/c/81251/
Due to patch on upsteam(https://codereview.chromium.org/
950223006/#ps150001),
UpdateDragDest function is called too early before RenderWidgetHostView is created.
So, modify to check RenderWidgetHostView value in UpdateDragDest() and call it when
creating View.
Change-Id: I8d376259e60471847537e2a5caabc3150ee885e5
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Tue, 4 Aug 2015 04:47:48 +0000 (13:47 +0900)]
[mobile][tizen v3.0] changes of sensor lib header
This patch cherry-picked from the dev/master by Youngsoo Choi
Origin Patch : http://165.213.202.130/gerrit/#/c/77837/
The header name of sensor lib has been changed
from sensor/sensors.h to sensor/sensor.h.
In addition, tizen v2.2.2 which is used only for tv doesn't
need to support the sensor feature.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12483
Change-Id: I565461557a788b43dbbc2f6f9709b46b01946eab
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Tue, 4 Aug 2015 05:01:53 +0000 (14:01 +0900)]
Mark b.kelemen, l.gombos, sl.ostapenko as inactive.
This patch cherry-picked from the dev/master by Laszlo Gombos
Origin Patch : http://165.213.202.130/gerrit/#/c/83366
This means they still qualified and authorized owners but
at the moment they not activly involved with the project.
Also sorted the inactive section.
Change-Id: If0928a883bb6c98ef6f3d3109e9d73acaaf7da08
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngsoo Choi [Mon, 3 Aug 2015 07:27:08 +0000 (16:27 +0900)]
Replacing deprecated 'efl-assist' with 'efl-extension'
The related APIs are changed to use 'efl-extension'.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14077
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I30ca226d679abc8ac3ab0f37520445bf934d32c0
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Wojciech Bielawski [Fri, 31 Jul 2015 08:40:37 +0000 (10:40 +0200)]
Added option to uBrowser to enable web inspector server.
Sometimes it's usefull to have a web inspector running on mobile/TV.
This patch provides new "context menu" option for uBrowser to start
web inspector server.
Reviewed by: Antonio Gomes, Daniel Waślicki
Change-Id: I83613375a83a1f6361a4c9a9a1a2ef10731d299d
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Pawel Forysiuk [Fri, 31 Jul 2015 09:58:34 +0000 (11:58 +0200)]
Disable v8 command line options tweaking v8 garbage collector.
They add some performance penalty and should probably be enabled
selectively only on very memory constrained devices.
Reviewed by: Antonio Gomes, kavitha devara
Change-Id: Id9f6e676fea9077b8a709577dd8e316051fa5c2a
Signed-off-by: Pawel Forysiuk <p.forysiuk@samsung.com>
Youngsoo Choi [Wed, 22 Jul 2015 01:12:35 +0000 (10:12 +0900)]
Initial support for tizen v2.4 product tv
1) Providing python acceleration
It makes generating gyp extremely faster than before.
2) Solving python-base issue with supplementary repository
This issue has been observed on tizen v2.2.1 as well.
The following patch of python-base causes errors.
>> subprocess-can-raise-OSError-EPIPE-when-communicatin.patch
3) Supporting prebuilt gold for tizen v2.4 tv
The chromium-efl built by our own prebuilt gold can not be executed
on target, so gold linker is newly built based on current platform.
4) Fixing not founding EGL header error
Following error was happened.
>> fatal error: EGL/egl.h: No such file or directory
5) Applying changed API usage of capi-appfw-application
Tizen v2.4 and v3.0 tv support the changed API usage as mobile does.
6) Disabling multi-media feature
Some of undefined multi-media variables are being used on x11.
Enabling the feature will be handled in other patch set.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14033
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: If510789d3e8990867ddd3618e072c43bbba0ab37
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Antonio Gomes [Wed, 29 Jul 2015 17:15:13 +0000 (13:15 -0400)]
Remove gcc46_compat_wrappers default include path
This directory does not exist anymore, since we
remove GCC 4.6 support.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12987
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I1acc42eb14e59900840c19bf5f9f735472f2ec16
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Wed, 29 Jul 2015 21:59:22 +0000 (17:59 -0400)]
Unify LOCALE_DIR resolve logic for desktop and GBS builds
Patch uses similar logic then EDJE_RESOURCES_DIR,
and eliminates more #if in our more.
Reviewed by: Janusz Majnert, SeungSeop Park
Change-Id: I45844c0a67cecf6c1801712aa4c4d85fa2b0c6c4
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Wed, 29 Jul 2015 20:20:22 +0000 (16:20 -0400)]
fixup! Make text selection feature available on desktop builds.
The original patch [1] had one problem:
No matter if one makes a debug or release build,
the value passed to GYP was the same, e.g.:
"$ build_desktop.sh --debug"
... was going to pass "-Dedje_dir=out.x64/Debug" to ninja,
regardless of the build configuration (Release or Debug), as show below.
$ grep -nHR edje_dir out.x64 --include=*.ninja
/out.x64/Debug/obj/content/content_common.ninja:
'-DEDJE_DIR="/path>/out.x64/Debug/resources"'
/out.x64/Release/obj/content/content_common.ninja:
'-DEDJE_DIR="/path>/out.x64/Debug/resources"'
See "Debug" in both ninja files.
To fix that, patch passes only the generic "out" directory to GYP,
and yields to GYP the responsibility to identify the build configuration.
"out" will allow us to use the logic to unify more codepaths,
including LOCALE_DIR.
[1] http://165.213.202.130/gerrit/#/c/84154/
Reviewed by: Janusz Majnert, SeungSeop Park
Change-Id: I6504ddb14ba4ee770701d61e26b28a108be68777
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Kamil Nowac [Wed, 15 Jul 2015 10:50:59 +0000 (12:50 +0200)]
[Chromedriver] Enable chromedriver build
Patch enables chromedriver build with --chromedriver flag
and fixes some major gypi problems.
Reviewed by: Antonio Gomes, Janusz Majnert
Change-Id: Ia51f2fb134867ae144ab76417848b01f8fde0741
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
Sebastian Stolinski [Wed, 29 Jul 2015 06:57:43 +0000 (08:57 +0200)]
[EWKAPI] Implementation features of tizen extensible api
Patch adds functions ewk_context_tizen_extensible_api_string_set
and ewk_context_tizen_extensible_api_string_getewk_object_unref
This API is requested by WRT team. WRT used this api since tizen 2.4
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11696
Reviewed by: DONGJUN KiM, Janusz Majnert, Karol Furmaniak
Signed-off-by: Sebastian Stolinski <s.stolinski@samsung.com>
Change-Id: Ib5ccf0146b6a2126d4abf12d866fd3ab86192269
Chandan Padhi [Wed, 29 Jul 2015 12:11:40 +0000 (17:41 +0530)]
Fix for black screen issue on tizen 2.4 product TV
Currently, glFlush gives black screen on tizen 2.4 product tv
similar to that in Note4 and XU3.
This patch uses glFinish instead of glFlush in SwapBuffers.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14021
Reviewed by: Antonio Gomes, DaeHyun Ko, Siba Samal, venu musham
Change-Id: I09e55ff7aaff0eb8407c28524fbc03c9c506e211
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
hh4813.kim [Fri, 24 Jul 2015 04:43:41 +0000 (13:43 +0900)]
Revert "Set same 'Source' name for chromium-efl-libs.spec and crosswalk-bin.spec"
This reverts commit
40e0e4088732224c3c812860bf065d8bd72c17e1.
Due to SR build failed on OBS, revert the commit.
Comments: build fail : chromium-efl-libs
[ 229s] + rm -rf chromium-efl-libs-42.2311.0.11
[ 229s] + /bin/gzip -dc /home/abuild/rpmbuild/SOURCES/chromium-efl-42.2311.0.11.tar.gz
[ 229s] + /bin/tar -xf -
[ 301s] + STATUS=0
[ 301s] + [ 0 -ne 0 ]
[ 301s] + cd chromium-efl-libs-42.2311.0.11
[ 301s] /var/tmp/rpm-tmp.ROzt89: line 32: cd: chromium-efl-libs-42.2311.0.11: No such file or directory
Git project: [platform/framework/web/chromium-efl]
Tag: submit/tizen_mobile/
20150721.055717
Reviewed by: Antonio Gomes, DONGJUN KiM
Change-Id: Ia500c33d83a37791f3a5c5a63c4d0dd14f381e84
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Antonio Gomes [Fri, 24 Jul 2015 20:31:36 +0000 (16:31 -0400)]
Make text selection feature available on desktop builds.
In GBS builds, we pass edje_dir value used to specify EDJ
resources' location as a GYP parameter (see -Dedje_dir in
chromium-efl.spec, for instance).
In order to have text selection on desktop builds, patch
does the same from build/common.sh.
Also, it makes GBS and desktop builds to take the same
codepath when resolving the respective edj path, eliminating
Reviewed by: Janusz Majnert, SeungSeop Park
Change-Id: Ia00bef1690f97ea77ff763718e6b36b6534fd9d0
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Pawel Forysiuk [Mon, 27 Jul 2015 08:33:58 +0000 (10:33 +0200)]
fixup! Add command line switches for memory optimization patches recently merged.
Patch disables "--grow-semi-space-by-n-pages" and
"--custom-semi-space-growth=0" switches from V8's js-flags.
It seems to introduce performance regression in sunspider 1.0.2 test.
Note that [1] only enables the switch. Feature itself was worked on in [2].
[1] http://165.213.202.130/gerrit/#/c/83144/
[2] http://165.213.202.130/gerrit/#/c/81306/
Reviewed by: Antonio Gomes, kavitha devara
Change-Id: Ic827b59966b5d505223431d84e387e7a8390d9f4
Signed-off-by: Pawel Forysiuk <p.forysiuk@samsung.com>
Chandan Padhi [Thu, 23 Jul 2015 11:34:22 +0000 (17:04 +0530)]
fixup! Implement Delegate renderer using frame buffer object on Tizen.
In delegated rendering, only one texture is used for composition of
layers(write to the texture) and drawing onto evasgl surface(read
from the texture), both in the browser process. Hence, there is no
need to hold back a pending mailbox texture.
This patch removes the unnescessary std::swap while drawing the
texture to evasgl surface.
Reviewed by: DaeHyun Ko, venu musham
Change-Id: I4d518eb44eae6703c26ad1dfee11adf23d34b2fd
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Marcin Lapinski [Fri, 17 Jul 2015 16:09:17 +0000 (18:09 +0200)]
Added custom edc file for selection handles.
This patch is nessesary because efl on odroid Tizen 3.0 platform
changed way of styling selection handles, and does not provides
style files for handles.
Reviewed by: Antonio Gomes, Janusz Majnert
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13434
Change-Id: Ic73ba7afea616ad7143c654e91622b9be5adb5a5
Umesh Kumar Patel [Thu, 23 Jul 2015 08:56:26 +0000 (14:26 +0530)]
[WCS][Plug-in] Implement Missing plug-in placeholder
Plug-ins are not supported by chromium-efl, However it is not notified
to end user.
This patch implements the missing plug-in placeholder to notify this.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13988
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13234
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: I28c0c2962514f89dcf47ab523068d87c236f7b5d
Signed-off-by: Umesh Kumar Patel <umeshk.patel@samsung.com>
k2.nagaraju [Thu, 23 Jul 2015 05:24:50 +0000 (10:54 +0530)]
fixup! [MM] CAPI port code refactor
Media duration precision lost because ConvertMilliSecondsToSeconds returns
duration as double and it is getting assigned to int.
Rollback to original code.
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: I1db828bf1c7b486f1e5bc05f6d326592682d2d16
Signed-off-by: k2.nagaraju <k2.nagaraju@samsung.com>
Antonio Gomes [Wed, 22 Jul 2015 15:06:58 +0000 (08:06 -0700)]
Fix VersionInfo::ProductNameAndVersionForUserAgent()
Our current implementation of this method returns something
that is not expected by caller sites:
Current:
- "Chromium/aa.bb.cc.dd efl-webkit 0.0.0.0".
Expected (see [1] and [2]):
- "Chromium/aa.bb.cc.dd".
This value is exposed to the engine through ContentClientEfl::GetProduct()
and currently it breaks chromedriver as one can see in [3].
Given that the "efl-webengine 0.0.0.0" suffix is not updated for one
year, it is meaningless and also break the expectation that caller
sites have, patch removes it.
[1] http://bit.ly/1Jfn4Tk
[2] http://bit.ly/1JxVjBc
[3] http://bit.ly/1KktFgA
Reviewed by: SeungSeop Park, arno renevier
Change-Id: I0016390d99f65d6731eda94fa2f24c11c7f7a5fb
Antonio Gomes [Wed, 22 Jul 2015 20:24:13 +0000 (13:24 -0700)]
Use gold linker all for non-arm64 builds on Tizen3.
Currently, we use platform gold for Tizen3 TV profile,
and our "home made" linker gold on Tizen3 Mobile profile,
no matter if it is 64bit and 32bit.
Patch changes it so that all Tizen3 ARM 32bit builds
use platform linker gold, and restrict use of our "home made"
linker on Tizen3 ARM 64bit builds, and Tizen2.
As a result, binaries are sligtly smaller:
Binary | Size Before | Size After
_________________________________________________
| xwalk | 1744736 | 1691760 |
| libchromium-ewk.so |
60752484 |
58894276 |
_________________________________________________
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9044
Reviewed by: arno renevier, mohan reddy
Change-Id: Ic33fe85ec1cbede4504d5b6c8462de0eebfb4e67
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Sanghyup Lee [Thu, 23 Jul 2015 09:57:51 +0000 (18:57 +0900)]
Clean up FileChooserControllerEfl class. Reviewed by: Antonio Gomes, Hyunhak Kim
Change-Id: I3aa1dfbe92851a5e35bc1e8d1ca6472331e862dc
Signed-off-by: Sanghyup Lee <sh53.lee@samsung.com>
Arnaud Renevier [Tue, 21 Jul 2015 21:30:52 +0000 (14:30 -0700)]
Simplify memory management in BrowserContextEfl
resource_context_ does not need to be deleted in IO thread.
set_url_request_context_getter takes direct URLRequestContextGetterEfl
pointer argument to avoid the creation of a temporary scoped_refptr
Reviewed by: Antonio Gomes, Hyunhak Kim
Change-Id: I77cae67173d96919f1c5833a91677861bf9b44a6
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Antonio Gomes [Wed, 22 Jul 2015 17:39:12 +0000 (10:39 -0700)]
fixup! Make it possible to link crosswalk against libchromium-ewk.so
Patch fixes Tizen3 mobile profile ARM 32bit build when
--xwalk parameter is passed.
Error:
[XXs] /lib/libpkgmgr_parser.so: error: undefined reference to 'smack_setlabel'
Build line:
$ tizen_src/build/build_mobile.sh --xwalk -P tzmb_v3.0_arm-wayland -A armv7l
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Hyunhak Kim, arno renevier
Change-Id: I158db5a9a479015b143e4608c07a67aa803d1067
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Tue, 21 Jul 2015 19:32:54 +0000 (12:32 -0700)]
fixup! Remove unneeded dependencies when building chromium-efl-libs and crosswalk-bin
Patch adds some explicit dependencies now needed when
building with "--xwalk".
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Hyunhak Kim, SeungSeop Park, arno renevier
Change-Id: I422eaf97aa82612906c79234201167d13995aa78
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Sanghyup Lee [Wed, 22 Jul 2015 03:41:19 +0000 (12:41 +0900)]
Scale factor should be considered in EWebView::GetScrollSize
Application can scroll the webpage by using ewk_view_scroll_by().
At that time, scroll position is calculated and stored in browser
independent of renderer.
Currently scroll position in browser dosen't changed on the page
which is scrollable only when it is scaled up. It because wrong
scrollable size which calculated without scale factor.
This patch uses scaled contents size to calculate scrollable size.
Reviewed by: Hyunhak Kim, Janusz Majnert, Karol Furmaniak
Change-Id: I2d8c9e7c9c880793d3fb51de1ada58f2fa2ab67a
Signed-off-by: Sanghyup Lee <sh53.lee@samsung.com>
Antonio Gomes [Tue, 21 Jul 2015 20:33:49 +0000 (16:33 -0400)]
fixup! Add command line switches for memory optimization patches recently merged.
Patch disables the kLimitMemoryAllocationInScheduleDelayedWork switch.
After [1], overall touch interaction got broken including link clicking.
Broken scenario: open WCS pages like gesture.html or
select_picker_test.html and try to touch/click; it fails.
Problem reproduced on target (note4) and desktop builds
(ubrowser --mobile).
Note that [1], only enables the switch. Feature itself was worked on in
[2].
[1] http://165.213.202.130/gerrit/#/c/83144/
[2] http://165.213.202.130/gerrit/#/c/81312/
Reviewed by: Karol Furmaniak, Prashant Nevase, Tomasz Weglarski
Change-Id: Ib3cb5259e574ff1cd53132ae7fc9029e01e1f80d
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
sm.venugopal [Tue, 14 Jul 2015 14:19:15 +0000 (19:49 +0530)]
[MM] Seek on pause is misbehaving
|delayed_player_state_| variable was not reset after usage. Hence player
started to play after seek.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13603
Reviewed by: SeungSeop Park, Sharath Kamath
Change-Id: I9e74da6bb552f3a0d178dc90167cbf275cebaec7
Signed-off-by: sm.venugopal <sm.venugopal@samsung.com>
Tomasz Czekala [Mon, 20 Jul 2015 12:08:24 +0000 (14:08 +0200)]
Implement ewk_view_page_zoom_get/set
Added implementation for ewk_view_page_zoom_get/set and fixed
implementation for ewk_view_text_zoom_get/set, which was setting page
zoom instead of text zoom
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13328
Reviewed by: Antonio Gomes, DONGJUN KiM
Change-Id: Idb208ca4152c02e59ec00f1b1e82731b458faa39
Signed-off-by: Tomasz Czekala <t.czekala@samsung.com>
sm.venugopal [Mon, 20 Jul 2015 10:40:43 +0000 (16:10 +0530)]
fixup! [MM] Fix proper restart after video play ends
In paused state, if seeking just update delayed state variable
and return.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13568
Reviewed by: SeungSeop Park, Sharath Kamath
Change-Id: I5612318faa33985520178ca0fc895d1a88880f75
Signed-off-by: sm.venugopal <sm.venugopal@samsung.com>
Antonio Gomes [Mon, 20 Jul 2015 14:44:21 +0000 (07:44 -0700)]
Remove unneeded dependencies when building chromium-efl-libs and crosswalk-bin
Patch adds a 'building_strategy' variable to chromium-efl
GYP machinery. In build/system.gypi, it can be used to
filter dependencies in and out, according to what target
is being built: ewk, chromium-efl-libs or crosswalk-bin.
Patch could have replaced the existing 'building_crosswalk_bin'
by 'building_strategy', but the former is a crosswalk
upstream GYP variable, which has it own meaning in
xwalk/build/build.gypi.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: SeungSeop Park, arno renevier
Change-Id: I724341bed2ae1cbae1dc50bbc18e5a5451f35973
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Mon, 20 Jul 2015 20:06:55 +0000 (13:06 -0700)]
Remove 'pango' dependency from crosswalk-bin.spec and jhbuild.modules
Pango is not needed anymore, and disabled (-Duse_pango=0).
Some rounds of pango dendency removal happened in [1] and [2].
This patch takes care of the desktop bits and crosswalk-bin
(which did not exist at the time).
[1] http://165.213.202.130/gerrit/#/c/81515/
[2] http://165.213.202.130/gerrit/#/c/81783/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13279
Reviewed by: SeungSeop Park, arno renevier
Change-Id: Ie3970d38eedbdcf9300ec7997e4c055237c34f39
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Mon, 20 Jul 2015 22:23:46 +0000 (15:23 -0700)]
Restrict -fno-use-linker-plugin to when using custom linker gold
chromium-efl on Tizen3 TV profile successfully builds and
runs with built-in gold linker (installed with
"BuildRequires: binutils-gold").
On Tizen3 Mobile profile though (Arm 64bit) custom
linker gold is still required to run.
Only disable linker-plugin (LTO) on the later.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9044
Reviewed by: SeungSeop Park, arno renevier
Change-Id: I96f74d2e57fdad0217482aac8e4bbb40c0b1d33a
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Karol Furmaniak [Fri, 17 Jul 2015 08:39:07 +0000 (10:39 +0200)]
ewk_settings_default_text_encoding_name_set does set encoding.
[Problem]: After call ewk_settings_default_text_encoding_name_set
encoding is not set because preferences are not updated after set.
[Solution] Added updating preferences after set encoding.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13643
Reviewed by: Antonio Gomes, Jaesik Chang
Change-Id: Ic03ba6ceb47d1d7defc3235bbc8b132d1cdb09b7
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
hh4813.kim [Fri, 17 Jul 2015 00:47:44 +0000 (09:47 +0900)]
fixup! Introduce 'crosswalk-bin.spec'.
This patch temporarily fixes a GBS build error of 'crosswalk-bin.spec'
related to 'rpmlint'. It happens when build_{tv/mobile}.sh scripts are
not used, and gbs <parameters> is called directly.
Similar fix is also present in chromium-efl.spec.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Antonio Gomes, DONGJUN KiM
Change-Id: Ic95092ee6c570d2e47e05e550b0cdd621714e8c5
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
yh106.jung [Fri, 17 Jul 2015 08:08:55 +0000 (17:08 +0900)]
Add symbols which are needed by crosswalk
Patch adds all symbols which are needed by crosswalk into filter file
when --xwalk option is enabled.
Notice:
Mangled symbol name is different between 32-bit architecture
and 64-bit architecture due to unsigned and long integer size.
Please give attention to it when you add new symbol.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13316
Reviewed by: Antonio Gomes, Hyunhak Kim, SeungSeop Park, arno renevier
Change-Id: Ide823c1d8de7b1f5213e0f9c9b306d54fbc192fd
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
hh4813.kim [Fri, 17 Jul 2015 02:25:44 +0000 (11:25 +0900)]
Set same 'Source' name for chromium-efl-libs.spec and crosswalk-bin.spec
To avoid duplicated source file creation by 3 specs in packaging,
use the same source file name of chromium-efl.spec.
On OBS build, duplicated source files are created for each specs.
- chromium-efl-42.2311.0.29.tar.gz : 1.98GB
- chromium-efl-libs-42.2311.0.11.tar.gz : 1.98GB
- crosswalk-bin-14.42.333.0.tar.gz : 1.98GB
So, OBS team has requested to use the same source file name for 3 specs.
Reviewed by: Antonio Gomes, DONGJUN KiM, arno renevier
Change-Id: I65b58bab425a55b87aabd791df3c738e7a04926e
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
hh4813.kim [Thu, 16 Jul 2015 04:40:36 +0000 (13:40 +0900)]
Switch xwalk repo from github to CT
This patch switch crosswalk-efl repo to CT
Reviewed by: Antonio Gomes, DONGJUN KiM
Change-Id: I60da474331e7125c05f19143ed5d7e05bf5c7644
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Antonio Gomes [Thu, 16 Jul 2015 20:06:36 +0000 (16:06 -0400)]
Fix multi-item <select> on desktop builds
There is a couple of small issues on the current implementation
of multi-item selects (read <select multiple="">...</select>)
when tested on desktop builds.
Patch basically:
* make Tizen-specific the assumption that 'elm_genlist_item_index_get'
starts iterating from index '1'. This is really the case on GBS
builds, but not on desktop builds.
Looking at the public docs and EFL code, there is nothing about it.
Also, on desktop builds, it was causing menuitems to be persisted in
the wrong index when closing and opening a <select multiple=""> popups.
* change the insertion logic of selected menuitems into their container
so that indexes are always sorted.
Each menuitem in a select has a corresponding index.
Active menuitem's indexes are stored in an array, and values
vary from 0 to n-1, where 'n' is the number of menuitems.
When an item is selected, its index used to be inserted unsorted,
at the end of the array. On desktop builds, this was confusing the
"compareChangedItems" function and causing index lookups to fail.
Test: WCS/select_picker_test.html
Reviewed by: DONGJUN KiM, arno renevier
Change-Id: I97faccb6ed627ed81473155610a2115333975381
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Arnaud Renevier [Wed, 15 Jul 2015 23:03:25 +0000 (16:03 -0700)]
Avoid temporary string object creation
Eliminate the pattern std::string + std::string(argument).
Instead, use std::string + argument to avoid the creation
of a temporary string object.
Reviewed by: Antonio Gomes, Hyunhak Kim
Change-Id: If2970562ecb7bf3d8e7c67dfbe5dee97f811a19f
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
kriti.s [Wed, 3 Jun 2015 13:38:11 +0000 (19:08 +0530)]
[M40 Merge] Block zoom in/out when html element is in fullscreen.
Added handling pinching events in web_contents_delegate_efl. If they
happen when there is a fullscreen and pinching zoom is enabled they
are ignored.
This patch is dependent on http://165.213.202.130/gerrit/#/c/77423
m40 patch: http://165.213.202.130/gerrit/#/c/76547/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12364
Reviewed by: Antonio Gomes, SeungSeop Park (OOO July 15~17), Siba Samal, venu musham
Change-Id: I703bc3e7786f6db2dd93cf6fe072347144de1a6f
Signed-off-by: kriti.s <kriti.s@samsung.com>
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Antonio Gomes [Mon, 13 Jul 2015 17:08:49 +0000 (13:08 -0400)]
Make it possible to link crosswalk against libchromium-ewk.so
There is a demand that we are able to link xwalk (the binary)
against libchromium-ewk.so, instead of statically linking it
against chromium's internal libraries (e.g. lots .a files).
That would reduce 'xwalk' binary size, and optimize our
libchromium-ewk.so usage among the varions chromium-efl-based
apps (browser, xwalk, etc).
Patch provides such capability by making use of the reverse
"dependency injection" GYP technique. Basically, it injects
content into the empty placeholders added to crosswalk's GYP files,
and from chromium-efl side we can populate them as per our needs.
The above behavior is controlled by the GYP variable
'xwalk_link_against_chromium_ewk', which is only enabled
when building xwalk *not* in "development mode".
PS: "xwalk development mode" here means the optimized
build procedures provided by chromium-efl-libs and crosswalk-bin
packages.
In order to test this patch, symbols control in efl_integration.gypi
has to be disabled (Youngha Jung is working on a fix for that).
For now, just comment our the following two lines:
'-Wl,--version-script,<!(cd <(DEPTH) && pwd -P)/tizen_src/ewk/chromium-ewk.filter',
'-fvisibility=hidden',
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Hyunhak Kim, arno renevier
Change-Id: Ie67d22f1281c6670126108b65b73b2336d86db30
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
hh4813.kim [Fri, 10 Jul 2015 11:27:07 +0000 (20:27 +0900)]
fixup! Introduce 'chromium-efl-libs.spec'.
This patch temporarily fixes a GBS build error of 'chromium-efl-libs.spec'
related to 'rpmlint'. It happens when build_{tv/mobile}.sh scripts are
not used, and gbs <parameters> is called directly.
Similar fix is also present in chromium-efl.spec.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Antonio Gomes, DONGJUN KiM, arno renevier
Change-Id: I0f0330d82f2b097c3dfd8e2036074ec4b7fd8a25
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Sanghyup Lee [Thu, 9 Jul 2015 02:34:06 +0000 (11:34 +0900)]
Fix ewk_view_text_selection_clear
When ewk_view_text_selection_clear() is called, selection in renderer
is cleared. But we should also clear selected text in browser.
Because we can get selected text in RWHVBase by using
ewk_view_text_selection_text_get().
This patch makes clear selected text in RWHVBase when
ewk_view_text_selection_clear() is called.
And remove unnecessary variable in EWebView.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13560
Reviewed by: Antonio Gomes, Jaesik Chang
Change-Id: Ib9ae750ed6361d9eb0e7f8b42c08fa59edd35511
Signed-off-by: Sanghyup Lee <sh53.lee@samsung.com>
Pawel Forysiuk [Fri, 10 Jul 2015 11:28:42 +0000 (13:28 +0200)]
Add command line switches for memory optimization patches recently merged.
This patch enables switches for following patches:
1. Limit memory allocations in MessagePumpForUIEf
http://165.213.202.130/gerrit/81312
2. Add --limit-memory-allocation-in-schedule-delayed-work runtime option
http://165.213.202.130/gerrit/81308
3. Defer creation of DisambiguationPopupEfl
http://165.213.202.130/gerrit/81351
4. [MEM OPT] Grow semispace by N pages
http://165.213.202.130/gerrit/81306
5. [MEM OPT] Shrink v8 new space to initial capacity in NewSpace::Shrink
http://165.213.202.130/gerrit/81307
This patch also enables ustream option "--enable-link-disambiguation-popup"
for easier testing.
Reviewed by: Antonio Gomes, kavitha devara
Change-Id: I9b260f640c4f1bc6c16d8821c02a716965262f31
Signed-off-by: Pawel Forysiuk <p.forysiuk@samsung.com>
Marcin Lapinski [Thu, 9 Jul 2015 09:34:19 +0000 (11:34 +0200)]
[uBrowser] Added autofill feature.
Reviewed by: Antonio Gomes, Janusz Majnert
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13450
Change-Id: Icb255a1d95bfa0c4b8715e4aad4b740b7531cec7
amit.kumar8 [Wed, 15 Jul 2015 09:25:49 +0000 (14:55 +0530)]
fixup! Enabling switches for memory optimization patches. Reviewed by: DaeHyun Ko, Eun Namgung, Prashant Nevase
Change-Id: Ica8109b736cd7ed1ebf0366a351bfd5663be9d7e
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
Michał Obrembski [Wed, 17 Jun 2015 10:45:54 +0000 (12:45 +0200)]
Fixed H/W back button
H/W back button wasn't working on Tizen 3.0 in Chromium-efl.
This was due changed keycode of HW back key.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13200
Reviewed by: Antonio Gomes, Janusz Majnert, Karol Furmaniak, Marcin Kolibabka, Piotr Grad
Change-Id: Icd140d70bc2ba6573e650f0e31ea0fa589771e70
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
jitu.patel [Wed, 17 Jun 2015 10:24:24 +0000 (15:54 +0530)]
[MM] CAPI port code refactor
This patch is for refactoring code of CAPI port for media element.
Reference: http://165.213.202.130/gerrit/#/c/72864/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13055
Reviewed by: SeungSeop Park (OOO July 15~17), Venugopal S M
Change-Id: I7f411f51fa045a3b03639e5f43cf561e5a0dae33
Signed-off-by: Umesh Kumar Patel <umeshk.patel@samsung.com>
Signed-off-by: jitu.patel <jitu.patel@samsung.com>
Karol Furmaniak [Fri, 10 Jul 2015 05:34:02 +0000 (07:34 +0200)]
fixup! Added autofill options to uBrowser menu.
Now changing remember form data option depends on form
profile option but it shouldn't.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12729
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I184814b7409f845f549052d50536108d439befef
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Arnaud Renevier [Fri, 10 Jul 2015 17:04:25 +0000 (10:04 -0700)]
fixup! Enabling switches for memory optimization patches.
Add dependency on base.gyp:base_static to not break component build.
Reviewed by: Prashant Nevase, SeungSeop Park
Change-Id: Ia179455a66e9c2f2e6063a619018e2d0c907984e
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Antonio Gomes [Thu, 9 Jul 2015 12:25:59 +0000 (21:25 +0900)]
Restructure chromium-efl.gyp (build entry point)
Patch creates a "build_all"-like target for EWK,
where all the sample apps are set as 'dependencies'.
It also deliberately removes the explicit inclusion of
efl_integration.gypi (where the 'chromium-ewk' target is
declared).
Reasoning is that 'chromium-ewk' is set as an explicit
dependecy of all three targets currently listed in chromium-ewk.gyp,
so its inclusion is redundant.
Also, the explicit inclusion of efl_integration.gypi from
chromium-ewk.gyp caused GYP error when we try to set 'chromium-ewk'
target as a dependency for 'xwalk' target:
[XXs] IndexError: string index out of range while reading
includes of /(..)/tizen_src/ewk/chromium-ewk.gyp while trying to load
/(..)/tizen_src/ewk/chromium-ewk.gyp
Reference: https://groups.google.com/forum/#!topic/gyp-developer/J-0xR5wye30
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Hyunhak Kim, arno renevier
Change-Id: Ic30be2a2dd218c7da3a1b5398b222b1c926ee941
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Pawel Forysiuk [Mon, 8 Jun 2015 18:13:31 +0000 (20:13 +0200)]
Limit memory allocations in MessagePumpForUIEfl
There was a segfault which occured when ecore_timer callback was
called but |MessagePumpForUIEfl| object (passed as |this| to the
callback) was previously destroyed.
In order to prevent this, all pending timers were added to |unordered_set|
object and they were deleted either when MessagePumpForUIEfl destructor was
called (to invalidate them) or when callback was handled.
As timers work asynchronously all objects passed to timer were
previously created on heap. As a result, there were a huge
number of allocations, for example,
scroll down and up on m.naver.com cause ~3500 of them.
According to doc of MessagePump::ScheduleDelayedWork() from
src/base/message_loop/message_pump.h, all previous pending timers
should be cancelled.
This fact allows getting rid of keeping pending timers and from now
only one timer is alive in MessagePumpForUIEfl.
Since this is extremely hot path in the source, this patch updates
pending timer interval instead of:
if (timer)
ecore_timer_del(timer);
timer = ecore_timer_add(...);
This should have good performance impact as well.
In average, depends on page content, this patch saves ~400 KB in PSS
for Browser process.
Patch cherry picked from beta/m40_2214_t_memopt
http://suprem.sec.samsung.net/gerrit/#/c/35486/
Original Author: Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by: Janusz Majnert, Karol Furmaniak, kavitha devara
Change-Id: I76b73d6134543af7b87ebb21546eaf7b2e24a9ed
Signed-off-by: Pawel Forysiuk <p.forysiuk@samsung.com>
Antonio Gomes [Thu, 9 Jul 2015 07:02:57 +0000 (16:02 +0900)]
Fix the chromium-ewk.filter patch in GYP
When we make crosswalk to link against chromium-ewk.so,
the relative path set for chromium-efl.filter fails to
resolve, as per the error below:
(..)/third_party/binutils/Linux_x64/Release/bin/ld.gold: error:
cannot open ../../../tizen_src/ewk/chromium-ewk.filter: No such file or directory
(..)/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: fatal error:
unable to parse version script file ../../../tizen_src/ewk/chromium-ewk.filter
Patch sets chromium-ewk.filter path in an absolute way,
similarly to [1].
[1] https://goo.gl/OiXpH3
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: SeungSeop Park, Sharath Kamath
Change-Id: I630bcc6f60b720a98f34a20eb97ec1c8602ff745
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
SeungSeop Park [Fri, 10 Jul 2015 00:44:05 +0000 (09:44 +0900)]
Build content_shell by default in desktop build
If you don't like to build it, pass '--no-content-shell' to build_desktop.sh.
Reviewed by: Antonio Gomes, Hyunhak Kim
Change-Id: I23e42e9a3ee1138f9b51c6d3bda229765c6bd019
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Youngsoo Choi [Thu, 2 Jul 2015 05:10:21 +0000 (14:10 +0900)]
Preventing creation of unused instance 'EdgeEffect' on TV target
[issue]
TV does not support touch event, so instance of 'EdgeEffect'
does not need to be created on the target.
But the instance has been created.
[resolve]
This patch provides lazy initialization for instance of 'EdgeEffect',
so that it can not be created on TV target which does not support
touch event.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13549
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Ifc784f92097f8dc2dc0418664dc03c9a74b35c4c
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
k2.nagaraju [Wed, 8 Jul 2015 10:07:09 +0000 (15:37 +0530)]
[MM][CAPI] Handle CAPI callbacks on main thread.
Handle all CAPI callbacks on main thread. Call CAPI API's only from
main thread. Don't do any processing of data in capi callback function
to avoid possible errors / deadlocks.
This reverts commit http://165.213.202.130/gerrit/#/c/75385/4
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11539
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: Ife6f0c58f3bcad98546924a57ba1309bff53256c
Signed-off-by: k2.nagaraju <k2.nagaraju@samsung.com>
amit.kumar8 [Mon, 6 Jul 2015 12:58:26 +0000 (18:28 +0530)]
Enabling switches for memory optimization patches.
This patch enables switches for following patches.
1. Implement purging unused resources.
http://165.213.202.130/gerrit/#/c/81192/
2. Optimize the tile texture size for edge tiles.
http://165.213.202.130/gerrit/#/c/81137/
3. Adding runtime switch for providing tile size
rounding up factor.
http://165.213.202.130/gerrit/#/c/81138/
4. Release discardable memory after used if purgable.
http://165.213.202.130/gerrit/#/c/81265/
5. Add runtime switch to configure the discardable
image cache size.
http://165.213.202.130/gerrit/#/c/81142/
Reviewed by: Antonio Gomes, Prashant Nevase
Change-Id: I039cc38e23fe049e2fb9aa99970d571c36acb7a0
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
sm.venugopal [Mon, 25 May 2015 14:22:51 +0000 (19:52 +0530)]
[M40 merge][MM] Audio is mismatching with video frame.
Streaming user-agent is now being set for media player. This was required
because for website "www.espncricinfo.com/ci/content/video_audio/796581.html",
the CDN was providing video URL in which there was audio-video sync issue.
After setting the user-agent it gives proper video URL.
Reference patch: http://165.213.202.130/gerrit/#/c/76885/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13055
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: Iba923286d9de766d3bb4b742cb68537235f361db
Signed-off-by: sm.venugopal <sm.venugopal@samsung.com>
Signed-off-by: jitu.patel <jitu.patel@samsung.com>
Pawel Forysiuk [Tue, 9 Jun 2015 07:12:53 +0000 (09:12 +0200)]
Defer creation of DisambiguationPopupEfl
This object is unnecessarily allocated and initialized together with rwhv as
the likehood of its usage is rather low.
This popup notifies the client that multiple touch targets may have been pressed.
Test: WebKit/Source/web/tests/data/disambiguation_popup.html
To test memory gain, you need to pass:
--enable-link-disambiguation-popup
This patch defers creation of DisambiguationPopupEfl when it needs to be shown.
This change does not regress performance and saves ~10O KB PSS.
Patch cherry picked from beta/m40_2214_t_memopt
http://suprem.sec.samsung.net/gerrit/#/c/33075/
Original Author: Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by: Antonio Gomes, Janusz Majnert
Change-Id: I2bcbe247c8cd5123d7ca2d35ced576aa504a9cc2
Signed-off-by: Pawel Forysiuk <p.forysiuk@samsung.com>
Nitish [Wed, 8 Jul 2015 11:54:08 +0000 (17:24 +0530)]
[M40 Merge] Enable parallel canvas by default.
Enable Parallel canvas by default for tizen OS.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13033
Reviewed by: DaeHyun Ko, Prashant Nevase
Change-Id: I9c7cc0610d28c63c8e3ae700398231622ab37d8e
Signed-off-by: Nitish <ask.nitish@samsung.com>
Karol Furmaniak [Thu, 18 Jun 2015 12:19:49 +0000 (14:19 +0200)]
Added autofill options to uBrowser menu.
[Problem]: There is no autofill related options in uBrowser.
[Solution]: Added autofill related options to uBrowser menu:
Enable/Disable Form Profile
Enable/Disable Remember Form Data
Enable/Disable Remember Password
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12731
Reviewed by: Antonio Gomes, Hyunhak Kim
Change-Id: I3c27fa0a29cb0de901e0939dbcc172de9253126e
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Marcin Lapinski [Tue, 7 Jul 2015 13:08:03 +0000 (15:08 +0200)]
Added ubrowser launch icon for tizen 2.4 and tizen 3.0.
Reviewed by: Antonio Gomes, Janusz Majnert
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13309
Change-Id: I7380573f9da465d6c39f4d3b3683e79768496262
DongJun Kim [Tue, 7 Jul 2015 05:19:05 +0000 (14:19 +0900)]
fixup! [M40 Merge] Add Ewk_Context specific notification handling
This patch is a fixup of http://165.213.202.130/gerrit/#/c/82262/
WRT had error in latest platform because mismatching of typedef.
It is for reverting modification that
had removed "Ewk_Context*" from notification callback.
Also we make a new implementation for
"ewk_context_notification_callbacks_set/reset" without build error.
Reviewed by: Antonio Gomes, Hyunhak Kim
Change-Id: I780523a86cd4bf528c4c1906bd10acd9268ca1ab
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
Sanghyup Lee [Wed, 8 Jul 2015 01:40:33 +0000 (10:40 +0900)]
[M40 Merge] Fix ewk_error_code_get
Currently ewk_error_code_get returns the code defined in
src/net/base/net_error_list.h. This patch introduces a function converting
some of the net_error_list's into Ewk_Error_Code enums.
m40 patch: http://165.213.202.130/gerrit/#/c/76234/
Original author: Michał Pakuła vel Rutka <m.pakula@samsung.com>
Reviewed by: DONGJUN KiM, Hyunhak Kim
Change-Id: I05abb2b3e3cbe7c70a01e391fe7fddec5a93811d
Signed-off-by: Sanghyup Lee <sh53.lee@samsung.com>
joke.song [Wed, 8 Jul 2015 01:18:15 +0000 (10:18 +0900)]
[tizen 3.0][m42][EWKAPI] add NULL check in ewk_autofill_profile_data_set
There is no NULL check for third parameter of ewk_autofill_profile_data_set.
It is needed for negaitve UTC cases,
utc_webkit2_ewk_autofill_profile_data_get_func_n,
utc_webkit2_ewk_autofill_profile_data_set_func_n.
Reviewed by: Antonio Gomes, DONGJUN KiM
Change-Id: Ie65cda987ea21c50ab65d19326b73e1ff9399753
Signed-off-by: joke.song <joke.song@samsung.com>
sm.venugopal [Mon, 6 Jul 2015 16:53:07 +0000 (22:23 +0530)]
[MM] Fix crash on playing only audio/video streams
Unused elements are removed while playing only audio/video streams. No
reference is maintained. So, only |gst_bin_remove| is sufficient. It will
internally free the element.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13518
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I51cd62e951bfc99454b51aff9a432aba21973801
Signed-off-by: sm.venugopal <sm.venugopal@samsung.com>
Marcin Lapinski [Thu, 2 Jul 2015 09:59:23 +0000 (11:59 +0200)]
[uBrowser] Can not open same window on window manager
Problem is caused by the default behavior of list item, which sends callback
only when first becoming selected. Any further clicks will do nothing.
Solution is changing window list selection mode to
ELM_OBJECT_SELECT_MODE_ALWAYS which makes calling callback on every click
for items even if item is selected.
Reviewed by: Antonio Gomes, Janusz Majnert
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13359
Change-Id: Ie3548f820a91366712f0d29ac340036d0631bef1
Arnaud Renevier [Mon, 6 Jul 2015 14:35:20 +0000 (16:35 +0200)]
Remove FOR_TESTING_ewk_hit_test_image_height_get
Remove FOR_TESTING_ewk_hit_test_image_height_get and
FOR_TESTING_ewk_hit_test_image_width_get. Those apis aren't used
anywhere.
Reviewed by: Antonio Gomes, Hyunhak Kim
Change-Id: Ic97f4060e6b7d1d6d65f1fd802bd430084b10265
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
ws29.jung [Thu, 2 Jul 2015 09:34:47 +0000 (18:34 +0900)]
[MM] Fix proper restart after video play ends
Before, restarting finished video didn't work properly because
internally, player tried to start video before seeking job is done.
This patch make player start video after seeking is done.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13568
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: I601e931910cec63585ef764904d9ff416c8e4dba
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
Youngsoo Choi [Thu, 2 Jul 2015 01:08:14 +0000 (10:08 +0900)]
Fixing for ewk_settings_edge_effect_enabled_set
[issue]
The EWK provides a API 'ewk_settings_edge_effect_enabled_set' to set
edge effect, but it does not work due to wrong condition in chromium-efl.
[resolve]
The variable 'enabled_globally' is changed by 'g_force_disable_edge_effect'
which follows google coding style, for better understanding,
and 'g_force_disable_edge_effect' is removed from the class member.
This patch also meets following condition.
Only if 'enabled_' is TRUE and 'g_force_disable_edge_effect' is FALSE,
the edge effect should be enabled.
Otherwise, the edge effect should be disabled.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13545
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I636e87cf4d08a52b1192ad0dcd649a098ce52394
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
yh106.jung [Tue, 7 Jul 2015 03:30:37 +0000 (12:30 +0900)]
fixup! fixup! [wayland][tizen v3.0] Initial support for TV and mobile
Patch removes wrong guard, MakeTouchEvent is not related to x11.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12490
Reviewed by: Antonio Gomes, Hyunhak Kim
Change-Id: Ic6b9874b4071d64c3f685cf71ee29a02b2008161
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
Adrian Szafranek [Mon, 29 Jun 2015 09:39:34 +0000 (11:39 +0200)]
[tizen 3.0][m42][EWKAPI] Implementation "ewk_object_ref, ewk_object_unref"
Patch adds functions ewk_object_ref and ewk_object_unref
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13329
Reviewed by: Hyunhak Kim, Marcin Kolibabka
Change-Id: I9a63c2d141e4e87d31cc1f94c601a18c62e545ff
Signed-off-by: Adrian Szafranek <a.szafranek@samsung.com>
Antonio Gomes [Wed, 24 Jun 2015 05:27:23 +0000 (22:27 -0700)]
Introduce 'crosswalk-bin.spec'.
Goal of the patch is:
Avoid requiring a full build of chromium-efl in order to
build xwalk-efl.
In order to achieve that, xwalk-efl "requires" chromium-efl-libs,
and makes it a hard dependency on the crosswalk-bin spec file.
Basically, chromium-efl-libs installs into the system all
.so files resulted of a component build of chromium-efl
targets ('xwalk' and 'ewk' targets excluded).
Then, when building crosswalk-bin, chromium (well also
blink, mojo, ffmpeg) is patched so that some targets
(the ones that take longer to build) are not rebuilt.
This is done by
crosswalk-do-not-build-several-chromium-dependencies.diff.
This patch changes several targets in the build system so that
they do not build or generate any files and just pass "-l<target>"
to the linker.
* packaging/crosswalk-bin.spec: fork of the xwalk's crosswalk-bin.spec.
Difference from the original: It adds some dependencies needed by
chromium-efl sources; it also calls gyp_chromiumefl.sh instead of
directly calling gyp_xwalk, and changes some filepaths are per
our needs.
* build/patches/crosswalk/crosswalk-do-not-build-several-chromium-dependencies.diff:
fork of the xwalk version.
Difference from the original: it does not patch the following
targets:
* third_party/icu/icu.gyp: we use ICU from system, and
patch was not making a different for such case.
* ui/views/views.gyp: chromium-efl (and xwalk-efl) use
EFL as toolkit, so patching 'views' is irrelevant.
* ui/aura/aura.gyp: same reason as above.
When building xwalk-efl (with crosswalk-bin) from scratch, only 2349
files are built instead of the original 12.6k of a full chromium-efl build.
There is a chance that the number of files built is decreased even more
if more chromium targets are changed as per the logic described above.
How to use use:
$ tizen_src/build/build_mobile.sh --crosswalk-bin
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Hyunhak Kim, arno renevier
Change-Id: If0b5af0ffb82d7f4ac450c7083d3538c13d3d322
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Nitish [Fri, 3 Jul 2015 05:19:15 +0000 (10:49 +0530)]
[M40 Merge] Enable accelerated 2d canvas feature.
Accelerated 2d canvas feature is not enabled by default in m42.
Enable accelerated 2d canvas by default by adding switch
kForceAccelerated2dCanvas.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13033
Reviewed by: DaeHyun Ko, venu musham
Change-Id: Id695f7dd55d00d0e854ff465897659ceda4256c8
Signed-off-by: Nitish <ask.nitish@samsung.com>
Chandan Padhi [Thu, 2 Jul 2015 06:39:09 +0000 (12:09 +0530)]
fixup! Implement Delegate renderer using frame buffer object on Tizen.
Currently, there are two InsertSyncPointCHROMIUM() calls in
MailboxOutputSurfaceEfl::SwapBuffers() which is unnescessary.
Only one call would suffice.
Reviewed by: DaeHyun Ko, venu musham
Change-Id: I00da46d3363a93bcea679f9b2682c59ba07939f0
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Tomasz Weglarski [Tue, 23 Jun 2015 10:22:39 +0000 (12:22 +0200)]
Implement orientation_lock and orientation_unlock API
This is a very basic implementation of orientation lock/unlock API:
http://www.w3.org/TR/screen-orientation/, based on current Chromium Android
implementation. Android's version has been stripped from Android specific
Start/StopAccurateListening methods, which will be provided in next patch.
This patch deprecates EWK API's ewk_view_orientation_lock_callback_set.
Together with: I51b8692482780fad707c723768b66dc776aa63cb
Reviewed by: Hyunhak Kim, Janusz Majnert, Karol Furmaniak, Piotr Grad, Tomasz Weglarski
Change-Id: I7569d94341c4de84b16066aab555822febacb03f
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
Signed-off-by: Tomasz Weglarski <t.weglarski@samsung.com>
Antonio Gomes [Wed, 1 Jul 2015 18:33:04 +0000 (14:33 -0400)]
Tie edge effect kick-off to touch events.
When touch events are disabled (in case of TV profile, and
desktop builds), RWHVEfl::DidOverscroll is still called, and
kicks off edge effect logic.
Problem is that our edge effect hide logic, happens on a touch-only
code path. As a consequence, edge effect does no go away on non-touch
set ups.
Additionally, WebKit/EFL for Tizen TV profile does not have edge
effect enabled at all.
In order to avoid that problem, patch makes our edge effect kick
off logic tied to touch events.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13452
Reviewed by: Hyunhak Kim, arno renevier
Change-Id: I3e648bafcf3ca8908e58fb6e14f928283dff4d2c
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Thu, 2 Jul 2015 21:18:09 +0000 (14:18 -0700)]
fixup! Introduce 'chromium-efl-libs.spec'.
Patch is a fixup of http://165.213.202.130/gerrit/#/c/82776/,
and consists in including the generated edj files
as part of the packaging of chromium-efl-libs.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Hyunhak Kim, arno renevier
Change-Id: Ia8a9846922c0a30e6f665e47efa1154291292960
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
DongJun Kim [Tue, 30 Jun 2015 14:57:02 +0000 (23:57 +0900)]
Internalization for notification
This patch is internalization for notification on tizen 3.0.
Permission request callback is set to web-engine
by default using this.
- _ewk_view_default_notification_permission
If do not set any permission callback by user,
it will be shown up by web engine side.
Reviewed by: Hyunhak Kim, Karol Furmaniak
Change-Id: I5df4a37c30ee17bc0bd07e95c7a0d0e734e51050
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
Antonio Gomes [Thu, 2 Jul 2015 19:18:40 +0000 (12:18 -0700)]
Make some edje resources directly compiled by content targets.
Some edc resources currently living in ewk/ are used
solely by chromium_impl targets. Namely:
Magnifier, Overscrolling and DisambiguationPopup.
Patch moves them to a specific target 'edje_resources_efl'
to be set as dependencies of targetd that need it.
As a consequence, it allows chromium-efl-libs (there
EWK targets are *not* build) to install the generated
edj files as part of packaging rules.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11889
Reviewed by: Hyunhak Kim, arno renevier
Change-Id: Ib90a6a69d2a4bf6c1458d00840d661f99ddb94f4
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
DongJun Kim [Tue, 30 Jun 2015 05:48:57 +0000 (14:48 +0900)]
Internalization for geolocation
This patch is internalization for geolocation on tizen 3.0.
Permission request callback is set to web-engine
by default using this.
- _ewk_view_default_user_media_permission
If do not set any permission callback by user,
it will be shown up by web engine side.
Reviewed by: Hyunhak Kim, Karol Furmaniak
Change-Id: I15c6237c97f0b7e9114b1bed4a5ae65303910586
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
ws29.jung [Fri, 26 Jun 2015 02:44:55 +0000 (11:44 +0900)]
[MM][GUM] Change default camera on TV
Before "back" camera was mapped to CAPI enum CAMERA_DEVICE_CAMERA0
and "front" camera to CAMERA_DEVICE_CAMERA1.
CameraHandle, an internal wrapper class for CAPI's camera handle, creates
a camera with CAMERA_DEVICE_CAMERA0 in its default constructor.
However, back camera (CAMERA_DEVICE_CAMERA0) is not available in TV,
which yields invalid CameraHandle and GetUserMedia does not work as result.
To fix this, patch changes the mapping on TV so that CAMERA_DEVICE_CAMERA0
be associated with "front" camera.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13236
Reviewed by: SeungSeop Park, Sharath Kamath
Change-Id: I5c80c3f98e147122acd9065a9207c5fff855ac03
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
Antonio Gomes [Tue, 30 Jun 2015 20:31:21 +0000 (13:31 -0700)]
fixup! [wayland][tizen v3.0] Initial support for TV and mobile
Patch removes unneeded dependencies and unneeded targets.
Namely: wayland-{client,cursor,egl,server}.
The dependencies were added needlessly, in preparation to a full
wayland-backend being developed for chromium-efl in [1]. This changed
when it was decided to take the ozone codepath [2].
[1] http://165.213.202.130/gerrit/#/c/80036/
[2] http://165.213.202.130/gerrit/#/c/80317/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12490
Reviewed by: Antonio Gomes, Balazs Kelemen, arno renevier
Change-Id: I3aa0eab3e9cb1e0de3378da46eba73a0e5413163
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Tue, 30 Jun 2015 17:54:34 +0000 (13:54 -0400)]
fixup! Different build fixups for ozone
Patch makes 'gl' target (ui/gl) depend explictly
on 'x11' target. It fixes the following build error
when doing a component build of chromium-efl for
Tizen 2.4 mobile profile.
gfx::OffScreenRootWindow::~OffScreenRootWindow():
error: undefined reference to 'XUnmapWindow'
gfx::OffScreenRootWindow::~OffScreenRootWindow():
error: undefined reference to 'XDestroyWindow'
gfx::NativeDisplayConnection::~NativeDisplayConnection():
error: undefined reference to 'XCloseDisplay'
gfx::NativeDisplayConnection::NativeDisplayConnection():
error: undefined reference to 'XOpenDisplay'
gfx::OffScreenRootWindow::OffScreenRootWindow(_XDisplay*):
error: undefined reference to 'XDefaultRootWindow'
gfx::OffScreenRootWindow::OffScreenRootWindow(_XDisplay*):
error: undefined reference to 'XCreateSimpleWindow'
gfx::OffScreenRootWindow::OffScreenRootWindow(_XDisplay*):
error: undefined reference to 'XChangeWindowAttributes'
gfx::OffScreenRootWindow::OffScreenRootWindow(_XDisplay*):
error: undefined reference to 'XMapWindow'
gfx::NativeBuffer::~NativeBuffer():
error: undefined reference to 'XFree'
gfx::NativeBufferManager::Initialize():
error: undefined reference to 'XDefaultScreen'
gfx::NativeBuffer::Lock(unsigned long, int):
error: undefined reference to 'XFree'
gfx::EflPixmap::CreatePixmap(gfx::Size const&):
error: undefined reference to 'XCreatePixmap'
gfx::EflPixmap::CreatePixmap(gfx::Size const&):
error: undefined reference to 'XFlush'
gfx::EflPixmap::Initialize():
error: undefined reference to 'XSync'
gfx::EflPixmap::FreePixmap(unsigned long):
error: undefined reference to 'XFreePixmap'
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Hyunhak Kim, arno renevier
Change-Id: Id971299dcc214078ba00bda0dc55234c31515ab8
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
hh4813.kim [Tue, 16 Jun 2015 11:23:37 +0000 (20:23 +0900)]
[EWK_REFACTOR] bringup Ewk_Settings::useKeyPadWithoutUserAction() in OnTextInputStateChanged
EWK_REFACTOR guards are removed for bringup Ewk_Settings::useKeyPadWithoutUserAction() call
in RenderWidgetHostViewEfl::OnTextInputStateChanged().
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12028
Reviewed by: Antonio Gomes, DONGJUN KiM, arno renevier
Change-Id: I4e5ef32cec0a36392bfe0afdb657dd2e8da162b4
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Chandan Padhi [Mon, 22 Jun 2015 09:22:17 +0000 (14:52 +0530)]
fixup! Implement Delegate renderer using frame buffer object on Tizen.
Currently, a TransferableFrame with empty mailbox is added to
pending_textures_ in MailboxOutputSurfaceEfl constructor. In
case of debug build, this results in crash due to failure in
DCHECK(!it->mailbox.IsZero()) condition in OnSwapAck().
This patch fixes the above crash.
Reviewed by: DaeHyun Ko, Prashant Nevase, venu musham
Change-Id: Ie65b263ae7884726f3a01977aad9dea135c9a3a3
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>