platform/upstream/libSkiaSharp.git
8 years agoRevert of Paranoid temporary check that Chrome's building with SSE2 on all Windows...
mtklein [Fri, 14 Aug 2015 12:49:17 +0000 (05:49 -0700)]
Revert of Paranoid temporary check that Chrome's building with SSE2 on all Windows builders. (patchset #1 id:1 of https://codereview.chromium.org/1283183004/ )

Reason for revert:
Nothing broke.  Experiment is over... SSE2 is present.

Original issue's description:
> Paranoid temporary check that Chrome's building with SSE2 on all Windows builders.
>
> BUG=chromium:475596
>
> Committed: https://skia.googlesource.com/skia/+/e8445307ac33eddcf04457ae21040e47dc9c2a97

TBR=egdaniel@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:475596

Review URL: https://codereview.chromium.org/1296593002

8 years agoSkScaledCodec class
emmaleer [Fri, 14 Aug 2015 12:46:08 +0000 (05:46 -0700)]
SkScaledCodec class

This class does scaling by using a scanlineDecoder.
getScanlines and skipScanlines are used for y sampling,
the swizzler is used for x sampling

this class is currently only working for png and jpeg images
I will update other Codec types to work soon

For SkJpegCodec to implement width wise swizzling it now
uses a swizzler. I ran performance tests on this change.
Here are the performance test results:
https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/0944100ac89f797714eeae0cf2875e2335ff52ee

Committed: https://skia.googlesource.com/skia/+/d518ea7927f9f4e0ed5b4134d1b4f48243855a47

Review URL: https://codereview.chromium.org/1260673002

8 years agoParanoid temporary check that Chrome's building with SSE2 on all Windows builders.
mtklein [Fri, 14 Aug 2015 00:53:28 +0000 (17:53 -0700)]
Paranoid temporary check that Chrome's building with SSE2 on all Windows builders.

BUG=chromium:475596

Review URL: https://codereview.chromium.org/1283183004

8 years agoSplit GrDrawBatch and GrVertexBatch into their own files
bsalomon [Thu, 13 Aug 2015 21:55:50 +0000 (14:55 -0700)]
Split GrDrawBatch and GrVertexBatch into their own files

TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/1296483002

8 years agosome catchup CL revisions
reed [Thu, 13 Aug 2015 21:06:46 +0000 (14:06 -0700)]
some catchup CL revisions

BUG=skia:

Review URL: https://codereview.chromium.org/1295593002

8 years agoEvery pixel ref gets its own mutex.
mtklein [Thu, 13 Aug 2015 21:02:06 +0000 (14:02 -0700)]
Every pixel ref gets its own mutex.

Seems like a memory-saving flourish follow up would be to use SkSpinlock.

BUG=Florin's email.

Review URL: https://codereview.chromium.org/1289623004

8 years agoRevert of SkScaledCodec class (patchset #34 id:660001 of https://codereview.chromium...
emmaleer [Thu, 13 Aug 2015 20:59:21 +0000 (13:59 -0700)]
Revert of SkScaledCodec class (patchset #34 id:660001 of https://codereview.chromium.org/1260673002/ )

Reason for revert:
Seg-faulting:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Release/builds/1608/steps/dm/logs/stdio

Original issue's description:
> SkScaledCodec class
>
> This class does scaling by using a scanlineDecoder.
> getScanlines and skipScanlines are used for y sampling,
> the swizzler is used for x sampling
>
> this class is currently only working for png and jpeg images
> I will update other Codec types to work soon
>
> For SkJpegCodec to implement width wise swizzling it now
> uses a swizzler. I ran performance tests on this change.
> Here are the performance test results:
> https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/0944100ac89f797714eeae0cf2875e2335ff52ee
>
> Committed: https://skia.googlesource.com/skia/+/d518ea7927f9f4e0ed5b4134d1b4f48243855a47

TBR=scroggo@google.com,msarett@google.com,djsollen@google.com,mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1294613002

8 years agoBelt and suspenders for colors in DrawAtlasBatch test
jvanverth [Thu, 13 Aug 2015 20:41:03 +0000 (13:41 -0700)]
Belt and suspenders for colors in DrawAtlasBatch test

Review URL: https://codereview.chromium.org/1290253002

8 years agoIntroduce GrBatch subclasses GrDrawBatch and GrVertexBatch to prepare for non-drawing...
bsalomon [Thu, 13 Aug 2015 20:34:48 +0000 (13:34 -0700)]
Introduce GrBatch subclasses GrDrawBatch and GrVertexBatch to prepare for non-drawing batches

Review URL: https://codereview.chromium.org/1293583002

8 years agoExtend SkImageGenerator to support natively generated GrTextures. As part of this...
reed [Thu, 13 Aug 2015 20:32:39 +0000 (13:32 -0700)]
Extend SkImageGenerator to support natively generated GrTextures. As part of this, added uniqueID() to the generator, and made it be in the same namespace is bitmaps, pixelrefs, images.

To do this, create SkImageCacherator, which wraps a generator and provides an
interface to get a cached answer for either the raster or texture output of
the generator.

BUG=skia:

Review URL: https://codereview.chromium.org/1291803002

8 years agoNormalize SkXfermode_opts.h argument order as d,s[,aa].
mtklein [Thu, 13 Aug 2015 20:10:30 +0000 (13:10 -0700)]
Normalize SkXfermode_opts.h argument order as d,s[,aa].

At head they're s,d[,aa] in SkXfermode_opts.h but Sk4px::Map* expect d,s[,aa]
so we ended up having to write weird little lambda shims to match impedance.

There's no reason for these to disagree, and d,s[,aa] is the One True Order
(because no matter what you're doing in graphics, there's always a dst).

Should be no perf or image diff, though I'm suspicious it might help MSVC code generation.

BUG=skia:4117

Committed: https://skia.googlesource.com/skia/+/6028a8476504022fe40b6870b1460b5e4a80969f

CQ_EXTRA_TRYBOTS=client.skia:Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Release-Trybot

Review URL: https://codereview.chromium.org/1289903002

8 years agoSkScaledCodec class
emmaleer [Thu, 13 Aug 2015 20:07:03 +0000 (13:07 -0700)]
SkScaledCodec class

This class does scaling by using a scanlineDecoder.
getScanlines and skipScanlines are used for y sampling,
the swizzler is used for x sampling

this class is currently only working for png and jpeg images
I will update other Codec types to work soon

For SkJpegCodec to implement width wise swizzling it now
uses a swizzler. I ran performance tests on this change.
Here are the performance test results:
https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/0944100ac89f797714eeae0cf2875e2335ff52ee

Review URL: https://codereview.chromium.org/1260673002

8 years agoFix for VALGRIND DrawAtlas test issue.
jvanverth [Thu, 13 Aug 2015 18:53:39 +0000 (11:53 -0700)]
Fix for VALGRIND DrawAtlas test issue.

Don't pre-alloc color array.

Review URL: https://codereview.chromium.org/1289003002

8 years agoRevert of SkScaledCodec class (patchset #32 id:620001 of https://codereview.chromium...
emmaleer [Thu, 13 Aug 2015 18:44:05 +0000 (11:44 -0700)]
Revert of SkScaledCodec class (patchset #32 id:620001 of https://codereview.chromium.org/1260673002/ )

Reason for revert:
Segfaulting:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Release/builds/1605/steps/dm/logs/stdio

Original issue's description:
> SkScaledCodec class
>
> This class does scaling by using a scanlineDecoder.
> getScanlines and skipScanlines are used for y sampling,
> the swizzler is used for x sampling
>
> this class is currently only working for png and jpeg images
> I will update other Codec types to work soon
>
> For SkJpegCodec to implement width wise swizzling it now
> uses a swizzler. I ran performance tests on this change.
> Here are the performance test results:
> https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/0944100ac89f797714eeae0cf2875e2335ff52ee

TBR=scroggo@google.com,msarett@google.com,djsollen@google.com,mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1294593002

8 years agoSkScaledCodec class
emmaleer [Thu, 13 Aug 2015 18:26:57 +0000 (11:26 -0700)]
SkScaledCodec class

This class does scaling by using a scanlineDecoder.
getScanlines and skipScanlines are used for y sampling,
the swizzler is used for x sampling

this class is currently only working for png and jpeg images
I will update other Codec types to work soon

For SkJpegCodec to implement width wise swizzling it now
uses a swizzler. I ran performance tests on this change.
Here are the performance test results:
https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing

BUG=skia:

Review URL: https://codereview.chromium.org/1260673002

8 years agofix up batch_spew
joshualitt [Thu, 13 Aug 2015 17:19:32 +0000 (10:19 -0700)]
fix up batch_spew

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1292113002

8 years agoMove GrRectBatch to GrBWFillRectBatch and make internal
joshualitt [Thu, 13 Aug 2015 17:05:51 +0000 (10:05 -0700)]
Move GrRectBatch to GrBWFillRectBatch and make internal

BUG=skia:

Review URL: https://codereview.chromium.org/1294553003

8 years agoadd SkImage::NewFromPicture and a GM to test it
reed [Thu, 13 Aug 2015 16:37:45 +0000 (09:37 -0700)]
add SkImage::NewFromPicture and a GM to test it

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1288403002

8 years agoSimplify parameters passed to path renderers
robertphillips [Thu, 13 Aug 2015 14:57:10 +0000 (07:57 -0700)]
Simplify parameters passed to path renderers

It appears that CanDrawPathArgs::fTarget was only ever used to access the shaderCaps and no instances of onGetStencilSupport ever used the drawTarget and pipelineBuilder parameters.

Review URL: https://codereview.chromium.org/1291803006

8 years agoadd asserts on Sk4px::Map functions that our arrays are non-null.
mtklein [Thu, 13 Aug 2015 14:51:29 +0000 (07:51 -0700)]
add asserts on Sk4px::Map functions that our arrays are non-null.

There's a crasher (null dereference it looks like) in Clank with an impossible stack, but with blit mask on top (apparently sk_free() calls blit mask...).  Can't hurt to check that all these Sk4px-using methods are iterating over non-null arrays.

(This is that bug I mentioned that got me thinking about blit mask in the first place.)

BUG=520354

Review URL: https://codereview.chromium.org/1295443002

8 years agoMinor fix to not save the modeling space rect
joshualitt [Thu, 13 Aug 2015 14:12:50 +0000 (07:12 -0700)]
Minor fix to not save the modeling space rect

BUG=skia:

Review URL: https://codereview.chromium.org/1292543002

8 years agoMove willColorBlendWithDst from pipeline builder to GrPipelineOptimizations.
bsalomon [Thu, 13 Aug 2015 14:08:31 +0000 (07:08 -0700)]
Move willColorBlendWithDst from pipeline builder to GrPipelineOptimizations.

Review URL: https://codereview.chromium.org/1285193004

8 years agoAdded mangleString member and onBefore*, onAfter* functions to GrGLFragmentShaderBuilder
wangyix [Thu, 13 Aug 2015 13:51:35 +0000 (06:51 -0700)]
Added mangleString member and  onBefore*, onAfter* functions to GrGLFragmentShaderBuilder

BUILDS! Added mangleString, onBefore, and onAfterChildProcEmitCode() to GrGLFragmentShaderBuilder.cpp

BUG=skia:4182

Review URL: https://codereview.chromium.org/1288723002

8 years agoFail early in GrPipeline::CreateAt() if XP creation fails
bsalomon [Thu, 13 Aug 2015 13:44:04 +0000 (06:44 -0700)]
Fail early in GrPipeline::CreateAt() if XP creation fails

R=egdaniel@google.com

Review URL: https://codereview.chromium.org/1286173006

8 years agoDefer flushes if kPreferNoIO is specified
robertphillips [Thu, 13 Aug 2015 12:19:14 +0000 (05:19 -0700)]
Defer flushes if kPreferNoIO is specified

Prior to this patch clients who were solely uploading to textures (e.g., SW Mask Mgr) would cause extra flushes b.c., even though kPreferNoIO was being specified, resources with pending IO would still be returned even though there was plenty of space in the resource cache.

Review URL: https://codereview.chromium.org/1286203002

8 years agoRevert "Revert[4] "move some public headers into private""
reed [Thu, 13 Aug 2015 01:58:52 +0000 (18:58 -0700)]
Revert "Revert[4] "move some public headers into private""

This reverts commit 33e00db73d5f1836481cf4053c64e4ed20537662.

BUG=skia:
TBR=
NOTREECHECKS=True

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/components/user_manager/user_manager_test_support.fake_user_manager.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=242792-1 -DCOMPONENT_BUILD -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DDONT_EMBED_BUILD_METADATA -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -D_GLIBCXX_DEBUG=1 -Igen -I../.. -I../../skia/config -I../../testing/gmock/include -I../../testing/gtest/include -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/linux_chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -B/b/build/slave/linux_chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64 -march=x86-64 -O0 -g -funwind-tables -gsplit-dwarf -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -g0 -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11  -c ../../components/user_manager/fake_user_manager.cc -o obj/components/user_manager/user_manager_test_support.fake_user_manager.o
In file included from ../../components/user_manager/fake_user_manager.cc:5:
In file included from ../../components/user_manager/fake_user_manager.h:12:
In file included from ../../components/user_manager/user.h:14:
In file included from ../../components/user_manager/user_image/user_image.h:12:
In file included from ../../ui/gfx/image/image_skia.h:15:
In file included from ../../ui/gfx/image/image_skia_rep.h:8:
In file included from ../../third_party/skia/include/core/SkBitmap.h:11:
In file included from ../../third_party/skia/include/core/SkColor.h:11:
In file included from ../../third_party/skia/include/core/SkScalar.h:12:
../../third_party/skia/include/core/../private/SkFloatingPoint.h:13:10: fatal error: 'SkTypes.h' file not found
#include "SkTypes.h"

ninja -w dupbuild=err -C /b/build/slave/linux_chromeos/build/src/out/Debug accessibility_unittests accessibility_unittests_run app_list_unittests app_list_unittests_run app_shell_unittests app_shell_unittests_run ash_unittests ash_unittests_run aura_builder aura_unittests aura_unittests_run base_unittests base_unittests_run browser_tests browser_tests_run cacheinvalidation_unittests cacheinvalidation_unittests_run chromeos_unittests chromeos_unittests_run components_unittests components_unittests_run compositor_unittests compositor_unittests_run content_browsertests content_browsertests_run content_unittests content_unittests_run crypto_unittests crypto_unittests_run dbus_unittests device_unittests device_unittests_run display_unittests display_unittests_run events_unittests events_unittests_run extensions_browsertests extensions_browsertests_run extensions_unittests extensions_unittests_run gcm_unit_tests gcm_unit_tests_run gfx_unittests gfx_unittests_run google_apis_unittests google_apis_unittests_run gpu_unittests gpu_unittests_run interactive_ui_tests interactive_ui_tests_run ipc_tests ipc_tests_run jingle_unittests jingle_unittests_run media_unittests media_unittests_run message_center_unittests message_center_unittests_run midi_unittests midi_unittests_run nacl_helper_nonsfi_unittests nacl_loader_unittests nacl_loader_unittests_run net_unittests net_unittests_run ppapi_unittests printing_unittests printing_unittests_run remoting_unittests remoting_unittests_run sandbox_linux_unittests sandbox_linux_unittests_run skia_unittests skia_unittests_run sql_unittests sql_unittests_run sync_unit_tests sync_unit_tests_run ui_base_unittests ui_base_unittests_run ui_chromeos_unittests ui_touch_selection_unittests ui_touch_selection_unittests_run unit_tests unit_tests_run url_unittests url_unittests_run views_unittests wm_unittests wm_unittests_run -j50
ninja: Entering directory `/b/build/slave/linux_chromeos/build/src/out/Debug'

Review URL: https://codereview.chromium.org/1288863002

8 years agoRevert of Normalize SkXfermode_opts.h argument order as d,s[,aa]. (patchset #1 id...
mtklein [Wed, 12 Aug 2015 20:51:27 +0000 (13:51 -0700)]
Revert of Normalize SkXfermode_opts.h argument order as d,s[,aa]. (patchset #1 id:1 of https://codereview.chromium.org/1289903002/ )

Reason for revert:
?

Original issue's description:
> Normalize SkXfermode_opts.h argument order as d,s[,aa].
>
> At head they're s,d[,aa] in SkXfermode_opts.h but Sk4px::Map* expect d,s[,aa]
> so we ended up having to write weird little lambda shims to match impedance.
>
> There's no reason for these to disagree, and d,s[,aa] is the One True Order
> (because no matter what you're doing in graphics, there's always a dst).
>
> Should be no perf or image diff, though I'm suspicious it might help MSVC code generation.
>
> BUG=skia:4117
>
> Committed: https://skia.googlesource.com/skia/+/6028a8476504022fe40b6870b1460b5e4a80969f

TBR=djsollen@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4117

Review URL: https://codereview.chromium.org/1284363002

8 years agoUse forwarding with SkTLazy::init.
bungeman [Wed, 12 Aug 2015 20:37:16 +0000 (13:37 -0700)]
Use forwarding with SkTLazy::init.

This allows removal the difficult to use (and so currently unused)
placement new and related macros to allow any constructor of T to
be used to initilize the storage of SkTLazy. This also properly
aligns the SkTLazy storage.

Review URL: https://codereview.chromium.org/1283183003

8 years agoAdd gyp support for new GPU backend
jvanverth [Wed, 12 Aug 2015 19:58:13 +0000 (12:58 -0700)]
Add gyp support for new GPU backend

Review URL: https://codereview.chromium.org/1287023006

8 years agoRefactor helper function for SkBitmapShader to GrFragmentProcessor
joshualitt [Wed, 12 Aug 2015 19:57:54 +0000 (12:57 -0700)]
Refactor helper function for SkBitmapShader to GrFragmentProcessor

BUG=skia:

Review URL: https://codereview.chromium.org/1285283002

8 years agoRevert[4] "move some public headers into private"
reed [Wed, 12 Aug 2015 19:53:10 +0000 (12:53 -0700)]
Revert[4] "move some public headers into private"

This reverts commit 9cdcabefa33d49febfdb45e388e762b4dee8dd6f.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1291613007

8 years agobroken bots war
joshualitt [Wed, 12 Aug 2015 19:52:47 +0000 (12:52 -0700)]
broken bots war

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1289803005

8 years agoAdd support for a new GPU interface
jvanverth [Wed, 12 Aug 2015 19:19:36 +0000 (12:19 -0700)]
Add support for a new GPU interface

Review URL: https://codereview.chromium.org/1290813002

8 years agoRevert of Refactor to put SkXfermode_opts inside SK_OPTS_NS. (patchset #1 id:1 of...
mtklein [Wed, 12 Aug 2015 18:56:43 +0000 (11:56 -0700)]
Revert of Refactor to put SkXfermode_opts inside SK_OPTS_NS. (patchset #1 id:1 of https://codereview.chromium.org/1286093004/ )

Reason for revert:
Maybe causing test / gold problems?

Original issue's description:
> Refactor to put SkXfermode_opts inside SK_OPTS_NS.
>
> Without this refactor I was getting warnings previously about having code
> inside namespace SK_OPTS_NS (e.g. namespace sse2, namespace neon) referring to
> code inside an anonymous namespace (Sk4px, SkPMFloat, Sk4f, etc) [1].
>
> That low-level code was in an anonymous namespace to allow multiple independent
> copies of its methods to be instantiated without the linker getting confused /
> offended about violating the One Definition Rule.  This was only happening in
> Debug mode where the methods were not being inlined.
>
> To fix this all, I've force-inlined the methods of the low-level code and
> removed the anonymous namespace.
>
> BUG=skia:4117
>
>
> [1] Here is what those errors looked like:
>
> In file included from ../../../../src/core/SkOpts.cpp:18:0:
> ../../../../src/opts/SkXfermode_opts.h:193:7: error: 'portable::Sk4pxXfermode' has a field 'portable::Sk4pxXfermode::fProc4' whose type uses the anonymous namespace [-Werror]
>  class Sk4pxXfermode : public SkProcCoeffXfermode {
>        ^
> ../../../../src/opts/SkXfermode_opts.h:193:7: error: 'portable::Sk4pxXfermode' has a field 'portable::Sk4pxXfermode::fAAProc4' whose type uses the anonymous namespace [-Werror]
> ../../../../src/opts/SkXfermode_opts.h:235:7: error: 'portable::SkPMFloatXfermode' has a field 'portable::SkPMFloatXfermode::fProcF' whose type uses the anonymous namespace [-Werror]
>  class SkPMFloatXfermode : public SkProcCoeffXfermode {
>        ^
> cc1plus: all warnings being treated as errors
>
> Committed: https://skia.googlesource.com/skia/+/b07bee3121680b53b98b780ac08d14d374dd4c6f

TBR=djsollen@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4117

Review URL: https://codereview.chromium.org/1284333002

8 years agoAdd GrAARectBatch which can handle a local matrix
joshualitt [Wed, 12 Aug 2015 18:51:46 +0000 (11:51 -0700)]
Add GrAARectBatch which can handle a local matrix

BUG=skia:

Review URL: https://codereview.chromium.org/1290763002

8 years agoAdd override to GrAAFillRectBatch::onCombineIfPossible
bsalomon [Wed, 12 Aug 2015 18:28:11 +0000 (11:28 -0700)]
Add override to GrAAFillRectBatch::onCombineIfPossible

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1287103003

8 years agoSkPDF: Move SkFlate into src/pdf (part 1/3) [reland]
halcanary [Wed, 12 Aug 2015 18:24:40 +0000 (11:24 -0700)]
SkPDF:  Move SkFlate into src/pdf (part 1/3) [reland]

Rename to SkDeflate so Chromium builders continue to work

Next, we change remove SkFlate from Chromium build files, then we can delete SkFlate.

Review URL: https://codereview.chromium.org/1285913002

8 years agoCheck for xfer barriers in GrBatch, auto-issue barriers in GrGpu
bsalomon [Wed, 12 Aug 2015 18:14:50 +0000 (11:14 -0700)]
Check for xfer barriers in GrBatch, auto-issue barriers in GrGpu

Review URL: https://codereview.chromium.org/1287973003

8 years agoNormalize SkXfermode_opts.h argument order as d,s[,aa].
mtklein [Wed, 12 Aug 2015 17:52:25 +0000 (10:52 -0700)]
Normalize SkXfermode_opts.h argument order as d,s[,aa].

At head they're s,d[,aa] in SkXfermode_opts.h but Sk4px::Map* expect d,s[,aa]
so we ended up having to write weird little lambda shims to match impedance.

There's no reason for these to disagree, and d,s[,aa] is the One True Order
(because no matter what you're doing in graphics, there's always a dst).

Should be no perf or image diff, though I'm suspicious it might help MSVC code generation.

BUG=skia:4117

Review URL: https://codereview.chromium.org/1289903002

8 years agoRefactor to put SkXfermode_opts inside SK_OPTS_NS.
mtklein [Wed, 12 Aug 2015 17:23:37 +0000 (10:23 -0700)]
Refactor to put SkXfermode_opts inside SK_OPTS_NS.

Without this refactor I was getting warnings previously about having code
inside namespace SK_OPTS_NS (e.g. namespace sse2, namespace neon) referring to
code inside an anonymous namespace (Sk4px, SkPMFloat, Sk4f, etc) [1].

That low-level code was in an anonymous namespace to allow multiple independent
copies of its methods to be instantiated without the linker getting confused /
offended about violating the One Definition Rule.  This was only happening in
Debug mode where the methods were not being inlined.

To fix this all, I've force-inlined the methods of the low-level code and
removed the anonymous namespace.

BUG=skia:4117

[1] Here is what those errors looked like:

In file included from ../../../../src/core/SkOpts.cpp:18:0:
../../../../src/opts/SkXfermode_opts.h:193:7: error: 'portable::Sk4pxXfermode' has a field 'portable::Sk4pxXfermode::fProc4' whose type uses the anonymous namespace [-Werror]
 class Sk4pxXfermode : public SkProcCoeffXfermode {
       ^
../../../../src/opts/SkXfermode_opts.h:193:7: error: 'portable::Sk4pxXfermode' has a field 'portable::Sk4pxXfermode::fAAProc4' whose type uses the anonymous namespace [-Werror]
../../../../src/opts/SkXfermode_opts.h:235:7: error: 'portable::SkPMFloatXfermode' has a field 'portable::SkPMFloatXfermode::fProcF' whose type uses the anonymous namespace [-Werror]
 class SkPMFloatXfermode : public SkProcCoeffXfermode {
       ^
cc1plus: all warnings being treated as errors

Review URL: https://codereview.chromium.org/1286093004

8 years agoAll child GrFragmentProcs' transforms and textures will be stored in the root GrFragm...
wangyix [Wed, 12 Aug 2015 16:40:47 +0000 (09:40 -0700)]
All child GrFragmentProcs' transforms and textures will be stored in the root GrFragmentProc in preorder

Changed childProcessor(i) to return const referencd

Fixed rootProc/parentProc offset issues; renamed a few things.

added nonempty check to gatherTransforms to avoid segfault

removed recursive append_gr_coord_transforms() from GrGLProgramBuilder

BUILDS! Changed num*includeProc() calls to num() calls

added gatherCoordTransforms(). added coordTransforms() for root proc only

Modified GrFragmentProcessor to append child proc transforms and textures to root proc's arrays.

BUG=skia:4182

Review URL: https://codereview.chromium.org/1275853005

8 years agoRevert of SkPDF: Move SkFlate into src/pdf (part 1/3) (patchset #1 id:1 of https...
halcanary [Wed, 12 Aug 2015 15:53:04 +0000 (08:53 -0700)]
Revert of SkPDF:  Move SkFlate into src/pdf (part 1/3) (patchset #1 id:1 of https://codereview.chromium.org/1285913002/ )

Reason for revert:
broke gn ("Duplicate object file")

Original issue's description:
> SkPDF:  Move SkFlate into src/pdf (part 1/3)
>
> Next, we change Chromium build files, then we do the actual move.
>
> Committed: https://skia.googlesource.com/skia/+/e14c1fe04fc72ec9bcf55820b5c65a71d7d0a764

TBR=bungeman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1289863002

8 years agoUpdate CodexTest to test valid_alpha.
scroggo [Wed, 12 Aug 2015 15:31:44 +0000 (08:31 -0700)]
Update CodexTest to test valid_alpha.

Add a static function to CodexTest, which consolidates decoding,
comparing to an expected SkCodec::Result, and optionally comparing to a
digest.

Test decoding non-opaque to opaque (fails) and premul to unpremul/vice
versa (succeeds).

BUG=skia:3475

Review URL: https://codereview.chromium.org/1277253003

8 years agoRevise DrawAtlasBatch to get rid of one copy when generating the batch.
jvanverth [Wed, 12 Aug 2015 15:15:31 +0000 (08:15 -0700)]
Revise DrawAtlasBatch to get rid of one copy when generating the batch.

This doesn't appear to have much affect on perf in SampleApp, but
it should avoid some copies and replaces a couple of STArrays
with one that just does a memcpy in the copy constructor.

Review URL: https://codereview.chromium.org/1279343004

8 years agoRemove trace marker support from GrBufferedDrawTarget
bsalomon [Wed, 12 Aug 2015 15:11:22 +0000 (08:11 -0700)]
Remove trace marker support from GrBufferedDrawTarget

Review URL: https://codereview.chromium.org/1284983002

8 years agoFix bmp RLE "bug"
msarett [Wed, 12 Aug 2015 15:08:56 +0000 (08:08 -0700)]
Fix bmp RLE "bug"

Chromium's test suite contains an RLE image that reports a certain
file size in the header, but then contains additional encoded data.
Our bmp decoder would only decode half of the image, before stopping.

With this fix, we check for additional data before returning
kIncompleteInput.

If this lands, I will upload the test image to the bots.

Also adding an invalid image test to CodexTest.

BUG=skia:

Review URL: https://codereview.chromium.org/1273853004

8 years agoSkPDF: Move SkFlate into src/pdf (part 1/3)
halcanary [Wed, 12 Aug 2015 14:39:33 +0000 (07:39 -0700)]
SkPDF:  Move SkFlate into src/pdf (part 1/3)

Next, we change Chromium build files, then we do the actual move.

Review URL: https://codereview.chromium.org/1285913002

8 years agoC API: add radial, sweep, and two-point conical gradient shaders
halcanary [Wed, 12 Aug 2015 14:37:34 +0000 (07:37 -0700)]
C API: add radial, sweep, and two-point conical gradient shaders

Review URL: https://codereview.chromium.org/1263773006

8 years agoConsolidate SkCodec functions for handling rewind
scroggo [Wed, 12 Aug 2015 14:24:13 +0000 (07:24 -0700)]
Consolidate SkCodec functions for handling rewind

Previously, many of our codec implementations followed the same
pattern (often in a function named handleRewind):

switch (this->rewindIfNeeded()) {
  case CouldNotRewind:
    return CouldNotRewind;
  case NoRewindNecessary:
    // keep going
    break;
  case Rewound:
     <re-read header etc>
    break;
}

In this CL, remove the enum, and put the piece that happens in the
Rewound case into a virtual function, onRewind. rewindIfNeeded now
contains the common pieces from various functions named handleRewind.

In SkBmpCodec, add a function that returns whether the BMP is in ICO,
so it can have a common implementation for onRewind.

BUG=skia:3257

Review URL: https://codereview.chromium.org/1288483002

8 years agoAdd ability to pass in an optional path to additional unit tests to run.
egdaniel [Wed, 12 Aug 2015 13:51:08 +0000 (06:51 -0700)]
Add ability to pass in an optional path to additional unit tests to run.

BUG=skia:

Review URL: https://codereview.chromium.org/1280133004

8 years agoMove AAFillRect into CPP for templatization
joshualitt [Wed, 12 Aug 2015 13:36:57 +0000 (06:36 -0700)]
Move AAFillRect into CPP for templatization

BUG=skia:

Review URL: https://codereview.chromium.org/1278043003

8 years agoRevert[3] "move some public headers into private"
reed [Wed, 12 Aug 2015 12:33:12 +0000 (05:33 -0700)]
Revert[3] "move some public headers into private"

This reverts commit 9d20ee57d72a3850a6b51f2f2b00e00978be3864.

BUG=skia:
TBR=

failures here: https://codereview.chromium.org/1286103004

Review URL: https://codereview.chromium.org/1290733002

8 years agoRevert[2] "move some public headers into private"
reed [Wed, 12 Aug 2015 11:42:08 +0000 (04:42 -0700)]
Revert[2] "move some public headers into private"

This reverts commit 4cf9e7e14797f87f08b2078fa1afaf731cbf8f52.

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/1284173002

8 years agoMake GrBatch carry its own GrPipeline
bsalomon [Tue, 11 Aug 2015 21:47:42 +0000 (14:47 -0700)]
Make GrBatch carry its own GrPipeline

Review URL: https://codereview.chromium.org/1278643006

8 years agoHopefully fix ios bots
msarett [Tue, 11 Aug 2015 21:44:02 +0000 (14:44 -0700)]
Hopefully fix ios bots
BUG=skia:

Review URL: https://codereview.chromium.org/1286833002

8 years agoSkPDF: clean up overuse of SK_SUPPORT_PDF
halcanary [Tue, 11 Aug 2015 20:35:12 +0000 (13:35 -0700)]
SkPDF: clean up overuse of SK_SUPPORT_PDF

When possible use run-time checks (via SkDocument::CreatePDF)
When PDF is disabled, do not compile tests/PDF*.cpp

Review URL: https://codereview.chromium.org/1278403006

8 years agoSwitching Skia to chromium's libjpeg-turbo
msarett [Tue, 11 Aug 2015 20:32:54 +0000 (13:32 -0700)]
Switching Skia to chromium's libjpeg-turbo

Compile SkJpegCodec and SkImageDecoder_libjpeg with
chromium's libjpeg-turbo.  SkImageDecoder_libjpeg still uses
libjpeg on Android and the Android framework.  SkJpegCodec is
still not compiled on the Android framework.

BUG=skia:

Review URL: https://codereview.chromium.org/1275773004

8 years agodecrement lockcount if we failed to get pixels
reed [Tue, 11 Aug 2015 19:23:45 +0000 (12:23 -0700)]
decrement lockcount if we failed to get pixels

BUG=519581

Review URL: https://codereview.chromium.org/1284953002

8 years agoAdd high resolution WallTimer to SampleApp
jvanverth [Tue, 11 Aug 2015 18:07:07 +0000 (11:07 -0700)]
Add high resolution WallTimer to SampleApp

Gives better than 1 ms results when timing framerate.

Review URL: https://codereview.chromium.org/1288473002

8 years agoSkPDF: allow PDF module to be disabled in DM and SampleApp
halcanary [Tue, 11 Aug 2015 17:30:12 +0000 (10:30 -0700)]
SkPDF: allow PDF module to be disabled in DM and SampleApp

To disable PDF:

    GYP_DEFINES='skia_pdf=0' bin/sync-and-gyp
    ninja -C out/Debug dm SampleApp

When disabled, SkDocument::CreatePDF() always returns NULL.

Review URL: https://codereview.chromium.org/1279123007

8 years agoRevert "move some public headers into private"
reed [Tue, 11 Aug 2015 15:39:18 +0000 (08:39 -0700)]
Revert "move some public headers into private"

This reverts commit eedf0fb20489bc6c3706539dd6ab499f41cbe048.

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/1270313005

8 years agomove some public headers into private
reed [Tue, 11 Aug 2015 14:15:00 +0000 (07:15 -0700)]
move some public headers into private

BUG=skia:

Review URL: https://codereview.chromium.org/1289483002

8 years agoMove Perf documentation to the testing section
hcm [Tue, 11 Aug 2015 14:00:01 +0000 (07:00 -0700)]
Move Perf documentation to the testing section

BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1280533003

Review URL: https://codereview.chromium.org/1280533003

8 years agoMake initBatchTracker private, move towards pipeline on batch
bsalomon [Mon, 10 Aug 2015 20:03:50 +0000 (13:03 -0700)]
Make initBatchTracker private, move towards pipeline on batch

Review URL: https://codereview.chromium.org/1282893002

8 years agoSk4px blit mask.
mtklein [Mon, 10 Aug 2015 19:58:17 +0000 (12:58 -0700)]
Sk4px blit mask.

Local SKP nanobenching ranges SSE between 1.05x and 0.87x, much more heavily weighted toward <1.0x ratios (speedups).
I profiled the top five regressions (1.05x-1.01x) and they look like noise.  Will follow up after broad bot results.

NEON looks similar but less extreme than SSE changes, ranging between 1.02x and 0.95x, again mostly speedups in 0.99x-0.97x range.

The old code trifurcated into black, opaque-but-not-black, and general versions as a function of the constant src color.  I did not see a significant difference between general and opaque-but-not-black, and I don't think a black version would be faster using SIMD.  So we have here just one version of the code, the general version.

Somewhat fantastically, I see no pixel diffs on GMs or SKPs.

I will be following up with more CLs for the other procs called by SkBlitMask.
BUG=skia:

Review URL: https://codereview.chromium.org/1278253003

8 years agoRemove GrPipelineOptimizations member from GrPipeline
bsalomon [Mon, 10 Aug 2015 19:01:15 +0000 (12:01 -0700)]
Remove GrPipelineOptimizations member from GrPipeline

Review URL: https://codereview.chromium.org/1275003004

8 years agotrivial CL to add drawBatch to GrDrawContext
joshualitt [Mon, 10 Aug 2015 18:59:02 +0000 (11:59 -0700)]
trivial CL to add drawBatch to GrDrawContext

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1282883002

8 years agoExpand functionality of GrRectBatchFactory with AARects
joshualitt [Mon, 10 Aug 2015 18:40:56 +0000 (11:40 -0700)]
Expand functionality of GrRectBatchFactory with AARects

BUG=skia:

Review URL: https://codereview.chromium.org/1279303002

8 years agoFix to call SkDelete_array instead of SkDelete to fix ASAN error.
egdaniel [Mon, 10 Aug 2015 18:39:10 +0000 (11:39 -0700)]
Fix to call SkDelete_array instead of SkDelete to fix ASAN error.
TBR=mtklein@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1282333002

8 years agoRevert of [TextBlob] Fall back to TightRunBounds when the font bounds are empty ...
egdaniel [Mon, 10 Aug 2015 18:02:46 +0000 (11:02 -0700)]
Revert of [TextBlob] Fall back to TightRunBounds when the font bounds are empty (patchset #1 id:1 of https://codereview.chromium.org/1284693002/ )

Reason for revert:
Breaking DEPS roll on Assert in SkTextBlobBuilder::TightRunBounds.

Original issue's description:
> [TextBlob] Fall back to TightRunBounds when the font bounds are empty
>
> Empty font bounds are likely an indication of a font bug.  As a best
> effort, we can use TightRunBounds in this easily detectable case.
>
> BUG=507022
> R=reed@google.com,bungeman@google.com
>
> Committed: https://skia.googlesource.com/skia/+/d6b99cc6b84b3ec864221cbe9945d203bd9eb072

TBR=bungeman@google.com,reed@google.com,fmalita@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=507022

Review URL: https://codereview.chromium.org/1283853002

8 years agoRename GrPipelineInfo to GrPipelineOptimizations
bsalomon [Mon, 10 Aug 2015 17:47:29 +0000 (10:47 -0700)]
Rename GrPipelineInfo to GrPipelineOptimizations

TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/1274513005

8 years agoMove GrStrokeRectBatch creation to behind factory
joshualitt [Mon, 10 Aug 2015 17:30:14 +0000 (10:30 -0700)]
Move GrStrokeRectBatch creation to behind factory

BUG=skia:

Review URL: https://codereview.chromium.org/1282283002

8 years agoCreate GrRectBatchFactory
joshualitt [Mon, 10 Aug 2015 17:08:26 +0000 (10:08 -0700)]
Create GrRectBatchFactory

BUG=skia:

Review URL: https://codereview.chromium.org/1287433003

8 years agoThis is a speculative fix for the crash on IOS
egdaniel [Mon, 10 Aug 2015 17:06:43 +0000 (10:06 -0700)]
This is a speculative fix for the crash on IOS
TBR=mtklein

Review URL: https://codereview.chromium.org/1277433005

8 years ago[TextBlob] Fall back to TightRunBounds when the font bounds are empty
fmalita [Mon, 10 Aug 2015 16:24:31 +0000 (09:24 -0700)]
[TextBlob] Fall back to TightRunBounds when the font bounds are empty

Empty font bounds are likely an indication of a font bug.  As a best
effort, we can use TightRunBounds in this easily detectable case.

BUG=507022
R=reed@google.com,bungeman@google.com

Review URL: https://codereview.chromium.org/1284693002

8 years agomove Stroke Rect and AAFill Rect to their own file
joshualitt [Mon, 10 Aug 2015 16:03:51 +0000 (09:03 -0700)]
move Stroke Rect and AAFill Rect to their own file

BUG=skia:

Review URL: https://codereview.chromium.org/1282723004

8 years agoEnsure that android "release" apps are signed with debug key
djsollen [Mon, 10 Aug 2015 15:58:03 +0000 (08:58 -0700)]
Ensure that android "release" apps are signed with debug key

Review URL: https://codereview.chromium.org/1275223003

8 years agoSkPDF: add assert for that SkWStream behaves.
halcanary [Mon, 10 Aug 2015 15:49:03 +0000 (08:49 -0700)]
SkPDF: add assert for that SkWStream behaves.

Motivation:  this might catch future issues like this.

BUG=skia:4181

Review URL: https://codereview.chromium.org/1287443002

8 years agoUse a factory function to create GrPipeline and remove unused member
bsalomon [Mon, 10 Aug 2015 15:23:11 +0000 (08:23 -0700)]
Use a factory function to create GrPipeline and remove unused member

Review URL: https://codereview.chromium.org/1273803004

8 years agoWire up testcreate function for GrDrawAtlasBatch
joshualitt [Mon, 10 Aug 2015 15:02:58 +0000 (08:02 -0700)]
Wire up testcreate function for GrDrawAtlasBatch

BUG=skia:

Review URL: https://codereview.chromium.org/1285593002

8 years agoRemove an unused function.
thakis [Mon, 10 Aug 2015 13:05:17 +0000 (06:05 -0700)]
Remove an unused function.

BUG=chromium:505316

Review URL: https://codereview.chromium.org/1282143002

8 years agoapi helpers inspired by blink use-cases
reed [Mon, 10 Aug 2015 02:41:13 +0000 (19:41 -0700)]
api helpers inspired by blink use-cases

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1278323002

8 years agoremove unneeded _DRAWIMAGERECT flags
reed [Sat, 8 Aug 2015 02:09:09 +0000 (19:09 -0700)]
remove unneeded _DRAWIMAGERECT flags

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1281123002

8 years agofixup precision with configurable atlas
joshualitt [Fri, 7 Aug 2015 20:36:44 +0000 (13:36 -0700)]
fixup precision with configurable atlas

BUG=skia:

Review URL: https://codereview.chromium.org/1276383003

8 years agoRevert of Update libwebp and resume testing scaled webp (patchset #2 id:20001 of...
scroggo [Fri, 7 Aug 2015 19:53:25 +0000 (12:53 -0700)]
Revert of Update libwebp and resume testing scaled webp (patchset #2 id:20001 of https://codereview.chromium.org/1280073002/ )

Reason for revert:
Compile failures, e.g.

http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_NoNeon/builds/1427/steps/build%20most/logs/stdio

Original issue's description:
> Update libwebp and resume testing scaled webp
>
> libwebp has a fix for [1]. Update to the commit that contains the fix.
>
> Update libwebp.gypi, corresponding to libwebp's latest makefile.
>
> Turn back on DM testing for scaled webp, now that it should no longer
> use uninitialized memory.
>
> Fix a warning in config.h
>
> [1] https://code.google.com/p/webp/issues/detail?id=254
>
> BUG=skia:4038
>
> Committed: https://skia.googlesource.com/skia/+/0575d3e6c272744a66ab3281f9871366717df339

TBR=djsollen@google.com,msarett@google.com,scroggo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4038

Review URL: https://codereview.chromium.org/1278173004

8 years agoUpdate libwebp and resume testing scaled webp
scroggo [Fri, 7 Aug 2015 19:49:16 +0000 (12:49 -0700)]
Update libwebp and resume testing scaled webp

libwebp has a fix for [1]. Update to the commit that contains the fix.

Update libwebp.gypi, corresponding to libwebp's latest makefile.

Turn back on DM testing for scaled webp, now that it should no longer
use uninitialized memory.

Fix a warning in config.h

[1] https://code.google.com/p/webp/issues/detail?id=254

BUG=skia:4038

Review URL: https://codereview.chromium.org/1280073002

8 years agoGrDrawVertices to batches
joshualitt [Fri, 7 Aug 2015 19:46:26 +0000 (12:46 -0700)]
GrDrawVertices to batches

BUG=skia:

Review URL: https://codereview.chromium.org/1276333004

8 years agoMove GrDrawAtlasBatch to separate file
jvanverth [Fri, 7 Aug 2015 19:18:54 +0000 (12:18 -0700)]
Move GrDrawAtlasBatch to separate file

Committed: https://skia.googlesource.com/skia/+/b091c44c33edbad3466601b29d60bc2eaa4453fa

Review URL: https://codereview.chromium.org/1274013003

8 years agoRevert of Move GrDrawAtlasBatch to separate file (patchset #1 id:1 of https://coderev...
jvanverth [Fri, 7 Aug 2015 18:53:13 +0000 (11:53 -0700)]
Revert of Move GrDrawAtlasBatch to separate file (patchset #1 id:1 of https://codereview.chromium.org/1274013003/ )

Reason for revert:
Build failures

Original issue's description:
> Move GrDrawAtlasBatch to separate file
>
> Committed: https://skia.googlesource.com/skia/+/b091c44c33edbad3466601b29d60bc2eaa4453fa

TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1276173003

8 years agoMove GrDrawAtlasBatch to separate file
jvanverth [Fri, 7 Aug 2015 18:49:17 +0000 (11:49 -0700)]
Move GrDrawAtlasBatch to separate file

Review URL: https://codereview.chromium.org/1274013003

8 years agoMake folder for batches
joshualitt [Fri, 7 Aug 2015 18:42:16 +0000 (11:42 -0700)]
Make folder for batches

BUG=skia:

Review URL: https://codereview.chromium.org/1277233002

8 years agoFirst pass at drawAtlas batching.
jvanverth [Fri, 7 Aug 2015 17:09:28 +0000 (10:09 -0700)]
First pass at drawAtlas batching.

Moves drawAtlas setup into its own method in GrDrawContext, and adds
DrawAtlasBatch.
Uses pre-built index buffer for quads.

TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/1277933003

8 years agoGold Workflows Documentation
hcm [Fri, 7 Aug 2015 17:09:03 +0000 (10:09 -0700)]
Gold Workflows Documentation

BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1276663003

Review URL: https://codereview.chromium.org/1276663003

8 years agoBreak LCD and Bitmap text dependency on hardcoded atlas values
joshualitt [Fri, 7 Aug 2015 16:55:23 +0000 (09:55 -0700)]
Break LCD and Bitmap text dependency on hardcoded atlas values

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/846b022f6b469cfde285372f26e0d5c593d122ac

Review URL: https://codereview.chromium.org/1271873002

8 years agoAdd approxBytesUsed to hashes.
mtklein [Fri, 7 Aug 2015 16:33:37 +0000 (09:33 -0700)]
Add approxBytesUsed to hashes.

BUG=skia:

Review URL: https://codereview.chromium.org/1280653003

8 years agoThe compiler can generate smulbb perfectly well nowadays.
mtklein [Fri, 7 Aug 2015 15:48:12 +0000 (08:48 -0700)]
The compiler can generate smulbb perfectly well nowadays.

BUG=skia:4117

Review URL: https://codereview.chromium.org/1273203002

8 years agoAdd Batch logging
joshualitt [Fri, 7 Aug 2015 15:11:19 +0000 (08:11 -0700)]
Add Batch logging

BUG=skia:

Review URL: https://codereview.chromium.org/1276913002

8 years agoThis iOS crash makes little sense to me. Add some debugging.
mtklein [Fri, 7 Aug 2015 14:22:44 +0000 (07:22 -0700)]
This iOS crash makes little sense to me.  Add some debugging.

We called new float[...].  The pointer returned should be aligned for float writes.

See https://uberchromegw.corp.google.com/i/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/30e4d75c3aebf49b179c265a91adbb6012970d2b

Review URL: https://codereview.chromium.org/1270403006

8 years agoThis iOS crash makes little sense to me. Add some debugging.
mtklein [Fri, 7 Aug 2015 13:55:31 +0000 (06:55 -0700)]
This iOS crash makes little sense to me.  Add some debugging.

We called new float[...].  The pointer returned should be aligned for float writes.

See https://uberchromegw.corp.google.com/i/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release

BUG=skia:

Review URL: https://codereview.chromium.org/1270403006

8 years agoFix StringTest for VS2015
bsalomon [Fri, 7 Aug 2015 00:56:13 +0000 (17:56 -0700)]
Fix StringTest for VS2015

TBR=reed@google.com

Review URL: https://codereview.chromium.org/1280853002