Denis Kenzior [Fri, 7 Aug 2009 16:50:42 +0000 (11:50 -0500)]
Keep new numbers in the main sim data structure
No sense to allocate / free memory for a single pointer
Denis Kenzior [Fri, 7 Aug 2009 16:35:14 +0000 (11:35 -0500)]
Move error label to a more logical place
Denis Kenzior [Fri, 7 Aug 2009 16:34:52 +0000 (11:34 -0500)]
Move variable declarations to a move logical place
Andrzej Zaborowski [Fri, 7 Aug 2009 09:24:27 +0000 (11:24 +0200)]
Make SubscriberNumbers writable.
This implements writing SubscriberNumbers if the SIM allows this
(optional to the SIM provider). Because the property is an array
of phone numbers, setting the property needs to write multiple
records on the SIM so it's not atomic and potentially can fail
partially. In this case we have to report a write error to DBus
client but at the same time file may be changed and we send a
PropertyChanged.
Andrzej Zaborowski [Thu, 6 Aug 2009 20:29:12 +0000 (22:29 +0200)]
Make SIM op queue more robust.
This allows ofono_sim_read and ofono_sim_write callbacks to queue new
read or write operations. The callback must not be called between
removing the operation from queue and checking queue length.
Marcel Holtmann [Fri, 7 Aug 2009 05:10:19 +0000 (22:10 -0700)]
Fix blocking service watch initial connect handling
Denis Kenzior [Thu, 6 Aug 2009 22:33:44 +0000 (17:33 -0500)]
Fix style
Denis Kenzior [Thu, 6 Aug 2009 22:33:00 +0000 (17:33 -0500)]
Fix style
Denis Kenzior [Thu, 6 Aug 2009 22:29:55 +0000 (17:29 -0500)]
Add whitespace properly
Denis Kenzior [Thu, 6 Aug 2009 22:29:11 +0000 (17:29 -0500)]
Fix trailing whitespace
Denis Kenzior [Thu, 6 Aug 2009 22:26:06 +0000 (17:26 -0500)]
No spaces between variable and ++/--
Denis Kenzior [Thu, 6 Aug 2009 22:24:46 +0000 (17:24 -0500)]
Fix trailing whitespace
Denis Kenzior [Thu, 6 Aug 2009 22:24:23 +0000 (17:24 -0500)]
Fix trailing whitespace
Denis Kenzior [Thu, 6 Aug 2009 22:05:52 +0000 (17:05 -0500)]
Be more lenient for PDU lines
Denis Kenzior [Thu, 6 Aug 2009 22:05:31 +0000 (17:05 -0500)]
Remove unneeded declarations
Denis Kenzior [Thu, 6 Aug 2009 20:50:22 +0000 (15:50 -0500)]
Update AT modem plugin to use GAtChat logging
Enabled if OFONO_AT_DEBUG environment variable is set
Denis Kenzior [Thu, 6 Aug 2009 20:50:10 +0000 (15:50 -0500)]
Cleanup the debug support patch
Andres Salomon [Wed, 5 Aug 2009 21:18:34 +0000 (17:18 -0400)]
gatchat: add debugging infrastructure
This patch adds debugging support to GAtChat (specifically of what's going
across the serial line). Callbacks can be set via g_at_chat_set_debugging,
and that callback is called after any channel reads or writes.
Denis Kenzior [Thu, 6 Aug 2009 19:23:04 +0000 (14:23 -0500)]
Make overflow code a bit better
Denis Kenzior [Tue, 4 Aug 2009 23:53:53 +0000 (18:53 -0500)]
Fixup atmodem.c for gatchat changes
Denis Kenzior [Tue, 4 Aug 2009 23:53:25 +0000 (18:53 -0500)]
Refactor GAtChat to accept user-provided parsers
Intended for really broken modems. A default 27.007 compliant
parser is provided.
Denis Kenzior [Thu, 6 Aug 2009 15:32:29 +0000 (10:32 -0500)]
Fix refcounting in GAtChat
Yang Gu [Thu, 6 Aug 2009 03:40:49 +0000 (11:40 +0800)]
Enlarge the timeout for phonebook import
Denis Kenzior [Thu, 6 Aug 2009 20:39:30 +0000 (15:39 -0500)]
Squash warning
Denis Kenzior [Thu, 6 Aug 2009 20:39:04 +0000 (15:39 -0500)]
Squash warning
Denis Kenzior [Thu, 6 Aug 2009 20:38:36 +0000 (15:38 -0500)]
Squash warning
Andrzej Zaborowski [Wed, 5 Aug 2009 07:08:40 +0000 (09:08 +0200)]
Attempt to update MBDN based on Enhanced VM IEI
Andrzej Zaborowski [Wed, 5 Aug 2009 07:08:40 +0000 (09:08 +0200)]
Implement committing the EF-MBDN records to SIM
Andrzej Zaborowski [Wed, 5 Aug 2009 07:08:40 +0000 (09:08 +0200)]
Add utility for building ADN records
Used to populate MSISDN, MBDN, etc records on the SIM
Andrzej Zaborowski [Wed, 5 Aug 2009 07:08:40 +0000 (09:08 +0200)]
Expose address encode/decode utilities
These can be used elsewhere, in particular for decoding the
enhanced message waiting notification ieis
Andrzej Zaborowski [Wed, 5 Aug 2009 07:08:40 +0000 (09:08 +0200)]
Add encode_bcd_number utility function
Denis Kenzior [Wed, 5 Aug 2009 17:44:36 +0000 (12:44 -0500)]
Don't emit signals for unexposed properties
Signals shouldn't be emitted, but we should still track the information
so it can be written to the SIM reliably
Andrzej Zaborowski [Wed, 5 Aug 2009 09:25:21 +0000 (11:25 +0200)]
Fix record number in at_sim_update_record.
Denis Kenzior [Wed, 5 Aug 2009 17:35:08 +0000 (12:35 -0500)]
Don't hardcode info len to 6
Denis Kenzior [Wed, 5 Aug 2009 17:33:57 +0000 (12:33 -0500)]
Make method async
Denis Kenzior [Wed, 5 Aug 2009 17:33:01 +0000 (12:33 -0500)]
Remove unused declaration
Andrzej Zaborowski [Wed, 5 Aug 2009 05:17:10 +0000 (07:17 +0200)]
Use invalid_args instead of invalid_format
Denis Kenzior [Tue, 4 Aug 2009 19:56:03 +0000 (14:56 -0500)]
Refactor how mwis updates are done
Denis Kenzior [Tue, 4 Aug 2009 19:07:16 +0000 (14:07 -0500)]
Name the callback properly
Denis Kenzior [Tue, 4 Aug 2009 18:59:30 +0000 (13:59 -0500)]
Don't emit SubscriberNumbers multiple times
We would emit the signal even if the record could not be parsed
Denis Kenzior [Tue, 4 Aug 2009 18:44:01 +0000 (13:44 -0500)]
Refactor how MBDN set is done
Denis Kenzior [Tue, 4 Aug 2009 16:04:47 +0000 (11:04 -0500)]
Don't gmalloc something that is max 140 bytes
Denis Kenzior [Tue, 4 Aug 2009 15:56:07 +0000 (10:56 -0500)]
Get rid of message-waiting.h
Denis Kenzior [Tue, 4 Aug 2009 15:45:15 +0000 (10:45 -0500)]
Fix minor style issues
Denis Kenzior [Tue, 4 Aug 2009 15:25:54 +0000 (10:25 -0500)]
Use invalid_args instead of invalid_format
Andrzej Zaborowski [Mon, 3 Aug 2009 12:50:14 +0000 (14:50 +0200)]
Add a MessageWaiting interface to track message waiting indications.
The state of the indications is kept in memory and written back to
the SIM after any changes.
Denis Kenzior [Tue, 4 Aug 2009 15:16:06 +0000 (10:16 -0500)]
Fix segfault when pnn record doesn't exist
Denis Kenzior [Tue, 4 Aug 2009 15:15:33 +0000 (10:15 -0500)]
Put defines near the top
Denis Kenzior [Tue, 4 Aug 2009 15:15:00 +0000 (10:15 -0500)]
Port Andrew's TFR patch
Denis Kenzior [Tue, 4 Aug 2009 15:02:50 +0000 (10:02 -0500)]
Make sim_op_info_cb caching a bit more readable
Denis Kenzior [Tue, 4 Aug 2009 14:54:51 +0000 (09:54 -0500)]
Make cache a gboolean
Denis Kenzior [Tue, 4 Aug 2009 14:53:11 +0000 (09:53 -0500)]
Make sim_op_retrieve_cb a bit more readable
Andrzej Zaborowski [Mon, 3 Aug 2009 13:38:21 +0000 (15:38 +0200)]
Check write() return values in sim.c for errors.
Andrzej Zaborowski [Tue, 4 Aug 2009 03:39:40 +0000 (05:39 +0200)]
Fix invalid queue use in sim_write_cb
Since we pop the queue's head, we can't use sim_op_error
Marcel Holtmann [Mon, 3 Aug 2009 18:20:46 +0000 (11:20 -0700)]
Fix over-complicated code flow that results in uninitialized variables
Andrzej Zaborowski [Sat, 1 Aug 2009 12:17:43 +0000 (14:17 +0200)]
Make sure SIM read callbacks die cleanly.
Denis Kenzior [Mon, 3 Aug 2009 17:41:44 +0000 (12:41 -0500)]
Make is_read a gboolean
Andrzej Zaborowski [Sat, 1 Aug 2009 13:48:37 +0000 (15:48 +0200)]
Implement ofono_sim_write
Writes use sim->simop_q queue together with reads.
Rémi Denis-Courmont [Mon, 3 Aug 2009 07:42:51 +0000 (10:42 +0300)]
Fix configure script on bash 2.0
../configure: line 11885: CFLAGS+= -Werror -Wextra: command not found
../configure: line 11886: CFLAGS+= -Wno-unused-parameter: command not found
../configure: line 11887: CFLAGS+= -Wno-missing-field-initializers: command not found
../configure: line 11888: CFLAGS+= -Wdeclaration-after-statement: command not found
../configure: line 11889: CFLAGS+= -Wmissing-declarations: command not found
../configure: line 11890: CFLAGS+= -Wredundant-decls: command not found
../configure: line 11891: CFLAGS+= -Wcast-align: command not found
Denis Kenzior [Fri, 31 Jul 2009 23:32:44 +0000 (18:32 -0500)]
Make distcheck work
Andres Salomon [Tue, 28 Jul 2009 01:34:51 +0000 (21:34 -0400)]
add manpage for ofonod
I created this manpage for Debian; feel free to use it. The license
is the same as oFono's.
Andrzej Zaborowski [Thu, 30 Jul 2009 08:05:32 +0000 (10:05 +0200)]
Fix possible memory leak on SIM reading error.
This would also stall the SIM op queue if there's a read error for a record
other than the first. The other solution would be "goto next;" (keep
reading further records).
Andrzej Zaborowski [Thu, 30 Jul 2009 08:05:10 +0000 (10:05 +0200)]
Don't use g_slist_length to check for empty lists.
A glib Anti-pattern according to http://www.burtonini.com/blog
Andrzej Zaborowski [Thu, 30 Jul 2009 08:04:59 +0000 (10:04 +0200)]
Clean up in sim.c.
Remove unused variables and fields.
Move EFadn format parsing to a common function because various files use
this same format.
Andrzej Zaborowski [Mon, 27 Jul 2009 16:36:11 +0000 (18:36 +0200)]
Use STORAGEDIR autoconf voodoo from Bluez.
Denis Kenzior [Wed, 29 Jul 2009 21:53:19 +0000 (16:53 -0500)]
Remove all uses of modem.h
Denis Kenzior [Wed, 29 Jul 2009 21:40:30 +0000 (16:40 -0500)]
Get rid of modem.h
Denis Kenzior [Wed, 29 Jul 2009 21:32:51 +0000 (16:32 -0500)]
Get rid of unnecessary function
Denis Kenzior [Wed, 29 Jul 2009 21:32:10 +0000 (16:32 -0500)]
Move ofono_modem functions to modem.c
Denis Kenzior [Wed, 29 Jul 2009 21:09:12 +0000 (16:09 -0500)]
Move MODEM_INTERFACE to dbus.h
Denis Kenzior [Wed, 29 Jul 2009 20:46:47 +0000 (15:46 -0500)]
Move MANAGER_PATH to dbus.h
Denis Kenzior [Wed, 29 Jul 2009 20:43:58 +0000 (15:43 -0500)]
Move MANAGER_INTERFACE to dbus.h
Denis Kenzior [Wed, 29 Jul 2009 19:33:58 +0000 (14:33 -0500)]
Rename ofono_modem_userdata
Denis Kenzior [Wed, 29 Jul 2009 19:26:45 +0000 (14:26 -0500)]
Make plugins use ofono_modem_get_path
Denis Kenzior [Wed, 29 Jul 2009 19:16:53 +0000 (14:16 -0500)]
Rename modem_add_interface / modem_remove_interface
Move to ofono_modem_add_interface, ofono_modem_remove_interface
and put in ofono/modem.h
Denis Kenzior [Wed, 29 Jul 2009 19:05:33 +0000 (14:05 -0500)]
Rename modem_alloc_callid, modem_release_callid
Denis Kenzior [Wed, 29 Jul 2009 19:03:34 +0000 (14:03 -0500)]
Move ofono_modem definition to ofono.h
Denis Kenzior [Wed, 29 Jul 2009 17:59:39 +0000 (12:59 -0500)]
Rename internal ofono history funcs to __ofono
Denis Kenzior [Wed, 29 Jul 2009 16:13:54 +0000 (11:13 -0500)]
Remove supports_tech variable
The proper way to register with a particular network technology
is to use a band selection command (e.g. select 2G only or 3G only,
or hybrid)
The tech selection according to 27.007 is non-binding anyway
Denis Kenzior [Wed, 29 Jul 2009 16:10:57 +0000 (11:10 -0500)]
Tweak CREG notification to be more fault tolerant
Denis Kenzior [Wed, 29 Jul 2009 16:10:47 +0000 (11:10 -0500)]
Rename dbus-gsm.c to dbus.c
Denis Kenzior [Wed, 29 Jul 2009 15:55:00 +0000 (10:55 -0500)]
Get rid of dbus-gsm.h
Denis Kenzior [Wed, 29 Jul 2009 15:40:17 +0000 (10:40 -0500)]
Rename dbus_gsm_pending_reply
Denis Kenzior [Wed, 29 Jul 2009 15:33:45 +0000 (10:33 -0500)]
Don't expose dbus_gsm_append_array_variant
Denis Kenzior [Wed, 29 Jul 2009 15:32:43 +0000 (10:32 -0500)]
Don't expose dbus_gsm_append_variant
Denis Kenzior [Wed, 29 Jul 2009 15:29:52 +0000 (10:29 -0500)]
Rename dbus_gsm_dict_append_array
Denis Kenzior [Wed, 29 Jul 2009 15:26:55 +0000 (10:26 -0500)]
Rename dbus_gsm_dict_append
Denis Kenzior [Wed, 29 Jul 2009 15:26:38 +0000 (10:26 -0500)]
Move & Rename PROPERTIES_ARRAY_SIGNATURE
Denis Kenzior [Wed, 29 Jul 2009 15:06:42 +0000 (10:06 -0500)]
Rename dbus_gsm_signal_array_property_changed
Denis Kenzior [Wed, 29 Jul 2009 15:04:06 +0000 (10:04 -0500)]
Rename dbus_gsm_signal_property_changed
Denis Kenzior [Wed, 29 Jul 2009 14:58:52 +0000 (09:58 -0500)]
Fix segfault
Denis Kenzior [Wed, 29 Jul 2009 00:11:32 +0000 (19:11 -0500)]
Rename dbus_gsm error functions to __ofono_error
Denis Kenzior [Tue, 28 Jul 2009 22:42:16 +0000 (17:42 -0500)]
Remove reconnect timeout define
Denis Kenzior [Tue, 28 Jul 2009 22:39:35 +0000 (17:39 -0500)]
Get rid of dbus_gsm_free_string_array
Use g_strfreev instead.
Denis Kenzior [Tue, 28 Jul 2009 21:59:05 +0000 (16:59 -0500)]
Refactor dbus initialization & reconnect
Denis Kenzior [Tue, 28 Jul 2009 21:29:08 +0000 (16:29 -0500)]
Move & Rename dbus_gsm_init & dbus_gsm_exit
Rename to __ofono_dbus_init && __ofono_dbus_cleanup for consistency
Move to ofono.h
Denis Kenzior [Tue, 28 Jul 2009 20:58:01 +0000 (15:58 -0500)]
Remove dbus_gsm_set_connection from header
Not actually needed outside of dbus-gsm.c
Denis Kenzior [Tue, 28 Jul 2009 20:56:11 +0000 (15:56 -0500)]
Move & Rename dbus_gsm_connection
Move to ofono/dbus.h ofono_dbus_get_connection
Denis Kenzior [Tue, 28 Jul 2009 20:50:26 +0000 (15:50 -0500)]
Add new ofono/dbus.h header
Denis Kenzior [Tue, 28 Jul 2009 20:26:37 +0000 (15:26 -0500)]
Experimental support for modems with no UCS2/UTF8
Some modems, like the G1 do not support UCS2/UTF8. However, we can
still attempt to export some phonebook entries which are probably
going to be simple Latin1 characters (e.g. 411, etc)