platform/upstream/dotnet/runtime.git
5 years agoRe-enable xunit warning 1019 (dotnet/corefx#40415)
madmir [Tue, 20 Aug 2019 00:59:07 +0000 (02:59 +0200)]
Re-enable xunit warning 1019 (dotnet/corefx#40415)

Make MemberData reference IEnumerable<object[]>

Commit migrated from https://github.com/dotnet/corefx/commit/3c09762fa14249c65e5bc676a5d812c2654c8941

5 years agoHonor converters for implementing types (dotnet/corefx#40411)
Layomi Akinrinade [Tue, 20 Aug 2019 00:06:47 +0000 (20:06 -0400)]
Honor converters for implementing types (dotnet/corefx#40411)

* Honor converters for implementing types

* Cache implementing-type converter if one is detected

* Address feedback: name parameters and add IEnumerable wrapper test

Commit migrated from https://github.com/dotnet/corefx/commit/ee880076f3bcacde1a32e88ea4ebd701a609e52d

5 years agoUse new instances of JsonSerializerOptions in property visibility tests to prevent...
Layomi Akinrinade [Mon, 19 Aug 2019 22:42:49 +0000 (18:42 -0400)]
Use new instances of JsonSerializerOptions in property visibility tests to prevent re-using cached metadata (dotnet/corefx#40414)

Commit migrated from https://github.com/dotnet/corefx/commit/21ce6673922a93d34117b6c757f394600b7f7dbb

5 years agoAdd DecoratedNameAttribute (dotnet/corefx#40125)
Jeremy Koritzinsky [Mon, 19 Aug 2019 18:15:08 +0000 (11:15 -0700)]
Add DecoratedNameAttribute (dotnet/corefx#40125)

Commit migrated from https://github.com/dotnet/corefx/commit/86db0ef4acc409ab29cd07908aec21c2dc237ea0

5 years agoHonor JsonIgnore attribute when applied to unsupported collections (dotnet/corefx...
Layomi Akinrinade [Mon, 19 Aug 2019 13:42:54 +0000 (09:42 -0400)]
Honor JsonIgnore attribute when applied to unsupported collections (dotnet/corefx#40401)

* Honor JsonIgnore attribute when applied to unsupported collections

* Address feedback: add more unsupported collections

Commit migrated from https://github.com/dotnet/corefx/commit/6739eab2f4ee9a895575289893edf63b6c234d43

5 years agoAvoid using double/floats within tests that don't roundtrip on netfx (dotnet/corefx...
Ahson Khan [Mon, 19 Aug 2019 11:15:46 +0000 (04:15 -0700)]
Avoid using double/floats within tests that don't roundtrip on netfx (dotnet/corefx#40408)

(for G17).

Commit migrated from https://github.com/dotnet/corefx/commit/b2ea249aa67d719b35c6a1c95befbf2b819bab17

5 years agoCorefx dotnet/corefx#40133 Use TryFormatDouble TryFormatFloat (dotnet/corefx#40197)
Mandar Sahasrabuddhe [Mon, 19 Aug 2019 04:04:53 +0000 (09:34 +0530)]
Corefx dotnet/corefx#40133 Use TryFormatDouble TryFormatFloat (dotnet/corefx#40197)

* Corefx dotnet/corefx#40133 Use TryFormatDouble TryFormatFloat

* add test cases

* Changes as per review comments

* remove extra empty line

Commit migrated from https://github.com/dotnet/corefx/commit/3d72b56b8e7d1e4e44262be6c45c2aac580bbbc4

5 years agoChange 'type' to 'inputType' on serialize methods (dotnet/corefx#40372)
Steve Harter [Mon, 19 Aug 2019 04:01:32 +0000 (23:01 -0500)]
Change 'type' to 'inputType' on serialize methods (dotnet/corefx#40372)

Commit migrated from https://github.com/dotnet/corefx/commit/9217d338671fe78d2bd31138a610bb9ad5a12608

5 years agoUse Count in Enumerable.Any if available (dotnet/corefx#40377)
Stephen Toub [Sat, 17 Aug 2019 23:49:42 +0000 (19:49 -0400)]
Use Count in Enumerable.Any if available (dotnet/corefx#40377)

* Use Count in Enumerable.Any if available

We've been hesitant to make this change in the past, as it adds several interface checks.  However, wide-spread "wisdom" is that `Any()` is as fast or faster than `Count() > 0`, and there are even FxCop rules/analyzers that warn about using the latter instead of the former, but in its current form that can frequently be incorrect: if the source does implement `ICollection<T>`, generally its `Count` is O(1) and allocation-free, whereas `Any()` will almost always end up allocating an enumerator.  On balance, it seems better to just have `Any()` map closely to `Count()` so that their performance can be reasoned about in parallel.

* Add test coverage for Enumerable.Any

Commit migrated from https://github.com/dotnet/corefx/commit/9021bc1cbc8c1189d2eb8de906e8891878430e6f

5 years agoDisable AssociatePersistedKey_CAPIviaCNG_RSA on arm64 (dotnet/corefx#40375)
Viktor Hofer [Sat, 17 Aug 2019 01:41:57 +0000 (03:41 +0200)]
Disable AssociatePersistedKey_CAPIviaCNG_RSA on arm64 (dotnet/corefx#40375)

Commit migrated from https://github.com/dotnet/corefx/commit/9ea74a6d3ec09fef63975338105abdca6fac8e1c

5 years agoRemove unnecessary field in PrinterSettings (dotnet/corefx#40339)
Stephen Toub [Fri, 16 Aug 2019 16:46:16 +0000 (12:46 -0400)]
Remove unnecessary field in PrinterSettings (dotnet/corefx#40339)

I'm not sure why it has its own ArrayEnumerator, but as long as it does, it doesn't need _startIndex.

Commit migrated from https://github.com/dotnet/corefx/commit/bfe2c58a4536db9a257940277c5d94bf9e26929a

5 years agoDisabling test failing in Mac OSX 10.15 (dotnet/corefx#40332)
buyaa-n [Fri, 16 Aug 2019 15:50:56 +0000 (08:50 -0700)]
Disabling test failing in Mac OSX 10.15 (dotnet/corefx#40332)

* Disabling test failing in Mac OSX 10.15

* Using active issue annotation

* Checking OS version instead of disabling test for any Mac

* Formatting update

Commit migrated from https://github.com/dotnet/corefx/commit/df3837cbced3fdcaab22464c18f0ce20b4aadfc7

5 years agoFix outerloop cron job (dotnet/corefx#40317)
Viktor Hofer [Fri, 16 Aug 2019 15:48:40 +0000 (17:48 +0200)]
Fix outerloop cron job (dotnet/corefx#40317)

Commit migrated from https://github.com/dotnet/corefx/commit/001f42b944e3a05a42f9f8cd7d14d338a06e6328

5 years agoRemove unnecessary null check from ConstraintCollection (dotnet/corefx#40343)
Stephen Toub [Fri, 16 Aug 2019 15:25:21 +0000 (11:25 -0400)]
Remove unnecessary null check from ConstraintCollection (dotnet/corefx#40343)

`_table` will never be null.  The `ConstraintCollection` is only constructed in one place, where it's passed `this` by `DataTable`.  It's used in many other places without a guard check, as well (and later in this method, unguarded).

Commit migrated from https://github.com/dotnet/corefx/commit/f4344b0d3b45fc7c8f41e5c909ddcb2752bea0fa

5 years agoFix IDE0066 across corefx (dotnet/corefx#40288)
Stephen Toub [Fri, 16 Aug 2019 15:24:54 +0000 (11:24 -0400)]
Fix IDE0066 across corefx (dotnet/corefx#40288)

* Fix IDE0066 across corefx

"Fix all", but then manual tweaking to accommodate places the rule doesn't work quite right.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/f71a5a1d88214a9e2c26ff2ff8bcfb1017aa6713

5 years agoImprove code coverage for VB Conversion module (dotnet/corefx#39937)
Edison Henrique Andreassy [Fri, 16 Aug 2019 05:09:40 +0000 (02:09 -0300)]
Improve code coverage for VB Conversion module (dotnet/corefx#39937)

Commit migrated from https://github.com/dotnet/corefx/commit/4d2b68c2cda66c861aa918fd91e9bf7d664ea05f

5 years agoFix BytesConsumed when reading JSON numbers within a multi-segment ReadOnlySequence...
Ahson Khan [Fri, 16 Aug 2019 04:12:23 +0000 (21:12 -0700)]
Fix BytesConsumed when reading JSON numbers within a multi-segment ReadOnlySequence via Utf8JsonReader (dotnet/corefx#40303)

* Add tests for reading numbers when data is within a multi-segment
ReadOnlySequence.

* Test rename and add debug.assert.

* Test clean up - remove unnecessary/expensive Debug.Assert.

* Test and code cleanup.

* Address feedback - add stronger test condition for token length.

Commit migrated from https://github.com/dotnet/corefx/commit/1b0f28942ccafca8a56f960536e125301e7b9306

5 years agoMinor cleanup tweaks in Regex (dotnet/corefx#40338)
Stephen Toub [Fri, 16 Aug 2019 00:35:39 +0000 (20:35 -0400)]
Minor cleanup tweaks in Regex (dotnet/corefx#40338)

* Remove unused local in RegexRunner.TextposDescription

* Remove redundant checks in RegexCharClass.AddRange

Commit migrated from https://github.com/dotnet/corefx/commit/04bd3fa5c2c7d379c22b805ad840bc28423d5242

5 years agoRemove duplicate _wrapped.WriteBase64 call in QueryOutputWriterV1 (dotnet/corefx...
Stephen Toub [Thu, 15 Aug 2019 23:02:51 +0000 (19:02 -0400)]
Remove duplicate _wrapped.WriteBase64 call in QueryOutputWriterV1 (dotnet/corefx#40345)

The same expression is used for both the if and the else branches.  But the if branch does make a mutating method call, which we keep.

Commit migrated from https://github.com/dotnet/corefx/commit/6aaba8d6f07c8f2e4db0a918dbdbad6d95b26eae

5 years agoadding ci to release 3.0 branch (dotnet/corefx#40359)
Anirudh Agnihotry [Thu, 15 Aug 2019 20:41:36 +0000 (13:41 -0700)]
adding ci to release 3.0 branch (dotnet/corefx#40359)

Commit migrated from https://github.com/dotnet/corefx/commit/c5cb132f5ad2b938e67866cf510d3f3bc58e32c3

5 years agoAvoid creating/populating unneeded certificate collection in SecureChannel.AcquireCli...
Stephen Toub [Thu, 15 Aug 2019 18:31:49 +0000 (14:31 -0400)]
Avoid creating/populating unneeded certificate collection in SecureChannel.AcquireClientCredentials (dotnet/corefx#40354)

Commit migrated from https://github.com/dotnet/corefx/commit/f34e088ff8400ff39ceff5a68b3b1a90dbe8d0ab

5 years agoTests for JsonSerializerOptions.GetConverter() and converter methods (dotnet/corefx...
buyaa-n [Thu, 15 Aug 2019 18:31:04 +0000 (11:31 -0700)]
Tests for JsonSerializerOptions.GetConverter() and converter methods (dotnet/corefx#39750)

* Tests for JsonSerializerOptions.GetConverter

Commit migrated from https://github.com/dotnet/corefx/commit/e11af6abaaec093cd77cb55738b99b466f70148e

5 years agoSupport custom converters that treat non-null input as null (dotnet/corefx#40287)
Steve Harter [Thu, 15 Aug 2019 16:03:56 +0000 (11:03 -0500)]
Support custom converters that treat non-null input as null (dotnet/corefx#40287)

Commit migrated from https://github.com/dotnet/corefx/commit/ba54c4034a0e87ac6bdf3d13b55b767f5c321df2

5 years agoPrevent threading issues with warm-up of property caching (dotnet/corefx#40261)
Steve Harter [Thu, 15 Aug 2019 16:01:33 +0000 (11:01 -0500)]
Prevent threading issues with warm-up of property caching (dotnet/corefx#40261)

Commit migrated from https://github.com/dotnet/corefx/commit/b35cfc014b17cca8ee20c24ee250c6925d73855f

5 years agoRenaming Microsoft.Framework.WebEncoders namespace (dotnet/corefx#40238)
Igor Šušić [Thu, 15 Aug 2019 15:50:16 +0000 (17:50 +0200)]
Renaming Microsoft.Framework.WebEncoders namespace (dotnet/corefx#40238)

* Renaming the namespace Microsoft.Framework.WebEncoders to System.Text.Encodings.Web.Tests

- Namespace Microsoft.Framework.WebEncoders renamed to System.Text.Encodings.Web.Tests

* Changed aliases naming from camelCase to PascalCase

* Deleted unnecessary using directives and reverted EncoderExtensionsTests

Deleted unnecessary using directives. Reverted changes made in EncoderCommonTests.cs to commit dotnet/corefx@db1dd29edac07716ac27b8916d5e12f9a85b4978 and changed using directive for test namespace to right one.

Commit migrated from https://github.com/dotnet/corefx/commit/1a8fab5315d2de425d530c6fb7d801ade653bc41

5 years agofixing ZipPackagePart.GetStreamCore crashes with NotSupportedException (dotnet/corefx...
Steven Kirbach [Thu, 15 Aug 2019 15:25:45 +0000 (08:25 -0700)]
fixing ZipPackagePart.GetStreamCore crashes with NotSupportedException (dotnet/corefx#40319)

* fixing ZipPackagePart.GetStreamCore crashes with NotSupportedException

ZipArchiveEntry only ever supports opening once when the backing archive is in Create mode,  and the backing stream is non-seekable, so we shouldn't call SetLength in that case. You could still open an archive in Update mode then call part.GetStream(FileMode.Create), in which case we'll want this call to SetLength, so we only avoid this call when the backing Archive is in Create mode.

* updating test to explicitly test the Update path for ZipPackage

* skip UAP since we don't have access to the file system to create the .zip

* undo accidental change to existing test

* removing unnecessary variable

Commit migrated from https://github.com/dotnet/corefx/commit/8ac53e0c022b7881f659e0838a25e91f2ec5c8c0

5 years agoUse sealed securityContext in SecureChannel (dotnet/corefx#40265)
Ben Adams [Thu, 15 Aug 2019 14:54:57 +0000 (15:54 +0100)]
Use sealed securityContext in SecureChannel (dotnet/corefx#40265)

* Use sealed securityContext in SecureChannel

* Less asm

* Feedback

* Remove ternary

Commit migrated from https://github.com/dotnet/corefx/commit/6e53bf857a5cbfa1a6b26be3173e00b7e032e819

5 years agoRemove duplicate code in WMIGenerator.ConvertToNumericValueAndAddToArray (dotnet...
Stephen Toub [Thu, 15 Aug 2019 14:36:01 +0000 (10:36 -0400)]
Remove duplicate code in WMIGenerator.ConvertToNumericValueAndAddToArray (dotnet/corefx#40346)

Commit migrated from https://github.com/dotnet/corefx/commit/203b1fda97a7421b24a0a41ef9459e0fc31efe3d

5 years agoApply feedback to pal_x509chain.c fix from release/3.0
buyaa-n [Thu, 15 Aug 2019 13:24:02 +0000 (06:24 -0700)]
Apply feedback to pal_x509chain.c fix from release/3.0

Commit migrated from https://github.com/dotnet/corefx/commit/cc1f32affb828e1a34a4c91d8e7ba1474fe196b3

5 years agoFix a few missing $s for string interpolation in tracing (dotnet/corefx#40322)
Stephen Toub [Thu, 15 Aug 2019 12:50:12 +0000 (08:50 -0400)]
Fix a few missing $s for string interpolation in tracing (dotnet/corefx#40322)

Commit migrated from https://github.com/dotnet/corefx/commit/d116b2d4ee4041970943d6fffdf8a97446f8b6ff

5 years agoFix non-ASCII characters across corefx (dotnet/corefx#40318)
Stephen Toub [Thu, 15 Aug 2019 12:17:46 +0000 (08:17 -0400)]
Fix non-ASCII characters across corefx (dotnet/corefx#40318)

* Fix several non-visible characters in test files

* Replace Unicode surrogate pairs with escaped hex values

* Fix non-ASCII characters in most C# files

Commit migrated from https://github.com/dotnet/corefx/commit/027eb8e19c3498cc2c656931c3b879f5ddb63b0d

5 years agoDelete dead code from XMLDiffLoader.ReadOldRowData (dotnet/corefx#40344)
Stephen Toub [Thu, 15 Aug 2019 10:59:51 +0000 (06:59 -0400)]
Delete dead code from XMLDiffLoader.ReadOldRowData (dotnet/corefx#40344)

We already exited out of the method earlier if table == null.

Commit migrated from https://github.com/dotnet/corefx/commit/323b0c158e3d6ece5a8cb1c87c443848cbde9afd

5 years agoFix PKCS1MaskGenerationMethod.GenerateMask handling of invalid hash name (dotnet...
Stephen Toub [Thu, 15 Aug 2019 10:53:40 +0000 (06:53 -0400)]
Fix PKCS1MaskGenerationMethod.GenerateMask handling of invalid hash name (dotnet/corefx#40323)

* Fix PKCS1MaskGenerationMethod.GenerateMask handling of invalid hash name

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/73b8056a88278b31752fdfbafbfe7479a0540767

5 years agoRemove unnecessary null check from QueryDynamicObject (dotnet/corefx#40320)
Stephen Toub [Thu, 15 Aug 2019 10:49:47 +0000 (06:49 -0400)]
Remove unnecessary null check from QueryDynamicObject (dotnet/corefx#40320)

Commit migrated from https://github.com/dotnet/corefx/commit/9982320d1d1185e30507152687ecd755ea95bb2b

5 years agoRemove dead else branch from SchemaGraph.Depends (dotnet/corefx#40325)
Stephen Toub [Thu, 15 Aug 2019 10:37:49 +0000 (06:37 -0400)]
Remove dead else branch from SchemaGraph.Depends (dotnet/corefx#40325)

Commit migrated from https://github.com/dotnet/corefx/commit/618de6e29d0c5b8b4cab65bdb98e6893240ab77d

5 years agoRemove duplicate casts from DbMetaDataFactory (dotnet/corefx#40328)
Stephen Toub [Thu, 15 Aug 2019 03:59:34 +0000 (23:59 -0400)]
Remove duplicate casts from DbMetaDataFactory (dotnet/corefx#40328)

Commit migrated from https://github.com/dotnet/corefx/commit/66273ed9944c7c964d3d51771ed8d4b4ddce3e8c

5 years agoRemove redundant code in DirectorySearcher (dotnet/corefx#40321)
Stephen Toub [Thu, 15 Aug 2019 03:52:38 +0000 (23:52 -0400)]
Remove redundant code in DirectorySearcher (dotnet/corefx#40321)

Commit migrated from https://github.com/dotnet/corefx/commit/f7ecc218455c41bb4c5c13b9d277a22a79146756

5 years agoRemove duplicate branch in ColorTranslator.ToHtml (dotnet/corefx#40337)
Stephen Toub [Thu, 15 Aug 2019 03:52:13 +0000 (23:52 -0400)]
Remove duplicate branch in ColorTranslator.ToHtml (dotnet/corefx#40337)

Commit migrated from https://github.com/dotnet/corefx/commit/87d6aa5daf9b5b7a01174c3849c731ecfbee3f29

5 years agoAvoid tracing-induced null ref in HttpListener when {Begin}Read/Write called with...
Stephen Toub [Thu, 15 Aug 2019 03:51:22 +0000 (23:51 -0400)]
Avoid tracing-induced null ref in HttpListener when {Begin}Read/Write called with invalid buffer (dotnet/corefx#40335)

HttpRequest/ResponseStream's {Begin}Read/Write methods trace the length of the caller-supplied buffer.  If the caller erroneously passes null, with tracing enabled it'll end up throwing a NullReferenceException instead of an ArgumentNullException.  This should never happen in real-world code, but might as well clean it up.

Commit migrated from https://github.com/dotnet/corefx/commit/04f9d7b23fd9e9c4d8499436f1a71742b5f640ee

5 years agoFix null ref in ImmutableArray's structural comparer (dotnet/corefx#40341)
Stephen Toub [Thu, 15 Aug 2019 03:51:01 +0000 (23:51 -0400)]
Fix null ref in ImmutableArray's structural comparer (dotnet/corefx#40341)

Commit migrated from https://github.com/dotnet/corefx/commit/a87fcffbd1606e4f29c8f0473cde2ae3f2209347

5 years agoDelete redundant Debug.Assert in XPathNodePointer.ComparePosition
Stephen Toub [Thu, 15 Aug 2019 03:27:08 +0000 (23:27 -0400)]
Delete redundant Debug.Assert in XPathNodePointer.ComparePosition

Commit migrated from https://github.com/dotnet/corefx/commit/ed56010a736dfc242edb07bf3c501696aad840fc

5 years agoRemove unnecessary null check from JsonClassInfo.CreatePolymorphicProperty (dotnet...
Stephen Toub [Thu, 15 Aug 2019 03:03:43 +0000 (23:03 -0400)]
Remove unnecessary null check from JsonClassInfo.CreatePolymorphicProperty (dotnet/corefx#40334)

`property` will never be null in calls to this method, and even if it were, prior dereferences of it would result in exceptions.

Commit migrated from https://github.com/dotnet/corefx/commit/324e6432b99c3c8a655d7db2de57811b12967450

5 years agoRemove stale ctor and field from ObjectManager (dotnet/corefx#40326)
Stephen Toub [Thu, 15 Aug 2019 02:07:18 +0000 (22:07 -0400)]
Remove stale ctor and field from ObjectManager (dotnet/corefx#40326)

Commit migrated from https://github.com/dotnet/corefx/commit/bfe528311e52fd41afca1c981dc28c2e62d96721

5 years agoRemove dead branches from ObjectManager (dotnet/corefx#40327)
Stephen Toub [Thu, 15 Aug 2019 02:06:25 +0000 (22:06 -0400)]
Remove dead branches from ObjectManager (dotnet/corefx#40327)

int.MaxValue is odd.  x * 2 will never be odd.

Commit migrated from https://github.com/dotnet/corefx/commit/c121f180b985f3bb2ca28096369eda7b7255af7b

5 years agoFix potential null ref in RuntimeInformation.FrameworkDescription (dotnet/corefx...
Stephen Toub [Thu, 15 Aug 2019 02:05:18 +0000 (22:05 -0400)]
Fix potential null ref in RuntimeInformation.FrameworkDescription (dotnet/corefx#40329)

If there's no FX_PRODUCT_VERSION and then if there's no AssemblyInformationalVersionAttribute on the assembly or its InformationVersion is null, we'll try to dereference a null string.

Commit migrated from https://github.com/dotnet/corefx/commit/c08abbe3527fca16b55df53a596164fac97031d4

5 years agoAdd comment to explain base.Pop call in CorrelationManager
Stephen Toub [Thu, 15 Aug 2019 01:51:47 +0000 (21:51 -0400)]
Add comment to explain base.Pop call in CorrelationManager

Commit migrated from https://github.com/dotnet/corefx/commit/36f1a74b4ecf04f2453c0e23265bb21500bbd45d

5 years agoJsonObject implementation and tests (dotnet/corefx#40206)
Katarzyna Bułat [Wed, 14 Aug 2019 22:19:05 +0000 (15:19 -0700)]
JsonObject implementation and tests (dotnet/corefx#40206)

* JsonObject implementation added
* JsonObject tests added
* JsonObject documentation added
* Review comments included

Commit migrated from https://github.com/dotnet/corefx/commit/ceaad9274f83273a4c95ec08b359253ad28bea1e

5 years agoAdd IPEndPoint tests and fix some bugs (dotnet/corefx#39726)
Hugh Bellamy [Wed, 14 Aug 2019 20:43:19 +0000 (20:43 +0000)]
Add IPEndPoint tests and fix some bugs (dotnet/corefx#39726)

* Cleanup IPEndPoint

* Add missing validation to IPEndPoint

Commit migrated from https://github.com/dotnet/corefx/commit/7224d186f90e28f0c04eefb875260c03d6acec07

5 years agoFix JSON Writer docs for data writter as Base64-encoded text (dotnet/corefx#40200)
Santiago Fernandez Madero [Wed, 14 Aug 2019 20:27:09 +0000 (13:27 -0700)]
Fix JSON Writer docs for data writter as Base64-encoded text (dotnet/corefx#40200)

* Fix JSON Writer docs for data writter as Base64-encoded text

* PR Feedback

* More Feedback

* One more try

Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
* Use Base64 instead

* As a to as for text

Commit migrated from https://github.com/dotnet/corefx/commit/39d8cf14b1eaf2d7678d1399bc903a0e547cce26

5 years agoAdd NotNullIfNotNull attribute to Interlocked.CompareExchange (dotnet/corefx#40258)
Santiago Fernandez Madero [Wed, 14 Aug 2019 19:35:04 +0000 (12:35 -0700)]
Add NotNullIfNotNull attribute to Interlocked.CompareExchange (dotnet/corefx#40258)

Commit migrated from https://github.com/dotnet/corefx/commit/b990ece3f8cd7999ad62483f1bd814ec586895de

5 years agoMake many fields readonly or const across corefx (dotnet/corefx#40298)
Stephen Toub [Wed, 14 Aug 2019 18:19:30 +0000 (14:19 -0400)]
Make many fields readonly or const across corefx (dotnet/corefx#40298)

* Make many fields readonly or const

* Address PR feedback

- Updated asn.xslt
- Regenerated .xml.cs files

Commit migrated from https://github.com/dotnet/corefx/commit/0cc22ccba707d7552159363d586262fa9c4e8a2a

5 years agoConsolidate the Image class, fix bug (dotnet/corefx#40181)
Frederik Carlier [Wed, 14 Aug 2019 18:11:21 +0000 (20:11 +0200)]
Consolidate the Image class, fix bug (dotnet/corefx#40181)

* Add new values for Encoder, EncoderParameterValueType

* Support encoder parameters of type ValueTypePointer

* Fix an overflow error when reading EncoderParameters

* Add unit tests

* Consolidate the Image class

Share the following methods across Windows & Unix:
- FromFile
- GetEncoderParameterList
- GetPixelFormatSize
- IsAlphaPixelFormat

* Fix P/Invoke declaration

* Fix compliation on NetFX

* Skip test on NetFX

* Fix typo

* Always skip GetEncoderParameterList_ReturnsExpected on netFX

* Remove new API

* Revert changes which require an API change

* Suppress failing test

* Image: Consolidate CreateImageObject
Metafile: Consolidate initialization from native handle

* Throw SkipTestException instead of silently skipping the test

* Enable some on Unix which rely on consolidated code

* Add missing using statement

* Get SkipTestException right

Commit migrated from https://github.com/dotnet/corefx/commit/31a04af352c0046b21b2ccdf5b409203a43fae1f

5 years agoFixed Dispose in JsonDocument and JsonDocument.MetadataDb in order to guard against...
David Cantu [Wed, 14 Aug 2019 18:02:35 +0000 (11:02 -0700)]
Fixed Dispose in JsonDocument and JsonDocument.MetadataDb in order to guard against multiple calls to ArrayPool.Return (dotnet/corefx#40290)

* Fixed Dispose in JsonDocument and JsonDocument.MetadataDb in order to guard against multiple calls to ArrayPool.Return.

* Added condition to validate _utf8Json.Length is > 0 in order to prevent that extraRentedBytes.AsSpan(0, length).Clear() takes a zero length range in a race condition.

* Added test related to this scenario.

* Addressing suggestions.

* Removing unnecesary null assingment.

* Adding comment explaining the reason for minimumLength = 4 on ArrayPool.Rent.

* Adding using System.Threading.

Commit migrated from https://github.com/dotnet/corefx/commit/f47bb86d84c5e08e1a8520c5f2b23a0bd7652e2a

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#40309)
dotnet-maestro[bot] [Wed, 14 Aug 2019 15:07:58 +0000 (15:07 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#40309)

* Update dependencies from https://github.com/dotnet/coreclr build 20190813.7

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19413.7
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19413.7
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19413.7

* Fix attribute target in ref

Commit migrated from https://github.com/dotnet/corefx/commit/4c4dc052c675394db5ca78f0503b350976599202

5 years agoRemove Microsoft.VisualBasic.{ApplicationServices,Devices,MyServices} (dotnet/corefx...
Charles Stoner [Wed, 14 Aug 2019 14:14:57 +0000 (07:14 -0700)]
Remove Microsoft.VisualBasic.{ApplicationServices,Devices,MyServices} (dotnet/corefx#39972) (dotnet/corefx#40292)

Commit migrated from https://github.com/dotnet/corefx/commit/02c729c4b6b3c705b9e19d1c819b17128a85c01a

5 years agoEnable Sdl Validation (dotnet/corefx#40294)
Santiago Fernandez Madero [Wed, 14 Aug 2019 10:39:07 +0000 (03:39 -0700)]
Enable Sdl Validation (dotnet/corefx#40294)

Commit migrated from https://github.com/dotnet/corefx/commit/df6c87128e0407b21103fe00680f498787631d5a

5 years agoFix problematic characters in XmlJsonReader.cs (dotnet/corefx#40291)
Stephen Toub [Tue, 13 Aug 2019 21:16:45 +0000 (17:16 -0400)]
Fix problematic characters in XmlJsonReader.cs (dotnet/corefx#40291)

A few stray invisible characters found their way into this .cs file and appear to be causing Visual Studio to be very unhappy.

Commit migrated from https://github.com/dotnet/corefx/commit/f0ec4a345fc31bc9d075fec86fa6fb3ec88d43a2

5 years agoAdd TLS 1.3 to all protocols in GetAsync_AllowedSSLVersion_Succeeds (dotnet/corefx...
Krzysztof Wicher [Tue, 13 Aug 2019 17:48:28 +0000 (10:48 -0700)]
Add TLS 1.3 to all protocols in GetAsync_AllowedSSLVersion_Succeeds (dotnet/corefx#40281)

Commit migrated from https://github.com/dotnet/corefx/commit/302b3283f5439907ca2586784ba32381ac312f72

5 years agoUse Strings.resx file within System.Text.Encodings.Web (dotnet/corefx#40239)
Roman Marusyk [Tue, 13 Aug 2019 16:34:04 +0000 (19:34 +0300)]
Use Strings.resx file within System.Text.Encodings.Web (dotnet/corefx#40239)

* Use Strings.resx file for the exception messages within System.Text.Encodings.Web

* Add reference to System.Resources.ResourceManager

* Change exception message

Commit migrated from https://github.com/dotnet/corefx/commit/6f8983d64c67fa86ac6f0338cde08d82e51cc805

5 years agoMake serialization null tests independent of reflection ordering (dotnet/corefx#40257)
Layomi Akinrinade [Tue, 13 Aug 2019 16:07:16 +0000 (12:07 -0400)]
Make serialization null tests independent of reflection ordering (dotnet/corefx#40257)

Commit migrated from https://github.com/dotnet/corefx/commit/ab78eb491689e1b6694e4543b74d2fa8a158fd08

5 years agoPerformance improvements in the CryptoConfig class
Vladimir Khvostov [Tue, 13 Aug 2019 15:34:11 +0000 (11:34 -0400)]
Performance improvements in the CryptoConfig class

CreateFromName is about 10x faster with this change.

* Use ConcurrentDictionary instead of big locks.
* Cache results of DefaultNameHT lookups resulting in string-to-Type into AppNameHT.
* Specify initial capacity when creating DefaultOidHT and DefaultNameHT dictionaries.

Commit migrated from https://github.com/dotnet/corefx/commit/963e0d64bd7a69ba4b8d4d933bd56d0f2a5a8913

5 years agoFix 2 System.Net.Http tests failing on debian (dotnet/corefx#40259)
Krzysztof Wicher [Tue, 13 Aug 2019 06:01:21 +0000 (23:01 -0700)]
Fix 2 System.Net.Http tests failing on debian (dotnet/corefx#40259)

Commit migrated from https://github.com/dotnet/corefx/commit/af36939acdf751d2465358be3f892170f73f9b48

5 years agoAvoid disposing Http2Stream's request body cancellation source (dotnet/corefx#40255)
Stephen Toub [Tue, 13 Aug 2019 01:24:30 +0000 (21:24 -0400)]
Avoid disposing Http2Stream's request body cancellation source (dotnet/corefx#40255)

Commit migrated from https://github.com/dotnet/corefx/commit/a4f5f13ec1fa0d51ce0964c126e35ef0046ea7be

5 years agoSqlClient: Fix BulkCopy double and single null widening handling (dotnet/corefx#37603)
Wraith2 [Mon, 12 Aug 2019 23:15:56 +0000 (00:15 +0100)]
SqlClient: Fix BulkCopy double and single null widening handling (dotnet/corefx#37603)

* change BulkCopy double and single handling to handle Null values when converting to decimal without throwing and add tests

* address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/97ddad9e75b241e752242c4e33c3e68f7fe0d5f3

5 years agoEnable StyleCop rules 1205, 1411, 1026, and 1000 (dotnet/corefx#40254)
Stephen Toub [Mon, 12 Aug 2019 20:45:34 +0000 (16:45 -0400)]
Enable StyleCop rules 1205, 1411, 1026, and 1000 (dotnet/corefx#40254)

* Fix StyleCop warning SA1411 (attribute ctor shouldn't use unnecessary parens)

* Fix StyleCop warning SA1026 (new[] spacing)

* Fix StyleCop warning SA1000 (consistent spacing around if, for, switch, etc.)

* Fix StyleCop warning SA1205 (partial elements should declare an access modifier)

Commit migrated from https://github.com/dotnet/corefx/commit/0c4c234a918254d569ffb0f6a607f98193608646

5 years agoMake several local functions static (dotnet/corefx#40251)
Stephen Toub [Mon, 12 Aug 2019 19:08:18 +0000 (15:08 -0400)]
Make several local functions static (dotnet/corefx#40251)

Commit migrated from https://github.com/dotnet/corefx/commit/d3155017e1fe6acdb72e2d1b30c5b2e36cf21af8

5 years agoDisable two SocketsHttpHandler tests on Debian10 (dotnet/corefx#40247)
Viktor Hofer [Mon, 12 Aug 2019 14:18:13 +0000 (16:18 +0200)]
Disable two SocketsHttpHandler tests on Debian10 (dotnet/corefx#40247)

Commit migrated from https://github.com/dotnet/corefx/commit/eb58b0a0e0a45c42d67b69b44047cf60116650c3

5 years agoRe-enable scheduled outerloop runs (dotnet/corefx#40244)
Viktor Hofer [Mon, 12 Aug 2019 14:15:44 +0000 (16:15 +0200)]
Re-enable scheduled outerloop runs (dotnet/corefx#40244)

Commit migrated from https://github.com/dotnet/corefx/commit/103456e6b0d122a4b1952e7b6dc38642f6eed2db

5 years agoDisable FinancialTest.FV test on arm64 (dotnet/corefx#40246)
Viktor Hofer [Mon, 12 Aug 2019 14:13:22 +0000 (16:13 +0200)]
Disable FinancialTest.FV test on arm64 (dotnet/corefx#40246)

Commit migrated from https://github.com/dotnet/corefx/commit/e446e9e774fce79e50fc29c5f57a2861e47fd6a3

5 years agoRe-enable StyleCop warning SA1400 (elements should specify access) (dotnet/corefx...
Stephen Toub [Mon, 12 Aug 2019 12:29:20 +0000 (08:29 -0400)]
Re-enable StyleCop warning SA1400 (elements should specify access) (dotnet/corefx#40240)

One of the more common things we "nit" in PRs.  Now the compiler will flag it for us.

Commit migrated from https://github.com/dotnet/corefx/commit/61a6264018989e06d314b68d57bd91b4b72e4360

5 years agoDisable System.Drawing tests failing on arm64 (dotnet/corefx#40223)
Viktor Hofer [Sun, 11 Aug 2019 12:47:38 +0000 (14:47 +0200)]
Disable System.Drawing tests failing on arm64 (dotnet/corefx#40223)

Commit migrated from https://github.com/dotnet/corefx/commit/d3d48eb94c38d22725fc348b445a80136979be17

5 years agoUpgrade Windows Nano Server to 1809 (dotnet/corefx#39734)
Viktor Hofer [Sun, 11 Aug 2019 12:19:01 +0000 (14:19 +0200)]
Upgrade Windows Nano Server to 1809 (dotnet/corefx#39734)

* Upgrade Windows Nano Server to 1809

* Handle ERROR_CALL_NOT_IMPLEMENTED in PlatformDetection.IsInAppContainer

* Disable TextInfo test on Nano server

* Disable EnvironmentVariable tests on user scope

Commit migrated from https://github.com/dotnet/corefx/commit/61c5e96b70fd14621ec71aee356b1b520696a3c9

5 years agoDisable two EventLog failing tests on Windows (dotnet/corefx#40225)
Viktor Hofer [Sun, 11 Aug 2019 11:31:30 +0000 (13:31 +0200)]
Disable two EventLog failing tests on Windows (dotnet/corefx#40225)

Commit migrated from https://github.com/dotnet/corefx/commit/8f86714ab411924ba83dcf0928130a3437eeba88

5 years agofollowup on SocketAddress validation (dotnet/corefx#40165)
Tomas Weinfurt [Sat, 10 Aug 2019 19:44:54 +0000 (12:44 -0700)]
followup on SocketAddress validation (dotnet/corefx#40165)

* followup on SocketAddress validation
* update unknow faimily tests
* feedback from review
* fix spelling
* add comments about new values
* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/b129f7657a1b93ce9cf577d769d9d03c862e2338

5 years agoFix bugs in null serialization (dotnet/corefx#40077)
Layomi Akinrinade [Sat, 10 Aug 2019 13:35:20 +0000 (09:35 -0400)]
Fix bugs in null serialization (dotnet/corefx#40077)

* Support null serialization for objects and dictionaries as values in Dictionary and KeyValuePair

* Address reviw comments

* Fix nested enumerable null serialization and add dictionaries to null test suite

Commit migrated from https://github.com/dotnet/corefx/commit/4fbef813c6e3c1ce1a23e5dc1528e65abb1b8c0a

5 years agoDon't restore files to later overwrite them during the build
Eric StJohn [Fri, 9 Aug 2019 21:46:44 +0000 (14:46 -0700)]
Don't restore files to later overwrite them during the build

NETStandard2.1 includes more facades which we still build in corefx.

Make sure we don't copy these then later overwrite them during the ref build.

binplacePackages was restoring runtime files even on NETCoreApp:
we should never do this.  We have to be careful to only test assemblies
we build in the repo for netcoreapp.  The only test target which needs
these is NETFX.

Commit migrated from https://github.com/dotnet/corefx/commit/a987f4972095f2a7357f6176eac7ba757df9bfad

5 years agoJson string and boolean (dotnet/corefx#40107)
Katarzyna Bułat [Sat, 10 Aug 2019 00:45:10 +0000 (17:45 -0700)]
Json string and boolean (dotnet/corefx#40107)

* API to implement added
* JsonBoolean implementation added
* JsonString implementation added
* JsonBoolean tests added
* JsonString tests added
* review comments included
* 100% lines and branches covered
* framework fixes

Commit migrated from https://github.com/dotnet/corefx/commit/a7c0f966923d3379febe517be672c30c0aac63e4

5 years agoAdd spec for writable JSON DOM (dotnet/corefx#39954)
Katarzyna Bułat [Fri, 9 Aug 2019 21:56:33 +0000 (14:56 -0700)]
Add spec for writable JSON DOM (dotnet/corefx#39954)

* Specification (dotnet/corefx#4)

* specification consisting of following sections added:
  - introduction
  - goals
  - todos
  - example scenarios
  - design choices
  - implementation details
  - open questions
  - useful links
* review comments included

Commit migrated from https://github.com/dotnet/corefx/commit/7ec39540d1964e231670ad731532e42f39913359

5 years agoMove corefx to stages, use arcade's package artifacts convention (dotnet/corefx#40124)
Santiago Fernandez Madero [Fri, 9 Aug 2019 20:17:20 +0000 (13:17 -0700)]
Move corefx to stages, use arcade's package artifacts convention (dotnet/corefx#40124)

* Move corefx to stages, use package artifacts convention start transition to use arcade publish tasks

* Update arcade dependencies from build 20190808.13

Commit migrated from https://github.com/dotnet/corefx/commit/071270147cfee17c70343b57662d11fa702804db

5 years agoHttpStress: add a 'GET Slow' operation (dotnet/corefx#40157)
Eirik Tsarpalis [Fri, 9 Aug 2019 18:35:03 +0000 (19:35 +0100)]
HttpStress: add a 'GET Slow' operation (dotnet/corefx#40157)

* HttpStress: add a 'GET Slow' operation

Adds a 'GET Slow' operation. Additionally randomize
the response content in GET requests. These are
validated by having the client specify the expected
content length in request headers.

Commit migrated from https://github.com/dotnet/corefx/commit/ba8156d2f0d206655caf0713f6bed0265f48f098

5 years agoPrevent copying structs unnecessarily (dotnet/corefx#40114)
Steve Harter [Fri, 9 Aug 2019 15:48:47 +0000 (10:48 -0500)]
Prevent copying structs unnecessarily (dotnet/corefx#40114)

Commit migrated from https://github.com/dotnet/corefx/commit/46d3f57a9bba6c79ee494996d465e33fd8effa32

5 years agoimprove detection of usable KeyChain (dotnet/corefx#40163)
Tomas Weinfurt [Fri, 9 Aug 2019 14:17:43 +0000 (07:17 -0700)]
improve detection of usable KeyChain (dotnet/corefx#40163)

* improve detection of usable KeyChain

* add hint to user for errSecInteractionNotAllowed

Commit migrated from https://github.com/dotnet/corefx/commit/ac0f983d1a52121f63c0cf1a282f890be494e912

5 years agoRemove unused parameters for custom test errors (dotnet/corefx#40151)
Aaron Kunz [Fri, 9 Aug 2019 14:15:24 +0000 (16:15 +0200)]
Remove unused parameters for custom test errors (dotnet/corefx#40151)

Closes dotnet/corefx#38575

Commit migrated from https://github.com/dotnet/corefx/commit/22259d8049554ba96f69908cc671cf117af0a826

5 years agoSystem.Drawing.Common: Clean SuppressMessage attributes (dotnet/corefx#40174)
Frederik Carlier [Fri, 9 Aug 2019 13:56:43 +0000 (15:56 +0200)]
System.Drawing.Common: Clean SuppressMessage attributes (dotnet/corefx#40174)

Commit migrated from https://github.com/dotnet/corefx/commit/72eb507d9b035940cf9243ae39970abd92b2f9d7

5 years agoFix NRE in SmtpConnection.Abort (dotnet/corefx#40171)
Blake Hensley [Fri, 9 Aug 2019 13:34:03 +0000 (06:34 -0700)]
Fix NRE in SmtpConnection.Abort (dotnet/corefx#40171)

Commit migrated from https://github.com/dotnet/corefx/commit/e7c76f913ad2b8ae324f3a01b20eb949f3447dab

5 years agoDisable GetGCMemoryInfoTest on arm (dotnet/corefx#40176)
Viktor Hofer [Fri, 9 Aug 2019 13:28:14 +0000 (15:28 +0200)]
Disable GetGCMemoryInfoTest on arm (dotnet/corefx#40176)

Commit migrated from https://github.com/dotnet/corefx/commit/0468493ef0c2e7d50d84a69c2de4c03becc42573

5 years agoensure we don't try to send RST_STREAM or EndStream while holding the stream lock...
Geoff Kizer [Fri, 9 Aug 2019 12:09:37 +0000 (05:09 -0700)]
ensure we don't try to send RST_STREAM or EndStream while holding the stream lock (dotnet/corefx#40123)

Commit migrated from https://github.com/dotnet/corefx/commit/719b8fb635db44ba80ea6d5f2e7effaf5906f588

5 years agoLine ending fixes for json tests (dotnet/corefx#38949)
Krzysztof Wicher [Fri, 9 Aug 2019 07:59:35 +0000 (00:59 -0700)]
Line ending fixes for json tests (dotnet/corefx#38949)

* line ending fixes for json tests

* uncomment InlineData

Commit migrated from https://github.com/dotnet/corefx/commit/e122f306410b1045ab2f4cb7e533ece8556bee56

5 years agoRefactor and clean up the SpanTestHelper helpers for asserting that a ref struct...
Roman Marusyk [Fri, 9 Aug 2019 03:35:03 +0000 (06:35 +0300)]
Refactor and clean up the SpanTestHelper helpers for asserting that a ref struct method throws (dotnet/corefx#39186)

* Refactor and clean up the SpanTestHelper helpers for asserting that a ref struct method throws

* Fix build

* Fix StringTests

* Fix StringTests

* Code review fixes

* Code review fixes

* Fix

Commit migrated from https://github.com/dotnet/corefx/commit/31e0725aadb8c241652ed20ffa93205005e3a625

5 years agoImprove Utf8JsonWriter code coverage (dotnet/corefx#39699)
madmir [Fri, 9 Aug 2019 02:33:12 +0000 (04:33 +0200)]
Improve Utf8JsonWriter code coverage (dotnet/corefx#39699)

Commit migrated from https://github.com/dotnet/corefx/commit/91ffa88d29cac706db3bceac055080c1126c6ea9

5 years agoWritable Json DOM - JsonNumber implementation and tests (dotnet/corefx#39917)
Katarzyna Bułat [Fri, 9 Aug 2019 01:23:00 +0000 (18:23 -0700)]
Writable Json DOM - JsonNumber implementation and tests (dotnet/corefx#39917)

* Json prototype (dotnet/corefx#1)

Basic API for Json writable DOM with scenarios including collection initialization, accessing and modifying Json nodes.

* Json prototype - transformation API  (dotnet/corefx#2)

* transformation API added
* assertions to existing scenarios added

* Json prototype (dotnet/corefx#1)

Basic API for Json writable DOM with scenarios including collection initialization, accessing and modifying Json nodes.

* Json prototype - transformation API  (dotnet/corefx#2)

* transformation API added
* assertions to existing scenarios added

* JsonNumber implementation and tests (dotnet/corefx#3)

* IEquatables added
* JsonNumber implementation and unit tests added
* pragmas deleted
* review comments included, more tests added
* decimal support added to JsonNumber
* decimal support added to JsonArray and JsonObject

* all unimplemented classes and methods with accompanying tests removed

* First part of documentation added

* documentation completed

* missing exceptions added

* JsonElement changes removed

* part of the review comments included

* work on review comments

* code refactor

* more decimal tests added using MemberData

* more decimal tests added using MemberData

* more test cases added

* equals summary adjusted, equals tests added

* more Equals tests added, GetHashCode tests added, minor changes

* scientifing notation support added, rational numbers tests fixes

* rational overflow tests added

* ulong maxvalue tests added to rational types

* presision problems fixes

* exception strings fixed

* CI failing fixes (hopefully), review comments included

* missing == tests added to achieve 100% branch coverage

* review comments included

* trailing whitespaces fixes

* equals comments added

* equals object refactored to call quals json number

* merge fix

Commit migrated from https://github.com/dotnet/corefx/commit/5050ee83755eb07494d7d4ff6d759bc056ceb371

5 years agoMap NetSecurityNative.Status to SecurityStatusPalErrorCode (dotnet/corefx#40105)
Chris Ross [Fri, 9 Aug 2019 01:19:58 +0000 (18:19 -0700)]
Map NetSecurityNative.Status to SecurityStatusPalErrorCode (dotnet/corefx#40105)

Commit migrated from https://github.com/dotnet/corefx/commit/3825673ba94b2117701d13d9b5bde2233bd5d677

5 years agoFix: XPathDescendantIterator.MoveNext starts iterating again when MoveNext is called...
Krzysztof Wicher [Thu, 8 Aug 2019 23:32:31 +0000 (16:32 -0700)]
Fix: XPathDescendantIterator.MoveNext starts iterating again when MoveNext is called after it is done (dotnet/corefx#38562)

* Update XPathDescendantIterator.cs

* Update XPathDescendantIterator.cs

* Add test

* Address offline feedback from @tarekgh

Commit migrated from https://github.com/dotnet/corefx/commit/82e64c6cec3f0bb6a5a98b6c1bddc568f0ab61c8

5 years agoConsolidate Graphics across Windows & Unix (dotnet/corefx#39945)
Frederik Carlier [Thu, 8 Aug 2019 22:50:35 +0000 (00:50 +0200)]
Consolidate Graphics across Windows & Unix (dotnet/corefx#39945)

* Consolidate Graphics acrossWindows & Unix

* Consolidate CopyFromScreen overloads

* Consolidate EnumerateMetafile overloads

* Consolidate delegates

* Fixes after rebase

* Consolidate TransformPoints

* StyleCop fixes

Commit migrated from https://github.com/dotnet/corefx/commit/0b1b7b5e70f6766168e9a6a33edd92863e8865f3

5 years agoMove CodeAnalysis.ruleset to shared (dotnet/corefx#40153)
Stephen Toub [Thu, 8 Aug 2019 22:09:17 +0000 (18:09 -0400)]
Move CodeAnalysis.ruleset to shared (dotnet/corefx#40153)

So that the same settings can be applied to corelib.

Commit migrated from https://github.com/dotnet/corefx/commit/0b822c65aa586d9a62239ee5c862fede2543a443

5 years agopal_console: add missing mutex_unlock (dotnet/corefx#40160)
Tom Deseyn [Thu, 8 Aug 2019 21:08:37 +0000 (23:08 +0200)]
pal_console: add missing mutex_unlock (dotnet/corefx#40160)

Commit migrated from https://github.com/dotnet/corefx/commit/9d37f9912eb790375b3cf3d99492740a0c2ccd1f

5 years agoAdd polymorphic test\sample (dotnet/corefx#40154)
Steve Harter [Thu, 8 Aug 2019 19:10:44 +0000 (14:10 -0500)]
Add polymorphic test\sample (dotnet/corefx#40154)

Commit migrated from https://github.com/dotnet/corefx/commit/fbb8b5c4b9566ba81596aa35f42b71bbda601528

5 years agoImprove exception message for cycles during serialization (dotnet/corefx#40126)
Steve Harter [Thu, 8 Aug 2019 18:37:37 +0000 (13:37 -0500)]
Improve exception message for cycles during serialization (dotnet/corefx#40126)

Commit migrated from https://github.com/dotnet/corefx/commit/4f6dab89368fee902cedfe9d9d628dfa7d8c172a

5 years agoFixing test failure caused from non breaking space (dotnet/corefx#40033)
buyaa-n [Thu, 8 Aug 2019 12:37:38 +0000 (05:37 -0700)]
Fixing test failure caused from non breaking space (dotnet/corefx#40033)

* Fixing test failure caused from nbsp happening on new Mac Version

* Addressing feedback

* Using system a.m. instead of hard coded one

Commit migrated from https://github.com/dotnet/corefx/commit/79fe3d98a599c5124aa836b4da0178b2786a0cd2

5 years agoFix several test use of RunContinuationsAsynchronously (dotnet/corefx#40121)
Stephen Toub [Thu, 8 Aug 2019 01:08:35 +0000 (21:08 -0400)]
Fix several test use of RunContinuationsAsynchronously (dotnet/corefx#40121)

Commit migrated from https://github.com/dotnet/corefx/commit/d3911035f2ba3eb5c44310342cc1d654e42aa316