platform/upstream/libSkiaSharp.git
11 years agoReduce calls to SkMatrix::reset from GrDrawState
robertphillips@google.com [Thu, 25 Apr 2013 17:23:46 +0000 (17:23 +0000)]
Reduce calls to SkMatrix::reset from GrDrawState

https://codereview.chromium.org/14474011/

git-svn-id: http://skia.googlecode.com/svn/trunk@8861 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWork around overzealous assertion in SkMaskFilter.
tomhudson@google.com [Thu, 25 Apr 2013 16:56:40 +0000 (16:56 +0000)]
Work around overzealous assertion in SkMaskFilter.

When drawing nine-patch filters, we assert that the source contains the
destination. However, at least on the new analytic rect blur path, we can get
0-width destinations, and a 0-width rectangle is considered empty and therefore
*not contained in any other rectangle*, even if the bounds are valid and
numerically properly contained.

This patch makes sure we don't try to draw any of the four corners if they
are of 0 width or height. (The assert doesn't exist on the other codepaths.)

git-svn-id: http://skia.googlecode.com/svn/trunk@8860 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GPU support for roundrects
commit-bot@chromium.org [Thu, 25 Apr 2013 15:27:00 +0000 (15:27 +0000)]
Add GPU support for roundrects

This uses the OvalRenderer to render roundrects as "stretched ovals." It adds an
additional shader that handles the straight edges of ellipsoid roundrects better,
and uses the circle shader for roundrects where the two radii are the same. Only
axis-aligned, simple roundrects are supported. Handles fill, stroke and hairline.

R=bsalomon@google.com, robertphillips@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/13852049

git-svn-id: http://skia.googlecode.com/svn/trunk@8859 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodisable checking the style name from fontmgr (not impl on some backends,
reed@google.com [Thu, 25 Apr 2013 14:59:32 +0000 (14:59 +0000)]
disable checking the style name from fontmgr (not impl on some backends,
and likely will be remvoed in future api)

git-svn-id: http://skia.googlecode.com/svn/trunk@8858 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding missing SK_API identifier to class so that it's accessible in debug blink.
sugoi@google.com [Thu, 25 Apr 2013 14:54:15 +0000 (14:54 +0000)]
Adding missing SK_API identifier to class so that it's accessible in debug blink.

Review URL: https://codereview.chromium.org/14190016

git-svn-id: http://skia.googlecode.com/svn/trunk@8857 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix build : add src\pathops to pathops_unittest
caryclark@google.com [Thu, 25 Apr 2013 14:28:14 +0000 (14:28 +0000)]
fix build : add src\pathops to pathops_unittest

git-svn-id: http://skia.googlecode.com/svn/trunk@8856 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops : make it real
caryclark@google.com [Thu, 25 Apr 2013 13:34:40 +0000 (13:34 +0000)]
path ops : make it real

Add an option to SkCanvas to turn on path
ops when combining clips.

Allow Op() to use one of the input paths
as an output path.

Fix a bug in Op() when the minuend is empty
and the subtrahend is not (for difference).

Change the build to allow core to depend on pathops.
Review URL: https://codereview.chromium.org/14474002

git-svn-id: http://skia.googlecode.com/svn/trunk@8855 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded "SkRRect::contains(const SkRect&) const"
robertphillips@google.com [Thu, 25 Apr 2013 12:23:00 +0000 (12:23 +0000)]
Added "SkRRect::contains(const SkRect&) const"

https://codereview.chromium.org/14200044/

git-svn-id: http://skia.googlecode.com/svn/trunk@8854 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdjust some Nexus 7 performance triggers
robertphillips@google.com [Thu, 25 Apr 2013 12:21:18 +0000 (12:21 +0000)]
Adjust some Nexus 7 performance triggers

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@8853 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops : fix empty-diff bug, op-in-place
caryclark@google.com [Thu, 25 Apr 2013 11:51:54 +0000 (11:51 +0000)]
path ops : fix empty-diff bug, op-in-place

add some debugging around reverse diff, inverse
Review URL: https://codereview.chromium.org/13851015

git-svn-id: http://skia.googlecode.com/svn/trunk@8852 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 25 Apr 2013 07:01:04 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8851 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSome fixes for saturation computation XferEffect.
commit-bot@chromium.org [Thu, 25 Apr 2013 00:40:41 +0000 (00:40 +0000)]
Some fixes for saturation computation XferEffect.

R=jvanverth@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/14034018

git-svn-id: http://skia.googlecode.com/svn/trunk@8850 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for compiler error:
robertphillips@google.com [Wed, 24 Apr 2013 22:14:01 +0000 (22:14 +0000)]
Fix for compiler error:

src\core\skdata.cpp(126) : fatal error C1017: invalid integer constant expression

git-svn-id: http://skia.googlecode.com/svn/trunk@8849 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove MMap to SkData.
commit-bot@chromium.org [Wed, 24 Apr 2013 20:03:00 +0000 (20:03 +0000)]
Move MMap to SkData.

R=reed@google.com

Author: bungeman@google.com

Review URL: https://chromiumcodereview.appspot.com/14336003

git-svn-id: http://skia.googlecode.com/svn/trunk@8848 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix the build.
scroggo@google.com [Wed, 24 Apr 2013 19:37:52 +0000 (19:37 +0000)]
Fix the build.

Allow NULL for defaultValue in SkCommandLineFlags.

unreviewed.

Review URL: https://codereview.chromium.org/14472017

git-svn-id: http://skia.googlecode.com/svn/trunk@8847 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding new bench tests for lighting and blur
sugoi@google.com [Wed, 24 Apr 2013 19:36:44 +0000 (19:36 +0000)]
Adding new bench tests for lighting and blur

Review URL: https://codereview.chromium.org/14474004

git-svn-id: http://skia.googlecode.com/svn/trunk@8846 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTreat default command line argument properly.
scroggo@google.com [Wed, 24 Apr 2013 19:25:26 +0000 (19:25 +0000)]
Treat default command line argument properly.

In SkCommandLineFlags, if the client sets a default value
of multiple arguments (e.g. "arg0 arg1 ..."), set
the actual defaults to all of those arguments separately
(i.e. an array with [0] == "arg0", [1] == "arg1", ...),
rather than as one string (i.e. [0] == "arg0 arg1 ...").

Remove the hack that worked around this bug.

Also move the increasingly complicated implementation of
SkFlagInfo::CreateStringFlag into the cpp file.

BUG=https://code.google.com/p/skia/issues/detail?id=1237

Review URL: https://codereview.chromium.org/14366034

git-svn-id: http://skia.googlecode.com/svn/trunk@8845 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofirst impl of fontmgr for gdi
reed@google.com [Wed, 24 Apr 2013 19:14:56 +0000 (19:14 +0000)]
first impl of fontmgr for gdi

git-svn-id: http://skia.googlecode.com/svn/trunk@8844 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshow fontstyle values for each style
reed@google.com [Wed, 24 Apr 2013 19:14:39 +0000 (19:14 +0000)]
show fontstyle values for each style

git-svn-id: http://skia.googlecode.com/svn/trunk@8843 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd option to specify defaults configs to --config flag in gm. This makes it easier...
bsalomon@google.com [Wed, 24 Apr 2013 18:07:11 +0000 (18:07 +0000)]
Add option to specify defaults configs to --config flag in gm. This makes it easier to run gm defaults configs with a delta. Also make ~ exclude a config.

Review URL: https://codereview.chromium.org/13842014

git-svn-id: http://skia.googlecode.com/svn/trunk@8842 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExit ~GrContext early if GrContext::init() failed.
bsalomon@google.com [Wed, 24 Apr 2013 17:59:32 +0000 (17:59 +0000)]
Exit ~GrContext early if GrContext::init() failed.

Review URL: https://codereview.chromium.org/14049028

git-svn-id: http://skia.googlecode.com/svn/trunk@8841 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test Commit Queue (SkipBuildbotRuns)
commit-bot@chromium.org [Wed, 24 Apr 2013 17:52:36 +0000 (17:52 +0000)]
Whitespace change to test Commit Queue (SkipBuildbotRuns)

R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/14474009

git-svn-id: http://skia.googlecode.com/svn/trunk@8840 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing numerical rounding edge case in SkTileGrid
junov@chromium.org [Wed, 24 Apr 2013 15:39:11 +0000 (15:39 +0000)]
Fixing numerical rounding edge case in SkTileGrid

BUG=https://code.google.com/p/chromium/issues/detail?id=234688
TEST=TileGrid skia unit test

Review URL: https://codereview.chromium.org/13860011

git-svn-id: http://skia.googlecode.com/svn/trunk@8839 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a bug in SkTextBox.
scroggo@google.com [Wed, 24 Apr 2013 14:10:57 +0000 (14:10 +0000)]
Fix a bug in SkTextBox.

When checking to see if the line of text is beyond the bottom of
the textbox, compare with the bottom, rather than the height (bottom
- top). Prior to this change, text in the bottom of a textbox could
be clipped out.

BUG=https://code.google.com/p/skia/issues/detail?id=1250

Review URL: https://codereview.chromium.org/13856017

git-svn-id: http://skia.googlecode.com/svn/trunk@8838 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix compile warning on mac that breaks a bot, and remove jpeg creation bitmap since...
edisonn@google.com [Wed, 24 Apr 2013 13:21:49 +0000 (13:21 +0000)]
Fix compile warning on mac that breaks a bot, and remove jpeg creation bitmap since we mock the compression.

git-svn-id: http://skia.googlecode.com/svn/trunk@8836 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEncode images with DCTDecode (JPEG) in PDFs if it makes sense. Fallback to FlateDecod...
edisonn@google.com [Wed, 24 Apr 2013 13:01:01 +0000 (13:01 +0000)]
Encode images with DCTDecode (JPEG) in PDFs if it makes sense. Fallback to FlateDecode (zip) if it makes sense. Otherewise include uncompressed stream.
This change will reduce the size of PDFs to 50% (in the case of the existing SKPs, we reduce the total size of PDFs from 105MB to 50MB)
Review URL: https://codereview.appspot.com/7068055

git-svn-id: http://skia.googlecode.com/svn/trunk@8835 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 24 Apr 2013 07:01:07 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8833 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd stroked rrect benches.
jvanverth@google.com [Tue, 23 Apr 2013 19:14:03 +0000 (19:14 +0000)]
Add stroked rrect benches.

Review URL: https://codereview.chromium.org/14238017/

git-svn-id: http://skia.googlecode.com/svn/trunk@8832 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoARGB image encoder for checksums.
bungeman@google.com [Tue, 23 Apr 2013 18:06:23 +0000 (18:06 +0000)]
ARGB image encoder for checksums.
https://codereview.chromium.org/14267031/

git-svn-id: http://skia.googlecode.com/svn/trunk@8831 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoits ok if there is no family name in the pattern for fontconfig, for fc will interpret
reed@google.com [Tue, 23 Apr 2013 16:35:09 +0000 (16:35 +0000)]
its ok if there is no family name in the pattern for fontconfig, for fc will interpret
an empty string as looking for the default (which is our intent).

git-svn-id: http://skia.googlecode.com/svn/trunk@8830 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix an SkCommandLineFlags bug.
scroggo@google.com [Tue, 23 Apr 2013 15:38:09 +0000 (15:38 +0000)]
Fix an SkCommandLineFlags bug.

Previously I was storing an SkTDArray of const char*,
which fails if the strings go out of scope.

Instead, store an SkTArray of SkString, and copy the
strings, so we do not depend on the strings sticking
around. Using an SkTArray because it is smart enough
to call the destructors, so the copies can be destroyed
on program exit.

BUG=https://code.google.com/p/skia/issues/detail?id=1237

Review URL: https://codereview.chromium.org/14414008

git-svn-id: http://skia.googlecode.com/svn/trunk@8829 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove static effects from the effect memory pool.
bsalomon@google.com [Tue, 23 Apr 2013 15:37:27 +0000 (15:37 +0000)]
Remove static effects from the effect memory pool.
Review URL: https://codereview.chromium.org/14081016

git-svn-id: http://skia.googlecode.com/svn/trunk@8828 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd block comment for using SkChecksum
reed@google.com [Tue, 23 Apr 2013 15:35:24 +0000 (15:35 +0000)]
add block comment for using SkChecksum

git-svn-id: http://skia.googlecode.com/svn/trunk@8827 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix
sugoi@google.com [Tue, 23 Apr 2013 14:37:38 +0000 (14:37 +0000)]
Build fix

git-svn-id: http://skia.googlecode.com/svn/trunk@8826 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded a few bench for some image filters
sugoi@google.com [Tue, 23 Apr 2013 14:20:45 +0000 (14:20 +0000)]
Added a few bench for some image filters

Review URL: https://codereview.chromium.org/14234019

git-svn-id: http://skia.googlecode.com/svn/trunk@8824 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops : enable optimizations
caryclark@google.com [Tue, 23 Apr 2013 12:04:05 +0000 (12:04 +0000)]
path ops : enable optimizations

this addresses a few FIXME issues
- speed up implicit quad computation
- use ulps instead of epsilon
- assert on bad line results more often

git-svn-id: http://skia.googlecode.com/svn/trunk@8823 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops -- use standard max, min, double-is-nan
caryclark@google.com [Tue, 23 Apr 2013 11:56:44 +0000 (11:56 +0000)]
path ops -- use standard max, min, double-is-nan

fix a comment or two as well
Review URL: https://codereview.chromium.org/13934009

git-svn-id: http://skia.googlecode.com/svn/trunk@8822 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAlso proxy bumpTestCount.
commit-bot@chromium.org [Tue, 23 Apr 2013 11:16:32 +0000 (11:16 +0000)]
Also proxy bumpTestCount.

Example output with -v -x:

...
Finished 127 tests, 0 failures, 0 skipped.
Ran 73094673 Internal tests.

BUG=
R=caryclark@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/13983011

git-svn-id: http://skia.googlecode.com/svn/trunk@8821 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds after skia-autogen reset
rmistry@google.com [Tue, 23 Apr 2013 11:06:52 +0000 (11:06 +0000)]
Whitespace change to trigger rebuilds after skia-autogen reset

git-svn-id: http://skia.googlecode.com/svn/trunk@8820 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 23 Apr 2013 07:01:29 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8819 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd non-separable xfer modes to GPU backend.
bsalomon@google.com [Mon, 22 Apr 2013 21:05:48 +0000 (21:05 +0000)]
Add non-separable xfer modes to GPU backend.
Review URL: https://codereview.chromium.org/14371014

git-svn-id: http://skia.googlecode.com/svn/trunk@8815 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix gyp files to allow ninja to build 64 bit on Mac.
commit-bot@chromium.org [Mon, 22 Apr 2013 20:26:44 +0000 (20:26 +0000)]
Fix gyp files to allow ninja to build 64 bit on Mac.
Fix warnings that cropped up building as 64-bit.

BUG=
R=bsalomon@google.com, bungeman@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/13852013

git-svn-id: http://skia.googlecode.com/svn/trunk@8814 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix asserts in SkMulDiv255Round, and add test
reed@google.com [Mon, 22 Apr 2013 20:21:56 +0000 (20:21 +0000)]
fix asserts in SkMulDiv255Round, and add test
Review URL: https://codereview.chromium.org/13934010

git-svn-id: http://skia.googlecode.com/svn/trunk@8813 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops -- crap, I checked in the wrong file
caryclark@google.com [Mon, 22 Apr 2013 20:12:47 +0000 (20:12 +0000)]
path ops -- crap, I checked in the wrong file

this has the changes Brian suggested

git-svn-id: http://skia.googlecode.com/svn/trunk@8812 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove deleted file from gyp
caryclark@google.com [Mon, 22 Apr 2013 20:09:23 +0000 (20:09 +0000)]
remove deleted file from gyp

git-svn-id: http://skia.googlecode.com/svn/trunk@8811 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops -- use standard SkTQSort
commit-bot@chromium.org [Mon, 22 Apr 2013 19:55:19 +0000 (19:55 +0000)]
path ops -- use standard SkTQSort

thanks to bungeman for the contextual sort

R=bungeman@google.com

Author: caryclark@google.com

Review URL: https://chromiumcodereview.appspot.com/14034014

git-svn-id: http://skia.googlecode.com/svn/trunk@8810 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd missing unistd.h include after r8765.
commit-bot@chromium.org [Mon, 22 Apr 2013 19:34:42 +0000 (19:34 +0000)]
Add missing unistd.h include after r8765.

TEST=Build with GCC 4.8.0 and glibc 2.17.
R=reed@google.com, jvanverth@google.com, bsalomon@google.com

Author: raphael.kubo.da.costa@intel.com

Review URL: https://chromiumcodereview.appspot.com/14401007

git-svn-id: http://skia.googlecode.com/svn/trunk@8809 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocheck-point for linux fontmgr impl
reed@google.com [Mon, 22 Apr 2013 18:48:45 +0000 (18:48 +0000)]
check-point for linux fontmgr impl

Review URL: https://codereview.chromium.org/14305007

git-svn-id: http://skia.googlecode.com/svn/trunk@8808 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix refcnts for singleton fontconfig-direct
reed@google.com [Mon, 22 Apr 2013 18:45:12 +0000 (18:45 +0000)]
fix refcnts for singleton fontconfig-direct

git-svn-id: http://skia.googlecode.com/svn/trunk@8807 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd new roundrect GM
commit-bot@chromium.org [Mon, 22 Apr 2013 18:05:19 +0000 (18:05 +0000)]
Add new roundrect GM

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/14348022

git-svn-id: http://skia.googlecode.com/svn/trunk@8806 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agostart cleanup, in prep for new fontmgr impl
reed@google.com [Mon, 22 Apr 2013 18:00:06 +0000 (18:00 +0000)]
start cleanup, in prep for new fontmgr impl

Review URL: https://codereview.chromium.org/13956032

git-svn-id: http://skia.googlecode.com/svn/trunk@8805 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUnbreak -z. The LocalReporter shim layer was forcing the pathops options back to...
commit-bot@chromium.org [Mon, 22 Apr 2013 17:35:55 +0000 (17:35 +0000)]
Unbreak -z.  The LocalReporter shim layer was forcing the pathops options back to defaults.

BUG=
R=caryclark@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/13849013

git-svn-id: http://skia.googlecode.com/svn/trunk@8804 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake it clearer what's going on at the end of tests.
commit-bot@chromium.org [Mon, 22 Apr 2013 16:43:07 +0000 (16:43 +0000)]
Make it clearer what's going on at the end of tests.
BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/14267022

git-svn-id: http://skia.googlecode.com/svn/trunk@8803 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd thread-per-core setting to SkThreadPool.
commit-bot@chromium.org [Mon, 22 Apr 2013 15:23:14 +0000 (15:23 +0000)]
Add thread-per-core setting to SkThreadPool.

BUG=
R=scroggo@google.com, caryclark@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/13855009

git-svn-id: http://skia.googlecode.com/svn/trunk@8802 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline performance triggers for new .skp files
robertphillips@google.com [Mon, 22 Apr 2013 15:07:34 +0000 (15:07 +0000)]
Rebaseline performance triggers for new .skp files

git-svn-id: http://skia.googlecode.com/svn/trunk@8801 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert accidentally changed msvs settings in r8764.
bsalomon@google.com [Mon, 22 Apr 2013 14:56:50 +0000 (14:56 +0000)]
Revert accidentally changed msvs settings in r8764.

git-svn-id: http://skia.googlecode.com/svn/trunk@8800 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFeed Clang a pragma to ignore -Wc++11-extensions to let it build Skia on Mac.
commit-bot@chromium.org [Mon, 22 Apr 2013 14:39:06 +0000 (14:39 +0000)]
Feed Clang a pragma to ignore -Wc++11-extensions to let it build Skia on Mac.

Tested:
CXX=clang++ ./gyp_skia && ninja -C out/Debug && CXX=G++ ./gyp_skia && ninja -C out/Debug && echo "ok"

Got to ok.

BUG=
R=bungeman@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/14365009

git-svn-id: http://skia.googlecode.com/svn/trunk@8799 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops : add support for inverse fill
caryclark@google.com [Mon, 22 Apr 2013 14:37:05 +0000 (14:37 +0000)]
path ops : add support for inverse fill

add inverse fill, reverse diff, and gm tests
cleaned up some interfaces
Review URL: https://codereview.chromium.org/14371011

git-svn-id: http://skia.googlecode.com/svn/trunk@8798 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding optimization to avoid image copy in SkSurface copy on write when content is...
commit-bot@chromium.org [Mon, 22 Apr 2013 14:28:01 +0000 (14:28 +0000)]
Adding optimization to avoid image copy in SkSurface copy on write when content is discardable

This patch also adds code to SkDeferredCanvas to trigger the optimization.

TEST=DeferredSurfaceCopy bench, Surface unit test
R=reed@google.com

Author: junov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14063015

git-svn-id: http://skia.googlecode.com/svn/trunk@8797 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCatch failures to SkTypeface::Deserialize() and use the default in that case.
reed@google.com [Mon, 22 Apr 2013 13:47:40 +0000 (13:47 +0000)]
Catch failures to SkTypeface::Deserialize() and use the default in that case.

This fixes cros bots, who are (for whatever reason) failing to deserialize one
of their fonts during picture-deserialization.

git-svn-id: http://skia.googlecode.com/svn/trunk@8796 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping (SkipBuildbotRuns)
rmistry@google.com [Mon, 22 Apr 2013 12:45:30 +0000 (12:45 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@8795 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCopied over new versions of SKP files.
rmistry@google.com [Sun, 21 Apr 2013 23:41:00 +0000 (23:41 +0000)]
Copied over new versions of SKP files.

(AddDashboardAnnotation)

git-svn-id: http://skia.googlecode.com/svn/trunk@8794 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove printf
mike@reedtribe.org [Sun, 21 Apr 2013 01:44:04 +0000 (01:44 +0000)]
remove printf

git-svn-id: http://skia.googlecode.com/svn/trunk@8792 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopass 0 instead of NULL for size_t parameter
mike@reedtribe.org [Sun, 21 Apr 2013 01:43:09 +0000 (01:43 +0000)]
pass 0 instead of NULL for size_t parameter

git-svn-id: http://skia.googlecode.com/svn/trunk@8791 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agospecialize SkDataTable for arrays where all elements are the same size.
mike@reedtribe.org [Sun, 21 Apr 2013 01:37:46 +0000 (01:37 +0000)]
specialize SkDataTable for arrays where all elements are the same size.
optimize impl to not require another level of indirection (SkData) for storage.
add unittests for flattening.
optimize builder to not make a deepcopy of its chunkalloc heap.

git-svn-id: http://skia.googlecode.com/svn/trunk@8790 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWin7 Intel performance rebaseline
robertphillips@google.com [Sat, 20 Apr 2013 21:51:06 +0000 (21:51 +0000)]
Win7 Intel performance rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@8789 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPerformance rebaseline on ubuntu
robertphillips@google.com [Sat, 20 Apr 2013 21:44:52 +0000 (21:44 +0000)]
Performance rebaseline on ubuntu

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@8788 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoVertex Attrib configurations now handled as pointers vs. SkSTArrays
robertphillips@google.com [Sat, 20 Apr 2013 12:26:07 +0000 (12:26 +0000)]
Vertex Attrib configurations now handled as pointers vs. SkSTArrays

https://codereview.chromium.org/14328009/

git-svn-id: http://skia.googlecode.com/svn/trunk@8787 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GR_STATIC_RECT_VB
robertphillips@google.com [Sat, 20 Apr 2013 12:10:26 +0000 (12:10 +0000)]
Remove GR_STATIC_RECT_VB

https://codereview.chromium.org/14367030/

git-svn-id: http://skia.googlecode.com/svn/trunk@8786 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 20 Apr 2013 07:01:07 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8785 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocan't return false for a ptr (unless you're in gcc)
reed@google.com [Fri, 19 Apr 2013 20:52:50 +0000 (20:52 +0000)]
can't return false for a ptr (unless you're in gcc)

git-svn-id: http://skia.googlecode.com/svn/trunk@8782 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SkDataTable to return familyNames for fontmgr
reed@google.com [Fri, 19 Apr 2013 20:45:30 +0000 (20:45 +0000)]
use SkDataTable to return familyNames for fontmgr

git-svn-id: http://skia.googlecode.com/svn/trunk@8781 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SkDataTable::NewEmpty()
reed@google.com [Fri, 19 Apr 2013 20:22:39 +0000 (20:22 +0000)]
add SkDataTable::NewEmpty()

git-svn-id: http://skia.googlecode.com/svn/trunk@8780 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SkDataTable, to efficiently store an immutable array. Includes a builder
reed@google.com [Fri, 19 Apr 2013 20:16:01 +0000 (20:16 +0000)]
add SkDataTable, to efficiently store an immutable array. Includes a builder
helper class.
Review URL: https://codereview.chromium.org/14188049

git-svn-id: http://skia.googlecode.com/svn/trunk@8779 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix non-uniform scale and stroked ellipses
commit-bot@chromium.org [Fri, 19 Apr 2013 19:01:45 +0000 (19:01 +0000)]
Fix non-uniform scale and stroked ellipses

Strokes were not being scaled properly for ellipses -- the
view matrix was being reset before the scale factors were
being applied. Scaling the stroke has been moved up higher in
the process. Also applies some optimizations suggested by
robertphillips.

R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/14017012

git-svn-id: http://skia.googlecode.com/svn/trunk@8777 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFinal round of .0s
bsalomon@google.com [Fri, 19 Apr 2013 18:10:50 +0000 (18:10 +0000)]
Final round of .0s

git-svn-id: http://skia.googlecode.com/svn/trunk@8774 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore .0s
bsalomon@google.com [Fri, 19 Apr 2013 17:21:49 +0000 (17:21 +0000)]
More .0s

git-svn-id: http://skia.googlecode.com/svn/trunk@8771 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd ".0" to 1 constants in xfermodes GLSL code.
bsalomon@google.com [Fri, 19 Apr 2013 16:20:20 +0000 (16:20 +0000)]
Add ".0" to 1 constants in xfermodes GLSL code.

git-svn-id: http://skia.googlecode.com/svn/trunk@8770 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd all remaining separable xfer modes to GPU backend.
bsalomon@google.com [Fri, 19 Apr 2013 15:03:21 +0000 (15:03 +0000)]
Add all remaining separable xfer modes to GPU backend.
Review URL: https://codereview.chromium.org/14189024

git-svn-id: http://skia.googlecode.com/svn/trunk@8768 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreturn empty fontstyleset instead of null
reed@google.com [Fri, 19 Apr 2013 14:28:54 +0000 (14:28 +0000)]
return empty fontstyleset instead of null

git-svn-id: http://skia.googlecode.com/svn/trunk@8767 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for segmentation fault in xfermodes2 GM.
jvanverth@google.com [Fri, 19 Apr 2013 13:59:52 +0000 (13:59 +0000)]
Fix for segmentation fault in xfermodes2 GM.

Reviewed offline by bsalomon.

git-svn-id: http://skia.googlecode.com/svn/trunk@8766 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocheck-point for new fontmgr on linux
reed@google.com [Fri, 19 Apr 2013 13:55:00 +0000 (13:55 +0000)]
check-point for new fontmgr on linux

git-svn-id: http://skia.googlecode.com/svn/trunk@8765 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agosilence && || parens clang warning.
bsalomon@google.com [Fri, 19 Apr 2013 13:25:28 +0000 (13:25 +0000)]
silence && || parens clang warning.

git-svn-id: http://skia.googlecode.com/svn/trunk@8764 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd --threads to tests binary, to run non-GPU tests on multiple cores.
commit-bot@chromium.org [Fri, 19 Apr 2013 13:24:28 +0000 (13:24 +0000)]
Add --threads to tests binary, to run non-GPU tests on multiple cores.

On my quad-core laptop I can get about a 3x speedup:
  Debug,   --threads 0  40.99s
  Debug,   --threads 8  14.39s
  Release, --threads 0   8.24s
  Release, --threads 8   2.80s

I also removed some unused Test.{h,cpp} APIs and refactored a little to make
things thread-safer.

BUG=
R=borenet@google.com, djsollen@google.com, scroggo@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/13855007

git-svn-id: http://skia.googlecode.com/svn/trunk@8763 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPerform coverage blend with the dst in the shader when using a dst-reading xfermode.
bsalomon@google.com [Fri, 19 Apr 2013 13:14:45 +0000 (13:14 +0000)]
Perform coverage blend with the dst in the shader when using a dst-reading xfermode.
Review URL: https://codereview.chromium.org/14233006

git-svn-id: http://skia.googlecode.com/svn/trunk@8762 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoensure that negative zeros are still ignored when computing isIdentity()
reed@google.com [Fri, 19 Apr 2013 12:25:00 +0000 (12:25 +0000)]
ensure that negative zeros are still ignored when computing isIdentity()

crbug.com/162747

git-svn-id: http://skia.googlecode.com/svn/trunk@8761 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoenable path ops in unit tests
caryclark@google.com [Fri, 19 Apr 2013 11:45:56 +0000 (11:45 +0000)]
enable path ops in unit tests

git-svn-id: http://skia.googlecode.com/svn/trunk@8760 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 19 Apr 2013 07:01:00 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8759 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test the commit queue. (SkipBuildbotRuns)
commit-bot@chromium.org [Fri, 19 Apr 2013 02:37:53 +0000 (02:37 +0000)]
Whitespace change to test the commit queue. (SkipBuildbotRuns)

R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/14079004

git-svn-id: http://skia.googlecode.com/svn/trunk@8758 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change (SkipBuildbotRuns)
commit-bot@chromium.org [Fri, 19 Apr 2013 02:36:29 +0000 (02:36 +0000)]
Whitespace change (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@8757 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops : remove countdown overkill
caryclark@google.com [Thu, 18 Apr 2013 19:50:01 +0000 (19:50 +0000)]
path ops : remove countdown overkill
Review URL: https://codereview.chromium.org/13958005

git-svn-id: http://skia.googlecode.com/svn/trunk@8756 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExpand modulate, add, subtract, extract component glsl helpers.
bsalomon@google.com [Thu, 18 Apr 2013 19:36:09 +0000 (19:36 +0000)]
Expand modulate, add, subtract, extract component glsl helpers.
Review URL: https://codereview.chromium.org/13895006

git-svn-id: http://skia.googlecode.com/svn/trunk@8755 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodisabling path ops
caryclark@google.com [Thu, 18 Apr 2013 19:21:06 +0000 (19:21 +0000)]
disabling path ops

Default single-threaded variant may wait forever.
Review URL: https://codereview.chromium.org/13874014

git-svn-id: http://skia.googlecode.com/svn/trunk@8754 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove exclude of file which no longer exists.
bungeman@google.com [Thu, 18 Apr 2013 19:18:19 +0000 (19:18 +0000)]
Remove exclude of file which no longer exists.

git-svn-id: http://skia.googlecode.com/svn/trunk@8753 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnable path ops
caryclark@google.com [Thu, 18 Apr 2013 19:02:56 +0000 (19:02 +0000)]
Enable path ops

Path ops work (to my knowledge) on all platforms.
Turning it on will use the bots to expose failing
combinations I don't know about.
Review URL: https://codereview.chromium.org/14057014

git-svn-id: http://skia.googlecode.com/svn/trunk@8751 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoallow tests to optionally use multiple threads
caryclark@google.com [Thu, 18 Apr 2013 18:47:37 +0000 (18:47 +0000)]
allow tests to optionally use multiple threads

modify threaded path ops tests to check

Background: this CL came out of a conversation with Eric where I learned that 10s of machines host 100s of bots. Since the bot hosting tests may be shared with many other tasks, it seems unwise for path ops to launch multiple test threads.

The change here is to make launching multiple threads "opt-in" and by default, bots can run path ops in a single thread.
Review URL: https://codereview.chromium.org/14002007

git-svn-id: http://skia.googlecode.com/svn/trunk@8750 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SkAutoTDelete instead of SkTScopedPtr
reed@google.com [Thu, 18 Apr 2013 18:43:26 +0000 (18:43 +0000)]
use SkAutoTDelete instead of SkTScopedPtr
Review URL: https://codereview.chromium.org/13831011

git-svn-id: http://skia.googlecode.com/svn/trunk@8749 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix compile warning
caryclark@google.com [Thu, 18 Apr 2013 17:44:57 +0000 (17:44 +0000)]
Fix compile warning
Review URL: https://codereview.chromium.org/14227005

git-svn-id: http://skia.googlecode.com/svn/trunk@8748 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops work in progress
caryclark@google.com [Thu, 18 Apr 2013 15:58:21 +0000 (15:58 +0000)]
path ops work in progress

fix bugs in tests on 32 bit release

Most changes revolve around pinning computed t values
very close to zero and one.

git-svn-id: http://skia.googlecode.com/svn/trunk@8745 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoaugmenting fix in 8700 and 8701, be careful NOT to "sort" the result of mapRect
reed@google.com [Thu, 18 Apr 2013 15:37:14 +0000 (15:37 +0000)]
augmenting fix in 8700 and 8701, be careful NOT to "sort" the result of mapRect
when we only want to proceed if the matrix is nearly identity. Hence we manually
apply the matrix to the two "points" of the rect.

git-svn-id: http://skia.googlecode.com/svn/trunk@8743 2bbb7eff-a529-9590-31e7-b0007b416f81