Yang Tse [Tue, 5 Aug 2008 06:44:21 +0000 (06:44 +0000)]
#148 Removed.
Rebooting the problematic system, releasing allocated memory and swap,
has allowed buildconf and configure to complete sucessfully since then.
Yang Tse [Tue, 5 Aug 2008 06:20:18 +0000 (06:20 +0000)]
Validate that autom4te and autoconf versions match.
Validate that aclocal and automake versions match.
Improve removal of previous run generated files.
Remove verbose debug logging of aclocal on Solaris.
Daniel Stenberg [Mon, 4 Aug 2008 22:07:50 +0000 (22:07 +0000)]
- Yehoshua Hershberg found a problem that would make libcurl re-use a
connection with the multi interface even if a previous use of it caused a
CURLE_PEER_FAILED_VERIFICATION to get returned. I now make sure that failed
SSL connections properly close the connections.
Daniel Stenberg [Mon, 4 Aug 2008 22:00:22 +0000 (22:00 +0000)]
- Test cases 1051, 1052 and 1055 were added by Daniel Fandrich on July 30 and
proved how PUT and POST with a redirect could lead to a "hang" due to the
data stream not being rewound properly when it had to in order to get sent
properly (again) to the subsequent URL. This is now fixed and these test
cases are no longer disabled.
Daniel Stenberg [Mon, 4 Aug 2008 20:23:12 +0000 (20:23 +0000)]
- Fix by Tofu Linden:
The symptom:
* Users (usually, but not always) on 2-Wire routers and the Comcast service
and a wired connection to their router would find that the second and
subsequent DNS lookups from fresh processes using c-ares to resolve the same
address would cause the process to never see a reply (it keeps polling for
around 1m15s before giving up).
The repro:
* On such a machine (and yeah, it took us a lot of QA to find the systems
that reproduce such a specific problem!), do 'ahost www.secondlife.com',
then do it again. The first process's lookup will work, subsequent lookups
will time-out and fail.
The cause:
* init_id_key() was calling randomize_key() *before* it initialized
key->state, meaning that the randomness generated by randomize_key() is
immediately overwritten with deterministic values. (/dev/urandom was also
being read incorrectly in the c-ares version we were using, but this was
fixed in a later version.)
* This makes the stream of generated query-IDs from any new c-ares process
be an identical and predictable sequence of IDs.
* This makes the 2-Wire's default built-in DNS server detect these queries
as probable-duplicates and (erroneously) not respond at all.
Yang Tse [Mon, 4 Aug 2008 10:13:02 +0000 (10:13 +0000)]
Update #144
Third version of the patch fixing a failure to chose a proper data
type submitted to the mailing list 2008-08-04.
Yang Tse [Mon, 4 Aug 2008 06:48:11 +0000 (06:48 +0000)]
Autoconf 2.62 has changed the behaviour of the AC_AIX macro which we use.
Prior versions of autoconf defined _ALL_SOURCE if _AIX was defined. But,
autoconf 2.62 version of AC_AIX defines _ALL_SOURCE along with other four
preprocessor symbols no matter if the system is AIX or not. To keep the
traditional behaviour, as well as an uniform one, across autoconf versions
AC_AIX is replaced with our own internal macro.
Daniel Stenberg [Sun, 3 Aug 2008 22:20:58 +0000 (22:20 +0000)]
- Test case 1041 (added by Daniel Fandrich April 14th) proved a bug where PUT
with -C - sent garbage in the Content-Range: header. I fixed this problem by
making sure libcurl always sets the size of the _entire_ upload if an app
attemps to do resumed uploads since libcurl simply cannot know the size of
what is currently at the server end. Test 1041 is no longer disabled.
Daniel Stenberg [Sun, 3 Aug 2008 21:50:56 +0000 (21:50 +0000)]
refer to the new option by its real name
Yang Tse [Sun, 3 Aug 2008 16:46:20 +0000 (16:46 +0000)]
Update #148
Rebooting the Solaris system, releasing allocated memory and swap,
has allowed buildconf and configure to complete sucessfully. Further
tests on the system might allow determination of the problem origin.
Solaris AutoBuilds suceeded on August 2 and 3.
Dan Fandrich [Sun, 3 Aug 2008 05:13:05 +0000 (05:13 +0000)]
Improved title
Yang Tse [Sun, 3 Aug 2008 03:14:05 +0000 (03:14 +0000)]
Adjust DEC/Compaq C compiler settings.
Yang Tse [Sun, 3 Aug 2008 01:01:05 +0000 (01:01 +0000)]
Another AC_TRY_COMPILE conversion to AC_COMPILE_IFELSE
Yang Tse [Sat, 2 Aug 2008 01:44:13 +0000 (01:44 +0000)]
No longer test availability of the gdi32 library, nor use it for linking, even
when we have been doing this since revision 1.47 of configure.ac 4 years and
5 months ago when cross-compiling a Windows target. We actually don't use any
function from the Windows GDI (Graphics Device Interface) related with drawing
or graphics-related operations.
Dan Fandrich [Fri, 1 Aug 2008 22:12:34 +0000 (22:12 +0000)]
Added tests 1057 and 1058 to test FTP and HTTPS transfers with ranges
relative to end of file.
Yang Tse [Fri, 1 Aug 2008 19:29:05 +0000 (19:29 +0000)]
Another AC_TRY_LINK conversion to AC_LINK_IFELSE.
Proper definition of HAVE_function if function is found deeper.
Yang Tse [Fri, 1 Aug 2008 19:01:35 +0000 (19:01 +0000)]
Another AC_TRY_LINK conversion to AC_LINK_IFELSE.
Sorting of function names.
Proper definition of HAVE_function if function is found deeper.
Dan Fandrich [Fri, 1 Aug 2008 18:41:14 +0000 (18:41 +0000)]
Added support for --append on SFTP uploads. Unfortunately, OpenSSH doesn't
support this so it goes untested.
Yang Tse [Fri, 1 Aug 2008 07:46:21 +0000 (07:46 +0000)]
This line was for local testing, not intended to be committed.
Yang Tse [Fri, 1 Aug 2008 06:21:34 +0000 (06:21 +0000)]
Add a whitespace
Yang Tse [Fri, 1 Aug 2008 06:07:43 +0000 (06:07 +0000)]
Ensure that reserved keyword AC_DEFUN is only used for its purpose.
Yang Tse [Fri, 1 Aug 2008 05:24:19 +0000 (05:24 +0000)]
Removed definition of CURL_CHECK_WORKING_RESOLVER from acinclude.m4 it has
not been in use since revision 1.81 of configure.in 6 years, 9 months ago.
Yang Tse [Fri, 1 Aug 2008 03:17:38 +0000 (03:17 +0000)]
Sync up with reality
Yang Tse [Fri, 1 Aug 2008 03:10:54 +0000 (03:10 +0000)]
Sync up with reality
Yang Tse [Fri, 1 Aug 2008 02:48:00 +0000 (02:48 +0000)]
Rename reentrant.m4 to avoid filename clash.
Dan Fandrich [Fri, 1 Aug 2008 02:09:08 +0000 (02:09 +0000)]
User names embedded in proxy URLs without a password were parsed
incorrectly--the host name is treated as part of the user name and the
port number becomes the password. This can be observed in test 279
(was KNOWN_ISSUE #54).
Dan Fandrich [Fri, 1 Aug 2008 01:39:24 +0000 (01:39 +0000)]
Added more code under #ifndef CURL_DISABLE_HTTP to fix builds with
--disable-http
Dan Fandrich [Fri, 1 Aug 2008 00:55:43 +0000 (00:55 +0000)]
Refactored create_conn by breaking it up into many smaller functions
Dan Fandrich [Fri, 1 Aug 2008 00:49:29 +0000 (00:49 +0000)]
Made a parameter const
Dan Fandrich [Thu, 31 Jul 2008 22:46:29 +0000 (22:46 +0000)]
Fixed a problem with any FTP URL or any URLs containing an IPv6 address
being mangled when passed to proxies when CURLOPT_PORT is also set
(reported by Pramod Sharma).
Dan Fandrich [Thu, 31 Jul 2008 20:04:00 +0000 (20:04 +0000)]
Fixed parsing of an IPv6 proxy address to support a scope identifier,
as well as IPv4 addresses in IPv6 format. Also, better handle the case
of a malformatted IPv6 address (avoid empty and NULL strings).
Yang Tse [Thu, 31 Jul 2008 17:58:28 +0000 (17:58 +0000)]
Second version of the patch addressing building outside of CVS tree
submitted to the mailing list 2008-07-31. Awaiting Ok to commit.
Patrick Monnerat [Thu, 31 Jul 2008 13:20:23 +0000 (13:20 +0000)]
New CURLOPT_ADDRESS_SCOPE option in ILE/RPG binding
Dan Fandrich [Thu, 31 Jul 2008 05:00:02 +0000 (05:00 +0000)]
Fixed keyword
Dan Fandrich [Thu, 31 Jul 2008 02:51:44 +0000 (02:51 +0000)]
Added keywords
Dan Fandrich [Thu, 31 Jul 2008 02:38:51 +0000 (02:38 +0000)]
Added test of IPv6 scope handling
Dan Fandrich [Thu, 31 Jul 2008 02:18:01 +0000 (02:18 +0000)]
Fixed a couple of problems in the IPv6 scope code. First, a host name in
an URL in a Location: header didn't have the scope ID removed, so an
invalid host name was used. Second, when the scope ID was removed, it
also removed any port number that may have existed in the URL.
Yang Tse [Thu, 31 Jul 2008 01:41:20 +0000 (01:41 +0000)]
s/silly/underquoted definition/
Yang Tse [Thu, 31 Jul 2008 01:20:25 +0000 (01:20 +0000)]
#149 fully done and verified. Removed from here now.
Dan Fandrich [Thu, 31 Jul 2008 01:12:06 +0000 (01:12 +0000)]
Fixed a couple of buffer overflows in the MS-DOS port of the curl tool.
Factored out unslashquote. Added some 'const's in function parameters.
Dan Fandrich [Wed, 30 Jul 2008 23:49:20 +0000 (23:49 +0000)]
Added IPv6 section
Daniel Stenberg [Wed, 30 Jul 2008 22:09:30 +0000 (22:09 +0000)]
Committed just now and thus removed from here:
145 - Phil Blundell's CURLOPT_SCOPE patch/work
Daniel Stenberg [Wed, 30 Jul 2008 21:57:27 +0000 (21:57 +0000)]
another option added, bump counter
Daniel Stenberg [Wed, 30 Jul 2008 21:55:26 +0000 (21:55 +0000)]
- Phil Blundell added the CURLOPT_SCOPE option, as well as adjusted the URL
parser to allow numerical IPv6-addresses to be specified with the scope
given, as per RFC4007 - with a percent letter that itself needs to be URL
escaped. For example, for an address of fe80::1234%1 the HTTP URL is:
"http://[fe80::1234%251]/"
Daniel Stenberg [Wed, 30 Jul 2008 21:42:26 +0000 (21:42 +0000)]
Fixed:
147 - PHP's bug report #43158 (http://bugs.php.net/bug.php?id=43158) identifies
a true bug in libcurl built with OpenSSL.
Daniel Stenberg [Wed, 30 Jul 2008 21:24:59 +0000 (21:24 +0000)]
- PHP's bug report #43158 (bugs.php.net/bug.php?id=43158) identifies a
true bug in libcurl built with OpenSSL. It made curl_easy_getinfo() more or
less always return 0 for CURLINFO_SSL_VERIFYRESULT because the function that
would set it to something non-zero would return before the assign in almost
all error cases. The internal variable is now set to non-zero from the start
of the function only to get cleared later on if things work out fine.
Daniel Stenberg [Wed, 30 Jul 2008 21:24:19 +0000 (21:24 +0000)]
- Made the curl tool's -w option support the %{ssl_verify_result} variable
Dan Fandrich [Wed, 30 Jul 2008 21:04:44 +0000 (21:04 +0000)]
Added test cases 1052 through 1055 to test uploading data from files
during redirects. Test cases 1052 and 1055 show problems (maybe the same
root cause as 1051) and are disabled.
Dan Fandrich [Wed, 30 Jul 2008 20:11:51 +0000 (20:11 +0000)]
Factored out Curl_copy_header_value
Yang Tse [Wed, 30 Jul 2008 12:09:35 +0000 (12:09 +0000)]
Add file version serial number that might be used by 'aclocal' and others.
Keep the '#' character as the first one on the line.
Yang Tse [Wed, 30 Jul 2008 08:27:02 +0000 (08:27 +0000)]
Update copyright year.
Yang Tse [Wed, 30 Jul 2008 08:21:25 +0000 (08:21 +0000)]
Sync comment with reality.
Dan Fandrich [Wed, 30 Jul 2008 07:31:10 +0000 (07:31 +0000)]
Added the problems with test cases 1041 and 1051
Dan Fandrich [Wed, 30 Jul 2008 07:24:59 +0000 (07:24 +0000)]
Added test case 1051 to test Location: following with PUT, as reported
by Ben Sutcliffe. The test when run manually shows a problem in curl,
but the test harness web server doesn't run the test correctly so it's
disabled for now.
Yang Tse [Wed, 30 Jul 2008 06:20:43 +0000 (06:20 +0000)]
Undo using the sreadfrom() wrapper to replace recvfrom() in our code, for real ;-)
Yang Tse [Wed, 30 Jul 2008 05:15:51 +0000 (05:15 +0000)]
#149 done. Awaiting autobuild verification before removing.
Yang Tse [Wed, 30 Jul 2008 05:10:42 +0000 (05:10 +0000)]
Undo using the sreadfrom() wrapper to replace recvfrom() in our code.
Yang Tse [Wed, 30 Jul 2008 04:46:24 +0000 (04:46 +0000)]
#148 no longer blocks #144
Yang Tse [Wed, 30 Jul 2008 04:42:16 +0000 (04:42 +0000)]
Reinstate hiding aclocal 'underquoted definition' warnings.
Yang Tse [Wed, 30 Jul 2008 03:24:38 +0000 (03:24 +0000)]
updated #148
Yang Tse [Wed, 30 Jul 2008 03:10:03 +0000 (03:10 +0000)]
Reinstate the 'aclocal -I m4' in buildconf and 'ACLOCAL_AMFLAGS = -I m4' way of
including our local m4/reentrant.m4 file. This even takes care of including the
file in the distribution tarball.
Yang Tse [Wed, 30 Jul 2008 01:17:15 +0000 (01:17 +0000)]
Show autom4te and aclocal versions.
Set SED for Solaris to gsed if available.
Dan Fandrich [Wed, 30 Jul 2008 00:10:32 +0000 (00:10 +0000)]
Minor Symbian updates.
Dan Fandrich [Wed, 30 Jul 2008 00:09:02 +0000 (00:09 +0000)]
Fixed --use-ascii to properly convert text files on Symbian OS, MS-DOS
and OS/2.
Yang Tse [Tue, 29 Jul 2008 23:56:01 +0000 (23:56 +0000)]
Updtae #148 with link to start of thread
Yang Tse [Tue, 29 Jul 2008 23:51:01 +0000 (23:51 +0000)]
Updated #144
Added #148 and # 149
Daniel Stenberg [Tue, 29 Jul 2008 21:51:47 +0000 (21:51 +0000)]
56. When libcurl sends CURLOPT_POSTQUOTE commands when connected to a SFTP
server using the multi interface, the commands are not being sent correctly
and instead the connection is "cancelled" (the operation is considered done)
prematurely. There is a half-baked (busy-looping) patch provided in the bug
report but it cannot be accepted as-is. See
http://curl.haxx.se/bug/view.cgi?id=2006544
Daniel Stenberg [Tue, 29 Jul 2008 21:39:05 +0000 (21:39 +0000)]
Added:
146 - Yehoshua Hershberg's re-using of connections that failed with
CURLE_PEER_FAILED_VERIFICATION
147 - PHP's bug report #43158 (http://bugs.php.net/bug.php?id=43158) identifies
a true bug in libcurl built with OpenSSL.
Dan Fandrich [Tue, 29 Jul 2008 20:59:51 +0000 (20:59 +0000)]
Document that PKG_CONFIG_PATH is the preferred way to configure with
OpenSSL.
Yang Tse [Tue, 29 Jul 2008 19:31:34 +0000 (19:31 +0000)]
For testing purposes on SunOS systems; directly feed acinclude.m4 with
reentrant.m4 and remove reentrant.m4 before calling aclocal.
Yang Tse [Tue, 29 Jul 2008 19:01:34 +0000 (19:01 +0000)]
For debugging purposes, show all sed's available in PATH on SunOS systems.
Dan Fandrich [Tue, 29 Jul 2008 18:57:01 +0000 (18:57 +0000)]
Return an error code when extra files are found in filecheck:
Dan Fandrich [Tue, 29 Jul 2008 18:26:35 +0000 (18:26 +0000)]
Eliminate a unnecessary socket creation in Curl_getaddrinfo for an IPv4
address in an IPv6 capable libcurl.
Yang Tse [Tue, 29 Jul 2008 18:23:11 +0000 (18:23 +0000)]
Add quoting for the AC_DEFINE arguments.
Yang Tse [Tue, 29 Jul 2008 18:01:29 +0000 (18:01 +0000)]
Also remove the whitespace.
Yang Tse [Tue, 29 Jul 2008 17:45:33 +0000 (17:45 +0000)]
Also remove the extra quoting.
Yang Tse [Tue, 29 Jul 2008 16:29:34 +0000 (16:29 +0000)]
Replace some '@%:@' quadigraphs by its actual representation '#'.
This quadigraph used before a C preprocessor 'define' directive could
be fooling M4, when processing this file, and make it think that the
line contains a pure M4 'define' macro.
Yang Tse [Tue, 29 Jul 2008 02:26:21 +0000 (02:26 +0000)]
Tests done using 'aclocal -I m4' in buildconf and 'ACLOCAL_AMFLAGS = -I m4
in top Makefile.am triggered a problem that prevented aclocal from running
successfully on SunOS 5.10 with GNU m4 1.4.5 and GNU Autoconf 2.61
A tarball which reproduces mentioned problem is the one dated July-28-2008
http://cool.haxx.se/curl-daily/curl-7.19.0-
20080728.tar.gz
We actually don't need all the bells and whistles that the above mechanism
provides. We only need to include our m4/reentrant.m4 file in acinclude.m4
so here we go with this simpler mechanism.
Yang Tse [Tue, 29 Jul 2008 02:05:07 +0000 (02:05 +0000)]
ignore *.dist files
Dan Fandrich [Tue, 29 Jul 2008 01:05:28 +0000 (01:05 +0000)]
Added test case 1050 to test --ftp-port with an IPv6 address.
Made --interface tests less restrictive on host address.
Daniel Stenberg [Mon, 28 Jul 2008 21:53:25 +0000 (21:53 +0000)]
I removed: "139 - Christopher Palow's CURLM_EASY_HANDLE_EXISTS patch" simply
because at the current point in time I think the benefit of adding that new
return code is very slim and it is a lot of work to introduce new return codes
(for docs and maintenance etc)
I added "145 - Phil Blundell's CURLOPT_SCOPE patch/work" since I want it
sorted/committed.
Dan Fandrich [Mon, 28 Jul 2008 18:39:32 +0000 (18:39 +0000)]
Added test cases 1045 through 1049 as simple tests of --interface using the
localhost interface.
Dan Fandrich [Mon, 28 Jul 2008 18:35:34 +0000 (18:35 +0000)]
Fixed display of the interface bind address in the trace output when it's
an IPv6 address.
Yang Tse [Mon, 28 Jul 2008 16:17:51 +0000 (16:17 +0000)]
Ensure that buildconf runs from the subdirectory where configure.ac lives
Yang Tse [Mon, 28 Jul 2008 15:15:13 +0000 (15:15 +0000)]
Remove files generated on previous buildconf/configure run,
and for debugging purposes show ACLOCAL_FLAGS.
Yang Tse [Mon, 28 Jul 2008 15:13:31 +0000 (15:13 +0000)]
for debugging purposes show ACLOCAL_FLAGS
Yang Tse [Mon, 28 Jul 2008 12:36:51 +0000 (12:36 +0000)]
ignore another file that might be generated
Yang Tse [Sun, 27 Jul 2008 23:43:53 +0000 (23:43 +0000)]
These lines were unintentionally removed in previous commit
Yang Tse [Sun, 27 Jul 2008 22:25:07 +0000 (22:25 +0000)]
Partially undo change that prevented SED, GREP, EGREP and AR from being changed by libtool or autoconf.
Yang Tse [Sun, 27 Jul 2008 21:47:22 +0000 (21:47 +0000)]
Assert that SED and GREP are set
Yang Tse [Sun, 27 Jul 2008 20:29:04 +0000 (20:29 +0000)]
Require autoconf 2.57 or newer
Yang Tse [Sun, 27 Jul 2008 18:10:54 +0000 (18:10 +0000)]
When calling aclocal, user defined ACLOCAL_FLAGS will now precede ours.
Yang Tse [Sun, 27 Jul 2008 17:24:37 +0000 (17:24 +0000)]
For debugging purposes, run aclocal in verbose mode on SunOS systems.
Yang Tse [Sun, 27 Jul 2008 16:37:02 +0000 (16:37 +0000)]
move ACLOCAL_AMFLAGS after AUTOMAKE_OPTIONS
Yang Tse [Sun, 27 Jul 2008 03:16:37 +0000 (03:16 +0000)]
setup.h handles definition of _REENTRANT based on NEED_REENTRANT
definition which might be defined in config.h or config-*.h files
Yang Tse [Sun, 27 Jul 2008 02:41:13 +0000 (02:41 +0000)]
Remove explicit inclusion of our m4 files first. It was interesting as a test,
but it breaks aclocal execution on some systems, with the following error:
Can't locate object method "rel2abs" via package "File::Spec" at /usr/local/bin/aclocal line 256.
Dan Fandrich [Sun, 27 Jul 2008 02:34:27 +0000 (02:34 +0000)]
Added feature in runtests.pl to select tests based on key word.
Dan Fandrich [Sun, 27 Jul 2008 02:20:34 +0000 (02:20 +0000)]
Eliminate a unnecessary socket creation in Curl_getaddrinfo for an IPv4
address in an IPv6 capable libcurl.
Yang Tse [Sun, 27 Jul 2008 01:36:33 +0000 (01:36 +0000)]
Another step towards detecting if _REENTRANT is already defined or actually
needed, and being able to define it if appropriate for further configure tests
as well as for the generated config file.
Daniel Stenberg [Sat, 26 Jul 2008 21:15:47 +0000 (21:15 +0000)]
- David Bau filed bug report #2026240 "CURL_READFUNC_PAUSE leads to buffer
overrun" (http://curl.haxx.se/bug/view.cgi?id=2026240) identifying two
problems, and providing the fix for them:
- CURL_READFUNC_PAUSE did in fact not pause the _sending_ of data that it is
designed for but paused _receiving_ of data!
- libcurl didn't internally set the read counter to zero when this return
code was detected, which would potentially lead to junk getting sent to
the server.