review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

Brian Salomon [Mon, 11 Aug 2014 15:21:25 +0000 (11:21 -0400)]

Remove bleed test from ignored-tests.txt

BUG=skia:

Review URL: https://codereview.chromium.org/463503004

commit | commitdiff | tree

mtklein [Mon, 11 Aug 2014 15:08:43 +0000 (08:08 -0700)]

Plumbing for using a BBH in SkRecordDraw.

For now this only creates a degenerate bounding box hierarchy where all ops
just have maximal bounds. I will flesh out FillBounds in future CL(s).

Not quite sure why QuadTree and TileGrid aren't drawing right---haven't even
looked at the diffs yet---so I've disabled those test modes for now. RTree
seems fine, so that'll at least get us coverage for all this new plumbing.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/454123003

commit | commitdiff | tree

Brian Salomon [Mon, 11 Aug 2014 14:22:10 +0000 (10:22 -0400)]

Rebase convex_poly_clip test on Win8 msaa16

BUG=skia:

Review URL: https://codereview.chromium.org/458243002

commit | commitdiff | tree

bungeman [Mon, 11 Aug 2014 14:19:56 +0000 (07:19 -0700)]

Fix string assert and dead code which caused it.

Running tools with a '--' parameter caused SkString to assert here
incorrectly. SkString::remove should allow the entire contents of a
string to be removed.

The code in the flags parser which caused this call is dead and should
be removed.

R=mtklein@google.com, reed@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/453333002

commit | commitdiff | tree

reed [Mon, 11 Aug 2014 13:35:48 +0000 (06:35 -0700)]

Revert of Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/457253002/)

Reason for revert:
webkit has been updated, so re-landing

Original issue's description:
> Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/456203002/)
>
> Reason for revert:
> still need to update ProfilingCanvas in blink
>
> Original issue's description:
> > remove (now unneeded) legacy onDrawPicture variant
> >
> > TBR=fmalita@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/2e69d292e5a389db7d9264eb66172376692de8ca
>
> TBR=
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/47f9bdcc3d741a63935c52bfe85db44ab13f66f2

R=reed@chromium.org
TBR=reed@chromium.org
NOTREECHECKS=true
NOTRY=true

Author: reed@google.com

Review URL: https://codereview.chromium.org/460693002

commit | commitdiff | tree

robertphillips [Mon, 11 Aug 2014 13:03:42 +0000 (06:03 -0700)]

Remove Matrix/Clip State collapse code

Given recent & upcoming changes (e.g., removal of save flags & SkRecord picture backend) this will have to be reimplemented.

R=fmalita@google.com, fmalita@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/453133003

commit | commitdiff | tree

reed [Mon, 11 Aug 2014 02:04:01 +0000 (19:04 -0700)]

Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/456203002/)

Reason for revert:
still need to update ProfilingCanvas in blink

Original issue's description:
> remove (now unneeded) legacy onDrawPicture variant
>
> TBR=fmalita@google.com
>
> Committed: https://skia.googlesource.com/skia/+/2e69d292e5a389db7d9264eb66172376692de8ca

TBR=
NOTREECHECKS=true
NOTRY=true

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/457253002

commit | commitdiff | tree

reed [Sun, 10 Aug 2014 18:28:46 +0000 (11:28 -0700)]

remove (now unneeded) legacy onDrawPicture variant

TBR=fmalita@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/456203002

commit | commitdiff | tree

kevin.petit [Sat, 9 Aug 2014 18:22:54 +0000 (11:22 -0700)]

Fix S32A_D565_Opaque for RGBA on arm64

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:2813
R=halcanary@google.com, djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/458453002

commit | commitdiff | tree

reed [Sat, 9 Aug 2014 18:08:05 +0000 (11:08 -0700)]

add drawPicture variant that takes a matrix and paint

will need some staging strategy, since chrome and blink have overrides of onDrawPicture

R=robertphillips@google.com, fmalita@google.com, bsalomon@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/448793004

commit | commitdiff | tree

bensong [Sat, 9 Aug 2014 17:19:22 +0000 (10:19 -0700)]

manual bench rebase after 8d9153f, adjusted with e530eb370c084336b584a6dff5a9e6974d932dfa

TBR=bungeman@google.com

Bypassing trybots:
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/451293002

commit | commitdiff | tree

bensong [Fri, 8 Aug 2014 22:59:30 +0000 (15:59 -0700)]

manual bench rebase after 8d9153f

R=bungeman@google.com
TBR=bungeman@google.com

Bypassing trybots:
NOTRY=true
BUG=skia:2819

Author: bensong@google.com

Review URL: https://codereview.chromium.org/454223002

commit | commitdiff | tree

Mike Klein [Fri, 8 Aug 2014 21:28:53 +0000 (17:28 -0400)]

Restore bench_util.py

BUG=skia:2819

Review URL: https://codereview.chromium.org/450253003

commit | commitdiff | tree

reed [Fri, 8 Aug 2014 19:51:24 +0000 (12:51 -0700)]

add dummy onDrawPicture to allow migration for chrome overrides

after this lands in chrome, land these two CLs
https://codereview.chromium.org/454993002/
https://codereview.chromium.org/454143003

then land this skia CL
https://codereview.chromium.org/448793004/

then remove the onDrawPicture overrides from chrome

R=fmalita@google.com, robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/457753002

commit | commitdiff | tree

humper [Fri, 8 Aug 2014 19:11:33 +0000 (12:11 -0700)]

add an animated test to verify that high-quality identity scaling doesn't change the image

BUG=skia:
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/454913002

commit | commitdiff | tree

bungeman [Fri, 8 Aug 2014 19:06:51 +0000 (12:06 -0700)]

Blink layout tests all assume it can provide custom font configuration files on every platform. In moving Android to the font manager, we broke those.

They're ugly, but this patch reinstates them.

R=tomhudson@google.com, djsollen@google.com, reed@google.com
TBR=reed@google.com
BUG=chromium:401954

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/451093002

commit | commitdiff | tree

humper [Fri, 8 Aug 2014 19:06:13 +0000 (12:06 -0700)]

short circuit high quality scales that are actually the identity
transform

BUG=skia:
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/456843002

commit | commitdiff | tree

mtklein [Fri, 8 Aug 2014 18:49:39 +0000 (11:49 -0700)]

Make BBH::search() const.

I'd like to have SkRecordDraw() work with a const SkBBoxHierarchy*, but
can't quite today. The only interesting change here is no longer flushing
if needed in RTree; instead we assert we've been flushed already.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/452233002

commit | commitdiff | tree

humper [Fri, 8 Aug 2014 18:45:46 +0000 (11:45 -0700)]

add a simple ascii-art debug thing for AA clips

BUG=skia:
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/450423002

commit | commitdiff | tree

krajcevski [Fri, 8 Aug 2014 18:38:27 +0000 (11:38 -0700)]

Add R11 KTX GM

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/456873002

commit | commitdiff | tree

hendrikw [Fri, 8 Aug 2014 17:44:33 +0000 (10:44 -0700)]

Moved SkPictureContentInfo into its own file.  It now tracks the number of skia
operations (maybe, I'm not 100% sure I'm doing this right yet)  and the number
of text draws.  I also moved some of the gpu logic out of SkPictureRecord and
into SkPictureContentInfo,

http://code.google.com/p/chromium/issues/detail?id=396908
http://code.google.com/p/chromium/issues/detail?id=397198
http://code.google.com/p/chromium/issues/detail?id=399728

BUG=396908
R=nduca@chromium.org, mtklein@chromium.org, robertphillips@google.com, mtklein@google.com

Author: hendrikw@chromium.org

Review URL: https://codereview.chromium.org/435093003

commit | commitdiff | tree

mtklein [Fri, 8 Aug 2014 17:05:19 +0000 (10:05 -0700)]

SkRecord: Strip out cull-skipping and y-only drawPosTextH skipping.

These optimizations are outclassed by a general bounding-box hierarchy,
and are just going to make plugging that into SkRecordDraw more complicated.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/452983002

commit | commitdiff | tree

joshualitt [Fri, 8 Aug 2014 16:41:42 +0000 (09:41 -0700)]

Pretty print of shaders

BUG=skia:
R=bsalomon@chromium.org, senorblanco@chromium.org, bsalomon@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/437593004

commit | commitdiff | tree

krajcevski [Fri, 8 Aug 2014 15:41:21 +0000 (08:41 -0700)]

Implement BlitRect for SkTCompressedAlphaBlitter

R=robertphillips@google.com, reed@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/451823002

commit | commitdiff | tree

Robert Phillips [Fri, 8 Aug 2014 15:40:08 +0000 (11:40 -0400)]

Add mandill_128.r11.ktx to resources

Review URL: https://codereview.chromium.org/457693002

commit | commitdiff | tree

krajcevski [Fri, 8 Aug 2014 15:12:29 +0000 (08:12 -0700)]

Fix bug in blitAntiH

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/449223002

commit | commitdiff | tree

bsalomon [Fri, 8 Aug 2014 15:08:50 +0000 (08:08 -0700)]

Add an opaqueness hint to GrDrawState.

Check it when deciding whether to combine draw states.

R=egdaniel@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/446953002

commit | commitdiff | tree

bsalomon [Fri, 8 Aug 2014 14:43:29 +0000 (07:43 -0700)]

Make the rotated rects bench allow more alpha/color variations and an arbitrary xfermode::mode.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/448253002

commit | commitdiff | tree

stephana [Fri, 8 Aug 2014 14:21:00 +0000 (07:21 -0700)]

Rebaseline-server: sorting of columns in asc/desc order in frontend.

NOTRY=true

BUG=skia:1907
R=epoger@google.com

Author: stephana@google.com

Review URL: https://codereview.chromium.org/449843002

commit | commitdiff | tree

senorblanco [Fri, 8 Aug 2014 14:14:35 +0000 (07:14 -0700)]

Remove external SkImageFilter cache, and rename UniqueIDCache -> Cache.

There Can Only Be One.... Cache for SkImageFilter.

R=bsalomon@google.com

BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/452923002

commit | commitdiff | tree

rmistry [Fri, 8 Aug 2014 12:24:06 +0000 (05:24 -0700)]

Whitespace change to test the CQ

BUG=skia:

(SkipBuildbotRuns)

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/454873002

commit | commitdiff | tree

mtklein [Thu, 7 Aug 2014 22:20:02 +0000 (15:20 -0700)]

Fix iOS build by centralizing --writePath.

CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/452633002

commit | commitdiff | tree

epoger [Thu, 7 Aug 2014 21:55:34 +0000 (14:55 -0700)]

don't list out all sourceSkpFile names in the rebaseline_server UI

(the list is long and crowds out the results themselves; better to use
a text filter to select the sourceSkpFiles of interest)

R=stephana@google.com
TBR=stephana
NOTREECHECKS=true
NOTRY=true

Author: epoger@google.com

Review URL: https://codereview.chromium.org/451853002

commit | commitdiff | tree

epoger [Thu, 7 Aug 2014 21:39:05 +0000 (14:39 -0700)]

make rebaseline_server properly handle unescaped URLs

R=rmistry@google.com
TBR=rmistry
NOTREECHECKS=true
NOTRY=true

Author: epoger@google.com

Review URL: https://codereview.chromium.org/445753005

commit | commitdiff | tree

bsalomon [Thu, 7 Aug 2014 21:28:50 +0000 (14:28 -0700)]

Add option to dump images from nanobench.

Add option to set the repeat count to any number, replacs the --runOnce flag.

R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/450743002

commit | commitdiff | tree

mtklein [Thu, 7 Aug 2014 21:27:03 +0000 (14:27 -0700)]

DM: conserve memory when using --skps

- limit to maximum 1000x1000 viewport like in bench_pictures and nanobench
- use lazy bitmap decoding when reading the pictures from disk

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/448263002

commit | commitdiff | tree

joshualitt [Thu, 7 Aug 2014 20:48:49 +0000 (13:48 -0700)]

Cleanup of context initialization

Cleanup context initialization on linux

BUG=skia:
R=bsalomon@chromium.org, bsalomon@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/422323003

commit | commitdiff | tree

bungeman [Thu, 7 Aug 2014 20:27:17 +0000 (13:27 -0700)]

Revert of Process Statistics header, add max RSS to render_pdfs (https://codereview.chromium.org/448993003/)

Reason for revert:
Reverting due to breaking iOS bots.

Original issue's description:
> Process Statistics header, add max RSS to render_pdfs
>
> Committed: https://skia.googlesource.com/skia/+/6274baae7fe82ce6481da367687aa6168356e1e1

R=mtklein@google.com, halcanary@google.com
TBR=halcanary@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/448243003

commit | commitdiff | tree

halcanary [Thu, 7 Aug 2014 20:13:54 +0000 (13:13 -0700)]

Process Statistics header, add max RSS to render_pdfs

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/448993003

commit | commitdiff | tree

borenet [Thu, 7 Aug 2014 20:02:42 +0000 (13:02 -0700)]

Empty the Recipes bot's GM expectations

BUG=skia:761
NOTRY=true
R=epoger@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/455433002

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 19:58:38 +0000 (12:58 -0700)]

Add astcbitmap to gm slides.
Add additional ASTC formats.
Add astc image decoder files.

R=reed@google.com, robertphillips@google.com, halcanary@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444093002

commit | commitdiff | tree

mtklein [Thu, 7 Aug 2014 19:46:29 +0000 (12:46 -0700)]

Default --skps to ./skps

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/452553002

commit | commitdiff | tree

reed [Thu, 7 Aug 2014 19:19:50 +0000 (12:19 -0700)]

change drawPicture in SkRecord to just ref the picture

also fix some int/unsigned/size_t warnings

BUG=skia:
R=mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/449933002

commit | commitdiff | tree

epoger [Thu, 7 Aug 2014 19:13:12 +0000 (12:13 -0700)]

rebaseline_server: allow live queries to examine JSONKEY_EXPECTEDRESULTS or JSONKEY_ACTUALRESULTS

See https://goto.google.com/CorrectnessTestingBigIssues for full context

BUG=skia:1942
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/453433004

commit | commitdiff | tree

reed [Thu, 7 Aug 2014 18:48:10 +0000 (11:48 -0700)]

add isRect() check to AAClip, to detect if a soft-clip is really just an irect

taken from (https://codereview.chromium.org/445233006/)

fix: don't assume that the first yoffset is 0, since we may have performed a translate and not
re-alloced our data.

This reverts commit 0aeea6d344f12e35e29a79f4bbc48af88f913204.

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/443353004

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 18:33:59 +0000 (11:33 -0700)]

Revert of - Add astcbitmap to gm slides (https://codereview.chromium.org/444093002/)

Reason for revert:
Breaking DM

Original issue's description:
> - Add astcbitmap to gm slides
> - Add additional ASTC formats
> - Add astc image decoder files
>
> Committed: https://skia.googlesource.com/skia/+/2fc05823fed4b9649338f3029cd1ba05ef49a02f

R=reed@google.com, robertphillips@google.com, halcanary@google.com
TBR=halcanary@google.com, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/447343002

commit | commitdiff | tree

djsollen [Thu, 7 Aug 2014 18:30:30 +0000 (11:30 -0700)]

Disable suspect NEON function for 64-bit Android

R=halcanary@google.com, mtklein@google.com, kevin.petit@arm.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/451633006

commit | commitdiff | tree

borenet [Thu, 7 Aug 2014 18:28:20 +0000 (11:28 -0700)]

Duplicate NoGPU expectations for new recipes bot

BUG=skia:761
R=epoger@google.com
TBR=epoger
NOTRY=true

Author: borenet@google.com

Review URL: https://codereview.chromium.org/447323003

commit | commitdiff | tree

reed [Thu, 7 Aug 2014 18:19:11 +0000 (11:19 -0700)]

Revert of add isRect() check to AAClip, to detect if a soft-clip is really just an irect (https://codereview.chromium.org/445233006/)

Reason for revert:
new code asserts on some pictures

Original issue's description:
> add isRect() check to AAClip, to detect if a soft-clip is really just an irect
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/592cb8d552556b1e922887d506d00b64bc5d0547

R=bsalomon@google.com, humper@google.com
TBR=bsalomon@google.com, humper@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/452533002

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 18:18:09 +0000 (11:18 -0700)]

- Add astcbitmap to gm slides
- Add additional ASTC formats
- Add astc image decoder files

R=reed@google.com, robertphillips@google.com, halcanary@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444093002

commit | commitdiff | tree

halcanary [Thu, 7 Aug 2014 18:13:45 +0000 (11:13 -0700)]

Assert allocation so we can catch it sooner.

R=bungeman@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/445363007

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 18:10:22 +0000 (11:10 -0700)]

Pass a struct of functions instead of a function to the compressed blitter

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/443303006

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 17:58:43 +0000 (10:58 -0700)]

Add support for compressed alpha ktx files

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/447283002

commit | commitdiff | tree

tomhudson [Thu, 7 Aug 2014 17:20:51 +0000 (10:20 -0700)]

Don't fail unit test if resources not found on device.

Not 100% sure about the right thing to do here; looks like some other
tests warn but don't officially fail.

R=djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/451703004

commit | commitdiff | tree

reed [Thu, 7 Aug 2014 16:20:12 +0000 (09:20 -0700)]

add isRect() check to AAClip, to detect if a soft-clip is really just an irect

BUG=skia:
R=bsalomon@google.com, humper@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/445233006

commit | commitdiff | tree

fmalita [Thu, 7 Aug 2014 15:39:24 +0000 (08:39 -0700)]

Clamp SkPictureShader's tile size.

Blink used to clamp the max size for its pattern bitmaps (several SVG
pattern tests rely on/verify this behavior).

This CL clamps the maximum tile area to a reasonable value (16M pixels),
and scales beyond that.

R=bsalomon@google.com, reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/446243002

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 15:15:14 +0000 (08:15 -0700)]

Pass compressed blitters to our mask drawing algorithm

R=robertphillips@google.com, reed@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/446103002

commit | commitdiff | tree

dandov [Thu, 7 Aug 2014 14:49:53 +0000 (07:49 -0700)]

Stopped skipping tests in dm of SkPatch by implementing the
corresponding drawPath calls on classes that derive from SkCanvas.

BUG=skia:
R=egdaniel@google.com, bsalomon@google.com, mtklein@google.com, robertphillips@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/429343004

commit | commitdiff | tree

Robert Phillips [Thu, 7 Aug 2014 14:34:03 +0000 (10:34 -0400)]

Remove mandrill_128.r11.ktx from resources directory

Review URL: https://codereview.chromium.org/449503003

commit | commitdiff | tree

halcanary [Thu, 7 Aug 2014 14:24:47 +0000 (07:24 -0700)]

render_pdfs implements --match

BUG=skia:2743
NOTRY=true
R=djsollen@google.com, mtklein@google.com, borenet@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/441423002

commit | commitdiff | tree

Robert Phillips [Thu, 7 Aug 2014 14:06:24 +0000 (10:06 -0400)]

Added mandrill_128.r11.ktx to resources

Review URL: https://codereview.chromium.org/443303005

commit | commitdiff | tree

Derek Sollenberger [Wed, 6 Aug 2014 20:34:40 +0000 (16:34 -0400)]

Revert "Remove SkPaintOptionsAndroid"

This reverts commit 27fb94999b8eec448423884e1d071e563c4c95d9.

Review URL: https://codereview.chromium.org/450513002

commit | commitdiff | tree

Derek Sollenberger [Wed, 6 Aug 2014 20:31:41 +0000 (16:31 -0400)]

Fix Android framework builds

R=mtklein@google.com

Review URL: https://codereview.chromium.org/450503002

commit | commitdiff | tree

Derek Sollenberger [Wed, 6 Aug 2014 20:30:51 +0000 (16:30 -0400)]

Remove SkPaintOptionsAndroid

Review URL: https://codereview.chromium.org/447873003

commit | commitdiff | tree

bungeman [Wed, 6 Aug 2014 20:20:59 +0000 (13:20 -0700)]

Fix reference counting on SkStream in SkFontMgr_android.

R=tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/447003002

commit | commitdiff | tree

fmalita [Wed, 6 Aug 2014 20:07:15 +0000 (13:07 -0700)]

Explicit tile bounds for SkPictureShader

The integer picture size is not granular enough to allow precise tiling
in arbitrary coordinate systems. This CL adds an optional tile bounds
float rect param to control the tile size and location.

(this also allows tile spacing emulation for picture
shaders).

R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/437393003

commit | commitdiff | tree

krajcevski [Wed, 6 Aug 2014 19:47:59 +0000 (12:47 -0700)]

Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444433002

commit | commitdiff | tree

reed [Wed, 6 Aug 2014 19:43:09 +0000 (12:43 -0700)]

fix concat order for local matrices

BUG=skia:
R=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/446013004

commit | commitdiff | tree

humper [Wed, 6 Aug 2014 19:39:59 +0000 (12:39 -0700)]

make the action buttons for rebaseline server stick to the top of the window as you scroll

NOTRY=true

BUG=skia:1912
R=stephana@google.com, epoger@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/446933002

commit | commitdiff | tree

krajcevski [Wed, 6 Aug 2014 19:35:27 +0000 (12:35 -0700)]

Revert of Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes. (https://codereview.chromium.org/444433002/)

Reason for revert:
Breaking chrome.

Original issue's description:
> Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.
>
> Committed: https://skia.googlesource.com/skia/+/1840dcd2f1368279df907988a9b584ffd500de4c

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444103002

commit | commitdiff | tree

krajcevski [Wed, 6 Aug 2014 19:02:49 +0000 (12:02 -0700)]

Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444433002

commit | commitdiff | tree

mtklein [Wed, 6 Aug 2014 18:57:00 +0000 (11:57 -0700)]

SkPicture: try to no-op away clone().

Will actually enable this by #defining SK_PICTURE_CLONE_NOOP in Chrome's SkUserConfig.h as a separate CL after this rolls in.

BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/447753003

commit | commitdiff | tree

robertphillips [Wed, 6 Aug 2014 18:26:53 +0000 (11:26 -0700)]

Second pass at rebaselining flaky N4 performance triggers

R=bungeman@google.com
TBR=bungeman@google.com
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/444063002

commit | commitdiff | tree

bungeman [Wed, 6 Aug 2014 18:12:20 +0000 (11:12 -0700)]

Implement SkFontMgr_Android::onMatchFamilyStyleCharacter.

This will allow us to replace SkGetFallbackFamilyNameForChar
and also eventually fix issues with it's reliance on names.

R=djsollen@google.com, tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/427293003

commit | commitdiff | tree

krajcevski [Wed, 6 Aug 2014 18:12:14 +0000 (11:12 -0700)]

Allow custom blitters to be passed to SkDraw::drawPath

R=reed@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444003004

commit | commitdiff | tree

halcanary [Wed, 6 Aug 2014 18:07:11 +0000 (11:07 -0700)]

Roll android/third_party/jpeg DEPS

BUG=skia:2791
R=djsollen@google.com
TBR=djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/449493004

commit | commitdiff | tree

egdaniel [Wed, 6 Aug 2014 18:07:02 +0000 (11:07 -0700)]

Create struct in GrDrawState to hold key DrawState data.

Eventually this struct will be used to easily set values for a reduced, optimized drawstate

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/448453002

commit | commitdiff | tree

djsollen [Wed, 6 Aug 2014 18:01:58 +0000 (11:01 -0700)]

Remove references to __system_property_get from Skia

BUG=392201
R=tomhudson@chromium.org, bungeman@google.com, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/433163002

commit | commitdiff | tree

bsalomon [Wed, 6 Aug 2014 18:01:44 +0000 (11:01 -0700)]

Fix drawVertices() on GPU when texs=colors=shaders=indices=null

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/449433003

commit | commitdiff | tree

epoger [Wed, 6 Aug 2014 17:56:50 +0000 (10:56 -0700)]

rebaseline_server: add "prefetch" directive that just warms the cache without awaiting results

This will allow the buildbots to warn the production rebaseline_server: "I just
generated some new results; here's a comparison that a human might ask for
soon. Download whatever images and generate whatever diffs you would need to
provide those results."

BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/443013002

commit | commitdiff | tree

bsalomon [Wed, 6 Aug 2014 17:52:33 +0000 (10:52 -0700)]

Add angle config to nanobench and make angle a default config for dm and nanobench.

NOTREECHECKS=true
R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/441333003

commit | commitdiff | tree

mtklein [Wed, 6 Aug 2014 17:08:42 +0000 (10:08 -0700)]

On the bots, there's no need to link GMs into SampleApp.

We build SampleApp on the bots to make sure it's not broken, but we don't run it. So, there's no need to link in all the GMs as samples.

This reduces the number of copies of our GMs from 4 to 3 (gm, dm, and nanobench remain).

NOTREECHECKS=true

BUG=skia:2142
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/447803002

commit | commitdiff | tree

reed [Wed, 6 Aug 2014 16:54:19 +0000 (09:54 -0700)]

parameterize tesselation params

TBR=
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/446913002

commit | commitdiff | tree

mtklein [Wed, 6 Aug 2014 15:39:36 +0000 (08:39 -0700)]

Bye bye bench.

NOTREECHECKS=true

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/442343004

commit | commitdiff | tree

epoger [Wed, 6 Aug 2014 15:37:53 +0000 (08:37 -0700)]

rebaseline_server live queries: allow comparison against summary files within the Skia repo

This is a step towards providing SKP comparisons against expectations, not just
other actual results... we still need to allow the user to select
JSONKEY_EXPECTEDRESULTS vs JSONKEY_ACTUALRESULTS within the summary
files found.

BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/442203002

commit | commitdiff | tree

bungeman [Wed, 6 Aug 2014 15:15:50 +0000 (11:15 -0400)]

Revert "Adds a GrGLPathRendering class that wraps the NV_path_rendering"

This reverts commit 5672da0fa54f31c9727568e9dd5fe82c6e1585bc.

This appears to be blocking the Skia roll by causing failures in the blink layout tests on the canvas-lost-gpu-context.html test.

The bisect for this can be seen at:

https://codereview.chromium.org/449473002/

Original issue's description:
> Adds a GrGLPathRendering class that wraps the NV_path_rendering
> extension and manages its various API versions. It also provides
> backup implementations when certain NVpr methods from later API
> versions are not present on the current system.
>
> Committed: https://skia.googlesource.com/skia/+/5672da0fa54f31c9727568e9dd5fe82c6e1585bc

commit | commitdiff | tree

bungeman [Wed, 6 Aug 2014 15:14:31 +0000 (11:14 -0400)]

Revert "Calculate rough approximations for nvpr path sizes"

This reverts commit 61bff7097251755bf9fa9a4ec60cc057c766b4a4.

This is built on 5672da0fa54f31c9727568e9dd5fe82c6e1585bc
which is causing blink test failures on canvas-lost-gpu-context.html.

commit | commitdiff | tree

Robert Phillips [Wed, 6 Aug 2014 14:50:53 +0000 (10:50 -0400)]

Add ASTC resource files

Review URL: https://codereview.chromium.org/442363003

commit | commitdiff | tree

mtklein [Wed, 6 Aug 2014 14:46:30 +0000 (07:46 -0700)]

DM: expand peak RAM usage to Mac and Android too.

BUG=skia:

NOTREECHECKS=true
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/445963002

commit | commitdiff | tree

reed [Wed, 6 Aug 2014 14:00:27 +0000 (07:00 -0700)]

fix hittest in Patch sample

TBR=
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/441373002

commit | commitdiff | tree

djsollen [Wed, 6 Aug 2014 13:58:06 +0000 (06:58 -0700)]

Remove ALL font fallback logic from Skia.

R=reed@google.com, bungeman@google.com, caryclark@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/434623002

commit | commitdiff | tree

mtklein [Wed, 6 Aug 2014 13:55:12 +0000 (06:55 -0700)]

SkThreadPool and co. are not public.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/444583006

commit | commitdiff | tree

borenet [Wed, 6 Aug 2014 13:04:00 +0000 (06:04 -0700)]

Remove Mac 10.8 x86 Perf expectations

This is one of the problems with the way the RecreateSKPs bot determines which trybots to run: Rather than use a hard-coded list, it figures out which bots have perf expectations and then runs those bots to generate new expectations. This is problematic when we remove a bot because we have to remove its expectations as well. This is really not that different from maintaining a hard-coded list...

NOTRY=true
BUG=skia:
R=bensong@google.com, rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/443093002

commit | commitdiff | tree

robertphillips [Wed, 6 Aug 2014 12:16:29 +0000 (05:16 -0700)]

Rebaseline flaky N4 & N7 performance triggers

R=bungeman@google.com
TBR=bungeman@google.com
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/440423002

commit | commitdiff | tree

senorblanco [Tue, 5 Aug 2014 21:27:27 +0000 (14:27 -0700)]

Greenify bench bot Perf-Android-Nexus10-MaliT604-Arm7-Release at build 2563

R=bsalomon@google.com
TBR=bsalomon@google.com

Bypassing trybots:
NOTRY=true

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/442083003

commit | commitdiff | tree

senorblanco [Tue, 5 Aug 2014 21:26:28 +0000 (14:26 -0700)]

Greenify bench bot Perf-Android-GalaxyNexus-SGX540-Arm7-Release at build 1811

R=bsalomon@google.com
TBR=bsalomon@google.com

Bypassing trybots:
NOTRY=true

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/443743002

commit | commitdiff | tree

krajcevski [Tue, 5 Aug 2014 21:13:36 +0000 (14:13 -0700)]

Add support for all compressed formats in KTX file format

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/440783004

commit | commitdiff | tree

tomhudson [Tue, 5 Aug 2014 20:35:00 +0000 (13:35 -0700)]

Parses sample code provided by Android project. Attempts to keep FontFamily data structures produced consistent with expectations of previous versions of Skia.

R=bungeman@google.com, djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/446473003

commit | commitdiff | tree

ch.dumez [Tue, 5 Aug 2014 19:20:19 +0000 (12:20 -0700)]

Expose SkColorTable class

Expose SkColorTable class as it is used in SkBitmap::allocPixels(SkColorTable*)
API, which is already exposed.

R=reed@google.com, ben@chromium.org

Author: ch.dumez@samsung.com

Review URL: https://codereview.chromium.org/418173011

commit | commitdiff | tree

senorblanco [Tue, 5 Aug 2014 19:05:03 +0000 (12:05 -0700)]

Greenify bench bot Perf-Ubuntu12-ShuttleA-GTX660-x86-Release at build 1551

R=bensong@google.com, bensong@chromium.org

Bypassing trybots:
NOTRY=true
BUG=2794

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/442903002

Domain: Dotnet / API;